FWD » Core Development » Base Language

05/19/2025

10:17 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Eduard, please update [[p2j:Bootstrap_Configuration#Configuration-Reference]] with for the @catch-stop@ configuration. Constantin Asofiei

10:14 AM Bug #10004: NativeInvoker fails if an argument is of type integerConstant

Artur Școlnic wrote:
> I committed a new solution to 10004a/15917. Constantin, please review.
Why not do this in @C... Constantin Asofiei

10:11 AM Bug #10004 (Review): NativeInvoker fails if an argument is of type integerConstant

I committed a new solution to 10004a/15917. Constantin, please review. Artur Școlnic

09:56 AM Bug #10004 (WIP): NativeInvoker fails if an argument is of type integerConstant

Artur Școlnic

09:45 AM Bug #10004: NativeInvoker fails if an argument is of type integerConstant

Artur, that is not what I had in mind. This class uses lots of @.equals(Class<BDT>)@, and the solution needs to be a... Constantin Asofiei

09:22 AM Bug #10004 (Review): NativeInvoker fails if an argument is of type integerConstant

Artur Școlnic

09:22 AM Bug #10004 (WIP): NativeInvoker fails if an argument is of type integerConstant

I added the missing type checks, the changes are in 10004a.
I did not try to normalize the type because we are deali... Artur Școlnic

07:55 AM Bug #10004: NativeInvoker fails if an argument is of type integerConstant

The @library_calls/@ tests in [[p2j:Testcases]] should be executed. These are not yet reworked as ABLUnit tests. Se... Greg Shah

07:51 AM Bug #10004: NativeInvoker fails if an argument is of type integerConstant

Alexandru Lungu wrote:
> I added it as a check next to @integer.class@ (i.e. @integer.integerConstant.class@) and it... Artur Școlnic

07:42 AM Bug #10004: NativeInvoker fails if an argument is of type integerConstant

@NativeInvoker@ has lots of cases like @cls.equals(decimal.class)@ - if not solved by #9060, the entire class needs t... Constantin Asofiei

07:38 AM Bug #10004: NativeInvoker fails if an argument is of type integerConstant

There is an issue when @NativeInvoker.checkModeAndType@ is called with an argument that is of type @integerConstant@.... Alexandru Lungu

07:35 AM Bug #10004 (WIP): NativeInvoker fails if an argument is of type integerConstant

Alexandru Lungu

08:39 AM Feature #9447: XML support feature improvements and testing

Use 9447a. Constantin Asofiei

08:38 AM Feature #9447: XML support feature improvements and testing

In order to work on this task, I need to create a new branch 9447b, or I can work on the existing branch, 9447a? Teodor Gorghe

04:49 AM Feature #9447: XML support feature improvements and testing

... Stefan Vieru

03:41 AM Feature #9447: XML support feature improvements and testing

Stefan Vieru wrote:
> They are the same format as the others in @base_language/xml/sax/support@, so I suppose yes.
... Constantin Asofiei

03:38 AM Feature #9447: XML support feature improvements and testing

They are the same format as the others in @base_language/xml/sax/support@, so I suppose yes. Stefan Vieru

03:37 AM Feature #9447: XML support feature improvements and testing

Stefan Vieru wrote:
> I still have the tests that I created locally, they're not on testcases, should I commit them?... Constantin Asofiei

03:36 AM Feature #9447: XML support feature improvements and testing

I think everything that is necessary is here. I still have the tests that I created locally, they're not on testcases... Stefan Vieru

03:32 AM Feature #9447: XML support feature improvements and testing

Stefan, if you have any other notes to document, please do so.
Otherwise, Teodor, please work on this. Constantin Asofiei

07:43 AM Feature #9437: enhancements for Progress.Lang.Class

Eduard Soltan wrote:
> Problem is that in FWD the access mode of the converted field will always be *private*. But w... Constantin Asofiei

06:49 AM Feature #9437: enhancements for Progress.Lang.Class

... Eduard Soltan

04:36 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

I found a conflicting behavior between the NEW statement and DYNAMIC-NEW statement in progress.
* While solving the... Paul Bodale

05/16/2025

12:27 PM Bug #9997: Apache HttpClient limitations when used via LegacySocketLibrary

Constantin, I just linked https://developer.mozilla.org/en-US/docs/Glossary/Forbidden_request_header to this issue be... Sergey Ivanovskiy

11:02 AM Bug #9997: Apache HttpClient limitations when used via LegacySocketLibrary

In FWD, the implementation of @OpenEdge.Net.HTTP.Lib.ABLSockets.ABLSocketLibrary@ uses Apache HttpClient library.
... Constantin Asofiei

10:56 AM Bug #9997 (New): Apache HttpClient limitations when used via LegacySocketLibrary

Constantin Asofiei

09:56 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

There this thing that needs to be addressed.
I wrote some more tests and like Constantin pointed out, in progress... Paul Bodale

05:11 AM Feature #6490: DYNAMIC-INVOKE which returns an extent

Rebased branch 6490a with trunk rev. 15908. Paul Bodale

02:21 AM Bug #9532: codepage support in ASC(), CHR(), OUTPUT TO ... CONVERT and FIX-CODEPAGE()

Constantin Asofiei wrote:
> Hi Delia, what is the state of #4766? Can you do some preliminary tests with the codepa... Delia Mitric

02:19 AM Bug #9996 (WIP): Object references should be decremented at the nearest block instead of the top-...

The problem was discussed in #9538-153 - #9538-158, the problem is that we increase the reference of an object when w... Dănuț Filimon

02:10 AM Bug #9996 (Test): Object references should be decremented at the nearest block instead of the top...

Dănuț Filimon

10:08 PM Feature #9955 (Review): Implement ClientPrincipal:TENANT-ID and ClientPrincipal:TENANT-NAME

Please review. Ovidiu Maxiniuc

10:07 PM Feature #9955 (WIP): Implement ClientPrincipal:TENANT-ID and ClientPrincipal:TENANT-NAME

Committed revision 15907 into 9955a with improved support. All above issues were addressed.
The only remaining issue... Ovidiu Maxiniuc

05/15/2025

01:16 PM Bug #9532: codepage support in ASC(), CHR(), OUTPUT TO ... CONVERT and FIX-CODEPAGE()

Hi Delia, what is the state of #4766? Can you do some preliminary tests with the codepages mentioned by Greg? Constantin Asofiei

07:44 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Committed rev. 15883 to branch 6161 that introduces a fix for the assignment to properties case.
The changes were... Paul Bodale

02:39 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Assignment to variables was working fine even for objects but then we changed the assignment rules to convert to the ... Paul Bodale

02:31 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Constantin Asofiei wrote:
> What is @getDynamicProperty@ returning in your branch?
Similar to DYNAMIC-INVOKE, @ge... Paul Bodale

06:33 AM Feature #9437: enhancements for Progress.Lang.Class

Eduard Soltan wrote:
> Greg Shah wrote:
>
> > Progress.Lang.Class.invoke - this can be considered 'partial' now, ... Marian Edu

05:47 AM Feature #9437: enhancements for Progress.Lang.Class

Greg Shah wrote:
> Progress.Lang.Class.invoke - this can be considered 'partial' now, it needs proper testing (may... Eduard Soltan

05:41 AM Feature #9437 (WIP): enhancements for Progress.Lang.Class

Eduard Soltan

04:45 AM Feature #9437: enhancements for Progress.Lang.Class

Added runtime support for Progress.Lang.Class.haswidgetpool(), in 9437a, rev. 15908. Eduard Soltan

08:45 PM Feature #9955: Implement ClientPrincipal:TENANT-ID and ClientPrincipal:TENANT-NAME

I created task branch 9955a and committed the initial implementation.
The initial commit contains:
* full support f... Ovidiu Maxiniuc

05/14/2025

02:58 PM Feature #9437: enhancements for Progress.Lang.Class

Eduard Soltan wrote:
> I think we could emit in converted class a field of type @WidgetPoolData@.
Please emit an an... Constantin Asofiei

02:56 PM Feature #9437: enhancements for Progress.Lang.Class

Greg Shah wrote:
> Progress.Lang.Class.haswidgetpool() - unsupported
Please observe my test class:... Eduard Soltan

10:05 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

What is @getDynamicProperty@ returning in your branch?
I would expect if this is a problem of extent vs non-extent... Constantin Asofiei

09:20 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

I've found the following conversion problems:... Paul Bodale

05:05 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality

Review of 6506a rev 15764:
* WebContextOps - anything not supported, like FORM/QUERY env, other CGI vars, etc need t... Constantin Asofiei

04:26 AM Feature #6490: DYNAMIC-INVOKE which returns an extent

Committed rev. 15912 on branch 6490a in which I modified "is_extent_lvalue_ref" function because it wasn't returning ... Paul Bodale

04:01 AM Feature #8904 (Test): implement -catchStop and the integration/conversion of STOP conditions into...

Constantin Asofiei

03:16 AM Bug #4602 (Review): fixes for OO 4GL and structured error handling

I tested patch from #9969 with the changes from 4602a, on customer application unittests and I no longer see the regr... Eduard Soltan

05/13/2025

05:07 AM Feature #6490: DYNAMIC-INVOKE which returns an extent

Committed rev. 15911 on branch 6490a that addresses the issue from note #6490-84
I changed the rules so that DYNAMIC... Paul Bodale

05/12/2025

07:20 AM Feature #6490: DYNAMIC-INVOKE which returns an extent

There is the case where LVALUE is an extent and RVALUE is a scalar:... Paul Bodale

07:05 AM Feature #6490: DYNAMIC-INVOKE which returns an extent

Is it 'safe' enough to emit @invoke()@ if LVALUE is a scalar field, and @invokeExtent@ otherwise? Ensuring that an ER... Constantin Asofiei

06:17 AM Feature #6490: DYNAMIC-INVOKE which returns an extent

@ObjectOps.dynamicInvoke@ is the API for poly, it returns object. Trunk doesn't have the methods for returning extent... Paul Bodale

06:03 AM Feature #6490: DYNAMIC-INVOKE which returns an extent

What is the behavior in trunk? Also, @ObjectOps.dynamicInvoke@ now returns 'object' or BDT? Constantin Asofiei

05:26 AM Feature #6490: DYNAMIC-INVOKE which returns an extent

This problem remained unresolved:... Paul Bodale

05/09/2025

10:30 AM Feature #6490: DYNAMIC-INVOKE which returns an extent

Committed rev. 15887 on branch 6490a that addresses the feedback.
Constantin Asofiei wrote:
> Review for 6490 rev... Paul Bodale

06:39 AM Feature #6490: DYNAMIC-INVOKE which returns an extent

Paul, please get the review addressed, rebase and lets get it through testing. Constantin Asofiei

07:40 AM Feature #9516: include pre-converted webspeed runtime code in FWD

You will also need to add @${P2J_HOME}/abl/ade/src/@ to the PROPATH in @p2j.cfg.xml@. Constantin Asofiei

07:38 AM Feature #9516: include pre-converted webspeed runtime code in FWD

You need to copy the skeleton project , and also add @<parameter name="oo-skeleton-path" value="skeleton" />@ in @p2j... Constantin Asofiei

07:32 AM Feature #9516: include pre-converted webspeed runtime code in FWD

One more thing, which might be needed in the future configurations: this is how @web-disp.p@ is included in the 4GL e... Radu Apetrii

07:13 AM Feature #9516: include pre-converted webspeed runtime code in FWD

While trying to set up the webspeed sample, I encountered something that I don't know how to fix. Basically, I update... Radu Apetrii

06:59 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Constantin Asofiei wrote:
> This is really weird - looks like a bug in 4GL, you can pass @DYNAMIC-PROPERTY(props, "i... Paul Bodale

06:34 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

This is really weird - looks like a bug in 4GL, you can pass @DYNAMIC-PROPERTY(props, "intExt1")@ as an argument to a... Constantin Asofiei

05:36 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

I also found this case and I'm not sure what to do... Paul Bodale

04:07 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Committed rev. 15881 on branch 6161a.
In this commit:
* I enhanced the API of DYNAMIC-PROPERTY to avoid unnecessary... Paul Bodale

05:26 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality

I committed to 6506a rev. 15764 a few more things:
* Added implementations for @GET-CGI-LIST()@, @GET-CGI-VALUE()@, ... Radu Apetrii

05/07/2025

06:25 AM Bug #9819: SESSION:FIRST-ASYNC-REQUEST and SESSION:LAST-ASYNC-REQUEST

Do I have the change @message h:connect("-URL http://localhost:8810/apsv -sessionModel Session-free").@ the connectio... Eduard Soltan

04:16 AM Bug #9819: SESSION:FIRST-ASYNC-REQUEST and SESSION:LAST-ASYNC-REQUEST

I can not make SESSION:FIRST/LAST-ASYNC-REQUEST to return anything else other than unknown with 11.7:
* start progra... Constantin Asofiei

04:48 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

8904a was merged to trunk rev. 15887 and archived. Eduard Soltan

03:58 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Please merge 8904a to trunk after 9877a. Constantin Asofiei

04:15 AM Bug #9877 (Test): output extent parameter when the type is object

Branch 9877a was merged into trunk as rev. 15886 and archived. Paul Bodale

03:58 AM Bug #9877: output extent parameter when the type is object

Please merge 9877a to trunk now. Constantin Asofiei

05/06/2025

12:29 PM Bug #9967: unix separator in strings gets resolved as unicode separator

This test when ran on Windows and Linux OpenEdge has different outputs:... Constantin Asofiei

12:20 PM Bug #9967 (New): unix separator in strings gets resolved as unicode separator

Constantin Asofiei

05/05/2025

05:31 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Constantin Asofiei wrote:
> > That should have converted as @res = assignMulti(res, ...)@. That is the problem.
> ... Paul Bodale

03:12 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Constantin Asofiei wrote:
> Please don't use @this.text@, use @evalLib("type_pair", prog.func_int, prog.kw_extent, t... Paul Bodale

05/03/2025

10:08 AM Bug #9963: Date literal issues

Florin: Please add these cases to the lexer tests. Greg Shah

09:19 AM Bug #9963: Date literal issues

Consider the following ABL program:... Vladimir Tsichevski

09:05 AM Bug #9963 (New): Date literal issues

Vladimir Tsichevski

05/02/2025

02:29 PM Bug #9893: LegacyErrorException is not rethrown in processForBody/processBody

I found a smaller recreate of the failing test:... Andrei Plugaru

08:17 AM Bug #9893: LegacyErrorException is not rethrown in processForBody/processBody

In the large customer application I tested, I discovered a few regressions. At this moment, I am not sure whether the... Andrei Plugaru

05/01/2025

07:15 AM Feature #9516: include pre-converted webspeed runtime code in FWD

For details on how we properly document the licensing of the ADE code, see [[p2j:Inclusion of Apache 2 Licensed ADE C... Greg Shah

07:15 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

For details on how we properly document the licensing of the ADE code, see [[p2j:Inclusion of Apache 2 Licensed ADE C... Greg Shah

04/30/2025

05:45 PM Bug #9906: Incorrect date parsing in FWD DATE(CHARACTER) implementation

The same issues occur when setting the @SCREEN-VALUE@ attribute of a date @FILL-IN@, because the @SCREEN-VALUE@ parsi... Vladimir Tsichevski

04:50 PM Bug #9956: Client crashes in DATE function

The same problem occurs is you use @SCREEN-VALUE@ attribute to set @FILL-IN@ value. Vladimir Tsichevski

04:49 PM Bug #9956: Client crashes in DATE function

The 9906a fixed this issue as well. Vladimir Tsichevski

03:57 PM Bug #9956: Client crashes in DATE function

Run the following program:... Vladimir Tsichevski

03:43 PM Bug #9956 (Closed): Client crashes in DATE function

Vladimir Tsichevski

09:20 AM Feature #9955: Implement ClientPrincipal:TENANT-ID and ClientPrincipal:TENANT-NAME

This task is mean for completing the runtime support for @ClientPrincipal:TENANT-ID@ and @ClientPrincipal:TENANT-NAME... Ioana-Cristina Prioteasa

09:18 AM Feature #9955 (Test): Implement ClientPrincipal:TENANT-ID and ClientPrincipal:TENANT-NAME

Ioana-Cristina Prioteasa

09:15 AM Feature #9436: add built-in OO classes

Testcases tests added from #9436 and #9488:
* @Progress.IO.ByteOrder@ at @tests/oo/progress/io/TestByteOrder.cls@ : ... Ioana-Cristina Prioteasa

08:57 AM Feature #9436: add built-in OO classes

Ioana-Cristina Prioteasa wrote:
> I still need to look at:
> * is there a destructor in @MemoryOutputStream@, which... Ioana-Cristina Prioteasa

05:25 AM Feature #9436: add built-in OO classes

Ioana-Cristina Prioteasa wrote:
> I added the @Array.cls@ and @ArrayIterator.cls@ from github ADE, where they are th... Constantin Asofiei

05:07 AM Feature #9436: add built-in OO classes

I added the @Array.cls@ and @ArrayIterator.cls@ from github ADE, where they are the same for 12.8 and 11.7 release.
... Ioana-Cristina Prioteasa

08:15 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Please don't use @this.text@, use @evalLib("type_pair", prog.func_int, prog.kw_extent, this)@ (or something like this). Constantin Asofiei

08:03 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

I've tried running the existing tests for extent variables but I've a problem.
Tests convert like this:... Paul Bodale

03:10 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Paul Bodale wrote:
> Should I also touch on the other cases?
We need to cover the same cases done for @DYNAMIC-INVO... Constantin Asofiei

03:09 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

I've made some debugging and I've reached this place in the @convert/assignments.rules@:... Paul Bodale

04/29/2025

12:48 PM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Just got news that customer application harness and reports regression testing went succesful. ☑️
I also run Ctrl+... Eduard Soltan

10:18 AM Feature #9436: add built-in OO classes

> At the moment resolving the proversion at conversion time is broken as it tries to use EnviromentOps.getVersion tha... Greg Shah

08:53 AM Feature #9436: add built-in OO classes

I twitched the Array Iterator 4GL Unit test. It has a lot of differences between the versions.
The @ArrayIterator@ ... Ioana-Cristina Prioteasa

10:02 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Constantin Asofiei wrote:
> That should have converted as @res = assignMulti(res, ...)@. That is the problem.
And ... Constantin Asofiei

10:01 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

That should have converted as @res = assignMulti(res, ...)@. That is the problem. Constantin Asofiei

09:59 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Constantin Asofiei wrote:
> Please post the entire testcase. The Java reference of an array is re-assigned *only if... Paul Bodale

09:58 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Please post the entire testcase. The Java reference of an array is re-assigned *only if it was resized* (so dynamic ... Constantin Asofiei

09:56 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Regarding the problem in the previous note,
I think I know where the problem comes from. In the class where the va... Paul Bodale

08:22 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Committed rev. 15878 on branch 6161a that introduces support for calling DYNAMIC-PROPERTY when the property retrieved... Paul Bodale

09:46 AM Bug #4766: fix CHR and ASC

Thank you for the explanation!
I've investigated myself to see if the problems comes from how bytes are stored in ... Delia Mitric

09:44 AM Bug #9893: LegacyErrorException is not rethrown in processForBody/processBody

Andrei Plugaru wrote:
> unit tests of large GUI application [ai]
Passed! ✅ Andrei Iacob

04:26 AM Bug #9893: LegacyErrorException is not rethrown in processForBody/processBody

Andrei Plugaru wrote:
> unit tests of large customer application [ai]
Passed! ✅ Andrei Iacob

04/28/2025

04:58 PM Feature #8904 (Internal Test): implement -catchStop and the integration/conversion of STOP condit...

I have no observation related to this revision. Ovidiu Maxiniuc

12:10 PM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Committed on 8904a, rev. 15903. Eduard Soltan

10:38 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

*Review of 8904a/r15902*
* @ConnectionManager.getTimeOut()@: why moving the connect options from @opts@ to @option... Ovidiu Maxiniuc

10:53 AM Feature #9436: add built-in OO classes

Committed on 9436b what is needed from 9488a:
* *rev. 15883*: Support *=, -=, +=, /= operator syntax.
* *rev. 15884... Ioana-Cristina Prioteasa

09:40 AM Feature #9436: add built-in OO classes

Had a meeting with Constantin about this and it seems that the methods in the @Progress@ package are not wrapped in a... Ioana-Cristina Prioteasa

08:23 AM Feature #9436: add built-in OO classes

Yes, and it gets converted as:... Ioana-Cristina Prioteasa

08:18 AM Feature #9436: add built-in OO classes

How is the test executed? With @NO-ERRO@? Constantin Asofiei

08:15 AM Feature #9436: add built-in OO classes

In @List.addAll@ I had:... Ioana-Cristina Prioteasa

09:23 AM Bug #9893: LegacyErrorException is not rethrown in processForBody/processBody

Harness testing passed! Lorian Sandu

07:46 AM Bug #9893: LegacyErrorException is not rethrown in processForBody/processBody

Test plan:
# fwd tests and unit tests [me]
# unit tests of large customer application [ai]
# unit tests of large c... Andrei Plugaru

07:23 AM Bug #9893 (Internal Test): LegacyErrorException is not rethrown in processForBody/processBody

Andrei Plugaru wrote:
> Constantin, can we move on to testing? If yes, I can do the unit tests and fwd tests of a la... Constantin Asofiei

07:01 AM Bug #9893: LegacyErrorException is not rethrown in processForBody/processBody

Constantin, can we move on to testing? If yes, I can do the unit tests and fwd tests of a large customer application.... Andrei Plugaru

05:31 AM Bug #9893: LegacyErrorException is not rethrown in processForBody/processBody

The changes make sense in -9754a- 9753a/15850. Constantin Asofiei

07:58 AM Bug #8944: FINALLY block transaction processing

Artur Școlnic wrote:
> No, it does not solve the test cases from this task, the problem is that there are multiple w... Eduard Soltan

07:55 AM Bug #8944: FINALLY block transaction processing

No, it does not solve the test cases from this task, the problem is that there are multiple ways to get to end up in ... Artur Școlnic

07:22 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Paul Bodale wrote:
> Constantin Asofiei wrote:
> > Please see #9488-157 - I think Ioana already fixed the unknown p... Constantin Asofiei

07:00 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Constantin Asofiei wrote:
> Please see #9488-157 - I think Ioana already fixed the unknown problem for extent resize... Paul Bodale

05:20 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Please see #9488-157 - I think Ioana already fixed the unknown problem for extent resize. Constantin Asofiei

05:18 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Constantin Asofiei wrote:
> There is code in @jobject.fromJava@, you can refactor that and use it at runtime, to con... Paul Bodale

02:52 AM Bug #9877 (Merge Pending): output extent parameter when the type is object

Conversion testing passed - do not merge now. I will post when this can be merged. Constantin Asofiei

04/27/2025

09:40 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Paul Bodale wrote:
> * When setting a simple BDT property the code sometimes converts to the java native type. This ... Constantin Asofiei

09:34 AM Feature #6490: DYNAMIC-INVOKE which returns an extent

Review for 6490 rev 15875:
* @rules/convert/base_structure.xml@
** shouldn't this call @is_extent_or_poly_case@ fro... Constantin Asofiei

09:19 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Ioana, please get these changes and commit them (one at a time) to 9436b; please see the review bellow, and also make... Constantin Asofiei

07:34 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

9488a was rebased from trunk rev 15875 - new rev 15902. Constantin Asofiei

08:38 AM Feature #9436: add built-in OO classes

Review for 9436b rev 15881:
* @MemoryOutputStream@
** please update the support annotations for @MemoryOutputStream... Constantin Asofiei

07:35 AM Feature #9436: add built-in OO classes

9436b was rebased from trunk rev 15875 - new rev 15881. Constantin Asofiei

04/26/2025

02:55 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Ovidiu Maxiniuc wrote:
> Review of 8904a/r15892.
>
> Generally, I am OK with the changes. And this is a large cha... Eduard Soltan

04/25/2025

03:04 PM Bug #4766: fix CHR and ASC

Delia Mitric wrote:
> What I don't understand is why BE result is the same as the LE result and I don't know how sh... Ovidiu Maxiniuc

02:48 AM Bug #4766: fix CHR and ASC

Ovidiu Maxiniuc wrote:
> Let's use @€@ (EURO SIGN) as reference.
> * it is the 8364th character in the Unicode se... Delia Mitric

10:53 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Review of 8904a/r15892.
Generally, I am OK with the changes. And this is a large change-set. I have just a few com... Ovidiu Maxiniuc

08:14 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Constantin Asofiei wrote:
> The only concern is the usage of @isIgnore()@ in @ErrorManager.handleStopException@ - do... Eduard Soltan

08:05 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

The only concern is the usage of @isIgnore()@ in @ErrorManager.handleStopException@ - do we really need this?
Othe... Constantin Asofiei

09:31 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality

Radu Apetrii wrote:
> Constantin Asofiei wrote:
> > * @WebNotifyListener.stopListening@ just does @webNotifyThread.... Constantin Asofiei

09:23 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality

Constantin Asofiei wrote:
> * @WebNotifyListener.stopListening@ just does @webNotifyThread.interrupt()@ - you need t... Radu Apetrii

08:58 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality

Review for 6506a rev 15763:
* @WebNotifyListener.stopListening@ just does @webNotifyThread.interrupt()@ - you need t... Constantin Asofiei

08:50 AM Feature #6506 (Review): implement CGI WebSpeed support and the standard web-disp.p dispatch funct...

On 6506a rev. 15763 I did the following:
* Addressed Constantin's review from #6506-103.
** Added code to terminate... Radu Apetrii

06:00 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality

Radu Apetrii wrote:
> And should I also add in @Agent.handleWebspeed@ a call to @WebHandlerHelper.clear()@ right bef... Constantin Asofiei

05:44 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality

And should I also add in @Agent.handleWebspeed@ a call to @WebHandlerHelper.clear()@ right before the return statemen... Radu Apetrii

05:29 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality

Radu Apetrii wrote:
> Constantin Asofiei wrote:
> > and remove @WebspeedRequestHandler@ - I don't see a reason for ... Constantin Asofiei

05:17 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality

Constantin Asofiei wrote:
> and remove @WebspeedRequestHandler@ - I don't see a reason for it.
May I also remove th... Radu Apetrii

09:31 AM Bug #8944: FINALLY block transaction processing

Artur Școlnic wrote:
> The patch from #9803-46 solved the initial problem this task was opened for, considering that... Eduard Soltan

07:57 AM Bug #8944: FINALLY block transaction processing

The patch from #9803-46 solved the initial problem this task was opened for, considering that changes from 4602a will... Artur Școlnic

04:53 AM Bug #8944: FINALLY block transaction processing

I have added a fix for transaction management in 4602a, rev. 15880. Eduard Soltan

02:50 AM Bug #8944: FINALLY block transaction processing

According to note #8944-26 and my observation in FWD.
Transaction is opened in @TM.PushScope@, through @TxWrapper.sc... Eduard Soltan

08:51 AM Feature #6432 (Review): implement the WEB special stream

The changes for web stream are on 6506a rev. 15763. The notes are on #6506-108, under the #6432 category. Also, the s... Radu Apetrii

08:26 AM Bug #9060: Cache oftenly used values that are immutable

OK, lets leave it as this for now.
For 9060b:
* please do @bzr diff -r 15867 --using meld@ and check the copyrigh... Constantin Asofiei

08:21 AM Bug #9060: Cache oftenly used values that are immutable

Returning a mutable instance for all implementations seems to work fine, the testing passed. Artur Școlnic

08:20 AM Bug #9060: Cache oftenly used values that are immutable

Constantin Asofiei wrote:
> * also, I think is part of a larger problem: we have @DataHandler.getField()@, for which... Constantin Asofiei

05:58 AM Bug #9060: Cache oftenly used values that are immutable

Artur, the change in @ControlFlowOps@ and @TargetLob@ are good. But, the @RecordBuffer@ change is not OK:
* you cha... Constantin Asofiei

05:49 AM Bug #9060: Cache oftenly used values that are immutable

I committed the fix for this and other issues to 9060b/15882. Constantin, maybe you can take a look while I continue ... Artur Școlnic

08:25 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Went thru the commits in *9488a*. Here is a summary:
h2. Fixes for converting legacy oo
- Added support for emi... Ioana-Cristina Prioteasa

05:02 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Classes that implement @com.goldencode.p2j.oo.core.collections.Icollection@(@OpenEdge.Core.Collections.ICollection@):... Ioana-Cristina Prioteasa

08:03 AM Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Constantin Asofiei wrote:
> Paul, please review the support for @DYNAMIC-PROPERTY@ and what tests exist, and what ne... Paul Bodale

05:46 AM Bug #9877: output extent parameter when the type is object

Committed rev. 15873 on branch 9877a which fixes the issue where the code would convert to the text @${rettype}@.
... Paul Bodale

04/24/2025

03:26 PM Feature #8904 (Review): implement -catchStop and the integration/conversion of STOP conditions in...

Eduard Soltan

03:25 PM Feature #8904 (WIP): implement -catchStop and the integration/conversion of STOP conditions into ...

Committed the handling of StopConditionException through ErrorManager.
Conversion of large GUI app and another cus... Eduard Soltan

02:14 PM Bug #9060: Cache oftenly used values that are immutable

Artur, I understand that, but constant types should be resolved to their actual types. There is a bug somewhere in @... Constantin Asofiei

09:22 AM Bug #9060: Cache oftenly used values that are immutable

... Artur Școlnic

09:09 AM Bug #9060: Cache oftenly used values that are immutable

The point is: the @type@ at that place most likely is a i.e. @integerConstant@ - look further or otherwise debug and ... Constantin Asofiei

09:08 AM Bug #9060: Cache oftenly used values that are immutable

Constantin Asofiei wrote:
> Artur, see @FuzzyMethodRt.resolveSignature@ - @type = arg.getClass().getSimpleName();@ -... Artur Școlnic

08:58 AM Bug #9060: Cache oftenly used values that are immutable

Artur, see @FuzzyMethodRt.resolveSignature@ - @type = arg.getClass().getSimpleName();@ - if arg is a @BaseDataTypeCon... Constantin Asofiei

08:40 AM Bug #9060: Cache oftenly used values that are immutable

With a simple null check, the failing tests are passing. Artur Școlnic

08:39 AM Bug #9060: Cache oftenly used values that are immutable

... Artur Școlnic

08:35 AM Bug #9060: Cache oftenly used values that are immutable

Artur, on a second thought: this is a *runtime* stack - that location should never be reached. Something is wrong in... Constantin Asofiei

08:18 AM Bug #9060: Cache oftenly used values that are immutable

... Artur Școlnic

08:17 AM Bug #9060: Cache oftenly used values that are immutable

Artur Școlnic wrote:
> The call is @fuzzyMethodLookup(methodName, sig, accessMode, isStatic, internal, null);@
Plea... Constantin Asofiei

08:16 AM Bug #9060: Cache oftenly used values that are immutable

The call is @fuzzyMethodLookup(methodName, sig, accessMode, isStatic, internal, null);@
null is passed for the @node... Artur Școlnic

08:12 AM Bug #9060: Cache oftenly used values that are immutable

I don't understand, @fuzzyMethodLookup@ is almost sure called. I see @WARNING: more than one method def found using ... Constantin Asofiei

07:59 AM Bug #9060: Cache oftenly used values that are immutable

In @fuzzyMethodLookup@, the line:... Artur Școlnic

05:43 AM Bug #9060: Cache oftenly used values that are immutable

Also, testing needs to include performance testing, where possible. Constantin Asofiei

05:43 AM Bug #9060: Cache oftenly used values that are immutable

In @TargetLob(FieldReference field)@, @field.get()@ is called twice per call. Please use @bdt@ for the second call. Constantin Asofiei

05:40 AM Bug #9060 (Internal Test): Cache oftenly used values that are immutable

Artur Școlnic

01:10 PM Bug #4766: fix CHR and ASC

Delia Mitric wrote:
> It is possible to be a bug in the Progress version I use? (11.6)
I do not think there is an e... Ovidiu Maxiniuc

07:38 AM Feature #9436: add built-in OO classes

I have a version of these tests that compile and pass both on 12.8 and 11.6.
I attached the zip.
*Marian*, would yo... Ioana-Cristina Prioteasa

07:19 AM Feature #9436: add built-in OO classes

We have customer applications that can only run in 11.x. Those applications will be compared with FWD using the OE 1... Greg Shah

07:10 AM Feature #9436: add built-in OO classes

Greg Shah wrote:
> Yes, 11.x must be supported.
I don't really see the benefits, other than testing PSC code on OE,... Marian Edu

06:17 AM Feature #9436: add built-in OO classes

We have customers that are on 11.x and will never go to 12.x. It is critical that the tests can work across multiple... Greg Shah

05:09 AM Feature #9436: add built-in OO classes

Ioana-Cristina Prioteasa wrote:
> If what is on xfer works on 12.2(i am not sure how I can access that version to te... Marian Edu

04:22 AM Feature #9436: add built-in OO classes

Marian Edu wrote:
> How old? In any case the baseline used for writing tests (ABLUnit style) was OE12.2, ABLUnit cod... Ioana-Cristina Prioteasa

04:17 AM Feature #9436: add built-in OO classes

Ioana-Cristina Prioteasa wrote:
> For integrating the v12 tests I think I need to use the preprocessor. For example ... Marian Edu

04:16 AM Feature #9436: add built-in OO classes

Ioana-Cristina Prioteasa wrote:
> Marian, I am now looking at the tests for @OpenEdge.Core.Collections.ArrayIterator... Marian Edu

04:11 AM Feature #9436: add built-in OO classes

For integrating the v12 tests I think I need to use the preprocessor. For example in @ArrayIteratorStub@ I need to ad... Ioana-Cristina Prioteasa

03:43 AM Feature #9436: add built-in OO classes

Marian, I am now looking at the tests for @OpenEdge.Core.Collections.ArrayIterator@ at @tests/oo/openedge/core/collec... Ioana-Cristina Prioteasa

02:12 AM Bug #9877: output extent parameter when the type is object

Committed rev. 15872 to branch 9877a. This revision fixes a problem found during conversion testing where the code wo... Paul Bodale

04/23/2025

02:15 PM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Ioana, please go through all the changes in 9488a and group them by the common 'feature'; so, file x, y, z fix this p... Constantin Asofiei

08:31 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

I did all the necessary modifications and saved the latest converted code at @devsrv01:/home/icp/ADE_latest_converted... Ioana-Cristina Prioteasa

07:40 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Ioana, I've created #9923 for the @bulkSetValue(new longchar@ problem - for now, please fix this 'by hand' by changin... Constantin Asofiei

06:47 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Committed in *9488a rev. 15866*: When loading builtin classes, correctly resolve setter and getter names. In @ClassDe... Ioana-Cristina Prioteasa

09:41 AM Bug #9923: extent argument type vs parameter type compatibility

For INPUT case, the solution (if arg and parameter type differs and is extent) would be to emit a @<T extends BaseDat... Constantin Asofiei

08:03 AM Bug #9923: extent argument type vs parameter type compatibility

Paul Bodale wrote:
> Constantin Asofiei wrote:
> > Paul: please let me know if you've already found something simil... Constantin Asofiei

07:59 AM Bug #9923: extent argument type vs parameter type compatibility

Constantin Asofiei wrote:
> Paul: please let me know if you've already found something similar.
Yes, I noticed th... Paul Bodale

07:39 AM Bug #9923: extent argument type vs parameter type compatibility

There is this test which shows that extent arguments can be of different (but compatible) types:... Constantin Asofiei

07:35 AM Bug #9923 (New): extent argument type vs parameter type compatibility

Constantin Asofiei

08:24 AM Feature #6292 (Closed): nested catch blocks

Greg Shah

08:18 AM Feature #6292: nested catch blocks

Greg Shah wrote:
> With 9470a merged to trunk as revision 15867, is this task complete?
Yes, I think so. Eduard Soltan

08:17 AM Feature #6292: nested catch blocks

With 9470a merged to trunk as revision 15867, is this task complete? Greg Shah

08:16 AM Bug #4766: fix CHR and ASC

Delia Mitric wrote:
> Yes, because I'm trying to see how "conversion" from cpinternal to source codepage is made. ... Marian Edu

05:47 AM Bug #4766: fix CHR and ASC

Marian Edu wrote:
> Delia Mitric wrote:
> > * @ASC(chr(14844588), "UTF-16", "UTF-16").@ run with cpinternal = UTF-8... Delia Mitric

05:17 AM Bug #4766: fix CHR and ASC

Delia Mitric wrote:
> * @ASC(chr(14844588), "UTF-16", "UTF-16").@ run with cpinternal = UTF-8 results in: *11305698*... Marian Edu

03:38 AM Bug #4766: fix CHR and ASC

Greg Shah wrote:
> > It is necessary to add files for these cases?
>
> Does OE have a default conversion that the... Delia Mitric

06:26 AM Bug #9060: Cache oftenly used values that are immutable

Constantin Asofiei wrote:
> Does @ this.lob = (LargeObject) field.get().duplicate();@ work, only and only if @field... Artur Școlnic

06:24 AM Bug #9060: Cache oftenly used values that are immutable

Does @ this.lob = (LargeObject) field.get().duplicate();@ work, only and only if @field.get()@ is a @BaseDataTypeCon... Constantin Asofiei

06:20 AM Bug #9060: Cache oftenly used values that are immutable

Artur Școlnic wrote:
> Constantin Asofiei wrote:
> > * in @Stream.readField@, @return res;@ should be used for non-... Constantin Asofiei

06:10 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality

Radu, this is review for 6560a rev 15762:
* in @Agent.startWebspeed@, add a finally block after the catch, to also t... Constantin Asofiei

05:48 AM Bug #9877 (Internal Test): output extent parameter when the type is object

We can to put this into conversion testing, the review for 15861 is OK. Anything else to do for this task? If not, p... Constantin Asofiei

02:53 AM Bug #9877: output extent parameter when the type is object

Constantin Asofiei wrote:
> Paul, just one question: @get_param_ast@ - this is supposed to find a PARAMETER node und... Paul Bodale

02:17 AM Bug #9877: output extent parameter when the type is object

Paul, just one question: @get_param_ast@ - this is supposed to find a PARAMETER node under @LPARENS@ of the method/fu... Constantin Asofiei

05:46 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Eduard, please double-check @StopConditionException@ throw throughout the project (i.e. @DbUtils.handleException@)
... Constantin Asofiei

05:35 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Constantin Asofiei wrote:
> Eduard Soltan wrote:
> > Committed on 8904a, rev. 15888.
>
> I assume there was a re... Eduard Soltan

05:11 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Eduard Soltan wrote:
> Committed on 8904a, rev. 15888.
I assume there was a rebase - please push the branch. Constantin Asofiei

04:00 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Committed on 8904a, rev. 15888. Eduard Soltan

03:32 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

No, I can't inherit from any of this classes.
It gives the following error, for all subclasses of Progress.Lang.Sto... Eduard Soltan

03:21 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Constantin Asofiei wrote:
> > > You cannot inherit from this class.
> Please confirm this with a test.
And also t... Constantin Asofiei

03:10 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Eduard Soltan wrote:
> Constantin Asofiei wrote:
> > Eduard, is it possible to have application-defined @Stop@ sub-... Constantin Asofiei

02:43 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Constantin Asofiei wrote:
> Eduard, is it possible to have application-defined @Stop@ sub-classes? I think the conve... Eduard Soltan

02:23 AM Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

Eduard, is it possible to have application-defined @Stop@ sub-classes? I think the conversion rules need to check exp... Constantin Asofiei

03:52 AM Feature #6161 (WIP): add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY la...

Paul, please review the support for @DYNAMIC-PROPERTY@ and what tests exist, and what needs to be added. Constantin Asofiei

04/22/2025

01:54 PM Bug #8944: FINALLY block transaction processing

Constantin Asofiei wrote:
> Eduard, in 4GL there is an implicit FULL transaction created when EXLCUSIVE-LOCK is used... Eduard Soltan

01:48 PM Bug #8944: FINALLY block transaction processing

Eduard, in 4GL there is an implicit FULL transaction created when EXLCUSIVE-LOCK is used or a @CREATE <buffeR>@ is us... Constantin Asofiei

01:00 PM Bug #8944: FINALLY block transaction processing

Greg Shah wrote:
> If the @FINALLY@ is more deeply nested (the full transaction is in a more enclosing block, not in... Eduard Soltan

08:33 AM Bug #8944: FINALLY block transaction processing

If the @FINALLY@ is more deeply nested (the full transaction is in a more enclosing block, not in the immediately con... Greg Shah

07:23 AM Bug #8944: FINALLY block transaction processing

Artur Școlnic wrote:
> Isn't a new transaction for the finally block expected?
I created the a test cases to look... Eduard Soltan

05:22 AM Bug #8944: FINALLY block transaction processing

Isn't a new transaction for the finally block expected? Artur Școlnic

05:16 AM Bug #8944: FINALLY block transaction processing

Artur Școlnic wrote:
> As far as I know, a full transaction is started by a block only if a transaction is not alrea... Eduard Soltan

10:42 AM Feature #9488: implement all built-in OO classes using the open source ADE code from 12.8.4

Committed in *9488a rev. 15865* a possible solution for the naming issue described in #9488-147. It solves all the ca... Ioana-Cristina Prioteasa

09:37 AM Bug #9060: Cache oftenly used values that are immutable

Constantin Asofiei wrote:
> * in @Stream.readField@, @return res;@ should be used for non-constant case (to keep the... Artur Școlnic

09:07 AM Bug #9060: Cache oftenly used values that are immutable

Review of 9060b rev 15860:
* in @Stream.readField@, @return res;@ should be used for non-constant case (to keep the ... Constantin Asofiei

08:37 AM Bug #9877 (Review): output extent parameter when the type is object

Paul Bodale

08:37 AM Bug #9877: output extent parameter when the type is object

I tested with both java 8 and java 17 and in both cases the project compiles and runs.
I committed rev. 15861 with... Paul Bodale

06:50 AM Feature #6490: DYNAMIC-INVOKE which returns an extent

While working on another task, I encountered a problem that applies to the changes I made for DYNAMIC-INVOKE and modi... Paul Bodale

06:25 AM Feature #9436: add built-in OO classes

Committed on *testcases project rev. 1744*: Added tests for @Progress.Collections.List@ and built-in function @HASH-C... Ioana-Cristina Prioteasa