FWD » Core Development » Base Language

12/04/2025

04:00 PM Bug #10973: REGRESSION: No string literal to LONGCHAR conversion for 4GL class method call parame...

This is a regression, this issue did not exist in trunk rev. 14527 when the task #7184 was worked on. Vladimir Tsichevski

03:56 PM Bug #10973: REGRESSION: No string literal to LONGCHAR conversion for 4GL class method call parame...

This issue affects the FWD conversion when passing a @CHARACTER@ literal as an argument to a class method expecting a... Vladimir Tsichevski

03:51 PM Bug #10973 (Review): REGRESSION: No string literal to LONGCHAR conversion for 4GL class method ca...

Vladimir Tsichevski

03:38 PM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR

> BTW, the call with no concatenation
> ... Vladimir Tsichevski

08:37 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR

The revision of 7184a is too old (14527) to be rebased to the current trunk, will create 7184b to continue... Vladimir Tsichevski

04:48 AM Bug #10935: Inherit the NO-UNDO option for a temp-table defined using the LIKE temp-table option

Committed rev. *16299* on branch *10935a* which contains the solution described in #10935-10.
After committing thi... Paul Bodale

12/03/2025

09:29 AM Feature #8138: ABLUnit configuration using environment variables

Rebased branch 8138b to trunk revision 16301. Please, review. Vladimir Tsichevski

09:22 AM Bug #10935: Inherit the NO-UNDO option for a temp-table defined using the LIKE temp-table option

I tested this on OE version 11.6 and 11.7. Paul Bodale

09:21 AM Bug #10935: Inherit the NO-UNDO option for a temp-table defined using the LIKE temp-table option

There is a problem. For the following test case:
A.cls... Paul Bodale

02:44 AM Bug #10935: Inherit the NO-UNDO option for a temp-table defined using the LIKE temp-table option

I think we need to go the same way as variable references are resolved, via @tempIdx@:
* in SymbolResolver, add a ca... Constantin Asofiei

02:28 AM Bug #10935: Inherit the NO-UNDO option for a temp-table defined using the LIKE temp-table option

Constantin Asofiei wrote:
> Paul, the direction is good, but the implementation needs to be rewritten to:
> * execu... Paul Bodale

06:39 AM Bug #10961: Optimize StringBuilder usage in FWD

For long lived code, we could pre-allocate a large @StringBuffer@ instance and reuse it instead of a local instance, ... Greg Shah

06:33 AM Bug #10961: Optimize StringBuilder usage in FWD

@StringBuilder@ has a constructor which can specify the expected number of characters. It will pre-allocate the memor... Ovidiu Maxiniuc

05:21 AM Bug #10961: Optimize StringBuilder usage in FWD

The initial capacity of @StringBuilder@ is 16 characters.
When this capacity exceeds, the entire string content gets... Teodor Gorghe

05:09 AM Bug #10961 (New): Optimize StringBuilder usage in FWD

Teodor Gorghe

12/02/2025

03:18 PM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR

Vladimir, back to this code:
* please test direct function calls with both longchar and char parameters, with standa... Constantin Asofiei

03:05 PM Feature #3853: implement LOG-MANAGER runtime

Vladimir Tsichevski wrote:
> > Vladimir, this was added during the initial FWD Assert implementation; what was the r... Constantin Asofiei

03:02 PM Feature #3853: implement LOG-MANAGER runtime

> Vladimir, this was added during the initial FWD Assert implementation; what was the reason for it?
@com.goldencode... Vladimir Tsichevski

12:20 PM Feature #3853: implement LOG-MANAGER runtime

Greg Shah wrote:
> > different class structure in OpenEdge.Core compared to FWD - In OE there is no OpenEdge.Core.Ab... Constantin Asofiei

11:50 AM Feature #3853: implement LOG-MANAGER runtime

> There is a tests that checks all available Logging Entries - not sure if it makes sense as I guess reported values ... Greg Shah

02:54 PM Bug #10935: Inherit the NO-UNDO option for a temp-table defined using the LIKE temp-table option

But, why not get the @NO-UNDO@ at the parse time and save it maybe as a special annotation, @like-no-undo@? Constantin Asofiei

02:54 PM Bug #10935 (WIP): Inherit the NO-UNDO option for a temp-table defined using the LIKE temp-table o...

Paul, the direction is good, but the implementation needs to be rewritten to:
* execute somewhere in schema phase (p... Constantin Asofiei

03:36 AM Bug #10935 (Review): Inherit the NO-UNDO option for a temp-table defined using the LIKE temp-tabl...

Created task branch *10935a* and committed rev. *16297* which introduces conversion changes to allow a temp-table def... Paul Bodale

01:56 PM Bug #7175 (Closed): substitute: incorrect handling of unknown longchar values

Greg Shah

01:37 PM Bug #7175 (Internal Test): substitute: incorrect handling of unknown longchar values

This issue does not exist anymore and should be closed. Vladimir Tsichevski

01:56 PM Bug #6993 (Closed): OO: incorrect field names in DataTypeEnum.java

Greg Shah

01:30 PM Bug #6993 (Internal Test): OO: incorrect field names in DataTypeEnum.java

This issue does not exist anymore: the example from #6993-10 compiles OK.
This issue can be closed. Vladimir Tsichevski

11:36 AM Bug #9956 (Closed): Client crashes in DATE function

Hynek Cihlar

11:35 AM Bug #9956 (Internal Test): Client crashes in DATE function

Vladimir Tsichevski wrote:
> The same problem occurs is you use @SCREEN-VALUE@ attribute to set @FILL-IN@ value.
... Vladimir Tsichevski

11/28/2025

04:06 PM Feature #3853: implement LOG-MANAGER runtime

I am almost done with fixing existing tests, just circling around some FWD-OE differences like:
* There is a tests... Tomasz Domin

07:35 AM Bug #10597: [Regression] extent field in form fails conversion

Dănuț Filimon wrote:
> The patch is already in the trunk from the instance, I'll give it the benefit of the doubt an... Stefanel Pezamosca

07:24 AM Bug #10597: [Regression] extent field in form fails conversion

Stefanel Pezamosca wrote:
> Dănuț Filimon wrote:
> > I ran a conversion with trunk/16293 for #10566 and the issue r... Dănuț Filimon

07:17 AM Bug #10597: [Regression] extent field in form fails conversion

Dănuț Filimon wrote:
> I ran a conversion with trunk/16293 for #10566 and the issue remained. Stefanel, did you also... Stefanel Pezamosca

06:48 AM Bug #10597: [Regression] extent field in form fails conversion

I ran a conversion with trunk/16293 for #10566 and the issue remained. Stefanel, did you also test the scenario using... Dănuț Filimon

11/27/2025

10:12 AM Feature #3853: implement LOG-MANAGER runtime

Constantin Asofiei wrote:
> See @ControlFlowOps.initializeLegacyObject@ - there are two methods being called when in... Tomasz Domin

11/26/2025

05:34 AM Bug #10935: Inherit the NO-UNDO option for a temp-table defined using the LIKE temp-table option

I did a little bit of digging into the methods that are related in some way to the @SchemaDictionary.TABLE_PROPS@.
... Paul Bodale

03:10 AM Bug #10935: Inherit the NO-UNDO option for a temp-table defined using the LIKE temp-table option

It looks like FWD partially ignores the @NO-UNDO@ keyword for a temp-table that also has the @LIKE@ option.
Check ... Paul Bodale

02:53 AM Bug #10935 (WIP): Inherit the NO-UNDO option for a temp-table defined using the LIKE temp-table o...

I tried adding @KW_NO_UNDO@ among the elements of the @SchemaDictionary.TABLE_PROPS@ converted the testcases I have a... Paul Bodale

02:20 AM Bug #10925 (WIP): Ignore dataset name if present, for a dataset declared with serialize-hidden

I will mark this task in WIP, since there are some more changes from 9457c that needs to be added there. Teodor Gorghe

01:48 AM Bug #10925 (Internal Test): Ignore dataset name if present, for a dataset declared with serialize...

Code review of *10925a* rev. @16293@:
* This includes the changes from *9457c/16275* and the fix from #10925-2.
* T... Teodor Gorghe

11/25/2025

10:28 AM Bug #10925: Ignore dataset name if present, for a dataset declared with serialize-hidden

Constantin Asofiei wrote:
> Paul: please create 10925a and add there the 9457c/16275 change and your change.
Crea... Paul Bodale

05:32 AM Bug #10925: Ignore dataset name if present, for a dataset declared with serialize-hidden

Paul: please create 10925a and add there the 9457c/16275 change and your change.
I'll also look into 9457c which o... Constantin Asofiei

03:17 AM Bug #10925 (Review): Ignore dataset name if present, for a dataset declared with serialize-hidden

Teodor Gorghe wrote:
> Code review of #10925-2:
> - this is a regression caused by the changes from 9457c rev 16275... Paul Bodale

08:44 AM Bug #10935: Inherit the NO-UNDO option for a temp-table defined using the LIKE temp-table option

For this 4gl testcase:... Paul Bodale

08:39 AM Bug #10935 (Closed): Inherit the NO-UNDO option for a temp-table defined using the LIKE temp-tabl...

Paul Bodale

06:32 AM Bug #10841 (Review): model table name is used in error messages for a 'like' temp-table definition

Created 10841a from trunk rev 16292; rev 16293 contains:
* A LIKE temp-table definition will copy the i.e. LABEL fro... Constantin Asofiei

02:47 AM Feature #3853: implement LOG-MANAGER runtime

See @ControlFlowOps.initializeLegacyObject@ - there are two methods being called when instantiating:
* the pseudo-ex... Constantin Asofiei

02:44 AM Feature #3853: implement LOG-MANAGER runtime

Constantin Asofiei wrote:
> Tomasz Domin wrote:
> > Is there a way to check in @Block@ if class constructor has bee... Tomasz Domin

02:32 AM Feature #3853: implement LOG-MANAGER runtime

Tomasz Domin wrote:
> Is there a way to check in @Block@ if class constructor has been called ?
You mean already ca... Constantin Asofiei

02:27 AM Feature #3853: implement LOG-MANAGER runtime

Is there a way to check in @Block@ if class constructor has been called ? Tomasz Domin

11/24/2025

12:38 PM Feature #8138 (Review): ABLUnit configuration using environment variables

Vladimir Tsichevski

12:37 PM Feature #8138: ABLUnit configuration using environment variables

Tested ABLUnit test execution on branch 8138b under Linux (both via Eclipse and console): no issues observed.
To v... Vladimir Tsichevski

11:11 AM Feature #8138: ABLUnit configuration using environment variables

8131b r.16294: Introduce Java system property for specifying the ABLUnit bootstrap XML configuration file replacing t... Vladimir Tsichevski

07:38 AM Feature #8138: ABLUnit configuration using environment variables

I was not able to rebase 8138a, and created a new branch 8138b. Vladimir Tsichevski

10:29 AM Bug #10925 (WIP): Ignore dataset name if present, for a dataset declared with serialize-hidden

Paul Bodale wrote:
> I attached a simple patch to be applied over the *9457c* rev. *16356* that solves the issue.
... Teodor Gorghe

09:11 AM Bug #10925: Ignore dataset name if present, for a dataset declared with serialize-hidden

I think you may need to use the SERIALIZE-NAME of the DATASET and not its NAME. Teodor, please review.
Also, Paul... Constantin Asofiei

08:51 AM Bug #10925 (Review): Ignore dataset name if present, for a dataset declared with serialize-hidden

I attached a simple patch to be applied over the *9457c* rev. *16356* that solves the issue. Paul Bodale

07:58 AM Bug #10925 (WIP): Ignore dataset name if present, for a dataset declared with serialize-hidden

There is this testcase:... Paul Bodale

07:07 AM Bug #10925 (Closed): Ignore dataset name if present, for a dataset declared with serialize-hidden

Paul Bodale

03:13 AM Feature #3853: implement LOG-MANAGER runtime

Constantin Asofiei wrote:
> Tomasz Domin wrote:
> > Not good thing about it that this approach requires storing all... Tomasz Domin

11/21/2025

06:24 PM Feature #8138: ABLUnit configuration using environment variables

Greg Shah wrote:
> Vladimir: I think you should take it from here.
Got it! Vladimir Tsichevski

06:20 PM Feature #8138: ABLUnit configuration using environment variables

My suggestion was in #8138-7. Greg Shah

06:02 PM Feature #8138: ABLUnit configuration using environment variables

Is this task active? Vladimir Tsichevski

03:48 PM Feature #3853: implement LOG-MANAGER runtime

Tomasz Domin wrote:
> Not good thing about it that this approach requires storing all function parameters values no ... Constantin Asofiei

03:46 PM Feature #3853: implement LOG-MANAGER runtime

Constantin Asofiei wrote:
> Tomasz Domin wrote:
> > Yes, but block manager does not process parameters, they are pa... Tomasz Domin

07:45 AM Feature #3853: implement LOG-MANAGER runtime

> But it may be needed to make conversion changes or a new AspectJ rules.
Conversion changes, if really needed, ar... Greg Shah

07:12 AM Feature #3853: implement LOG-MANAGER runtime

Tomasz Domin wrote:
> Constantin Asofiei wrote:
> > And how would the 4GL code look like, which would produce these... Constantin Asofiei

07:09 AM Feature #3853: implement LOG-MANAGER runtime

Constantin Asofiei wrote:
> And how would the 4GL code look like, which would produce these logs?... Tomasz Domin

06:10 AM Feature #3853: implement LOG-MANAGER runtime

And how would the 4GL code look like, which would produce these logs?
Note that every call (beside some exceptions... Constantin Asofiei

04:35 AM Feature #3853: implement LOG-MANAGER runtime

Constantin Asofiei wrote:
> Tomasz, if you need line numbers, look into how @p2j.oo.lang.ProError.callStack@ is calc... Tomasz Domin

03:38 AM Feature #3853: implement LOG-MANAGER runtime

Tomasz, if you need line numbers, look into how @p2j.oo.lang.ProError.callStack@ is calculated (from the Java stacktr... Constantin Asofiei

02:33 AM Feature #3853: implement LOG-MANAGER runtime

Greg, Constantin
I have a question on a preferred way legacy logging should be implemented, which requires finding a... Tomasz Domin

11/19/2025

03:35 PM Feature #3853: implement LOG-MANAGER runtime

Greg Shah wrote:
> > Is there a standard way of resolving (as a reverse lookup) of current procedure name, line and ... Constantin Asofiei

11:52 AM Feature #3853: implement LOG-MANAGER runtime

Greg Shah wrote:
> > I didnt find anything related to reverse lookup of a line number.
>
> We don't have this at ... Tomasz Domin

10:51 AM Feature #3853: implement LOG-MANAGER runtime

> Is there a standard way of resolving (as a reverse lookup) of current procedure name, line and method ?
> I've fou... Greg Shah

05:10 AM Feature #3853 (WIP): implement LOG-MANAGER runtime

Greg
Is there a standard way of resolving (as a reverse lookup) of current procedure name, line and method ?
I've f... Tomasz Domin

08:54 AM Bug #10567 (Test): same buffer can be used as argument multiple times

Alexandru Lungu

08:53 AM Bug #10567: same buffer can be used as argument multiple times

ChUI regression testing passed, but I have forgot that I had included this into #10729 testing process.
Branch *10... Teodor Gorghe

08:43 AM Bug #10567 (Merge Pending): same buffer can be used as argument multiple times

Feel free to skip ChUI regression tests and pair this branch testing with another task that requires ChUI regression ... Alexandru Lungu

08:41 AM Bug #10567: same buffer can be used as argument multiple times

All regression tests were done, but not for ChUI regression tests.
I am starting the tests right now and I think tom... Teodor Gorghe

08:40 AM Bug #10567: same buffer can be used as argument multiple times

Teodor, is 10567a ready for trunk? Alexandru Lungu

11/17/2025

09:31 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality

Dănuț Filimon wrote:
> I see that *6065a* is based on trunk/15757, but I've been testing with trunk/16277. I'll swit... Dănuț Filimon

07:33 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality

I see that *6065a* is based on trunk/15757, but I've been testing with trunk/16277. I'll switch the branch and check ... Dănuț Filimon

07:31 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality

The issue with the .w file not being included seems to be related to convertSourceNameToAstNames():... Dănuț Filimon

07:12 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality

If an @.htm@ or @.html@ file is changed, then we must run the embedded 4GL preprocessor on that file. Running the E4... Greg Shah

07:10 AM Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality

After ./abl/goldencodewebspeed_htm.w is generated and incremental conversion is started, it will also be picked up if... Dănuț Filimon

11/14/2025

09:08 AM Bug #10391: Comparisons methods not returning the correct result in poly cases

Paul Bodale wrote:
> I checked out the branch locally just to be sure. The only thing I understand from #10391-32 is... Eugenie Lyzenko

09:01 AM Bug #10391: Comparisons methods not returning the correct result in poly cases

I checked out the branch locally just to be sure. The only thing I understand from #10391-32 is that the branch was m... Paul Bodale

09:00 AM Bug #10391: Comparisons methods not returning the correct result in poly cases

Paul Bodale wrote:
> I don't think I created a @10800a@ branch. Didn't know about it until now
OK, never mind. I ... Eugenie Lyzenko

08:46 AM Bug #10391: Comparisons methods not returning the correct result in poly cases

Paul Bodale wrote:
> I don't think I created a @10800a@ branch. Didn't know about it until now... Eugenie Lyzenko

08:45 AM Bug #10391: Comparisons methods not returning the correct result in poly cases

I don't think I created a @10800a@ branch. Didn't know about it until now Paul Bodale

08:39 AM Bug #10391: Comparisons methods not returning the correct result in poly cases

Paul,
I have a question for branch repos on @devsrv01@.
Did you create @10800a@ branch? What was the purpose?
... Eugenie Lyzenko

05:01 AM Bug #10597 (Test): [Regression] extent field in form fails conversion

Branch 10597a was merged into trunk as rev. 16275 and archived. Stefanel Pezamosca

04:49 AM Bug #10597 (Merge Pending): [Regression] extent field in form fails conversion

Please merge 10597a to trunk now. Alexandru Lungu

03:25 AM Bug #10597: [Regression] extent field in form fails conversion

Can this be merged to trunk? Stefanel Pezamosca

11/13/2025

08:02 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

> The main explanation I think is because the invokedynamic JVM instruction relies on the JVM implementation, where t... Alexandru Lungu

11/10/2025

11:35 AM Bug #10841: model table name is used in error messages for a 'like' temp-table definition

So the rule I think is this, for the unique validation 'already exists with' message:
* for temp-tables, no field na... Constantin Asofiei

11:01 AM Bug #10841: model table name is used in error messages for a 'like' temp-table definition

For a temp-table defined as:... Constantin Asofiei

10:53 AM Bug #10841 (Closed): model table name is used in error messages for a 'like' temp-table definition

Constantin Asofiei

11/07/2025

12:37 AM Feature #3853: implement LOG-MANAGER runtime

> In order to pass one of tests I had to make FILE-INFO:FILE-SIZE to reread file size.
> Was it static on purpose (... Greg Shah

11/06/2025

03:43 PM Feature #3853: implement LOG-MANAGER runtime

Greg
In order to pass one of tests I had to make FILE-INFO:FILE-SIZE to reread file size.
Was it static on purpos... Tomasz Domin

01:28 PM Bug #10831 (Review): Incorrect handling of UNDO, RETURN ERROR <error> causes IllegalStateExceptio...

Please review. Ovidiu Maxiniuc

01:27 PM Bug #10831 (WIP): Incorrect handling of UNDO, RETURN ERROR <error> causes IllegalStateException t...

Task branch 10831a was created and the fix was committed. With r16262 the double rollback is gone and the exception i... Ovidiu Maxiniuc

01:14 PM Bug #10831: Incorrect handling of UNDO, RETURN ERROR <error> causes IllegalStateException to be t...

As noted in the title, there is a flaw in handling of statements @UNDO, RETURN ERROR <error>@ if this occurs in a @CA... Ovidiu Maxiniuc

12:53 PM Bug #10831 (Closed): Incorrect handling of UNDO, RETURN ERROR <error> causes IllegalStateExceptio...

Ovidiu Maxiniuc

08:26 AM Bug #10567 (Internal Test): same buffer can be used as argument multiple times

I am OK with the changes in 10567a. they are cleaner than my attempt in #10818 in fact :)
Alexandru Lungu

07:54 AM Bug #9906 (Closed): Incorrect date parsing in FWD DATE(CHARACTER) implementation

Greg Shah

06:25 AM Bug #9906: Incorrect date parsing in FWD DATE(CHARACTER) implementation

Greg Shah wrote:
> Vladimir: Please post the commit message here and we can close the task.
The branch 9906b was ... Vladimir Tsichevski

04:06 AM Bug #9906 (Merge Pending): Incorrect date parsing in FWD DATE(CHARACTER) implementation

Greg Shah

04:06 AM Bug #9906: Incorrect date parsing in FWD DATE(CHARACTER) implementation

Vladimir: Please post the commit message here and we can close the task. Greg Shah

03:51 AM Bug #9906: Incorrect date parsing in FWD DATE(CHARACTER) implementation

> There is no active 9906b branch to review.
I approved merge in #7143-1731 after reviewing in #7143. I wasn't awa... Alexandru Lungu

03:38 AM Bug #9906 (Review): Incorrect date parsing in FWD DATE(CHARACTER) implementation

Hynek Cihlar

02:53 AM Bug #9906: Incorrect date parsing in FWD DATE(CHARACTER) implementation

There is no active 9906b branch to review. Greg Shah

11/05/2025

04:27 PM Feature #3853: implement LOG-MANAGER runtime

Another OE 11.7 difference:
You can set @LOG-MANAGER:LOGGING-LEVEL@ only to a value greater than it was already set,... Tomasz Domin

02:14 AM Feature #3853: implement LOG-MANAGER runtime

Greg Shah wrote:
> It means that any version specific code should be protected. If there is existing code that work... Tomasz Domin

02:40 AM Bug #9906: Incorrect date parsing in FWD DATE(CHARACTER) implementation

Hynek, please review. Could 9906b rev. 16259. be merged into the trunk? Sergey Ivanovskiy