Project

General

Profile

Activity

From 12/28/2012 to 01/26/2013

01/26/2013

05:50 PM Feature #1947: add conversion support for database methods
Two questions.
1) Methods
FIND-FIRST (predicate-expression[, lockmode[, wait-mode] ])
FIND-LAST (predicate-e...
Vadim Nebogatov
02:03 AM Feature #1974: add conversion support for (non-dynamic) database attributes
See the parent issue for all instructions and updates. This issue only exists to separate the conversion development ... Eric Faulhaber
01:54 AM Feature #1974 (Closed): add conversion support for (non-dynamic) database attributes
Eric Faulhaber
01:54 AM Feature #1975 (Closed): add runtime support for (non-dynamic) database attributes
Eric Faulhaber
01:53 AM Feature #1668: add support for additional (non-dynamic) database attributes
The following is the full list of attributes (including database and non-database) which need to be supported for our... Eric Faulhaber

01/25/2013

02:18 PM Feature #1947: add conversion support for database methods
After I went through #17 everything started work.
Examples of converted code:...
Vadim Nebogatov
02:12 PM Feature #1967 (Closed): rework DMO class/interface hierarchy
Update has passed regression testing; committed to bzr (rev 10154). Eric Faulhaber
06:47 AM Feature #1955 (WIP): add conversion support for CREATE-TEMP-TABLE statement
Ovidiu Maxiniuc

01/24/2013

05:51 PM Feature #1947: add conversion support for database methods
... Greg Shah
05:48 PM Feature #1947: add conversion support for database methods
Yes, I missed some parts of #17 and only added int/integer parameters combinations Vadim Nebogatov
05:27 PM Feature #1947: add conversion support for database methods
Regarding why the EXCLUSIVE-LOCK parameter does not emit: have you made the parser changes Greg mentions above (in e... Eric Faulhaber
04:36 PM Feature #1947: add conversion support for database methods
... Vadim Nebogatov

01/23/2013

05:31 PM Feature #1947: add conversion support for database methods
Updated variant for new model (with using Buffer interface) without LOCKs and NO-WAIT support so far.
methods_att...
Vadim Nebogatov
05:18 PM Feature #1967: rework DMO class/interface hierarchy
Yes, I should have removed the commented methods once I got everything compiling. I didn't notice this when I built ... Eric Faulhaber
04:49 PM Feature #1967: rework DMO class/interface hierarchy
Methods RecordBuffer.copy() and RecordBuffer.openScope() are not deprecated, but compiler makes warnings... Vadim Nebogatov
05:48 AM Feature #1967: rework DMO class/interface hierarchy
Here is a drop of the code which is about to undergo regression testing. Note that additional, customer-specific file... Eric Faulhaber
02:55 PM Feature #1949: add conversion support for database triggers
OK, go ahead with this approach. Greg Shah
02:14 PM Feature #1949: add conversion support for database triggers
> The primary advantage is that the runtime would be able to call the proper methods without any use of reflection.
...
Stanislav Lomany
01:42 PM Feature #1949: add conversion support for database triggers
... Greg Shah
12:57 PM Feature #1949: add conversion support for database triggers
> I'm not sure we need an interface, but I was thinking it might have an empty implementation for each of the trigger... Stanislav Lomany
11:52 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Added 1st implementation of conversion for dynamic creation of @TEMP-TABLE@ and a few related methods and attributes. Ovidiu Maxiniuc

01/22/2013

05:43 PM Feature #1947: add conversion support for database methods
Eric Faulhaber wrote:... Vadim Nebogatov
02:00 PM Feature #1947: add conversion support for database methods
Eric Faulhaber wrote:... Vadim Nebogatov
12:14 PM Feature #1947: add conversion support for database methods
Greg Shah wrote:
> Also, I am pretty sure Eric will not want you to use Object as the first parameter type. But I w...
Eric Faulhaber
12:00 PM Feature #1947: add conversion support for database methods
Interesting finding! We have seen some other cases where Progress provides some 4GL options as a compiler constant. ... Greg Shah
08:58 AM Feature #1947: add conversion support for database methods
... Vadim Nebogatov
08:33 AM Feature #1947: add conversion support for database methods
... Vadim Nebogatov
04:42 PM Feature #1949: add conversion support for database triggers
... Greg Shah
03:49 PM Feature #1949: add conversion support for database triggers
>registerDatabaseTrigger(DatabaseTriggerType.WRITE,
> TriggerBlock0.class,
> ...
Stanislav Lomany
03:40 PM Feature #1949: add conversion support for database triggers

> Why are we passing the name "book2" as a string to registerTrigger, instead of as a Book.Buf proxy instance? Als...
Stanislav Lomany
11:15 AM Feature #1949: add conversion support for database triggers
registerTrigger() is in the LogicalTerminal, which is not something that should be involved with database triggers. ... Greg Shah
10:13 AM Feature #1949: add conversion support for database triggers
Stanislav Lomany wrote:
> Is this conversion correct (part 2)?
Why are we passing the name "book2" as a string to...
Eric Faulhaber
08:23 AM Feature #1949: add conversion support for database triggers
Is this conversion correct (part 2)?
5.
The main decision about session triggers is how we going to pass target b...
Stanislav Lomany
07:20 AM Feature #1949: add conversion support for database triggers
Eric Faulhaber wrote:
> Hmm... you're right. Greg and I can't seem to remember why this is, but leave it the way yo...
Stanislav Lomany
12:32 PM Feature #1653: add conversion and runtime support for dynamically prepared queries
Oops, I forgot to add the new query_definitions.rules file. Ovidiu Maxiniuc

01/21/2013

06:40 PM Feature #1949: add conversion support for database triggers
Hmm... you're right. Greg and I can't seem to remember why this is, but leave it the way you initially proposed for ... Eric Faulhaber
05:59 PM Feature #1949: add conversion support for database triggers
> In cases 1 and 2, the openScope/openReadOnlyScope calls and the assignments to the external procedure's Buf* instan... Stanislav Lomany
05:38 PM Feature #1949: add conversion support for database triggers
Stanislav Lomany wrote:
> Is this conversion correct (part 1)?
In cases 1 and 2, the openScope/openReadOnlyScope ...
Eric Faulhaber
05:26 PM Feature #1949: add conversion support for database triggers
Is this conversion correct (part 1)?
1. ...
Stanislav Lomany
04:09 PM Feature #1949: add conversion support for database triggers
> Why don't we go with dmo.openReadOnlyScope()? I can add this to the new Buffer interface and BufferImpl class (see... Stanislav Lomany
03:57 PM Feature #1949: add conversion support for database triggers
Why don't we go with dmo.openReadOnlyScope()? I can add this to the new Buffer interface and BufferImpl class (see #... Eric Faulhaber
03:47 PM Feature #1949: add conversion support for database triggers
Eric, for the write trigger we need to have read-only buffer parameter which represents the old state of the buffer. ... Stanislav Lomany
05:24 PM Feature #1967: rework DMO class/interface hierarchy
Updated the Buffer interface to accommodate the following, additional changes:... Eric Faulhaber
10:01 AM Feature #1967: rework DMO class/interface hierarchy
Stanislav Lomany wrote:
> Will buffer parameters change to {DMO interface}.Buf?
Yes, any access to a DMO from bus...
Eric Faulhaber
05:19 AM Feature #1967: rework DMO class/interface hierarchy
Will buffer parameters change to {DMO interface}.Buf?... Stanislav Lomany
12:19 AM Feature #1967 (WIP): rework DMO class/interface hierarchy
Eric Faulhaber
12:18 AM Feature #1967: rework DMO class/interface hierarchy
The idea is to support buffer handles more naturally and to support converted, buffer-related methods, attributes, an... Eric Faulhaber
11:30 PM Feature #1967 (Closed): rework DMO class/interface hierarchy
Eric Faulhaber
04:25 PM Feature #1947: add conversion support for database methods
Latest variant
P2JQuery.java:...
Vadim Nebogatov
01:04 PM Feature #1947: add conversion support for database methods
Agreed (w/ entry 12). Eric Faulhaber
01:00 PM Feature #1947: add conversion support for database methods
Eric Faulhaber wrote:... Vadim Nebogatov
12:18 PM Feature #1954 (WIP): add conversion support for CREATE QUERY statement
Ovidiu Maxiniuc
12:18 PM Feature #1653 (WIP): add conversion and runtime support for dynamically prepared queries
I have wrote more than needed code. As the creation of the query is dynamic, one cannot do much with the created quer... Ovidiu Maxiniuc

01/20/2013

10:27 AM Feature #1947: add conversion support for database methods
To be clear, the problem with 4GL methods that take "parameters" like SHARE-LOCK or NO-WAIT, is that these things are... Greg Shah
12:52 AM Feature #1947: add conversion support for database methods
Vadim Nebogatov wrote:
> Will P2J support conversion of methods with variable parameters amount?
For methods whic...
Eric Faulhaber
12:23 AM Feature #1947: add conversion support for database methods
Vadim Nebogatov wrote:
> All handle-based methods return LOGICAL. I think statement based analogues throw errors on ...
Eric Faulhaber

01/19/2013

03:58 PM Feature #1947: add conversion support for database methods
Updated latest variant above Vadim Nebogatov

01/18/2013

06:32 PM Feature #1947: add conversion support for database methods
... Vadim Nebogatov
06:20 PM Feature #1947: add conversion support for database methods
... Vadim Nebogatov
03:16 PM Feature #1947: add conversion support for database methods
... Vadim Nebogatov
07:32 PM Feature #1947: add conversion support for database methods
RecordBuffer is something of an unusual class, in that instances of it are never exposed to converted business logic.... Eric Faulhaber
01:58 PM Feature #1949: add conversion support for database triggers
In regard to the TRIGGER PROCEDURE conversion:... Greg Shah
12:30 PM Feature #1949: add conversion support for database triggers
About the ways of conversion:
1. The following statements:...
Stanislav Lomany
04:19 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
If the 4GL code specifies directly the table-name like:
@CREATE BUFFER hBuff FOR TABLE "customer".@
then, P2J conv...
Ovidiu Maxiniuc
09:11 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
Code review 20130117b:
I don't think all the extra overloading of the @RecordBuffer.createBufferForTable@ method t...
Eric Faulhaber

01/17/2013

06:37 PM Feature #1947: add conversion support for database methods
... Vadim Nebogatov
09:38 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
After cleanup of source I observed that the code is much simple that I first implemented.
I choose to create a sep...
Ovidiu Maxiniuc
09:29 AM Feature #1953 (Review): add conversion support for CREATE BUFFER statement
Ovidiu Maxiniuc

01/16/2013

06:56 AM Feature #1949: add conversion support for database triggers
In regard to the TRIGGER PROCEDURE conversion, it seems like the external procedure can be converted to something wit... Greg Shah
09:21 PM Feature #1949: add conversion support for database triggers
We need to convert the session triggers (like your ON example above), but we also need support for schema triggers (i... Eric Faulhaber
08:34 PM Feature #1947: add conversion support for database methods
Vadim Nebogatov wrote:
> Please check if I am on the correct way.
>
> I have started implementation for BUFFER-...
Eric Faulhaber

01/15/2013

04:53 PM Feature #1949 (WIP): add conversion support for database triggers
Eric, am I correct that I only need to cover session triggers, i.e.... Stanislav Lomany
12:44 PM Feature #1953 (WIP): add conversion support for CREATE BUFFER statement
Ovidiu Maxiniuc
07:48 PM Feature #1953: add conversion support for CREATE BUFFER statement
This issue is meant to track conversion support only; runtime implementation should be deferred as much as possible,... Eric Faulhaber
07:45 PM Feature #1953 (Closed): add conversion support for CREATE BUFFER statement
Eric Faulhaber
07:52 PM Feature #1955: add conversion support for CREATE-TEMP-TABLE statement
This issue is meant to track conversion support only; runtime implementation should be deferred as much as possible,... Eric Faulhaber
07:52 PM Feature #1955 (Closed): add conversion support for CREATE-TEMP-TABLE statement
Eric Faulhaber
07:50 PM Feature #1954: add conversion support for CREATE QUERY statement
This issue is meant to track conversion support only; runtime implementation should be deferred as much as possible,... Eric Faulhaber
07:50 PM Feature #1954 (Closed): add conversion support for CREATE QUERY statement
Eric Faulhaber

01/14/2013

06:16 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Changed sources are attached just for backup Vadim Nebogatov
04:47 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
I have attached tests passed for mandatory and not mandatory fields and their combinations Vadim Nebogatov
05:10 PM Feature #1949: add conversion support for database triggers
We need to support conversion of trigger procedures and ON statements for the following database triggers:
* DELET...
Eric Faulhaber
04:45 PM Feature #1949 (Closed): add conversion support for database triggers
Eric Faulhaber
04:06 PM Feature #1910 (Closed): add schema conversion support for sequences
Eric Faulhaber
11:56 AM Feature #1910: add schema conversion support for sequences
I just updated a fresh copy from bzr repository and checked all modified files. There are no conflicts.
I am going ...
Ovidiu Maxiniuc
11:36 AM Feature #1910: add schema conversion support for sequences
No code review comments. We put this update through regression testing and it has passed. Please re-confirm these c... Eric Faulhaber
10:52 AM Feature #1926: create an en_GB@p2j_basic locale definition
The customer has confirmed that they normally use 8859-1 for the database but 8859-15 for the 4GL environment (code e... Greg Shah
09:56 AM Feature #1580: upgrade Hibernate to latest level
About "Session factory scoping warning": now the XmlDocuments produced by ORMHandler are stored and re-used for datab... Stanislav Lomany
03:56 AM Feature #1947: add conversion support for database methods
The following are database, handle-based methods that we need to support (in priority order):
* BUFFER-FIELD (KW_BUF...
Eric Faulhaber
03:42 AM Feature #1947 (Closed): add conversion support for database methods
Eric Faulhaber

01/10/2013

06:08 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
Created sync testing environments for using persistent tables with mandatory/not-mandatory fields on 4GL and P2J: cre... Vadim Nebogatov
09:26 AM Feature #1583: add conversion and runtime support for the INSERT language statement
Replacement of INSERT by CREATE+UPDATE moved to new ruleset file. The intermediary files generated differ just by pee... Ovidiu Maxiniuc
08:06 AM Feature #1910: add schema conversion support for sequences
Apparently I omitted to put @com.goldencode.p2j.persist.pl.Operators.java@ file on the update package.
I also re-rev...
Ovidiu Maxiniuc
01:28 AM Feature #1910: add schema conversion support for sequences
Code review 20130109a:
Good work overall! However, I did have one serious problem; see below.
I made some minor ch...
Eric Faulhaber

01/09/2013

09:05 AM Feature #1910 (Review): add schema conversion support for sequences
The sequences are now imported directly into psql using generated ddl from conversion step and initialized at the imp... Ovidiu Maxiniuc

01/08/2013

01:29 PM Feature #1580: upgrade Hibernate to latest level
About "Error closing Hibernate session": session factory is closed in the context which holds the last session connec... Stanislav Lomany
12:19 PM Feature #1933: add conversion support for certain metadata constructs
This task is just about converting these constructs and stubbing out any new runtime methods needed, so that the conv... Eric Faulhaber
12:15 PM Feature #1933 (Closed): add conversion support for certain metadata constructs
Eric Faulhaber

01/04/2013

02:07 PM Feature #1910: add schema conversion support for sequences
Ovidiu Maxiniuc wrote:
> Does-it make sense to create another file or should I just extend the @dmo-index@'s dtd @sc...
Eric Faulhaber
12:26 PM Feature #1910: add schema conversion support for sequences
> OK, I understand that there is some configuration that needs to be migrated, when the backing database does not sup... Ovidiu Maxiniuc
10:40 AM Feature #1910: add schema conversion support for sequences
OK, I understand that there is some configuration that needs to be migrated, when the backing database does not suppo... Greg Shah
10:15 AM Feature #1910: add schema conversion support for sequences
When doing the (one-time) import there is no special care for sequences, they are imported with the actual value. How... Ovidiu Maxiniuc
09:36 AM Feature #1910: add schema conversion support for sequences
I thought that the "directory-backed crossed-the-sequence-boundary flag" approach was only needed to remember the fac... Greg Shah
01:44 PM Feature #1651: add support for dynamic database features
We need to determine whether dynamic database features are scope-agnostic in terms of resolving database references; ... Eric Faulhaber

01/03/2013

07:23 PM Feature #1910: add schema conversion support for sequences
Ovidiu Maxiniuc wrote:
> ...
> I have some issues / questions about all these modification:
> 1. I did not have ac...
Eric Faulhaber

01/02/2013

01:10 AM Feature #1910: add schema conversion support for sequences
Sequence conversion and import for PostgreSQL seems to work well with some minor changes I've made. I need to merge ... Eric Faulhaber
01:08 AM Feature #1926 (Hold): create an en_GB@p2j_basic locale definition
Eric Faulhaber

12/31/2012

08:15 AM Feature #1580: upgrade Hibernate to latest level
1. About NPE in suggestNextVendorNumber: strange, but if we use a PreparedStatement which returns a ResultSet in do(R... Stanislav Lomany

12/28/2012

11:58 AM Feature #1910: add schema conversion support for sequences
This note is somewhere at the border between sequence conversion and runtime.
I tried to add the H2 database support...
Ovidiu Maxiniuc
09:30 AM Feature #1580: upgrade Hibernate to latest level
1.
> Please be careful in making any changes to code which initializes collections; I originally tried to make the ...
Stanislav Lomany
 

Also available in: Atom