Activity
From 01/09/2013 to 02/07/2013
02/07/2013
- 06:06 PM Feature #1947: add conversion support for database methods
- Code review 20130207a:
This version of the update still had a few issues, but it was close enough that I just made... - 01:28 PM Feature #1947: add conversion support for database methods
- Two updates are attached:
1) vmn_upd20130207a.zip - support database methods and attributes
2) vmn_upd20130207a_t... - 01:26 PM Feature #1947: add conversion support for database methods
- ...
- 10:26 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Ovidiu Maxiniuc wrote:
> Regarding the class that implements @DynamicTempTable@. At moment of naming it, it did make... - 10:05 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- I have moved the @getField()@ to Buffer interface and renamed it to simply @field()@ so there would be no collisions ...
02/06/2013
- 03:00 PM Feature #1947: add conversion support for database methods
- Code review 20130205a:
* It seems that you must have changed handle.java, but it was not included in the update.
... - 12:02 PM Feature #1947: add conversion support for database methods
- Two updates are attached:
1) vmn_upd20130205a.zip - support database methods and attributes
2) vmn_upd20130205a_t...
02/05/2013
- 05:27 PM Feature #1586: add quick and dirty support for word indexes using LIKE operator
- For the current project, the use of CONTAINS is very consistent. The AST generally looks like:...
- 01:17 PM Feature #1586 (WIP): add quick and dirty support for word indexes using LIKE operator
- I learned that this operator is a little strange, only works on whole words (btw, the field on which it is applied mu...
- 01:18 PM Feature #1947: add conversion support for database methods
- On 02/01/2013 02:49 PM, Vadim wrote:...
02/01/2013
- 12:39 PM Feature #1668: add support for additional (non-dynamic) database attributes
- I have merged all my changes form @CREATE BUFFER/QUERY/TEMP-TABLE@ along with other methods/attributes and functions ...
- 02:20 AM Feature #1668: add support for additional (non-dynamic) database attributes
- Attached table with information about supported attributes
- 12:31 PM Feature #1653: add conversion and runtime support for dynamically prepared queries
- > Also regarding 20130129c: you mentioned a DELETE OBJECT conversion above, but I did not see this in the code. Did...
- 12:13 PM Feature #1653: add conversion and runtime support for dynamically prepared queries
- Also regarding 20130129c: you mentioned a DELETE OBJECT conversion above, but I did not see this in the code. Did I...
- 11:51 AM Feature #1653: add conversion and runtime support for dynamically prepared queries
- Code review 20130129c:
I too am concerned that P2JQuery and AbstractQuery may not be the correct targets for all o... - 11:58 PM Feature #1947: add conversion support for database methods
- Please merge all of your code in these updates (primarily the code update) with the latest code in bzr and re-submit ...
- 11:36 PM Feature #1581: add conversion and runtime support for certain metadata constructs
- The approach to support conversion of business logic which uses metadata is to treat these references just like any o...
- 11:21 PM Feature #1933 (WIP): add conversion support for certain metadata constructs
- 11:09 PM Feature #1583 (Closed): add conversion and runtime support for the INSERT language statement
01/31/2013
- 05:11 PM Feature #1947: add conversion support for database methods
- Attached table with information about supported attributes
- 03:07 PM Feature #1947: add conversion support for database methods
- Two updates are attached:...
- 02:35 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Code review 20130129b:
I see some problems with the DynamicTempTable interface. I believe all of the @getXXX@ metho... - 11:35 AM Feature #1668: add support for additional (non-dynamic) database attributes
- Vadim Nebogatov wrote:
> Support for EXTENT attribute should be implemented in FieldReference class. Is it correct?
... - 09:43 AM Feature #1668: add support for additional (non-dynamic) database attributes
- I got down to "remote" attribute, but last for the 5 of them are not finished.
For some of then I needed some help f... - 05:21 AM Feature #1668: add support for additional (non-dynamic) database attributes
- Support for EXTENT attribute should be implemented in FieldReference class. Is it correct?...
- 11:00 AM Feature #1586: add quick and dirty support for word indexes using LIKE operator
- This issue isn't really about word indexes per se, but it is a quick and dirty precursor to true word index support, ...
01/30/2013
- 06:09 PM Feature #1668: add support for additional (non-dynamic) database attributes
- Vadim Nebogatov wrote:
> 3) What if we have both method (with no parameters) and attribute with equal names and we w... - 04:34 PM Feature #1668: add support for additional (non-dynamic) database attributes
- Vadim Nebogatov wrote:
> 2) Query handle based INDEX-INFORMATION Attribute. Why it is called as attribute, not metho... - 04:21 PM Feature #1668: add support for additional (non-dynamic) database attributes
- Vadim Nebogatov wrote:
> 1) Conversion result of
>
> hBuffer:AVAILABLE.
> hBuffer:AVAILABLE().
>
> is the same... - 11:21 AM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
- After review, I added @currentChanged@ and @_currentChanged@ to the @Buffer@ interface, and removed the static versio...
- 06:44 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
- Changed implementation to take advantage of new handle implementation.
Added method/attribute conversion support for...
01/29/2013
- 02:39 PM Feature #1668: add support for additional (non-dynamic) database attributes
- Several questions:...
- 11:59 AM Feature #1653: add conversion and runtime support for dynamically prepared queries
- Changed code to take advantage of new handle implementation.
In fact some support was already there, written by Cons... - 10:55 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Changed implementation to take advantage of new handle implementation.
I created a new interface (@DynamicTempTable@... - 08:28 AM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
- I attached the code. I merged it with latest sources from bzr as it was a couple of months old.
The conversion runs ... - 02:26 AM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
- Ovidiu, do you have any code in process that you have not attached to this issue? We at least need the conversion ch...
- 09:31 PM Feature #1967: rework DMO class/interface hierarchy
- Note this fix has not yet been regression tested. Though I couldn't find any unanticipated conversion differences in...
01/28/2013
- 03:04 PM Feature #1947: add conversion support for database methods
- Eric Faulhaber wrote: ...
- 10:11 AM Feature #1947: add conversion support for database methods
- Vadim Nebogatov wrote:
> Two questions.
>
> 1) Methods
>
> FIND-FIRST (predicate-expression[, lockmode[, wai... - 02:24 PM Feature #1967: rework DMO class/interface hierarchy
- Stas, Constantin, thanks for letting me know about this. I have an update which fixes this for me locally, but it ne...
- 04:02 AM Feature #1967: rework DMO class/interface hierarchy
- I confirm for temp-tables too, please check the buffer_test2a.p and buffer_test2b.p (they are in bazaar).
- 03:42 AM Feature #1967: rework DMO class/interface hierarchy
- Eric, please be aware that @define parameter buffer@ is not converted properly:...
- 01:11 PM Feature #1668: add support for additional (non-dynamic) database attributes
- Ovidiu, thank you for organizing this list further. The reason most of the attributes you mentioned are not in the a...
- 12:07 PM Feature #1668: add support for additional (non-dynamic) database attributes
- I took the list of attributes and I used the OpenEdge Reference to compile some details for them. You can group the a...
01/26/2013
- 05:50 PM Feature #1947: add conversion support for database methods
- Two questions.
1) Methods
FIND-FIRST (predicate-expression[, lockmode[, wait-mode] ])
FIND-LAST (predicate-e... - 02:03 AM Feature #1974: add conversion support for (non-dynamic) database attributes
- See the parent issue for all instructions and updates. This issue only exists to separate the conversion development ...
- 01:54 AM Feature #1974 (Closed): add conversion support for (non-dynamic) database attributes
- 01:54 AM Feature #1975 (Closed): add runtime support for (non-dynamic) database attributes
- 01:53 AM Feature #1668: add support for additional (non-dynamic) database attributes
- The following is the full list of attributes (including database and non-database) which need to be supported for our...
01/25/2013
- 02:18 PM Feature #1947: add conversion support for database methods
- After I went through #17 everything started work.
Examples of converted code:... - 02:12 PM Feature #1967 (Closed): rework DMO class/interface hierarchy
- Update has passed regression testing; committed to bzr (rev 10154).
- 06:47 AM Feature #1955 (WIP): add conversion support for CREATE-TEMP-TABLE statement
01/24/2013
- 05:51 PM Feature #1947: add conversion support for database methods
- ...
- 05:48 PM Feature #1947: add conversion support for database methods
- Yes, I missed some parts of #17 and only added int/integer parameters combinations
- 05:27 PM Feature #1947: add conversion support for database methods
- Regarding why the EXCLUSIVE-LOCK parameter does not emit: have you made the parser changes Greg mentions above (in e...
- 04:36 PM Feature #1947: add conversion support for database methods
- ...
01/23/2013
- 05:31 PM Feature #1947: add conversion support for database methods
- Updated variant for new model (with using Buffer interface) without LOCKs and NO-WAIT support so far.
methods_att... - 05:18 PM Feature #1967: rework DMO class/interface hierarchy
- Yes, I should have removed the commented methods once I got everything compiling. I didn't notice this when I built ...
- 04:49 PM Feature #1967: rework DMO class/interface hierarchy
- Methods RecordBuffer.copy() and RecordBuffer.openScope() are not deprecated, but compiler makes warnings...
- 05:48 AM Feature #1967: rework DMO class/interface hierarchy
- Here is a drop of the code which is about to undergo regression testing. Note that additional, customer-specific file...
- 02:55 PM Feature #1949: add conversion support for database triggers
- OK, go ahead with this approach.
- 02:14 PM Feature #1949: add conversion support for database triggers
- > The primary advantage is that the runtime would be able to call the proper methods without any use of reflection.
... - 01:42 PM Feature #1949: add conversion support for database triggers
- ...
- 12:57 PM Feature #1949: add conversion support for database triggers
- > I'm not sure we need an interface, but I was thinking it might have an empty implementation for each of the trigger...
- 11:52 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Added 1st implementation of conversion for dynamic creation of @TEMP-TABLE@ and a few related methods and attributes.
01/22/2013
- 05:43 PM Feature #1947: add conversion support for database methods
- Eric Faulhaber wrote:...
- 02:00 PM Feature #1947: add conversion support for database methods
- Eric Faulhaber wrote:...
- 12:14 PM Feature #1947: add conversion support for database methods
- Greg Shah wrote:
> Also, I am pretty sure Eric will not want you to use Object as the first parameter type. But I w... - 12:00 PM Feature #1947: add conversion support for database methods
- Interesting finding! We have seen some other cases where Progress provides some 4GL options as a compiler constant. ...
- 08:58 AM Feature #1947: add conversion support for database methods
- ...
- 08:33 AM Feature #1947: add conversion support for database methods
- ...
- 04:42 PM Feature #1949: add conversion support for database triggers
- ...
- 03:49 PM Feature #1949: add conversion support for database triggers
- >registerDatabaseTrigger(DatabaseTriggerType.WRITE,
> TriggerBlock0.class,
> ... - 03:40 PM Feature #1949: add conversion support for database triggers
> Why are we passing the name "book2" as a string to registerTrigger, instead of as a Book.Buf proxy instance? Als...- 11:15 AM Feature #1949: add conversion support for database triggers
- registerTrigger() is in the LogicalTerminal, which is not something that should be involved with database triggers. ...
- 10:13 AM Feature #1949: add conversion support for database triggers
- Stanislav Lomany wrote:
> Is this conversion correct (part 2)?
Why are we passing the name "book2" as a string to... - 08:23 AM Feature #1949: add conversion support for database triggers
- Is this conversion correct (part 2)?
5.
The main decision about session triggers is how we going to pass target b... - 07:20 AM Feature #1949: add conversion support for database triggers
- Eric Faulhaber wrote:
> Hmm... you're right. Greg and I can't seem to remember why this is, but leave it the way yo... - 12:32 PM Feature #1653: add conversion and runtime support for dynamically prepared queries
- Oops, I forgot to add the new query_definitions.rules file.
01/21/2013
- 06:40 PM Feature #1949: add conversion support for database triggers
- Hmm... you're right. Greg and I can't seem to remember why this is, but leave it the way you initially proposed for ...
- 05:59 PM Feature #1949: add conversion support for database triggers
- > In cases 1 and 2, the openScope/openReadOnlyScope calls and the assignments to the external procedure's Buf* instan...
- 05:38 PM Feature #1949: add conversion support for database triggers
- Stanislav Lomany wrote:
> Is this conversion correct (part 1)?
In cases 1 and 2, the openScope/openReadOnlyScope ... - 05:26 PM Feature #1949: add conversion support for database triggers
- Is this conversion correct (part 1)?
1. ... - 04:09 PM Feature #1949: add conversion support for database triggers
- > Why don't we go with dmo.openReadOnlyScope()? I can add this to the new Buffer interface and BufferImpl class (see...
- 03:57 PM Feature #1949: add conversion support for database triggers
- Why don't we go with dmo.openReadOnlyScope()? I can add this to the new Buffer interface and BufferImpl class (see #...
- 03:47 PM Feature #1949: add conversion support for database triggers
- Eric, for the write trigger we need to have read-only buffer parameter which represents the old state of the buffer. ...
- 05:24 PM Feature #1967: rework DMO class/interface hierarchy
- Updated the Buffer interface to accommodate the following, additional changes:...
- 10:01 AM Feature #1967: rework DMO class/interface hierarchy
- Stanislav Lomany wrote:
> Will buffer parameters change to {DMO interface}.Buf?
Yes, any access to a DMO from bus... - 05:19 AM Feature #1967: rework DMO class/interface hierarchy
- Will buffer parameters change to {DMO interface}.Buf?...
- 12:19 AM Feature #1967 (WIP): rework DMO class/interface hierarchy
- 12:18 AM Feature #1967: rework DMO class/interface hierarchy
- The idea is to support buffer handles more naturally and to support converted, buffer-related methods, attributes, an...
- 11:30 PM Feature #1967 (Closed): rework DMO class/interface hierarchy
- 04:25 PM Feature #1947: add conversion support for database methods
- Latest variant
P2JQuery.java:... - 01:04 PM Feature #1947: add conversion support for database methods
- Agreed (w/ entry 12).
- 01:00 PM Feature #1947: add conversion support for database methods
- Eric Faulhaber wrote:...
- 12:18 PM Feature #1954 (WIP): add conversion support for CREATE QUERY statement
- 12:18 PM Feature #1653 (WIP): add conversion and runtime support for dynamically prepared queries
- I have wrote more than needed code. As the creation of the query is dynamic, one cannot do much with the created quer...
01/20/2013
- 10:27 AM Feature #1947: add conversion support for database methods
- To be clear, the problem with 4GL methods that take "parameters" like SHARE-LOCK or NO-WAIT, is that these things are...
- 12:52 AM Feature #1947: add conversion support for database methods
- Vadim Nebogatov wrote:
> Will P2J support conversion of methods with variable parameters amount?
For methods whic... - 12:23 AM Feature #1947: add conversion support for database methods
- Vadim Nebogatov wrote:
> All handle-based methods return LOGICAL. I think statement based analogues throw errors on ...
01/19/2013
- 03:58 PM Feature #1947: add conversion support for database methods
- Updated latest variant above
01/18/2013
- 06:32 PM Feature #1947: add conversion support for database methods
- ...
- 06:20 PM Feature #1947: add conversion support for database methods
- ...
- 03:16 PM Feature #1947: add conversion support for database methods
- ...
- 07:32 PM Feature #1947: add conversion support for database methods
- RecordBuffer is something of an unusual class, in that instances of it are never exposed to converted business logic....
- 01:58 PM Feature #1949: add conversion support for database triggers
- In regard to the TRIGGER PROCEDURE conversion:...
- 12:30 PM Feature #1949: add conversion support for database triggers
- About the ways of conversion:
1. The following statements:... - 04:19 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
- If the 4GL code specifies directly the table-name like:
@CREATE BUFFER hBuff FOR TABLE "customer".@
then, P2J conv... - 09:11 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
- Code review 20130117b:
I don't think all the extra overloading of the @RecordBuffer.createBufferForTable@ method t...
01/17/2013
- 06:37 PM Feature #1947: add conversion support for database methods
- ...
- 09:38 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
- After cleanup of source I observed that the code is much simple that I first implemented.
I choose to create a sep... - 09:29 AM Feature #1953 (Review): add conversion support for CREATE BUFFER statement
01/16/2013
- 06:56 AM Feature #1949: add conversion support for database triggers
- In regard to the TRIGGER PROCEDURE conversion, it seems like the external procedure can be converted to something wit...
- 09:21 PM Feature #1949: add conversion support for database triggers
- We need to convert the session triggers (like your ON example above), but we also need support for schema triggers (i...
- 08:34 PM Feature #1947: add conversion support for database methods
- Vadim Nebogatov wrote:
> Please check if I am on the correct way.
>
> I have started implementation for BUFFER-...
01/15/2013
- 04:53 PM Feature #1949 (WIP): add conversion support for database triggers
- Eric, am I correct that I only need to cover session triggers, i.e....
- 12:44 PM Feature #1953 (WIP): add conversion support for CREATE BUFFER statement
- 07:48 PM Feature #1953: add conversion support for CREATE BUFFER statement
- This issue is meant to track conversion support only; runtime implementation should be deferred as much as possible,...
- 07:45 PM Feature #1953 (Closed): add conversion support for CREATE BUFFER statement
- 07:52 PM Feature #1955: add conversion support for CREATE-TEMP-TABLE statement
- This issue is meant to track conversion support only; runtime implementation should be deferred as much as possible,...
- 07:52 PM Feature #1955 (Closed): add conversion support for CREATE-TEMP-TABLE statement
- 07:50 PM Feature #1954: add conversion support for CREATE QUERY statement
- This issue is meant to track conversion support only; runtime implementation should be deferred as much as possible,...
- 07:50 PM Feature #1954 (Closed): add conversion support for CREATE QUERY statement
01/14/2013
- 06:16 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- Changed sources are attached just for backup
- 04:47 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- I have attached tests passed for mandatory and not mandatory fields and their combinations
- 05:10 PM Feature #1949: add conversion support for database triggers
- We need to support conversion of trigger procedures and ON statements for the following database triggers:
* DELET... - 04:45 PM Feature #1949 (Closed): add conversion support for database triggers
- 04:06 PM Feature #1910 (Closed): add schema conversion support for sequences
- 11:56 AM Feature #1910: add schema conversion support for sequences
- I just updated a fresh copy from bzr repository and checked all modified files. There are no conflicts.
I am going ... - 11:36 AM Feature #1910: add schema conversion support for sequences
- No code review comments. We put this update through regression testing and it has passed. Please re-confirm these c...
- 10:52 AM Feature #1926: create an en_GB@p2j_basic locale definition
- The customer has confirmed that they normally use 8859-1 for the database but 8859-15 for the 4GL environment (code e...
- 09:56 AM Feature #1580: upgrade Hibernate to latest level
- About "Session factory scoping warning": now the XmlDocuments produced by ORMHandler are stored and re-used for datab...
- 03:56 AM Feature #1947: add conversion support for database methods
- The following are database, handle-based methods that we need to support (in priority order):
* BUFFER-FIELD (KW_BUF... - 03:42 AM Feature #1947 (Closed): add conversion support for database methods
01/10/2013
- 06:08 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
- Created sync testing environments for using persistent tables with mandatory/not-mandatory fields on 4GL and P2J: cre...
- 09:26 AM Feature #1583: add conversion and runtime support for the INSERT language statement
- Replacement of INSERT by CREATE+UPDATE moved to new ruleset file. The intermediary files generated differ just by pee...
- 08:06 AM Feature #1910: add schema conversion support for sequences
- Apparently I omitted to put @com.goldencode.p2j.persist.pl.Operators.java@ file on the update package.
I also re-rev... - 01:28 AM Feature #1910: add schema conversion support for sequences
- Code review 20130109a:
Good work overall! However, I did have one serious problem; see below.
I made some minor ch...
01/09/2013
- 09:05 AM Feature #1910 (Review): add schema conversion support for sequences
- The sequences are now imported directly into psql using generated ddl from conversion step and initialized at the imp...
Also available in: Atom