FWD » Core Development » Database

02/24/2013

05:29 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...

A problem has occurred in the use of the ATTR_POLY BUFFER-VALUE (KW_BUF_VAL) as a parameter to an INTEGER() built-in ... Greg Shah

05:08 PM Feature #2045 (Closed): conversion support for a DELETE statement with a validation expression

Greg Shah

03:18 PM Feature #2045: conversion support for a DELETE statement with a validation expression

This is for time tracking and milestone association only. All history should be in the parent task #2044. Greg Shah

03:17 PM Feature #2045 (Closed): conversion support for a DELETE statement with a validation expression

Greg Shah

05:08 PM Feature #2044: implement support for a DELETE statement with a validation expression

It passed conversion testing and is committed to bzr as revision 10198. Greg Shah

04:08 PM Feature #2044: implement support for a DELETE statement with a validation expression

And now the update... Greg Shah

04:08 PM Feature #2044: implement support for a DELETE statement with a validation expression

I fixed the header and have re-attached the update. This is going into conversion regression testing now. Greg Shah

04:04 PM Feature #2044: implement support for a DELETE statement with a validation expression

Code review 20130224a:
Changes look OK to me. Note that database_access.rules needs a header entry for your changes. Eric Faulhaber

03:31 PM Feature #2044: implement support for a DELETE statement with a validation expression

Add support to the conversion and runtime for a DELETE statement with a validation expression. We already support DE... Greg Shah

03:17 PM Feature #2044 (Closed): implement support for a DELETE statement with a validation expression

Greg Shah

03:19 PM Feature #2046: runtime support for DELETE statement with a validation expression

This is for time tracking and milestone association only. All history should be in the parent task #2044. Greg Shah

03:19 PM Feature #2046 (Closed): runtime support for DELETE statement with a validation expression

Greg Shah

02/23/2013

04:39 PM Feature #2042: add conversion support for some embedded SQL features

Log history in parent issue. Eric Faulhaber

03:27 PM Feature #2042 (Closed): add conversion support for some embedded SQL features

Eric Faulhaber

04:39 PM Feature #2043: add runtime support for some embedded SQL features

Log history in parent issue. Eric Faulhaber

04:38 PM Feature #2043 (Closed): add runtime support for some embedded SQL features

Eric Faulhaber

11:11 AM Feature #1992: add support for double-colon (::) syntax

OK, please add a suitable task to the Base Language project and target it to milestone 7. Please put all the relevan... Greg Shah

10:55 AM Feature #1992: add support for double-colon (::) syntax

For milestone 4, I don't think there is anything we need to do about the *_POLY rvalues, all -will- can be in the run... Constantin Asofiei

10:48 AM Feature #1992: add support for double-colon (::) syntax

> Idea is, if we have the ATTR/METH_POLY in an expression or as a rvalue, then 4GL does some automatic conversion of ... Greg Shah

03:49 AM Feature #2000: add conversion support for table and table handle parameters

I'm sending the update in its current state: INPUT/OUTPUT parameters and APPEND option are not handled, createDynamic... Stanislav Lomany

03:00 AM Feature #2000: add conversion support for table and table handle parameters

Stanislav, OK now I understand what you mean. APPEND clause used with OUTPUT/INPUT-OUTPUT table at the caller affects... Constantin Asofiei

10:47 PM Feature #2000: add conversion support for table and table handle parameters

Stas: please provide an update for all the other functionality discussed above ASAP, even if you don't yet have an a... Eric Faulhaber

01:42 AM Feature #1660: add conversion and runtime support for OF keyword use in a CAN-FIND

Vadim Nebogatov wrote:
> ... but conversion of
> ... Eric Faulhaber

12:38 AM Feature #1660: add conversion and runtime support for OF keyword use in a CAN-FIND

I have created environment for tests and made some first conversion tests. Will try to make more tests on Monday.
... Vadim Nebogatov

02/22/2013

03:09 PM Feature #1992: add support for double-colon (::) syntax

All the specified cases work nicely.
> I'm not sure I understand what is being asked here. By definition, the ATTR... Constantin Asofiei

03:00 PM Feature #1992: add support for double-colon (::) syntax

> in assignment case, when the rvalue is a ATTR/METH_POLY, are there cases when the lvalue is of a different type tha... Greg Shah

02:57 PM Feature #1992: add support for double-colon (::) syntax

> are there any ATTR_POLY/METH_POLY used directly in a frame-related statement?
In regard to the FUNC_POLY/ATTR_PO... Greg Shah

01:55 PM Feature #2000: add conversion support for table and table handle parameters

> Please fill out this matrix:
When you specify APPEND in the calling procedure it logically applies to the table ... Stanislav Lomany

12:44 PM Feature #2000: add conversion support for table and table handle parameters

> Progress documentation tells that "You can only use the APPEND option for an INPUT parameter in the calling procedu... Greg Shah

12:36 PM Feature #2000: add conversion support for table and table handle parameters

Leave it as Temporary if you don't have a need to change it. Less runtime change. If we find we need it to be Buffe... Eric Faulhaber

12:34 PM Feature #2000: add conversion support for table and table handle parameters

So, Eric, do you prefer to leave Temporary or switch to Buffer?
Constantin, Greg, how do you prefer to pass APPEND... Stanislav Lomany

12:02 PM Feature #1974 (Closed): add conversion support for (non-dynamic) database attributes

Eric Faulhaber

11:15 PM Feature #1999 (Closed): add conversion support for builtin functions in a WHERE clause

I am closing this issue. While it brought up some interesting issues with our CAN-FIND support (which are now docume... Eric Faulhaber

10:28 PM Feature #1999: add conversion support for builtin functions in a WHERE clause

Vadim Nebogatov wrote:
> CAN-FIND(): SHARE-LOCK and NO-WAIT
> Yes, you are right, it is supported. I did not notic... Eric Faulhaber

08:30 PM Feature #1999: add conversion support for builtin functions in a WHERE clause

CAN-FIND(): SHARE-LOCK and NO-WAIT
Yes, you are right, it is supported. I did not notice that WHERE clause is gener... Vadim Nebogatov

07:19 PM Feature #1999: add conversion support for builtin functions in a WHERE clause

Vadim Nebogatov wrote:
> Briefly, all functions are supported with all options excepting
>
> 1) can-find() - work... Eric Faulhaber

11:09 PM Feature #2035: optimize conversion of CAN-FIND([FIRST|LAST] temp-table-record ... {SHARE-LOCK|EXC...

Currently, we convert this construct to use a WhereExpression, which does a client-side lock test for the found recor... Eric Faulhaber

11:02 PM Feature #2035 (New): optimize conversion of CAN-FIND([FIRST|LAST] temp-table-record ... {SHARE-LO...

Eric Faulhaber

10:59 PM Bug #2034: correct conversion of CAN-FIND({FIRST|LAST} ... {SHARE-LOCK|EXCLUSIVE_LOCK} [NO-WAIT])

Currently, we convert @CAN-FIND({FIRST|LAST} ...)@ with a lock the same as we do as if it doesn't have a lock; that ... Eric Faulhaber

10:54 PM Bug #2034 (New): correct conversion of CAN-FIND({FIRST|LAST} ... {SHARE-LOCK|EXCLUSIVE_LOCK} [NO-...

Eric Faulhaber

10:50 PM Feature #1660: add conversion and runtime support for OF keyword use in a CAN-FIND

The construct @record OF table@ in a 4gl query signifies a join between two tables (see "Record phrase" documentation... Eric Faulhaber

02/21/2013

03:36 PM Feature #2000: add conversion support for table and table handle parameters

> From my testing, I don't remember finding any parameter validation based on APPEND clause for temp-tables. This is ... Stanislav Lomany

03:20 PM Feature #2000: add conversion support for table and table handle parameters

> Maybe I misunderstood your original comment "@Temporary@ should be at least @Buffer@". I thought you meant the par... Stanislav Lomany

03:00 PM Feature #2000: add conversion support for table and table handle parameters

> > 2. We must make a decision on how APPEND parameter should be passed from the calling side.
> I think we need Con... Constantin Asofiei

02:35 PM Feature #2000: add conversion support for table and table handle parameters

Stanislav Lomany wrote:
> 1.
> > OK, in that case I think we can have Temporary extend Buffer.
> Hmm, it seems tha... Eric Faulhaber

02:16 PM Feature #2000: add conversion support for table and table handle parameters

1.
> OK, in that case I think we can have Temporary extend Buffer.
Hmm, it seems that it makes *.Buf classes obsole... Stanislav Lomany

07:04 PM Feature #2000: add conversion support for table and table handle parameters

> I'm pretty sure we already support the APPEND option, even though it's not used in Majic.
APPEND option can be s... Stanislav Lomany

01:41 PM Feature #1949 (Closed): add conversion support for database triggers

Eric Faulhaber

01:30 PM Feature #1949 (Review): add conversion support for database triggers

Stanislav Lomany

01:39 PM Feature #2024 (Closed): implement runtime support for database triggers

Eric Faulhaber

12:39 PM Feature #1999: add conversion support for builtin functions in a WHERE clause

Briefly, all functions are supported with all options excepting
1) can-find() - works in general, but at least FIR... Vadim Nebogatov

12:34 PM Feature #1999: add conversion support for builtin functions in a WHERE clause

Spreadsheet with testing results is attached.
Vadim Nebogatov

11:49 AM Feature #1668: add support for additional (non-dynamic) database attributes

The update is added for review at #2002. Constantin Asofiei

09:57 AM Feature #1992: add support for double-colon (::) syntax

Yes, this is the case for the @::@, too, as the final attribute in the rewritten form is buffer-value() attribute whe... Ovidiu Maxiniuc

09:51 AM Feature #1992: add support for double-colon (::) syntax

Greg, Ovidiu found an interesting case of BUFFER-VALUE usage (which applies to any ATTR_POLY or METH_POLY). If is use... Constantin Asofiei

02/20/2013

06:41 PM Feature #2000: add conversion support for table and table handle parameters

Stanislav Lomany wrote:
> Conversion for TABLE-HANDLE parameters should probably look in the similar way:
> [...]
... Eric Faulhaber

06:37 PM Feature #2000: add conversion support for table and table handle parameters

Stanislav Lomany wrote:
> Notes: 1. @Temporary@ should be at least @Buffer@
OK, in that case I think we can have ... Eric Faulhaber

05:56 PM Feature #2000: add conversion support for table and table handle parameters

Conversion for TABLE-HANDLE parameters should probably look in the similar way:... Stanislav Lomany

05:48 PM Feature #2000: add conversion support for table and table handle parameters

Heh, I didn't expected it to be converted...
It is converted to:... Stanislav Lomany

05:30 PM Feature #2000: add conversion support for table and table handle parameters

We already support it today, as far as I understand. Remember that you implemented all the deep copy of temp-tables ... Greg Shah

05:02 PM Feature #2000: add conversion support for table and table handle parameters

How do we convert this today? I vaguely remember dealing with this issue in the past, but I don't recall whether we ... Eric Faulhaber

03:55 PM Feature #2000: add conversion support for table and table handle parameters

About TABLE parameters.
We must pass to the called function information that identifies the table and information ... Stanislav Lomany

02:55 PM Feature #1949: add conversion support for database triggers

h2. TODO
This update doesn't handle the case if an UI trigger is 1. nested into DB trigger and 2. references DB tr... Stanislav Lomany

01:59 PM Feature #1992: add support for double-colon (::) syntax

Here is the implementation and some testcase.
I'm afraid this is not built on the last source-code, I will work on t... Ovidiu Maxiniuc

01:50 PM Feature #1992: add support for double-colon (::) syntax

> This could be one of the hardest things to implement. If the field name has changed during the conversion process i... Greg Shah

12:39 PM Feature #1992: add support for double-colon (::) syntax

Greg Shah wrote:
> Some thoughts:
>
> 1. Queries are explicitly mentioned as supported by @::@ in the 4GL languag... Ovidiu Maxiniuc

12:13 PM Feature #1992: add support for double-colon (::) syntax

Some thoughts:
1. Queries are explicitly mentioned as supported by @::@ in the 4GL language reference. It wouldn'... Greg Shah

11:19 AM Feature #1992: add support for double-colon (::) syntax

I already have an implementation here but, reading your previous note, made me turn back to OE installation.
The rea... Ovidiu Maxiniuc

10:28 AM Feature #1992: add support for double-colon (::) syntax

OK, so without chaining, the scope of this feature should be much smaller. As you suggested earlier, let's go with a... Eric Faulhaber

10:41 AM Feature #1999: add conversion support for builtin functions in a WHERE clause

Please provide a summary of which functions are supported by conversion already and which need work. We need to get ... Eric Faulhaber

09:29 AM Feature #1668: add support for additional (non-dynamic) database attributes

Constantin Asofiei wrote:
> > Yes, you are correct.
> Please provide an example of read-only private-data attribute... Vadim Nebogatov

09:09 AM Feature #1668: add support for additional (non-dynamic) database attributes

> Yes, you are correct.
Please provide an example of read-only private-data attribute. Constantin Asofiei

09:08 AM Feature #1668: add support for additional (non-dynamic) database attributes

Constantin Asofiei wrote:
> Also #2 - I see that PRIVATE-DATA has an unwrap case of WriteablePrivateData - are there... Vadim Nebogatov

02/19/2013

04:20 PM Feature #1668: add support for additional (non-dynamic) database attributes

CORRECTION: vmn_upd20130218b.zip is what we tested; it should be overlaid with vmn_upd20130219b.zip. Eric Faulhaber

04:18 PM Feature #1668: add support for additional (non-dynamic) database attributes

Constantin,
We had a regression in staging for a browse column widget handle which used to do @handle.unwrapWidget... Eric Faulhaber

01:25 PM Feature #1668: add support for additional (non-dynamic) database attributes

> Greg, Constantin: thoughts on how to properly support this? I added the WidthCharable (I know, lame name) interfa... Constantin Asofiei

01:10 PM Feature #1668: add support for additional (non-dynamic) database attributes

Update above is resubmitted Vadim Nebogatov

12:54 PM Feature #1668: add support for additional (non-dynamic) database attributes

Vadim Nebogatov wrote:
> IS-OPEN
> POSITION
> TABLE-HANDLE
> SESSION:FIRST-BUFFER
> (DBNAME was already supporte... Eric Faulhaber

12:36 PM Feature #1668: add support for additional (non-dynamic) database attributes

IS-OPEN
POSITION
TABLE-HANDLE
SESSION:FIRST-BUFFER
(DBNAME was already supported )
Update vmn_20130219a.zip co... Vadim Nebogatov

11:47 PM Feature #1668: add support for additional (non-dynamic) database attributes

Vadim Nebogatov wrote:
> I also created Sizeable/WriteableSizeable interfaces for attributes
>
> WIDTH-CHARS (KW_WID... Eric Faulhaber

01:23 PM Feature #1992: add support for double-colon (::) syntax

>First, as I wrote above in notes 4 and 7, the second operand can be almost anything (as it is the name of a field fr... Greg Shah

12:58 PM Feature #1992: add support for double-colon (::) syntax

First, as I wrote above in notes 4 and 7, the second operand can be almost anything (as it is the name of a field fro... Ovidiu Maxiniuc

12:20 PM Feature #2000: add conversion support for table and table handle parameters

Yes, that's correct. Eric Faulhaber

12:07 PM Feature #2000 (WIP): add conversion support for table and table handle parameters

Am I correct that the scope of this task is
DEFINE PARAMETER TABLE
DEFINE PARAMETER TABLE-HANDLE
TABLE functio... Stanislav Lomany

02/18/2013

06:24 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...

Based on a review of the recent reports, the following dynamic DB attributes are in use but are not yet implemented:
... Greg Shah

06:23 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...

Based on a review of the recent reports, the following dynamic DB method is in use but is not yet implemented:... Greg Shah

05:49 PM Feature #1668: add support for additional (non-dynamic) database attributes

There are some DB attributes still missing from the checked in code:
DBNAME
IS-OPEN
POSITION
TABLE-HANDLE
SESS... Greg Shah

12:24 PM Feature #1668: add support for additional (non-dynamic) database attributes

I have attached merge of previous update (vmn_upd20130218a) with current bzr
1) vmn_upd20130218a.zip - support res... Vadim Nebogatov

01:13 PM Feature #1992: add support for double-colon (::) syntax

Taking into consideration a dataset handle @dh@ that contains a buffer handle @bh@ (named @bh-name@) with a character... Ovidiu Maxiniuc

12:58 PM Feature #1999 (WIP): add conversion support for builtin functions in a WHERE clause

Vadim Nebogatov

02/17/2013

01:22 PM Feature #1668: add support for additional (non-dynamic) database attributes

I have attached update
1) vmn_upd20130217a.zip - support rest of database attributes
2) vmn_upd20130217a_test_ca... Vadim Nebogatov

02/16/2013

04:40 PM Feature #1992: add support for double-colon (::) syntax

Eric Faulhaber wrote:
> Ovidiu Maxiniuc wrote:
> > For the converted code I was thinking/investigated implementing ... Eric Faulhaber

09:57 PM Feature #1992: add support for double-colon (::) syntax

Ovidiu Maxiniuc wrote:
> For the converted code I was thinking/investigated implementing directly the @::@ as a membe... Eric Faulhaber

03:27 PM Feature #1949: add conversion support for database triggers

> * Do you have test cases? Please provide a separate update if those are ready.
I'll provide them.
> * There are ... Stanislav Lomany

08:54 AM Feature #1949: add conversion support for database triggers

> But are you sure that WAIT-FOR can "see" DB events?
I'm mistaken on this, I was doing a @wait-for find of person.f... Constantin Asofiei

08:41 AM Feature #1949: add conversion support for database triggers

There are no mixed cases in the server project. I don't have a good check for the GUI right now, but that is OK.
... Greg Shah

08:01 AM Feature #1949: add conversion support for database triggers

ui_statements.rules looks OK (is built on top of H081); the only comment is about the "== true" and "!= true" tests. ... Constantin Asofiei

09:05 AM Feature #1586 (Closed): add quick and dirty support for word indexes using LIKE operator

Update was regression tested and checked into bzr revision 10173. Eric Faulhaber

09:01 AM Feature #1974: add conversion support for (non-dynamic) database attributes

Update vmn_upd20130214a.zip (see parent issue) was regression tested and checked into bzr revision 10172. Eric Faulhaber

08:56 AM Feature #1955 (Closed): add conversion support for CREATE-TEMP-TABLE statement

Updates (see #1652) were regression tested and checked into bzr revision 10171. Eric Faulhaber

08:55 AM Feature #1954 (Closed): add conversion support for CREATE QUERY statement

Updates (see #1652) were regression tested and checked into bzr revision 10171. Eric Faulhaber

08:52 AM Feature #1953 (Closed): add conversion support for CREATE BUFFER statement

Updates (see #1652) were regression tested and checked into bzr revision 10171. Eric Faulhaber

02/15/2013

06:07 PM Feature #2000 (Closed): add conversion support for table and table handle parameters

Eric Faulhaber

05:07 PM Feature #1999: add conversion support for builtin functions in a WHERE clause

The following builtin functions are used within a WHERE clause in the current project (in order of most to least used... Eric Faulhaber

04:47 PM Feature #1999 (Closed): add conversion support for builtin functions in a WHERE clause

Eric Faulhaber

04:17 PM Feature #1949: add conversion support for database triggers

Code review 20130213a:
Overall, this first drop looks quite good, though honestly it's such a big set of changes i... Eric Faulhaber

03:22 PM Feature #1890: upgrade to the latest stable PLJava and ensure that it is available on all target ...

h2. From the PL/Java mailing list (potentially helpful for Linux 64bit and Java 7)...
Send Pljava-dev mailing list... Eric Faulhaber

12:33 PM Feature #1668: add support for additional (non-dynamic) database attributes

Attached is an updated version of your last code drop, merged with newer levels of Ovidiu's code, with which this upd... Eric Faulhaber

12:31 PM Feature #1586: add quick and dirty support for word indexes using LIKE operator

Sorry, I misspoke (mistyped?) in my last update. I made some minor changes to the 20130212c drop to merge with newer... Eric Faulhaber

10:07 AM Feature #1586 (Test): add quick and dirty support for word indexes using LIKE operator

We are regression testing the update as is, which contains conversion support and some of the runtime implementation.... Eric Faulhaber

11:27 AM Feature #1947: add conversion support for database methods

Yes, please do. Greg Shah

11:25 AM Feature #1947: add conversion support for database methods

Greg Shah wrote:
> This is a conversion time problem only (since it is in the parser, which has no runtime implicati... Vadim Nebogatov

11:02 AM Feature #1947: add conversion support for database methods

This is a conversion time problem only (since it is in the parser, which has no runtime implications). Greg Shah

11:01 AM Feature #1947: add conversion support for database methods

Vadim Nebogatov wrote:
> Do you mean runtime? In conversion time
>
> FIND FIRST btest WHERE NO-LOCK.
>
> is c... Eric Faulhaber

10:55 AM Feature #1947: add conversion support for database methods

Greg Shah wrote:
> There is a bug related to the parser changes for making the lock types into literals:
>
> [...... Vadim Nebogatov

07:56 AM Feature #1947: add conversion support for database methods

There is a bug related to the parser changes for making the lock types into literals:... Greg Shah

11:15 AM Bug #1914: database conversion requires Internet connectivity

The stacktrace for this error is:... Constantin Asofiei

02/14/2013

06:10 PM Feature #1949: add conversion support for database triggers

Test update, doesn't handle trigger deregistration and DISABLE-*-TRIGGERS functions. Stanislav Lomany

04:35 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

Code review 20130214a:
I had to make a few changes, updated archive is attached (same name; I will delete the old... Eric Faulhaber

10:03 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

Fixed issues and attached update. I added a couple of @BUFFER-COPY@ method declarations. At least enough to get a com... Ovidiu Maxiniuc

03:27 PM Feature #1947 (Closed): add conversion support for database methods

Eric Faulhaber

02:37 PM Feature #1947 (WIP): add conversion support for database methods

Vadim Nebogatov

02:36 PM Feature #1947: add conversion support for database methods

This update was regression tested, is committed to bzr revision 10168 & 10169. Vadim Nebogatov

02:05 PM Feature #1933 (Closed): add conversion support for certain metadata constructs

Attached update has been regression tested and is committed to bzr revision 10170. Eric Faulhaber

01:37 PM Feature #1581: add conversion and runtime support for certain metadata constructs

Further information on p2j.cfg.xml change...
Old example schema node structure:... Eric Faulhaber

12:47 PM Feature #1992: add support for double-colon (::) syntax

By chance, I used the NAME as the field to be evaluates like: @bufh::name@.
Here is the error:... Ovidiu Maxiniuc

12:31 PM Feature #1668: add support for additional (non-dynamic) database attributes

CORRECTION:
The partial interface hierarchy should look like this, since CommonErrorStatus should not extend Writa... Eric Faulhaber

12:23 PM Feature #1668: add support for additional (non-dynamic) database attributes

> Ovidiu: if there is any special implementation requirement you know of for the ERROR attribute for temp-table hand... Ovidiu Maxiniuc

12:13 PM Feature #1668: add support for additional (non-dynamic) database attributes

OK, given that CommonErrorStatus.java appears to not be necessary for either of your updates, I am going to drop it f... Eric Faulhaber

11:58 AM Feature #1668: add support for additional (non-dynamic) database attributes

Additionally, hwrap = "ErrorStatus" unwrapped just for CommonErrorStatus confused in methods_attributes.rules Vadim Nebogatov

11:48 AM Feature #1668: add support for additional (non-dynamic) database attributes

> Class name CommonErrorStatus confused me: I thought it was common interface specially created for supporting all ER... Ovidiu Maxiniuc

11:42 AM Feature #1668: add support for additional (non-dynamic) database attributes

Eric Faulhaber wrote:... Vadim Nebogatov

10:28 AM Feature #1668: add support for additional (non-dynamic) database attributes

Eric, that will do the trick. At some point, maybe we should put these interfaces under the same package? IMO it will... Constantin Asofiei

10:15 AM Feature #1668: add support for additional (non-dynamic) database attributes

Also note that the ERROR attribute is only writable for ProDataSet, buffer, and temp-table handles. So, it seems lik... Eric Faulhaber

10:08 AM Feature #1668: add support for additional (non-dynamic) database attributes

Another note about ERROR attribute: as this is common to more than ERROR-HANDLE resource, it needs to be placed in an... Constantin Asofiei

09:51 AM Feature #1668: add support for additional (non-dynamic) database attributes

Vadim, Ovidiu:
Both of you included this same change to the CommonErrorStatus interface in your most recent update... Eric Faulhaber

08:29 AM Feature #1668: add support for additional (non-dynamic) database attributes

There is a reason why the getters and setters for attributes/builtin functions/methods... are not symmetrical.
4GL... Greg Shah

12:07 AM Feature #1668: add support for additional (non-dynamic) database attributes

Vadim: please go ahead and add setError(logical) setter (and keep setError(boolean)) in both CommonErrorStatus and Er... Constantin Asofiei

07:47 PM Feature #1668: add support for additional (non-dynamic) database attributes

Constantin Asofiei wrote... Vadim Nebogatov

02/13/2013

01:27 PM Feature #1668: add support for additional (non-dynamic) database attributes

Greg Shah wrote:
> I'll let Eric name Interface1.
Let's go with @DatabaseInfo@, since both DBNAME and TABLE retur... Eric Faulhaber

01:16 PM Feature #1668: add support for additional (non-dynamic) database attributes

I'll let Eric name Interface1.
My ideas:
Interface2 - Labelable
Interface3 - Typable Greg Shah

01:07 PM Feature #1668: add support for additional (non-dynamic) database attributes

> and CommonErrorStatus.setError() fix
Please share the reason/testcase you used to change setError from accepting a... Constantin Asofiei

12:55 PM Feature #1668: add support for additional (non-dynamic) database attributes

* name [KW_NAME] and private-data [KW_PRIV_DAT] - these two are defined by the CommonHandleChain interface. Looking a... Constantin Asofiei

12:22 PM Feature #1668: add support for additional (non-dynamic) database attributes

Constantin: looking at note 24, I guess all of these remaining attributes (not just the ones in my last note) are not... Greg Shah

12:19 PM Feature #1668: add support for additional (non-dynamic) database attributes

Constantin: in regard to the NAME and PRIVATE-DATA attributes, in which interface are they best located? Same questi... Greg Shah

11:09 AM Feature #1668: add support for additional (non-dynamic) database attributes

I have attached update containing support for
BUFFER-NAME (KW_BUF_NAME),
INDEX-INFORMATION (KW_IDX_INFO)
LITERA... Vadim Nebogatov

11:00 AM Feature #1668: add support for additional (non-dynamic) database attributes

Ovidiu already implemented the following (his update is in the queue for regression testing -- see om_upd20130213a.zi... Eric Faulhaber

10:40 AM Feature #1668: add support for additional (non-dynamic) database attributes

List of database attributes still to be supported (mostly in combined cases):
name (KW_NAME)
private-data [KW_PR... Vadim Nebogatov

03:23 AM Feature #1668: add support for additional (non-dynamic) database attributes

Just a question.
I saw that the conversion of BUFFER-VALUE attribute (KW_BUF_VAL) declared in FieldInterface is now... Ovidiu Maxiniuc

11:01 PM Feature #1668: add support for additional (non-dynamic) database attributes

Based on the latest drop of customer source, the following attributes from the list in note 3 above are *no longer in... Eric Faulhaber

01:21 PM Feature #1992: add support for double-colon (::) syntax

From Ovidiu:... Greg Shah

12:51 PM Feature #1992 (WIP): add support for double-colon (::) syntax

Ovidiu Maxiniuc

10:03 AM Feature #1992: add support for double-colon (::) syntax

The double-colon (::) syntax is a shorthand for extracting information from a handle to a buffer, query, or ProDataSe... Eric Faulhaber

09:53 AM Feature #1992 (Closed): add support for double-colon (::) syntax

Eric Faulhaber

01:02 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

Ovidiu Maxiniuc wrote:
> That's strange, the files I sent @DefaultDelegate@ inner class had the new method implement... Eric Faulhaber

12:44 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

That's strange, the files I sent @DefaultDelegate@ inner class had the new method implemented (they were returning nu... Ovidiu Maxiniuc

12:08 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

Code review 20130213a:
QueryWrapper did not compile, due to missing (new) P2JQuery method implementations in the i... Eric Faulhaber

04:05 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

I added the forgotten files and merged with your update. Ovidiu Maxiniuc

02/12/2013

05:23 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

Code review 20130212a (cont):
I am uploading an update with 3 newer versions of the files you provided. 2 have ve... Eric Faulhaber

04:33 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

Code review 20130212a:
Everything here looks good, _except_ we are missing updated versions of AbstractQuery and Q... Eric Faulhaber

11:28 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

Ovidiu Maxiniuc wrote:
> I merged the changes from all CREATE TEMP-TABLE / BUFFER / QUERY tasks using the last vmn_u... Eric Faulhaber

11:13 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

I merged the changes from all CREATE TEMP-TABLE / BUFFER / QUERY tasks using the last vmn_upd20130211a.zip as base. H... Ovidiu Maxiniuc

01:11 PM Feature #1586: add quick and dirty support for word indexes using LIKE operator

Implemented temporary solution.
Some more details were added to the javadoc of character.convertToSQLContains() met... Ovidiu Maxiniuc

11:38 AM Feature #1668: add support for additional (non-dynamic) database attributes

Go ahead and post the update that you have. Then work with Eric to either finish any remaining attributes and method... Greg Shah

11:14 AM Feature #1668: add support for additional (non-dynamic) database attributes

Practically all database related attributes are implemented excepting ones used in combined cases Vadim Nebogatov

11:10 AM Feature #1668: add support for additional (non-dynamic) database attributes

I have attached spreadsheet with one more column showing already supported attributes Vadim Nebogatov

11:04 AM Feature #1668: add support for additional (non-dynamic) database attributes

The browse attributes and methods are UI-related, not database. So I think you don't need to be working on those.
... Greg Shah

10:59 AM Feature #1668: add support for additional (non-dynamic) database attributes

I have created BrowseWidgetInterface and unwrap method, but converted code uses BrowseWidget directly:... Vadim Nebogatov

08:50 AM Feature #1668: add support for additional (non-dynamic) database attributes

Implemented, tested and commented attributes:
BUFFER-NAME (KW_BUF_NAME),
INDEX-INFORMATION (KW_IDX_INFO)
LITERAL-Q... Vadim Nebogatov

08:25 AM Feature #1947: add conversion support for database methods

The change in implicit_where_clause.rules is correct and as you say, it is very necessary. Greg Shah

02:14 AM Feature #1947: add conversion support for database methods

Yet another version of this update, with a fixed version of methods_attributes.rules and literals.rules. The previou... Eric Faulhaber

11:04 PM Feature #1947: add conversion support for database methods

Greg,
The changes we made to literal processing (specifically, the "literals" function in common-progress.rules) c... Eric Faulhaber

07:07 PM Feature #1947: add conversion support for database methods

This version of your update is merged with the latest code revision in bzr (10166), and with overlapping changes in a... Eric Faulhaber

02/11/2013

02:10 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

Ovidiu Maxiniuc wrote:
> I did that. Please see the attached update. I removed any unrelated code, only bzr + vmn_up... Eric Faulhaber

01:51 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

> I reviewed this update in combination with your 20130201a update, which was necessary to make sure I had everything... Ovidiu Maxiniuc

12:14 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

Code review 20130208a:
I reviewed this update in combination with your 20130201a update, which was necessary to ma... Eric Faulhaber

02/10/2013

12:01 PM Feature #1947: add conversion support for database methods

Implemented, tested and commented attributes:
BUFFER-NAME (KW_BUF_NAME),
INDEX-INFORMATION (KW_IDX_INFO)
LITERAL-QUES... Vadim Nebogatov

02/08/2013

12:59 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

Does this update include all of the changes you rolled into your last (combined) update for #1668, or do I need to me... Eric Faulhaber

12:57 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

I attached the update pack and testcases. Ovidiu Maxiniuc

11:01 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

Ovidiu Maxiniuc wrote:
> In this case, "builder" would be more appropriate.
Works for me. Eric Faulhaber

11:00 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

Eric Faulhaber wrote:
> How about @TempTable@ for the interface and @TempTableFactory@ for the class? Is "factory... Ovidiu Maxiniuc

08:43 AM Feature #1947: add conversion support for database methods

All true. I would still prefer Query over P2JQuery. Greg Shah

08:07 AM Feature #1947: add conversion support for database methods

Vadim Nebogatov wrote:
> What is Query? I saw hwrap to it. Is it still not implemented new interface which will be e... Eric Faulhaber

07:13 AM Feature #1947: add conversion support for database methods

What is Query? I saw hwrap to it. Is it still not implemented new interface which will be extended by P2Query? Vadim Nebogatov

02/07/2013

06:06 PM Feature #1947: add conversion support for database methods

Code review 20130207a:
This version of the update still had a few issues, but it was close enough that I just made... Eric Faulhaber

01:28 PM Feature #1947: add conversion support for database methods

Two updates are attached:
1) vmn_upd20130207a.zip - support database methods and attributes
2) vmn_upd20130207a_t... Vadim Nebogatov

01:26 PM Feature #1947: add conversion support for database methods

... Vadim Nebogatov

10:26 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

Ovidiu Maxiniuc wrote:
> Regarding the class that implements @DynamicTempTable@. At moment of naming it, it did make... Eric Faulhaber

10:05 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

I have moved the @getField()@ to Buffer interface and renamed it to simply @field()@ so there would be no collisions ... Ovidiu Maxiniuc

02/06/2013

03:00 PM Feature #1947: add conversion support for database methods

Code review 20130205a:
* It seems that you must have changed handle.java, but it was not included in the update.
... Eric Faulhaber

12:02 PM Feature #1947: add conversion support for database methods

Two updates are attached:
1) vmn_upd20130205a.zip - support database methods and attributes
2) vmn_upd20130205a_t... Vadim Nebogatov

02/05/2013

05:27 PM Feature #1586: add quick and dirty support for word indexes using LIKE operator

For the current project, the use of CONTAINS is very consistent. The AST generally looks like:... Eric Faulhaber

01:17 PM Feature #1586 (WIP): add quick and dirty support for word indexes using LIKE operator

I learned that this operator is a little strange, only works on whole words (btw, the field on which it is applied mu... Ovidiu Maxiniuc

01:18 PM Feature #1947: add conversion support for database methods

On 02/01/2013 02:49 PM, Vadim wrote:... Vadim Nebogatov

02/01/2013

12:39 PM Feature #1668: add support for additional (non-dynamic) database attributes

I have merged all my changes form @CREATE BUFFER/QUERY/TEMP-TABLE@ along with other methods/attributes and functions ... Ovidiu Maxiniuc

02:20 AM Feature #1668: add support for additional (non-dynamic) database attributes

Attached table with information about supported attributes Vadim Nebogatov

12:31 PM Feature #1653: add conversion and runtime support for dynamically prepared queries

> Also regarding 20130129c: you mentioned a DELETE OBJECT conversion above, but I did not see this in the code. Did... Constantin Asofiei

12:13 PM Feature #1653: add conversion and runtime support for dynamically prepared queries

Also regarding 20130129c: you mentioned a DELETE OBJECT conversion above, but I did not see this in the code. Did I... Eric Faulhaber

11:51 AM Feature #1653: add conversion and runtime support for dynamically prepared queries

Code review 20130129c:
I too am concerned that P2JQuery and AbstractQuery may not be the correct targets for all o... Eric Faulhaber

11:58 PM Feature #1947: add conversion support for database methods

Please merge all of your code in these updates (primarily the code update) with the latest code in bzr and re-submit ... Eric Faulhaber

11:36 PM Feature #1581: add conversion and runtime support for certain metadata constructs

The approach to support conversion of business logic which uses metadata is to treat these references just like any o... Eric Faulhaber

11:21 PM Feature #1933 (WIP): add conversion support for certain metadata constructs

Eric Faulhaber

11:09 PM Feature #1583 (Closed): add conversion and runtime support for the INSERT language statement

Eric Faulhaber

01/31/2013

05:11 PM Feature #1947: add conversion support for database methods

Attached table with information about supported attributes Vadim Nebogatov

03:07 PM Feature #1947: add conversion support for database methods

Two updates are attached:... Vadim Nebogatov

02:35 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

Code review 20130129b:
I see some problems with the DynamicTempTable interface. I believe all of the @getXXX@ metho... Eric Faulhaber

11:35 AM Feature #1668: add support for additional (non-dynamic) database attributes

Vadim Nebogatov wrote:
> Support for EXTENT attribute should be implemented in FieldReference class. Is it correct?
... Eric Faulhaber

09:43 AM Feature #1668: add support for additional (non-dynamic) database attributes

I got down to "remote" attribute, but last for the 5 of them are not finished.
For some of then I needed some help f... Ovidiu Maxiniuc

05:21 AM Feature #1668: add support for additional (non-dynamic) database attributes

Support for EXTENT attribute should be implemented in FieldReference class. Is it correct?... Vadim Nebogatov

11:00 AM Feature #1586: add quick and dirty support for word indexes using LIKE operator

This issue isn't really about word indexes per se, but it is a quick and dirty precursor to true word index support, ... Eric Faulhaber

01/30/2013

06:09 PM Feature #1668: add support for additional (non-dynamic) database attributes

Vadim Nebogatov wrote:
> 3) What if we have both method (with no parameters) and attribute with equal names and we w... Eric Faulhaber

04:34 PM Feature #1668: add support for additional (non-dynamic) database attributes

Vadim Nebogatov wrote:
> 2) Query handle based INDEX-INFORMATION Attribute. Why it is called as attribute, not metho... Eric Faulhaber

04:21 PM Feature #1668: add support for additional (non-dynamic) database attributes

Vadim Nebogatov wrote:
> 1) Conversion result of
>
> hBuffer:AVAILABLE.
> hBuffer:AVAILABLE().
>
> is the same... Eric Faulhaber

11:21 AM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function

After review, I added @currentChanged@ and @_currentChanged@ to the @Buffer@ interface, and removed the static versio... Eric Faulhaber

06:44 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Changed implementation to take advantage of new handle implementation.
Added method/attribute conversion support for... Ovidiu Maxiniuc

01/29/2013

02:39 PM Feature #1668: add support for additional (non-dynamic) database attributes

Several questions:... Vadim Nebogatov

11:59 AM Feature #1653: add conversion and runtime support for dynamically prepared queries

Changed code to take advantage of new handle implementation.
In fact some support was already there, written by Cons... Ovidiu Maxiniuc

10:55 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

Changed implementation to take advantage of new handle implementation.
I created a new interface (@DynamicTempTable@... Ovidiu Maxiniuc

08:28 AM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function

I attached the code. I merged it with latest sources from bzr as it was a couple of months old.
The conversion runs ... Ovidiu Maxiniuc

02:26 AM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function

Ovidiu, do you have any code in process that you have not attached to this issue? We at least need the conversion ch... Eric Faulhaber

09:31 PM Feature #1967: rework DMO class/interface hierarchy

Note this fix has not yet been regression tested. Though I couldn't find any unanticipated conversion differences in... Eric Faulhaber

01/28/2013

03:04 PM Feature #1947: add conversion support for database methods

Eric Faulhaber wrote: ... Vadim Nebogatov

10:11 AM Feature #1947: add conversion support for database methods

Vadim Nebogatov wrote:
> Two questions.
>
> 1) Methods
>
> FIND-FIRST (predicate-expression[, lockmode[, wai... Eric Faulhaber

02:24 PM Feature #1967: rework DMO class/interface hierarchy

Stas, Constantin, thanks for letting me know about this. I have an update which fixes this for me locally, but it ne... Eric Faulhaber

04:02 AM Feature #1967: rework DMO class/interface hierarchy

I confirm for temp-tables too, please check the buffer_test2a.p and buffer_test2b.p (they are in bazaar). Constantin Asofiei

03:42 AM Feature #1967: rework DMO class/interface hierarchy

Eric, please be aware that @define parameter buffer@ is not converted properly:... Stanislav Lomany

01:11 PM Feature #1668: add support for additional (non-dynamic) database attributes

Ovidiu, thank you for organizing this list further. The reason most of the attributes you mentioned are not in the a... Eric Faulhaber

12:07 PM Feature #1668: add support for additional (non-dynamic) database attributes

I took the list of attributes and I used the OpenEdge Reference to compile some details for them. You can group the a... Ovidiu Maxiniuc

01/26/2013

05:50 PM Feature #1947: add conversion support for database methods

Two questions.
1) Methods
FIND-FIRST (predicate-expression[, lockmode[, wait-mode] ])
FIND-LAST (predicate-e... Vadim Nebogatov

02:03 AM Feature #1974: add conversion support for (non-dynamic) database attributes

See the parent issue for all instructions and updates. This issue only exists to separate the conversion development ... Eric Faulhaber

01:54 AM Feature #1974 (Closed): add conversion support for (non-dynamic) database attributes

Eric Faulhaber

01:54 AM Feature #1975 (Closed): add runtime support for (non-dynamic) database attributes

Eric Faulhaber

01:53 AM Feature #1668: add support for additional (non-dynamic) database attributes

The following is the full list of attributes (including database and non-database) which need to be supported for our... Eric Faulhaber