Activity
From 02/10/2013 to 03/11/2013
03/12/2013
- 10:15 PM Feature #2000: add conversion support for table and table handle parameters
- Code looks good, AFAICT, but without test cases and being able to look at the ASTs, the changes were hard to follow, ...
- 09:54 PM Bug #2084: Conversion misplaced parameter for can-find statement
- Code review 20130311a:
* Do you have a test case that illustrates the problem described by Constantin in notes 5 a... - 08:58 PM Feature #2080: add runtime support for database methods
- Update vmn_upd20130311c.zip has passed conversion regression testing. Please commit it to bzr and distribute. Note ...
03/11/2013
- 06:30 PM Feature #2080: add runtime support for database methods
- Code review 20130311c:
The merge looks fine. The implementation of @BufferImpl.bufferCompare@ doesn't look right. ... - 05:00 PM Feature #2080: add runtime support for database methods
- Attached update
vmn_upd20130311c.zip
vmn_upd20130311d.zip (corresponding test cases)
is next replacement of vm... - 04:26 PM Feature #2080: add runtime support for database methods
- P2JQuery,
** 040 CA 20130311 Added bufferHandle(integer).
It seems wrong number - 03:08 PM Feature #2080: add runtime support for database methods
- Code review 20130311a:
The changes all look good.
I noticed on this second review that even the no-arg versions... - 10:01 AM Feature #2080: add runtime support for database methods
- Attached update
vmn_upd20130311a.zip
vmn_upd20130311b.zip (corresponding test cases)
is replacement of vmn_upd2013... - 06:20 PM Feature #2000: add conversion support for table and table handle parameters
- Regression conversion completed without errors.
- 03:42 PM Feature #2000: add conversion support for table and table handle parameters
- > Is this merged up to the latest bzr revision?
Yes, it is merged. - 02:59 PM Feature #2000: add conversion support for table and table handle parameters
- Is this merged up to the latest bzr revision?
If so, please do run conversion regression testing. Eric will do a ... - 02:32 PM Feature #2000: add conversion support for table and table handle parameters
- Update for TABLE-HANDLE FOR case. Should I regression-test it?
- 03:32 PM Bug #2083: client-side where-clause leak in FindQuery
- The @<action>sibref.setHidden(true)</action>@ from @where_clause_post.rules@ at line 438 from my previous update seem...
- 11:24 AM Bug #2083: client-side where-clause leak in FindQuery
- After some more tests, it seems like this update does not fix the issue, in fact it is too restrictive, it will cut m...
- 06:07 AM Bug #2083: client-side where-clause leak in FindQuery
- With help from Constantin, the missing @setHidden@ is now in place.
- 01:46 PM Bug #2084: Conversion misplaced parameter for can-find statement
- Added proposed update which checks if the javaname is marked for remap but not as a generated increment name.
- 11:05 AM Feature #1947: add conversion support for database methods
- Added missing API bufferHandle(integer). Committed to bzr revision -10276- 10277.
03/10/2013
- 03:29 PM Feature #1668: add support for additional (non-dynamic) database attributes
- Update ecf_upd20130308a.zip has passed conversion regression testing and is committed as bzr rev. 10274.
03/09/2013
- 09:11 AM Bug #2083: client-side where-clause leak in FindQuery
- I couldn't get my mind of client_taint and I took a quick look where is used. In where_clause_post.rules, at line 413...
03/08/2013
- 04:40 PM Feature #1668: add support for additional (non-dynamic) database attributes
- Fix candidate attached. I'll push this through conversion regression testing.
Vadim: please take note of this up... - 03:56 PM Feature #1668: add support for additional (non-dynamic) database attributes
- Eric, we've hit this on another occasion (? literal). For now, just handle both cases. The parser changes related to ...
- 03:43 PM Feature #1668: add support for additional (non-dynamic) database attributes
- Interesting...outside of the message statement, the NO_LOCK_LITERAL is the child of an intermediate EXPRESSION node, ...
- 03:24 PM Feature #1668: add support for additional (non-dynamic) database attributes
- The update doesn't handle this case:...
- 01:59 PM Bug #2084: Conversion misplaced parameter for can-find statement
- Sorry, I should have been more explicit. The failures are caused by the fact that, when you have a table named @prodc...
- 01:53 PM Bug #2084: Conversion misplaced parameter for can-find statement
- Constantin Asofiei wrote:
> Conversion regression testing has failed, as the tests above have passed because the jav... - 06:53 AM Bug #2084: Conversion misplaced parameter for can-find statement
- Conversion regression testing has failed, as the tests above have passed because the javaname in these cases is the s...
- 04:51 AM Bug #2084: Conversion misplaced parameter for can-find statement
- The changes looks good, also solves other compile errors where wrong buf name was used, in cases like:...
- 04:01 AM Bug #2084: Conversion misplaced parameter for can-find statement
- Added proposed update,
In previous comment I didn't understood exactly the process so I assumed there's an addition... - 12:20 PM Feature #2000: add conversion support for table and table handle parameters
- About the state of work: I changed the parser so TABLE-HANDLE FOR is recognized as a variable reference rather than a...
- 12:19 PM Bug #2083: client-side where-clause leak in FindQuery
- At this moment, I use the following simplified testcase:...
- 12:09 PM Bug #2083: client-side where-clause leak in FindQuery
- I'm getting closer. Here what I found:
The extra node (@f1 [FUNC_LOGICAL]@) should be made hidden so it will not b... - 09:09 AM Bug #2083: client-side where-clause leak in FindQuery
- In my previous note there the and operator from where clause contains a reference to a buffer other than the one that...
- 10:35 AM Feature #2086 (Closed): add support for the VALIDATE clause, for the temp-table's fiels defined u...
- 10:34 AM Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
- Committed to bzr 10266.
- 09:58 AM Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
- OK, this change looks fine. Commit and distribute it.
- 09:48 AM Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
- The update has passed conversion regression testing. There is one additional change in MAJIC, from a @DEFINE TEMP-TAB...
- 08:37 AM Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
- Sorry, when you say "VALIDATE clause", I thought you are referring to the option for a TEMP-TABLE (not for a specific...
- 07:27 AM Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
- New version of the update, which solves the VALIDATE when used with @DEFINE TEMP-TABLE tt1 LIKE source VALIDATE@. Als...
- 03:09 AM Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
- This fix removes the extent annotation from the source field reference in the VALEXP. What is still needed to do:
# ... - 01:41 AM Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
- Greg, the VALIDATE clause is used in the server project with a field definition. See file pmcon/cjcotdo0.w. There are...
03/07/2013
- 06:12 PM Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
- VALIDATE is NOT used in the server project (in a TEMP-TABLE or WORK-TABLE definition). Only NO-UNDO and RCODE-INFORM...
- 05:41 PM Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
- MAJIC has finished conversion and there are changes, expected: validation clauses are dropped for temp-table fields d...
- 04:55 PM Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
- The server project exposed a problem with the temp-table fields defined using the LIKE clause, when the target field ...
- 04:43 PM Feature #2086 (Closed): add support for the VALIDATE clause, for the temp-table's fiels defined u...
- 03:12 PM Feature #2080: add runtime support for database methods
- Code review 20130307a:
* There is no implementation for @QueryWrapper.getNext(LockType)@. The other @getXXX(LockT... - 11:10 AM Feature #2080: add runtime support for database methods
- Vadim Nebogatov wrote:
> Does P2J have common module responsible for 4GL errors processing? (I found actually ErrorM... - 11:01 AM Feature #2080: add runtime support for database methods
- Attached update vmn_upd20130307a.zip. Added runtime support for queryClose, queryForward, queryReposition, queryRepos...
- 05:11 AM Feature #2080: add runtime support for database methods
- Does P2J have common module responsible for 4GL errors processing? (I found actually ErrorManager.recordOrThrowError(...
- 02:10 PM Bug #2084: Conversion misplaced parameter for can-find statement
- The problem seems to be happening in the annotation phase in the following way:
The BUFFER_SCOPE with a bufname" va... - 07:46 AM Bug #2084: Conversion misplaced parameter for can-find statement
- Example:...
- 07:44 AM Bug #2084 (Closed): Conversion misplaced parameter for can-find statement
- 09:57 AM Bug #2083: client-side where-clause leak in FindQuery
- I did some patch (removing the extra expression from where node after generating the anonymous inner class needed by ...
- 05:33 AM Bug #2083: client-side where-clause leak in FindQuery
- Another can-find leak:...
- 08:48 AM Feature #2000: add conversion support for table and table handle parameters
- > When will the solution be ready for review?
Hopefully will finish it today. - 08:46 AM Feature #2000: add conversion support for table and table handle parameters
- When will the solution be ready for review?
- 04:44 AM Feature #2000: add conversion support for table and table handle parameters
- About @DEF PARAMETER TABLE-HANDLE FOR th@ where @th@ is a regular variable:
1. OUTPUT case will produce compile-ti...
03/06/2013
- 05:13 PM Feature #2080: add runtime support for database methods
- Please implement all the methods you can, which do not require dynamic database support. For example, FIND-FIRST wit...
- 02:02 PM Bug #2083: client-side where-clause leak in FindQuery
- Ovidiu Maxiniuc wrote:
> The parameter is in fact an echo of the content of the client-side WhereExpression: @f1(cus... - 01:59 PM Bug #2083: client-side where-clause leak in FindQuery
- Here are the converted code for two cases (which attempt to call two new constructors), with and without another join...
- 01:50 PM Bug #2083: client-side where-clause leak in FindQuery
- I tried to simplify the sample. Suppose we have a simple function:...
- 01:25 PM Bug #2083 (Closed): client-side where-clause leak in FindQuery
- 01:37 PM Feature #1947 (Closed): add conversion support for database methods
- Vadim committed this update to bzr as revision number 10256.
- 11:21 AM Feature #1947: add conversion support for database methods
- I made a minor change to the database_general.rules header. Please check in and distribute the attached version of y...
- 10:58 AM Feature #1947: add conversion support for database methods
- I have attached one more variant of the same update, but merged manually
- 10:29 AM Feature #1947: add conversion support for database methods
- Code review 20130306a:
Other than the literal.rules merge issue noted above (which I do think was my mistake), eve... - 09:35 AM Feature #1947: add conversion support for database methods
- I will merge everything manually and resubmit
- 09:25 AM Feature #1947: add conversion support for database methods
- As I see, update from Eric was not merged with revision you pointed. Maybe I am wrong with time calculation?
- 09:21 AM Feature #1947: add conversion support for database methods
- Update #134 from Eric was attached at 2013-03-05 11:38PM, so I supposed that it was merged with revision 10245 that w...
- 08:54 AM Feature #1947: add conversion support for database methods
- Vadim, literals.rules is not merged with 10245 (evl_upd20130305a.zip). I'll let Eric review the rest of the update.
- 08:49 AM Feature #1947: add conversion support for database methods
- Attached update
vmn_upd20130306a.zip / vmn_upd20130306a_test_cases.zip (start/final revisions 10245/10253)
The follow... - 11:46 PM Feature #1947: add conversion support for database methods
- Vadim, please note that Ovidiu soon will be committing to bzr some changes to files which will overlap with your upda...
- 12:42 PM Bug #2077: fix converted table and field name collisions
- Committed to bzr revision 10257.
- 11:54 AM Bug #2077: fix converted table and field name collisions
- Check it in and distribute it.
- 11:40 AM Bug #2077: fix converted table and field name collisions
- Update has passed conversion regression testing - no changes in generated code.
- 10:46 AM Bug #2077: fix converted table and field name collisions
- This solves the collision cases for good. Also, I've added support for buffer names collision check. I'm putting this...
- 09:12 AM Bug #2077: fix converted table and field name collisions
- Yes, the fix is pretty simple. I'll provide an update today.
- 09:00 AM Bug #2077: fix converted table and field name collisions
- If this is easy enough to fix, please go ahead and put the fix in. That way we don't have to remember there is a pro...
- 07:38 AM Bug #2077: fix converted table and field name collisions
- Ovidiu, sorry I hijacked this from you last night. Anyway, this case I don't think is encountered in the server proje...
- 07:26 AM Bug #2077: fix converted table and field name collisions
- By chance I prepared a sample test-case for this issue which at this moment is not converted correctly by p2j:...
- 01:50 AM Bug #2077: fix converted table and field name collisions
- Committed to bzr revision 10246.
- 07:14 AM Feature #1967: rework DMO class/interface hierarchy
- 0306b.zip was committed to bzr revision 10253.
- 04:46 AM Feature #1967: rework DMO class/interface hierarchy
- ca_upd20130306b.zip has passed conversion regression testing (no changes in generated sources).
- 02:25 AM Feature #1967: rework DMO class/interface hierarchy
- Attached update fixes the problem for my 0305d.zip. It brackets the deleteAll with a block only if it's parent is not...
- 11:36 PM Feature #1967: rework DMO class/interface hierarchy
- The om_upd20130304b.zip and ecf_upd20130305a.zip updates have gotten through conversion regression testing. However,...
- 09:50 PM Feature #1967: rework DMO class/interface hierarchy
- Code review -20130304a- 20130304b:
The code looks fine. The attached update corrects some cut-and-paste errors in t... - 03:03 AM Feature #1953: add conversion support for CREATE BUFFER statement
- Committed revision 10248.
- 09:07 PM Feature #1953: add conversion support for CREATE BUFFER statement
- Update 20130303a looks fine, except that the zip file is based at the com directory instead of src. Please fix this,...
- 11:41 PM Feature #1933: add conversion support for certain metadata constructs
- Conversion regression testing was successful. Please commit and distribute the 20130305b update.
- 10:15 PM Feature #1933: add conversion support for certain metadata constructs
- Code review 20130305a:
Changes look good.
Code review 20130305b:
The change is fine, but a slightly tighter ... - 11:39 PM Feature #1668: add support for additional (non-dynamic) database attributes
- Update 20130304c has passed conversion regression testing. Please correct the FieldReference header as noted above, ...
- 09:58 PM Feature #1668: add support for additional (non-dynamic) database attributes
- Code review 20130304c:
Code changes look fine, but please correct the file header numbering for the last 2 entries...
03/05/2013
- 06:20 PM Bug #2077: fix converted table and field name collisions
- It looks fine. Check it in and distribute it.
- 05:16 PM Bug #2077: fix converted table and field name collisions
- Passed conversion regression testing.
- 04:18 PM Bug #2077: fix converted table and field name collisions
- I'm putting this through conversion regression testing.
- 02:39 PM Bug #2077: fix converted table and field name collisions
- This update solves collisions for dmo, table, property and column names. It adds a numeric suffix, similar to how tem...
- 02:05 PM Bug #2077: fix converted table and field name collisions
- In 4GL, it is possible to have two tables names named @p2j_test@ and @p2j-test@. Also, these field names can be in th...
- 02:02 PM Bug #2077 (Closed): fix converted table and field name collisions
- 05:50 PM Feature #2080: add runtime support for database methods
- The following static methods should be removed from AbstractQuery:...
- 05:44 PM Feature #2080: add runtime support for database methods
- This issue is for adding runtime support for all the database methods added in issue #1947. For the most part, we on...
- 05:40 PM Feature #2080 (Closed): add runtime support for database methods
- 05:30 PM Feature #1947: add conversion support for database methods
- Update 20130305b hit a snag in conversion regression testing. It did not cause a regression per se, because the chan...
- 03:55 PM Feature #1947: add conversion support for database methods
- I tried to update code from bzr now (I did not make any changes since the time I sent update).
Please see result - ... - 03:49 PM Feature #1947: add conversion support for database methods
- I made fresh check out today morning and merged manually from updates with adding only my changes. Maybe I missed som...
- 03:44 PM Feature #1947: add conversion support for database methods
- Eric, sorry, but I updated code today from bzr minimum 5 times during the day with bzr update command. Last time imme...
- 03:38 PM Feature #1947: add conversion support for database methods
- Code review 20130305a:
The changes all look good, but rules/convert/literals.rules was out of date with bzr (confl... - 09:41 AM Feature #1947: add conversion support for database methods
- Updated test cases with expressions
- 09:31 AM Feature #1947: add conversion support for database methods
- Yes, it is true. Tests passed in this case too with the results like
query1.getNext(LockType.LT_EXCLUSIVE, plus(7,... - 07:43 AM Feature #1947: add conversion support for database methods
- Vadim,
> are even not compilable.
the correct syntax for you tests is this:... - 07:40 AM Feature #1947: add conversion support for database methods
- Attached update
vmn_upd20130305a.zip / vmn_upd20130305a_test_cases.zip
is next replacement of update vmn_upd20130... - 05:16 PM Feature #1967: rework DMO class/interface hierarchy
- I'm taking this back, wrong task: this has some regressions in terms that is too aggressive when bracketing the delet...
- 05:15 PM Feature #1967: rework DMO class/interface hierarchy
- -Passed conversion regression testing.-
- 04:18 PM Feature #1967: rework DMO class/interface hierarchy
- I'm putting this through conversion regression testing.
- 01:48 PM Feature #1967: rework DMO class/interface hierarchy
- Fix cases of a FOR EACH block converted to a tt.delete call, in case the FOR EACH is enclosed in a statement - in thi...
- 10:56 AM Feature #1933: add conversion support for certain metadata constructs
- This update adds a message to standard console when a duplicate dmo name is detected.
- 10:11 AM Feature #1933: add conversion support for certain metadata constructs
- I only want you to add this feature if it is very fast to implement, since this is not in the critical path. Otherwi...
- 10:04 AM Feature #1933: add conversion support for certain metadata constructs
- Should I add the verification? What kind should it be? Just a @System.err/out.print()@ or persisted to logging file ?...
- 09:13 AM Feature #1933: add conversion support for certain metadata constructs
- Ovidiu Maxiniuc wrote:
> Shouldn't we use an automated postfixed name change if some name is already taken? Or at le... - 07:52 AM Feature #1933: add conversion support for certain metadata constructs
- Fixed java package for metadata tables.
Just a question. I know that the problem is solvable by using hints but if...
03/04/2013
- 04:03 PM Bug #2059: CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a FOR EACH...
- Good point. Actually, the best is probably just to get rid of the @schemaScope@ variable altogether and use the @glo...
- 03:53 PM Bug #2059: CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a FOR EACH...
- LE: actually, I think the correct test is:...
- 03:45 PM Bug #2059: CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a FOR EACH...
- Eric, your fix in SchemaDictionary I don't think it works for temp-tables, as the following code:...
- 03:12 PM Feature #1933: add conversion support for certain metadata constructs
- Ovidiu Maxiniuc wrote:
> You mean that we should use @P2OLookup@ instead of the current @SymbolResolver@ calls ?
... - 01:04 PM Feature #1933: add conversion support for certain metadata constructs
- > I think this is probably best done in P2OLookup (in the schema package), such that P2OLookup.javaPackage(String his...
- 11:07 AM Feature #1933: add conversion support for certain metadata constructs
- Ovidiu Maxiniuc wrote:
> 4GL has a meta set of tables associated with each database and from the user point of view ... - 01:19 PM Feature #1947: add conversion support for database methods
- Vadim Nebogatove wrote (in email):
> I tried to make tests today with literal constants. Possible I implemented chan... - 09:44 AM Feature #1947: add conversion support for database methods
- Vadim Nebogatov wrote:
> I have analyzed one more time. Solution you wrote is useful if both parameters are literals... - 04:05 AM Feature #1947: add conversion support for database methods
- I have analyzed one more time. Solution you wrote is useful if both parameters are literals. But many combined cases ...
- 03:04 AM Feature #1947: add conversion support for database methods
- I did not notice that Ubuntu Nautilus does not show backup files by default...
- 09:48 PM Feature #1947: add conversion support for database methods
- Code review 20130303a:
* As I noted earlier, please don't include backup files (e.g., @QueryWrapper.java~@) in you... - 10:54 AM Feature #1668: add support for additional (non-dynamic) database attributes
- Added @FieldInterface@/@FieldReference.value(NumberType)@. This is related to #2068, note 18.1.
This update must be... - 10:47 AM Feature #1967: rework DMO class/interface hierarchy
- Unfortunately, at some point we might have to rename the APIs in these interfaces too, which are extended by Buffer i...
- 10:33 AM Feature #1967: rework DMO class/interface hierarchy
- This update fixes eventual collisions in dmo interfaces because of @WrappedResource@ interface (@isValid()@ & @isUnkn...
- 09:37 AM Feature #2000: add conversion support for table and table handle parameters
- Got it. I was mis-reading the meaning of the syntax.
- 09:33 AM Feature #2000: add conversion support for table and table handle parameters
- > Is there any difference in behavior if you switch the order of the DEF SHARED VAR and DEF PARAMETER (if the DEF SHA...
- 09:31 AM Feature #2000: add conversion support for table and table handle parameters
- Is there any difference in behavior if you switch the order of the DEF SHARED VAR and DEF PARAMETER (if the DEF SHARE...
- 05:39 AM Feature #2000: add conversion support for table and table handle parameters
- I found that @DEF PARAMETER TABLE-HANDLE FOR th@ where @th@ is a [new] shared variable is handled differently that if...
- 05:15 AM Feature #1953: add conversion support for CREATE BUFFER statement
- Added missing create() overloads.
Also reformatted and sorted so that they are more visible/countable.
Fixes compil...
03/03/2013
- 03:28 PM Feature #1947: add conversion support for database methods
- Attached update vmn_upd20130303a.zip with tests vmn_upd20130303a_test_cases.zip is next replacement of update vmn_upd...
- 03:22 PM Bug #2059: CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a FOR EACH...
- The attached update is an interim workaround to protect against the NPE so we can get further into conversion. Still...
03/02/2013
- 06:11 PM Feature #1947: add conversion support for database methods
- The ges_upd20130302a.zip passed conversion testing and checked in as bzr revision 10232.
- 04:52 PM Feature #1947: add conversion support for database methods
- As found in #1985 (and documented in note 3 of #1655), the DELETE-RESULT-LIST-ENTRY() method should have been added p...
- 09:34 AM Feature #1947: add conversion support for database methods
- Vadim Nebogatov wrote:
> Eric Faulhaber wrote:
> > In convert/literals.rules, rewrite the rules regarding lock type... - 05:23 AM Feature #1947: add conversion support for database methods
- Eric Faulhaber wrote:
> In convert/literals.rules, rewrite the rules regarding lock type literals (added in the last... - 12:42 PM Feature #1933: add conversion support for certain metadata constructs
- For identifying the correct package to be imported I went back on the annotation paths for @pkgname@, @bufname@, @sch...
- 02:39 AM Bug #2071 (Closed): conversion fails to find attach point for QueryWrapper instance variable decl...
- 02:36 AM Bug #2071: conversion fails to find attach point for QueryWrapper instance variable declaration
- A non-promoted OPEN QUERY in an IF-THEN construct fails to find an attach point to which to graft its QueryWrapper de...
- 01:25 AM Bug #2071 (Closed): conversion fails to find attach point for QueryWrapper instance variable decl...
03/01/2013
- 04:05 PM Feature #1947: add conversion support for database methods
- Attached update vmn_upd20130301c.zip with tests vmn_upd20130301c_test_cases.zip is replacement of update vmn_upd20130...
- 12:15 PM Feature #1947: add conversion support for database methods
- Vadim Nebogatov wrote:
> Yes, I hope
If not, please post what you have at the end of the day so we have the optio... - 11:42 AM Feature #1947: add conversion support for database methods
- Yes, I hope
- 11:22 AM Feature #1947: add conversion support for database methods
- Vadim Nebogatov wrote:
> Changes in *.rules files. OK, will correct. My impression was that it will be needed for ru... - 10:55 AM Feature #1947: add conversion support for database methods
- Changes in *.rules files. OK, will correct. My impression was that it will be needed for runtime.
Static queryC... - 09:40 AM Feature #1947: add conversion support for database methods
- Code review 20130301a:
* The update is incomplete. I provided detailed instructions on the needed changes to rule... - 09:05 AM Feature #1947: add conversion support for database methods
- Attached update vmn_upd20130301b.zip with tests vmn_upd20130301b_test_cases.zip
containing fixes for # 1947/ #102: ... - 08:58 AM Feature #1947: add conversion support for database methods
- Sorry I have not specified, it was Ovidiu's update.
- 08:57 AM Feature #1947: add conversion support for database methods
- I think he means 104. I'm reviewing 103 now. It is not ready; I'll provide detail shortly.
- 08:50 AM Feature #1947: add conversion support for database methods
- Constantin Asofiei wrote:
> It passed conversion regression testing, please go ahead and checkin/ distribute.
Do ... - 08:49 AM Feature #1947: add conversion support for database methods
- It passed conversion regression testing, please go ahead and checkin/ distribute.
- 07:16 AM Feature #1947: add conversion support for database methods
- The code looks good, I'm putting this through conversion regression testing.
- 07:03 AM Feature #1947: add conversion support for database methods
- This update removes the unneeded @handle:@ token from the chaining like:...
- 03:46 AM Feature #1947: add conversion support for database methods
- Attached update vmn_upd20130301a.zip with tests vmn_upd20130301a_test_cases.zip containing
1) the conversion and runt... - 03:14 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Update has passed conversion regression test and is committed to bzr rev. 10228.
- 08:03 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- @defaultBufferHandle@ is pushed up from @TempTable@ to @Buffer@ interface.
- 03:04 PM Feature #1949: add conversion support for database triggers
- This update looks good and has passed conversion regression testing. Please check it into bzr and distribute.
- 08:31 AM Feature #1949: add conversion support for database triggers
- Constantin's point is a good one. It looks to me like the parser is fine (of course I like saying that :)).
Can w... - 08:16 AM Feature #1949: add conversion support for database triggers
- 2.1 would be OK only if the ON WRITE statement would work only with table names, but looks like it works with buffer ...
- 07:59 AM Feature #1949: add conversion support for database triggers
- Option 2.1 seems most correct to me, because it makes the tree accurately reflect the meaning of the code from the be...
- 03:29 AM Feature #1949: add conversion support for database triggers
- ...
- 10:13 AM Feature #1933: add conversion support for certain metadata constructs
- I will go on with this issue, as I am now able to see what's wrong using my project.
- 07:50 AM Feature #1933: add conversion support for certain metadata constructs
- Ovidiu Maxiniuc wrote:
> I exported a sample @_File@ structure (.df) and data (.d) from my test database ...
I ca... - 03:28 AM Feature #1933: add conversion support for certain metadata constructs
- Eric,
I exported a sample @_File@ structure (.df) and data (.d) from my test database but, for some unknown (to me)... - 01:01 AM Feature #1668: add support for additional (non-dynamic) database attributes
- FieldReference.value is missing the value(NumberType) version (subscript can be more than int literals).
PS: and Fie...
02/28/2013
- 04:41 PM Feature #1947: add conversion support for database methods
- I'm posting these here too, from #2068:
More errors related to database methods:... - 04:02 PM Feature #1947: add conversion support for database methods
- Vadim Nebogatov wrote:
> It works with 0 without errors too; - as far as I understood
>
> ... - 03:11 PM Feature #1947: add conversion support for database methods
- I tested in 4GL the following...
- 02:22 PM Feature #1947: add conversion support for database methods
- One correction to my last posting:
In the case where the first argument is NOT one of the lock literals, AND we ha... - 02:05 PM Feature #1947: add conversion support for database methods
- OK, then we must emulate this error handling at runtime, which means we need the following APIs:...
- 01:13 PM Feature #1947: add conversion support for database methods
- I have tested in 4GL the following...
- 11:59 AM Feature #1947: add conversion support for database methods
- Constantin Asofiei wrote:
> > Again, if the literals don't match the well-known compiler constants, Progress must de... - 11:36 AM Feature #1947: add conversion support for database methods
- > Again, if the literals don't match the well-known compiler constants, Progress must default to some lock behavior d...
- 11:34 AM Feature #1947: add conversion support for database methods
- Constantin Asofiei wrote:
> You forgot these:
> ... - 11:14 AM Feature #1947: add conversion support for database methods
- Eric Faulhaber wrote:
> Yes, please hold this update for the moment.
>
> I think we can cover all cases with:
> ... - 11:08 AM Feature #1947: add conversion support for database methods
- Yes, please hold this update for the moment.
I think we can cover all cases with:... - 10:45 AM Feature #1947: add conversion support for database methods
- Variant with 100+ methods (integer, int64, long, LockType) is ready
GET-NEXT (KW_GET_NEXT)
GET-PREV (KW_GET_PREV... - 10:41 AM Feature #1947: add conversion support for database methods
- > OK, but wouldn't the @i + 1@ expression be converted to @plus(i, 1)@ (which returns an integer wrapper instance), s...
- 10:36 AM Feature #1947: add conversion support for database methods
- Constantin Asofiei wrote:
> > Am I missing something?
> yes, you can pass vars/expressions to these parameters, not... - 10:22 AM Feature #1947: add conversion support for database methods
- > Am I missing something?
yes, you can pass vars/expressions to these parameters, not just literals:... - 10:19 AM Feature #1947: add conversion support for database methods
- Constantin Asofiei wrote:
> Vadim Nebogatov wrote:
> > If we want to reuse current(LockType lockType) we will need ... - 10:07 AM Feature #1947: add conversion support for database methods
- Eric Faulhaber wrote:
> I don't understand this. Why can't we use NumberType to reduce the explosion of APIs? We a... - 10:05 AM Feature #1947: add conversion support for database methods
- Constantin Asofiei wrote:
> where both parameters are optional, and nowait appears only if first is set. We can redu... - 08:51 AM Feature #1947: add conversion support for database methods
- Vadim Nebogatov wrote:
> If we want to reuse current(LockType lockType) we will need to create LockType from other ty... - 08:49 AM Feature #1947: add conversion support for database methods
- If we want to reuse current(LockType lockType) we will need to create LockType from other types including long
- 08:40 AM Feature #1947: add conversion support for database methods
- If you set the parameter to java native long, then all native int values will be accepted, so no casting is needed. I...
- 08:39 AM Feature #1947: add conversion support for database methods
- Will we cast long to int before using LockType.fromInt(int type)?
- 08:33 AM Feature #1947: add conversion support for database methods
- Vadim Nebogatov wrote:
> LockType aggregates lock and wait statuses, what is the sense of using it with other parame... - 08:26 AM Feature #1947: add conversion support for database methods
- LockType aggregates lock and wait statuses, what is the sense of using it with other parameters, especially with one ...
- 08:14 AM Feature #1947: add conversion support for database methods
- The syntax for this method would be (example for GET-NEXT):...
- 08:03 AM Feature #1947: add conversion support for database methods
- Constantin Asofiei wrote:
> Vadim Nebogatov wrote:
> > OK, good. What do you think about #68 (getNext(LockType lock... - 07:35 AM Feature #1947: add conversion support for database methods
- LE: when I say no work needed, I refer to the lock types. You will still need getNext(LockType) version to be added.
- 07:34 AM Feature #1947: add conversion support for database methods
- Vadim Nebogatov wrote:
> OK, good. What do you think about #68 (getNext(LockType lockType))?
Actually, NO-LOCK and ... - 06:38 AM Feature #1947: add conversion support for database methods
- OK, good. What do you think about #68 (getNext(LockType lockType))?
- 06:11 AM Feature #1947: add conversion support for database methods
- > According doc, lock is mandatory, no-wait is optional:
>
> GET-NEXT ( NO-LOCK| SHARE-LOCK [, NO-WAIT] | EXCLUSIV... - 06:00 AM Feature #1947: add conversion support for database methods
- Eric Faulhaber wrote:
> Ignore my last post; I mis-read the documentation. NO-LOCK is the default if not specified... - 03:51 AM Feature #1947: add conversion support for database methods
- I don't understand... stupid chrome or redmine ?
- 03:50 AM Feature #1947: add conversion support for database methods
- I think ...
- 03:47 AM Feature #1947: add conversion support for database methods
- The same question concerning getNext parameters. Do we really need method with signature using P2J type LockType?
... - 03:40 AM Feature #1947: add conversion support for database methods
- The question: BUFFER-COMPARE/ BUFFER-COPY support also should be corrected. May I do this in the same update?
BUF... - 03:33 PM Feature #1933: add conversion support for certain metadata constructs
- Correct, we need the import.
Ovidiu was looking at this at the end of the day today, I guess he will continue tomo... - 02:49 PM Feature #1933: add conversion support for certain metadata constructs
- Ah, good point. So, we need to emit an import statement for ...dmo._meta.*, right? Are you taking this, or do you w...
- 02:43 PM Feature #1933: add conversion support for certain metadata constructs
- The metadata tables are emitted to the dmo._meta package, but all buffers referring meta tables are still converted t...
- 03:31 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Note that the defaultBufferHandle API I think it needs to be added to the Buffer interface too, because there are com...
- 09:06 AM Feature #1949: add conversion support for database triggers
- > do you have any idea why this happens ? Is this intentional ?
No. No. I'll take it as my top priority. - 08:25 AM Feature #1949: add conversion support for database triggers
- During the investigations for #1985, note 69, resulted that a possible bug is in the parser.
The following code:
<p... - 01:48 AM Feature #1588: add conversion and runtime support for embedded SQL
- 20130227a update has passed regression testing and is committed to bzr rev. 10225.
- 12:40 AM Feature #1588: add conversion and runtime support for embedded SQL
- Attached update fixes a defect during annotations processing.
02/27/2013
- 05:17 PM Feature #2000: add conversion support for table and table handle parameters
- I uncommited my last commit.
- 05:13 PM Feature #2000: add conversion support for table and table handle parameters
- > Please distribute the Config change as a separate update zip file BUT at the SAME TIME as the svl_upd20130226a.zip....
- 05:04 PM Feature #2000: add conversion support for table and table handle parameters
- Please distribute the Config change as a separate update zip file BUT at the SAME TIME as the svl_upd20130226a.zip. ...
- 04:37 PM Feature #2000: add conversion support for table and table handle parameters
- Actually, I think we're OK here. All the failures are in the Config class, which is hand-written and will need to be...
- 03:47 PM Feature #2000: add conversion support for table and table handle parameters
- Majic did not compile after this update. Please see #2067 for the results.
- 03:08 PM Feature #2000: add conversion support for table and table handle parameters
- > I'll do it here. Do you expect any differences? If I find anything unusual, I'll ask.
TABLE parameters should us... - 02:29 PM Feature #2000: add conversion support for table and table handle parameters
- I'll do it here. Do you expect any differences? If I find anything unusual, I'll ask.
- 02:17 PM Feature #2000: add conversion support for table and table handle parameters
- > Have you run conversion on Majic with this to check for unexpected changes?
No. I can run, but it will take 2.5 h. - 02:10 PM Feature #2000: add conversion support for table and table handle parameters
- Have you run conversion on Majic with this to check for unexpected changes?
- 02:07 PM Feature #2000: add conversion support for table and table handle parameters
- Everything except SHARED variables for TABLE-HANDLE FOR. I recommend to distribute the remaining part later as a sepa...
- 12:11 AM Feature #2000: add conversion support for table and table handle parameters
- Stanislav Lomany wrote:
> Heh, it look like BUFFER parameter is misconverted, but not because of me:
>
> [...]
... - 07:23 PM Feature #2000: add conversion support for table and table handle parameters
- Fix for #2.
- 03:53 PM Feature #1947: add conversion support for database methods
- om_upd20130227c.zip has passed conversion testing and is checked into bzr as revision 10223.
- 02:17 PM Feature #1947: add conversion support for database methods
- The om_upd20130227b.zip is close, but I have made a couple of changes to the code. The post-rules section is moved t...
- 01:29 PM Feature #1947: add conversion support for database methods
- Ignore my last post; I mis-read the documentation. NO-LOCK is the default if not specified. So, it seems we will n...
- 01:25 PM Feature #1947: add conversion support for database methods
- Correction: I don't think we'll need @P2JQuery.getNext()@ (only @P2JQuery.getNext(LockType lockType)@); seems the 4...
- 01:14 PM Feature #1947: add conversion support for database methods
- Vadim, please fix the query handle GET-* return type problem, as described in #1985, note 61 (repeated below for conv...
- 12:37 PM Feature #1947: add conversion support for database methods
- This update fixes generation of @LockType@ literals into converted java source.
- 12:04 PM Feature #1947 (WIP): add conversion support for database methods
- Needed to re-open this for some conversion corrections to query methods GET-NEXT, GET-FIRST, etc. Please see note 61...
- 01:48 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- Passed runtime regression testing and is checked into bzr as revision 10222.
- 01:45 PM Feature #1949: add conversion support for database triggers
- Passed conversion testing and is checked in as bzr revision 10221.
- 12:16 PM Feature #1949: add conversion support for database triggers
- Conversion testing passed. Please check in the update and distribute it.
- 09:45 AM Feature #1949: add conversion support for database triggers
- I have started conversion testing.
- 09:41 AM Feature #1949: add conversion support for database triggers
- The code looks OK. We need to conversion test it.
- 09:40 AM Feature #1949: add conversion support for database triggers
- Indeed, the annotations are not set unless some variables are first declared. And, because in our sample the block is...
- 09:19 AM Feature #1949: add conversion support for database triggers
- Looks like for trigger blocks, the undoable counter are not initialized (written as annotation).
The attached propos... - 05:24 AM Feature #1949: add conversion support for database triggers
- Problem with DB triggers in server project:...
- 11:53 AM Feature #1668: add support for additional (non-dynamic) database attributes
- Discussion moved from emails.
---
Eric,
As far as I understood, Ovidiu is already busy with BUFFER-VALUE r... - 12:07 AM Bug #2062 (Closed): buffer parameter names doubled up, not included in RecordBuffer.openScope() call
- The following test:...
- 12:01 AM Bug #2062 (Closed): buffer parameter names doubled up, not included in RecordBuffer.openScope() call
02/26/2013
- 06:53 PM Feature #2000: add conversion support for table and table handle parameters
- > In regards to issue number 4, can you explain what the code in th-proc.p is supposed to do?
> This code seems like... - 06:08 PM Feature #2000: add conversion support for table and table handle parameters
- Heh, it look like BUFFER parameter is misconverted, but not because of me:...
- 05:33 PM Feature #2000: add conversion support for table and table handle parameters
- > Hm...actually, a BUFFER parameter on a temp-table won't cause a call to TemporaryBuffer.associate. Is there still ...
- 05:28 PM Feature #2000: add conversion support for table and table handle parameters
- Stanislav Lomany wrote:
> > What about BUFFER parameters on temp-tables?
>
> Yes, I missed this type of parameter... - 04:58 PM Feature #2000: add conversion support for table and table handle parameters
- > What about BUFFER parameters on temp-tables?
Yes, I missed this type of parameters when I was analyzing the impa... - 04:56 PM Feature #2000: add conversion support for table and table handle parameters
- Stanislav Lomany wrote:
> >In record_scoping.rules, you changed the bufclassname annotation to TableParameter from T... - 04:47 PM Feature #2000: add conversion support for table and table handle parameters
- In regards to issue number 4, can you explain what the code in th-proc.p is supposed to do?...
- 04:43 PM Feature #2000: add conversion support for table and table handle parameters
- >In record_scoping.rules, you changed the bufclassname annotation to TableParameter from Temporary. Isn't that going ...
- 04:37 PM Feature #2000: add conversion support for table and table handle parameters
- In record_scoping.rules, you changed the bufclassname annotation to TableParameter from Temporary. Isn't that going ...
- 04:12 PM Feature #2000: add conversion support for table and table handle parameters
- > Did you intend to remove this from the define_stmt rule in progress.g?
Yes. I don't know why it was there, proba... - 04:09 PM Feature #2000: add conversion support for table and table handle parameters
- Did you intend to remove this from the define_stmt rule in progress.g?...
- 04:08 PM Feature #2000: add conversion support for table and table handle parameters
- #1 - yes, working on it
#2 - emit TableParameter when calling a function, working on it
#3 - yes, it works fine
#4... - 04:00 PM Feature #2000: add conversion support for table and table handle parameters
- Stanislav Lomany wrote:
> What remains is:
> 1. procedure TABLE-HANDLE calls using TableParameters, calling side - ... - 03:44 PM Feature #2000: add conversion support for table and table handle parameters
- I'll add javadocs later.
- 01:19 PM Feature #2000: add conversion support for table and table handle parameters
- Attached is the parser change to accept the APPEND syntax on a function call.
- 05:55 PM Bug #2057 (Closed): buffer unique name disambiguation (separator problems)
- 02:16 PM Bug #2057: buffer unique name disambiguation (separator problems)
- Passed conversion regression testing, committed to bzr revision 10213.
- 02:13 PM Bug #2057: buffer unique name disambiguation (separator problems)
- attached correct update, previous one was for another task (will delete it)
- 02:08 PM Bug #2057: buffer unique name disambiguation (separator problems)
- The conversion regression testing has passed, the only diffs were related to instance field order (RecordBuffer.defin...
- 12:15 PM Bug #2057: buffer unique name disambiguation (separator problems)
- Constantin Asofiei wrote:
> Eric, one more question: if you can, please explain why BufferScopeWorker.getBuffer atte... - 11:45 AM Bug #2057: buffer unique name disambiguation (separator problems)
- Update: with the BuffescScopeWorker.getBuffer changed I mentioned earlier, conversion of app folder goes through all ...
- 11:20 AM Bug #2057: buffer unique name disambiguation (separator problems)
- Eric, one more question: if you can, please explain why BufferScopeWorker.getBuffer attempts to match the buffer usin...
- 11:00 AM Bug #2057: buffer unique name disambiguation (separator problems)
- Eric, the code converts because our test db is named "p2j_test", with an underscore... I had to change the DB name to...
- 10:59 AM Bug #2057: buffer unique name disambiguation (separator problems)
- I realize you're the assignee for this, but it looked like it might be related to what I fixed last night, so I conve...
- 10:10 AM Bug #2057: buffer unique name disambiguation (separator problems)
- We have a case where an existing buffer defined for a table, like:...
- 10:00 AM Bug #2057 (Closed): buffer unique name disambiguation (separator problems)
- 05:54 PM Feature #2055 (Closed): RECID AND ROWID IN WHERE CLAUSE
- 12:37 PM Feature #2055: RECID AND ROWID IN WHERE CLAUSE
- Commited to bzr as revision 10212.
- 12:26 PM Feature #2055: RECID AND ROWID IN WHERE CLAUSE
- Conversion regression testing has passed, please check in and distribute update.
- 11:08 AM Feature #2055: RECID AND ROWID IN WHERE CLAUSE
- Eliminated the problems from previous update
- 10:17 AM Feature #2055: RECID AND ROWID IN WHERE CLAUSE
- Beside the header in RecidExpression (where you reference RowidExpression), I don't see any problems. I'm putting thi...
- 10:14 AM Feature #2055: RECID AND ROWID IN WHERE CLAUSE
- I'm reviewing this now.
- 09:59 AM Feature #2055: RECID AND ROWID IN WHERE CLAUSE
- Derived a case from that for recid
Added proposed update. - 09:11 AM Feature #2055: RECID AND ROWID IN WHERE CLAUSE
- Costin, use this test:...
- 08:53 AM Feature #2055: RECID AND ROWID IN WHERE CLAUSE
- Is there any case for RECID I can use?
For ROWID I testedn the changes with something like @FIND FIRST book WHERE TO... - 05:01 AM Feature #2055: RECID AND ROWID IN WHERE CLAUSE
- Next error is in .../vcpl/daqueau0.p:...
- 04:59 AM Feature #2055 (Closed): RECID AND ROWID IN WHERE CLAUSE
- 05:53 PM Bug #2052 (Closed): conversion error resolving master temp-table buffer
- 07:48 PM Bug #2052: conversion error resolving master temp-table buffer
- This update has passed conversion regression testing and is checked into bzr revision 10205.
- 12:45 PM Bug #2059 (WIP): CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a FO...
- The following code fails at conversion time:...
- 12:43 PM Bug #2059 (Closed): CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a...
- 12:14 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- I have updated the p2jpl.ddr and have applied it to staging. It has no conversion impact, only runtime. Runtime regr...
- 04:05 AM Feature #1668: add support for additional (non-dynamic) database attributes
- Added conversion support for EMPTY-TEMP-TABLE and BUFFER-DELETE (see ecf_upd20130226a.zip at #1985). This update pas...
- 02:34 AM Bug #2054 (Closed): conversion errors with complex buffer parameters and definitions
- The fix has passed conversion regression testing. It is checked into bzr revision 10207.
- 02:08 AM Bug #2054: conversion errors with complex buffer parameters and definitions
- The following testcases produce buffers and fields with the incorrect schemaname annotation, such that downstream pro...
- 01:59 AM Bug #2054 (Closed): conversion errors with complex buffer parameters and definitions
02/25/2013
- 04:51 PM Bug #2052: conversion error resolving master temp-table buffer
- Turns out the previous update fixed the symptom rather than the root cause. Turns out we were not handling empty int...
- 03:40 PM Bug #2052: conversion error resolving master temp-table buffer
- Constantin Asofiei wrote:
> This testcase is related to this issue:
> [...]
>
> The buffers get reordered, but n... - 03:08 PM Bug #2052: conversion error resolving master temp-table buffer
- This testcase is related to this issue:...
- 02:59 PM Bug #2052: conversion error resolving master temp-table buffer
- OK, I'll try postponing the DEFINE BUFFER lookups until all the DEFINE TEMP-TABLE statements in a file have been visi...
- 02:56 PM Bug #2052: conversion error resolving master temp-table buffer
- I think this is related to annotations/record_scoping_post.rules H008.
- 02:49 PM Bug #2052: conversion error resolving master temp-table buffer
- The error occurs because there is an expectation of a DEFINE TEMP-TABLE xyz statement appearing earlier in the AST th...
- 02:18 PM Bug #2052 (Closed): conversion error resolving master temp-table buffer
- 03:37 PM Feature #2047 (Closed): field references in procedures without explicit buffer scope
- 03:15 PM Feature #2047: field references in procedures without explicit buffer scope
- Committed to bzr revision 10204.
- 03:02 PM Feature #2047: field references in procedures without explicit buffer scope
- Check it in and distribute it.
- 02:42 PM Feature #2047: field references in procedures without explicit buffer scope
- The conversion has finished and the generated sources look good to me (only some reordering in openScope and buffer i...
- 01:32 PM Feature #2047: field references in procedures without explicit buffer scope
- I had a copy-paste error in SymbolResolver, I saved bufname instead of dbname in the "dbname" annotation. I'm running...
- 11:40 AM Feature #2047: field references in procedures without explicit buffer scope
- I'm a little nervous about the change BUT I think it should be OK. I'm going to put it into conversion testing now.
- 11:01 AM Feature #2047: field references in procedures without explicit buffer scope
- Fix attempt for scope computation for fields in procedures/functions without explicit buffer scope created by other s...
- 09:39 AM Feature #2047: field references in procedures without explicit buffer scope
- This one is related to #1706. Looking at the perm buffer scoping from some compile listings from 4GL v9 and new ones ...
- 08:53 AM Feature #2047: field references in procedures without explicit buffer scope
- Looks like 4GL allows a buffer reference in a procedure, without having its scope set, as it inherits the buffer scop...
- 08:51 AM Feature #2047 (Closed): field references in procedures without explicit buffer scope
- 01:01 PM Feature #1992 (Closed): add support for double-colon (::) syntax
- 12:35 PM Feature #1992: add support for double-colon (::) syntax
- I have chosen not to alter in any way the update that have passed the testing (om_upd20130225a.zip) and committed it ...
- 11:38 AM Feature #1992: add support for double-colon (::) syntax
- Your update (including my change to progress.g) has passed conversion regression testing. I am attaching my updated ...
- 10:55 AM Feature #1992: add support for double-colon (::) syntax
- > There was one change to progress.g that seemed unnecessary: after discussion with Greg, I removed the actions in t...
- 10:43 AM Feature #1992: add support for double-colon (::) syntax
- Code review 20130225a:
Nice work! I am running it through conversion regression testing now.
There was one cha... - 06:19 AM Feature #1992: add support for double-colon (::) syntax
- Latest :: conversion merged with bzr revision 10199 and updated testcase.
- 11:47 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- Greg Shah wrote:
> Final conversion testing passed. This is checked into bzr as 10200.
This will fail runtime reg... - 10:21 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- Final conversion testing passed. This is checked into bzr as 10200.
- 09:15 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- Initial conversion testing passed. Attached is the update merged up to bzr 10199. This is going back into conversio...
- 02:43 AM Feature #1975: add runtime support for (non-dynamic) database attributes
- Log all history in parent task.
- 02:37 AM Feature #2042 (Closed): add conversion support for some embedded SQL features
- 02:34 AM Feature #1588: add conversion and runtime support for embedded SQL
- Added support for the simple, single table (and column) constructs listed above. These convert to methods in Buffer....
02/24/2013
- 05:29 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- A problem has occurred in the use of the ATTR_POLY BUFFER-VALUE (KW_BUF_VAL) as a parameter to an INTEGER() built-in ...
- 05:08 PM Feature #2045 (Closed): conversion support for a DELETE statement with a validation expression
- 03:18 PM Feature #2045: conversion support for a DELETE statement with a validation expression
- This is for time tracking and milestone association only. All history should be in the parent task #2044.
- 03:17 PM Feature #2045 (Closed): conversion support for a DELETE statement with a validation expression
- 05:08 PM Feature #2044: implement support for a DELETE statement with a validation expression
- It passed conversion testing and is committed to bzr as revision 10198.
- 04:08 PM Feature #2044: implement support for a DELETE statement with a validation expression
- And now the update...
- 04:08 PM Feature #2044: implement support for a DELETE statement with a validation expression
- I fixed the header and have re-attached the update. This is going into conversion regression testing now.
- 04:04 PM Feature #2044: implement support for a DELETE statement with a validation expression
- Code review 20130224a:
Changes look OK to me. Note that database_access.rules needs a header entry for your changes. - 03:31 PM Feature #2044: implement support for a DELETE statement with a validation expression
- Add support to the conversion and runtime for a DELETE statement with a validation expression. We already support DE...
- 03:17 PM Feature #2044 (Closed): implement support for a DELETE statement with a validation expression
- 03:19 PM Feature #2046: runtime support for DELETE statement with a validation expression
- This is for time tracking and milestone association only. All history should be in the parent task #2044.
- 03:19 PM Feature #2046 (Closed): runtime support for DELETE statement with a validation expression
02/23/2013
- 04:39 PM Feature #2042: add conversion support for some embedded SQL features
- Log history in parent issue.
- 03:27 PM Feature #2042 (Closed): add conversion support for some embedded SQL features
- 04:39 PM Feature #2043: add runtime support for some embedded SQL features
- Log history in parent issue.
- 04:38 PM Feature #2043 (Closed): add runtime support for some embedded SQL features
- 11:11 AM Feature #1992: add support for double-colon (::) syntax
- OK, please add a suitable task to the Base Language project and target it to milestone 7. Please put all the relevan...
- 10:55 AM Feature #1992: add support for double-colon (::) syntax
- For milestone 4, I don't think there is anything we need to do about the *_POLY rvalues, all -will- can be in the run...
- 10:48 AM Feature #1992: add support for double-colon (::) syntax
- > Idea is, if we have the ATTR/METH_POLY in an expression or as a rvalue, then 4GL does some automatic conversion of ...
- 03:49 AM Feature #2000: add conversion support for table and table handle parameters
- I'm sending the update in its current state: INPUT/OUTPUT parameters and APPEND option are not handled, createDynamic...
- 03:00 AM Feature #2000: add conversion support for table and table handle parameters
- Stanislav, OK now I understand what you mean. APPEND clause used with OUTPUT/INPUT-OUTPUT table at the caller affects...
- 10:47 PM Feature #2000: add conversion support for table and table handle parameters
- Stas: please provide an update for all the other functionality discussed above ASAP, even if you don't yet have an a...
- 01:42 AM Feature #1660: add conversion and runtime support for OF keyword use in a CAN-FIND
- Vadim Nebogatov wrote:
> ... but conversion of
> ... - 12:38 AM Feature #1660: add conversion and runtime support for OF keyword use in a CAN-FIND
- I have created environment for tests and made some first conversion tests. Will try to make more tests on Monday.
...
02/22/2013
- 03:09 PM Feature #1992: add support for double-colon (::) syntax
- All the specified cases work nicely.
> I'm not sure I understand what is being asked here. By definition, the ATTR... - 03:00 PM Feature #1992: add support for double-colon (::) syntax
- > in assignment case, when the rvalue is a ATTR/METH_POLY, are there cases when the lvalue is of a different type tha...
- 02:57 PM Feature #1992: add support for double-colon (::) syntax
- > are there any ATTR_POLY/METH_POLY used directly in a frame-related statement?
In regard to the FUNC_POLY/ATTR_PO... - 01:55 PM Feature #2000: add conversion support for table and table handle parameters
- > Please fill out this matrix:
When you specify APPEND in the calling procedure it logically applies to the table ... - 12:44 PM Feature #2000: add conversion support for table and table handle parameters
- > Progress documentation tells that "You can only use the APPEND option for an INPUT parameter in the calling procedu...
- 12:36 PM Feature #2000: add conversion support for table and table handle parameters
- Leave it as Temporary if you don't have a need to change it. Less runtime change. If we find we need it to be Buffe...
- 12:34 PM Feature #2000: add conversion support for table and table handle parameters
- So, Eric, do you prefer to leave Temporary or switch to Buffer?
Constantin, Greg, how do you prefer to pass APPEND... - 12:02 PM Feature #1974 (Closed): add conversion support for (non-dynamic) database attributes
- 11:15 PM Feature #1999 (Closed): add conversion support for builtin functions in a WHERE clause
- I am closing this issue. While it brought up some interesting issues with our CAN-FIND support (which are now docume...
- 10:28 PM Feature #1999: add conversion support for builtin functions in a WHERE clause
- Vadim Nebogatov wrote:
> CAN-FIND(): SHARE-LOCK and NO-WAIT
> Yes, you are right, it is supported. I did not notic... - 08:30 PM Feature #1999: add conversion support for builtin functions in a WHERE clause
- CAN-FIND(): SHARE-LOCK and NO-WAIT
Yes, you are right, it is supported. I did not notice that WHERE clause is gener... - 07:19 PM Feature #1999: add conversion support for builtin functions in a WHERE clause
- Vadim Nebogatov wrote:
> Briefly, all functions are supported with all options excepting
>
> 1) can-find() - work... - 11:09 PM Feature #2035: optimize conversion of CAN-FIND([FIRST|LAST] temp-table-record ... {SHARE-LOCK|EXC...
- Currently, we convert this construct to use a WhereExpression, which does a client-side lock test for the found recor...
- 11:02 PM Feature #2035 (New): optimize conversion of CAN-FIND([FIRST|LAST] temp-table-record ... {SHARE-LO...
- 10:59 PM Bug #2034: correct conversion of CAN-FIND({FIRST|LAST} ... {SHARE-LOCK|EXCLUSIVE_LOCK} [NO-WAIT])
- Currently, we convert @CAN-FIND({FIRST|LAST} ...)@ with a lock the same as we do as if it doesn't have a lock; that ...
- 10:54 PM Bug #2034 (New): correct conversion of CAN-FIND({FIRST|LAST} ... {SHARE-LOCK|EXCLUSIVE_LOCK} [NO-...
- 10:50 PM Feature #1660: add conversion and runtime support for OF keyword use in a CAN-FIND
- The construct @record OF table@ in a 4gl query signifies a join between two tables (see "Record phrase" documentation...
02/21/2013
- 03:36 PM Feature #2000: add conversion support for table and table handle parameters
- > From my testing, I don't remember finding any parameter validation based on APPEND clause for temp-tables. This is ...
- 03:20 PM Feature #2000: add conversion support for table and table handle parameters
- > Maybe I misunderstood your original comment "@Temporary@ should be at least @Buffer@". I thought you meant the par...
- 03:00 PM Feature #2000: add conversion support for table and table handle parameters
- > > 2. We must make a decision on how APPEND parameter should be passed from the calling side.
> I think we need Con... - 02:35 PM Feature #2000: add conversion support for table and table handle parameters
- Stanislav Lomany wrote:
> 1.
> > OK, in that case I think we can have Temporary extend Buffer.
> Hmm, it seems tha... - 02:16 PM Feature #2000: add conversion support for table and table handle parameters
- 1.
> OK, in that case I think we can have Temporary extend Buffer.
Hmm, it seems that it makes *.Buf classes obsole... - 07:04 PM Feature #2000: add conversion support for table and table handle parameters
- > I'm pretty sure we already support the APPEND option, even though it's not used in Majic.
APPEND option can be s... - 01:41 PM Feature #1949 (Closed): add conversion support for database triggers
- 01:30 PM Feature #1949 (Review): add conversion support for database triggers
- 01:39 PM Feature #2024 (Closed): implement runtime support for database triggers
- 12:39 PM Feature #1999: add conversion support for builtin functions in a WHERE clause
- Briefly, all functions are supported with all options excepting
1) can-find() - works in general, but at least FIR... - 12:34 PM Feature #1999: add conversion support for builtin functions in a WHERE clause
- Spreadsheet with testing results is attached.
- 11:49 AM Feature #1668: add support for additional (non-dynamic) database attributes
- The update is added for review at #2002.
- 09:57 AM Feature #1992: add support for double-colon (::) syntax
- Yes, this is the case for the @::@, too, as the final attribute in the rewritten form is buffer-value() attribute whe...
- 09:51 AM Feature #1992: add support for double-colon (::) syntax
- Greg, Ovidiu found an interesting case of BUFFER-VALUE usage (which applies to any ATTR_POLY or METH_POLY). If is use...
02/20/2013
- 06:41 PM Feature #2000: add conversion support for table and table handle parameters
- Stanislav Lomany wrote:
> Conversion for TABLE-HANDLE parameters should probably look in the similar way:
> [...]
... - 06:37 PM Feature #2000: add conversion support for table and table handle parameters
- Stanislav Lomany wrote:
> Notes: 1. @Temporary@ should be at least @Buffer@
OK, in that case I think we can have ... - 05:56 PM Feature #2000: add conversion support for table and table handle parameters
- Conversion for TABLE-HANDLE parameters should probably look in the similar way:...
- 05:48 PM Feature #2000: add conversion support for table and table handle parameters
- Heh, I didn't expected it to be converted...
It is converted to:... - 05:30 PM Feature #2000: add conversion support for table and table handle parameters
- We already support it today, as far as I understand. Remember that you implemented all the deep copy of temp-tables ...
- 05:02 PM Feature #2000: add conversion support for table and table handle parameters
- How do we convert this today? I vaguely remember dealing with this issue in the past, but I don't recall whether we ...
- 03:55 PM Feature #2000: add conversion support for table and table handle parameters
- About TABLE parameters.
We must pass to the called function information that identifies the table and information ... - 02:55 PM Feature #1949: add conversion support for database triggers
- h2. TODO
This update doesn't handle the case if an UI trigger is 1. nested into DB trigger and 2. references DB tr... - 01:59 PM Feature #1992: add support for double-colon (::) syntax
- Here is the implementation and some testcase.
I'm afraid this is not built on the last source-code, I will work on t... - 01:50 PM Feature #1992: add support for double-colon (::) syntax
- > This could be one of the hardest things to implement. If the field name has changed during the conversion process i...
- 12:39 PM Feature #1992: add support for double-colon (::) syntax
- Greg Shah wrote:
> Some thoughts:
>
> 1. Queries are explicitly mentioned as supported by @::@ in the 4GL languag... - 12:13 PM Feature #1992: add support for double-colon (::) syntax
- Some thoughts:
1. Queries are explicitly mentioned as supported by @::@ in the 4GL language reference. It wouldn'... - 11:19 AM Feature #1992: add support for double-colon (::) syntax
- I already have an implementation here but, reading your previous note, made me turn back to OE installation.
The rea... - 10:28 AM Feature #1992: add support for double-colon (::) syntax
- OK, so without chaining, the scope of this feature should be much smaller. As you suggested earlier, let's go with a...
- 10:41 AM Feature #1999: add conversion support for builtin functions in a WHERE clause
- Please provide a summary of which functions are supported by conversion already and which need work. We need to get ...
- 09:29 AM Feature #1668: add support for additional (non-dynamic) database attributes
- Constantin Asofiei wrote:
> > Yes, you are correct.
> Please provide an example of read-only private-data attribute... - 09:09 AM Feature #1668: add support for additional (non-dynamic) database attributes
- > Yes, you are correct.
Please provide an example of read-only private-data attribute. - 09:08 AM Feature #1668: add support for additional (non-dynamic) database attributes
- Constantin Asofiei wrote:
> Also #2 - I see that PRIVATE-DATA has an unwrap case of WriteablePrivateData - are there...
02/19/2013
- 04:20 PM Feature #1668: add support for additional (non-dynamic) database attributes
- CORRECTION: vmn_upd20130218b.zip is what we tested; it should be overlaid with vmn_upd20130219b.zip.
- 04:18 PM Feature #1668: add support for additional (non-dynamic) database attributes
- Constantin,
We had a regression in staging for a browse column widget handle which used to do @handle.unwrapWidget... - 01:25 PM Feature #1668: add support for additional (non-dynamic) database attributes
- > Greg, Constantin: thoughts on how to properly support this? I added the WidthCharable (I know, lame name) interfa...
- 01:10 PM Feature #1668: add support for additional (non-dynamic) database attributes
- Update above is resubmitted
- 12:54 PM Feature #1668: add support for additional (non-dynamic) database attributes
- Vadim Nebogatov wrote:
> IS-OPEN
> POSITION
> TABLE-HANDLE
> SESSION:FIRST-BUFFER
> (DBNAME was already supporte... - 12:36 PM Feature #1668: add support for additional (non-dynamic) database attributes
- IS-OPEN
POSITION
TABLE-HANDLE
SESSION:FIRST-BUFFER
(DBNAME was already supported )
Update vmn_20130219a.zip co... - 11:47 PM Feature #1668: add support for additional (non-dynamic) database attributes
- Vadim Nebogatov wrote:
> I also created Sizeable/WriteableSizeable interfaces for attributes
>
> WIDTH-CHARS (KW_WID... - 01:23 PM Feature #1992: add support for double-colon (::) syntax
- >First, as I wrote above in notes 4 and 7, the second operand can be almost anything (as it is the name of a field fr...
- 12:58 PM Feature #1992: add support for double-colon (::) syntax
- First, as I wrote above in notes 4 and 7, the second operand can be almost anything (as it is the name of a field fro...
- 12:20 PM Feature #2000: add conversion support for table and table handle parameters
- Yes, that's correct.
- 12:07 PM Feature #2000 (WIP): add conversion support for table and table handle parameters
- Am I correct that the scope of this task is
DEFINE PARAMETER TABLE
DEFINE PARAMETER TABLE-HANDLE
TABLE functio...
02/18/2013
- 06:24 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- Based on a review of the recent reports, the following dynamic DB attributes are in use but are not yet implemented:
... - 06:23 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- Based on a review of the recent reports, the following dynamic DB method is in use but is not yet implemented:...
- 05:49 PM Feature #1668: add support for additional (non-dynamic) database attributes
- There are some DB attributes still missing from the checked in code:
DBNAME
IS-OPEN
POSITION
TABLE-HANDLE
SESS... - 12:24 PM Feature #1668: add support for additional (non-dynamic) database attributes
- I have attached merge of previous update (vmn_upd20130218a) with current bzr
1) vmn_upd20130218a.zip - support res... - 01:13 PM Feature #1992: add support for double-colon (::) syntax
- Taking into consideration a dataset handle @dh@ that contains a buffer handle @bh@ (named @bh-name@) with a character...
- 12:58 PM Feature #1999 (WIP): add conversion support for builtin functions in a WHERE clause
02/17/2013
- 01:22 PM Feature #1668: add support for additional (non-dynamic) database attributes
- I have attached update
1) vmn_upd20130217a.zip - support rest of database attributes
2) vmn_upd20130217a_test_ca...
02/16/2013
- 04:40 PM Feature #1992: add support for double-colon (::) syntax
- Eric Faulhaber wrote:
> Ovidiu Maxiniuc wrote:
> > For the converted code I was thinking/investigated implementing ... - 09:57 PM Feature #1992: add support for double-colon (::) syntax
- Ovidiu Maxiniuc wrote:
> For the converted code I was thinking/investigated implementing directly the @::@ as a membe... - 03:27 PM Feature #1949: add conversion support for database triggers
- > * Do you have test cases? Please provide a separate update if those are ready.
I'll provide them.
> * There are ... - 08:54 AM Feature #1949: add conversion support for database triggers
- > But are you sure that WAIT-FOR can "see" DB events?
I'm mistaken on this, I was doing a @wait-for find of person.f... - 08:41 AM Feature #1949: add conversion support for database triggers
- There are no mixed cases in the server project. I don't have a good check for the GUI right now, but that is OK.
... - 08:01 AM Feature #1949: add conversion support for database triggers
- ui_statements.rules looks OK (is built on top of H081); the only comment is about the "== true" and "!= true" tests. ...
- 09:05 AM Feature #1586 (Closed): add quick and dirty support for word indexes using LIKE operator
- Update was regression tested and checked into bzr revision 10173.
- 09:01 AM Feature #1974: add conversion support for (non-dynamic) database attributes
- Update vmn_upd20130214a.zip (see parent issue) was regression tested and checked into bzr revision 10172.
- 08:56 AM Feature #1955 (Closed): add conversion support for CREATE-TEMP-TABLE statement
- Updates (see #1652) were regression tested and checked into bzr revision 10171.
- 08:55 AM Feature #1954 (Closed): add conversion support for CREATE QUERY statement
- Updates (see #1652) were regression tested and checked into bzr revision 10171.
- 08:52 AM Feature #1953 (Closed): add conversion support for CREATE BUFFER statement
- Updates (see #1652) were regression tested and checked into bzr revision 10171.
02/15/2013
- 06:07 PM Feature #2000 (Closed): add conversion support for table and table handle parameters
- 05:07 PM Feature #1999: add conversion support for builtin functions in a WHERE clause
- The following builtin functions are used within a WHERE clause in the current project (in order of most to least used...
- 04:47 PM Feature #1999 (Closed): add conversion support for builtin functions in a WHERE clause
- 04:17 PM Feature #1949: add conversion support for database triggers
- Code review 20130213a:
Overall, this first drop looks quite good, though honestly it's such a big set of changes i... - 03:22 PM Feature #1890: upgrade to the latest stable PLJava and ensure that it is available on all target ...
- h2. From the PL/Java mailing list (potentially helpful for Linux 64bit and Java 7)...
Send Pljava-dev mailing list... - 12:33 PM Feature #1668: add support for additional (non-dynamic) database attributes
- Attached is an updated version of your last code drop, merged with newer levels of Ovidiu's code, with which this upd...
- 12:31 PM Feature #1586: add quick and dirty support for word indexes using LIKE operator
- Sorry, I misspoke (mistyped?) in my last update. I made some minor changes to the 20130212c drop to merge with newer...
- 10:07 AM Feature #1586 (Test): add quick and dirty support for word indexes using LIKE operator
- We are regression testing the update as is, which contains conversion support and some of the runtime implementation....
- 11:27 AM Feature #1947: add conversion support for database methods
- Yes, please do.
- 11:25 AM Feature #1947: add conversion support for database methods
- Greg Shah wrote:
> This is a conversion time problem only (since it is in the parser, which has no runtime implicati... - 11:02 AM Feature #1947: add conversion support for database methods
- This is a conversion time problem only (since it is in the parser, which has no runtime implications).
- 11:01 AM Feature #1947: add conversion support for database methods
- Vadim Nebogatov wrote:
> Do you mean runtime? In conversion time
>
> FIND FIRST btest WHERE NO-LOCK.
>
> is c... - 10:55 AM Feature #1947: add conversion support for database methods
- Greg Shah wrote:
> There is a bug related to the parser changes for making the lock types into literals:
>
> [...... - 07:56 AM Feature #1947: add conversion support for database methods
- There is a bug related to the parser changes for making the lock types into literals:...
- 11:15 AM Bug #1914: database conversion requires Internet connectivity
- The stacktrace for this error is:...
02/14/2013
- 06:10 PM Feature #1949: add conversion support for database triggers
- Test update, doesn't handle trigger deregistration and DISABLE-*-TRIGGERS functions.
- 04:35 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Code review 20130214a:
I had to make a few changes, updated archive is attached (same name; I will delete the old... - 10:03 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Fixed issues and attached update. I added a couple of @BUFFER-COPY@ method declarations. At least enough to get a com...
- 03:27 PM Feature #1947 (Closed): add conversion support for database methods
- 02:37 PM Feature #1947 (WIP): add conversion support for database methods
- 02:36 PM Feature #1947: add conversion support for database methods
- This update was regression tested, is committed to bzr revision 10168 & 10169.
- 02:05 PM Feature #1933 (Closed): add conversion support for certain metadata constructs
- Attached update has been regression tested and is committed to bzr revision 10170.
- 01:37 PM Feature #1581: add conversion and runtime support for certain metadata constructs
- Further information on p2j.cfg.xml change...
Old example schema node structure:... - 12:47 PM Feature #1992: add support for double-colon (::) syntax
- By chance, I used the NAME as the field to be evaluates like: @bufh::name@.
Here is the error:... - 12:31 PM Feature #1668: add support for additional (non-dynamic) database attributes
- CORRECTION:
The partial interface hierarchy should look like this, since CommonErrorStatus should not extend Writa... - 12:23 PM Feature #1668: add support for additional (non-dynamic) database attributes
- > Ovidiu: if there is any special implementation requirement you know of for the ERROR attribute for temp-table hand...
- 12:13 PM Feature #1668: add support for additional (non-dynamic) database attributes
- OK, given that CommonErrorStatus.java appears to not be necessary for either of your updates, I am going to drop it f...
- 11:58 AM Feature #1668: add support for additional (non-dynamic) database attributes
- Additionally, hwrap = "ErrorStatus" unwrapped just for CommonErrorStatus confused in methods_attributes.rules
- 11:48 AM Feature #1668: add support for additional (non-dynamic) database attributes
- > Class name CommonErrorStatus confused me: I thought it was common interface specially created for supporting all ER...
- 11:42 AM Feature #1668: add support for additional (non-dynamic) database attributes
- Eric Faulhaber wrote:...
- 10:28 AM Feature #1668: add support for additional (non-dynamic) database attributes
- Eric, that will do the trick. At some point, maybe we should put these interfaces under the same package? IMO it will...
- 10:15 AM Feature #1668: add support for additional (non-dynamic) database attributes
- Also note that the ERROR attribute is only writable for ProDataSet, buffer, and temp-table handles. So, it seems lik...
- 10:08 AM Feature #1668: add support for additional (non-dynamic) database attributes
- Another note about ERROR attribute: as this is common to more than ERROR-HANDLE resource, it needs to be placed in an...
- 09:51 AM Feature #1668: add support for additional (non-dynamic) database attributes
- Vadim, Ovidiu:
Both of you included this same change to the CommonErrorStatus interface in your most recent update... - 08:29 AM Feature #1668: add support for additional (non-dynamic) database attributes
- There is a reason why the getters and setters for attributes/builtin functions/methods... are not symmetrical.
4GL... - 12:07 AM Feature #1668: add support for additional (non-dynamic) database attributes
- Vadim: please go ahead and add setError(logical) setter (and keep setError(boolean)) in both CommonErrorStatus and Er...
- 07:47 PM Feature #1668: add support for additional (non-dynamic) database attributes
- Constantin Asofiei wrote...
02/13/2013
- 01:27 PM Feature #1668: add support for additional (non-dynamic) database attributes
- Greg Shah wrote:
> I'll let Eric name Interface1.
Let's go with @DatabaseInfo@, since both DBNAME and TABLE retur... - 01:16 PM Feature #1668: add support for additional (non-dynamic) database attributes
- I'll let Eric name Interface1.
My ideas:
Interface2 - Labelable
Interface3 - Typable - 01:07 PM Feature #1668: add support for additional (non-dynamic) database attributes
- > and CommonErrorStatus.setError() fix
Please share the reason/testcase you used to change setError from accepting a... - 12:55 PM Feature #1668: add support for additional (non-dynamic) database attributes
- * name [KW_NAME] and private-data [KW_PRIV_DAT] - these two are defined by the CommonHandleChain interface. Looking a...
- 12:22 PM Feature #1668: add support for additional (non-dynamic) database attributes
- Constantin: looking at note 24, I guess all of these remaining attributes (not just the ones in my last note) are not...
- 12:19 PM Feature #1668: add support for additional (non-dynamic) database attributes
- Constantin: in regard to the NAME and PRIVATE-DATA attributes, in which interface are they best located? Same questi...
- 11:09 AM Feature #1668: add support for additional (non-dynamic) database attributes
- I have attached update containing support for
BUFFER-NAME (KW_BUF_NAME),
INDEX-INFORMATION (KW_IDX_INFO)
LITERA... - 11:00 AM Feature #1668: add support for additional (non-dynamic) database attributes
- Ovidiu already implemented the following (his update is in the queue for regression testing -- see om_upd20130213a.zi...
- 10:40 AM Feature #1668: add support for additional (non-dynamic) database attributes
- List of database attributes still to be supported (mostly in combined cases):
name (KW_NAME)
private-data [KW_PR... - 03:23 AM Feature #1668: add support for additional (non-dynamic) database attributes
- Just a question.
I saw that the conversion of BUFFER-VALUE attribute (KW_BUF_VAL) declared in FieldInterface is now... - 11:01 PM Feature #1668: add support for additional (non-dynamic) database attributes
- Based on the latest drop of customer source, the following attributes from the list in note 3 above are *no longer in...
- 01:21 PM Feature #1992: add support for double-colon (::) syntax
- From Ovidiu:...
- 12:51 PM Feature #1992 (WIP): add support for double-colon (::) syntax
- 10:03 AM Feature #1992: add support for double-colon (::) syntax
- The double-colon (::) syntax is a shorthand for extracting information from a handle to a buffer, query, or ProDataSe...
- 09:53 AM Feature #1992 (Closed): add support for double-colon (::) syntax
- 01:02 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Ovidiu Maxiniuc wrote:
> That's strange, the files I sent @DefaultDelegate@ inner class had the new method implement... - 12:44 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- That's strange, the files I sent @DefaultDelegate@ inner class had the new method implemented (they were returning nu...
- 12:08 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Code review 20130213a:
QueryWrapper did not compile, due to missing (new) P2JQuery method implementations in the i... - 04:05 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- I added the forgotten files and merged with your update.
02/12/2013
- 05:23 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Code review 20130212a (cont):
I am uploading an update with 3 newer versions of the files you provided. 2 have ve... - 04:33 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Code review 20130212a:
Everything here looks good, _except_ we are missing updated versions of AbstractQuery and Q... - 11:28 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Ovidiu Maxiniuc wrote:
> I merged the changes from all CREATE TEMP-TABLE / BUFFER / QUERY tasks using the last vmn_u... - 11:13 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- I merged the changes from all CREATE TEMP-TABLE / BUFFER / QUERY tasks using the last vmn_upd20130211a.zip as base. H...
- 01:11 PM Feature #1586: add quick and dirty support for word indexes using LIKE operator
- Implemented temporary solution.
Some more details were added to the javadoc of character.convertToSQLContains() met... - 11:38 AM Feature #1668: add support for additional (non-dynamic) database attributes
- Go ahead and post the update that you have. Then work with Eric to either finish any remaining attributes and method...
- 11:14 AM Feature #1668: add support for additional (non-dynamic) database attributes
- Practically all database related attributes are implemented excepting ones used in combined cases
- 11:10 AM Feature #1668: add support for additional (non-dynamic) database attributes
- I have attached spreadsheet with one more column showing already supported attributes
- 11:04 AM Feature #1668: add support for additional (non-dynamic) database attributes
- The browse attributes and methods are UI-related, not database. So I think you don't need to be working on those.
... - 10:59 AM Feature #1668: add support for additional (non-dynamic) database attributes
- I have created BrowseWidgetInterface and unwrap method, but converted code uses BrowseWidget directly:...
- 08:50 AM Feature #1668: add support for additional (non-dynamic) database attributes
- Implemented, tested and commented attributes:
BUFFER-NAME (KW_BUF_NAME),
INDEX-INFORMATION (KW_IDX_INFO)
LITERAL-Q... - 08:25 AM Feature #1947: add conversion support for database methods
- The change in implicit_where_clause.rules is correct and as you say, it is very necessary.
- 02:14 AM Feature #1947: add conversion support for database methods
- Yet another version of this update, with a fixed version of methods_attributes.rules and literals.rules. The previou...
- 11:04 PM Feature #1947: add conversion support for database methods
- Greg,
The changes we made to literal processing (specifically, the "literals" function in common-progress.rules) c... - 07:07 PM Feature #1947: add conversion support for database methods
- This version of your update is merged with the latest code revision in bzr (10166), and with overlapping changes in a...
02/11/2013
- 02:10 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Ovidiu Maxiniuc wrote:
> I did that. Please see the attached update. I removed any unrelated code, only bzr + vmn_up... - 01:51 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- > I reviewed this update in combination with your 20130201a update, which was necessary to make sure I had everything...
- 12:14 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Code review 20130208a:
I reviewed this update in combination with your 20130201a update, which was necessary to ma...
02/10/2013
- 12:01 PM Feature #1947: add conversion support for database methods
- Implemented, tested and commented attributes:
BUFFER-NAME (KW_BUF_NAME),
INDEX-INFORMATION (KW_IDX_INFO)
LITERAL-QUES...
Also available in: Atom