Project

General

Profile

Activity

From 03/09/2013 to 04/07/2013

04/06/2013

10:51 AM Feature #2080: add runtime support for database methods
To display a message, use the @LogicalTerminal.message@ API from the business logic (note that each message gets wrap... Constantin Asofiei

04/05/2013

06:08 PM Feature #2080: add runtime support for database methods
Constantin Asofiei wrote:
> For cases when ERROR condition is not raised but messages are still shown, the new @di... Vadim Nebogatov
05:03 AM Feature #2080: add runtime support for database methods
> You described how to implement runtime behavior similar to 4GL in each concrete case. But my question was actually ... Constantin Asofiei
06:04 AM Feature #2092: add server-side database support for several builtin functions
chr also exist in postgress , renamed it to toChr, didn't find anything for the others. Costin Savin
04:47 AM Feature #2092: add server-side database support for several builtin functions
Added update Costin Savin
04:13 AM Feature #2092: add server-side database support for several builtin functions
It seems "replace" already is a function name in PostgreSql. I will replace "replace" with "replaceText" and search f... Costin Savin

04/04/2013

05:59 PM Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> I have attached update vmn_upd20130401a.zip/vmn_upd20130401b.zip
> It contains @FETCH-SELE... Eric Faulhaber
04:46 PM Feature #2080: add runtime support for database methods
You described how to implement runtime behavior similar to 4GL in each concrete case. But my question was actually no... Vadim Nebogatov
03:18 PM Feature #2080: add runtime support for database methods
> I still don't understand how ErrorManager will recognize what mode (silent or not) should be used. From examples I ... Constantin Asofiei
02:38 PM Feature #2080: add runtime support for database methods
Constantin Asofiei wrote:
> # add the new @ErrorManager.displayOrLogError@ API now, so you can use it for error mess... Vadim Nebogatov

04/03/2013

01:16 PM Feature #2080: add runtime support for database methods
The Text.setTemporaryCaseSensitive (actually the entire class) is extracted from the character.java class. I don't th... Constantin Asofiei
08:23 AM Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> * Please re-read the JavaDoc for @Text.setTemporaryCaseSensitive@. I'm not sure it was meant... Vadim Nebogatov
07:17 AM Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> Constantin Asofiei wrote:
>
> > Again, the testcase does not help us in determining the ... Constantin Asofiei
06:13 AM Feature #2080: add runtime support for database methods
Constantin Asofiei wrote:
> Again, the testcase does not help us in determining the NO-ERROR behavior, as a runtime ... Vadim Nebogatov

04/02/2013

12:48 PM Feature #2080: add runtime support for database methods
> > *class Date, line 1435* - note 70
> Should I fix it directly in CVS without sending special update and regressio... Constantin Asofiei
12:19 PM Feature #2080: add runtime support for database methods
Constantin Asofiei wrote:
> Please edit each case and add the value of the ERROR:NUM-MESSAGES attribute (you can add ... Vadim Nebogatov

04/01/2013

05:58 PM Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> Code review 20130328a:
>
> * Why have you commented out the re-throwing of the @reason@ T... Vadim Nebogatov
04:41 PM Feature #2080: add runtime support for database methods
I have attached update vmn_upd20130401a.zip/vmn_upd20130401b.zip
It contains @FETCH-SELECTED-ROW()@ conversion, usin... Vadim Nebogatov
11:46 AM Feature #2080: add runtime support for database methods
Please edit each case and add the value of the ERROR:NUM-MESSAGES attribute (you can add it in the same MESSAGE line ... Constantin Asofiei

03/31/2013

05:36 PM Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> Duding testing I have found out that @FETCH-SELECTED-ROW()@ conversion requires @BrowseWidg... Eric Faulhaber
05:35 PM Feature #2080: add runtime support for database methods
Code review 20130328a:
* Why have you commented out the re-throwing of the @reason@ Throwable in @BlockManager.pro... Eric Faulhaber

03/30/2013

06:45 AM Feature #2080: add runtime support for database methods

*class <Not found in code>*
Example:... Vadim Nebogatov
06:42 AM Feature #2080: add runtime support for database methods
*class <Not found in code>*
Example:... Vadim Nebogatov
06:40 AM Feature #2080: add runtime support for database methods
*class <Not found in code>*
Example:... Vadim Nebogatov
06:37 AM Feature #2080: add runtime support for database methods
*class ControlFlowOps, line 3519*
Example:... Vadim Nebogatov
05:57 AM Feature #2080: add runtime support for database methods
Moved to #2106, note 2
*class <Not found in code>*
Example:... Vadim Nebogatov
05:43 AM Feature #2080: add runtime support for database methods
Moved to #2106, note 1
*class <Not found in code>*
Example:... Vadim Nebogatov
05:29 AM Feature #2080: add runtime support for database methods
this note should be ignored according note 85
*class HandleOps, line 67*
Example:... Vadim Nebogatov
05:24 AM Feature #2080: add runtime support for database methods
*class handle, line 254*
Example:... Vadim Nebogatov
05:18 AM Feature #2080: add runtime support for database methods
Moved from #2080, notes 3,4
*class BrowseWidget, line 751*
Example:... Vadim Nebogatov
04:59 AM Feature #2080: add runtime support for database methods
*class NumberType, line 3189*
Example:... Vadim Nebogatov
04:55 AM Feature #2080: add runtime support for database methods
*class ControlFlowOps, line 3577*
Example:... Vadim Nebogatov
04:36 AM Feature #2080: add runtime support for database methods
*class ControlFlowOps, line 2991*
Example:... Vadim Nebogatov

03/29/2013

05:32 PM Feature #2080: add runtime support for database methods
*class Date, line 1435*
Example:... Vadim Nebogatov
04:48 PM Feature #2080: add runtime support for database methods
In regard to the use of an .odt document for reporting information about the errors, I prefer that you put the inform... Greg Shah
01:44 PM Feature #2080: add runtime support for database methods
I have found also that @SESSION:TIMEZONE@ is not supported (but mentioned in code).
Example is ... Vadim Nebogatov
12:43 PM Bug #2093 (Closed): VALEXP support in P2J
Eric Faulhaber
12:42 PM Bug #2093: VALEXP support in P2J
At this moment, with the exception of the cases where the expression from the string condition is not valid, I don't ... Ovidiu Maxiniuc
10:36 AM Bug #2093: VALEXP support in P2J
Is there anything left to do on this issue or can it be closed? Eric Faulhaber
10:26 AM Bug #2095 (Closed): FIELDS/EXCEPT record phrase options not honored
Eric Faulhaber
09:43 AM Bug #2097 (Closed): FOR EACH with multiple, nested CAN-FINDs converts badly
The fix has addressed the original problem and does not appear to have regressed anything else in the customer's serv... Eric Faulhaber
09:19 AM Bug #2094 (Closed): OUTER-JOIN record phrase option not honored
Eric Faulhaber

03/28/2013

06:59 PM Feature #2080: add runtime support for database methods
I have attached update vmn_upd20130328a.zip/vmn_upd20130328b.zip as replacement of vmn_upd20130326a.zip/ vmn_upd20130... Vadim Nebogatov
06:23 PM Feature #2080: add runtime support for database methods
Eric, sorry for so dangerous RecordBuffer.java. I think it was wrong bazaar merge with latest bzr revision. I do not ... Vadim Nebogatov
05:10 PM Feature #2080: add runtime support for database methods
Document with tests is updated Vadim Nebogatov
03:56 PM Feature #2080: add runtime support for database methods
Regarding vmn_upd20130326a.zip: there are hundreds of unnecessary/unwanted format changes in RecordBuffer, which mak... Eric Faulhaber
01:07 PM Feature #2080: add runtime support for database methods
Duding testing I have found out that @FETCH-SELECTED-ROW()@ conversion requires @BrowseWidget.fetchSelectedRow()@ wit... Vadim Nebogatov

03/27/2013

06:22 PM Feature #2080: add runtime support for database methods
I have attached some first test cases. Is such format would be ok?
Please notice that I found also some cases that ... Vadim Nebogatov
03:17 PM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
The update has passed conversion regression testing and is committed to bzr rev. 10333. Eric Faulhaber
02:20 PM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
A fix candidate is attached. Currently running it through conversion regression testing. Eric Faulhaber

03/26/2013

05:22 PM Feature #2080: add runtime support for database methods
I have attached update vmn_upd20130326a.zip/ vmn_upd20130326b.zip
with current state of BUFFER-COPY() and BUFFER-COM... Vadim Nebogatov
09:58 AM Feature #2080: add runtime support for database methods
I want to resolve this properly as part of this work. This includes any cases of ErrorManager.displayError() that sh... Greg Shah
03:23 PM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
Ovidiu Maxiniuc wrote:
> ...but I wonder if we shouldn't treat the first @each person@ the same like @each w-person@... Eric Faulhaber
09:57 AM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
I understand. The algorithm is working in fact if you analyze the first clause that works.
And starting from here, I... Ovidiu Maxiniuc
09:31 AM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
Ovidiu Maxiniuc wrote:
> The reason why the where clause filtered to client-side is probably the @where_clause_prep2... Eric Faulhaber
04:44 AM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
The reason why the where clause filtered to client-side is probably the @where_clause_prep2.rules@. You can read in i... Ovidiu Maxiniuc
02:53 AM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
I have isolated the #2068 note 272 regression like this:... Constantin Asofiei

03/25/2013

04:31 PM Bug #2097 (Review): FOR EACH with multiple, nested CAN-FINDs converts badly
The ecf_upd20130325e.zip update (finally) has passed conversion regression testing; there are some differences in th... Eric Faulhaber
03:56 PM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
Hopefully the final candidate; conversion regression testing it now. Eric Faulhaber
01:39 PM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
Another candidate, in conversion regression testing now. Eric Faulhaber
09:49 AM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
While there are a number of expected differences, there are also still some regressions, though far fewer than the la... Eric Faulhaber
05:37 AM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
Fix candidate for regressions. Testing now. Eric Faulhaber
04:53 AM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
This update regresses many files in Majic; cannot check it in. Eric Faulhaber
03:59 AM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
Missed a bit of cleanup in one of the files. Eric Faulhaber
03:48 AM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
A fix candidate and test cases are attached. I am currently putting the fix through conversion regression testing. ... Eric Faulhaber
03:58 PM Feature #2080: add runtime support for database methods
OK, I forgot that the ERROR attribute is set for error conditions raised when the NO-ERROR clause is used (this expla... Constantin Asofiei
03:30 PM Feature #2080: add runtime support for database methods
Constantin,
I have removed @SESSION:SUPPRESS-WARNINGS = YES.@ and started from command line. But it did not affect ... Vadim Nebogatov
05:42 AM Feature #2080: add runtime support for database methods
I do not understand which line of code generates the 9039 and 12860 messages. Please remove the @SESSION:SUPPRESS-WAR... Constantin Asofiei
01:01 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
The current fix doesn't work for all cases, e.g.:
1. REPEAT PRESELECT.
2. DEFINE QUERY.
Note that FIELDS/EXCEP... Stanislav Lomany
11:42 PM Bug #2095 (Review): FIELDS/EXCEPT record phrase options not honored
The update has passed conversion regression testing and I have committed it to bzr rev. 10329. Eric Faulhaber
10:43 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
The update looks good to me. I am running conversion regression testing on it now. Eric Faulhaber
08:00 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
Fixes the cases specified in note #2. Probably fixes all other cases too. Stanislav Lomany

03/24/2013

05:33 PM Bug #2101 (Closed): multi-buffer FOR loop with rowid and to-rowid functions in WHERE clause not c...
I've compared conversions of the customer's server project with and without this fix and it seems correct in all the ... Eric Faulhaber
09:46 PM Bug #2101 (Review): multi-buffer FOR loop with rowid and to-rowid functions in WHERE clause not c...
Update ecf_upd20130323a.zip has passed conversion regression testing and is committed to bzr rev. 10325. Eric Faulhaber
08:23 PM Bug #2101: multi-buffer FOR loop with rowid and to-rowid functions in WHERE clause not converting...
Although I'm not the assignee, in having to think through the problem for the above post, I took a quick look at the ... Eric Faulhaber
05:27 PM Bug #2094: OUTER-JOIN record phrase option not honored
BTW, location of the original problem is pmplan/gapptfn5.p.cache, line 700. Eric Faulhaber
05:25 PM Bug #2094 (Review): OUTER-JOIN record phrase option not honored
Passed conversion regression testing, committed to bzr revision 10328. I'll do a separate server folder conversion wi... Constantin Asofiei
05:03 PM Bug #2094: OUTER-JOIN record phrase option not honored
Change looks good to me. Please check in and distribute if/when it passes conversion regression testing. Eric Faulhaber
04:04 PM Bug #2094 (WIP): OUTER-JOIN record phrase option not honored
Constantin Asofiei
03:47 PM Bug #2094: OUTER-JOIN record phrase option not honored
Properly handles the @OUTER-JOIN@ and @LEFT OUTER-JOIN@ to convert the same. Constantin Asofiei
03:37 PM Bug #2094: OUTER-JOIN record phrase option not honored
This update adds support for the OUTER-JOIN clause for a record phrase. -The LEFT OUTER-JOIN will not emit anything.-... Constantin Asofiei
10:09 PM Bug #2094: OUTER-JOIN record phrase option not honored
The following:... Eric Faulhaber
05:10 PM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
I'm working toward what I think the correct conversion would be:... Eric Faulhaber
04:29 PM Feature #2080: add runtime support for database methods
Constantin, I use ErrorManager.recordOrThrowError.
In my example above, 4GL meets errors 9039 and 12860 with differ... Vadim Nebogatov
07:29 AM Feature #2080: add runtime support for database methods
PS: about @SESSION:SUPPRESS-WARNINGS = YES.@. Note that in the 4GL editor, if you run a program which doesn't set the... Constantin Asofiei
07:26 AM Feature #2080: add runtime support for database methods
> Another observation. Not all 4GL errors throw “exceptions”, some of them look like not critical errors or warnings,... Constantin Asofiei
07:20 AM Feature #2080: add runtime support for database methods
Another observation. Not all 4GL errors throw “exceptions”, some of them look like not critical errors or warnings, e... Vadim Nebogatov
03:53 AM Feature #2080: add runtime support for database methods
> Conversion code should also support this option, returning value if ON-ERROR is set (current behaviour) and propaga... Constantin Asofiei
03:51 AM Feature #2080: add runtime support for database methods
Constantin: yes, it is just switch in behavior I was looking.
Conversion code should also support this option, retur... Vadim Nebogatov
03:07 AM Feature #2080: add runtime support for database methods
Eric/Vadim: there is another way to supress the 4GL's errors, the @NO-ERROR@ clause. When trying to understand when a... Constantin Asofiei
02:02 AM Feature #2080: add runtime support for database methods
Yes, I also think so. Return value has no sense if 4gl propagates its "exceptions". I only thought that maybe this pr... Vadim Nebogatov
09:26 PM Feature #2080: add runtime support for database methods
This indicates that the idiom of:... Eric Faulhaber
10:11 PM Bug #2084 (Closed): Conversion misplaced parameter for can-find statement
Eric Faulhaber
10:10 PM Feature #2000 (Closed): add conversion support for table and table handle parameters
Eric Faulhaber
09:49 PM Feature #2092 (Closed): add server-side database support for several builtin functions
Eric Faulhaber

03/23/2013

06:54 PM Feature #1668: add support for additional (non-dynamic) database attributes
This update has passed conversion regression testing (CA 0323d used deleteRecord for the "quick_delete" loops, instea... Constantin Asofiei
12:58 PM Feature #1668: add support for additional (non-dynamic) database attributes
ca_upd20130323d.zip update looks good to me. If it passes conversion regression testing (expect some changes to Maji... Eric Faulhaber
12:52 PM Feature #1668: add support for additional (non-dynamic) database attributes
Replaces ca_upd2013023a.zip, and has the changes from note 105. Constantin Asofiei
12:33 PM Feature #1668: add support for additional (non-dynamic) database attributes
You are not missing anything, this is the first time I touch embedded sqls, so that's why the questions. Now I have a... Constantin Asofiei
12:30 PM Feature #1668: add support for additional (non-dynamic) database attributes
This refers to:... Eric Faulhaber
12:23 PM Feature #1668: add support for additional (non-dynamic) database attributes
For embedded SQL, I was referring to this rule in convert/database_access:... Constantin Asofiei
12:19 PM Feature #1668: add support for additional (non-dynamic) database attributes
Let's use:... Eric Faulhaber
11:38 AM Feature #1668: add support for additional (non-dynamic) database attributes
Eric: the ca_upd20130323a.zip has regressions. I see that the Buffer.delete API is used by other cases, like DELETE s... Constantin Asofiei
10:23 AM Feature #1668: add support for additional (non-dynamic) database attributes
This update changes the API for BUFFER-DELETE to deleteRecord, because else will collide with the resource's delete()... Constantin Asofiei
06:53 PM Feature #2080: add runtime support for database methods
Also I have noticed the difference in behavior of 4GL and converted code.
I am comparing a lot of tests in the form... Vadim Nebogatov
06:50 PM Bug #2101: multi-buffer FOR loop with rowid and to-rowid functions in WHERE clause not converting...
This issue was first reported in note 192 of #2068.
The following converts badly:... Eric Faulhaber
06:34 PM Bug #2101 (Closed): multi-buffer FOR loop with rowid and to-rowid functions in WHERE clause not c...
Eric Faulhaber

03/22/2013

05:38 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
> I still think the include/exclude call should directly follow the associated addComponent call. I think it is easie... Stanislav Lomany
05:31 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
I guess there's one more option; chain the call, as in:... Eric Faulhaber
05:04 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
So if the full list of options is:
1. Add the list of fields to query c'tor / addComponent
2. include(String ...) -... Stanislav Lomany
04:34 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
Stanislav Lomany wrote:
> For a multi-table query the buffer should be specified, but as an option we can have quali... Eric Faulhaber
04:28 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
For a multi-table query the buffer should be specified, but as an option we can have qualified field names:... Stanislav Lomany
03:32 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
OK, but please emit this method immediately after the associated @addComponent@ call.
> ... Eric Faulhaber
03:07 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
Unless someone has objections, for multi-component queries, I'll make include/exclude methods of the parent query:
<... Stanislav Lomany
11:42 AM Bug #2095: FIELDS/EXCEPT record phrase options not honored
> Removes FIELDS/EXCEPT nodes.
Thanks, I'm starting server folder conversion, hope nothing new will appear. Constantin Asofiei
11:36 AM Bug #2095: FIELDS/EXCEPT record phrase options not honored
Removes FIELDS/EXCEPT nodes. Stanislav Lomany
10:38 AM Bug #2095: FIELDS/EXCEPT record phrase options not honored
OK Stanislav Lomany
10:14 AM Bug #2095: FIELDS/EXCEPT record phrase options not honored
Stanislav: if it doesn't take you long to build some rules which just drop/hide the FIELDS/EXCEPT nodes (so they will... Constantin Asofiei
02:32 PM Feature #1668: add support for additional (non-dynamic) database attributes
Costin Savin wrote:
> Well theoreticaly it is already there because both Buffer and TempTable extend it, but probabl... Constantin Asofiei
02:32 PM Feature #1668: add support for additional (non-dynamic) database attributes
Well theoreticaly it is already there because both Buffer and TempTable extend it, but probably it's good to see it i... Costin Savin
02:12 PM Feature #1668: add support for additional (non-dynamic) database attributes
Costin, regarding cs_upd20130322b.zip - you forgot to add the new interface to HandleCommon. Please put it right afte... Constantin Asofiei
01:43 PM Feature #1668: add support for additional (non-dynamic) database attributes
Commited as revision number 10317 Costin Savin
01:07 PM Feature #1668: add support for additional (non-dynamic) database attributes
cs_upd20130322b.zip has passed conversion regression testing. Please check it in and distribute. Eric Faulhaber
10:54 AM Feature #1668: add support for additional (non-dynamic) database attributes
cs_upd20130322b.zip looks good. I am putting it through conversion regression testing.
It does look like we still... Eric Faulhaber
08:21 AM Feature #1668: add support for additional (non-dynamic) database attributes
Added proposed update for missing addFieldToIndex methods. Moved the defaultBufferHandle() method form the Buffer int... Costin Savin
05:06 AM Feature #1668: add support for additional (non-dynamic) database attributes
This class evolved a little. The @defaultBufferHandle()@ (implementation of @DEFAULT-BUFFER-HANDLE@) was at the begin... Ovidiu Maxiniuc
04:35 AM Feature #1668: add support for additional (non-dynamic) database attributes
> ADMData was my mistake (should have not added it, as I don't see the ADM-DATA attribute defined for the temp-table ... Constantin Asofiei
02:15 PM Feature #2080: add runtime support for database methods
I have noticed from testing in 4GL that error message... Vadim Nebogatov
10:46 AM Feature #1947: add conversion support for database methods
CA 0322c.zip was committed to bzr revision 10315 and CA 0322e.zip to 10316. Constantin Asofiei
10:40 AM Feature #1947: add conversion support for database methods
Both updates look good, please check them in. Eric Faulhaber
09:30 AM Feature #1947: add conversion support for database methods
Both 0322c.zip and 0322e.zip have passed conversion regression testing. Constantin Asofiei
07:42 AM Feature #1947: add conversion support for database methods
Adds missing @queryRows(integer)@ API. Constantin Asofiei
06:49 AM Feature #1947: add conversion support for database methods
Solved note 151 by always expanding array vars passed to the REPOSITION-TO-ROWID method. This avoids adding an @query... Constantin Asofiei
06:06 AM Feature #1947: add conversion support for database methods
I'm working on note 151. Constantin Asofiei
05:23 AM Feature #1947: add conversion support for database methods
See note 202 from #2068, which documents a server failure. Note that the @REPOSITION-TO-ROWID@ can accept mixed exten... Constantin Asofiei
10:24 AM Feature #2000: add conversion support for table and table handle parameters
ca_upd20130322g.zip committed to bzr revision 10214. Constantin Asofiei
09:15 AM Feature #2000: add conversion support for table and table handle parameters
The code looks fine. If it passes testing, check it in and distribute it. Greg Shah
09:11 AM Feature #2000: add conversion support for table and table handle parameters
Fixes a regression in the TABLE-HANDLE parameter conversion, introduced by 10293. Constantin Asofiei
08:55 AM Feature #2000: add conversion support for table and table handle parameters
OK, I'll look at it. Constantin Asofiei
08:15 AM Feature #2000: add conversion support for table and table handle parameters
It has been regressed since revision 10279.
Correct output is:... Stanislav Lomany
07:38 AM Feature #2000: add conversion support for table and table handle parameters
Stanislav: did this convert properly after you added TABLE-HANDLE parameter support?... Constantin Asofiei
08:18 AM Feature #2092: add server-side database support for several builtin functions
Go ahead and check this in immediately (and distribute it). It has no effect on conversion and it is already being r... Greg Shah
07:07 AM Feature #2092: add server-side database support for several builtin functions
Removed the extra ' character from p2jpl.ddr at line 699 Costin Savin

03/21/2013

03:54 PM Feature #1668: add support for additional (non-dynamic) database attributes
From the TEMP-TABLE attributes the following are not implemented in any interface:
AFTER-TABLE, BEFORE-TABLE, DATA... Costin Savin
01:54 PM Feature #1668: add support for additional (non-dynamic) database attributes
Eric/Costin: there is one more thing we should do - identify all attributes which are already defined by interfaces (... Constantin Asofiei
01:49 PM Feature #1668: add support for additional (non-dynamic) database attributes
> So, Costin: please remove Buffer and ADMData from the TempTable interface and post here what method stubs are still... Costin Savin
01:42 PM Feature #1668: add support for additional (non-dynamic) database attributes
So, Costin: please remove Buffer and ADMData from the TempTable interface and post here what method stubs are still ... Eric Faulhaber
01:39 PM Feature #1668: add support for additional (non-dynamic) database attributes
Constantin Asofiei wrote:
> Why is TempTable interface extending Buffer, ADMData and UniqueID interfaces?
Good qu... Eric Faulhaber
01:38 PM Feature #1668: add support for additional (non-dynamic) database attributes
ADMData was my mistake (should have not added it, as I don't see the ADM-DATA attribute defined for the temp-table re... Constantin Asofiei
01:31 PM Feature #1668: add support for additional (non-dynamic) database attributes
Eric/Ovidiu/Costin: the interfaces extended by TempTable don't look OK. In the docs, the temp-table resource can acce... Constantin Asofiei
01:30 PM Feature #1668: add support for additional (non-dynamic) database attributes
Costin Savin wrote:
> > That's strange, all the TempTable methods should be implemented in TempTableBuilder, AFAIK. ... Eric Faulhaber
01:25 PM Feature #1668: add support for additional (non-dynamic) database attributes
> That's strange, all the TempTable methods should be implemented in TempTableBuilder, AFAIK. I don't know why they a... Costin Savin
12:55 PM Feature #1668: add support for additional (non-dynamic) database attributes
Vadim, your 20130321a update has passed conversion regression testing. Please check it in (and the test case) and di... Eric Faulhaber
11:50 AM Feature #1668: add support for additional (non-dynamic) database attributes
Ovidiu Maxiniuc wrote:
> > That's strange, all the TempTable methods should be implemented in TempTableBuilder, AFAI... Eric Faulhaber
11:36 AM Feature #1668: add support for additional (non-dynamic) database attributes
Code review 20130321a:
Looks good, I'm putting it through conversion regression test now. Eric Faulhaber
10:59 AM Feature #1668: add support for additional (non-dynamic) database attributes
Update vmn_upd20130321a.zip (vmn_upd20130321b.zip - conversion test) is replacement of vmn_upd20130320a.zip (vmn_upd2... Vadim Nebogatov
09:17 AM Feature #1668: add support for additional (non-dynamic) database attributes
> That's strange, all the TempTable methods should be implemented in TempTableBuilder, AFAIK. I don't know why they ... Ovidiu Maxiniuc
06:55 AM Feature #1668: add support for additional (non-dynamic) database attributes
> Please post your test case.
I used the pers-addr table from p2j_test and created a temp table like pers-addr and... Costin Savin
02:20 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
Stanislav Lomany wrote:
> Do I need to ensure that there are no duplicates in the converted list (e.g. if we are con... Eric Faulhaber
02:01 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
It is possible to reference an element of an extent field. The progress documentation says that "If field is an array... Stanislav Lomany
11:21 AM Bug #2095 (WIP): FIELDS/EXCEPT record phrase options not honored
Stanislav Lomany
09:51 AM Feature #2000 (Review): add conversion support for table and table handle parameters
Stanislav Lomany

03/20/2013

06:05 PM Feature #1668: add support for additional (non-dynamic) database attributes
Code review 20130320a:
All looks good except QueryWrapper: the new @numBuffers@ method implementation should dele... Eric Faulhaber
05:38 PM Feature #1668: add support for additional (non-dynamic) database attributes
Update vmn_upd20130320a.zip (vmn_upd20130320b.zip - conversion test) contains correction of NUM-BUFFERS()(KW_NUM_BUFF... Vadim Nebogatov
02:07 PM Feature #1668: add support for additional (non-dynamic) database attributes
Costin Savin wrote:
> Tested this case, The result is a runtime error message: @"Third argument to ADD-INDEX-FIELD m... Eric Faulhaber
02:05 PM Feature #1668: add support for additional (non-dynamic) database attributes
> Write a test case and see what happens if you pass in something other than "asc" or "desc" as the last parameter. D... Costin Savin
01:07 PM Feature #1668: add support for additional (non-dynamic) database attributes
Costin Savin wrote:
> there are only these methods defined in the TempTable interface:
> public logical addFieldTo... Eric Faulhaber
12:37 PM Feature #1668: add support for additional (non-dynamic) database attributes
For:... Costin Savin
02:38 PM Feature #2092: add server-side database support for several builtin functions
Update cs_upd20130320a1.zip has passed conversion regression testing and is committed to bzr rev. 10301. Eric Faulhaber
01:29 PM Feature #2092: add server-side database support for several builtin functions
Code review 20130320a:
This one is mostly correct, except for the following:
* @Functions.minimum(Date var1, Date... Eric Faulhaber
11:55 AM Feature #2092: add server-side database support for several builtin functions
Added proposed update, for the testcase it seems you can't define a field as rowid in 4gl so I modified that part.
W... Costin Savin
05:35 AM Feature #2092: add server-side database support for several builtin functions
Costin: the test you've uploaded doesn't work with the repository p2j_test.df schema definition. When modifying the p... Constantin Asofiei

03/19/2013

04:29 PM Feature #2092: add server-side database support for several builtin functions
Code review 20130319a:
* common-progress.rules: changes look good, but see comment below about max/min.
* where-... Eric Faulhaber
02:29 PM Feature #2092: add server-side database support for several builtin functions
Re-arranged the code , solved the reviewed problems and merged with latest updates.
Testcase used to check convers... Costin Savin
01:29 AM Feature #2092: add server-side database support for several builtin functions
Costin Savin wrote:
> Added merged update.
> Are there any other functions that need to be added? I saw DATETIME an... Eric Faulhaber
01:11 PM Feature #1668: add support for additional (non-dynamic) database attributes
Constantin Asofiei wrote:
> For this, I think we should add a @P2JQuery.tableCount@ API which returns @integer@ and ... Eric Faulhaber
07:30 AM Feature #1668: add support for additional (non-dynamic) database attributes
Eric,
> * num-buffers [KW_NUM_BUFF] (seems buggy) (I think this should map to P2JQuery.getTableCount, which already ... Constantin Asofiei
07:57 AM Bug #2093: VALEXP support in P2J
The AST is slightly different with last revision from bzr:... Ovidiu Maxiniuc
07:20 AM Bug #2093: VALEXP support in P2J
Please check the failed case in the previous note with the latest #1620 fix, if you haven't done already so. Constantin Asofiei
07:09 AM Bug #2093: VALEXP support in P2J
Everything seems to work smooth, validation is only generated in @schema-validation@:... Ovidiu Maxiniuc
04:03 AM Bug #2093: VALEXP support in P2J
Ovidiu: with the #1620 changes, I can't see any more schema VALEXP problems in the logs (I think P2J was too aggressi... Constantin Asofiei

03/18/2013

03:39 PM Feature #2080: add runtime support for database methods
Update vmn_upd20130318a.zip (vmn_upd20130318b.zip - tests) contains runtime support for BUFFER-COMPARE and some prepa... Vadim Nebogatov
11:36 AM Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
This issue stems from note 127 in #2068.
The following code:... Eric Faulhaber
11:16 AM Bug #2097 (Closed): FOR EACH with multiple, nested CAN-FINDs converts badly
Eric Faulhaber
08:23 AM Feature #2092: add server-side database support for several builtin functions
Added merged update.
Are there any other functions that need to be added? I saw DATETIME and DATETIME-TZ which fit t... Costin Savin
06:34 AM Feature #2092: add server-side database support for several builtin functions
After some tests it seems that min and max can be applied also to character and date variables, not only numeric valu... Costin Savin
04:31 AM Feature #2092 (Review): add server-side database support for several builtin functions
Costin Savin
04:31 AM Feature #2092 (WIP): add server-side database support for several builtin functions
Costin Savin
12:12 AM Bug #2059 (Closed): CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a...
Eric Faulhaber

03/17/2013

03:42 PM Bug #2077 (Closed): fix converted table and field name collisions
Eric Faulhaber
03:32 PM Bug #2084 (Review): Conversion misplaced parameter for can-find statement
Eric Faulhaber
03:31 PM Bug #2084: Conversion misplaced parameter for can-find statement
The net effect of the cs_upd20130314a.zip update is that the correct Java output is produced, but the change still le... Eric Faulhaber

03/16/2013

10:24 AM Feature #2092: add server-side database support for several builtin functions
Added proposed update,
For ROWID I didn't knew how a ROWID data type it's represented in the database so I assumed ... Costin Savin

03/15/2013

05:13 PM Feature #2080: add runtime support for database methods
Constantin's advice has gotten you past the immediate handle problem, but please re-read note 9. The runtime impleme... Eric Faulhaber
05:11 PM Feature #2080: add runtime support for database methods
Yes, it works, thank you Vadim Nebogatov
04:53 PM Feature #2080: add runtime support for database methods
Vadim, I don't think the runtime for the CREATE BUFFER statement is implemented. Try this instead:... Constantin Asofiei
04:41 PM Feature #2080: add runtime support for database methods
It seems, ... Vadim Nebogatov
12:09 PM Feature #2080: add runtime support for database methods
update [vmn_upd20130314a.zip]
Refs #2080, checked in as bzr revision 10291.
Corrected runtime for BUFFER-COPY (KW_B... Vadim Nebogatov
11:52 AM Feature #2080: add runtime support for database methods
> Constantin: can you just pick up common-progress.rules from bzr and merge your quoter changes in?
OK, I'll wait f... Constantin Asofiei
11:49 AM Feature #2080: add runtime support for database methods
Vadim: the 20130314a update looks good. Please go ahead and commit it to bzr.
Constantin: can you just pick up ... Eric Faulhaber
11:39 AM Feature #2080: add runtime support for database methods
Constantin Asofiei wrote:
> Vadim, have you done the changes at notes #29? If yes, please upload just the common-pro... Vadim Nebogatov
11:37 AM Feature #2080: add runtime support for database methods
Vadim, have you done the changes at notes #29? If yes, please upload just the common-progress.rules file. If not, I c... Constantin Asofiei
11:08 AM Feature #2080: add runtime support for database methods
Yes, the pairs parameter is in use. Eric Faulhaber
11:00 AM Feature #2080: add runtime support for database methods
What about pairs in RecordBuffer.compare()? Should it be supported? Vadim Nebogatov
10:39 AM Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> I am implementing now RecordBuffer.compare(Buffer buffer, character mode, character except,... Eric Faulhaber
08:46 AM Feature #2080: add runtime support for database methods
I am implementing now RecordBuffer.compare(Buffer buffer, character mode, character except, character pairs) similar... Vadim Nebogatov
01:27 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
BTW, since multi-table queries also implement P2JQuery indirectly, they should throw UnsupportedOperationException fo... Eric Faulhaber
01:20 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
The runtime API will look like:... Eric Faulhaber
12:41 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
The use cases we must support:... Eric Faulhaber
12:16 PM Bug #2095: FIELDS/EXCEPT record phrase options not honored
Paraphrased from #2068:
Looks like P2J doesn't like the FIELDS clause, because with it, the fields get emitted as ... Eric Faulhaber
12:12 PM Bug #2095 (Closed): FIELDS/EXCEPT record phrase options not honored
Eric Faulhaber
12:30 PM Bug #2084: Conversion misplaced parameter for can-find statement
Eric: I've put this through conversion regression testing (which has passed) plus server folder conversion, and I don... Constantin Asofiei
12:11 PM Bug #2094 (Closed): OUTER-JOIN record phrase option not honored
Eric Faulhaber
12:06 PM Bug #2093: VALEXP support in P2J
This issue is dedicated to note 80 from Issue #2068.
> There is this validation expression for the @dvofrsts.dvofr... Ovidiu Maxiniuc
11:57 AM Bug #2093 (Closed): VALEXP support in P2J
Ovidiu Maxiniuc
02:06 AM Feature #2092: add server-side database support for several builtin functions
The following builtin functions are used within where clauses in queries and thus need to be supported as database se... Eric Faulhaber
01:14 AM Feature #2092 (Closed): add server-side database support for several builtin functions
Eric Faulhaber

03/14/2013

05:44 PM Feature #2080: add runtime support for database methods
What methods are priority for now? Vadim Nebogatov
05:43 PM Feature #2080: add runtime support for database methods
Attached update vmn_upd20130314a.zip (vmn_upd20130314b.zip - tests).
This update is replacement vmn_upd20130312a.z... Vadim Nebogatov
03:12 PM Feature #2080: add runtime support for database methods
for note 22:
> Constantin: you didn't already do this, right?
No, I have not changed the @Buffer.findXXXX@ APIs
for ... Constantin Asofiei
03:46 PM Bug #2084: Conversion misplaced parameter for can-find statement
Went back and searched for another solution, since the last one started from the wrong premise that can-find BUFFER_S... Costin Savin
03:35 PM Bug #2084: Conversion misplaced parameter for can-find statement
Costin, please provide a detailed update of what you have found/done on this today. Eric Faulhaber

03/13/2013

06:06 PM Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> Will be ast processing with rules also required with wrapping String to character?
Const... Eric Faulhaber
04:49 PM Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> With your next update, please replace the predicate data type of @String@ in all the @Buff... Vadim Nebogatov
03:23 PM Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> Eric Faulhaber wrote:
> > One question: why not just implement @AbstractQuery.queryReposi... Eric Faulhaber
03:18 PM Feature #2080: add runtime support for database methods
Low priority: related to my last note, we are using the wrong data type for the NO-LOBS parameter in our bufferCopy/... Eric Faulhaber
03:16 PM Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> One question: why not just implement @AbstractQuery.queryReposition(NumberType n)@ as
> [.... Vadim Nebogatov
02:07 PM Feature #2080: add runtime support for database methods
The current project never uses the NO-LOBS parameter of BUFFER-COPY and BUFFER-COMPARE, so the variants of @BufferImp... Eric Faulhaber
01:46 PM Feature #2080: add runtime support for database methods
Code review 20130312a:
Update looks fine.
Good catch on the @queryReposition@ method. One question: why not j... Eric Faulhaber
11:10 AM Feature #2080: add runtime support for database methods
I suspect that much of the use we will see of this feature will involve expressions resolving to character values (si... Eric Faulhaber
05:40 AM Feature #2080: add runtime support for database methods
The FIND-FIRST/LAST/UNIQUE methods can receive a character for the first parameter. Currently, the Buffer.find* imple... Constantin Asofiei
03:13 PM Bug #2084: Conversion misplaced parameter for can-find statement
Tried to replicate the test which failed on update cs_upd20130312a.zip (-where- before I moved the logic from post-ru... Costin Savin
11:09 AM Bug #2084: Conversion misplaced parameter for can-find statement
The testcase from note 11 passed, there was another file from conversion regression tests that failed (with the remap... Costin Savin
10:53 AM Bug #2084: Conversion misplaced parameter for can-find statement
I haven't looked at this issue in detail nor tried to reproduce the problem yet, but the last update you sent looks w... Eric Faulhaber
08:11 AM Bug #2084: Conversion misplaced parameter for can-find statement
There seems to be a problem with some buffers being used in different db schemas,
after the change it seems the buff... Costin Savin
05:25 AM Bug #2084: Conversion misplaced parameter for can-find statement
There are changes in two files with this update, I think they are expected, but Costin is checking them now. Constantin Asofiei
02:14 AM Bug #2090 (Closed): correct sorting of DMO properties during schema conversion
Eric Faulhaber

03/12/2013

05:20 PM Feature #2080: add runtime support for database methods
Current status of methods from ref 1947
Implemented:
GET-CURRENT (KW_GET_CUR)
FIND-LAST (KW_FIND_LST)
FIND-FIRST ... Vadim Nebogatov
05:19 PM Feature #2080: add runtime support for database methods
Attached update vmn_upd20130312a.zip.
Corrected runtime for BUFFER-COPY (KW_BUF_COPY) and BUFFER-COMPARE (KW_BUF_CO... Vadim Nebogatov
04:40 PM Feature #2080: add runtime support for database methods
Yes, I handed my changes off to Constantin a few days ago, based on an older version, to integrate with some other ch... Eric Faulhaber
04:26 PM Feature #2080: add runtime support for database methods
Eric, I corrected BufferImpl.bufferCompare according #12, but noticed that you replaced function body with ... Unsupp... Vadim Nebogatov
06:22 AM Feature #2080: add runtime support for database methods
Tests
uast/find-with-locks.p
uast/get-with-locks.p
committed revision 991.
 Vadim Nebogatov
05:01 AM Feature #2080: add runtime support for database methods
vmn_upd20130311c.zip checked in as bzr revision 10278. Vadim Nebogatov
08:58 PM Feature #2080: add runtime support for database methods
Update vmn_upd20130311c.zip has passed conversion regression testing. Please commit it to bzr and distribute. Note ... Eric Faulhaber
03:37 PM Bug #2083: client-side where-clause leak in FindQuery
This fix looks good to me. I have merged it with the latest bzr revision, re-run conversion regression testing with ... Eric Faulhaber
01:36 PM Bug #2083: client-side where-clause leak in FindQuery
I see you found another solution.
I also found one simple and straightforward solution by refining the condition f... Ovidiu Maxiniuc
12:19 PM Bug #2083: client-side where-clause leak in FindQuery
Ovidiu, I was having many similar issues with client-side query substitution parameters and CAN-FIND while fixing #20... Eric Faulhaber
02:33 PM Bug #2084: Conversion misplaced parameter for can-find statement
Added proposed update
It seems the problem is in some situation the remap scope is deleted before we get into the <p... Costin Savin
11:28 AM Bug #2084: Conversion misplaced parameter for can-find statement
It seems there are still some weird cases where it fails. Working on reproducing and fixing it Costin Savin
04:54 AM Bug #2084: Conversion misplaced parameter for can-find statement
I'm sorry about that, it seems I forgot to save after doing the clean-up, and created the archive with some unwanted ... Costin Savin
09:54 PM Bug #2084: Conversion misplaced parameter for can-find statement
Code review 20130311a:
* Do you have a test case that illustrates the problem described by Constantin in notes 5 a... Eric Faulhaber
01:17 PM Bug #2059: CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a FOR EACH...
Update has passed conversion regression testing and is committed to bzr rev. 10280. Eric Faulhaber
12:14 PM Bug #2059: CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a FOR EACH...
Fix candidate is attached. I am conversion regression testing this now. Eric Faulhaber
10:15 PM Feature #2000: add conversion support for table and table handle parameters
Code looks good, AFAICT, but without test cases and being able to look at the ASTs, the changes were hard to follow, ... Eric Faulhaber

03/11/2013

06:30 PM Feature #2080: add runtime support for database methods
Code review 20130311c:
The merge looks fine. The implementation of @BufferImpl.bufferCompare@ doesn't look right. ... Eric Faulhaber
05:00 PM Feature #2080: add runtime support for database methods
Attached update
vmn_upd20130311c.zip
vmn_upd20130311d.zip (corresponding test cases)
is next replacement of vm... Vadim Nebogatov
04:26 PM Feature #2080: add runtime support for database methods
P2JQuery,
** 040 CA 20130311 Added bufferHandle(integer).
It seems wrong number Vadim Nebogatov
03:08 PM Feature #2080: add runtime support for database methods
Code review 20130311a:
The changes all look good.
I noticed on this second review that even the no-arg versions... Eric Faulhaber
10:01 AM Feature #2080: add runtime support for database methods
Attached update
vmn_upd20130311a.zip
vmn_upd20130311b.zip (corresponding test cases)
is replacement of vmn_upd2013... Vadim Nebogatov
06:20 PM Feature #2000: add conversion support for table and table handle parameters
Regression conversion completed without errors. Stanislav Lomany
03:42 PM Feature #2000: add conversion support for table and table handle parameters
> Is this merged up to the latest bzr revision?
Yes, it is merged. Stanislav Lomany
02:59 PM Feature #2000: add conversion support for table and table handle parameters
Is this merged up to the latest bzr revision?
If so, please do run conversion regression testing. Eric will do a ... Greg Shah
02:32 PM Feature #2000: add conversion support for table and table handle parameters
Update for TABLE-HANDLE FOR case. Should I regression-test it? Stanislav Lomany
03:32 PM Bug #2083: client-side where-clause leak in FindQuery
The @<action>sibref.setHidden(true)</action>@ from @where_clause_post.rules@ at line 438 from my previous update seem... Ovidiu Maxiniuc
11:24 AM Bug #2083: client-side where-clause leak in FindQuery
After some more tests, it seems like this update does not fix the issue, in fact it is too restrictive, it will cut m... Ovidiu Maxiniuc
06:07 AM Bug #2083: client-side where-clause leak in FindQuery
With help from Constantin, the missing @setHidden@ is now in place. Ovidiu Maxiniuc
01:46 PM Bug #2084: Conversion misplaced parameter for can-find statement
Added proposed update which checks if the javaname is marked for remap but not as a generated increment name. Costin Savin
11:05 AM Feature #1947: add conversion support for database methods
Added missing API bufferHandle(integer). Committed to bzr revision -10276- 10277. Constantin Asofiei

03/10/2013

03:29 PM Feature #1668: add support for additional (non-dynamic) database attributes
Update ecf_upd20130308a.zip has passed conversion regression testing and is committed as bzr rev. 10274. Eric Faulhaber

03/09/2013

09:11 AM Bug #2083: client-side where-clause leak in FindQuery
I couldn't get my mind of client_taint and I took a quick look where is used. In where_clause_post.rules, at line 413... Constantin Asofiei
 

Also available in: Atom