Project

General

Profile

Activity

From 04/24/2013 to 05/23/2013

05/23/2013

05:42 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
It looks like the single way to update ORM at runtime is to create/update @Configuration@ object and build a new @Ses... Stanislav Lomany
05:28 PM Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> I think you need to execute the FindQuery with silent error mode enabled, then return the res...
Vadim Nebogatov
04:56 PM Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> Please help me understand the need for the ErrorIfNull enum and the changes to @RecordBuffer...
Vadim Nebogatov
04:45 PM Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> Vadim Nebogatov wrote:
> > I thought these methods are still not implemented properly and p...
Vadim Nebogatov
12:39 AM Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> Eric Faulhaber wrote:
> > I think you need to execute the FindQuery with silent error mode...
Eric Faulhaber
04:17 PM Bug #2090: correct sorting of DMO properties during schema conversion
Please see the attached fix. At this time, I think the DataModelWorker solved the symptom, and not the cause. Idea is... Constantin Asofiei
12:54 PM Bug #2090 (WIP): correct sorting of DMO properties during schema conversion
Constantin Asofiei
08:27 AM Bug #2090: correct sorting of DMO properties during schema conversion
Good work.
Please go ahead and work this. Right now, the code as we have it checked into bzr can't properly conve...
Greg Shah
08:15 AM Bug #2090: correct sorting of DMO properties during schema conversion
I can confirm this is a real problem. This is the case in dan/Dec.java:... Constantin Asofiei
08:03 AM Bug #2090: correct sorting of DMO properties during schema conversion
Attached the DataModelWorker changes. Constantin Asofiei

05/22/2013

05:56 PM Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> I think you need to execute the FindQuery with silent error mode enabled, then return the re...
Vadim Nebogatov
02:46 PM Feature #2080: add runtime support for database methods
I think you need to execute the FindQuery with silent error mode enabled, then return the result of @ErrorManager.isE... Eric Faulhaber
12:50 PM Bug #2090: correct sorting of DMO properties during schema conversion
How much time is estimated to be needed to check this? Greg Shah
10:59 AM Bug #2090: correct sorting of DMO properties during schema conversion
The remaining problem here is that this fix changes the widget order for some "display temp-buffer." cases in MAJIC. ... Constantin Asofiei

05/21/2013

04:34 AM Feature #2080: add runtime support for database methods
I am comparing and fixing differences with 4GL and P2J error handling after I implemented method FIND-BY-ROWID as
<p...
Vadim Nebogatov

05/20/2013

01:42 PM Feature #1911: add runtime support for sequences
I've changed the H2 and PostgreSQL dialects to not use quoted sequence names, so that we are not forcing case-sensiti... Eric Faulhaber

05/16/2013

12:17 PM Feature #2080: add runtime support for database methods
Code review 20130510:
Update looks fine. However, since the change really isn't about the BUFFER-RELEASE method s...
Eric Faulhaber

05/13/2013

06:20 PM Feature #2080: add runtime support for database methods
I have attached update vmn_upd20130513a.zip/vmn_upd20130513b.zip
Fixed properties comparing with extent: isAssignabl...
Vadim Nebogatov
01:16 PM Feature #2080: add runtime support for database methods
Yes, I just do with this way Vadim Nebogatov
12:47 PM Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> Difference related with transaction absense is found in error handling of @BUFFER-CREATE()@...
Eric Faulhaber
12:42 PM Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> One more question: do we plan to support @tenant-expression@ parameter for BUFFER-CREATE me...
Eric Faulhaber

05/12/2013

05:30 PM Feature #2080: add runtime support for database methods
Difference related with transaction absense is found in error handling of @BUFFER-CREATE()@ method:... Vadim Nebogatov
05:03 PM Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> Try
> def var log as logical no-undo.
Thanks, it works!
One more question: do we plan ...
Vadim Nebogatov
02:00 PM Feature #2080: add runtime support for database methods
Try... Eric Faulhaber

05/11/2013

05:13 PM Feature #2080: add runtime support for database methods
Strange example for buffer-create() method. ... Vadim Nebogatov
04:13 PM Feature #2080: add runtime support for database methods
Test uniqueness violation with BUFFER-RELEASE method (buffer-release-method-2.p)... Vadim Nebogatov

05/10/2013

03:59 AM Feature #2080: add runtime support for database methods
Additionally to note 169 concerning H2 database behavior.
P2J requests @hibernateConfigs@ map
on DataBaseManager,...
Vadim Nebogatov
01:46 AM Feature #2080: add runtime support for database methods
I've finally worked around the sequence issues with some temporary code changes and I'm now seeing the constraint vio... Eric Faulhaber
12:49 AM Feature #2080: add runtime support for database methods
Please ignore the noise about the broken H2 schema in my last post. I misread the errors; they are nothing new and ... Eric Faulhaber
11:18 PM Feature #2080: add runtime support for database methods
I was trying to recreate your results, but I cannot even generate a usable H2 table schema for the p2j_test database ... Eric Faulhaber

05/09/2013

07:20 PM Feature #2080: add runtime support for database methods
Problem is in different P2JDialect.needsComputedColumns() implementations, affects registerDatabase().
for PostgreSQ...
Vadim Nebogatov
06:13 PM Feature #2080: add runtime support for database methods
Problem seems with indexes recognition, possible with H2 only. Method checkUniqueAndShare() returns before actual val... Vadim Nebogatov
05:38 PM Feature #2080: add runtime support for database methods
When I run your test case once in Progress, I get:... Eric Faulhaber
01:16 PM Feature #2080: add runtime support for database methods
HibernateException is thrown from session.flush(); in rollback. I think it should do nothing in my simple example, an... Vadim Nebogatov
01:07 PM Feature #2080: add runtime support for database methods
I have corrected update above: actual message is some shorter. First time I copied message from log, sorry.
Vadim Nebogatov
10:22 PM Feature #2080: add runtime support for database methods
Something is wrong here. This functionality has long since been in P2J. You should not be seeing Hibernate-level ex... Eric Faulhaber

05/08/2013

06:11 PM Feature #2080: add runtime support for database methods
Test for RELEASE statement with p2j_test database.... Vadim Nebogatov

05/07/2013

04:07 PM Feature #2080: add runtime support for database methods
Yes, much of the trigger functionality is still unimplemented. However, I don't understand why you need triggers to ... Eric Faulhaber
03:53 PM Feature #2080: add runtime support for database methods
I have created two tests for RELEASE statement and BUFFER-RELEASE method and found out that triggers do not work. Onl... Vadim Nebogatov
12:02 PM Feature #1580 (Review): upgrade Hibernate to latest level
I get the following warnings when compiling with this update. I have updated the code from bzr, rather than manually... Eric Faulhaber

05/03/2013

04:53 AM Feature #2140: use positional query substitution parameters in HQLPreprocessor and related classes
Basic idea of the solution is to:
1. Use @setParameter(String, ... )@ in places like @Persistence.getQuery@ (search ...
Stanislav Lomany
10:32 PM Feature #1890 (Closed): upgrade to the latest stable PLJava and ensure that it is available on al...
Constantin completed this as part of updating the regression testing environment (#2104). Eric Faulhaber
10:29 PM Feature #2148: enhance prototype to compile p2jpl.jar file with IKVMC into .NET assembly and load...
The scope of this issue is to take the implementation from prototype to a working solution which supports all of the ... Eric Faulhaber
10:17 PM Feature #2148 (Closed): enhance prototype to compile p2jpl.jar file with IKVMC into .NET assembly...
Eric Faulhaber
10:14 PM Feature #2143: prototype IKVM solution for Java UDFs compiled to CIL assemblies and loaded in SQL...
Preliminary research indicates that using IKVM is feasible and probably represents the simplest solution. Turns out ... Eric Faulhaber

05/02/2013

03:54 PM Feature #1580: upgrade Hibernate to latest level
Patch for MAJIC. Be aware that I have not tested @QaVendorUtils@. Stanislav Lomany
10:44 AM Feature #1580: upgrade Hibernate to latest level
> In what form should I provide changes to the configuration directory file? Should I make a patching script and/or p... Constantin Asofiei
10:42 AM Feature #1580: upgrade Hibernate to latest level
In what form should I provide changes to the configuration directory file? Should I make a patching script and/or pat... Stanislav Lomany
08:34 AM Feature #1580: upgrade Hibernate to latest level
I prefer the first solution. I don't want to have yet another query parser at runtime. Eric Faulhaber
05:19 AM Feature #1580: upgrade Hibernate to latest level
Eric, there are two options to solve positional parameters:
1. Number parameters in @HQLPreprocessor@ and other plac...
Stanislav Lomany
02:20 PM Feature #2143: prototype IKVM solution for Java UDFs compiled to CIL assemblies and loaded in SQL...
This will provide a partial analog (i.e., the subset we need) to PL/Java on SQL Server. The features we need are:
*...
Eric Faulhaber
02:14 PM Feature #2143 (Closed): prototype IKVM solution for Java UDFs compiled to CIL assemblies and load...
Eric Faulhaber
02:03 PM Feature #2141 (Closed): generate SQL Server schema
Eric Faulhaber
01:55 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
The idea is to make the normalization of extent fields into separate database tables configurable, on an all-or-nothi... Eric Faulhaber
01:39 PM Feature #2140: use positional query substitution parameters in HQLPreprocessor and related classes
The query substitution parameter placeholders we emit in our converted HQL where clauses (?) are deprecated in HQL. ... Eric Faulhaber
01:33 PM Feature #2140 (Closed): use positional query substitution parameters in HQLPreprocessor and relat...
Eric Faulhaber
02:56 AM Bug #2090: correct sorting of DMO properties during schema conversion
Although the runtime passed, I've double-checked the generated sources, and it does affect frame definitions/display ... Constantin Asofiei
01:53 AM Feature #1661: support case-sensitive fields in indexes
I think everything here is working, except that @P2JH2Dialect.isCaseInsensitiveColumn@ is implemented incorrectly. T... Eric Faulhaber
01:35 AM Feature #1663 (Closed): test/debug case-sensitive field support
I've reviewed the schema and code conversion, and the runtime code. It appears case-sensitive fields are dealt with ... Eric Faulhaber

05/01/2013

07:40 PM Bug #2090: correct sorting of DMO properties during schema conversion
When using the DataModelWorker originally developed during the Majic conversion project with a newer project, we hit ... Eric Faulhaber
06:13 PM Feature #1580: upgrade Hibernate to latest level
OK, please make the minor merges and check in what you've got.
Please push through the positional parameters issue...
Eric Faulhaber
03:35 PM Feature #1580: upgrade Hibernate to latest level
> * In the ImportWorker.QueryHelper c'tor, the TYPES map initialization should include the new data types. At the mo... Stanislav Lomany
03:00 PM Feature #1580: upgrade Hibernate to latest level
Position parameters are not handled yet, I though it has lower priority than other tasks. Yes they are just log noise... Stanislav Lomany
02:46 PM Feature #1580: upgrade Hibernate to latest level
Code review 20130501a:
* In the ImportWorker.QueryHelper c'tor, the TYPES map initialization should include the ne...
Eric Faulhaber
05:24 AM Feature #1580: upgrade Hibernate to latest level
The final Hibernate update (P2J part). Passed regression testing (with postgresql-8*.jar). You may want review it. Stanislav Lomany
04:39 PM Feature #2080: add runtime support for database methods
Tests for code vmn_upd20130430a.zip (with latest fix, not in Bazaar so far) are attached
@BUFFER-COPY statement...
Vadim Nebogatov
12:52 PM Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> 4GL statement copy and compare give compile warnings (not errors)
>
> [...]
> and exec...
Eric Faulhaber
12:43 PM Feature #2080: add runtime support for database methods
The vmn_upd20130429a.zip update (the one I changed and uploaded with note 155) has passed runtime regression testing.... Eric Faulhaber

04/30/2013

04:29 PM Feature #2080: add runtime support for database methods
I have attached new update vmn_upd20130430a.zip/vmn_upd20130430ba.zip as replacement of vmn_upd20130429a.zip
Fixed...
Vadim Nebogatov
12:14 PM Feature #2080: add runtime support for database methods
The vmn_upd20130429a.zip update has passed conversion regression testing. Runtime regression testing is not yet fini... Eric Faulhaber
09:44 PM Feature #2080: add runtime support for database methods
The 20130429a code looks good, except for two lines in RecordBuffer.java which had an unnecessary, single space inden... Eric Faulhaber

04/29/2013

06:21 PM Feature #1580: upgrade Hibernate to latest level
Missing class problems were about outdated @p2jpl.ddr@ in my test directory on lightning (missing change was "Renamed... Stanislav Lomany
12:09 PM Feature #1580: upgrade Hibernate to latest level
Stanislav, just a thought: make sure the right p2jpl.jar version is installed in the and DB and the install_p2jpl.sql... Constantin Asofiei
12:01 PM Feature #1580: upgrade Hibernate to latest level
I fixed importing problems.
While working on p2jpl I came to the point where MAJIC throws this NPE _no matter what...
Stanislav Lomany
04:49 PM Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> You should also have tests between temp-tables with some matching AND some non-matching fiel...
Vadim Nebogatov
04:44 PM Feature #2080: add runtime support for database methods
I have attached update vmn_upd20130429a.zip/vmn_upd20130429b.zip as replacement of vmn_upd20130426a.zip/vmn_upd201304... Vadim Nebogatov
02:37 PM Feature #2080: add runtime support for database methods
Code review 20130426:
The code changes look good.
However, you still don't have any test cases that compare/cop...
Eric Faulhaber

04/26/2013

06:37 PM Feature #2080: add runtime support for database methods
I have attached update vmn_upd20130426a.zip/vmn_upd20130426b.zip as replacement of vmn_upd20130423a.zip/vmn_upd201304... Vadim Nebogatov
04:10 PM Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> I should have caught this earlier in my code review. Please use:
> [...]
>
> This will ...
Vadim Nebogatov
03:16 PM Feature #2080: add runtime support for database methods
I should have caught this earlier in my code review. Please use:... Eric Faulhaber
03:02 PM Feature #1580: upgrade Hibernate to latest level
There is ... Stanislav Lomany
12:29 PM Feature #1580: upgrade Hibernate to latest level
Fixed minor issue with importing.
Met another error:...
Stanislav Lomany
09:28 AM Feature #2137 (New): runtime support for FIELDS/EXCEPT record phrase options
Eric Faulhaber

04/25/2013

05:51 PM Feature #2080: add runtime support for database methods
I found out that we need convert @mode@ to low case before check
@if ("case-sensitive".equals(mode.getValue()) ||...
Vadim Nebogatov
05:31 PM Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> Estimations:
>
> @bufferRelease@ - seems already implemented. Is it correct implementat...
Eric Faulhaber
04:30 PM Feature #2080: add runtime support for database methods
Estimations:
@bufferRelease@ - seems already implemented. Is it correct implementation?
@bufferCreate@ - reusing ...
Vadim Nebogatov
04:18 PM Feature #2080: add runtime support for database methods
I only want these features for now:
> * CASE-SENSITIVE - 1-2 days, maybe less.
> * Testing and fixes possible ne...
Eric Faulhaber
04:05 PM Feature #2080: add runtime support for database methods
Rest of BUFFER-COMPARE/COPY support
* for the statement version
# CASE-SENSITIVE - 1-2 days, maybe less.
# EX...
Vadim Nebogatov
01:48 PM Feature #2080: add runtime support for database methods
Besides CASE-SENSITIVE support for the statement version of BUFFER-COMPARE, what is left to do in order for copy/comp... Eric Faulhaber
11:28 AM Feature #2080: add runtime support for database methods
After bufferCopy and bufferCompare, please work on the following, which should be achievable without metadata or dyna... Eric Faulhaber
04:32 PM Feature #1580: upgrade Hibernate to latest level
Yes, that is definitely sufficient. I'll add missing classes (although I'm still interested what is exactly wrong wit... Stanislav Lomany
04:12 PM Feature #1580: upgrade Hibernate to latest level
Stanislav Lomany wrote:
> About testing changes in @ImportWorker@: how can I start import? I supposed it is performe...
Eric Faulhaber
04:09 PM Feature #1580: upgrade Hibernate to latest level
About testing changes in @ImportWorker@: how can I start import? I supposed it is performed thru @ConversionDriver@.
...
Stanislav Lomany
03:15 PM Feature #2128: generate and load DMO interface and implementation classes for dynamic temp-tables...
This issue is closely related to its sibling issue, #2122. I have split these into two, because the parent feature i... Eric Faulhaber
01:37 PM Feature #2134 (Closed): configurable denormalization of extent fields into individual fields in s...
Eric Faulhaber
11:55 AM Feature #1668: add support for additional (non-dynamic) database attributes
The following are in scope for this task.
Buffer attributes:
* currentIteration
* is/setError
* get/setADMData
...
Eric Faulhaber
11:45 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
The following Buffer methods require dynamic database or metadata support to be in place, but are not directly relate... Eric Faulhaber

04/24/2013

06:34 PM Feature #2080: add runtime support for database methods
OK, thanks. Please go forward with the CASE-SENSITIVE support, but not with the EXPLICIT, COMPARES, WHEN, THEN. Eric Faulhaber
04:26 PM Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> Vadim Nebogatov wrote:
> > BUFFER-COMPARE statement runtime does not support CASE-SENSITIVE...
Vadim Nebogatov
02:53 PM Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> BUFFER-COMPARE statement runtime does not support CASE-SENSITIVE option. Should it be suppo...
Eric Faulhaber
02:27 PM Feature #2080: add runtime support for database methods
BUFFER-COMPARE statement runtime does not support CASE-SENSITIVE option. Should it be supported now? What about EXPLI... Vadim Nebogatov
02:20 PM Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> Code review 20130423:
>
> In RecordBuffer, you have the following comment in a few places...
Vadim Nebogatov
01:06 PM Feature #2080: add runtime support for database methods
Code review 20130423:
In RecordBuffer, you have the following comment in a few places, before a call to a worker @...
Eric Faulhaber
02:08 PM Feature #1580: upgrade Hibernate to latest level
I assume it is timestamp for datetime, but datetimetz is a compound type mapped to 2 types: timestamp and smallint. ... Eric Faulhaber
01:28 PM Feature #1580: upgrade Hibernate to latest level
For @HQLPreprocessor.inlineSubstitutionParameter@ we need a formatting function for these types, like @P2JDialect.for... Stanislav Lomany
12:57 PM Feature #1580: upgrade Hibernate to latest level
Stanislav Lomany wrote:
> Eric, am I correct that should add @HQLTypes.DATETIME@ and @HQLTypes.DATETIMETZ@,
Yes.
...
Eric Faulhaber
12:47 PM Feature #1580: upgrade Hibernate to latest level
Eric, am I correct that should add @HQLTypes.DATETIME@ and @HQLTypes.DATETIMETZ@, but shouldn't worry about handling ... Stanislav Lomany
11:57 AM Feature #1580: upgrade Hibernate to latest level
Stanislav Lomany wrote:
> I suggest to add the new type @HQLTypes.TIMESTAMP@ for both of them.
IIRC, the @HQLType...
Eric Faulhaber
11:29 AM Feature #1580: upgrade Hibernate to latest level
No, not yet, and probably will not work on datetime/tz and persistence this week.
Please add the two constants, fo...
Ovidiu Maxiniuc
11:14 AM Feature #1580: upgrade Hibernate to latest level
Stanislav Lomany wrote:
> Eric, I need to add mapping for @datetime@ and @datetimetz@ to @DataTypeHelper.classes@. W...
Eric Faulhaber
11:10 AM Feature #1580: upgrade Hibernate to latest level
Eric, I need to add mapping for @datetime@ and @datetimetz@ to @DataTypeHelper.classes@. What HQL type(s) (see @HQLTy... Stanislav Lomany
10:42 AM Feature #1580: upgrade Hibernate to latest level
Patch for Hibernate. Stanislav Lomany
07:24 AM Feature #1580: upgrade Hibernate to latest level
The problem with p2jpl.jar is not reproducible at this point. Maybe database state is wrong, maybe something else. I'... Stanislav Lomany
 

Also available in: Atom