Project

General

Profile

Activity

From 07/11/2013 to 08/09/2013

08/09/2013

07:26 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Constantin, Ovidiu, is there any difference between @TempTable.uniqueId()@ and @UniqueID.getUniqueID()@? Stanislav Lomany
01:34 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
> I have not reviewed the code yet (will do that later today). Is there anything left to do on this task (considering... Stanislav Lomany
01:25 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
I have not reviewed the code yet (will do that later today). Is there anything left to do on this task (considering s... Eric Faulhaber
03:18 PM Feature #1660: add conversion and runtime support for OF keyword use in a CAN-FIND
Ovidiu Maxiniuc wrote:
> Indeed, there were some issues at conversion time:
> - join of a buffer with a table
> ...
Eric Faulhaber
02:37 PM Feature #1660: add conversion and runtime support for OF keyword use in a CAN-FIND
Indeed, there were some issues at conversion time:
- join of a buffer with a table
- join of a buffer with the sa...
Ovidiu Maxiniuc
02:45 PM Feature #1911: add runtime support for sequences
I removed the TODO comment that eclipse inserted automatically.
Regarding the desc sequences, I believe they are n...
Ovidiu Maxiniuc
11:15 AM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Eric, thanks, I have no questions so far. Vadim Nebogatov

08/08/2013

06:14 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Vadim Nebogatov wrote:
> Do we still keep FOR-EACH loop based RecordBuffer.deleteAll implementation?
Yes, it is the...
Eric Faulhaber
06:11 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
I've been thinking about this most of the afternoon here, and actually, after some discussions with Greg, I'm leaning... Eric Faulhaber
05:18 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Eric, could you describe your idea about using table pinned lock for bulk delete in some more detail? I still not goo... Vadim Nebogatov
04:21 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
OK, but if you remove the conditional test, please be sure to add comments so we don't lose information. This condit... Eric Faulhaber
03:59 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Condition on the line RecordBuffer, line 7747... Vadim Nebogatov
10:53 AM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Eric Faulhaber wrote:
> I think the desired effect can be achieved with changes to @RecordLockContext@ and @RecordBu...
Vadim Nebogatov
04:09 PM Feature #1911: add runtime support for sequences
In regard to note 26 and note 30, this is a known flaw in our processing for the MESSAGE statement. We don't need to... Greg Shah
03:37 PM Feature #1660: add conversion and runtime support for OF keyword use in a CAN-FIND
Code review 20130808a:
This update looks OK, but it is in a very sensitive area of the conversion, and it is hard ...
Eric Faulhaber
01:21 PM Feature #1660: add conversion and runtime support for OF keyword use in a CAN-FIND
The first version of the update attached.
I used the disjunction between of-join foreign-key phrase and any existing ...
Ovidiu Maxiniuc
06:42 AM Feature #1660: add conversion and runtime support for OF keyword use in a CAN-FIND
My first approach here was to analyze the AST tree to see why the @OF@ node does not get encoded as needed.
I used ...
Ovidiu Maxiniuc
08:52 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Unless there are significant downsides, I think we should implement chaining of both classloaders as our default appr... Greg Shah
08:34 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
When distributing update I forgot to mention that if someone wants to use dynamic temp tables, @InMemoryClassLoader@ ... Stanislav Lomany
08:22 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
This update adds basic support for dynamic tables. Stanislav Lomany

08/07/2013

05:59 PM Feature #2044: implement support for a DELETE statement with a validation expression
Eric Faulhaber wrote:
> Vadim Nebogatov wrote:
> > Do you plan to support Alternate Buffer Pool (since 10.2B)?
> N...
Vadim Nebogatov
03:31 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Eric Faulhaber wrote:
> Vadim Nebogatov wrote:
> > In case of separate TableIdentifier class we will need to use @i...
Vadim Nebogatov
03:21 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Vadim Nebogatov wrote:
> In case of separate TableIdentifier class we will need to use @instanceof TableIdentifier@ ...
Eric Faulhaber
03:16 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Eric Faulhaber wrote:
> It seems it might be best to leave the @LockManager@ interface and @InMemoryLockManager@ cla...
Vadim Nebogatov
02:59 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
It seems it might be best to leave the @LockManager@ interface and @InMemoryLockManager@ class alone after all.
Gi...
Eric Faulhaber

08/06/2013

09:07 PM Feature #1911: add runtime support for sequences
Code review 20130801a:
Looks good. There is a TODO comment in the PostgreSQLSequenceHandler c'tor. Is there some...
Eric Faulhaber

08/05/2013

07:43 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Good point. Please see the class @RecordLockContext@, which already deals with this issue (it is a bit more complicat... Eric Faulhaber
10:30 AM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Several records could be locked from one context and require SHARE-LOCK for the same table.
I suggest to add one m...
Vadim Nebogatov
02:27 PM Feature #1911: add runtime support for sequences
On Friday, the runtime test failed with an abend in gso_ctrlc_3way, failure in step 11, and about 10 other issues in ... Ovidiu Maxiniuc

08/04/2013

02:23 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
These names will available via an API. The code will look something like this:... Eric Faulhaber
02:00 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Eric, please note that in order to authentically implement @CREATE-LIKE@ and @ADD-LIKE-FIELD@ I need to have original... Stanislav Lomany

08/02/2013

12:39 PM Feature #2044: implement support for a DELETE statement with a validation expression
I think it is ok to commit. Eric Faulhaber
10:27 AM Feature #2044: implement support for a DELETE statement with a validation expression
Regression 20130802_053132 completed. There are 4 FAILED and 3 FAILED_DEPENDENCY tests in ts_tests.... Vadim Nebogatov
05:00 AM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Yes, that's a good point. The @update@ parameter will need to be passed through from the @lock@ method. Eric Faulhaber

08/01/2013

05:43 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Is the any sense in adding also @boolean update@ parameter like for @lock@ method? Vadim Nebogatov
03:54 PM Feature #2044: implement support for a DELETE statement with a validation expression
Regression 20130801_101909 completed. There are 6 FAILED tests in ts_tests.... Vadim Nebogatov
10:11 AM Feature #1911: add runtime support for sequences
Near final update. Issues from Eric's review were fixed. The PSQL issues were eliminated.
I am putting this update t...
Ovidiu Maxiniuc

07/31/2013

05:29 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Correction: @lockTable(LockType lockType)@ should actually be @lockTable(String table, LockType lockType)@, where @ta... Eric Faulhaber
05:04 PM Feature #1602: support BigDecimal in PLJAVA indexOf() implementation
I have no idea. I'm sure I was just going off our estimate spreadsheet, based on some feedback you provided originally. Greg Shah
05:01 PM Feature #1602: support BigDecimal in PLJAVA indexOf() implementation
Greg: I just looked into the Functions class and found we have the following method:... Eric Faulhaber
01:36 PM Feature #2044: implement support for a DELETE statement with a validation expression
Update vmn_upd20130731a.zip replaces update vmn_upd20130729a.zip with fixed comments in note 22.
Updated to revision...
Vadim Nebogatov
12:32 PM Feature #2044: implement support for a DELETE statement with a validation expression
Eric Faulhaber wrote:
> Vadim Nebogatov wrote:
> > I have tested DELETE with validation when record is locked. In t...
Vadim Nebogatov
08:38 AM Feature #2044: implement support for a DELETE statement with a validation expression
Vadim Nebogatov wrote:
> I have tested DELETE with validation when record is locked. In this case 4GL simply ignores...
Eric Faulhaber
08:21 AM Feature #2044: implement support for a DELETE statement with a validation expression
Code review 20130729a:
Code looks fine. However, I would suggest, instead of changing @handle@ and @ControlFlowOps...
Eric Faulhaber
07:27 AM Feature #2044: implement support for a DELETE statement with a validation expression
Vadim Nebogatov wrote:
> Do you plan to support Alternate Buffer Pool (since 10.2B)?
Not to my knowledge. There are...
Eric Faulhaber
07:12 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Please go ahead and fix the conversion defect. AFAIK, all the information we have regarding rules about buffers is in... Eric Faulhaber

07/30/2013

05:37 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
@DEFAULT-BUFFER-HANDLE@ will take some more time if I'm going to implement it completely, specifically it is converte... Stanislav Lomany
02:58 PM Feature #2044: implement support for a DELETE statement with a validation expression
Be careful with your conclusions here. This result can be heavily affected by the 4GL caching/flushing behavior AND ... Greg Shah
02:47 PM Feature #2044: implement support for a DELETE statement with a validation expression
I have tested DELETE with validation when record is locked. In this case 4GL simply ignores this record.
One user...
Vadim Nebogatov
05:12 AM Feature #2137 (WIP): runtime support for FIELDS/EXCEPT record phrase options
See #2095 for cases which require support. Eric Faulhaber

07/29/2013

04:21 PM Feature #2044: implement support for a DELETE statement with a validation expression
Do you plan to support Alternate Buffer Pool (since 10.2B)?
Vadim Nebogatov
03:36 PM Feature #2044: implement support for a DELETE statement with a validation expression
I have attached update vmn_upd20130729a.zip/vmn_upd20130729b.zip
1) Added a boolean asMsg parameter to recordOrThr...
Vadim Nebogatov
11:58 AM Feature #2044: implement support for a DELETE statement with a validation expression
I don't see the value in making changes to builtErrorText(). If I understand correctly, we just need to bypass the c... Greg Shah
11:48 AM Feature #2044: implement support for a DELETE statement with a validation expression
Greg Shah wrote:
> Before I can answer, I have one more question. In both cases (NO-ERROR and without NO-ERROR), wha...
Vadim Nebogatov
09:33 AM Feature #2044: implement support for a DELETE statement with a validation expression
Before I can answer, I have one more question. In both cases (NO-ERROR and without NO-ERROR), what is returned from ... Greg Shah
11:59 AM Feature #1588: add conversion and runtime support for embedded SQL
Yes, please commit and distribute. Eric Faulhaber
11:12 AM Feature #1588: add conversion and runtime support for embedded SQL
Eric, may I commit this update? Vadim Nebogatov

07/26/2013

03:41 PM Feature #2044: implement support for a DELETE statement with a validation expression
What about adding one more parameter to buildErrorText and recordOrThrowError:
boolean withNumber
and do not pr...
Vadim Nebogatov
10:52 AM Feature #2044: implement support for a DELETE statement with a validation expression
*Non-Error case*... Vadim Nebogatov
07:21 AM Feature #2044: implement support for a DELETE statement with a validation expression
2 things:
1. Are you sure that failing a validation in the 4GL is considered an "ERROR" in the 4GL sense? What do...
Greg Shah
06:17 AM Feature #2044: implement support for a DELETE statement with a validation expression
Eric Faulhaber wrote:
> Please propose a change which adjusts for these minor differences with minimal or (if possib...
Vadim Nebogatov
08:22 PM Feature #2044: implement support for a DELETE statement with a validation expression
Oh, I believed you, I just found it interesting how inconsistent Progress is. Eric Faulhaber
05:38 AM Feature #1588: add conversion and runtime support for embedded SQL
Regression 20130725_172005 completed in time you pointed. There are less errors: 3 FAILED tests in ts_tests.
1. tc...
Vadim Nebogatov

07/25/2013

06:17 PM Feature #2044: implement support for a DELETE statement with a validation expression
I have attached screenshots Vadim Nebogatov
05:57 PM Feature #2044: implement support for a DELETE statement with a validation expression
Interesting. I have not previously seen a Progress-style error which does not have the leading asterisks and trailing... Eric Faulhaber
05:27 PM Feature #2044: implement support for a DELETE statement with a validation expression
I have tested both in P2J and 4GL and also with NO-ERROR and some other examples like ... Vadim Nebogatov

07/24/2013

05:52 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
For now, that is the best way. Later on, we will start to move our utility classes into separate jars, but let's kee... Greg Shah
03:49 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
I guess we have the same files in both projects.
Greg: can you think of a better way?
Eric Faulhaber
02:00 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Eric, @com.goldencode.compile.*@ classes are from the harness project. They are now required for P2J project too. How... Stanislav Lomany
12:38 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
> What is the TODO comment in DMOIndex.classes()
Dynamic table classes are not returned by this function. Since this...
Stanislav Lomany
04:51 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Code review 20130717a/b/c:
Nice work. A very interesting update.
* What is the TODO comment in @DMOIndex.class...
Eric Faulhaber
05:20 PM Feature #2046 (WIP): runtime support for DELETE statement with a validation expression
Eric Faulhaber
03:01 PM Feature #1588: add conversion and runtime support for embedded SQL
IIRC, some of the "job clock" tests are sensitive to the time of day they are run, so these may be false negatives (o... Eric Faulhaber
02:48 PM Feature #1588: add conversion and runtime support for embedded SQL
Regression 20130724_051719 completed. There are 8 FAILED and FAILED_DEPENDENCY tests in ts_tests:
1. tc_job_002 FA...
Vadim Nebogatov

07/23/2013

05:38 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Then I think your suggested approach makes sense. Eric Faulhaber
03:53 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Default buffer for dynamic tables can be used anywhere, i.e. within and outside of @TEMP-TABLE-PREPARE()@ call scope. Stanislav Lomany
02:37 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Stanislav Lomany wrote:
> Eric, I was working on @DEFAULT-BUFFER-HANDLE@ - handle to default buffer which can be use...
Eric Faulhaber
02:21 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Stanislav Lomany wrote:
> ...
> I think we should use "field1", "field2" as Hibernate names and parse queries passe...
Eric Faulhaber
01:54 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Eric, I was working on @DEFAULT-BUFFER-HANDLE@ - handle to default buffer which can be used anywhere in the program a... Stanislav Lomany
03:25 PM Feature #1588: add conversion and runtime support for embedded SQL
Code review 20130723a/b:
Code looks good. Please regression test and check it in if successful.
Eric Faulhaber
03:05 PM Feature #1588: add conversion and runtime support for embedded SQL
I have attached update vmn_upd20130723a.zip/vmn_upd20130723b.zip with deleteAll based on "converted-style" FOR-EACH l... Vadim Nebogatov
02:48 PM Feature #1588: add conversion and runtime support for embedded SQL
Vadim Nebogatov wrote:
> This is file you sent me separately. Bzr version does not contain 023 ECF 20130618
Yes, ...
Eric Faulhaber

07/22/2013

10:18 AM Feature #1588: add conversion and runtime support for embedded SQL
> Good. But hibernate-core-4.1.8.jar is file I received from Stas, I am not sure if he will commit (or already commit... Stanislav Lomany
10:05 AM Feature #1588: add conversion and runtime support for embedded SQL
Eric Faulhaber wrote:
> * Please put the Hibernate jar in a separate update and put it under the @lib@ directory ins...
Vadim Nebogatov
09:34 AM Feature #1588: add conversion and runtime support for embedded SQL
Eric Faulhaber wrote:
> * This version of database_general.rules is the same as the one currently checked into bzr. ...
Vadim Nebogatov

07/21/2013

06:02 PM Feature #1588: add conversion and runtime support for embedded SQL
Code review 20130719a:
* This version of database_general.rules is the same as the one currently checked into bzr....
Eric Faulhaber

07/19/2013

03:01 PM Feature #1588: add conversion and runtime support for embedded SQL
Savepoint based reversible actually could work for other operations, not only for @deleteAll@. I have attached update... Vadim Nebogatov

07/18/2013

06:17 PM Feature #1588: add conversion and runtime support for embedded SQL
I was mistaken, temporary table was created by DefaultDirtyShareManager for track changes Vadim Nebogatov
01:09 AM Feature #1911: add runtime support for sequences
Code review 20130712a:
Generally looks good; nice work. Some comments below.
* Please add a WARNING to schema co...
Eric Faulhaber
12:23 AM Feature #1911: add runtime support for sequences
Ovidiu Maxiniuc wrote:
> +Note 26 continued+.
> ...
Greg: I need your input here.
Ovidiu: since this is an erro...
Eric Faulhaber

07/17/2013

06:11 PM Feature #1588: add conversion and runtime support for embedded SQL
Savepoint seems more promising and common approach. I have attached very draft @deleteAll@ support based on Savepoin... Vadim Nebogatov
01:05 PM Feature #1911: add runtime support for sequences
+Note 26 continued+.
From my quick tests, it seems that @message@ is more permissive about errors occurred while eva...
Ovidiu Maxiniuc
09:34 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
All metadata from the _field, _file, _index, _index_field, _user, and _lock tables are being stored in an embedded H2... Eric Faulhaber
09:12 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
About field name validation for dynamic tables.
1. Basically you can create a field with any name, and this field ca...
Stanislav Lomany
08:52 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Update - part 3 (Hibernate changes). Stanislav Lomany
04:07 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Update - part 2. Stanislav Lomany

07/16/2013

02:30 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Did some research regarding these methods, focusing on @bufferField()@.
My first thought were to 'capture' the mis...
Ovidiu Maxiniuc
11:14 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Update for review. Allows potentially manipulate DMOs using P2J framework. I'll post remaining parts and make comment... Stanislav Lomany
10:24 AM Feature #1588: add conversion and runtime support for embedded SQL
The other option is to look at savepoints sooner rather than later, since this is probably the most correct/supported... Eric Faulhaber

07/15/2013

06:33 PM Feature #1588: add conversion and runtime support for embedded SQL
Interesting idea.
Please detail your proposed design for bulk delete "undo"-ability (to use the Progress term) for...
Eric Faulhaber
05:24 PM Feature #1588: add conversion and runtime support for embedded SQL
Reversible operations for temporary tables are based on multiplex ID value and records are not actually deleted from ... Vadim Nebogatov
02:19 PM Feature #1911: add runtime support for sequences
I discovered something strange with sequences.
If you define a sequence with negative increment Progress will automa...
Ovidiu Maxiniuc

07/12/2013

06:25 PM Feature #1588: add conversion and runtime support for embedded SQL
OK, this complicates the implementation.
Based on your findings so far, I think the way we need to handle this is to...
Eric Faulhaber
01:49 PM Feature #1588: add conversion and runtime support for embedded SQL
Example undo for DELETE FROM for subtransaction. It works: record exists after bulk delete and undo ... Vadim Nebogatov
02:15 PM Feature #1911: add runtime support for sequences
This update package contains a first stage of runtime implementation. Main points:
- fixed name issues (4GL-legacy ...
Ovidiu Maxiniuc
11:59 AM Feature #1911: add runtime support for sequences
I am having the following issue.... Ovidiu Maxiniuc

07/11/2013

04:58 PM Feature #1588: add conversion and runtime support for embedded SQL
Good question. I'm sure a DELETE FROM style bulk delete would be rolled back at a full transaction scope, but we nee... Eric Faulhaber
04:52 PM Feature #1588: add conversion and runtime support for embedded SQL
Are there sense of reversible bulk delete for persistent tables? Vadim Nebogatov
03:09 PM Feature #1588: add conversion and runtime support for embedded SQL
Vadim Nebogatov wrote:
> Additionally to note 29.
> I have tested @DELETE FOR@ with @WHERE@ clause. I understand i...
Eric Faulhaber
02:01 PM Feature #2080: add runtime support for database methods
OK, please check in and distribute this update. Eric Faulhaber
01:58 PM Feature #2080: add runtime support for database methods
Regression 20130711_075408 completed with the following results.
Only 2 tests failed: tc_job_002 as expected and ...
Vadim Nebogatov
 

Also available in: Atom