Project

General

Profile

Activity

From 09/05/2013 to 10/04/2013

10/04/2013

06:29 PM Feature #2141: generate SQL Server schema
Eric, Greg,
Yes, this expression is wrong because second parameter in @replace()@ is the substring to be found, not...
Vadim Nebogatov
08:34 AM Feature #2141: generate SQL Server schema
> We want to right-trim ANY whitespace character (i.e., '\t', '\n', '\r') which appears after the last non-whitespace... Greg Shah
07:45 AM Feature #2141: generate SQL Server schema
Please clarify something for me. I should have asked this earlier, but I just noticed it now:... Eric Faulhaber
05:26 AM Feature #2141: generate SQL Server schema
Attached updated ddl files. Vadim Nebogatov
05:07 AM Feature #2141: generate SQL Server schema
Eric Faulhaber wrote:
> Does this mean a row will not be inserted into the table if it exceeds these limitations of ...
Vadim Nebogatov
04:27 PM Feature #2116: add runtime support for _user metadata table
Code Review 1004a
I'm only reviewing the util/ and security/ changes. Eric will handle the persistence stuff (run...
Greg Shah
02:47 PM Feature #2116: add runtime support for _user metadata table
When importing the _User table, the implementation searches for the @_User.d@ and @pwds.txt@ files at the same locati... Ovidiu Maxiniuc
01:43 PM Feature #2116: add runtime support for _user metadata table
I attached the latest sources. I hope the above note and comments from code will help understand the implementation. ... Ovidiu Maxiniuc
10:13 AM Feature #2125: add runtime support for dynamic buffer creation and cleanup
Stanislav: please double-check the FIRST-BUFFER parameter (I will release an update for it soon), to make sure is imp... Constantin Asofiei

10/03/2013

07:43 PM Feature #2141: generate SQL Server schema
Does this mean a row will not be inserted into the table if it exceeds these limitations of the index, or that the in... Eric Faulhaber
04:45 PM Feature #2141: generate SQL Server schema
Series of warnings if map to varchar(8000) ... Vadim Nebogatov

10/02/2013

07:05 PM Feature #2141: generate SQL Server schema
*About using Hibernate SQL Functions and stored procedures (functions) for new rtrim*.
It is possible Hibernate SQL...
Vadim Nebogatov
09:29 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
20131002a changes look good. Please commit and distribute if testing passes. Eric Faulhaber
07:46 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
And @get4GLTableName@ functions too. Stanislav Lomany
06:56 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
> OK, please run it through another round of regression testing after you've made the above changes. Since they are p... Stanislav Lomany

10/01/2013

06:41 PM Feature #2141: generate SQL Server schema
Eric Faulhaber wrote:
> I'm familiar. It's an absolute necessity to have updated statistics to get the query planner...
Vadim Nebogatov
06:22 PM Feature #2141: generate SQL Server schema
Vadim Nebogatov wrote:
> Eric Faulhaber wrote:
> > Vadim Nebogatov wrote:
> > > @[substring(expr, 0, len(replace(e...
Eric Faulhaber
04:17 PM Feature #2141: generate SQL Server schema
Eric Faulhaber wrote:
> Vadim Nebogatov wrote:
> > @[substring(expr, 0, len(replace(expr, CHAR(9)+CHAR(10)+CHAR(13), ...
Vadim Nebogatov
06:26 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
OK, please run it through another round of regression testing after you've made the above changes. Since they are pre... Eric Faulhaber
05:00 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
> I would like to see your test cases. Are these checked into the testcases project? Please provide a list of names, ... Stanislav Lomany
08:33 AM Feature #2116: add runtime support for _user metadata table
The implementation I am debugging now works like this:
* I added a new type of authentication (@AUTH_MODE_METADATA =...
Ovidiu Maxiniuc
08:10 AM Feature #2116: add runtime support for _user metadata table
> If for one of the databases the authentication fails all three times, the client process is closed, even if for a p... Greg Shah
08:08 AM Feature #2116: add runtime support for _user metadata table
I'm moving this discussion here from email, because it is important to record it as part of the task.
-------- Ori...
Greg Shah

09/30/2013

05:14 PM Feature #2141: generate SQL Server schema
Vadim Nebogatov wrote:
> @[substring(expr, 0, len(replace(expr, CHAR(9)+CHAR(10)+CHAR(13), ' ')))]@
I appreciate ...
Eric Faulhaber
05:06 PM Feature #2141: generate SQL Server schema
Vadim Nebogatov wrote:
> It seems it is a problem in MSSQL: varchar(MAX) cannot be used in indexes.
[...]
OK, le...
Eric Faulhaber
04:54 PM Feature #2141: generate SQL Server schema
Or even simpler:... Vadim Nebogatov
04:47 PM Feature #2141: generate SQL Server schema
Eric Faulhaber wrote:
> My only other concern is the rtrim function. The SQL Server version simply doesn't do what w...
Vadim Nebogatov
04:14 PM Feature #2141: generate SQL Server schema
varchar is equivalent to varchar(1) Vadim Nebogatov
08:34 AM Feature #2141: generate SQL Server schema
And N=8000 is restriction for varchar(N) . BTW @varchar(MAX)@ in MSSQL - special type name. Vadim Nebogatov
08:32 AM Feature #2141: generate SQL Server schema
It seems it is a problem in MSSQL: varchar(MAX) cannot be used in indexes. The maximum amount of bytes on a index is ... Vadim Nebogatov
08:19 AM Feature #2141: generate SQL Server schema
> Greg: what was the rule again? AFAIR, the whole record can be no larger than 32K, but any individual field can clai... Greg Shah
07:21 AM Feature #2141: generate SQL Server schema
and to varbinary(MAX). BTW SQLServer2005Dialect also maps to these types when size is not known.... Vadim Nebogatov
07:16 AM Feature #2141: generate SQL Server schema
Eric Faulhaber wrote:
> But I think 4GL @character@ fields can be larger than 8,000.
>
> Greg: what was the rule ...
Vadim Nebogatov
07:03 AM Feature #2141: generate SQL Server schema
But I think 4GL @character@ fields can be larger than 8,000.
Greg: what was the rule again? AFAIR, the whole recor...
Eric Faulhaber
06:44 AM Feature #2141: generate SQL Server schema
Eric Faulhaber wrote:
> Where did the choice of 8,000 as a limit come from?
It is private constant from SQLServer2005...
Vadim Nebogatov
01:12 PM Feature #2116: add runtime support for _user metadata table
Yes, the above directory paths are relative, not absolute. The question was: should I add p2j-user collections with (... Ovidiu Maxiniuc
01:04 PM Feature #2116: add runtime support for _user metadata table
... Greg Shah
12:55 PM Feature #2116: add runtime support for _user metadata table
Progress client allows multiple database connection at startup, the following command line is correct:... Ovidiu Maxiniuc
12:47 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
OK, let's leave the synchronization as is.
Code review 20130924a:
Wow, this is an exciting update and a hugely ...
Eric Faulhaber

09/29/2013

05:50 PM Feature #2141: generate SQL Server schema
The output looks good. I would like to review the code. Please upload an update when ready.
Where did the choice o...
Eric Faulhaber
05:14 PM Feature #2141: generate SQL Server schema
Attached updated and tested dll files for sql server 2012.
I have added private constant from 2005 dialect...
Vadim Nebogatov

09/27/2013

06:34 PM Feature #2141: generate SQL Server schema
Eric Faulhaber wrote:
> Is it necessary to create the placeholder computed columns in the CREATE TABLE statements, if...
Vadim Nebogatov
03:54 PM Feature #2141: generate SQL Server schema
Is it necessary to create the placeholder computed columns in the CREATE TABLE statements, if we are just going to dr... Eric Faulhaber
03:45 PM Feature #2141: generate SQL Server schema
Sequences seems implemented, I have attached ddl files for sql server 2012.
Both are tested on sql server 2012.
Vadim Nebogatov
03:41 PM Feature #2141: generate SQL Server schema
Eric Faulhaber wrote:
> It seems like these methods would be necessary at runtime. Are any of them necessary for the...
Vadim Nebogatov
02:30 PM Feature #2141: generate SQL Server schema
It seems like these methods would be necessary at runtime. Are any of them necessary for the generation of a feature-... Eric Faulhaber
01:09 PM Feature #2141: generate SQL Server schema
TODO after sequences:
isQueryRangeParameterInlined(),
inlineLimit(),
requiresExplicitCastInsideTernary,
use...
Vadim Nebogatov
09:54 AM Feature #2141: generate SQL Server schema
Please prioritize finishing support for 2012 over 2008. Hopefully, getting sequences to emit in the DDL is easier for... Eric Faulhaber
05:03 AM Feature #2141: generate SQL Server schema
Created 2 different targetDb: mssql2008 and mssql2012.
schema_table_p2j_test_mssql2008.sql, schema_index_p2j_test_ms...
Vadim Nebogatov
02:37 PM Feature #2156: datetime-tz and hibernate
h3. Record of e-mail discussion
Eric,
If I remember correctly, I already managed to get DDLs well generated, so...
Eric Faulhaber

09/26/2013

04:01 PM Feature #2141: generate SQL Server schema
No, there is no need to set the precision differently by conversion project. The value of 50 was chosen to match Prog... Eric Faulhaber
01:09 AM Feature #2141: generate SQL Server schema
So, precision could be set as @dialect && conversion specific@ in p2j.cfg.xml:... Vadim Nebogatov
02:48 PM Feature #2116: add runtime support for _user metadata table
> So each user/group defined in directory.xml can have a [user/password] combination that will be used like -U -P par... Greg Shah
02:10 PM Feature #2116: add runtime support for _user metadata table
Greg Shah wrote:
> > _Should we emulate these parameters by adding equivalent items in the directory?
>
> Yes, t...
Ovidiu Maxiniuc
11:45 AM Feature #2116: add runtime support for _user metadata table
I don't see any difference between the behaviors of @pro@ and @mpro@ executables.
I looked into launch scripts and ...
Ovidiu Maxiniuc
01:33 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
> * Also in @MutableSessionFactoryImpl@, there are several TODOs. What needs to be done for these, and what is the im... Stanislav Lomany

09/25/2013

07:35 PM Feature #2116: add runtime support for _user metadata table
I will let Eric reply in regard to the code. I will try to answer some questions.
> _Should we emulate these para...
Greg Shah
02:26 PM Feature #2116: add runtime support for _user metadata table
Are these results based on using a single-user (pro) or multi-user (mpro) database process? Eric Faulhaber
01:17 PM Feature #2116: add runtime support for _user metadata table
The P2J "permanent databases" concept seems like starting the the Progress client with database location as startup p... Ovidiu Maxiniuc
07:07 PM Feature #2141: generate SQL Server schema
Eric Faulhaber wrote:
> Vadim Nebogatov wrote:
> > [...]
> > P2J sets precision, scale in hibernate.xml. Workarou...
Vadim Nebogatov
06:38 PM Feature #2141: generate SQL Server schema
Eric Faulhaber wrote:
> Ah, TRPL cannot deal with static references. What error messages do you get?
>
> Try:
> ...
Vadim Nebogatov
03:35 PM Feature #2141: generate SQL Server schema
Ah, TRPL cannot deal with static references. What error messages do you get?
Try:...
Eric Faulhaber
03:19 PM Feature #2141: generate SQL Server schema
Eric Faulhaber wrote:
> Vadim Nebogatov wrote:
> > If "if exists" is not important we could avoid it on schema export...
Vadim Nebogatov
11:42 AM Feature #2141: generate SQL Server schema
Vadim Nebogatov wrote:
> [...]
> P2J sets precision, scale in hibernate.xml. Workaround for MSSQL is using in P2J...
Eric Faulhaber
11:28 AM Feature #2141: generate SQL Server schema
Vadim Nebogatov wrote:
> If "if exists" is not important we could avoid it on schema export using in generate_ddl.xm...
Eric Faulhaber
05:34 PM Feature #2122 (Review): add runtime support for dynamically prepared temp-tables
Eric Faulhaber
05:34 PM Feature #2128 (Review): generate and load DMO interface and implementation classes for dynamic te...
Eric Faulhaber
05:31 PM Bug #2164 (Closed): Server fails to start a Progress app when persistence disabled
Eric Faulhaber
05:23 PM Bug #2164: Server fails to start a Progress app when persistence disabled
Committed revision 10387. Hynek Cihlar
04:48 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Eric Faulhaber wrote:
> Code review 20130924b:
> * Please add a simple javadoc comment for the @MutableSessionFacto...
Eric Faulhaber
04:45 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Code review 20130924b:
* Please add a simple javadoc comment for the @MutableSessionFactoryImpl@ constructor, and ad...
Eric Faulhaber
02:36 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Have you run this update through regression testing yet? If not, please do. I will review in parallel, but I don't wa... Eric Faulhaber

09/24/2013

06:36 PM Feature #2141: generate SQL Server schema
As I understood Hibernate doesn't worry about real column precision in table and takes column
precision from htm fi...
Vadim Nebogatov
05:42 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Hibernate part. Stanislav Lomany
09:14 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Update with runtime support for dynamic tables except MetaSchema and COPY-TEMP-TABLE. Stanislav Lomany
08:34 PM Bug #2164: Server fails to start a Progress app when persistence disabled
The update looks good to me. Please commit and distribute it, and record the revision number here. Eric Faulhaber

09/23/2013

05:18 PM Feature #2141: generate SQL Server schema
Eric Faulhaber wrote:
> The @if exists@ prefix is a nice safety feature, but in practice we rarely will run the DDL ...
Vadim Nebogatov

09/22/2013

04:32 PM Feature #2141: generate SQL Server schema
Eric Faulhaber wrote:
> Does this come into play anywhere other than in generate_ddl.xml?
Hibernate has only two usa...
Vadim Nebogatov

09/21/2013

12:02 PM Feature #2141: generate SQL Server schema
Does this come into play anywhere other than in generate_ddl.xml? The @if exists@ prefix is a nice safety feature, bu... Eric Faulhaber

09/20/2013

07:59 PM Bug #2164: Server fails to start a Progress app when persistence disabled
The changes passed regression test, see shared\clients\timco\majic_test_results\10382_9c2ae9a_20130920_hc.zip.
Fixed...
Hynek Cihlar
04:04 PM Feature #2141: generate SQL Server schema
Another problem I have found out that for MS SQL Server both supportsIfExistsBeforeTableName() and supportsIfExistsAf... Vadim Nebogatov
03:57 PM Feature #2141: generate SQL Server schema
Yes, I also already understood that it does not depend on dialect. Vadim Nebogatov
03:54 PM Feature #2141: generate SQL Server schema
Vadim Nebogatov wrote:
> 11. Table creation
>
> Maximum MS SQL Server NUMERIC column precision is 38.
The more y...
Eric Faulhaber
04:19 AM Feature #2141: generate SQL Server schema
I have added item 11 about table creation to note 11. Vadim Nebogatov
03:07 PM Feature #2137 (New): runtime support for FIELDS/EXCEPT record phrase options
This feature is an optimization, but is not necessary for the runtime to function properly. Moving target version acc... Eric Faulhaber
03:03 PM Feature #1580 (Closed): upgrade Hibernate to latest level
Eric Faulhaber
07:13 AM Feature #1580: upgrade Hibernate to latest level
I've uploaded original Hibernate sources to @shared/projects/p2j/hibernate/hibernate-4.1.8.Final-original.zip@ and th... Stanislav Lomany

09/19/2013

01:48 PM Feature #2116: add runtime support for _user metadata table
Ovidiu Maxiniuc wrote:
> I altered the conversion so that the _user AST is copied from meta to each processed databa...
Eric Faulhaber
01:37 PM Feature #2116: add runtime support for _user metadata table
I altered the conversion so that the _user AST is copied from meta to each processed database if configured in p2j.cf... Ovidiu Maxiniuc
01:37 PM Feature #2175 (Closed): add support for -rereadnolock startup parameter
Eric Faulhaber
03:56 AM Feature #2175: add support for -rereadnolock startup parameter
The update "om_upd20130912e.zip":https://proj.goldencode.com/redmine/attachments/1285/om_upd20130912e.zip added in #1... Ovidiu Maxiniuc
01:36 PM Feature #1594 (Closed): add conversion and runtime support for CURRENT-CHANGED() built-in function
Eric Faulhaber
03:39 AM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
The update was committed to bzr as revision 10381 and distributed by email. Ovidiu Maxiniuc

09/18/2013

05:46 PM Feature #2141: generate SQL Server schema
Vadim Nebogatov wrote:
> 10. getAlterComputedColumnString()
> ...
> MS SQL Server ALTER TABLE does not allow alter...
Eric Faulhaber
05:18 PM Feature #2141: generate SQL Server schema
Items 9, 10 about rtrim and getAlterComputedColumnString added to note 9. Vadim Nebogatov
01:40 PM Feature #2141: generate SQL Server schema
I have added item 8 about collation to note 9. Vadim Nebogatov
05:35 PM Feature #2116: add runtime support for _user metadata table
Ovidiu Maxiniuc wrote:
> ...the @_User@ table has changed; the .d /.df pair I extracted today have a different numbe...
Eric Faulhaber
05:16 PM Feature #2116: add runtime support for _user metadata table
Ovidiu Maxiniuc wrote:
> I also start adding import support for _User meta-table.
> I understand that this is a ta...
Eric Faulhaber
02:07 PM Feature #2116: add runtime support for _user metadata table
Ovidiu Maxiniuc wrote:
> > * I am a bit confused by the use of the @Database@ class to hold the userid.
> Indeed, ...
Eric Faulhaber
12:52 PM Feature #2116: add runtime support for _user metadata table
I also start adding import support for _User meta-table.
I understand that this is a table like others from the dat...
Ovidiu Maxiniuc
12:35 PM Feature #2116: add runtime support for _user metadata table
> * I am a bit confused by the use of the @Database@ class to hold the userid.
Indeed, I was a little confused abou...
Ovidiu Maxiniuc

09/17/2013

04:11 PM Feature #2175 (WIP): add support for -rereadnolock startup parameter
Eric Faulhaber
04:09 PM Feature #2116: add runtime support for _user metadata table
Eliminating the Apache logging dependency:
1. Replace:...
Eric Faulhaber
04:08 PM Feature #2116: add runtime support for _user metadata table
Code review 20130917a:
I realize this is only an intermediate update, but I had a quick look to get an idea of you...
Eric Faulhaber
02:41 PM Feature #2116: add runtime support for _user metadata table
An intermediate version.
From my tests, @userid@ and @setuserid@ forms of the function without ldbname use indeed the...
Ovidiu Maxiniuc

09/16/2013

04:41 PM Feature #2141: generate SQL Server schema
Please bear in mind that the scope of this task is to generate a SQL Server schema, not to implement all functionalit... Eric Faulhaber
04:34 PM Feature #2141: generate SQL Server schema
Sorry, I missed this earlier. Yes, we need to support both (and only those) versions (2008 and 2012). We do not need ... Eric Faulhaber
04:28 PM Feature #2141: generate SQL Server schema
Eric, what do you think about my last question in note 9 ("Will we create separate P2JSQLServer2008Dialect and P2JSQL... Vadim Nebogatov
04:25 PM Feature #2141: generate SQL Server schema
MS SQL Server allows double quoted column names and I meant we need support this too... But it seems I understood now... Vadim Nebogatov
10:22 AM Feature #2141: generate SQL Server schema
I'm not sure what use case would make this necessary. We control the conversion of all names, and we don't allow doub... Eric Faulhaber
04:54 AM Feature #2141: generate SQL Server schema
I think all usages of dialect.getComputedColumnPrefix() should be corrected for the case when prefix could be meet in... Vadim Nebogatov
04:12 PM Feature #2116: add runtime support for _user metadata table
Ovidiu Maxiniuc wrote:
> In P2J terms, we need to have an "default" database defined in the directory, that will be ...
Eric Faulhaber
03:53 PM Feature #2116: add runtime support for _user metadata table
If the @_user@ table of "default" database is populated (is not empty) and the -U -P command line parameters are not ... Ovidiu Maxiniuc
03:46 PM Feature #2116: add runtime support for _user metadata table
From my researches I found out some interesting things about @userid@ and @setuserid@ which are not very explicit in ... Ovidiu Maxiniuc
02:10 PM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
OK, thanks. Please commit and distribute the update. Eric Faulhaber
11:42 AM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
The @crtRecBuffCount == 1@ means that the respective record is referred by one buffer. In this case, there are two ca... Ovidiu Maxiniuc
11:49 PM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
Code review 20130911b/20130912e:
Changes look good, but please help me understand why the refresh code in the 2 ma...
Eric Faulhaber

09/13/2013

04:26 AM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
Yesterday my work was focused on fixing the queries for failing tests. Because of the large amounts of sql queries ne... Ovidiu Maxiniuc

09/12/2013

04:35 PM Feature #2141: generate SQL Server schema
I have added item 7 about sequences to note 9 and question. Vadim Nebogatov
03:22 PM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function
The initial tests had some unimportant fails in CTRL+C and quite a lot of fails in the main part:
* 7 in gso_tests ...
Ovidiu Maxiniuc

09/11/2013

03:33 PM Feature #2141: generate SQL Server schema
*XXXXP2JDialect implementation (will be extended)*
1. extractColumnName(String expr) , needsComputedColumns() and i...
Vadim Nebogatov

09/09/2013

01:21 AM Feature #2141: generate SQL Server schema
Vadim Nebogatov wrote:
> One more question concerning mapping varchar to TEXT in PostgreSQL.
Progress @character@ f...
Eric Faulhaber

09/07/2013

05:21 PM Feature #2141: generate SQL Server schema
Vadim Nebogatov wrote:
> I have noticed in import_util.rules that PostgreSQL connection string is configured only fo...
Vadim Nebogatov
03:39 AM Feature #2141: generate SQL Server schema
One more question concerning mapping varchar to TEXT in PostgreSQL. Vadim Nebogatov

09/06/2013

04:46 PM Feature #2141: generate SQL Server schema
I have noticed in import_util.rules that PostgreSQL connection string is configured only for default port (5432). Is ... Vadim Nebogatov
12:23 PM Bug #2178: Asymmetric sequence behavior
Sequences in Progress are somewhat asymmetric relatively to their increment:
- An ascending sequence will allow any ...
Ovidiu Maxiniuc
12:02 PM Bug #2178 (New): Asymmetric sequence behavior
Ovidiu Maxiniuc

09/05/2013

05:14 PM Feature #2141: generate SQL Server schema
I have checked in SQL Server 2005 (I think the same for SQL Server 2008 and 2012): the following column names are cor... Vadim Nebogatov
09:28 AM Feature #2141: generate SQL Server schema
Your understanding is correct (assuming that prefix generates a legal name in SQL Server). Eric Faulhaber
03:15 AM Feature #2141: generate SQL Server schema
Could the same prefix @CC_PREFIX = "__"@ be used for any database supporting computed columns? As far as I understood... Vadim Nebogatov
02:32 PM Feature #2175: add support for -rereadnolock startup parameter
The runtime test failed.
Some CTRL+C test failed and 3 reports show results different than expected.
I started disc...
Ovidiu Maxiniuc
 

Also available in: Atom