FWD » Core Development » Database

10/18/2013

04:10 PM Feature #2141: generate SQL Server schema

Regression 20131018_102350, 3 FAILED tests:
1. tc_job_002 FAILED failure in step 40: 'Unexpected EOF in actual at ... Vadim Nebogatov

09:45 PM Feature #2141: generate SQL Server schema

Vadim Nebogatov wrote:
> Start regression one more time?
Might as well, but please also work with Eugenie in the me... Eric Faulhaber

02:48 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Second run of CTRL-C testing for 1018a.zip was OK. Constantin Asofiei

01:25 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Attached update completes the legacy annotations at the DMO implementation class. See #2195 for the MAJIC changes.
... Constantin Asofiei

01:03 PM Feature #2115: add runtime support for _file and _field metadata tables

This is an interim drop of my implementation of this feature. It has failed regression testing so far, but contains s... Eric Faulhaber

12:59 PM Feature #2116: add runtime support for _user metadata table

Code review 20131014a (database-related):
* Other than to avoid collisions with Java and SQL reserved keywords, le... Eric Faulhaber

10/17/2013

06:52 PM Feature #2141: generate SQL Server schema

Start regression one more time? Vadim Nebogatov

12:55 PM Feature #2141: generate SQL Server schema

Regression 20131017_034322, 9 FAILED and 3 FAILED_DEPENDENCY tests:
1. gso_491 FAILED failure in step 15: 'timeout ... Vadim Nebogatov

02:54 PM Feature #2116: add runtime support for _user metadata table

> Then I thought - at connection time there is only one session per queue so let's try enriching the SessionListener ... Greg Shah

02:10 PM Feature #2116: add runtime support for _user metadata table

> I'm thinking that the SecurityManager should be completely disabled if database authorization is in charge.
I do... Greg Shah

01:07 PM Feature #2116: add runtime support for _user metadata table

Greg Shah wrote:
> If I understand the issue properly, you need to do some processing at the end of Conversation.run... Ovidiu Maxiniuc

12:24 PM Feature #2116: add runtime support for _user metadata table

Sorry, I fail to understand some of the notes above.
I'm thinking that the @SecurityManager@ should be completely di... Ovidiu Maxiniuc

01:08 PM Feature #2120: add runtime support for dynamically prepared queries

> Stanislav, is there a specific reason why you chose to explicitly store objects rather than build something generic... Stanislav Lomany

11:42 AM Feature #2120: add runtime support for dynamically prepared queries

Stanislav, is there a specific reason why you chose to explicitly store objects rather than build something generic i... Constantin Asofiei

08:54 AM Feature #2120: add runtime support for dynamically prepared queries

The 2nd approach (in-memory compilation of real java code, like with the dynamic DMOs) is the one that I believe is t... Greg Shah

08:12 AM Feature #2120: add runtime support for dynamically prepared queries

About extracting the query instance from a generated JavaAST. The current approach is to parse a 4GL code like @OPEN ... Constantin Asofiei

08:56 AM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...

The requirements of this task have changed somewhat.
The change will no longer take place on an all or nothing bas... Eric Faulhaber

01:31 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> * It's been a long time since I was in this code, but shouldn't the call to @TableMapper.removeTemporaryTables@ in ... Constantin Asofiei

11:12 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Code review 20131016b:
This update looks quite good, but I have a few questions:
* It's been a long time since ... Eric Faulhaber

10/16/2013

03:49 PM Feature #2116: add runtime support for _user metadata table

If I understand the issue properly, you need to do some processing at the end of Conversation.run() when the session'... Greg Shah

02:10 PM Feature #2116: add runtime support for _user metadata table

I am working on these changes, but only one question remains:
* in the case that metadata authentication is success... Ovidiu Maxiniuc

12:19 PM Feature #2116: add runtime support for _user metadata table

> in order to store database-level userid/password a per-user structure need to be added in directory. In a non-scope... Greg Shah

11:36 AM Feature #2116: add runtime support for _user metadata table

Greg Shah wrote:
> Although I like the database authentication to be isolated in its own methods as much as possible... Ovidiu Maxiniuc

10:09 AM Feature #2116: add runtime support for _user metadata table

> The problem is that I need the authenticated userids for each database at runtime, in the context of the client. Th... Greg Shah

07:21 AM Feature #2116: add runtime support for _user metadata table

Greg Shah wrote:
> Code Review 1014a
>
> Eric will handle all the database/persistence portions (conversion and r... Ovidiu Maxiniuc

12:02 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Constantin Asofiei wrote:
> Please let me know if you see something wrong in my reasoning above (and an initial revi... Eric Faulhaber

11:07 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

LE: actually, for parsing the prepare query string, I need the legacy buffer name, not the legacy temp-table name. An... Constantin Asofiei

10:54 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Greg Shah wrote:
> There must be a place in the generated business logic where we access the DMO implementation clas... Constantin Asofiei

09:43 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

There must be a place in the generated business logic where we access the DMO implementation class for the temp-table... Greg Shah

09:10 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Greg,
> I prefer to keep a common/shared temp-table class where it is structurally possible, as this is a much bette... Constantin Asofiei

08:26 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> If a dynamic buffer is created in an inner scope, and then used to change data in an arbitrary, "middle" scope (i.e... Stanislav Lomany

08:24 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> And if we want to be completely perfect, we should convert temp tables which have the names in different cases to d... Greg Shah

06:26 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Stanislav, some notes on TempTableBuilder getters for various attributes; i.e. @TempTableBuilder.uniqueId@ is defined... Constantin Asofiei

06:06 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> Now I even can't start server:
Please comment line 223 in ORMHandler (to disable mappings for permanent DBs) until... Constantin Asofiei

06:01 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

There are massive changes in TableMapper. Is that right table mapper? Stanislav Lomany

06:00 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Now I even can't start server:... Stanislav Lomany

05:09 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Stanislav Lomany wrote:
> > Remove the @get@, @set@ or @is@ prefixes (so there is no way to conflict with a DMO gett... Constantin Asofiei

05:02 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> Remove the @get@, @set@ or @is@ prefixes (so there is no way to conflict with a DMO getter or setter).
And if we h... Stanislav Lomany

04:47 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

PS: the NPE is fixed, but I need to finish the annotations for the hand-written DMOs in MAJIC. Will post this later t... Constantin Asofiei

04:08 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> Constantin, how the new names should look like?
Remove the @get@, @set@ or @is@ prefixes (so there is no way to co... Constantin Asofiei

03:48 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> Stanislav, while you are working on dynamic buffers, I think is a good opportunity to rename get and set methods ac... Stanislav Lomany

05:48 AM Feature #2120: add runtime support for dynamically prepared queries

Related to note 8 - see the discussion in notes 20-36 in #1654. Summary: TableMapper was added to map legacy names fo... Constantin Asofiei

10/15/2013

06:51 PM Feature #2116: add runtime support for _user metadata table

Code Review 1014a
Eric will handle all the database/persistence portions (conversion and runtime).
In regard to... Greg Shah

02:04 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

This update contains the following:
# conversion rules to emit annotations at DMO impl class and DMO properties
# r... Constantin Asofiei

12:56 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Stanislav Lomany wrote:
> In its outermost scope the buffer should be
> 1. registered as finalizable
> 2. added to ... Eric Faulhaber

08:09 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

In 4GL, an external program can end up with two temp-tables with the same name (exposed via handles).
* Program 1 de... Constantin Asofiei

12:22 PM Feature #2141: generate SQL Server schema

Regression 20131015_061357
A lot (20+) failed ts_tests, all related with timeout. I think something happened and I... Vadim Nebogatov

10/14/2013

02:52 PM Feature #2024 (WIP): implement runtime support for database triggers

Ovidiu Maxiniuc

02:42 PM Feature #2141: generate SQL Server schema

Sorry, silly question, I should have looked at the timestamps. Times seem OK.
Perhaps your last run will resolve t... Eric Faulhaber

02:04 PM Feature #2141: generate SQL Server schema

Eric Faulhaber wrote:
> What time of day (i.e., devsrv01 time -- EDT) did you run the harness?
Regression 20131... Vadim Nebogatov

01:47 PM Feature #2141: generate SQL Server schema

What time of day (i.e., devsrv01 time -- EDT) did you run the harness? Eric Faulhaber

01:42 PM Feature #2141: generate SQL Server schema

I have executed regression two times.
Regression @20131013_090710@, 3 FAILED tests:
1. tc_job_002 FAILED failur... Vadim Nebogatov

12:45 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

OK.
One more request: for the API, let's use @getDMOName@ instead of @javaName@ and @getPropertyName@ instead of @... Eric Faulhaber

12:43 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> One minor change is that I think we need to store the legacy buffer name in @RecordBuffer@ instead of @BufferImpl@.... Constantin Asofiei

12:38 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

I agree with this proposed approach. One minor change is that I think we need to store the legacy buffer name in @Rec... Eric Faulhaber

12:08 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> What would the code look like which would use these annotations at runtime?
What I'm thinking is to have several ma... Constantin Asofiei

11:38 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Interesting idea. This would obviate the need for the @_new-name@ field in @_file@ and @_field@. What would the code ... Eric Faulhaber

11:26 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> > I'm thinking if it would not be easier using annotations at the DMO interface definition; from these, we could bu... Constantin Asofiei

11:04 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Constantin Asofiei wrote:
> I don't think _file can be easily used for temp-tables, as I won't be able to do a "sele... Eric Faulhaber

10:36 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> @MetaSchema@ will give you access to this lookup in both directions.
Thanks, this is good news.

> Now, Progres... Constantin Asofiei

10:15 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Constantin Asofiei wrote:
> As I understand, the temp-tables will not be mapped by @MetaSchema@; thus, how do we obt... Eric Faulhaber

09:46 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

I'll let Eric respond on the MetaSchema questions.
> Beside this, SchemaDictionary must implement Scopeable too, t... Greg Shah

09:01 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> We would like to integrate the dynamic-temp table state information as much as possible with the @SchemaDictionary@... Constantin Asofiei

07:18 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Stanislav, while you are working on dynamic buffers, I think is a good opportunity to rename get and set methods acce... Constantin Asofiei

12:06 PM Feature #2116: add runtime support for _user metadata table

This update includes:
* generation of meta_user table within the other normal schemas
* when importing a database d... Ovidiu Maxiniuc

05:20 AM Feature #2116: add runtime support for _user metadata table

Indeed, the database/p2j_test from my directory.xml was wrong, it contained the following entries:... Ovidiu Maxiniuc

10/12/2013

10:18 AM Feature #2141: generate SQL Server schema

I have attached update vmn_upd20131012a.zip and corresponding cfg and dll files in vmn_upd20131012b.zip.
Update cor... Vadim Nebogatov

06:31 AM Feature #2141: generate SQL Server schema

Eric Faulhaber wrote:
> I'm just curious: what is the @SelectedMethod=Cursor@ parameter in the database URL for (@ge... Vadim Nebogatov

12:07 AM Feature #2116: add runtime support for _user metadata table

Wait, why are you using @TempTableConnectionProvider@ for those other connected databases? This sounds like a configu... Eric Faulhaber

10/11/2013

04:21 PM Feature #2116: add runtime support for _user metadata table

Meanwhile I tried to connect to different database servers using different dialects (one PSQL, one H2).
I was expect... Ovidiu Maxiniuc

03:40 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

OK, please let me know if you see some obvious flaws in the rest of the plan. Stanislav Lomany

03:07 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Sorry I missed that detail in my review. This is a good question, and after speaking with Greg, I am shifting my opin... Eric Faulhaber

01:42 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> I am a bit confused by this comment. @MetaSchema@ will have schema information, basically the equivalent for temp-t... Stanislav Lomany

12:37 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Stanislav Lomany wrote:
> Determination of the outermost scope for a temp-table is the task for MetaSchema, it canno... Eric Faulhaber

08:12 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Let's forget for a second about persistent procedures and widget pools. For normal processing, as I said earlier, a d... Stanislav Lomany

09:56 PM Feature #2141: generate SQL Server schema

Code review 20131006:
Nice work.
I'm just curious: what is the @SelectedMethod=Cursor@ parameter in the databas... Eric Faulhaber

10/10/2013

09:03 AM Feature #2116: add runtime support for _user metadata table

Another difference I thought of is that when we connect to multiple databases in regression testing, both have the sa... Eric Faulhaber

08:49 AM Feature #2116: add runtime support for _user metadata table

Thanks for the clarification. So, are you saying the above stack trace was generated from the query running against @... Eric Faulhaber

03:41 AM Feature #2116: add runtime support for _user metadata table

I will investigate the @JdbcKeyRetriever@, I did not see any flaw in @DatabaseManager.getDatabaseTables(Database)@.
... Ovidiu Maxiniuc

10/09/2013

04:20 PM Feature #2116: add runtime support for _user metadata table

This query doesn't look correct. Why are we accessing tables from different databases in the same query? Perhaps a bu... Eric Faulhaber

02:25 PM Feature #2116: add runtime support for _user metadata table

The customer is using simultaneous connection to databases "common" and "<db_name>".
I have done today some research... Ovidiu Maxiniuc

10/08/2013

02:10 PM Feature #2120: add runtime support for dynamically prepared queries

Don't know why I forgot the SymbolResolver is backed by the SchemaDictionary for temp-table stuff; with this in mind,... Constantin Asofiei

01:53 PM Feature #2120: add runtime support for dynamically prepared queries

Interesting results. These are good limitations as they greatly reduce the possible functionality.
> temp-table d... Greg Shah

01:41 PM Feature #2120: add runtime support for dynamically prepared queries

Some initial thoughts on this: the documentation (and practice) shows that for a prepared query string:
# it follows ... Constantin Asofiei

08:29 AM Feature #2120: add runtime support for dynamically prepared queries

I wrote:
> optimization of conversion resources into a queued service (i.e., to prevent one instance of SchemaDictio... Eric Faulhaber

08:57 AM Feature #2116: add runtime support for _user metadata table

>> 2. Why is there a <node class="container" name="bogus"> container in your example directory structure?
>
> Yes, ... Greg Shah

08:46 AM Feature #1651: add support for dynamic database features

To clarify:
# We are not going to use a binary implementation of TRPL for our first implementation.
# We don't wa... Greg Shah

08:34 AM Feature #1651: add support for dynamic database features

Note that any use of conversion features at runtime will require the use of existing or new conversion rule-sets and ... Eric Faulhaber

04:52 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

About @CREATE BUFFER@ and implicit resource deletion in general. I've tested using these two programs:
# a program wh... Constantin Asofiei

02:25 AM Feature #1654 (WIP): add conversion and runtime support for dynamic buffer creation and cleanup

Stanislav Lomany

10/07/2013

06:12 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Stas, while you're in this code, please move all the @public static@ variants of @RecordBuffer.create@ where they bel... Eric Faulhaber

02:16 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> Right now I'm trying to figure out how a dynamic buffer should be handled in the scopes outer to the point where th... Greg Shah

03:49 PM Feature #2116: add runtime support for _user metadata table

Greg Shah wrote:
> 1. Your "implements UserSecurityOps" needs to be on its own line (in 2 files).
I believe this is... Ovidiu Maxiniuc

01:37 PM Feature #2141: generate SQL Server schema

I guess the 2-character difference in the "usable" portion of the key is attributable to extra overhead caused by the... Eric Faulhaber

12:29 PM Feature #2141: generate SQL Server schema

Test: ... Vadim Nebogatov

09:32 AM Feature #2141: generate SQL Server schema

If I understand correctly, this is good news. I was not aware of this limit in Progress.
Vadim, please put togethe... Eric Faulhaber

06:59 AM Feature #2141: generate SQL Server schema

It's very possible that I'm misunderstanding the issue, but isn't the MS SQL server limit less restrictive than the c... Paul E

04:37 AM Feature #2141: generate SQL Server schema

Corrected vmn_upd20131006a and added vmn_upd20131006b with uast (p2j.cfg.xml and all generated ddls). Vadim Nebogatov

10/06/2013

05:21 PM Feature #2141: generate SQL Server schema

I have attached update vmn_upd20131006a.zip and corresponding tested dll files. Update corresponds to latest bzr revi... Vadim Nebogatov

10/04/2013

06:29 PM Feature #2141: generate SQL Server schema

Eric, Greg,
Yes, this expression is wrong because second parameter in @replace()@ is the substring to be found, not... Vadim Nebogatov

08:34 AM Feature #2141: generate SQL Server schema

> We want to right-trim ANY whitespace character (i.e., '\t', '\n', '\r') which appears after the last non-whitespace... Greg Shah

07:45 AM Feature #2141: generate SQL Server schema

Please clarify something for me. I should have asked this earlier, but I just noticed it now:... Eric Faulhaber

05:26 AM Feature #2141: generate SQL Server schema

Attached updated ddl files. Vadim Nebogatov

05:07 AM Feature #2141: generate SQL Server schema

Eric Faulhaber wrote:
> Does this mean a row will not be inserted into the table if it exceeds these limitations of ... Vadim Nebogatov

04:27 PM Feature #2116: add runtime support for _user metadata table

Code Review 1004a
I'm only reviewing the util/ and security/ changes. Eric will handle the persistence stuff (run... Greg Shah

02:47 PM Feature #2116: add runtime support for _user metadata table

When importing the _User table, the implementation searches for the @_User.d@ and @pwds.txt@ files at the same locati... Ovidiu Maxiniuc

01:43 PM Feature #2116: add runtime support for _user metadata table

I attached the latest sources. I hope the above note and comments from code will help understand the implementation. ... Ovidiu Maxiniuc

10:13 AM Feature #2125: add runtime support for dynamic buffer creation and cleanup

Stanislav: please double-check the FIRST-BUFFER parameter (I will release an update for it soon), to make sure is imp... Constantin Asofiei

10/03/2013

07:43 PM Feature #2141: generate SQL Server schema

Does this mean a row will not be inserted into the table if it exceeds these limitations of the index, or that the in... Eric Faulhaber

04:45 PM Feature #2141: generate SQL Server schema

Series of warnings if map to varchar(8000) ... Vadim Nebogatov

10/02/2013

07:05 PM Feature #2141: generate SQL Server schema

*About using Hibernate SQL Functions and stored procedures (functions) for new rtrim*.
It is possible Hibernate SQL... Vadim Nebogatov

09:29 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

20131002a changes look good. Please commit and distribute if testing passes. Eric Faulhaber

07:46 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

And @get4GLTableName@ functions too. Stanislav Lomany

06:56 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

> OK, please run it through another round of regression testing after you've made the above changes. Since they are p... Stanislav Lomany

10/01/2013

06:41 PM Feature #2141: generate SQL Server schema

Eric Faulhaber wrote:
> I'm familiar. It's an absolute necessity to have updated statistics to get the query planner... Vadim Nebogatov

06:22 PM Feature #2141: generate SQL Server schema

Vadim Nebogatov wrote:
> Eric Faulhaber wrote:
> > Vadim Nebogatov wrote:
> > > @[substring(expr, 0, len(replace(e... Eric Faulhaber

04:17 PM Feature #2141: generate SQL Server schema

Eric Faulhaber wrote:
> Vadim Nebogatov wrote:
> > @[substring(expr, 0, len(replace(expr, CHAR(9)+CHAR(10)+CHAR(13), ... Vadim Nebogatov

06:26 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

OK, please run it through another round of regression testing after you've made the above changes. Since they are pre... Eric Faulhaber

05:00 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

> I would like to see your test cases. Are these checked into the testcases project? Please provide a list of names, ... Stanislav Lomany

08:33 AM Feature #2116: add runtime support for _user metadata table

The implementation I am debugging now works like this:
* I added a new type of authentication (@AUTH_MODE_METADATA =... Ovidiu Maxiniuc

08:10 AM Feature #2116: add runtime support for _user metadata table

> If for one of the databases the authentication fails all three times, the client process is closed, even if for a p... Greg Shah

08:08 AM Feature #2116: add runtime support for _user metadata table

I'm moving this discussion here from email, because it is important to record it as part of the task.
-------- Ori... Greg Shah

09/30/2013

05:14 PM Feature #2141: generate SQL Server schema

Vadim Nebogatov wrote:
> @[substring(expr, 0, len(replace(expr, CHAR(9)+CHAR(10)+CHAR(13), ' ')))]@
I appreciate ... Eric Faulhaber

05:06 PM Feature #2141: generate SQL Server schema

Vadim Nebogatov wrote:
> It seems it is a problem in MSSQL: varchar(MAX) cannot be used in indexes.
[...]
OK, le... Eric Faulhaber

04:54 PM Feature #2141: generate SQL Server schema

Or even simpler:... Vadim Nebogatov

04:47 PM Feature #2141: generate SQL Server schema

Eric Faulhaber wrote:
> My only other concern is the rtrim function. The SQL Server version simply doesn't do what w... Vadim Nebogatov

04:14 PM Feature #2141: generate SQL Server schema

varchar is equivalent to varchar(1) Vadim Nebogatov

08:34 AM Feature #2141: generate SQL Server schema

And N=8000 is restriction for varchar(N) . BTW @varchar(MAX)@ in MSSQL - special type name. Vadim Nebogatov

08:32 AM Feature #2141: generate SQL Server schema

It seems it is a problem in MSSQL: varchar(MAX) cannot be used in indexes. The maximum amount of bytes on a index is ... Vadim Nebogatov

08:19 AM Feature #2141: generate SQL Server schema

> Greg: what was the rule again? AFAIR, the whole record can be no larger than 32K, but any individual field can clai... Greg Shah

07:21 AM Feature #2141: generate SQL Server schema

and to varbinary(MAX). BTW SQLServer2005Dialect also maps to these types when size is not known.... Vadim Nebogatov

07:16 AM Feature #2141: generate SQL Server schema

Eric Faulhaber wrote:
> But I think 4GL @character@ fields can be larger than 8,000.
>
> Greg: what was the rule ... Vadim Nebogatov

07:03 AM Feature #2141: generate SQL Server schema

But I think 4GL @character@ fields can be larger than 8,000.
Greg: what was the rule again? AFAIR, the whole recor... Eric Faulhaber

06:44 AM Feature #2141: generate SQL Server schema

Eric Faulhaber wrote:
> Where did the choice of 8,000 as a limit come from?
It is private constant from SQLServer2005... Vadim Nebogatov

01:12 PM Feature #2116: add runtime support for _user metadata table

Yes, the above directory paths are relative, not absolute. The question was: should I add p2j-user collections with (... Ovidiu Maxiniuc

01:04 PM Feature #2116: add runtime support for _user metadata table

... Greg Shah

12:55 PM Feature #2116: add runtime support for _user metadata table

Progress client allows multiple database connection at startup, the following command line is correct:... Ovidiu Maxiniuc

12:47 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

OK, let's leave the synchronization as is.
Code review 20130924a:
Wow, this is an exciting update and a hugely ... Eric Faulhaber

09/29/2013

05:50 PM Feature #2141: generate SQL Server schema

The output looks good. I would like to review the code. Please upload an update when ready.
Where did the choice o... Eric Faulhaber

05:14 PM Feature #2141: generate SQL Server schema

Attached updated and tested dll files for sql server 2012.
I have added private constant from 2005 dialect... Vadim Nebogatov

09/27/2013

06:34 PM Feature #2141: generate SQL Server schema

Eric Faulhaber wrote:
> Is it necessary to create the placeholder computed columns in the CREATE TABLE statements, if... Vadim Nebogatov

03:54 PM Feature #2141: generate SQL Server schema

Is it necessary to create the placeholder computed columns in the CREATE TABLE statements, if we are just going to dr... Eric Faulhaber

03:45 PM Feature #2141: generate SQL Server schema

Sequences seems implemented, I have attached ddl files for sql server 2012.
Both are tested on sql server 2012.
Vadim Nebogatov

03:41 PM Feature #2141: generate SQL Server schema

Eric Faulhaber wrote:
> It seems like these methods would be necessary at runtime. Are any of them necessary for the... Vadim Nebogatov

02:30 PM Feature #2141: generate SQL Server schema

It seems like these methods would be necessary at runtime. Are any of them necessary for the generation of a feature-... Eric Faulhaber

01:09 PM Feature #2141: generate SQL Server schema

TODO after sequences:
isQueryRangeParameterInlined(),
inlineLimit(),
requiresExplicitCastInsideTernary,
use... Vadim Nebogatov

09:54 AM Feature #2141: generate SQL Server schema

Please prioritize finishing support for 2012 over 2008. Hopefully, getting sequences to emit in the DDL is easier for... Eric Faulhaber

05:03 AM Feature #2141: generate SQL Server schema

Created 2 different targetDb: mssql2008 and mssql2012.
schema_table_p2j_test_mssql2008.sql, schema_index_p2j_test_ms... Vadim Nebogatov

02:37 PM Feature #2156: datetime-tz and hibernate

h3. Record of e-mail discussion
Eric,
If I remember correctly, I already managed to get DDLs well generated, so... Eric Faulhaber

09/26/2013

04:01 PM Feature #2141: generate SQL Server schema

No, there is no need to set the precision differently by conversion project. The value of 50 was chosen to match Prog... Eric Faulhaber

01:09 AM Feature #2141: generate SQL Server schema

So, precision could be set as @dialect && conversion specific@ in p2j.cfg.xml:... Vadim Nebogatov

02:48 PM Feature #2116: add runtime support for _user metadata table

> So each user/group defined in directory.xml can have a [user/password] combination that will be used like -U -P par... Greg Shah

02:10 PM Feature #2116: add runtime support for _user metadata table

Greg Shah wrote:
> > _Should we emulate these parameters by adding equivalent items in the directory?
>
> Yes, t... Ovidiu Maxiniuc

11:45 AM Feature #2116: add runtime support for _user metadata table

I don't see any difference between the behaviors of @pro@ and @mpro@ executables.
I looked into launch scripts and ... Ovidiu Maxiniuc

01:33 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

> * Also in @MutableSessionFactoryImpl@, there are several TODOs. What needs to be done for these, and what is the im... Stanislav Lomany

09/25/2013

07:35 PM Feature #2116: add runtime support for _user metadata table

I will let Eric reply in regard to the code. I will try to answer some questions.
> _Should we emulate these para... Greg Shah

02:26 PM Feature #2116: add runtime support for _user metadata table

Are these results based on using a single-user (pro) or multi-user (mpro) database process? Eric Faulhaber

01:17 PM Feature #2116: add runtime support for _user metadata table

The P2J "permanent databases" concept seems like starting the the Progress client with database location as startup p... Ovidiu Maxiniuc

07:07 PM Feature #2141: generate SQL Server schema

Eric Faulhaber wrote:
> Vadim Nebogatov wrote:
> > [...]
> > P2J sets precision, scale in hibernate.xml. Workarou... Vadim Nebogatov

06:38 PM Feature #2141: generate SQL Server schema

Eric Faulhaber wrote:
> Ah, TRPL cannot deal with static references. What error messages do you get?
>
> Try:
> ... Vadim Nebogatov

03:35 PM Feature #2141: generate SQL Server schema

Ah, TRPL cannot deal with static references. What error messages do you get?
Try:... Eric Faulhaber

03:19 PM Feature #2141: generate SQL Server schema

Eric Faulhaber wrote:
> Vadim Nebogatov wrote:
> > If "if exists" is not important we could avoid it on schema export... Vadim Nebogatov

11:42 AM Feature #2141: generate SQL Server schema

Vadim Nebogatov wrote:
> [...]
> P2J sets precision, scale in hibernate.xml. Workaround for MSSQL is using in P2J... Eric Faulhaber

11:28 AM Feature #2141: generate SQL Server schema

Vadim Nebogatov wrote:
> If "if exists" is not important we could avoid it on schema export using in generate_ddl.xm... Eric Faulhaber

05:34 PM Feature #2122 (Review): add runtime support for dynamically prepared temp-tables

Eric Faulhaber

05:34 PM Feature #2128 (Review): generate and load DMO interface and implementation classes for dynamic te...

Eric Faulhaber

05:31 PM Bug #2164 (Closed): Server fails to start a Progress app when persistence disabled

Eric Faulhaber

05:23 PM Bug #2164: Server fails to start a Progress app when persistence disabled

Committed revision 10387. Hynek Cihlar

04:48 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

Eric Faulhaber wrote:
> Code review 20130924b:
> * Please add a simple javadoc comment for the @MutableSessionFacto... Eric Faulhaber

04:45 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

Code review 20130924b:
* Please add a simple javadoc comment for the @MutableSessionFactoryImpl@ constructor, and ad... Eric Faulhaber

02:36 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

Have you run this update through regression testing yet? If not, please do. I will review in parallel, but I don't wa... Eric Faulhaber

09/24/2013

06:36 PM Feature #2141: generate SQL Server schema

As I understood Hibernate doesn't worry about real column precision in table and takes column
precision from htm fi... Vadim Nebogatov

05:42 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

Hibernate part. Stanislav Lomany

09:14 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

Update with runtime support for dynamic tables except MetaSchema and COPY-TEMP-TABLE. Stanislav Lomany

08:34 PM Bug #2164: Server fails to start a Progress app when persistence disabled

The update looks good to me. Please commit and distribute it, and record the revision number here. Eric Faulhaber

09/23/2013

05:18 PM Feature #2141: generate SQL Server schema

Eric Faulhaber wrote:
> The @if exists@ prefix is a nice safety feature, but in practice we rarely will run the DDL ... Vadim Nebogatov

09/22/2013

04:32 PM Feature #2141: generate SQL Server schema

Eric Faulhaber wrote:
> Does this come into play anywhere other than in generate_ddl.xml?
Hibernate has only two usa... Vadim Nebogatov

09/21/2013

12:02 PM Feature #2141: generate SQL Server schema

Does this come into play anywhere other than in generate_ddl.xml? The @if exists@ prefix is a nice safety feature, bu... Eric Faulhaber

09/20/2013

07:59 PM Bug #2164: Server fails to start a Progress app when persistence disabled

The changes passed regression test, see shared\clients\timco\majic_test_results\10382_9c2ae9a_20130920_hc.zip.
Fixed... Hynek Cihlar

04:04 PM Feature #2141: generate SQL Server schema

Another problem I have found out that for MS SQL Server both supportsIfExistsBeforeTableName() and supportsIfExistsAf... Vadim Nebogatov

03:57 PM Feature #2141: generate SQL Server schema

Yes, I also already understood that it does not depend on dialect. Vadim Nebogatov

03:54 PM Feature #2141: generate SQL Server schema

Vadim Nebogatov wrote:
> 11. Table creation
>
> Maximum MS SQL Server NUMERIC column precision is 38.
The more y... Eric Faulhaber

04:19 AM Feature #2141: generate SQL Server schema

I have added item 11 about table creation to note 11. Vadim Nebogatov

03:07 PM Feature #2137 (New): runtime support for FIELDS/EXCEPT record phrase options

This feature is an optimization, but is not necessary for the runtime to function properly. Moving target version acc... Eric Faulhaber

03:03 PM Feature #1580 (Closed): upgrade Hibernate to latest level

Eric Faulhaber

07:13 AM Feature #1580: upgrade Hibernate to latest level

I've uploaded original Hibernate sources to @shared/projects/p2j/hibernate/hibernate-4.1.8.Final-original.zip@ and th... Stanislav Lomany

09/19/2013

01:48 PM Feature #2116: add runtime support for _user metadata table

Ovidiu Maxiniuc wrote:
> I altered the conversion so that the _user AST is copied from meta to each processed databa... Eric Faulhaber

01:37 PM Feature #2116: add runtime support for _user metadata table

I altered the conversion so that the _user AST is copied from meta to each processed database if configured in p2j.cf... Ovidiu Maxiniuc

01:37 PM Feature #2175 (Closed): add support for -rereadnolock startup parameter

Eric Faulhaber

03:56 AM Feature #2175: add support for -rereadnolock startup parameter

The update "om_upd20130912e.zip":https://proj.goldencode.com/redmine/attachments/1285/om_upd20130912e.zip added in #1... Ovidiu Maxiniuc

01:36 PM Feature #1594 (Closed): add conversion and runtime support for CURRENT-CHANGED() built-in function

Eric Faulhaber

03:39 AM Feature #1594: add conversion and runtime support for CURRENT-CHANGED() built-in function

The update was committed to bzr as revision 10381 and distributed by email. Ovidiu Maxiniuc