FWD » Core Development » Database

10/30/2013

01:52 PM Feature #2120: add runtime support for dynamically prepared queries

Constantin Asofiei wrote:
> I think we need a @QueryResource@ interface to be implemented only by the @QueryWrapper@... Eric Faulhaber

01:46 PM Feature #2120: add runtime support for dynamically prepared queries

Constantin Asofiei wrote:
> > Some other issues, all minor:
> I'll fix these tomorrow (as I need to double-check no... Eric Faulhaber

01:42 PM Feature #2120: add runtime support for dynamically prepared queries

Eric Faulhaber wrote:
> I'm wondering if it makes sense to refactor @P2JQuery@ and @AbstractQuery@, since so many of... Constantin Asofiei

01:37 PM Feature #2120: add runtime support for dynamically prepared queries

Greg Shah wrote:
> Anything else?
The issues Constantin described in notes 63 & 66 above.
With regard to the @Ab... Eric Faulhaber

01:31 PM Feature #2120: add runtime support for dynamically prepared queries

Eric Faulhaber wrote:
> ... due to the memory requirements of the pristineScope data in each SchemaDictionary insta... Constantin Asofiei

01:06 PM Feature #2120: add runtime support for dynamically prepared queries

Let's create new tasks for the open issues:
* Conversion artifacts moved into and read from the application jar.
... Greg Shah

12:50 PM Feature #2120: add runtime support for dynamically prepared queries

Code review 20131030a:
Wow, brilliant update! Looks really good, only one major concern: the approach of having a ... Eric Faulhaber

12:12 PM Feature #2120: add runtime support for dynamically prepared queries

Constantin Asofiei wrote:
> the following files and folders must exist in the server/ folder (i.e. current folder whe... Eric Faulhaber

11:22 AM Feature #2120: add runtime support for dynamically prepared queries

I missed something in the @QueryWrapper@ c'tor; I think this code:... Constantin Asofiei

09:52 AM Feature #2120 (Review): add runtime support for dynamically prepared queries

Attached 1030a.zip (replacement for 1029c.zip) and 1029a.zip have passed conversion and runtime testing. (1029c.zip h... Constantin Asofiei

12:26 PM Feature #2116: add runtime support for _user metadata table

I discovered that the buffer conflict was not correctly fixed. The name collision could occur also with buffers/table... Ovidiu Maxiniuc

10/29/2013

02:53 PM Feature #2116: add runtime support for _user metadata table

Eric,
I believe that we can live with a few hundreds KB of data permanently loaded for never or seldom databases ... Ovidiu Maxiniuc

10:35 AM Feature #2120: add runtime support for dynamically prepared queries

Code Review 1029a
This update is good to go. Nice!
Eric will handle the other update. Greg Shah

07:58 AM Feature #2120: add runtime support for dynamically prepared queries

1029a.zip is replacement for 1023d.zip (in-memory registry/storage plugin).
1029c.zip contains the changes for conve... Constantin Asofiei

03:31 AM Feature #2120: add runtime support for dynamically prepared queries

Eric Faulhaber wrote:
> I guess this makes sense on some level. For a dynamically created query, the handle(s) to it... Constantin Asofiei

03:22 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Eric Faulhaber wrote:
> Constantin, I didn't think of this earlier when we were discussing all the new annotations f... Constantin Asofiei

10/28/2013

07:14 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Testcases. Note that most of them are not directly convertible since we do not support dynamic queries yet, I've been... Stanislav Lomany

06:32 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Test update. Sorry, no Javadoc, but function names are pretty self-explanatory.
In general it works properly, exc... Stanislav Lomany

03:38 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Constantin, I didn't think of this earlier when we were discussing all the new annotations for the DMOs: are we going... Eric Faulhaber

04:53 PM Feature #2116: add runtime support for _user metadata table

I was continuing work on #2115 and noticed this same issue. I don't have a use case like yours readily available; ple... Eric Faulhaber

04:44 PM Feature #2116: add runtime support for _user metadata table

I merged my sources with the latest from bzr (especially 2115, with other metadata implementation)
I have the fol... Ovidiu Maxiniuc

03:34 PM Feature #2120: add runtime support for dynamically prepared queries

I guess this makes sense on some level. For a dynamically created query, the handle(s) to it are the only way to acce... Eric Faulhaber

07:40 AM Feature #2120: add runtime support for dynamically prepared queries

I found something interesting and pretty weird about the static QUERY behaviour. Although the query handle CAN be del... Constantin Asofiei

12:37 AM Feature #2115 (WIP): add runtime support for _file and _field metadata tables

Eric Faulhaber

12:18 AM Feature #2115: add runtime support for _file and _field metadata tables

This update passed regression testing and is committed to bzr rev 10407. This drop does not include the @MetaSchema@ ... Eric Faulhaber

10/25/2013

12:42 PM Feature #2120: add runtime support for dynamically prepared queries

Eric Faulhaber wrote:
> I didn't want to rely on the naming convention alone to determine the DMO class from the DMO... Constantin Asofiei

10:11 AM Feature #2120: add runtime support for dynamically prepared queries

I didn't want to rely on the naming convention alone to determine the DMO class from the DMO interface. So, in order ... Eric Faulhaber

09:39 AM Feature #2120: add runtime support for dynamically prepared queries

Eric, I'm finally going into the record scoping behavior for the dynamic queries, and I have a question: why don't we... Constantin Asofiei

03:14 AM Feature #2120: add runtime support for dynamically prepared queries

Greg Shah wrote:
> > I think a separate task is appropriate, to check that all resources (static or dynamic) are del... Constantin Asofiei

10/24/2013

04:40 PM Feature #2116: add runtime support for _user metadata table

> P4gl does not compile the code (Error 1762: name is ambiguous with p2j_test.customer.Name and db2.Customer.name) so... Greg Shah

04:25 PM Feature #2116: add runtime support for _user metadata table

Ovidiu Maxiniuc wrote:
> I have fixed it (by analyzing in @record_scoping_post.rules@ if there are buffer conflicts ... Eric Faulhaber

01:27 PM Feature #2116: add runtime support for _user metadata table

I have discovered an issue yesterday. Having two databases connected that have common table names (as particular case... Ovidiu Maxiniuc

01:17 PM Feature #2120: add runtime support for dynamically prepared queries

> I think a separate task is appropriate, to check that all resources (static or dynamic) are deleted properly.
Pl... Greg Shah

12:58 PM Feature #2120: add runtime support for dynamically prepared queries

Eric Faulhaber wrote:
> Each extent field has a @size<PropertyName>@ method in the DMO, which returns an @integer@.
... Constantin Asofiei

12:55 PM Feature #2120: add runtime support for dynamically prepared queries

Stanislav Lomany wrote:
> Constantin Asofiei wrote:
> > Stanislav: for dynamic temp-tables, I see that you clean al... Constantin Asofiei

12:49 PM Feature #2120: add runtime support for dynamically prepared queries

Constantin Asofiei wrote:
> Eric: I need the extent information for a field too; should I annotate the inner Composit... Eric Faulhaber

12:48 PM Feature #2120: add runtime support for dynamically prepared queries

Constantin Asofiei wrote:
> Stanislav: for dynamic temp-tables, I see that you clean all the dynamic DMOs in @TempTa... Stanislav Lomany

12:47 PM Feature #2120: add runtime support for dynamically prepared queries

Greg Shah wrote:
> Do we need a new "hook" to handle the class unloading "event" in a RUN PERSISTENT case?
Yes, s... Constantin Asofiei

12:35 PM Feature #2120: add runtime support for dynamically prepared queries

Do we need a new "hook" to handle the class unloading "event" in a RUN PERSISTENT case? For a procedure run as non-p... Greg Shah

12:26 PM Feature #2120: add runtime support for dynamically prepared queries

Stanislav: for dynamic temp-tables, I see that you clean all the dynamic DMOs in @TempTableBuilder$Context.finished@.... Constantin Asofiei

12:03 PM Feature #2120: add runtime support for dynamically prepared queries

Eric: I need the extent information for a field too; should I annotate the inner Composite class or I can assume ever... Constantin Asofiei

10:01 AM Feature #2120: add runtime support for dynamically prepared queries

The plan for implementing the attributes/methods is this:
# query attributes:
The following are almost done:... Constantin Asofiei

01:48 AM Feature #2120: add runtime support for dynamically prepared queries

Attached 1023c.zip update is the final version for conditional rule-sets.
The following updates have passed conversio... Constantin Asofiei

10:41 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> Stanislav, if you've managed to implement BUFFER's NAME and TABLE-HANDLE attributes, please extract these changes (... Stanislav Lomany

10:07 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Stanislav, if you've managed to implement BUFFER's NAME and TABLE-HANDLE attributes, please extract these changes (in... Constantin Asofiei

10/23/2013

02:44 PM Feature #2120: add runtime support for dynamically prepared queries

> Code Review 1023d
This has passed conversion testing (as the other 2 updates), but I'll keep it a little more unti... Constantin Asofiei

12:07 PM Feature #2120: add runtime support for dynamically prepared queries

> I want to initialize the AstManager before anyone else gets a chance to initialize it, as this is a JVM-wide settin... Greg Shah

11:58 AM Feature #2120: add runtime support for dynamically prepared queries

> 2. The InMemoryRegistryPlugin has this comment: @implements an in-memory XML storage option for an AstManagerPlugin... Constantin Asofiei

11:36 AM Feature #2120: add runtime support for dynamically prepared queries

Code Review 1023d
1. I really like the changes. It is possible some of the file normalization could cause breaka... Greg Shah

11:05 AM Feature #2120: add runtime support for dynamically prepared queries

Greg, please check these changes; they are related to the in-memory AST storage plugin. For this, the filenames must ... Constantin Asofiei

10:00 AM Feature #2120: add runtime support for dynamically prepared queries

Code Review 1023a/1023b
I am good with all these changes.
The only request I have is to replace the javadoc tex... Greg Shah

09:57 AM Feature #2120: add runtime support for dynamically prepared queries

Greg: 1023a.zip needs some more testing, please let me know if the approach is correct. Constantin Asofiei

07:11 AM Feature #2120: add runtime support for dynamically prepared queries

Attached are:
# 1023a.zip - new version of conditional rule-set processing. In the end, I think is best to allow fla... Constantin Asofiei

12:21 AM Feature #2120: add runtime support for dynamically prepared queries

The database portions (1021c/g) look OK to me, as long as we address the TODO in @TempTableBuilder.asHandle@. I have ... Eric Faulhaber

10/22/2013

02:18 PM Feature #2116: add runtime support for _user metadata table

Code Review 1022a
The changes are fine. The only thing I see is that it seems the SessionListener notification in... Greg Shah

01:18 PM Feature #2116: add runtime support for _user metadata table

Greg, thanks for your quick review. It was much easier fr me to find those issues.
As you probably observed, update ... Ovidiu Maxiniuc

07:14 AM Feature #2116: add runtime support for _user metadata table

Code Review 1021a
Overall, this is really good. It is very close to what we need.
1. It seems that we can drop... Greg Shah

08:30 PM Feature #2116: add runtime support for _user metadata table

Code review 20131021a (database-related only):
Generally looks good from the database side, though you need to mer... Eric Faulhaber

01:19 PM Feature #2120: add runtime support for dynamically prepared queries

I am OK with this approach. Greg Shah

11:14 AM Feature #2120: add runtime support for dynamically prepared queries

Greg, thanks, is much more clear now. Please confirm the following approach is good. At this time, there are two plac... Constantin Asofiei

10:32 AM Feature #2120: add runtime support for dynamically prepared queries

> The handle.unwrap[hwrap] API referenced by the hwrap var in methods_attributes.rules is not hard-linked with the in... Greg Shah

09:57 AM Feature #2120: add runtime support for dynamically prepared queries

> Code Review 1021c
> 1. It seems like the methods_attributes.rules change should have hwrap as DynamicResource not ... Constantin Asofiei

08:51 AM Feature #2120: add runtime support for dynamically prepared queries

Code Review 1021g
1. I prefer the enable/disable of conditional rule-set processing to be done at the PatternEngin... Greg Shah

08:40 AM Feature #2120: add runtime support for dynamically prepared queries

Code Review 1021f
I am fine with the change to brew.xml. Eric will have to review the rest. Greg Shah

08:38 AM Feature #2120: add runtime support for dynamically prepared queries

Code Review 1021c
1. It seems like the methods_attributes.rules change should have hwrap as DynamicResource not Dy... Greg Shah

08:16 AM Feature #2120: add runtime support for dynamically prepared queries

1021g.zip (legacy index annotations), 1021f.zip (conditional rule-sets) and 1021c.zip (DYNAMIC attribute support) ha... Constantin Asofiei

08:06 AM Feature #2120: add runtime support for dynamically prepared queries

Stanislav Lomany wrote:
> Constantin, in order to generate UNIQUE-ID for static temp-tables, their creation should b... Constantin Asofiei

06:33 AM Feature #2120: add runtime support for dynamically prepared queries

> I need just the TEMP-TABLE:UNIQUE-ID attribute and the TempTableBuilder.persistentClass to be implemented for stati... Stanislav Lomany

10/21/2013

04:01 PM Feature #2120: add runtime support for dynamically prepared queries

1021g.zip is replacement for 1021d.zip (legacy index annotations); changes:
* fix bug to ignore synthetic indexes
*... Constantin Asofiei

09:25 AM Feature #2120: add runtime support for dynamically prepared queries

Attached update adds legacy index annotations at the DMO implementation classes. This and the info provided by the DM... Constantin Asofiei

08:38 AM Feature #2120: add runtime support for dynamically prepared queries

> currently, the entire annotations/base_structure/core_conversion rulesets are ran, but I will try to limit this to ... Greg Shah

08:13 AM Feature #2120: add runtime support for dynamically prepared queries

Yes, good point. Sorry, haven't had my morning coffee yet. <g> Eric Faulhaber

08:07 AM Feature #2120: add runtime support for dynamically prepared queries

Eric, the same problem with the legacy temp-table name: temp-table information is not in the legacy metadata tables; ... Constantin Asofiei

08:05 AM Feature #2120: add runtime support for dynamically prepared queries

I should have thought of this earlier: I am regression testing metadata support (#2115), which includes the @_Index@ ... Eric Faulhaber

07:50 AM Feature #2120: add runtime support for dynamically prepared queries

Eric Faulhaber wrote:
> ... we already have a lot of knowledge of index information in the runtime via the IndexHel... Constantin Asofiei

07:35 AM Feature #2120: add runtime support for dynamically prepared queries

Adds @DYNANIC@ attribute support; main rules are:
# static resources can't be deleted
# for static widget case, an ... Constantin Asofiei

02:30 AM Feature #2120: add runtime support for dynamically prepared queries

> AFAIK, we do not support temp-table handles, so I guess it will not come with the very first version.
The dynamic ... Constantin Asofiei

02:21 AM Feature #2120: add runtime support for dynamically prepared queries

> 5. the support for the @DYNAMIC@ attribute needs to be fixed, as this attribute is for more than one resource (curr... Stanislav Lomany

09:03 PM Feature #2120: add runtime support for dynamically prepared queries

Constantin Asofiei wrote:
> following test does convert and produces valid output
> [...]
Very cool!
> need to ... Eric Faulhaber

01:59 PM Feature #2116: add runtime support for _user metadata table

I have moved the processing of _user from *.java into TRPL. While reviewing the changes I found a solution to have th... Ovidiu Maxiniuc

07:57 AM Feature #2116: add runtime support for _user metadata table

Ovidiu Maxiniuc wrote:
> Hardcoding the table name, _userid and _password fields are necessary because they need to ... Eric Faulhaber

06:39 AM Feature #2116: add runtime support for _user metadata table

Hardcoding the table name, _userid and _password fields are necessary because they need to be accessed in a special w... Ovidiu Maxiniuc

02:45 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Attached update is merged with 10402 and committed to bzr revision 10403. Constantin Asofiei

08:43 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

This update looks fine to me. Please go ahead and commit/distribute it. Eric Faulhaber

10/20/2013

02:31 PM Feature #2120: add runtime support for dynamically prepared queries

Some notes on my current status (Stanislav/Greg/Eric, please check the questions):
# following test does convert and... Constantin Asofiei

10/19/2013

03:46 AM Feature #2141: generate SQL Server schema

> Finally, tc_job_clock_002 passed and I think issue passes regression.
Yes, exactly. Eugenie Lyzenko

03:39 AM Feature #2141: generate SQL Server schema

Finally, tc_job_clock_002 passed and I think issue passes regression. Vadim Nebogatov

03:39 AM Feature #2141: generate SQL Server schema

Regression 20131018_172945, 5 FAILED tests:
1. tc_job_002 FAILED failure in step 40: 'Unexpected EOF in actual at ... Vadim Nebogatov

10/18/2013

04:10 PM Feature #2141: generate SQL Server schema

Regression 20131018_102350, 3 FAILED tests:
1. tc_job_002 FAILED failure in step 40: 'Unexpected EOF in actual at ... Vadim Nebogatov

09:45 PM Feature #2141: generate SQL Server schema

Vadim Nebogatov wrote:
> Start regression one more time?
Might as well, but please also work with Eugenie in the me... Eric Faulhaber

02:48 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Second run of CTRL-C testing for 1018a.zip was OK. Constantin Asofiei

01:25 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Attached update completes the legacy annotations at the DMO implementation class. See #2195 for the MAJIC changes.
... Constantin Asofiei

01:03 PM Feature #2115: add runtime support for _file and _field metadata tables

This is an interim drop of my implementation of this feature. It has failed regression testing so far, but contains s... Eric Faulhaber

12:59 PM Feature #2116: add runtime support for _user metadata table

Code review 20131014a (database-related):
* Other than to avoid collisions with Java and SQL reserved keywords, le... Eric Faulhaber

10/17/2013

06:52 PM Feature #2141: generate SQL Server schema

Start regression one more time? Vadim Nebogatov

12:55 PM Feature #2141: generate SQL Server schema

Regression 20131017_034322, 9 FAILED and 3 FAILED_DEPENDENCY tests:
1. gso_491 FAILED failure in step 15: 'timeout ... Vadim Nebogatov

02:54 PM Feature #2116: add runtime support for _user metadata table

> Then I thought - at connection time there is only one session per queue so let's try enriching the SessionListener ... Greg Shah

02:10 PM Feature #2116: add runtime support for _user metadata table

> I'm thinking that the SecurityManager should be completely disabled if database authorization is in charge.
I do... Greg Shah

01:07 PM Feature #2116: add runtime support for _user metadata table

Greg Shah wrote:
> If I understand the issue properly, you need to do some processing at the end of Conversation.run... Ovidiu Maxiniuc

12:24 PM Feature #2116: add runtime support for _user metadata table

Sorry, I fail to understand some of the notes above.
I'm thinking that the @SecurityManager@ should be completely di... Ovidiu Maxiniuc

01:08 PM Feature #2120: add runtime support for dynamically prepared queries

> Stanislav, is there a specific reason why you chose to explicitly store objects rather than build something generic... Stanislav Lomany

11:42 AM Feature #2120: add runtime support for dynamically prepared queries

Stanislav, is there a specific reason why you chose to explicitly store objects rather than build something generic i... Constantin Asofiei

08:54 AM Feature #2120: add runtime support for dynamically prepared queries

The 2nd approach (in-memory compilation of real java code, like with the dynamic DMOs) is the one that I believe is t... Greg Shah

08:12 AM Feature #2120: add runtime support for dynamically prepared queries

About extracting the query instance from a generated JavaAST. The current approach is to parse a 4GL code like @OPEN ... Constantin Asofiei

08:56 AM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...

The requirements of this task have changed somewhat.
The change will no longer take place on an all or nothing bas... Eric Faulhaber

01:31 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> * It's been a long time since I was in this code, but shouldn't the call to @TableMapper.removeTemporaryTables@ in ... Constantin Asofiei

11:12 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Code review 20131016b:
This update looks quite good, but I have a few questions:
* It's been a long time since ... Eric Faulhaber

10/16/2013

03:49 PM Feature #2116: add runtime support for _user metadata table

If I understand the issue properly, you need to do some processing at the end of Conversation.run() when the session'... Greg Shah

02:10 PM Feature #2116: add runtime support for _user metadata table

I am working on these changes, but only one question remains:
* in the case that metadata authentication is success... Ovidiu Maxiniuc

12:19 PM Feature #2116: add runtime support for _user metadata table

> in order to store database-level userid/password a per-user structure need to be added in directory. In a non-scope... Greg Shah

11:36 AM Feature #2116: add runtime support for _user metadata table

Greg Shah wrote:
> Although I like the database authentication to be isolated in its own methods as much as possible... Ovidiu Maxiniuc

10:09 AM Feature #2116: add runtime support for _user metadata table

> The problem is that I need the authenticated userids for each database at runtime, in the context of the client. Th... Greg Shah

07:21 AM Feature #2116: add runtime support for _user metadata table

Greg Shah wrote:
> Code Review 1014a
>
> Eric will handle all the database/persistence portions (conversion and r... Ovidiu Maxiniuc

12:02 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Constantin Asofiei wrote:
> Please let me know if you see something wrong in my reasoning above (and an initial revi... Eric Faulhaber

11:07 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

LE: actually, for parsing the prepare query string, I need the legacy buffer name, not the legacy temp-table name. An... Constantin Asofiei

10:54 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Greg Shah wrote:
> There must be a place in the generated business logic where we access the DMO implementation clas... Constantin Asofiei

09:43 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

There must be a place in the generated business logic where we access the DMO implementation class for the temp-table... Greg Shah

09:10 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Greg,
> I prefer to keep a common/shared temp-table class where it is structurally possible, as this is a much bette... Constantin Asofiei

08:26 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> If a dynamic buffer is created in an inner scope, and then used to change data in an arbitrary, "middle" scope (i.e... Stanislav Lomany

08:24 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> And if we want to be completely perfect, we should convert temp tables which have the names in different cases to d... Greg Shah

06:26 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Stanislav, some notes on TempTableBuilder getters for various attributes; i.e. @TempTableBuilder.uniqueId@ is defined... Constantin Asofiei

06:06 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> Now I even can't start server:
Please comment line 223 in ORMHandler (to disable mappings for permanent DBs) until... Constantin Asofiei

06:01 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

There are massive changes in TableMapper. Is that right table mapper? Stanislav Lomany

06:00 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Now I even can't start server:... Stanislav Lomany

05:09 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Stanislav Lomany wrote:
> > Remove the @get@, @set@ or @is@ prefixes (so there is no way to conflict with a DMO gett... Constantin Asofiei

05:02 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> Remove the @get@, @set@ or @is@ prefixes (so there is no way to conflict with a DMO getter or setter).
And if we h... Stanislav Lomany

04:47 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

PS: the NPE is fixed, but I need to finish the annotations for the hand-written DMOs in MAJIC. Will post this later t... Constantin Asofiei

04:08 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> Constantin, how the new names should look like?
Remove the @get@, @set@ or @is@ prefixes (so there is no way to co... Constantin Asofiei

03:48 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> Stanislav, while you are working on dynamic buffers, I think is a good opportunity to rename get and set methods ac... Stanislav Lomany

05:48 AM Feature #2120: add runtime support for dynamically prepared queries

Related to note 8 - see the discussion in notes 20-36 in #1654. Summary: TableMapper was added to map legacy names fo... Constantin Asofiei

10/15/2013

06:51 PM Feature #2116: add runtime support for _user metadata table

Code Review 1014a
Eric will handle all the database/persistence portions (conversion and runtime).
In regard to... Greg Shah

02:04 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

This update contains the following:
# conversion rules to emit annotations at DMO impl class and DMO properties
# r... Constantin Asofiei

12:56 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Stanislav Lomany wrote:
> In its outermost scope the buffer should be
> 1. registered as finalizable
> 2. added to ... Eric Faulhaber

08:09 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

In 4GL, an external program can end up with two temp-tables with the same name (exposed via handles).
* Program 1 de... Constantin Asofiei

12:22 PM Feature #2141: generate SQL Server schema

Regression 20131015_061357
A lot (20+) failed ts_tests, all related with timeout. I think something happened and I... Vadim Nebogatov

10/14/2013

02:52 PM Feature #2024 (WIP): implement runtime support for database triggers

Ovidiu Maxiniuc

02:42 PM Feature #2141: generate SQL Server schema

Sorry, silly question, I should have looked at the timestamps. Times seem OK.
Perhaps your last run will resolve t... Eric Faulhaber

02:04 PM Feature #2141: generate SQL Server schema

Eric Faulhaber wrote:
> What time of day (i.e., devsrv01 time -- EDT) did you run the harness?
Regression 20131... Vadim Nebogatov

01:47 PM Feature #2141: generate SQL Server schema

What time of day (i.e., devsrv01 time -- EDT) did you run the harness? Eric Faulhaber

01:42 PM Feature #2141: generate SQL Server schema

I have executed regression two times.
Regression @20131013_090710@, 3 FAILED tests:
1. tc_job_002 FAILED failur... Vadim Nebogatov

12:45 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

OK.
One more request: for the API, let's use @getDMOName@ instead of @javaName@ and @getPropertyName@ instead of @... Eric Faulhaber

12:43 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> One minor change is that I think we need to store the legacy buffer name in @RecordBuffer@ instead of @BufferImpl@.... Constantin Asofiei

12:38 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

I agree with this proposed approach. One minor change is that I think we need to store the legacy buffer name in @Rec... Eric Faulhaber

12:08 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> What would the code look like which would use these annotations at runtime?
What I'm thinking is to have several ma... Constantin Asofiei

11:38 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Interesting idea. This would obviate the need for the @_new-name@ field in @_file@ and @_field@. What would the code ... Eric Faulhaber

11:26 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> > I'm thinking if it would not be easier using annotations at the DMO interface definition; from these, we could bu... Constantin Asofiei

11:04 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Constantin Asofiei wrote:
> I don't think _file can be easily used for temp-tables, as I won't be able to do a "sele... Eric Faulhaber

10:36 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> @MetaSchema@ will give you access to this lookup in both directions.
Thanks, this is good news.

> Now, Progres... Constantin Asofiei

10:15 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Constantin Asofiei wrote:
> As I understand, the temp-tables will not be mapped by @MetaSchema@; thus, how do we obt... Eric Faulhaber

09:46 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

I'll let Eric respond on the MetaSchema questions.
> Beside this, SchemaDictionary must implement Scopeable too, t... Greg Shah

09:01 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> We would like to integrate the dynamic-temp table state information as much as possible with the @SchemaDictionary@... Constantin Asofiei

07:18 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Stanislav, while you are working on dynamic buffers, I think is a good opportunity to rename get and set methods acce... Constantin Asofiei

12:06 PM Feature #2116: add runtime support for _user metadata table

This update includes:
* generation of meta_user table within the other normal schemas
* when importing a database d... Ovidiu Maxiniuc

05:20 AM Feature #2116: add runtime support for _user metadata table

Indeed, the database/p2j_test from my directory.xml was wrong, it contained the following entries:... Ovidiu Maxiniuc

10/12/2013

10:18 AM Feature #2141: generate SQL Server schema

I have attached update vmn_upd20131012a.zip and corresponding cfg and dll files in vmn_upd20131012b.zip.
Update cor... Vadim Nebogatov

06:31 AM Feature #2141: generate SQL Server schema

Eric Faulhaber wrote:
> I'm just curious: what is the @SelectedMethod=Cursor@ parameter in the database URL for (@ge... Vadim Nebogatov

12:07 AM Feature #2116: add runtime support for _user metadata table

Wait, why are you using @TempTableConnectionProvider@ for those other connected databases? This sounds like a configu... Eric Faulhaber

10/11/2013

04:21 PM Feature #2116: add runtime support for _user metadata table

Meanwhile I tried to connect to different database servers using different dialects (one PSQL, one H2).
I was expect... Ovidiu Maxiniuc

03:40 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

OK, please let me know if you see some obvious flaws in the rest of the plan. Stanislav Lomany

03:07 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Sorry I missed that detail in my review. This is a good question, and after speaking with Greg, I am shifting my opin... Eric Faulhaber

01:42 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> I am a bit confused by this comment. @MetaSchema@ will have schema information, basically the equivalent for temp-t... Stanislav Lomany

12:37 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Stanislav Lomany wrote:
> Determination of the outermost scope for a temp-table is the task for MetaSchema, it canno... Eric Faulhaber

08:12 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Let's forget for a second about persistent procedures and widget pools. For normal processing, as I said earlier, a d... Stanislav Lomany

09:56 PM Feature #2141: generate SQL Server schema

Code review 20131006:
Nice work.
I'm just curious: what is the @SelectedMethod=Cursor@ parameter in the databas... Eric Faulhaber

10/10/2013

09:03 AM Feature #2116: add runtime support for _user metadata table

Another difference I thought of is that when we connect to multiple databases in regression testing, both have the sa... Eric Faulhaber

08:49 AM Feature #2116: add runtime support for _user metadata table

Thanks for the clarification. So, are you saying the above stack trace was generated from the query running against @... Eric Faulhaber

03:41 AM Feature #2116: add runtime support for _user metadata table

I will investigate the @JdbcKeyRetriever@, I did not see any flaw in @DatabaseManager.getDatabaseTables(Database)@.
... Ovidiu Maxiniuc

10/09/2013

04:20 PM Feature #2116: add runtime support for _user metadata table

This query doesn't look correct. Why are we accessing tables from different databases in the same query? Perhaps a bu... Eric Faulhaber

02:25 PM Feature #2116: add runtime support for _user metadata table

The customer is using simultaneous connection to databases "common" and "<db_name>".
I have done today some research... Ovidiu Maxiniuc

10/08/2013

02:10 PM Feature #2120: add runtime support for dynamically prepared queries

Don't know why I forgot the SymbolResolver is backed by the SchemaDictionary for temp-table stuff; with this in mind,... Constantin Asofiei

01:53 PM Feature #2120: add runtime support for dynamically prepared queries

Interesting results. These are good limitations as they greatly reduce the possible functionality.
> temp-table d... Greg Shah

01:41 PM Feature #2120: add runtime support for dynamically prepared queries

Some initial thoughts on this: the documentation (and practice) shows that for a prepared query string:
# it follows ... Constantin Asofiei

08:29 AM Feature #2120: add runtime support for dynamically prepared queries

I wrote:
> optimization of conversion resources into a queued service (i.e., to prevent one instance of SchemaDictio... Eric Faulhaber

08:57 AM Feature #2116: add runtime support for _user metadata table

>> 2. Why is there a <node class="container" name="bogus"> container in your example directory structure?
>
> Yes, ... Greg Shah

08:46 AM Feature #1651: add support for dynamic database features

To clarify:
# We are not going to use a binary implementation of TRPL for our first implementation.
# We don't wa... Greg Shah

08:34 AM Feature #1651: add support for dynamic database features

Note that any use of conversion features at runtime will require the use of existing or new conversion rule-sets and ... Eric Faulhaber

04:52 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

About @CREATE BUFFER@ and implicit resource deletion in general. I've tested using these two programs:
# a program wh... Constantin Asofiei

02:25 AM Feature #1654 (WIP): add conversion and runtime support for dynamic buffer creation and cleanup

Stanislav Lomany

10/07/2013

06:12 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

Stas, while you're in this code, please move all the @public static@ variants of @RecordBuffer.create@ where they bel... Eric Faulhaber

02:16 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup

> Right now I'm trying to figure out how a dynamic buffer should be handled in the scopes outer to the point where th... Greg Shah

03:49 PM Feature #2116: add runtime support for _user metadata table

Greg Shah wrote:
> 1. Your "implements UserSecurityOps" needs to be on its own line (in 2 files).
I believe this is... Ovidiu Maxiniuc

01:37 PM Feature #2141: generate SQL Server schema

I guess the 2-character difference in the "usable" portion of the key is attributable to extra overhead caused by the... Eric Faulhaber

12:29 PM Feature #2141: generate SQL Server schema

Test: ... Vadim Nebogatov

09:32 AM Feature #2141: generate SQL Server schema

If I understand correctly, this is good news. I was not aware of this limit in Progress.
Vadim, please put togethe... Eric Faulhaber

06:59 AM Feature #2141: generate SQL Server schema

It's very possible that I'm misunderstanding the issue, but isn't the MS SQL server limit less restrictive than the c... Paul E

04:37 AM Feature #2141: generate SQL Server schema

Corrected vmn_upd20131006a and added vmn_upd20131006b with uast (p2j.cfg.xml and all generated ddls). Vadim Nebogatov

10/06/2013

05:21 PM Feature #2141: generate SQL Server schema

I have attached update vmn_upd20131006a.zip and corresponding tested dll files. Update corresponds to latest bzr revi... Vadim Nebogatov

10/04/2013

06:29 PM Feature #2141: generate SQL Server schema

Eric, Greg,
Yes, this expression is wrong because second parameter in @replace()@ is the substring to be found, not... Vadim Nebogatov

08:34 AM Feature #2141: generate SQL Server schema

> We want to right-trim ANY whitespace character (i.e., '\t', '\n', '\r') which appears after the last non-whitespace... Greg Shah

07:45 AM Feature #2141: generate SQL Server schema

Please clarify something for me. I should have asked this earlier, but I just noticed it now:... Eric Faulhaber

05:26 AM Feature #2141: generate SQL Server schema

Attached updated ddl files. Vadim Nebogatov

05:07 AM Feature #2141: generate SQL Server schema

Eric Faulhaber wrote:
> Does this mean a row will not be inserted into the table if it exceeds these limitations of ... Vadim Nebogatov

04:27 PM Feature #2116: add runtime support for _user metadata table

Code Review 1004a
I'm only reviewing the util/ and security/ changes. Eric will handle the persistence stuff (run... Greg Shah

02:47 PM Feature #2116: add runtime support for _user metadata table

When importing the _User table, the implementation searches for the @_User.d@ and @pwds.txt@ files at the same locati... Ovidiu Maxiniuc

01:43 PM Feature #2116: add runtime support for _user metadata table

I attached the latest sources. I hope the above note and comments from code will help understand the implementation. ... Ovidiu Maxiniuc

10:13 AM Feature #2125: add runtime support for dynamic buffer creation and cleanup

Stanislav: please double-check the FIRST-BUFFER parameter (I will release an update for it soon), to make sure is imp... Constantin Asofiei

10/03/2013

07:43 PM Feature #2141: generate SQL Server schema

Does this mean a row will not be inserted into the table if it exceeds these limitations of the index, or that the in... Eric Faulhaber

04:45 PM Feature #2141: generate SQL Server schema

Series of warnings if map to varchar(8000) ... Vadim Nebogatov

10/02/2013

07:05 PM Feature #2141: generate SQL Server schema

*About using Hibernate SQL Functions and stored procedures (functions) for new rtrim*.
It is possible Hibernate SQL... Vadim Nebogatov

09:29 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

20131002a changes look good. Please commit and distribute if testing passes. Eric Faulhaber

07:46 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

And @get4GLTableName@ functions too. Stanislav Lomany

06:56 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

> OK, please run it through another round of regression testing after you've made the above changes. Since they are p... Stanislav Lomany

10/01/2013

06:41 PM Feature #2141: generate SQL Server schema

Eric Faulhaber wrote:
> I'm familiar. It's an absolute necessity to have updated statistics to get the query planner... Vadim Nebogatov

06:22 PM Feature #2141: generate SQL Server schema

Vadim Nebogatov wrote:
> Eric Faulhaber wrote:
> > Vadim Nebogatov wrote:
> > > @[substring(expr, 0, len(replace(e... Eric Faulhaber

04:17 PM Feature #2141: generate SQL Server schema

Eric Faulhaber wrote:
> Vadim Nebogatov wrote:
> > @[substring(expr, 0, len(replace(expr, CHAR(9)+CHAR(10)+CHAR(13), ... Vadim Nebogatov

06:26 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

OK, please run it through another round of regression testing after you've made the above changes. Since they are pre... Eric Faulhaber

05:00 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables

> I would like to see your test cases. Are these checked into the testcases project? Please provide a list of names, ... Stanislav Lomany

08:33 AM Feature #2116: add runtime support for _user metadata table

The implementation I am debugging now works like this:
* I added a new type of authentication (@AUTH_MODE_METADATA =... Ovidiu Maxiniuc

08:10 AM Feature #2116: add runtime support for _user metadata table

> If for one of the databases the authentication fails all three times, the client process is closed, even if for a p... Greg Shah

08:08 AM Feature #2116: add runtime support for _user metadata table

I'm moving this discussion here from email, because it is important to record it as part of the task.
-------- Ori... Greg Shah