Project

General

Profile

Activity

From 11/12/2013 to 12/11/2013

12/12/2013

11:46 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Vadim Nebogatov wrote:
> What will we do now with dynamic references for custom extents? Recognize them on @record_s...
Eric Faulhaber

12/11/2013

06:24 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Statically indexed references seems converted correctly now, for example... Vadim Nebogatov
03:58 PM Feature #2024: implement runtime support for database triggers
Uploaded update package. This version is merged with latest bzr revision.
Previously mentioned issues have been fix...
Ovidiu Maxiniuc
07:40 AM Feature #1662: runtime support for table parameters
Eric, I'm still investigating the question in order to provide exact list of required changes, but at this point it i... Stanislav Lomany

12/10/2013

04:57 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
I know it is confusing, but this does occur for a reason. The top-most node of an expression is always EXPRESSION. A... Greg Shah
04:35 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
In *.ast file, for expression like
@person.schedule[1] = person.schedule[4].@
"EXPRESSION" ast node missed for...
Vadim Nebogatov
04:38 PM Feature #2024: implement runtime support for database triggers
Attached large part of my test-cases for database triggers. Ovidiu Maxiniuc
01:52 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
OK, I've added the info there. Constantin Asofiei
01:42 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
Use #1655 for this. We can change the assignee. Eric Faulhaber
01:35 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
Stanislav/Eric: is there a task for implementing the attributes/methods for the BUFFER-field resource? I ask this bec... Constantin Asofiei
01:51 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
For M7, we need to add support for the BUFFER-field attributes in use. At least DATA-TYPE is needed. The attributes w... Constantin Asofiei
01:44 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
We can ignore the last entry about @MetaSchema@. This approach has been replaced by the use of annotations, which sho... Eric Faulhaber
09:28 AM Feature #2207: Remaining issues for dynamic buffers and dynamic tables
Remaining issues:
1. Bug which causes abend if there is constraints violation error in two buffers for a dynamic tab...
Stanislav Lomany

12/09/2013

06:56 PM Feature #2024: implement runtime support for database triggers
Please check in all test cases as you go. Greg Shah
06:49 PM Feature #2024: implement runtime support for database triggers
I've looked at om_upd20131206a.zip. There is a lot there, but it's too difficult for me to understand in its current ... Eric Faulhaber
06:45 PM Feature #2024: implement runtime support for database triggers
Stanislav: please see the following excerpt from an email discussion I had with Ovidiu today:
>> ECF: The update als...
Eric Faulhaber
06:35 PM Feature #2024: implement runtime support for database triggers
Code Review 1206a
This is just a review of the progress.g changes. I am OK with the changes so far. Please make ...
Greg Shah
12:35 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
Committed to bzr revision 10418.
All unfinished issues were moved to #2207.
Stanislav Lomany
12:25 PM Feature #2207 (WIP): Remaining issues for dynamic buffers and dynamic tables
Stanislav Lomany

12/06/2013

02:48 PM Feature #2024: implement runtime support for database triggers
This update contains the merged progress.g from Greg with support for parsing TRIGGER PROCEDURES as described in note... Ovidiu Maxiniuc
02:45 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Update vmn_upd20131206a.zip attached as result of merge vmn_upd20131129a.zip with revision 10418 (corresponding to co... Vadim Nebogatov
07:23 PM Feature #2127 (Closed): complete runtime support for dynamically prepared queries
Closing this task as redundant with #2120. Eric Faulhaber
07:13 PM Feature #2141 (Closed): generate SQL Server schema
We eventually will need to add a conversion feature to use explicit lengths for text columns, to be supplied by the c... Eric Faulhaber
07:07 PM Feature #1592 (Closed): implement additional database built-in functions
Eric Faulhaber
07:07 PM Feature #1593 (Closed): add conversion and runtime support for TO-ROWID() built-in function
Eric Faulhaber
07:06 PM Feature #1595 (Closed): add conversion and runtime support for DBPARAM() built-in function
Eric Faulhaber

12/05/2013

06:48 PM Feature #2118 (Closed): add runtime support for _index and _index-field metadata tables
Eric Faulhaber
06:45 PM Feature #2116 (Closed): add runtime support for _user metadata table
Eric Faulhaber
04:18 PM Feature #2206: use encoded passwords for _User table data import
Currently, we have a special data import requirement for applications which use the @_User@ metadata table: the deplo... Eric Faulhaber
04:07 PM Feature #2206 (Rejected): use encoded passwords for _User table data import
Eric Faulhaber
04:02 PM Feature #1662: runtime support for table parameters
Yes. Eric Faulhaber
03:55 PM Feature #1662: runtime support for table parameters
Does it include TABLE-HANDLE parameters? Stanislav Lomany
03:55 PM Feature #1652 (Closed): add conversion and runtime support for dynamically prepared temp-tables
Eric Faulhaber
03:55 PM Feature #2128 (Closed): generate and load DMO interface and implementation classes for dynamic te...
Eric Faulhaber
03:54 PM Feature #2122 (Closed): add runtime support for dynamically prepared temp-tables
Eric Faulhaber
03:35 PM Feature #1588: add conversion and runtime support for embedded SQL
See my review of 20131129a/b in #2126. Eric Faulhaber
03:33 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Code review 20131129a/b:
The changes look good. I am expecting an update for #1654 to be checked in today. Once th...
Eric Faulhaber
01:33 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Yes, you will need to track down all the places in code conversion we use the extent value to make some analysis/anno... Eric Faulhaber
07:02 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
I tried the way you ponted, namely with changes in javaGetterName and javaSetterName methods. Initial problem was how... Vadim Nebogatov
12:17 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
1204a looks good. Please commit and distribute the update. Eric Faulhaber

12/04/2013

05:59 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
To expand on my last post, the place where the DMO getter and setter method names are determined for purposes of conv... Eric Faulhaber
05:16 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
The *.dict file is used for parsing/interpreting the original 4GL code (as opposed to generating converted code), so ... Eric Faulhaber
05:08 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Question: the problem now is that we corrected *.p2o for fields with custom extent conversion, but code conversion pa... Vadim Nebogatov
04:36 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
This approach makes sense to me. Eric Faulhaber
01:50 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
Changes in this update:
1. Merged with the latest P2J code.
2. @getName()@/@setName(val)@ renamed to @name()@/@name...
Stanislav Lomany
05:37 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
Great! You are correct about the schema issue. Stanislav Lomany
04:07 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
Some possible problems:
1. is it possible that @getLegacyFieldName@ is called with a DMO interface parameter, not a ...
Constantin Asofiei
03:55 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
As far as I can tell, there is the single regression left:... Stanislav Lomany

12/03/2013

04:52 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
> As an approach, for some attributes we chose to use i.e. @character name()@ as getter and i.e. @name(character some... Stanislav Lomany
03:13 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
Stanislav Lomany wrote:
> Guy, what do you think is the best way to resolve naming conflict between @buf.name@ and @...
Constantin Asofiei
02:53 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
Guy, what do you think is the best way to resolve naming conflict between @buf.name@ and @buffer buf:name@? There are... Stanislav Lomany

12/02/2013

02:17 PM Feature #2024: implement runtime support for database triggers
After more testing/investigations on the schema ASSIGN trigger syntax I came to following form:... Ovidiu Maxiniuc
09:12 AM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
For getters/setters recognition in business logic, I suggest to add “index” property to LegacyField. It will be fill... Vadim Nebogatov
08:29 AM Feature #2116: add runtime support for _user metadata table
h3. 1. Conversion time
To be generated with @_user@ metadata support, the @p2j.cfg.xml@ has to declare the @<table...
Ovidiu Maxiniuc

12/01/2013

05:33 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
OK, I'll implement error handling in @StaticTempTable@. I don't think this should take much time. Stanislav Lomany

11/30/2013

10:18 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
>> Is this just about errors that only come into play in improperly written 4GL code?
>
> The errors appear if you...
Greg Shah

11/29/2013

03:20 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
> * In @DMOValidator.uniqueConstraintViolation@, you made a change to use the legacy table name. Have you confirmed t... Stanislav Lomany
12:51 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
Please also note that a large update for #2116 was just committed, and may require merges. Eric Faulhaber
12:33 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
Code review 20131129a:
Looks good overall, but I have some questions/comments:
* In @DMOValidator.uniqueConstra...
Eric Faulhaber
02:45 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Note 27 implemented in #2126, note 49 Vadim Nebogatov
02:37 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Update vmn_upd20131129a.zip/vmn_upd20131129b.zip attached.
Additionally to previous update vmn_upd20131126a.zip:
...
Vadim Nebogatov
12:47 PM Feature #2116: add runtime support for _user metadata table
Please post generic instructions here (or point to them, if they already exist -- I did not find them) on how to prod... Eric Faulhaber
12:40 PM Feature #2116: add runtime support for _user metadata table
Both pdates were committed to bzr rev 10417 and resp. git.
They were also distributed to team by mail.
Ovidiu Maxiniuc
12:34 PM Feature #2125 (Test): add runtime support for dynamic buffer creation and cleanup
Eric Faulhaber
08:25 AM Feature #2024: implement runtime support for database triggers
Update for review.
I know it's not up-to date (to rev 10416), I will merge the changes probably on Monday.
Known is...
Ovidiu Maxiniuc

11/28/2013

01:18 PM Feature #2024: implement runtime support for database triggers
Thanks, I see now.
I was blinded by the @WRITE@ trigger that also allows @new@/@old@ values. If no field is specifie...
Ovidiu Maxiniuc
12:57 PM Feature #2024: implement runtime support for database triggers
From the v11.0 documention for the TRIGGER PROCEDURE statement:... Greg Shah
12:28 PM Feature #2024: implement runtime support for database triggers
> In regard to your other changes, I should note that the 4GL docs state that NEW is a possible keyword used in the a... Ovidiu Maxiniuc
11:25 AM Feature #2024: implement runtime support for database triggers
This is the intermediate version of my progress.g changes which I plan to include with my work on #1634. Greg Shah
11:23 AM Feature #2024: implement runtime support for database triggers
Sadly, I independently found the same "implicit like" problem with the assign_trigger_var_def/regular_parm processing... Greg Shah
12:09 PM Feature #2116: add runtime support for _user metadata table
Code Review 1125d and 1121b
CustomSecurityOps has had the @public@ access modifier removed from all the methods. ...
Greg Shah
07:10 PM Feature #2116: add runtime support for _user metadata table
Code review 20131125d (database-related):
The database portions of this most recent drop look fine for check-in. T...
Eric Faulhaber
09:45 AM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
But I found out on testing one strange fact. Data Dictionary allows to create permanent table with no fields, default... Vadim Nebogatov
08:43 AM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Eric Faulhaber wrote:
> * Also regarding @IndexHelper.getPrimaryIndex@, I'm pretty sure this is the case, but have y...
Vadim Nebogatov
08:00 AM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Eric Faulhaber wrote:
> * In @IndexHelper.getPrimaryIndex@, the @primaryIndexByEntity@ map will never contain any en...
Vadim Nebogatov
04:43 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
With any solution @each tt1 where tt.f-1 = 0 or tt.f-2 = 0@ will be converted to @select tt__1.id from DynamicRecord1... Stanislav Lomany

11/27/2013

06:10 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Code review 20131126a:
* The new @legacy_primary_index_annotation@ in @java_templates.tpl@ is largely redundant with...
Eric Faulhaber
03:53 PM Feature #2024: implement runtime support for database triggers
I think that parts of the @progress.g@ should be re-written to allow the correct syntax to be parsed. It here are the... Ovidiu Maxiniuc
03:21 PM Feature #2116: add runtime support for _user metadata table
I finally obtained a satisfiable result with the update for this issue.
The final run wasn't flawless, but I couldn'...
Ovidiu Maxiniuc
11:26 AM Feature #2116 (Test): add runtime support for _user metadata table
Eric Faulhaber
09:27 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
So, when you use a dynamic table @tt@ (with fields @f-1@ and @f-2@) in a dynamic query, and in 4GL you have this pred... Constantin Asofiei
07:04 AM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
The problem: dynamic queries do not recognize fields of dynamic tables specified in 4GL where clause.
Cause:
1. Na...
Stanislav Lomany

11/26/2013

03:36 PM Feature #1588: add conversion and runtime support for embedded SQL
Actually I tested deleteAll() with @DELETE FOR@ for permanent tables. Rest issue, – fix in P2JIndex.getOrderByClause... Vadim Nebogatov
03:35 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Update vmn_upd20131126a.zip is attached.
Fixed P2JIndex.getOrderByClause(), used dmoAlias instead of table name.
...
Vadim Nebogatov

11/25/2013

02:01 PM Feature #1588: add conversion and runtime support for embedded SQL
Please use the new primary index annotation you have added for #2126 to ensure that the no-WHERE-clause variant of @d... Eric Faulhaber
01:53 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Update vmn_upd20131125a.zip is attached.
1) Using java annotations for retrieving primary index and deleteAll().
...
Vadim Nebogatov

11/23/2013

12:18 AM Feature #2117: add runtime support for _lock metadata table
The attached update adds basic conversion and runtime metadata support for the _lock table. It has passed regression ... Eric Faulhaber

11/22/2013

03:08 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Vadim Nebogatov wrote:
> [...] But I agree that separate <extent-name> elements look better. Should I correct?
Yes...
Eric Faulhaber
02:41 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Eric Faulhaber wrote:
> * Why did you choose a CSV format for the @<extent-names>@ hint element, instead of using se...
Vadim Nebogatov
07:01 AM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Go ahead and commit and distribute the update, even though the above issues need to be addressed. It won't affect con... Eric Faulhaber

11/21/2013

06:24 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Second regresion 20131121_123331 executed with 6 FAILED tests:
1. tc_job_002 FAILED failure in step 40: 'Unexpecte...
Vadim Nebogatov
05:59 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Code review 20131117*:
This is a good start, but it only handles the schema conversion, DMO creation, and ORM conf...
Eric Faulhaber

11/20/2013

06:29 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Regresion 20131119_150620 executed with 3 FAILED tests:
1. tc_job_002 FAILED failure in step 40: 'Unexpected EOF i...
Vadim Nebogatov
01:57 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
>Is there any significant technical debt you are adding by going with the simple map approach now, which will complic... Stanislav Lomany
01:32 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
Do what you need to do to get this issue finished for M7 (so...simple map for now). Please open a separate issue for ... Eric Faulhaber
01:27 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
Guys, in order to make Java compiler work for dynamic queries + dynamic tables, I've done the following:
1. @InMemor...
Stanislav Lomany
11:04 AM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Constantin Asofiei wrote:
> More, I think for temp-tables the primary (and other info like this) is emitted to the @...
Eric Faulhaber
10:50 AM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
I am OK with Constantin's approach, especially if we are going to get rid of the @@LegacyIndexes@ parent with Java 8. Eric Faulhaber
10:40 AM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Vadim Nebogatov wrote:
> ...in order to find primary index without search in array for example.
Yes, but you can al...
Constantin Asofiei
10:35 AM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
...in order to find primary index without search in array for example. Vadim Nebogatov
10:33 AM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Actually I also started with adding boolean @primary@ to LegacyIndex, but noticed that Eric suggested to add index na... Vadim Nebogatov
10:23 AM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Vadim/Eric: The @LegacyIndexes@ annotation is used only because Java 7 does not allow multiple annotations with the s... Constantin Asofiei
10:11 AM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
I am trying to add optional annotation “primary” and generate DMO impl annotation like ... Vadim Nebogatov
11:03 AM Feature #2203: replace or minimize use of dmo_index.xml file
The @dmo_index.xml@ file (and @DMOIndex@ class) originally was established as a list of DMOs needed to bootstrap Hibe... Eric Faulhaber
10:55 AM Feature #2203 (New): replace or minimize use of dmo_index.xml file
Eric Faulhaber

11/19/2013

07:38 AM Feature #2116: add runtime support for _user metadata table
The @_User@ table should only be involved in conversion and at runtime if it was configured to be a metadata table in... Eric Faulhaber
07:26 AM Feature #2116: add runtime support for _user metadata table
I have the following issue:
I have the @meta_user@ table created in the @schema_table_<dbname>_<dialect>.sql@ and th...
Ovidiu Maxiniuc

11/18/2013

01:20 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
Doesn't include features from the todo list above. Stanislav Lomany

11/17/2013

06:08 AM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Updated files attached Vadim Nebogatov

11/15/2013

05:47 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Issue is found and fixed concerning wrong conversion of fields with no extent in case if hint is assigned for whole t... Vadim Nebogatov
01:17 PM Bug #2199: ambiguity warnings too aggressively disabled
I believe the following test-case is related:
This is a P4GL valid code (temp-table @book@ 'hides' the @book@ tabl...
Ovidiu Maxiniuc
01:02 PM Feature #1654: add conversion and runtime support for dynamic buffer creation and cleanup
todo list for this task:
1. fix dynamic tables + dynamic queries (WIP)
2. fix scoping for dynamic buffers for stati...
Stanislav Lomany
12:19 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
Note that we will not need the @primary@ annotation element for temp-tables (at least not for bulk delete purposes), ... Eric Faulhaber
12:16 PM Feature #2126: add support for table-level locking (share and exclusive) for runtime internal use
We have decided not to move forward with the @MetaSchema@ interface, and instead to use Java annotations in the DMO i... Eric Faulhaber

11/14/2013

04:07 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Issue with
<property column="hours9" name="hours3" type="p2j_integer"/>
is resolved.
Vadim Nebogatov
10:20 AM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Attached
1) code update vmn_upd20131114a.zip merged with latest bzr revision 10411;
2) vmn_upd20131114b.zip con...
Vadim Nebogatov
01:06 PM Feature #2120: add runtime support for dynamically prepared queries
Variation of the bug above. Testcase:... Stanislav Lomany
12:41 PM Feature #2120: add runtime support for dynamically prepared queries
Yet another minor bug. Testcase:... Stanislav Lomany

11/13/2013

01:30 PM Feature #2024: implement runtime support for database triggers
Wouldn't it be easier/cleaner to invoke the trigger manager from the record buffer proxy? It's already an architected... Eric Faulhaber
01:19 PM Feature #2024: implement runtime support for database triggers
Here is a 100 points question.
What's the best solution for notifying ASSIGN triggers ?
In P4GL, the ASSIGN trigg...
Ovidiu Maxiniuc

11/12/2013

04:54 PM Feature #2116: add runtime support for _user metadata table
I saw that change, but it wasn't clear to me how this fixed the problem. I understand now: the problem was not that t... Eric Faulhaber
01:04 PM Feature #2116: add runtime support for _user metadata table
I already have talked to Contstantin and he helped me with this issue; the last update contains the fix for it. See t... Ovidiu Maxiniuc
12:58 PM Feature #2116: add runtime support for _user metadata table
Ovidiu Maxiniuc wrote:
> ...the big problem is registering dirty databases and doing the cleanup of @DatabaseManager...
Eric Faulhaber
12:38 PM Feature #2116: add runtime support for _user metadata table
Sorry for the delay in review, lost track of this one. Please merge up to latest code level, make my minor changes be... Eric Faulhaber
02:02 PM Feature #2024: implement runtime support for database triggers
Today I had some questions about the WRITE trigger and its implementation so I had the following summarized mail disc... Ovidiu Maxiniuc
 

Also available in: Atom