Activity

From 12/20/2013 to 01/18/2014

01/18/2014

05:16 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Ovidiu Maxiniuc wrote:
> // has TODO regarding generating a properly converted sort clause (currently null); otherwi... Eric Faulhaber
03:28 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Eric Faulhaber wrote:
> The VAL-EXP attribute actually is used in both read and write modes in the current project. ... Vadim Nebogatov

01/17/2014

06:13 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: The VAL-EXP attribute actually is used in both read and write modes in the current project. In the function where it ... Eric Faulhaber
05:49 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: LE: just took a look at the implementation and the attribute name is hard-coded, not determined from annotations - so... Constantin Asofiei
05:44 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Eric Faulhaber wrote:
> Vadim Nebogatov wrote:
> > Two cosmetics found in @HEIGHT-CHARS@ implementation: @HEIGHT-CH... Constantin Asofiei
05:42 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Vadim Nebogatov wrote:
> Schema conversion step starts from *.dict file received as result of parsing. Am I correct?... Constantin Asofiei
05:40 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Vadim Nebogatov wrote:
> Two cosmetics found in @HEIGHT-CHARS@ implementation: @HEIGHT-CHARS@ instead of @HEIGHT@ an... Eric Faulhaber
05:38 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Vadim Nebogatov wrote:
> @POSITION attribute@
> From tests, it is just field order (fieldId) plus 1. It is interest... Eric Faulhaber
05:24 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Constantin Asofiei wrote:
> Ah, I get it know, you want to get the legacy 4GL expression. The best way is to save it ... Vadim Nebogatov
05:17 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Ah, I get it know, you want to get the legacy 4GL expression. The best way is to save it in an annotation at the fiel... Constantin Asofiei
05:08 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: No special test is required: it is from p2j_test.dict for p2j_test.book.cost field. Vadim Nebogatov
05:04 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Can you post a small testcase showing how this behaves? If it works how I think it works (i.e. @VALIDATE-EXPRESSION@ ... Constantin Asofiei
04:44 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: @VALIDATE-EXPRESSION attribute@
I missed annotation of this attribute. In *.dict it looks like ... Vadim Nebogatov
03:06 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Two cosmetics found in @HEIGHT-CHARS@ implementation: @HEIGHT-CHARS@ instead of @HEIGHT@ and @setable@ with one @t@ ... Vadim Nebogatov
01:46 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: @POSITION attribute@... Vadim Nebogatov
01:23 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: I also added some more optional annotations like
/** Data member */
@LegacyField( name = "fc" , format = "... Vadim Nebogatov
11:27 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: I have attached the intermediary update that contains some my changes for this issue.
I am putting this update to c... Ovidiu Maxiniuc
10:46 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Agreed. Consider whether runtime regression testing is necessary for this update. If its impact is only on new runtim... Eric Faulhaber
10:39 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Ovidiu, please check if you can extract the code which adds the new annotations into a separate update; I think is wo... Constantin Asofiei
10:10 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Some more details on implementation of @bufferField(int)@:
I have done some researches that clarified me that the ... Ovidiu Maxiniuc
09:30 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Eric Faulhaber wrote:
> Sorry, this was my comment and I see how it is misleading. It was not based on testing, but ... Constantin Asofiei
09:23 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: *Ovidiu* working on @BufferImpl.java@
// has TODO regarding generating a properly converted sort clause (currently... Ovidiu Maxiniuc
08:15 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Eric Faulhaber wrote:
> Vadim, to me it doesn't look like @format@ and @changeFormat@ are actually in use. I don't s... Vadim Nebogatov
08:01 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: The same for the LITERAL-QUESTION attribute, I have implemented attribute support without proper analysys according n... Vadim Nebogatov
07:52 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Eric Faulhaber wrote:
> AFAIK, RowObjectValidate is just an ADM SmartObjects procedure that we convert. Does this ha... Vadim Nebogatov
07:39 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Constantin Asofiei wrote:
> Vadim Nebogatov wrote:
> > public void setDataType(String dataType) [LE: cannot se... Eric Faulhaber
07:35 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Constantin Asofiei wrote:
> > // not sure why this is implemented for FieldReference; DELETE cannot be called on a
... Eric Faulhaber
07:23 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Vadim Nebogatov wrote:
> public void setDataType(String dataType) [LE: cannot set data type for a buffer field]... Constantin Asofiei
07:19 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Vadim, to me it doesn't look like @format@ and @changeFormat@ are actually in use. I don't see any rules to generate ... Eric Faulhaber
07:09 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: h3. Vadim, current status (implemented methods are marked in bold)
h3. BufferImpl
*public handle bufferField(chara... Vadim Nebogatov
04:31 PM Feature #2117 (Closed): add runtime support for _lock metadata table: See #2115, note 18. Eric Faulhaber
04:31 PM Feature #2115 (Closed): add runtime support for _file and _field metadata tables: This update fixes metadata foreign key detection, completes basic lock metadata support (#2117), removes underscore f... Eric Faulhaber

01/16/2014

06:23 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: AFAIK, RowObjectValidate is just an ADM SmartObjects procedure that we convert. Does this have any bearing on the imp... Eric Faulhaber
04:59 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: @MANDATORY attribute@... Vadim Nebogatov
06:54 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: > Do P2J already has such option for different quoted character values processing and runtime options support?
No.
... Greg Shah
04:48 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: @LITERAL-QUESTION attribute@
Needed to support -literalquestion startup parameter and special processing for quot... Vadim Nebogatov
02:05 PM Feature #1652 (WIP): add conversion and runtime support for dynamically prepared temp-tables: I am temporarily re-opening this task to track the final implementations of TODOs in DynamicTablesHelper and TempTabl... Eric Faulhaber
07:21 AM Feature #2116: add runtime support for _user metadata table: Indeed, this is true (values are @?@) for the rest of fields of _User exports except for @_Userid@/@_Password@ and @_... Ovidiu Maxiniuc

01/15/2014

02:25 PM Feature #2116: add runtime support for _user metadata table: I also should note that the data export of the _User table has unknown value for the _User_number field in all record... Eric Faulhaber
02:22 PM Feature #2116: add runtime support for _user metadata table: Ovidiu, when you were working this task, did you create any test cases that explored the contents of the _User record... Eric Faulhaber

01/14/2014

07:53 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Status update (related to BufferImpl)
* @findFirst@, @findLast@, @findUnique@ - implemented, testing in progress, ... Ovidiu Maxiniuc

01/13/2014

06:27 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: I'm pretty sure the double quotes around the numeric value represent optional syntax. It is the value itself that is ... Eric Faulhaber
06:20 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Eric Faulhaber wrote:
> > But I did not find so far methods allowing creation BaseDataType instance from a pair of s... Vadim Nebogatov
05:45 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Eric Faulhaber wrote:
> Vadim, in the version of @BufferImpl@ you just checked in (rev 10433), you removed the origi... Vadim Nebogatov
05:42 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Vadim, in the version of @BufferImpl@ you just checked in (rev 10433), you removed the original copyright year of 201... Eric Faulhaber
05:38 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: > But I did not find so far methods allowing creation BaseDataType instance from a pair of strings initialValue and i... Eric Faulhaber
04:49 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: I think for INITIAL attribute we need two string annotations: initialValue and initialType, assigning them from text/... Vadim Nebogatov
01:05 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Yes, agreed. I made internal methods returning LegacyFieldInfo, bit public methods are the same. Vadim Nebogatov
10:13 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: While I do see some value in not repeating the pattern... Eric Faulhaber

01/12/2014

05:55 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: It seems TableMapper needs refactoring if we plan to add some new annotations to LegacyField like now I added format(... Vadim Nebogatov
04:42 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Vadim wrote (in email):
> The question: 'initial' was added in *.p2o as Ast node in contrast to other attributes adde... Eric Faulhaber

01/11/2014

05:53 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: The following also need implementation in BufferImpl:... Vadim Nebogatov
07:10 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Implemented bufferField(character) in BufferImpl. Attached update has not been regression tested, because it affects ... Vadim Nebogatov

01/10/2014

06:30 PM Bug #1914: database conversion requires Internet connectivity: Conversion on Windows virtual machine mode without networking causes the error:... Eugenie Lyzenko
01:05 PM Feature #2024 (Closed): implement runtime support for database triggers: Base trigger support is finished. Several bugs have been found and are being worked as separate tasks. Eric Faulhaber

01/09/2014

05:09 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Note 25 corrected, added one more error message after comparing with 4GL behavior. Vadim Nebogatov
03:03 PM Bug #2223: ASSIGN schema triggers without reference to database fields: There are two kinds of ASSIGN schema triggers:
* related to a well known database field (declared using @TRIGGER PRO... Ovidiu Maxiniuc
02:41 PM Bug #2223 (New): ASSIGN schema triggers without reference to database fields: Ovidiu Maxiniuc

01/08/2014

04:19 PM Bug #2221 (Closed): indexes not created or being dropped during data import: Eric Faulhaber
04:16 PM Bug #2221: indexes not created or being dropped during data import: Index creation after a table's data import (i.e., all non-unique indexes) was happening outside of a transaction, as ... Eric Faulhaber
03:23 PM Feature #1666 (Closed): add support for mixed-direction indexes: Eric Faulhaber
07:02 AM Feature #1666: add support for mixed-direction indexes: Constant CC_PREFIX - removed.
Also added the modifications into the P2JSQLServer2008Dialect.java, too, but this file... Ovidiu Maxiniuc
02:08 PM Bug #2222: WRITE event triggered too early: In some conditions, the WRITE event caused by the flush of the record to database occurs earlier than the correspondi... Ovidiu Maxiniuc
12:41 PM Bug #2222 (Hold): WRITE event triggered too early: Ovidiu Maxiniuc
01:46 PM Feature #1662: runtime support for table parameters: Code review 20140107a:
* I was a bit confused by the deferred copy error processing in @TemporaryBuffer@, with the... Eric Faulhaber
11:50 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Once you are sufficiently comfortable that your @bufferField(character)@ implementation works properly with your test... Eric Faulhaber
07:46 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Vadim: the @bufferField(character)@ implementation looks good to me.
You don't need to implement @bufferField(int)... Eric Faulhaber

01/07/2014

06:05 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Just noticed that I needed to start from bufferField(character fieldName). It will reuse bufferField(String fieldName... Vadim Nebogatov
05:59 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: The question about @BufferImpl.bufferField(int fieldNumber@) implementation.
I am going to reuse @bufferField(Str... Vadim Nebogatov
03:12 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Eric Faulhaber wrote:
> Constantin: you left TODOs in the @QueryWrapper@ methods listed above in note 20. Did you de... Constantin Asofiei
01:26 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: Implementation note: where new Java annotations are needed on DMOs to implement some of the above attributes, please ... Eric Faulhaber
01:14 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: I realize the previous 3 entries are not necessarily all about dynamic attributes and methods, but I needed to summar... Eric Faulhaber
01:05 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: The following need implementation in @QueryWrapper@:... Eric Faulhaber
01:03 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: The following need implementation in @FieldReference@:... Eric Faulhaber
01:01 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...: The following need implementation in @BufferImpl@:... Eric Faulhaber
02:51 PM Bug #2221: indexes not created or being dropped during data import: We seem to have introduced a regression to the data import process. Recent customer data imports are missing many of ... Eric Faulhaber
02:35 PM Bug #2221 (Closed): indexes not created or being dropped during data import: Eric Faulhaber
02:20 PM Feature #1669 (Closed): add support for additional database methods: Remaining methods are being coordinated from #1655. Eric Faulhaber
02:18 PM Feature #1661 (WIP): support case-sensitive fields in indexes: The remaining portion of this task is not needed for M7; moving to M11. Eric Faulhaber
02:15 PM Feature #2117 (Test): add runtime support for _lock metadata table: Eric Faulhaber
02:14 PM Feature #1666: add support for mixed-direction indexes: Code review 20131221a:
Looks good. Please remove the commented-out @P2JH2Dialect.CC_PREFIX@ class variable -- no n... Eric Faulhaber
01:04 PM Feature #2024: implement runtime support for database triggers: From Ovidiu's email response:
The @openReadOnlyScope()@ is not needed any more. The OLD buffer is built in Databas... Eric Faulhaber
01:19 AM Feature #2024: implement runtime support for database triggers: The following trigger-related methods are present but not implemented in @BufferImpl@:... Eric Faulhaber
01:01 PM Feature #1662 (Test): runtime support for table parameters: Eric Faulhaber
02:43 AM Feature #1662: runtime support for table parameters: Merged with the latest P2J. Stanislav Lomany
12:45 PM Feature #1588 (Closed): add conversion and runtime support for embedded SQL: Eric Faulhaber
12:43 PM Feature #2043 (Closed): add runtime support for some embedded SQL features: Eric Faulhaber
12:42 PM Feature #2126 (Closed): add support for table-level locking (share and exclusive) for runtime int...: Eric Faulhaber
12:39 PM Feature #1653 (Closed): add conversion and runtime support for dynamically prepared queries: Eric Faulhaber
12:35 PM Feature #2080 (Closed): add runtime support for database methods: All remaining, database-related methods and attributes are being managed through issue #1655. Eric Faulhaber
12:32 PM Feature #1654 (Closed): add conversion and runtime support for dynamic buffer creation and cleanup: Eric Faulhaber
12:31 PM Feature #2125 (Closed): add runtime support for dynamic buffer creation and cleanup: Eric Faulhaber
12:29 PM Feature #2120 (Closed): add runtime support for dynamically prepared queries: The problematic test cases above have been recorded in #2220, as they are not expected to be needed for M7. Eric Faulhaber
12:27 PM Feature #2220: dynamic query methods which require implementation: The following need implementation in @QueryWrapper@:... Eric Faulhaber
12:27 PM Feature #2220 (Closed): dynamic query methods which require implementation: Eric Faulhaber
12:25 PM Bug #2219: problematic dynamic query test cases: *Originally reported by Stanislav in #2120:*
Variation of the bug above. Testcase:... Eric Faulhaber
12:24 PM Bug #2219: problematic dynamic query test cases: *Originally reported by Stanislav in #2120:*
Yet another minor bug. Testcase:... Eric Faulhaber
12:22 PM Bug #2219 (Closed): problematic dynamic query test cases: Eric Faulhaber
12:12 PM Feature #1668 (Closed): add support for additional (non-dynamic) database attributes: See #1655. Eric Faulhaber
12:11 PM Feature #1975 (Closed): add runtime support for (non-dynamic) database attributes: I am closing this issue; the remaining methods and attributes are being managed through issue #1655. Eric Faulhaber

01/06/2014

02:37 PM Feature #1666: add support for mixed-direction indexes: Updated and cleaned-up version of the previous patch.
Some files were removed from the zip as their changes has alr... Ovidiu Maxiniuc
02:13 PM Feature #1662: runtime support for table parameters: TABLE/TABLE-HANDLE parameters work with the following exceptions:
1. extents copying doesn't work;
2. @thparm-inval... Stanislav Lomany

01/05/2014

01:48 PM Feature #1662: runtime support for table parameters: Stanislav Lomany wrote:
> [...]
> The ideas that I have:
> 1. Create prioritized finalizables.
> 2. Track all sta... Eric Faulhaber

01/04/2014

05:04 PM Feature #1662: runtime support for table parameters: Eric, please consider OUTPUT TABLE-HANDLE parameters, like this:... Stanislav Lomany

01/02/2014

11:33 PM Feature #1662: runtime support for table parameters: We already have an annotation like this for #2134, but currently it is only for extent fields which have been expande... Eric Faulhaber

12/30/2013

11:32 AM Feature #1662: runtime support for table parameters: Eric, @TemporaryBuffer.copyAlRows@ which is supposed to perform record copy upon calling a procedure which uses TABLE... Stanislav Lomany

12/26/2013

06:21 AM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...: Metadata problem is found for denormalized fields with extent:
Caused by: org.h2.jdbc.JdbcSQLException: Unique in... Vadim Nebogatov

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » Database

Activity

Activity

01/18/2014

01/17/2014

01/16/2014

01/15/2014

01/14/2014

01/13/2014

01/12/2014

01/11/2014

01/10/2014

01/09/2014

01/08/2014

01/07/2014

01/06/2014

01/05/2014

01/04/2014

01/02/2014

12/30/2013

12/26/2013