Project

General

Profile

Activity

From 01/23/2014 to 02/21/2014

02/21/2014

03:46 PM Feature #2143: prototype IKVM solution for Java UDFs compiled to CIL assemblies and loaded in SQL...
The SQL Server can execute 'external' code in two ways:
1. *as 'Extended Stored Procedures'*. This is the deprecated...
Ovidiu Maxiniuc

02/20/2014

01:50 PM Feature #2143: prototype IKVM solution for Java UDFs compiled to CIL assemblies and loaded in SQL...
Eric Faulhaber wrote:
> Sounds like you're making good headway, Ovidiu.
This was the easy part.. the time-consuming...
Ovidiu Maxiniuc
12:59 PM Feature #2024 (Closed): implement runtime support for database triggers
Eric Faulhaber

02/19/2014

04:00 PM Feature #2143 (WIP): prototype IKVM solution for Java UDFs compiled to CIL assemblies and loaded ...
Sounds like you're making good headway, Ovidiu.
> I attempted to convert the whole p2jpl.jar. Operation finished and...
Eric Faulhaber
02:54 PM Feature #2143: prototype IKVM solution for Java UDFs compiled to CIL assemblies and loaded in SQL...
Progress so far:
* created a small test java class with 2 operators
* compiled the java source code and built the j...
Ovidiu Maxiniuc
02:35 PM Feature #2024: implement runtime support for database triggers
Committed to bzr as revision 10472 and distributed by mail. Ovidiu Maxiniuc

02/17/2014

10:05 AM Feature #2024: implement runtime support for database triggers
I have merged the update with latest bzr version. The conversion testing passed (as expected, no changes in generated... Ovidiu Maxiniuc

02/14/2014

02:53 PM Bug #2237: wrong historical annotations in dynamic temp-tables
Replaced the update with the new one with the small change.
It was committed to bzr in rev 10465 and distributed by ...
Ovidiu Maxiniuc
02:14 PM Bug #2237: wrong historical annotations in dynamic temp-tables
Ovidiu, you modified @p2o.xml@ and conversion testing has passed. The only other files that changed are new runtime c... Eric Faulhaber
01:58 PM Bug #2237: wrong historical annotations in dynamic temp-tables
This is the latest update that is not under testing.
It passed the conversion (I had to manually run the diff - there...
Ovidiu Maxiniuc
01:51 PM Bug #2237: wrong historical annotations in dynamic temp-tables
Ovidiu, please post the final update you used for testing and check it in and distribute once it has passed. Eric Faulhaber

02/13/2014

04:20 PM Bug #2222: WRITE event triggered too early
As Eric affirmed in a mail I am _modifying some very sensitive code_.
The flush procedure (WRITE triggers and effect...
Ovidiu Maxiniuc
11:29 AM Feature #2140 (Review): use positional query substitution parameters in HQLPreprocessor and relat...
Committed to bzr revision 10462. Stanislav Lomany

02/12/2014

02:22 PM Feature #2140: use positional query substitution parameters in HQLPreprocessor and related classes
This is something Greg or Ovidiu added specifically for composite data type support (specifically, datetime-tz), but ... Eric Faulhaber
02:02 PM Feature #2140: use positional query substitution parameters in HQLPreprocessor and related classes
I saw this code which is currently not active... Stanislav Lomany
01:45 PM Feature #2140: use positional query substitution parameters in HQLPreprocessor and related classes
Code review 20140212a:
Looks good, nice work. Once it passes the rest of regression testing, please check it in an...
Eric Faulhaber
09:44 AM Feature #2140 (WIP): use positional query substitution parameters in HQLPreprocessor and related ...
Minor update for MAJIC (fixed query in TmpSumCleanupContextHook). Stanislav Lomany
09:04 AM Feature #2140: use positional query substitution parameters in HQLPreprocessor and related classes
> How does this update take into account the parameter indices we are managing within the @HQLPreprocessor@ (see @par... Stanislav Lomany

02/11/2014

05:35 PM Feature #2140: use positional query substitution parameters in HQLPreprocessor and related classes
How does this update take into account the parameter indices we are managing within the @HQLPreprocessor@ (see @param... Eric Faulhaber
04:54 PM Feature #2140: use positional query substitution parameters in HQLPreprocessor and related classes
Update for review. Passed main part of regression testing. The main idea is to:
1. exclude explicit placeholders ("?...
Stanislav Lomany

02/09/2014

06:56 AM Bug #2236 (Review): HQL error generated from dynamically converted query with extent field refere...
Stanislav Lomany
06:26 AM Bug #2236: HQL error generated from dynamically converted query with extent field reference in wh...
Committed to bzr revision 10460. Stanislav Lomany

02/07/2014

05:31 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
From other side, it is even not needed: such properties already exists in LegacyField annotation:... Vadim Nebogatov
05:20 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
I added CustomExtentProperty as indicator that property was denormalized. I thought it was simpler. In principle, I a... Vadim Nebogatov
11:52 AM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Vadim Nebogatov wrote:
> CustomExtentProperty annotation needed for remember denormalized property name, this “pseud...
Eric Faulhaber
08:22 AM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Eric Faulhaber wrote:
> Why is the @@CustomExtentMethod@ annotation needed? Don't all the getter and setter methods ...
Vadim Nebogatov
03:38 PM Bug #2222: WRITE event triggered too early
OK, good work. Please go ahead and implement these changes and document the names of the test cases which you created... Eric Faulhaber
03:04 PM Bug #2222: WRITE event triggered too early
Write-to-db is NOT expected at the end of a block including:
- transactions,
- internal procedures
- fun...
Ovidiu Maxiniuc
02:42 PM Bug #2236: HQL error generated from dynamically converted query with extent field reference in wh...
> There are some new TODOs added to @TemporaryBuffer.copyAllRows@. What is the plan for those?
1. ...
Stanislav Lomany
09:55 AM Bug #2236: HQL error generated from dynamically converted query with extent field reference in wh...
Code review 20140205a:
In general, looks good. Please regression test.
There are some new TODOs added to @Tempo...
Eric Faulhaber
01:01 PM Bug #2237: wrong historical annotations in dynamic temp-tables
No 'strong' reason. Looking into @AbstractCollection@'s source code, both methods share the same implementation excep... Ovidiu Maxiniuc
12:08 PM Bug #2237: wrong historical annotations in dynamic temp-tables
> I have fixed that (see DynamicTablesHelper.java:858) before uploading the update.
Why not use @java.util.Set@'s @<...
Eric Faulhaber

02/06/2014

05:29 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Eric Faulhaber wrote:
> This will require that you become familiar with the @HQLPreprocessor@ class, since it is her...
Eric Faulhaber
05:24 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Thank you for providing the tests and especially the hints and conversion output; it is very helpful for doing the re... Eric Faulhaber

02/05/2014

04:53 AM Bug #2236 (WIP): HQL error generated from dynamically converted query with extent field reference...
Update for review. Contains:
1. fix for this issue
2. part of COPY-TEMP-TABLE functionality
3. fix for BUFFER-VALU...
Stanislav Lomany

02/04/2014

05:48 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
I have attached vmn_upd20140204a.zip for your review.
Updated with latest bzr revision 10458.
Test cases were ...
Vadim Nebogatov
01:17 PM Bug #2236: HQL error generated from dynamically converted query with extent field reference in wh...
I'll post the testcase here.... Stanislav Lomany
10:09 AM Bug #2222: WRITE event triggered too early
Please see the last notes of VALIDATE statement, in ABL Reference rev 10.2B, page 1115. Ovidiu Maxiniuc

02/03/2014

04:03 PM Feature #2207: Remaining issues for dynamic buffers and dynamic tables
About the issue in note 3. What P2J does in this case:... Stanislav Lomany
02:27 PM Bug #2222: WRITE event triggered too early
Ovidiu Maxiniuc wrote:
> * The AVM performs validation when it leaves a field.
> What does "leaves" means ?
Thi...
Eric Faulhaber
02:11 PM Bug #2222: WRITE event triggered too early
I encountered two sentences that look interesting from the WRITE-trigger pov:
* The AVM performs validation when i...
Ovidiu Maxiniuc
10:12 AM Feature #2024: implement runtime support for database triggers
The @om_upd20140130b.zip@ update fixes a schema-trigger conversion bug when the project contains access to temp-table... Ovidiu Maxiniuc
08:13 AM Feature #2024: implement runtime support for database triggers
I wasn't expecting special issues as the update only affects schema triggers and majic does not use them.
Surprising...
Ovidiu Maxiniuc
09:51 AM Feature #1662: runtime support for table parameters
Also, NO-ERROR option is not properly handled. Stanislav Lomany
09:49 AM Feature #1662: runtime support for table parameters
Issue noted in note 4 in #2207 also affects table parameters. The only difference is that the records can't be partia... Stanislav Lomany

01/31/2014

09:24 AM Feature #2207: Remaining issues for dynamic buffers and dynamic tables
Stas, please put your work on the COPY-TEMP-TABLE handle method on hold. As we discussed previously, this method is n... Eric Faulhaber
07:47 AM Feature #2207: Remaining issues for dynamic buffers and dynamic tables
FYI, there is the problem with @COPY-TEMP-TABLE@. Consider the tables... Stanislav Lomany

01/30/2014

04:09 PM Feature #2024 (WIP): implement runtime support for database triggers
Temporarily re-opening this issue to post Ovidiu's update to fix some problems with trigger conversion. Ovidiu, pleas... Eric Faulhaber
03:52 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
I have attached vmn_upd20140130a.zip with first tests results containing examples of generated DMOs, table hints and ... Vadim Nebogatov

01/29/2014

12:28 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Technically note is correct. I can write "initialize sizer for extent fields and do not initialize for non-extent fie... Stanislav Lomany
11:35 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Stanislav Lomany wrote:
> ...
Eric Faulhaber
07:08 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
@FieldReference.value(int)@ was broken. I'll include this fix in my next update.... Stanislav Lomany

01/28/2014

01:42 PM Bug #2237: wrong historical annotations in dynamic temp-tables
Looks like this update fixes the issue.
The table legacy name is also added to in-memory AST. When TRPL (p2o.xml) is...
Ovidiu Maxiniuc
09:49 AM Bug #2237: wrong historical annotations in dynamic temp-tables
Here is a more complex sample case:... Ovidiu Maxiniuc
09:43 AM Bug #2237 (WIP): wrong historical annotations in dynamic temp-tables
When creating dynamic temp-tables the field and table annotations are wrong. I could reproduce this in dynamic querie... Ovidiu Maxiniuc
09:38 AM Bug #2237 (Closed): wrong historical annotations in dynamic temp-tables
Ovidiu Maxiniuc
01:38 PM Feature #1662: runtime support for table parameters
> * I was a bit confused by the deferred copy error processing in @TemporaryBuffer@, with the corresponding change in... Stanislav Lomany
10:59 AM Feature #2207: Remaining issues for dynamic buffers and dynamic tables
The first issue is not a dynamic tables issue, it is about undo processing for NO-UNDO temp tables. The same result c... Stanislav Lomany

01/27/2014

01:29 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Update to Hibernate sources. Committed to bzr revision 10454. Stanislav Lomany
11:23 AM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
The unique index is needed; it is part of the legacy metadata schema and an application may include code which relies... Eric Faulhaber
10:23 AM Feature #1651 (Closed): add support for dynamic database features
Eric Faulhaber
10:22 AM Feature #1655 (Closed): add conversion and runtime support for certain dynamic database attribute...
This update fixes problems with the columnLabel and validateExpression annotations (refs #1655), encountered while co... Eric Faulhaber

01/26/2014

06:26 PM Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Could you check my last question (note 45) about order? Similar question should be addressed with newly added @fieldI... Vadim Nebogatov
09:25 PM Feature #1655 (Test): add conversion and runtime support for certain dynamic database attributes ...
The attached, merged update passed regression testing and was committed by Ovidiu to bzr rev. 10452.
I encountered...
Eric Faulhaber
08:30 PM Feature #1652 (Closed): add conversion and runtime support for dynamically prepared temp-tables
Eric Faulhaber
08:29 PM Bug #2236: HQL error generated from dynamically converted query with extent field reference in wh...
Failing test case is dbuf-query-extent1-dt.p (Stanislav: please provide test case; it is not currently in the testcas... Eric Faulhaber
08:19 PM Bug #2236 (Closed): HQL error generated from dynamically converted query with extent field refere...
Eric Faulhaber
08:15 PM Feature #2235: fix deployment issues related to dynamic database conversion resources
In #1652, note 135, Stanislav wrote:
> The following files and directories have to be accessed from the server class...
Eric Faulhaber
08:09 PM Feature #2235 (Closed): fix deployment issues related to dynamic database conversion resources
Eric Faulhaber
08:06 PM Feature #1662 (Closed): runtime support for table parameters
Eric Faulhaber

01/25/2014

09:35 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
As mentioned in #1651 note 5:
> 7. Long term, we want the standard rules to be loaded from the p2j.jar instead of ...
Greg Shah
02:54 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
The following files and directories have to be accessed from the server classpath:... Stanislav Lomany

01/24/2014

03:29 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Stas, I looked around this task history and that of related tasks, but I can't seem to find a summary of the configur... Eric Faulhaber
01:21 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Committed to bzr revision 10448. Stanislav Lomany
01:19 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Update for remaining issues. Presumably does not need regression testing. Stanislav Lomany
01:23 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
I am running now the full regression on this update. It is based on bzr rev 10450.
It contains the
* om_upd2014012...
Ovidiu Maxiniuc
09:59 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Tested, results are the same:... Vadim Nebogatov
02:28 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Vadim: this seems like the BUFFER-FIELD can never be deleted explicitly. I forgot about dynamic buffers - please test... Constantin Asofiei
12:33 PM Feature #1658 (Closed): improve database trigger support
Eric Faulhaber
12:33 PM Feature #1581 (Closed): add conversion and runtime support for certain metadata constructs
Eric Faulhaber

01/23/2014

06:54 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
I tested the following test case based on note 98... Vadim Nebogatov
06:26 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Notes about @DynamicQueryHelper@ from om_upd20140123a:
* I'm OK with using the @QueryProcessor@ interface instead of...
Constantin Asofiei
06:05 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Code review om_upd20140123a:
I'm good with the changes, assuming you will come back around after M7 and finish up ...
Eric Faulhaber
05:09 PM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Changes in this update (beside the things from notes 89, 90 & 97):
* Added support for dereference as left-side of a...
Ovidiu Maxiniuc
10:28 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Update @vmn_upd20140123a.zip@ contains all implemented methods from note 47 excepting @FieldReference.resourceDelete(... Vadim Nebogatov
03:09 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Vadim Nebogatov wrote:
> Is current implementation of FieldReference.resourceDelete() correct? What should be tested ...
Constantin Asofiei
02:56 AM Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
About the dynamic query code in om_upd20140122a.zip:
* what I don't like is that we are duplicating code in @parseQu...
Constantin Asofiei
02:54 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
OK, that's a bit confusing, but got it. Still, please open a separate task to track the features needed for full comp... Eric Faulhaber
02:49 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
> I think append- is the only option in scope here, since it can be used in internal code paths. The replace- and loo... Stanislav Lomany
02:38 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Stanislav Lomany wrote:
> 3. COPY-TEMP-TABLE: copy modes: append-, replace- and loose-copy-
I think append- is the ...
Eric Faulhaber
02:29 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
> * Is the @import com.goldencode.p2j.convert.*;@ statement needed in @TemporaryBuffer@?
That is required for @ParmT...
Stanislav Lomany
02:27 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
OK, makes sense. I was understanding this to be a different problem. Eric Faulhaber
02:11 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
> Regarding the first error, is it actually necessary to modify Hibernate? I don't know where the code you modified a... Stanislav Lomany
01:36 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Code review 20140123a:
* Is the @import com.goldencode.p2j.convert.*;@ statement needed in @TemporaryBuffer@?
* The...
Eric Faulhaber
01:04 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Regarding the first error, is it actually necessary to modify Hibernate? I don't know where the code you modified abo... Eric Faulhaber
12:24 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Regarding the second error, this query is generated by the conversion rules for historical reasons, when we handled s... Eric Faulhaber
12:21 PM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Current state of work. Needs regression testing. Stanislav Lomany
10:50 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
> Is there a stack trace that goes with this error that shows the problem at the Hibernate level?... Stanislav Lomany
10:18 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Is there a stack trace that goes with this error that shows the problem at the Hibernate level?
Hibernate cannot d...
Eric Faulhaber
09:59 AM Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
I was pretty sure that extents work normally for dynamic tables, there are several checked in testcases for them. How... Stanislav Lomany
 

Also available in: Atom