Project

General

Profile

Activity

From 04/05/2014 to 05/04/2014

05/04/2014

10:49 AM Feature #2281: enhance schema name conversion to support literal replacements
Actually I thought that properties and class names should meet java naming conventions.
I have attached vmn_upd20...
Vadim Nebogatov
05:47 AM Bug #2219: problematic dynamic query test cases
Constantin, thank you for the idea! Stanislav Lomany

05/02/2014

04:39 PM Feature #2296: update record buffer validation to prevent database index overflow
Since the validation algorithm will be hit quite frequently, it must be as efficient as possible:
* We should figure...
Eric Faulhaber
04:28 PM Feature #2296: update record buffer validation to prevent database index overflow
Some notes on determining the maximum index limit to apply and whether or not to perform the validation at all:
* We...
Eric Faulhaber
04:05 PM Feature #2296: update record buffer validation to prevent database index overflow
This task is sort of a follow-on to #2273, but is scoped slightly differently. It is meant to add some generic Progre... Eric Faulhaber
02:56 PM Feature #2296 (Closed): update record buffer validation to prevent database index overflow
Eric Faulhaber
03:48 PM Bug #2222: WRITE event triggered too early
I attached the last version of implementation. The files contain extra logging code.
Also the current set of testcas...
Ovidiu Maxiniuc
02:54 PM Feature #1661 (Closed): support case-sensitive fields in indexes
Eric Faulhaber
10:07 AM Feature #2281: enhance schema name conversion to support literal replacements
I haven't had time to look at the code yet, but there seems to be something wrong with the result. The hints file has... Eric Faulhaber
08:00 AM Feature #2281: enhance schema name conversion to support literal replacements
Sorry, it is my fault. I worked last time with backticks, switched off to another bug fix, and did not include my pre... Vadim Nebogatov
09:52 AM Bug #2219: problematic dynamic query test cases
OK, please make the change. Eric Faulhaber
02:38 AM Bug #2219: problematic dynamic query test cases
Stanislav Lomany wrote:
> The difference between a pure @AdaptiveQuery@ and an @AdaptiveQuery@ assigned to a @QueryW...
Constantin Asofiei
12:28 AM Bug #2219: problematic dynamic query test cases
Stanislav Lomany wrote:
> Do you think that we should convert a dynamic query using @QueryWrapper@?
Yes, assuming C...
Eric Faulhaber
12:14 AM Bug #2219: problematic dynamic query test cases
Update for review for the original issues (except the one noted in the previous note). Stanislav Lomany
11:04 PM Bug #2219: problematic dynamic query test cases
Guys, we have a problem with dynamic queries which are converted to @AdaptiveQueries@. Consider testcase:... Stanislav Lomany

05/01/2014

02:39 AM Feature #2281: enhance schema name conversion to support literal replacements
Code review 20140429a:
Unfortunately, there are some major problems with this update. Except for the escaping with...
Eric Faulhaber

04/29/2014

04:33 PM Bug #2222: WRITE event triggered too early
Attached the update form this morning that generated the also attached server log.
The sessions are still 'synchro...
Ovidiu Maxiniuc
04:13 PM Feature #2281: enhance schema name conversion to support literal replacements
In regard to the regression test failures, please make sure you have read the new timco.html document. It describes ... Greg Shah
03:56 PM Feature #2281: enhance schema name conversion to support literal replacements
Vadim Nebogatov wrote:
> I started regression before your code review only in order to find/fix some bugs. Should I ...
Eric Faulhaber
03:54 PM Feature #2281: enhance schema name conversion to support literal replacements
Regression 20140429_114111 completed. 3 FAILED tests:
1. tc_job_002 FAILED failure in step 40: 'Unexpected EOF in ...
Vadim Nebogatov
12:23 PM Feature #2281: enhance schema name conversion to support literal replacements
I have attached update vmn_upd20140429a.zip after some fixes during testing regression and merge with latest bzr chan... Vadim Nebogatov
11:11 AM Bug #2295: In Progress output parameters ignore decimal precision
The following code:... Hynek Cihlar
11:06 AM Bug #2295 (WIP): In Progress output parameters ignore decimal precision
Hynek Cihlar

04/25/2014

12:44 PM Feature #1661: support case-sensitive fields in indexes
Update committed revision 10515 and distributed by mail. Ovidiu Maxiniuc
12:10 PM Feature #1661: support case-sensitive fields in indexes
There is nothing in your update that affects network/session/context processing, so I would not worry about the Ctrl+... Eric Faulhaber
11:20 AM Feature #1661: support case-sensitive fields in indexes
In the second run of the ctrl+c the number of failed test went down by 10. It was not enough so I tested a 3rd time. ... Ovidiu Maxiniuc
05:52 AM Feature #1661: support case-sensitive fields in indexes
Testing this update based on bzr revision 10512.
The main passed flawlessly (except for the expected "Unexpected EOF...
Ovidiu Maxiniuc

04/24/2014

02:35 PM Feature #2220: dynamic query methods which require implementation
>I guess you are referring to OPEN QUERY FOR ... cases (as opposed to OPEN QUERY PRESELECT ...),
By preselect queri...
Stanislav Lomany
08:25 AM Feature #2220: dynamic query methods which require implementation
Right. I thought we are talking about only about queries which can be used in OPEN QUERY and forgot that P2JQuery has... Stanislav Lomany
08:22 AM Feature #2220: dynamic query methods which require implementation
Stanislav Lomany wrote:
> >Are there any concrete implementations of P2JQuery for which this parameter will not appl...
Constantin Asofiei
06:53 AM Feature #2220: dynamic query methods which require implementation
>Are there any concrete implementations of P2JQuery for which this parameter will not apply (i.e., with which indexIn... Stanislav Lomany

04/23/2014

06:56 PM Feature #2220: dynamic query methods which require implementation
Yes, I see. The conversion seems correct, but the sort clause is lossy in this case, with respect to the selected ind... Eric Faulhaber
06:28 PM Feature #2220: dynamic query methods which require implementation
> I would like to avoid passing additional information into the constructor for the index in use, because we essentia... Stanislav Lomany
03:59 PM Feature #2220: dynamic query methods which require implementation
Stanislav Lomany wrote:
> About @deleteResultListEntry@ - it can be applied to
> 1. queries with preselected resul...
Eric Faulhaber
03:32 PM Feature #2220: dynamic query methods which require implementation
Stanislav Lomany wrote:
> @createResultListEntry@ doesn't present in the customer project. Should I implement it?
N...
Eric Faulhaber
03:09 PM Feature #2220: dynamic query methods which require implementation
Stanislav Lomany wrote:
> Eric, some issues about @indexInformation@:
> 3. For static queries I see three ways of s...
Eric Faulhaber
02:48 PM Feature #2220: dynamic query methods which require implementation
About @deleteResultListEntry@ - it can be applied to
1. queries with preselected result set
2. scrolling queries o...
Stanislav Lomany
02:50 PM Feature #2281: enhance schema name conversion to support literal replacements
I have attached update vmn_upd20140423a.zip and examples of hints and conversion results vmn_upd20140423b.zip. The co... Vadim Nebogatov
01:21 PM Feature #1661: support case-sensitive fields in indexes
Ovidiu Maxiniuc wrote:
> I observed that some code is duplicated (TempTableHelper:516-527 and P2JH2Dialect:795-805)....
Eric Faulhaber
01:00 PM Feature #1661: support case-sensitive fields in indexes
Eric Faulhaber wrote:
> * Why was the change to schema/fixups.xml needed? Does the @kw_case_sen@ token appear anywhe...
Ovidiu Maxiniuc

04/22/2014

03:58 PM Feature #2281: enhance schema name conversion to support literal replacements
Vadim Nebogatov wrote:
> Remaining issue is escaping schema name. It is not used in DDL, so I try to understand now ...
Eric Faulhaber
03:49 PM Feature #2281: enhance schema name conversion to support literal replacements
I have attached first results: update vmn_upd20140422a.zip contains example of new hints and corresponding DDL files.... Vadim Nebogatov
11:05 AM Feature #2290: enhance SchemaDictionary to store context-local information for dynamic queries
Currently, a new @SchemaDictionary@ instance is created for each context (see @SchemaDicitonary.localInstance@, which... Eric Faulhaber
10:53 AM Feature #2290 (New): enhance SchemaDictionary to store context-local information for dynamic queries
Eric Faulhaber
07:57 AM Bug #2219: problematic dynamic query test cases
Stanislav Lomany wrote:
> > The problem here is that a dynamic resource can survive a procedure ran persistent - ple...
Constantin Asofiei
07:20 AM Bug #2219: problematic dynamic query test cases
> The problem here is that a dynamic resource can survive a procedure ran persistent - please test what happens if yo... Stanislav Lomany
02:50 AM Bug #2219: problematic dynamic query test cases
Stanislav Lomany wrote:
> The issue is caused by an unclosed implicit transaction opened by a query. It doesn't caus...
Constantin Asofiei

04/21/2014

04:06 PM Feature #2281: enhance schema name conversion to support literal replacements
Processed formats: @"%s_timestamp"@, @"%s_offset"@, @"alter table %s alter column %s %s as %s;"@
Actually only tw...
Vadim Nebogatov
03:35 AM Feature #2281: enhance schema name conversion to support literal replacements
Some more changes implemented: ... Vadim Nebogatov
01:37 PM Bug #18: issues with ne/equal and true/false conversion in WHERE clauses
The non-WHERE clause related conversion errors are being managed in #2288. The scope of this task is now just the WHE... Eric Faulhaber
12:07 PM Bug #2219: problematic dynamic query test cases
The issue is caused by an unclosed implicit transaction opened by a query. It doesn't cause an error for static queri... Stanislav Lomany

04/20/2014

12:21 PM Feature #1661: support case-sensitive fields in indexes
Eric Faulhaber wrote:
> * DynamicQueryHelper: why have you added back the @WorkArea.permSchemasLoaded@ flag? Perhaps...
Eric Faulhaber
10:17 AM Feature #2281: enhance schema name conversion to support literal replacements
Eric, no problems, it is not an issue already.
It seems approach with using Hybernate's backticks is good and I a...
Vadim Nebogatov

04/19/2014

02:46 PM Feature #2281: enhance schema name conversion to support literal replacements
Vadim Nebogatov wrote:
> The question concerning using @escape@ attribute.
>
> Should it be done on the level of...
Eric Faulhaber
09:24 PM Feature #2281: enhance schema name conversion to support literal replacements
The reason for this feature is that some customers (as for the current project) want to use names where case is relev... Eric Faulhaber
02:43 PM Bug #2285 (Closed): Regression when converting the server sources: null annotation
Eric Faulhaber
09:51 AM Bug #2285: Regression when converting the server sources: null annotation
Update vmn_upd20140416a.zip committed to bzr rev.10512 and distributed. Vadim Nebogatov
10:19 PM Bug #2285: Regression when converting the server sources: null annotation
With this fix, the NullPointerException (the 1st problem in note 1 above) no longer occurs. I don't see the other pro... Eric Faulhaber
02:32 PM Feature #2258 (Closed): retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime suppor...
Eric Faulhaber
01:38 PM Feature #2220: dynamic query methods which require implementation
Guys, about @deleteResultListEntry@ - how it should be implemented? My idea is to make query-specific list of recids ... Stanislav Lomany

04/18/2014

07:21 PM Feature #2281: enhance schema name conversion to support literal replacements
I am trying to implement @escape@ support using Hybernate's backticks @`@ for columns with escape hint. In this case ... Vadim Nebogatov
06:15 PM Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
Update vmn_upd20140409a.zip passed regression and distributed. Bzr revision is 10511. Vadim Nebogatov
05:52 PM Feature #1661: support case-sensitive fields in indexes
Code review 20140416b:
Nice functional update (and a lot of code cleanup as well). Some issues/questions:
* Why...
Eric Faulhaber
01:26 PM Feature #1661: support case-sensitive fields in indexes
I believe the current update passed the test. The only issues were:
* ctrlc_01_session5: Expected '' (0x0000 at rela...
Ovidiu Maxiniuc
04:23 PM Bug #2285: Regression when converting the server sources: null annotation
Code review 20140416a:
The changes look OK to me. Please do a regular conversion regression test.
I will run a ...
Eric Faulhaber
11:48 AM Feature #2220: dynamic query methods which require implementation
Constantin, yes, for static query it for some reason requires explicit fields specifications while works fine for dyn... Stanislav Lomany
11:21 AM Feature #2220: dynamic query methods which require implementation
Stanislav, if I'm putting your example into a @OPEN QUERY@ case, the code can not compile in 4GL - it says that @f2@ ... Constantin Asofiei
09:15 AM Feature #2220 (WIP): dynamic query methods which require implementation
Eric, some issues about @indexInformation@:
1. There may be some differences in index selection rules with 4GL, e.g....
Stanislav Lomany

04/17/2014

05:22 PM Feature #1661: support case-sensitive fields in indexes
The update almost passed the full-regression testing, 3 tests failed:
* ctrlc_11_session1/3/4: because some semaphor...
Ovidiu Maxiniuc

04/16/2014

02:35 PM Bug #2285: Regression when converting the server sources: null annotation
Attached @vmn_upd20140416a.zip@ fixes first exception. It is possible some more errors also will be fixed. Attached @... Vadim Nebogatov
03:26 AM Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
Regression 20140415_154604 completed. 3 tests failed:
1. tc_job_002 FAILED failure in step 40: 'Unexpected EOF in ...
Vadim Nebogatov

04/14/2014

03:18 PM Bug #2285 (WIP): Regression when converting the server sources: null annotation
-------- Original Message --------
Subject: regression when converting the server sources
Date: Mon, 14 Apr 2014 ...
Vadim Nebogatov
03:17 PM Bug #2285 (Closed): Regression when converting the server sources: null annotation
Vadim Nebogatov

04/13/2014

05:22 PM Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
tc_job_clock_002 test fails each time because of timeout error:
failure in step 20: 'timeout before the specific s...
Vadim Nebogatov
02:49 PM Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
Since tc_job_clock_002 has failed each time, have you checked the server.log to see if there is a real regression? Ha... Eric Faulhaber
01:47 PM Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
Regression 20140413_095429 completed. 6 tests failed, including
tc_job_002
tc_job_clock_002
Will start regre...
Vadim Nebogatov
02:40 PM Feature #2281: enhance schema name conversion to support literal replacements
The question concerning using @escape@ attribute.
Should it be done on the level of overriding normalizer.normalize...
Vadim Nebogatov

04/12/2014

08:47 PM Feature #2282 (Hold): make number of pattern engine instances per conversion profile configurable
Currently, we create one pattern engine instance per conversion profile (e.g., schema/p2o, annotations/annotations, e... Eric Faulhaber
08:25 PM Feature #2282 (Hold): make number of pattern engine instances per conversion profile configurable
Eric Faulhaber
08:23 PM Feature #2276 (Closed): create a work queue of PatternEngine instances for runtime conversion tasks
The attached update has passed regression testing and is committed to bzr rev. 10510. Eric Faulhaber

04/11/2014

05:09 PM Feature #1661: support case-sensitive fields in indexes
Intermediary update, not fully tested.
Changes:
Added case-sensitive attribute in @P2JField@.
Added @caseSensitive...
Ovidiu Maxiniuc
02:43 PM Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
Regression 20140411_102011 completed. 3 tests failed:
1. tc_job_002 FAILED failure in step 40: 'Unexpected EOF in ...
Vadim Nebogatov
02:25 PM Feature #2148: enhance prototype to compile p2jpl.jar file with IKVMC into .NET assembly and load...
Using the attached om_upd20140314a.zip, almost all methods and functions have full support for MSSQL (the fully imple... Ovidiu Maxiniuc

04/10/2014

03:26 PM Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
Regression 20140410_105536 completed. 3 tests failed:
1. tc_job_002 FAILED failure in step 40: 'Unexpected EOF in ...
Vadim Nebogatov
12:50 AM Feature #2258 (Test): retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support ...
Eric Faulhaber
12:46 AM Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
Code review 20140409a:
The update looks good. Please regression test.
Eric Faulhaber
02:51 PM Feature #2281: enhance schema name conversion to support literal replacements
Yes and yes. Eric Faulhaber
01:41 PM Feature #2281: enhance schema name conversion to support literal replacements
The question concerning fields with extent.
Would be possible using denormalization hints along with literal replac...
Vadim Nebogatov
10:55 AM Feature #2281 (WIP): enhance schema name conversion to support literal replacements
Vadim Nebogatov
12:39 AM Feature #2281: enhance schema name conversion to support literal replacements
We need to enhance the schema hint syntax to allow the name conversion algorithms to be bypassed entirely, such that ... Eric Faulhaber
12:14 AM Feature #2281 (Closed): enhance schema name conversion to support literal replacements
Eric Faulhaber

04/09/2014

05:48 PM Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
I have attached update vmn_upd20140409a.zip and tests used vmn_upd20140409b.zip for review.
Vadim Nebogatov
05:23 PM Bug #2280: Error with FIND-FIRST() method
Test case:... Vadim Nebogatov
05:02 PM Bug #2280 (Closed): Error with FIND-FIRST() method
Vadim Nebogatov
04:42 PM Feature #1661: support case-sensitive fields in indexes
There is as chance that the proposed solution might not be implemented because at some points the indexes are dropped... Ovidiu Maxiniuc

04/08/2014

03:58 PM Feature #1661: support case-sensitive fields in indexes
Eric Faulhaber wrote:
> What do you propose to correct this? You can modify the dialect API as needed.
To fix this is...
Ovidiu Maxiniuc
02:18 PM Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Reuploaded the update after merging with latest bzr revision (10506). Ovidiu Maxiniuc
06:27 AM Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
Fixed with replacement in @database_access.rules@:... Vadim Nebogatov

04/07/2014

03:50 PM Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
Added update for review.
The implementation allows specifying @sql-size@ attribute for all datatypes. However, only ...
Ovidiu Maxiniuc
02:15 PM Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
One more not related bug found with compare with BINARY both for statement (method works properly):... Vadim Nebogatov

04/05/2014

12:28 PM Feature #2276: create a work queue of PatternEngine instances for runtime conversion tasks
Missed a few files, so I'm re-uploading this update. Eric Faulhaber
12:21 PM Feature #2276: create a work queue of PatternEngine instances for runtime conversion tasks
Interim update. I am uploading it as a safety backup, but it still needs a lot of work and cleanup. Eric Faulhaber
08:33 AM Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
Please include the fix with your update for this issue. Eric Faulhaber
06:42 AM Feature #2258: retrofit BUFFER-COPY and BUFFER-COMPARE language statement runtime support to use ...
During testing I have found one bug not related directly with issue.
RecordBuffer, line 4032:...
Vadim Nebogatov
 

Also available in: Atom