FWD » Core Development » Database

01/16/2020

06:15 PM Feature #4011: database/persistence layer performance improvements

Speaking of dynamic temp-tables, one of us is going to need to address the changes to the DMO interface design. Right... Eric Faulhaber

06:15 PM Feature #4011: database/persistence layer performance improvements

In email, Ovidiu Maxiniuc wrote:
> Have you had the time to add the support for extent properties? I am a bit bloc... Eric Faulhaber

07:36 AM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> Ovidiu Maxiniuc wrote:
> > ... The code is documented that _it is OK to do this with cached... Ovidiu Maxiniuc

01/15/2020

05:41 PM Feature #4011: database/persistence layer performance improvements

Ovidiu Maxiniuc wrote:
> The nice part is that if this works correctly (apparently it did until now) it will also co... Eric Faulhaber

05:35 PM Feature #4011: database/persistence layer performance improvements

Ovidiu Maxiniuc wrote:
> One more thing: I see the cache is context-local. Wouldn't it cover all connections if we m... Eric Faulhaber

05:21 PM Feature #4011: database/persistence layer performance improvements

Ovidiu Maxiniuc wrote:
> ... The code is documented that _it is OK to do this with cached queries, because each use ... Eric Faulhaber

04:42 PM Feature #4011: database/persistence layer performance improvements

Eric,
after fixing some issues that surfaced while working with repetitive queries and client (re-)connections, my e... Ovidiu Maxiniuc

01/14/2020

04:32 PM Bug #4492: database trigger defined with abbreviation should create a new buffer

I agree, let's pause work on this. Greg Shah

04:24 PM Bug #4492: database trigger defined with abbreviation should create a new buffer

The root of the problem is clearly at a lower level than anticipated. After some code analysis, the parser is the one... Adrian Lungu

01/13/2020

01:32 PM Bug #4492: database trigger defined with abbreviation should create a new buffer

Finally, I've got to the responsible area in the conversion. Mainly it looks like a new @BUFFER-SCORE@ Progress Ast s... Adrian Lungu

05:55 AM Bug #4492: database trigger defined with abbreviation should create a new buffer

Greg Shah wrote:
> Didn't you previously find that some abbreviations were treated as the same buffer as @dummy@ but... Adrian Lungu

08:58 AM Feature #3813: misc DB features part deux

4335a Greg Shah

08:52 AM Feature #3813: misc DB features part deux

Which branch should I use for this task?
Thank you. Igor Skornyakov

08:21 AM Feature #3813 (WIP): misc DB features part deux

From Eric:
> Pending Ovidiu's review, I believe the rest of #3813-2 is now pretty accurate, though I don't know ho... Greg Shah

04:40 AM Feature #4011: database/persistence layer performance improvements

After addressing the items in #4011-61 through #4011-65, please consider and propose a design for a caching/optimizat... Eric Faulhaber

04:29 AM Feature #4011: database/persistence layer performance improvements

Ovidiu, currently, we determine which implementation of @DirtyShareContext@ we use for a particular buffer by the typ... Eric Faulhaber

01/12/2020

10:13 AM Bug #4492: database trigger defined with abbreviation should create a new buffer

Didn't you previously find that some abbreviations were treated as the same buffer as @dummy@ but @dum@ was somehow s... Greg Shah

01/11/2020

09:56 AM Bug #4492: database trigger defined with abbreviation should create a new buffer

Issue #4492-1 is implying multiple changes regarding conversion:
# If the buffer used has the same name as the sch... Adrian Lungu

01/10/2020

10:46 AM Bug #4492: database trigger defined with abbreviation should create a new buffer

Issue #4492-5 fixed. @RecordBuffer.create()@ should have called the trigger before updating the @dirtyContext@, other... Adrian Lungu

08:52 AM Bug #4492: database trigger defined with abbreviation should create a new buffer

There seems to be a sub-issue in #4492-1. The @find last@ statement will find the newly created record. In 4GL, an er... Adrian Lungu

09:22 AM Feature #4011: database/persistence layer performance improvements

The trick is to write the @hashCode@ and @equals@ methods generically, to operate only on those properties that are c... Eric Faulhaber

09:15 AM Feature #4011: database/persistence layer performance improvements

Ovidiu Maxiniuc wrote:
> For the moment, I have one question, from 1st phrase, related to the key for the hash map/s... Eric Faulhaber

09:07 AM Feature #4011: database/persistence layer performance improvements

For the moment, I have one question, from 1st phrase, related to the key for the hash map/set: wouldn't it be a bit o... Ovidiu Maxiniuc

08:21 AM Feature #4011: database/persistence layer performance improvements

Ovidiu, please implement a feature which uses @BitSet@ and @HashSet@ (or @HashMap@) to implement a tracker for record... Eric Faulhaber

01/09/2020

12:04 PM Bug #4492 (WIP): database trigger defined with abbreviation should create a new buffer

Adrian Lungu

01/08/2020

04:22 PM Feature #4011: database/persistence layer performance improvements

Tasks from note 59 are implemented and were pushed to branch 4011 as r11370. Ovidiu Maxiniuc

03:37 PM Bug #4450: implement shared query and shared browse

Roger Borrello wrote:
> These testcases are broken:
>
> ./uast/browse/shared_query_browse_frame.p
> ./uast/brows... Roger Borrello

02:08 PM Bug #4450: implement shared query and shared browse

These testcases are broken:
./uast/browse/shared_query_browse_frame.p
./uast/browse/shared_query_browse_frame-run... Roger Borrello

05:13 AM Bug #4450: implement shared query and shared browse

> The 4GL probably provides the ability to use a shared browse in more than one non-shared frame.
As far as I test... Stanislav Lomany

01/07/2020

06:57 PM Bug #4450: implement shared query and shared browse

Stanislav Lomany wrote:
> 4450a was merged into 4207a as rev 11371.
I updated my 4207a to that rev, and customer ... Roger Borrello

06:05 PM Bug #4450: implement shared query and shared browse

4450a was merged into 4207a as rev 11371. Stanislav Lomany

09:34 AM Bug #4450: implement shared query and shared browse

Greg Shah wrote:
> Code Review Task Branch 4450a Revision 11342
>
> I'm good with the changes. Please merge them... Roger Borrello

09:27 AM Bug #4450: implement shared query and shared browse

Code Review Task Branch 4450a Revision 11342
I'm good with the changes. Please merge them into 4207a and then dea... Greg Shah

09:20 AM Bug #4450 (WIP): implement shared query and shared browse

Iterator issue and javadocs are fixed in 4450a rev 11342. (please note that I'll be unavailable for the next couple o... Stanislav Lomany

08:11 AM Bug #4450: implement shared query and shared browse

Please check in your changes and I will review. I'd like to have them merged into 4207a ASAP, if there is no issue.
... Greg Shah

08:02 AM Bug #4450: implement shared query and shared browse

Heh, I forgot to define a local iterator and and the one from the outer cycle was used.
The files in the customer's ... Stanislav Lomany

06:10 AM Bug #4450: implement shared query and shared browse

> 1. Why aren't shared browse instances registered with/imported from the SVM?
Browse widget is a part of a frame,... Stanislav Lomany

01/06/2020

05:54 PM Feature #4011: database/persistence layer performance improvements

Please go ahead and implement the conversion changes for the DMO interface simplification (i.e., moving the bulk meth... Eric Faulhaber

03:20 PM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> It seems we could rationalize the DMO interface and implementation class hierarchy a bit. Cu... Ovidiu Maxiniuc

02:09 PM Feature #4011: database/persistence layer performance improvements

Another issue I want to discuss for when I get back to the bulk getters and setter for extent fields in @DmoClass@...... Eric Faulhaber

01:49 PM Feature #4011: database/persistence layer performance improvements

Ovidiu Maxiniuc wrote:
> The usage of @BitSet@ should be blazing fast.
I think it should be much better, though n... Eric Faulhaber

07:29 AM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> Ovidiu, welcome back! I am reworking the @RecordBuffer$Handler@ inner class pretty drastical... Ovidiu Maxiniuc

01:21 AM Feature #4011: database/persistence layer performance improvements

Ovidiu, welcome back! I am reworking the @RecordBuffer$Handler@ inner class pretty drastically, pushing much of the p... Eric Faulhaber

11:18 AM Bug #4450: implement shared query and shared browse

Code Review Task Branch 4450a Revision 11341
1. Why aren't shared browse instances registered with/imported from t... Greg Shah

09:19 AM Bug #4450: implement shared query and shared browse

Roger Borrello wrote:
> Stanislav Lomany wrote:
> > 4450a rev 11341 fixes the testcase, not sure about the customer... Roger Borrello

09:13 AM Bug #4450: implement shared query and shared browse

Stanislav Lomany wrote:
> 4450a rev 11341 fixes the testcase, not sure about the customer's app. Please review.
I... Roger Borrello

06:25 AM Bug #4492: database trigger defined with abbreviation should create a new buffer

A database trigger defined in the following manner behaves differently on FWD:... Adrian Lungu

06:17 AM Bug #4492 (WIP): database trigger defined with abbreviation should create a new buffer

Adrian Lungu

01/04/2020

03:35 PM Bug #4450: implement shared query and shared browse

4450a rev 11341 fixes the testcase, not sure about the customer's app. Please review. Stanislav Lomany

01/02/2020

06:59 AM Bug #4450: implement shared query and shared browse

Please summarize the status of the task, what is left to do and the estimated time needed. Greg Shah

05:09 AM Bug #4450: implement shared query and shared browse

> Let me know if you'd like me to run the customer code through this branch for testing purposes.
Sure, as soon as... Stanislav Lomany

12/31/2019

10:00 AM Bug #4450: implement shared query and shared browse

Stanislav Lomany wrote:
> Created task branch 4450a from FWD trunk revision 11339.
Let me know if you'd like me t... Roger Borrello

12/24/2019

11:16 AM Bug #4450: implement shared query and shared browse

Created task branch 4450a from FWD trunk revision 11339. Stanislav Lomany

12/23/2019

09:54 AM Bug #4450: implement shared query and shared browse

Queries declared with @DEF QUERY@, e.g.... Stanislav Lomany

12/20/2019

05:24 PM Feature #4011: database/persistence layer performance improvements

I committed revision 11369. Most important changes:
* removed completely the temporary @populateFields()@ and @popul... Ovidiu Maxiniuc

04:19 PM Feature #4011: database/persistence layer performance improvements

I had a question w.r.t. the FQL->SQL generation: I know you've been focused primarily on getting the functionality wo... Eric Faulhaber

01:55 PM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> Yes, the idea behind @PropertyMeta@ was to store any information needed to convert between t... Ovidiu Maxiniuc

01:53 PM Feature #4011: database/persistence layer performance improvements

Yes, the idea behind @PropertyMeta@ was to store any information needed to convert between these lower level types an... Eric Faulhaber

01:28 PM Feature #4011: database/persistence layer performance improvements

Done, see r11368.
Related to the content of @data[]@: I was using BDT, with unknown values. Your approach uses @nu... Ovidiu Maxiniuc

01:08 PM Feature #4011: database/persistence layer performance improvements

Ah, makes sense. That's a remnant of how the old Hibernate @Transaction@ object worked. I did not really intend to ca... Eric Faulhaber

11:22 AM Feature #4011: database/persistence layer performance improvements

Ovidiu Maxiniuc wrote:
> However, after rolling back that code, it seems that there is a imbalance in @Persistence@ ... Ovidiu Maxiniuc

12/19/2019

05:21 PM Feature #4011: database/persistence layer performance improvements

RB's flushing and Hibernate's transparent write-behind are not directly related. We implemented the flushing in RB to... Eric Faulhaber

04:59 PM Feature #4011: database/persistence layer performance improvements

Well, a bit of investigation and I remember that in RecordBuffer:5917 I replaced @if (!isTransient())@ with @if (curr... Ovidiu Maxiniuc

04:47 PM Feature #4011: database/persistence layer performance improvements

The message is just a WARNING at the moment it is first displayed, but something goes wrong after the active (convert... Ovidiu Maxiniuc

04:41 PM Feature #4011: database/persistence layer performance improvements

Ovidiu Maxiniuc wrote:
> Oops, I have this too, but when closing the client window.
I am using the ChUI client.... Eric Faulhaber

04:38 PM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> Hm, I still get the @Illegal attempt to register Finalizable@ crash. You're not seeing this?... Ovidiu Maxiniuc

04:34 PM Feature #4011: database/persistence layer performance improvements

Hm, I still get the @Illegal attempt to register Finalizable@ crash. You're not seeing this? Do you have any changes ... Eric Faulhaber

04:31 PM Feature #4011: database/persistence layer performance improvements

No, it is not. It works without the release, too, but I wanted t be sure it does this way, too. Ovidiu Maxiniuc

04:29 PM Feature #4011: database/persistence layer performance improvements

Ovidiu Maxiniuc wrote:
> Your basic testcase works for me. Clean convert, launched server, client and got the follow... Eric Faulhaber

04:28 PM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> Hm, I had intended the block at line 262 to avoid this. I'll look at it in a bit...
I chang... Ovidiu Maxiniuc

04:25 PM Feature #4011: database/persistence layer performance improvements

Your basic testcase works for me. Clean convert, launched server, client and got the following output: @0x1 1@ after ... Ovidiu Maxiniuc

04:25 PM Feature #4011: database/persistence layer performance improvements

Ovidiu Maxiniuc wrote:
> The @for@ a line 252 will create multiple setters and getters for same property because the... Eric Faulhaber

04:21 PM Feature #4011: database/persistence layer performance improvements

Once that is working, I will implement the state changes to get an update test case going. Then expand into a more co... Eric Faulhaber

04:08 PM Feature #4011: database/persistence layer performance improvements

I see. I started form that point and gradually gain complexity. I'm going back to the basic testcase to have the same... Ovidiu Maxiniuc

04:05 PM Feature #4011: database/persistence layer performance improvements

I am working my way up to extent fields. I put in the basic getter/setter methods -- incorrectly, apparently ;-) -- b... Eric Faulhaber

04:00 PM Feature #4011: database/persistence layer performance improvements

Yes, sorry, I missed the file. Ovidiu Maxiniuc

03:59 PM Feature #4011: database/persistence layer performance improvements

Ovidiu Maxiniuc wrote:
> I have the following compile issue in @src/com/goldencode/p2j/persist/orm/DmoClass.java@:
... Eric Faulhaber

03:55 PM Feature #4011: database/persistence layer performance improvements

Sorry to bother. The generated classes are invalid when they contain extent fields. The @for@ a line 252 will create ... Ovidiu Maxiniuc

03:47 PM Feature #4011: database/persistence layer performance improvements

The @DmoClass@ does not have full support for EXTENT fields. For completeness, there are two more getter and three se... Ovidiu Maxiniuc

03:41 PM Feature #4011: database/persistence layer performance improvements

I have the following compile issue in @src/com/goldencode/p2j/persist/orm/DmoClass.java@:... Ovidiu Maxiniuc

03:29 PM Feature #4011: database/persistence layer performance improvements

There is still work I need to do on the DMO class assembler, but I wanted to try to get a real, converted, test code ... Eric Faulhaber

03:23 PM Feature #4011: database/persistence layer performance improvements

Ovidiu Maxiniuc wrote:
> Please move the line that registers the DMO class just before returning the @dmoIface@ (ie.... Eric Faulhaber

03:13 PM Feature #4011: database/persistence layer performance improvements

Please move the line that registers the DMO class just before returning the @dmoIface@ (ie. after the last @if@). Thi... Ovidiu Maxiniuc

03:06 PM Feature #4011: database/persistence layer performance improvements

Thanks, that helped. Now I get:... Eric Faulhaber

02:52 PM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> I'm getting a @Failed to locate ALIAS for Tt_1_1__Impl__@ error on a select. Is there an imp... Ovidiu Maxiniuc

02:12 PM Feature #4011: database/persistence layer performance improvements

I'm getting a @Failed to locate ALIAS for Tt_1_1__Impl__@ error on a select. Is there an implicit assumption somewher... Eric Faulhaber

02:04 PM Feature #4011: database/persistence layer performance improvements

Ovidiu Maxiniuc wrote:
> As the priority is to get real code running, please continue to work through the @AbstractM... Eric Faulhaber

01:55 PM Feature #4011: database/persistence layer performance improvements

Ovidiu Maxiniuc wrote:
> Eric, I am aware of this. In fact, I wrote in note 14 about BDT used temporarily in data (s... Eric Faulhaber

01:54 PM Feature #4011: database/persistence layer performance improvements

Whew, ok good :)
I haven't gotten my head fully around your FQL stuff yet, and I was worried the dependency might ... Eric Faulhaber

01:52 PM Feature #4011: database/persistence layer performance improvements

Eric, I am aware of this. In fact, I wrote in note 14 about BDT used temporarily in data (search for "Note that the v... Ovidiu Maxiniuc

01:48 PM Feature #4011: database/persistence layer performance improvements

Ovidiu, I think there is a fundamental misunderstanding in your implementation of @populateData@, and as I dig furthe... Eric Faulhaber

12:06 PM Feature #4011: database/persistence layer performance improvements

FYI, I've gotten through the verifier errors and I'm trying a simpler test case than yours (to begin with):... Eric Faulhaber

09:48 AM Feature #4011: database/persistence layer performance improvements

_And the answer from Eric (also by email):_
I think you are correct that the @Buf@ interface can be removed, but I... Ovidiu Maxiniuc

09:46 AM Feature #4011: database/persistence layer performance improvements

_Current state of the task (from email):_
I have just committed the revision 11365 of 4011a. I tested it, and the ... Ovidiu Maxiniuc