FWD » Core Development » Database

02/14/2020

08:20 AM Feature #3813: misc DB features part deux

Additional tests of the @CONNECT@ @-pf@ option support passed. A minor typo was fixed.
4335a revision 11421 is ready... Igor Skornyakov

04:57 AM Feature #4011: database/persistence layer performance improvements

I committed intermediate changes for unique constraint validation in r11389, but it is not yet working properly. The ... Eric Faulhaber

04:57 AM Bug #4492: database trigger defined with abbreviation should create a new buffer

Adrian Lungu wrote:
> Issue #4492-5 fixed. @RecordBuffer.create()@ should have called the trigger before updating th... Adrian Lungu

02/13/2020

04:12 PM Feature #3813: misc DB features part deux

Added configuration file (@-pf@ option of the @CONNECT@ statement).
Committed to 4335a revision 11419.
Please not... Igor Skornyakov

10:04 AM Feature #3813: misc DB features part deux

Yes, failing on recursion is a good idea. Hangs don't have to be duplicated. Greg Shah

10:03 AM Feature #3813: misc DB features part deux

4GL allows @-pf@ option in the .pf file. However, this may result in the application hang due to infinite recursion.... Igor Skornyakov

03:23 PM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> [OM] replace current UNDO architecture with savepoint-based, just-in-time DMO refresh impl... Eric Faulhaber

03:19 PM Feature #4011: database/persistence layer performance improvements

Just a note on what I'm up to, since I realize I've become a bit quiet again. I've been reworking @UniqueTracker@ as ... Eric Faulhaber

02/12/2020

10:23 AM Feature #3813: misc DB features part deux

Finished rework of @CONNECT@/@DBPARAM@.
Committed to 4335a revision 11416.
Working on the parameter file support ... Igor Skornyakov

02/11/2020

03:50 PM Bug #4537: CONNECT statement parameters parsing quirks

4GL uses some weird logic when parsing @CONNECT@ statement arguments which I cannot understand.
For example, if one ... Igor Skornyakov

03:46 PM Bug #4537 (New): CONNECT statement parameters parsing quirks

Igor Skornyakov

01:36 PM Feature #3813: misc DB features part deux

> Is it OK if FWD will complain about a complete key, e.g.
Yes, for *now* it is OK. Please create a new task for ... Greg Shah

12:21 PM Feature #3813: misc DB features part deux

4GL uses some weird logic when parsing @CONNECT@ statement arguments which I cannot understand.
For example, if one ... Igor Skornyakov

11:03 AM Feature #3813: misc DB features part deux

Greg Shah wrote:
> Ignoring the quirks in #4535 (which will be deferred), what is the effort to resolve these other ... Igor Skornyakov

10:31 AM Feature #3813: misc DB features part deux

Ignoring the quirks in #4535 (which will be deferred), what is the effort to resolve these other issues (from #3813-51)? Greg Shah

07:25 AM Feature #3813: misc DB features part deux

Some important notes:
# The @CONNECT@ statement can create more than one connection. This is mentioned in the Progre... Igor Skornyakov

08:35 AM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> * I am testing/debugging @UniqueTracker@ and I will have some changes. Do you have any pendi... Ovidiu Maxiniuc

05:47 AM Feature #4011: database/persistence layer performance improvements

Ovidiu, a few questions...
* I am testing/debugging @UniqueTracker@ and I will have some changes. Do you have any ... Eric Faulhaber

06:17 AM Bug #4535: CONNECT statement with VALUE expression quirks

The @VALUE@ usage in the @CONNECT@ statement looks really tricky. For example... Igor Skornyakov

06:13 AM Bug #4535 (New): CONNECT statement with VALUE expression quirks

Igor Skornyakov

02/10/2020

05:55 PM Feature #3813: misc DB features part deux

Greg Shah wrote:
> #3813 does need to handle the case where there are more than 1 option inside a single @VALUE()@ e... Igor Skornyakov

05:51 PM Feature #3813: misc DB features part deux

#3813 does need to handle the case where there are more than 1 option inside a single @VALUE()@ expression. That is ... Greg Shah

05:44 PM Feature #3813: misc DB features part deux

Greg Shah wrote:
> For now, I don't know of a case where customer code uses this approach. Please create a new task... Igor Skornyakov

05:36 PM Feature #3813: misc DB features part deux

For now, I don't know of a case where customer code uses this approach. Please create a new task (under the Database... Greg Shah

05:31 PM Feature #3813: misc DB features part deux

Constantin Asofiei wrote:
> Does @CONNECT E:\testcases\uast\security\fwd1.db -P secret -P secret -U fwdb@domain -... Igor Skornyakov

05:22 PM Feature #3813: misc DB features part deux

Does @CONNECT E:\testcases\uast\security\fwd1.db -P secret -P secret -U fwdb@domain -bibufs 13 -1 -ld fwd1.@ work ... Constantin Asofiei

05:21 PM Feature #3813: misc DB features part deux

The @VALUE@ usage in the @CONNECT@ statement looks really tricky. For example... Igor Skornyakov

02:10 PM Feature #3813: misc DB features part deux

Greg Shah wrote:
> Is this the 4GL or FWD?
It is 4GL. The current implementation of FWD doesn't support any of th... Igor Skornyakov

02:08 PM Feature #3813: misc DB features part deux

Is this the 4GL or FWD? Greg Shah

01:21 PM Feature #3813: misc DB features part deux

Using @VALUE()@ in the @CONNECT@ statement looks a little tricky. Consider the following code:... Igor Skornyakov

11:35 AM Feature #3813: misc DB features part deux

I agree that we need to improve our documentation to explain this. For now, I think you can ignore it. Greg Shah

11:10 AM Feature #3813: misc DB features part deux

Greg Shah wrote:
> In your case, were you explicitly setting @unix-escapes@ to @true@ even though @opsys@ was set to... Igor Skornyakov

10:55 AM Feature #3813: misc DB features part deux

> This means that even if the incorrect value of the "unix-escapes" was specified before "opsys" (as in my case) it w... Greg Shah

03:58 PM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> 4. Removing reflection dependencies (getter/setter methods) from @PropertyMeta@ if possible.... Ovidiu Maxiniuc

03:49 PM Feature #4011: database/persistence layer performance improvements

Ovidiu, I've made some initial assignments in #4011-105. Please look at those items which I've marked with your initi... Eric Faulhaber

02:12 PM Feature #4011: database/persistence layer performance improvements

Regarding the @BDTType@ and the @TypeManager@.
The problem is that, I wrote @TypeManager@ to provide @ParameterSette... Ovidiu Maxiniuc

11:28 AM Feature #4011: database/persistence layer performance improvements

Eric,
I committed my latest changes as revision 11385. The caching of UPDATES is included, along with fixes for BDTT... Ovidiu Maxiniuc

04:51 AM Feature #4011: database/persistence layer performance improvements

Ovidiu, please see #4011-105 and note that I have assigned the "refactor and finish @BDTType@ implementations" item t... Eric Faulhaber

04:08 AM Feature #4011: database/persistence layer performance improvements

Ovidiu Maxiniuc wrote (in email):
> working on update optimization based on "changed" bitsets as keys. It proves t... Eric Faulhaber

11:34 AM Bug #3471: incremental conversion is regressed

> Not sure how to handle the files which are deleted (or removed from the conversion).
If the 4GL source files are... Greg Shah

11:05 AM Bug #3471: incremental conversion is regressed

Greg Shah wrote:
> > add all files without an @.ast@
>
> Yes, this makes sense. I presume that this really means... Constantin Asofiei

10:59 AM Bug #3471: incremental conversion is regressed

> add all files without an @.ast@
Yes, this makes sense. I presume that this really means "add all files (that wo... Greg Shah

02/09/2020

02:50 PM Bug #3471: incremental conversion is regressed

Greg, about identifying the 'modified files' from a full conversion project. What I'm thinking is to:
* add all fil... Constantin Asofiei

08:29 PM Feature #4011: database/persistence layer performance improvements

Ovidiu, this is a brain dump of things on my mind about the latest effort. I'm sure more will come to me, and I will ... Eric Faulhaber

02/08/2020

03:41 AM Feature #3813: misc DB features part deux

Greg Shah wrote:
> Setting @opsys@ should have implicitly set @unix-escapes@, so that sounds like a bug. Please fig... Igor Skornyakov

02/07/2020

04:55 PM Feature #3813: misc DB features part deux

Setting @opsys@ should have implicitly set @unix-escapes@, so that sounds like a bug. Please figure that out now, be... Greg Shah

04:41 PM Feature #3813: misc DB features part deux

Greg Shah wrote:
> This means your project is not configured as a Windows project. See @p2j.cfg.xml@ and the @<para... Igor Skornyakov

04:20 PM Feature #3813: misc DB features part deux

This means your project is not configured as a Windows project. See @p2j.cfg.xml@ and the @<parameter name="opsys" ... Greg Shah

04:17 PM Feature #3813: misc DB features part deux

It seems that a backslash is processed at a very early stage. I see eaten chars in a .cache file. Not sure how to dea... Igor Skornyakov

04:04 PM Feature #3813: misc DB features part deux

Greg Shah wrote:
> Isn't this just the fact that the @\@ is an escape char and will always be eaten? And when used ... Igor Skornyakov

03:48 PM Feature #3813: misc DB features part deux

Isn't this just the fact that the @\@ is an escape char and will always be eaten? And when used with some characters... Greg Shah

03:05 PM Feature #3813: misc DB features part deux

I've essentially re-worked the @CONNECT@ statement conversion. The only remaining problem I see now is about the para... Igor Skornyakov

04:27 PM Feature #4011: database/persistence layer performance improvements

Oops. Please use rev 11381 instead. I missed rolling back one aborted change in rev 11380. The class it referenced st... Eric Faulhaber

04:15 PM Feature #4011: database/persistence layer performance improvements

Thank you!
I've committed rev 11380. Please take a look when you have time (doesn't need to be now), starting with... Eric Faulhaber

04:04 PM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> Can you please point me to the test cases you are using? Thanks.
Well, I do not have a se... Ovidiu Maxiniuc

03:42 PM Feature #4011: database/persistence layer performance improvements

Ovidiu Maxiniuc wrote:
> Done, please see r11379. Sorry, I forgot to "bzr add" :(.
>
> I understand that you stil... Eric Faulhaber

03:37 PM Feature #4011: database/persistence layer performance improvements

Done, please see r11379. Sorry, I forgot to @bzr add@ :(.
I understand that you still have a bit of work before co... Ovidiu Maxiniuc

03:33 PM Feature #4011: database/persistence layer performance improvements

After I updated to your latest revision, I seem to be missing a @RecordHelper@ class. Please commit just that class s... Eric Faulhaber

03:30 PM Feature #4011: database/persistence layer performance improvements

Please hold off committing that. I have very similar changes which I will be committing shortly (sorry in advance for... Eric Faulhaber

03:28 PM Feature #4011 (WIP): database/persistence layer performance improvements

I have a pending update with some fixes. This exact piece of code is affected. In fact it looks something like:
<p... Ovidiu Maxiniuc

03:25 PM Feature #4011: database/persistence layer performance improvements

Never mind. I think I have worked it out. Eric Faulhaber

03:19 PM Feature #4011: database/persistence layer performance improvements

Ovidiu, I do not understand this code at line 370 of @Session@, from one of your recent updates:... Eric Faulhaber

09:27 PM Bug #4450: implement shared query and shared browse

Stanislav Lomany wrote:
> Roger, can you provide a testcase or point the files where duplicate widgets occur?
> I'm... Roger Borrello

02/06/2020

08:24 AM Bug #3471: incremental conversion is regressed

Greg Shah wrote:
> I think the core thing to worry about here are cares where @deleteDictionary()@ is not called
I... Constantin Asofiei

02/05/2020

07:33 AM Bug #4450: implement shared query and shared browse

Greg Shah wrote:
> Marian: Open questions which I'm hoping you can answer (see #4450-36):
>
> * Is there any way ... Marian Edu

10:34 PM Bug #4450: implement shared query and shared browse

Roger, can you provide a testcase or point the files where duplicate widgets occur?
I'm on vacation and most like I'... Stanislav Lomany

03:32 AM Bug #3471: incremental conversion is regressed

Greg Shah wrote:
> I think the core thing to worry about here are cares where @deleteDictionary()@ is not called OR ... Constantin Asofiei

02/04/2020

05:22 PM Bug #3471: incremental conversion is regressed

I think the core thing to worry about here are cares where @deleteDictionary()@ is not called OR where dictionaries a... Greg Shah

04:08 PM Bug #3471: incremental conversion is regressed

Greg, I have a question about the @DictionaryWorker@. In FWD, the pattern worker instances are global for each conve... Constantin Asofiei

12:08 AM Bug #4450: implement shared query and shared browse

Stanislav, there is a change to @rules/convert/frame_generator.xml@:... Roger Borrello

01/31/2020

05:45 PM Feature #4011: database/persistence layer performance improvements

Ovidiu Maxiniuc wrote:
> Eric, I understand that the "altered" bits allow to update only some of fields of a record.... Eric Faulhaber

04:44 PM Feature #4011: database/persistence layer performance improvements

Eric, I understand that the "altered" bits allow to update only some of fields of a record. The idea is good but I ha... Ovidiu Maxiniuc

03:34 PM Feature #4011: database/persistence layer performance improvements

Separate idea, Ovidiu, for the caching of converted FQL statements...
A lot of 4GL code I've seen has a pattern li... Eric Faulhaber

03:22 PM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> Well, wait a minute. The savepoint is tightly bracketed to just that validating update, so I... Ovidiu Maxiniuc

03:15 PM Feature #4011: database/persistence layer performance improvements

I think we're ok on both the explicit RELEASE statement validate/flush as well as the implicit validate/flush when a ... Eric Faulhaber

03:12 PM Feature #4011: database/persistence layer performance improvements

Well, wait a minute. The savepoint is tightly bracketed to just that validating update, so I suppose I could just rol... Eric Faulhaber

02:44 PM Feature #4011: database/persistence layer performance improvements

Perhaps in the @VALIDATE@ case we can have a routine that implements the multiple queries approach. It is not optima... Greg Shah

02:30 PM Feature #4011: database/persistence layer performance improvements

I was thinking of @RELEASE@, too. However, the release will automatically issue a FLUSH routine, indirectly validatin... Ovidiu Maxiniuc

02:30 PM Feature #4011: database/persistence layer performance improvements

Constantin Asofiei wrote:
> Eric, does the above include what VALIDATE does in 4GL?
That's a good point. No, I wa... Eric Faulhaber

02:29 PM Feature #4011: database/persistence layer performance improvements

Ovidiu Maxiniuc wrote:
> Yes, I totally agree with the change of the way records are handled on rollback events. And... Eric Faulhaber

02:25 PM Feature #4011: database/persistence layer performance improvements

Eric, does the above include what VALIDATE does in 4GL? Constantin Asofiei

02:14 PM Feature #4011: database/persistence layer performance improvements

Ovidiu, I have been reworking the DMO validation processing to take advantage of the fact that we have removed hibern... Eric Faulhaber

11:45 AM Bug #3471: incremental conversion is regressed

Greg Shah wrote:
> Constantin: Are you planning to use an H2 database for storing project state?
Yes Constantin Asofiei

11:45 AM Bug #3471: incremental conversion is regressed

Constantin: Are you planning to use an H2 database for storing project state? Greg Shah

09:31 AM Bug #4450: implement shared query and shared browse

Marian: Open questions which I'm hoping you can answer (see #4450-36):
* Is there any way to use a shared browse i... Greg Shah

01/27/2020

05:15 PM Feature #3813: misc DB features part deux

Eric Faulhaber wrote:
> For implementation of the @DBPARAM@ builtin function, correct. For those options which we in... Igor Skornyakov

05:09 PM Feature #3813: misc DB features part deux

For implementation of the @DBPARAM@ builtin function, correct. For those options which we intend to add support, the ... Eric Faulhaber

04:09 PM Feature #3813: misc DB features part deux

Eric Faulhaber wrote:
> The original, ordered list approach was based on a very limited set of connection options, w... Igor Skornyakov

03:52 PM Feature #3813: misc DB features part deux

The original, ordered list approach was based on a very limited set of connection options, which were basically the m... Eric Faulhaber

03:47 PM Feature #3813: misc DB features part deux

Eric Faulhaber wrote:
> Hm, you're correct, that conversion looks completely wrong. I think the conversion may have ... Igor Skornyakov

03:34 PM Feature #3813: misc DB features part deux

Hm, you're correct, that conversion looks completely wrong. I think the conversion may have been broken along the way... Eric Faulhaber

02:40 PM Feature #3813: misc DB features part deux

The conversion of the @CONNECT@ statement looks a little bit strange.
For example. The statement ... Igor Skornyakov

11:38 AM Bug #3471: incremental conversion is regressed

I believe the original issue of the task is gone now as recently Adrian replaced the @schema-triggers@ two-stage trig... Ovidiu Maxiniuc

11:26 AM Bug #3471: incremental conversion is regressed

Greg Shah wrote:
> The first phase is part of the 4-6 weeks?
Yes.
> The second phase is the extra 3-4 days?
Yes,... Constantin Asofiei

11:13 AM Bug #3471: incremental conversion is regressed

>>> I plan to rely on an explicit list of files to 'incrementally convert'.
>>
>> We would build this list automati... Greg Shah

10:29 AM Bug #3471: incremental conversion is regressed

Greg Shah wrote:
> > automatic incremental conversion
>
> By this do you mean item 3 in #3471-7/?
Yes.
> > I pl... Constantin Asofiei

09:49 AM Bug #3471: incremental conversion is regressed

> automatic incremental conversion
By this do you mean item 3 in #3471-7/?
> I plan to rely on an explicit list... Greg Shah

09:32 AM Bug #3471: incremental conversion is regressed

I think it will take ~4-6 weeks to complete and stabilize. I've been working on identifying and analyzing the parts ... Constantin Asofiei

01/24/2020

05:53 PM Feature #3815 (Closed): more temp-table options

Greg Shah

02:04 PM Feature #3815: more temp-table options

Task #4520 was created for the inheritance from permanent to temp tables issue. This task can be closed. Stanislav Lomany

02:01 PM Bug #4520: Implement proper codepage inheritance from permanent to temp tables

A code page can be set for a clob field of a permanent table. E.g.... Stanislav Lomany

01:41 PM Bug #4520 (New): Implement proper codepage inheritance from permanent to temp tables

Stanislav Lomany

11:55 AM Feature #3813: misc DB features part deux

Greg Shah wrote:
> Igor Skornyakov wrote:
> Did the original pf file you tested have parameters that are not relate... Igor Skornyakov

11:34 AM Feature #3813: misc DB features part deux

Igor Skornyakov wrote:
> All connection parameters from #3813-11 are accepted in the @CONNECT@ statement and are sho... Greg Shah

11:10 AM Feature #3813: misc DB features part deux

All connection parameters from #3813-11 are accepted in the @CONNECT@ statement and are shown by @DBPARAM@ in this case. Igor Skornyakov

08:22 AM Feature #3813: misc DB features part deux

Greg Shah wrote:
> One thing that was not clear from #3813-11: which of these items can be specified in the @CONNECT... Igor Skornyakov

08:17 AM Feature #3813: misc DB features part deux

>> I understand that I should add support for the remaining options in the CONNECT statement by just storing values a... Greg Shah

03:31 AM Feature #3813: misc DB features part deux

Eric Faulhaber wrote:
> Igor Skornyakov wrote:
> > Can anybody help me to figure which of the database connection p... Igor Skornyakov

09:24 AM Feature #4516: testing and completion of runtime compatibility for table/table-handle/dataset/dat...

Greg Shah wrote:
> Constantin: Did I write up the part about the UAST testcases correctly?
Yes.
> All: What is th... Constantin Asofiei

08:11 AM Feature #4175 (WIP): add support for -1 (single user) option for CONNECT statement

Greg Shah

01/23/2020

06:15 PM Feature #3813: misc DB features part deux

Igor Skornyakov wrote:
> Can anybody help me to figure which of the database connection parameters described in the ... Eric Faulhaber

05:14 PM Feature #3813: misc DB features part deux

Can anybody help me to figure which of the database connection parameters described in the previous note have direct ... Igor Skornyakov

05:02 PM Feature #3813: misc DB features part deux

Here is a (hopefully) complete list of database connection parameters shown by @DBPARAM@ function.
|_.Parameter|_.De... Igor Skornyakov

04:02 PM Feature #4011: database/persistence layer performance improvements

Yes, I totally agree with the change of the way records are handled on rollback events. And I firmly believe that, ev... Ovidiu Maxiniuc

02:07 PM Feature #4516: testing and completion of runtime compatibility for table/table-handle/dataset/dat...

The buffer alias changes shouldn't affect any of the above. They are strictly regarding "proxying" any buffer paramet... Adrian Lungu

12:22 PM Feature #4516: testing and completion of runtime compatibility for table/table-handle/dataset/dat...

Constantin: Did I write up the part about the UAST testcases correctly?
Adrian: Does your buffer alias work have a... Greg Shah

12:21 PM Feature #4516: testing and completion of runtime compatibility for table/table-handle/dataset/dat...

The initial work was done as part of #3816. All of those changes are in trunk. As of trunk 11340, this is the statu... Greg Shah

11:59 AM Feature #4516 (New): testing and completion of runtime compatibility for table/table-handle/datas...

Greg Shah

12:28 PM Feature #3815: more temp-table options

>> Also I left a comment in the code which says that it's not clear if a temp-table inherits code page from a permane... Greg Shah

12:23 PM Feature #3816 (Closed): table and table handle parameter options

The final work will be done in #4516. Greg Shah

01/22/2020

05:49 PM Feature #3809 (Closed): ProDataSet support

Greg Shah

05:49 PM Feature #3809: ProDataSet support

All remaining work (of which I'm aware) related to ProDataSets is documented in these tasks:
* #4514 run ProDataSe... Greg Shah

05:42 PM Feature #4514: run ProDataSet test suite in FWD and resolve any issues such that it works the sam...

As part of the work to add ProDataSet support in #3809, a test suite was written to explore the behavior of the PDS f... Greg Shah

05:40 PM Feature #4514 (WIP): run ProDataSet test suite in FWD and resolve any issues such that it works t...

Greg Shah

02:01 PM Feature #4011: database/persistence layer performance improvements

Ovidiu, I want to run my ideas for planned changes to the undo architecture by you and get your input...
To the gr... Eric Faulhaber

07:32 AM Feature #4011: database/persistence layer performance improvements

> We might be able to create some custom bulk/mass get/set methods to call from these methods that might be more effi... Greg Shah

01:21 AM Feature #4011: database/persistence layer performance improvements

I'm not sure why you get the @VerifyError@.
I haven't considered the most efficient ways these methods might be wr... Eric Faulhaber

01/21/2020

04:01 PM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> Yes, please go ahead and make the necessary changes to @DmoClass@ to add the missing signatu... Ovidiu Maxiniuc

03:33 PM Feature #3813: misc DB features part deux

Greg Shah wrote:
> > For example, I have a @.pf@ file with multiple parameters, but only two of them are included in... Igor Skornyakov

03:17 PM Feature #3813: misc DB features part deux

> For example, I have a @.pf@ file with multiple parameters, but only two of them are included in the @DBPARAM@ resul... Greg Shah

12:17 PM Feature #3813: misc DB features part deux

The following statement from the Progress documentation regarding @DBPARAM@ functions (see https://docs.progress.com/... Igor Skornyakov

09:06 AM Feature #2156: datetime-tz and hibernate

3809e was merged to trunk as revision 11340. Greg Shah

01/20/2020

07:02 AM Feature #4011: database/persistence layer performance improvements

Eric Faulhaber wrote:
> @isTracked@ actually removes a record's key. That doesn't seem right. Maybe I'm not understa... Ovidiu Maxiniuc

06:17 AM Feature #4011: database/persistence layer performance improvements

Ovidiu, please hold off making changes to @UniqueTracker@ related to the above post. I have begun refactoring the dir... Eric Faulhaber

04:15 AM Feature #3809: ProDataSet support

3809e passed ChUI and GUI regression tests. It was merged to trunk as revision 11340 and archived. Hynek Cihlar

01/17/2020

05:42 PM Feature #4011: database/persistence layer performance improvements

Another feature we need is an atomic, context-safe, check and update feature to update an index with a new record if ... Eric Faulhaber

04:41 PM Feature #4011: database/persistence layer performance improvements

Ovidiu, thanks for the @UniqueTracker@ implementation. I am working to integrate this code now, but I have some quest... Eric Faulhaber