FWD » Core Development » Database

08/09/2022

05:45 PM Feature #6371: implement SAVE CACHE statement

XML is more consistent with the rest of the configuration in FWD. Greg Shah

04:59 PM Feature #6371: implement SAVE CACHE statement

I pushed revision 6371a/14095 with code to support comparison for tables and columns. Also, extended the javadoc on t... Boris Schegolev

11:20 AM Feature #6371: implement SAVE CACHE statement

Eric Faulhaber wrote:
> Boris Schegolev wrote:
> > Saved state will consist of tables, columns and index lists. Thi... Tijs Wickardt

11:02 AM Feature #6371: implement SAVE CACHE statement

Eric Faulhaber wrote:
> Boris, please commit all your updates to 6371a. You are the only one changing this branch, s... Eric Faulhaber

10:56 AM Feature #6371: implement SAVE CACHE statement

Boris Schegolev wrote:
> Saved state will consist of tables, columns and index lists. This object can be serialized ... Eric Faulhaber

10:47 AM Feature #6371: implement SAVE CACHE statement

Boris, please commit all your updates to 6371a. You are the only one changing this branch, so it is safe. This will m... Eric Faulhaber

11:55 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

If the JSON array approach seems to be the only viable option, I think we have to use it for now. Another alternative... Eric Faulhaber

08/05/2022

02:35 PM Feature #6371: implement SAVE CACHE statement

Implemented @DatabaseState@ object, @Difference@ object and loading / comparison for tables. Please, review. Boris Schegolev

12:04 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

There is a about a couple of dozens of PostgreSQL native UDFs (~10%) that heavily use arrays and/or user-defined data... Igor Skornyakov

08/04/2022

06:18 AM Feature #6348: implement support for MariaDB

Greg Shah wrote:
> > However supporing word indexes for non-normalized extent fields can be not strightforward.
>
... Igor Skornyakov

05:50 AM Feature #6348: implement support for MariaDB

> However supporing word indexes for non-normalized extent fields can be not strightforward.
Is it possible to use... Greg Shah

12:38 AM Feature #6348: implement support for MariaDB

Eric Faulhaber wrote:
> Agreed, we should not have logic that begins @if (dialect instanceof *Dialect) ...@.
>
I'... Igor Skornyakov

10:59 PM Feature #6348: implement support for MariaDB

Ovidiu Maxiniuc wrote:
> Yes, I noticed that @WordTable@ class and some methods of @DDLGeneratorWorker@ are not full... Eric Faulhaber

08/03/2022

04:39 PM Feature #6371: implement SAVE CACHE statement

Saved state will consist of tables, columns and index lists. This object can be serialized using common methods (YAML... Boris Schegolev

12:41 AM Feature #6371: implement SAVE CACHE statement

Boris Schegolev wrote:
> I am attaching a proposal for Schema Comparator service. It would be invoked like:
>
> [... Eric Faulhaber

03:52 PM Feature #6348: implement support for MariaDB

Yes, I noticed that @WordTable@ class and some methods of @DDLGeneratorWorker@ are not fully dialect independent. The... Ovidiu Maxiniuc

02:56 PM Feature #6348: implement support for MariaDB

Please note that @CONTAINS@ (word tables') support for MariaDB will also need some some efforts (we need MariaDB-spec... Igor Skornyakov

01:10 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Eric Faulhaber wrote:
> Please see #6348-7. In fact, it would be good to review that whole task.
Thank you, revie... Igor Skornyakov

12:52 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Please see #6348-7. In fact, it would be good to review that whole task. Eric Faulhaber

12:11 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Have we already made a decision about datatypes' mapping for MariaDB?
At this moment the most important for me are s... Igor Skornyakov

08/01/2022

03:42 PM Feature #6371: implement SAVE CACHE statement

I am attaching a proposal for Schema Comparator service. It would be invoked like:... Boris Schegolev

02:32 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Ovidiu Maxiniuc wrote:
> I used the following command:
> [...]
>
> That installed for me:
> [...]
>
> I do n... Igor Skornyakov

02:22 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

I used the following command:... Ovidiu Maxiniuc

01:27 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Working with version 10.8.3 Igor Skornyakov

12:45 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Igor Skornyakov wrote:
> Which version of MariaDB should I work with?
The most recent production build (10.8, AFA... Eric Faulhaber

04:14 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Which version of MariaDB should I work with?
Thank you. Igor Skornyakov

07/31/2022

03:41 PM Feature #6628 (WIP): port PostgreSQL native user defined functions to MariaDB

Igor Skornyakov

07/29/2022

01:25 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Igor Skornyakov wrote:
> I understand that MariaDB does not have arrays
Not as a first class data type, no, but p... Eric Faulhaber

07/27/2022

04:02 PM Bug #6599: minimal mode conversion problem with DMO name collision

Eric, minimal mode conversion was added after I my @NameConverter.java@ change - and conversion was fine, until the r... Constantin Asofiei

03:43 PM Bug #6599: minimal mode conversion problem with DMO name collision

Constantin, it looks like you made this change very early in 6129a (rev 13815), apparently to address cases of confli... Eric Faulhaber

06:15 AM Bug #6599: minimal mode conversion problem with DMO name collision

Eric, can this be fixed? Although is not a problem when running the converted code, this is a problem when executing... Constantin Asofiei

03:33 AM Support #4701: try to improve H2 transaction commit performance

I just noticed that H2 is moving kinda fast with no more than 5 releases in the last couple of months. I can't tell i... Alexandru Lungu

07/25/2022

03:56 AM Feature #6582: implement multi-table AdaptiveQuery

Alexandru Lungu wrote:
> I've done a bit of query exploring. I converted the following example:
>
> [...]
>
> ... Igor Skornyakov

03:38 AM Feature #6582: implement multi-table AdaptiveQuery

I've done a bit of query exploring. I converted the following example:... Alexandru Lungu

07/24/2022

01:28 PM Feature #6582: implement multi-table AdaptiveQuery

Alexandru Lungu wrote:
> I was rather thinking if there are implications of @FIRST/LAST@ and @OUTER-JOIN@ when doing... Igor Skornyakov

06:06 AM Feature #6582: implement multi-table AdaptiveQuery

Eric Faulhaber wrote:
> The ideal scenario is that we start in preselect (fast) mode and we only ever transition to ... Alexandru Lungu

05:08 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

It looks that in migration of the PostgreSQL native UDFs to MariaDB the most efforts will require those UDFs that use... Igor Skornyakov

07/23/2022

01:50 PM Feature #6582: implement multi-table AdaptiveQuery

As far as I understand the approach described in #6582-9 works with MariaDB 10.2+ as well. Igor Skornyakov

07:44 AM Feature #6582: implement multi-table AdaptiveQuery

Alexandru Lungu wrote:
>Also, I didn't consider yet other aspects as: FIRST/LAST or OUTER-JOIN.
I can suggest the f... Igor Skornyakov

04:28 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Eric Faulhaber wrote:
> Igor, can you think of a way to generate a list of the PostgreSQL built-in functions (includ... Igor Skornyakov

07/22/2022

06:07 PM Feature #6630: optimize return of table parameter

While working on a related issue I noticed the following stack trace:... Ovidiu Maxiniuc

05:55 PM Feature #6630 (Closed): optimize return of table parameter

Ovidiu Maxiniuc

02:25 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Eric Faulhaber wrote:
> So far, so good...
>
> [...]
Please note the PostreSQL UDF raise both @ERROR@ and @NOT... Igor Skornyakov

02:20 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

So far, so good...... Eric Faulhaber

01:06 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Eric Faulhaber wrote:
> Igor, can you think of a way to generate a list of the PostgreSQL built-in functions (includ... Igor Skornyakov

01:05 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Eric Faulhaber wrote:
> Greg Shah wrote:
>
> > I suspect that error handling will be a problem.
>
> I guess yo... Eric Faulhaber

01:01 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Eric Faulhaber wrote:
> What are the technical prerequisites a database implementation must have for word index su... Igor Skornyakov

01:01 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Greg Shah wrote:
> I suspect that error handling will be a problem.
I guess you're right, based on the answers ... Eric Faulhaber

12:55 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Igor, can you think of a way to generate a list of the PostgreSQL built-in functions (including signatures) upon whic... Eric Faulhaber

12:42 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Igor Skornyakov wrote:
> Please note also that it is makes sense to check how the words tables' support can be porte... Eric Faulhaber

12:40 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Looping in SQL can be simulated using "Common Table Expressions":https://en.wikipedia.org/wiki/Hierarchical_and_recur... Greg Shah

12:24 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

Please note also that it is makes sense to check how the words tables' support can be ported to MariaDB. Igor Skornyakov

12:11 PM Feature #6628: port PostgreSQL native user defined functions to MariaDB

We need a robust library of UDFs for MariaDB to represent 4GL built-in functions used in WHERE clauses, which referen... Eric Faulhaber

11:50 AM Feature #6628 (WIP): port PostgreSQL native user defined functions to MariaDB

Eric Faulhaber

12:07 PM Feature #6348: implement support for MariaDB

Greg Shah wrote:
> > Greg: I know Roger was keeping the documentation/license project up-to-date, but is there a wik... Ovidiu Maxiniuc

07:50 AM Feature #6348: implement support for MariaDB

> Greg: I know Roger was keeping the documentation/license project up-to-date, but is there a wiki with the steps nee... Greg Shah

04:00 AM Feature #6348: implement support for MariaDB

With 3821c/14095 change of build.gradle, this was added:... Constantin Asofiei

11:46 AM Feature #6582: implement multi-table AdaptiveQuery

Alexandru Lungu wrote:
> I got the time to familiarize myself with @AdaptiveQuery@. I understood the motivation for ... Eric Faulhaber

10:41 AM Feature #6582: implement multi-table AdaptiveQuery

I got the time to familiarize myself with @AdaptiveQuery@. I understood the motivation for the "adaptive" part, but n... Alexandru Lungu

10:07 AM Feature #6582: implement multi-table AdaptiveQuery

Alexandru Lungu wrote:
> Eric Faulhaber wrote:
> > Alexandru, please review the existing @AdaptiveQuery@ implementa... Eric Faulhaber

07/20/2022

07:53 PM Feature #6348: implement support for MariaDB

A first revision of FWD with partial support for MariaDb dialect was committed in 14095:
* the build script will fet... Ovidiu Maxiniuc

08:20 PM Feature #6348: implement support for MariaDB

Some observations on data types resulted from the attempt to create a (partial) database from generated DDL for Maria... Ovidiu Maxiniuc

04:51 AM Bug #6577 (Review): move RecordBuffer.ooFields at the DMO meta

3821c/14090 - RecordBuffer instance fields can not be accessed directly from static methods - their getter must be us... Constantin Asofiei

07/19/2022

03:20 PM Feature #6418: represent extent fields as arrays

Downsides of the JSON approach:
* The syntax is pretty messy since you have to use functions to access/set element... Greg Shah

01:57 PM Feature #6418: represent extent fields as arrays

Eric Faulhaber wrote:
> AFAICT, MariaDB offers no native array data type which can be assigned to a column. The re... Eric Faulhaber

12:55 PM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Greg Shah wrote:
> This is a reasonable restriction. Let's just make sure the limitation is clearly documented.
I a... Ovidiu Maxiniuc

11:53 AM Feature #6584 (Review): implement schema hint which generates a POJO in addition to a DMO interface

Greg Shah wrote:
> I made some minor edits to the doc. Please review.
Thank you for your contribution. I moved t... Ovidiu Maxiniuc

08:41 AM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

I made some minor edits to the doc. Please review. Greg Shah

08:36 AM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

I took a quick look at the docs. It looks good. Please move it to here:
"Using POJOs for Database Entities":/pro... Greg Shah

09:14 PM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

The documentation can be found at:
https://proj.goldencode.com/projects/timco/wiki/POJOs_-_Tutorial#section-8
I c... Ovidiu Maxiniuc

07/18/2022

02:30 PM Feature #6371: implement SAVE CACHE statement

Constantin Asofiei wrote:
> There is a compile error in 3821c/14083:
> [...]
>
> Boris: when committing somethin... Boris Schegolev

09:50 AM Feature #6371: implement SAVE CACHE statement

There is a compile error in 3821c/14083:... Constantin Asofiei

12:28 PM Bug #5673: Additional support for INDEXED REPOSITION open query attribute

The issue which required support for @INDEXED-REPOSITION@ was using a @REPOSITION-TO-ROWID@. I can't recall if this w... Alexandru Lungu

04:59 AM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

In 3821c/14082 I've added support for Java enums and, if there is no FWD serializer registered for the given type, de... Constantin Asofiei

07/16/2022

05:49 PM Feature #6348 (WIP): implement support for MariaDB

Started adding support for the new database by implementation of the @MariaDbDialect.java@. On Monday I will continue... Ovidiu Maxiniuc

07/15/2022

03:35 PM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Constantin,
I know you worked with JSON probably more than any of us. Do you have an API which serialize a POJOs an... Ovidiu Maxiniuc

01:38 PM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

I committed the (final ?) version of the POJO/DMO marshalling solution. Revision is 14075.
To summarize:
* the PO... Ovidiu Maxiniuc

09:13 AM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Constantin Asofiei wrote:
> I don't think is OK to be using the SQL types:
> * date/datetime/datetime-tz should all... Ovidiu Maxiniuc

12:14 AM Feature #6574 (Closed): auto-detect native UDFs at server startup and install them if missing

The changes in 3821c/14066 look good.
Note: to ensure missing native UDFs are installed, entries for @admin_userna... Eric Faulhaber

07/14/2022

07:23 PM Feature #6371: implement SAVE CACHE statement

Code review @6371.diff@:
The changes seem fine; looks like general code cleanup. Assuming they compile (I didn't a... Eric Faulhaber

03:59 PM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

I already committed the same fix (r14069).
Notice that, for the moment, the POJOs are not supported for temp datab... Ovidiu Maxiniuc

03:55 PM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Eric Faulhaber wrote:
> Ovidiu, I'm running a customer application (unrelated to this task). I launched a program wh... Eric Faulhaber

03:09 PM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Eric Faulhaber wrote:
> Ovidiu Maxiniuc wrote:
>
> > Are there other concerns about the types or generally about ... Eric Faulhaber

03:06 PM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Ovidiu, I'm running a customer application (unrelated to this task). I launched a program which tries to register a t... Eric Faulhaber

02:05 PM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Ovidiu Maxiniuc wrote:
> Are there other concerns about the types or generally about the implementation itself?
... Eric Faulhaber

01:46 PM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

This was my initial solution, where I tried to keep the same data types from FWD @Record@ (see #6584-15).
I will add... Ovidiu Maxiniuc

01:35 PM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

I don't think is OK to be using the SQL types:
* date/datetime/datetime-tz should all map to @java.util.GregorianCal... Constantin Asofiei

01:23 PM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Constantin, here it is. First the @.df@ content: {{collapse("tm-all" table)... Ovidiu Maxiniuc

01:59 AM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Ovidiu, please post the POJO for a table which has extent fields, blob, clob, etc (all data types). Constantin Asofiei

09:46 PM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Support for converting to/from POJOs was committed as r14064.
There are no hints (for the moment). The only way to... Ovidiu Maxiniuc

11:53 AM Feature #6574: auto-detect native UDFs at server startup and install them if missing

BTW: I think that right way to re-work @ScriptRunner@ for more dialects is to create its dialect-specific versions in... Igor Skornyakov

11:39 AM Feature #6574: auto-detect native UDFs at server startup and install them if missing

Eric Faulhaber wrote:
> Right, so let's just go with the additional comments for now, to make that refactoring easie... Igor Skornyakov

11:05 AM Feature #6574 (Review): auto-detect native UDFs at server startup and install them if missing

Right, so let's just go with the additional comments for now, to make that refactoring easier as we add UDF support i... Eric Faulhaber

11:01 AM Feature #6574: auto-detect native UDFs at server startup and install them if missing

Eric Faulhaber wrote:
> Code review @missing-udf.diff@:
>
> It seems this should work.
>
> Please note we will... Igor Skornyakov

10:43 AM Feature #6574: auto-detect native UDFs at server startup and install them if missing

Code review @missing-udf.diff@:
It seems this should work.
Please note we will have to support this feature for... Eric Faulhaber

06:16 AM Bug #6599: minimal mode conversion problem with DMO name collision

After the 6129a rebase, a table named "property" no longer converts as @property@ when @conversion="minimal"@ is set ... Constantin Asofiei

06:10 AM Bug #6599 (New): minimal mode conversion problem with DMO name collision

Constantin Asofiei

07/13/2022

03:14 PM Feature #6371 (WIP): implement SAVE CACHE statement

Boris Schegolev wrote (in email):
> My only question at the moment is how to simulate the desired state. I guess I... Eric Faulhaber

07/12/2022

02:38 PM Bug #6591: DMO collisions with converted program/legacy class name or FWD classes

If not too late, I think we can slightly adjust the DMO name using hints. Ovidiu Maxiniuc

07:14 AM Bug #6591 (WIP): DMO collisions with converted program/legacy class name or FWD classes

The the DMO collisions with converted Java class name is already solved by appending the @Program@ suffix (although t... Constantin Asofiei

06:40 AM Bug #6591: DMO collisions with converted program/legacy class name or FWD classes

In 3821c, there was a change which solved a camel-case issue - legacy tables names like @SomeTableName@ were converte... Constantin Asofiei

06:29 AM Bug #6591 (WIP): DMO collisions with converted program/legacy class name or FWD classes

Constantin Asofiei

12:00 PM Feature #6574: auto-detect native UDFs at server startup and install them if missing

Done. Please review.
Thank you. Igor Skornyakov

09:54 AM Feature #6574: auto-detect native UDFs at server startup and install them if missing

> This makes sense. We could add an @admin_username@ and @admin_password@ in the @.../database/<database_name>/orm/co... Igor Skornyakov

09:53 AM Feature #6574: auto-detect native UDFs at server startup and install them if missing

Igor Skornyakov wrote:
> Another problem is with creation of the @udf@ schema. The @create schema if not exists udf@... Eric Faulhaber

09:49 AM Feature #6574: auto-detect native UDFs at server startup and install them if missing

Igor Skornyakov wrote:
> There is a problem with "on the fly" creation of native UDFs.
> Many of them a declared as... Eric Faulhaber

08:14 AM Feature #6574: auto-detect native UDFs at server startup and install them if missing

Another problem is with creation of the @udf@ schema. The @create schema if not exists udf@ statament also can be exe... Igor Skornyakov

07:48 AM Feature #6574: auto-detect native UDFs at server startup and install them if missing

There is a problem with "on the fly" creation of native UDFs.
Many of them a declared as "leakproof" but such UDFs c... Igor Skornyakov

11:05 AM Feature #6348: implement support for MariaDB

Ovidiu Maxiniuc wrote:
> It has a PL language somewhat similar to PSQL.
I followed the CREATE FUNCTION doc link y... Eric Faulhaber

09:26 AM Feature #6582 (WIP): implement multi-table AdaptiveQuery

Eric Faulhaber wrote:
> Alexandru, please review the existing @AdaptiveQuery@ implementation and consider how we mig... Alexandru Lungu

09:24 AM Feature #6582: implement multi-table AdaptiveQuery

Alexandru, please review the existing @AdaptiveQuery@ implementation and consider how we might go about extending/rew... Eric Faulhaber

07:16 AM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Even if we want to allow for only a subset of the DMOs to get POJOs, we should make it easy to generate POJOs for all... Greg Shah

11:28 PM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Eric Faulhaber wrote:
> I thought we had discussed not using reflection and instead having default implementations... Eric Faulhaber

11:24 PM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Ovidiu Maxiniuc wrote:
> I have implemented the marshalling methods between POJO and DMO. Here are the important hig... Eric Faulhaber

11:08 PM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

Ovidiu Maxiniuc wrote:
> I added the setters and performed more class polishing, like the initialization of extent f... Eric Faulhaber

09:14 PM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

I have implemented the marshalling methods between POJO and DMO. Here are the important highlights:
* the @Record@ h... Ovidiu Maxiniuc

07/11/2022

12:54 PM Feature #6371: implement SAVE CACHE statement

Boris Schegolev wrote:
> As I was writing, Eric added the above specs, answering most of my questions :)
>
> A fe... Eric Faulhaber

12:06 PM Feature #6371: implement SAVE CACHE statement

As I was writing, Eric added the above specs, answering most of my questions :)
A few points from my side:
# Th... Boris Schegolev

11:50 AM Feature #6371: implement SAVE CACHE statement

This feature is only for use with specially designated databases, whose schemas are mutable. These are special purpos... Eric Faulhaber

08:33 AM Feature #6584: implement schema hint which generates a POJO in addition to a DMO interface

> I was thinking of a switch in p2j.cfg.xml for turning their generation on or off (as opposed to individual hints)
... Greg Shah