Project

General

Profile

Activity

From 08/24/2023 to 09/22/2023

09/22/2023

02:31 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
The latest revision of @import.sh@ is checked into the branch:... Roger Borrello
01:13 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Thanks, Ovidiu. I was following the MariaDB setup from @build_db.xml@ in hotel_gui. I'll update that. Right now my @i... Roger Borrello
08:33 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
> Should the user ID for the PatternEngine be fwd_admin?
Not mandatory. @fwd_user@ does not have enough privileges g...
Ovidiu Maxiniuc
12:12 PM Bug #7836: explicit buffer scope when defined at external program and used in an internal entry
This is an existing issue:... Constantin Asofiei
12:11 PM Bug #7836 (New): explicit buffer scope when defined at external program and used in an internal e...
Constantin Asofiei
11:18 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
I've looked at the CompoundQuery in the trunk.
For me this check for CONTAINS looks oversimplified:
# The @where@...
Igor Skornyakov
10:46 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
In what branch can I find these changes?
Thank you.
Igor Skornyakov
09:35 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
I started by looking first at the part of this task related to @CONTAINS@ and run-time optimization of multiple @Comp... Andrei Bălteanu

09/21/2023

03:19 AM Feature #6496 (Review): add equivalent support for -trig command line option
Commited branch #6496a on rev. 14743 and 14744,
with necessary changes to support -trig parameter for searching a s...
Alexandru Donica
03:02 AM Bug #7797: FWD-H2 LAZY reverse index regression
This turned out to be quite a massive set of changes. While doing some tests I noticed things that were not in order ... Radu Apetrii
09:47 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
With some updates to my @import.sh@, I am close with mariadb:... Roger Borrello
08:55 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> Some things I need clarification with respect to Maria:
> * Do I need to create a @fwd_user...
Ovidiu Maxiniuc

09/20/2023

07:29 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
I checked in an updated @import.sh@ which works with H2. I am still testing with Maria, which I just attempted.
So...
Roger Borrello
06:08 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
I am updating the @import.sh@ script to handle all the DBs... on H2, to create the database, there are not separate c... Roger Borrello
04:14 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Try https://proj.goldencode.com/projects/p2j/wiki/Database_Server_Setup_for_MariaDb_on_Linux.
I am sure I did the ...
Ovidiu Maxiniuc
04:06 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Igor Skornyakov wrote:
> I do not know how this can happen. Word tables for H2 are not supposed to be implemented be...
Roger Borrello
03:40 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> Igor Skornyakov wrote:
> > This can happen only if your @build_db.xml@ contains a correspon...
Igor Skornyakov
03:34 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Igor Skornyakov wrote:
> This can happen only if your @build_db.xml@ contains a corresponding @ScriptRunner@ call.
...
Roger Borrello
03:26 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> The updates to prevent an unneeded DDL from being generated if the dialect does not use them...
Igor Skornyakov
03:13 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
The updates to prevent an unneeded DDL from being generated if the dialect does not use them is why there isn't any H... Roger Borrello
12:18 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu Maxiniuc wrote:
> Roger Borrello wrote:
> > Branch 4722a has been rebased to the latest trunk (14745). It is...
Igor Skornyakov
11:21 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> Branch 4722a has been rebased to the latest trunk (14745). It is at revision 14758. Ovidiu a...
Ovidiu Maxiniuc
08:24 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> @prepare_template.sh@ is only used for turning Hotel GUI into a template for a new application. ...
Roger Borrello
06:33 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
@prepare_template.sh@ is only used for turning Hotel GUI into a template for a new application. You would only ever ... Greg Shah
06:11 PM Bug #7821: Duplication of table records in schema namespace causes dynamic conversion to fail
I found that the schema dictionary is created and the private @nodes@ @List@ is populated, in certain conditions, the... Ovidiu Maxiniuc
05:46 PM Bug #7821 (New): Duplication of table records in schema namespace causes dynamic conversion to fail
Ovidiu Maxiniuc

09/19/2023

07:37 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
There are two events in your log:
# @data/standard.dict@ is not found in jar. In this case, FWD will try to find it ...
Ovidiu Maxiniuc
07:36 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722a has been rebased to the latest trunk (14745). It is at revision 14758. Ovidiu and Igor, can you confirm ... Roger Borrello
07:31 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Eric Faulhaber wrote:
> Is @prepare_template.sh@ a requirement now? TBH, I haven't kept up with every change in thes...
Roger Borrello
06:59 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Hmm... I checked out revision 273, ran the @./prepare_template.sh -n < hotel.input.linux.pg@ and got a successful bui... Roger Borrello
06:41 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> Thanks, Eric. Did you run any @prepare_template.sh@ varieties?
No, this was an update of ...
Eric Faulhaber
06:37 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> I didn't see any particular problems building. What stage should they be logged at? Log atta...
Eric Faulhaber
06:36 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Thanks, Eric. Did you run any @prepare_template.sh@ varieties? Roger Borrello
06:27 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
I just updated to the latest Hotel GUI project (rev 273) and ran @ant clean deploy.all@, using FWD trunk rev 14723. M... Eric Faulhaber
06:21 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
I didn't see any particular problems building. What stage should they be logged at? Log attached. Roger Borrello
06:06 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Never mind. I found this in the @hotel.df@ for Hotel GUI:... Eric Faulhaber
06:03 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> I committed an updated @import.sh@ to this branch which allows for the tables to be built wi...
Eric Faulhaber
05:07 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
I committed an updated @import.sh@ to this branch which allows for the tables to be built without the logging warning... Roger Borrello
03:30 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
The chances are these were added by me when debugging various pieces of code. Certainly, they are not a problem in ho... Ovidiu Maxiniuc
02:50 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Yes, I think we should not need the @logging.properties@.
There are also 3 instances of debug ...
Roger Borrello
02:20 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Yes, I think we should not need the @logging.properties@. Greg Shah
02:19 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> As soon as you require @logging.properties@ there is now a 2nd way to configure logging and it is...
Roger Borrello
11:05 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
As soon as you require @logging.properties@ there is now a 2nd way to configure logging and it is incompatible with o... Greg Shah
10:56 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> I don't think it opens pandora's box to assume that all our dependent libraries are in the same d...
Roger Borrello
10:48 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
I don't think it opens pandora's box to assume that all our dependent libraries are in the same directory. That is t... Greg Shah
10:47 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
> Is that for sure next to @p2j.jar@?
In all cases today which I know of, yes.
Greg Shah
10:44 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Did you try to include @fwd-slf4j.jar@ in the classpath (described in the documentation)?
Is t...
Roger Borrello
10:20 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Did you try to include @fwd-slf4j.jar@ in the classpath (described in the documentation)? Greg Shah
10:09 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> We definitely don't want to put properties files all over the place.
>
> [[p2j:Logging#Interfe...
Roger Borrello
09:58 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
> For the @SLF4J@ issue, I included the @cfg/logging.properties@ in the @hotel.jar@, and specified @-Djava.util.loggi... Greg Shah
09:41 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Igor Skornyakov wrote:
> The problem caused by the fact that DDL scripts for the @hotel@ projects had DOS line endin...
Roger Borrello
04:50 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> Roger Borrello wrote:
> > It hangs here, and does not proceed.
>
> I noticed I was using...
Igor Skornyakov
08:15 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
I noticed the quotes around the @$db_url@. I do not think that is the main cause, but I am sure they are not removed ... Ovidiu Maxiniuc

09/18/2023

06:19 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> It hangs here, and does not proceed.
I noticed I was using @fwd_admin@ instead of @fwd_us...
Roger Borrello
06:17 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
I am working on updating the import script to utilize the new options for building the database tables. I am receivin... Roger Borrello

09/15/2023

10:37 AM Bug #7797: FWD-H2 LAZY reverse index regression
*Review:*
* You made sortUsingReversedIndex by default true. I don't think this is right!
* For ReversedRes...
Alexandru Lungu
06:30 AM Bug #7797: FWD-H2 LAZY reverse index regression
I put some thought into this and tried a couple of things and I think (or hope at least) that I've reached a pretty "... Radu Apetrii
10:30 AM Feature #6628: port PostgreSQL native user defined functions to MariaDB
Eric: Please review. Greg Shah
10:30 AM Bug #6767: Possible name clashes in DMO classes
Eric: Please review. Greg Shah
10:28 AM Bug #6812: fix FastFindCache to use a shared instance per persistent database
How do we move this along? Greg Shah
10:27 AM Feature #7020: always use "expanded" extent fields
Eric: Please review. Greg Shah
09:03 AM Feature #7802: implement INACTIVE index support
This task is meant to provide support for the @INACTIVE@ schema value in an index definition (in a @.df@) file. In #... Greg Shah
09:01 AM Feature #7802 (New): implement INACTIVE index support
Greg Shah

09/14/2023

08:09 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Sorry, my bad. Alexandru Lungu
05:36 AM Bug #7797: FWD-H2 LAZY reverse index regression
Radu Apetrii wrote:
> This might turn out to be more messy than I hoped. I was right saying that the changes are the...
Alexandru Lungu
05:19 AM Bug #7797: FWD-H2 LAZY reverse index regression
This might turn out to be more messy than I hoped. I was right saying that the changes are there, but it's a bit more... Radu Apetrii
03:30 AM Bug #7797: FWD-H2 LAZY reverse index regression
I don't have an example yet.
Attempt to make something like @FOR EACH tt BY tt.f1 DESC@, while you have an @ASC@ i...
Alexandru Lungu
03:10 AM Bug #7797: FWD-H2 LAZY reverse index regression
I'm on it. I think I already have the changes necessary, but they need to be added to 7066c_h2 (which I will create v... Radu Apetrii

09/13/2023

11:55 AM Bug #7641: Lower the number of Map.get() calls in the persistence layer
Alexandru Lungu wrote:
> As this doesn't provide consistent improvements in this state, I am pending this for furthe...
Constantin Asofiei
10:22 AM Bug #7641: Lower the number of Map.get() calls in the persistence layer
Done some improvements and committed 7641a / rev. 14721. I didn't expect to have that many (new) instances of @Static... Alexandru Lungu
10:47 AM Feature #7066: Implement multi-table indexed query in H2
> No, but it was quite straight-forward to solve that test. I committed to 7066b_h2, rev. 28.
Great news.
Merge...
Alexandru Lungu
05:26 AM Feature #7066: Implement multi-table indexed query in H2
Alexandru Lungu wrote:
> I am OK with the changes. The regression tests are ok. Does this also solve #7776?
No, but...
Radu Apetrii
04:46 AM Feature #7066: Implement multi-table indexed query in H2
I am OK with the changes. The regression tests are ok. Does this also solve #7776?
Radu, *please extend your regress...
Alexandru Lungu
04:30 AM Feature #7066: Implement multi-table indexed query in H2
Done. I committed to *7066b_h2, rev. 27* changes that target the behavior of @lazy@ when using @previous()@. I tried ... Radu Apetrii
02:59 AM Feature #7066: Implement multi-table indexed query in H2
Greg Shah wrote:
> Since 7066a_h2 is needed to fix a bug (regression?) that causes #7666 (and several other related ...
Radu Apetrii
10:45 AM Bug #7797: FWD-H2 LAZY reverse index regression
... Alexandru Lungu
10:37 AM Bug #7797 (Closed): FWD-H2 LAZY reverse index regression
Alexandru Lungu
09:43 AM Bug #7793: incremental conversion with deleted table from .df
Ovidiu Maxiniuc wrote:
> I have only one unknown thing: at runtime, how do we decide which is the timestamp which ma...
Constantin Asofiei
09:37 AM Bug #7793: incremental conversion with deleted table from .df
I think of the following solution:
* add a conversion timestamp to DMOs (as an annotation). This might be useful for...
Ovidiu Maxiniuc
08:22 AM Bug #7793: incremental conversion with deleted table from .df
The current solutions for a customer were:
* delete all artifacts for this table manually (from src/, build/, other ...
Constantin Asofiei
07:42 AM Bug #7793: incremental conversion with deleted table from .df
We don't support incremental conversion when the schema changes. This is expected to fail. Greg Shah
11:57 PM Bug #7793: incremental conversion with deleted table from .df
Ovidiu, the scenario is this:
* full conversion uses table Book with dump-name 'paper'.
* incremental conversion re...
Constantin Asofiei
05:30 AM Bug #7776: Previous regression on FWD-H2 lazy mode
Alexandru Lungu wrote:
> If that is the case, note that @beforeLast@ can be reset back to @false@ if we ever do @nex...
Radu Apetrii
04:59 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
Merged 7535a_h2/rev.27 into FWD-H2 trunk as rev. 27 and archived. Alexandru Lungu

09/12/2023

07:25 PM Bug #7788: NPE when assigning query to browse
Let me put my thoughts. Is it a browse issue? Yes and no.
First, if you try this code:...
Stanislav Lomany
11:10 AM Bug #7788: NPE when assigning query to browse
> Maybe they were tested individually and the actual operator is || instead of &&?
This was exactly what I thought...
Alexandru Lungu
10:32 AM Bug #7788: NPE when assigning query to browse
Alexandru Lungu wrote:
> There are two issues here:
> * The browse is not dynamic, so @_dynamic@ returns @false@. I...
Ovidiu Maxiniuc
08:18 AM Bug #7788: NPE when assigning query to browse
That part is not quite relevant for the test-case. The following is also problematic:... Alexandru Lungu
07:26 AM Bug #7788: NPE when assigning query to browse
Nice catch!
It seems like the query from @new-query-handle@ is not properly initialized. I did not run the testcase ...
Ovidiu Maxiniuc
04:42 AM Bug #7788: NPE when assigning query to browse
This code works in 4GL, but after conversion it throws a NullPointerExpression.... Alexandru Donica
03:47 AM Bug #7788 (New): NPE when assigning query to browse
Alexandru Donica
05:45 PM Bug #7793: incremental conversion with deleted table from .df
I am not sure I understand. Please correct me if I am wrong.
We have an initial conversion over a .df which contai...
Ovidiu Maxiniuc
12:02 PM Bug #7793: incremental conversion with deleted table from .df
If an incremental conversion is done with a .df file which removes a table, the DMO remains in place, both as .java a... Constantin Asofiei
11:48 AM Bug #7793 (Closed): incremental conversion with deleted table from .df
Constantin Asofiei
04:52 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Review of 4722a, up to 14738.
I am generally OK with the code. Just a few notes to add:
Globally:
* the module...
Ovidiu Maxiniuc
03:08 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu: Please review. Greg Shah
11:33 AM Bug #7641: Lower the number of Map.get() calls in the persistence layer
I continued improving 7641a, which is now at rev. 14720. Basically, I moved @SchemaHelper@ to persist, instead of orm... Alexandru Lungu
10:30 AM Feature #7066: Implement multi-table indexed query in H2
Since 7066a_h2 is needed to fix a bug (regression?) that causes #7666 (and several other related tasks), what is the ... Greg Shah
07:58 AM Bug #7731: performance improvements for FQLPreprocessor
Dănuț Filimon wrote:
> So I should leave the cache size to *512k* instead of *8192* and wait for #7767 to be complet...
Constantin Asofiei
07:50 AM Bug #7731: performance improvements for FQLPreprocessor
Constantin Asofiei wrote:
> The total number of cache hits (or misses). Set the cache number to something large (li...
Dănuț Filimon
07:21 AM Bug #7731: performance improvements for FQLPreprocessor
Dănuț Filimon wrote:
> I will test it right away but is the number of calls the only information that you want to kn...
Constantin Asofiei
06:58 AM Bug #7731: performance improvements for FQLPreprocessor
Constantin Asofiei wrote:
> For #7767, there are ~280k of @HQLParser.expression@ calls, which in turn create some 94...
Dănuț Filimon
06:45 AM Bug #7731: performance improvements for FQLPreprocessor
Dănuț Filimon wrote:
> The problem with using simple @FIND FIRST@ statements is that if I want to use a counter vari...
Constantin Asofiei
06:39 AM Bug #7731: performance improvements for FQLPreprocessor
Constantin Asofiei wrote:
> I don't think longer where clauses will show much - try to build a test having 100s/1000...
Dănuț Filimon
05:01 AM Feature #6496 (WIP): add equivalent support for -trig command line option
Alex, please handle this now. There is some insight in spr and proghand documentations, but quite minimal.
Attempt t...
Alexandru Lungu

09/11/2023

11:00 AM Bug #7731: performance improvements for FQLPreprocessor
Dănuț Filimon wrote:
> I want to test a customer application to see if the current size of the LRUCache (8196) is en...
Constantin Asofiei
08:57 AM Bug #7731: performance improvements for FQLPreprocessor
*Committed 7731a/rev.14733*. Added the initial implementation for the HQLAst cache.
* The cache will be created usin...
Dănuț Filimon
08:27 AM Bug #7731: performance improvements for FQLPreprocessor
I want to test a customer application to see if the current size of the LRUCache (8192) is enough and increase it if ... Dănuț Filimon
08:18 AM Bug #7731: performance improvements for FQLPreprocessor
Constantin Asofiei wrote:
> Danut, just to be clear, I'm referring to the HQL AST returned by this code:
> [...]
>...
Dănuț Filimon
08:13 AM Bug #7731: performance improvements for FQLPreprocessor
Danut, just to be clear, I'm referring to the HQL AST returned by this code:... Constantin Asofiei
08:07 AM Bug #7731: performance improvements for FQLPreprocessor
Dănuț Filimon wrote:
> One problem with the cache implementation is that when we have two dynamic queries, one with ...
Dănuț Filimon
07:57 AM Bug #7731: performance improvements for FQLPreprocessor
The @FQLPreprocessor@ will always use the cache when the dialect is @P2JH2Dialect@ because of the @inline = inline &&... Dănuț Filimon
05:56 AM Bug #7389: Make fast-copy statements cachable
Committed 7404a to trunk as rev. 14730. Alexandru Lungu
05:55 AM Bug #7488 (Test): Slow fast-copy with before tables in H2
Committed 7404a to trunk as rev. 14730. Alexandru Lungu
04:36 AM Bug #7641 (Review): Lower the number of Map.get() calls in the persistence layer
I committed 7641a rev. 14716 and 14717 with some improvements, including the use of Java array instead of ArrayList. ... Alexandru Lungu

09/10/2023

12:27 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Added H2 support in ScriptRunner.
Committed to 4722a/14738.
All changes to the ScriptRunner are done now.
Please...
Igor Skornyakov
05:17 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Igor Skornyakov wrote:
> Ovidiu Maxiniuc wrote:
> > The statement for dropping the index is @getDropIndexString()@ ...
Igor Skornyakov

09/08/2023

04:52 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu Maxiniuc wrote:
> The statement for dropping the index is @getDropIndexString()@ for each @Dialect@. If you l...
Igor Skornyakov
04:36 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
The statement for dropping the index is @getDropIndexString()@ for each @Dialect@. If you look at @MariaDbLenientDial... Ovidiu Maxiniuc
03:18 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> > I understand that on the "normal" database creation the @schema...
Igor Skornyakov
03:02 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Igor Skornyakov wrote:
> I understand that on the "normal" database creation the @schema_index_${dbname}_${dialect}....
Ovidiu Maxiniuc
02:34 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
I've noticed the following.
If I use @<parameter name="ddl-dialects" value="h2,postgresql,mariadblenient" />@ in the...
Igor Skornyakov
02:27 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Add support for more SQL script types for PostgreSQL and MariaDB.
Committed to 4722/14735.
New commands are *create...
Igor Skornyakov
07:41 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
I understand that on the "normal" database creation the @schema_index_${dbname}_${dialect}.sql@ DDL script is not use... Igor Skornyakov
09:33 AM Feature #6720: lazy hydration
> I found tons of examples where static inference of @FIELDS@ clause would make lazy hydration less appealing.
My ...
Greg Shah
08:43 AM Feature #6720: lazy hydration
I've reread this issue and refreshed my mind. There are some key observations before moving on:
* Eric, 6720b exis...
Alexandru Lungu

09/07/2023

09:59 AM Bug #7776: Previous regression on FWD-H2 lazy mode
... Alexandru Lungu
09:39 AM Bug #7776 (Closed): Previous regression on FWD-H2 lazy mode
Alexandru Lungu
09:04 AM Feature #7404 (Test): Trasform replace-mode into append-mode when target table is empty
Committed 7404a to trunk as rev. 14730. Alexandru Lungu
08:02 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty
Starting the rebase; I will notify you when ready. Alexandru Lungu
06:54 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty
If you are ready, you can go ahead with the merge now. Greg Shah
02:47 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty
OK. Alexandru Lungu

09/06/2023

12:28 PM Feature #7404: Trasform replace-mode into append-mode when target table is empty
Merged is postponed for tomorrow - please coordinate with Greg before queuing for merge. Constantin Asofiei
10:58 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty
Constantin Asofiei wrote:
> I'll do a round of ETF tests.
ETF tests is OK. Actually, it fixes a test which previou...
Constantin Asofiei
09:34 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty
Fixed the history numbers. I tested today the performance and I had 7 runs: some with 0.9% - 1.5% perf. improvement a... Alexandru Lungu
09:15 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty
Alexandru, do you have a round of performance testing with 7156b + 7404a? I ask because #7404-28 notes a performance... Constantin Asofiei
08:53 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty
I'll do a round of ETF tests.
In the mean time, please fix the history numbers - one per file, for the very first ...
Constantin Asofiei
10:36 AM Bug #7731: performance improvements for FQLPreprocessor
The cache is meant to be on the FQL string, before the parse is performed - there is no buffer reference (i.e. semant... Constantin Asofiei
10:34 AM Bug #7731: performance improvements for FQLPreprocessor
If we create a @HQLAst@ cache and I assume that we want to access and populate it in @FQLPreprocessor.parse()@, won't... Dănuț Filimon
09:49 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
This branch was rebased to @trunk_14728@ and is now at revision @14734@. Roger Borrello
08:13 AM Bug #7496: finish support for query:forward-only attribute
Alexandru Lungu wrote:
> Danut, as a debugging hint, I downloaded the PG driver sources and debugged them when @Resu...
Dănuț Filimon
04:55 AM Bug #7496: finish support for query:forward-only attribute
Danut, as a debugging hint, I downloaded the PG driver sources and debugged them when @ResultSet.next@ was called. Th... Alexandru Lungu
04:39 AM Bug #7496: finish support for query:forward-only attribute
The dump was done using @TYPE_SCROLL_INSENSITIVE@ and @ForwardResults@ wasn't used, I had to modify he original dump ... Dănuț Filimon
03:03 AM Bug #7496: finish support for query:forward-only attribute
Dănuț Filimon wrote:
> I dumped the customer application database in *9 hours and 17 minutes*. While monitoring the ...
Alexandru Lungu
02:35 AM Bug #7496: finish support for query:forward-only attribute
I dumped the customer application database in *9 hours and 17 minutes*. While monitoring the CPU and Memory using Vis... Dănuț Filimon
07:00 AM Feature #6371 (Closed): implement SAVE CACHE statement
Greg Shah

09/05/2023

04:01 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Found the key... during the post-init phase of the postgres image startup, all connections have to be Unix sockets. T... Roger Borrello
10:51 AM Bug #7488 (Review): Slow fast-copy with before tables in H2
I've done a second commit on 7404a removing more mutable data and making the solution more stable (rev. 14663). Now I... Alexandru Lungu
05:41 AM Bug #7488: Slow fast-copy with before tables in H2
Alexandru Lungu wrote:
> I made this change in 7404a/rev. 14662. Radu, please review.
The changes make sense, it wa...
Radu Apetrii
05:19 AM Bug #7488: Slow fast-copy with before tables in H2
*Radu, in 7404a, the immutable and mutable data still not independent from each other:*
* In @FastCopyHelper.execute...
Alexandru Lungu
08:24 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
I retested a customer application and used VisualVM to keep track of any @pendingReclaimedKeys@ and @reclaimedKeys@ l... Dănuț Filimon
06:48 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
> I tested 7535c using a customer application and there is an issue with direct-access. Now, temp-tables will have a ... Dănuț Filimon

09/04/2023

06:29 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
I created a postgres image containing the FWD convert deployment. All the libraries that are required to run the @Scr... Roger Borrello
11:28 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
This branch has been rebased to trunk_14724 and is now at revision 14728. Roger Borrello
09:55 AM Bug #7496: finish support for query:forward-only attribute
> The current problem is with the incremental version which I finally made it work, but even after making sure that n... Dănuț Filimon
06:45 AM Bug #7496: finish support for query:forward-only attribute
Rebased 7496a to trunk and is now at rev. 14732. Alexandru Lungu
08:58 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
I tested 7535c using a customer application and there is an issue with direct-access. Now, temp-tables will have a tr... Dănuț Filimon
06:21 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
Rebased 7535c with latest trunk and is now at rev. 14725. Alexandru Lungu
06:05 AM Bug #7731 (WIP): performance improvements for FQLPreprocessor
Danut, please do some investigation here - you have some consistent background with @FQLPreprocessor@ and inlining :)... Alexandru Lungu
04:00 AM Bug #7488: Slow fast-copy with before tables in H2
Dănuț Filimon wrote:
> Alexandru Lungu wrote:
> > Danut, did you had some correctness tests with fast-copy at some ...
Radu Apetrii

09/03/2023

02:28 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
It appears that @ScriptRunner@ requires more re-working than I've expected initially. In particular DDL scripts for t... Igor Skornyakov

09/02/2023

10:48 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Ovidiu: What additional testing is needed?
I meant testing whether the @ScriptRunner@ could be u...
Ovidiu Maxiniuc

09/01/2023

07:01 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
In revisiting getting the postgres image augmented to be able to run the data import internally, we have to install J... Roger Borrello
01:27 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> If you are using the latest @hotel_gui@ project, and the latest @4722a@, you should be able ...
Igor Skornyakov
01:25 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Igor Skornyakov wrote:
> > I see the following message on the database import fron the @holel-gu...
Igor Skornyakov
01:24 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> > Please note also that at this moment @ScriptRunner@ works only with @PostgreSQL@ and @MariaDB@ ...
Igor Skornyakov
12:55 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
If you are using the latest @hotel_gui@ project, and the latest @4722a@, you should be able to run: @./p2j/import.sh ... Roger Borrello
12:28 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Igor Skornyakov wrote:
> I see the following message on the database import fron the @holel-gui@:
> [...]
> It see...
Greg Shah
12:27 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
> Please note also that at this moment @ScriptRunner@ works only with @PostgreSQL@ and @MariaDB@ since @H2@ UDFs are ... Greg Shah
11:20 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
I see the following message on the database import fron the @holel-gui@:... Igor Skornyakov
11:04 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Some changes in the @ScriptRunner@ configuration logic are required.
Working on this.
Please note also that at this...
Igor Skornyakov
09:42 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Application-specific DDL (for creating databases and indices) will be found in the application ja...
Igor Skornyakov
09:41 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Application-specific DDL (for creating databases and indices) will be found in the application jar.
All changes go...
Greg Shah
09:33 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
One more questions.
Should I use 4722a branch for this task?
Thank you.
Igor Skornyakov
09:27 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Igor: Please go ahead with this change. Assume that the DDL is available in the jar in a known l...
Igor Skornyakov
09:09 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Igor: Please go ahead with this change. Assume that the DDL is available in the jar in a known location. Greg Shah
09:01 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> > Even if there were an enhancement to have ScriptRunner be able to execute the DDL,
>
> The D...
Igor Skornyakov
08:40 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
> Even if there were an enhancement to have ScriptRunner be able to execute the DDL,
The DDL definitely should be ...
Greg Shah
08:38 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Roger: Based on your testing, there anything else needed in this task?
From my perspective, no...
Roger Borrello
08:34 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Eric: This is still waiting for review.
Ovidiu: What additional testing is needed?
Roger: Based on your testing...
Greg Shah
09:14 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
I've replaced the @hotel-import.sh@ with @import@ that now utilizes the *p2j.jar* and *app.jar*. There is a new requi... Roger Borrello
02:10 AM Bug #7488: Slow fast-copy with before tables in H2
Alexandru Lungu wrote:
> Danut, did you had some correctness tests with fast-copy at some point? Can you share them ...
Dănuț Filimon

08/31/2023

11:15 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
> Branch was rebased to trunk_14721 and is at revision 14722. I noticed there were many spelling/formatting updates i... Greg Shah
11:07 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch was rebased to trunk_14721 and is at revision 14722. I noticed there were many spelling/formatting updates in ... Roger Borrello
09:05 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Any objections to me rebase-ing to the latest trunk? My checkout is at revision 14663. No pending changes to commit t... Roger Borrello
09:58 AM Bug #7488: Slow fast-copy with before tables in H2
The changes are very close to state-of-the-art in 7404a. Very good job, Radu!
* Please rename @PK__MAPPING@ into @...
Alexandru Lungu
09:47 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
Alexandru Lungu wrote:
> * You call @if (!isUndoable()) { reclaimKeys();}@ Note that this will reclaim all keys acro...
Dănuț Filimon
07:17 AM Bug #7496: finish support for query:forward-only attribute
Personal tests and customer application were tested previously. I've retested them just to make sure, but I was not s... Dănuț Filimon
04:22 AM Bug #7731: performance improvements for FQLPreprocessor
Alexandru, I think this can help - can you take a look at it? Constantin Asofiei

08/30/2023

09:39 AM Bug #7535 (Review): Temporary tables require trailing recid component even for unique indexes
Danut, I am mostly OK with the changes in 7535c.
* You call @if (!isUndoable()) { reclaimKeys();}@ Note that this ...
Alexandru Lungu
08:09 AM Bug #7488: Slow fast-copy with before tables in H2
I applied the bullets from #7488-28 and committed to 7404a, rev. 14660. In addition to that, I also merged the two @p... Radu Apetrii
04:19 AM Bug #7488: Slow fast-copy with before tables in H2
Radu Apetrii wrote:
> The only relevant purpose at the moment for @isBefore@ would be bullet 2 from the list above. ...
Alexandru Lungu
04:06 AM Bug #7488: Slow fast-copy with before tables in H2
Alexandru Lungu wrote:
> * There is quite some logic around @isBefore@ inside @executeCopy@. Can you summarize it he...
Radu Apetrii
05:12 AM Bug #7567: use Session.PK instead of DatabaseManager.PRIMARY_KEY wherever possible
*Committed 7567a/rev.14714 and 7567a_h2/rev.27*. Removed DatabaseManager.PRIMARY_KEY and replaced it's usage with Ses... Dănuț Filimon
04:31 AM Bug #7496 (Review): finish support for query:forward-only attribute
Danut, please let me know if there is something left in this task.
Please do a full round of testing with this:
*...
Alexandru Lungu
04:00 AM Bug #7641: Lower the number of Map.get() calls in the persistence layer
Committed refactoring the code on 7641a revision 14715.
Eduard Soltan

08/29/2023

10:45 AM Bug #7488: Slow fast-copy with before tables in H2
*Review of 7404a*
* You don't actually need @FastCopyContext.newInstance@ - you can call the constructor directly....
Alexandru Lungu
06:57 AM Feature #7447 (Closed): Compare ValueString and ValueStringIgnoreCase faster in FWD-H2
Greg Shah
03:32 AM Feature #7447 (Review): Compare ValueString and ValueStringIgnoreCase faster in FWD-H2
Ok, this can be closed then - let me know if there is something left here to discuss Alexandru Lungu
03:29 AM Feature #7447: Compare ValueString and ValueStringIgnoreCase faster in FWD-H2
Great news! I retested the customer application using a different approach which allowed me to test it a lot faster a... Dănuț Filimon

08/28/2023

02:27 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
@ScriptRunner@ currently only accepts the commands:
* @udf.install@
* @udf.install.search_path@
It would need ...
Eric Faulhaber
01:58 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu Maxiniuc wrote:
> I think the @build.xml@ is only modified to allow the packaging of the @ddl@ scripts inside...
Roger Borrello
01:52 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
I think the @build.xml@ is only modified to allow the packaging of the @ddl@ scripts inside the app's jar file.
On...
Ovidiu Maxiniuc
01:40 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
That is all understood... and @import.sh@ allows you to perform an import with only the @p2j.jar@, the @app.jar@ and ... Roger Borrello
01:04 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Customers need to be able to deploy without a project installation. Optimally, the solution would only require the F... Greg Shah
12:02 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
If this tool cuts the muster, should it be part of FWD versus something given to the customers for use in their appli... Roger Borrello
10:24 AM Bug #7641: Lower the number of Map.get() calls in the persistence layer
Rebased 7641a to trunk. 14711. Alexandru Lungu
09:36 AM Feature #7447: Compare ValueString and ValueStringIgnoreCase faster in FWD-H2
Alexandru Lungu wrote:
> Danut, please check if this is still happening after your changes in #7454. Of course, befo...
Dănuț Filimon
08:17 AM Bug #7488: Slow fast-copy with before tables in H2
Alexandru Lungu wrote:
> Radu Apetrii wrote:
> > The problem with this is that @TemporaryBuffer.copyAllRows@ is a *...
Radu Apetrii
08:07 AM Bug #7488: Slow fast-copy with before tables in H2
Radu Apetrii wrote:
> The problem with this is that @TemporaryBuffer.copyAllRows@ is a *static* method, so I don't h...
Alexandru Lungu
06:03 AM Bug #7488: Slow fast-copy with before tables in H2
I've applied the suggestions from the last post (except one) and committed to 7404a, rev. 14658.
Alexandru Lungu w...
Radu Apetrii
08:05 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
Alexandru Lungu wrote:
> Danut, please push on 7535c (newly created) a sound solution. Most important is to allow re...
Dănuț Filimon
07:16 AM Feature #7064 (Rejected): Analyze the performance impact of the implicit meta schema in H2
Greg Shah
03:56 AM Feature #7064: Analyze the performance impact of the implicit meta schema in H2
* When you open a session and create a database, you reach @Database.open@, which calls @Database.addDatabaseObject@.... Alexandru Lungu

08/25/2023

10:46 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
> It is not completely clear to me what your conclusions are regarding persistent tables. I would like to avoid attem... Alexandru Lungu
10:20 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
Alexandru Lungu wrote:
> In the last 2 examples, in practice, there are other recids (1491 instead of 1488, etc.)....
Eric Faulhaber
10:38 AM Bug #6941 (Rejected): conversion issue when using undo in do transaction
Greg Shah
10:31 AM Bug #6941 (WIP): conversion issue when using undo in do transaction
This can be closed / rejected. Alexandru Lungu
10:02 AM Bug #6941: conversion issue when using undo in do transaction
It seems that this has been solved in the meantime. I tested with trunk, rev. 14709 and everything worked fine. No is... Radu Apetrii
10:29 AM Bug #7641: Lower the number of Map.get() calls in the persistence layer
I am OK with most of the changes; there seemed to be quite some places which needed refactoring.
Eduard, please co...
Alexandru Lungu
09:56 AM Bug #7496: finish support for query:forward-only attribute
*Committed 7496a/rev.14705*. After fixing #7737 (#7737-12) and investigating @TRANSACTION_COMMITTING@, I managed to f... Dănuț Filimon
06:36 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> I made some upgrades to the program to:
> # Handle multiple database imports
> # Retrieve ...
Greg Shah
03:57 AM Bug #7488: Slow fast-copy with before tables in H2
*Review of 7404a, rev. 14656*
The changes are quite good now and look pretty stable. However, there are still some...
Alexandru Lungu

08/24/2023

04:46 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
I made some upgrades to the program to:
# Handle multiple database imports
# Retrieve DDL from the application jar
...
Roger Borrello
11:57 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
I do notice that my application jar file does *not* include the ddl necessary to create the table structure. I can ea... Roger Borrello
08:27 AM Feature #7323: Implement soft unique index in FWD-H2
Committed 7323a_h2 as FWD-H2 rev. 26 and archived.
The FWD changes will be merged once we upgrade to the latest FW...
Alexandru Lungu
03:18 AM Feature #7323: Implement soft unique index in FWD-H2
Alexandru Lungu wrote:
> Please focus on identifying any changes that may cause regressions when VALIDATE mode is no...
Radu Apetrii
03:42 AM Bug #7535: Temporary tables require trailing recid component even for unique indexes
I was using @COMPILE test.p LISTING test.lst@ at some point, but this is informative only when working with a persist... Alexandru Lungu
 

Also available in: Atom