Project

General

Profile

Activity

From 12/13/2023 to 01/11/2024

01/11/2024

06:11 PM Bug #8183: debugging database module
Code review 8183a/14914:
The changes look useful, but there is a security concern, in that these public methods ca...
Eric Faulhaber
05:51 AM Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Branch 7667b was merged to trunk revision 14916 and archived. Alexandru Lungu
05:48 AM Feature #6815 (WIP): configure all cache sizes in the directory, and create documentation for them
Alexandru Lungu wrote:
> What other statistics can be achieved? I suspect the ratio is the most important one, so le...
Dănuț Filimon
05:39 AM Feature #6815: configure all cache sizes in the directory, and create documentation for them
What other statistics can be achieved? I suspect the ratio is the most important one, so lets get it done. Also, we n... Alexandru Lungu
05:28 AM Feature #6815: configure all cache sizes in the directory, and create documentation for them
*Committed 6815a/rev.14917*. Removed unnecessary methods and changes the container accessed for the @instrumentation@... Dănuț Filimon
03:52 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
There are currently problems with the POC project and the performance tests will be put on *hold* until further notic... Dănuț Filimon

01/10/2024

07:12 AM Feature #6815 (Review): configure all cache sizes in the directory, and create documentation for ...
Created *6815a* and committed *rev.14916*. As suggested by Alexandru in #6815-9, I've created a way to instrument cac... Dănuț Filimon

01/09/2024

08:16 AM Bug #7454 (Closed): Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Greg Shah
08:04 AM Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
This can be closed. Alexandru Lungu
08:16 AM Feature #7404 (Closed): Trasform replace-mode into append-mode when target table is empty
Greg Shah
08:04 AM Feature #7404: Trasform replace-mode into append-mode when target table is empty
This can be closed. Alexandru Lungu
08:16 AM Bug #7389 (Closed): Make fast-copy statements cachable
Greg Shah
08:03 AM Bug #7389: Make fast-copy statements cachable
This can be closed. Alexandru Lungu
08:03 AM Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses
Radu, lets see how we can "resurrect" this task. I think the initial statistic of *lots* of @SELECT@ statements that ... Alexandru Lungu
07:37 AM Bug #8183: debugging database module
This task should include an easy way to see a temp-table or permanent table's contents without having to do complex m... Greg Shah
05:06 AM Feature #7382: Check performance of delete from vs drop table in H2
Alexandru [ad], please refer to [[internal-documentation:H2_Database_Fork]] for further insights. Alexandru Lungu
04:38 AM Feature #7382: Check performance of delete from vs drop table in H2
> This is a patch of what I wrote so far. So from what I understand, instead of having a delete from tt where _multip... Alexandru Lungu
04:24 AM Feature #7382: Check performance of delete from vs drop table in H2
This is a patch of what I wrote so far. So from what I understand, instead of having a @delete from tt where _multipl... Alexandru Donica
04:20 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
An update on the current test status:
* Rebased *7138a_h2* with *fwd-h2/rev.38*. *7138a_h2* is now at revision *45*;...
Dănuț Filimon

01/08/2024

05:55 PM Bug #8183 (WIP): debugging database module
I created task branch 8183a and committed some of my code I have maintained for some time (r14914). It was designed n... Ovidiu Maxiniuc
04:57 PM Bug #8183: debugging database module
This task is the place for discussions on how to do database debugging and develop tools for doing this optimally.
Ovidiu Maxiniuc
04:53 PM Bug #8183 (WIP): debugging database module
Ovidiu Maxiniuc
09:13 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
Alexandru Lungu wrote:
> Please let the application convert over night. After, we can go ahead with proper testing.
...
Dănuț Filimon
09:10 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
Please let the application convert over night. After, we can go ahead with proper testing. Alexandru Lungu
08:45 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
I updated the sources for the customer applications but there are some regressions/files missing which I'll need to l... Dănuț Filimon

01/05/2024

09:14 AM Bug #7776 (Closed): Previous regression on FWD-H2 lazy mode
Greg Shah
04:07 AM Bug #7776 (Test): Previous regression on FWD-H2 lazy mode
This can be closed. Alexandru Lungu
09:14 AM Bug #8032 (Closed): Deleted records are returned by a preselect query
Greg Shah
04:06 AM Bug #8032: Deleted records are returned by a preselect query
5768a was merged to trunk. This task can be Closed. Alexandru Lungu
05:12 AM Feature #6720: lazy hydration
Eduard, please assist the regression hunting here. I am aware that you have a more suitable environment for regressio... Alexandru Lungu
05:08 AM Feature #7382: Check performance of delete from vs drop table in H2
Alexandru [ad], please provide a prototype for this task asap. Alexandru Lungu
04:04 AM Feature #7416 (Test): Reiterate DatabaseStatistics and leverage to other database profling tools
Alexandru Lungu
04:01 AM Bug #7138 (Internal Test): Short circuit fake-update (update with a new value eqaul to the old va...
Greg Shah wrote:
> What is the status of 7138a_h2? Does it need more review? More testing? It seems to provide a ...
Alexandru Lungu
03:56 AM Bug #7167: Associating records from opened buffers to new sessions is slow
Danut, I don't think that the shift to 10s looks OK with these statistics. Mind that we "lock" a connection from the ... Alexandru Lungu
03:48 AM Feature #6825 (WIP): improve table meta runtime (TableMapper and other)
Alexandru [ad], please attempt to continue profiling and optimization of @TableMapper@. The recent changes shifted a ... Alexandru Lungu

12/25/2023

07:04 AM Bug #6767: Possible name clashes in DMO classes
The work redone in the branch 6767b, The branch is rebased to trunk rev. 14906 the branch revision is 14917.
Please,...
Vladimir Tsichevski

12/22/2023

03:01 PM Bug #6767: Possible name clashes in DMO classes
The following methods should be also renamed in addition to the methods listed in #6767-9:... Vladimir Tsichevski
10:42 AM Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
What is the status of 7138a_h2? Does it need more review? More testing? It seems to provide a decent improvement o... Greg Shah
12:31 AM Bug #7496 (WIP): finish support for query:forward-only attribute
Since 7496b was merged, I'll put this issue into WIP. I've managed to find a few other issues with the implementation... Dănuț Filimon

12/21/2023

12:39 PM Feature #6442: missing encoding/collation features
The @DBCODEPAGE()@ and @DBCOLLATION()@ built-in function were implemented in #7326 and available in trunk starting wi... Ovidiu Maxiniuc
12:05 PM Feature #4722 (Test): data import should be able to run with only the converted application jar f...
Branch 4722b was merged into trunk revision 14895 and archived. Ovidiu Maxiniuc
11:24 AM Feature #4722 (Merge Pending): data import should be able to run with only the converted applicat...
Please merge 4722b after 8056b. Greg Shah
10:58 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
I rebased the branch to trunk/14890 and fixed the (strange, albeit simple) conflicts.
Pushed up 4722b to revision 14...
Ovidiu Maxiniuc
09:11 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu : Please rebase and if the result is working with a smoke test, we will get it merged. Greg Shah
09:03 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Constantin: Please review the @memptr@ change in 4722b rev 14888. If this was a safe change, why...
Constantin Asofiei
08:44 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Constantin: Please review the @memptr@ change in 4722b rev 14888. If this was a safe change, why didn't we make it b... Greg Shah
08:31 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu, there are a couple of conflicts when attempting to rebase against trunk revision 14890. Could you take a look... Roger Borrello
08:28 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Eric Faulhaber wrote:
> I think the @import.sh@ changes are ok, but I did not confirm with a test. Has this been tes...
Roger Borrello
09:36 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Eric Faulhaber wrote:
> In the @XmlFilePlugin@ c'tor, there is this comment:
> [...]
> At @ImportWorker@ line 606,...
Ovidiu Maxiniuc
11:23 AM Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks
I fully agree with Eric and mark this as top focus in the implementation. However, I am not 100% sure this approach w... Alexandru Lungu
11:13 AM Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks
Please note that an explicit FIELDS clause in 4GL code will raise an error if a field is accessed in downstream code ... Eric Faulhaber
10:50 AM Bug #7496: finish support for query:forward-only attribute
Branch 7496b was merged into trunk revision 14891 and archived.
This task is still open due to 7496a.
Alexandru Lungu
10:07 AM Bug #7496: finish support for query:forward-only attribute
Doing it now - just 10 mins to check it out. Alexandru Lungu
07:52 AM Bug #7496: finish support for query:forward-only attribute
You can merge 7496b to trunk now. Greg Shah
04:57 AM Bug #7496: finish support for query:forward-only attribute
Greg, this seems like an easy performance gain. It was fully tested (except ETF). We can go ahead with the merge of 7... Alexandru Lungu
08:42 AM Bug #6767: Possible name clashes in DMO classes
Eric Faulhaber wrote:
> Vladimir, sorry for the long delay in reviewing this again. Please rebase this branch when y...
Vladimir Tsichevski

12/20/2023

04:39 PM Bug #6767: Possible name clashes in DMO classes
Vladimir, sorry for the long delay in reviewing this again. Please rebase this branch when you can. I started reviewi... Eric Faulhaber
01:37 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Code review 4722b/14887-14892:
Generally good, but please see comments/questions below.
I think the @import.sh@...
Eric Faulhaber
12:14 PM Feature #4722 (Review): data import should be able to run with only the converted application jar...
Eric: Please review. Greg Shah
11:59 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722b was rebased to trunk_14886 and is at revision 14892. Roger Borrello
09:43 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
I think so but, to my knowledge, the changes r14878..14884 were not reviewed. Ovidiu Maxiniuc
08:29 AM Feature #6720: lazy hydration
I am "battling" with a small regression when averaging the new row-structure architecture with lazy hydration. I was ... Alexandru Lungu
08:25 AM Bug #7496: finish support for query:forward-only attribute
*Committed 7496b/rev.14879* Added the patch from #7496-41. Dănuț Filimon
05:40 AM Bug #7496: finish support for query:forward-only attribute
I finished testing the patch from #7496-41:
* POC tests: passed;
* POC regression tests: passed (with the expected ...
Dănuț Filimon

12/19/2023

05:47 PM Bug #8101: Issue with temp-table defined as reference-only
The above 4gl code generates the following java code.... Theodoros Theodorou
03:58 PM Feature #6720: lazy hydration
How far along is 6720b? Greg Shah
09:59 AM Feature #7066: Implement multi-table indexed query in H2
It is pending mostly as it was attempting to optimize multi-table queries on H2. After some profiling and tracking, t... Alexandru Lungu
09:50 AM Feature #7066: Implement multi-table indexed query in H2
What is the status of this task and of 7066a? Greg Shah
08:29 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu: Is this safe and ready to merge to trunk? Greg Shah
08:28 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Does this need any further testing?
Not from my perspective.
Roger Borrello
07:42 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Does this need any further testing? Greg Shah
07:41 AM Bug #7496 (Internal Test): finish support for query:forward-only attribute
This change is invasive as it affects all @ProgressiveResults@ across any application. I am OK with the change: we sh... Alexandru Lungu
07:38 AM Bug #7496: finish support for query:forward-only attribute
Alexandru, I tested POC with the solution mentioned in #7496-40 after we discussed it could provide a performance imp... Dănuț Filimon
03:06 AM Bug #7496: finish support for query:forward-only attribute
Dănuț Filimon wrote:
> First things first, there are a lot of @23/12/15 12:47:11.619+0200 | SEVERE | com.goldencode...
Dănuț Filimon

12/18/2023

10:02 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722b was rebased to trunk_14882 and is at revision 14888. Roger Borrello
09:51 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> Great! Don't forget to update the @ImportWorker.java@ header. I'll test it out this AM.
I...
Roger Borrello
09:22 AM Bug #8101: Issue with temp-table defined as reference-only
The failure comes from the line @boolean hasRecords = local.nonEmptyTableFlags.contains(multiplexID);@ in @TemporaryB... Theodoros Theodorou

12/15/2023

09:10 AM Bug #7496 (WIP): finish support for query:forward-only attribute
POC tests still fail, I am trying to setup the fwdtests project in Eclipse and debug. Dănuț Filimon
07:10 AM Bug #7496: finish support for query:forward-only attribute
First things first, there are a lot of @23/12/15 12:47:11.619+0200 | SEVERE | com.goldencode.p2j.persist.ForwardResu... Dănuț Filimon
04:07 AM Bug #7496: finish support for query:forward-only attribute
I am picking up work on this issue for #7991 and will be testing the changes first to see if there are any obvious pr... Dănuț Filimon
07:43 AM Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks
Committed on 8967a, revision 14872.
Added an annotation @internalfields@ with fields used in a @FOR EACH@ block to...
Eduard Soltan

12/14/2023

10:07 AM Feature #6720: lazy hydration
Adapted 6720b according to the row structure architecture. Continuing with testing and tracking. Alexandru Lungu
08:05 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu Maxiniuc wrote:
> Roger,
> Please update to latest 4922b. There are two issues fixed, which in fact, were pr...
Roger Borrello
08:16 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger,
Please update to latest 4922b. There are two issues fixed, which in fact, were present in trunk:
* changing ...
Ovidiu Maxiniuc

12/13/2023

04:30 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> It is clear there is a regression that needs to be fixed here.
Well... not really. The culprit...
Roger Borrello
03:51 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
It is clear there is a regression that needs to be fixed here. Greg Shah
03:49 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Just want to log the *reservation.d* processing from non-4722b:... Roger Borrello
02:11 PM Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> I'd like to get this into trunk. What is the effort to make this safe?
If Ovidiu could verify...
Roger Borrello
06:59 AM Feature #4722: data import should be able to run with only the converted application jar file (an...
I'd like to get this into trunk. What is the effort to make this safe? Greg Shah
10:55 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Done. Branch 7416b was merged into trunk as rev. 14872 and archived. Radu Apetrii
10:10 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Greg Shah wrote:
> You can go ahead.
I'll quickly rebase the branch and then proceed with the merging.
Radu Apetrii
10:03 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
You can go ahead. Greg Shah
06:31 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
After re-running the performance tests for both the baseline and the changed version, I got the following result:
* ...
Radu Apetrii
04:23 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Radu Apetrii wrote:
> Alexandru Lungu wrote:
> > Radu, first "batch" of logging refactoring didn't show any downgra...
Radu Apetrii
 

Also available in: Atom