Project

General

Profile

Activity

From 07/25/2024 to 08/23/2024

08/24/2024

09:03 PM Bug #9036: Multi-tenancy: refactor the database in Persistence context-wise
9036a branch was updated. Latest revision is 15388.
Changes:
* Improve database awareness of tenant information;
...
Ovidiu Maxiniuc

08/23/2024

08:52 AM Bug #9091: Unique composite index is ignored when create is used in an external procedure
Artur Școlnic wrote:
> Considering that the proc1 is an internalProcedure, is persistent and the @staticResources@ i...
Constantin Asofiei
08:48 AM Bug #9091: Unique composite index is ignored when create is used in an external procedure
Considering that the proc1 is an internalProcedure, is persistent and the @staticResources@ is empty, could someone s... Artur Școlnic
07:58 AM Bug #9091: Unique composite index is ignored when create is used in an external procedure
In @scopeFinished@ for the proc1, the procedure gets deleted only if it is external and not persistent,
which in th...
Artur Școlnic
07:18 AM Bug #9091: Unique composite index is ignored when create is used in an external procedure
On @popScope@ of the buffer, @finishedImpl@ is not executed, instead the @worldScope@ attribute is set to true. Artur Școlnic
04:32 AM Bug #9091: Unique composite index is ignored when create is used in an external procedure
@target.finished()@ for a @BufferManager@ does... Artur Școlnic
03:54 AM Bug #9091: Unique composite index is ignored when create is used in an external procedure
The buffer is in @PersistentProcScope@, but the problem is still persisting, @target.finished()@ is called to soon or... Artur Școlnic
03:27 AM Bug #9091: Unique composite index is ignored when create is used in an external procedure
The opening of the scope in the external procedure is correct. To propagate it, FWD is checking if the procedure was ... Alexandru Lungu
03:19 AM Bug #9091: Unique composite index is ignored when create is used in an external procedure
When using @run proc1 in external@, the conversion for @external.p@ is ... Artur Școlnic

08/22/2024

06:34 PM Bug #9036: Multi-tenancy: refactor the database in Persistence context-wise
9036a branch was updated. Latest revision is 15387.
Changes:
* Made @Database@ objects tenant-friendly;
* Started ...
Ovidiu Maxiniuc
02:17 PM Bug #9036: Multi-tenancy: refactor the database in Persistence context-wise
To summary (hopefully most or all of) our discussion today...
*@Database@ Object Use*
We agreed that we want to...
Eric Faulhaber
01:30 PM Feature #9093: add protection for multi-tenant imports to optionally only import tables that are ...
> I did not see that attribute in the @.df@ file I have. The table @test@ is defined as:[...]
I think that attribu...
Greg Shah
01:05 PM Feature #9093: add protection for multi-tenant imports to optionally only import tables that are ...
Radu,
I did not see that attribute in the @.df@ file I have. The table @test@ is defined as:...
Ovidiu Maxiniuc
12:02 PM Feature #9093: add protection for multi-tenant imports to optionally only import tables that are ...
Radu got to the schema answer before I could post. :)
> I do not think the tables from different tenants can be in...
Greg Shah
11:48 AM Feature #9093: add protection for multi-tenant imports to optionally only import tables that are ...
Ovidiu Maxiniuc wrote:
> But in order to generate that, the information must come from somewhere. How is this inform...
Radu Apetrii
11:32 AM Feature #9093: add protection for multi-tenant imports to optionally only import tables that are ...
Yep, I forgot about the DMO annotations.
But in order to generate that, the information must come from somewhere. H...
Ovidiu Maxiniuc
10:37 AM Feature #9093: add protection for multi-tenant imports to optionally only import tables that are ...
I don't think this is correct.
The default database and the tenant databases have the same exact schema. There is...
Greg Shah
08:45 AM Feature #9093: add protection for multi-tenant imports to optionally only import tables that are ...
If I understand it correctly, when a database is declared (generically speaking) we get the following information:
#...
Ovidiu Maxiniuc
07:33 AM Feature #9093: add protection for multi-tenant imports to optionally only import tables that are ...
When running import, the user should be able to optionally force the import to limit itself to one the following:
...
Greg Shah
07:28 AM Feature #9093 (Closed): add protection for multi-tenant imports to optionally only import tables ...
Greg Shah
09:28 AM Bug #9091: Unique composite index is ignored when create is used in an external procedure
In @TransactionManager.processFinalazables()@, the record buffer is missing from the @blk.finalizables@ when using @r... Artur Școlnic
09:16 AM Bug #9091: Unique composite index is ignored when create is used in an external procedure
Artur Școlnic wrote:
> @run external.p@ is converted as an externalProcedure.
> [...] is converted as an internalPr...
Artur Școlnic
09:11 AM Bug #9091: Unique composite index is ignored when create is used in an external procedure
I meant that the @proc1@ is @internalProcedure@.... Artur Școlnic
09:09 AM Bug #9091: Unique composite index is ignored when create is used in an external procedure
I converted the example in #9091-11 and I get:... Alexandru Lungu
08:45 AM Bug #9091: Unique composite index is ignored when create is used in an external procedure
@run external.p@ is converted as an externalProcedure.... Artur Școlnic
08:27 AM Bug #9091: Unique composite index is ignored when create is used in an external procedure
Alexandru Lungu wrote:
> Who is causing the release of @tt@ the second time? The first time it is clear.
I added ...
Artur Școlnic
08:16 AM Bug #9091: Unique composite index is ignored when create is used in an external procedure
Who is causing the release of @tt@ the second time? The first time it is clear. Alexandru Lungu
08:10 AM Bug #9091: Unique composite index is ignored when create is used in an external procedure
Releasing tt after the second create does cause the error to be thrown. Artur Școlnic
08:03 AM Bug #9091: Unique composite index is ignored when create is used in an external procedure
Artur, the first record that you created is flushed to the database because you re-use the buffer (causing an implici... Alexandru Lungu
07:57 AM Bug #9091: Unique composite index is ignored when create is used in an external procedure
@getUnvalidatedIndices@ returns null because the unique bit set is being checked against the Map of properties touche... Artur Școlnic
07:32 AM Bug #9091: Unique composite index is ignored when create is used in an external procedure
When using composite indices in this context, @getUnvalidatedIndices@ returns null instead of the bit set representin... Artur Școlnic
06:26 AM Bug #9091: Unique composite index is ignored when create is used in an external procedure
main.p... Artur Școlnic
06:18 AM Bug #9091 (WIP): Unique composite index is ignored when create is used in an external procedure
Artur Școlnic
06:18 AM Bug #9091: Unique composite index is ignored when create is used in an external procedure
This ticket is derived from #8912-216. Artur Școlnic
06:17 AM Bug #9091 (WIP): Unique composite index is ignored when create is used in an external procedure
Artur Școlnic
03:44 AM Feature #7960: Allow query logs to be collected in a H2 database
Committed on *7960a rev. 15355* formatting changes.
The testing plan has been successfully completed, please refer...
Ioana-Cristina Prioteasa

08/20/2024

02:26 PM Feature #7960: Allow query logs to be collected in a H2 database
Only small formatting issues:
* return javadoc doesn't need to have the type; only the description of the returned v...
Alexandru Lungu
08:42 AM Feature #7960 (Internal Test): Allow query logs to be collected in a H2 database
Eric Faulhaber
12:13 PM Bug #9078: emit FindQuery as (reused) variables
There is another point here. When a Java method gets called 10k's of times, then the local-var FIND will be created ... Constantin Asofiei
11:13 AM Bug #9078: emit FindQuery as (reused) variables
A @FIND@ statement can be executed 10k's or more just for simple API calls. This requires, for each execution:
* a ...
Constantin Asofiei
11:00 AM Bug #9078 (Review): emit FindQuery as (reused) variables
Constantin Asofiei

08/19/2024

05:45 PM Bug #9036: Multi-tenancy: refactor the database in Persistence context-wise
> I think the best solution is a runtime flag (in @directory.xml@)
Whether or not a table is shared or multi-tena...
Greg Shah
05:04 PM Bug #9036 (WIP): Multi-tenancy: refactor the database in Persistence context-wise
Multiple issue reported in my previous note are caused because some objects are cached locally, in different persiste... Ovidiu Maxiniuc
08:26 AM Feature #7960: Allow query logs to be collected in a H2 database
Ioana-Cristina Prioteasa wrote:
> Made a small error in @CentralLoggerFile@ at @fileCount@ and @fileLimit@ condition...
Galya B
07:48 AM Feature #7960: Allow query logs to be collected in a H2 database
Made a small error in @CentralLoggerFile@ at @fileCount@ and @fileLimit@ conditions. Resolved it and committed the fi... Ioana-Cristina Prioteasa
05:47 AM Feature #7960: Allow query logs to be collected in a H2 database
Addressed code review.
I retested the scenario where @filepath@ is null or empty, as I was concerned about potentia...
Ioana-Cristina Prioteasa
03:47 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Greg Shah wrote:
> OE knows whether a table is shared (default tenant) or is multi-tenant. In OE, setting the tenan...
Radu Apetrii

08/18/2024

05:51 PM Bug #9036: Multi-tenancy: refactor the database in Persistence context-wise
I have created task branch 9036a and committed the changes to problems I encountered. Latest revision is 15386. Below... Ovidiu Maxiniuc

08/15/2024

07:32 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
OE knows whether a table is shared (default tenant) or is multi-tenant. In OE, setting the tenant using @SET-DB-CLIE... Greg Shah
07:31 AM Feature #9057 (Test): enable intermixed access to default tenant (shared) data and tenant-specifi...
Greg Shah

08/14/2024

03:39 AM Bug #9034: FindQuery unique fails in a self join context
Alexandru Lungu wrote:
> * I am a bit confused with the state of this branch. I already reviewed 9034a/15373 in #903...
Artur Școlnic
03:18 AM Bug #9034: FindQuery unique fails in a self join context
Review of 9034a:
* I am a bit confused with the state of this branch. I already reviewed 9034a/15373 in #9034-9. May...
Alexandru Lungu
02:11 AM Feature #7960: Allow query logs to be collected in a H2 database
Ioana-Cristina Prioteasa wrote:
> Committed changes to *7960a rev.15352*. Added a concrete version of @CentralLogger...
Galya B

08/13/2024

11:17 AM Bug #9034: FindQuery unique fails in a self join context
Alexandru, please review. Eric Faulhaber
05:57 AM Bug #9034 (Review): FindQuery unique fails in a self join context
I committed 9034a/15373 and 9034a_h2/51, added support for identifying ambiguous unique find. Artur Școlnic
09:32 AM Feature #7960: Allow query logs to be collected in a H2 database
Committed changes to *7960a rev.15352*. Added a concrete version of @CentralLogger@ that allows dynamic file path con... Ioana-Cristina Prioteasa
06:55 AM Feature #7960: Allow query logs to be collected in a H2 database
The existing code was using the @CentralLogger@ format and @WARNING@ log level, so I think it's would be great if the... Ioana-Cristina Prioteasa
05:24 AM Feature #7960: Allow query logs to be collected in a H2 database
Ioana-Cristina Prioteasa wrote:
> I could add a server hook and if profiling was enable to close the file.
I think ...
Galya B
04:27 AM Feature #7960: Allow query logs to be collected in a H2 database
I looked into the file closing issue. The problem is here:
In @P2JQueryStatisticsConfiguration@:...
Ioana-Cristina Prioteasa
08:57 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Branch 8593e was merged to trunk rev 15379 and archived. Constantin Asofiei
08:31 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Greg Shah wrote:
> If this is ready to merge, it can go after 8233a. Constantin/Alexandru make the call.
Queued fo...
Constantin Asofiei
08:16 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
If this is ready to merge, it can go after 8233a. Constantin/Alexandru make the call. Greg Shah
08:09 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
I agree, I reckon 7156c fails because a @StopConditionException@. The SQL is wrong as a column is not found.
*So*, I...
Alexandru Lungu
08:06 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
This passed ETF and also solves #9048. We need to merge it, even if it does not address issues in 7156c. Constantin Asofiei
03:19 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
> Alexandru, I've backed out the 'cleanup' change in RecordBuffer.finishedImpl; I don't have a recreate yet, but I'll... Alexandru Lungu
08:43 PM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Review of 8593e/15379 (I assume this is your 15354 after the rebase).
I think the code is OK. I like the direct ac...
Ovidiu Maxiniuc

08/12/2024

11:21 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Ovidiu, please see 8593e 15354 - this fixes better ACCEPT-CHANGES.
Alexandru, I've backed out the 'cleanup' change...
Constantin Asofiei
07:12 AM Feature #7960: Allow query logs to be collected in a H2 database
h3. Test results
Tested with a small testcase in dataset. Below is an example output.
!7960a_results.png!
Ad...
Ioana-Cristina Prioteasa

08/09/2024

08:46 AM Bug #9034 (WIP): FindQuery unique fails in a self join context
Review of 9034a:
I understand the problem; the direct-access presumed that a unique index look-up would find one s...
Alexandru Lungu
07:55 AM Bug #9034: FindQuery unique fails in a self join context
Code review 9034b/15373:
The conversion change looks good.
Eric Faulhaber
07:24 AM Bug #9034: FindQuery unique fails in a self join context
Alexandru, please review 9034a/15373. The only issue I see is a minor coding standard format issue, but you are more ... Eric Faulhaber
07:59 AM Feature #7960: Allow query logs to be collected in a H2 database
Addressed code review and committed on 7960a rev. 15351. Ioana-Cristina Prioteasa
07:55 AM Bug #7489 (Rejected): Lazily initialize DMO signature
Greg Shah
07:45 AM Bug #7489: Lazily initialize DMO signature
This task can be rejected. Alexandru Lungu

08/08/2024

08:44 AM Bug #9040: fixe dataset serialization over appserver calls
Attached is a test which shows how how datasets can be transferred over appserver calls, via a OO instance.
This c...
Constantin Asofiei
08:41 AM Bug #9040 (New): fixe dataset serialization over appserver calls
Constantin Asofiei
08:26 AM Bug #9034: FindQuery unique fails in a self join context
Using 9034b this query... Artur Școlnic
06:19 AM Bug #9034 (Review): FindQuery unique fails in a self join context
I committed a better version of the change from #9034-4 to 9034a, I did some initial testing and it looks ok.
The co...
Artur Școlnic
07:45 AM Bug #9030: FIND statements should use an internal buffer cursor
Alexandru, I've created task branch 9030a from trunk rev 15372. This is the first attempt to solve the buffer's inte... Constantin Asofiei
07:05 AM Bug #9030: FIND statements should use an internal buffer cursor
The regression in #9015-29 is from trunk rev 15325, for #8433, where a FIND NEXT without the strong scope needs to st... Constantin Asofiei
06:59 AM Bug #9030: FIND statements should use an internal buffer cursor
Trunk has a change to invalidate @AdaptiveQuery@ right from the start if there are records in the dirty database. Thi... Alexandru Lungu
06:49 AM Bug #9030: FIND statements should use an internal buffer cursor
Did we recently make changes that caused this issue to be a problem? Surely this has not always been an issue. Greg Shah

08/07/2024

03:08 PM Bug #9036: Multi-tenancy: refactor the database in Persistence context-wise
Initially, the @database@ field in @Persistence@ was not context-related. However, when implementing multi-tenancy su... Radu Apetrii
02:54 PM Bug #9036 (Closed): Multi-tenancy: refactor the database in Persistence context-wise
Radu Apetrii
10:24 AM Bug #9034: FindQuery unique fails in a self join context
In this case, @DirectAccessHelper.findByUniqueIndex()@ is used, it assumes that if there is a unique index, only one ... Artur Școlnic
09:27 AM Bug #9034: FindQuery unique fails in a self join context
... Artur Școlnic
09:23 AM Bug #9034: FindQuery unique fails in a self join context
This ticket is derived from #8912-188. Artur Școlnic
09:23 AM Bug #9034 (Test): FindQuery unique fails in a self join context
Artur Școlnic
09:27 AM Feature #1664: data import improvements
I have some thoughts about (quick and rough) profiling the import process using the current implementation. The idea ... Ovidiu Maxiniuc

08/06/2024

02:45 PM Feature #1664: data import improvements
Ovidiu Maxiniuc wrote:
> generating a SQL file instead of the actual SQL import, in a file similar to a SQL dump. Ev...
Eric Faulhaber
02:37 PM Feature #1664: data import improvements
I see two paths:
* we go with the DMOs and ignore p2o. This is a bit more conservator. The DMO has all needed inform...
Ovidiu Maxiniuc
02:32 PM Feature #1664: data import improvements
Greg Shah wrote:
> The AST has little meaning because the structure is shallow and completely regular. Parsing it b...
Eric Faulhaber
02:25 PM Feature #1664: data import improvements
Eric Faulhaber wrote:
> Constantin added (verbally) in a meeting:
>
> ---
>
> * Optimally, don't use BDTs at a...
Eric Faulhaber
02:23 PM Feature #1664: data import improvements
The AST has little meaning because the structure is shallow and completely regular. Parsing it brings extra work. I... Greg Shah
02:18 PM Feature #1664: data import improvements
Greg Shah wrote:
> I think we should:
>
> * eliminate the usage of DMOs
> * eliminate the usage of TRPL
> * pos...
Eric Faulhaber
02:13 PM Feature #1664: data import improvements
> possibly eliminate the usage of the the .p2o documents (though we still need something to tell us how to read the .... Greg Shah
02:01 PM Feature #1664: data import improvements
Constantin added (verbally) in a meeting:
---
* Optimally, don't use BDTs at all, to avoid the overhead of allo...
Eric Faulhaber
01:59 PM Feature #1664: data import improvements
Ovidiu added:
---
The current implementation is struggling too much to maintain compatibility with normal FWD e...
Eric Faulhaber
01:56 PM Feature #1664: data import improvements
Greg added:
---
I think we should:
* eliminate the usage of DMOs
* eliminate the usage of TRPL
* possibly ...
Eric Faulhaber
01:55 PM Feature #1664: data import improvements
From email, in connection with a customer import issue:
---
I think the core problem is the way we import one t...
Eric Faulhaber
01:31 PM Feature #7020: always use "expanded" extent fields
Constantin,
emitting a list of @columns = "f_1_11, f_1_2, f_1_32"@ (as it was computed to avoid collisions in denorm...
Ovidiu Maxiniuc
01:20 PM Feature #7020: always use "expanded" extent fields
Eric, I think it may make sense (for expanded mode) to emit at the DMO property the list of SQL names associated with... Constantin Asofiei
01:12 PM Feature #7020: always use "expanded" extent fields
I used a permanent table with same structure as the temp-table from #7020-36 and converted it with *trunk* (r15368), ... Ovidiu Maxiniuc

08/05/2024

03:47 AM Bug #9030: FIND statements should use an internal buffer cursor
> Alexandru, this may not be a query, but a cursor on the index. For example, you can have FIND statements with diffe... Alexandru Lungu
03:27 AM Bug #9030: FIND statements should use an internal buffer cursor
Alexandru, this may not be a query, but a cursor on the index. For example, you can have FIND statements with differ... Constantin Asofiei
03:13 AM Bug #9030: FIND statements should use an internal buffer cursor
This task extracts the issue from #8752-3 and discussion from #6667-1054 to #6667-1087.... Alexandru Lungu
03:10 AM Bug #9030 (WIP): FIND statements should use an internal buffer cursor
Alexandru Lungu

08/01/2024

06:39 PM Feature #7020: always use "expanded" extent fields
While investigating a possible regression I identified the following problem I am trying to solve. Assuming we have t... Ovidiu Maxiniuc

07/30/2024

06:01 AM Bug #9016: Improve performance in FQLPreprocessor by using astCache
The @astCache@ added in #7731 is only used in @FqlPreprocessor.parse()@, but it can also be used in ... Dănuț Filimon
05:58 AM Bug #9016 (Test): Improve performance in FQLPreprocessor by using astCache
Dănuț Filimon

07/29/2024

06:26 PM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
I also looked over 8593e/15351.
I don't see anything wrong with the new code.
I remember we had previously anot...
Ovidiu Maxiniuc

07/26/2024

06:11 AM Bug #7731 (Closed): performance improvements for FQLPreprocessor
Greg Shah
03:27 AM Bug #7731: performance improvements for FQLPreprocessor
This can be closed. Alexandru Lungu
06:10 AM Bug #8196 (Closed): Reduce number of AbstractTempTable._hasRecords calls to avoid BufferManager.a...
Greg Shah
03:27 AM Bug #8196: Reduce number of AbstractTempTable._hasRecords calls to avoid BufferManager.activeBuffers
This can be closed. Alexandru Lungu
06:10 AM Bug #8030 (Closed): unique index violation when creating a record in two sessions
Greg Shah
03:27 AM Bug #8030: unique index violation when creating a record in two sessions
This can be closed. Alexandru Lungu
06:10 AM Feature #7416 (Closed): Reiterate DatabaseStatistics and leverage to other database profling tools
Greg Shah
03:24 AM Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
This can be closed. Alexandru Lungu
03:26 AM Bug #8044 (WIP): Fix "Failed direct-access due to Error direct accessing for finding record by un...
Alexandru Lungu

07/25/2024

08:57 AM Bug #7488 (Closed): Slow fast-copy with before tables in H2
Greg Shah
06:51 AM Bug #7488: Slow fast-copy with before tables in H2
This can be closed. Alexandru Lungu
08:57 AM Feature #7323 (Closed): Implement soft unique index in FWD-H2
Greg Shah
06:46 AM Feature #7323: Implement soft unique index in FWD-H2
This can be closed. Alexandru Lungu
08:57 AM Bug #7420 (Closed): Optimize Cursor for scrolling AdaptiveQuery
Greg Shah
06:45 AM Bug #7420: Optimize Cursor for scrolling AdaptiveQuery
> 7026e reached into trunk. This can be closed. Alexandru Lungu
08:56 AM Bug #7334 (Closed): Reclaim used sessions to improve performance
Greg Shah
06:44 AM Bug #7334: Reclaim used sessions to improve performance
This can be closed. Alexandru Lungu
08:56 AM Feature #6630 (Closed): optimize return of table parameter
Greg Shah
06:43 AM Feature #6630: optimize return of table parameter
Alexandru Lungu wrote:
> This can be closed now.
Alexandru Lungu
08:56 AM Feature #7194 (Closed): Avoid generating an ORDER-BY clause if not required
Greg Shah
06:43 AM Feature #7194: Avoid generating an ORDER-BY clause if not required
This can be closed. Alexandru Lungu
08:56 AM Bug #7329 (Closed): improve FieldReference resolution of getter/setter/extent accessors
Greg Shah
06:42 AM Bug #7329: improve FieldReference resolution of getter/setter/extent accessors
Alexandru Lungu wrote:
> This can be closed.
Alexandru Lungu
08:55 AM Bug #7358 (Closed): Optimize Session.invalidateRecords
Greg Shah
06:42 AM Bug #7358: Optimize Session.invalidateRecords
This can be closed. Alexandru Lungu
08:55 AM Bug #7321 (Closed): Improve FWD-H2 wildcard projection
Greg Shah
06:41 AM Bug #7321: Improve FWD-H2 wildcard projection
This can be closed. Alexandru Lungu
08:55 AM Bug #7355 (Closed): regression in row structure calculation for DATETIME-TZ when join is used on ...
Greg Shah
06:40 AM Bug #7355: regression in row structure calculation for DATETIME-TZ when join is used on temp-tables
Alexandru Lungu wrote:
> This can be closed.
Alexandru Lungu
03:14 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'
Alexandru Lungu wrote:
> > Hm... you are right, the record can't become 'dirty'; I think direct access to these fiel...
Constantin Asofiei
 

Also available in: Atom