Project

General

Profile

Activity

From 09/20/2024 to 10/19/2024

10/18/2024

02:25 AM Bug #9251: cache the translated FQL in FQLPreprocessor.translate
> Good catch. Stefanel: please add check at the top of FQLPreprocessor.translate, if the where clause is null, just e... Stefanel Pezamosca

10/17/2024

11:51 AM Bug #9251: cache the translated FQL in FQLPreprocessor.translate
Ovidiu Maxiniuc wrote:
> # the synchronization. In @AbstractQuery.translateSort()@ and also in @FQLPreprocessor.tran...
Constantin Asofiei
11:39 AM Bug #9251: cache the translated FQL in FQLPreprocessor.translate
Stefanel Pezamosca wrote:
> I committed to *revision 15501*: Added caching for translateSort(RecordBuffer, RecordBuf...
Ovidiu Maxiniuc
03:41 AM Bug #9251 (Test): cache the translated FQL in FQLPreprocessor.translate
Branch 9251a was merged into trunk as rev. 15503 and archived. Stefanel Pezamosca
03:12 AM Bug #9251 (Merge Pending): cache the translated FQL in FQLPreprocessor.translate
The changes look good. I've ran ETF and #9214 and they are OK.
You can merge to trunk now.
Constantin Asofiei
09:23 AM Bug #7496: finish support for query:forward-only attribute
This is really good stuff, Danut! Alexandru Lungu
08:53 AM Bug #7496: finish support for query:forward-only attribute
Good news! I've expanded the unit tests and included the adaptive tests (that use temp-tables) after rewriting them a... Dănuț Filimon
09:10 AM Bug #9267: Index Selection in case of a multiple index matches.
The following change drove down the change in @IndexSelectionWorker@ from trunk/ rev. 15486:... Eduard Soltan
08:33 AM Bug #9267 (Test): Index Selection in case of a multiple index matches.
Eduard Soltan

10/16/2024

08:46 AM Bug #9251: cache the translated FQL in FQLPreprocessor.translate
I committed to *revision 15501*: Added caching for translateSort(RecordBuffer, RecordBuffer, String) output.
Please ...
Stefanel Pezamosca
07:10 AM Bug #9251: cache the translated FQL in FQLPreprocessor.translate
Stefanel Pezamosca wrote:
> First try: it seems like caching the @translateSort@ output does not bring any improveme...
Constantin Asofiei
06:52 AM Bug #9251 (Review): cache the translated FQL in FQLPreprocessor.translate
First try: it seems like caching the @translateSort@ output does not bring any improvements.
Please review the tra...
Stefanel Pezamosca
04:54 AM Bug #9251 (WIP): cache the translated FQL in FQLPreprocessor.translate
I have created *branch 9251a* from *trunk revision 15498*.
I committed to *revision 15499* the implementation for ca...
Stefanel Pezamosca
05:25 AM Bug #9262: batch assign updates the dirty database on each assignment
Yes, in 7156c the @RecordNursery@ will hold onto all inserts/updates till the first query will occur. This is how tru... Alexandru Lungu
05:01 AM Bug #9262 (Hold): batch assign updates the dirty database on each assignment
Yes, with 7156c @DirtyShareContext.insert@ is being called on batch end, so assuming the changes in 7156c will reach ... Constantin Asofiei
04:17 AM Bug #9262: batch assign updates the dirty database on each assignment
Can you do a similar test with 7156c? 7156c has a reword of @RecordNursery@ and how the dirty changes are registered.... Alexandru Lungu
03:32 AM Bug #9262: batch assign updates the dirty database on each assignment
I found some cases where @DirtyShareContext.insert@ is being called on each assignment in a batch assign, and not jus... Constantin Asofiei
03:27 AM Bug #9262 (Hold): batch assign updates the dirty database on each assignment
Constantin Asofiei

10/15/2024

08:35 AM Bug #7641: Lower the number of Map.get() calls in the persistence layer
I have created branch 7641b (trunk 15494). At the moment I managed to extract mostly all the changes from 7641a (e.g.... Stefanel Pezamosca
07:20 AM Bug #7641 (WIP): Lower the number of Map.get() calls in the persistence layer
> So, I tried to rebase, but I get that error with key already present in map. devsrv01 is too slow to do the rebase ... Alexandru Lungu
07:59 AM Bug #7496: finish support for query:forward-only attribute
I've managed to create unit tests based on the tests I've had for this issue (there were a lot more compared to what ... Dănuț Filimon
06:28 AM Bug #7496: finish support for query:forward-only attribute
I am currently working on replacing the old tests for this issue with unit tests. Dănuț Filimon

10/14/2024

06:44 AM Bug #9251: cache the translated FQL in FQLPreprocessor.translate
The recreate is this:... Constantin Asofiei
06:26 AM Bug #9251: cache the translated FQL in FQLPreprocessor.translate
> Alexandru: can you add this to the existing sprint?
Ok; do you have a small test-case in which that part of code...
Alexandru Lungu
06:09 AM Bug #9251: cache the translated FQL in FQLPreprocessor.translate
We need a LRU cache for the @FQLPreprocessor.translate@ result. The cache key will be similar to existing FQL keys, ... Constantin Asofiei
06:07 AM Bug #9251 (Test): cache the translated FQL in FQLPreprocessor.translate
Constantin Asofiei

10/11/2024

10:56 AM Bug #7641: Lower the number of Map.get() calls in the persistence layer
So, I tried to rebase, but I get that error with key already present in map. devsrv01 is too slow to do the rebase th... Stefanel Pezamosca
04:40 AM Bug #7641: Lower the number of Map.get() calls in the persistence layer
Stefanel, please recap #7641 effort, rebase 7641a and review.
After, lets do some performance testing with it to und...
Alexandru Lungu
04:14 AM Bug #7641: Lower the number of Map.get() calls in the persistence layer
Constantin - I wanted to remember you of this task, considering you have worked recently on performance matters. 7641... Alexandru Lungu
08:03 AM Bug #7496: finish support for query:forward-only attribute
Rebased *7496a* with *trunk/rev.15494*. *7496a* is now at revision *15504*. Dănuț Filimon

10/09/2024

10:53 AM Bug #9194: FWD selects the wrong index when using CONTAINS?
It's time for another blast from the past (maybe?). I'm going to take all of you back to #1587 (the ticket, not the y... Radu Apetrii
09:19 PM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
The current solution I am trying to make it work is as follows:
* each @Database@ object should have a reference to ...
Ovidiu Maxiniuc

10/08/2024

09:20 AM Bug #9194: FWD selects the wrong index when using CONTAINS?
I have created 9194a for further changes. First, I'll check why the word-index is not selected. After that, I'll see ... Radu Apetrii
02:03 AM Bug #9194: FWD selects the wrong index when using CONTAINS?
OK, thank you for your response and the one previous about the projects (I hadn't been made aware of this). Andy Edwards
09:08 AM Bug #9228: FQL to SQL conversion for CONTAINS when the output is expected to be always false is n...
Please update [[regression:Open Regressions in FWD v4]] with the status. Greg Shah
03:28 AM Bug #9228 (Test): FQL to SQL conversion for CONTAINS when the output is expected to be always fal...
Branch 9228a was merged to trunk rev 15483 and archived. Stefanel Pezamosca
02:02 AM Bug #9228 (Merge Pending): FQL to SQL conversion for CONTAINS when the output is expected to be a...
Stefanel Pezamosca wrote:
> I had the changes patched to my local trunk for a while now. I didn't encounter any obvi...
Constantin Asofiei

10/07/2024

07:15 PM Bug #9194: FWD selects the wrong index when using CONTAINS?
Eric Faulhaber wrote:
> Andy Edwards wrote:
> > [...] FWD will not use the same WORD-INDEX rules as the 4GL so we w...
Ovidiu Maxiniuc
03:03 PM Bug #9194: FWD selects the wrong index when using CONTAINS?
Andy Edwards wrote:
> Hi all, we have completed the "indeterminate sorting" review and are now starting to make the ...
Eric Faulhaber
10:11 AM Bug #9228: FQL to SQL conversion for CONTAINS when the output is expected to be always false is n...
I had the changes patched to my local trunk for a while now. I didn't encounter any obvious issues while testing. Stefanel Pezamosca
05:13 AM Bug #9228: FQL to SQL conversion for CONTAINS when the output is expected to be always false is n...
Stefanel, please go ahead and test other projects. If they are OK, we can queue this for merge. Constantin Asofiei

10/04/2024

05:52 AM Bug #9194: FWD selects the wrong index when using CONTAINS?
Hi all, we have completed the "indeterminate sorting" review and are now starting to make the necessary changes, henc... Andy Edwards
03:42 AM Bug #9228: FQL to SQL conversion for CONTAINS when the output is expected to be always false is n...
I've tested ETF and is OK. I think we need to wait for 6667i to be merged, and after that we'll test some other apps... Constantin Asofiei

10/03/2024

09:29 AM Feature #9218: Changes in internal tenant management
> I adjusted the implementation of the tenant ID to match the one from 4GL. As result, at each server restart, the un... Greg Shah
09:16 AM Bug #9228 (Internal Test): FQL to SQL conversion for CONTAINS when the output is expected to be a...
Ovidiu Maxiniuc wrote:
> Revision of 9228a, r15478.
>
> I think the code will work fine. I have just a few notes ...
Stefanel Pezamosca
08:52 AM Bug #9228: FQL to SQL conversion for CONTAINS when the output is expected to be always false is n...
Revision of 9228a, r15478.
I think the code will work fine. I have just a few notes to add:
* @FqlToSqlConverte...
Ovidiu Maxiniuc
07:05 AM Bug #9228: FQL to SQL conversion for CONTAINS when the output is expected to be always false is n...
Ovidiu, please review. Constantin Asofiei
06:01 AM Bug #9228: FQL to SQL conversion for CONTAINS when the output is expected to be always false is n...
I committed to *9228a revision 15478* a fix for the wrong orderFields generation.
Please review.
Stefanel Pezamosca
12:01 AM Bug #9228: FQL to SQL conversion for CONTAINS when the output is expected to be always false is n...
Constantin Asofiei wrote:
> Was your test with 6667i? Because this code does not check correctly for 'order by' AST...
Stefanel Pezamosca

10/02/2024

03:18 PM Feature #9218: Changes in internal tenant management
I have cherry-picked the changes and put them in 9057a. Revision 15463. I hope the branch is not broken (compilable a... Ovidiu Maxiniuc
02:58 PM Feature #9218: Changes in internal tenant management
Ovidiu, is this work in a task branch yet? I'd like to look it over to get a better understanding of the changes. Eric Faulhaber
02:34 PM Feature #9218: Changes in internal tenant management
I adjusted the implementation of the tenant ID to match the one from 4GL. As result, at each server restart, the uniq... Ovidiu Maxiniuc
02:51 PM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Current status:
While the private tables in a tenant enabled database works correctly, the shared tables are still...
Ovidiu Maxiniuc
02:31 PM Bug #9228: FQL to SQL conversion for CONTAINS when the output is expected to be always false is n...
Was your test with 6667i? Because this code does not check correctly for 'order by' ASTs, in the case when the sort ... Constantin Asofiei
01:57 PM Bug #9228: FQL to SQL conversion for CONTAINS when the output is expected to be always false is n...
Constantin Asofiei wrote:
> What's the FQL being converted here?
The one you discovered while testing with 6667i.
Stefanel Pezamosca
01:49 PM Bug #9228: FQL to SQL conversion for CONTAINS when the output is expected to be always false is n...
What's the FQL being converted here? Constantin Asofiei
09:40 AM Bug #9228 (Review): FQL to SQL conversion for CONTAINS when the output is expected to be always f...
I have created task branch *9228a* from *trunk revision 15476*.
I committed the fix in *9228a revision 15477*. Ple...
Stefanel Pezamosca
09:39 AM Bug #9228 (WIP): FQL to SQL conversion for CONTAINS when the output is expected to be always fals...
The issue is that for some cases CONTAINS parameter can be an empty string.
* 1. This should be picked up by @FQLPr...
Stefanel Pezamosca
09:06 AM Bug #9228 (Test): FQL to SQL conversion for CONTAINS when the output is expected to be always fal...
Stefanel Pezamosca

10/01/2024

09:55 AM Bug #9224: conversion of sql table name honors FWD reserved words
A legacy table named @Property@ will have a sql table name of @Property_@ - this is because FWD has a reserved name t... Constantin Asofiei
09:52 AM Bug #9224 (New): conversion of sql table name honors FWD reserved words
Constantin Asofiei
08:47 AM Bug #9222: Validation of a record buffer throws an error in FWD, but does not in 4GL
This ticket is derived from #9181-10. Artur Școlnic
08:47 AM Bug #9222: Validation of a record buffer throws an error in FWD, but does not in 4GL
... Artur Școlnic
08:45 AM Bug #9222 (New): Validation of a record buffer throws an error in FWD, but does not in 4GL
Artur Școlnic
08:39 AM Feature #9218: Changes in internal tenant management
My concern is for any interface (now or introduced later) which takes that tenant id. It is just more secure if the ... Greg Shah
08:31 AM Feature #9218: Changes in internal tenant management
I did additional research and found "this":https://docs.progress.com/bundle/openedge-database-multitenancy-117/page/T... Ovidiu Maxiniuc

09/30/2024

02:38 PM Feature #9218: Changes in internal tenant management
> ** @0@ for default tenant,
> ** incrementing positive values for regular tenants
> ** decrementing negative valu...
Greg Shah
02:23 PM Feature #9218: Changes in internal tenant management
After initial iteration implementation some changes in the management of FWD internal management of tenant feature.
...
Ovidiu Maxiniuc
02:22 PM Feature #9218 (New): Changes in internal tenant management
Ovidiu Maxiniuc

09/25/2024

02:58 PM Feature #9057 (WIP): enable intermixed access to default tenant (shared) data and tenant-specific...
First, a short description of the current state from the implementation standpoint. All low-level data management for... Ovidiu Maxiniuc
09:53 AM Bug #9133: Array subscript is out of range stops the evaluation of other expressions in the where...
I am moving this to Normal priority as the regression in #9189 was fixed by reverting the original changes. We can ha... Alexandru Lungu
06:28 AM Bug #9133: Array subscript is out of range stops the evaluation of other expressions in the where...
So this means that converting to client where is the only way to go here? I suppose so. Alexandru Lungu
06:26 AM Bug #9133: Array subscript is out of range stops the evaluation of other expressions in the where...
Alexandru Lungu wrote:
> Hmm I see. This is because it will end up as @null ne 0@ and this is basically true. This y...
Lorian Sandu
06:17 AM Bug #9133: Array subscript is out of range stops the evaluation of other expressions in the where...
Hmm I see. This is because it will end up as @null ne 0@ and this is basically true. This you also happen for cases w... Alexandru Lungu
06:08 AM Bug #9133: Array subscript is out of range stops the evaluation of other expressions in the where...
Lorian Sandu wrote:
> I will investigate deeper to see if this case is simplified as @BOOL_FALSE@
Actually, this ...
Lorian Sandu
05:51 AM Bug #9133: Array subscript is out of range stops the evaluation of other expressions in the where...
I looked into @FQLPreprocessor.mainWalk()@ and found out how we handle the cases @tablename.extField[?]@ , where the ... Lorian Sandu
04:37 AM Bug #9133: Array subscript is out of range stops the evaluation of other expressions in the where...
Alexandru Lungu wrote:
> Lorian, please attempt 2) in 9133a. It means replacing invalid @tablename.extField[id]@ wit...
Lorian Sandu
03:21 AM Bug #9133: Array subscript is out of range stops the evaluation of other expressions in the where...
> In the customer application, the second preprocessor, even if it is created, it is never actually used. This is why... Alexandru Lungu

09/24/2024

07:44 PM Bug #9133: Array subscript is out of range stops the evaluation of other expressions in the where...
I think I have the question for why before 9095a the incorrect FQL (containing references of form @<tablename>.null@)... Ovidiu Maxiniuc
01:01 PM Bug #9133: Array subscript is out of range stops the evaluation of other expressions in the where...
I will do a quick summary here. Let's assume we have a @tablename@ table with a @extField@ and a local integer variab... Ovidiu Maxiniuc
10:30 AM Bug #9133: Array subscript is out of range stops the evaluation of other expressions in the where...
I really fear the impact of client where. For the first query you posted: if that query would run over a persistent d... Alexandru Lungu
05:25 AM Bug #9133: Array subscript is out of range stops the evaluation of other expressions in the where...
>Lorian please, do such experiment and post the Java conversion of buf1.f1[i1] vs buf1.f1[buf1.f2]. Are these process... Lorian Sandu
03:56 AM Bug #9133 (WIP): Array subscript is out of range stops the evaluation of other expressions in the...
> Ovidiu/Alexandru: Please review.
I don't think changing the grandparent is always correct.
* You can have @for...
Alexandru Lungu

09/23/2024

10:38 AM Bug #9133 (Review): Array subscript is out of range stops the evaluation of other expressions in ...
Committed to @9133a / rev 15454@
Ovidiu/Alexandru: Please review.
Lorian Sandu
07:50 AM Bug #9133: Array subscript is out of range stops the evaluation of other expressions in the where...
Lorian, please put this change in a branch and move this into Review. Alexandru Lungu
06:50 AM Bug #9133 (WIP): Array subscript is out of range stops the evaluation of other expressions in the...
I looked into how @AbstractQuery.preprocessSubstituionArguments@ behaves in terms of error handling. I found out that... Lorian Sandu
09:19 AM Bug #9194: FWD selects the wrong index when using CONTAINS?
Good findings. Please edit the wiki page to include your important clarifications. Greg Shah
07:26 AM Bug #9194: FWD selects the wrong index when using CONTAINS?
Greg Shah wrote (note #8357-130):
> [[p2j:Chapter_27_Sorting_Query_Results#Single-Index-Selection-Rules|Index Select...
Radu Apetrii
05:40 AM Bug #9194: FWD selects the wrong index when using CONTAINS?
Here's a summary of what happened so far:
*Example 1*
{{collapse
Working with a table @test@ that has two indexe...
Radu Apetrii
05:15 AM Bug #9194: FWD selects the wrong index when using CONTAINS?
In #8357, it was brought to our attention that FWD selects the wrong index in a query that has the @CONTAINS@ clause.... Radu Apetrii
04:50 AM Bug #9194 (WIP): FWD selects the wrong index when using CONTAINS?
Radu Apetrii

09/20/2024

07:28 AM Bug #9133: Array subscript is out of range stops the evaluation of other expressions in the where...
For awareness, I am raising the priority of this task in relation to #9189. Ovidiu Maxiniuc
 

Also available in: Atom