FWD » Core Development » Database

10/25/2024

09:49 AM Bug #7496: finish support for query:forward-only attribute

Rebased *7496a* with *trunk/rev.15523*. *7496a* is now at revision *15534*. Dănuț Filimon

09:36 AM Bug #7496: finish support for query:forward-only attribute

After retesting, performance is not affected. (-1% from baseline) Ioana-Cristina Prioteasa

08:59 AM Bug #7496: finish support for query:forward-only attribute

I updated the test plan status from #7496-76 with the latest results. The test plan was completed and there were no r... Dănuț Filimon

06:44 AM Bug #7496: finish support for query:forward-only attribute

I applied the changes over 7156c rev. 15501. I will redo the testing today, I will update when they are done. ETA: 3h. Ioana-Cristina Prioteasa

03:58 AM Bug #7496: finish support for query:forward-only attribute

Ioana-Cristina Prioteasa wrote:
> Applied 7496 changes over 7156c. The total time for a performance round has gone f... Dănuț Filimon

09:23 AM Bug #9267: Index Selection in case of a multiple index matches.

Radu, let me do you one better: https://proj.goldencode.com/artifacts/javadoc/latest/api/com/goldencode/p2j/schema/pa... Alexandru Lungu

09:05 AM Bug #9267: Index Selection in case of a multiple index matches.

If needed, there is also this wiki page "Index Selection":https://proj.goldencode.com/projects/p2j/wiki/Chapter_27_So... Radu Apetrii

04:11 AM Bug #9267: Index Selection in case of a multiple index matches.

Alexandru Lungu wrote:
> Eduard, can you augment the xfer testcases on index_selection with some of your findings an... Eduard Soltan

04:11 AM Bug #9267: Index Selection in case of a multiple index matches.

Eduard, can you augment the xfer testcases on index_selection with some of your findings and test that as well: make ... Alexandru Lungu

03:58 AM Bug #9267: Index Selection in case of a multiple index matches.

I comitted my change on 9267a, rev. 15522.
With this change, in *findLeadingIndexMatch* in case we have multiple i... Eduard Soltan

02:41 AM Bug #9267: Index Selection in case of a multiple index matches.

> Looking at calcIndexSelection it will always return a single index. Do you know whether that is intentional or sele... Alexandru Lungu

08:03 AM Bug #9078: emit FindQuery as (reused) variables

I've managed to find a fix for #9078-22, it involved searching for a top level block that has a top level ancestor an... Dănuț Filimon

07:17 AM Bug #9078: emit FindQuery as (reused) variables

I've managed to fix #9078-21, there was another rule whre the FindQuery constructor was created so I had to change it... Dănuț Filimon

03:01 AM Bug #9078: emit FindQuery as (reused) variables

I have trouble differentiating between the top block execute method and top block class method. Because of #9078-20 a... Dănuț Filimon

07:26 AM Bug #9034: FindQuery unique fails in a self join context

I committed 9034a_h2/53, it addressed the review points from #9034-12 and the issue discussed in #9034-17.
deleted Artur Școlnic

06:13 AM Bug #9034: FindQuery unique fails in a self join context

This is how the code looked before any FWD-H2 specific changes:... Alexandru Lungu

05:24 AM Bug #9034: FindQuery unique fails in a self join context

Alexandru, during testing of 9134a_h2, I encountered some issue with the @next@ method in @TreeCursor@:... Artur Școlnic

03:30 AM Bug #9034: FindQuery unique fails in a self join context

> Review of 9034a:
These were change local on my side, ignore review. Alexandru Lungu

10/24/2024

09:39 AM Bug #9267: Index Selection in case of a multiple index matches.

... Eduard Soltan

07:51 AM Bug #9078: emit FindQuery as (reused) variables

Another known problem where the FindQuery is not properly converted:... Dănuț Filimon

07:15 AM Bug #9078: emit FindQuery as (reused) variables

Alexandru Lungu wrote:
> I am not sure if the FindQuery should be generated as a class member anyway. Its scope can ... Dănuț Filimon

07:07 AM Bug #9078: emit FindQuery as (reused) variables

I am not sure if the FindQuery should be generated as a class member anyway. Its scope can remain there. Otherwise, f... Alexandru Lungu

07:06 AM Bug #9078: emit FindQuery as (reused) variables

Committed *9078a/15518*. Added a default constructor for FindQuery so that the converted code compiles. Dănuț Filimon

06:50 AM Bug #9078: emit FindQuery as (reused) variables

The issue was related to adding an annotation to @this@ and not @copy@, after this I managed to make a few more chang... Dănuț Filimon

04:31 AM Bug #9078: emit FindQuery as (reused) variables

Dănuț Filimon wrote:
> I am currently working on adding a "qryname" annotation to each find query (not just for the ... Dănuț Filimon

03:14 AM Bug #9078: emit FindQuery as (reused) variables

I am currently working on adding a "qryname" annotation to each find query (not just for the AdaptiveFind) but I am f... Dănuț Filimon

03:55 AM Bug #7496: finish support for query:forward-only attribute

Applied 7496 changes over 7156c. The total time for a performance round has gone from *38.4s to 44.1s, 14% slowdown.*... Ioana-Cristina Prioteasa

10/23/2024

09:02 AM Bug #9274: Analyze how creatingBuffer is relevant after the introduction of multiplyReferenced DMOs

This task is about the relevance of @RecordBuffer.creatingBuffer@.
Recently, FWD added support for multiplyReferen... Alexandru Lungu

08:45 AM Bug #9274 (New): Analyze how creatingBuffer is relevant after the introduction of multiplyReferen...

Alexandru Lungu

05:33 AM Bug #7496: finish support for query:forward-only attribute

Alexandru Lungu wrote:
> I am OK with the changes in rev. 15505.
> Please also run performance tests - contact [icp... Dănuț Filimon

05:22 AM Bug #7496 (Internal Test): finish support for query:forward-only attribute

I am OK with the changes in rev. 15505.
Please also run performance tests - contact [icp] for the performance tests ... Alexandru Lungu

05:01 AM Bug #7496: finish support for query:forward-only attribute

Testing finished successfully:
* Smoke test 3 GUI application
* Harness test
* 2 customer unit tests
Testing le... Dănuț Filimon

05:28 AM Bug #9034 (WIP): FindQuery unique fails in a self join context

Review of 9034a:
* remove oo imports from RAQ
* add history entry for @DirectAccessHelper@
* remove changes from E... Alexandru Lungu

05:16 AM Bug #9078: emit FindQuery as (reused) variables

I think I get it ... there is no link between the columns. So on line 1, there are actual 3 different find queries.
... Alexandru Lungu

04:33 AM Bug #9078: emit FindQuery as (reused) variables

Alexandru Lungu wrote:
> What does first place mean? Is the same FIND Query 1022 times in a constructor, 111403 in a... Dănuț Filimon

04:21 AM Bug #9078: emit FindQuery as (reused) variables

What does first place mean? Is the same FIND Query 1022 times in a constructor, 111403 in an execute and 883905 in an... Alexandru Lungu

03:59 AM Bug #9078: emit FindQuery as (reused) variables

After a retest of the scenario mentioned in #9078, I managed to gather the following information:
* Instances create... Dănuț Filimon

10/22/2024

07:49 AM Bug #9078: emit FindQuery as (reused) variables

After a quick analysis I found the following:
* Instances created: *6900539*
* Instances created in a constructor c... Dănuț Filimon

05:10 AM Bug #9078: emit FindQuery as (reused) variables

Dănuț Filimon wrote:
> * A part of the analysis can be done on the converted code (how many FindQuery instances can ... Constantin Asofiei

04:27 AM Bug #9078: emit FindQuery as (reused) variables

My plan is to analyze a customer application (using a test scenario) for:
* The number of total FindQuery instances ... Dănuț Filimon

03:48 AM Bug #9078 (WIP): emit FindQuery as (reused) variables

Dănuț Filimon

06:26 AM Bug #7496: finish support for query:forward-only attribute

I finished running the unit tests of a customer and found 2 tests regressing in 2 modules, but after retesting with @... Dănuț Filimon

01:21 AM Bug #7496: finish support for query:forward-only attribute

I've started testing 7496a using the unit tests of a customer last night and it got stuck on a module (infinite loop)... Dănuț Filimon

10/21/2024

05:57 PM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data

New update.
I am advancing with identifying and choosing the right physical database when some API from persistenc... Ovidiu Maxiniuc

07:57 AM Bug #7496 (Review): finish support for query:forward-only attribute

*Committed 7496a/15505*. Fixed error handling for static and dynamic queries, removed unnecessary boolean parameter. ... Dănuț Filimon

07:37 AM Bug #7496: finish support for query:forward-only attribute

Dănuț Filimon wrote:
> The @queryForward()@ method does not take into account that the query might be closed, the er... Dănuț Filimon

07:27 AM Bug #7496: finish support for query:forward-only attribute

The following example:... Dănuț Filimon

07:03 AM Bug #7496 (WIP): finish support for query:forward-only attribute

I'll put the issue in WIP a bit until I am done investigating #7496-66. Dănuț Filimon

07:01 AM Bug #7496: finish support for query:forward-only attribute

Oh I see, it is a difference on the method called - you are right. Alexandru Lungu

06:58 AM Bug #7496: finish support for query:forward-only attribute

Alexandru Lungu wrote:
> * There are some places where @ ErrorManager.recordOrShowError(3159, String.format(errMsg, ... Dănuț Filimon

06:43 AM Bug #7496: finish support for query:forward-only attribute

Review of #7496:
* I am OK with the changes
* There are some places where @ ErrorManager.recordOrShowError(3159, St... Alexandru Lungu

06:35 AM Bug #7496: finish support for query:forward-only attribute

I started investigating the failing tests and made the following change:... Dănuț Filimon

06:08 AM Bug #7496 (Review): finish support for query:forward-only attribute

Alexandru Lungu wrote:
> It is normal to have the same number of P2J queries. In an @AdaptiveQuery@ it either choose... Dănuț Filimon

06:01 AM Bug #7496: finish support for query:forward-only attribute

It is normal to have the same number of P2J queries. In an @AdaptiveQuery@ it either chooses to use @ProgressiveResul... Alexandru Lungu

05:53 AM Bug #7496: finish support for query:forward-only attribute

I compared the p2j-query__temp.log of the Startup + warmup + 5 runs of the extented performance scenario of a custome... Dănuț Filimon

10/18/2024

02:25 AM Bug #9251: cache the translated FQL in FQLPreprocessor.translate

> Good catch. Stefanel: please add check at the top of FQLPreprocessor.translate, if the where clause is null, just e... Stefanel Pezamosca

10/17/2024

11:51 AM Bug #9251: cache the translated FQL in FQLPreprocessor.translate

Ovidiu Maxiniuc wrote:
> # the synchronization. In @AbstractQuery.translateSort()@ and also in @FQLPreprocessor.tran... Constantin Asofiei

11:39 AM Bug #9251: cache the translated FQL in FQLPreprocessor.translate

Stefanel Pezamosca wrote:
> I committed to *revision 15501*: Added caching for translateSort(RecordBuffer, RecordBuf... Ovidiu Maxiniuc

03:41 AM Bug #9251 (Test): cache the translated FQL in FQLPreprocessor.translate

Branch 9251a was merged into trunk as rev. 15503 and archived. Stefanel Pezamosca

03:12 AM Bug #9251 (Merge Pending): cache the translated FQL in FQLPreprocessor.translate

The changes look good. I've ran ETF and #9214 and they are OK.
You can merge to trunk now. Constantin Asofiei

09:23 AM Bug #7496: finish support for query:forward-only attribute

This is really good stuff, Danut! Alexandru Lungu

08:53 AM Bug #7496: finish support for query:forward-only attribute

Good news! I've expanded the unit tests and included the adaptive tests (that use temp-tables) after rewriting them a... Dănuț Filimon

09:10 AM Bug #9267: Index Selection in case of a multiple index matches.

The following change drove down the change in @IndexSelectionWorker@ from trunk/ rev. 15486:... Eduard Soltan

08:33 AM Bug #9267 (Test): Index Selection in case of a multiple index matches.

Eduard Soltan

10/16/2024

08:46 AM Bug #9251: cache the translated FQL in FQLPreprocessor.translate

I committed to *revision 15501*: Added caching for translateSort(RecordBuffer, RecordBuffer, String) output.
Please ... Stefanel Pezamosca

07:10 AM Bug #9251: cache the translated FQL in FQLPreprocessor.translate

Stefanel Pezamosca wrote:
> First try: it seems like caching the @translateSort@ output does not bring any improveme... Constantin Asofiei

06:52 AM Bug #9251 (Review): cache the translated FQL in FQLPreprocessor.translate

First try: it seems like caching the @translateSort@ output does not bring any improvements.
Please review the tra... Stefanel Pezamosca

04:54 AM Bug #9251 (WIP): cache the translated FQL in FQLPreprocessor.translate

I have created *branch 9251a* from *trunk revision 15498*.
I committed to *revision 15499* the implementation for ca... Stefanel Pezamosca

05:25 AM Bug #9262: batch assign updates the dirty database on each assignment

Yes, in 7156c the @RecordNursery@ will hold onto all inserts/updates till the first query will occur. This is how tru... Alexandru Lungu

05:01 AM Bug #9262 (Hold): batch assign updates the dirty database on each assignment

Yes, with 7156c @DirtyShareContext.insert@ is being called on batch end, so assuming the changes in 7156c will reach ... Constantin Asofiei

04:17 AM Bug #9262: batch assign updates the dirty database on each assignment

Can you do a similar test with 7156c? 7156c has a reword of @RecordNursery@ and how the dirty changes are registered.... Alexandru Lungu

03:32 AM Bug #9262: batch assign updates the dirty database on each assignment

I found some cases where @DirtyShareContext.insert@ is being called on each assignment in a batch assign, and not jus... Constantin Asofiei

03:27 AM Bug #9262 (Hold): batch assign updates the dirty database on each assignment

Constantin Asofiei

10/15/2024

08:35 AM Bug #7641: Lower the number of Map.get() calls in the persistence layer

I have created branch 7641b (trunk 15494). At the moment I managed to extract mostly all the changes from 7641a (e.g.... Stefanel Pezamosca

07:20 AM Bug #7641 (WIP): Lower the number of Map.get() calls in the persistence layer

> So, I tried to rebase, but I get that error with key already present in map. devsrv01 is too slow to do the rebase ... Alexandru Lungu

07:59 AM Bug #7496: finish support for query:forward-only attribute

I've managed to create unit tests based on the tests I've had for this issue (there were a lot more compared to what ... Dănuț Filimon

06:28 AM Bug #7496: finish support for query:forward-only attribute

I am currently working on replacing the old tests for this issue with unit tests. Dănuț Filimon

10/14/2024

06:44 AM Bug #9251: cache the translated FQL in FQLPreprocessor.translate

The recreate is this:... Constantin Asofiei

06:26 AM Bug #9251: cache the translated FQL in FQLPreprocessor.translate

> Alexandru: can you add this to the existing sprint?
Ok; do you have a small test-case in which that part of code... Alexandru Lungu

06:09 AM Bug #9251: cache the translated FQL in FQLPreprocessor.translate

We need a LRU cache for the @FQLPreprocessor.translate@ result. The cache key will be similar to existing FQL keys, ... Constantin Asofiei

06:07 AM Bug #9251 (Test): cache the translated FQL in FQLPreprocessor.translate

Constantin Asofiei

10/11/2024

10:56 AM Bug #7641: Lower the number of Map.get() calls in the persistence layer

So, I tried to rebase, but I get that error with key already present in map. devsrv01 is too slow to do the rebase th... Stefanel Pezamosca

04:40 AM Bug #7641: Lower the number of Map.get() calls in the persistence layer

Stefanel, please recap #7641 effort, rebase 7641a and review.
After, lets do some performance testing with it to und... Alexandru Lungu

04:14 AM Bug #7641: Lower the number of Map.get() calls in the persistence layer

Constantin - I wanted to remember you of this task, considering you have worked recently on performance matters. 7641... Alexandru Lungu

08:03 AM Bug #7496: finish support for query:forward-only attribute

Rebased *7496a* with *trunk/rev.15494*. *7496a* is now at revision *15504*. Dănuț Filimon

10/09/2024

10:53 AM Bug #9194: FWD selects the wrong index when using CONTAINS?

It's time for another blast from the past (maybe?). I'm going to take all of you back to #1587 (the ticket, not the y... Radu Apetrii

09:19 PM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data

The current solution I am trying to make it work is as follows:
* each @Database@ object should have a reference to ... Ovidiu Maxiniuc

10/08/2024

09:20 AM Bug #9194: FWD selects the wrong index when using CONTAINS?

I have created 9194a for further changes. First, I'll check why the word-index is not selected. After that, I'll see ... Radu Apetrii

02:03 AM Bug #9194: FWD selects the wrong index when using CONTAINS?

OK, thank you for your response and the one previous about the projects (I hadn't been made aware of this). Andy Edwards

09:08 AM Bug #9228: FQL to SQL conversion for CONTAINS when the output is expected to be always false is n...

Please update [[regression:Open Regressions in FWD v4]] with the status. Greg Shah

03:28 AM Bug #9228 (Test): FQL to SQL conversion for CONTAINS when the output is expected to be always fal...

Branch 9228a was merged to trunk rev 15483 and archived. Stefanel Pezamosca

02:02 AM Bug #9228 (Merge Pending): FQL to SQL conversion for CONTAINS when the output is expected to be a...

Stefanel Pezamosca wrote:
> I had the changes patched to my local trunk for a while now. I didn't encounter any obvi... Constantin Asofiei

10/07/2024

07:15 PM Bug #9194: FWD selects the wrong index when using CONTAINS?

Eric Faulhaber wrote:
> Andy Edwards wrote:
> > [...] FWD will not use the same WORD-INDEX rules as the 4GL so we w... Ovidiu Maxiniuc

03:03 PM Bug #9194: FWD selects the wrong index when using CONTAINS?

Andy Edwards wrote:
> Hi all, we have completed the "indeterminate sorting" review and are now starting to make the ... Eric Faulhaber

10:11 AM Bug #9228: FQL to SQL conversion for CONTAINS when the output is expected to be always false is n...

I had the changes patched to my local trunk for a while now. I didn't encounter any obvious issues while testing. Stefanel Pezamosca

05:13 AM Bug #9228: FQL to SQL conversion for CONTAINS when the output is expected to be always false is n...

Stefanel, please go ahead and test other projects. If they are OK, we can queue this for merge. Constantin Asofiei

10/04/2024

05:52 AM Bug #9194: FWD selects the wrong index when using CONTAINS?

Hi all, we have completed the "indeterminate sorting" review and are now starting to make the necessary changes, henc... Andy Edwards

03:42 AM Bug #9228: FQL to SQL conversion for CONTAINS when the output is expected to be always false is n...

I've tested ETF and is OK. I think we need to wait for 6667i to be merged, and after that we'll test some other apps... Constantin Asofiei

10/03/2024

09:29 AM Feature #9218: Changes in internal tenant management

> I adjusted the implementation of the tenant ID to match the one from 4GL. As result, at each server restart, the un... Greg Shah

09:16 AM Bug #9228 (Internal Test): FQL to SQL conversion for CONTAINS when the output is expected to be a...

Ovidiu Maxiniuc wrote:
> Revision of 9228a, r15478.
>
> I think the code will work fine. I have just a few notes ... Stefanel Pezamosca

08:52 AM Bug #9228: FQL to SQL conversion for CONTAINS when the output is expected to be always false is n...

Revision of 9228a, r15478.
I think the code will work fine. I have just a few notes to add:
* @FqlToSqlConverte... Ovidiu Maxiniuc

07:05 AM Bug #9228: FQL to SQL conversion for CONTAINS when the output is expected to be always false is n...

Ovidiu, please review. Constantin Asofiei

06:01 AM Bug #9228: FQL to SQL conversion for CONTAINS when the output is expected to be always false is n...

I committed to *9228a revision 15478* a fix for the wrong orderFields generation.
Please review. Stefanel Pezamosca

12:01 AM Bug #9228: FQL to SQL conversion for CONTAINS when the output is expected to be always false is n...

Constantin Asofiei wrote:
> Was your test with 6667i? Because this code does not check correctly for 'order by' AST... Stefanel Pezamosca

10/02/2024

03:18 PM Feature #9218: Changes in internal tenant management

I have cherry-picked the changes and put them in 9057a. Revision 15463. I hope the branch is not broken (compilable a... Ovidiu Maxiniuc

02:58 PM Feature #9218: Changes in internal tenant management

Ovidiu, is this work in a task branch yet? I'd like to look it over to get a better understanding of the changes. Eric Faulhaber

02:34 PM Feature #9218: Changes in internal tenant management

I adjusted the implementation of the tenant ID to match the one from 4GL. As result, at each server restart, the uniq... Ovidiu Maxiniuc

02:51 PM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data

Current status:
While the private tables in a tenant enabled database works correctly, the shared tables are still... Ovidiu Maxiniuc

02:31 PM Bug #9228: FQL to SQL conversion for CONTAINS when the output is expected to be always false is n...

Was your test with 6667i? Because this code does not check correctly for 'order by' ASTs, in the case when the sort ... Constantin Asofiei

01:57 PM Bug #9228: FQL to SQL conversion for CONTAINS when the output is expected to be always false is n...

Constantin Asofiei wrote:
> What's the FQL being converted here?
The one you discovered while testing with 6667i. Stefanel Pezamosca

01:49 PM Bug #9228: FQL to SQL conversion for CONTAINS when the output is expected to be always false is n...

What's the FQL being converted here? Constantin Asofiei

09:40 AM Bug #9228 (Review): FQL to SQL conversion for CONTAINS when the output is expected to be always f...

I have created task branch *9228a* from *trunk revision 15476*.
I committed the fix in *9228a revision 15477*. Ple... Stefanel Pezamosca

09:39 AM Bug #9228 (WIP): FQL to SQL conversion for CONTAINS when the output is expected to be always fals...

The issue is that for some cases CONTAINS parameter can be an empty string.
* 1. This should be picked up by @FQLPr... Stefanel Pezamosca

09:06 AM Bug #9228 (Test): FQL to SQL conversion for CONTAINS when the output is expected to be always fal...

Stefanel Pezamosca

10/01/2024

09:55 AM Bug #9224: conversion of sql table name honors FWD reserved words

A legacy table named @Property@ will have a sql table name of @Property_@ - this is because FWD has a reserved name t... Constantin Asofiei

09:52 AM Bug #9224 (New): conversion of sql table name honors FWD reserved words

Constantin Asofiei

08:47 AM Bug #9222: Validation of a record buffer throws an error in FWD, but does not in 4GL

This ticket is derived from #9181-10. Artur Școlnic

08:47 AM Bug #9222: Validation of a record buffer throws an error in FWD, but does not in 4GL

... Artur Școlnic

08:45 AM Bug #9222 (New): Validation of a record buffer throws an error in FWD, but does not in 4GL

Artur Școlnic

08:39 AM Feature #9218: Changes in internal tenant management

My concern is for any interface (now or introduced later) which takes that tenant id. It is just more secure if the ... Greg Shah

08:31 AM Feature #9218: Changes in internal tenant management

I did additional research and found "this":https://docs.progress.com/bundle/openedge-database-multitenancy-117/page/T... Ovidiu Maxiniuc

09/30/2024

02:38 PM Feature #9218: Changes in internal tenant management

> ** @0@ for default tenant,
> ** incrementing positive values for regular tenants
> ** decrementing negative valu... Greg Shah

02:23 PM Feature #9218: Changes in internal tenant management

After initial iteration implementation some changes in the management of FWD internal management of tenant feature.
... Ovidiu Maxiniuc

02:22 PM Feature #9218 (New): Changes in internal tenant management

Ovidiu Maxiniuc