FWD » Core Development » Database

11/09/2024

05:57 PM Bug #9267: Index Selection in case of a multiple index matches.

Eduard Soltan wrote:
> Committed on 9267a, rev. 15541.
Well, my 9267a only goes to revision 15527. Are we facing an... Radu Apetrii

11/08/2024

11:46 AM Bug #9267: Index Selection in case of a multiple index matches.

Added tests cases for general index selection rules on @tests/query/index/MainIndexTests.cls@. Eduard Soltan

06:40 AM Bug #8200 (Test): Explicit buffer used instead of the implicit one for a persistent table

Greg Shah

06:39 AM Bug #8200: Explicit buffer used instead of the implicit one for a persistent table

#8200 was solved in #8860. The changes were added in trunk rev. 15421. I will attach the converted test-case from #82... Andreea Bârzu

05:43 AM Feature #9302: new reports for abbreviated field names and abbreviated table names

Roger Borrello wrote:
> The code that is checked in does find abbreviated db/table/field in the fieldtype, and annot... Greg Shah

05:41 AM Feature #9302: new reports for abbreviated field names and abbreviated table names

> If there are 2 @'.'@ characters, that's a good indication that there are DB/table qualifiers.
A "good" indicatio... Greg Shah

09:03 PM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data

Eric Faulhaber wrote:
> Code review 9057a/15544-15551:
Thank you for the quick review.
> General question: throu... Ovidiu Maxiniuc

11/07/2024

05:58 PM Feature #9302: new reports for abbreviated field names and abbreviated table names

The code that is checked in does find abbreviated db/table/field in the fieldtype, and annotates:... Roger Borrello

05:53 PM Feature #9302: new reports for abbreviated field names and abbreviated table names

While the use of @EntityName@ is great for getting the precise name of the DB/table/field, trying to determine if the... Roger Borrello

03:35 PM Feature #9302: new reports for abbreviated field names and abbreviated table names

Make sure that any abbreviation uniquely references a single table or a single field (of a single table). So: @roo@ ... Greg Shah

03:24 PM Feature #9302: new reports for abbreviated field names and abbreviated table names

In trying to enlarge my testcase, it obvious I can't just hack out the tail end of table names and field names. For e... Roger Borrello

03:04 PM Feature #9302: new reports for abbreviated field names and abbreviated table names

Something else to mention: table abbreviations can appear in field references, too - see my example. So for @evalLib... Constantin Asofiei

02:52 PM Feature #9302: new reports for abbreviated field names and abbreviated table names

@evalLib("fieldtype", type)@ is correct for looking at fields. Use @evalLib("record_types")@ to look at table/buffer... Greg Shah

01:40 PM Feature #9302: new reports for abbreviated field names and abbreviated table names

If I understand correctly, I can use the @schemaname@ to breakdown the table and field. My current helper for *fields... Roger Borrello

01:23 PM Feature #9302: new reports for abbreviated field names and abbreviated table names

> I don't think the 'quirk' with the space before the field is relevant for this report.
Yes, you're right. We ha... Greg Shah

01:21 PM Feature #9302: new reports for abbreviated field names and abbreviated table names

> So @record.field@ can be @record. field@ or @record .field@ or @record . field@ ?
... Greg Shah

12:52 PM Feature #9302: new reports for abbreviated field names and abbreviated table names

Roger, I don't think the 'quirk' with the space before the field is relevant for this report.
See this example:
<... Constantin Asofiei

12:35 PM Feature #9302: new reports for abbreviated field names and abbreviated table names

So @record&#46;field@ can be @record&#46;&#32;field@ or @record&#32;&#46;field@ or @record&#32;&#46;&#32;field@ ? Tha... Roger Borrello

11:56 AM Feature #9302: new reports for abbreviated field names and abbreviated table names

From our parser:... Greg Shah

11:38 AM Feature #9302: new reports for abbreviated field names and abbreviated table names

Greg Shah wrote:
> The @original-text@ annotation comes from the parser, so it will already be there *if it is going... Roger Borrello

11:34 AM Feature #9302: new reports for abbreviated field names and abbreviated table names

The @original-text@ annotation comes from the parser, so it will already be there *if it is going to be there*.
To... Greg Shah

11:28 AM Feature #9302: new reports for abbreviated field names and abbreviated table names

Greg Shah wrote:
> Recall that you must handle the fact that the @text@ can be qualified (@db.table.field@, @db.tabl... Roger Borrello

11:14 AM Feature #9302: new reports for abbreviated field names and abbreviated table names

> I plan to determine if the length of the @text@ doesn't match the length of the appropriate location in @schemaname... Greg Shah

11:10 AM Feature #9302: new reports for abbreviated field names and abbreviated table names

Yes, forget about ambiguous. The issue here is abbreviations. Greg Shah

11:08 AM Feature #9302: new reports for abbreviated field names and abbreviated table names

Parsing wouldn't work if the names were ambiguous, correct? In other words, tables in the DB are "best-dream" and "be... Roger Borrello

11:02 AM Feature #9302: new reports for abbreviated field names and abbreviated table names

Note from customer:
> Erm I think just database tables?
>
> *slli-claim-goods-val* which should be *slli-claim-go... Roger Borrello

09:32 AM Feature #9302: new reports for abbreviated field names and abbreviated table names

If a table is named @rogers-fav@, then an abbreviated name would be "rog" or "roge" or "roger" or...
The concept i... Greg Shah

09:31 AM Feature #9302: new reports for abbreviated field names and abbreviated table names

Sorry, I should not have used "ambiguous". That is something completely different. We are needing to identify abbre... Greg Shah

08:18 AM Feature #9302: new reports for abbreviated field names and abbreviated table names

Is this an example of an ambiguous field name?... Roger Borrello

07:00 PM Feature #9302: new reports for abbreviated field names and abbreviated table names

@eliminate_field_abbreviations.xml@ isn't used in any conversion or report. It just shows some example code that imp... Greg Shah

02:59 PM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data

Code review 9057a/15544-15551:
General question: throughout the changes, there are a number of "TODO 9057" tags ad... Eric Faulhaber

10:29 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data

I have rebased the branch successfully. The current revision is 15551, based on trunk 15543.
Ready for review, but p... Ovidiu Maxiniuc

09:45 AM Bug #9267: Index Selection in case of a multiple index matches.

Committed on 9267a, rev. 15541.
Tested regression test projects and a large customer application unit test. Source... Eduard Soltan

02:00 AM Bug #9267: Index Selection in case of a multiple index matches.

Ovidiu Maxiniuc wrote:
> I looked at 9267a, rev. 15525/6, but I have some difficulties understanding the logic. I wi... Eduard Soltan

09:08 PM Bug #9267: Index Selection in case of a multiple index matches.

I looked at 9267a, rev. 15525/6, but I have some difficulties understanding the logic. I will go deeper tomorrow.
... Ovidiu Maxiniuc

07:29 AM Bug #7737 (Test): QueryWrapper should either show or throw errors depending on the query type

Matching status with #7496, the changes reached trunk/15530 as part of the 7496a branch. Dănuț Filimon

07:28 AM Bug #7737 (Internal Test): QueryWrapper should either show or throw errors depending on the query...

Dănuț Filimon

03:05 AM Feature #9305: Replace begins with interval based conditional

This is deferred work from #8495 and refers to the replacement of @expr1 begins expr2@ with @expr1 >= low_bound and e... Alexandru Lungu

03:03 AM Feature #9305 (WIP): Replace begins with interval based conditional

Alexandru Lungu

01:31 AM Bug #9078: emit FindQuery as (reused) variables

One thing that I want to mention is that there were no @error: code too large@ problems and an ongoing "issue". You c... Dănuț Filimon

01:18 AM Bug #9078: emit FindQuery as (reused) variables

I managed to successfully convert a large customer application and after looking a bit of the sources I did not notic... Dănuț Filimon

11/06/2024

02:50 PM Feature #9302: new reports for abbreviated field names and abbreviated table names

Greg Shah wrote:
> Please create 2 reports for:
>
> * Abbreviated Field Names
> * Abbreviated Table Names
>
>... Roger Borrello

09:47 AM Feature #9302: new reports for abbreviated field names and abbreviated table names

In @reports.rules@, there is a recent addition for nested finds:... Roger Borrello

07:48 PM Feature #9302: new reports for abbreviated field names and abbreviated table names

Please create 2 reports for:
* Abbreviated Field Names
* Abbreviated Table Names
You will need to create 2 hel... Greg Shah

07:47 PM Feature #9302 (Closed): new reports for abbreviated field names and abbreviated table names

Greg Shah

09:31 AM Bug #9078: emit FindQuery as (reused) variables

Committed *9078a/15541*. Reinitialize the query when the bound buffers are different.
Left 20% for making adjustm... Dănuț Filimon

07:34 AM Bug #9078: emit FindQuery as (reused) variables

Constantin Asofiei wrote:
> Dănuț Filimon wrote:
> > Constantin Asofiei wrote:
> > > The only way to initialize th... Dănuț Filimon

07:27 AM Bug #9078: emit FindQuery as (reused) variables

Dănuț Filimon wrote:
> Constantin Asofiei wrote:
> > The only way to initialize the FIND is via @FindQuery.initiali... Constantin Asofiei

07:25 AM Bug #9078: emit FindQuery as (reused) variables

Constantin Asofiei wrote:
> The only way to initialize the FIND is via @FindQuery.initialize@, right?
Not quite, th... Dănuț Filimon

07:17 AM Bug #9078: emit FindQuery as (reused) variables

The only way to initialize the FIND is via @FindQuery.initialize@, right? All DMOs (the proxy) are there, save them ... Constantin Asofiei

07:00 AM Bug #9078: emit FindQuery as (reused) variables

Constantin Asofiei wrote:
> See the AdaptiveFind issue: a buffer can switch its bound buffer at any time. But other... Dănuț Filimon

07:47 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data

Radu Apetrii wrote:
> Or not. Next to the revision number there was a @[merge]@, and I assumed it came from trunk, b... Ovidiu Maxiniuc

07:02 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data

Radu Apetrii wrote:
> Rev. 15533 seems to be with things from the trunk, but please correct me if I'm wrong.
Or not... Radu Apetrii

06:33 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data

I assume the revisions that need reviewing are 15526-15532 inclusively. Rev. 15533 seems to be with things from the t... Radu Apetrii

07:13 AM Bug #9267: Index Selection in case of a multiple index matches.

*I committed some of my changes regarding index selection on @9267a, rev. 15526@.*
The changes are quite minimal, ... Andrei Plugaru

02:05 AM Bug #9267: Index Selection in case of a multiple index matches.

Sorry, my branch was unbind. I pushed on 9267a, rev. 15524. Eduard Soltan

07:29 PM Bug #9267: Index Selection in case of a multiple index matches.

I checked the devsrv01, the last revision of 9267a is indeed 15524, from 2024-10-30. Ovidiu Maxiniuc

11/05/2024

03:04 PM Bug #9267: Index Selection in case of a multiple index matches.

Eduard Soltan wrote:
> I committed on 9267a, rev. 15531.
Eduard, are you sure the branch was bound when you commit... Radu Apetrii

09:54 AM Bug #9267: Index Selection in case of a multiple index matches.

Eduard Soltan wrote:
> Radu Apetrii wrote:
> > Oh, that's great then. As long as we have the cases talked in this t... Eduard Soltan

09:53 AM Bug #9267: Index Selection in case of a multiple index matches.

Radu Apetrii wrote:
> OK, then, if you agree, we'll split the work as following:
> * Eduard: create the testcases f... Eduard Soltan

09:48 AM Bug #9267: Index Selection in case of a multiple index matches.

Radu Apetrii wrote:
> Oh, that's great then. As long as we have the cases talked in this task covered, I'm good.
... Eduard Soltan

07:51 AM Bug #9267: Index Selection in case of a multiple index matches.

Eduard Soltan wrote:
> > * Radu: I'll look into #9267-36 and see what I can deduce.
>
> If you need more assistan... Radu Apetrii

07:48 AM Bug #9267: Index Selection in case of a multiple index matches.

First of all, don't ask me what I searched to get to this pdf. Secondly, it seems that we were right: persistent tabl... Radu Apetrii

07:30 AM Bug #9267: Index Selection in case of a multiple index matches.

Radu Apetrii wrote:
> OK, then, if you agree, we'll split the work as following:
> * Eduard: create the testcases... Eduard Soltan

06:48 AM Bug #9267: Index Selection in case of a multiple index matches.

Eduard Soltan wrote:
> Radu Apetrii wrote:
>
> > I think we're going to need an example for each of these cases. ... Radu Apetrii

06:40 AM Bug #9267: Index Selection in case of a multiple index matches.

Radu Apetrii wrote:
> I think we're going to need an example for each of these cases. If Eduard is not available r... Eduard Soltan

06:40 AM Bug #9267: Index Selection in case of a multiple index matches.

Alexandru Lungu wrote:
> > OK, an update to this: I believe the alphabetical order is for the "static" index definit... Radu Apetrii

06:36 AM Bug #9267: Index Selection in case of a multiple index matches.

> OK, an update to this: I believe the alphabetical order is for the "static" index definitions, or in other words, t... Alexandru Lungu

06:32 AM Bug #9267: Index Selection in case of a multiple index matches.

I've also added Eric as a watcher to this discussion. I don't know why he wasn't here in the first place. Radu Apetrii

06:30 AM Bug #9267: Index Selection in case of a multiple index matches.

Radu Apetrii wrote:
> Does this mean that the order in which we define the indexes is the tie-breaker here? If so, ... Radu Apetrii

10:41 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data

Eric and Radu: please review. Greg Shah

09:15 AM Feature #9057 (Review): enable intermixed access to default tenant (shared) data and tenant-speci...

I added intermixed access support for some of the methods above. In fact only for those where I was able to identify ... Ovidiu Maxiniuc

07:23 AM Bug #9078: emit FindQuery as (reused) variables

Fixed an action and removed the check in *9078a/15540*. Dănuț Filimon

07:10 AM Bug #9078: emit FindQuery as (reused) variables

Committed *9078a/15539*. Addressed #9078-47.
I think something like ... Dănuț Filimon

03:18 AM Bug #9078: emit FindQuery as (reused) variables

Alexandru Lungu wrote:
> > From my understanding, there are no longer queries without a name. Each FindQuery will ha... Dănuț Filimon

03:07 AM Bug #9078: emit FindQuery as (reused) variables

> From my understanding, there are no longer queries without a name. Each FindQuery will have a name, even if it is n... Alexandru Lungu

03:05 AM Bug #9078 (WIP): emit FindQuery as (reused) variables

Constantin Asofiei wrote:
> Review of 9078a/15537:
> ** is it ever possible for @<rule>toplvlref != null and toplvl... Dănuț Filimon

02:51 AM Bug #9078: emit FindQuery as (reused) variables

Review of 9078a/15537:
* @hasAncestorLoopingInnerBlock@ - this needs to look through all 'inner_block', not just the... Constantin Asofiei

11/04/2024

10:12 AM Bug #9267: Index Selection in case of a multiple index matches.

Radu Apetrii wrote:
>
> Does this mean that the order in which we define the indexes is the tie-breaker here? If s... Eduard Soltan

09:23 AM Bug #9267: Index Selection in case of a multiple index matches.

Constantin Asofiei wrote:
> There are documented rules for index selection here: [[p2j:Chapter_27_Sorting_Query_Resu... Radu Apetrii

08:06 AM Bug #9267: Index Selection in case of a multiple index matches.

There are documented rules for index selection here: [[p2j:Chapter_27_Sorting_Query_Results]]
We should update thi... Constantin Asofiei

07:42 AM Bug #9267: Index Selection in case of a multiple index matches.

Radu Apetrii wrote:
>
> Here, Progress and FWD trunk choose @idx1@. With the 9267a changes, @idx2@ is selected.
... Eduard Soltan

06:46 AM Bug #9267 (WIP): Index Selection in case of a multiple index matches.

Greg Shah

06:41 AM Bug #9267: Index Selection in case of a multiple index matches.

OK, so, here's the testcase:
Table definition:
{{collapse... Radu Apetrii

02:58 AM Bug #9267: Index Selection in case of a multiple index matches.

Eduard: I got informed by a customer of a query that uses the wrong index now (with the 9267a changes), and was using... Radu Apetrii

09:46 AM Bug #9078: emit FindQuery as (reused) variables

Committed *9078a/15538*.
* Extended field initialization in FindQuery to support the new conversion changes. Field... Dănuț Filimon

04:27 AM Bug #7496 (Test): finish support for query:forward-only attribute

Branch 7496a was merged into trunk as rev. 15530 and archived. Dănuț Filimon

04:17 AM Bug #7496 (Merge Pending): finish support for query:forward-only attribute

Please merge 7496a to trunk now. Alexandru Lungu

11/02/2024

09:33 PM Bug #9267: Index Selection in case of a multiple index matches.

Eduard Soltan wrote:
> Conversion of a customer GUI application finished successfully. Also tested unit tests, with ... Ovidiu Maxiniuc

11/01/2024

04:29 PM Feature #7020: always use "expanded" extent fields

Ovidiu Maxiniuc wrote:
> I understand now. The problem is @display ttw.f1[i] with frame f3.@. Note the variable @i@ ... Hynek Cihlar

01:21 PM Feature #7020: always use "expanded" extent fields

I understand now. The problem is @display ttw.f1[i] with frame f3.@. Note the variable @i@ as index in @ext1b.p@ as o... Ovidiu Maxiniuc

10:08 AM Feature #7020: always use "expanded" extent fields

Ovidiu Maxiniuc wrote:
> Does the build fail because of the missing accessors?
This is the compilation error:
<p... Roger Borrello

10:27 AM Bug #9267: Index Selection in case of a multiple index matches.

I finished testing another customer application after reconversion. Results of unit tests and smoke testing GUI are p... Andrei Iacob

07:55 AM Bug #9267: Index Selection in case of a multiple index matches.

I finished testing another customer application. The result is positive, everything went fine. ✅ Radu Apetrii

02:42 AM Bug #9267: Index Selection in case of a multiple index matches.

Conversion of a customer GUI application finished successfully. Also tested unit tests, with no regression.
Pushed... Eduard Soltan

09:53 AM Bug #9078 (Review): emit FindQuery as (reused) variables

Constantin, as discussed, please review the changes when you have time. Dănuț Filimon

07:06 AM Bug #9078: emit FindQuery as (reused) variables

Committed *9078a/15537*. Fixed wrong order of emitted FindQuery variable. Dănuț Filimon

05:57 AM Bug #9078: emit FindQuery as (reused) variables

Committed *9078a/15536*.
* Only emit a FindQuery as a variable for looping inner blocks.
* Fixed #9032-42.
* Cl... Dănuț Filimon

10/31/2024

07:53 PM Feature #7020: always use "expanded" extent fields

Roger,
I looked at the code. I do not see what the problem is. The only difference which is probably visible in ap... Ovidiu Maxiniuc

04:00 PM Feature #7020: always use "expanded" extent fields

Constantin provided a simple example in #8805-64 where this is in a persistent DB:... Roger Borrello

11:02 AM Bug #9078: emit FindQuery as (reused) variables

I've managed to get a stable conversion with the new changes, but I found this case that needs to be investigated:
<... Dănuț Filimon

10/30/2024

02:18 PM Bug #9267: Index Selection in case of a multiple index matches.

Made the necessary changes on 9267a, revision 15524.
I will redo the conversion of a customer application this eve... Eduard Soltan

11:50 AM Bug #9267 (Internal Test): Index Selection in case of a multiple index matches.

+Review of 9267a r15523.+
I must admit it is strange that simple find queries and 'looping' queries use different ... Ovidiu Maxiniuc

08:01 AM Bug #9267: Index Selection in case of a multiple index matches.

Radu Apetrii wrote:
> I'm gonna assume that I need to re-run the conversion for that customer application. I've alre... Eduard Soltan

07:25 AM Bug #9267: Index Selection in case of a multiple index matches.

Eduard Soltan wrote:
> I made some changes to reflect behaviour from #9267-20 in 9267a, rev. 15523. Please review.
... Radu Apetrii

07:16 AM Bug #9267: Index Selection in case of a multiple index matches.

I made some changes to reflect behaviour from #9267-20 in 9267a, rev. 15523. Please review. Eduard Soltan

03:46 AM Bug #9267: Index Selection in case of a multiple index matches.

Ovidiu Maxiniuc wrote:
> I did analyse at the sources posted on devsrv01. Definitely, the ones generated by 9267a lo... Eduard Soltan

10:15 AM Bug #9078: emit FindQuery as (reused) variables

Constantin Asofiei wrote:
> Danut, the @FindQuery@ var def should be similar to the @OPEN QUERY@ var def - see @con... Dănuț Filimon

10:02 AM Bug #9078: emit FindQuery as (reused) variables

Danut, the @FindQuery@ var def should be similar to the @OPEN QUERY@ var def - see @convert/database_access.rules@ a... Constantin Asofiei

06:06 AM Bug #9078: emit FindQuery as (reused) variables

Constantin Asofiei wrote:
> Dănuț Filimon wrote:
> > Constantin, at this point the conversion changes for #9032-2 a... Dănuț Filimon

05:53 AM Bug #9078: emit FindQuery as (reused) variables

Dănuț Filimon wrote:
> Constantin, at this point the conversion changes for #9032-2 are implemented, but during yest... Constantin Asofiei

05:37 AM Bug #9078: emit FindQuery as (reused) variables

Rebased *9078a* with *trunk/15526*, the branch is now at revision *15535*. Dănuț Filimon

05:25 AM Bug #9078: emit FindQuery as (reused) variables

Committed *9078a/15525*.
* FIND statements are annotated using "fqryname" annotation instead of "qryname". Because t... Dănuț Filimon

10/29/2024

03:08 PM Bug #9267: Index Selection in case of a multiple index matches.

Review of 9267a, r15522.
The changes do make sense. Please add the H entry.
I did analyse at the sources posted... Ovidiu Maxiniuc

10:14 AM Bug #9267: Index Selection in case of a multiple index matches.

Eduard Soltan wrote:
> Please review 9267a, rev. 15522.
>
> I have tests with regression changes project, and a l... Eduard Soltan

10:07 AM Bug #9267 (Review): Index Selection in case of a multiple index matches.

Please review 9267a, rev. 15522.
I have tests with regression changes project, and a large customer GUI app. The r... Eduard Soltan

10:04 AM Bug #9267 (WIP): Index Selection in case of a multiple index matches.

Eduard Soltan

09:51 AM Bug #9267: Index Selection in case of a multiple index matches.

Radu Apetrii wrote:
> The point here is that @idx2@ and the @WHERE@ clause share a prefix of fields, but they are no... Eduard Soltan

09:45 AM Bug #9267: Index Selection in case of a multiple index matches.

So, I've attached the @.df@ used. It's a basic @test@ persistent table with three indexes: one primary unique one (wh... Radu Apetrii

09:31 AM Bug #9267: Index Selection in case of a multiple index matches.

Sure, go ahead. Eduard Soltan

09:31 AM Bug #9267: Index Selection in case of a multiple index matches.

It seems that 9267a fixes my issue from #8357-140. Eduard, if you want, I can post here a small testcase with what I ... Radu Apetrii

08:54 AM Bug #9267: Index Selection in case of a multiple index matches.

Added my testcases on @tests/query/index/IndexSelectionExactMatching.cls@.
Out of 13 tests:
- 6 test fails with... Eduard Soltan

07:34 AM Bug #9078: emit FindQuery as (reused) variables

Fixed #9078-33 in *9078a/15524*. Dănuț Filimon

05:00 AM Bug #9078: emit FindQuery as (reused) variables

Committed *9078a/15523*. Added the fix mentioned in #9078-32. Dănuț Filimon

04:46 AM Bug #9078: emit FindQuery as (reused) variables

This one also:... Dănuț Filimon

04:42 AM Bug #9078: emit FindQuery as (reused) variables

I found a new fix for #9078-28, after converting hotel_gui and comparing the old and new conversions, I found the fol... Dănuț Filimon

03:16 AM Bug #9078: emit FindQuery as (reused) variables

Dănuț Filimon wrote:
> 9078a/15521 commit reverts most of the effort done for 9078a. I will have to think of another... Dănuț Filimon

10/28/2024

10:08 AM Bug #9078: emit FindQuery as (reused) variables

9078a/15521 commit reverts most of the effort done for 9078a. I will have to think of another solution. Dănuț Filimon

09:44 AM Bug #9078: emit FindQuery as (reused) variables

Dănuț Filimon wrote:
> Dănuț Filimon wrote:
> > I discovered a new conversion issue while testing hotel_gui so I am... Dănuț Filimon

06:51 AM Bug #9078: emit FindQuery as (reused) variables

Dănuț Filimon wrote:
> I discovered a new conversion issue while testing hotel_gui so I am currently investigating i... Dănuț Filimon

06:41 AM Bug #9078: emit FindQuery as (reused) variables

Committed *9078a/15520*. Modified CAN-FIND conversion to match the FIND statement conversion.
I discovered a new c... Dănuț Filimon

04:12 AM Bug #9078: emit FindQuery as (reused) variables

Committed *9078a/15519*. Support FindQuery constructor conversion as a variable scoped to the top level block.
TOD... Dănuț Filimon

03:06 AM Bug #7496: finish support for query:forward-only attribute

*7496a* can be merged. Dănuț Filimon

10/25/2024

09:49 AM Bug #7496: finish support for query:forward-only attribute

Rebased *7496a* with *trunk/rev.15523*. *7496a* is now at revision *15534*. Dănuț Filimon

09:36 AM Bug #7496: finish support for query:forward-only attribute

After retesting, performance is not affected. (-1% from baseline) Ioana-Cristina Prioteasa

08:59 AM Bug #7496: finish support for query:forward-only attribute

I updated the test plan status from #7496-76 with the latest results. The test plan was completed and there were no r... Dănuț Filimon

06:44 AM Bug #7496: finish support for query:forward-only attribute

I applied the changes over 7156c rev. 15501. I will redo the testing today, I will update when they are done. ETA: 3h. Ioana-Cristina Prioteasa

03:58 AM Bug #7496: finish support for query:forward-only attribute

Ioana-Cristina Prioteasa wrote:
> Applied 7496 changes over 7156c. The total time for a performance round has gone f... Dănuț Filimon

09:23 AM Bug #9267: Index Selection in case of a multiple index matches.

Radu, let me do you one better: https://proj.goldencode.com/artifacts/javadoc/latest/api/com/goldencode/p2j/schema/pa... Alexandru Lungu

09:05 AM Bug #9267: Index Selection in case of a multiple index matches.

If needed, there is also this wiki page "Index Selection":https://proj.goldencode.com/projects/p2j/wiki/Chapter_27_So... Radu Apetrii

04:11 AM Bug #9267: Index Selection in case of a multiple index matches.

Alexandru Lungu wrote:
> Eduard, can you augment the xfer testcases on index_selection with some of your findings an... Eduard Soltan

04:11 AM Bug #9267: Index Selection in case of a multiple index matches.

Eduard, can you augment the xfer testcases on index_selection with some of your findings and test that as well: make ... Alexandru Lungu

03:58 AM Bug #9267: Index Selection in case of a multiple index matches.

I comitted my change on 9267a, rev. 15522.
With this change, in *findLeadingIndexMatch* in case we have multiple i... Eduard Soltan

02:41 AM Bug #9267: Index Selection in case of a multiple index matches.

> Looking at calcIndexSelection it will always return a single index. Do you know whether that is intentional or sele... Alexandru Lungu

08:03 AM Bug #9078: emit FindQuery as (reused) variables

I've managed to find a fix for #9078-22, it involved searching for a top level block that has a top level ancestor an... Dănuț Filimon

07:17 AM Bug #9078: emit FindQuery as (reused) variables

I've managed to fix #9078-21, there was another rule whre the FindQuery constructor was created so I had to change it... Dănuț Filimon

03:01 AM Bug #9078: emit FindQuery as (reused) variables

I have trouble differentiating between the top block execute method and top block class method. Because of #9078-20 a... Dănuț Filimon

07:26 AM Bug #9034: FindQuery unique fails in a self join context

I committed 9034a_h2/53, it addressed the review points from #9034-12 and the issue discussed in #9034-17.
deleted Artur Școlnic

06:13 AM Bug #9034: FindQuery unique fails in a self join context

This is how the code looked before any FWD-H2 specific changes:... Alexandru Lungu

05:24 AM Bug #9034: FindQuery unique fails in a self join context

Alexandru, during testing of 9134a_h2, I encountered some issue with the @next@ method in @TreeCursor@:... Artur Școlnic

03:30 AM Bug #9034: FindQuery unique fails in a self join context

> Review of 9034a:
These were change local on my side, ignore review. Alexandru Lungu

10/24/2024

09:39 AM Bug #9267: Index Selection in case of a multiple index matches.

... Eduard Soltan

07:51 AM Bug #9078: emit FindQuery as (reused) variables

Another known problem where the FindQuery is not properly converted:... Dănuț Filimon

07:15 AM Bug #9078: emit FindQuery as (reused) variables

Alexandru Lungu wrote:
> I am not sure if the FindQuery should be generated as a class member anyway. Its scope can ... Dănuț Filimon

07:07 AM Bug #9078: emit FindQuery as (reused) variables

I am not sure if the FindQuery should be generated as a class member anyway. Its scope can remain there. Otherwise, f... Alexandru Lungu

07:06 AM Bug #9078: emit FindQuery as (reused) variables

Committed *9078a/15518*. Added a default constructor for FindQuery so that the converted code compiles. Dănuț Filimon

06:50 AM Bug #9078: emit FindQuery as (reused) variables

The issue was related to adding an annotation to @this@ and not @copy@, after this I managed to make a few more chang... Dănuț Filimon

04:31 AM Bug #9078: emit FindQuery as (reused) variables

Dănuț Filimon wrote:
> I am currently working on adding a "qryname" annotation to each find query (not just for the ... Dănuț Filimon

03:14 AM Bug #9078: emit FindQuery as (reused) variables

I am currently working on adding a "qryname" annotation to each find query (not just for the AdaptiveFind) but I am f... Dănuț Filimon

03:55 AM Bug #7496: finish support for query:forward-only attribute

Applied 7496 changes over 7156c. The total time for a performance round has gone from *38.4s to 44.1s, 14% slowdown.*... Ioana-Cristina Prioteasa

10/23/2024

09:02 AM Bug #9274: Analyze how creatingBuffer is relevant after the introduction of multiplyReferenced DMOs

This task is about the relevance of @RecordBuffer.creatingBuffer@.
Recently, FWD added support for multiplyReferen... Alexandru Lungu

08:45 AM Bug #9274 (New): Analyze how creatingBuffer is relevant after the introduction of multiplyReferen...

Alexandru Lungu

05:33 AM Bug #7496: finish support for query:forward-only attribute

Alexandru Lungu wrote:
> I am OK with the changes in rev. 15505.
> Please also run performance tests - contact [icp... Dănuț Filimon

05:22 AM Bug #7496 (Internal Test): finish support for query:forward-only attribute

I am OK with the changes in rev. 15505.
Please also run performance tests - contact [icp] for the performance tests ... Alexandru Lungu

05:01 AM Bug #7496: finish support for query:forward-only attribute

Testing finished successfully:
* Smoke test 3 GUI application
* Harness test
* 2 customer unit tests
Testing le... Dănuț Filimon

05:28 AM Bug #9034 (WIP): FindQuery unique fails in a self join context

Review of 9034a:
* remove oo imports from RAQ
* add history entry for @DirectAccessHelper@
* remove changes from E... Alexandru Lungu

05:16 AM Bug #9078: emit FindQuery as (reused) variables

I think I get it ... there is no link between the columns. So on line 1, there are actual 3 different find queries.
... Alexandru Lungu

04:33 AM Bug #9078: emit FindQuery as (reused) variables

Alexandru Lungu wrote:
> What does first place mean? Is the same FIND Query 1022 times in a constructor, 111403 in a... Dănuț Filimon

04:21 AM Bug #9078: emit FindQuery as (reused) variables

What does first place mean? Is the same FIND Query 1022 times in a constructor, 111403 in an execute and 883905 in an... Alexandru Lungu

03:59 AM Bug #9078: emit FindQuery as (reused) variables

After a retest of the scenario mentioned in #9078, I managed to gather the following information:
* Instances create... Dănuț Filimon

10/22/2024

07:49 AM Bug #9078: emit FindQuery as (reused) variables

After a quick analysis I found the following:
* Instances created: *6900539*
* Instances created in a constructor c... Dănuț Filimon

05:10 AM Bug #9078: emit FindQuery as (reused) variables

Dănuț Filimon wrote:
> * A part of the analysis can be done on the converted code (how many FindQuery instances can ... Constantin Asofiei

04:27 AM Bug #9078: emit FindQuery as (reused) variables

My plan is to analyze a customer application (using a test scenario) for:
* The number of total FindQuery instances ... Dănuț Filimon

03:48 AM Bug #9078 (WIP): emit FindQuery as (reused) variables

Dănuț Filimon

06:26 AM Bug #7496: finish support for query:forward-only attribute

I finished running the unit tests of a customer and found 2 tests regressing in 2 modules, but after retesting with @... Dănuț Filimon

01:21 AM Bug #7496: finish support for query:forward-only attribute

I've started testing 7496a using the unit tests of a customer last night and it got stuck on a module (infinite loop)... Dănuț Filimon

10/21/2024

05:57 PM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data

New update.
I am advancing with identifying and choosing the right physical database when some API from persistenc... Ovidiu Maxiniuc

07:57 AM Bug #7496 (Review): finish support for query:forward-only attribute

*Committed 7496a/15505*. Fixed error handling for static and dynamic queries, removed unnecessary boolean parameter. ... Dănuț Filimon

07:37 AM Bug #7496: finish support for query:forward-only attribute

Dănuț Filimon wrote:
> The @queryForward()@ method does not take into account that the query might be closed, the er... Dănuț Filimon

07:27 AM Bug #7496: finish support for query:forward-only attribute

The following example:... Dănuț Filimon

07:03 AM Bug #7496 (WIP): finish support for query:forward-only attribute

I'll put the issue in WIP a bit until I am done investigating #7496-66. Dănuț Filimon

07:01 AM Bug #7496: finish support for query:forward-only attribute

Oh I see, it is a difference on the method called - you are right. Alexandru Lungu

06:58 AM Bug #7496: finish support for query:forward-only attribute

Alexandru Lungu wrote:
> * There are some places where @ ErrorManager.recordOrShowError(3159, String.format(errMsg, ... Dănuț Filimon

06:43 AM Bug #7496: finish support for query:forward-only attribute

Review of #7496:
* I am OK with the changes
* There are some places where @ ErrorManager.recordOrShowError(3159, St... Alexandru Lungu

06:35 AM Bug #7496: finish support for query:forward-only attribute

I started investigating the failing tests and made the following change:... Dănuț Filimon

06:08 AM Bug #7496 (Review): finish support for query:forward-only attribute

Alexandru Lungu wrote:
> It is normal to have the same number of P2J queries. In an @AdaptiveQuery@ it either choose... Dănuț Filimon

06:01 AM Bug #7496: finish support for query:forward-only attribute

It is normal to have the same number of P2J queries. In an @AdaptiveQuery@ it either chooses to use @ProgressiveResul... Alexandru Lungu

05:53 AM Bug #7496: finish support for query:forward-only attribute

I compared the p2j-query__temp.log of the Startup + warmup + 5 runs of the extented performance scenario of a custome... Dănuț Filimon

10/18/2024

02:25 AM Bug #9251: cache the translated FQL in FQLPreprocessor.translate

> Good catch. Stefanel: please add check at the top of FQLPreprocessor.translate, if the where clause is null, just e... Stefanel Pezamosca

10/17/2024

11:51 AM Bug #9251: cache the translated FQL in FQLPreprocessor.translate

Ovidiu Maxiniuc wrote:
> # the synchronization. In @AbstractQuery.translateSort()@ and also in @FQLPreprocessor.tran... Constantin Asofiei

11:39 AM Bug #9251: cache the translated FQL in FQLPreprocessor.translate

Stefanel Pezamosca wrote:
> I committed to *revision 15501*: Added caching for translateSort(RecordBuffer, RecordBuf... Ovidiu Maxiniuc

03:41 AM Bug #9251 (Test): cache the translated FQL in FQLPreprocessor.translate

Branch 9251a was merged into trunk as rev. 15503 and archived. Stefanel Pezamosca

03:12 AM Bug #9251 (Merge Pending): cache the translated FQL in FQLPreprocessor.translate

The changes look good. I've ran ETF and #9214 and they are OK.
You can merge to trunk now. Constantin Asofiei

09:23 AM Bug #7496: finish support for query:forward-only attribute

This is really good stuff, Danut! Alexandru Lungu

08:53 AM Bug #7496: finish support for query:forward-only attribute

Good news! I've expanded the unit tests and included the adaptive tests (that use temp-tables) after rewriting them a... Dănuț Filimon

09:10 AM Bug #9267: Index Selection in case of a multiple index matches.

The following change drove down the change in @IndexSelectionWorker@ from trunk/ rev. 15486:... Eduard Soltan

08:33 AM Bug #9267 (Test): Index Selection in case of a multiple index matches.

Eduard Soltan

10/16/2024

08:46 AM Bug #9251: cache the translated FQL in FQLPreprocessor.translate

I committed to *revision 15501*: Added caching for translateSort(RecordBuffer, RecordBuffer, String) output.
Please ... Stefanel Pezamosca

07:10 AM Bug #9251: cache the translated FQL in FQLPreprocessor.translate

Stefanel Pezamosca wrote:
> First try: it seems like caching the @translateSort@ output does not bring any improveme... Constantin Asofiei

06:52 AM Bug #9251 (Review): cache the translated FQL in FQLPreprocessor.translate

First try: it seems like caching the @translateSort@ output does not bring any improvements.
Please review the tra... Stefanel Pezamosca

04:54 AM Bug #9251 (WIP): cache the translated FQL in FQLPreprocessor.translate

I have created *branch 9251a* from *trunk revision 15498*.
I committed to *revision 15499* the implementation for ca... Stefanel Pezamosca

05:25 AM Bug #9262: batch assign updates the dirty database on each assignment

Yes, in 7156c the @RecordNursery@ will hold onto all inserts/updates till the first query will occur. This is how tru... Alexandru Lungu

05:01 AM Bug #9262 (Hold): batch assign updates the dirty database on each assignment

Yes, with 7156c @DirtyShareContext.insert@ is being called on batch end, so assuming the changes in 7156c will reach ... Constantin Asofiei

04:17 AM Bug #9262: batch assign updates the dirty database on each assignment

Can you do a similar test with 7156c? 7156c has a reword of @RecordNursery@ and how the dirty changes are registered.... Alexandru Lungu

03:32 AM Bug #9262: batch assign updates the dirty database on each assignment

I found some cases where @DirtyShareContext.insert@ is being called on each assignment in a batch assign, and not jus... Constantin Asofiei

03:27 AM Bug #9262 (Hold): batch assign updates the dirty database on each assignment

Constantin Asofiei

10/15/2024

08:35 AM Bug #7641: Lower the number of Map.get() calls in the persistence layer

I have created branch 7641b (trunk 15494). At the moment I managed to extract mostly all the changes from 7641a (e.g.... Stefanel Pezamosca

07:20 AM Bug #7641 (WIP): Lower the number of Map.get() calls in the persistence layer

> So, I tried to rebase, but I get that error with key already present in map. devsrv01 is too slow to do the rebase ... Alexandru Lungu

07:59 AM Bug #7496: finish support for query:forward-only attribute

I've managed to create unit tests based on the tests I've had for this issue (there were a lot more compared to what ... Dănuț Filimon

06:28 AM Bug #7496: finish support for query:forward-only attribute

I am currently working on replacing the old tests for this issue with unit tests. Dănuț Filimon

10/14/2024

06:44 AM Bug #9251: cache the translated FQL in FQLPreprocessor.translate

The recreate is this:... Constantin Asofiei

06:26 AM Bug #9251: cache the translated FQL in FQLPreprocessor.translate

> Alexandru: can you add this to the existing sprint?
Ok; do you have a small test-case in which that part of code... Alexandru Lungu

06:09 AM Bug #9251: cache the translated FQL in FQLPreprocessor.translate

We need a LRU cache for the @FQLPreprocessor.translate@ result. The cache key will be similar to existing FQL keys, ... Constantin Asofiei

06:07 AM Bug #9251 (Test): cache the translated FQL in FQLPreprocessor.translate

Constantin Asofiei