Project

General

Profile

Activity

From 10/29/2024 to 11/27/2024

11/28/2024

10:30 PM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Committed revision 15600 of 9057a. It contains the changes noted in above discussion (review). Ovidiu Maxiniuc

11/27/2024

05:19 PM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Eric Faulhaber wrote:
> * I reviewed the changes, but it is hard to review for possible missing changes, such as pla...
Ovidiu Maxiniuc
02:41 PM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Code review 9057a/15578-15598:
Big update! In part, this is because I have re-reviewed the older revisions I revie...
Eric Faulhaber
01:37 PM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Never done, in the new format. I will try to. Ovidiu Maxiniuc
12:55 PM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Ovidiu Maxiniuc wrote:
> I've just done that. Committed revision 15599.
>
> I wanted to test them but for some st...
Eric Faulhaber
12:39 PM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
I've just done that. Committed revision 15599.
I wanted to test them but for some strange causes, the project fail...
Ovidiu Maxiniuc
12:35 PM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Alexandru Lungu wrote:
> I was successful in converting and compiling some part of the direct Java code. However, I ...
Eric Faulhaber
10:01 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
I was successful in converting and compiling some part of the direct Java code. However, I got to a point where there... Alexandru Lungu
08:38 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Status update:
* I addressed the issues reported by Constantin in note #9057-38 and Alexandru in #9057-39. Committe...
Ovidiu Maxiniuc
06:08 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Testing ETF, in the conversion the only change is a new line which no longer exists between the var def and the @forE... Constantin Asofiei
03:02 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Ovidiu, I am sorry, but I missed:... Alexandru Lungu
02:58 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Ovidiu, please remove this debug line:
> src/com/goldencode/p2j/persist/orm/SessionFactory.java:381: ...
Constantin Asofiei
09:34 PM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Added TRPL documentation on MT processing.
Committed revision 15597.
Ovidiu Maxiniuc
09:33 AM Bug #9365 (Test): The active buffer is no longer set for getters, so _getClob is not working
Artur Școlnic
09:30 AM Bug #9365: The active buffer is no longer set for getters, so _getClob is not working
9365a is merged to trunk as rev 15579. Artur Școlnic
09:21 AM Bug #9365 (Merge Pending): The active buffer is no longer set for getters, so _getClob is not wor...
I am OK with the changes in 9365a. Please merge to trunk now. Alexandru Lungu
08:44 AM Bug #9365: The active buffer is no longer set for getters, so _getClob is not working
I committed rev 15578 and tested it, the testing went ok. Artur Școlnic
07:30 AM Bug #9365 (Internal Test): The active buffer is no longer set for getters, so _getClob is not wor...
Review of 15577:
* I think there is a confusion. I was looking into a branch older than rev. 15573 in which the ac...
Alexandru Lungu
06:21 AM Bug #9365: The active buffer is no longer set for getters, so _getClob is not working
Made the discussed changes, committed rev 15577 and added @TestCLOBGetter.cls@ to the testcases project. Artur Școlnic
05:39 AM Bug #9365: The active buffer is no longer set for getters, so _getClob is not working
I think we need more consistency with the moment when the active buffer is set and @activeBufferSet@ flag is used. So... Alexandru Lungu
05:34 AM Bug #9365: The active buffer is no longer set for getters, so _getClob is not working
Alexandru Lungu wrote:
> Can you describe what are the possible cases in which this addition in required?
This is ...
Artur Școlnic
05:15 AM Bug #9365: The active buffer is no longer set for getters, so _getClob is not working
> If you mean if (bmd.batchDepth != BatchModeData.NOT_ACTIVE && !bmd.dirtyBatchBuffers.containsKey(buffer)), then yes... Alexandru Lungu
04:57 AM Bug #9365: The active buffer is no longer set for getters, so _getClob is not working
Alexandru Lungu wrote:
> Review of 9365a:
> * is @BufferManager@ change still needed?
If you mean @if (bmd.batchDe...
Artur Școlnic
04:35 AM Bug #9365: The active buffer is no longer set for getters, so _getClob is not working
Review of 9365a:
* I am OK with the set/restore mechanism.
* is @BufferManager@ change still needed?
* you also ha...
Alexandru Lungu
04:06 AM Bug #9365: The active buffer is no longer set for getters, so _getClob is not working
The largest app unit test regression testing passed. I could think of a single scenario where the issue discussed in ... Artur Școlnic
07:34 AM Feature #6441: compatible collation for UTF-8 databases
From #9378-8 :
This looks like is just how @en_US.UTF-8@ collation works, and is not a postgresql problem, but a c...
Constantin Asofiei
05:34 AM Bug #7496: finish support for query:forward-only attribute
Rebased *7496c* to latest *trunk/15578* and the branch is now at revision *7496c/15579*. Dănuț Filimon
05:24 AM Bug #7496: finish support for query:forward-only attribute
Test plan:
* large customer application harness and run some reports. (Harness passed, tested 4 reports and those al...
Dănuț Filimon
03:29 AM Bug #7496: finish support for query:forward-only attribute
Committed *xfer testcases/1655*:
* adaptive scrolling tests in @fwd_tests/persist/queries/@
* forward-only tests ...
Dănuț Filimon

11/26/2024

12:33 PM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Done. I did a quick smoke test to check at least it compiles correctly.
I am going on with tests as described in #90...
Ovidiu Maxiniuc
11:30 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Alexandru,
Thank you for reporting this.
I encountered similar issue when I did some tests with the large applicat...
Ovidiu Maxiniuc
10:00 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Ovidiu, I started looking into 9057a, but I failed running @ant deploy@ on the ChUi regression tests because it uses ... Alexandru Lungu
09:35 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Ovidiu, should I test 9057a? There is also a 9057b, that is why I am asking. Alexandru Lungu
09:27 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Eric Faulhaber wrote:
> Ovidiu, don't you need to rebase the branch?
I've just done the rebase. The current revisio...
Ovidiu Maxiniuc
03:33 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
I attempted to patch 7156c with the changes from 9057a, but did not succeed, the patch is over 10k lines, 7156c and t... Artur Școlnic
11:45 PM Feature #9057 (Review): enable intermixed access to default tenant (shared) data and tenant-speci...
Ovidiu, don't you need to rebase the branch? Eric Faulhaber
08:16 PM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
I think I have finished the multi-tenant specific implementation. The latest commit is 15586 in branch 9057a.
Since ...
Ovidiu Maxiniuc
09:46 AM Bug #9365: The active buffer is no longer set for getters, so _getClob is not working
Artur, please also design a small 4GL Unit Test suite with this edge case and add it to your existing suite. Also tes... Alexandru Lungu
09:45 AM Bug #9365 (Review): The active buffer is no longer set for getters, so _getClob is not working
I made the necessary changes and committed 15576, meanwhile I started a large app unit test module for testing. Artur Școlnic
08:53 AM Bug #9365 (WIP): The active buffer is no longer set for getters, so _getClob is not working
Alexandru Lungu
07:32 AM Bug #9365: The active buffer is no longer set for getters, so _getClob is not working
I wanted to be consistent with the way the restore is happening for all buffers, but I guess this is not imperative f... Artur Școlnic
07:28 AM Bug #9365: The active buffer is no longer set for getters, so _getClob is not working
> but if is is used in a batch assign, then it's state can't be restored in the invoke of the getter, it has to be at... Alexandru Lungu
06:25 AM Bug #9365: The active buffer is no longer set for getters, so _getClob is not working
@getterActiveBuffers@ has a similar functionality to @dirtyBathBuffers@ In a simple assign case, we can just check if... Artur Școlnic
05:37 AM Bug #9365: The active buffer is no longer set for getters, so _getClob is not working
*My understanding of the problem and proposed solution*: The problem is that CLOB field getters don't have an active ... Alexandru Lungu
09:45 AM Bug #9194 (WIP): FWD selects the wrong index when using CONTAINS?
I've committed to 9194a rev. 15578 a really small change:
* I re-enabled the selection of word-indexes.
Next, we ...
Radu Apetrii
07:27 AM Bug #7496: finish support for query:forward-only attribute
Alexandru Lungu wrote:
> adaptive_scrolling should clearly go into fwd_tests (maybe persist/queries folder?).
I was...
Dănuț Filimon
07:25 AM Bug #7496: finish support for query:forward-only attribute
adaptive_scrolling should clearly go into fwd_tests (maybe persist/queries folder?).
forward_only depends ... the ...
Alexandru Lungu
06:04 AM Bug #7496: finish support for query:forward-only attribute
Alexandru Lungu wrote:
> Also please extend xfer 4GL unit test suite with your examples.
Should I commit the adap...
Dănuț Filimon
05:11 AM Bug #7496 (Internal Test): finish support for query:forward-only attribute
*Review of 7496c/15558*
* The changes aim to notify the @AdaptiveQuery@ when the delegate of the @ProgressiveResul...
Alexandru Lungu
05:07 AM Bug #9383: Cache only the current delegate on transaction commit if a ProgressiveResults is used
An observation as part of #7496 (especially #7496-92), the @ProgressiveResults@ are not cached if it uses a @SimpleRe... Alexandru Lungu
05:04 AM Bug #9383 (Test): Cache only the current delegate on transaction commit if a ProgressiveResults i...
Alexandru Lungu

11/25/2024

10:22 AM Bug #9194: FWD selects the wrong index when using CONTAINS?
Radu Apetrii wrote:
> I think I'll run the same test with Hotel next.
Well, nothing changed in Hotel with word-inde...
Radu Apetrii
09:04 AM Bug #9194: FWD selects the wrong index when using CONTAINS?
Eric, if you want to take a look at the files, you can check both @.diff@ files, they aren't that large. Keep in mind... Radu Apetrii
06:51 AM Bug #9194: FWD selects the wrong index when using CONTAINS?
Soo, I can finally make an update. I will attach a couple of files:
* A @start.p@ which contains 7 query examples wr...
Radu Apetrii
08:52 AM Bug #9318: Make record nursery visible on removeRecords
From #8959-19:
> The only limitation is that deleteIndex should come from the converted code and requires conversion...
Dănuț Filimon
07:42 AM Bug #9318 (WIP): Make record nursery visible on removeRecords
Dănuț Filimon
07:38 AM Bug #9318: Make record nursery visible on removeRecords
9275a was merged recently to trunk. The same changes reached 7156c at some point. Danut, please take over this as par... Alexandru Lungu
07:57 AM Bug #9317: FIRST/LAST clauses can avoid generating sub-selects if the WHERE clause matches a uniq...
PS: Mind that @FqlPreprocessor.preprocess@ does the whole work. It iterates the AST *multiple times*, so there are se... Alexandru Lungu
07:44 AM Bug #9317: FIRST/LAST clauses can avoid generating sub-selects if the WHERE clause matches a uniq...
Ioana, please focus on detecting how @dropAlias@ and @replacementAlias@ are relevant and why we need to computed them... Alexandru Lungu
07:43 AM Bug #7641: Lower the number of Map.get() calls in the persistence layer
Alexandru Lungu wrote:
> I think we already invested to much effort on too little results for #7641. I will reject t...
Stefanel Pezamosca
07:39 AM Bug #7641 (Rejected): Lower the number of Map.get() calls in the persistence layer
I think we already invested to much effort on too little results for #7641. I will reject this task. Stefanel, please... Alexandru Lungu
06:25 AM Bug #9365 (Review): The active buffer is no longer set for getters, so _getClob is not working
@isBatchAssignMode@ looks in the current scope, so in the case from note 1, @tt2@ won't be added to the dirty batch b... Artur Școlnic
06:23 AM Bug #9365 (WIP): The active buffer is no longer set for getters, so _getClob is not working
Artur Școlnic

11/23/2024

10:15 PM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Yesterday I implemented the runtime support for the @setMultiTenantAlternative()@ to be method injected in case of po... Ovidiu Maxiniuc

11/22/2024

05:29 AM Bug #9365: The active buffer is no longer set for getters, so _getClob is not working
After the following change:... Alexandru Lungu
03:55 AM Bug #9365 (Test): The active buffer is no longer set for getters, so _getClob is not working
Alexandru Lungu
03:09 AM Bug #7496: finish support for query:forward-only attribute
I've tested 7496c/15558 using the unit tests of a large customer and did not find any regressions. Dănuț Filimon

11/21/2024

07:59 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Greg Shah wrote:
> > a new set of FindQuery APIs which would accept both tuple of (fql, client-where, args). I think...
Ovidiu Maxiniuc
07:27 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Carson Mader wrote:
> Will the runtime still support running in single-tenant and multi-tenant mode without the need...
Greg Shah
07:17 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Will the runtime still support running in single-tenant and multi-tenant mode without the need for a conversion when ... Carson Mader
06:44 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
> a new set of FindQuery APIs which would accept both tuple of (fql, client-where, args). I think we can keep the cur... Greg Shah
06:09 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Yes, I did think of something like that, but since it involved changes in generated code, I kept it a plan B.
Ther...
Ovidiu Maxiniuc
04:34 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Are you expecting conversion to be specific to MT in this case? It would be the first thing that was hard coded in t... Greg Shah
07:45 PM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Update on my latest effort to get done the last known multiple-tenant issue described above.
The compound queries ...
Ovidiu Maxiniuc
05:36 AM Bug #9251 (Test): cache the translated FQL in FQLPreprocessor.translate
Branch 9251b was merged into trunk as rev. 15572 and archived. Stefanel Pezamosca
05:27 AM Bug #9251 (Merge Pending): cache the translated FQL in FQLPreprocessor.translate
You can merge to trunk now. Greg Shah
04:49 AM Bug #9251: cache the translated FQL in FQLPreprocessor.translate
9251b should have been merged to trunk. It's just a null check. Stefanel Pezamosca
04:46 AM Bug #9251: cache the translated FQL in FQLPreprocessor.translate
What are the next steps with 9251b? Greg Shah
05:03 AM Bug #7496 (Review): finish support for query:forward-only attribute
*Committed 7496c/15558*. When the delegate of ProgressiveResults closes, the AdaptiveQuery.resultsCached should be se... Dănuț Filimon
04:11 AM Bug #7496: finish support for query:forward-only attribute
Dănuț Filimon wrote:
> I am now thinking on how to _notify_ the AdaptiveQuery that it's results (ProgressiveResults)...
Dănuț Filimon
07:11 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
Eugenie Lyzenko wrote:
> Does it require reconversion?
No.
Roger Borrello
07:05 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
Roger,
Does it require reconversion?
Eugenie Lyzenko

11/20/2024

06:56 PM Feature #9302 (Closed): new reports for abbreviated field names and abbreviated table names
Greg Shah
06:45 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
*Merge notification for task branch 9302a*
Branch 9302a was merged to trunk as revision 15571 and archived.
* A...
Roger Borrello
06:32 PM Feature #9302 (Merge Pending): new reports for abbreviated field names and abbreviated table names
You can merge to trunk now. Greg Shah
06:14 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
There isn't anything left to do with this task. I've rebased the branch to 15577. Roger Borrello
06:09 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
That's fine. We'll just document the Custom Reports:
|_. Field |_. Value |
| Report Type | ...
Roger Borrello
05:53 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
The multiple buckets version is the useful case for actually interacting with the report online.
If we need this k...
Greg Shah
05:47 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
Greg Shah wrote:
> Instead of setting @dumpType@, you set @dumpExpr@.
That works great... this is a very useful r...
Roger Borrello
05:02 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
> Is there a way to set the match expression in the profile.rpt?
Instead of setting @dumpType@, you set @dumpExpr@...
Greg Shah
04:44 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
I have a good report that aggregates all the details so an export contains all the matches:... Roger Borrello
09:31 AM Bug #7496: finish support for query:forward-only attribute
Dănuț Filimon wrote:
> The strangest part now, I'd expect a rollback / the transaction to be committed (the TRANSACT...
Dănuț Filimon
05:00 AM Bug #7496: finish support for query:forward-only attribute
I've tracked the issue and found the following:
* In @ProgressiveResults.moveTo()@, the @position@ is @236@, it scro...
Dănuț Filimon

11/19/2024

08:00 AM Bug #9317: FIRST/LAST clauses can avoid generating sub-selects if the WHERE clause matches a uniq...
The need for a subselect is currently determined in two places:
# @QueryComponent.getWhere()@:...
Ioana-Cristina Prioteasa

11/18/2024

05:02 PM Feature #7020: always use "expanded" extent fields
Greg Shah wrote:
> Ovidiu: What is the list of remaining work/testing to finish this task?
I have committed revis...
Ovidiu Maxiniuc
08:13 AM Feature #7020: always use "expanded" extent fields
Ovidiu Maxiniuc wrote:
> As far as I can remember, 7020c is the latest revision. I did not removed (archived) 7020b ...
Stefanel Pezamosca
08:08 AM Feature #7020: always use "expanded" extent fields
Stefanel Pezamosca wrote:
> I have locally rebased 7020b branch to trunk revision 15561. @./gradlew all@ works, but ...
Ovidiu Maxiniuc
07:41 AM Feature #7020: always use "expanded" extent fields
I have locally rebased 7020b branch to trunk revision 15561. @./gradlew all@ works, but functionality remains to be t... Stefanel Pezamosca
08:44 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
I have committed a new revision of 9057a (r15574, was rebased to trunk 15560).
It contains clarifications for all ...
Ovidiu Maxiniuc
07:52 AM Bug #9317: FIRST/LAST clauses can avoid generating sub-selects if the WHERE clause matches a uniq...
This is right! However, the optimization shouldn't be only on OUTER-JOIN; it can be used for non-outer join queries. ... Alexandru Lungu
07:22 AM Bug #9317 (WIP): FIRST/LAST clauses can avoid generating sub-selects if the WHERE clause matches ...
h3. Testcase
The schema consists of two persistent tables, @table1@ and @table2@, with the following characteristi...
Ioana-Cristina Prioteasa
03:38 AM Bug #9267: Index Selection in case of a multiple index matches.
Updated [[p2j:Chapter_27_Sorting_Query_Results#section-18]], with new index selection rule (4.1). Eduard Soltan
03:20 AM Bug #9034: FindQuery unique fails in a self join context
9034a_h2 was merged to FWD-H2 trunk as rev 54. Artur Școlnic
03:11 AM Bug #9034: FindQuery unique fails in a self join context
Please go ahead and merge 9034a_h2 to FWD-H2 trunk. Alexandru Lungu
02:10 AM Bug #9034: FindQuery unique fails in a self join context
I am ready to merge 9034a_h2. Artur Școlnic
03:18 AM Bug #9347: Refactor the breakTie method fro temp-tables.
This task is a follow up for #9267-44.
The way to break the tie between multiples indices choices should be refacto...
Eduard Soltan
03:12 AM Bug #9347 (New): Refactor the breakTie method fro temp-tables.
Eduard Soltan

11/16/2024

05:27 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
Greg Shah wrote:
> > So the report now looks like this, although I'm pressed for time, and haven't been able to tes...
Roger Borrello

11/15/2024

11:47 AM Feature #7020: always use "expanded" extent fields
Ovidiu: What is the list of remaining work/testing to finish this task? Greg Shah
10:00 AM Bug #9267 (Test): Index Selection in case of a multiple index matches.
Eduard Soltan
09:56 AM Bug #9267: Index Selection in case of a multiple index matches.
Branch 9267a was merged into trunk revision 15561. Eduard Soltan
09:29 AM Bug #9267 (Merge Pending): Index Selection in case of a multiple index matches.
I am mostly OK with 9267a. This seems to be a quirky case that requires special attention when computing the selected... Alexandru Lungu
07:26 AM Bug #9078: emit FindQuery as (reused) variables
#9078-63 can be ignored, after looking into the structure of the table there is an additional field similar to @field... Dănuț Filimon
06:40 AM Bug #9078: emit FindQuery as (reused) variables
I think I might have been chasing a totally different bug in a customer application (a bit weird), the following quer... Dănuț Filimon
06:55 AM Feature #8834: add bootstrap configuration support for -db OE command line parameter (and related...
> Are @-H@, @-S@ and @-P@ used only for the db? If so, it's best to have an array of custom objects with all the conf... Greg Shah
02:14 AM Bug #7496 (WIP): finish support for query:forward-only attribute
From Constantin in #7143-1302:
> There is a regression in trunk rev 15530 when running ETF test:
> ...
Dănuț Filimon

11/14/2024

03:53 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
> The use of @record_types_rel@ threw me... should I be using that in the check for abbreviations instead of @evalLib... Greg Shah
03:05 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
I'm trying to keep this moving along in my spare time, so I'm still peeking at emails. See revision 15563.
The use...
Roger Borrello
08:38 AM Feature #9302: new reports for abbreviated field names and abbreviated table names
Greg Shah wrote:
> @condition="evalLib("record_types_rel", this) and this.getAnnotation("tablename_ab...
Constantin Asofiei
07:51 AM Feature #9302: new reports for abbreviated field names and abbreviated table names
Code Review Task Branch 9302a Revisions 15556 and 15557
This is much better.
1. Unless you have found that data...
Greg Shah
04:36 AM Bug #9078: emit FindQuery as (reused) variables
Danut, the scenario would be like this, but OE doesn't allow unbind/re-bind of an already bound reference-only table ... Constantin Asofiei

11/13/2024

05:36 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
> My guess is that trying to include database abbreviations is just a waste.
I would say so, since database names...
Greg Shah
11:14 AM Feature #9302: new reports for abbreviated field names and abbreviated table names
The customer's application ran reports fine, and I was able to see the number of table/field abbreviations. My guess ... Roger Borrello
05:06 AM Bug #9078: emit FindQuery as (reused) variables
Constantin, do you have any test case where the bound buffers can differ? I tried getting a snippet from a customer a... Dănuț Filimon
08:55 PM Feature #9057 (WIP): enable intermixed access to default tenant (shared) data and tenant-specific...
I have committed a new incremental revision on 9057a (r15555).
Changes:
* the buffers are re-initialized (their per...
Ovidiu Maxiniuc

11/12/2024

05:37 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
Greg Shah wrote:
> You can use it to parse @text@ like this:
>
> @en2 = create("com.goldencode.p2j.schema.EntityN...
Roger Borrello
04:51 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
Roger Borrello wrote:
> I am not sold on @EntityName@, partly because there isn't many solid examples, and also it b...
Roger Borrello
04:25 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
I am not sold on @EntityName@, partly because there isn't many solid examples, and also it blew up on Hotel GUI. The ... Roger Borrello
04:06 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
> When we get to the @text@, how can I use @EntityName@ to parse? I need a leg up on that, because it is kind of free... Greg Shah
03:49 PM Feature #9302 (Review): new reports for abbreviated field names and abbreviated table names
Greg Shah wrote:
> Code Review Task Branch 9302a Revisions 15553 through 15555
>
> I think you should separate th...
Roger Borrello
03:06 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
Code Review Task Branch 9302a Revisions 15553 through 15555
I think you should separate the table and field proces...
Greg Shah
01:16 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
Roger Borrello wrote:
> Please review branch 15555 as I believe I have a solution to both tables and fields (and dat...
Roger Borrello
12:55 PM Feature #9302 (WIP): new reports for abbreviated field names and abbreviated table names
Please review branch 15555 as I believe I have a solution to both tables and fields (and databases) to be able to ann... Roger Borrello
09:51 AM Feature #9302: new reports for abbreviated field names and abbreviated table names
Roger Borrello wrote:
> Greg Shah wrote:
> > Make @fieldname_abbreviated@ a @boolean@. Same for @tablename_abbrevi...
Greg Shah
09:20 AM Feature #9302: new reports for abbreviated field names and abbreviated table names
Greg Shah wrote:
> Make @fieldname_abbreviated@ a @boolean@. Same for @tablename_abbreviated@. It just tells someo...
Roger Borrello
08:13 AM Feature #9302: new reports for abbreviated field names and abbreviated table names
Make @fieldname_abbreviated@ a @boolean@. Same for @tablename_abbreviated@. It just tells someone that the field or... Greg Shah
05:41 AM Bug #9267: Index Selection in case of a multiple index matches.
> Alex/Eric/Greg: So, are we waiting for something else, or can this be merged into trunk?
I understand that testi...
Alexandru Lungu
04:49 AM Bug #9267: Index Selection in case of a multiple index matches.
Radu Apetrii wrote:
> Eduard Soltan wrote:
> > - another GUI app, Radu did the conversion and query report. No regr...
Radu Apetrii
04:48 AM Bug #9267: Index Selection in case of a multiple index matches.
Eduard Soltan wrote:
> - another GUI app, Radu did the conversion and query report. No regression.
It was reported ...
Radu Apetrii

11/11/2024

06:46 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
Greg Shah wrote:
> Yes, tables cannot be fields.
I think we are not communicating well. How do you see this annot...
Roger Borrello
12:19 PM Bug #6767: Possible name clashes in DMO classes
Vladimir Tsichevski wrote:
> The work redone in the branch 6767b, The branch is rebased to trunk rev. 14906 the bran...
Vladimir Tsichevski
09:31 AM Bug #9267 (Review): Index Selection in case of a multiple index matches.
Radu Apetrii wrote:
> Well, my 9267a only goes to revision 15527. Are we facing another "unbound" issue or did I do ...
Eduard Soltan
09:24 AM Bug #9318: Make record nursery visible on removeRecords
> @containsRecordBufferDmo@ was a quick fix to have the 6667i branch fast tracked into trunk. It was a very aggressiv... Alexandru Lungu
09:23 AM Bug #9318 (Review): Make record nursery visible on removeRecords
Alexandru Lungu
07:57 AM Bug #9317: FIRST/LAST clauses can avoid generating sub-selects if the WHERE clause matches a uniq...
For optimized compound queries that have FIRST/LAST components, FWD emits something like:... Alexandru Lungu
07:53 AM Bug #9317 (Closed): FIRST/LAST clauses can avoid generating sub-selects if the WHERE clause match...
Alexandru Lungu
04:54 AM Bug #9034 (Internal Test): FindQuery unique fails in a self join context
I am OK with the changes in 9034a_h2. Please go ahead and merge to the FWD_H2 trunk. From my understanding, 9034a sho... Alexandru Lungu

11/09/2024

05:57 PM Bug #9267: Index Selection in case of a multiple index matches.
Eduard Soltan wrote:
> Committed on 9267a, rev. 15541.
Well, my 9267a only goes to revision 15527. Are we facing an...
Radu Apetrii

11/08/2024

11:46 AM Bug #9267: Index Selection in case of a multiple index matches.
Added tests cases for general index selection rules on @tests/query/index/MainIndexTests.cls@. Eduard Soltan
06:40 AM Bug #8200 (Test): Explicit buffer used instead of the implicit one for a persistent table
Greg Shah
06:39 AM Bug #8200: Explicit buffer used instead of the implicit one for a persistent table
#8200 was solved in #8860. The changes were added in trunk rev. 15421. I will attach the converted test-case from #82... Andreea Bârzu
05:43 AM Feature #9302: new reports for abbreviated field names and abbreviated table names
Roger Borrello wrote:
> The code that is checked in does find abbreviated db/table/field in the fieldtype, and annot...
Greg Shah
05:41 AM Feature #9302: new reports for abbreviated field names and abbreviated table names
> If there are 2 @'.'@ characters, that's a good indication that there are DB/table qualifiers.
A "good" indicatio...
Greg Shah
09:03 PM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Eric Faulhaber wrote:
> Code review 9057a/15544-15551:
Thank you for the quick review.
> General question: throu...
Ovidiu Maxiniuc

11/07/2024

05:58 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
The code that is checked in does find abbreviated db/table/field in the fieldtype, and annotates:... Roger Borrello
05:53 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
While the use of @EntityName@ is great for getting the precise name of the DB/table/field, trying to determine if the... Roger Borrello
03:35 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
Make sure that any abbreviation uniquely references a single table or a single field (of a single table). So: @roo@ ... Greg Shah
03:24 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
In trying to enlarge my testcase, it obvious I can't just hack out the tail end of table names and field names. For e... Roger Borrello
03:04 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
Something else to mention: table abbreviations can appear in field references, too - see my example. So for @evalLib... Constantin Asofiei
02:52 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
@evalLib("fieldtype", type)@ is correct for looking at fields. Use @evalLib("record_types")@ to look at table/buffer... Greg Shah
01:40 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
If I understand correctly, I can use the @schemaname@ to breakdown the table and field. My current helper for *fields... Roger Borrello
01:23 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
> I don't think the 'quirk' with the space before the field is relevant for this report.
Yes, you're right. We ha...
Greg Shah
01:21 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
> So @record.field@ can be @record. field@ or @record .field@ or @record . field@ ?
...
Greg Shah
12:52 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
Roger, I don't think the 'quirk' with the space before the field is relevant for this report.
See this example:
<...
Constantin Asofiei
12:35 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
So @record&#46;field@ can be @record&#46;&#32;field@ or @record&#32;&#46;field@ or @record&#32;&#46;&#32;field@ ? Tha... Roger Borrello
11:56 AM Feature #9302: new reports for abbreviated field names and abbreviated table names
From our parser:... Greg Shah
11:38 AM Feature #9302: new reports for abbreviated field names and abbreviated table names
Greg Shah wrote:
> The @original-text@ annotation comes from the parser, so it will already be there *if it is going...
Roger Borrello
11:34 AM Feature #9302: new reports for abbreviated field names and abbreviated table names
The @original-text@ annotation comes from the parser, so it will already be there *if it is going to be there*.
To...
Greg Shah
11:28 AM Feature #9302: new reports for abbreviated field names and abbreviated table names
Greg Shah wrote:
> Recall that you must handle the fact that the @text@ can be qualified (@db.table.field@, @db.tabl...
Roger Borrello
11:14 AM Feature #9302: new reports for abbreviated field names and abbreviated table names
> I plan to determine if the length of the @text@ doesn't match the length of the appropriate location in @schemaname... Greg Shah
11:10 AM Feature #9302: new reports for abbreviated field names and abbreviated table names
Yes, forget about ambiguous. The issue here is abbreviations. Greg Shah
11:08 AM Feature #9302: new reports for abbreviated field names and abbreviated table names
Parsing wouldn't work if the names were ambiguous, correct? In other words, tables in the DB are "best-dream" and "be... Roger Borrello
11:02 AM Feature #9302: new reports for abbreviated field names and abbreviated table names
Note from customer:
> Erm I think just database tables?
>
> *slli-claim-goods-val* which should be *slli-claim-go...
Roger Borrello
09:32 AM Feature #9302: new reports for abbreviated field names and abbreviated table names
If a table is named @rogers-fav@, then an abbreviated name would be "rog" or "roge" or "roger" or...
The concept i...
Greg Shah
09:31 AM Feature #9302: new reports for abbreviated field names and abbreviated table names
Sorry, I should not have used "ambiguous". That is something completely different. We are needing to identify abbre... Greg Shah
08:18 AM Feature #9302: new reports for abbreviated field names and abbreviated table names
Is this an example of an ambiguous field name?... Roger Borrello
07:00 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
@eliminate_field_abbreviations.xml@ isn't used in any conversion or report. It just shows some example code that imp... Greg Shah
02:59 PM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Code review 9057a/15544-15551:
General question: throughout the changes, there are a number of "TODO 9057" tags ad...
Eric Faulhaber
10:29 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
I have rebased the branch successfully. The current revision is 15551, based on trunk 15543.
Ready for review, but p...
Ovidiu Maxiniuc
09:45 AM Bug #9267: Index Selection in case of a multiple index matches.
Committed on 9267a, rev. 15541.
Tested regression test projects and a large customer application unit test. Source...
Eduard Soltan
02:00 AM Bug #9267: Index Selection in case of a multiple index matches.
Ovidiu Maxiniuc wrote:
> I looked at 9267a, rev. 15525/6, but I have some difficulties understanding the logic. I wi...
Eduard Soltan
09:08 PM Bug #9267: Index Selection in case of a multiple index matches.
I looked at 9267a, rev. 15525/6, but I have some difficulties understanding the logic. I will go deeper tomorrow.
...
Ovidiu Maxiniuc
07:29 AM Bug #7737 (Test): QueryWrapper should either show or throw errors depending on the query type
Matching status with #7496, the changes reached trunk/15530 as part of the 7496a branch. Dănuț Filimon
07:28 AM Bug #7737 (Internal Test): QueryWrapper should either show or throw errors depending on the query...
Dănuț Filimon
03:05 AM Feature #9305: Replace begins with interval based conditional
This is deferred work from #8495 and refers to the replacement of @expr1 begins expr2@ with @expr1 >= low_bound and e... Alexandru Lungu
03:03 AM Feature #9305 (WIP): Replace begins with interval based conditional
Alexandru Lungu
01:31 AM Bug #9078: emit FindQuery as (reused) variables
One thing that I want to mention is that there were no @error: code too large@ problems and an ongoing "issue". You c... Dănuț Filimon
01:18 AM Bug #9078: emit FindQuery as (reused) variables
I managed to successfully convert a large customer application and after looking a bit of the sources I did not notic... Dănuț Filimon

11/06/2024

02:50 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
Greg Shah wrote:
> Please create 2 reports for:
>
> * Abbreviated Field Names
> * Abbreviated Table Names
>
>...
Roger Borrello
09:47 AM Feature #9302: new reports for abbreviated field names and abbreviated table names
In @reports.rules@, there is a recent addition for nested finds:... Roger Borrello
07:48 PM Feature #9302: new reports for abbreviated field names and abbreviated table names
Please create 2 reports for:
* Abbreviated Field Names
* Abbreviated Table Names
You will need to create 2 hel...
Greg Shah
07:47 PM Feature #9302 (Closed): new reports for abbreviated field names and abbreviated table names
Greg Shah
09:31 AM Bug #9078: emit FindQuery as (reused) variables
Committed *9078a/15541*. Reinitialize the query when the bound buffers are different.
Left 20% for making adjustm...
Dănuț Filimon
07:34 AM Bug #9078: emit FindQuery as (reused) variables
Constantin Asofiei wrote:
> Dănuț Filimon wrote:
> > Constantin Asofiei wrote:
> > > The only way to initialize th...
Dănuț Filimon
07:27 AM Bug #9078: emit FindQuery as (reused) variables
Dănuț Filimon wrote:
> Constantin Asofiei wrote:
> > The only way to initialize the FIND is via @FindQuery.initiali...
Constantin Asofiei
07:25 AM Bug #9078: emit FindQuery as (reused) variables
Constantin Asofiei wrote:
> The only way to initialize the FIND is via @FindQuery.initialize@, right?
Not quite, th...
Dănuț Filimon
07:17 AM Bug #9078: emit FindQuery as (reused) variables
The only way to initialize the FIND is via @FindQuery.initialize@, right? All DMOs (the proxy) are there, save them ... Constantin Asofiei
07:00 AM Bug #9078: emit FindQuery as (reused) variables
Constantin Asofiei wrote:
> See the AdaptiveFind issue: a buffer can switch its bound buffer at any time. But other...
Dănuț Filimon
07:47 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Radu Apetrii wrote:
> Or not. Next to the revision number there was a @[merge]@, and I assumed it came from trunk, b...
Ovidiu Maxiniuc
07:02 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Radu Apetrii wrote:
> Rev. 15533 seems to be with things from the trunk, but please correct me if I'm wrong.
Or not...
Radu Apetrii
06:33 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
I assume the revisions that need reviewing are 15526-15532 inclusively. Rev. 15533 seems to be with things from the t... Radu Apetrii
07:13 AM Bug #9267: Index Selection in case of a multiple index matches.
*I committed some of my changes regarding index selection on @9267a, rev. 15526@.*
The changes are quite minimal, ...
Andrei Plugaru
02:05 AM Bug #9267: Index Selection in case of a multiple index matches.
Sorry, my branch was unbind. I pushed on 9267a, rev. 15524. Eduard Soltan
07:29 PM Bug #9267: Index Selection in case of a multiple index matches.
I checked the devsrv01, the last revision of 9267a is indeed 15524, from 2024-10-30. Ovidiu Maxiniuc

11/05/2024

03:04 PM Bug #9267: Index Selection in case of a multiple index matches.
Eduard Soltan wrote:
> I committed on 9267a, rev. 15531.
Eduard, are you sure the branch was bound when you commit...
Radu Apetrii
09:54 AM Bug #9267: Index Selection in case of a multiple index matches.
Eduard Soltan wrote:
> Radu Apetrii wrote:
> > Oh, that's great then. As long as we have the cases talked in this t...
Eduard Soltan
09:53 AM Bug #9267: Index Selection in case of a multiple index matches.
Radu Apetrii wrote:
> OK, then, if you agree, we'll split the work as following:
> * Eduard: create the testcases f...
Eduard Soltan
09:48 AM Bug #9267: Index Selection in case of a multiple index matches.
Radu Apetrii wrote:
> Oh, that's great then. As long as we have the cases talked in this task covered, I'm good.
...
Eduard Soltan
07:51 AM Bug #9267: Index Selection in case of a multiple index matches.
Eduard Soltan wrote:
> > * Radu: I'll look into #9267-36 and see what I can deduce.
>
> If you need more assistan...
Radu Apetrii
07:48 AM Bug #9267: Index Selection in case of a multiple index matches.
First of all, don't ask me what I searched to get to this pdf. Secondly, it seems that we were right: persistent tabl... Radu Apetrii
07:30 AM Bug #9267: Index Selection in case of a multiple index matches.
Radu Apetrii wrote:
> OK, then, if you agree, we'll split the work as following:
> * Eduard: create the testcases...
Eduard Soltan
06:48 AM Bug #9267: Index Selection in case of a multiple index matches.
Eduard Soltan wrote:
> Radu Apetrii wrote:
>
> > I think we're going to need an example for each of these cases. ...
Radu Apetrii
06:40 AM Bug #9267: Index Selection in case of a multiple index matches.
Radu Apetrii wrote:
> I think we're going to need an example for each of these cases. If Eduard is not available r...
Eduard Soltan
06:40 AM Bug #9267: Index Selection in case of a multiple index matches.
Alexandru Lungu wrote:
> > OK, an update to this: I believe the alphabetical order is for the "static" index definit...
Radu Apetrii
06:36 AM Bug #9267: Index Selection in case of a multiple index matches.
> OK, an update to this: I believe the alphabetical order is for the "static" index definitions, or in other words, t... Alexandru Lungu
06:32 AM Bug #9267: Index Selection in case of a multiple index matches.
I've also added Eric as a watcher to this discussion. I don't know why he wasn't here in the first place. Radu Apetrii
06:30 AM Bug #9267: Index Selection in case of a multiple index matches.
Radu Apetrii wrote:
> Does this mean that the order in which we define the indexes is the tie-breaker here? If so, ...
Radu Apetrii
10:41 AM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data
Eric and Radu: please review. Greg Shah
09:15 AM Feature #9057 (Review): enable intermixed access to default tenant (shared) data and tenant-speci...
I added intermixed access support for some of the methods above. In fact only for those where I was able to identify ... Ovidiu Maxiniuc
07:23 AM Bug #9078: emit FindQuery as (reused) variables
Fixed an action and removed the check in *9078a/15540*. Dănuț Filimon
07:10 AM Bug #9078: emit FindQuery as (reused) variables
Committed *9078a/15539*. Addressed #9078-47.
I think something like ...
Dănuț Filimon
03:18 AM Bug #9078: emit FindQuery as (reused) variables
Alexandru Lungu wrote:
> > From my understanding, there are no longer queries without a name. Each FindQuery will ha...
Dănuț Filimon
03:07 AM Bug #9078: emit FindQuery as (reused) variables
> From my understanding, there are no longer queries without a name. Each FindQuery will have a name, even if it is n... Alexandru Lungu
03:05 AM Bug #9078 (WIP): emit FindQuery as (reused) variables
Constantin Asofiei wrote:
> Review of 9078a/15537:
> ** is it ever possible for @<rule>toplvlref != null and toplvl...
Dănuț Filimon
02:51 AM Bug #9078: emit FindQuery as (reused) variables
Review of 9078a/15537:
* @hasAncestorLoopingInnerBlock@ - this needs to look through all 'inner_block', not just the...
Constantin Asofiei

11/04/2024

10:12 AM Bug #9267: Index Selection in case of a multiple index matches.
Radu Apetrii wrote:
>
> Does this mean that the order in which we define the indexes is the tie-breaker here? If s...
Eduard Soltan
09:23 AM Bug #9267: Index Selection in case of a multiple index matches.
Constantin Asofiei wrote:
> There are documented rules for index selection here: [[p2j:Chapter_27_Sorting_Query_Resu...
Radu Apetrii
08:06 AM Bug #9267: Index Selection in case of a multiple index matches.
There are documented rules for index selection here: [[p2j:Chapter_27_Sorting_Query_Results]]
We should update thi...
Constantin Asofiei
07:42 AM Bug #9267: Index Selection in case of a multiple index matches.
Radu Apetrii wrote:
>
> Here, Progress and FWD trunk choose @idx1@. With the 9267a changes, @idx2@ is selected.
...
Eduard Soltan
06:46 AM Bug #9267 (WIP): Index Selection in case of a multiple index matches.
Greg Shah
06:41 AM Bug #9267: Index Selection in case of a multiple index matches.
OK, so, here's the testcase:
Table definition:
{{collapse...
Radu Apetrii
02:58 AM Bug #9267: Index Selection in case of a multiple index matches.
Eduard: I got informed by a customer of a query that uses the wrong index now (with the 9267a changes), and was using... Radu Apetrii
09:46 AM Bug #9078: emit FindQuery as (reused) variables
Committed *9078a/15538*.
* Extended field initialization in FindQuery to support the new conversion changes. Field...
Dănuț Filimon
04:27 AM Bug #7496 (Test): finish support for query:forward-only attribute
Branch 7496a was merged into trunk as rev. 15530 and archived. Dănuț Filimon
04:17 AM Bug #7496 (Merge Pending): finish support for query:forward-only attribute
Please merge 7496a to trunk now. Alexandru Lungu

11/02/2024

09:33 PM Bug #9267: Index Selection in case of a multiple index matches.
Eduard Soltan wrote:
> Conversion of a customer GUI application finished successfully. Also tested unit tests, with ...
Ovidiu Maxiniuc

11/01/2024

04:29 PM Feature #7020: always use "expanded" extent fields
Ovidiu Maxiniuc wrote:
> I understand now. The problem is @display ttw.f1[i] with frame f3.@. Note the variable @i@ ...
Hynek Cihlar
01:21 PM Feature #7020: always use "expanded" extent fields
I understand now. The problem is @display ttw.f1[i] with frame f3.@. Note the variable @i@ as index in @ext1b.p@ as o... Ovidiu Maxiniuc
10:08 AM Feature #7020: always use "expanded" extent fields
Ovidiu Maxiniuc wrote:
> Does the build fail because of the missing accessors?
This is the compilation error:
<p...
Roger Borrello
10:27 AM Bug #9267: Index Selection in case of a multiple index matches.
I finished testing another customer application after reconversion. Results of unit tests and smoke testing GUI are p... Andrei Iacob
07:55 AM Bug #9267: Index Selection in case of a multiple index matches.
I finished testing another customer application. The result is positive, everything went fine. ✅ Radu Apetrii
02:42 AM Bug #9267: Index Selection in case of a multiple index matches.
Conversion of a customer GUI application finished successfully. Also tested unit tests, with no regression.
Pushed...
Eduard Soltan
09:53 AM Bug #9078 (Review): emit FindQuery as (reused) variables
Constantin, as discussed, please review the changes when you have time. Dănuț Filimon
07:06 AM Bug #9078: emit FindQuery as (reused) variables
Committed *9078a/15537*. Fixed wrong order of emitted FindQuery variable. Dănuț Filimon
05:57 AM Bug #9078: emit FindQuery as (reused) variables
Committed *9078a/15536*.
* Only emit a FindQuery as a variable for looping inner blocks.
* Fixed #9032-42.
* Cl...
Dănuț Filimon

10/31/2024

07:53 PM Feature #7020: always use "expanded" extent fields
Roger,
I looked at the code. I do not see what the problem is. The only difference which is probably visible in ap...
Ovidiu Maxiniuc
04:00 PM Feature #7020: always use "expanded" extent fields
Constantin provided a simple example in #8805-64 where this is in a persistent DB:... Roger Borrello
11:02 AM Bug #9078: emit FindQuery as (reused) variables
I've managed to get a stable conversion with the new changes, but I found this case that needs to be investigated:
<...
Dănuț Filimon

10/30/2024

02:18 PM Bug #9267: Index Selection in case of a multiple index matches.
Made the necessary changes on 9267a, revision 15524.
I will redo the conversion of a customer application this eve...
Eduard Soltan
11:50 AM Bug #9267 (Internal Test): Index Selection in case of a multiple index matches.
+Review of 9267a r15523.+
I must admit it is strange that simple find queries and 'looping' queries use different ...
Ovidiu Maxiniuc
08:01 AM Bug #9267: Index Selection in case of a multiple index matches.
Radu Apetrii wrote:
> I'm gonna assume that I need to re-run the conversion for that customer application. I've alre...
Eduard Soltan
07:25 AM Bug #9267: Index Selection in case of a multiple index matches.
Eduard Soltan wrote:
> I made some changes to reflect behaviour from #9267-20 in 9267a, rev. 15523. Please review.
...
Radu Apetrii
07:16 AM Bug #9267: Index Selection in case of a multiple index matches.
I made some changes to reflect behaviour from #9267-20 in 9267a, rev. 15523. Please review. Eduard Soltan
03:46 AM Bug #9267: Index Selection in case of a multiple index matches.
Ovidiu Maxiniuc wrote:
> I did analyse at the sources posted on devsrv01. Definitely, the ones generated by 9267a lo...
Eduard Soltan
10:15 AM Bug #9078: emit FindQuery as (reused) variables
Constantin Asofiei wrote:
> Danut, the @FindQuery@ var def should be similar to the @OPEN QUERY@ var def - see @con...
Dănuț Filimon
10:02 AM Bug #9078: emit FindQuery as (reused) variables
Danut, the @FindQuery@ var def should be similar to the @OPEN QUERY@ var def - see @convert/database_access.rules@ a... Constantin Asofiei
06:06 AM Bug #9078: emit FindQuery as (reused) variables
Constantin Asofiei wrote:
> Dănuț Filimon wrote:
> > Constantin, at this point the conversion changes for #9032-2 a...
Dănuț Filimon
05:53 AM Bug #9078: emit FindQuery as (reused) variables
Dănuț Filimon wrote:
> Constantin, at this point the conversion changes for #9032-2 are implemented, but during yest...
Constantin Asofiei
05:37 AM Bug #9078: emit FindQuery as (reused) variables
Rebased *9078a* with *trunk/15526*, the branch is now at revision *15535*. Dănuț Filimon
05:25 AM Bug #9078: emit FindQuery as (reused) variables
Committed *9078a/15525*.
* FIND statements are annotated using "fqryname" annotation instead of "qryname". Because t...
Dănuț Filimon

10/29/2024

03:08 PM Bug #9267: Index Selection in case of a multiple index matches.
Review of 9267a, r15522.
The changes do make sense. Please add the H entry.
I did analyse at the sources posted...
Ovidiu Maxiniuc
10:14 AM Bug #9267: Index Selection in case of a multiple index matches.
Eduard Soltan wrote:
> Please review 9267a, rev. 15522.
>
> I have tests with regression changes project, and a l...
Eduard Soltan
10:07 AM Bug #9267 (Review): Index Selection in case of a multiple index matches.
Please review 9267a, rev. 15522.
I have tests with regression changes project, and a large customer GUI app. The r...
Eduard Soltan
10:04 AM Bug #9267 (WIP): Index Selection in case of a multiple index matches.
Eduard Soltan
09:51 AM Bug #9267: Index Selection in case of a multiple index matches.
Radu Apetrii wrote:
> The point here is that @idx2@ and the @WHERE@ clause share a prefix of fields, but they are no...
Eduard Soltan
09:45 AM Bug #9267: Index Selection in case of a multiple index matches.
So, I've attached the @.df@ used. It's a basic @test@ persistent table with three indexes: one primary unique one (wh... Radu Apetrii
09:31 AM Bug #9267: Index Selection in case of a multiple index matches.
Sure, go ahead. Eduard Soltan
09:31 AM Bug #9267: Index Selection in case of a multiple index matches.
It seems that 9267a fixes my issue from #8357-140. Eduard, if you want, I can post here a small testcase with what I ... Radu Apetrii
08:54 AM Bug #9267: Index Selection in case of a multiple index matches.
Added my testcases on @tests/query/index/IndexSelectionExactMatching.cls@.
Out of 13 tests:
- 6 test fails with...
Eduard Soltan
07:34 AM Bug #9078: emit FindQuery as (reused) variables
Fixed #9078-33 in *9078a/15524*. Dănuț Filimon
05:00 AM Bug #9078: emit FindQuery as (reused) variables
Committed *9078a/15523*. Added the fix mentioned in #9078-32. Dănuț Filimon
04:46 AM Bug #9078: emit FindQuery as (reused) variables
This one also:... Dănuț Filimon
04:42 AM Bug #9078: emit FindQuery as (reused) variables
I found a new fix for #9078-28, after converting hotel_gui and comparing the old and new conversions, I found the fol... Dănuț Filimon
03:16 AM Bug #9078: emit FindQuery as (reused) variables
Dănuț Filimon wrote:
> 9078a/15521 commit reverts most of the effort done for 9078a. I will have to think of another...
Dănuț Filimon
 

Also available in: Atom