FWD » Core Development » Database

12/23/2024

12:40 PM Bug #6767 (Review): Possible name clashes in DMO classes

The new renamed method list:
# @logical Buffer.isMultiTenant()@
# @void Buffer.setMultiTenant(logical)@
# @void ... Vladimir Tsichevski

12/21/2024

07:59 PM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data

Indeed, we are not handling the sequences the right way. At this moment, all of them are processed within the default... Ovidiu Maxiniuc

12/20/2024

08:56 AM Bug #9397: Fix COPY-TEMP-TABLE issues

9397a is also merged to 7156c as rev.15524. Ioana-Cristina Prioteasa

08:15 AM Bug #9397 (Test): Fix COPY-TEMP-TABLE issues

9397a is merged to trunk as rev. 15627. Ioana-Cristina Prioteasa

07:25 AM Bug #9397 (Merge Pending): Fix COPY-TEMP-TABLE issues

Please merge 9397a to trunk now. Adjust the %Done accordingly. Alexandru Lungu

08:24 AM Bug #7403: Copy-temp-table with replace-mode should replace already inserted records

#7403 is *fixed* by 9397a - FWD behavior aligns with progress with *trunk rev.15627*. Ioana-Cristina Prioteasa

07:27 AM Bug #7403 (WIP): Copy-temp-table with replace-mode should replace already inserted records

Ioana, please reassess #7403 after merging 9397a: is #7403-1 fixed by 9397a? if not, please analyze the status of thi... Alexandru Lungu

07:28 AM Bug #7364: Build a full test-suite for fast copy-temp-table

This task was posted way before the xfer testcases were a thing. Please check if the tests in xfer are comprehensive. Alexandru Lungu

06:33 AM Bug #9493: Inline word index CTE for trivial clauses

This task is deferred from #9370-13 and most of the description and investigation was already delivered there.
TL;... Alexandru Lungu

06:26 AM Bug #9493 (New): Inline word index CTE for trivial clauses

Alexandru Lungu

05:22 AM Bug #9317: FIRST/LAST clauses can avoid generating sub-selects if the WHERE clause matches a uniq...

Successfully refactored the logic to detect the need for a subselect in @FQLPreprocessor@.
When the preprocessor i... Ioana-Cristina Prioteasa

05:02 AM Bug #9078: emit FindQuery as (reused) variables

Committed *9078b/15623*. Fix an infinite loop by making arguments part of the condition for reinitialization, some ar... Dănuț Filimon

12/19/2024

09:46 AM Bug #9078: emit FindQuery as (reused) variables

Example of the problem:... Dănuț Filimon

08:53 AM Bug #9078: emit FindQuery as (reused) variables

Dănuț Filimon wrote:
> Solution:
> * Reinitialize the query when the arguments do not match.
I found that even i... Dănuț Filimon

06:04 AM Bug #9078: emit FindQuery as (reused) variables

The following FindQuery extracted from ETF (slightly modified table/field names):... Dănuț Filimon

06:04 AM Bug #9397: Fix COPY-TEMP-TABLE issues

Completed performance testing, is seems unaffected as it is 1% better than the baseline.
Testing plan is complete, ... Ioana-Cristina Prioteasa

05:11 AM Bug #9133 (Review): Array subscript is out of range stops the evaluation of other expressions in ...

Alexandru Lungu wrote:
> I put some thinking into this again, but (again) I can't see a clear implementation for thi... Lorian Sandu

03:52 AM Bug #9133: Array subscript is out of range stops the evaluation of other expressions in the where...

I put some thinking into this again, but (again) I can't see a clear implementation for this. Can we have a log SEVER... Alexandru Lungu

02:26 AM Bug #9383 (WIP): Cache only the current delegate on transaction commit if a ProgressiveResults is...

Alexandru Lungu wrote:
> I think there is a flaw in 9383a:
> * in case of a @ProgressiveQuery@, only the current br... Dănuț Filimon

12/18/2024

03:40 PM Feature #9057: enable intermixed access to default tenant (shared) data and tenant-specific data

Ovidiu, looking back over #9057-48, when we were discussing the use of the @META_CTX@ constant w.r.t. sequence handle... Eric Faulhaber

10:32 AM Bug #9465: Emit the right errors when binding datasets

I further investigate the exception presented in #9465-9. Up until now, in the constructor for @DataSetParameter@ we ... Andrei Plugaru

07:45 AM Bug #9465: Emit the right errors when binding datasets

While running the dataset unit tests, I came across this exception in @server.log@ I would also want to investigate:
... Andrei Plugaru

07:22 AM Bug #9465: Emit the right errors when binding datasets

Committed @9265a/15620@. Main changes:
# Implemented what I described in #9465-5
# Validate the case when the BIND ... Andrei Plugaru

09:03 AM Bug #9383: Cache only the current delegate on transaction commit if a ProgressiveResults is used

I think there is a flaw in 9383a:
* in case of a @ProgressiveQuery@, only the current bracket will be cached in a @S... Alexandru Lungu

07:20 AM Bug #9078: emit FindQuery as (reused) variables

Committed *9078b/15622*. This branch contains the changes from 9078a, with the database_access.rules adjusted to comp... Dănuț Filimon

02:48 AM Bug #9078: emit FindQuery as (reused) variables

I will have to rework almost all the changes from database_access.rules because the constructor is no longer generati... Dănuț Filimon

12:56 AM Bug #9078: emit FindQuery as (reused) variables

I created *9078b* from *trunk/15621*, after making a patch of 9078a on top of that branch I found conversion issues u... Dănuț Filimon

04:07 AM Bug #9397: Fix COPY-TEMP-TABLE issues

Smoketests of another large GUI application passed ✅ Andrei Iacob

12/17/2024

10:04 AM Bug #9465: Emit the right errors when binding datasets

Here are the testcases I used to test #9465-5. Andrei Plugaru

10:02 AM Bug #9465 (WIP): Emit the right errors when binding datasets

Andrei Plugaru

10:02 AM Bug #9465: Emit the right errors when binding datasets

I am currently looking into the situation when both the datasets on the caller and called side are reference-only. St... Andrei Plugaru

04:56 AM Bug #9465: Emit the right errors when binding datasets

Error @13012@ should now be emitted in the right situation with the appropriate message. The logic for emitting this ... Andrei Plugaru

09:20 AM Bug #9397: Fix COPY-TEMP-TABLE issues

Large customer gui application unit-tests passed ✅ Lorian Sandu

08:01 AM Bug #9397: Fix COPY-TEMP-TABLE issues

Added one more test to the @TestCopyTempTable@ 4GL unit tests suite and committed to the testcases project in total 6... Ioana-Cristina Prioteasa

02:57 AM Bug #9397: Fix COPY-TEMP-TABLE issues

ETF also passed ✅ Lorian Sandu

02:45 AM Bug #9397: Fix COPY-TEMP-TABLE issues

Chui regression tests passed ✅ Andrei Iacob

04:02 AM Bug #9078: emit FindQuery as (reused) variables

I've converted ETF with 9078a but all tests fail due to @Cannot create temp table field for "BATCHACTION"@. I've also... Dănuț Filimon

12/16/2024

02:22 PM Feature #9477: implement missing QUERY handle methods/attributes

* methods
** FIRST-OF(<level>) (none/none)
** LAST-OF(<level>) (none/none)
** REPOSITION-BACKWARDS() (full/basic)
... Eric Faulhaber

02:16 PM Feature #9477 (New): implement missing QUERY handle methods/attributes

Eric Faulhaber

07:33 AM Bug #9465: Emit the right errors when binding datasets

Committed 15 tests to @tests.dataset.parameter.inout.TestHandleDatasetBind@. Currently 4 of them fail all regarding t... Andrei Plugaru

06:44 AM Bug #9465: Emit the right errors when binding datasets

I have found a useful comment in @DataSet.isCompatibleWith@ which clarifies why my initial attempt to throw the error... Andrei Plugaru

05:44 AM Bug #9318: Make record nursery visible on removeRecords

Rebased *9318a* to latest *trunk/15616*, the branch is now at revision *15618*. Dănuț Filimon

05:38 AM Bug #9383: Cache only the current delegate on transaction commit if a ProgressiveResults is used

Rebased *9383a* to latest *trunk/15616*, the branch is now at revision *15617*. Dănuț Filimon

04:30 AM Bug #9397: Fix COPY-TEMP-TABLE issues

Lorian Sandu wrote:
> Ioana, can you rebase the branch to latest trunk, please?
*9397a* is rebased and it is now at... Ioana-Cristina Prioteasa

03:28 AM Bug #9397: Fix COPY-TEMP-TABLE issues

Ioana, can you rebase the branch to latest trunk, please? Lorian Sandu

12/13/2024

12:01 PM Bug #6767 (WIP): Possible name clashes in DMO classes

A year passed since the issue was fixed, the old results cannot be used anymore, the work should be redone. Vladimir Tsichevski

09:55 AM Bug #9397: Fix COPY-TEMP-TABLE issues

Lorian Sandu wrote:
> @9397a@ has only runtime changes?
Yes, no reconversion needed. Ioana-Cristina Prioteasa

09:28 AM Bug #9397: Fix COPY-TEMP-TABLE issues

@9397a@ has only runtime changes? Lorian Sandu

09:20 AM Bug #9397: Fix COPY-TEMP-TABLE issues

Testing plan for *9397a rev. 15585-15589*:
* *Ioana[icp]*: large customer application unit tests - *done*
* *Andrei... Ioana-Cristina Prioteasa

09:06 AM Bug #9397: Fix COPY-TEMP-TABLE issues

Committed to *9397a rev. 15589* a couple of quick fixes: removed unused import and corrected the use of @getPropretyN... Ioana-Cristina Prioteasa

12/12/2024

09:46 AM Bug #9030: FIND statements should use an internal buffer cursor

Committed 9030b/rev. 15614: minor fixes
* reintroduced off-end on RAQ to properly support invalidated AdaptiveQuery ... Alexandru Lungu

07:55 AM Bug #9030: FIND statements should use an internal buffer cursor

Committed 9030b/rev 15612 and 9030b/rev. 15613:
* Finished the implementation at the level of fixing the unit tests ... Alexandru Lungu

08:43 AM Bug #9465: Emit the right errors when binding datasets

There are some edge cases for binding datasets that throw errors in 4GL, however FWD doesn't handle at all these case... Andrei Plugaru

03:50 AM Bug #9465 (WIP): Emit the right errors when binding datasets

Andrei Plugaru

07:40 AM Bug #9267: Index Selection in case of a multiple index matches.

Alexandru Lungu wrote:
> I don't think this is correct. If I am defining the @indexes@ in a different order @idx1@ f... Ovidiu Maxiniuc

06:41 AM Bug #9267: Index Selection in case of a multiple index matches.

Alexandru Lungu wrote:
> I don't think this is correct. If I am defining the @indexes@ in a different order @idx1@ ... Eduard Soltan

06:10 AM Bug #9267: Index Selection in case of a multiple index matches.

> I think it makes sense: the first find next had a f2 = 5, therefore idx2(f2) was the logical choice. The simpler fi... Alexandru Lungu

05:30 AM Bug #9267: Index Selection in case of a multiple index matches.

I think it makes sense: the first @find next@ had a @f2 = 5@, therefore @idx2(f2)@ was the logical choice. The simple... Ovidiu Maxiniuc

05:13 AM Bug #9267: Index Selection in case of a multiple index matches.

I think it related to the way how index is selected in temp-tables, when the tie between 2 indices that satisfy all c... Eduard Soltan

05:03 AM Bug #9267: Index Selection in case of a multiple index matches.

I found another case of incorrect index selection. As Eduard and Radu already engaged in this topic through #9267, I ... Alexandru Lungu

03:27 AM Bug #9383 (Review): Cache only the current delegate on transaction commit if a ProgressiveResults...

Harness and reports passed.
Alexandru, please review. Dănuț Filimon

07:27 PM Feature #9456 (WIP): implement SQL Server dialect and helpers

Eric Faulhaber

07:26 PM Feature #9455 (Internal Test): port native user defined functions to SQL Server

Eric Faulhaber

12/11/2024

10:10 AM Bug #9383: Cache only the current delegate on transaction commit if a ProgressiveResults is used

Created *9383a* from *trunk/15611* and committed *9383a/15612*. @cacheResults()@ call from the notified TRANSACTION_C... Dănuț Filimon

12/10/2024

12:47 PM Feature #9443: add runtime support for DSLOG-MANAGER

At a minimum, @DB-CONTEXT@ needs to be supported.
In all likelihood, instrumentation for logging levels and entry-... Greg Shah

12:45 PM Feature #9443 (New): add runtime support for DSLOG-MANAGER

Greg Shah

12:00 PM Bug #9397 (Internal Test): Fix COPY-TEMP-TABLE issues

I have reviewed 9397a rev. 15588.
All issues I identified are done. Please also remove the unnecessary imports fro... Ovidiu Maxiniuc

05:11 AM Bug #9397: Fix COPY-TEMP-TABLE issues

Addressed the code review in *9397a rev. 15588*:
* Corrected the @if@ statement, which was indeed missing a set of p... Ioana-Cristina Prioteasa

10:35 AM Feature #9440: get-codepage() function should work with CLOB fields

The current implementation of @GET-CODEPAGE()@ (implemented in #3753) works with @LONGCHAR@ but not with @CLOB@ field... Greg Shah

10:31 AM Feature #9440 (Closed): get-codepage() function should work with CLOB fields

Greg Shah

10:24 AM Bug #9030 (WIP): FIND statements should use an internal buffer cursor

Implemented 9030b/rev 15611
* Includes an alpha version of @FindSupport@ that managed the algorithm presented abov... Alexandru Lungu

09:09 AM Bug #9030: FIND statements should use an internal buffer cursor

Extra findings:
* doing a FIND NEXT on another index *doesn't seem to reset the cursor*... Alexandru Lungu

05:53 AM Bug #9030: FIND statements should use an internal buffer cursor

Extra findings:
* If the buffer is sent as parameter, it keeps it state in regard to FIND NEXT.
* If the table is s... Alexandru Lungu

04:42 AM Bug #9030: FIND statements should use an internal buffer cursor

> Alexandru, I've created task branch 9030a from trunk rev 15372. This is the first attempt to solve the buffer's int... Alexandru Lungu

08:51 AM Bug #9383: Cache only the current delegate on transaction commit if a ProgressiveResults is used

Alexandru Lungu wrote:
> > I will try to find a test case from a customer application scenario and an analysis of ho... Dănuț Filimon

06:52 AM Bug #9383: Cache only the current delegate on transaction commit if a ProgressiveResults is used

> I will try to find a test case from a customer application scenario and an analysis of how often cacheResults and s... Alexandru Lungu

06:41 AM Bug #9383: Cache only the current delegate on transaction commit if a ProgressiveResults is used

Alexandru Lungu wrote:
>If the results are progressive, then an optimization would be to only cache the current dele... Dănuț Filimon

12/09/2024

04:05 PM Bug #9397: Fix COPY-TEMP-TABLE issues

*Review of 9397a, r15587:*
I see the issues from my previous review have been addressed.
But, as Alex mentioned... Ovidiu Maxiniuc

10:00 AM Bug #9397: Fix COPY-TEMP-TABLE issues

*Review of 9397a*:
* Changes look good in terms of error handling.
* for type checking:... Alexandru Lungu

08:25 AM Bug #9426 (Rejected): Failed to UPDATE when flushing an INVALID dmo

Greg Shah

08:10 AM Bug #9426: Failed to UPDATE when flushing an INVALID dmo

After setting up an instance with the proper version and testing the test mentioned in #9416, the issue can't be repr... Dănuț Filimon

04:09 AM Bug #9383 (WIP): Cache only the current delegate on transaction commit if a ProgressiveResults is...

Dănuț Filimon

12/06/2024

09:21 AM Bug #9426: Failed to UPDATE when flushing an INVALID dmo

The stack trace:... Dănuț Filimon

09:11 AM Bug #9426 (Rejected): Failed to UPDATE when flushing an INVALID dmo

Dănuț Filimon

08:42 AM Bug #9318: Make record nursery visible on removeRecords

Latest implementation was committed to *9318a/15588* Dănuț Filimon

08:01 AM Bug #9318 (Review): Make record nursery visible on removeRecords

@Buffer.delete()@ is used for temporary tables because there is no order by clause generated at conversion, but a @re... Dănuț Filimon

05:35 AM Bug #9397: Fix COPY-TEMP-TABLE issues

Ioana, please design a 4GL Unit Tests suite according to [[p2j:4GL_Unit_Testing]]. Include the cases you found in the... Alexandru Lungu

05:32 AM Bug #9397 (Review): Fix COPY-TEMP-TABLE issues

Committed on *9397a rev. 15587*:
* removed logic to rollback when a validation error occurs.
* Moved the 12304 erro... Ioana-Cristina Prioteasa

12/05/2024

07:03 AM Bug #9397: Fix COPY-TEMP-TABLE issues

The result is a bit strange, before the fix. I understand that @a: 1, c: 0, d: 0@ is the row correctly copied, but th... Ovidiu Maxiniuc

06:06 AM Bug #9397: Fix COPY-TEMP-TABLE issues

I am currently testing different parameter combinations for @COPY-TEMP-TABLE@ and have identified another inconsisten... Ioana-Cristina Prioteasa

06:50 AM Bug #9318: Make record nursery visible on removeRecords

My point for #9318-10 is that we do not need a deleteAll(deleteIndex), we only need to make the distinction between d... Dănuț Filimon

06:30 AM Bug #9318: Make record nursery visible on removeRecords

Currently:
* EMPTY TEMP-TABLE should honor all indices;
* FOR EACH tt1. DELETE tt1. END. should honor the primary i... Dănuț Filimon

04:42 AM Bug #7496 (Test): finish support for query:forward-only attribute

Branch 7496c was merged into trunk as rev. 15596 and archived. Dănuț Filimon

04:33 AM Bug #7496 (Merge Pending): finish support for query:forward-only attribute

Please merge 7496c to trunk now. Alexandru Lungu

12/04/2024

08:09 AM Bug #9397: Fix COPY-TEMP-TABLE issues

Addressed code review in *9397a rev. 15586*.
Ovidiu Maxiniuc wrote:
> * @TemporaryBuffer.java@:
> ** line 4481... Ioana-Cristina Prioteasa

12/03/2024

01:08 PM Bug #9397 (WIP): Fix COPY-TEMP-TABLE issues

+Review of *9397a rev. 15584/5*.+
In spite of the long list below, the update is actually good. These are hidden a... Ovidiu Maxiniuc

09:31 AM Bug #9397 (Review): Fix COPY-TEMP-TABLE issues

Committed on *9397a rev. 15585*.
Added 5368 and 12304 errors, added type check for throwing 11885 error, fixed how @... Ioana-Cristina Prioteasa

09:30 AM Bug #9397 (WIP): Fix COPY-TEMP-TABLE issues

Ioana-Cristina Prioteasa

08:24 AM Bug #9397: Fix COPY-TEMP-TABLE issues

Ioana-Cristina Prioteasa wrote:
> 1. Are there other places where assigning int and in64 does not match progress beh... Ovidiu Maxiniuc

06:44 AM Bug #9397: Fix COPY-TEMP-TABLE issues

The type check for emitting the *11885* error has been implemented and we now we also ensure the @srcBuf@ is not empt... Ioana-Cristina Prioteasa

09:56 AM Bug #9034 (Test): FindQuery unique fails in a self join context

9034a was merged to trunk as rev 15593. Artur Școlnic

09:42 AM Bug #9034 (Merge Pending): FindQuery unique fails in a self join context

Please merge 9034a *after 9263a* to trunk. Alexandru Lungu

08:08 AM Bug #7496: finish support for query:forward-only attribute

ChUI regression tests passed. l.e. updated #7496-102
*7496c* can be merged. Dănuț Filimon

05:33 AM Bug #6744: rollback when there are catch/finally blocks opening their own transactions

On the first look, it seems related. Artur Școlnic

05:30 AM Bug #6744: rollback when there are catch/finally blocks opening their own transactions

Artur, is this task related to your recent work on FINALLY blocks and transaction scoping? Alexandru Lungu

12/02/2024

04:03 AM Bug #9318: Make record nursery visible on removeRecords

Alexandru Lungu wrote:
> I meant making the existing @deleteAll()@ call the @deleteAll(deleteIndex)@ with @null@ and... Dănuț Filimon

03:54 AM Bug #9318: Make record nursery visible on removeRecords

> I am wondering how should this look in the converted code?
Well, the converted code is now @tt.deleteAll()@ and ... Alexandru Lungu

03:50 AM Bug #9318: Make record nursery visible on removeRecords

Created *9318a* from *trunk/15586* and committed an initial implementation on *9318a/15587*. Allows to make a distinc... Dănuț Filimon

03:48 AM Bug #7496: finish support for query:forward-only attribute

Alexandru Lungu wrote:
> Danut, what is the status of 7496c? What testing is left?
*7496c* has be queued for ChUI r... Dănuț Filimon

03:46 AM Bug #7496: finish support for query:forward-only attribute

Danut, what is the status of 7496c? What testing is left? Alexandru Lungu