Project

General

Profile

Activity

From 03/08/2025 to 04/06/2025

04/05/2025

04:42 PM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
Created branch 9831a and committed the implementation.
Committed revision 15843.
Ovidiu Maxiniuc
11:23 AM Bug #9872: Runtime import statement relies on the ImportWorker to read lob data.
The @PropertyMapper@ is one class which was created only during the import, as an utility of @ImportWorker@. The fact... Ovidiu Maxiniuc

04/04/2025

06:10 PM Feature #9093: add protection for multi-tenant imports to optionally only import tables that are ...
I rebased 9093a. Pushed up to revision 15848.
I also created #9875 to hold customer specific scripts for importing...
Ovidiu Maxiniuc
03:45 PM Feature #9093: add protection for multi-tenant imports to optionally only import tables that are ...
Indeed, I tried to keep it up-to-date.
However, there were a couple of big updates this wee, so it requires rebasi...
Ovidiu Maxiniuc
03:40 PM Feature #9093 (Internal Test): add protection for multi-tenant imports to optionally only import ...
Eric Faulhaber wrote:
> Ovidiu, I think you said last standup that this branch was ready for merge, but it is still ...
Eric Faulhaber
03:33 PM Feature #9093: add protection for multi-tenant imports to optionally only import tables that are ...
Ovidiu, I think you said last standup that this branch was ready for merge, but it is still in review status, with no... Eric Faulhaber
06:14 AM Bug #9872: Runtime import statement relies on the ImportWorker to read lob data.
In @PropertyMapper.readLobData@, @Importworker@ is used to retrieve the path to the lob file. @Importworker@ is not s... Artur Școlnic
06:12 AM Bug #9872 (New): Runtime import statement relies on the ImportWorker to read lob data.
Artur Școlnic
05:00 AM Bug #9853 (Test): ProgressiveResults invalidate badly when changing the record on the edge of a b...

Branch 9853a was merged to trunk rev 15841 and archived.
Alexandru Lungu
04:50 AM Bug #9853 (Internal Test): ProgressiveResults invalidate badly when changing the record on the ed...
Alexandru Lungu

04/03/2025

05:04 PM Bug #9853: ProgressiveResults invalidate badly when changing the record on the edge of a bracket
Alexandru Lungu wrote:
> Committed 9853a/15839 and 15840, replacing !isPreselect with errorCondition. Please review....
Constantin Asofiei
08:26 AM Bug #9853: ProgressiveResults invalidate badly when changing the record on the edge of a bracket
Committed 9853a/15839 and 15840, replacing !isPreselect with errorCondition. Please review. Alexandru Lungu
06:51 AM Bug #9853: ProgressiveResults invalidate badly when changing the record on the edge of a bracket
Alexandru Lungu wrote:
> Would you prefer @errorCondition@? I guess it is less confusing than seeing @isPreselect@ a...
Constantin Asofiei
06:50 AM Bug #9853: ProgressiveResults invalidate badly when changing the record on the edge of a bracket
Yes, this is what is happening in @next@. Would you prefer @errorCondition@? I guess it is less confusing than seeing... Alexandru Lungu
06:45 AM Bug #9853: ProgressiveResults invalidate badly when changing the record on the edge of a bracket
Can we rely on @errorCondition@ instead of @!isPreselect()@? That's set like this:... Constantin Asofiei
06:32 AM Bug #9853: ProgressiveResults invalidate badly when changing the record on the edge of a bracket
> But, the condition to enter this block is if (cacheOnReval || isPreselect()) - so, can the preselect be false, when... Alexandru Lungu
06:26 AM Bug #9853: ProgressiveResults invalidate badly when changing the record on the edge of a bracket
I don't really understand the fix.
The line @Results cached = cacheResults(old, true);@ where @Results old = adapt...
Constantin Asofiei
03:58 AM Bug #9853 (Review): ProgressiveResults invalidate badly when changing the record on the edge of a...
Committed 9853a/rev. 15838.
Constantin, please review.
Alexandru Lungu
08:03 AM Feature #7020: always use "expanded" extent fields
Ovidiu Maxiniuc wrote:
> Stefanel,
> I think 7020d is broken at this moment, @RecordMeta@ probably fails to compile...
Stefanel Pezamosca
07:57 AM Feature #7020: always use "expanded" extent fields
Ovidiu Maxiniuc wrote:
> Stefanel,
> I think 7020d is broken at this moment, @RecordMeta@ probably fails to compile...
Stefanel Pezamosca
07:48 AM Feature #7020: always use "expanded" extent fields
Stefanel,
I think 7020d is broken at this moment, @RecordMeta@ probably fails to compile. The reason is the usage of...
Ovidiu Maxiniuc
06:55 AM Bug #9852: Portal "C_10" does not exist error
I think making all FOR EACH queries FORWARD-ONLY was the main cause of this problem. I will revisit this after review... Dănuț Filimon
06:51 AM Bug #9852: Portal "C_10" does not exist error
This seems solved with trunk 15839 (after rollback of #7991). Looks it is related to FORWARD-RESULTS fix. Constantin Asofiei

04/02/2025

11:20 AM Bug #9853 (WIP): ProgressiveResults invalidate badly when changing the record on the edge of a br...
I investigated this case. It is about a fail-safe of @ProgressiveResults@ to invalidate if things look not-alright. B... Alexandru Lungu
05:12 AM Feature #7020: always use "expanded" extent fields
Fixed. Please see *7020d revision 15846*.
I also have rebased 7020c to trunk 15830. Same as 7020d.
Stefanel Pezamosca

04/01/2025

12:29 PM Feature #7020: always use "expanded" extent fields
First, a quick look at 7020c (r15824):
* @FqlToSqlConverter.java@
** multiple usages of @appendExpandedName()@: the...
Ovidiu Maxiniuc

03/31/2025

10:14 AM Feature #7020: always use "expanded" extent fields
*7020d* was rebased to *trunk revision 15830* and is now at revision *15843*.
In revision *15844* I committed a fi...
Stefanel Pezamosca
06:43 AM Bug #9852: Portal "C_10" does not exist error
... Dănuț Filimon
04:12 AM Bug #9852: Portal "C_10" does not exist error
The issue is:... Dănuț Filimon
03:43 AM Bug #9852: Portal "C_10" does not exist error
I was able to reproduce the issue. Dănuț Filimon
03:41 AM Bug #9852: Portal "C_10" does not exist error
Constantin Asofiei wrote:
> Please attach the .df file; what postgresql version do you use?
Just realized I have ...
Dănuț Filimon
03:39 AM Bug #9852: Portal "C_10" does not exist error
Please attach the .df file; what postgresql version do you use? Constantin Asofiei
03:39 AM Bug #9852: Portal "C_10" does not exist error
This is the server log of the test, takes more than 5 minutes to run the test. Dănuț Filimon
03:28 AM Bug #9852: Portal "C_10" does not exist error
Dănuț Filimon wrote:
> Alex, I can't reproduce this error with latest trunk/15829.
I've tested now and it fails:
<...
Constantin Asofiei
02:55 AM Bug #9852: Portal "C_10" does not exist error
Alex, I can't reproduce this error with latest trunk/15829. Dănuț Filimon
02:28 AM Bug #9852 (WIP): Portal "C_10" does not exist error
Dănuț Filimon
06:18 AM Bug #9763: xml-node-name buffer option
Testing performed with *rev. 15835*:
- unit tests of a large customer application ✅
- harness ✅
- Chui regressio...
Eduard Soltan

03/29/2025

01:57 AM Bug #9763: xml-node-name buffer option
Ovidiu Maxiniuc wrote:
> > [...]
> I see @READ-json@, I was expecting a @read-xml@ based on the changes in @XmlIm...
Eduard Soltan

03/28/2025

06:14 PM Bug #9763: xml-node-name buffer option
Eduard Soltan wrote:
> I have made the modification in @TempTableBuilder@.
The setters use @_prepared()@ and the ge...
Ovidiu Maxiniuc
04:44 PM Bug #9763: xml-node-name buffer option
I have made the modification in @TempTableBuilder@.
But also made some changes in @XmlExport@ and @XmlExport@ to m...
Eduard Soltan
04:11 PM Bug #9763: xml-node-name buffer option
Good, that's the idea.
I think the code will work as expected. My observations for @TempTableBuilder.java@, the on...
Ovidiu Maxiniuc
03:33 PM Bug #9763: xml-node-name buffer option
Committed on 9763b, rev. 15832.
Sure thing, I added the method in @TempTableBuilder@, and the attributes will be set...
Eduard Soltan
03:20 PM Bug #9763: xml-node-name buffer option
Indeed, it does. This is specific to dynamic temp-tables, therefore, this is the proper place to do it.
LE: the im...
Ovidiu Maxiniuc
03:03 PM Bug #9763: xml-node-name buffer option
Ovidiu Maxiniuc wrote:
> Not in @AbstractTempTable@, just in @TempTableBuilder@.
But this implies to override all...
Eduard Soltan
02:17 PM Bug #9763: xml-node-name buffer option
Not in @AbstractTempTable@, just in @TempTableBuilder@.
LE: and the attributes will be set in @TempTableBuilder.cr...
Ovidiu Maxiniuc
02:14 PM Bug #9763: xml-node-name buffer option
Ovidiu Maxiniuc wrote:
> Only in this particular case (@AbstractTempTable._dynamic()@ returns @true@), the attribut...
Eduard Soltan
02:09 PM Bug #9763: xml-node-name buffer option
Eduard Soltan wrote:
> I am thinking to initialize the @ctx.tt.tempTablePrepare@ and create the @defaultBuffer@, but...
Ovidiu Maxiniuc
02:07 PM Bug #9763: xml-node-name buffer option
The @AbstractTempTable@ has two specialised subclasses: @StaticTempTable@ and @TempTableBuilder@ (for dynamic temp-ta... Ovidiu Maxiniuc
02:06 PM Bug #9763: xml-node-name buffer option
Eduard Soltan wrote:
> The problem is that @TempTableBuilder@ does not initialize the @defaultBuffer@. Hence setting...
Eduard Soltan
01:45 PM Bug #9763: xml-node-name buffer option
There is a regression in at @dataset ddt1:read-xml@, when has no buffer set.
In @XmlImport.importDataset@ it go on...
Eduard Soltan
12:49 PM Bug #9763: xml-node-name buffer option
Eduard Soltan wrote:
> Ovidiu, why do we use @if (buffer.getSerializeName().toStringMessage().equalsIgnoreCase(name)...
Ovidiu Maxiniuc
07:19 AM Bug #9763: xml-node-name buffer option
The unit tests and smoke tests of a large GUI application went fine.✅
Also got some news that unit test of a very ...
Eduard Soltan
04:29 AM Bug #9763: xml-node-name buffer option
Testing on another customer application was successful. No more errors encountered nor strange behaviors. ✅ Radu Apetrii
03:10 AM Bug #9763: xml-node-name buffer option
Ovidiu, why do we use @if (buffer.getSerializeName().toStringMessage().equalsIgnoreCase(name)@ in XmlImport.importDat... Eduard Soltan
10:59 AM Bug #9853: ProgressiveResults invalidate badly when changing the record on the edge of a bracket
... Alexandru Lungu
10:54 AM Bug #9853 (Test): ProgressiveResults invalidate badly when changing the record on the edge of a b...
Alexandru Lungu
10:54 AM Bug #9852: Portal "C_10" does not exist error
... Alexandru Lungu
10:53 AM Bug #9852 (WIP): Portal "C_10" does not exist error
Alexandru Lungu

03/27/2025

04:59 PM Bug #9763: xml-node-name buffer option
I tested @read-json@ and @read-xml@, and they are fine.
Also made some tests with datasets (@define dataset dtt1 f...
Eduard Soltan
04:44 PM Bug #9763 (Internal Test): xml-node-name buffer option
Eduard Soltan wrote:
> Committed on 9763a, rev. 15796.
A couple of minor observations:
* Please revert @RecordBuff...
Ovidiu Maxiniuc
03:00 PM Bug #9763: xml-node-name buffer option
Committed on 9763a, rev. 15796.
I modified the @JsonImport@, @JsonExport@, @XmlExport@ and @XmlImport@, to use just ...
Eduard Soltan
12:08 PM Bug #9763: xml-node-name buffer option
Eduard, for some reasons I missed some files in #9763-47 (I think I pressed Ctrl+C in wrong console):
* @JsonExpo...
Ovidiu Maxiniuc
11:24 AM Bug #9763: xml-node-name buffer option
Also initialize to defaultBuffer in StaticTempTable before setting up its attributes. Eduard Soltan
08:40 AM Bug #9763: xml-node-name buffer option
Ovidiu Maxiniuc wrote:
> ** lines 2660-2692: these method seem to be duplicates of 2695-2725? The file most likely f...
Eduard Soltan
07:41 AM Bug #9763: xml-node-name buffer option
+Review of 9763b/15792+
This is pretty good, but there are several things which must be addressed:
* @AbstractTem...
Ovidiu Maxiniuc

03/26/2025

04:26 AM Bug #9763 (Review): xml-node-name buffer option
Constantin Asofiei wrote:
> Eduard, is 9763b ready for review?
Yes, it is ready for review.
Eduard Soltan
08:00 PM Feature #9093 (Review): add protection for multi-tenant imports to optionally only import tables ...
I created the new tenant import mode. It is called @strict@ and also added an alias @strict-default@. In this case th... Ovidiu Maxiniuc

03/25/2025

10:32 AM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
The following c3p0 database connection pool settings, normally set in the directory for a primary database, should be... Eric Faulhaber
10:20 AM Feature #9831 (Closed): add admin API to set c3p0 configuration for individual tenant databases
Eric Faulhaber
09:41 AM Support #4060: investigate converting extent fields to array columns
I wanted to investigate this a little bit. 7020d branch makes it easier to implement this. Most places are already us... Stefanel Pezamosca
09:38 AM Bug #9763: xml-node-name buffer option
Eduard, is 9763b ready for review? Constantin Asofiei
06:29 AM Feature #7020: always use "expanded" extent fields
So, to summarize: *7020d* is based on *trunk 15813*. *7020d* has all the changes from 7020c but with some other impro... Stefanel Pezamosca

03/24/2025

11:06 AM Feature #7020: always use "expanded" extent fields
7020d was rebased to trunk revision 15813.
7020d contains now all the changes from 7020c + some improvements. There ...
Stefanel Pezamosca

03/21/2025

08:44 AM Support #4060: investigate converting extent fields to array columns
Recently we found out that:
* Most databases have a limit on the number of columns in a table.
** PostgreSQL: 160...
Greg Shah
03:34 AM Feature #7020: always use "expanded" extent fields
Greg Shah wrote:
> For some reason, the work on 9537a is actually in #8982 and the last notes there suggest that we ...
Stefanel Pezamosca

03/20/2025

02:58 PM Feature #7020: always use "expanded" extent fields
If the shared frame above is fixed, yet the customer application hit that other limit, we'd need both to be fixed bef... Roger Borrello
02:54 PM Feature #7020: always use "expanded" extent fields
Greg Shah wrote:
> For some reason, the work on 9537a is actually in #8982 and the last notes there suggest that we ...
Roger Borrello
02:18 PM Feature #7020: always use "expanded" extent fields
For some reason, the work on 9537a is actually in #8982 and the last notes there suggest that we have a design limita... Greg Shah
11:47 AM Feature #7020: always use "expanded" extent fields
Roger Borrello wrote:
> Is there any relationship between branches 9537a and 7020c? I am especially concerned with m...
Stefanel Pezamosca
11:39 AM Feature #7020: always use "expanded" extent fields
Is there any relationship between branches 9537a and 7020c? I am especially concerned with my big application, since ... Roger Borrello
11:27 AM Feature #7020 (Review): always use "expanded" extent fields
I have rebased 7020c to trunk revision 15800.
I have committed revisions 15823/15824 with some fixes. Please revie...
Stefanel Pezamosca
10:57 AM Feature #7020: always use "expanded" extent fields
Stefanel Pezamosca wrote:
> Now that I think about the potential issues, I believe this plan will be safer. So, I’m ...
Ovidiu Maxiniuc

03/19/2025

02:09 PM Feature #9093: add protection for multi-tenant imports to optionally only import tables that are ...
I am preparing a new @tenantMode@, which will restrict the import to @Default@ physical database only to tables not m... Ovidiu Maxiniuc
11:06 AM Bug #9763: xml-node-name buffer option
Branch 9763c was merged to trunk rev 15800 and archived. Constantin Asofiei
03:38 AM Bug #9763: xml-node-name buffer option
Created task branch 9763c from trunk rev 15790. 15791 fixes a problem with an edge case (regression in trunk 15785),... Constantin Asofiei
04:21 AM Feature #7020 (WIP): always use "expanded" extent fields
Thank you for the review. I will start working on addressing the above now.
> * as noted above, is the drop of the...
Stefanel Pezamosca

03/18/2025

12:58 PM Feature #7020: always use "expanded" extent fields
Review of 7020c / 15792.
I see that you did what I was afraid to do: completely drop the support for custom extent...
Ovidiu Maxiniuc
12:32 PM Bug #9763: xml-node-name buffer option
Constantin Asofiei wrote:
> Eduard, isn't @SERIALIZE-NAME@ used for JSON? So please try @READ-JSON@ and @WRITE-JSON@...
Eduard Soltan
11:29 AM Bug #9763: xml-node-name buffer option
Eduard, isn't @SERIALIZE-NAME@ used for JSON? So please try @READ-JSON@ and @WRITE-JSON@. Constantin Asofiei
11:25 AM Bug #9763: xml-node-name buffer option
Main faindings regarding buffer attributes:
@NAMESPACE-URI@
1) for statement @buffer btt1:NAMESPACE-URI@, it w...
Eduard Soltan
05:09 AM Bug #9763 (WIP): xml-node-name buffer option
Eduard Soltan
04:43 AM Bug #9763: xml-node-name buffer option
9763a was merged into trunk revision 15785 and archived. Eduard Soltan
05:08 AM Feature #9543: implement missing BUFFER attributes
9543a was merged into trunk revision 15786 and archived. Eduard Soltan
04:17 AM Bug #9756 (Test): Performance improvements for CONTAINS udf related methods.
Stefanel Pezamosca
04:13 AM Bug #9756: Performance improvements for CONTAINS udf related methods.
Branch 9756a was merged into trunk as rev. 15784 and archived. Stefanel Pezamosca

03/17/2025

09:01 AM Feature #9543 (Merge Pending): implement missing BUFFER attributes
Please merge after 9763a Constantin Asofiei
06:35 AM Feature #9543: implement missing BUFFER attributes
Performed a conversion of Regression test project and it went without any problems. Eduard Soltan
03:24 AM Feature #9543: implement missing BUFFER attributes
Constantin Asofiei wrote:
> Please use @rt_lvl_stub@, not @none@.
The necessary change added.
Eduard Soltan
03:21 AM Feature #9543: implement missing BUFFER attributes
Eduard Soltan wrote:
> Constantin Asofiei wrote:
> > You are missing history entry in a file. gaps are not updated...
Constantin Asofiei
03:16 AM Feature #9543: implement missing BUFFER attributes
Constantin Asofiei wrote:
> You are missing history entry in a file. gaps are not updated.
Updated gaps, and add...
Eduard Soltan
02:54 AM Feature #9543: implement missing BUFFER attributes
You are missing history entry in a file. gaps are not updated. Constantin Asofiei
02:40 AM Feature #9543: implement missing BUFFER attributes
Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > Constantin, shouldn't we generate the optimised @logical.TRU...
Eduard Soltan
09:01 AM Bug #9763 (Merge Pending): xml-node-name buffer option
Please merge after 9756a. Constantin Asofiei
03:16 AM Bug #9763: xml-node-name buffer option
Constantin Asofiei wrote:
> You are missing history entry in a file.
Added history entry.
Eduard Soltan
02:55 AM Bug #9763: xml-node-name buffer option
You are missing history entry in a file. Constantin Asofiei
02:43 AM Bug #9763: xml-node-name buffer option
I performed a conversion of Regression test project with 9763a, rev. 15774. And it went without any problems. Eduard Soltan
05:03 AM Bug #9756 (Merge Pending): Performance improvements for CONTAINS udf related methods.
Please merge 9756a to trunk *after 9676a*. Alexandru Lungu
04:53 AM Bug #9756: Performance improvements for CONTAINS udf related methods.
I have continued testing various CONTAINS testcases and there were no other issues.
This can be merged.
Stefanel Pezamosca

03/14/2025

07:09 AM Bug #9763: xml-node-name buffer option
Constantin Asofiei wrote:
> Eduard, the fact that 4GL doesn't allow @label@ as a field name doesn't mean is not poss...
Eduard Soltan
03:42 AM Bug #9763: xml-node-name buffer option
Eduard, the fact that 4GL doesn't allow @label@ as a field name doesn't mean is not possible for the DMO property nam... Constantin Asofiei
02:12 AM Bug #9763: xml-node-name buffer option
Constantin Asofiei wrote:
> Ovidiu, you are right. Eduard: for now, please rename @setLabel@ and @getLabel@ to @lab...
Eduard Soltan

03/13/2025

06:51 PM Bug #9756 (Internal Test): Performance improvements for CONTAINS udf related methods.
O am OK with the changes in r15769. Ovidiu Maxiniuc
08:09 AM Bug #9756 (Review): Performance improvements for CONTAINS udf related methods.
I made some other minor changes in revision 15769. Stefanel Pezamosca
03:44 PM Bug #9763: xml-node-name buffer option
Constantin Asofiei wrote:
> Ovidiu, you are right. Eduard: for now, please rename @setLabel@ and @getLabel@ to @lab...
Ovidiu Maxiniuc
02:21 PM Bug #9763: xml-node-name buffer option
Ovidiu, you are right. Eduard: for now, please rename @setLabel@ and @getLabel@ to @label@; this way we don't introd... Constantin Asofiei
02:09 PM Bug #9763: xml-node-name buffer option
I looked at 9763a.
* @buffer_definitions.rules@:
** contains some hard tabs (@#09@, @\t@)
** rules should use t...
Ovidiu Maxiniuc
01:54 PM Bug #9763: xml-node-name buffer option
Constantin Asofiei wrote:
> I assume you mean 9763b.
Yes, you are right. Sorry, I did not realise that there are 2 ...
Ovidiu Maxiniuc
01:52 PM Bug #9763: xml-node-name buffer option
Ovidiu Maxiniuc wrote:
> I looked at 9763a and I do NOT agree with the implementation.
I assume you mean 9763b.
Constantin Asofiei
01:51 PM Bug #9763: xml-node-name buffer option
I looked at 9763a and I do NOT agree with the implementation.
IMHO, the values of these new attributes should be s...
Ovidiu Maxiniuc
01:25 PM Bug #9763 (Internal Test): xml-node-name buffer option
Please do some minimal tests with 9763a to get this into trunk. Constantin Asofiei
06:34 AM Bug #9763: xml-node-name buffer option
Constantin Asofiei wrote:
>
> Test also with @buffer tt1:write-xml@ and @buffer tt1:xml-node-name = "something".@....
Eduard Soltan
04:36 AM Bug #9763: xml-node-name buffer option
Eduard Soltan wrote:
> Added runtime support for buffer attributes, on 9763b, rev. *15771*.
>
> @buffer btt1:writ...
Constantin Asofiei
04:34 AM Bug #9763: xml-node-name buffer option
Added runtime support for buffer attributes, on 9763b, rev. *15771*.
@buffer btt1:write-xml("longchar", lc).@
@...
Eduard Soltan
01:31 PM Feature #9543: implement missing BUFFER attributes
Ovidiu Maxiniuc wrote:
> Constantin, shouldn't we generate the optimised @logical.TRUE@ instead when a literal is us...
Constantin Asofiei
12:10 PM Feature #9543: implement missing BUFFER attributes
There is another conversion issue. Instead of... Ovidiu Maxiniuc
11:15 AM Feature #9543: implement missing BUFFER attributes
Ovidiu Maxiniuc wrote:
> I do not think you need to add a new method.
> The _missing_ method is most likely @Common...
Eduard Soltan
10:56 AM Feature #9543: implement missing BUFFER attributes
I do not think you need to add a new method.
The _missing_ method is most likely @CommonHandle.readOnlyError(String ...
Ovidiu Maxiniuc
09:29 AM Feature #9543: implement missing BUFFER attributes

> Constantin Asofiei wrote:
> * did you test how the setter converts for @CAN-READ@?
>
>> Well, is converts in...
Eduard Soltan
08:49 AM Feature #9543: implement missing BUFFER attributes
Addressed review issues in rev. *15773*.
Constantin Asofiei wrote:
> * did you test how the setter converts for @...
Eduard Soltan
08:17 AM Feature #9543: implement missing BUFFER attributes
Review of @9543a, revision 15771:
* why the @AutoSynchronize@ interface? If the attribute is specific only to BUFFER...
Constantin Asofiei

03/12/2025

06:34 PM Feature #7020: always use "expanded" extent fields
I have started reviewing the branch, but it will not be ready until tomorrow due to its size. Ovidiu Maxiniuc
11:37 AM Feature #7020 (Review): always use "expanded" extent fields
Done. 7020c was rebased to trunk revision 15770. 7020c is at revision 15792 and is ready for review. Stefanel Pezamosca
09:43 AM Feature #7020 (WIP): always use "expanded" extent fields
Greg Shah wrote:
> Stefanel: Is there anything else that needs to get done on this task?
As I extracted some of t...
Stefanel Pezamosca
09:33 AM Feature #7020: always use "expanded" extent fields
Eric/Ovidiu: Please make it a priority to get this code review done. We have several bugs being held open due to thi... Greg Shah
11:16 AM Bug #9683: CompoundQuery is doing extra hydration attempts
Review of 9683a:
There is still a place:...
Alexandru Lungu
10:07 AM Feature #9543 (WIP): implement missing BUFFER attributes
Eduard Soltan
10:03 AM Feature #9543: implement missing BUFFER attributes
Added conversion support on 9543a, revision *15770*.
For @AUTO-SYNCHRONIZE@ can be setable and queryable, although...
Eduard Soltan
07:11 AM Feature #9543: implement missing BUFFER attributes
Eduard, please add conversion support for these two. Constantin Asofiei
08:56 AM Bug #9756: Performance improvements for CONTAINS udf related methods.
I fixed this in 9756a revision 15769.
Other tests passed. If there are no other objections I think 9756a is safe f...
Stefanel Pezamosca
08:09 AM Bug #9756: Performance improvements for CONTAINS udf related methods.
Oh, I discovered an issue that is also in trunk. One example of problematic statement @contains(words, -)@ I will fix... Stefanel Pezamosca
07:57 AM Bug #9756 (Internal Test): Performance improvements for CONTAINS udf related methods.
I will continue testing the functionality with different parameters for contains. Stefanel Pezamosca
07:40 AM Bug #9756: Performance improvements for CONTAINS udf related methods.
Ovidiu Maxiniuc wrote:
> Cool. I have looked at the code. The changes are minimal. They are OK in my opinion. Howeve...
Stefanel Pezamosca
06:42 AM Bug #9756: Performance improvements for CONTAINS udf related methods.
Cool. I have looked at the code. The changes are minimal. They are OK in my opinion. However, we can assume the first... Ovidiu Maxiniuc
05:16 AM Bug #9756: Performance improvements for CONTAINS udf related methods.
I changed boolean[] to BitSet and used ConcurrentHashMap for skipPatterns in 9756a revision 15767. Stefanel Pezamosca
08:32 AM Bug #7924 (Test): add support for creating an empty database
The effort was moved to #7894 task and completed.
Branch 7894a was merged into trunk as rev. 15770 and archived.
...
Dănuț Filimon
06:33 AM Bug #9763: xml-node-name buffer option
9763a rev 15771 changes @return new character("label")@ to @return character.UNKNOWN@.
I'll move ahead with the co...
Constantin Asofiei
06:20 AM Bug #9763: xml-node-name buffer option
Constantin Asofiei wrote:
> As @LABEL@ is *not an attribute* for BUFFER or TEMP-TABLE (you can't set or get it via @...
Eduard Soltan
05:58 AM Bug #9763: xml-node-name buffer option
Constantin Asofiei wrote:
> Please post the test and how it converts now.
The 4gl test:...
Eduard Soltan
05:55 AM Bug #9763: xml-node-name buffer option
As @LABEL@ is *not an attribute* for BUFFER or TEMP-TABLE (you can't set or get it via @h:LABEL@), then please do not... Constantin Asofiei
05:53 AM Bug #9763: xml-node-name buffer option
Please post the test and how it converts now. Constantin Asofiei
05:36 AM Bug #9763: xml-node-name buffer option
Committed on 9765a, rev. *15768*. Conversion support for NAMESPACE-URI, NAMESPACE-PREFIX, SERIALIZE-NAME and LABEL bu... Eduard Soltan
04:44 AM Bug #9763 (WIP): xml-node-name buffer option
Eduard Soltan wrote:
> However the following syntax in OE will not raise any errors @def temp-table tt1 field f1 as ...
Constantin Asofiei
04:34 AM Bug #9763: xml-node-name buffer option
Eduard Soltan wrote:
> Constantin Asofiei wrote:
> > Is this LABEL only for buffers, or temp-table, too? Is it acc...
Eduard Soltan
04:28 AM Bug #9763: xml-node-name buffer option
Constantin Asofiei wrote:
> Is this LABEL only for buffers, or temp-table, too? Is it accessible via @BUFFER btt1:L...
Eduard Soltan
04:23 AM Bug #9763: xml-node-name buffer option
Is this LABEL only for buffers, or temp-table, too? Is it accessible via @BUFFER btt1:LABEL = "something"@? Constantin Asofiei
04:15 AM Bug #9763: xml-node-name buffer option
Constantin Asofiei wrote:
> Eduard, so I found @SERIALIZE-NAME@ also at the @DEF BUFFER@ statement. Please work on ...
Eduard Soltan
03:32 AM Bug #9763: xml-node-name buffer option
Eduard, so I found @SERIALIZE-NAME@ also at the @DEF BUFFER@ statement. Please work on adding all these. I don't kn... Constantin Asofiei

03/11/2025

02:16 PM Bug #9763: xml-node-name buffer option
Constantin Asofiei wrote:
> > 9763a/15767 only adds conversion support for buffer's @xml-node-name@ attribute. But t...
Ovidiu Maxiniuc
12:55 PM Bug #9763: xml-node-name buffer option
I don't see any @label@ support in @BufferImpl@, so we may want to defer that.
Otherwise, please create a more com...
Constantin Asofiei
12:31 PM Bug #9763: xml-node-name buffer option
Constantin Asofiei wrote:

> Eduard: please do some small tests and see if conversion of these works properly.
...
Eduard Soltan
11:48 AM Bug #9763 (New): xml-node-name buffer option
Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > Ovidiu: please review 9763a
>
> 9763a/15767 only adds con...
Constantin Asofiei
11:24 AM Bug #9763: xml-node-name buffer option
Constantin Asofiei wrote:
> Ovidiu: please review 9763a
9763a/15767 only adds conversion support for buffer's @xm...
Ovidiu Maxiniuc
10:00 AM Bug #9763 (Review): xml-node-name buffer option
A buffer can set its own @XML-NODE-NAME@ - and multiple buffers (for the same temp-table) can have different @XML-NOD... Constantin Asofiei
09:51 AM Bug #9763 (Test): xml-node-name buffer option
Constantin Asofiei
11:08 AM Bug #9756: Performance improvements for CONTAINS udf related methods.
Stefanel Pezamosca wrote:
> The cache I made only saves the ast given by FQLParser, and has only the String fql as a...
Ovidiu Maxiniuc
10:43 AM Bug #9756: Performance improvements for CONTAINS udf related methods.
Ovidiu Maxiniuc wrote:
> * related to the new, rather large, boolean arrays in @Contains@ and @LogicalExpressionConv...
Stefanel Pezamosca
10:37 AM Bug #9756: Performance improvements for CONTAINS udf related methods.
Ovidiu Maxiniuc wrote:
> * also in @FqlToSqlConverter.fqlAstCache@, I think there are 90% cases when the AST tree do...
Stefanel Pezamosca
10:29 AM Bug #9756: Performance improvements for CONTAINS udf related methods.
Ovidiu Maxiniuc wrote:
> Review of 9756a/15766.
>
> I agree that these are two directions we can improve performa...
Stefanel Pezamosca
10:28 AM Bug #9756: Performance improvements for CONTAINS udf related methods.
Review of 9756a/15766.
I agree that these are two directions we can improve performance. The ideas are good. But I...
Ovidiu Maxiniuc
06:23 AM Bug #9756 (Review): Performance improvements for CONTAINS udf related methods.
Please review! Stefanel Pezamosca
06:22 AM Bug #9756 (WIP): Performance improvements for CONTAINS udf related methods.
Working at #7020 I also made some performance improvements for CONTAINS udf related methods. LogicalExpressionConvert... Stefanel Pezamosca
03:07 AM Bug #9756 (Test): Performance improvements for CONTAINS udf related methods.
Stefanel Pezamosca
10:41 AM Bug #9764: Some events (like VALUE-CHANGED) are invoked after errors are displayed for the buffer...
Given a browse with a set query. This query can have one ore more buffers set. One of the buffers (say buff1) contain... Delia Mitric
10:37 AM Bug #9764 (New): Some events (like VALUE-CHANGED) are invoked after errors are displayed for the ...
Delia Mitric
04:35 AM Bug #9755: Reimplement AdaptiveQuery dynamic-mode using a LookAheadResults delegate
Alexandru Lungu wrote:
> ...
> There is no point in "revalidating" if a @LookAheadQuery@ delegate for dynamic-mode ...
Dănuț Filimon

03/10/2025

02:33 PM Feature #9093: add protection for multi-tenant imports to optionally only import tables that are ...
I downloaded the files from your link. Thank you.
As you said, there are 2 directories:
* the @emptydbwithschema@...
Ovidiu Maxiniuc
11:57 AM Feature #9093: add protection for multi-tenant imports to optionally only import tables that are ...
I've prepared 4 empty database bzip2 backups and the current metadata split into the two separate directories as we c... Brian Woodard
10:12 AM Bug #9755: Reimplement AdaptiveQuery dynamic-mode using a LookAheadResults delegate
I did some prototyping, but I must admit that having it as a @Query@ is much too complex comparing to having it as a ... Alexandru Lungu
07:15 AM Bug #9755: Reimplement AdaptiveQuery dynamic-mode using a LookAheadResults delegate
h4. Problem
A pattern was detected in a customer application that uses a browsed query, which is automatically scr...
Alexandru Lungu
06:51 AM Bug #9755 (New): Reimplement AdaptiveQuery dynamic-mode using a LookAheadResults delegate
Alexandru Lungu
04:42 AM Bug #9633: bulk delete for permanent tables
Branch 9656a was merged to trunk rev 15762 and archived. Constantin Asofiei
03:37 AM Bug #9633: bulk delete for permanent tables
Ovidiu Maxiniuc wrote:
> Review of 9656a/15759.
Done, please see rev 15760.
Constantin Asofiei
 

Also available in: Atom