Activity

From 07/28/2014 to 08/26/2014

08/26/2014

05:46 AM Feature #2252: implement GUI client support: Greg Shah wrote:
> > About ca_upd20140808c.zip: as code touched by this update seems to be affected by other tasks, ... Constantin Asofiei
02:31 AM Feature #2381: implement PUT-KEY-VALUE COLOR (n | ALL): Marius Gligor wrote:
> PUT-KEY-VALUE COLOR (n | ALL) is used to save COLOR-TABLE of current environment on a persist... Marius Gligor
02:28 AM Feature #2381 (New): implement PUT-KEY-VALUE COLOR (n | ALL): Marius Gligor

08/25/2014

03:29 PM Feature #1793: improve color support: > 5. In P2J the COLOR-TABLE management is done on each environment on the client side. That's why all server API for ... Greg Shah
03:16 PM Feature #1793: improve color support: Code Review 0825a
I'm fine with the changes. Greg Shah
03:05 PM Feature #1793: improve color support: Code Review 0822b
1. Minor javadoc changes to @getLegacyPlatform()@:
@specify a legacy platform regarding the r... Greg Shah
02:47 PM Feature #1793: improve color support: If we decide to load and store custom environments also on server side like default environment we could move the cod... Marius Gligor
02:18 PM Feature #1793: improve color support: > In conclusion I think that we have to follow the same behaviour and implements a mechanism to save COLOR-TABLE some... Greg Shah
10:47 AM Feature #1793: improve color support: Here are my changes after your code review for 0814a on note 9.
Also I did new tests this time using @LOAD@ @USE@ an... Marius Gligor
10:58 AM Feature #1791: implement dynamic UI support: > The suggested fix is:
I don't see any reason to enter the @synchronized@ block. Entering it obtains the lock fo... Greg Shah
10:25 AM Feature #2252: implement GUI client support: > any widget resource requiring access to these attributes (from either server or client side) will interrogate the c... Greg Shah
10:09 AM Feature #2252: implement GUI client support: > About ca_upd20140808c.zip: as code touched by this update seems to be affected by other tasks, I think I should rel... Greg Shah

08/22/2014

04:14 PM Feature #1791: implement dynamic UI support: Two more issues has been found during testing:
1. NullPointer exception in code @LogicalTerminal.deregisterFrameCont... Eugenie Lyzenko
08:27 AM Feature #1791: implement dynamic UI support: Code Review 0821a
I'm fine with the changes. Let's get this through testing. You can fix the memory leak in the ... Greg Shah
06:42 AM Feature #1791: implement dynamic UI support: Greg Shah wrote:
> # @LT.releaseSharedFrame()@ is the only way that shared frames actually "go away" permanently. U... Constantin Asofiei
08:49 PM Feature #1791: implement dynamic UI support: Looks like I've found the root cause. It really the interference of new ID approach and old one. The method is @Widge... Eugenie Lyzenko
02:28 PM Feature #2252: implement GUI client support: About ca_upd20140808c.zip: as code touched by this update seems to be affected by other tasks, I think I should relea... Constantin Asofiei
02:26 PM Feature #2252: implement GUI client support: About note 157/158, the work for #2254 and sync'ing the server and client-side widget states. Unfortunately, there i... Constantin Asofiei
12:43 PM Feature #1793: improve color support: The attached archive @0822b@ contains implementation of @EnvironmentOps.getLegacyPlatform()@ Marius Gligor
11:03 AM Feature #1793: improve color support: Digging in the customer's @OE 10.2b@ environment I found the configuration file progress.ini which contains among oth... Marius Gligor
08:53 AM Feature #1793: improve color support: Code Review 0822a
The changes are fine.
> the code inside ColorSpec class is running only on the server side, ... Greg Shah
07:17 AM Feature #1793: improve color support: Here are my changes for COLOR phrase implementation as a result of your code review.
1. Regarding platform detecti... Marius Gligor

08/21/2014

01:38 PM Feature #2252: implement GUI client support: Committed to bzr with rev 10600. Vadim Gindin
01:17 PM Feature #2252: implement GUI client support: > Previous update passed regression testing. Can I commit it?
Yes, please do. Greg Shah
01:16 PM Feature #2252: implement GUI client support: Previous update passed regression testing. Can I commit it? Vadim Gindin
08:42 AM Feature #2252: implement GUI client support: Code Review 0821a
I like the way this is going. Moving the @Window@ functionality from @static@ to non-@static@ i... Greg Shah
04:35 AM Feature #2252: implement GUI client support: > What happens if CURRENT-WINDOW is unrealized?
DEFAULT-WINDOW is used
I've added some client implementation for ... Vadim Gindin
11:42 AM Feature #1793: improve color support: Code Review 0821a
I like the result. Some minor feedback:
1. All data members should be at the top of the clas... Greg Shah
11:17 AM Feature #1793: improve color support: I've created #2379 to capture the work item for adding color support to the native Windows console (ChUI) client. We... Greg Shah
10:58 AM Feature #1793: improve color support: The attached archive contains my changes which I made to implements COLOR phrase for ChUI interfaces.
The @protermca... Marius Gligor
11:16 AM Feature #2379 (New): implement color support in the Windows native console (ChUI) client: Greg Shah
11:15 AM Feature #2378: implements dos-hex-attribute of COLOR phrase: See notes 11 and 12 in #1793 for details of previous research. Greg Shah

08/20/2014

05:47 PM Feature #1793: improve color support: Enums have the advantage of being very concise in syntax and being easy to read/understand/use. The down side of usi... Greg Shah
05:44 PM Feature #1793: improve color support: Question from MAG:
ColorPalette should holds multiple entries depending on platform Linux or Windows. ColorPalette... Greg Shah
04:18 PM Feature #1791: implement dynamic UI support: The update certainly has a regressions in frame ID handling(on client side I guess). After main syman menu displaying... Eugenie Lyzenko
10:32 AM Feature #1791: implement dynamic UI support: Sorry, I did not remove @ClientIdHelper@ from old location, so 0820a has two files with same class. Repackaged in 082... Eugenie Lyzenko
09:46 AM Feature #1791: implement dynamic UI support: Code Review 0820a
I like the changes. Well done.
> If you do not mind I'll start the runtime regression testin... Greg Shah
09:42 AM Feature #1791: implement dynamic UI support: This update for your review moves the @INPUT_FRAME_ID@ constant to @WidgetId@ class. The @WIDGET_ID_RANGE_BEGIN@ now ... Eugenie Lyzenko
08:18 AM Feature #1791: implement dynamic UI support: > I think these widgets do not have the server side counterpart because they exist only at editing time.
Yes.
>... Greg Shah
09:15 AM Feature #2252: implement GUI client support: Code Review 0820a
The changes look fine.
> Implicit Pause behaves exactly as explicit: uses CURRENT-WINDOW.
... Greg Shah
02:27 AM Feature #2252: implement GUI client support: I've tested implicit pause cases, listed in the note №160. Implicit Pause behaves exactly as explicit: uses CURRENT-W... Vadim Gindin

08/19/2014

06:54 PM Feature #1791: implement dynamic UI support: Also I guess this artificial frame and fill-in will neither be in widget registry not the part of server side frame. ... Eugenie Lyzenko
06:46 PM Feature #1791: implement dynamic UI support: >Does it work? :) Please test it with standalone testcases, including shared frames.
Yes, but there is one little ... Eugenie Lyzenko
05:32 PM Feature #1791: implement dynamic UI support: Code Review 0819a
I like it.
Does it work? :) Please test it with standalone testcases, including shared fra... Greg Shah
03:42 PM Feature #1791: implement dynamic UI support: This update for your review includes:
1. Methods renaming for @registerWidgetIdObject()@, @deregisterWidgetIdObject(... Eugenie Lyzenko
05:55 AM Feature #1791: implement dynamic UI support: Eugenie Lyzenko wrote:
> >We can remove the @LT.activateSharedFrame()@ method completely.
>
> In this case we nee... Greg Shah
05:37 AM Feature #1791: implement dynamic UI support: >We can remove the @LT.activateSharedFrame()@ method completely.
In this case we need to move the work this method... Eugenie Lyzenko
10:41 PM Feature #1791: implement dynamic UI support: > The problem here is sharedframereg is a map of <id, GenericFrame> while widget registry is a map of <id, GenericWid... Greg Shah
01:41 PM Feature #2378 (New): implements dos-hex-attribute of COLOR phrase: Marius Gligor
12:53 PM Feature #1793: improve color support: These are very good findings.
> 8. I could not do tests using dos-hex-attribute on Windows ChUI (see 2-b) However ... Greg Shah
12:07 PM Feature #1793: improve color support: Here are my conclusion doing some "researches" on color implementation for ChUI and GUI interfaces on Linux OS/ Windo... Marius Gligor
08:37 PM Feature #1793: improve color support: > The valuse are stored on Windows registry and are used by Windows GUI widgets.
> I think that our GUI implementati... Greg Shah
08:34 PM Feature #1793: improve color support: Code Review 0814a
1. Line 463 of language_statements.rules has a reference to KW_FONT.
2. The progress.g change... Greg Shah

08/18/2014

07:45 PM Feature #1791: implement dynamic UI support: >The processing of LT.replaceFrame() probably needs to remap the new frame's contained widgets into the widget regist... Eugenie Lyzenko
07:22 PM Feature #1791: implement dynamic UI support: >11. Once the client has actually hidden the frame, it will notify the server and in the LT.applyChanges() method, ... Eugenie Lyzenko
05:43 PM Feature #1791: implement dynamic UI support: >I think the sharedframereg is NOT needed after your changes. It is only used to make sure that shared frame IDs are ... Eugenie Lyzenko
04:37 PM Feature #1791: implement dynamic UI support: Eugenie Lyzenko wrote:
> >5. The deregisterFrameContent() code should still have the locking implemented...
>
> Y... Greg Shah
04:35 PM Feature #1791: implement dynamic UI support: In regard to the shared frame processing, it is quite complex. I'm not sure that our basic approach is 100% correct.... Greg Shah
04:16 PM Feature #1791: implement dynamic UI support: >5. The deregisterFrameContent() code should still have the locking implemented...
You mean @private deregisterFra... Eugenie Lyzenko
01:10 PM Feature #1791: implement dynamic UI support: Code Review 0818a
1. Please rename the following:
@registerWidgetIdObject()@ to @registerWidget()@
@deregister... Greg Shah
09:51 AM Feature #1791: implement dynamic UI support: Adding some improvements in this update:
1. Deregister frame when it is destroyed
2. Adding static method to deregi... Eugenie Lyzenko
07:49 AM Feature #1791: implement dynamic UI support: Checking the code with frame related testcases I have found potential issues with widget registry. This is related to... Eugenie Lyzenko
04:50 PM Feature #2252: implement GUI client support: Code Review vig_upd20140815a.zip
The only thing I would like to see changed is to move the common @hWin@ processin... Greg Shah
12:57 PM Feature #2252: implement GUI client support: Greg Shah wrote:
> I will handle the code review for vig_upd20140815a.zip shortly.
>
> > Only following statement... Vadim Gindin
12:28 PM Feature #2252: implement GUI client support: I will handle the code review for vig_upd20140815a.zip shortly.
> Only following statements with BEFORE-HIDE are c... Greg Shah
08:01 AM Feature #2252: implement GUI client support: Greg Shah wrote:
>
> Also, do check in your testcases.
Due to the customer server outage I have committed the t... Hynek Cihlar

08/16/2014

06:24 PM Feature #1791: implement dynamic UI support: This update adds more cleanup for frame deregistration. Looks like we need to remove widgets even when the frame is m... Eugenie Lyzenko

08/15/2014

03:21 PM Feature #2252: implement GUI client support: > Change the int data type to double for all existing data structures and attributes holding character coordinate val... Greg Shah
01:58 PM Feature #2252: implement GUI client support: *About PAUSE statements list*. Only following statements with BEFORE-HIDE are correct from the Progress point of view... Vadim Gindin
09:09 AM Feature #2252: implement GUI client support: I would like to do some real work (read code changes) on the GUI coordinate support (#2323). The following are the st... Hynek Cihlar
03:15 PM Feature #1791: implement dynamic UI support: This update for your review includes:
1. Operations with widget registry are now have protection locking
2. Addin... Eugenie Lyzenko

08/14/2014

06:33 PM Feature #1791: implement dynamic UI support: > The question: the map has data pair <Integer,GenericWidget>. On the other hand we can(and other maps uses this) use... Greg Shah
06:20 PM Feature #1791: implement dynamic UI support: Code Review 0814b
1. The locking for the widget registry (and frame registries...) needs to be improved. Right no... Greg Shah
05:12 PM Feature #1791: implement dynamic UI support: The next update for your review contains widget ID registry implementation in addition to other notes resolution. The... Eugenie Lyzenko
02:06 PM Feature #1791: implement dynamic UI support: > May be it is better to move ClientIdHelper class to com.goldencode.p2j.ui.chui package(the same place as ThinClient... Greg Shah
02:05 PM Feature #1791: implement dynamic UI support: Code Review 0814a
Yes, the approach is correct. Some minor feedback:
1. The @ClientIdHelper@ should be in the ... Greg Shah
02:01 PM Feature #1791: implement dynamic UI support: The question. May be it is better to move @ClientIdHelper@ class to @com.goldencode.p2j.ui.chui@ package(the same pla... Eugenie Lyzenko
11:44 AM Feature #1791: implement dynamic UI support: This update for review reflects the recent notes to using @ThinClient@ or @LogicalTerminal@ to work with ID. I need t... Eugenie Lyzenko
08:37 AM Feature #1791: implement dynamic UI support: Code Review 0813a
This version is very good.
My only concern is how this will work in certain scenarios like ... Greg Shah
12:54 PM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > We need to decide what is the policy of pushing a certain widge... Greg Shah
12:37 PM Feature #1793: improve color support: Here is a first version of @COLOR-TABLE@ implementation.
The implementation of @COLOR-TABLE@ looks the same as @FONT... Marius Gligor

08/13/2014

06:04 PM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> We need to decide what is the policy of pushing a certain widget config to the client:
... Hynek Cihlar
09:31 AM Feature #2252: implement GUI client support: > I will need to know not only default window from the client (static method Window.getDefaultWindow()), but also ac... Greg Shah
09:22 AM Feature #2252: implement GUI client support: About my question 4 in the note 144. I will need to know not only default window from the client (static method @Wind... Vadim Gindin
05:39 PM Feature #1791: implement dynamic UI support: The point to clarify:
>Please investigate keeping a single server-side registry of all widgets, including windows,... Eugenie Lyzenko
04:05 PM Feature #1791: implement dynamic UI support: Working on the point #7 from your note. But have the update to upload meantime.
In this update for review: @FrameI... Eugenie Lyzenko
06:28 AM Feature #1791: implement dynamic UI support: > I think the solution can be just replacement WindowConfig.SESSION_WINDOW_ID with WidgetId.DEFAULT_WINDOW_ID in all ... Greg Shah

08/12/2014

07:08 PM Feature #1791: implement dynamic UI support: > 5. The @WidgetId.allocateWindowID()@ can't work for allocating anything other than the @DEFAULT-WINDOW@, which is n... Eugenie Lyzenko
10:56 AM Feature #1791: implement dynamic UI support: Code Review 0811b
1. In WidgetId, the class javadoc states "Every JVM session has it's own set of widget ID.". Th... Greg Shah
04:34 PM Feature #2252: implement GUI client support: > Do you mean WindowWidget or exactly Window?
I mean WindowWidget.
>> 4. The external LogicalTerminal.pause*()... Greg Shah
04:13 PM Feature #2252: implement GUI client support: Greg Shah wrote:
..
> 3. @isWindowRealized()@ seems like it would be best implemented inside the @Window@ widget it... Vadim Gindin
03:14 AM Feature #2144: add minimum runtime support for methods (server): passed regression testing and committed with rev 10596. Vadim Gindin

08/11/2014

05:14 PM Feature #2144: add minimum runtime support for methods (server): Code Review 0811b
I am fine with the changes. Greg Shah
04:42 PM Feature #2144: add minimum runtime support for methods (server): next update with corrections Vadim Gindin
01:41 PM Feature #2144: add minimum runtime support for methods (server): Code Review 0811a
1. This code needs @null@ protection since @query@ can be @null@.... Greg Shah
01:29 PM Feature #2144: add minimum runtime support for methods (server): During the work on that task I found that DESELECT-ROWS is already implemented and only some error checking was neede... Vadim Gindin
03:48 PM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> # @ACTIVE-WINDOW@ (and maybe @CURRENT-WINDOW@ too) can be driven from the client-side; c... Constantin Asofiei
03:43 PM Feature #2252: implement GUI client support: Greg Shah wrote:
> Code Review vig_upd20140810a.zip
Some thoughts about this update:
# instead of @UiUtils.locateP... Constantin Asofiei
03:06 PM Feature #2252: implement GUI client support: Greg Shah wrote:
> Interesting. This is all caused by the PAGED option when the "terminal" is opened as a stream. ... Constantin Asofiei
01:21 PM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> That is an old assumption, which is no longer valid: the widget location can't change wi... Hynek Cihlar
01:20 PM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > The position of a widget can be set via both character-based an... Constantin Asofiei
12:41 PM Feature #2252: implement GUI client support: Code Review vig_upd20140810a.zip
The approach is moving in the right direction.
1. I would prefer to use an @in... Greg Shah
10:21 AM Feature #2252: implement GUI client support: Code Review ca_upd20140808c.zip
The changes are OK. Greg Shah
10:19 AM Feature #2252: implement GUI client support: > The idea was that this proves that GUI still handles the PUT SCREEN. But we need to make sure that the client code ... Greg Shah
03:43 PM Feature #1791: implement dynamic UI support: This update adds client/server session type checking into @EventDefinition.java@. Eugenie Lyzenko
12:04 PM Feature #1791: implement dynamic UI support: Forgot to add @ThinClient.java@ to previous update. Also the javadoc comments added in @WidhetId@ class. Eugenie Lyzenko
11:08 AM Feature #1791: implement dynamic UI support: The question/clarification for new ID approach update. I've found the class @EventDefinition@ is used on both on the ... Eugenie Lyzenko
02:58 PM Feature #2374: implement WINDOW events in GUI mode: From #2252 note 138:
> Doesn't it still generate the WINDOW-CLOSE 4GL event? It is very common to have code like ON ... Constantin Asofiei
02:57 PM Feature #2374 (Closed): implement WINDOW events in GUI mode: Constantin Asofiei
02:55 PM Feature #2373: implemented output to redirected, paged terminal via (un)named streams in GUI mode: Starting from the case in #2252-141, implement output to stream when the stream is paged/page-size is set and it targ... Constantin Asofiei
02:53 PM Feature #2373 (New): implemented output to redirected, paged terminal via (un)named streams in GU...: Constantin Asofiei
10:09 AM Feature #2372: implement support for PUT SCREEN in GUI: Although PUT SCREEN is documented (in the 4GL reference) as not working in GUI, in fact it can be used. However, its... Greg Shah
09:54 AM Feature #2372 (New): implement support for PUT SCREEN in GUI: Greg Shah

08/10/2014

06:50 PM Feature #1791: implement dynamic UI support: The update is the new widget ID allocation approach for you to review. Does not include the dynamic widget ID support... Eugenie Lyzenko
12:53 PM Feature #2252: implement GUI client support: Here is the first skeleton of implementation system handles ^-WINDOW. Could you look at it. I've added window Id para... Vadim Gindin

08/09/2014

06:09 PM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> The position of a widget can be set via both character-based and pixel-based coordinates... Hynek Cihlar

08/08/2014

04:25 PM Feature #2252: implement GUI client support: I would summarize behavior rules of *-WINDOW system handles as follows.
Handles itself.
1. When the 4GL starts,... Vadim Gindin
03:56 PM Feature #2252: implement GUI client support: Greg Shah wrote:
> > There were two reasons I've changed them this way:
> No, your reasons make sense. Please put ... Constantin Asofiei
08:52 AM Feature #2252: implement GUI client support: Two other thoughts:
1. When the ui/chui/ code reaches a state where:
* It only has ChUI-specific code left in i... Greg Shah
08:30 AM Feature #2252: implement GUI client support: Code Review 0808b
My only concern is with the previous @ThinClient.waitForEvent()@ change:
1. Why isn't @honorS... Greg Shah
07:08 AM Feature #2252: implement GUI client support: > add multiple driver support at runtime, to allow writing to streams. This is somehow tricky, as same widget can be ... Greg Shah
06:51 AM Feature #2252: implement GUI client support: > > 4. Why are the @ChuiWidgetFactory@ and @GuiWidgetFactory@ classes modifying the return value signature to be the ... Greg Shah
06:32 AM Feature #2252: implement GUI client support: Greg Shah wrote:
> 1. The @ProcessStream@ history entry is not accurate. You are removing the unnecessary TC import... Constantin Asofiei
03:17 PM Feature #2370: finish window popup menu impl: The window popup (shown at mouse right-click on the window title or mouse click on window icon or alt+space) needs to... Constantin Asofiei
03:15 PM Feature #2370 (Closed): finish window popup menu impl: Constantin Asofiei
03:15 PM Feature #2369: add configuration for window details inherited from the OS (title, border, color, ...: See #2252 note 127. The widow details (like title font, color, icon, border, background, etc) need to be made config... Constantin Asofiei
03:14 PM Feature #2369 (Rejected): add configuration for window details inherited from the OS (title, bord...: Constantin Asofiei
03:13 PM Feature #2368: allow widget output to stream in GUI mode: In GUI mode, writing widget to streams requires access to a ChUI driver. See #2252-127. Constantin Asofiei
03:11 PM Feature #2368 (WIP): allow widget output to stream in GUI mode: Constantin Asofiei
02:10 PM Feature #1791: implement dynamic UI support: > The ID will be incrementing for new widget?
Yes.
> Meaning allocation direction from 1 to UPPER_LIMIT, correc... Greg Shah
11:54 AM Feature #1791: implement dynamic UI support: > I am interested in the results of your PAUSE version. But we already have enough knowledge to know that there are m... Eugenie Lyzenko
09:18 AM Feature #1791: implement dynamic UI support: I am interested in the results of your PAUSE version. But we already have enough knowledge to know that there are mo... Greg Shah
07:11 AM Feature #1791: implement dynamic UI support: > Make sure to run this directly from the command line (with @-p@) instead of from the procedure editor. The procedu... Eugenie Lyzenko
06:36 AM Feature #1791: implement dynamic UI support: Eugenie, check if this limit is not somehow related to some @pro@ arguments. At least for recursivity issues, I've f... Constantin Asofiei
06:15 AM Feature #1791: implement dynamic UI support: > I made simple creation loop without delete. The results vary from run to run. The maximum I've got is 9972 creatio... Greg Shah
05:46 AM Feature #1791: implement dynamic UI support: The process of ID saturation has some notes. I made simple creation loop without delete. The results vary from run to... Eugenie Lyzenko

08/07/2014

07:09 PM Feature #2252: implement GUI client support: Code Review 0806d
This is a really great step forward for the client! I was already deep into this review before ... Greg Shah
02:21 PM Feature #2252: implement GUI client support: Replacement for ca_upd20140806d.zip. It fixes a bug exposed by regression testing (related to 0806d.zip) plus:
* cur... Constantin Asofiei
11:42 AM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> > It seems that character positioning and sizing is always performed with the default fo... Hynek Cihlar
11:04 AM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Once you have this, see what happens if the widget is moved to ... Constantin Asofiei
10:41 AM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Greg Shah wrote:
> > > What is the correct way to move a widget from one window to another?
... Hynek Cihlar
10:35 AM Feature #2252: implement GUI client support: Greg Shah wrote:
> > What is the correct way to move a widget from one window to another?
>
> The f1 frame is nev... Hynek Cihlar
10:32 AM Feature #2252: implement GUI client support: > What is the correct way to move a widget from one window to another?
The f1 frame is never realized before the @... Greg Shah
10:10 AM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Once you have this, see what happens if the widget is moved to a window with a different... Hynek Cihlar
03:03 PM Feature #1791: implement dynamic UI support: Interesting. We won't implement this feature right now.
Since we can't "see" the widget IDs that are generated in... Greg Shah
01:21 PM Feature #1791: implement dynamic UI support: >Probably so. Before I say for sure, please do this test: run the same test without the -usewidgetid and see if it be... Eugenie Lyzenko
11:55 AM Feature #1791: implement dynamic UI support: > This means Progress has serious constraint for using dynamic widgets
Yes.
> often delete/create is not recomm... Greg Shah
10:41 AM Feature #1791: implement dynamic UI support: Yes, you are right, just after attempt to create new widget in "wrap around" case - when widget with @ID = 1@ was jus... Eugenie Lyzenko
10:16 AM Bug #2365: ThinClient.trigger() and ThinClient.validate() must send the screen-buffer for all fra...: The original discussion in which this issue was identified:
-------- Original Message --------
Subject: Re: GUI ... Greg Shah
10:14 AM Bug #2365 (Closed): ThinClient.trigger() and ThinClient.validate() must send the screen-buffer fo...: Greg Shah

08/06/2014

05:18 PM Feature #1791: implement dynamic UI support: > But now we need to differentiate the server and client context for this calculation because classes used in this pr... Greg Shah
05:16 PM Feature #1791: implement dynamic UI support: > So when I got 1 number the next creation shows the error message and existed widgets disappears.
This is not exa... Greg Shah
05:09 PM Feature #1791: implement dynamic UI support: Another issue we need to solve in P2J implementation is the new implementation for @WidgetId.frameIdFromWidgetId(int ... Eugenie Lyzenko
04:19 PM Feature #2252: implement GUI client support: Greg, attached is a massive update which touches more than the window title. The GUI window is a little ugly at this... Constantin Asofiei
08:49 AM Feature #2252: implement GUI client support: Code Review vig_upd20140806a.zip
1. Can ACTIVE-WINDOW really be assigned from business logic? Your code allows it... Greg Shah
08:14 AM Feature #2252: implement GUI client support: > To add some real behavior (for ENABLE, MESSAGE and other statements) I need to know the future GUI client class. Wi... Greg Shah
05:28 AM Feature #2252: implement GUI client support: I just added new fields to @LogicalTerminal@ class. To add some real behavior (for ENABLE, MESSAGE and other statemen... Vadim Gindin

08/05/2014

03:36 PM Feature #2252: implement GUI client support: Vadim Gindin wrote:
> If you meant conversion rules, they already formulated for the corresponding task for CHUI cas... Constantin Asofiei
03:32 PM Feature #2252: implement GUI client support: If you meant conversion rules, they already formulated for the corresponding task for CHUI case. I'm trying to add ju... Vadim Gindin
03:19 PM Feature #2252: implement GUI client support: Vadim Gindin wrote:
> I tried to run _change_parent_frame.p_ with gui swing driver.
The swing gui driver is very-v... Constantin Asofiei
03:13 PM Feature #2252: implement GUI client support: I tried to run _change_parent_frame.p_ with gui swing driver. I added some UI components stubs for that, but I faced ... Vadim Gindin

08/04/2014

04:39 PM Feature #1791: implement dynamic UI support: >How did you determine that this was the behavior?
Consider the testcase @dyn_wid_test6.p@. It has two pair of but... Eugenie Lyzenko
03:39 PM Feature #1791: implement dynamic UI support: > If there are the dynamic widgets allocated at this time - they will be destroyed. So we returning to the state when... Greg Shah
02:17 PM Feature #1791: implement dynamic UI support: The investigation findings:
1. The starting point for ID allocation is 65535. Neither 0 nor 1. And more important ... Eugenie Lyzenko

08/01/2014

04:02 PM Feature #1791: implement dynamic UI support: We can at least use it for now to see how Progress creates its widget ids. Yes, it only works on GUI and without it ... Greg Shah
03:56 PM Feature #1791: implement dynamic UI support: The only I've found is @WIDGET-ID@ attribute. But it is declared as working only in Windows GUI. Is it what we implem... Eugenie Lyzenko
03:48 PM Feature #1791: implement dynamic UI support: >From what I have seen, the Progress widget ID allocation approach is a simple sequential increment. Can you find any... Eugenie Lyzenko
03:02 PM Feature #1791: implement dynamic UI support: Code Review 0731a
We can't use this approach.
First of all, widget ID allocation will be used on the server. ... Greg Shah
03:30 PM Feature #2252: implement GUI client support: Greg Shah wrote:
> > I'm trying to display this frame in every of these windows using DISPLAY .. IN WINDOW statemen... Vadim Gindin
11:59 AM Feature #2252: implement GUI client support: ca_upd20140731a.zip was released as bzr rev 10589. Constantin Asofiei
10:06 AM Feature #2252: implement GUI client support: Greg Shah wrote:
> I will let you and Constantin split the work on this one, as you find makes the most sense. Your... Hynek Cihlar
10:00 AM Feature #2252: implement GUI client support: Constantin wrote:
> I think we should do it before or at the same time with the #2323, but after my first iteration... Greg Shah
05:56 AM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> > _Note that character units are decimal values and pixels are integer values in Progres... Hynek Cihlar
05:03 AM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Greg/Hynek, something about the character and pixel units. I think these metrics can ori... Hynek Cihlar
04:59 AM Feature #2252: implement GUI client support: > Greg Shah wrote:
> > I wonder if this is also the time when we pursue #2254.
> Yes, I think we need to do this.... Hynek Cihlar

07/31/2014

05:32 PM Feature #1791: implement dynamic UI support: This update for your review is the starting point for new widget approach. The public method in @WidgetId@ class:
<p... Eugenie Lyzenko
05:24 PM Feature #2252: implement GUI client support: Greg Shah wrote:
> I wonder if this is also the time when we pursue #2254.
Yes, I think we need to do this. Bett... Constantin Asofiei
04:30 PM Feature #2252: implement GUI client support: > create APIs to push only that config to the client (i.e. only the window title, not the full config)
We don't wa... Greg Shah
04:11 PM Feature #2252: implement GUI client support: Greg, my goal would be to provide full bi-directional support of these coordinate/size attributes; but if the client ... Constantin Asofiei
01:14 PM Feature #2252: implement GUI client support: Greg/Hynek, something about the character and pixel units. I think these metrics can originate from two directions:
... Constantin Asofiei
10:16 AM Feature #2252: implement GUI client support: Code Review 0731a
It looks good. You can check-in and distribute, if you are comfortable with the level of testing. Greg Shah
09:27 AM Feature #2252: implement GUI client support: replacement for 0729a.zip: fixed the ScreenBitmap problems related to using lists of activated rectangles instead of ... Constantin Asofiei

07/29/2014

01:58 PM Feature #2252: implement GUI client support: > The code is correct, unless I got the coordinate system wrong. My assumption is that origin is on (top, left) corne... Greg Shah
11:58 AM Feature #2252: implement GUI client support: Greg Shah wrote:
> Code Review ca_upd20140729a
>
> Shouldn't it be @rect.left - baseUnit <= left@ and @rect.right... Constantin Asofiei
11:25 AM Feature #2252: implement GUI client support: Code Review ca_upd20140729a
1. In @Rectangle.difference()@, is this code correct?... Greg Shah
11:13 AM Feature #2252: implement GUI client support: Copied from #2340, posted by Constantin:
This version switches from a matrix bitmap to a list of activated rectang... Greg Shah
09:10 AM Feature #2252: implement GUI client support: Greg Shah wrote:
> As far as I can tell, the flow/rules of the layout are the same for GUI and ChUI, but because of ... Constantin Asofiei
09:02 AM Feature #2252: implement GUI client support: > I'm trying to display this frame in every of these windows using DISPLAY .. IN WINDOW statement. After execution o... Greg Shah
08:57 AM Feature #2252: implement GUI client support: > The mapping function for ChUI will be a simple 1 Character = 1 Pixel, for GUI the mapping logic will include some f... Greg Shah
06:12 AM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Also I had the impression that the font-table is allocated per session.
The font-table is ass... Constantin Asofiei
06:05 AM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Are you saying that we may not know the type/resolution of the UI for a particular session or ... Constantin Asofiei
05:53 AM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> > Ad (2)
> > All coordinate values should be stored only in the pixel units.
> I don't... Hynek Cihlar
04:18 AM Feature #2252: implement GUI client support: Greg Shah wrote:
> > 4) Unrealized windows case. There are created default window for the external procedure that ow... Vadim Gindin
03:08 AM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Ad (1)
> The proper type system is not surprisingly one of the key ingredients. Nothing new h... Constantin Asofiei
08:19 PM Feature #2252: implement GUI client support: Here are some first thoughts regarding the refactoring of coordinate system - #2323..
From what I have seen in the... Hynek Cihlar
01:23 PM Feature #1790: implement menu support: Greg Shah wrote:
> > I need to properly conversion for next line:
> > [...]
> > This code add menu to current wind... Evgeny Kiselev
01:22 PM Feature #1790: implement menu support: > I need to properly conversion for next line:
> [...]
> This code add menu to current window
Hopefully you only... Greg Shah
01:13 PM Feature #1790: implement menu support: Greg Shah wrote:
> I don't want to duplicate effort here. What do you need to add right now?
I need to properly co... Evgeny Kiselev
09:13 AM Feature #2308 (Closed): remote client launch: Greg Shah
08:14 AM Feature #2340: implement the window title bar: This version switches from a matrix bitmap to a list of activated rectangles. This allows a more dynamic approach of... Constantin Asofiei

07/28/2014

05:11 PM Feature #2252: implement GUI client support: > 2) Dialog frames. It's hard to classify this case because dialogs are not visually related to it's parent window.
... Greg Shah
01:28 PM Feature #1791: implement dynamic UI support: Sorry it has taken me so long to review your results.
> As general considerations: Currently we encode the frame I... Greg Shah
12:46 PM Feature #1793: improve color support: I fixed the issue by using OE 10.2b instead OE 11.3, thanks Constantin. Marius Gligor
12:18 PM Feature #1793: improve color support: Today I tried again to use OpenEdge for Windows on customer server.
Unfortunately I cannot use both ChUI and GUI Ope... Marius Gligor
11:15 AM Feature #1790: implement menu support: Please post your current code for an early review. Your status report noted this:
> 2) added conversion for curre... Greg Shah

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » User Interface

Activity

Activity

08/26/2014

08/25/2014

08/22/2014

08/21/2014

08/20/2014

08/19/2014

08/18/2014

08/16/2014

08/15/2014

08/14/2014

08/13/2014

08/12/2014

08/11/2014

08/10/2014

08/09/2014

08/08/2014

08/07/2014

08/06/2014

08/05/2014

08/04/2014

08/01/2014

07/31/2014

07/29/2014

07/28/2014