Activity
From 09/15/2014 to 10/14/2014
10/14/2014
- 05:48 PM Feature #2252: implement GUI client support
- Thank you for review. My comments are below.
Constantin Asofiei wrote:
> Vadim, about vig_upd20141013a.zip:
>
... - 11:45 AM Feature #2252: implement GUI client support
- Vadim, about vig_upd20141013a.zip:
Browse.java:
- line 1989/2582: avoid resolving ancestor() twice...
- line 25... - 11:23 AM Feature #2252: implement GUI client support
- Greg Shah wrote:
> Hynek Cihlar wrote:
> The @move-win()@ function and the test suite in general evolved greatly as... - 11:15 AM Feature #2252: implement GUI client support
- Code Review mag_upd20141014b.zip
It looks good. - 11:11 AM Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> Greg I have a question about the window_sizing test cases. Why some of the calls to @move-win@... - 11:10 AM Feature #2252: implement GUI client support
- Sorry was my fault. For @frame_scoping.rules@ I didn't found a solution so far.
The rules in @frame_generator.xml@ w... - 11:05 AM Feature #2252: implement GUI client support
- Vadim: Constantin is reviewing your vig_upd20141013a.zip update and will provide some feedback.
> We can see extra... - 11:01 AM Feature #2252: implement GUI client support
- Code Review mag_upd20141014a
The changes to @CommonFrame@ and @GenericFrame@ seem fine.
The @frame_scoping.rule... - 10:59 AM Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Marius Gligor wrote:
> > @FrameWidget@ has both @set/getWidth/WidthChars@ and @set/getH... - 10:16 AM Feature #2252: implement GUI client support
- Greg I have a question about the window_sizing test cases. Why some of the calls to @move-win@ function don't use the...
- 09:45 AM Feature #2252: implement GUI client support
- I did the changes for set/get WidthChars/HeightChars by inheriting from @Sizeable@ API.
- 08:02 AM Feature #2252: implement GUI client support
- Vadim Gindin wrote:
> Hynek, they are based on my update. Here it is.
I didn't find anything suspicious. I would ... - 07:01 AM Feature #2252: implement GUI client support
- Here are the results of compiling the frame test @f-1.p@ using @xref@ option: ...
- 06:16 AM Feature #2252: implement GUI client support
- Hynek, they are based on my update. Here it is.
- 05:28 AM Feature #2252: implement GUI client support
- Vadim Gindin wrote:
> I fixed HIDE error from previous regression testing and It reduced number of gso_* failed test... - 05:26 AM Feature #2252: implement GUI client support
- Sorry, Redmine corrupts output screens in my previous note in spite of it's preview displayed them correctly. I'm att...
- 05:24 AM Feature #2252: implement GUI client support
- Marius Gligor wrote:
> @FrameWidget@ has both @set/getWidth/WidthChars@ and @set/getHeight/HeightChars@ We should ke... - 05:19 AM Feature #2252: implement GUI client support
- I fixed HIDE error from previous regression testing and It reduced number of gso_* failed tests from 90 to 26. tc_* f...
- 04:49 AM Feature #2252: implement GUI client support
- @FrameWidget@ has both @set/getWidth/WidthChars@ and @set/getHeight/HeightChars@ We should keep the same methods for ...
- 03:15 AM Feature #2252: implement GUI client support
- Greg Shah wrote:
> Code Review mag_upd20141013a.zip
> 1. In methods_attributes.rules, @ref@ can't be relied upon to... - 10:44 AM Feature #1791: implement dynamic UI support
- Eugenie:
1. Please ensure that all 3 examples shown in note 212 are checked in to the dynamic widget testcases and... - 04:16 AM Feature #1791: implement dynamic UI support
- Greg Shah wrote:
> I do agree that I can't yet think of a way to make static frame statements like DISPLAY or DOWN w...
10/13/2014
- 07:08 PM Feature #1791: implement dynamic UI support
- > As we expected from the 4GL documentation the dynamic frame is only one down frame.
One thing that is strange is... - 04:06 PM Feature #1791: implement dynamic UI support
- For @iterate()@ hook. As we expected from the 4GL documentation the dynamic frame is only one down frame. Trying to u...
- 06:35 PM Feature #2252: implement GUI client support
- Code Review mag_upd20141013a.zip
I don't think either of these changes is correct.
1. In methods_attributes.rul... - 06:01 PM Feature #2252: implement GUI client support
- > How to get WindowWidget having GenericFrame or GenericWidget? Some code on server side needs to use Window handling...
- 03:32 PM Feature #2252: implement GUI client support
- How to get WindowWidget having GenericFrame or GenericWidget? Some code on server side needs to use Window handling: ...
- 10:14 AM Feature #2252: implement GUI client support
- Today I worked to fix frame conversion issues:
1. For frame scoping I changed the @frame_scoping.rules@ by adding ... - 09:12 AM Feature #2252: implement GUI client support
- Reposted from #2415 (by MAG):
Passed regression tests. Committed revision 10625.
The following files were delet... - 08:59 AM Feature #2252: implement GUI client support
- > Do you have anything against if I add the flag to the config and getters/setters to the widgets? The flag will be s...
- 09:11 AM Feature #2415 (Closed): insert indicator support for GUI window
10/11/2014
- 12:28 PM Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> ... or better yet ask the driver for the translated origin and offset @boundary@.
This one is... - 11:44 AM Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > I see. Do you have anything against if I add the flag to the co... - 05:02 AM Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> I see. Do you have anything against if I add the flag to the config and getters/setters to the... - 02:51 AM Feature #2415: insert indicator support for GUI window
- Passed regression tests. Committed revision 10625.
The following files were deleted:
src/com/goldencode/p2j/ui/cl...
10/10/2014
- 03:52 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> For a widget to be realized, it means that the widget has been viewed (made visible on the screen... - 03:37 PM Feature #2252: implement GUI client support
- For a widget to be realized, it means that the widget has been viewed (made visible on the screen) at least once. In...
- 03:28 PM Feature #2252: implement GUI client support
- I have a question to the widget experts out there. What does it mean for a window (in GUI) to be realized? I found th...
- 03:08 PM Feature #2252: implement GUI client support
- The @gso_200/buyer_search1.txt@ is only referenced in 1 test (@majic_baseline/tests/gso/gso_200/gso_200.xml@):
<pr... - 02:14 PM Feature #2252: implement GUI client support
- > > Constantin Asofiei wrote:
> Sorry, in note 315 I meant ScreenBitmap.rows/cols - this is still set to character u... - 02:06 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> Code Review vig_upd20141009a.zip
>
> I'm fine with the changes. It looks like the @messageBox... - 12:42 PM Feature #2252: implement GUI client support
- > The audit logs have always been there... I think audit might have been enabled sometime before devsrv01 was in plac...
- 12:40 PM Feature #2252: implement GUI client support
- > The problem is that generated code is not compiled due to an error in statement. fFrame.setHeightChars(new integer(...
- 12:31 PM Feature #2252: implement GUI client support
- Marius Gligor wrote:
> We could change a little bit @WidgetFactoryAdaptor.create@ method to works with constructors ... - 12:29 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> Constantin: did we intentionally enable this at some point? It seems like we should clean that u... - 12:15 PM Feature #2252: implement GUI client support
- Code Review mag_upd20141010a.zip
It looks good. Please test it. - 12:06 PM Feature #2252: implement GUI client support
- I've started to work on task #2416. First of all I converted your sample...
- 12:02 PM Feature #2252: implement GUI client support
- Fixed Code Review mag_upd20141009a.zip issues.
- 10:33 AM Feature #2252: implement GUI client support
- Code Review vig_upd20141009a.zip
I'm fine with the changes. It looks like the @messageBox()@ signatures look much... - 10:00 AM Feature #2252: implement GUI client support
- > we can add a .sh script with the same name as the archive, and execute that script in the i.e. ~/testing/majic or ...
- 09:37 AM Feature #2252: implement GUI client support
- Code Review mag_upd20141009a.zip
It looks good.
1. The explicit use of @import com.goldencode.p2j.ui.chui.ThinC... - 06:48 AM Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek, if the common UI logic is using native coordinates (you ... - 06:32 AM Feature #2252: implement GUI client support
- The next update, that failed regression testing. I've also attached logs. They looks strange. The log "testing_*" con...
- 12:36 PM Feature #1791: implement dynamic UI support
- Greg Shah wrote:
> Constantin: do you have anything to add?
Dynamic widgets can survive the creator procedure, if t... - 12:12 PM Feature #1791: implement dynamic UI support
- > Investigating the scoping approach for dynamic widgets I've found interesting info in Progress Programming Handbook...
- 09:22 AM Feature #1791: implement dynamic UI support
- Committed in bzr as 10624. No testing required.
- 09:21 AM Feature #1791: implement dynamic UI support
- Small drop to fix the missed/not required history entries. Will be committed and distributed soon.
- 01:37 AM Feature #2416 (WIP): implement frame widget support for GUI
10/09/2014
- 04:40 PM Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Hynek, if the common UI logic is using native coordinates (you have bitmaps of NativeRec... - 03:58 PM Feature #2252: implement GUI client support
- Hynek, if the common UI logic is using native coordinates (you have bitmaps of NativeRectangle), then am I correct to...
- 10:56 AM Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Greg, an idea: we can add a .sh script with the same name as the archive, and execute th... - 09:24 AM Feature #2252: implement GUI client support
- Marius Gligor wrote:
> 3. I observed that we cannot manage deleted files from project when we run regression tests. ... - 09:11 AM Feature #2252: implement GUI client support
- 1. The idea behind @AbstractMessageArea@ was to find an @OOP@ solution (abstraction) rather than a trivial test like ...
- 04:38 PM Feature #1791: implement dynamic UI support
- Investigating the scoping approach for dynamic widgets I've found interesting info in @Progress Programming Handbook@...
- 11:54 AM Bug #2418: frame construction issue
- Sometimes the frame are not correctly formed. Consider the following procedure:...
- 11:47 AM Bug #2418 (New): frame construction issue
- 09:15 AM Feature #2415 (Review): insert indicator support for GUI window
10/08/2014
- 06:26 PM Feature #2252: implement GUI client support
- About #2415 and #2334:
Now we know that there is no insert indicator for GUI. That is good information. Before w... - 03:23 PM Feature #2252: implement GUI client support
- Code Review vig_upd20141008a.zip
1. Please add this TODO just above the call to @view()@ on line 4471 of @GenericF... - 02:06 PM Feature #2252: implement GUI client support
- Vadim Gindin wrote:
> There are also other strange error:
> @org.hibernate.service.UnknownServiceException: Unknown... - 01:52 PM Feature #2252: implement GUI client support
- Merged update.
- 01:29 PM Feature #2252: implement GUI client support
- VIG: While I look at the log, please merge your vig_upd20141007a.zip with the latest bzr level 10623.
- 01:01 PM Feature #2252: implement GUI client support
- After regression testing of vig_upd20141007a.zip I faced with the error (see attached log):
@java.io.NotSerializable... - 12:37 PM Feature #2252: implement GUI client support
- Today I managed to connect @OE@ to @sports2000@ database on the customer's server. Having a database connection I did...
- 09:22 AM Feature #2333 (Closed): implement the GUI status line widget
- 02:47 AM Feature #2334 (Review): implement the GUI message line widget
- 1007b passed regression tests. committed revision 10621.
This task require more changes after task #2229 will be fin...
10/07/2014
- 01:13 PM Feature #2252: implement GUI client support
- Before you consider your work with #2415 closed, please test SET, INSERT, CHOOSE, ENABLE + WAIT-FOR. I'm not referri...
- 12:32 PM Feature #2252: implement GUI client support
- 1. I tested @INSERT@ indicator for @GUI@ using the following simple tests:...
- 10:49 AM Feature #2252: implement GUI client support
- Merged update with Constantin's fix of @ProcedureManager.currentWindow@ bug.
- 10:34 AM Feature #2334: implement the GUI message line widget
- Code Review 1007b
I'm good with the update. - 10:11 AM Feature #2334: implement the GUI message line widget
- Fixed Code Review 1007a. I renamed @MessageLineGui@ to @InsertIndicator.java@
I'm going to start regression tests. - 09:50 AM Feature #2334: implement the GUI message line widget
- Code Review 1007a
@client/chui/MessageAreaImpl.java@ is missing a history entry. Otherwise I am fine with the upd... - 06:17 AM Feature #2334: implement the GUI message line widget
- Here are my latest changes which contains:
1. I fixed @MessageAreaImpl@ issue. I renamed @MessageArea@ class as @A... - 06:23 AM Feature #2415 (WIP): insert indicator support for GUI window
10/06/2014
- 06:41 PM Feature #2252: implement GUI client support
- Details of work for #2416:
This task is about implementing GUI frame support. At this time we will only implement a... - 05:30 PM Feature #2252: implement GUI client support
- Details of work for #2415:
I have not yet seen an insert indicator be displayed/maintained in GUI windows. This i... - 11:12 AM Feature #2252: implement GUI client support
- Code Review hc_upd20141005a.zip
If it passes testing, you can check it in.
Please note that since this affects ... - 11:06 AM Feature #2252: implement GUI client support
- Code Review vig_upd20141006a.zip
This looks really good. Did you fix the NPE from regression testing yet?
1. T... - 09:40 AM Feature #2252: implement GUI client support
- Final update for #2254, replacement for 1002h.zip - passed testing, released to bzr rev 10620. The lib/aspectjtools....
- 08:27 AM Feature #2252: implement GUI client support
- The change set is already up to date with ca_upd20141003a.zip and ca_upd20140929c.zip and is currently regression-tes...
- 05:15 PM Feature #2416: implement frame widget support for GUI
- This task is only for time tracking. Please put all history entries in parent task #2252.
- 05:15 PM Feature #2416 (Closed): implement frame widget support for GUI
- 05:14 PM Feature #2415: insert indicator support for GUI window
- This task is only for time tracking. Please put all history entries in parent task #2252.
- 05:13 PM Feature #2415 (Closed): insert indicator support for GUI window
- 12:09 PM Feature #2334: implement the GUI message line widget
- @MessageAreaImpl@ in package @com.goldencode.p2j.ui.client.gui@ is no longer used on GUI. The @MessageAreaGuiImpl@ is...
- 11:57 AM Feature #2334: implement the GUI message line widget
- Code Review 1006a
Everything looks good except there is some hard coded message output in @MessageAreaImpl.draw()@... - 11:30 AM Feature #2334: implement the GUI message line widget
- I updated and configured my project to use AOP builder. Here are my latest changes and fixes that I did after doing t...
- 09:40 AM Feature #2254 (Closed): eliminate the logic in the Config* classes and make them simple container...
- 04:56 AM Feature #2254 (WIP): eliminate the logic in the Config* classes and make them simple containers w...
10/05/2014
- 05:31 PM Feature #2252: implement GUI client support
- Here is an update for multi-window support of DISPLAY/VIEW/HIDE statements. Have a look please. I'm not sure about VI...
- 04:49 PM Feature #2252: implement GUI client support
- I am attaching the change set with added javadocs and the TODO implemented.
Greg Shah wrote:
> Code Review hc_upd... - 08:13 AM Feature #2252: implement GUI client support
- Code Review hc_upd20141004a.zip
I like the approach. It changes nothing for current context local instances, but ... - 08:54 AM Feature #2412: Implement widget browser
- The Widget browser should provide runtime insight into the widget hierarchy. The idea is to have some basic functiona...
- 08:46 AM Feature #2412 (Closed): Implement widget browser
10/04/2014
- 05:32 PM Feature #2252: implement GUI client support
- @Constantin, I found a little problem with the initialization of LogicalTerminal in ca_upd20141002h.zip.
LogicalT...
10/03/2014
- 11:04 AM Feature #2252: implement GUI client support
- DOWN/UP/SCROLL statements also do not support IN WINDOW clause. Compile error is @IN WINDOW invalid with UP, DOWN, an...
- 09:34 AM Feature #2252: implement GUI client support
- Greg Shah wrote:
> It looks good. We should remember the "wishlist" somewhere for later development:
>
> * Deleg... - 08:49 AM Feature #2252: implement GUI client support
- > Regression testing of p2j trunk without my update succeed. Only 2 tests have failed: tc_job_002 and tc_misc_reports...
- 08:37 AM Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> Greg Shah wrote:
> > * Implement a listener/notification framework and a clean way to associa... - 05:44 AM Feature #2252: implement GUI client support
- Regression testing of p2j trunk without my update succeed. Only 2 tests have failed: tc_job_002 and tc_misc_reports_0...
- 02:29 AM Feature #2252: implement GUI client support
- Greg Shah wrote:
> * Implement a listener/notification framework and a clean way to associate listeners with their t...
10/02/2014
- 04:15 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> Is there anything left to do for STATUS or MESSAGE in #2229?
Nothing.
> ..
> What is the sta... - 04:00 PM Feature #2252: implement GUI client support
- Is there anything left to do for STATUS or MESSAGE in #2229? If not, then please work on DEFINE FRAME/FORM next (see...
- 03:56 PM Feature #2252: implement GUI client support
- Code Review vig_upd20141002b.zip
It looks good. - 03:52 PM Feature #2252: implement GUI client support
- I thought so. I've combined history entries.
- 03:36 PM Feature #2252: implement GUI client support
- Code Review vig_upd20141002a.zip
The changes are fine. Please do combine the history entries into a single entry ... - 03:18 PM Feature #2252: implement GUI client support
- I merged status* update and message* update. Here is the merged common update. Can I stay 2 history entries in corres...
- 12:56 PM Feature #2252: implement GUI client support
- Code Review ca_upd20141002h.zip
It looks good. We should remember the "wishlist" somewhere for later development:... - 12:11 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> 1. The @StandardServer.invoke()@ issue still exists.
Thanks, forgot about it, is fixed now.
>...
10/01/2014
- 06:26 PM Feature #2334: implement the GUI message line widget
- Code Review 1001a
The code changes look good.
I think the @ThinClient.splitMessage()@ should probably be move... - 11:58 AM Feature #2334: implement the GUI message line widget
- 1. The number of visible lines is @Window.RESERVED_LINES - 1@ (2) like on ChUI .
2. Message area could hold ... - 08:29 AM Feature #2334: implement the GUI message line widget
- I'm sure that any such code is just temporary and has no deep meaning. You can remove the conditional "protection" l...
- 06:03 AM Feature #2334: implement the GUI message line widget
- I'm trying to test the following p4 statement @current-window:message-area-font=5.@ which in turn is converted in Jav...
- 05:35 PM Feature #2252: implement GUI client support
- Code Review ca_upd20141001d.zip
1. The @StandardServer.invoke()@ issue still exists.
2. The merge of the histor... - 03:50 PM Feature #2252: implement GUI client support
- Code Review vig_upd20141001a.zip
Everything looks fine. Please merge your STATUS and MESSAGE updates into a singl... - 03:33 PM Feature #2252: implement GUI client support
- > By the way, should I ran majic from the folder @~/testing/majic@, created by @run_regression.sh configure@ or from ...
- 01:20 PM Feature #2252: implement GUI client support
- Attached update is built on top of 0926c and 0296g.zip. Not yet merged with latest version. Issues from review no...
- 12:43 PM Feature #2252: implement GUI client support
- I merged my update (message multi-window support) with the last updates, moved 3 flags from ThinClient to Window and ...
- 11:24 AM Feature #2252: implement GUI client support
- I ran regression testing on devsrv01 2 or 3 times. That is the point. I didn't see failures in the tests, that are ma...
- 08:25 AM Feature #2252: implement GUI client support
- Please focus on running testing on devsrv01. What failures are you seeing consistently on that system? How many tim...
- 03:36 AM Feature #2252: implement GUI client support
- I tried to manually recreate the failures in tests I noted earlier in devsrv01. But there were no such error. Moreove...
- 12:17 PM Feature #2340: implement the window title bar
- Regarding selection of mouse source which is the widget that should handle the mouse events.
Basically we have widg...
09/30/2014
- 04:11 PM Feature #2252: implement GUI client support
- OK, then please ignore this issue and try to debug and/or solve your problems a different way. One important questio...
- 03:49 PM Feature #2252: implement GUI client support
- No, server logs (server.log, server_gso_0.log) does not contain such error.
- 08:48 AM Feature #2252: implement GUI client support
- Are these same "apparent deadlock" issues occurring when you run testing on devsrv01?
- 07:44 AM Feature #2252: implement GUI client support
- Understood. I ran local server with remote (devsrv01) database. An Internet connection to GCD is good and stable. Con...
- 02:52 AM Feature #2252: implement GUI client support
- Yes, good point -- it makes sense that the application would not work at all if the fundamental things I told you to ...
- 03:28 PM Feature #2334: implement the GUI message line widget
- Thanks Constantin I will check on customer's server.
I have another question related to fonts please: The call to @F... - 01:46 PM Feature #2334: implement the GUI message line widget
- Greg/Marius: in case you are not aware, see note 3 from #2252 - the message area in GUI holds a maximum of 50 message...
- 01:43 PM Feature #2334: implement the GUI message line widget
- Code Review 0930a
This looks really good.
1. There are still some hard coded message lines left behind.
2. I... - 01:37 PM Feature #2334: implement the GUI message line widget
- The picture are uploaded just to show how scroll bar looks. I forced 8 lines instead 2 for message area.
When messag... - 01:05 PM Feature #2334: implement the GUI message line widget
- Why do the message-area5.png, message-area6.png and message-area7.png show a message area that is 8 lines in size? T...
- 01:00 PM Feature #2334: implement the GUI message line widget
- > Should be the same value as for ChUI or should be a parameter stored in server directory?
As I noted in note 79 ... - 10:56 AM Feature #2334: implement the GUI message line widget
- 1. For ChUI the number of message lines is hard coded and the @ThinClient# getMessageLines@ return always @Window.RES...
- 08:14 AM Feature #1791: implement dynamic UI support
- From EVL via email:
> Just for you to know: in addition there are some missing functionality on client side I've d... - 08:00 PM Feature #1791: implement dynamic UI support
- Committed to bzr as 10617.
09/29/2014
- 07:52 PM Feature #1791: implement dynamic UI support
- The @CTRL-C@ part completed without regressions. Had to start 3-way tests in separate session to get all passed in su...
- 06:22 PM Feature #1791: implement dynamic UI support
- >Please post the testcase code here.
Here it is. Pretty ugly but I guess do work.... - 05:08 PM Feature #1791: implement dynamic UI support
- In other words, we will deal with the dynamic frame scoping as the next update (after you get back).
- 05:07 PM Feature #1791: implement dynamic UI support
- > So I think the conclusion is scope is attached to widget pool, correct?
It tells us that at least some of the sc... - 04:58 PM Feature #1791: implement dynamic UI support
- >3. Try to use the frame in procedure Y, but outside (after) the REPEAT block. If that works, then you know that the ...
- 09:03 AM Feature #1791: implement dynamic UI support
- Code Review 0929a
The code looks good.
The last problem is the @openScope()@. We definitely need to execute ... - 08:40 AM Feature #1791: implement dynamic UI support
- > >3. I'm not sure opening the scope of a dynamic frame in GenericWidget.setId() is correct. That will associate it w...
- 05:15 AM Feature #1791: implement dynamic UI support
- Small change to fix resource type requesting in @GenericWidget@ for building the error message. The testing cycle is ...
- 04:48 PM Feature #2252: implement GUI client support
- Eric, If it would be a database connectivity problem the application would not work. The error happen at the quit pro...
- 02:31 PM Feature #2252: implement GUI client support
- Vadim, from the @server_gso_370.log@ file you attached, it looks like the P2J server cannot connect to the database. ...
- 01:29 PM Feature #2252: implement GUI client support
- I looked into testing results for my update and tried to reproduce failed tests locally. I found that most of them fa...
- 12:07 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> Constantin Asofiei wrote:
> > Greg Shah wrote:
> > > Wouldn't moving to tracking changes at the... - 12:04 PM Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Greg Shah wrote:
> > Wouldn't moving to tracking changes at the field-level solve this ... - 12:00 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> Wouldn't moving to tracking changes at the field-level solve this issue?
We are not in the track... - 11:30 AM Feature #2252: implement GUI client support
- Wouldn't moving to tracking changes at the field-level solve this issue?
- 11:04 AM Feature #2252: implement GUI client support
- About the MethodHandle performance issues: disabling the field setter listener code during duplicate plus the AspectJ...
- 08:30 AM Feature #2252: implement GUI client support
- > This is because the AspectJ Point Cuts (intercepted field setters) are called always (including during instance fie...
09/28/2014
- 04:28 PM Feature #1791: implement dynamic UI support
- This update for review reflects your recent notes. I'm going to put it on regression testing cycle shortly.
- 02:34 PM Feature #1791: implement dynamic UI support
- The changes passed the regression testing.
>3. I'm not sure opening the scope of a dynamic frame in GenericWidget.... - 09:55 AM Feature #1791: implement dynamic UI support
- Code Review 0927a
It looks good! As you suggest, if it passes testing you can check it in since any broken dynami... - 11:14 AM Feature #2252: implement GUI client support
- > 1. Could we drive association of common listeners (e.g. @pushScreenDefinition()@ or rounding) by AspectJ using anno...
- 09:30 AM Feature #2252: implement GUI client support
- Code Review ca_upd20140926g.zip
Generally, it all looks fine. The only thing I don't understand is why @ConfigMan...
09/27/2014
- 12:24 PM Feature #1791: implement dynamic UI support
- This is the main dynamic widget support update for review. Has the incorrect attributes handling, dynamic frames, wid...
- 12:07 PM Feature #2399: Implement output redirection in GUI mode
- The challenge here is that the GUI session uses GUI-specific widgets which know how to render themselves on raster-ba...
- 12:03 PM Feature #2399 (Rejected): Implement output redirection in GUI mode
09/26/2014
- 06:38 PM Feature #2252: implement GUI client support
- Code Review ca_upd20140926c.zip - Part 2
I still haven't reviewed your latest update. That is next. My apologies ... - 04:32 PM Feature #2252: implement GUI client support
- > In the context of #2388 I checked the current state of output redirection logic and it seems to be far away from th...
- 04:20 PM Feature #2252: implement GUI client support
- In the context of #2388 I checked the current state of output redirection logic and it seems to be far away from the ...
- 02:22 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> 1. Why not sync the server state on the next trip down to the client, instead of waiting for a @p... - 01:41 PM Feature #2252: implement GUI client support
- Code Review ca_upd20140926c.zip - Part 1
I'm half-way through the review of your previous update. I haven't looke... - 12:51 PM Feature #2252: implement GUI client support
- This update contains some fixes and the AspectJ changes related to optimizing the computation of widget config update...
- 11:48 AM Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Vadim, there is this code in OutputManager.setInvalidate which breaks the GUI window cre... - 11:19 AM Feature #2252: implement GUI client support
- I found the same problem.
I fixed this problem in my current task by creating a method @SwingGuiPrimitives#hasWindow... - 10:55 AM Feature #2252: implement GUI client support
- Vadim, there is this code in OutputManager.setInvalidate which breaks the GUI window creation:...
- 05:25 AM Feature #2252: implement GUI client support
- This entry contains details for #2254
New configuration manager
------------------------------------
The new Con... - 02:33 PM Feature #1791: implement dynamic UI support
- Greg/Eugenie: first of all, a trigger can't be registered with a handle which is not valid. The widget (dynamic or n...
- 01:50 PM Feature #1791: implement dynamic UI support
- > But imagine the case when dynamic widget creation is the result of user(or application logic) intervention. For exa...
- 01:16 PM Feature #1791: implement dynamic UI support
- >We don't want to change how the client works. The client has no knowledge of handles. And to know when to fire a tri...
- 08:55 AM Feature #1791: implement dynamic UI support
- > So the triggers should be attached to the handle itself, not to the widget object(which might be not yet created). ...
- 07:52 AM Feature #1791: implement dynamic UI support
- Triggering issue to discuss.
The problem I'm currently work with is related to the triggers identification for dyn...
09/25/2014
- 01:10 PM Feature #2334: implement the GUI message line widget
- Agreed and understood.
- 12:40 PM Feature #2334: implement the GUI message line widget
- Yes we could do the code more abstract. But first of all I want to have the coordinates fixed.
Fonts are used only o... - 12:30 PM Feature #2334: implement the GUI message line widget
- Code Review 0925a
This is really good! I'm excited that you have achieved the "Hello World" for GUI.
My only c... - 11:29 AM Feature #2334: implement the GUI message line widget
- Here are my latest changes. I fixed many problems related to status bar and message area widgets but is still an inte...
09/24/2014
- 05:34 PM Feature #1791: implement dynamic UI support
- > If something is not supported on conversion level(like RADIO-BUTTONS attribute for RADIO-SET widget) I can postpone...
- 05:13 PM Feature #1791: implement dynamic UI support
- > OK, this all sounds like a reasonable approach. How quickly can you implement the necessary changes?
I guess if... - 04:41 PM Feature #1791: implement dynamic UI support
- OK, this all sounds like a reasonable approach. How quickly can you implement the necessary changes?
- 01:11 PM Feature #1791: implement dynamic UI support
- From the testing I did I can tell we certainly need tp change the @ScreenBuffer@ class. To be able to extent the cont...
- 04:46 PM Feature #2323 (Closed): refactor coordinate system and implement GUI coordinate support
- 02:19 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> I agree. I will close #2323 unless you believe there is something else to do (outside of the add... - 10:49 AM Feature #2252: implement GUI client support
- Code Review hc_upd20140924a.zip
Wow! Great work. That is a huge amount of change. Please go ahead and check it ... - 10:31 AM Feature #2252: implement GUI client support
- Code Review vig_upd20140924a.zip
The overall approach is correct. Eventually, some of this logic may be moved to ... - 10:19 AM Feature #2252: implement GUI client support
- For the #2323 please review the attached file.
- fixed initialization of GUI mode
- fixed AlertBox positioning in... - 04:43 AM Feature #2252: implement GUI client support
- Here is the update with multi-window support for message methods. Following methods was moved from @ThinClient@ to @W...
09/23/2014
- 06:13 PM Feature #2334: implement the GUI message line widget
- > 1. The implementation of GUI widgets still depends on coordinate conversion between pixels units and character unit...
- 06:07 PM Feature #2334: implement the GUI message line widget
- Code Review 0923a
1. In @WindowGuiImpl@ do we need to keep the hard coded message output (e.g. @line 1@...)? Even... - 01:33 PM Feature #2334: implement the GUI message line widget
- A first implementation of GUI message area. I implemented a scroll bar widget a scroll pane widget and a scrollable l...
- 03:23 PM Feature #1791: implement dynamic UI support
- Eugenie, you can ignore these for now. Your support for dynamic widget creation should be generic enough to be able ...
- 03:02 PM Feature #1791: implement dynamic UI support
- There is an issues creating something other than fill-in widget. Consider the following code in @DynamicWidgetFactory...
- 01:41 PM Feature #1791: implement dynamic UI support
- How much testing have you done and what are your findings?
- 11:41 AM Feature #2252: implement GUI client support
- This is the priority order for implementation of multi-window support (please edit this entry over time to mark off w...
09/22/2014
- 10:16 AM Feature #2252: implement GUI client support
- Please see the "Source Management" section of the timco.html document for details on how to deal with check-out/check...
- 09:18 AM Feature #2252: implement GUI client support
- Vadim Gindin wrote:
> These errors correlate with my update not with Eugenys.
I guess your changes affect MAJIC cod... - 08:57 AM Feature #2252: implement GUI client support
- These errors correlate with my update not with Eugenys.
- 08:22 AM Feature #2252: implement GUI client support
- Eugenie (EVL) sent a recent update email that notified that there were MAJIC changes to match his recent check-in:
... - 08:02 AM Feature #2252: implement GUI client support
- Tried to run regression testing and faced with the problem: majic is not builded because of compile errors:...
09/20/2014
- 12:14 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> Would you please add a task documenting the problem? It should be added to the "Harness" project... - 08:32 AM Feature #2252: implement GUI client support
- > The mystery resolved! Harness reporting doesn't HTML-escape the HTML outputs, that is the reason the button is not ...
- 08:30 AM Feature #2252: implement GUI client support
- Code Review vig_upd20140920a.zip
1. @THIS-PROCEDURE:CURRENT-WINDOW@ is not handled via state sync but you previous... - 08:04 AM Feature #2252: implement GUI client support
- The mystery resolved! Harness reporting doesn't HTML-escape the HTML outputs, that is the reason the button is not vi...
09/19/2014
- 04:18 PM Feature #2252: implement GUI client support
- I made corrections. Have a look please.
- 08:08 AM Feature #2252: implement GUI client support
- Code Review vig_upd20140919c.zip
This is moving in the right direction. - 08:07 AM Feature #2252: implement GUI client support
- > > Perhaps it should be kept in a context-local static var so it is shared between all @Window@ instances for this c...
- 05:32 AM Feature #2252: implement GUI client support
- Next update with the latest corrections except StatusStack move from ThinClient. See below.
Greg Shah wrote (note ... - 02:43 PM Feature #1791: implement dynamic UI support
- > If 1-3 will work fine I think we do not need any special processing for dynamic widgets on the client side. What do...
- 01:37 PM Feature #1791: implement dynamic UI support
- >One area I wonder about is whether the client-side WidgetRegistry needs to add/remove dynamic widgets differently.
... - 11:32 AM Feature #1791: implement dynamic UI support
- OK, go ahead and commit/distribute evl_upd20140919a.zip.
> >No, there is no such thing as a NEW GLOBAL SHARED frame.... - 11:16 AM Feature #1791: implement dynamic UI support
- >Let me take one last look first.
OK.
>No, there is no such thing as a NEW GLOBAL SHARED frame. You can only cr... - 11:06 AM Feature #1791: implement dynamic UI support
- Let me take one last look first.
- 11:05 AM Feature #1791: implement dynamic UI support
- The CTRL-C testing finished without regressions. I had to run 3-way tests in standalone session and they are OK too.
... - 09:57 AM Feature #1791: implement dynamic UI support
- The only change in this update is removed TODO from @GenericWidget.resourceDelete()@.
Is it OK to commit and distr... - 06:24 AM Feature #1791: implement dynamic UI support
- >This memory leak already exists in P2J. So we can go forward with your change anyway. But I do want to fix this some...
- 11:56 AM Bug #2396: memory leak when using shared frames
- In #1791 we found that using shared frames results in a memory leak because we never fully remove shared frames from ...
- 11:28 AM Bug #2396 (New): memory leak when using shared frames
09/18/2014
- 05:32 PM Feature #2252: implement GUI client support
- Code Review vig_upd20140919b.zip
This mostly is moving in the right direction.
1. The @statusStack@, @StatusD... - 05:17 PM Feature #2252: implement GUI client support
- > 1. Why it is necessary to hold the stack of statuses even for one-window UI?
Because you can have nested WAIT-FO... - 04:50 PM Feature #2252: implement GUI client support
- Fixed 2 files (compile errors)
- 02:34 PM Feature #2252: implement GUI client support
- I've made corrections with status stack, but I have some doubts.
1. Why it is necessary to hold the stack of statu... - 12:16 PM Feature #2252: implement GUI client support
- Details for #2388:
I have created a test suite that explores the behavior of window move/positioning. #2388 is int... - 05:01 PM Feature #1791: implement dynamic UI support
- > On the other hand I think the shared frame in 4GL approach has memory leak bomb initially. We never know at this ti...
- 01:53 PM Feature #1791: implement dynamic UI support
- >1. The changes to LT bring back that memory leak of shared frames, right? I understand it may be needed to defer the...
- 01:30 PM Feature #1791: implement dynamic UI support
- >2. Can the TODO from @GenericWidget.resourceDelete()@ be removed now?
I think we can remove. This is not my TODO ... - 12:32 PM Feature #1791: implement dynamic UI support
- Code Review 0918a
I only have the following concerns:
1. The changes to LT bring back that memory leak of share... - 11:57 AM Feature #1791: implement dynamic UI support
- >Your top priority is getting the new widget ID implementation through regression testing and checked in.
OK.
>Ho... - 10:43 AM Feature #1791: implement dynamic UI support
- Your top priority is getting the new widget ID implementation through regression testing and checked in.
However, ... - 10:41 AM Feature #1791: implement dynamic UI support
- Yes, it must build upon (add to) that code.
- 10:39 AM Feature #1791: implement dynamic UI support
- >Get this update prepared and uploaded for review ASAP. Please also test it with a variety of dynamic widget cases to...
- 09:46 AM Feature #1791: implement dynamic UI support
- I am fine with the proposed approach. Some thoughts:
1. The use of reflection (to lookup the constructor) needs s... - 08:29 AM Feature #1791: implement dynamic UI support
- Now at least two issues/regressions remain:
- one for NullPointerException.
- other with shared variable missing.
... - 12:02 PM Feature #2388: finish GUI window move/position support
- This is just for time tracking. Please put all history in the parent task #2252.
- 12:01 PM Feature #2388 (Closed): finish GUI window move/position support
09/17/2014
- 07:33 PM Feature #1791: implement dynamic UI support
- Code Review 0917a
I am fine with the changes.
Besides the testing, how soon can you make a list of the changes ... - 02:58 PM Feature #1791: implement dynamic UI support
- The regression testing has regression. The next update will be tested as fix. What is in the update:
1. Merge with... - 07:23 PM Feature #2252: implement GUI client support
- > WAIT-FOR always has widget specification. This widget uniquely identify the window it belongs. Assuming we have 2 w...
- 06:40 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> I think the more important question is how does the @statusStack@ need to be implemented in a mul... - 02:05 PM Feature #2252: implement GUI client support
- > I am wondering how is the test runner interacting with the application and whether it may cause a different path of...
- 01:45 PM Feature #2252: implement GUI client support
- Regarding #2323 please advice with runtime regression results. Several test cases fail with an alert box missing butt...
- 10:35 AM Feature #2333: implement the GUI status line widget
- I am keeping this open only because we still have the drawing differences between Windows and Linux. When the #2323 ...
- 10:17 AM Feature #2333 (Review): implement the GUI status line widget
- 10:16 AM Feature #2333: implement the GUI status line widget
- 0916a passed regression tests. Committed revision 10613.
- 07:29 AM Feature #2334: implement the GUI message line widget
- In @OpenEdge@ GUI the message area is a reserved region at the bottom of window above status bar implemented as a scr...
- 01:42 AM Feature #2334 (WIP): implement the GUI message line widget
09/16/2014
- 02:25 PM Feature #2252: implement GUI client support
- > I asked more about popStatus and pushStatus, rather then nesting. Do you mean I should stay these methods in ThinCl...
- 01:59 PM Feature #2252: implement GUI client support
- I asked more about popStatus and pushStatus, rather then nesting. Do you mean I should stay these methods in ThinClient?
- 01:38 PM Feature #2252: implement GUI client support
- > Recalling, I'm going to move these methods (pop and push) to Window. What window to apply these methods for? May be...
- 01:15 PM Feature #2252: implement GUI client support
- I have the following question about methods @pushStatus@ and @popStatus@ (ThinClient). They are called from applyChan...
- 10:55 AM Feature #2252: implement GUI client support
- In regard to task #2334 (finish message area support), the following needs to be done:
* create a proper scrollabl... - 11:15 AM Feature #2333: implement the GUI status line widget
- OK, the failure is actually on the client side and it is just that our GUI support does not yet handle frames. So wh...
- 11:12 AM Feature #2333: implement the GUI status line widget
- [09/16/2014 18:11:26 EEST] (StandardServer.invoke:SEVERE) {00000005:00000016:bogus} Abnormal end!
java.lang.reflect.... - 11:10 AM Feature #2333: implement the GUI status line widget
- Please post the full stack trace.
- 11:09 AM Feature #2333: implement the GUI status line widget
- I found the following error: @Attempt to instantiate classclass com.goldencode.p2j.ui.client.Frame which has no prope...
- 11:05 AM Feature #2333: implement the GUI status line widget
- What causes the server-side crash?
- 11:03 AM Feature #2333: implement the GUI status line widget
- When GUI client starts after authentication the @Ask.p@ is tried to be executed on server side but crash in @Standard...
- 10:50 AM Feature #2333: implement the GUI status line widget
- Code Review 0916a
The changes look good. Please go ahead into runtime regression testing.
> In conclusions all... - 10:20 AM Feature #2333: implement the GUI status line widget
- 1. Insets could be used by other widgets as well like message area, window title bar.
Even window widgets could ...
09/15/2014
- 04:20 PM Feature #2252: implement GUI client support
- > I'm just recalling that the client-side implementation is not finished yet. Status line does not display a value.
... - 03:35 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
>..
> Is there anything else that remains to be done to finish multi-window status support?
I'm... - 11:38 AM Feature #2252: implement GUI client support
- Code Review vig_upd20140912a.zip
In general, the changes are really good. I do want to make some slight changes t... - 10:01 AM Feature #2252: implement GUI client support
- > Considering that if i.e. char metrics are set, the pixel metrics automatically change, I'm inclined to let the clie...
- 03:17 PM Feature #2333: implement the GUI status line widget
- Code Review 0915a
The changes look very good.
1. Are the @GuiOptions@ insets only useful for the status line? ... - 11:47 AM Feature #2333: implement the GUI status line widget
- Here are the changes which I did so far. Some of the changes like color inheritance could be applied to other widget...
- 02:42 PM Feature #1791: implement dynamic UI support
- OK, we will keep going with the current plan. Hopefully it will pass testing and get checked in tomorrow.
- 02:34 PM Feature #1791: implement dynamic UI support
- Greg Shah wrote:
> This update just puts the new ID infrastructure into place. It doesn't solve any of the other dy... - 02:31 PM Feature #1791: implement dynamic UI support
- > My goal is to separate the widget's config (and in the end the runtime state) from its concrete implementation, so...
- 01:49 PM Feature #1791: implement dynamic UI support
- On a side note, do you now how much work is left on this task? I want to integrate this with my changes.
- 01:33 PM Feature #1791: implement dynamic UI support
- Greg Shah wrote:
> How many of these cases can act like "real" widgets? In other words, many of these are not treat... - 12:57 PM Feature #1791: implement dynamic UI support
- How many of these cases can act like "real" widgets? In other words, many of these are not treated as widgets by the...
- 11:49 AM Feature #1791: implement dynamic UI support
- Greg Shah wrote:
> > there are some widgets created on client-side which don't have a server-side counterpart
>
>... - 11:43 AM Feature #1791: implement dynamic UI support
- > there are some widgets created on client-side which don't have a server-side counterpart
Please provide more det... - 10:11 AM Feature #1791: implement dynamic UI support
- Greg/Eugenie: there are some widgets created on client-side which don't have a server-side counterpart. Looking at t...
Also available in: Atom