Activity

From 03/25/2015 to 04/23/2015

04/23/2015

05:08 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Today I analyzed the case of nested frames and some other corner cases. Hopefully now we have a complete picture.
Le... Igor Skornyakov
02:57 PM Feature #1790: implement menu support: Vadim Gindin wrote:
> > > If so, then this means that the 4GL is setting a "fake" keycode as 1079 and lastkey is -1.... Constantin Asofiei
02:38 PM Feature #1790: implement menu support: Code Review vig_upd20150423a.zip
This is quite good.
1. In @Menu.java@, what is the requirement for import of @... Greg Shah
02:12 PM Feature #1790: implement menu support: At the first time I met this bug I thought that it is related to MENU-DROP. Now I think it is not related. Vadim Gindin
02:09 PM Feature #1790: implement menu support: Is the pause behavior related to MENU-DROP? Greg Shah
02:08 PM Feature #1790: implement menu support: PAUSE behavior fix is left. The current bug is the following. In Constantin's procedure message "bogus message so tha... Vadim Gindin
01:57 PM Feature #1790: implement menu support: I will look at the code next.
What is left to do to make ChUI menus fully functional? Greg Shah
01:27 PM Feature #1790: implement menu support: I didn't find another way beside to make hardcode fix for MENU-DROP event case for LAST-EVENT attributes. All attribu... Vadim Gindin
10:01 AM Feature #1790: implement menu support: > > If so, then this means that the 4GL is setting a "fake" keycode as 1079 and lastkey is -1. This means you woul... Vadim Gindin
09:55 AM Feature #1790: implement menu support: Greg Shah wrote:
> > Here is the sample output string for one trigger run:
> >
> > @MENU-DROP -1 PROGRESS 1079... Vadim Gindin
08:52 AM Feature #1790: implement menu support: > Here is the sample output string for one trigger run:
>
> @MENU-DROP -1 PROGRESS 1079 MENU-DROP PSEUDO-WIDGET... Greg Shah
08:14 AM Feature #1790: implement menu support: Vadim Gindin wrote:
> There are some interesting information in _langref_ in the definition of ON statement:
> [...... Constantin Asofiei
07:54 AM Feature #1790: implement menu support: Vadim Gindin wrote:
> About "no pause on RETURN" strange, but after I ran your procedure, choose sub-menu "Orwell", ... Constantin Asofiei
04:07 AM Feature #1790: implement menu support: My MENU-DROP trigger is the following:... Vadim Gindin
03:14 AM Feature #2546: implement combo-box widget in GUI: Eugenie Lyzenko wrote:
> Constantin, I see the @ScrollableListGuiImpl@ class implemented. Is it the GUI version of t... Constantin Asofiei
08:30 PM Feature #2546: implement combo-box widget in GUI: Code Review evl_upd20150422b.zip
It is a good start. Greg Shah
08:11 PM Feature #2546: implement combo-box widget in GUI: This is the current update for @combo-box@ implementation in addition to screens from P2J and 4GL. The drop-down butt... Eugenie Lyzenko
08:33 PM Feature #2545: add support for specially named button images: Code Review evl_upd20150422c.zip
It looks good. Greg Shah
08:31 PM Feature #2545: add support for specially named button images: Greg Shah wrote:
> Code Review evl_upd20150422a.zip
>
> Please move the @public static final@ members above the @... Eugenie Lyzenko
08:22 PM Feature #2545: add support for specially named button images: Code Review evl_upd20150422a.zip
Please move the @public static final@ members above the @private@ members. And t... Greg Shah

04/22/2015

07:49 PM Feature #2545: add support for specially named button images: The update has minor @javadoc@ comment fixes and making some constant public to be used in @ComboBoxGuiImpl@ when the... Eugenie Lyzenko
06:50 PM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> I think this is a good example of the case when, instead of relying on a synchronization mecha... Hynek Cihlar
06:47 PM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> So we have two options:
> # identify all cases which need to call super.afterConfigUpda... Hynek Cihlar
06:20 PM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> And even if we make these changes, the widget's size does not get update. This is relat... Constantin Asofiei
05:43 PM Feature #2252: implement GUI client support: Hynek, by any chance, do you have any FORMAT-related issues? Because this test is not working:... Constantin Asofiei
10:12 AM Feature #2252: implement GUI client support: Code Review hc_upd20150421c.zip
Everything looks good. I appreciate the improved comments and javadoc. It is ver... Greg Shah
05:13 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Constantin Asofiei wrote:
> You're welcome. But, are you sure you need FRAME:ROW/FRAME:BOX attributes? If the form... Igor Skornyakov
05:07 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor Skornyakov wrote:
> Well, Constantin was right - the rule for the INNER-LINES attribute setter is pretty simple... Constantin Asofiei
04:46 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Well, Constantin was right - the rule for the INNER-LINES attribute setter is pretty simple:
@<new value>@ = @min(<a... Igor Skornyakov
12:12 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Constantin Asofiei wrote:
> You can experiment with boxed or no-boxed frames, other widget/frame positions; if you f... Igor Skornyakov
11:57 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor, what I think is happening is this:
# the combo's drop box (when drawn) can not exceed beyond the status area. ... Constantin Asofiei
11:06 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Hynek Cihlar wrote:
> The algorithm maybe accounts for the widget border, at least in the case of @N2@?
Well, bot... Igor Skornyakov
10:44 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: The algorithm maybe accounts for the widget border, at least in the case of @N2@? Hynek Cihlar
10:27 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Wow, that is not complicated at all. :)
I've added Hynek and Eugenie as watchers. Eugenie is working on @ComboBox... Greg Shah
12:34 PM Feature #2546: implement combo-box widget in GUI: If the 4GL inherits the color from the container, then we need to do so as well.
If our result is incorrect becaus... Greg Shah
12:14 PM Feature #2546: implement combo-box widget in GUI: >> I'm asking because currently our colors differs from what we have in 4GL.
>
>Please provide some specifics.
... Eugenie Lyzenko
10:33 AM Feature #2546: implement combo-box widget in GUI: Good headway. Would you please also attach the Windows 4GL version of this same procedure?
> The plan is to attac... Greg Shah
09:58 PM Feature #2546: implement combo-box widget in GUI: The attached sample is the current state of the GUI implementations. The plan is to attach drop-down button based on ... Eugenie Lyzenko
12:28 PM Feature #1790: implement menu support: > Are there some artificial events like MENU-DROP, that also have no key?
Yes, everything in @Keyboard.evNames1@. ... Greg Shah
12:24 PM Feature #1790: implement menu support: I've tried do not use I/O operations in MENU-DROP trigger and accumulate strings in a global array and got the same r... Vadim Gindin
11:55 AM Feature #1790: implement menu support: Greg Shah wrote:
> > @keycode("MENU-DROP")@ is -1. Why?
>
> I assume you are describing the 4GL here? I guess th... Vadim Gindin
10:55 AM Feature #1790: implement menu support: > @keycode("MENU-DROP")@ is -1. Why?
I assume you are describing the 4GL here? I guess the reason is simply that ... Greg Shah
11:07 AM Feature #1798: implement full frame family support (parent-child relationships between frames): Code Review ca_upd20150421a.zip
I'm good with the changes. Greg Shah
02:54 AM Feature #1798: implement full frame family support (parent-child relationships between frames): This version passed runtime testing (fixes problems in TC.setScreenBuffer).
Will retest/release after HC's config ... Constantin Asofiei
09:55 AM Feature #2422: add features to BROWSE: > Because this is not a browse problem and I cannot fix it quickly, I'll return to it after all other browse work is ... Greg Shah
07:25 AM Feature #2422: add features to BROWSE: Conversion bug - two temp-tables with different labels / column labels are converted to the same @TempRecord@ class. ... Stanislav Lomany

04/21/2015

04:17 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Contrary to the 4GL docs the INNER-LINES attribute for the COMBO-BOX does have meaning in ChUI - it affects the heigh... Igor Skornyakov
04:03 PM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> I have Majic changes for review, should I post them here?
No, create a new task in the Majic ... Constantin Asofiei
04:02 PM Feature #2252: implement GUI client support: I have Majic changes for review, should I post them here? Hynek Cihlar
03:08 PM Feature #2252: implement GUI client support: The attached replaces hc_upd20150420g.zip and contains changes based on the review, Majic regression fixes and improv... Hynek Cihlar
10:45 AM Feature #2252: implement GUI client support: Greg Shah wrote:
> Code Review hc_upd20150420g.zip
>
> This is a really great step forward. Some comments and qu... Hynek Cihlar
10:01 AM Feature #2252: implement GUI client support: Code Review hc_upd20150420g.zip
This is a really great step forward. Some comments and questions:
1. I don't u... Greg Shah
09:16 PM Feature #2252: implement GUI client support: Attached is an update to the config refactoring work. The changes from last review are: worked-in comments, Majic reg... Hynek Cihlar
03:27 PM Feature #1790: implement menu support: There are some interesting information in _langref_ in the definition of ON statement:... Vadim Gindin
03:02 PM Feature #1790: implement menu support: A couple of questions about MENU-DROP event.
# @keycode("MENU-DROP")@ is -1. Why?
# @last-event:code@ is 1079. Wh... Vadim Gindin
02:54 PM Feature #1790: implement menu support: Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Questions.
> > # How to duplicate double call of trigger?
> I... Vadim Gindin
01:45 PM Feature #1811: implement the AJAX client driver: +Research Item+
*What is the best approach to provide web GUI client support for images as provided in the 4GL?*
... Greg Shah
11:12 AM Feature #1811: implement the AJAX client driver: The following are the next development steps to implement the GUI web client:
# Much of the web-specific code for ... Greg Shah

04/20/2015

02:59 PM Feature #2545: add support for specially named button images: > The only I can say was "stolen" is the size of the images (16x16) and how it looks.
This isn't stealing. Such ... Greg Shah
02:58 PM Feature #2545: add support for specially named button images: Code Review evl_upd20150420a.zip
It is good. Greg Shah
02:38 PM Feature #2545: add support for specially named button images: >1. In ButtonWidget change the import com.goldencode.p2j.ui.client.*; into import com.goldencode.p2j.ui.client.ImageH... Eugenie Lyzenko
02:03 PM Feature #2545: add support for specially named button images: Code Review evl_upd20150417a.zip
1. In @ButtonWidget@ change the @import com.goldencode.p2j.ui.client.*;@ into @im... Greg Shah
01:41 PM Feature #1790: implement menu support: Vadim Gindin wrote:
> Questions.
> # How to duplicate double call of trigger?
I think you need to explicitly treat... Constantin Asofiei
01:22 PM Feature #1790: implement menu support: I'm working on the last founded bug with pause. I've simplified testing procedure as it was possible:... Vadim Gindin

04/18/2015

04:33 PM Feature #2545: add support for specially named button images: All my button tests work fine with this update. So waiting for Hynek to checking in. Or may be there are the notes fr... Eugenie Lyzenko
08:28 PM Feature #2545: add support for specially named button images: This update for review is merged with the recent code base full support for prepackaged button images. 4 more icons h... Eugenie Lyzenko

04/17/2015

04:45 PM Feature #1790: implement menu support: Constantin Asofiei wrote:
> About 0417a.zip:
> * Please check the header for LogicalTerminal, is not merged properl... Vadim Gindin
01:46 PM Feature #1790: implement menu support: About 0417a.zip:
* Please check the header for LogicalTerminal, is not merged properly.
* MenuItemWidget - don't ad... Constantin Asofiei
12:46 PM Feature #1790: implement menu support: Here it is:... Vadim Gindin
11:42 AM Feature #1790: implement menu support: Here is my current update. Vadim Gindin
09:44 AM Feature #1790: implement menu support: Vadim Gindin wrote:
> I'm testing pausing bug from the note №265 and I need help. Here is what I've founded during t... Constantin Asofiei
09:33 AM Feature #1790: implement menu support: > P.S. I've change base classes of MenuItemWidget and MenuItemConfig to BaseEntity/BaseEntityConfig. But I can't do t... Greg Shah
03:57 PM Feature #1798: implement full frame family support (parent-child relationships between frames): Replacement of 0416c.zip. Fixed a regression and some other issues. Constantin Asofiei
02:50 PM Feature #1798: implement full frame family support (parent-child relationships between frames): > I was under the impression that we removed the "use a base ID for determining the frame's widget IDs", but we still... Greg Shah
02:39 PM Feature #1798: implement full frame family support (parent-child relationships between frames): I was under the impression that we removed the "use a base ID for determining the frame's widget IDs", but we still u... Constantin Asofiei
02:14 PM Feature #1798: implement full frame family support (parent-child relationships between frames): Greg Shah wrote:
> Code Review ca_upd20150416c.zip
>
> It looks good. It may make sense to not check this in unt... Constantin Asofiei
11:00 AM Feature #1798: implement full frame family support (parent-child relationships between frames): Code Review ca_upd20150416c.zip
It looks good. It may make sense to not check this in until after Hynek checks in... Greg Shah
03:15 PM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Very well, I implemented this for X attribute as well as it fol... Hynek Cihlar
11:07 AM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Very well, I implemented this for X attribute as well as it follows the same logic.
Please up... Constantin Asofiei
09:37 AM Feature #2422: add features to BROWSE: > I suggest to NOT implement the "weird" mode (1-7).
Agreed. Greg Shah
03:56 AM Feature #2422: add features to BROWSE: Implemented SELECT-NEXT/PREV-ROW, MAX-DATA-GUESS and ROW-MARKERS. Committed to bzr rev 10839. Stanislav Lomany
08:18 PM Feature #2422: add features to BROWSE: The set or rules for REFRESHABLE. By the "repositioned row" I mean the last row the query was repositioned to.
h3. R... Stanislav Lomany
09:40 PM Feature #2545: add support for specially named button images: The next step for review in prepackaged images support:
- the DEFINE BUTTON rule has been changes to add missing @SI... Eugenie Lyzenko

04/16/2015

03:18 PM Feature #1798: implement full frame family support (parent-child relationships between frames): This update adds server-side support for FIRST/LAST-CHILD and finishes server-side support for PARENT.
Also, NEXT/PR... Constantin Asofiei
05:58 AM Feature #1798 (WIP): implement full frame family support (parent-child relationships between frames): > Window family support is needed as well. We can split that off into another task if that is worthwhile. Window fa... Constantin Asofiei
02:43 PM Feature #2451 (Closed): implement FILL-IN widget in GUI client: Greg Shah
11:59 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> > I was looking for the annotated setter/getter
>
> That annotation does look like it is missi... Constantin Asofiei
10:36 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> > I was looking for the annotated setter/getter
>
> That annotation does look like it is missi... Igor Skornyakov
10:33 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: > I was looking for the annotated setter/getter
That annotation does look like it is missing in @CommonWidget.setF... Greg Shah
10:17 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> @GenericWidget.setFormat()@ calls @WidgetConfig.setDynamicFormat()@ which should set the @Control... Igor Skornyakov
10:06 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: @GenericWidget.setFormat()@ calls @WidgetConfig.setDynamicFormat()@ which should set the @ControlSetConfig.format@. Greg Shah
09:56 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> @ComboBoxConfig@ is a @ControlSetConfig@ which already supports the @FORMAT@ attribute. Is that ... Igor Skornyakov
10:14 AM Feature #2252: implement GUI client support: Very well, I implemented this for X attribute as well as it follows the same logic. Hynek Cihlar
09:50 AM Feature #2252: implement GUI client support: OK, this is not dead code. The problem the code was trying to fix was related to side-labels and changing the side-l... Constantin Asofiei
09:30 AM Feature #2252: implement GUI client support: This case brings you to a literal, although in P2J first-child doesn't yet work. I think that is really dead code, a... Constantin Asofiei
09:19 AM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin, @LiteralWidget.setColumnOrRowWorker()@ contains @co... Hynek Cihlar
09:11 AM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Constantin, @LiteralWidget.setColumnOrRowWorker()@ contains @config.align == ControlEntity.ALI... Constantin Asofiei
09:02 AM Feature #2252: implement GUI client support: Constantin, @LiteralWidget.setColumnOrRowWorker()@ contains @config.align == ControlEntity.ALIGN_RIGHT@ condition. I ... Hynek Cihlar
08:34 AM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Greg Shah wrote:
> > > Alternatively I can introduce new method next to Widget.getId(), Widge... Greg Shah
05:58 AM Feature #2252: implement GUI client support: Greg Shah wrote:
> BTW, I think the ca_upd201504315c.zip update is for #1798 not #2229.
Correct. I've added notes ... Constantin Asofiei
04:57 AM Feature #2252: implement GUI client support: Greg Shah wrote:
> > Alternatively I can introduce new method next to Widget.getId(), Widget.getIdInt() maybe?
>
... Hynek Cihlar
09:07 AM Feature #1790: implement menu support: I'm testing pausing bug from the note №265 and I need help. Here is what I've founded during today's testing.
# The ... Vadim Gindin
08:43 PM Feature #2545: add support for specially named button images: The update has basic implementation for prepackaged button images support. Several notes for what is ready:
- in 4GL... Eugenie Lyzenko
08:34 PM Feature #2422: add features to BROWSE: The plan is fine. How long do you need for the implementation? Greg Shah

04/15/2015

07:59 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: @ComboBoxConfig@ is a @ControlSetConfig@ which already supports the @FORMAT@ attribute. Is that not sufficient? Greg Shah
06:45 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: As far as I understand the SET-SELECTION method (and its companion SELECTION-TEXT attribute) for COMBO-BOX depends on... Igor Skornyakov
06:56 PM Feature #2422: add features to BROWSE: About REFRESHABLE. Typical use case of it is the following:
# Set it OFF.
# Make some repositions/re-open query, i.... Stanislav Lomany
12:31 PM Feature #2422: add features to BROWSE: Eric Faulhaber wrote:
> Stanislav Lomany wrote:
> > 3. Potentially there may be cases that fill-in state may differ... Greg Shah
12:21 PM Feature #2422: add features to BROWSE: Code Review svl_upd20150415a.zip
I'm good with the changes. Please get them regression tested.
Greg Shah
07:32 AM Feature #2422: add features to BROWSE: I'll put here rules which are applied to MAX-DATA-GUESS:
* Its default value is 100.
* For preselect queries it equ... Stanislav Lomany
06:25 PM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> And about the overhead: try to determine the CPU time/invocation count for your new aspe... Hynek Cihlar
04:58 PM Feature #2252: implement GUI client support: BTW, I think the ca_upd201504315c.zip update is for #1798 not #2229. Greg Shah
04:57 PM Feature #2252: implement GUI client support: Code Review ca_upd201504315c.zip
This is a really good update. The subject matter is tricky but you have implemen... Greg Shah
03:42 PM Feature #2252: implement GUI client support: This is for the #2229, WINDOW:PARENT attribute. It adds runtime support for window families: for the WINDOW-MINIMIZE... Constantin Asofiei
12:23 PM Feature #2545: add support for specially named button images: OK, then the only thing I want you to change in the plan is to bypass app jar and local client filesystem searches wi... Greg Shah
11:24 AM Feature #2545: add support for specially named button images: >What is missing?
Loading an image(not default icon for main window) from @p2j.jar@ file. Eugenie Lyzenko
11:02 AM Feature #2545: add support for specially named button images: > - store the arrow images on the client side p2j.jar file.
Yes.
> - use the current tools to load button image... Greg Shah
10:58 AM Feature #2545: add support for specially named button images: >In the 4GL, does one specify the special image name as a quoted string ("btn-up-arrow") or as unquoted text btn-up-a... Eugenie Lyzenko
10:28 AM Feature #2545: add support for specially named button images: In the 4GL, does one specify the special image name as a quoted string (@"btn-up-arrow"@) or as unquoted text @btn-up... Greg Shah
08:32 PM Feature #2545: add support for specially named button images: The base for embedded images is ready but the investigation shows we do not have the functionality to load them from ... Eugenie Lyzenko

04/14/2015

05:12 PM Feature #2422: add features to BROWSE: Update for review. Contains SELECT-NEXT/PREV-ROW, MAX-DATA-GUESS and ROW-MARKERS. Stanislav Lomany
09:57 AM Feature #2422: add features to BROWSE: > Is it feasible to subclass here instead?
Yes, we can do that. Stanislav Lomany
09:52 AM Feature #2422: add features to BROWSE: Stanislav Lomany wrote:
> 3. Potentially there may be cases that fill-in state may differ from browse column state, ... Eric Faulhaber
09:48 AM Feature #2422: add features to BROWSE: > In the Option 2 getter, I don't understand what this means: @--TriggerProcessing pushes screen definitions-->@.
... Stanislav Lomany
08:33 AM Feature #2422: add features to BROWSE: Option 1 is not feasible. The performance cost is too great. Attributes and methods can be called in loops. We can... Greg Shah
04:43 PM Feature #1790: implement menu support: As I stated in note 271 item 7, I really think that inheriting from @BaseEntity@/@BaseConfig@ does make sense. Other... Greg Shah
04:35 PM Feature #1790: implement menu support: Vadim Gindin wrote:
> P.S. Constantin, about base classes for config and MenuItemWidget. I can't remember concrete r... Constantin Asofiei
04:06 PM Feature #1790: implement menu support: Here is the next update with the following fixes:
# Fixes of previous Greg's remarks.
# Fix of parent bug. I added ... Vadim Gindin
08:40 AM Feature #1790: implement menu support: About the parent issue:
# there should be only one @parentId@ attribute, now we have one in @BaseConfig@ and one in @... Constantin Asofiei
03:16 PM Feature #2481 (Closed): enable, test and fix clipping for both rectangle and button GUI widgets: Greg Shah
02:48 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: @0414b@ committed in bzr as 10834. Will be distributed shortly. Eugenie Lyzenko
02:18 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Code Review evl_upd20150414b.zip
I'm good with the changes. Please go ahead and check them in since they only aff... Greg Shah
01:47 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: The repacked update for review with modified @FrameGuiImpl@ and removed @ThinClient@. Eugenie Lyzenko
01:32 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Eugenie Lyzenko wrote:
> Another word neither @FrameGuiImpl@(the updates will come from you) not @ThinClient@ are in... Constantin Asofiei
01:29 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Constantin Asofiei wrote:
> So, the plan is: remove the TC changes, add the @FrameGuiImpl.resizeScrollPane@ change I... Eugenie Lyzenko
01:20 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Eugenie, the tests you mention work fine with my #2451 work, and are incorrect without it: so this problem was relate... Constantin Asofiei
12:55 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: The update has modified @TC@ to brace widget painting inside @TC.eventDrawingBracket()@ for both cases, @viewWorker()... Eugenie Lyzenko
12:35 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Sorry for rectangle it is better to use @rect_test4.p@, after filling become off. Eugenie Lyzenko
09:56 AM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: >Do you have a recreate for rectangle/button, with the same (or similar) mis-placement as the fill-in? I can't find a... Eugenie Lyzenko
09:36 AM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Eugenie Lyzenko wrote:
> >Do you see this with other widgets beside FILL-IN? Because looks like with my frame layout... Constantin Asofiei
09:24 AM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: >Do you see this with other widgets beside FILL-IN? Because looks like with my frame layout changes in #2451 (pending... Eugenie Lyzenko
09:19 AM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Eugenie Lyzenko wrote:
> Yes, I know, this should go this way. But sometimes coordinate translation become inconsist... Constantin Asofiei
09:04 AM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: >No, I haven't encountered this issue. Can you tell me the test and steps to recreate this?
This is the @uast/button... Eugenie Lyzenko
08:52 AM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > Eugenie, from the update, the only changes I'm not OK with a... Constantin Asofiei
08:46 AM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Constantin Asofiei wrote:
> Eugenie, from the update, the only changes I'm not OK with are the TC changes:
> # @dra... Eugenie Lyzenko
04:50 AM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Eugenie, from the update, the only changes I'm not OK with are the TC changes:
# @drawAffectedWidgets@ - this is not... Constantin Asofiei

04/13/2015

06:54 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: The update for review adds clipping feature tested and multiple minor fixes taking into account changed widget coordi... Eugenie Lyzenko
01:55 PM Feature #2422: add features to BROWSE: My vision of two options explained:
Option 1 getter:
@BrowseWidget.getSome --LogicalTerminal API call--> Browse.get... Stanislav Lomany
12:36 PM Feature #2422: add features to BROWSE: In the 4GL many browse column attributes/methods are really just "redirected" from the contained control. I really d... Greg Shah
12:18 PM Feature #2422: add features to BROWSE: Guys, the CURSOR-OFFSET and AUTO-ZAP attributes reflect corresponding attributes of the fill-in which represents the ... Stanislav Lomany
06:15 AM Feature #2422: add features to BROWSE: COLUMN-BGCOLOR attribute is applicable to GUI only. Stanislav Lomany
10:10 AM Feature #1790: implement menu support: > I'll probably need additional state attribute in config class, for example "initialDisabled" and set it only during... Greg Shah
10:06 AM Feature #1790: implement menu support: > As you can see from AST mi has type VAR_HANDLE.
That is as it should be. @mi@ is really a reference to a handle... Greg Shah
09:51 AM Feature #1790: implement menu support: Vadim Gindin wrote:
> What is @<shadow-node .. />@ in AST tree?
These are nodes that store hidden tokens like whi... Greg Shah
08:46 AM Feature #1790: implement menu support: The question about mnemonic bug. Mnemonic is a char in the menu-item title that is a menu-item hot-key. It is specifi... Vadim Gindin
09:48 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Please check it in. Greg Shah

04/12/2015

09:19 AM Feature #1790: implement menu support: I made the test procedure that is similar to mine. This procedure creates dynamic frame widget (FillIn) and tries to ... Vadim Gindin
07:32 AM Feature #1790: implement menu support: What is @<shadow-node .. />@ in AST tree? Vadim Gindin

04/11/2015

07:13 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: The update for review adds fix for UI screen phantom rectangle issue. The @TC.viewWorker()@ needs to use indirect @re... Eugenie Lyzenko
08:32 AM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Code Review evl_upd20150410a.zip
I'm OK with the changes. Greg Shah
08:36 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: This update includes rectangle related clipping functionality plus minor clean up. The @GuiSimulator@ also has minor ... Eugenie Lyzenko
05:15 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: All regression tests (except tc_job_002) passed. Igor Skornyakov
08:21 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Code Review ias_upd20150411a.zip
The change looks fine. Greg Shah
04:45 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Fixed bug found by regression test Igor Skornyakov

04/10/2015

04:58 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: >Eugenie: this is fixed in FrameGuiImpl.resizeScrollPane. Here is the code which places the scroll-pane in the correc... Eugenie Lyzenko
03:38 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Greg Shah wrote:
> Does the solution delegate the calculation of the correct drawing space to the container?
The ro... Constantin Asofiei
02:54 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Does the solution delegate the calculation of the correct drawing space to the container? Greg Shah
02:51 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Eugenie Lyzenko wrote:
> It is not Window issue, my explanation was bad. It is Frame issue. If there is no outer box... Constantin Asofiei
02:49 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: It is not Window issue, my explanation was bad. It is Frame issue. If there is no outer box in a frame our coordinate... Eugenie Lyzenko
11:25 AM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: >Are we just incorrectly reporting the coordinates of the Window's "client area"? The 1-pixel black rectangle should ... Eugenie Lyzenko
05:45 AM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: > 1. The widget coordinate has one pixel skew to left and up from what we have in 4GL. I know it is always expected t... Greg Shah
09:58 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Some interesting investigation results:
During debugging clip/draw code I've found two points to be considered and... Eugenie Lyzenko
09:20 AM Feature #1790: implement menu support: @mi.unwrapWidget().setParent(m.getSelf())@ seems best. It is also more consistent with the approach we use for the r... Greg Shah
07:37 AM Feature #1790: implement menu support: Greg, I've fixed "handle" problem for menu as you advised. Now @assign mi:parent = menu m:handle@ is converted to @mi... Vadim Gindin
04:41 AM Feature #1790: implement menu support: This is a problem with the name resolution: in 4GL, a table can be abbreviated using only the first letter, so a @fin... Constantin Asofiei
03:25 AM Feature #1790: implement menu support: From time to time I'm facing with the following conversion problem. Look at the following procedure:... Vadim Gindin
06:03 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Code Review ias_upd20150410a.zip
This looks good. Greg Shah
04:59 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Fixed bug found by regression test. Igor Skornyakov

04/09/2015

03:08 PM Feature #1790: implement menu support: Search on @prog.kw_handle@ in @methods_attributes.rules@. There are places there where we emit a special accessor to... Greg Shah
01:28 PM Feature #1790: implement menu support: The question about conversion bug with handles. Lets look at the following procedure:... Vadim Gindin
02:42 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Please create a new task that has a recreate (both a 4GL testcase and a set of instructions) for the problem. Greg Shah
01:01 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> I agree. Actually, if you think the described behavior is rare enough that it is less likely to ... Igor Skornyakov
12:53 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: I agree. Actually, if you think the described behavior is rare enough that it is less likely to be encountered AND i... Greg Shah
12:44 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> How compatible are we? Please document any areas where differences remain (as far as you know).
... Igor Skornyakov
12:36 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: How compatible are we? Please document any areas where differences remain (as far as you know). Greg Shah
12:07 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> Generally, I'm good with the changes. In some ways the result is cleaner and in some other way... Igor Skornyakov
11:33 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Code Review ias_upd20150409a.zip
Generally, I'm good with the changes. In some ways the result is cleaner and in ... Greg Shah
04:59 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Merged with revno 10832, fixed bug found by regression test. Igor Skornyakov
09:48 AM Feature #2480 (Closed): add support for button and image attributes and options: The special button arrow images task is #2545. Greg Shah
08:34 AM Feature #2480: add support for button and image attributes and options: Greg Shah wrote:
> As far as I understand, all features for this task are finished and working properly. Is that cor... Eugenie Lyzenko
07:54 AM Feature #2480: add support for button and image attributes and options: As far as I understand, all features for this task are finished and working properly. Is that correct?
There are t... Greg Shah
08:19 PM Feature #2480: add support for button and image attributes and options: The update has been committed in bzr as @10832@. Eugenie Lyzenko
08:08 PM Feature #2480: add support for button and image attributes and options: The regression testing completed. There are no issues, results - @10831_9aea7ab_20150408_evl.zip@.
I'm going to co... Eugenie Lyzenko
08:07 AM Feature #2546: implement combo-box widget in GUI: This task is for full implementation of the GUI widget implementation for combo-box. Please note that some attribute... Greg Shah
08:03 AM Feature #2546 (Closed): implement combo-box widget in GUI: Greg Shah
07:57 AM Feature #2545: add support for specially named button images: For details see #2480 notes 84 and 85. This task is to implement support for those images. Greg Shah
07:56 AM Feature #2545 (Closed): add support for specially named button images: Greg Shah
07:54 AM Bug #2477 (Closed): button remains pressed when it should not: Greg Shah
04:01 AM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > And about the overhead: try to determine the CPU time/invocatio... Constantin Asofiei

04/08/2015

05:54 PM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> And about the overhead: try to determine the CPU time/invocation count for your new aspe... Hynek Cihlar
05:49 PM Feature #2252: implement GUI client support: Greg Shah wrote:
> The aspects make things difficult for 2 reasons: they are hidden/indirect AND the conditions that... Hynek Cihlar
03:02 PM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek, beside what Greg noted:
> > * AbstractWidget.afterConfi... Hynek Cihlar
02:21 PM Feature #2252: implement GUI client support: > Server-side doesn't need to track widget attribute changes. If an attribute gets changed, we rely on the LT.pushScr... Greg Shah
01:27 PM Feature #2252: implement GUI client support: Greg Shah wrote:
> > Was the impact contributed just by the aspect overhead or the useful logic itself?
>
> I thi... Constantin Asofiei
12:59 PM Feature #2252: implement GUI client support: > Was the impact contributed just by the aspect overhead or the useful logic itself?
I think Constantin would know... Greg Shah
11:50 AM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Hynek, beside what Greg noted:
> * AbstractWidget.afterConfigUpdateBase - beforeUpdate ... Hynek Cihlar
11:41 AM Feature #2252: implement GUI client support: Greg Shah wrote:
> Code Review hc_upd20150407b.zip
>
> Overall, this is a really great step forward. Although th... Hynek Cihlar
08:33 AM Feature #2252: implement GUI client support: Hynek, beside what Greg noted:
* AbstractWidget.afterConfigUpdateBase - beforeUpdate param has no javadoc
* FillIn.... Constantin Asofiei
07:12 AM Feature #2252: implement GUI client support: Code Review hc_upd20150407b.zip
Overall, this is a really great step forward. Although the aspect code is both in... Greg Shah
05:17 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Editor rework finished. Igor Skornyakov
03:14 PM Feature #1790: implement menu support: Greg Shah wrote:
> Code Review vig_upd20150408a.zip
>
> 1. It seems to me that there is quite a bit of potentiall... Vadim Gindin
11:51 AM Feature #1790: implement menu support: Code Review vig_upd20150408a.zip
1. It seems to me that there is quite a bit of potentially generic functionality ... Greg Shah
05:19 AM Feature #1790: implement menu support: Here is my current update, intended for your review. The main functionality is working: MENUBAR and POPUP-MENU: drawi... Vadim Gindin
10:07 AM Feature #2480: add support for button and image attributes and options: Code Review evl_upd20150408a.zip
It looks good.
Agreed, no conversion testing is needed. Greg Shah
09:26 AM Feature #2480: add support for button and image attributes and options: This is the merge with recent @10831@ code base.
Because @ThinClient@ has crossing I'm going to restart runtime te... Eugenie Lyzenko
08:39 AM Feature #2480: add support for button and image attributes and options: The main part completed without regressions. Continue with @CTRL-C@ sessions. Eugenie Lyzenko
08:20 PM Feature #2480: add support for button and image attributes and options: The conversion testing completed. The generated code has a changes but they are expected. It is @SetAutoGo()@ replaci... Eugenie Lyzenko
02:55 AM Feature #2422: add features to BROWSE: Committed to bzr rev 10831. Stanislav Lomany

04/07/2015

06:08 PM Feature #2252: implement GUI client support: The attached update:
- removes business logic from config classes,
- refactors location fields in BaseConfig,
- co... Hynek Cihlar
03:38 PM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin Asofiei wrote:
> > > First failure is at label_leng... Hynek Cihlar
03:35 PM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > First failure is at label_length.p COLON TEST step 3:
>
> Th... Constantin Asofiei
02:36 PM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> First failure is at label_length.p COLON TEST step 3:
Thank you for the outputs. You ... Hynek Cihlar
02:21 PM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek Cihlar wrote:
> > > Constantin Asofiei wrote:
> > > > Y... Constantin Asofiei
02:07 PM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin Asofiei wrote:
> > > Yeah, fixedColumn/fixedRow, th... Hynek Cihlar
01:49 PM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Yeah, fixedColumn/fixedRow, that is what I'm referring to. Ple... Constantin Asofiei
01:39 PM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Yeah, fixedColumn/fixedRow, that is what I'm referring to. Please check the label_lengt... Hynek Cihlar
12:47 PM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > If I set it during frame layout and restore it before frame lay... Constantin Asofiei
12:45 PM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> If I set it during frame layout and restore it before frame layout (from the savedWidget... Hynek Cihlar
12:33 PM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Not all of them are supposed to work properly in P2J, right? Because at least label_leng... Hynek Cihlar
12:27 PM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > My ZCL's fixedRow/fixedColumn are very problematic... need to f... Constantin Asofiei
12:22 PM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> My ZCL's fixedRow/fixedColumn are very problematic... need to find an alternative, other... Hynek Cihlar
12:21 PM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Greg Shah wrote:
> > Hynek: please review the ZCL changes.
>
> ZCL.RegularModeVariables.se... Constantin Asofiei
12:18 PM Feature #2252: implement GUI client support: Greg Shah wrote:
> Hynek: please review the ZCL changes.
ZCL.RegularModeVariables.setStartColumn(), line 1788 (al... Hynek Cihlar
10:41 AM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Constantin,
>
> please see testcases/uast/frame_layout. The tests are interactive, the best... Constantin Asofiei
09:24 AM Feature #2252: implement GUI client support: Greg Shah wrote:
> Code Review ca_upd20150406c.zip
>
> 1. In @LabelImpl.nativeHeight()@, if there is more than on... Constantin Asofiei
08:18 AM Feature #2252: implement GUI client support: Code Review ca_upd20150406c.zip
1. In @LabelImpl.nativeHeight()@, if there is more than one line (the label has mu... Greg Shah
04:54 PM Feature #2480: add support for button and image attributes and options: >Please confirm if this works the same on Windows, too. After this, you can go ahead and test.
Yes, P2J on Windows... Eugenie Lyzenko
01:48 PM Feature #2480: add support for button and image attributes and options: Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > Eugenie Lyzenko wrote:
> > > ... But to make your sample wo... Constantin Asofiei
01:36 PM Feature #2480: add support for button and image attributes and options: Constantin Asofiei wrote:
> Eugenie Lyzenko wrote:
> > ... But to make your sample working we have to do one more c... Eugenie Lyzenko
01:21 PM Feature #2480: add support for button and image attributes and options: Eugenie Lyzenko wrote:
> ... But to make your sample working we have to do one more change - move mouse down 4GL eve... Constantin Asofiei
01:14 PM Feature #2480: add support for button and image attributes and options: OK. This is the updated change for review has included @MOUSE_PRESSED@ and @MOUSE_RELEASED@ into key reading loop. Bu... Eugenie Lyzenko
12:05 PM Feature #2480: add support for button and image attributes and options: Eugenie Lyzenko wrote:
> >So the only issue remaining to mouse is: allow the MOUSE_PRESSED and MOUSE_RELEASED beside... Constantin Asofiei
11:59 AM Feature #2480: add support for button and image attributes and options: >So the only issue remaining to mouse is: allow the MOUSE_PRESSED and MOUSE_RELEASED beside MOUSE_CLICKED to escape T... Eugenie Lyzenko
11:31 AM Feature #2480: add support for button and image attributes and options: Eugenie Lyzenko wrote:
> >This bit of code in TC.waitForEvent looks too specific:
> >
> >[...]
> >
> >Eugenie, h... Constantin Asofiei
11:15 AM Feature #2480: add support for button and image attributes and options: >This bit of code in TC.waitForEvent looks too specific:
>
>... Eugenie Lyzenko
10:41 AM Feature #2480: add support for button and image attributes and options: Greg Shah wrote:
> Code Review evl_upd20150406a.zip
>
> I like the approach, it seems correct now.
>
> Constan... Constantin Asofiei
07:36 AM Feature #2480: add support for button and image attributes and options: Code Review evl_upd20150406a.zip
I like the approach, it seems correct now.
Constantin: any objections? Greg Shah
10:36 AM Feature #1790: implement menu support: I think your option 3 is probably the best. The normal focus processing should be "suspended" during menu processing... Greg Shah
10:30 AM Feature #1790: implement menu support: Another question about pop-up menu hierarchy. Pop-up menu can be assigned for the following widgets: Browse, Button, ... Vadim Gindin
08:14 AM Feature #1790: implement menu support: Greg Shah wrote:
> I would expect that the @ThinClient.needPause@ flag would possibly be involved. Are you sure thi... Vadim Gindin
07:30 AM Feature #1790: implement menu support: I would expect that the @ThinClient.needPause@ flag would possibly be involved. Are you sure this is about the trigg... Greg Shah

04/06/2015

07:18 PM Feature #2480: add support for button and image attributes and options: The code for review is the next iteration of the mouse event processing fix(may be the final). The changes:
1. The @... Eugenie Lyzenko
12:21 PM Feature #2252: implement GUI client support: Constantin,
please see testcases/uast/frame_layout. The tests are interactive, the best way to test is to run them... Hynek Cihlar
11:19 AM Feature #2252: implement GUI client support: Greg, this is for the GUI label and widget/frame layout. The only issue which bugs me are some edge cases when COLON... Constantin Asofiei
09:37 AM Feature #1790: implement menu support: Yesterday I worked on some unusual focusing behavior. When some sub-menu is dropped down first time, its first elemen... Vadim Gindin

04/04/2015

12:12 PM Feature #2480: add support for button and image attributes and options: Greg Shah wrote:
> Constantin: please comment.
Eugenie, I have some concerns/questions:
# in TC.waitForEvent, ther... Constantin Asofiei

04/03/2015

04:50 PM Feature #2480: add support for button and image attributes and options: Code Review evl_upd20150403a.zip
The changes to @TC.processProgressEvent()@ seem reasonable.
I'm still concerne... Greg Shah
02:52 PM Feature #2480: add support for button and image attributes and options: This update for review has fix for mouse related triggers/exit events. The idea is:
1. In @TC.waitForEvent()@ we lea... Eugenie Lyzenko
11:21 AM Feature #2480: add support for button and image attributes and options: >I think you have found some important things here, but the approach is not correct.
>
>The triggers won't fire bec... Eugenie Lyzenko
08:48 AM Feature #2480: add support for button and image attributes and options: Code Review evl_upd20150402a.zip
I think you have found some important things here, but the approach is not correc... Greg Shah
09:50 PM Feature #2480: add support for button and image attributes and options: The update is the next step fixing client side key loop by 4GL mouse event unlocking. Now the mouse press/click trigg... Eugenie Lyzenko
12:55 PM Feature #2422: add features to BROWSE: Code Review svl_upd20150403a.zip
I'm good with the changes. Greg Shah
10:29 AM Feature #2422: add features to BROWSE: Update for review. DELETE-* functions has been optimized, refresh after deletion of multiple rows has been implemente... Stanislav Lomany

04/02/2015

01:57 PM Feature #1790: implement menu support: Constantin Asofiei wrote:
> I think you need to split the sub-menu and its body into separate widgets. Check how the... Vadim Gindin
11:40 AM Feature #1790: implement menu support: Vadim Gindin wrote:
> Hiding sub-menu body doesn't mean hiding sub-menu itself. Sub-menu body is not a separate widg... Constantin Asofiei
11:26 AM Feature #1790: implement menu support: Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > *The question about sub-menu width.*
> > Constantin, you wrot... Vadim Gindin
11:12 AM Feature #1790: implement menu support: Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > *Strange behavior for MENU-DROP event.*
> > This event is sent... Vadim Gindin
06:06 AM Feature #1790: implement menu support: Vadim Gindin wrote:
> *The question about sub-menu width.*
> Constantin, you wrote, that I should set dimension fi... Constantin Asofiei
06:00 AM Feature #1790: implement menu support: Vadim Gindin wrote:
> *Strange behavior for MENU-DROP event.*
> This event is sent when sub-menu (or pop-up menu) i... Constantin Asofiei
03:42 AM Feature #1790: implement menu support: *The question about sub-menu width.*
Constantin, you wrote, that I should set dimension field @AbstractContainer.si... Vadim Gindin
03:12 AM Feature #1790: implement menu support: *Strange behavior for MENU-DROP event.*
This event is sent when sub-menu (or pop-up menu) is dropped down. I've wrot... Vadim Gindin
09:53 AM Feature #2480: add support for button and image attributes and options: Code Review evl_upd20150401a.zip
This is a substantial improvement!
Fix the remaining event processing and I th... Greg Shah
08:07 AM Feature #2480: add support for button and image attributes and options: Constantin Asofiei wrote:
> I'm good with the changes. Are the tests in note 86 now working properly?
No, the fi... Eugenie Lyzenko
06:45 AM Feature #2480: add support for button and image attributes and options: I'm good with the changes. Are the tests in note 86 now working properly? Constantin Asofiei
05:57 AM Feature #2422: add features to BROWSE: Greg Shah wrote:
> Constantin: please review the use of @ThinClient.invokeTriggers()@ in @Browse@ in this update.
I... Constantin Asofiei

04/01/2015

06:46 PM Feature #2480: add support for button and image attributes and options: This update for review present new approach for @GO@/@CHOOSE@ issue resolution. The idea is to include mouse clicks i... Eugenie Lyzenko
02:07 PM Feature #2422: add features to BROWSE: Greg Shah wrote:
> Eric: please review the query changes.
The query changes look fine. Eric Faulhaber
11:28 AM Feature #2422: add features to BROWSE: > 1. @BrowseWidget.deleteSelectedRow(integer)@ and @BrowseWidget.deleteCurrentRow()@ may need to be optimized to only... Stanislav Lomany
10:21 AM Feature #2422: add features to BROWSE: Code Review svl_upd20150401a.zip
Constantin: please review the use of @ThinClient.invokeTriggers()@ in @Browse@ in... Greg Shah
09:09 AM Bug #2477: button remains pressed when it should not: Code Review evl_upd20150331a.zip
I'm good with the solution. Please include it in your next update for #2480. Greg Shah
08:09 PM Bug #2477: button remains pressed when it should not: The root cause I think is the fact when drag event occurs on GUI button the button itself does not get the mouse exit... Eugenie Lyzenko
08:27 AM Bug #2452: Button label resize fails with error 4054: Eugenie, I'm bit delayed. I am expecting the work to be finished sometime at the end of the week. Hynek Cihlar

03/31/2015

07:46 PM Feature #2422: add features to BROWSE: Update for review. Added DELETE-* functions, SCREEN-VALUE for browse columns and ROW-LEAVE triggers. Stanislav Lomany
05:15 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Code Review ias_upd20150331a.zip
The code looks good. The only (minor) issue is see is that @Editor.setCursorChar... Greg Shah
05:02 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: @INNER-LINES runtime setter attribute unknown behavior should be implemented editor
BOX attribute conversion support... Igor Skornyakov

03/30/2015

02:53 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor Skornyakov wrote:
> Greg,
> I suggest to leave setCursor* as now - this will be more efficient then to send th... Greg Shah
02:26 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg,
I suggest to leave setCursor* as now - this will be more efficient then to send the entire config. In addition... Igor Skornyakov
02:18 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: >
> I believe that the @config.*@ values are already being edited for every content change.
>
> Those changes au... Igor Skornyakov
02:15 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: > Both getCursor* (except getLine) and setCursor* methods' implementation depends on the content - this is why I deci... Greg Shah
01:40 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> Code Review ias_upd20150327a.zip
>
> 1. Please change @BoxedWidget@ to @BoxInterface@. Please... Igor Skornyakov
01:15 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Code Review ias_upd20150327a.zip
1. Please change @BoxedWidget@ to @BoxInterface@. Please also change @is/setBoxe... Greg Shah
12:40 PM Feature #1790: implement menu support: If you are using the testcase from note 243, then I wonder if a @CHOOSE@ event is (accidentally?) being raised for @m... Greg Shah

03/29/2015

12:55 PM Feature #1790: implement menu support: I'm working on unexpected end error:
Constantin Asofiei wrote:
..
> > 2. During menu-items traversal at some mom... Vadim Gindin

03/28/2015

12:33 PM Feature #2487 (Closed): implement READ-FILE() and SAVE-FILE() methods in the editor widget: Greg Shah
08:45 PM Feature #2480: add support for button and image attributes and options: >What about this: let the TC.pause and TC.readkey call TC.waitForEvent with some parameter to wait only for key event... Eugenie Lyzenko

03/27/2015

04:55 PM Feature #2480: add support for button and image attributes and options: Eugenie Lyzenko wrote:
> I think we need to make mouse events(at least press/release) to be returned from @TypeAhead... Constantin Asofiei
09:44 AM Feature #2480: add support for button and image attributes and options: > Or for property reasons we can not use images from commercial 4GL product and have to create our own versions?
... Eugenie Lyzenko
09:43 AM Feature #2480: add support for button and image attributes and options: There is one thing I've recently found related to button widget. In Windows 4GL there are 4 prepackaged images to be ... Eugenie Lyzenko
10:46 PM Feature #2480: add support for button and image attributes and options: >This is another reason why I think is better to try to find a generic solution for this BUTTON/CHOOSE/GO problem now... Eugenie Lyzenko
04:25 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: @DELETE-LINE return false compatibility testing and fixes as needed@
Looks OK
@MAX-CHARS runtime - docs say this... Igor Skornyakov
01:36 PM Bug #2452: Button label resize fails with error 4054: Eugenie Lyzenko wrote:
> > Eugenie, I suggest you wait with this until I finish my in-progress changes. I am modif... Hynek Cihlar
01:18 PM Bug #2452: Button label resize fails with error 4054: Hynek Cihlar wrote:
> Indeed, the original description doesn't seem to be correct. Still there are differences betwe... Eugenie Lyzenko
12:48 PM Bug #2452: Button label resize fails with error 4054: Indeed, the original description doesn't seem to be correct. Still there are differences between 4GL and P2J - 4GL gi... Hynek Cihlar
12:09 PM Bug #2452: Button label resize fails with error 4054: Hynek, I need your comments.... Eugenie Lyzenko

03/26/2015

05:34 PM Feature #2480: add support for button and image attributes and options: Eugenie Lyzenko wrote:
> The reason is the same - we are in @TC.waitForEvent@ waiting for the real key pressing from... Constantin Asofiei
04:51 PM Feature #2480: add support for button and image attributes and options: >Please post a test which shows this difference. And I mean difference in ChUI/GUI behavior in 4GL, not P2J, because ... Eugenie Lyzenko
03:41 PM Feature #2480: add support for button and image attributes and options: Eugenie Lyzenko wrote:
> We need to:
> 1. Preserve natural 4GL event sequence. We can not postpone some events beca... Constantin Asofiei
01:56 PM Feature #2480: add support for button and image attributes and options: >What I think we need is a way to capture this additional event (the CHOOSE event for BUTTON, correct?), and let it p... Eugenie Lyzenko
01:22 PM Feature #2480: add support for button and image attributes and options: >Eugenie, about the EventManager.postOSEvent and when mouse is used to click the button. From what I can tell, past t... Eugenie Lyzenko
12:55 PM Feature #2480: add support for button and image attributes and options: >2. Does that focus shift cause LEAVE and ENTRY events to occur?
Yes, @LEAVE@ for button loosing focus and @ENTRY@ f... Eugenie Lyzenko
12:28 PM Feature #2480: add support for button and image attributes and options: Eugenie, about the @EventManager.postOSEvent@ and when mouse is used to click the button. From what I can tell, past... Constantin Asofiei
10:36 AM Feature #2480: add support for button and image attributes and options: >1. Does clicking on a mouse button in the 4GL shift focus to that button?
Yes if button's @NO-FOCUS@ is false.
>... Eugenie Lyzenko
10:21 AM Feature #2480: add support for button and image attributes and options: >Shouldn't clicking on a button cause that button to receive focus? That focus change should probably occur before an... Eugenie Lyzenko
09:51 AM Feature #2480: add support for button and image attributes and options: These are some good points.
> The significant event we need to react can came from widget currently not having the... Greg Shah
09:42 AM Feature #2480: add support for button and image attributes and options: >This is significantly better than before. But it still uses the OSEvent mechanism for something that it wasn't origi... Eugenie Lyzenko
09:17 AM Feature #2480: add support for button and image attributes and options: Code Review evl_upd20150326a.zip
This is significantly better than before. But it still uses the OSEvent mechanis... Greg Shah
09:06 AM Feature #2480: add support for button and image attributes and options: This update for review fixes the previous notes.
- @applyWorker()@ in @waitForWorker()@ is now free from condition.
... Eugenie Lyzenko
03:59 PM Feature #1790: implement menu support: Vadim Gindin wrote:
> Now I'm working on the next focus error. In sub-menu "Submenu" focus is drawn incorrectly: whe... Constantin Asofiei
03:33 PM Feature #1790: implement menu support: My current update Vadim Gindin
12:54 PM Feature #1790: implement menu support: Constantin, thank you for help!
Yesterday I fixed nested sub-menu drawing. Now It is shown, but also with an error... Vadim Gindin
09:43 AM Feature #2422: add features to BROWSE: A bug not related to browse which affect reproduction of the "... There are no selected rows" quirk.
Testcase:
<pre... Stanislav Lomany
09:22 AM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: Code Review evk_upd20150326a.zip
I'm OK with the merge. Please check it in and distribute it. Greg Shah
09:06 AM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: merged with latest revision Evgeny Kiselev

03/25/2015

05:56 PM Feature #2480: add support for button and image attributes and options: >...I don't like using the @EventManager$WorkArea.osEvent@ queue with other non-mouse or non-window events. This queu... Eugenie Lyzenko
05:45 PM Feature #2480: add support for button and image attributes and options: >1. This code needs to be merged with the latest bzr level.
It was synced yesterday with 10821.
>2. Why did you a... Eugenie Lyzenko
05:40 PM Feature #2480: add support for button and image attributes and options: Greg Shah wrote:
> Constantin: please review.
Eugenie, beside what Greg noted, I don't like using the @EventManager... Constantin Asofiei
05:03 PM Feature #2480: add support for button and image attributes and options: Code Review evl_upd20150325a.zip
1. This code needs to be merged with the latest bzr level.
2. Why did you add ... Greg Shah
04:34 PM Feature #2480: add support for button and image attributes and options: This update for review has fix for wait-for loop "exit" button without endkey option issue. The idea is to propagate ... Eugenie Lyzenko
02:42 PM Feature #2480: add support for button and image attributes and options: Investigation results for case when both @AUTO-ENDKEY@ and @AUTO-GO@ options are true for same button:
1. define b... Eugenie Lyzenko
08:35 AM Feature #2480: add support for button and image attributes and options: Code Review evl_upd20150324a.zip
I'm OK with this approach.
> The loop is releasing only after pressing any key... Greg Shah
02:12 PM Feature #1790: implement menu support: Vadim Gindin wrote:
> This variant also don't work. @WidgetBrowserAspect.onWidgetDrawn@ is not called at all. I didn... Constantin Asofiei
02:11 PM Feature #1790: implement menu support: This variant also don't work. @WidgetBrowserAspect.onWidgetDrawn@ is not called at all. I didn't find something about... Vadim Gindin
01:19 PM Feature #1790: implement menu support: Vadim Gindin wrote:
> I've tried to add JVM option "-Dwidgetbrowser", but @WidgetBrowser@ wasn't show. I suspect tha... Constantin Asofiei
01:06 PM Feature #1790: implement menu support: I've tried to add JVM option "-Dwidgetbrowser", but @WidgetBrowser@ wasn't show. I suspect that @WidgetBrowserAspect@... Vadim Gindin
11:57 AM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: Actually, you will have to merge up to the 10821 level. Just do the merge and then upload the zip file. I will revi... Greg Shah
08:27 AM Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget: Great! Please commit it and distribute. Greg Shah

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » User Interface

Activity

Activity

04/23/2015

04/22/2015

04/21/2015

04/20/2015

04/18/2015

04/17/2015

04/16/2015

04/15/2015

04/14/2015

04/13/2015

04/12/2015

04/11/2015

04/10/2015

04/09/2015

04/08/2015

04/07/2015

04/06/2015

04/04/2015

04/03/2015

04/02/2015

04/01/2015

03/31/2015

03/30/2015

03/29/2015

03/28/2015

03/27/2015

03/26/2015

03/25/2015