Activity

From 04/08/2015 to 05/07/2015

05/07/2015

06:54 PM Feature #1811: implement the AJAX client driver: Two other notes about my update:
1. The node "chuiWeb" in the directory needs to be changed to "webClient".
2. ... Greg Shah
06:48 PM Feature #1811: implement the AJAX client driver: Following up on my note 651, the attached update is the first (partially working) pass at steps 1 - 7.
I have also... Greg Shah
06:45 PM Feature #2546: implement combo-box widget in GUI: Finally I have found the fix for drop-down disappearing. So the new update for review is attached. Certainly this is ... Eugenie Lyzenko
05:56 PM Feature #2546: implement combo-box widget in GUI: This is the cleaned code for review. The UI drop-down disappearing issue is still here. Working on it. Eugenie Lyzenko
12:02 PM Feature #2546: implement combo-box widget in GUI: Eugenie Lyzenko wrote:
> Constantin, if you have some short answer please share. Does every mouse movement cause the... Constantin Asofiei
11:56 AM Feature #2546: implement combo-box widget in GUI: >Shouldn't the WidgetFactoryAdapter.createDropDown() just throw an exception? Under what conditions will it actually ... Eugenie Lyzenko
08:36 AM Feature #2546: implement combo-box widget in GUI: Code Review evl_upd20150506a.zip
Generally, this looks good.
Shouldn't the @WidgetFactoryAdapter.createDropDown... Greg Shah
11:51 PM Feature #2546: implement combo-box widget in GUI: This is the next step for review. Finally the scrollbar is working to use sroll-buttons to navigate drop-down.
The... Eugenie Lyzenko
06:17 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Here is my current update. I've fixed WIDTH/HEIGHT attributes calculation. Vadim Gindin
01:28 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Thank you! It was a classpath problem. I had "/testcases/uast/font/system.metrics" folder in my classpath and after I... Vadim Gindin
01:15 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > About matching the label metrics in GUI with the legacy metrics... Constantin Asofiei
01:11 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Constantin Asofiei wrote:
> About matching the label metrics in GUI with the legacy metrics as on windev01.
> # Aft... Vadim Gindin
09:17 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: About matching the label metrics in GUI with the legacy metrics as on windev01.
# After each conversion, there is a ... Constantin Asofiei
09:13 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: In looking at your screen-shots, is the P2J toggle-box shadow color correct? It seems too dark. Greg Shah
08:53 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Vadim Gindin wrote:
> About label width for widgets: @gd.getTextWidth("tbx", gf.font().font)@ has returned 13. Is it... Constantin Asofiei
08:52 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Vadim Gindin wrote:
> About WIDTH*/HEIGHT* attributes initialization problem. Hynek proposed me to initialize these ... Constantin Asofiei
08:50 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Greg Shah wrote:
> About the window clearing, I don't think this has anything to do with the toggle-box. We will wo... Vadim Gindin
08:45 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: About the window clearing, I don't think this has anything to do with the toggle-box. We will work it in another task. Greg Shah
08:34 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Greg Shah wrote:
> Please post 2 screen captures (of the 4GL and P2J) so I can understand what you mean.
I'm post... Vadim Gindin
08:22 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: About WIDTH*/HEIGHT* attributes initialization problem. Hynek proposed me to initialize these fields in @ToggleBox.in... Vadim Gindin
08:17 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Please post 2 screen captures (of the 4GL and P2J) so I can understand what you mean. Greg Shah
07:45 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Greg Shah wrote:
> > But 4GL clears the window and P2J - does not. Should I fix it?
>
> Do you mean that the fram... Vadim Gindin
07:36 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: > But 4GL clears the window and P2J - does not. Should I fix it?
Do you mean that the frame f is still displayed i... Greg Shah
04:02 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Greg, thank you! "F2" is mapped on "GO" event in GUI. I've tested GO event. It works for toggle-box. Trigger @on go o... Vadim Gindin
03:45 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Greg Shah wrote:
> > >
> > > This is incorrect. @GO@ is a frame-level event. Try @on go of frame f@ instead of @... Vadim Gindin
04:54 PM Feature #2252: implement GUI client support: Code Review ca_upd20150507a.zip
I'm generally fine with the changes. Unfortunately, your nice changes are going t... Greg Shah
03:57 PM Feature #2252: implement GUI client support: Fixes following issues:
# frame title in GUI - centered vertically and fixed frame height problems. Also, it uses th... Constantin Asofiei

05/06/2015

07:00 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: > So it is not fixed yet.. Should I work on it now anyway?
Actually, yes. Constantin's changes are already checke... Greg Shah
06:59 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: > >
> > This is incorrect. @GO@ is a frame-level event. Try @on go of frame f@ instead of @on go of lll@ will not... Greg Shah
06:24 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: "2. Make sure ASSIGN and SCREEN-VALUE after WAIT-FOR work."
I've checked. P2J works as 4GL. Here is my test case:
... Vadim Gindin
05:59 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Greg Shah wrote:
> > I mean that the last message "after .." is not printed, i.e. execution is stopped before this s... Vadim Gindin
05:56 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: > I mean that the last message "after .." is not printed, i.e. execution is stopped before this statement.
The pro... Greg Shah
05:25 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Greg Shah wrote:
> This testcase doesn't seem correct. In the 4GL, the @UPDATE@ statement is roughly equivalent to ... Vadim Gindin
04:25 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: This testcase doesn't seem correct. In the 4GL, the @UPDATE@ statement is roughly equivalent to @ENABLE@ + @WAIT-FOR... Greg Shah
04:14 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: There is a strange thing with UPDATE statement for toggle-box. Have a look at this procedure:... Vadim Gindin
11:11 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: In regard to the WIDTH/HEIGHT issue, Hynek reported the following:
> I tested your sample. The problem doesn't see... Greg Shah
10:44 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Code Review vig_upd20150506a.zip
I'm OK with the code so far.
Since MAJIC doesn't use toggle-boxes and your cha... Greg Shah
10:40 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: > This test works fine (P2J like Progress). both toggle-boxes are checked and message area contains the string "yes".... Greg Shah
08:43 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: I forgot to add, that at this moment WIDTH/HEIGHT attributes are calculated improperly at this moment. Here is my cur... Vadim Gindin
08:36 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Greg Shah wrote:
> The 4GL docs say that @VALUE-CHANGED@ should work. Make sure that your testcase is correct. Tha... Vadim Gindin
08:12 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Greg Shah wrote:
> Vadim Gindin wrote:
> > If user presses mouse on checkbox and starts dragging the mouse over it ... Vadim Gindin
12:08 PM Feature #2422: add features to BROWSE: Implemented REFRESHABLE and ADD-LIKE-COLUMN. Committed to bzr rev 10848. Stanislav Lomany
09:35 AM Feature #2422: add features to BROWSE: > So CREATE-ON-ADD is added to the GUI list.
OK, please add notes to #2564 so that this is not missed.
Also: if... Greg Shah
09:52 PM Feature #2422: add features to BROWSE: About @CREATE-ON-ADD@. At this point it cannot be implemented because:
1. I do not quite understand what it does. He... Stanislav Lomany

05/05/2015

05:09 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Vadim Gindin wrote:
> If user presses mouse on checkbox and starts dragging the mouse over it checkbox background is... Greg Shah
05:07 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: The 4GL docs say that @VALUE-CHANGED@ should work. Make sure that your testcase is correct. That event is probably ... Greg Shah
01:14 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: I've checked attributes and events. P2J works as Progress. VALUE-CHANGED event is not working for both Progress and P... Vadim Gindin
10:13 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: If user presses mouse on checkbox and starts dragging the mouse over it checkbox background is colored to some other ... Vadim Gindin
03:36 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Static case works fine: both P2J and Progress shows toggle-box in one row after the button "exit". Vadim Gindin
03:25 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Vadim Gindin wrote:
> Addition to previous note. If I'll remove @skip(1)@ expression from the frame definition, than... Constantin Asofiei
03:22 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Addition to previous note. If I'll remove @skip(1)@ expression from the frame definition, than Progress will show tog... Vadim Gindin
02:18 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Just for documenting purpose. This testcase also shows wrong placement of toggle-box. Progress shows toggle-box at th... Vadim Gindin

05/04/2015

02:30 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: I'm working on WIDTH/HEIGHT attributes and after the last update this attributes became 0. Don't you know why? And wh... Vadim Gindin
11:01 AM Feature #2422: add features to BROWSE: 20150504a looks OK to me from the persistence side. Eric Faulhaber
09:35 AM Feature #2422: add features to BROWSE: Code Review svl_upd20150504a.zip
1. In @ThinClient.queryClosed()@ and @ThinClient.refreshScrollRow()@, the call to... Greg Shah
03:19 AM Feature #2422: add features to BROWSE: All the flaws fixed. Stanislav Lomany
10:02 AM Feature #2446 (Closed): implement BUTTON and IMAGE GUI widgets (runtime and conversion support): Greg Shah
10:01 AM Feature #2545 (Closed): add support for specially named button images: Greg Shah
10:00 AM Feature #2545: add support for specially named button images: @evl_upd20150503a.zip@ has been committed as @10847@. Eugenie Lyzenko
09:45 AM Feature #2545: add support for specially named button images: Greg Shah wrote:
> Code Review evl_upd20150503a.zip
>
> It looks good. Check it in when it passes testing.
Th... Eugenie Lyzenko
09:27 AM Feature #2545: add support for specially named button images: Code Review evl_upd20150503a.zip
It looks good. Check it in when it passes testing. Greg Shah
10:01 AM Bug #2452 (Closed): Button label resize fails with error 4054: Greg Shah
09:48 AM Bug #2452: Button label resize fails with error 4054: The fix for this issue is included into update for task #2545 for commit and distribute, @evl_upd20150503a.zip@. Pass... Eugenie Lyzenko

05/03/2015

06:31 PM Feature #2545: add support for specially named button images: The code is the merge with @10846@ and small change to label cutting approach. With the recent changes the frame widt... Eugenie Lyzenko
09:40 AM Feature #2545: add support for specially named button images: Please merge to bzr 10846 and get this tested. Greg Shah
01:23 PM Feature #2422: add features to BROWSE: Code Review svl_upd20150503a.zip
Eric: please review.
1. Shouldn't there be a @methods_attributes.rules@ change... Greg Shah
12:32 PM Feature #2422: add features to BROWSE: Update for review - REFRESHABLE and ADD-LIKE-COLUMN. Stanislav Lomany
03:33 AM Feature #1790: implement menu support: There were 2 failed test that was not being recreated during manual testing. So, I've committed current changes with ... Vadim Gindin

05/02/2015

02:35 PM Feature #1790: implement menu support: > Should I ignore this error?
If I understand correctly, you are saying that your manual testing could not recreat... Greg Shah
02:54 AM Feature #1790: implement menu support: So, I've checked gso_269. It also is not reproduced as tc_code_employees_261 manually (as tc_code_employees_264 in th... Vadim Gindin
01:39 AM Feature #1790: implement menu support: Constantin Asofiei wrote:
> Vadim, what update are these results from? Because I can recreate it with your 0430a.zip... Vadim Gindin
08:50 PM Feature #2546: implement combo-box widget in GUI: This is the next step for review in combo-box GUI widget implementation. So what it can:
1. Complete keyboard suppor... Eugenie Lyzenko

05/01/2015

04:54 PM Feature #1790: implement menu support: You can check in your code as soon as it passes, unless you have to make some other fix besides the history entry men... Greg Shah
04:15 PM Feature #1790: implement menu support: Code Review vig_upd20150501b.zip
Please just add a history entry to @MenuWidget@. Otherwise it looks good. Greg Shah
03:52 PM Feature #1790: implement menu support: OK. There was some mess with that. I hope, you right, moreover my update passed successfully regression testing befor... Vadim Gindin
12:44 PM Feature #1790: implement menu support: Vadim, what update are these results from? Because I can recreate it with your 0430a.zip but not with 0430b.zip.
A... Constantin Asofiei
11:11 AM Feature #1790: implement menu support: Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > Vadim Gindin wrote:
> > > I've checked gso_17 test, the first ... Constantin Asofiei
11:09 AM Feature #1790: implement menu support: Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > I've checked gso_17 test, the first failed test and found the f... Vadim Gindin
04:39 AM Feature #1790: implement menu support: Vadim Gindin wrote:
> I've checked gso_17 test, the first failed test and found the following. During the test there... Constantin Asofiei
04:38 AM Feature #1790: implement menu support: Vadim Gindin wrote:
> There are a lot of similar errors where generated files differ from expected. But there are an... Constantin Asofiei
02:24 AM Feature #1790: implement menu support: There are a lot of similar errors where generated files differ from expected. But there are another errors exist. I'v... Vadim Gindin
02:00 AM Feature #1790: implement menu support: I've checked gso_17 test, the first failed test and found the following. During the test there are gso_17.txt is gene... Vadim Gindin
01:03 AM Feature #1790: implement menu support: This update (after merge) failed regression testing: gso_tests (19) tc_tests (24). I'm working on it. Vadim Gindin
03:34 PM Feature #2545: add support for specially named button images: Code Review evl_upd20150501a.zip
It's good.
> Now the conversion testing is not required because is was already... Greg Shah
03:25 PM Feature #2545: add support for specially named button images: This is the merge with @10845@. Now the conversion testing is not required because is was already done(as part of the... Eugenie Lyzenko
11:14 AM Feature #1798: implement full frame family support (parent-child relationships between frames): Greg Shah wrote:
> Code Review ca_upd20150501a.zip
>
> It looks good. Check it in when it passes.
Committed rev... Constantin Asofiei
10:35 AM Feature #1798: implement full frame family support (parent-child relationships between frames): Code Review ca_upd20150501a.zip
It looks good. Check it in when it passes. Greg Shah
05:44 AM Feature #1798: implement full frame family support (parent-child relationships between frames): Merged version of 0421a.zip with rev 10844. Conversion testing passed, runtime testing is starting (it should pass t... Constantin Asofiei
05:10 AM Feature #2564: implement GUI BROWSE widget: Addition to the list:
MIN-HEIGHT-CHARS
SORT - I think that actually means implementation of drop-down cells
Stanislav Lomany
05:06 AM Feature #2422: add features to BROWSE: > If I understand correctly, then we have the following categories:
>
> 1. features currently being implemented
K... Stanislav Lomany
05:04 AM Feature #2422: add features to BROWSE: Here is the list of all remaining features:
*GUI-specific*
FIT-LAST-COLUMN/EXPANDABLE
NO-COLUMN-SCROLLING
ROW... Stanislav Lomany
04:04 AM Feature #2252: implement GUI client support: Greg Shah wrote:
> Code Review ca_upd20150429a.zip
>
> This is a really good update. I suspect it is cleaning up... Constantin Asofiei

04/30/2015

04:53 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Code Review vig_upd20150501a.zip
It is a very good start.
1. In @ToggleBoxGuiImpl.draw()@, the 3 TODOs should b... Greg Shah
03:23 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Vadim Gindin wrote:
> After I set BGCOLOR I saw real area, occupied by widget and when I manually changed width and ... Constantin Asofiei
03:16 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Here is the current update merged with the latest revision. Please review shortly. The changes are small. Vadim Gindin
10:28 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: That was my procedure:... Vadim Gindin
10:27 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Here are the results. Thank you very much! After I used NO-LABELS dimensions became concurred:
width-chars: 5
width... Vadim Gindin
04:41 PM Feature #2567: add misc widget support part 2: more options, attributes and methods: Please add support for the following:
+Options+
WIDGET-ID - all widgets, see #1791 for some prior research, we ... Greg Shah
03:17 PM Feature #2567 (Closed): add misc widget support part 2: more options, attributes and methods: Greg Shah
04:22 PM Feature #1834: implement direct manipulation (drag and drop): Implement runtime support for the following attributes:
MOVABLE
RESIZABLE
SELECTABLE
Conversion support for t... Greg Shah
03:48 PM Feature #1800 (Closed): add some missing widget options: Most of this work got done with the button, rectangle and image widget implementations. The remaining work will be d... Greg Shah
03:48 PM Feature #2032 (Closed): runtime support for widget options: Greg Shah
03:47 PM Feature #2031 (Closed): conversion support for remaining widget options: Greg Shah
03:08 PM Feature #1796 (WIP): implement full GUI layout support: Greg Shah
02:23 PM Feature #2566 (Closed): implement LOAD-MOUSE-POINTER method: Greg Shah
02:22 PM Feature #2565 (Closed): implement runtime support for the SET-WAIT-STATE method: Greg Shah
02:20 PM Feature #2422: add features to BROWSE: I've checked the @GET-BROWSE-COLUMN@ method and although it is implemented, I see that it is supposed to return a @HA... Greg Shah
02:17 PM Feature #2422: add features to BROWSE: I've added the GUI-specific options, attributes and methods to the #2564 task (creation of the GUI BROWSE widget).
... Greg Shah
02:05 PM Feature #2564: implement GUI BROWSE widget: The following options, attributes and methods were investigated in #2422. They were determined to be GUI-specific. ... Greg Shah
01:56 PM Feature #2564 (Closed): implement GUI BROWSE widget: Greg Shah
01:11 PM Feature #2563: implement GUI EDITOR widget: Please note that @MAX-CHARS@, @RETURN-INSERTED@ and @WORD-WRAP@ are attributes which need to be implemented as part o... Greg Shah
01:07 PM Feature #2563 (Closed): implement GUI EDITOR widget: Greg Shah
12:39 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: 1. I hope to finish tomorrow or at the weekend.
2. All features mentioned in the task will be done.
3. I've promise... Igor Skornyakov
12:30 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Please provide a status update with:
1. The expected time when your next update will be ready for review.
2. A su... Greg Shah
12:29 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor checked in ias_upd20150411a.zip as bzr rev 10833 on April 13, 2015. Greg Shah
12:26 PM Bug #2558: generated frame getter/setter names can conflict with existing CommonFrame APIs: If you have a @COMBO-BOX@ widget named 'x' then in the generated code for the enclosing static frame there will be me... Greg Shah
10:45 AM Feature #1790: implement menu support: Code Review vig_upd20150430b.zip
This is good. Greg Shah
10:41 AM Feature #1790: implement menu support: Greg Shah wrote:
> Code Review vig_upd20150430a.zip
>
> 1. In @WidgetConfig.applyConfig()@, shouldn't the assignm... Vadim Gindin
10:27 AM Feature #1790: implement menu support: Code Review vig_upd20150430a.zip
1. In @WidgetConfig.applyConfig()@, shouldn't the assignment be done using @Confi... Greg Shah
10:31 AM Bug #2452: Button label resize fails with error 4054: Code Review evl_upd20150429e.zip
I like it! Greg Shah
10:04 AM Feature #2252: implement GUI client support: Code Review ca_upd20150429a.zip
This is a really good update. I suspect it is cleaning up a lot of problems.
1... Greg Shah

04/29/2015

04:57 PM Feature #2560 (Closed): implement GUI DIALOG-BOX support: Greg Shah
04:56 PM Feature #2559 (Closed): implement ALERT-BOX support: Greg Shah
04:55 PM Feature #1827: implement a replacement for the Windows help viewer: This is no longer needed in M12. Greg Shah
04:22 PM Bug #2452: Button label resize fails with error 4054: >OK, let's go with this as is for now.
Before I've got this message I prepared one more improved version of the sa... Eugenie Lyzenko
04:03 PM Bug #2452: Button label resize fails with error 4054: OK, let's go with this as is for now.
Pause testing on this until Constantin's changes are checked in. Then merge... Greg Shah
03:52 PM Bug #2452: Button label resize fails with error 4054: Greg Shah wrote:
> Code Review evl_upd20150429d.zip
>
> It is good.
>
> Hynek: any concerns?
I think it is ... Hynek Cihlar
03:37 PM Bug #2452: Button label resize fails with error 4054: @GenericWidget.setLabel()@ is becoming a little overblown. It should be split into several parts - label validation, ... Hynek Cihlar
03:36 PM Bug #2452: Button label resize fails with error 4054: Code Review evl_upd20150429d.zip
It is good.
Hynek: any concerns? Greg Shah
03:17 PM Bug #2452: Button label resize fails with error 4054: >Greg Shah wrote:
> Please add a TODO in that method to explain this so that we can "remember" it easily.
Adding ... Eugenie Lyzenko
03:01 PM Bug #2452: Button label resize fails with error 4054: Code Review evl_upd20150429c.zip
I like your original idea of avoiding more type checking in @GenericWidget.setLab... Greg Shah
02:39 PM Bug #2452: Button label resize fails with error 4054: >Does the 4GL remove the & characters from the label before it calculates that the label is too big to fit? See @Gene... Eugenie Lyzenko
02:19 PM Bug #2452: Button label resize fails with error 4054: Code Review evl_upd20150429b.zip
Does the 4GL remove the @&@ characters from the label before it calculates that t... Greg Shah
02:11 PM Bug #2452: Button label resize fails with error 4054: This update for review has fix for button resizing. I have modified @ButtonWidget@ class adding override for @Generic... Eugenie Lyzenko
12:39 PM Bug #2452: Button label resize fails with error 4054: Yes, it is a good idea to include it in the #2545 update. Greg Shah
12:32 PM Bug #2452: Button label resize fails with error 4054: Greg Shah wrote:
> This task can be worked on now.
OK. Soon I will have the fix. Can I include it into update pen... Eugenie Lyzenko
09:36 AM Bug #2452: Button label resize fails with error 4054: This task can be worked on now. Greg Shah
03:32 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Vadim Gindin wrote:
> Here is the following result of WIN32 API calls:
> 8 - COLOR_WINDOWTEXT – the color of the "c... Constantin Asofiei
03:15 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Here is the following result of WIN32 API calls:
8 - COLOR_WINDOWTEXT – the color of the "check" and the color of th... Vadim Gindin
11:53 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: One other thing to remember: in Windows a toggle-box (or "check-box" in WIN32 terms) is actually a type of WIN32 butt... Greg Shah
10:00 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: > It is an instruction how to change system colors using Visual Basic.
The code would be simpler to do it in C and... Greg Shah
03:19 PM Feature #2252: implement GUI client support: FYI, the issue Vadim was facing was related to project setup. Hynek Cihlar
02:34 PM Feature #2252: implement GUI client support: Attached is replacement of ca_upd20150406c.zip (note 865), frame layout and misc GUI fixes:
* Rectangle(Point, Dimen... Constantin Asofiei
12:01 PM Feature #2252: implement GUI client support: hc_upd20150429b.zip committed to bzr rev 10843. Hynek Cihlar
11:38 AM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> The attached fixes GUI window positioning. Only GUI code is affected. Please review.
The chan... Constantin Asofiei
11:35 AM Feature #2252: implement GUI client support: The attached fixes GUI window positioning. Only GUI code is affected. Please review. Hynek Cihlar
11:26 AM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Please post some details about the issue here, if you haven't solved it yet :).
This ... Hynek Cihlar
11:11 AM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek Cihlar wrote:
> > > Constantin Asofiei wrote:
> > > > H... Constantin Asofiei
11:09 AM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin Asofiei wrote:
> > > Hynek,
> > > Regarding the GU... Hynek Cihlar
11:07 AM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek,
> > Regarding the GUI window problems, I think the main... Constantin Asofiei
10:48 AM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Hynek,
> Regarding the GUI window problems, I think the main issue is in WindowGuiImpl,... Hynek Cihlar
09:58 AM Feature #2252: implement GUI client support: Hynek,
Regarding the GUI window problems, I think the main issue is in WindowGuiImpl, where @moveBy@ was using inval... Constantin Asofiei
02:51 PM Feature #1790: implement menu support: Here is the merged update. I didn't check GSO 269 test by hand because I already updated p2j project from trunk with ... Vadim Gindin
04:07 AM Feature #1790: implement menu support: Vadim Gindin wrote:
> We can assume that current update has passed regression testing. Only 2 tests are failed: gso_... Constantin Asofiei
04:05 AM Feature #1790: implement menu support: We can assume that current update has passed regression testing. Only 2 tests are failed: gso_269 and tc_job_002. Sho... Vadim Gindin
11:49 AM Bug #2558 (New): generated frame getter/setter names can conflict with existing CommonFrame APIs: Igor Skornyakov
10:10 AM Feature #2422: add features to BROWSE: > I assumed that it should be a dynamic widget. Is that correct?
I doubt it. Unfortunately, the 4GL docs suggest ... Greg Shah
01:13 AM Feature #2422: add features to BROWSE: I need to create a browse column.
# I assumed that it should be a dynamic widget. Is that correct? I've created it u... Stanislav Lomany
09:35 AM Feature #2545: add support for specially named button images: Code Review evl_upd20150429a.zip
The merge looks good.
Constantin has an update that will be checked in before ... Greg Shah
07:34 AM Feature #2545: add support for specially named button images: This is merge with @10842@ code base to be ready to regression testing. Eugenie Lyzenko
08:02 PM Feature #2545: add support for specially named button images: Now I can merge @evl_upd20150422c.zip@ with 10841 and start testing, OK? Eugenie Lyzenko
01:40 AM Feature #2546: implement combo-box widget in GUI: Eugenie Lyzenko wrote:
> The mouse handling is not yet working. Moreover moving mouse in application workspace close... Constantin Asofiei
09:41 PM Feature #2546: implement combo-box widget in GUI: This is another in progress update for review to keep you informed about the implementation. I have separated GUI par... Eugenie Lyzenko

04/28/2015

07:13 PM Feature #2252: implement GUI client support: hc_upd20150428b.zip committed to revision 10841. Hynek Cihlar
06:51 PM Feature #2252: implement GUI client support: The attached is a replacement of hc_upd20150428a.zip. It contains a trivial fix and passes Majic regression tests.
S... Hynek Cihlar
09:08 AM Feature #2252: implement GUI client support: Code Review hc_upd20150428a.zip
It looks fine. If it passes, you can check it in. Greg Shah
06:02 AM Feature #2252: implement GUI client support: Greg Shah wrote:
> It's good. I have my "fingers crossed" that regression testing goes well.
The test ended with... Hynek Cihlar
06:47 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Greg Shah wrote:
> I can't logon to windev01 right now and I don't have easy access to a windows system. But I'm qu... Vadim Gindin
04:22 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: I can't logon to windev01 right now and I don't have easy access to a windows system. But I'm quite sure that you ca... Greg Shah
03:03 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Greg Shah wrote:
> > How can I change some system color, as you advise?
>
> Isn't there something in the Control ... Vadim Gindin
02:49 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > ..
> > Vadim Gindin wrote:
> > > 3. I tried to draw objects w... Constantin Asofiei
02:34 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: > How can I change some system color, as you advise?
Isn't there something in the Control Panel that allows you to... Greg Shah
02:25 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Constantin Asofiei wrote:
> ..
> Vadim Gindin wrote:
> > 3. I tried to draw objects with sizes equal to source. Is... Vadim Gindin
02:17 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Greg Shah wrote:
> ..
> > 2. How to calculate real colors for checkbox lines? I just try them intuitively.
>
> T... Vadim Gindin
03:41 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Vadim Gindin wrote:
> 1. When I'm going between checkboxes I've faced with view affect (see attached image). Why it ... Constantin Asofiei
03:56 PM Feature #1790: implement menu support: Code Review vig_upd20150429a.zip
I'm good with this approach.
It is worth running regression testing on this up... Greg Shah
02:09 PM Feature #1790: implement menu support: I've fixed it, by implementing of @AbstractWidget.syncWithConfig()@ method and also in @AbstractWidget.initialize()@ ... Vadim Gindin
02:27 PM Feature #2546: implement combo-box widget in GUI: > I prefer the ChUI and GUI specifics to be completely separated(of course there can be an exceptions). Is it accept... Greg Shah
02:15 PM Feature #2546: implement combo-box widget in GUI: >I don't really understand what you are saying here. Are you saying that the GUI support will require the ChUI code t... Eugenie Lyzenko
09:10 AM Feature #2546: implement combo-box widget in GUI: I don't really understand what you are saying here. Are you saying that the GUI support will require the ChUI code t... Greg Shah
11:09 PM Feature #2546: implement combo-box widget in GUI: This is the fist step of the drop-down implementation for GUI. But the analysis is complete. Here is the painting way... Eugenie Lyzenko

04/27/2015

07:16 PM Feature #2252: implement GUI client support: Code Review hc_upd20150427b.zip
It's good. I have my "fingers crossed" that regression testing goes well. Greg Shah
06:28 PM Feature #2252: implement GUI client support: The attached update replaces hc_upd20150424h.zip.
Fixes redraw problem with multi selection lists (and radio buttons... Hynek Cihlar
03:42 PM Feature #2252: implement GUI client support: Actually you are right, @formatUnchanged@ will always be @true@ when called from @afterConfigUpdate@ as it was @syncW... Hynek Cihlar
03:37 PM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Hynek, what about this case? Are you sure @formatUnchaged@ is computed properly?
> [...... Hynek Cihlar
02:51 PM Feature #2252: implement GUI client support: Hynek, what about this case? Are you sure @formatUnchaged@ is computed properly?... Constantin Asofiei
05:10 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX: Please merge this code with the latest version in bzr. Otherwise the code review is too difficult.
> 1. When I'm ... Greg Shah
04:50 PM Feature #1790: implement menu support: > but I found that at the moment of initialization config().popupMenuId has no value
I guess that only a dynamic w... Greg Shah
04:42 PM Feature #1790: implement menu support: Code Review vig_upd20150427a.zip
I'm fine with the changes. Greg Shah
01:51 PM Feature #1790: implement menu support: Greg Shah wrote:
> Code Review vig_upd20150423a.zip
>
> This is quite good.
>
> 1. In @Menu.java@, what is the... Vadim Gindin
01:29 PM Feature #1790: implement menu support: Please address my issues 1 and 3 from the code review in note 316. Post that update here. Hopefully it is the final... Greg Shah
01:11 PM Feature #1790: implement menu support: The task #2557 is created. Can I run regression testing for current update? If yes, should I add some menu scenarios ... Vadim Gindin
12:29 PM Feature #1790: implement menu support: Vadim Gindin wrote:
> Should I include "message hiding" and "pausing bugs" there or fix it?
Yes, include these two ... Constantin Asofiei
11:15 AM Feature #1790: implement menu support: Should I include "message hiding" and "pausing bugs" there or fix it? Vadim Gindin
10:43 AM Feature #1790: implement menu support: > My suggestion is to finish the menu's drawing/event/etc first and work on this in a second phase, as some refactori... Greg Shah
04:00 AM Feature #1790: implement menu support: Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > Some other thoughts about my notes in 325: when attaching/detac... Constantin Asofiei
01:09 PM Bug #2557: Fix MENUBAR layouting in a window: Current MENUBAR implementation has several layout problems, that should be solved in this task.
# If source proced... Vadim Gindin
12:43 PM Bug #2557 (New): Fix MENUBAR layouting in a window: Vadim Gindin
05:24 AM Feature #1811: implement the AJAX client driver: >We can send the image data as a byte[] using the web socket. This is simple, clean and has not additional security i... Anton Breaur
03:47 AM Feature #2556: add support for COLOR statement in GUI: There's more than just drawing related to colors. When COLOR ... NORMAL/INPUT/MESSAGES is used, in GUI this affects ... Constantin Asofiei
03:28 AM Feature #2556 (New): add support for COLOR statement in GUI: Constantin Asofiei

04/26/2015

03:50 PM Feature #1790: implement menu support: Constantin Asofiei wrote:
> Some other thoughts about my notes in 325: when attaching/detaching the menubar, the "wo... Vadim Gindin
12:48 PM Feature #2252: implement GUI client support: Code Review hc_upd20150424h.zip
@ScrollContainer@ is missing a history entry. Otherwise this update looks very good. Greg Shah

04/25/2015

09:09 PM Feature #2252: implement GUI client support: The attached is a replacement of hc_upd20150424g.zip and fixes javadoc warnings. Hynek Cihlar
09:01 PM Feature #2252: implement GUI client support: The attached is a replacement of hc_upd20150424f.zip and adds some more javadocs. Hynek Cihlar
08:36 PM Feature #2252: implement GUI client support: Renamed hc_upd20140424f.zip to hc_upd20150424f.zip. Hynek Cihlar
08:34 PM Feature #2252: implement GUI client support: The attached update is a replacement of hc_upd20150421c.zip. It contains changes based on the last review, Majic regr... Hynek Cihlar

04/24/2015

03:23 PM Feature #1790: implement menu support: Some other thoughts about my notes in 325: when attaching/detaching the menubar, the "workspace" area were drawing is... Constantin Asofiei
03:15 PM Feature #1790: implement menu support: Vadim Gindin wrote:
> Yes, in P2J. You can use my last update.
I think the cause is that we are pushing the entire ... Constantin Asofiei
02:42 PM Feature #1790: implement menu support: Yes, in P2J. You can use my last update. Vadim Gindin
02:41 PM Feature #1790: implement menu support: Vadim Gindin wrote:
> My question is not about MENU-DROP now. I use the following procedure:
> [...]
> I found yes... Constantin Asofiei
02:39 PM Feature #1790: implement menu support: My question is not about MENU-DROP now. I use the following procedure:... Vadim Gindin
02:35 PM Feature #1790: implement menu support: Vadim Gindin wrote:
> Constantin, could you advice my why message (that is just before WAIT-FOR) is cleared when men... Constantin Asofiei
02:32 PM Feature #1790: implement menu support: Constantin, could you advice my why message (that is just before WAIT-FOR) is cleared when menu is drawn? In analogic... Vadim Gindin
02:08 PM Feature #1790: implement menu support: Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > ..
> > I think @MENU-DROP@ acts like an OS event, the same way... Constantin Asofiei
02:02 PM Feature #1790: implement menu support: Constantin Asofiei wrote:
> ..
> I think @MENU-DROP@ acts like an OS event, the same way i.e. @WINDOW-CLOSE@ acts. ... Vadim Gindin

04/23/2015

05:08 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Today I analyzed the case of nested frames and some other corner cases. Hopefully now we have a complete picture.
Le... Igor Skornyakov
02:57 PM Feature #1790: implement menu support: Vadim Gindin wrote:
> > > If so, then this means that the 4GL is setting a "fake" keycode as 1079 and lastkey is -1.... Constantin Asofiei
02:38 PM Feature #1790: implement menu support: Code Review vig_upd20150423a.zip
This is quite good.
1. In @Menu.java@, what is the requirement for import of @... Greg Shah
02:12 PM Feature #1790: implement menu support: At the first time I met this bug I thought that it is related to MENU-DROP. Now I think it is not related. Vadim Gindin
02:09 PM Feature #1790: implement menu support: Is the pause behavior related to MENU-DROP? Greg Shah
02:08 PM Feature #1790: implement menu support: PAUSE behavior fix is left. The current bug is the following. In Constantin's procedure message "bogus message so tha... Vadim Gindin
01:57 PM Feature #1790: implement menu support: I will look at the code next.
What is left to do to make ChUI menus fully functional? Greg Shah
01:27 PM Feature #1790: implement menu support: I didn't find another way beside to make hardcode fix for MENU-DROP event case for LAST-EVENT attributes. All attribu... Vadim Gindin
10:01 AM Feature #1790: implement menu support: > > If so, then this means that the 4GL is setting a "fake" keycode as 1079 and lastkey is -1. This means you woul... Vadim Gindin
09:55 AM Feature #1790: implement menu support: Greg Shah wrote:
> > Here is the sample output string for one trigger run:
> >
> > @MENU-DROP -1 PROGRESS 1079... Vadim Gindin
08:52 AM Feature #1790: implement menu support: > Here is the sample output string for one trigger run:
>
> @MENU-DROP -1 PROGRESS 1079 MENU-DROP PSEUDO-WIDGET... Greg Shah
08:14 AM Feature #1790: implement menu support: Vadim Gindin wrote:
> There are some interesting information in _langref_ in the definition of ON statement:
> [...... Constantin Asofiei
07:54 AM Feature #1790: implement menu support: Vadim Gindin wrote:
> About "no pause on RETURN" strange, but after I ran your procedure, choose sub-menu "Orwell", ... Constantin Asofiei
04:07 AM Feature #1790: implement menu support: My MENU-DROP trigger is the following:... Vadim Gindin
03:14 AM Feature #2546: implement combo-box widget in GUI: Eugenie Lyzenko wrote:
> Constantin, I see the @ScrollableListGuiImpl@ class implemented. Is it the GUI version of t... Constantin Asofiei
08:30 PM Feature #2546: implement combo-box widget in GUI: Code Review evl_upd20150422b.zip
It is a good start. Greg Shah
08:11 PM Feature #2546: implement combo-box widget in GUI: This is the current update for @combo-box@ implementation in addition to screens from P2J and 4GL. The drop-down butt... Eugenie Lyzenko
08:33 PM Feature #2545: add support for specially named button images: Code Review evl_upd20150422c.zip
It looks good. Greg Shah
08:31 PM Feature #2545: add support for specially named button images: Greg Shah wrote:
> Code Review evl_upd20150422a.zip
>
> Please move the @public static final@ members above the @... Eugenie Lyzenko
08:22 PM Feature #2545: add support for specially named button images: Code Review evl_upd20150422a.zip
Please move the @public static final@ members above the @private@ members. And t... Greg Shah

04/22/2015

07:49 PM Feature #2545: add support for specially named button images: The update has minor @javadoc@ comment fixes and making some constant public to be used in @ComboBoxGuiImpl@ when the... Eugenie Lyzenko
06:50 PM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> I think this is a good example of the case when, instead of relying on a synchronization mecha... Hynek Cihlar
06:47 PM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> So we have two options:
> # identify all cases which need to call super.afterConfigUpda... Hynek Cihlar
06:20 PM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> And even if we make these changes, the widget's size does not get update. This is relat... Constantin Asofiei
05:43 PM Feature #2252: implement GUI client support: Hynek, by any chance, do you have any FORMAT-related issues? Because this test is not working:... Constantin Asofiei
10:12 AM Feature #2252: implement GUI client support: Code Review hc_upd20150421c.zip
Everything looks good. I appreciate the improved comments and javadoc. It is ver... Greg Shah
05:13 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Constantin Asofiei wrote:
> You're welcome. But, are you sure you need FRAME:ROW/FRAME:BOX attributes? If the form... Igor Skornyakov
05:07 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor Skornyakov wrote:
> Well, Constantin was right - the rule for the INNER-LINES attribute setter is pretty simple... Constantin Asofiei
04:46 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Well, Constantin was right - the rule for the INNER-LINES attribute setter is pretty simple:
@<new value>@ = @min(<a... Igor Skornyakov
12:12 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Constantin Asofiei wrote:
> You can experiment with boxed or no-boxed frames, other widget/frame positions; if you f... Igor Skornyakov
11:57 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor, what I think is happening is this:
# the combo's drop box (when drawn) can not exceed beyond the status area. ... Constantin Asofiei
11:06 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Hynek Cihlar wrote:
> The algorithm maybe accounts for the widget border, at least in the case of @N2@?
Well, bot... Igor Skornyakov
10:44 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: The algorithm maybe accounts for the widget border, at least in the case of @N2@? Hynek Cihlar
10:27 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Wow, that is not complicated at all. :)
I've added Hynek and Eugenie as watchers. Eugenie is working on @ComboBox... Greg Shah
12:34 PM Feature #2546: implement combo-box widget in GUI: If the 4GL inherits the color from the container, then we need to do so as well.
If our result is incorrect becaus... Greg Shah
12:14 PM Feature #2546: implement combo-box widget in GUI: >> I'm asking because currently our colors differs from what we have in 4GL.
>
>Please provide some specifics.
... Eugenie Lyzenko
10:33 AM Feature #2546: implement combo-box widget in GUI: Good headway. Would you please also attach the Windows 4GL version of this same procedure?
> The plan is to attac... Greg Shah
09:58 PM Feature #2546: implement combo-box widget in GUI: The attached sample is the current state of the GUI implementations. The plan is to attach drop-down button based on ... Eugenie Lyzenko
12:28 PM Feature #1790: implement menu support: > Are there some artificial events like MENU-DROP, that also have no key?
Yes, everything in @Keyboard.evNames1@. ... Greg Shah
12:24 PM Feature #1790: implement menu support: I've tried do not use I/O operations in MENU-DROP trigger and accumulate strings in a global array and got the same r... Vadim Gindin
11:55 AM Feature #1790: implement menu support: Greg Shah wrote:
> > @keycode("MENU-DROP")@ is -1. Why?
>
> I assume you are describing the 4GL here? I guess th... Vadim Gindin
10:55 AM Feature #1790: implement menu support: > @keycode("MENU-DROP")@ is -1. Why?
I assume you are describing the 4GL here? I guess the reason is simply that ... Greg Shah
11:07 AM Feature #1798: implement full frame family support (parent-child relationships between frames): Code Review ca_upd20150421a.zip
I'm good with the changes. Greg Shah
02:54 AM Feature #1798: implement full frame family support (parent-child relationships between frames): This version passed runtime testing (fixes problems in TC.setScreenBuffer).
Will retest/release after HC's config ... Constantin Asofiei
09:55 AM Feature #2422: add features to BROWSE: > Because this is not a browse problem and I cannot fix it quickly, I'll return to it after all other browse work is ... Greg Shah
07:25 AM Feature #2422: add features to BROWSE: Conversion bug - two temp-tables with different labels / column labels are converted to the same @TempRecord@ class. ... Stanislav Lomany

04/21/2015

04:17 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Contrary to the 4GL docs the INNER-LINES attribute for the COMBO-BOX does have meaning in ChUI - it affects the heigh... Igor Skornyakov
04:03 PM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> I have Majic changes for review, should I post them here?
No, create a new task in the Majic ... Constantin Asofiei
04:02 PM Feature #2252: implement GUI client support: I have Majic changes for review, should I post them here? Hynek Cihlar
03:08 PM Feature #2252: implement GUI client support: The attached replaces hc_upd20150420g.zip and contains changes based on the review, Majic regression fixes and improv... Hynek Cihlar
10:45 AM Feature #2252: implement GUI client support: Greg Shah wrote:
> Code Review hc_upd20150420g.zip
>
> This is a really great step forward. Some comments and qu... Hynek Cihlar
10:01 AM Feature #2252: implement GUI client support: Code Review hc_upd20150420g.zip
This is a really great step forward. Some comments and questions:
1. I don't u... Greg Shah
09:16 PM Feature #2252: implement GUI client support: Attached is an update to the config refactoring work. The changes from last review are: worked-in comments, Majic reg... Hynek Cihlar
03:27 PM Feature #1790: implement menu support: There are some interesting information in _langref_ in the definition of ON statement:... Vadim Gindin
03:02 PM Feature #1790: implement menu support: A couple of questions about MENU-DROP event.
# @keycode("MENU-DROP")@ is -1. Why?
# @last-event:code@ is 1079. Wh... Vadim Gindin
02:54 PM Feature #1790: implement menu support: Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Questions.
> > # How to duplicate double call of trigger?
> I... Vadim Gindin
01:45 PM Feature #1811: implement the AJAX client driver: +Research Item+
*What is the best approach to provide web GUI client support for images as provided in the 4GL?*
... Greg Shah
11:12 AM Feature #1811: implement the AJAX client driver: The following are the next development steps to implement the GUI web client:
# Much of the web-specific code for ... Greg Shah

04/20/2015

02:59 PM Feature #2545: add support for specially named button images: > The only I can say was "stolen" is the size of the images (16x16) and how it looks.
This isn't stealing. Such ... Greg Shah
02:58 PM Feature #2545: add support for specially named button images: Code Review evl_upd20150420a.zip
It is good. Greg Shah
02:38 PM Feature #2545: add support for specially named button images: >1. In ButtonWidget change the import com.goldencode.p2j.ui.client.*; into import com.goldencode.p2j.ui.client.ImageH... Eugenie Lyzenko
02:03 PM Feature #2545: add support for specially named button images: Code Review evl_upd20150417a.zip
1. In @ButtonWidget@ change the @import com.goldencode.p2j.ui.client.*;@ into @im... Greg Shah
01:41 PM Feature #1790: implement menu support: Vadim Gindin wrote:
> Questions.
> # How to duplicate double call of trigger?
I think you need to explicitly treat... Constantin Asofiei
01:22 PM Feature #1790: implement menu support: I'm working on the last founded bug with pause. I've simplified testing procedure as it was possible:... Vadim Gindin

04/18/2015

04:33 PM Feature #2545: add support for specially named button images: All my button tests work fine with this update. So waiting for Hynek to checking in. Or may be there are the notes fr... Eugenie Lyzenko
08:28 PM Feature #2545: add support for specially named button images: This update for review is merged with the recent code base full support for prepackaged button images. 4 more icons h... Eugenie Lyzenko

04/17/2015

04:45 PM Feature #1790: implement menu support: Constantin Asofiei wrote:
> About 0417a.zip:
> * Please check the header for LogicalTerminal, is not merged properl... Vadim Gindin
01:46 PM Feature #1790: implement menu support: About 0417a.zip:
* Please check the header for LogicalTerminal, is not merged properly.
* MenuItemWidget - don't ad... Constantin Asofiei
12:46 PM Feature #1790: implement menu support: Here it is:... Vadim Gindin
11:42 AM Feature #1790: implement menu support: Here is my current update. Vadim Gindin
09:44 AM Feature #1790: implement menu support: Vadim Gindin wrote:
> I'm testing pausing bug from the note №265 and I need help. Here is what I've founded during t... Constantin Asofiei
09:33 AM Feature #1790: implement menu support: > P.S. I've change base classes of MenuItemWidget and MenuItemConfig to BaseEntity/BaseEntityConfig. But I can't do t... Greg Shah
03:57 PM Feature #1798: implement full frame family support (parent-child relationships between frames): Replacement of 0416c.zip. Fixed a regression and some other issues. Constantin Asofiei
02:50 PM Feature #1798: implement full frame family support (parent-child relationships between frames): > I was under the impression that we removed the "use a base ID for determining the frame's widget IDs", but we still... Greg Shah
02:39 PM Feature #1798: implement full frame family support (parent-child relationships between frames): I was under the impression that we removed the "use a base ID for determining the frame's widget IDs", but we still u... Constantin Asofiei
02:14 PM Feature #1798: implement full frame family support (parent-child relationships between frames): Greg Shah wrote:
> Code Review ca_upd20150416c.zip
>
> It looks good. It may make sense to not check this in unt... Constantin Asofiei
11:00 AM Feature #1798: implement full frame family support (parent-child relationships between frames): Code Review ca_upd20150416c.zip
It looks good. It may make sense to not check this in until after Hynek checks in... Greg Shah
03:15 PM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Very well, I implemented this for X attribute as well as it fol... Hynek Cihlar
11:07 AM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Very well, I implemented this for X attribute as well as it follows the same logic.
Please up... Constantin Asofiei
09:37 AM Feature #2422: add features to BROWSE: > I suggest to NOT implement the "weird" mode (1-7).
Agreed. Greg Shah
03:56 AM Feature #2422: add features to BROWSE: Implemented SELECT-NEXT/PREV-ROW, MAX-DATA-GUESS and ROW-MARKERS. Committed to bzr rev 10839. Stanislav Lomany
08:18 PM Feature #2422: add features to BROWSE: The set or rules for REFRESHABLE. By the "repositioned row" I mean the last row the query was repositioned to.
h3. R... Stanislav Lomany
09:40 PM Feature #2545: add support for specially named button images: The next step for review in prepackaged images support:
- the DEFINE BUTTON rule has been changes to add missing @SI... Eugenie Lyzenko

04/16/2015

03:18 PM Feature #1798: implement full frame family support (parent-child relationships between frames): This update adds server-side support for FIRST/LAST-CHILD and finishes server-side support for PARENT.
Also, NEXT/PR... Constantin Asofiei
05:58 AM Feature #1798 (WIP): implement full frame family support (parent-child relationships between frames): > Window family support is needed as well. We can split that off into another task if that is worthwhile. Window fa... Constantin Asofiei
02:43 PM Feature #2451 (Closed): implement FILL-IN widget in GUI client: Greg Shah
11:59 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> > I was looking for the annotated setter/getter
>
> That annotation does look like it is missi... Constantin Asofiei
10:36 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> > I was looking for the annotated setter/getter
>
> That annotation does look like it is missi... Igor Skornyakov
10:33 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: > I was looking for the annotated setter/getter
That annotation does look like it is missing in @CommonWidget.setF... Greg Shah
10:17 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> @GenericWidget.setFormat()@ calls @WidgetConfig.setDynamicFormat()@ which should set the @Control... Igor Skornyakov
10:06 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: @GenericWidget.setFormat()@ calls @WidgetConfig.setDynamicFormat()@ which should set the @ControlSetConfig.format@. Greg Shah
09:56 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> @ComboBoxConfig@ is a @ControlSetConfig@ which already supports the @FORMAT@ attribute. Is that ... Igor Skornyakov
10:14 AM Feature #2252: implement GUI client support: Very well, I implemented this for X attribute as well as it follows the same logic. Hynek Cihlar
09:50 AM Feature #2252: implement GUI client support: OK, this is not dead code. The problem the code was trying to fix was related to side-labels and changing the side-l... Constantin Asofiei
09:30 AM Feature #2252: implement GUI client support: This case brings you to a literal, although in P2J first-child doesn't yet work. I think that is really dead code, a... Constantin Asofiei
09:19 AM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin, @LiteralWidget.setColumnOrRowWorker()@ contains @co... Hynek Cihlar
09:11 AM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Constantin, @LiteralWidget.setColumnOrRowWorker()@ contains @config.align == ControlEntity.ALI... Constantin Asofiei
09:02 AM Feature #2252: implement GUI client support: Constantin, @LiteralWidget.setColumnOrRowWorker()@ contains @config.align == ControlEntity.ALIGN_RIGHT@ condition. I ... Hynek Cihlar
08:34 AM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Greg Shah wrote:
> > > Alternatively I can introduce new method next to Widget.getId(), Widge... Greg Shah
05:58 AM Feature #2252: implement GUI client support: Greg Shah wrote:
> BTW, I think the ca_upd201504315c.zip update is for #1798 not #2229.
Correct. I've added notes ... Constantin Asofiei
04:57 AM Feature #2252: implement GUI client support: Greg Shah wrote:
> > Alternatively I can introduce new method next to Widget.getId(), Widget.getIdInt() maybe?
>
... Hynek Cihlar
09:07 AM Feature #1790: implement menu support: I'm testing pausing bug from the note №265 and I need help. Here is what I've founded during today's testing.
# The ... Vadim Gindin
08:43 PM Feature #2545: add support for specially named button images: The update has basic implementation for prepackaged button images support. Several notes for what is ready:
- in 4GL... Eugenie Lyzenko
08:34 PM Feature #2422: add features to BROWSE: The plan is fine. How long do you need for the implementation? Greg Shah

04/15/2015

07:59 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: @ComboBoxConfig@ is a @ControlSetConfig@ which already supports the @FORMAT@ attribute. Is that not sufficient? Greg Shah
06:45 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: As far as I understand the SET-SELECTION method (and its companion SELECTION-TEXT attribute) for COMBO-BOX depends on... Igor Skornyakov
06:56 PM Feature #2422: add features to BROWSE: About REFRESHABLE. Typical use case of it is the following:
# Set it OFF.
# Make some repositions/re-open query, i.... Stanislav Lomany
12:31 PM Feature #2422: add features to BROWSE: Eric Faulhaber wrote:
> Stanislav Lomany wrote:
> > 3. Potentially there may be cases that fill-in state may differ... Greg Shah
12:21 PM Feature #2422: add features to BROWSE: Code Review svl_upd20150415a.zip
I'm good with the changes. Please get them regression tested.
Greg Shah
07:32 AM Feature #2422: add features to BROWSE: I'll put here rules which are applied to MAX-DATA-GUESS:
* Its default value is 100.
* For preselect queries it equ... Stanislav Lomany
06:25 PM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> And about the overhead: try to determine the CPU time/invocation count for your new aspe... Hynek Cihlar
04:58 PM Feature #2252: implement GUI client support: BTW, I think the ca_upd201504315c.zip update is for #1798 not #2229. Greg Shah
04:57 PM Feature #2252: implement GUI client support: Code Review ca_upd201504315c.zip
This is a really good update. The subject matter is tricky but you have implemen... Greg Shah
03:42 PM Feature #2252: implement GUI client support: This is for the #2229, WINDOW:PARENT attribute. It adds runtime support for window families: for the WINDOW-MINIMIZE... Constantin Asofiei
12:23 PM Feature #2545: add support for specially named button images: OK, then the only thing I want you to change in the plan is to bypass app jar and local client filesystem searches wi... Greg Shah
11:24 AM Feature #2545: add support for specially named button images: >What is missing?
Loading an image(not default icon for main window) from @p2j.jar@ file. Eugenie Lyzenko
11:02 AM Feature #2545: add support for specially named button images: > - store the arrow images on the client side p2j.jar file.
Yes.
> - use the current tools to load button image... Greg Shah
10:58 AM Feature #2545: add support for specially named button images: >In the 4GL, does one specify the special image name as a quoted string ("btn-up-arrow") or as unquoted text btn-up-a... Eugenie Lyzenko
10:28 AM Feature #2545: add support for specially named button images: In the 4GL, does one specify the special image name as a quoted string (@"btn-up-arrow"@) or as unquoted text @btn-up... Greg Shah
08:32 PM Feature #2545: add support for specially named button images: The base for embedded images is ready but the investigation shows we do not have the functionality to load them from ... Eugenie Lyzenko

04/14/2015

05:12 PM Feature #2422: add features to BROWSE: Update for review. Contains SELECT-NEXT/PREV-ROW, MAX-DATA-GUESS and ROW-MARKERS. Stanislav Lomany
09:57 AM Feature #2422: add features to BROWSE: > Is it feasible to subclass here instead?
Yes, we can do that. Stanislav Lomany
09:52 AM Feature #2422: add features to BROWSE: Stanislav Lomany wrote:
> 3. Potentially there may be cases that fill-in state may differ from browse column state, ... Eric Faulhaber
09:48 AM Feature #2422: add features to BROWSE: > In the Option 2 getter, I don't understand what this means: @--TriggerProcessing pushes screen definitions-->@.
... Stanislav Lomany
08:33 AM Feature #2422: add features to BROWSE: Option 1 is not feasible. The performance cost is too great. Attributes and methods can be called in loops. We can... Greg Shah
04:43 PM Feature #1790: implement menu support: As I stated in note 271 item 7, I really think that inheriting from @BaseEntity@/@BaseConfig@ does make sense. Other... Greg Shah
04:35 PM Feature #1790: implement menu support: Vadim Gindin wrote:
> P.S. Constantin, about base classes for config and MenuItemWidget. I can't remember concrete r... Constantin Asofiei
04:06 PM Feature #1790: implement menu support: Here is the next update with the following fixes:
# Fixes of previous Greg's remarks.
# Fix of parent bug. I added ... Vadim Gindin
08:40 AM Feature #1790: implement menu support: About the parent issue:
# there should be only one @parentId@ attribute, now we have one in @BaseConfig@ and one in @... Constantin Asofiei
03:16 PM Feature #2481 (Closed): enable, test and fix clipping for both rectangle and button GUI widgets: Greg Shah
02:48 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: @0414b@ committed in bzr as 10834. Will be distributed shortly. Eugenie Lyzenko
02:18 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Code Review evl_upd20150414b.zip
I'm good with the changes. Please go ahead and check them in since they only aff... Greg Shah
01:47 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: The repacked update for review with modified @FrameGuiImpl@ and removed @ThinClient@. Eugenie Lyzenko
01:32 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Eugenie Lyzenko wrote:
> Another word neither @FrameGuiImpl@(the updates will come from you) not @ThinClient@ are in... Constantin Asofiei
01:29 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Constantin Asofiei wrote:
> So, the plan is: remove the TC changes, add the @FrameGuiImpl.resizeScrollPane@ change I... Eugenie Lyzenko
01:20 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Eugenie, the tests you mention work fine with my #2451 work, and are incorrect without it: so this problem was relate... Constantin Asofiei
12:55 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: The update has modified @TC@ to brace widget painting inside @TC.eventDrawingBracket()@ for both cases, @viewWorker()... Eugenie Lyzenko
12:35 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Sorry for rectangle it is better to use @rect_test4.p@, after filling become off. Eugenie Lyzenko
09:56 AM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: >Do you have a recreate for rectangle/button, with the same (or similar) mis-placement as the fill-in? I can't find a... Eugenie Lyzenko
09:36 AM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Eugenie Lyzenko wrote:
> >Do you see this with other widgets beside FILL-IN? Because looks like with my frame layout... Constantin Asofiei
09:24 AM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: >Do you see this with other widgets beside FILL-IN? Because looks like with my frame layout changes in #2451 (pending... Eugenie Lyzenko
09:19 AM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Eugenie Lyzenko wrote:
> Yes, I know, this should go this way. But sometimes coordinate translation become inconsist... Constantin Asofiei
09:04 AM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: >No, I haven't encountered this issue. Can you tell me the test and steps to recreate this?
This is the @uast/button... Eugenie Lyzenko
08:52 AM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > Eugenie, from the update, the only changes I'm not OK with a... Constantin Asofiei
08:46 AM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Constantin Asofiei wrote:
> Eugenie, from the update, the only changes I'm not OK with are the TC changes:
> # @dra... Eugenie Lyzenko
04:50 AM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Eugenie, from the update, the only changes I'm not OK with are the TC changes:
# @drawAffectedWidgets@ - this is not... Constantin Asofiei

04/13/2015

06:54 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: The update for review adds clipping feature tested and multiple minor fixes taking into account changed widget coordi... Eugenie Lyzenko
01:55 PM Feature #2422: add features to BROWSE: My vision of two options explained:
Option 1 getter:
@BrowseWidget.getSome --LogicalTerminal API call--> Browse.get... Stanislav Lomany
12:36 PM Feature #2422: add features to BROWSE: In the 4GL many browse column attributes/methods are really just "redirected" from the contained control. I really d... Greg Shah
12:18 PM Feature #2422: add features to BROWSE: Guys, the CURSOR-OFFSET and AUTO-ZAP attributes reflect corresponding attributes of the fill-in which represents the ... Stanislav Lomany
06:15 AM Feature #2422: add features to BROWSE: COLUMN-BGCOLOR attribute is applicable to GUI only. Stanislav Lomany
10:10 AM Feature #1790: implement menu support: > I'll probably need additional state attribute in config class, for example "initialDisabled" and set it only during... Greg Shah
10:06 AM Feature #1790: implement menu support: > As you can see from AST mi has type VAR_HANDLE.
That is as it should be. @mi@ is really a reference to a handle... Greg Shah
09:51 AM Feature #1790: implement menu support: Vadim Gindin wrote:
> What is @<shadow-node .. />@ in AST tree?
These are nodes that store hidden tokens like whi... Greg Shah
08:46 AM Feature #1790: implement menu support: The question about mnemonic bug. Mnemonic is a char in the menu-item title that is a menu-item hot-key. It is specifi... Vadim Gindin
09:48 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Please check it in. Greg Shah

04/12/2015

09:19 AM Feature #1790: implement menu support: I made the test procedure that is similar to mine. This procedure creates dynamic frame widget (FillIn) and tries to ... Vadim Gindin
07:32 AM Feature #1790: implement menu support: What is @<shadow-node .. />@ in AST tree? Vadim Gindin

04/11/2015

07:13 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: The update for review adds fix for UI screen phantom rectangle issue. The @TC.viewWorker()@ needs to use indirect @re... Eugenie Lyzenko
08:32 AM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Code Review evl_upd20150410a.zip
I'm OK with the changes. Greg Shah
08:36 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: This update includes rectangle related clipping functionality plus minor clean up. The @GuiSimulator@ also has minor ... Eugenie Lyzenko
05:15 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: All regression tests (except tc_job_002) passed. Igor Skornyakov
08:21 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Code Review ias_upd20150411a.zip
The change looks fine. Greg Shah
04:45 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Fixed bug found by regression test Igor Skornyakov

04/10/2015

04:58 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: >Eugenie: this is fixed in FrameGuiImpl.resizeScrollPane. Here is the code which places the scroll-pane in the correc... Eugenie Lyzenko
03:38 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Greg Shah wrote:
> Does the solution delegate the calculation of the correct drawing space to the container?
The ro... Constantin Asofiei
02:54 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Does the solution delegate the calculation of the correct drawing space to the container? Greg Shah
02:51 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Eugenie Lyzenko wrote:
> It is not Window issue, my explanation was bad. It is Frame issue. If there is no outer box... Constantin Asofiei
02:49 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: It is not Window issue, my explanation was bad. It is Frame issue. If there is no outer box in a frame our coordinate... Eugenie Lyzenko
11:25 AM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: >Are we just incorrectly reporting the coordinates of the Window's "client area"? The 1-pixel black rectangle should ... Eugenie Lyzenko
05:45 AM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: > 1. The widget coordinate has one pixel skew to left and up from what we have in 4GL. I know it is always expected t... Greg Shah
09:58 PM Feature #2481: enable, test and fix clipping for both rectangle and button GUI widgets: Some interesting investigation results:
During debugging clip/draw code I've found two points to be considered and... Eugenie Lyzenko
09:20 AM Feature #1790: implement menu support: @mi.unwrapWidget().setParent(m.getSelf())@ seems best. It is also more consistent with the approach we use for the r... Greg Shah
07:37 AM Feature #1790: implement menu support: Greg, I've fixed "handle" problem for menu as you advised. Now @assign mi:parent = menu m:handle@ is converted to @mi... Vadim Gindin
04:41 AM Feature #1790: implement menu support: This is a problem with the name resolution: in 4GL, a table can be abbreviated using only the first letter, so a @fin... Constantin Asofiei
03:25 AM Feature #1790: implement menu support: From time to time I'm facing with the following conversion problem. Look at the following procedure:... Vadim Gindin
06:03 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Code Review ias_upd20150410a.zip
This looks good. Greg Shah
04:59 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Fixed bug found by regression test. Igor Skornyakov

04/09/2015

03:08 PM Feature #1790: implement menu support: Search on @prog.kw_handle@ in @methods_attributes.rules@. There are places there where we emit a special accessor to... Greg Shah
01:28 PM Feature #1790: implement menu support: The question about conversion bug with handles. Lets look at the following procedure:... Vadim Gindin
02:42 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Please create a new task that has a recreate (both a 4GL testcase and a set of instructions) for the problem. Greg Shah
01:01 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> I agree. Actually, if you think the described behavior is rare enough that it is less likely to ... Igor Skornyakov
12:53 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: I agree. Actually, if you think the described behavior is rare enough that it is less likely to be encountered AND i... Greg Shah
12:44 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> How compatible are we? Please document any areas where differences remain (as far as you know).
... Igor Skornyakov
12:36 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: How compatible are we? Please document any areas where differences remain (as far as you know). Greg Shah
12:07 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> Generally, I'm good with the changes. In some ways the result is cleaner and in some other way... Igor Skornyakov
11:33 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Code Review ias_upd20150409a.zip
Generally, I'm good with the changes. In some ways the result is cleaner and in ... Greg Shah
04:59 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Merged with revno 10832, fixed bug found by regression test. Igor Skornyakov
09:48 AM Feature #2480 (Closed): add support for button and image attributes and options: The special button arrow images task is #2545. Greg Shah
08:34 AM Feature #2480: add support for button and image attributes and options: Greg Shah wrote:
> As far as I understand, all features for this task are finished and working properly. Is that cor... Eugenie Lyzenko
07:54 AM Feature #2480: add support for button and image attributes and options: As far as I understand, all features for this task are finished and working properly. Is that correct?
There are t... Greg Shah
08:19 PM Feature #2480: add support for button and image attributes and options: The update has been committed in bzr as @10832@. Eugenie Lyzenko
08:08 PM Feature #2480: add support for button and image attributes and options: The regression testing completed. There are no issues, results - @10831_9aea7ab_20150408_evl.zip@.
I'm going to co... Eugenie Lyzenko
08:07 AM Feature #2546: implement combo-box widget in GUI: This task is for full implementation of the GUI widget implementation for combo-box. Please note that some attribute... Greg Shah
08:03 AM Feature #2546 (Closed): implement combo-box widget in GUI: Greg Shah
07:57 AM Feature #2545: add support for specially named button images: For details see #2480 notes 84 and 85. This task is to implement support for those images. Greg Shah
07:56 AM Feature #2545 (Closed): add support for specially named button images: Greg Shah
07:54 AM Bug #2477 (Closed): button remains pressed when it should not: Greg Shah
04:01 AM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > And about the overhead: try to determine the CPU time/invocatio... Constantin Asofiei

04/08/2015

05:54 PM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> And about the overhead: try to determine the CPU time/invocation count for your new aspe... Hynek Cihlar
05:49 PM Feature #2252: implement GUI client support: Greg Shah wrote:
> The aspects make things difficult for 2 reasons: they are hidden/indirect AND the conditions that... Hynek Cihlar
03:02 PM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek, beside what Greg noted:
> > * AbstractWidget.afterConfi... Hynek Cihlar
02:21 PM Feature #2252: implement GUI client support: > Server-side doesn't need to track widget attribute changes. If an attribute gets changed, we rely on the LT.pushScr... Greg Shah
01:27 PM Feature #2252: implement GUI client support: Greg Shah wrote:
> > Was the impact contributed just by the aspect overhead or the useful logic itself?
>
> I thi... Constantin Asofiei
12:59 PM Feature #2252: implement GUI client support: > Was the impact contributed just by the aspect overhead or the useful logic itself?
I think Constantin would know... Greg Shah
11:50 AM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Hynek, beside what Greg noted:
> * AbstractWidget.afterConfigUpdateBase - beforeUpdate ... Hynek Cihlar
11:41 AM Feature #2252: implement GUI client support: Greg Shah wrote:
> Code Review hc_upd20150407b.zip
>
> Overall, this is a really great step forward. Although th... Hynek Cihlar
08:33 AM Feature #2252: implement GUI client support: Hynek, beside what Greg noted:
* AbstractWidget.afterConfigUpdateBase - beforeUpdate param has no javadoc
* FillIn.... Constantin Asofiei
07:12 AM Feature #2252: implement GUI client support: Code Review hc_upd20150407b.zip
Overall, this is a really great step forward. Although the aspect code is both in... Greg Shah
05:17 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Editor rework finished. Igor Skornyakov
03:14 PM Feature #1790: implement menu support: Greg Shah wrote:
> Code Review vig_upd20150408a.zip
>
> 1. It seems to me that there is quite a bit of potentiall... Vadim Gindin
11:51 AM Feature #1790: implement menu support: Code Review vig_upd20150408a.zip
1. It seems to me that there is quite a bit of potentially generic functionality ... Greg Shah
05:19 AM Feature #1790: implement menu support: Here is my current update, intended for your review. The main functionality is working: MENUBAR and POPUP-MENU: drawi... Vadim Gindin
10:07 AM Feature #2480: add support for button and image attributes and options: Code Review evl_upd20150408a.zip
It looks good.
Agreed, no conversion testing is needed. Greg Shah
09:26 AM Feature #2480: add support for button and image attributes and options: This is the merge with recent @10831@ code base.
Because @ThinClient@ has crossing I'm going to restart runtime te... Eugenie Lyzenko
08:39 AM Feature #2480: add support for button and image attributes and options: The main part completed without regressions. Continue with @CTRL-C@ sessions. Eugenie Lyzenko
02:55 AM Feature #2422: add features to BROWSE: Committed to bzr rev 10831. Stanislav Lomany

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » User Interface

Activity

Activity

05/07/2015

05/06/2015

05/05/2015

05/04/2015

05/03/2015

05/02/2015

05/01/2015

04/30/2015

04/29/2015

04/28/2015

04/27/2015

04/26/2015

04/25/2015

04/24/2015

04/23/2015

04/22/2015

04/21/2015

04/20/2015

04/18/2015

04/17/2015

04/16/2015

04/15/2015

04/14/2015

04/13/2015

04/12/2015

04/11/2015

04/10/2015

04/09/2015

04/08/2015