Project

General

Profile

Activity

From 07/05/2015 to 08/03/2015

08/04/2015

10:57 PM Feature #2252: implement GUI client support
Code Review Task Branch 2424b Revision 10921
I'm good with the changes.
> the code still needs cleanup and is ...
Greg Shah
08:01 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
> CHARVA is mentioned in many places in this class. Should I remove them all?
Yes, please do.
Greg Shah

08/03/2015

04:03 PM Feature #2252: implement GUI client support
Please review task branch 2424b, revision 10921. This among others resolves the comments from the review of revision ... Hynek Cihlar
11:10 AM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek Cihlar wrote:
> > > @frame-scrolling-size.p@ abends for ...
Constantin Asofiei
10:56 AM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > @frame-scrolling-size.p@ abends for me, I didn't investigate fu...
Hynek Cihlar
10:40 AM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> @frame-scrolling-size.p@ abends for me, I didn't investigate further:
Something has regressed...
Constantin Asofiei
05:45 AM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek, beside this there are some frame size issues: the frame size is not computed corr...
Hynek Cihlar
05:27 AM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek, beside this there are some frame size issues: the frame size is not computed corr...
Hynek Cihlar
05:12 AM Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review Task Branch 2424b Revision 10916
Greg, the code still needs cleanup and is missing...
Hynek Cihlar
05:04 AM Feature #2252: implement GUI client support
Code Review Task Branch 2424b Revision 10916
Overall, the update is quite good. I assume you are planning to add ...
Greg Shah
03:04 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Fixed issues 1,2,3,6 mentioned in the code review. Committed to the branch 2567a, revno 10925.
Regarding the issue...
Igor Skornyakov
02:42 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Code Review Task Branch 2567a Revision 10924
>
> This is quite good. Most issues are minor, b...
Igor Skornyakov
02:06 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Code Review Task Branch 2567a Revision 10924
This is quite good. Most issues are minor, but issue 4 is a more ser...
Greg Shah
02:26 PM Feature #1811: implement the AJAX client driver
> 1)Draw an image on the server side in a memory (GuiWebEmulatedWindow,SwingEmulatedWindow)
> 2)Transfer binaries vi...
Greg Shah
12:39 PM Feature #1811: implement the AJAX client driver
> Then please review the @PaintPrimitives.DRAW_IMAGE@ implementation in our GUI client. The easiest way is to search... Sergey Ivanovskiy
10:44 AM Bug #2623: mouse cursor icons for the window edges sometimes don't change back to the standard ar...
Rebased branch 2623a, from trunk rev 10906 (new branch rev 10907) Constantin Asofiei
10:43 AM Bug #2621: wait-for only works for current-window
Rebased branch 2621a, from trunk rev 10906 (new branch rev 10907) Constantin Asofiei
08:01 AM Feature #1790: implement menu support
I'm working on the following error. If the source procedure contains the statement WAIT-FOR with the event of some me... Vadim Gindin

08/02/2015

12:03 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Added Javadocs. Committed to the branch 2567a, revno 10924.
Ready for the code review
Igor Skornyakov

08/01/2015

06:35 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Rebased task branch 2567a from P2J trunk revision 10906 (new branch revision 10923). Igor Skornyakov
06:12 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> That is great!
>
> Now may be a good time to rebase. Do you need any more changes/cleanup bef...
Igor Skornyakov
06:04 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
That is great!
Now may be a good time to rebase. Do you need any more changes/cleanup before code review?
Greg Shah
05:56 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Fixed the bug with the @ON LEAVE@ trigger activation (note #50). Committed to the branch 2567a, revno 10918. Igor Skornyakov
08:05 PM Feature #2546: implement combo-box widget in GUI
After some investigations especially for widgets without explicit width/height set I have found the character based v... Eugenie Lyzenko

07/31/2015

07:24 PM Feature #2252: implement GUI client support
Rebased task branch 2424b from P2J trunk revision 10906 (branch revision 10916). Hynek Cihlar
06:30 AM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek, sorry for the delay about this one:
> > I am not sure how the Windows font scali...
Hynek Cihlar
04:23 PM Feature #2546: implement combo-box widget in GUI
Rebased task branch @2546c@ from P2J trunk revision @10906@, new branch revision is @10906@. Eugenie Lyzenko
08:06 AM Feature #2546: implement combo-box widget in GUI
Eugenie, in case you need to determine if the widget's dimension was set explicitly, there are the @fixedWidth@ and @... Constantin Asofiei
05:56 AM Feature #2546: implement combo-box widget in GUI
Created task branch @2546c@ from P2J trunk revision @10905@. Eugenie Lyzenko
05:49 AM Feature #2546: implement combo-box widget in GUI
The branch @2546b@ has been merged and committed to trunk as revision @10905@. Archived. Eugenie Lyzenko
05:36 AM Feature #2546: implement combo-box widget in GUI
@2546b@ passed the regression testing. The results - @2546b_10916_16cd2a2_20150731_evl.zip@. Starting to merge into m... Eugenie Lyzenko
03:48 PM Feature #1811: implement the AJAX client driver
Rebased task branch 1811o from P2J trunk revision 10906. Greg Shah
03:19 PM Feature #1811: implement the AJAX client driver
That is fine. 1811p branch is merged to the trunc with revno: 10906.
Sergey Ivanovskiy
03:08 PM Feature #1811: implement the AJAX client driver
The rebase looks fine.
> do want to see in the trunc all history from 1811p
When you commit the change in the t...
Greg Shah
03:06 PM Feature #1811: implement the AJAX client driver
Now 1811p is branched from rev 10905 of trunc. Sergey Ivanovskiy
02:58 PM Feature #1811: implement the AJAX client driver
> Let me know what questions you have.
Greg, now 1811p has been rebased to the trunc 10905, do want to see in the tru...
Sergey Ivanovskiy
02:21 PM Feature #1811: implement the AJAX client driver
Next task: I would like you to help me add image support to the GUI web client. You will be making changes in task b... Greg Shah
02:12 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811p Revision 10905
It looks good.
Please rebase the update to the latest trunk revisi...
Greg Shah
01:54 PM Feature #1811: implement the AJAX client driver
> Code Review Task Branch 1811p Revision 10904
All done accordingly
> 3. I see your changes in @p2j.clipboard_helpe...
Sergey Ivanovskiy
12:48 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811p Revision 10904
1. I still have not seen any testing results with my original idea of...
Greg Shah
10:04 AM Feature #1811: implement the AJAX client driver
> Please document the results of your "use strict" testing here.
There are no possibilities to define "use strict" in...
Sergey Ivanovskiy
09:51 AM Feature #1811: implement the AJAX client driver
Please document the results of your "use strict" testing here. Greg Shah
08:29 AM Feature #1811: implement the AJAX client driver
Added all changes from rev 10901 trunc to rev 10904 of branch 1811p.
Sergey Ivanovskiy
08:21 AM Feature #1811: implement the AJAX client driver
Greg, please review final changes for 1811p branch rev. 10904.
Sergey Ivanovskiy
03:14 PM Bug #2621: wait-for only works for current-window
> but this will mean that the current EmulatedWindowState needs to be interrogated each time draw() is called to get ... Greg Shah
03:04 PM Bug #2621: wait-for only works for current-window
Greg Shah wrote:
> Code Review Task Branch 2621a Revision 10906
>
> I like the changes.
>
> My only question: ...
Constantin Asofiei
02:54 PM Bug #2621: wait-for only works for current-window
Code Review Task Branch 2621a Revision 10906
I like the changes.
My only question: Should the @gd.selectWindow(...
Greg Shah
06:19 AM Bug #2621: wait-for only works for current-window
Rebased branch 2621a, from trunk rev 10905 (new branch rev 10906) Constantin Asofiei
03:00 PM Bug #2623: mouse cursor icons for the window edges sometimes don't change back to the standard ar...
Code Review Task Branch 2623a Revision 10906
I'm good with the changes.
Greg Shah
07:46 AM Bug #2623 (Review): mouse cursor icons for the window edges sometimes don't change back to the st...
Please review branch 2623a rev 10906. Constantin Asofiei
06:30 AM Bug #2623 (WIP): mouse cursor icons for the window edges sometimes don't change back to the stand...
Created task branch 2623a from trunk rev 10905. Constantin Asofiei
12:53 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> > Well, suggest to take the route 2. If this will not be done today and at the weekend, then reve...
Igor Skornyakov
12:51 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
> Well, suggest to take the route 2. If this will not be done today and at the weekend, then revert to the route 1.
...
Greg Shah
12:45 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> OK, good. Then we have 3 options on moving forward:
>
> 1. Review and regression test the cur...
Igor Skornyakov
12:31 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
OK, good. Then we have 3 options on moving forward:
1. Review and regression test the current 2567a branch. Then...
Greg Shah
12:25 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Other than the bug in note 50, am I correct that only the GUI related features are left?
>
> T...
Igor Skornyakov
12:23 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Other than the bug in note 50, am I correct that only the GUI related features are left?
That would be this list:
...
Greg Shah
11:58 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Finished implementation of the runtime support for the WIDGET-ENTER and WIDGET-LEAVE attributes. Committed to the br... Igor Skornyakov
08:08 AM Bug #2622 (WIP): width-pixel/height-pixels can't be assigned during create frame
Setting the frame's width/height attributes works in P2J only in "batch" mode, with the @CREATE ASSIGN@ statement. W... Constantin Asofiei

07/30/2015

05:36 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Partial runtime support for the WIDGET-ENTER and WIDGET-LEAVE attributes. Committed to the branch 2567a, revno 10916.... Igor Skornyakov
01:30 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> I mean when you find something which is related to the core focus or event processing. ...
Igor Skornyakov
01:22 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > When you find incompatibilities like this, please confirm 4G...
Constantin Asofiei
01:21 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> When you find incompatibilities like this, please confirm 4GL test behaves the some, bot...
Igor Skornyakov
01:04 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> Greg Shah wrote:
> > Thanks for the heads-up on this. I assume you are working on this as...
Constantin Asofiei
10:09 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Thanks for the heads-up on this. I assume you are working on this as part of the current task. ...
Igor Skornyakov
09:56 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> The logic of the @FocusManager.focusChange()@ method should be changed as within the @ON LE...
Greg Shah
09:54 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Thanks for posting the unknown value processing/messages problems (notes 46 and 56). I have created task #2629 for t... Greg Shah
07:35 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> For this task, please change your test to protect against unknown handle usage. So, ins...
Igor Skornyakov
07:29 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Igor Skornyakov wrote:
> > > p2j generates incompatible err...
Constantin Asofiei
07:21 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > p2j generates incompatible error message when referencing to...
Igor Skornyakov
07:10 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> p2j generates incompatible error message when referencing to the attributes of the @handle@...
Constantin Asofiei
07:09 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
p2j generates incompatible error message when referencing to the attributes of the @handle@ which has 'unknown' value... Igor Skornyakov
05:20 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
The logic of the @FocusManager.focusChange()@ method should be changed as within the @ON LEAVE@ trigger it should be ... Igor Skornyakov
04:42 PM Feature #1782: implement LAST-EVENT system handle and associated attributes
> Have you found a use-case which is not working?
No. Sometime in the past I had written down a note to myself t...
Greg Shah
04:03 PM Feature #1782: implement LAST-EVENT system handle and associated attributes
Greg Shah wrote:
> LAST-EVENT:EVENT-TYPE = "MOUSE" needs to be supported for GUI
This is already added: @KeyReader....
Constantin Asofiei
04:38 PM Feature #1796 (Closed): implement full GUI layout support
Greg Shah
04:15 PM Feature #2252: implement GUI client support
Hynek, sorry for the delay about this one:
> I am not sure how the Windows font scaling affects this equation (it ca...
Constantin Asofiei
01:23 PM Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review Task Branch 1796d Revision 10912
>
> I'm fine with the changes. And we can stick ...
Constantin Asofiei
08:08 AM Feature #2252: implement GUI client support
Code Review Task Branch 1796d Revision 10912
I'm fine with the changes. And we can stick with the new token appro...
Greg Shah
05:19 AM Feature #2252: implement GUI client support
Rebased task branch 1796d from P2J trunk revision 10902 (new branch revision 10912).
Testing has already passed for ...
Constantin Asofiei
03:50 PM Bug #2621: wait-for only works for current-window
Please review branch 2621a, revision 10905. It contains these fixes:
* FramePlacementManager must be window specifi...
Constantin Asofiei
03:46 PM Feature #1811: implement the AJAX client driver
> If a translation is required without a draw operation then I would create a new method executeTranslated(origin, co... Greg Shah
03:32 PM Feature #1811: implement the AJAX client driver
Also, please put in a comment to explain why @\r@ is being used instead of @\n@. Greg Shah
03:31 PM Feature #1811: implement the AJAX client driver
> it helps me if instead of '\n' web client will send '\r' as EOL that is okay for EditorImpl and it is treated prop... Greg Shah
02:13 PM Feature #1811: implement the AJAX client driver
> I don't understand this one. @Editor.processKeyEvent@ has this code to treat the @KA_RETURN@ and @KA_NEW_LINE@ cas... Sergey Ivanovskiy
01:52 PM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> > Overall, adding newlines to the copy function seems like a reasonable way to do this. I...
Constantin Asofiei
12:18 PM Feature #1811: implement the AJAX client driver
> web client supports browser side clipboard with help of hidden input field
Yes.
> If a user presses CTRL+C a...
Greg Shah
11:50 AM Feature #1811: implement the AJAX client driver
> Overall, adding newlines to the copy function seems like a reasonable way to do this. I don't know offhand why thes... Sergey Ivanovskiy
09:17 AM Feature #1811: implement the AJAX client driver
> end-lines are lost on the server side, it is unclear if screen.video (2-dim array, p2j.screen.js) should contain e... Greg Shah
09:05 AM Feature #1811: implement the AJAX client driver
> Please look at the committed code 1811p revision 10903 and run it to prove the reason.
I've looked at the code t...
Greg Shah
04:29 AM Feature #1811: implement the AJAX client driver
1811#756
> > "use strict" defined in each module's function gives possibility to work with an external non-strict j...
Sergey Ivanovskiy
03:31 PM Feature #2546: implement combo-box widget in GUI
Rebased task branch @2546b@ from P2J trunk revision @10904@, new branch revision is @10916@. Eugenie Lyzenko
03:13 PM Feature #2546: implement combo-box widget in GUI
Looks like I need another rebase from @10904@ and restart testing. Starting. Eugenie Lyzenko
02:50 PM Feature #2546: implement combo-box widget in GUI
>Eugenie: please rebase 2546b from 10903 in the trunk. Then put that version into regression testing. If it passes te... Eugenie Lyzenko
01:56 PM Feature #2546: implement combo-box widget in GUI
Eugenie: please rebase 2546b from 10903 in the trunk. Then put that version into regression testing. If it passes t... Greg Shah
01:43 PM Feature #2546: implement combo-box widget in GUI
Eugenie, your scaling approach is still faulty; easiest way to prove is to use an explicit font with a small size and... Constantin Asofiei
11:32 AM Feature #2546: implement combo-box widget in GUI
>We have accepted that the font rendering may be slightly different in our system. But it must be very close, such th... Eugenie Lyzenko
10:36 AM Feature #2546: implement combo-box widget in GUI
Rebased task branch @2546b@ from P2J trunk revision @10902@, new branch revision is @10914@. Eugenie Lyzenko
08:47 AM Feature #2546: implement combo-box widget in GUI
I'll let Constantin answer the note 237.
> Despite of the modern systems WYSIWYG declaration the real life is diff...
Greg Shah
08:16 AM Feature #2546: implement combo-box widget in GUI
What I do not understand here is the difference between your offering and what we currently have in @10913@? And why ... Eugenie Lyzenko
05:47 AM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Task branch @2546b@ for review updated to revision @10913@.
What I meant is to remove comp...
Constantin Asofiei
01:58 PM Feature #1790: implement menu support
> Is that correct?
Yes, exactly right.
Greg Shah
01:55 PM Feature #1790: implement menu support
Greg Shah wrote:
> > The format of the key-name string depends on the current keyboard layout.
>
> Yes, it is a c...
Vadim Gindin
12:04 PM Feature #1790: implement menu support
> The format of the key-name string depends on the current keyboard layout.
Yes, it is a concern. It means that f...
Greg Shah
11:48 AM Feature #1790: implement menu support
Constantin Asofiei wrote:
> Greg Shah wrote:
> > The answer to how, is simple: capture the result of the WIN32 API ...
Vadim Gindin
08:58 AM Feature #1790: implement menu support
Greg Shah wrote:
> The answer to how, is simple: capture the result of the WIN32 API call for each key code that we ...
Constantin Asofiei
08:40 AM Feature #1790: implement menu support
> This function returned exactly "PgDn" for VK_NEXT (0x22=34 in a decimal notation). So I think that is the origin of... Greg Shah
07:01 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> I've made these corrections, but it didn't helped. All proposed changes are in the client-side...
Constantin Asofiei
01:32 PM Feature #1791: implement dynamic UI support
I think this should have been done previously, but it was missed.
We do need TRIGGERS phrase support to be impleme...
Greg Shah
01:29 PM Feature #1791: implement dynamic UI support
Is CREATE ... TRIGGERS supposed to be converted properly? Is somebody working on that? Currently ... Stanislav Lomany
10:41 AM Feature #1791: implement dynamic UI support
> Did you expect to remove the query attribute from the @methods_attributes.rules@ in revision 10904 of branch 2026a?... Stanislav Lomany
08:58 AM Feature #1791: implement dynamic UI support
Did you expect to remove the query attribute from the @methods_attributes.rules@ in revision 10904 of branch 2026a?
...
Greg Shah
06:22 AM Feature #1791: implement dynamic UI support
Rebased task branch 2026a from P2J trunk revision 10902. Stanislav Lomany
10:46 AM Feature #2422 (Closed): add features to BROWSE
Greg Shah
09:58 AM Feature #2422: add features to BROWSE
Stanislav Lomany wrote:
> I cannot remember or see any unimplemented features. The only thing that comes to mind is ...
Greg Shah
09:53 AM Feature #2422: add features to BROWSE
I cannot remember or see any unimplemented features. The only thing that comes to mind is that saving of new rows is ... Stanislav Lomany
07:54 AM Feature #2422: add features to BROWSE
Please create the related task for non-fill-in column support in browse.
I know we have moved some GUI features to...
Greg Shah
04:33 AM Feature #2422 (Review): add features to BROWSE
Branch 2422b has been committed to trunk revision 10902 (Implemented BROWSE:MODIFIED and SET-REPOSITIONED-ROW). Stanislav Lomany
10:32 AM Feature #2630: Add ability to save new rows in browse.
Currently we can insert new rows in a browse, but not save them. Saving is combination of INSERT-ROW, ASSIGN and CREA... Stanislav Lomany
10:30 AM Feature #2630 (New): Add ability to save new rows in browse.
Stanislav Lomany
09:52 AM Bug #2629: deviations in handle with unknown value error processing and messages
There are multiple problems. Please see the testcases and descriptions as posted in #2567 note 46 and note 56. Greg Shah
09:52 AM Bug #2629 (New): deviations in handle with unknown value error processing and messages
Greg Shah
08:37 AM Feature #2628: Non-fill-in column support in browse.
Browse can contain combo-boxes and toggle-boxes. Stanislav Lomany
08:35 AM Feature #2628 (WIP): Non-fill-in column support in browse.
Stanislav Lomany
08:33 AM Feature #2627: Implement quirky cases of refresh when REFRESHABLE is turned ON
See commented code section in @Browse.executePendingRefresh@. Stanislav Lomany
08:31 AM Feature #2627 (New): Implement quirky cases of refresh when REFRESHABLE is turned ON
Stanislav Lomany

07/29/2015

07:34 PM Feature #2546: implement combo-box widget in GUI
>...This will create a text-metrics.xml file which you will need to add to your classpath, when running the programs.... Eugenie Lyzenko
03:10 PM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Consider button testcases, one example is the button like "Enable on/off". The button text ...
Constantin Asofiei
02:47 PM Feature #2546: implement combo-box widget in GUI
Task branch @2546b@ for review updated to revision @10913@.
Scaling clean up completed.
Eugenie Lyzenko
02:26 PM Feature #2546: implement combo-box widget in GUI
>I don't understand this one: to me, it looks like in this case there is an implicit font and the width is not set ex... Eugenie Lyzenko
02:05 PM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> But the main issue on my guess is wrong calculation(or not enough precision) of the @FontMa...
Constantin Asofiei
01:42 PM Feature #2546: implement combo-box widget in GUI
>Otherwise, you need to change your scaling approach in ComboBoxGuiImpl so that the dimension is computed using the f... Eugenie Lyzenko
10:15 AM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Task branch @2546b@ for review updated to revision @10912@.
* ComboBoxGuiImpl:497 - please...
Constantin Asofiei
05:26 PM Feature #1790: implement menu support
I've made these corrections, but it didn't helped. All proposed changes are in the client-side. Menu config change (v... Vadim Gindin
02:59 PM Feature #1790: implement menu support
About "PgDn" string origin in accelerator, where "PAGE-DOWN" is specified. Here are the following results:
# VK_NE...
Vadim Gindin
03:02 PM Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review Task Branch 1796d Revision 10910
>
> My only questions:
>
> 1. Why are the FRAM...
Constantin Asofiei
02:39 PM Feature #2252: implement GUI client support
Code Review Task Branch 1796d Revision 10910
My only questions:
1. Why are the FRAME_LOCK/FRAME_UNLOCK nodes ne...
Greg Shah
01:54 PM Feature #2252: implement GUI client support
Please review branch 1796d:
* revisions 10907, 10908, 10909 contain more fixes for drawing a GUI frame (down/title/s...
Constantin Asofiei
12:00 PM Feature #2252: implement GUI client support
Greg Shah wrote:
> Once you have the CREATE ASSIGN locking fix, plan to merge up with Stanislav's 2422b update that ...
Constantin Asofiei
02:10 PM Feature #1811: implement the AJAX client driver
> running this command isn't permitted for sbi@devsrv01 user:
Good point. I have made some modifications to devsr...
Greg Shah
05:51 AM Feature #1811: implement the AJAX client driver
> 3. Ensure that the spawner is installed into that directory:
>
> @cd ~/testing/majic/p2j/@
> @ant jar native -Dpos...
Sergey Ivanovskiy
05:41 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> I don't understand the need for the 2nd @translate()@ and it will cause me some problems with t...
Hynek Cihlar

07/28/2015

05:56 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Rebased task branch 2567a from P2J trunk revision 10901 (new branch revision 10915).
Igor Skornyakov
05:43 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Partial runtime support for the WIDGET-ENTER and WIDGET-LEAVE attributes. Committed to the branch 2567a, revno 10914. Igor Skornyakov
12:32 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
It seems that there is a bug in p2j. When running the attached program in 4GL all four triggers are invoked pairwise,... Igor Skornyakov
05:45 PM Feature #1811: implement the AJAX client driver
> But if there is no selection, then Ctrl + C terminates the client's session and the client is redirected to login p... Greg Shah
05:41 PM Feature #1811: implement the AJAX client driver
For rev 10866 the selection is working as expected the selection rectangle highlights the target text. And if there i... Sergey Ivanovskiy
05:24 PM Feature #1811: implement the AJAX client driver
> How the selection should work? Usually, we can use a mouse or a keyboard to select a text. But in revision 10866 mo... Greg Shah
04:24 PM Feature #1811: implement the AJAX client driver
> I believe that the current ChUI Web client (in the P2J trunk) may have its clipboard support in a broken state. Th... Sergey Ivanovskiy
03:32 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> This case has an extra @translate()@ in the middle. And I'm not clear why it is there. If I und...
Constantin Asofiei
03:23 PM Feature #1811: implement the AJAX client driver
In the Javascript canvas, the management of clipping and translation is limited. It provides those features, but it ... Greg Shah
02:23 PM Feature #1811: implement the AJAX client driver
It was my fault that I used the template gso_20090909_1_14_4a_master and didn't setup a personal MAJIC database on de... Sergey Ivanovskiy
12:58 PM Feature #1811: implement the AJAX client driver
Eric Faulhaber wrote:
> Constantin, since it looks like the master was used against a live system, it is no longer p...
Constantin Asofiei
12:49 PM Feature #1811: implement the AJAX client driver
The problem is that there is no working database, only templates:... Eric Faulhaber
12:31 PM Feature #1811: implement the AJAX client driver
Sergey, how did you start the server on devsrv01? via @server.sh@ or via @run_regression.sh@? p2jpl.jar should be au... Constantin Asofiei
12:29 PM Feature #1811: implement the AJAX client driver
Ah, I thought this was a local installation of the database. Still, there's something wrong with the built-in functio... Eric Faulhaber
12:04 PM Feature #1811: implement the AJAX client driver
He is using a devsrv01 database instance. We shouldn't need to build pljava from scratch there. Greg Shah
11:44 AM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> _[07/28/2015 18:09:24 MSK] (org.hibernate.engine.jdbc.spi.SqlExceptionHelper:ERROR) ERROR...
Eric Faulhaber
11:35 AM Feature #1811: implement the AJAX client driver
> "use strict" defined in each module's function gives possibility to work with an external non-strict jscript code i... Greg Shah
11:33 AM Feature #1811: implement the AJAX client driver
> failed to load aero.timco.oasis.remote.p2j.OasisServerHookRegistrar
This is not a cause of the problem. This is...
Greg Shah
11:19 AM Feature #1811: implement the AJAX client driver
> Hmmm. This should not be an error that is due to the javascript changes, since it is about database record retriev... Sergey Ivanovskiy
11:06 AM Feature #1811: implement the AJAX client driver
> Code Review Task Branch 1811p Revision 10902
> My only question: wouldn't it be better to implement the "use stric...
Sergey Ivanovskiy
10:53 AM Feature #1811: implement the AJAX client driver
Sergey: In addition to the "use strict" changes you are working on, I'd like you to look into the following problem.
...
Greg Shah
10:40 AM Feature #1811: implement the AJAX client driver
> but if select Service Order Entry, then the target screen isn't displayed and the server logs
>
> [07/28/2015 16...
Greg Shah
10:38 AM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811p Revision 10902
My only question: wouldn't it be better to implement the "use strict"...
Greg Shah
09:50 AM Feature #1811: implement the AJAX client driver
> I don't see any changes checked into task branch 1811p. I realize you have posted a diffs file, but it is better t... Sergey Ivanovskiy
04:02 PM Feature #2252: implement GUI client support
Code Review Task Branch 1796d Revision 10906
@FillInGuiImpl@, @FrameGuiImpl@, @LabelGuiImpl@, @ScrollPaneGuiImpl@,...
Greg Shah
09:39 AM Feature #2252: implement GUI client support
Rebased task branch 1796d from P2J trunk revision 10901 (branch revision 10905).
Constantin Asofiei
01:26 PM Feature #1791: implement dynamic UI support
Rebased task branch 2026a from P2J trunk revision 10901. Stanislav Lomany
07:40 AM Feature #2546: implement combo-box widget in GUI
Task branch @2546b@ for review updated to revision @10912@.
The error message tool for @ComboBoxWidget@ is changed...
Eugenie Lyzenko
08:15 PM Feature #2546: implement combo-box widget in GUI
Task branch @2546b@ for review updated to revision @10911@.
This changes for the following note:
>please test wha...
Eugenie Lyzenko
07:04 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> I probably wasn't clear. Synchronizing @server->client@ works. I already have @MenuContainerWi...
Constantin Asofiei
06:38 AM Feature #1790: implement menu support
I probably wasn't clear. Synchronizing @server->client@ works. I already have @MenuContainerWidget.pushMenuDefinition... Vadim Gindin
06:01 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> Constantin,
>
> I wanted to answer about your changes after fixing of the bug I'm currently wo...
Constantin Asofiei
05:26 AM Feature #1790: implement menu support
Constantin,
I wanted to answer about your changes after fixing of the bug I'm currently working on. I need an advi...
Vadim Gindin

07/27/2015

06:19 PM Feature #2252: implement GUI client support
Rebased task branch 2424b from P2J trunk revision 10901 (branch revision 10910). Hynek Cihlar
06:06 PM Feature #1811: implement the AJAX client driver
> Greg, please review "use strict" changes.
I don't see any changes checked into task branch 1811p. I realize yo...
Greg Shah
05:35 PM Feature #1811: implement the AJAX client driver
Fixed a bug in @rawLine()@ and added polygon support. All of these changes are now integrated back into the 1811o br... Greg Shah
10:30 AM Feature #1811: implement the AJAX client driver
Greg, please review "use strict" changes. The changes are tested for a web chui client of the installed MAJIC with re... Sergey Ivanovskiy
05:55 PM Feature #2422: add features to BROWSE
Just started it. Stanislav Lomany
05:53 PM Feature #2422: add features to BROWSE
Code Review Task Branch 2422b Revision 10912
It looks fine. What is the status of regression testing?
Greg Shah
05:06 PM Feature #2422: add features to BROWSE
Rebased task branch 2422b from P2J trunk revision 10901. Stanislav Lomany
09:28 AM Feature #2422: add features to BROWSE
Code Review Task Branch 2422b Revision 10908
I'm fine with the changes.
Greg Shah
03:43 PM Feature #2546: implement combo-box widget in GUI
Constantin Asofiei wrote:
> Eugenie Lyzenko wrote:
> Please commit the CheckMetricsCb.java file.
Done.
Eugenie Lyzenko
01:28 PM Feature #2546: implement combo-box widget in GUI
Task branch @2546b@ for review updated to revision @10910@.
Some cleanup, code unifying and testing performed. I g...
Eugenie Lyzenko
12:09 PM Feature #2546: implement combo-box widget in GUI
Rebased task branch @2546b@ from P2J trunk revision @10901@, new branch revision is @10909@. Eugenie Lyzenko
11:26 AM Feature #2546: implement combo-box widget in GUI
Task branch @2546b@ for review updated to revision @10908@.
This is the @TAB@ key processing fix. Preparing to reb...
Eugenie Lyzenko
12:52 PM Feature #1790: implement menu support
Vadim, see revision 10919 - the drawing is almost good now. I've added comments where I've made changes - if somethi... Constantin Asofiei
07:04 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> Constantin,
>
> Have a look at @SubMenuGuiImple.draw()@ method and at the second @gd.draw(...
Constantin Asofiei

07/26/2015

04:34 PM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin, @wnd.setMessageText(null, null)@ in @ThinClient.pause...
Hynek Cihlar
01:50 PM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> Constantin, @wnd.setMessageText(null, null)@ in @ThinClient.pause@ removes any existing messag...
Constantin Asofiei
01:42 PM Feature #2252: implement GUI client support
Constantin, @wnd.setMessageText(null, null)@ in @ThinClient.pause@ removes any existing messages from the window mess... Hynek Cihlar
02:09 PM Feature #1790: implement menu support
Constantin,
Have a look at @SubMenuGuiImple.draw()@ method and at the second @gd.draw()@ call in it which draws t...
Vadim Gindin
01:53 PM Feature #2422: add features to BROWSE
Please review task branch 2422b, revision 10908. Not yet merged with the latest baseline. I've changed approach of ha... Stanislav Lomany
01:49 PM Bug #2621: wait-for only works for current-window
The @wait-for window-close of h or close of h@ where @h@ is a window seems to work, but there some issues:
* solved -...
Constantin Asofiei
01:14 PM Bug #2621 (WIP): wait-for only works for current-window
Created branch 2621a from trunk rev 10900. Constantin Asofiei

07/25/2015

04:17 PM Feature #2252: implement GUI client support
Please review branch 1796d, rev 10901 - it includes FRAME- attribute support for all cases of frames: it was simple, ... Constantin Asofiei
03:28 PM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> If is enough to just let @BaseEntity.canSetPixelPositionInChui@ return true by default...
Hynek Cihlar
03:24 PM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek, do you have a testcases for this error, when setting the...
Constantin Asofiei
03:22 PM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek, do you have a testcases for this error, when setting the X or Y attribute in ChU...
Hynek Cihlar
03:13 PM Feature #2252: implement GUI client support
Hynek, do you have a testcases for this error, when setting the X or Y attribute in ChUI:... Constantin Asofiei
02:19 PM Feature #2252: implement GUI client support
Rebased task branch 2424b from P2J trunk revision 10900 (branch revision 10907). Hynek Cihlar
09:24 AM Bug #2624: window clear at procedure end
See #2513 note 62.
If the window doesn't have any explicit pause, instead of terminating, it shows "Procedure comp...
Greg Shah
09:23 AM Bug #2624 (New): window clear at procedure end
Greg Shah
09:21 AM Bug #2623 (Closed): mouse cursor icons for the window edges sometimes don't change back to the st...
Greg Shah
09:21 AM Bug #2622 (Closed): width-pixel/height-pixels can't be assigned during create frame
Greg Shah
09:20 AM Bug #2621: wait-for only works for current-window
WAIT-FOR needs to be fully generalized to any window handle. Greg Shah
09:20 AM Bug #2621 (Closed): wait-for only works for current-window
Greg Shah
09:19 AM Bug #2620: problems when editable size of a field is smaller than the format length
If the editable part doesn't fit in the widget, the cursor goes crazy. Both for ChUI and GUI. There may be addition... Greg Shah
09:18 AM Bug #2620 (Closed): problems when editable size of a field is smaller than the format length
Greg Shah
08:55 AM Feature #1782: implement LAST-EVENT system handle and associated attributes
LAST-EVENT:EVENT-TYPE = "MOUSE" needs to be supported for GUI Greg Shah
08:17 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> I should have been more clear earlier: please implement KEEP-FRAME-Z-ORDER for the window widget ...
Igor Skornyakov
08:12 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
I should have been more clear earlier: please implement KEEP-FRAME-Z-ORDER for the window widget so that your MOVE-TO... Greg Shah
08:14 AM Feature #1801: add some frame options
The following is the remaining work for this task. These need to be implemented for conversion and runtime for FRAME... Greg Shah
07:48 AM Feature #2039 (Rejected): more runtime support for frame options
Greg Shah
09:01 PM Feature #2546: implement combo-box widget in GUI
Task branch @2546b@ for review updated to revision @10907@.
The update has fix for unable to edit new selected ite...
Eugenie Lyzenko

07/24/2015

06:31 PM Feature #1811: implement the AJAX client driver
I've tried a variety of compositing approaches and other means, to disable or bypass the anti-aliasing.
In the end...
Greg Shah
10:01 AM Feature #1811: implement the AJAX client driver
I added major tick marks every 10 pixels and minor tick marks every 2 pixels. Attached is a close-up of the results.... Greg Shah
08:19 AM Feature #1811: implement the AJAX client driver
Yes, I noticed that. But I am guessing that is something unique to the Java2D implementation and is not needed for a... Greg Shah
04:51 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Added conversion support for the WINDOW, WIDGET-ENTER, and WIDGET-LEAVE attributes.
Rebased task branch 2567a from...
Igor Skornyakov
02:58 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
There is a minor incompatibility between p2j and 4GL. If @h@ is a handle with the 'unknown' value then the statement ... Igor Skornyakov
08:29 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Please go ahead with the GUI implementation of all of these features as part of this task. Of co...
Igor Skornyakov
08:23 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> I was unable to figure any noticeable semantics of the MANUAL-HIGHLIGHT attribute in the Ch...
Greg Shah
07:08 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> I'll take both the runtime and conversion support for these. So please don't spend time...
Igor Skornyakov
06:21 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> 2. As per Constantin the fixes which are required for the FRAME-COL, FRAME-ROW, FRAME-X, an...
Constantin Asofiei
04:08 PM Feature #2546: implement combo-box widget in GUI
Rebased task branch @2546b@ from P2J trunk revision @10900@ (new branch revision @10906@). Eugenie Lyzenko
03:09 PM Feature #2546: implement combo-box widget in GUI
Task branch @2546b@ for review updated to revision @10903@.
The small fix in scrollbar location for border-less pa...
Eugenie Lyzenko
01:57 PM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > Eugenie, about @combo_box10.p@, there are some issues:
> > ...
Constantin Asofiei
01:45 PM Feature #2546: implement combo-box widget in GUI
Constantin Asofiei wrote:
> Eugenie, about @combo_box10.p@, there are some issues:
> * @TAB@ pressing in the combo'...
Eugenie Lyzenko
01:35 PM Feature #2546: implement combo-box widget in GUI
Constantin Asofiei wrote:
> * I can't find a way to press the EXIT button via mouse - is this working in rev 10898?
...
Constantin Asofiei
01:34 PM Feature #2546: implement combo-box widget in GUI
Eugenie, about @combo_box10.p@, there are some issues:
* @TAB@ pressing in the combo's fill-in is not switching focu...
Constantin Asofiei
11:44 AM Feature #2546: implement combo-box widget in GUI
Task branch @2546b@ for review updated to revision @10902@.
The fix for @fill-in@ disabled color regression.
Eugenie Lyzenko
03:07 AM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Task branch @2546b@ for review updated to revision @10901@.
Some issues:
# the change in ...
Constantin Asofiei
02:04 AM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Also the standalone program for scaling approach gives OK result with fixed difference that...
Constantin Asofiei
03:01 PM Feature #1790: implement menu support
Vadim Gindin wrote:
> If I'll split sub-menu rectangle by 2 rectangles for a title and for a body, body rectangle wi...
Constantin Asofiei
02:36 PM Feature #1790: implement menu support
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Constantin Asofiei wrote:
> > > Review for branch 1790d, revis...
Vadim Gindin
02:15 PM Feature #1790: implement menu support
Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > Review for branch 1790d, revision 10909:
> > * about mnemonic:...
Constantin Asofiei
01:20 PM Feature #1790: implement menu support
Constantin Asofiei wrote:
> Review for branch 1790d, revision 10909:
> * about mnemonic: what happens if there is m...
Vadim Gindin
07:25 AM Feature #1790: implement menu support
Review for branch 1790d, revision 10909:
* about mnemonic: what happens if there is more than a @&@ char?
* @Menu.g...
Constantin Asofiei
02:43 PM Feature #2252: implement GUI client support
Greg Shah wrote:
> Go ahead and merge to trunk.
Branch 1796c was merged to trunk rev 10900 and archived. Created br...
Constantin Asofiei
02:29 PM Feature #2252: implement GUI client support
Code Review Task Branch 1796c Revision 10901
I am fine with the changes.
Go ahead and merge to trunk.
Greg Shah
02:22 PM Feature #2252: implement GUI client support
Please review branch 1796c rev 10900 and 10901:
* 10900: it fixes the TODO in Frame.postprocess (from note 1063)
* ...
Constantin Asofiei
01:16 PM Feature #2252: implement GUI client support
Eugenie Lyzenko wrote:
> Constantin,
>
> The trunk @10899@ after merging @1796b@ introduces significant regression i...
Constantin Asofiei
12:35 PM Feature #2252: implement GUI client support
Constantin,
The trunk @10899@ after merging @1796b@ introduces significant regression in all my GUI combo-box test...
Eugenie Lyzenko
08:44 AM Feature #2252: implement GUI client support
Created branch 1796c from trunk revision 10899. Constantin Asofiei
08:32 AM Feature #2252: implement GUI client support
Branch 1796b revision 10927 was merged to trunk revision 10899. Branch 1796b was archived. Constantin Asofiei
08:19 AM Feature #1791: implement dynamic UI support
Stanislav, if you are adding support for DOWN, please make sure that FRAME:DOWN is supported too. Constantin Asofiei
08:13 AM Feature #1791: implement dynamic UI support
In @methods_attributes.rules@, please add the new attributes (down and query) to the @load_descriptors@ function inst... Greg Shah
06:39 AM Feature #1791: implement dynamic UI support
For CREATE BROWSE created task branch 2026a from P2J trunk revision 10898. Stanislav Lomany

07/23/2015

06:43 PM Feature #1811: implement the AJAX client driver
Btw. the black-filled rounded Java2D rectangles in canvas_drawing_output_comparison_20150723.jpg don't seem to be sym... Hynek Cihlar
06:15 PM Feature #1811: implement the AJAX client driver
Yes, anti-aliasing is probably a more accurate description than color interpolation. Greg Shah
06:14 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> ...color interpolation (or compositing, I'm not sure)...
anti-aliasing?
Eric Faulhaber
06:09 PM Feature #1811: implement the AJAX client driver
I forgot the latest version of the Java2D samples. Greg Shah
06:08 PM Feature #1811: implement the AJAX client driver
Yesterday and today, I have worked on adding color support and 3D rectangle drawing. As part of that I also resolved... Greg Shah
03:35 PM Feature #1811: implement the AJAX client driver
1811p task branch is created. Branched 10898 revisions Sergey Ivanovskiy
02:54 PM Feature #1811 (WIP): implement the AJAX client driver
> 1811p task branch is created
Please note which trunk revision the branch was created from.
> Greg, what are tests...
Greg Shah
02:26 PM Feature #1811: implement the AJAX client driver
1811p task branch is created on devsrv01 with help of create_task_branch.sh
Greg, what are tests we should perform i...
Sergey Ivanovskiy
12:55 PM Feature #1811: implement the AJAX client driver
The incomplete description of web client and simple server architecture is presented here in order to save time of de... Sergey Ivanovskiy
12:40 PM Feature #1811: implement the AJAX client driver
This article "JavaScript’s Strict Mode and Why You Should Use It" http://cjihrig.com/blog/javascripts-strict-mode-and... Sergey Ivanovskiy
08:08 AM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> To "use strict"; directive in p2j.js module requires to declare p2j variable explicitly b...
Greg Shah
06:27 PM Feature #2546: implement combo-box widget in GUI
Task branch @2546b@ for review updated to revision @10901@.
The update has several minor GUI fixes including clipp...
Eugenie Lyzenko
05:16 PM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > Eugenie, about H009 in FillinGuiImpl: does the FILL-IN in ca...
Constantin Asofiei
05:14 PM Feature #2546: implement combo-box widget in GUI
Constantin Asofiei wrote:
> Eugenie, about H009 in FillinGuiImpl: does the FILL-IN in case of combo-box show a gray ...
Eugenie Lyzenko
04:30 PM Feature #2546: implement combo-box widget in GUI
Eugenie, about H009 in FillinGuiImpl: does the FILL-IN in case of combo-box show a gray foreground when disabled? Bec... Constantin Asofiei
05:55 AM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Some suggestions:
>
> 1. What is the "base" unit in GUI mode?
The base unit in GUI is t...
Constantin Asofiei
04:37 AM Feature #2546: implement combo-box widget in GUI
Some suggestions:
1. What is the "base" unit in GUI mode? Correct me if I'm wrong but looks like it is still @char...
Eugenie Lyzenko
03:51 AM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> >Have you proved the formula using the captured metrics?
>
> Constantin, let's clarify t...
Constantin Asofiei
05:44 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
I was unable to figure any noticeable semantics of the MANUAL-HIGHLIGHT attribute in the ChUI.
About the remaining...
Igor Skornyakov
04:06 PM Feature #1790: implement menu support
Please review the code. Current revision is 10909. Vadim Gindin
03:50 PM Feature #1791: implement dynamic UI support
Please change the branch name to 2026a. That way we can match up your specific changes with the child task. Greg Shah
03:39 PM Feature #1791: implement dynamic UI support
For CREATE BROWSE created task branch 1791a from P2J trunk revision 10898. Stanislav Lomany
03:20 PM Feature #2252: implement GUI client support
Code Review Task Branch 1796b Revision 10926
1. Should @GenericWidget.finishConfigProcessing()@ be @protected@ ins...
Greg Shah
02:55 PM Feature #2252: implement GUI client support
I'm OK with the update. There is a regression in 2422b and, besides, there is conflicting change in DOWN processing, ... Stanislav Lomany
01:36 PM Feature #2252: implement GUI client support
Please review branch 1796b revision 10926. It adds support for drawing down frames in GUI, fixes note 1068 and some ... Constantin Asofiei
12:33 PM Feature #2252: implement GUI client support
Greg Shah wrote:
> For a future improvement: should we implement an empty @finishConfigProcessing()@ in @GenericWidg...
Constantin Asofiei
11:28 AM Feature #2252: implement GUI client support
Greg Shah wrote:
> Are the issues documented in #2567 notes 12 (CA - #1796) and 19 (CA - #1796) already addressed in...
Hynek Cihlar
11:23 AM Feature #2252: implement GUI client support
Are the issues documented in #2567 notes 12 (CA - #1796) and 19 (CA - #1796) already addressed in 1796b?
Hynek: Ar...
Greg Shah
11:16 AM Feature #2252: implement GUI client support
In regard to the #1796 remaining items: anything left for later should have its own task created and linked here as a... Greg Shah
10:57 AM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek, beside this there are some frame size issues: the frame size is not computed corr...
Hynek Cihlar
10:01 AM Feature #2252: implement GUI client support
Greg Shah wrote:
> Constantin: what work is left for #1796?
The next issues I have on the list are these (in order if...
Constantin Asofiei
09:15 AM Feature #2252: implement GUI client support
Code Review Task Branch 1796b Revision 10923
Interesting, I didn't realize that the @num + date@ form of the @+@ o...
Greg Shah
08:17 AM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Rebased task branch 1796b from P2J trunk revision 10898 (branch revision 10923).
>
> ...
Constantin Asofiei
01:25 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
This task is for full implementation of the GUI widget implementation for RADIO-SET. Both static and dynamic usage is... Greg Shah
01:08 PM Feature #2614 (Closed): implement GUI runtime support for RADIO-SET widget
Greg Shah
01:09 PM Bug #2613: improve performance of ScreenBitmap.canDraw (and of its callers)
In GUI, @ScreenBitmap.canDraw@ (and its callers, @getVerticalFragments@ and @getHorizontalFragments@) are used intens... Constantin Asofiei
01:04 PM Bug #2613 (New): improve performance of ScreenBitmap.canDraw (and of its callers)
Constantin Asofiei
12:25 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
This task is for full implementation of the GUI widget implementation for SLIDER. Both static and dynamic usage is ne... Greg Shah
12:19 PM Feature #2612 (Closed): implement GUI conversion and runtime support for the SLIDER widget
Greg Shah
08:03 AM Feature #2422: add features to BROWSE
Code Review Task Branch 2422b Revision 10907
Everything looks good. If this passes testing, please check it in an...
Greg Shah

07/22/2015

06:33 PM Feature #2546: implement combo-box widget in GUI
>Have you proved the formula using the captured metrics?
Constantin, let's clarify this point. Is there the approa...
Eugenie Lyzenko
05:00 PM Feature #2546: implement combo-box widget in GUI
Task branch @2546b@ for review updated to revision @10900@.
Fixed the @WIDTH-PIXELS@ attribute getting issue.
>...
Eugenie Lyzenko
03:37 PM Feature #2546: implement combo-box widget in GUI
Eugenie, please check the @uast/demo/movie-ratings-static.p@ - the combo does not behave OK, the drop-down list is no... Constantin Asofiei
09:20 AM Feature #2546: implement combo-box widget in GUI
>No, other widgets work fine. The problem is with the combo-box implementation.
Yes, you are right. And this is stra...
Eugenie Lyzenko
04:23 AM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Task branch @2546b@ for review updated to revision @10899@.
>
> This is the alternative ...
Constantin Asofiei
05:34 PM Feature #2422: add features to BROWSE
Greg Shah wrote:
> Code Review Task Branch 2422b Revision 10906
>
> Eric: please review the query-related changes...
Eric Faulhaber
05:12 PM Feature #2422: add features to BROWSE
You should start regression testing with the 10906 revision. We will continue discussing the browse-column support o... Greg Shah
02:05 PM Feature #2422: add features to BROWSE
The 11.x documentation clearly states otherwise:... Greg Shah
01:34 PM Feature #2422: add features to BROWSE
I'm not sure how to enable COMBO-BOX in browse. Even for GUI. ... Stanislav Lomany
12:40 PM Feature #2422: add features to BROWSE
Did you test with COMBO-BOX as a browse column? The error message may have only been formatted that way because the ... Greg Shah
12:35 PM Feature #2422: add features to BROWSE
As far as I tested, they match. Error message for browse column "Unable to assign UNKNOWN value to attribute MODIFIED... Stanislav Lomany
12:30 PM Feature #2422: add features to BROWSE
Code Review Task Branch 2422b Revision 10906
Eric: please review the query-related changes.
My only question: Does ...
Greg Shah
11:44 AM Feature #2422: add features to BROWSE
Rebased task branch 2422b from P2J trunk revision 10898.
Please review task branch 2422b, revision 10906.
Stanislav Lomany
03:42 PM Bug #2611: problems in UNDERLINE support for ChUI - stream/redirected mode
For a start, see the @uast/frame_layout/redirected_underline.p@ test - the UNDERLINE (when it proceeds a DISPLAY, DOW... Constantin Asofiei
03:38 PM Bug #2611 (New): problems in UNDERLINE support for ChUI - stream/redirected mode
Constantin Asofiei
02:45 PM Feature #2252: implement GUI client support
Rebased task branch 1796b from P2J trunk revision 10898 (branch revision 10923).
Please review branch 1796b, revis...
Constantin Asofiei
01:20 PM Feature #1811: implement the AJAX client driver
To "use strict"; directive in p2j.js module requires to declare p2j variable explicitly by
var p2j = (function()...)
Sergey Ivanovskiy
12:10 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> As far as I understand it, using this option should cause the widget to draw without a highlight....
Igor Skornyakov
12:07 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
As far as I understand it, using this option should cause the widget to draw without a highlight. The programmer wou... Greg Shah
11:43 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg,
I've implemented the conversion and setters/getters for the MANUAL-HIGHLIGHT attribute, but the only thing I'v...
Igor Skornyakov

07/21/2015

06:31 PM Feature #2546: implement combo-box widget in GUI
The picture... Eugenie Lyzenko
06:30 PM Feature #2546: implement combo-box widget in GUI
Task branch @2546b@ for review updated to revision @10899@.
This is the alternative scaling implementation for com...
Eugenie Lyzenko
06:20 PM Feature #1811: implement the AJAX client driver
Attached are some samples I am using to get the drawing operations in Javascript to match the Java2D operations that ... Greg Shah
06:15 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Rebased task branch 2567a from P2J trunk revision 10898 (new branch revision 10909). Igor Skornyakov
02:29 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Added INDEX and MANUAL-HIGHLIGHT conversion support. Commited to branch 2567a. New revno 10907
Igor Skornyakov
10:54 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Added TAB-STOP attribute runtime support. Commited to branch 2567a. New revno 10906.
This took some time because t...
Igor Skornyakov
10:12 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
I've noticed an incompatilityy between 2GK and p2j. When running the attached program with 4GL all 3 widgets (@a@, @f... Igor Skornyakov
05:27 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
test please ignore Igor Skornyakov

07/20/2015

06:05 PM Feature #2252: implement GUI client support
Rebased task branch 2424b from P2J trunk revision 10897 (branch revision 10898). Hynek Cihlar
05:13 PM Feature #2252: implement GUI client support
Rebased task branch 1796b from P2J trunk revision 10897 (branch revision 10916).
Constantin Asofiei
05:49 PM Feature #2546: implement combo-box widget in GUI
Task branch @2546b@ for review updated to revision @10898@.
The fixes including:
1. Fix for wrong initial selecti...
Eugenie Lyzenko
10:41 AM Feature #2546: implement combo-box widget in GUI
Created task branch @2546b@ from P2J trunk revision @10897@. Eugenie Lyzenko
10:41 AM Feature #2546: implement combo-box widget in GUI
The branch @2546a@ has been merged and committed to trunk as revision @10897@. Archived. Eugenie Lyzenko
10:28 AM Feature #2546: implement combo-box widget in GUI
>Also, somethign else: P2J automatically selects first element in this test, while 4GL does not...
For this issue,...
Eugenie Lyzenko
08:14 AM Feature #2546: implement combo-box widget in GUI
Please merge task branch 2546a to trunk, commit and send the notification email. Greg Shah
05:17 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
About the FRAME-COL/ROW/X/Y coordinate attributes: the current BaseConfig.column/row/x/y fields are actually for the ... Constantin Asofiei
03:02 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> > Is the implementation of the runtime semantics of the TAB-STOP attribute in the scope of this t...
Igor Skornyakov
03:00 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
> Is the implementation of the runtime semantics of the TAB-STOP attribute in the scope of this task?
Yes.
Greg Shah
01:34 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Added NO-TAB-STOP option and TAB-STOP attribute conversion support. Commited to branch 2567a. New revno 10905.
Gre...
Igor Skornyakov
11:45 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Added CONTEXT-HELP-ID conversion and runtime support. Commited to branch 2567a. New revno 10904 Igor Skornyakov
11:05 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Added DEBLANK conversion and runtime support. Commited to branch 2567a. New revno 10903 Igor Skornyakov
07:23 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Added BLANK conversion and runtime support. Commited to branch 2567a. New revno 10902 Igor Skornyakov
05:17 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Added PASSWORD-FIELD runtime support. Commited to branch 2567a. New revno 10901 Igor Skornyakov
03:45 PM Feature #1790: implement menu support
Vadim Gindin wrote:
> 1. What about the case of letters? Note, that "PgDn" is shown in the specified testcase, but D...
Constantin Asofiei
03:29 PM Feature #1790: implement menu support
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Here it is
> >
> > [...]
> >
> > Have a look how the menu...
Vadim Gindin
03:09 PM Feature #1790: implement menu support
Vadim Gindin wrote:
> Here it is
>
> [...]
>
> Have a look how the menu-item "Mi1 item" looks. It's accelerato...
Constantin Asofiei
02:32 PM Feature #1790: implement menu support
Here it is... Vadim Gindin
02:16 PM Feature #1790: implement menu support
Greg Shah wrote:
> Greg Shah wrote:
> > > It is a "PAGE-DOWN" itself, but for GUI, there are possible several labe...
Constantin Asofiei
10:11 AM Feature #1790: implement menu support
Greg Shah wrote:
> > It is a "PAGE-DOWN" itself, but for GUI, there are possible several labels: "PAGE-DOWN", "PGDN...
Greg Shah
10:04 AM Feature #1790: implement menu support
> It is a "PAGE-DOWN" itself, but for GUI, there are possible several labels: "PAGE-DOWN", "PGDN", "NEXT-PAGE", "NEX... Greg Shah
10:22 AM Feature #2422: add features to BROWSE
It is OK to base your work on the unoptimized/current approach, but please:
1. Add a comment to the @ConfigManager...
Greg Shah
10:19 AM Feature #2422: add features to BROWSE
That is interesting:... Stanislav Lomany
09:54 AM Feature #2422: add features to BROWSE
> # Widget re-creation resets its backup configuration. Backup configuration should match the previous state sent to ... Greg Shah
09:19 AM Feature #2422: add features to BROWSE
Rebased task branch 2422b from P2J trunk revision 10896. Stanislav Lomany
05:24 AM Feature #2422: add features to BROWSE
Greg, for editing cells we have a single @FillInWidget@ for each column. Its configuration is send to the client and ... Stanislav Lomany

07/19/2015

06:03 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Added PASSWORD-FIELD conversion support. Commited to branch 2567a. New revno 10900 Igor Skornyakov
03:15 PM Feature #1790: implement menu support
It seems, that GUI menu widgets use only system colors. Documentation says that it is possible to set bgcolor and fgc... Vadim Gindin

07/18/2015

11:46 AM Feature #2546: implement combo-box widget in GUI
Greg,
According to handbook rules I'm waiting for approval confirmation to start merging the branch into the trunk.
Eugenie Lyzenko
11:34 AM Feature #2546: implement combo-box widget in GUI
Testing completed without regressions. Had to start @CTRL-C@ 3-way tests in a separate session. The results are in @2... Eugenie Lyzenko
09:20 AM Feature #2546: implement combo-box widget in GUI
The main part for @2546a@ finished without regressions, running the @CTRL-C@ one. Eugenie Lyzenko
09:20 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Perhaps it makes sense to work on other attributes first? That would give Constantin time to fix...
Igor Skornyakov
08:21 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> Hynek Cihlar wrote:
> > This is again a bug in @ZeroColumnLayout@. Although server logic c...
Greg Shah
07:57 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Hynek Cihlar wrote:
> This is again a bug in @ZeroColumnLayout@. Although server logic correctly assigns the widget'...
Igor Skornyakov
07:40 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> I've used the attached test to understand the correlation between ROW/COLUMN and FRAME-ROW/...
Hynek Cihlar
05:35 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
I've used the attached test to understand the correlation between ROW/COLUMN and FRAME-ROW/FRAME-COL attributes. It s... Igor Skornyakov

07/17/2015

04:52 PM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> >The remaining task is computing the combo's dimension as in 4GL. Consider the test at note...
Constantin Asofiei
02:06 PM Feature #2546: implement combo-box widget in GUI
Rebased task branch @2546a@ from P2J trunk revision @10897@ (new branch revision @10908@ - a few words added in comme... Eugenie Lyzenko
12:23 PM Feature #2546: implement combo-box widget in GUI
>The remaining task is computing the combo's dimension as in 4GL. Consider the test at note 130 with a font8 set to T... Eugenie Lyzenko
08:59 AM Feature #2546: implement combo-box widget in GUI
Greg Shah wrote:
> > if all issues (except dimension) are fixed, please get it into regression testing and release i...
Constantin Asofiei
08:39 AM Feature #2546: implement combo-box widget in GUI
> if all issues (except dimension) are fixed, please get it into regression testing and release it
Constantin: he ...
Greg Shah
06:51 AM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Task branch @2546a@ for review updated to revision @10907@.
>
> The update has improved ...
Constantin Asofiei
09:04 PM Feature #2546: implement combo-box widget in GUI
Task branch @2546a@ for review updated to revision @10907@.
The update has improved implementation for width scali...
Eugenie Lyzenko
04:39 PM Feature #2252: implement GUI client support
Rebased task branch 1796b from P2J trunk revision 10896 (branch revision 10915). Constantin Asofiei
04:30 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > More, there is another issue: in 4GL, widget coordinates are re...
Constantin Asofiei
12:12 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Rebased task branch 2567a from P2J trunk revision 10896 (new branch revision 10898). Igor Skornyakov
08:52 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> More, there is another issue: in 4GL, widget coordinates are relative to the parent. Bu...
Hynek Cihlar
06:15 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> >
> > - a bug in @ZeroLayoutColumn@ positioning the selection-list wid...
Constantin Asofiei
11:43 AM Feature #2563 (Closed): implement GUI EDITOR widget
Greg Shah
11:36 AM Feature #2563: implement GUI EDITOR widget
Branch 2563b was merged to trunk as revno 10896 then it was archived. Constantin Asofiei
06:22 AM Feature #2563: implement GUI EDITOR widget
Code Review Task Branch 2563b, Revision 10907
I'm fine with the changes. If it passes testing, please merge/commit...
Greg Shah
05:01 AM Feature #2563: implement GUI EDITOR widget
Please review task branch 2563b, revision 10907.
I'm running regression testing one more time, to clear some false...
Constantin Asofiei

07/16/2015

01:57 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Hynek Cihlar wrote:
> Igor, I fixed this as part of 2424b.
Thank you Hynek.
Igor Skornyakov
01:53 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Hynek Cihlar wrote:
>
> - a bug in @ZeroLayoutColumn@ positioning the selection-list widget at @ROW@ 3 instead of 1. ...
Hynek Cihlar
11:28 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Igor Skornyakov wrote:
> > I've noticed that X and Y attributes' p2j support is not compatible wit...
Hynek Cihlar
10:02 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> I've noticed that X and Y attributes' p2j support is not compatible with 4GL. In the attach...
Greg Shah
09:54 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
I've noticed that X and Y attributes' p2j support is not compatible with 4GL. In the attached test the values are (1,... Igor Skornyakov
10:08 AM Feature #2546: implement combo-box widget in GUI
> Some consideration for introducing the push screen definition lock to discuss.
> ...
Constantin will handle the...
Greg Shah
08:20 PM Feature #2546: implement combo-box widget in GUI
Task branch @2546a@ for review updated to revision @10906@.
In this update:
1. According to my previous suggest t...
Eugenie Lyzenko
09:09 AM Feature #2422: add features to BROWSE
Stanislav Lomany wrote:
> You may say that at the point of widget registration its state should already be synchroni...
Hynek Cihlar
08:26 AM Feature #2422: add features to BROWSE
Guys, about "transparent" data sending with AspectJ. P2J code calculates differences between "active (current) config... Stanislav Lomany
03:40 AM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> >
> > Don't consider it as a suggestion but if JWindow is replaced ...
Sergey Ivanovskiy

07/15/2015

03:47 PM Feature #2546: implement combo-box widget in GUI
Some consideration for introducing the push screen definition lock to discuss.
I would suggest another way of impl...
Eugenie Lyzenko
01:59 PM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Can we defer all screen definition pushing until first @GenericFrame.enable()@ call? Or oth...
Constantin Asofiei
03:06 PM Feature #1811: implement the AJAX client driver
Hynek Cihlar wrote:
> @ContentPane@ already contains a call to @window.dispose()@ so it should be enough to make sur...
Greg Shah
12:50 PM Feature #1811: implement the AJAX client driver
@ContentPane@ already contains a call to @window.dispose()@ so it should be enough to make sure @ContentPane.quit()@ ... Hynek Cihlar
12:46 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Some questions related to window creation/destruction:
>
> 1. What is the purpose of the title pa...
Hynek Cihlar
12:29 PM Feature #1811: implement the AJAX client driver
Some questions related to window creation/destruction:
1. What is the purpose of the title passed to the @JWindow@...
Greg Shah
01:50 PM Feature #2252: implement GUI client support
Rebased task branch 1796b from P2J trunk revision 10895 (branch revision 10914). Constantin Asofiei
08:42 AM Feature #2252: implement GUI client support
Sergey Ivanovskiy wrote:
>
> Don't consider it as a suggestion but if JWindow is replaced by JDialog, then a deskt...
Hynek Cihlar
06:12 AM Feature #2252: implement GUI client support
Greg, Hynek
What is the reason to implement a JFrame for any normal 4GL window and a JWindow for alert-boxes/dialog...
Sergey Ivanovskiy
12:16 PM Feature #1790: implement menu support
> So, the easiest way is to emit new Object[] instead of new handle[] for the value of second parameter of addEvent.
...
Greg Shah
04:58 AM Feature #1790: implement menu support
I faced with the following conversion problem. I have a testcase with different triggers defined and here are 2 of th... Vadim Gindin
08:17 AM Feature #2422: add features to BROWSE
Please implement both. Greg Shah
07:52 AM Feature #2422: add features to BROWSE
Greg, should I implement @browse:MODIFIED@ attribute or @column:MODIFIED@ too? I ask because they have completely dif... Stanislav Lomany
07:54 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Hello Eugenie.
I've introduced the internal ids exactly for the correct restoring of the selected item. I've tested...
Igor Skornyakov
07:36 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> Eugenie.
> From the other side I've realized now that if one replaces LIST-ITEMS/LISTS-ITE...
Eugenie Lyzenko
05:34 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Eugenie.
The test seems running OK with my version of the code and looking at your version of the @ComboBoxWidget@ I...
Igor Skornyakov
02:28 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Eugenie Lyzenko wrote:
> @uast/combo_box/combo_box12_3.p@ from testcases bzr repo. I guess you will need the GUI com...
Igor Skornyakov

07/14/2015

07:49 PM Feature #2546: implement combo-box widget in GUI
Task branch @2546a@ for review updated to revision @10905@.
This small update fixes the dynamic combo-box behavior...
Eugenie Lyzenko
07:46 PM Feature #2546: implement combo-box widget in GUI
Can we defer all screen definition pushing until first @GenericFrame.enable()@ call? Or other frame related call that... Eugenie Lyzenko
04:41 PM Feature #2546: implement combo-box widget in GUI
> To cover the case of setting the FRAME attr in and outside the CREATE ... ASSIGN clause, we can:
> ...
Yes, g...
Greg Shah
04:38 PM Feature #2546: implement combo-box widget in GUI
Greg Shah wrote:
> We should be able to bypass pushing screen definitions until the frame is set.
Yes, this is alr...
Constantin Asofiei
04:22 PM Feature #2546: implement combo-box widget in GUI
I should say this a different way.
I understand that we can't depend on there being a FRAME defined in the ASSIGN....
Greg Shah
04:13 PM Feature #2546 (WIP): implement combo-box widget in GUI
Wouldn't it be better to always bracket @CREATE WINDOW@ assign by setting @batch@ mode on in @GenericFrame@ and then ... Greg Shah
04:03 PM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Task branch @2546a@ for review updated to revision @10903@.
I'm OK with these changes.
Constantin Asofiei
04:00 PM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Task branch @2546a@ for review updated to revision @10904@.
Consider that the widget's FRA...
Constantin Asofiei
09:19 PM Feature #2546: implement combo-box widget in GUI
Task branch @2546a@ for review updated to revision @10904@.
This update adds batch mode lock when widget attribute...
Eugenie Lyzenko
06:30 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
@uast/combo_box/combo_box12_3.p@ from testcases bzr repo. I guess you will need the GUI combo-box recent code too(bra... Eugenie Lyzenko
05:35 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Eugenie Lyzenko wrote:
> The bug has been found during testing combo-box widget with setting attribute @LIST-ITEMS@ ...
Igor Skornyakov
05:27 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
The bug has been found during testing combo-box widget with setting attribute @LIST-ITEMS@ outside the @define ... vi... Eugenie Lyzenko
04:52 PM Feature #2563: implement GUI EDITOR widget
Code Review Task Branch 2563b, Revision 10903
I'm fine with the changes. If it passes testing, please merge/commi...
Greg Shah
03:41 PM Feature #2563: implement GUI EDITOR widget
Please review task branch 2563b, revision 10903.
Revision 10901 is currently in runtime testing. Revisions 10902/...
Constantin Asofiei
04:43 PM Feature #2252: implement GUI client support
Greg Shah wrote:
> >> On the other hand, it doesn't seem too hard to implement. Are we really saving much time to av...
Hynek Cihlar
04:38 PM Feature #2252: implement GUI client support
>> On the other hand, it doesn't seem too hard to implement. Are we really saving much time to avoid this?
>
> To i...
Greg Shah
03:42 PM Feature #2252: implement GUI client support
Greg Shah wrote:
> > The window is moved to negative Y so that the bottom of the window is visible on the screen.
>...
Hynek Cihlar
03:15 PM Feature #2252: implement GUI client support
> The window is moved to negative Y so that the bottom of the window is visible on the screen.
Is this implicitly ...
Greg Shah
02:45 PM Feature #2252: implement GUI client support
It seems that 4GL internally limits coordinates to smaller values than allowed in positional attributes (X, Y).
He...
Hynek Cihlar
08:17 AM Feature #2252: implement GUI client support
The value of 39.48 seems to be the height of the display less window decorations. The value indeed copies screen reso... Hynek Cihlar
08:05 AM Feature #2252: implement GUI client support
I am guessing that when converted to a pixel value (based on the default font's metrics), that (at least some of) the... Greg Shah
02:37 PM Feature #1811: implement the AJAX client driver
I am working on the new window and new child window support for the web client. In the current implementation, we us... Greg Shah
09:17 AM Feature #1811: implement the AJAX client driver
Rebased task branch 1811o from P2J trunk revision 10895. Greg Shah
08:29 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Tha task branch 2567a has been created. First updates are committed to the branch, revno: 10896 Igor Skornyakov

07/13/2015

06:27 PM Feature #2252: implement GUI client support
For #2424, please assess whether any of these should be replicated in P2J.
*Case 1*...
Hynek Cihlar
03:17 PM Feature #2252: implement GUI client support
Greg Shah wrote:
> Also, it seems to me that now is the time to go ahead and implement a cleaner set of classes for ...
Hynek Cihlar
02:47 PM Feature #2252: implement GUI client support
OK, please go ahead and implement a compatible max sizing algorithm.
Also, it seems to me that now is the time to ...
Greg Shah
02:09 PM Feature #2252: implement GUI client support
Greg Shah wrote:
> > The question is how far should we go to replicate this?
>
> I'd like to see the algorithm be...
Hynek Cihlar
11:13 AM Feature #2252: implement GUI client support
> A way out of this could be an interactive calibration process that would provide these (and possibly other) dynamic... Greg Shah
10:59 AM Feature #2252: implement GUI client support
Greg Shah wrote:
> > A Windows theme may differ with Windows versions.
>
> Yes, but for us it is going to be some...
Hynek Cihlar
10:32 AM Feature #2252: implement GUI client support
> The window border size is however hardcoded to a constant value.
I expect that we will allow this to be configur...
Greg Shah
10:18 AM Feature #2252: implement GUI client support
Greg Shah wrote:
> The window decoration dimensions are values that we hard code in P2J based on the chosen Windows ...
Hynek Cihlar
09:43 AM Feature #2252: implement GUI client support
> It seems that 4GL calculates these maximum values based on window decorations - i.e. window caption size and border... Greg Shah
09:28 AM Feature #2252: implement GUI client support
This relates to #2424.
I identified a problem related to the max allowed window size. In GUI, a window widget trun...
Hynek Cihlar
05:38 PM Feature #2546: implement combo-box widget in GUI
Task branch @2546a@ for review updated to revision @10903@.
This update includes the changes required to complete ...
Eugenie Lyzenko
01:44 PM Feature #2546: implement combo-box widget in GUI
More finding for @MAX-CHARS@ in 4GL @COMBO-BOX@.
The default value is @0@, not @255@, like as the reaction to sett...
Eugenie Lyzenko
01:25 PM Feature #2546: implement combo-box widget in GUI
For @MAX-CHARS@ implementation in @COMBO-BOX@:
In all modes, the attribute is ignoring, @MAX-CHAR@ maximum value i...
Eugenie Lyzenko
12:02 PM Feature #2546: implement combo-box widget in GUI
Greg Shah wrote:
> Eugenie: the only attribute that needs implementation is @MAX-CHARS@. That was something that co...
Constantin Asofiei
08:46 AM Feature #2546: implement combo-box widget in GUI
Try using @createJavaAst()@ instead of @createPeerAst()@. Greg Shah
05:20 PM Feature #1811: implement the AJAX client driver
A first pass implementation of clipboard support is checked in to task branch 1811o. The rest of the work will be de... Greg Shah
01:07 PM Feature #1790: implement menu support
As Constantin and I have noted multiple times:
> the MenuContainerWidget needs to inherit from BaseEntity.
Sea...
Greg Shah
12:18 PM Feature #1790: implement menu support
When I refactored menu classes I removed unneeded fields from classes and those setters, that appear in config classe... Vadim Gindin
09:33 AM Feature #1790: implement menu support
This is a problem, but do not work on it now. We will leave this as a TODO.
We also have this same problem with t...
Greg Shah
12:25 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Constantin Asofiei wrote:
> I meant what testcase did you use to check the SET-SELECTED method?
I think it was the ...
Igor Skornyakov
12:23 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Igor, can you point me to a testcase which covers your H046 ...
Constantin Asofiei
12:16 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Constantin Asofiei wrote:
> Igor, can you point me to a testcase which covers your H046 change in Editor.java? This ...
Igor Skornyakov
12:07 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor, can you point me to a testcase which covers your H046 change in Editor.java? This no longer works with the #256... Constantin Asofiei
12:01 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> No, you are not wrong. I'm just confirming my understanding that the only remaining functionalit...
Constantin Asofiei
12:05 PM Feature #2422: add features to BROWSE
> So considering this complexity and that it is not likely to be used, I suggest to add it to the quirks list.
OK.
Greg Shah
11:51 AM Feature #2422: add features to BROWSE
Greg, about @REFRESHABLE@. Its typical use case is to turn it off - reposition - turn it on. However there is a poten... Stanislav Lomany
11:59 AM Feature #2563: implement GUI EDITOR widget
Rebased task branch 2563b from P2J trunk revision 10895 (new branch revision 10899).
There is a compile problem, n...
Constantin Asofiei

07/10/2015

06:29 PM Feature #1790: implement menu support
I faced with the difficulty. When nested submenus exceed window size (width or height) they do not shrink to window s... Vadim Gindin
05:44 PM Feature #2422: add features to BROWSE
At this point there are the following issues left:
# In 4GL repositioned row is <= DOWN value. DOWN value is calcula...
Stanislav Lomany
05:38 PM Feature #2546: implement combo-box widget in GUI
I put the following rule into @convert/ui_statements.rules@(end of @ascent-rules@ section):... Eugenie Lyzenko
01:29 PM Feature #2546: implement combo-box widget in GUI
> We need to generate special marker indicating the last internal assignment in CREATE WIDGET... may be.
Correct. ...
Greg Shah
12:10 PM Feature #2546: implement combo-box widget in GUI
Rebased task branch @2546a@ from P2J trunk revision @10895@, new branch revision is @10902@. Eugenie Lyzenko
12:09 PM Feature #2546: implement combo-box widget in GUI
>For static frames, we handle this in GenericFrame.setupFrame(). In other words, in GenericFrame.pushScreenDefinition... Eugenie Lyzenko
11:39 AM Feature #2546: implement combo-box widget in GUI
> In P2J every assignment inside create widget... causes the pushScreenDefinition() call and almost everything after ... Greg Shah
11:19 AM Feature #2546: implement combo-box widget in GUI
>Is this different from how the 4GL works?
Yes in 4GL there is no such condition, INNER-LINES setting can be after...
Eugenie Lyzenko
10:34 AM Feature #2546: implement combo-box widget in GUI
> For dynamic widget we have to place INNER-LINES setting before VISIBLE and SENSITIVE to have proper scrollbar. This... Greg Shah
10:33 AM Feature #2546: implement combo-box widget in GUI
The testcase set updated to rev @1290@. The only change is in @combo_box15.p@. For dynamic widget we have to place @I... Eugenie Lyzenko
09:38 AM Feature #2546: implement combo-box widget in GUI
Greg Shah wrote:
> Eugenie: the only attribute that needs implementation is @MAX-CHARS@. That was something that co...
Eugenie Lyzenko
09:29 AM Feature #2546: implement combo-box widget in GUI
Eugenie: the only attribute that needs implementation is @MAX-CHARS@. That was something that could not be done in #... Greg Shah
08:58 AM Feature #2546: implement combo-box widget in GUI
> I think 4GL makes the row reposition at runtime on the layout stage so the screen coordinate for combo_box15.p is ... Greg Shah
08:54 AM Feature #2546: implement combo-box widget in GUI
> This is the list I see.
>
> ...
Yes, I know that we have many attributes and methods that are not yet finishe...
Greg Shah
08:04 AM Feature #2546: implement combo-box widget in GUI
>I think you are correct - P2J uses the ROW relative as to the top frame border, while 4GL uses the ROW as relative t... Eugenie Lyzenko
07:54 AM Feature #2546: implement combo-box widget in GUI
Constantin Asofiei wrote:
> Please commit the tests you are using for the screens you posted...
Done. Committed...
Eugenie Lyzenko
11:54 PM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> I think this is not @combo-box@ specific issue, but all dynamic widgets with explicit coord...
Constantin Asofiei
11:35 PM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> The only issue I see for now is the proper location in case we have NOT side labeled widget...
Constantin Asofiei
01:49 PM Bug #2607: The java generated code isn't compiled due to there is some implicit scoping that goes...
The following exceptions occur if the conversion 4GL->Java is applied to the attached addressApp.p
compile:
[ja...
Sergey Ivanovskiy
01:39 PM Bug #2607 (New): The java generated code isn't compiled due to there is some implicit scoping tha...
Sergey Ivanovskiy
10:19 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
This task is for full implementation of the GUI widget implementation for SELECTION-LIST. Both static and dynamic us... Greg Shah
10:16 AM Feature #2606 (Closed): implement GUI runtime support for SELECTION-LIST
Greg Shah
09:27 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> No, you are not wrong. I'm just confirming my understanding that the only remaining functionalit...
Igor Skornyakov
09:25 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
No, you are not wrong. I'm just confirming my understanding that the only remaining functionality from this task is ... Greg Shah
09:22 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> Igor: is the only feature left for this task the MAX-CHARS GUI support?
Greg. In my understand...
Igor Skornyakov
09:18 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor: is the only feature left for this task the MAX-CHARS GUI support? Greg Shah
09:01 AM Feature #2534 (Closed): methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah
09:02 AM Feature #2486 (Closed): enhance editor functionality
Greg Shah

07/09/2015

06:54 PM Feature #2546: implement combo-box widget in GUI
>1. Check and implement if required the possibility to handle not character data by combo-box. I mean if the combo-bo... Eugenie Lyzenko
06:49 PM Feature #2546: implement combo-box widget in GUI
Greg Shah wrote:
> Can you let me know what you are thinking here? #2534 already has quite a few changes for combo-...
Eugenie Lyzenko
05:43 PM Feature #2546: implement combo-box widget in GUI
> 2. Verify and implement all attribute and method for both static and dynamic combo-box.
Can you let me know what...
Greg Shah
03:13 PM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Task branch @2546a@ for review updated to revision @10900@.
I'm OK with the changes.
Constantin Asofiei
12:51 PM Feature #2546: implement combo-box widget in GUI
Task branch @2546a@ for review updated to revision @10900@.
The updates included change for drop-down button reloc...
Eugenie Lyzenko
05:31 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Code Review ias_upd20150709b.zip
I'm good with the changes.
Please commit and distribute this update. Well done!
Greg Shah
05:23 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
After two runs the intersection of the failed tests' sets is @tc_job_002@ only. Igor Skornyakov
09:36 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
> BTW: the problem was with the extra pushScreenDefinition which overrides dynamic header. It seems a little bit frag... Greg Shah
09:25 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> I'm fine with the changes.
>
> The only thing I need you to change is that you should not have...
Igor Skornyakov
09:12 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Code Review ias_upd20150709a.zip
I'm fine with the changes.
The only thing I need you to change is that you should ...
Greg Shah
05:18 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
After a fix the test passed OK in a manual run. Full regression restarted. Igor Skornyakov
09:58 AM Bug #2605: pushScreenDefinition overrides dynamic header of the frame
The problem was revealed in the regression testing of the #2534. In the changes the conditional invocation of the @pu... Igor Skornyakov
09:46 AM Bug #2605 (New): pushScreenDefinition overrides dynamic header of the frame
Igor Skornyakov

07/08/2015

05:46 PM Feature #2546: implement combo-box widget in GUI
Task branch @2546a@ for review updated to revision @10899@.
The enhancements has been made to mouse event handling...
Eugenie Lyzenko
09:44 AM Feature #2252: implement GUI client support
CUT/COPY/PASTE have alternative key mappings in Windows. I think we need to add those to @GuiKeyboard.standardKeyFun... Greg Shah

07/07/2015

07:54 PM Feature #2546: implement combo-box widget in GUI
Please review task branch @2546a@, revision @10898@.
This update has new approach that fixes the multiple combo-bo...
Eugenie Lyzenko
02:41 PM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > The only issue I have is with code like this: @if (child != ...
Constantin Asofiei
01:56 PM Feature #2546: implement combo-box widget in GUI
Constantin Asofiei wrote:
> The only issue I have is with code like this: @if (child != null && child instanceof Scr...
Eugenie Lyzenko
07:59 AM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Please review task branch @2546a@, revision @10897@.
The only issue I have is with code li...
Constantin Asofiei
10:49 PM Feature #2546: implement combo-box widget in GUI
Please review task branch @2546a@, revision @10897@.
Adding drop-down press opening fix. The main logic of drop-do...
Eugenie Lyzenko
09:30 PM Feature #2546: implement combo-box widget in GUI
Rebased task branch @2546a@ from P2J trunk revision @10894@. Eugenie Lyzenko
05:16 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> I recommend that you zip up the @p2j/@ directory on devsrv01 and copy it to your local system. M...
Igor Skornyakov
04:57 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
I recommend that you zip up the @p2j/@ directory on devsrv01 and copy it to your local system. Make sure to exclude ... Greg Shah
04:51 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
The situation is very strange. On my machine the manual testing is OK (the dynamic header is in place). Igor Skornyakov
04:36 PM Feature #1807: implement clipboard support
Some things to note:
1. ChUI does support use of the CLIPBOARD system handle (including the VALUE attribute for bo...
Greg Shah
04:20 PM Feature #1811: implement the AJAX client driver
The current clipboard support for the ChUI web client has many of the building blocks that are needed for GUI clipboa... Greg Shah
11:25 AM Feature #2563: implement GUI EDITOR widget
Rebased task branch 2563b from P2J trunk revision 10894 (new branch revision 10898).
Constantin Asofiei
10:02 AM Feature #2252: implement GUI client support
Rebased task branch 1796b from P2J trunk revision 10894 (branch revision 10906).
Constantin Asofiei

07/06/2015

07:33 PM Feature #2252: implement GUI client support
Rebased task branch 2424 from P2J trunk revision 10894 (branch revision 10896). Hynek Cihlar
03:37 PM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Greg, a conversion question; in 4GL, the following frames are equivalent:
> [...]
> In...
Greg Shah
10:39 AM Feature #2252: implement GUI client support
Task branch 2559e committed to trunk as revision 10894. Hynek Cihlar
09:49 AM Feature #2252: implement GUI client support
> I only didn't expect any ChUI-specific features, hence no ChUI-specific sublass.
I see. Good.
Greg Shah
09:43 AM Feature #2252: implement GUI client support
Greg Shah wrote:
> I think the best approach is to create GUI and ChUI subclasses of @WindowManager@ that can have m...
Hynek Cihlar
09:34 AM Feature #2252: implement GUI client support
Go ahead and merge 2559e into the trunk.
The next time we have some work in @WindowManager@, we can make some fact...
Greg Shah
08:06 AM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> Greg Shah wrote:
> > Code Review Task Branch 2559e Revision 10896
> >
> > This is good.
>...
Hynek Cihlar
05:03 PM Feature #2546: implement combo-box widget in GUI
> Should I try to reboot it(not sure if I have enough permissions)?
No, let the customer handle that.
> The exc...
Greg Shah
04:42 PM Feature #2546: implement combo-box widget in GUI
The exception from drop-down dismiss rule is mouse events in combo-box entry field or outside drop-down or combo-box(... Eugenie Lyzenko
04:30 PM Feature #2546: implement combo-box widget in GUI
Greg Shah wrote:
> Does the 4GL code (actually, it is really the Windows drop-down control) dismiss the drop-down on...
Eugenie Lyzenko
09:48 AM Feature #2546: implement combo-box widget in GUI
> The root cause was too early dismiss the drop-down. I have preferred to use mouse press due to mouse press does imm... Greg Shah
07:46 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> Could you help me to find why sub-menu body is truncated and where the truncating is happen?
...
Constantin Asofiei
04:42 AM Feature #1790: implement menu support
Constantin, could you look at my current changes in 1790d?
Here is my testcase:...
Vadim Gindin
 

Also available in: Atom