Project

General

Profile

Activity

From 08/04/2015 to 09/02/2015

09/03/2015

10:35 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Another issue to solve in the @SVG@ converter implementation. The converter takes the source file as name or @URL@ wh... Eugenie Lyzenko

09/02/2015

05:08 PM Feature #1790: implement menu support
Vadim, rev 10954 contains fixes for MENU-DROP event generation + misc fixes for popup menu. At this time, the menuba... Constantin Asofiei
04:08 PM Feature #1790: implement menu support
Constantin Asofiei wrote:
> About the wait-for: I think is safe to assume that wait-for must not check VISIBLE for a...
Vadim Gindin
03:58 PM Feature #1790: implement menu support
Vadim, this is good, I've integrated it with my changes and it fixed some popup issues I was having. Please don't co... Constantin Asofiei
03:30 PM Feature #1790: implement menu support
# I've moved "clicking" logic from @mouseClicked@ to @mousePressed@ that is more convenient place.
# I've added hidin...
Vadim Gindin
08:38 AM Feature #1790: implement menu support
Another issue: @VK_ENTER@ key is used to trigger an open of a sub-menu (or click of menu-item), when a mouse action w... Constantin Asofiei
08:02 AM Feature #1790: implement menu support
Revision 10952 fixes:
* focus processing when focus is moved from a higher to a lower level in the menu tree. The c...
Constantin Asofiei
04:07 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Sergey: please review this task history from note 30 to the end.
Eugenie/Hynek: Sergey has implemented an image ca...
Greg Shah
04:02 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Eugenie, also try to keep only unique set of converted images. For example when multiple scroll bars are painted we o... Hynek Cihlar
03:35 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
> Let me know if I've missed for something.
Your assumptions seem reasonable. Please make sure the SVG files are ...
Greg Shah
03:20 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
What I can tell from samples is the basic approach we can use:
1. Having @SVG@ files for every image we want to be...
Eugenie Lyzenko
02:56 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
> For Windows 7 I assume you mean the default non-aero Windows 7 Basic theme?
Yes.
For now, we should focus on ...
Greg Shah
02:08 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Eugenie Lyzenko wrote:
> Hynek, the 1.7 batik binary is enough to use this rasterizer in P2J? Do you have any sample...
Hynek Cihlar
01:52 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Hynek, the 1.7 batik binary is enough to use this rasterizer in P2J? Do you have any sample Java code that demonstrat... Eugenie Lyzenko
01:43 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Greg Shah wrote:
> > 4GL reference docs show screenshots from different versions of Windows and their themes, inclu...
Hynek Cihlar
01:01 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
> 4GL reference docs show screenshots from different versions of Windows and their themes, including a theme which l... Greg Shah
12:49 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Greg Shah wrote:
> > As much confident as with the hard-coded approach.
>
> Eugenie: please give the SVG approac...
Hynek Cihlar
12:04 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
> As much confident as with the hard-coded approach.
Eugenie: please give the SVG approach a try. Don't worry ab...
Greg Shah
11:59 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Hynek Cihlar wrote:
> As much confident as with the hard-coded approach. And I am afraid we won't achieve pixel perf...
Eugenie Lyzenko
11:54 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Greg Shah wrote:
> How confident are you that we can match the Windows vectors pixel for pixel using SVG?
As much...
Hynek Cihlar
10:03 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Greg Shah wrote:
> How confident are you that we can match the Windows vectors pixel for pixel using SVG?
I'm par...
Greg Shah
09:57 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
How confident are you that we can match the Windows vectors pixel for pixel using SVG? Greg Shah
09:29 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Greg Shah wrote:
> > My concern is that hard coding the vector images will lock us down to any future improvements (...
Hynek Cihlar
08:46 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
> My concern is that hard coding the vector images will lock us down to any future improvements (new themes for examp... Greg Shah
08:20 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Greg Shah wrote:
> Hynek Cihlar wrote:
> > Greg, there are and likely will be more places where vector based icons/...
Hynek Cihlar
08:19 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Hynek Cihlar wrote:
> Greg, there are and likely will be more places where vector based icons/images will be needed....
Greg Shah
08:16 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > Greg, there are and likely will be more places where vector based ...
Hynek Cihlar
08:13 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Hynek Cihlar wrote:
> Greg, there are and likely will be more places where vector based icons/images will be needed....
Eugenie Lyzenko
08:10 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Greg, there are and likely will be more places where vector based icons/images will be needed. Do you think it would ... Hynek Cihlar
08:04 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
I can see that some customers may need to customize that value (using themes) for accessibility reasons. We are goin... Greg Shah
08:00 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Greg Shah wrote:
> > Adding support for painting the disabled state for GUI scrollbar button. The current implementa...
Hynek Cihlar
07:43 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Eugenie Lyzenko wrote:
> Task branch @2606a@ for review updated to revision @10944@.
>
> Adding support for paint...
Hynek Cihlar
07:34 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
> As far as I know the scroll buttons is a part of the Windows system controls, not the 4GL elements. So the questio... Greg Shah
07:24 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
>But I wonder if it is bitmap based or if it can be scaled to a larger/smaller size. Please test in the 4GL, if there... Eugenie Lyzenko
07:13 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
> Adding support for painting the disabled state for GUI scrollbar button. The current implementation for button draw... Greg Shah
07:10 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
> Do we really need this to be implemented in SELECTION-LIST?
I checked, you're right. We don't need MAX-CHARS.
Greg Shah
09:13 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Testing on 4GL system shows the @MAX-CHARS@ is not queryable/settable attribute for @SELECTION-LIST@ widget. I have u... Eugenie Lyzenko
08:49 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10944@.
Adding support for painting the disabled state for GUI s...
Eugenie Lyzenko
04:02 PM Feature #1811: implement the AJAX client driver
Adding a sleep is not a solution we can use in the production code. For now, stop working on this problem. I'll ope... Greg Shah
03:43 PM Feature #1811: implement the AJAX client driver
May be task bar application window that represents the application icon is updated asynchronously on @setVisible(true... Sergey Ivanovskiy
03:22 PM Feature #1811: implement the AJAX client driver
If the image is found on the path, then you can try to run it several times or set the breakpoint after on @setVisibl... Sergey Ivanovskiy
03:08 PM Feature #1811: implement the AJAX client driver
The test does not work for me. I uncommented the @frame.setVisible(false)@ and tried it, but there is no difference.... Greg Shah
02:19 PM Feature #1811: implement the AJAX client driver
Found that if @frame.setIconImage()@ is called after the @frame@ becomes visible, then the application task bar icon ... Sergey Ivanovskiy
07:21 AM Feature #1811: implement the AJAX client driver
> Planning to fix it because this code works properly
OK, good.
Greg Shah
06:44 AM Feature #1811: implement the AJAX client driver
Greg, setIconImage doesn't change the swing client application icon for my Ubuntu task bar(like desktop),
please look...
Sergey Ivanovskiy

09/01/2015

06:32 PM Feature #1790: implement menu support
Vadim Gindin wrote:
> # fix the bug with unexpected exit when I click a menu-item from MENUBAR with assigned trigger...
Constantin Asofiei
11:01 AM Feature #1790: implement menu support
# fix the bug with unexpected exit when I click a menu-item from MENUBAR with assigned trigger, that dynamically sets... Vadim Gindin
09:53 AM Feature #1790: implement menu support
When you post the list of open issues, please include an estimate of how long it will take to resolve those issues. ... Greg Shah
09:51 AM Feature #1790: implement menu support
I faced with some new bugs after last commits and rebase. So I'm still close but not yet ready. I'll post current lis... Vadim Gindin
08:11 AM Feature #1790: implement menu support
Vadim, I'm good with the changes in rev 10949. If you are close to finish, please:
# rebase from latest revision
#...
Constantin Asofiei
05:45 PM Feature #2564: implement GUI BROWSE widget
Some metrics. I'll update @font_details.odt@ accordingly.
Browse constraints:...
Stanislav Lomany
10:59 AM Feature #2564: implement GUI BROWSE widget
You should expect to use @GuiFontResolver@ and @GuiColorResolver@. Greg Shah
05:08 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10980
The changes are good.
Greg Shah
04:58 PM Feature #1811: implement the AJAX client driver
Greg, please review the committed revision 10980. Sergey Ivanovskiy
04:38 PM Feature #1811: implement the AJAX client driver
Greg, 10979 uses @doLayout@ of @WindowTitleBar@, I would like to change it again to place @setIcon()@ code to @draw()... Sergey Ivanovskiy
04:18 PM Feature #1811: implement the AJAX client driver
> Code Review Task Branch 1811q Revision 10978
>
> I have one concern. It is possible to load a @.ico@ file as an...
Sergey Ivanovskiy
04:02 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10978
I have one concern. It is possible to load a @.ico@ file as an image...
Greg Shah
03:52 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10977
The changes are good.
Greg Shah
03:32 PM Feature #1811: implement the AJAX client driver
h2. Remaining Task List (in priority order)
h3. Task Branch 1811q
# -fix system menu- (CA)
# -pressing maximize but...
Greg Shah
02:39 PM Feature #1811: implement the AJAX client driver
Committed revision 10978. The changes are not good due to setIcon has the drawImage signature. It is because the web ... Sergey Ivanovskiy
11:56 AM Feature #1811: implement the AJAX client driver
1811q rev 10977 contains fixes related to p2j.mouse (window events functions are refactored to use a worker) and a fi... Constantin Asofiei
09:27 AM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10975
The changes look good. The only thing that seems missing would be ch...
Greg Shah
08:50 AM Feature #1811: implement the AJAX client driver
Greg, please review the committed revision 10975. It is the SET_ICON implementation. Sergey Ivanovskiy
07:32 AM Feature #1811: implement the AJAX client driver
> for SET_ICON?
Yes, this seems reasonable. If we have an image ID, we can easily draw the icon from that alone, ...
Greg Shah
07:24 AM Feature #1811: implement the AJAX client driver
Greg, do we need to reuse... Sergey Ivanovskiy
04:25 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> I just committed some merge fixes in rev 10973.
>
> Constantin: would you please check @FontTa...
Constantin Asofiei
04:13 AM Feature #1811: implement the AJAX client driver
> I'm aware of this. The question is: do you plan to set the window state by other means than the window's caption b... Sergey Ivanovskiy
03:59 AM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> Constantin please look at this issue
> >1. Implement the GuiWebEmulatedWindow.setIconifi...
Constantin Asofiei
03:23 AM Feature #1811: implement the AJAX client driver
Constantin please look at this issue
>1. Implement the GuiWebEmulatedWindow.setIconificationState() which will certa...
Sergey Ivanovskiy
03:30 PM Support #2675: list of differences between the web GUI client and the original 4GL Windows GUI en...
Please add to this list whenever you find something that is a permanent restriction.
1. The font rendering will be c...
Greg Shah
03:26 PM Support #2675 (New): list of differences between the web GUI client and the original 4GL Windows ...
Greg Shah
03:25 PM Support #2674: list of HTML5, CSS and Javascript features in use in the web client (both ChUI and...
Here is my first pass. I'm sure it is incomplete.
|_. Feature |_. Firefox |_. Chrome |_. IE |_. Safari |
| HTML5...
Greg Shah
02:41 PM Support #2674 (New): list of HTML5, CSS and Javascript features in use in the web client (both Ch...
Greg Shah
02:38 PM Feature #2673: support a kind of virtual desktop in the GUI web client
The idea here is to make sure that users can interact with the GUI web client in the similar use patterns to how they... Greg Shah
02:28 PM Feature #2673 (WIP): support a kind of virtual desktop in the GUI web client
Greg Shah
02:27 PM Support #2672: GUI web client performance improvements
The following are ideas for performance improvements in the GUI web client.
1. Watching the log of drawing operati...
Greg Shah
02:00 PM Support #2672 (New): GUI web client performance improvements
Greg Shah
12:10 PM Feature #2252: implement GUI client support
Greg Shah wrote:
> 1. One future improvement would be to improve abstraction such that there would not be widget-s...
Hynek Cihlar
11:33 AM Feature #2252: implement GUI client support
Code Review Task Branch 2424c Revision 10954
I like the improvements very much! It certainly is more regular and e...
Greg Shah
09:08 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Code Review Task Branch 2606a Revision 10942
This is very good! I've made some small cleanups to javadoc and chec...
Greg Shah
08:36 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
The current testcases for @selection-list@ widget have been uploaded to bzr repo. Version is @1313@. Eugenie Lyzenko
08:11 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10942@.
This update changes the location of the tooltip featur...
Eugenie Lyzenko

08/31/2015

07:49 PM Feature #2252: implement GUI client support
Please review 2424c revision 10954. Although it is not yet free of issues, it is close to be finished.
The changes pr...
Hynek Cihlar
07:46 PM Feature #1811: implement the AJAX client driver
Committed revision 10974. Sergey Ivanovskiy
06:12 PM Feature #1811: implement the AJAX client driver
I just committed some merge fixes in rev 10973.
Constantin: would you please check @FontTable@ to make sure I didn...
Greg Shah
06:02 PM Feature #1811: implement the AJAX client driver
Rebased task branch 1811q from P2J trunk revision 10930. The latest branch revision is 10972. Greg Shah
05:47 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10963
This is good. Please add a comment to the @draw()@ code where you re...
Greg Shah
05:44 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10962
It is quite good. A couple of thoughts:
1. The @WindowClose@, @Wi...
Greg Shah
05:28 PM Feature #1811: implement the AJAX client driver
gui&webClients.png
!gui&webClients.png!
Sergey Ivanovskiy
05:19 PM Feature #1811: implement the AJAX client driver
Committed revision 10963. It should fix close button differences for web and swing clients. Now the logs for drawing ... Sergey Ivanovskiy
05:10 PM Feature #1811: implement the AJAX client driver
> I have already implemented setGuiRenderingHints but it follows that STOKE_PURE produces incorrect graphics. I think... Greg Shah
04:54 PM Feature #1811: implement the AJAX client driver
Greg, Hynec, please look at these difficulties that comes trying to synchronize the close button with swing client an... Sergey Ivanovskiy
04:47 PM Feature #1811: implement the AJAX client driver
1811q revision 10926 contains support for window iconification/deiconification, maximize and close, plus enableEvents... Constantin Asofiei
03:04 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10961
The changes look good.
Greg Shah
01:45 PM Feature #1811: implement the AJAX client driver
> > But I think that it would be good if we have setRenderingHint implementation for stroke and for antialiasing?
> ...
Sergey Ivanovskiy
01:24 PM Feature #1811: implement the AJAX client driver
> But I think that it would be good if we have setRenderingHint implementation for stroke and for antialiasing?
We...
Greg Shah
01:19 PM Feature #1811: implement the AJAX client driver
!StrokeControl&LineCoveredWithSquares.png! Sergey Ivanovskiy
01:08 PM Feature #1811: implement the AJAX client driver
> > How about a different version of JRE?
>
> This would restrict customers (and ourselves) too much to be accepta...
Sergey Ivanovskiy
12:52 PM Feature #1811: implement the AJAX client driver
> How about a different version of JRE?
This would restrict customers (and ourselves) too much to be acceptable. ...
Greg Shah
12:50 PM Feature #1811: implement the AJAX client driver
> we would like to add setRenderingHints to drawing primitives.
Yes, go ahead.
Sergey: please also note that in...
Greg Shah
12:18 PM Feature #1811: implement the AJAX client driver
Greg, we would like to add setRenderingHints to drawing primitives. Sergey Ivanovskiy
12:13 PM Feature #1811: implement the AJAX client driver
When RenderingHints.KEY_STROKE_CONTROL set to RenderingHints.VALUE_STROKE_PURE, the following produces the expected r... Hynek Cihlar
11:59 AM Feature #1811: implement the AJAX client driver
> Setting @RenderingHints.KEY_STROKE_CONTROL@ to @RenderingHints.VALUE_STROKE_PURE@ does resolve the problem.
I will...
Sergey Ivanovskiy
11:52 AM Feature #1811: implement the AJAX client driver
Setting @RenderingHints.KEY_STROKE_CONTROL@ to @RenderingHints.VALUE_STROKE_PURE@ does resolve the problem. Hynek Cihlar
11:40 AM Feature #1811: implement the AJAX client driver
> Sergey, have you tried changing the KEY_STROKE_CONTROL hint? See http://docs.oracle.com/javase/7/docs/api/java/awt/... Sergey Ivanovskiy
11:28 AM Feature #1811: implement the AJAX client driver
Sergey, have you tried changing the KEY_STROKE_CONTROL hint? See http://docs.oracle.com/javase/7/docs/api/java/awt/Re... Hynek Cihlar
11:24 AM Feature #1811: implement the AJAX client driver
How about a different version of JRE? Hynek Cihlar
11:15 AM Feature #1811: implement the AJAX client driver
> Another idea: we could implement transforms that rotate the \ and horizontally flip (mirror image) the pixels aroun... Sergey Ivanovskiy
11:11 AM Feature #1811: implement the AJAX client driver
Another idea: we could implement transforms that rotate the \ and horizontally flip (mirror image) the pixels around ... Greg Shah
11:03 AM Feature #1811: implement the AJAX client driver
This code draws the cross of 2 pixels width, we have two variants: to implement the custom line widening drawing prim... Sergey Ivanovskiy
10:40 AM Feature #1811: implement the AJAX client driver
> We can use drawString('x' .. if it looks like the cross.
It must be exactly the same to work.
I'm not sure...
Greg Shah
10:30 AM Feature #1811: implement the AJAX client driver
> The reason for vectors was to allow caption size scaling.
Good point, I had forgotten this.
> I think it's a ...
Greg Shah
10:06 AM Feature #1811: implement the AJAX client driver
We can use drawString('x' .. if it looks like the cross. Sergey Ivanovskiy
09:56 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
>
> Why not use images instead of vector drawing?
The reason for vectors was to allow caption ...
Hynek Cihlar
09:48 AM Feature #1811: implement the AJAX client driver
But the stroke color can't be changed for an image. We can draw line like you do it for js? Sergey Ivanovskiy
09:39 AM Feature #1811: implement the AJAX client driver
Greg, please approve I am going to add the cross.png image with the transparent background and then to change Caption... Sergey Ivanovskiy
09:06 AM Feature #1811: implement the AJAX client driver
> if we can't find a way to fix things in the Swing client, I think it's a good idea to move the Caption button draw... Greg Shah
03:41 PM Feature #2671: provide a facility to customize the JVM args and Java command line used by the spa...
It can be very useful (for debugging purposes) to customize the JVM args and/or Java command line used by the spawner... Greg Shah
03:38 PM Feature #2671 (New): provide a facility to customize the JVM args and Java command line used by t...
Greg Shah
03:36 PM Feature #2670: browser resize should re-layout the login page
Once loaded, the current login page does not react to a resize of the browser itself. It should re-layout instead. Greg Shah
03:36 PM Feature #2670 (New): browser resize should re-layout the login page
Greg Shah
03:29 PM Feature #2669: tabbing flow improvements
When first loaded, the username field should have the focus, so that the user can type immediately.
Use of ENTER i...
Greg Shah
03:28 PM Feature #2669 (New): tabbing flow improvements
Greg Shah
03:27 PM Feature #2668: if there are multiple spawn hosts, allow the user to select the host being logged ...
If more than one host is available for spawning AND if the customer has configured the spawning host to be selectable... Greg Shah
03:25 PM Feature #2668 (New): if there are multiple spawn hosts, allow the user to select the host being l...
Greg Shah
03:24 PM Feature #2667: login page title improvements
The current page title implementation is mostly static and is hard coded in the @web_client.html@. This should be cu... Greg Shah
03:13 PM Feature #2667 (New): login page title improvements
Greg Shah
03:07 PM Feature #2666 (New): web client login page improvements
Greg Shah
12:28 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Rebased task branch @2606a@ from P2J trunk revision @10930@, new branch revision is @10941@. Eugenie Lyzenko
12:28 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10940@.
This update completes handling of the @SIZE PHRASE@ op...
Eugenie Lyzenko
10:37 AM Feature #2564: implement GUI BROWSE widget
Hynek is working on major improvements to the scrolling support classes in task branch 2424c. It should be in testin... Greg Shah
10:02 AM Feature #2564: implement GUI BROWSE widget
For editing browse I'll re-use @FillInGuiImpl@ component. Stanislav Lomany
10:00 AM Feature #2564: implement GUI BROWSE widget
Guys, are there any existing components that I can re-use for drawing browse or that can simplify drawing process? I ... Stanislav Lomany

08/30/2015

05:58 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Rebased task branch 2567b from P2J trunk revision 10930 (new branch revision 10931).
Igor Skornyakov
01:34 PM Feature #2252: implement GUI client support
Rebased task branch 2424c from P2J trunk revision 10930 (branch revision 10950). Hynek Cihlar
01:09 PM Feature #2252: implement GUI client support
Rebased task branch 2424c from P2J trunk revision 10929 (branch revision 10949). Hynek Cihlar
01:09 PM Bug #2662: memory leak in the native NCURSES client
Rebased task branch 2662a to trunk rev. 10929; task branch is now 10933.
Merged 2662a/10933 to trunk. 2662a was ar...
Eric Faulhaber

08/29/2015

07:01 PM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> Greg, please review my finding if turn on antialiasing before '/' drawing and turn off af...
Constantin Asofiei
04:10 PM Feature #1811: implement the AJAX client driver
Greg, please review my finding if turn on antialiasing before '/' drawing and turn off after it, then the final / lin... Sergey Ivanovskiy
10:23 AM Feature #1811: implement the AJAX client driver
1811q rev 10961 contains WindowActivated support for the JS (windows can be used in the Web client now). Constantin Asofiei
08:28 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Another TODO work is to verify @SIZE PHRASE@ working and tooltip functionality. Eugenie Lyzenko
11:12 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10939@.
This update fixes the scrollbar positioning. However I...
Eugenie Lyzenko
10:20 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
The new code samples to compare. As we can see the scrollbar does not have the painting for disabled state. But the w... Eugenie Lyzenko

08/28/2015

07:20 PM Feature #2252: implement GUI client support
I needed to add GUI drawing logic to @BorderedPanel@. Instead of mixing ChUI and GUI code in one class I split it in ... Hynek Cihlar
05:07 PM Feature #1811: implement the AJAX client driver
Greg, if we can't find a way to fix things in the Swing client, I think it's a good idea to move the Caption button d... Constantin Asofiei
03:55 PM Feature #1811: implement the AJAX client driver
No, it doesn't help.!strokesJava2DTest.png! The Java2d surprises me. It doesn't use symmetry of x and y. Sergey Ivanovskiy
02:48 PM Feature #1811: implement the AJAX client driver
Is there any performance or functional disadvantage to switching the @g2.drawLine()@ to @g2.getStroke().createStroked... Greg Shah
02:40 PM Feature #1811: implement the AJAX client driver
> I really don't want to duplicate a Java2D bug in JS. Please see if you can determine why the Java2D implementation... Sergey Ivanovskiy
02:27 PM Feature #1811: implement the AJAX client driver
Good idea. I'm going with this:... Greg Shah
02:20 PM Feature #1811: implement the AJAX client driver
Yes, that should do it. I would only prefer the @GuiDriver.draw@ method. Hynek Cihlar
02:04 PM Feature #1811: implement the AJAX client driver
How about changing this:... Greg Shah
01:21 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Task branch 1811q, revision 10959 has a fix for scrollable list overdrawing its boundaries when t...
Hynek Cihlar
12:58 PM Feature #1811: implement the AJAX client driver
Task branch 1811q, revision 10959 has a fix for scrollable list overdrawing its boundaries when the right or bottom i... Greg Shah
11:59 AM Feature #1811: implement the AJAX client driver
> We can simulate this behaviour in js for two nearest parallel lines to be 2-pixel width if its stroke width is also... Greg Shah
11:42 AM Feature #1811: implement the AJAX client driver
> The two @drawLine@ calls for the SW-NE line are there as a workaround for a Swing? 2D rendering bug. I couldn't mak... Sergey Ivanovskiy
11:32 AM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> Greg, please clarify the issue, we draw the cross with two pixels width, if so we can rem...
Hynek Cihlar
11:28 AM Feature #1811: implement the AJAX client driver
Greg, please clarify the issue, we draw the cross with two pixels width, if so we can remove this
// TODO: the SW-N...
Sergey Ivanovskiy
10:52 AM Feature #1811: implement the AJAX client driver
> May be due to odd or even points coordinates two pixels width of two parallels are collapsed in java 2d?
Possibl...
Greg Shah
10:50 AM Feature #1811: implement the AJAX client driver
I will try to fix it base on odd or even coordinates in p2j.strokes.js class WidenPathRenderer. Sergey Ivanovskiy
10:40 AM Feature #1811: implement the AJAX client driver
Also, these logs of swing client are proved it:
PaintPrimitives.TRANSLATE_POP 1; x = -358; y = -4
PaintPrimitives.TR...
Sergey Ivanovskiy
10:35 AM Feature #1811: implement the AJAX client driver
> Sergey: the drawing of the X in the close button is quite different from the Swing version. Would you please diagno... Sergey Ivanovskiy
10:14 AM Feature #1811: implement the AJAX client driver
Sergey: the drawing of the X in the close button is quite different from the Swing version. Would you please diagnose... Greg Shah
10:12 AM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10957
I'm good with the changes.
Greg Shah
10:06 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Constantin: Good work. Please check in your changes.
1811q rev 10958 contains the fix for the f...
Constantin Asofiei
10:01 AM Feature #1811: implement the AJAX client driver
Constantin: Good work. Please check in your changes.
In addition to the unwanted anti-aliasing, it also seems tha...
Greg Shah
09:20 AM Feature #1811: implement the AJAX client driver
Greg, about the fonts.
# bold fonts require their own .ttf file - so I've changed the custom fonts to specify if the...
Constantin Asofiei
04:14 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Rebased task branch @2606a@ from P2J trunk revision @10929@, new branch revision is @10938@. Eugenie Lyzenko
01:11 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10937@.
This improves height scaling. Preparing to rebase.
Eugenie Lyzenko
09:23 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10936@.
This update for review has fix for incorrect widget wi...
Eugenie Lyzenko
02:57 PM Bug #2665 (New): vim only partially works as an interactive child process in the NCURSES client
Greg Shah
02:55 PM Bug #2664 (New): vim doesn't work as an interactive child process in either Swing ChUI or the web...
Greg Shah
01:01 PM Feature #1791 (Closed): implement dynamic UI support
Greg Shah
12:26 PM Feature #1791: implement dynamic UI support
2026b has been committed into the trunk as bzr revision 10929. Stanislav Lomany
01:00 PM Feature #2026 (Closed): conversion support for CREATE_BROWSE
Greg Shah
12:27 PM Feature #2026 (Review): conversion support for CREATE_BROWSE
Stanislav Lomany
12:27 PM Feature #2026 (WIP): conversion support for CREATE_BROWSE
Stanislav Lomany
11:18 AM Feature #1790: implement menu support
I missed a case where @copy@ should have been used instead of @wa.anyActions@ on line 250 please fix it. Constantin Asofiei
11:05 AM Feature #1790: implement menu support
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Remained tasks:
> > > # fix sub-menu closing when clicking in ...
Vadim Gindin
04:10 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> Remained tasks:
> > # fix sub-menu closing when clicking in some free space. I wrote about th...
Constantin Asofiei
02:29 AM Feature #1790: implement menu support
I've committed actual tests. See below.
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Remained tasks:
> >...
Vadim Gindin
08:21 AM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> Guys, you are mentioning "3D" mode for GUI widgets. How is it switched?
Are you thinkin...
Greg Shah
08:20 AM Feature #2564: implement GUI BROWSE widget
The @*-DCOLOR@ and @*-PFCOLOR@ attributes/options are supposed to only be for ChUI, so it makes some sense if they do... Greg Shah
07:46 AM Feature #2564: implement GUI BROWSE widget
Guys, you are mentioning "3D" mode for GUI widgets. How is it switched? Stanislav Lomany
07:41 AM Feature #2564: implement GUI BROWSE widget
Attributes which affect drawing:
*Coloring:*
COLUMN-BGCOLOR attribute Column
COLUMN-FGCOLOR attribute Column
...
Stanislav Lomany

08/27/2015

05:28 PM Feature #1790: implement menu support
Vadim Gindin wrote:
> Remained tasks:
> > # fix sub-menu closing when clicking in some free space. I wrote about th...
Constantin Asofiei
05:26 PM Feature #1790: implement menu support
Remained tasks:
> # fix sub-menu closing when clicking in some free space. I wrote about this problem earlier. See t...
Vadim Gindin
03:52 PM Feature #1790: implement menu support
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Constantin Asofiei wrote:
> > > - please try something like th...
Vadim Gindin
05:37 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > - please try something like this: use a PAUSE statement and pre...
Constantin Asofiei
04:33 AM Feature #1790: implement menu support
Constantin Asofiei wrote:
> - please try something like this: use a PAUSE statement and press ALT (without having a ...
Vadim Gindin
04:22 AM Feature #1790: implement menu support
Greg Shah wrote:
> Based on the stack trace in note 528, by the time you see that the exception has already been pro...
Vadim Gindin
05:02 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Several testing shows the selection-list widget is working properly in case of the dynamically creation. Also the imp... Eugenie Lyzenko
08:56 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10935@.
This update completes the support for @SCROLL-TO-ITEM(...
Eugenie Lyzenko
04:56 PM Feature #1791: implement dynamic UI support
Code Review Task Branch 2026b Revision 10945
The change is good. Merge to trunk if it passes.
Greg Shah
04:47 PM Feature #1791: implement dynamic UI support
There is single minor regression. I've fixed it and committed the fix. Re-running regression testing. Stanislav Lomany
04:11 PM Feature #1791: implement dynamic UI support
Code Review Task Branch 2026b Revision 10944
I'm good with the changes. If they pass testing, please merge to tru...
Greg Shah
07:23 AM Feature #1791: implement dynamic UI support
Stanislav Lomany wrote:
> Constantin, many thanks! To be sure - are you talking about @GenericWIDGET.setVisible@?
A...
Constantin Asofiei
06:58 AM Feature #1791: implement dynamic UI support
Constantin, many thanks! To be sure - are you talking about @GenericWIDGET.setVisible@? Stanislav Lomany
05:16 AM Feature #1791: implement dynamic UI support
Stanislav, I think you are managing the VISIBLE attribute wrong. Even if you set it in the @CREATE BROWSE@, the VISI... Constantin Asofiei
04:32 PM Feature #1811: implement the AJAX client driver
Committed revision 10956 should fix the close button issue (#2) related to FILL_RECT drawing operation. Clean up the ... Sergey Ivanovskiy
03:43 PM Feature #1811: implement the AJAX client driver
Sergey: after your work on the bug number 2 from note 1014, please work on the following.
1. Implement the @GuiWeb...
Greg Shah
03:24 PM Feature #1811: implement the AJAX client driver
Constantin, I'd like you to tackle the following (in this priority order, unless you have reasons that a different or... Greg Shah
03:00 PM Feature #1811: implement the AJAX client driver
Wow, we are very code to having the hello world program pixel-for-pixel identical with the Swing version:
!hello_w...
Greg Shah
02:47 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10955
Good changes.
Greg Shah
01:19 PM Feature #1811: implement the AJAX client driver
And the attachments... Greg Shah
01:18 PM Feature #1811: implement the AJAX client driver
> are we sure we need a hard-coded 96 DPI for the web driver? Because setting it to 72 produces the same drawn string... Greg Shah
09:58 AM Feature #1811: implement the AJAX client driver
Greg, please review the committed revision 10955, added new parameter path to drawLine, but with help of function dra... Sergey Ivanovskiy
08:38 AM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10954
This is really good. Some thoughts:
1. When you add more details ...
Greg Shah
07:43 AM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > > # test/fix window resize in Web
> >
> > What kind of issue...
Hynek Cihlar
07:26 AM Feature #1811: implement the AJAX client driver
Hynek Cihlar wrote:
> > # test/fix window resize in Web
>
> What kind of issue is this?
Window resize in browse/...
Constantin Asofiei
07:01 AM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> Branch 1811q rev 10952 contains second phase of mouse support. Remaining mouse issues:
...
Hynek Cihlar
03:56 AM Feature #1811: implement the AJAX client driver
Greg, please review the committed revision 10954. It is a fix for window caption buttons, and p2j.strokes.js, empty s... Sergey Ivanovskiy

08/26/2015

07:29 PM Feature #1811: implement the AJAX client driver
Okay, I am using the current version, only please note that draw3DRect doesn't draw 3-D outline and if we use this.ct... Sergey Ivanovskiy
06:47 PM Feature #1811: implement the AJAX client driver
Revision 10953 has major fixes for @draw3DRect()@. With this (and prior fixes), the result is now:
!hello_world_w...
Greg Shah
06:16 PM Feature #1811: implement the AJAX client driver
Branch 1811q rev 10952 contains second phase of mouse support. Remaining mouse issues:
# window resize: the cursor i...
Constantin Asofiei
06:03 PM Feature #1811: implement the AJAX client driver
Greg, I think draw3DRect and drawRect are not correct. I will try to fix it. Sergey Ivanovskiy
05:39 PM Feature #1811: implement the AJAX client driver
Greg, please look at these changes, I have tested how to draw the window close button exactly like it is done by our ... Sergey Ivanovskiy
05:02 PM Feature #1811: implement the AJAX client driver
Revisions 10950 and 10951 fix @draw3DRect()@ and @drawRect()@ (fill mode only) respectively. With these changes some... Greg Shah
04:37 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Constantin: do you have a more functional version of mouse support that can be checked in (even i...
Constantin Asofiei
01:14 PM Feature #1811: implement the AJAX client driver
Attached are logs taken with rev 10949. The JS and Java sides of the web client output are basically the same. The S... Greg Shah
12:57 PM Feature #1811: implement the AJAX client driver
Constantin: do you have a more functional version of mouse support that can be checked in (even if it isn't the optim... Greg Shah
12:48 PM Feature #1811: implement the AJAX client driver
The reduction in console usage was enough to solve the current performance issue. I think it is best to get the func... Greg Shah
12:47 PM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> Greg, at first I can take this task 4. There is a dark outline around the min/max/close b...
Greg Shah
12:46 PM Feature #1811: implement the AJAX client driver
Greg, at first I can take this task 4. There is a dark outline around the min/max/close buttons. The min/max buttons ... Sergey Ivanovskiy
12:14 PM Feature #1811: implement the AJAX client driver
To be more concrete let us consider this example
Window.prototype.drawRect = function(ctx, x, y, width, height, color...
Sergey Ivanovskiy
11:47 AM Feature #1811: implement the AJAX client driver
> For now, please don't spend any time on loading extra modules. I think your webworker idea has more promise as a r... Sergey Ivanovskiy
09:21 AM Feature #1811: implement the AJAX client driver
> I think the difference is in the color usage for fill3DRect - it uses draker/lighter colors, when it should not cha... Greg Shah
06:07 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Code Review Task Branch 1811q Revision 10942
>
> The changes are good. Nice catch on the @dra...
Constantin Asofiei
06:01 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Constantin: any thoughts on item 2?
> 2. Fonts are significantly different.
I'm looking into ...
Constantin Asofiei
05:05 PM Feature #1790: implement menu support
Based on the stack trace in note 528, by the time you see that the exception has already been processed. You are bre... Greg Shah
04:37 PM Feature #1790: implement menu support
No ConditionException is raised. I've set a breakpoint after the event processing loop in @ThinClient.waitForEventWor... Vadim Gindin
04:05 PM Feature #1790: implement menu support
Vadim Gindin wrote:
> # fix the bug with unexpected exit when I click a menu-item from MENUBAR with assigned trigger...
Vadim Gindin
02:46 PM Feature #1790: implement menu support
I'm not able to finish all bugs till tomorrow. Here is the actual list.
# check drawing navigation mode (check pop-u...
Vadim Gindin
10:16 AM Feature #1791: implement dynamic UI support
The following testcase is for
(1) - @k@ should have no value
(2) report.txt should be "Employee: 0"...
Stanislav Lomany
08:48 AM Feature #1791: implement dynamic UI support
Stanislav, please specify some of the MAJIC tests which fail for the 3 issues in note 317 and also a 4GL test related... Constantin Asofiei
07:49 AM Feature #1791: implement dynamic UI support
In addition to the "value is displayed while it shouldn't" (1) changes in @makeFrameVisible@ also brought border draw... Stanislav Lomany
05:26 AM Feature #2252: implement GUI client support
I identified a new issue related to size calculation of scroll pane and its child widgets manifesting as frame scroll... Hynek Cihlar
03:35 AM Bug #2662: memory leak in the native NCURSES client
Greg Shah wrote:
> > is defined using @jbyteArray@ instead of @jintArray@ for attrs and colors parameters
>
> Thi...
Constantin Asofiei
08:45 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10934@.
This update contains suspended implementation scrollin...
Eugenie Lyzenko

08/25/2015

06:43 PM Feature #1811: implement the AJAX client driver
I just committed 10946. It has a temporary solution to the console log issue. It is not suitable for production use... Greg Shah
06:40 PM Feature #1811: implement the AJAX client driver
I'm not sure this is a real problem. I only saw it 4 times and that was while I also had an invalid character in @p2... Greg Shah
06:15 PM Feature #1811: implement the AJAX client driver
I see this when the client starts (output to Java stderr):... Greg Shah
04:46 PM Feature #1811: implement the AJAX client driver
> unexpected problems to direct dojo loading custom AMD js modules
Our Dojo is not loading the normal way you migh...
Greg Shah
04:39 PM Feature #1811: implement the AJAX client driver
> the browser console loses messages at the start of application, so we can't check the server log with the client lo... Greg Shah
04:08 PM Feature #1811: implement the AJAX client driver
It can help to evaluate log4javascript.js The diff file misses log4javascript.js, it must be copied to the folder wit... Sergey Ivanovskiy
03:49 PM Feature #1811: implement the AJAX client driver
Greg, I have some arguments to use log4javascript-1.4.13 or to implement own logger. The first one browser console ap... Sergey Ivanovskiy
03:10 PM Feature #1811: implement the AJAX client driver
> what do you think if we will use http://log4javascript.org/docs/index.html logging js library in p2j.js? http://www... Greg Shah
03:05 PM Feature #1811: implement the AJAX client driver
> I have tried to resolve missed web browser console logs. May be it is related to the js UI thread is utilized exte... Greg Shah
03:00 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10945
Good changes.
Greg Shah
02:57 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10944
It looks good.
Greg Shah
02:55 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10943
It looks good.
Greg Shah
02:52 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10942
The changes are good. Nice catch on the @drawPolygon()@ fix.
Did ...
Greg Shah
02:42 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10941
I like the changes.
Greg Shah
02:30 PM Feature #1811: implement the AJAX client driver
Attached is the current output of the GUI web client (left) and the same converted code in the Swing GUI client (righ... Greg Shah
10:46 AM Feature #1811: implement the AJAX client driver
Greg, what do you think if we will use http://log4javascript.org/docs/index.html logging js library in p2j.js? http:/... Sergey Ivanovskiy
03:13 PM Feature #1791: implement dynamic UI support
Code Review Task Branch 2026b Revision 10942
I was hoping for more comments in @makeFrameVisible()@ rather than le...
Greg Shah
01:42 PM Feature #1791: implement dynamic UI support
I don't like the fact that widget state is modified just by pushing definitions. So I think it is time to put into ac... Stanislav Lomany
12:27 PM Feature #1791: implement dynamic UI support
(copy from email) There is the regression. Now I got the sense of the comment in GenericFrame.makeFrameVisible:
<p...
Stanislav Lomany
11:55 AM Bug #2662: memory leak in the native NCURSES client
> is defined using @jbyteArray@ instead of @jintArray@ for attrs and colors parameters
This is definitely wrong. I ...
Greg Shah
11:53 AM Bug #2662: memory leak in the native NCURSES client
I have committed a change (rev 10929) to delete the screen resources when the driver is re-initialized (and also at p... Greg Shah
11:43 AM Bug #2662: memory leak in the native NCURSES client
Created task branch 2662a from trunk revision 10928. Greg Shah
11:30 AM Bug #2662: memory leak in the native NCURSES client
Greg, something else in @terminal.c@ - the @Java_com_goldencode_p2j_ui_client_chui_driver_console_ConsoleHelper_addAr... Constantin Asofiei
11:17 AM Bug #2662: memory leak in the native NCURSES client
I've been digging into the NCURSES API usage.
In @initConsole()@ we call @newterm()@, which allocates a @SCREEN@ d...
Greg Shah
10:54 AM Bug #2662: memory leak in the native NCURSES client
Next test was a long loop which just writes to a file numbers from 1 to 1 million: the RES memory stays constant at ~... Constantin Asofiei
10:44 AM Bug #2662: memory leak in the native NCURSES client
After using @mtrace()@ function, it reports lots of still allocated addresses. Unfortunately I haven't found a way t... Constantin Asofiei
10:22 AM Bug #2662: memory leak in the native NCURSES client
-------- Forwarded Message --------
Subject: Re: re-running full-search tests.
Date: Tue, 25 Aug 2015 08:35:14 -0...
Greg Shah
10:22 AM Bug #2662: memory leak in the native NCURSES client
-------- Forwarded Message --------
Subject: Re: re-running full-search tests.
Date: Tue, 25 Aug 2015 07:53:44 -0...
Greg Shah
10:22 AM Bug #2662: memory leak in the native NCURSES client
-------- Forwarded Message --------
Subject: Re: re-running full-search tests.
Date: Tue, 25 Aug 2015 12:57:55 +030...
Greg Shah
10:20 AM Bug #2662: memory leak in the native NCURSES client
-------- Forwarded Message --------
Subject: Re: memory usage
Date: Thu, 20 Aug 2015 08:46:21 -0400
From: Greg ...
Greg Shah
10:19 AM Bug #2662: memory leak in the native NCURSES client
This link is useful in understanding things:
http://stackoverflow.com/questions/561245/virtual-memory-usage-from-j...
Greg Shah
10:18 AM Bug #2662: memory leak in the native NCURSES client
Initial identification of the problem was from this report by a customer:... Greg Shah
10:16 AM Bug #2662 (Closed): memory leak in the native NCURSES client
Greg Shah
09:08 AM Support #2660: evaluate if the NCURSES 5.7 "threading improvements" can be made to work for P2J s...
NCURSES 5.9 release notes includes:
> This extends support for threaded applications by providing a new API which...
Greg Shah
08:59 AM Support #2660: evaluate if the NCURSES 5.7 "threading improvements" can be made to work for P2J s...
I never heard back from that reply. BUT then they added some dual threading support in 5.7. NCURSES 5.7 came out on... Greg Shah
08:55 AM Support #2660: evaluate if the NCURSES 5.7 "threading improvements" can be made to work for P2J s...
-------- Forwarded Message --------
Subject: Re: proposed extension API addition for ncurses 5.5
Date: Wed, 30 Au...
Greg Shah
08:54 AM Support #2660: evaluate if the NCURSES 5.7 "threading improvements" can be made to work for P2J s...
-------- Forwarded Message --------
Subject: Re: proposed extension API addition for ncurses 5.5
Date: Tue, 29 Au...
Greg Shah
08:53 AM Support #2660: evaluate if the NCURSES 5.7 "threading improvements" can be made to work for P2J s...
-------- Forwarded Message --------
Subject: proposed extension API addition for ncurses 5.5
Date: Tue, 29 Aug 20...
Greg Shah
08:53 AM Support #2660: evaluate if the NCURSES 5.7 "threading improvements" can be made to work for P2J s...
http://invisible-island.net/ncurses/ncurses.faq.html#multithread... Greg Shah
08:50 AM Support #2660 (Test): evaluate if the NCURSES 5.7 "threading improvements" can be made to work fo...
Greg Shah
09:05 AM Support #2661: evaluate use of NCURSES 6.0 on Windows which now has a MinGW port
The key question: does it make sense to use NCURSES instead of the WIN32 console APIs?
This task is meant to explo...
Greg Shah
09:03 AM Support #2661 (New): evaluate use of NCURSES 6.0 on Windows which now has a MinGW port
Greg Shah
07:56 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Greg Shah wrote:
> Do you have things to work on that do not involve scrolling? Hynek's 2424c update which is close...
Eugenie Lyzenko
07:47 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Do you have things to work on that do not involve scrolling? Hynek's 2424c update which is close to finishing testin... Greg Shah
09:53 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10933@.
This adds the generic scrollbar support for GUI select...
Eugenie Lyzenko

08/24/2015

05:37 PM Feature #1791: implement dynamic UI support
Code Review Task Branch 2026b Revision 10941
It looks good. Please get it regression tested (both conversion and ...
Greg Shah
03:26 PM Feature #1791: implement dynamic UI support
> * @query_associations.rules@: please refresh my memory...why were we hiding the DEFINE_QUERY node's children, and ... Stanislav Lomany
11:41 AM Feature #1791: implement dynamic UI support
Code review 2026b/10940:
* @query_associations.rules@: please refresh my memory...why were we hiding the DEFINE_Q...
Eric Faulhaber
09:25 AM Feature #1791: implement dynamic UI support
Code Review Task Branch 2026b Revision 10940
This is really good.
The only thing I see here is that @GenericFra...
Greg Shah
03:45 PM Feature #1790: implement menu support
Here is the list of opened issues:
# menuItem.setSensitive call actuates ThinClient.enable method (fixed, but not co...
Vadim Gindin
10:10 AM Feature #1790: implement menu support
Constantin Asofiei wrote:
> > I wrote earlier, that in it doesn't for my machine. Why it could be?
> Do you use the...
Vadim Gindin
08:26 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> > # @MenuGuiImpl@
> > - is missing history entry
> > - why did you comment out the code in @...
Constantin Asofiei
07:53 AM Feature #1790: implement menu support
Constantin Asofiei wrote:
> Review branch 1790e revision 10941:
> # @expressions.rules@
> - I don't understand the...
Vadim Gindin
05:33 AM Feature #1790: implement menu support
Review branch 1790e revision 10941:
# @expressions.rules@
- I don't understand the @ Added ';' suppression for ACCE...
Constantin Asofiei
02:40 AM Feature #1790: implement menu support
Constantin, thank you for help. I've rebased the branch. Now current revision is 1941. Please review the code. Can I ... Vadim Gindin
03:04 PM Feature #1811: implement the AJAX client driver
Greg, please review the committed revision 10945. I have tried to resolve missed web browser console logs. May be it ... Sergey Ivanovskiy

08/23/2015

06:06 PM Feature #1791: implement dynamic UI support
Rebased task branch 2026b from P2J trunk revision 10928. Stanislav Lomany
05:11 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Rebased task branch @2606a@ from P2J trunk revision @10928@, new branch revision is @10932@. Eugenie Lyzenko
04:51 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10931@.
This adds the mouse support for GUI selection-list is ...
Eugenie Lyzenko
03:40 PM Feature #1790: implement menu support
Vadim Gindin wrote:
> Next bug is the following:
> @MESSAGE MENU-ITEM mi:NEXT-SIBLING.@ is converted to @message(Me...
Constantin Asofiei
02:29 PM Feature #1790: implement menu support
Next bug is the following:
@MESSAGE MENU-ITEM mi:NEXT-SIBLING.@ is converted to @message(MenuItemWidget.findMenuItem...
Vadim Gindin
09:52 AM Feature #1790: implement menu support
Constantin, mnemonics do not work for me.. Vadim Gindin
08:34 AM Feature #1790: implement menu support
Constantin Asofiei wrote:
> Also, in GUI, why is this code in @Window.afterConfigUpdate@:
> [...]
> This will keep...
Vadim Gindin

08/22/2015

04:14 PM Feature #1811: implement the AJAX client driver
> ... Maybe there is some problem in reading the binary int32/int16.
Constantin, our functions to read and write int...
Sergey Ivanovskiy
03:55 PM Feature #1811: implement the AJAX client driver
Committed revision 10944. Fixed by sending non-premultiplied images pixels and calculating the middle value from an i... Sergey Ivanovskiy
08:32 AM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> Greg Shah wrote:
> > ... and the drawing of the window border.
> I don't think the win...
Constantin Asofiei
08:08 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> ... and the drawing of the window border.
I don't think the window border is being drawn explici...
Constantin Asofiei
07:57 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> I can't find any issues with the @draw3DRect()@ or @drawPolygon()@. The implementation works as ...
Constantin Asofiei
07:41 AM Feature #1791: implement dynamic UI support
Please review task branch 2026b revision 10939. Stanislav Lomany
03:35 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> Constantin, could you have a look at my CHUI implementation. I faced with the following bug: w...
Constantin Asofiei
03:19 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > Please take the changes from branch 1794c rev 10927 - I will me...
Constantin Asofiei

08/21/2015

07:24 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10930@.
This update adds support for multiple selection mode i...
Eugenie Lyzenko
09:07 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10929@.
This is very base selection-list implementation for si...
Eugenie Lyzenko
04:22 PM Feature #1811: implement the AJAX client driver
> 1. Initialize the image drawing buffer using @getImageData()@ to ensure that the original canvas contents are alrea... Sergey Ivanovskiy
04:03 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Hmm, looking at the console there are no errors. But the clipping coordinates are not always the...
Constantin Asofiei
04:01 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> I was a bit surprised that you integrated the mechanism with the drawing ops. It seems to me that...
Constantin Asofiei
03:41 PM Feature #1811: implement the AJAX client driver
Hmm, looking at the console there are no errors. But the clipping coordinates are not always the same as the ones lo... Greg Shah
03:22 PM Feature #1811: implement the AJAX client driver
I can't find any issues with the @draw3DRect()@ or @drawPolygon()@. The implementation works as expected in all the ... Greg Shah
02:01 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10940
This is a really good update. I'll be interested to see how the widge...
Greg Shah
01:06 PM Feature #1811: implement the AJAX client driver
I see something interesting in my debugging. I set a breakpoint in @draw3DRect()@ and ran the client. The first tim... Greg Shah
01:01 PM Feature #1811: implement the AJAX client driver
Greg, rev 10940 contains first pass at mouse support. Currently, the entire window area is registered for all mouse ... Constantin Asofiei
12:09 PM Feature #1811: implement the AJAX client driver
> There still exists another problem that was unseen before how to do the image background consistent with the curren... Greg Shah
11:53 AM Feature #1811: implement the AJAX client driver
Greg, please review the image resize fix committed revision 10939. There still exists another problem that was unseen... Sergey Ivanovskiy
10:24 AM Feature #1811: implement the AJAX client driver
The canvas line stroking state will definitely affect @drawRoundRect()@, because the corners are only rendered via th... Greg Shah
09:10 AM Feature #1811: implement the AJAX client driver
> Now we have additional properties strokeStyle and strokeWidth, is it true that lineWidth and strokeWidth should hav... Greg Shah
09:08 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Constantin: Do you think the keyboard improvements should be done before the mouse support? I'll...
Constantin Asofiei
09:01 AM Feature #1811: implement the AJAX client driver
Greg, I am doing 3 and 4. From my previous task there are the following unresolved issues. Now we have additional pro... Sergey Ivanovskiy
08:31 AM Feature #1811: implement the AJAX client driver
It looks to me like we have the following drawing problems:
1. The draw 3D rectangle is badly broken.
2. The fill...
Greg Shah
08:28 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> I never get the press ESC to exit the application when I run our Swing client or the web GUI. Is...
Constantin Asofiei
08:25 AM Feature #1811: implement the AJAX client driver
> Have you managed to press ESC key to terminate the app?
I think the current keyboard code is ChUI-specific. In ...
Greg Shah
08:15 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> By the way, the key processing works. Pressing space, cleanly exits the app.
Have you managed to...
Constantin Asofiei
08:14 AM Feature #1811: implement the AJAX client driver
With those changes (see rev 10938), we get this:
!better_drawing_polygons.png!
The polygon outline overdrawing ...
Greg Shah
08:11 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> I think the fill portion of the @drawPolygon()@ should not have any origin translation applied. ...
Constantin Asofiei
08:05 AM Feature #1811: implement the AJAX client driver
@drawRoundRect()@ has the same issue I think. It doesn't need the origin translation applied. Greg Shah
08:03 AM Feature #1811: implement the AJAX client driver
I think the fill portion of the @drawPolygon()@ should not have any origin translation applied. The reason is that t... Greg Shah
07:59 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Constantin: please check in your @p2j.screen.js@ changes.
Committed to 1811q rev 10937.
Constantin Asofiei
07:51 AM Feature #1811: implement the AJAX client driver
Sergey: you get "extra points" for being creative in using the built-in canvas APIs to figure out the current transla... Greg Shah
06:40 AM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> And the modified p2j.screen.js used to get the drawing in note 938.
To resume the chang...
Constantin Asofiei
06:25 AM Feature #1811: implement the AJAX client driver
Constantin, agree with you
> Explicitly maintaining the window translated origin provides better results.
Sergey Ivanovskiy
06:17 AM Feature #1811: implement the AJAX client driver
And the modified p2j.screen.js used to get the drawing in note 938. Constantin Asofiei
06:16 AM Feature #1811: implement the AJAX client driver
Explicitly maintaining the window translated origin provides better results.
!better_drawing.png!
Constantin Asofiei
06:11 AM Feature #1811: implement the AJAX client driver
I found the way to determine translation coordinates
ctx.beginPath();
ctx.rect(0, 0, 1, 1);...
Sergey Ivanovskiy
05:35 AM Feature #1811: implement the AJAX client driver
CanvasRenderingContext2D.currentTransform isn't supported by firefox, only chrome (https://developer.mozilla.org/en-U... Sergey Ivanovskiy
05:12 AM Feature #1811: implement the AJAX client driver
Constantin, you are right translate operations don't influence putImage results.
https://developer.mozilla.org/en-US...
Sergey Ivanovskiy
04:24 AM Feature #1811: implement the AJAX client driver
Sergey/Greg: I think the drawing corruption is related to the fact that when drawing pixels, this is not aware of the... Constantin Asofiei
04:10 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> The drawing is not 100% correct yet. Also there is some kind of problem interpreting the drawing...
Constantin Asofiei
04:05 PM Feature #1790: implement menu support
Constantin Asofiei wrote:
> Please take the changes from branch 1794c rev 10927 - I will merge it to trunk later tod...
Vadim Gindin
12:54 PM Feature #1790: implement menu support
Constantin, could you have a look at my CHUI implementation. I faced with the following bug: when sub-menu is hiding ... Vadim Gindin
03:48 PM Feature #1791: implement dynamic UI support
Stanislav, go ahead and disable the pushScreenLock/Unlock completely - comment out the code in @embedded_attribute_as... Constantin Asofiei
02:13 PM Feature #1791: implement dynamic UI support
Rebased task branch 2026a from P2J trunk revision 10927. Stanislav Lomany
01:39 PM Feature #1791: implement dynamic UI support
@realized@ is set on the client side. Well, I can check @locked && visible && !realized@ on the server side, but woul... Stanislav Lomany
07:56 AM Feature #1791: implement dynamic UI support
Stanislav Lomany wrote:
> @func()@ is just a way to show that assignments are executed one by one. The differences I...
Constantin Asofiei
05:58 AM Feature #1791: implement dynamic UI support
@func()@ is just a way to show that assignments are executed one by one. The differences I'm taking about is that aft... Stanislav Lomany
05:52 AM Feature #1791: implement dynamic UI support
Stanislav Lomany wrote:
> Unfortunately I think this optimization is incorrect. I will turn it off for browse becaus...
Constantin Asofiei
05:16 AM Feature #1791: implement dynamic UI support
Unfortunately I think this optimization is incorrect. I will turn it off for browse because of the behavior differenc... Stanislav Lomany
02:40 AM Feature #1791: implement dynamic UI support
Stanislav Lomany wrote:
> I mean the following:
> 1. A testcase that includes @pushScreenLock@ after conversion (i....
Constantin Asofiei
03:24 PM Feature #2252: implement GUI client support
Rebased task branch 2424c from P2J trunk revision 10927 (branch revision 10943). Hynek Cihlar

08/20/2015

05:33 PM Feature #1791: implement dynamic UI support
I mean the following:
1. A testcase that includes @pushScreenLock@ after conversion (i.e. testcase should have CREAT...
Stanislav Lomany
05:26 PM Feature #1791: implement dynamic UI support
Stanislav Lomany wrote:
> Constantin, can you provide a testcase that fails without @pushScreenLock/Unlock@?...
Constantin Asofiei
05:23 PM Feature #1791: implement dynamic UI support
Constantin, can you provide a testcase that fails without @pushScreenLock/Unlock@? Stanislav Lomany
04:59 PM Feature #1791: implement dynamic UI support
Greg/Stanislav: the usage of the @GenericWidget.frame@ field (throughout the server-side widget sub-classes) should b... Constantin Asofiei
04:40 PM Feature #1791: implement dynamic UI support
Stanislav Lomany wrote:
> Guys, I want to have a conversation about @pushScreenLock/pushScreenUnlock@. AFAIK what it...
Constantin Asofiei
04:34 PM Feature #1791: implement dynamic UI support
Stanislav Lomany wrote:
> > > There is no need to do it explicitly, it is done automatically in @pushScreenDefinitio...
Hynek Cihlar
04:21 PM Feature #1791: implement dynamic UI support
> > There is no need to do it explicitly, it is done automatically in @pushScreenDefinitions@ trip.
>
> Interestin...
Stanislav Lomany
04:04 PM Feature #1791: implement dynamic UI support
Guys, I want to have a conversation about @pushScreenLock/pushScreenUnlock@. AFAIK what it does is deferring @pushScr... Stanislav Lomany
03:30 PM Feature #1791: implement dynamic UI support
Stanislav Lomany wrote:
> > For the case when it is set on the client a similar logic must execute on the server.
>...
Hynek Cihlar
03:12 PM Feature #1791: implement dynamic UI support
> For the case when it is set on the client a similar logic must execute on the server.
There is no need to do it ...
Stanislav Lomany
02:56 PM Feature #1791: implement dynamic UI support
Indeed, the management of @realized@ flag is a bit messy.
Stanislav, your solution seems to be ok when @visible@ ...
Hynek Cihlar
02:32 PM Feature #1791: implement dynamic UI support
I don't know the answer to the question in note 287. It seems OK to me.
Constantin/Hynek: what do you think?
Greg Shah
05:22 PM Feature #1811: implement the AJAX client driver
I've just checked in revision 10935 which has many, many fixes. Some of the problems were caused by unqualified refer... Greg Shah
01:15 PM Feature #1811: implement the AJAX client driver
Greg, I fixed 1 and 2 in the committed revision 10934. Let me look at 3 and 4 due to we have no working example. To e... Sergey Ivanovskiy
11:11 AM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10932
This is really good. Note that I did check in some minor formatting ...
Greg Shah
10:45 AM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10931
It looks good. The only thing to change is that @ChuiWebDriver.waitI...
Greg Shah
10:42 AM Feature #1811: implement the AJAX client driver
Greg, please review the committed revision 10932. Sergey Ivanovskiy
10:10 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> > to fix the page-loading race issue I've added a new message type MSG_PAGE_LOADED = 0xFF
>
>...
Constantin Asofiei
09:15 AM Feature #1811: implement the AJAX client driver
> to fix the page-loading race issue I've added a new message type MSG_PAGE_LOADED = 0xFF
Nice work! This sounds...
Greg Shah
08:54 AM Feature #1811: implement the AJAX client driver
Greg, to fix the page-loading race issue I've added a new message type @MSG_PAGE_LOADED = 0xFF@:
# @p2j.js@ will cal...
Constantin Asofiei
06:39 AM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> > Function @drawPixel@ I think has more issues; even if I set @this.pixData@, it still do...
Constantin Asofiei
06:35 AM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> But it still bugs me that sometimes the initial createFont call never gets executed: is...
Constantin Asofiei
06:29 AM Feature #1811: implement the AJAX client driver
> Function @drawPixel@ I think has more issues; even if I set @this.pixData@, it still doesn't work, because @pixData... Sergey Ivanovskiy
06:15 AM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> It is due to ctx must be changed to this.ctx and pixData to this.pixData. The draw method...
Constantin Asofiei
04:56 AM Feature #1811: implement the AJAX client driver
It is due to ctx must be changed to this.ctx and pixData to this.pixData. The draw method of Window class have many s... Sergey Ivanovskiy
04:48 AM Feature #1811: implement the AJAX client driver
Sergey, I get these JS errors in the console:... Constantin Asofiei
04:37 AM Feature #1811: implement the AJAX client driver
Greg, I've committed to rev 10929 some more fixes related to font creation/initialization. This time the web client ... Constantin Asofiei
11:12 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Rebased task branch @2606a@ from P2J trunk revision @10927@, new branch revision is @10928@. Eugenie Lyzenko
05:29 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Created task branch 2567b Igor Skornyakov
05:09 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Merged to trunk rev. 10927 Igor Skornyakov
04:42 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
I assume the conversion testing has passed? If so, you can merge branch 2567a and also commit the baseline changes - ... Constantin Asofiei
04:32 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Rebased task branch 2567a from P2J trunk revision 10926 (new branch revision 10960). Igor Skornyakov
04:19 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> All regression tests except @tc_job_002@ passed (not all in one run, but the intersection o...
Constantin Asofiei
04:18 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
All regression tests except @tc_job_002@ passed (not all in one run, but the intersection of sets of failed tests in ... Igor Skornyakov

08/19/2015

05:16 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> > Next step would be to debug into p2j.fonts.js createFont and see if it manages to finish proper...
Constantin Asofiei
04:50 PM Feature #1811: implement the AJAX client driver
> Next step would be to debug into p2j.fonts.js createFont and see if it manages to finish properly and if the fontTa... Greg Shah
04:48 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> > Are there any messages in the console (CTRL-SHIFT-K for firefox)?
>
> Nothing useful. There...
Constantin Asofiei
04:39 PM Feature #1811: implement the AJAX client driver
> Are there any messages in the console (CTRL-SHIFT-K for firefox)?
Nothing useful. There are just some comments ...
Greg Shah
04:28 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> My next problem is this:
>
> [...]
>
> When the client processes the MSG_GET_FONT_WIDTHS me...
Constantin Asofiei
04:11 PM Feature #1811: implement the AJAX client driver
Some points about my setup:
1. I converted a simple @hello.p@ and I'm using @...Hello.execute@ as my entry point i...
Greg Shah
04:04 PM Feature #1811: implement the AJAX client driver
I've started trying to get the GUI web client running here. My thought is to test out the simplest hello world GUI p... Greg Shah
03:01 PM Feature #1811: implement the AJAX client driver
Fixed stroke drawing, the dash strokes performance becomes no more that 10 times slower than native performance for s... Sergey Ivanovskiy
10:57 AM Feature #1811: implement the AJAX client driver
By the way, the hit-testing implementation will have to be custom built by us. The @CanvasRenderingContext2D.isPoint... Greg Shah
10:54 AM Feature #1811: implement the AJAX client driver
> Line Stroking Review
> 1... That approach works fine in the simple example, where there is nothing already there t...
Sergey Ivanovskiy
10:48 AM Feature #1811: implement the AJAX client driver
> What I'm suggesting is for the driver to know which rectangles (in a window) can react to which mouse events. In ca... Greg Shah
10:37 AM Feature #1811: implement the AJAX client driver
A note for record keeping: the JS side needs implementation for the font aliases and underline font style. Constantin Asofiei
10:35 AM Feature #1811: implement the AJAX client driver
Greg, about the mouse events. For the Swing implementation the call chain for a mouse event looks like this:
# @Mou...
Constantin Asofiei
10:23 AM Feature #1811: implement the AJAX client driver
Line Stroking Review
This is really, really good! Go ahead and make your changes to 1811q to add stroking. Some ...
Greg Shah
09:33 AM Feature #1811: implement the AJAX client driver
Greg, please review, added strokes test and implemented SPECIFIED_WIDTH stroke style, it is a very first coming imple... Sergey Ivanovskiy
08:49 AM Feature #1811: implement the AJAX client driver
> the first uses java 2D api, the second - native browser api and the third - custom jscript implementation that is a... Greg Shah
09:10 PM Feature #1811: implement the AJAX client driver
Greg, 3 pictures, the first uses java 2D api, the second - native browser api and the third - custom jscript impleme... Sergey Ivanovskiy
04:51 PM Bug #2654: Making a widget VISIBLE displays the parent frame
In 4GL setting @VISIBLE@ attribute of a widget to @true@ displays the parent frame. In P2J - doesn't. The full set of... Stanislav Lomany
04:45 PM Bug #2654 (New): Making a widget VISIBLE displays the parent frame
Stanislav Lomany
04:38 PM Feature #1791: implement dynamic UI support
Guys, at this point @config.realized@ is set in @AbstractWidget._setVisible@. Setting of @config.visible@ attribute d... Stanislav Lomany
01:04 PM Feature #1791: implement dynamic UI support
Constanin, thanks, I'll make reference to this task there.
OK, here is the correct set of rules:
1. Browse is "re...
Stanislav Lomany
03:57 AM Feature #1791: implement dynamic UI support
Stanislav Lomany wrote:
> As I suggested, concept of "realized" browse (used in "Unable to set ATTRIBUTE because the...
Constantin Asofiei
10:27 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Rebased task branch @2606a@ from P2J trunk revision @10926@, new branch revision is @10927@. Eugenie Lyzenko
08:55 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10925@.
This is just placeholder for selection-list implementa...
Eugenie Lyzenko
10:01 AM Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review Task Branch 2563c Revision 10928
>
> It looks good. You can merge to trunk.
Merg...
Constantin Asofiei
09:54 AM Feature #2252: implement GUI client support
Code Review Task Branch 2563c Revision 10928
It looks good. You can merge to trunk.
Greg Shah
09:41 AM Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review Task Branch 2563c Revision 10926
>
> I'm fine with the changes. You can merge to ...
Constantin Asofiei
08:54 AM Feature #2252: implement GUI client support
Code Review Task Branch 2563c Revision 10926
I'm fine with the changes. You can merge to trunk.
Greg Shah
08:47 AM Feature #2252: implement GUI client support
There is a regression in trunk in the MAJIC function browser - the highlighted text is not removed from the previous ... Constantin Asofiei
09:36 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
In this run all @gso_tests@ passed. Some tc_tests failed (tc_gl_rpts_007, tc_codes_employees_010, tc_codes_employees_... Igor Skornyakov
05:24 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Well, it seems that I did something wrong in a hurry. The manual test passed OK.
Restarted regression test.
Igor Skornyakov
05:05 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> Some notes about how FocusManager.focusChange works:
> # it performs a temporary focus ...
Igor Skornyakov
04:47 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Some notes about how FocusManager.focusChange works:
# it performs a temporary focus change - for browse case, this ...
Constantin Asofiei
04:07 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> The protection logic doesn't seem OK... I wonder if we really ...
Igor Skornyakov
03:55 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> Well, actually my last change appears to be wrong as well. @gso_216@ fails anyway but at a ...
Constantin Asofiei
08:46 AM Feature #1794: implement font support
Merged to trunk rev 10925, notification email sent and branch 1794c archived.
Constantin Asofiei
08:36 AM Feature #1794: implement font support
Code Review Task branch 1794c Revision 10927
I'm fine with the changes, except @SwingGuiDriver@ needs a history en...
Greg Shah
03:50 AM Feature #1794: implement font support
Rev 10927 contains support for underline fonts. No support for drawing text with partially underlined text yet at th... Constantin Asofiei
03:49 AM Feature #1790: implement menu support
And something else: you can split the menu text drawing in three parts: draw prefix, draw mnemonic, draw suffix. Constantin Asofiei
03:47 AM Feature #1790: implement menu support
Please take the changes from branch 1794c rev 10927 - I will merge it to trunk later today.
If the mnemonic really u...
Constantin Asofiei
03:31 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> Constantin Asofiei wrote:
> ..
> > BTW, have you determined what font is used for the mnemon...
Constantin Asofiei
01:46 AM Feature #1790: implement menu support
Constantin Asofiei wrote:
..
> BTW, have you determined what font is used for the mnemonics?
I didn't speciall...
Vadim Gindin

08/18/2015

04:18 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Well, actually my last change appears to be wrong as well. @gso_216@ fails anyway but at a later step. So I decided t... Igor Skornyakov
03:08 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > A "protection logic" added to the @Browse.nextFocus()@ was t...
Igor Skornyakov
02:56 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> A "protection logic" added to the @Browse.nextFocus()@ was too rude. A more delicate versio...
Constantin Asofiei
11:07 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
A "protection logic" added to the @Browse.nextFocus()@ was too rude. A more delicate version was implemented.
Comm...
Igor Skornyakov
08:50 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
> Stanislav, this change is related to browse widget in editing mode; can you suggest a test to check if editing brow... Stanislav Lomany
06:41 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > Committed to the branch 2567a, revno 10953.
> Review rev 10...
Igor Skornyakov
06:37 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> Committed to the branch 2567a, revno 10953.
Review rev 10953:
# Browse.java:
- you need ...
Constantin Asofiei
06:19 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
The failed test is @gso_216@. The @Browse.nextFocus()@ detaches current focus which is not correct for a temporary fo... Igor Skornyakov
03:47 PM Feature #2546 (Closed): implement combo-box widget in GUI
Greg Shah
03:09 PM Feature #2546: implement combo-box widget in GUI
Greg Shah wrote:
> If I understand correctly, all work defined for this task is complete. Correct?
Yes, I've fin...
Eugenie Lyzenko
02:43 PM Feature #2546: implement combo-box widget in GUI
If I understand correctly, all work defined for this task is complete. Correct? Greg Shah
02:13 PM Feature #2546: implement combo-box widget in GUI
The @2646c@ has been merged into trunk as revision @10924@. Then archived. Eugenie Lyzenko
02:03 PM Feature #2546: implement combo-box widget in GUI
Please merge 2546c to trunk. Greg Shah
01:43 PM Feature #2546: implement combo-box widget in GUI
The testing completed, no regressions. The results file is @2546c_10926_16cd2a2_20150818_evl.zip@.
So the @2546c@ ...
Eugenie Lyzenko
11:53 AM Feature #2546: implement combo-box widget in GUI
The main part for @2546c@ has been completed without regressions. Waiting for @CTRL-C@ one to be done. Eugenie Lyzenko
03:28 PM Feature #1794: implement font support
Rebased branch 1794c from trunk rev 10924 (new branch rev 10926). Constantin Asofiei
03:26 PM Feature #2252: implement GUI client support
Rebased branch 2451d from trunk rev 10924 (new branch rev 10926). Rev 10927 contains right-trimming of numeric fill... Constantin Asofiei
12:30 PM Feature #2252: implement GUI client support
Greg Shah wrote:
> I think the dual-implementation is purely historical. Sergey Yevtushenko wrote the original @Vie...
Hynek Cihlar
09:56 AM Feature #2252: implement GUI client support
I think the dual-implementation is purely historical. Sergey Yevtushenko wrote the original @ViewPort@ when we were ... Greg Shah
05:27 AM Feature #2252: implement GUI client support
It seems we have two classes that implement the "viewport" part of the widget scrolling feature - @Viewport@ and @Scr... Hynek Cihlar
01:22 PM Feature #1811: implement the AJAX client driver
I have taken a look at the line stroke test. It definitely looks quite interesting, but it is hard for me to determi... Greg Shah
12:49 PM Feature #1811: implement the AJAX client driver
Greg, please look at the line stroke test, the native implementation is able to represent small thin dots style, and ... Sergey Ivanovskiy
09:14 AM Feature #1811: implement the AJAX client driver
Greg, don't take it in account because it is due to pixel data is not cached in my test. Sergey Ivanovskiy
09:02 AM Feature #1811: implement the AJAX client driver
Greg, the performance issues have startled me, the usability test is not finished yet, but please look at the perform... Sergey Ivanovskiy
08:33 AM Feature #1811: implement the AJAX client driver
>> 1. Why is import org.eclipse.jetty.websocket.api.annotations.WebSocket; needed in GuiWebSocket?
>
> GuiWebSocket...
Greg Shah
08:30 AM Feature #1811: implement the AJAX client driver
Constantin: please implement mouse event support next. Consider the performance aspects. Minimize the number of roun... Greg Shah
04:34 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Code Review Task Branch 1811q Revision 10925
>
> The changes look good.
>
> 1. I think the ...
Constantin Asofiei
11:59 AM Feature #1791: implement dynamic UI support
> For browse rules are: if the FRAME attribute is set, it is "realized" when VISIBLE is set. Otherwise it is "realize... Greg Shah
10:50 AM Feature #1791: implement dynamic UI support
As I suggested, concept of "realized" browse (used in "Unable to set ATTRIBUTE because the BROWSE widget has been rea... Stanislav Lomany

08/17/2015

06:00 PM Feature #2252: implement GUI client support
Created branch 2451d from trunk rev 10923. Branch rev 10924/10925 is meant to fix some issues related to positioning... Constantin Asofiei
05:33 PM Feature #2252: implement GUI client support
Created branch 2563c from trunk rev 10923 with a fix for the editor drawing issue: @EditorGuiImpl.refresh@ must call ... Constantin Asofiei
05:20 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> I'm reviewing the current z-order implementation in the GUI client. Some thoughts:
>
> 1. @Gu...
Constantin Asofiei
04:09 PM Feature #1811: implement the AJAX client driver
I'm reviewing the current z-order implementation in the GUI client. Some thoughts:
1. @GuiDriver.isOnTop()@ is no...
Greg Shah
02:22 PM Feature #1811: implement the AJAX client driver
> Yes. Consider that we may have to add stroke styles in the future. And it is possible that we will have to use st... Sergey Ivanovskiy
10:40 AM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10925
The changes look good.
1. I think the call to @getFontHeight()@ in...
Greg Shah
10:27 AM Feature #1811: implement the AJAX client driver
> Do you want to implement supports of this 4 style to draw rectangles shapes? We are using only rectangle shapes wit... Greg Shah
10:22 AM Feature #1811: implement the AJAX client driver
Greg, please could clarify line stroke task. We can't use canvas native strokes because of lines and rectangles shape... Sergey Ivanovskiy
08:12 AM Feature #1811: implement the AJAX client driver
The changes for paragraph layout/drawing are in rev 10925. Constantin Asofiei
08:04 AM Feature #1811: implement the AJAX client driver
You can commit it now. Greg Shah
07:37 AM Feature #1811: implement the AJAX client driver
Greg, I've integrated the JS code from note 884 into p2j.screen.js and p2j.socket.js - let me know when I can commit it. Constantin Asofiei
04:58 PM Feature #1790: implement menu support
Vadim Gindin wrote:
> Short question: I need to draw mnemonics using underlined font. I set @FontStyle.UNDERLINE@ fo...
Constantin Asofiei
04:46 PM Feature #1790: implement menu support
I'll fix these remarks these days. Short question: I need to draw mnemonics using underlined font. I set @FontStyle.U... Vadim Gindin
10:18 AM Feature #1790: implement menu support
Code Review Task Branch 1790e Revision 10922
1. The @methods_attributes.rules@ change should be in the @load_descr...
Greg Shah
09:51 AM Feature #1790: implement menu support
> By the way there is another one conversion bug: ';' remained in converted code for "ACCELERATOR" attribute.
Ple...
Greg Shah
04:17 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Added NPE rethrow as per Constantin's suggestion.
Committed to the branch 2567a, revno 10952.
Regression test ...
Igor Skornyakov
09:05 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> Igor, please change the TC.processEventsWorker:14596 so that the NPE is re-thrown, not c...
Igor Skornyakov
08:19 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor, please change the TC.processEventsWorker:14596 so that the NPE is re-thrown, not consumed. After this, re-star... Constantin Asofiei
02:33 PM Feature #1801: add some frame options
All references to IDE-PARENT-HWND and IDE-WINDOW-TYPE have been removed from the current project. Do NOT implement s... Greg Shah
01:34 PM Feature #2546: implement combo-box widget in GUI
>
> BTW, I assume that the tests I've posted in note 241 and 130 are OK now, correct?
Yes, the widget size in pi...
Eugenie Lyzenko
01:22 PM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Task branch @2546c@ for review updated to revision @10926@.
>
> This is the final cleanu...
Constantin Asofiei
11:13 AM Feature #2546: implement combo-box widget in GUI
Task branch @2546c@ for review updated to revision @10926@.
This is the final cleanup/adjustment candidate. Please...
Eugenie Lyzenko
11:19 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Please add @SCROLL-TO-ITEM()@ method support as part of this task. Greg Shah
10:18 AM Bug #2641: ENABLE ALL should be able to display an empty frame
Testcase:... Stanislav Lomany
10:12 AM Bug #2641 (New): ENABLE ALL should be able to display an empty frame
Stanislav Lomany
09:34 AM Bug #2640: NPE in registerPersistentTrigger
Testcase:... Stanislav Lomany
09:33 AM Bug #2640 (New): NPE in registerPersistentTrigger
Stanislav Lomany
06:56 AM Feature #1794: implement font support
Rebased branch 1794c from trunk rev 10923 (new branch rev 10925).
Constantin Asofiei

08/16/2015

07:50 PM Feature #1791: implement dynamic UI support
Rebased task branch 2026b from P2J trunk revision 10923. Stanislav Lomany
09:29 AM Feature #1790: implement menu support
Greg, thank you, I fixed it at the day before yesterday. By the way there is another one conversion bug: ';' remained... Vadim Gindin
03:22 AM Feature #2252: implement GUI client support
Rebased task branch 2424c from P2J trunk revision 10923 (branch revision 10930). Hynek Cihlar

08/15/2015

05:14 PM Feature #1811: implement the AJAX client driver
This is a demo for the paragraph drawing - it follows the same rules as the Swing implementation. Constantin Asofiei
01:12 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> Have you seen it before testing branch 2567b? Because looks like a regression related t...
Igor Skornyakov
12:45 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Were there some tests failed with this issue? Is it from the...
Constantin Asofiei
12:37 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> Were there some tests failed with this issue? Is it from the CTRL-C part? Because I don'...
Igor Skornyakov
12:33 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Igor Skornyakov wrote:
> > > Please find the log attached
...
Constantin Asofiei
09:11 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > Please find the log attached
> And where did you see this? ...
Igor Skornyakov
07:57 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> Please find the log attached
And where did you see this? In MAJIC testing or somewhere else?
Constantin Asofiei
06:39 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > I've noticed that NPE is frequently happens in the @FillIn@ ...
Igor Skornyakov
06:34 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> I've noticed that NPE is frequently happens in the @FillIn@ line 1211:
>
> [...]
>
> ...
Constantin Asofiei
05:26 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Rebased task branch 2567a from P2J trunk revision 10923 (new branch revision 10951).
Ready to merge, however the u...
Igor Skornyakov
05:09 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
ctrl-c tests passed. Can I commit 2567a and updated tests?
Thank you.
Igor Skornyakov
03:48 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
I've noticed that NPE is frequently happens in the @FillIn@ line 1211:... Igor Skornyakov
03:39 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
After last changes in tests' parameters all main tests (except @tc_job_002@) passed OK. However in @gso_ctrlc_3way_te... Igor Skornyakov
07:01 AM Feature #2546: implement combo-box widget in GUI
Rebased task branch @2546c@ from P2J trunk revision @10923@, new branch revision is @10925@. Eugenie Lyzenko
08:49 PM Feature #2546: implement combo-box widget in GUI
Task branch @2546c@ for review updated to revision @10923@.
This is the candidate. The entry field now also uses t...
Eugenie Lyzenko

08/14/2015

04:57 PM Feature #1811: implement the AJAX client driver
> 1. Why is @import org.eclipse.jetty.websocket.api.annotations.WebSocket;@ needed in @GuiWebSocket@?
GuiWebSocket ex...
Sergey Ivanovskiy
03:34 PM Feature #1811: implement the AJAX client driver
Code Review Task Brnach 1811q Revision 10923
The custom font support looks good.
Greg Shah
03:29 PM Feature #1811: implement the AJAX client driver
Code Review Task Brnach 1811q Revision 10922
The cursor style changes look good. I only have these minor question...
Greg Shah
02:50 PM Feature #1811: implement the AJAX client driver
Revision 10923 contains the changes for custom fonts in the web client. It contains the @@font-face@ approach with t... Constantin Asofiei
02:45 PM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> Greg, I have some changes in p2j.fonts.js and p2j.socket.js related to custom font def -...
Greg Shah
02:42 PM Feature #1811: implement the AJAX client driver
Greg, I have some changes in p2j.fonts.js and p2j.socket.js related to custom font def - may I commit them? Constantin Asofiei
02:39 PM Feature #1811: implement the AJAX client driver
The attached example shows that only the resize operation requires us to redraw bits that were already drawn to the c... Greg Shah
08:41 AM Feature #1811: implement the AJAX client driver
Committed to 1811q, cursor style changes, rev 10922. Sergey Ivanovskiy
07:21 AM Feature #1811: implement the AJAX client driver
MAJIC regression testing has passed for task branch 1811o. Manual Swing GUI testing and manual ChUI web testing did ... Greg Shah
04:00 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
> I suggest to reduce the minimum value to 20. I will do it now and restart tests. If this will help the tests in th... Greg Shah
03:53 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Well, in this run there are no miracles. The tests which failed before failed again. However with the new version of ... Igor Skornyakov
10:14 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Rebased task branch 2567a from P2J trunk revision 10921 (new branch revision 10949).
Regression tests restarted
Igor Skornyakov
10:00 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Before you run testing again, perhaps it is a good time to rebase? I think if the next run goes ...
Igor Skornyakov
09:58 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Before you run testing again, perhaps it is a good time to rebase? I think if the next run goes well (and doesn't ov... Greg Shah
09:36 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
This is really strange but after (I'm not sure that because of) the harness test change (#2639) the results of the re... Igor Skornyakov
08:08 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Agreed.
>
> Please create a new task in the Harness project. Post this information, create a ...
Igor Skornyakov
08:05 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Agreed.
Please create a new task in the Harness project. Post this information, create a task branch and get this...
Greg Shah
05:04 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
It seems that there is a misprint in the @com.goldencode.harness.test.SendKey@. The format specification @SPEC3@ is:
...
Igor Skornyakov
10:05 AM Feature #2546: implement combo-box widget in GUI
Rebased task branch @2546c@ from P2J trunk revision @10921@, new branch revision is @10922@. Eugenie Lyzenko
04:16 AM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Task branch @2546c@ for review updated to revision @10921@.
The approach looks good - this...
Constantin Asofiei
09:20 PM Feature #2546: implement combo-box widget in GUI
Task branch @2546c@ for review updated to revision @10921@.
The idea behind is as I know the base for size measure...
Eugenie Lyzenko
03:35 AM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek, about @SwingEmulatedWindow.layoutParagraphWorker@ (we need an equivalent for the ...
Hynek Cihlar

08/13/2015

07:48 PM Feature #1811: implement the AJAX client driver
Main regression testing has passed on the 2nd run (only GSO 237 failed, which passed on the 1st run, so this is consi... Greg Shah
04:54 PM Feature #1811: implement the AJAX client driver
Sergey: your next task is to implement line stroke support. To review our current implementation, please search on @... Greg Shah
04:37 PM Feature #1811: implement the AJAX client driver
Greg, please review my cursor local changes. Sergey Ivanovskiy
04:28 PM Feature #1811: implement the AJAX client driver
Please do NOT commit any changes to 1811o. If it passes regression testing, I am going to merge revision 10962 to tr... Greg Shah
04:22 PM Feature #1811: implement the AJAX client driver
Greg, would you mind if I committed the cursor changes in 1811o? Sergey Ivanovskiy
03:35 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> > but I haven't considered something: this duplicates the font definition both in the browser's p...
Constantin Asofiei
03:27 PM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> Greg, this is a demo how to use @font-face@ to dynamically define a font. @base64@ works...
Greg Shah
03:11 PM Feature #1811: implement the AJAX client driver
The first main regression testing run has completed. The only failures are tc_dc_slot_025, tc_job_clock_002 and tc_p... Greg Shah
01:41 PM Feature #1811: implement the AJAX client driver
Greg
> > Thus I excluded menu/simple_sm.p because the conversion for it is failed.
>
> We don't have any conversi...
Sergey Ivanovskiy
01:27 PM Feature #1811: implement the AJAX client driver
Constantin
> > For all other tests if it gets another key instead of SPACE the test becomes frozen (may be deadlock)
...
Sergey Ivanovskiy
01:15 PM Feature #1811: implement the AJAX client driver
> Thus I excluded menu/simple_sm.p because the conversion for it is failed.
We don't have any conversion changes i...
Greg Shah
01:09 PM Feature #1811: implement the AJAX client driver
Greg, this is a demo how to use @font-face@ to dynamically define a font. @base64@ works, but I haven't considered so... Constantin Asofiei
01:07 PM Feature #1811: implement the AJAX client driver
Thus I excluded menu/simple_sm.p because the conversion for it is failed. Please see above the attached log. Sergey Ivanovskiy
12:51 PM Feature #1811: implement the AJAX client driver
Constantin, I need to retest because using old version of the testcase project, now my testcase project is up to date... Sergey Ivanovskiy
12:39 PM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> are failed to start for 1811o:
this is a conversion issue, @three-d@ attribute doesn't ...
Constantin Asofiei
12:22 PM Feature #1811: implement the AJAX client driver
These tests menu/popup_ext.p
window_sizing/create_empty_window.p
window_sizing/default_empty_window.p
window_sizin...
Sergey Ivanovskiy
12:12 PM Feature #1811: implement the AJAX client driver
Greg, all found issues are already in trunk:
movie-ratings-dynamic.p
movie-ratings-static.p
- same as clipboard_...
Constantin Asofiei
11:36 AM Feature #1811: implement the AJAX client driver
simple_sm.p
Sergey Ivanovskiy
11:26 AM Feature #1811: implement the AJAX client driver
Nevermind, I just noticed the @testcases/uast/clipboard/clipboard_basic.p@ has different content... Constantin Asofiei
11:24 AM Feature #1811: implement the AJAX client driver
Greg, I can't convert this test, I get this:... Constantin Asofiei
11:00 AM Feature #1811: implement the AJAX client driver
Constantin, Greg I found a strange behaviour (1811o) of a editor field from my clipboard_basic.p but haven't compared... Sergey Ivanovskiy
10:52 AM Feature #1811: implement the AJAX client driver
OK. I fixed the missing javadoc, added some comments and made some other code formatting cleanups in revision 10962.... Greg Shah
10:17 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Please do a quick code review. If the two of you don't see anything of concern, then I will run ...
Constantin Asofiei
09:46 AM Feature #1811: implement the AJAX client driver
Rebased task branch 1811o from P2J trunk revision 10920. The latest revision is now 10961. This does include some h... Greg Shah
02:34 AM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> We have two messages types related to a cursor, MSG_CURSOR_STATUS to hide it (chui mode) ...
Constantin Asofiei
02:01 AM Feature #1811: implement the AJAX client driver
From https://developer.mozilla.org/en-US/docs/Web/CSS/cursor the modern browsers support all interesting types of pre... Sergey Ivanovskiy
03:43 PM Feature #2252: implement GUI client support
Hynek, about @SwingEmulatedWindow.layoutParagraphWorker@ (we need an equivalent for the web client) - this is suppose... Constantin Asofiei
08:32 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> It looks like if accelerator is specified = than converted Java-code will contain empty line w...
Greg Shah
07:00 AM Feature #1790: implement menu support
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin Asofiei wrote:
> > > Vadim Gindin wrote:
> > > > W...
Hynek Cihlar
06:11 AM Feature #1790: implement menu support
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin Asofiei wrote:
> > > Vadim Gindin wrote:
> > > > W...
Vadim Gindin
04:36 AM Feature #1790: implement menu support
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Vadim Gindin wrote:
> > > Why @ThinClient.pause()@ cleans the ...
Constantin Asofiei
01:37 AM Feature #1790: implement menu support
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Why @ThinClient.pause()@ cleans the message area and status lin...
Hynek Cihlar
08:16 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Eugenie Lyzenko wrote:
> Try to run single @GSO 307@ test after DB restore. What is the result?
>
> In general if...
Igor Skornyakov
07:57 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Try to run single @GSO 307@ test after DB restore. What is the result?
In general if we are not sure the test does...
Eugenie Lyzenko
06:34 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Something strange is going on with the test @gso_307@
With branch 2567a tt consistently fails on step 40 with messag...
Igor Skornyakov
05:17 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Rebased task branch 2567a from P2J trunk revision 10920 (new branch revision 10948). Igor Skornyakov
07:40 AM Feature #2546: implement combo-box widget in GUI
Rebased task branch @2546c@ from P2J trunk revision @10920@, new branch revision is @10920@. Eugenie Lyzenko

08/12/2015

07:12 PM Feature #2546: implement combo-box widget in GUI
Rebased task branch @2546c@ from P2J trunk revision @10919@, new branch revision is @10919@. Eugenie Lyzenko
06:02 PM Feature #1790: implement menu support
It looks like if accelerator is specified = than converted Java-code will contain empty line with the only ';' symbol... Vadim Gindin
05:45 PM Feature #1790: implement menu support
Greg Shah wrote:
> I think that the KW_ACCEL attribute support still needs to be added to @methods_attributes.rules@...
Vadim Gindin
04:17 PM Feature #1790: implement menu support
Vadim Gindin wrote:
> Why @ThinClient.pause()@ cleans the message area and status line only for CHUI (isChui()==true...
Constantin Asofiei
04:16 PM Feature #1790: implement menu support
Ok, I'll fix it.
Why @ThinClient.pause()@ cleans the message area and status line only for CHUI (isChui()==true)? ...
Vadim Gindin
02:56 PM Feature #1790: implement menu support
I think that the KW_ACCEL attribute support still needs to be added to @methods_attributes.rules@. Greg Shah
03:12 PM Feature #1811: implement the AJAX client driver
Sergey: your next task is to investigate cursor management support for the GUI web client. This would be the backing... Greg Shah
03:06 PM Feature #1811: implement the AJAX client driver
Tested web chui client to MAJIC server running on devsrv01 using branch 1811o rev 10950, menus and clipboard selectio... Sergey Ivanovskiy
02:08 PM Feature #1811: implement the AJAX client driver
> I'm inclined in using the font-face tag to register the new font with a base64 encoded of the font bytes passed at... Greg Shah
01:50 PM Feature #1811: implement the AJAX client driver
Revision 10953 contains js-side support for font/text metrics and text drawing; a new @p2j.fonts@ module was added, w... Constantin Asofiei
01:47 PM Feature #1811: implement the AJAX client driver
The following are some very useful articles on CSS z-order and positioning:
http://vanseodesign.com/css/css-positi...
Greg Shah
01:38 PM Feature #1811: implement the AJAX client driver
And the example... Greg Shah
01:37 PM Feature #1811: implement the AJAX client driver
I just checked in revision 10952 which finishes the first pass at window resize. Some factors about resize can be se... Greg Shah
01:32 PM Feature #1811: implement the AJAX client driver
Greg, I have a second pass at the web font work (js-side). May I commit it? Constantin Asofiei
01:31 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811o Revision 10951
It looks good.
Greg Shah
12:40 PM Feature #1811: implement the AJAX client driver
Cleanup the code rev 10951. Sergey Ivanovskiy
10:13 AM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811o Revision 10950
The approach is good. My only concerns are related to coding standar...
Greg Shah
09:42 AM Feature #1811: implement the AJAX client driver
Hynek Cihlar wrote:
> Greg Shah wrote:
> > * @AbstractGuiDriver.setWindowLocation()@. This will cause all pending o...
Greg Shah
07:41 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> * @AbstractGuiDriver.setWindowLocation()@. This will cause all pending ops to be drawn and flushe...
Hynek Cihlar
01:54 PM Feature #1791: implement dynamic UI support
Rebased task branch 2026b from P2J trunk revision 10919. Stanislav Lomany
09:26 AM Feature #1794: implement font support
Rebased branch 1794c from trunk rev 10919 (new branch rev 10921).
Constantin Asofiei

08/11/2015

06:33 PM Feature #1791: implement dynamic UI support
Plus issue:
9. Error on ctrl-c processing.
Stanislav Lomany
09:31 PM Feature #1791: implement dynamic UI support
Stanislav Lomany wrote:
> I'm making changes only to static query case:
> # OPEN QUERY without DEFINE QUERY - no co...
Eric Faulhaber
06:18 PM Feature #1811: implement the AJAX client driver
> currently the web client's drawing is asynchronous. What I'm worried is that, if we give control back to the java s... Greg Shah
06:16 PM Feature #1811: implement the AJAX client driver
> > I did a modified version of @setOwnPropertiesTo()@
Yes, it works properly.
Greg, please review my changes (comm...
Sergey Ivanovskiy
06:10 PM Feature #1811: implement the AJAX client driver
The following are the locations of calls to @EmulatedWindowState.repaint()@:
* @GuiPrimitivesImpl.sync()@ as overr...
Greg Shah
05:49 PM Feature #1811: implement the AJAX client driver
> I did a modified version of @setOwnPropertiesTo()@
This is checked in as revision 10948.
Greg Shah
05:48 PM Feature #1811: implement the AJAX client driver
> please review the fix
Overall, I'm fine with the fixes.
> it follows that style property returns a typed obje...
Greg Shah
10:53 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> I am trying to finish work on resizing (as implemented by @SwingEmulatedWindow.resizeScreenBuffer...
Constantin Asofiei
10:29 AM Feature #1811: implement the AJAX client driver
Greg, please review the fix. From https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/style it follows that ... Sergey Ivanovskiy
08:54 AM Feature #1811: implement the AJAX client driver
> But the clipboard selection in web chui client is broken now, if you are agree I will try to fix it.
Please do.
Greg Shah
08:11 AM Feature #1811: implement the AJAX client driver
Greg, these two units src/com/goldencode/p2j/ui/client/chui/driver/web/res/p2j.clipboard_helpers.js
and src/com/gold...
Sergey Ivanovskiy
03:55 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> 1. In the Swing client @SwingEmulatedWindow.resizeScreenBuffers()@ locks all other threads out an...
Hynek Cihlar
05:45 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Rebased task branch 2567a from P2J trunk revision 10919 (new branch revision 10947). Igor Skornyakov
02:39 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Rebased task branch 2567a from P2J trunk revision 10918 (new branch revision 10946). Igor Skornyakov
07:50 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Regarding @gso_307@
In the template screen the bottom line is @Press any key for corrections or ENTER to print@
In ...
Igor Skornyakov
06:01 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
@gso_289@ failed in the same way as @gso_281@ but manual run passed OK. Igor Skornyakov
05:20 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
After several runs of the regression tests some tests are still failing. I'm analyzing them now and at least some fai... Igor Skornyakov
02:47 PM Feature #1790: implement menu support
Created task branch 1790e from P2J trunk revision 10919. Vadim Gindin
02:26 PM Feature #1790: implement menu support
The branch 1790d has been merged and committed into the trunk as bzr revision 10919. Vadim Gindin
02:17 PM Feature #1790: implement menu support
1790d is rebased with the latest revision. Current branch revision is 10948. Vadim Gindin
01:28 PM Feature #1790: implement menu support
I'm good with the changes. Once you've rebased with 10918 (there will be no conflicts), you can merge to trunk.
D...
Constantin Asofiei
12:20 PM Feature #1790: implement menu support
Please rebase from trunk rev 10918 first, I'll finish the review shortly. Constantin Asofiei
10:45 AM Feature #1790: implement menu support
tc_codes_employees_21, tc_codes_employees_24 are also passed testing. Yes, 1790d is ready for review. Vadim Gindin
10:27 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> First, I rerun full regression testing. Failed test are the following (intersected with previo...
Constantin Asofiei
09:38 AM Feature #1790: implement menu support
First, I rerun full regression testing. Failed test are the following (intersected with previous run): gso_269, tc_co... Vadim Gindin
04:29 AM Feature #1790: implement menu support
One more thing: to avoid checking the tests by hand, you can add the failed tests to @majic_baseline/majic_single.xml... Constantin Asofiei
04:26 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> GSO_206. Strange, but in the test current screen is the different from expected:
This is bec...
Constantin Asofiei
03:49 AM Feature #1790: implement menu support
Please check the test(s) manually (step-by-step) and confirm the error is still there. There might be timeouts somet... Constantin Asofiei
03:37 AM Feature #1790: implement menu support
GSO_206. Strange, but in the test current screen is the different from expected: ... Vadim Gindin
03:09 AM Feature #1790: implement menu support
Regression testing is finished. There are several failed tests: gso_245, gso_206, gso_238, gso_269, tc_codes_employee... Vadim Gindin
03:09 AM Feature #1790: implement menu support
Greg Shah wrote:
> > It looks like menubar is visible before WAIT-FOR - just right after menubar assignment.
>
> ...
Vadim Gindin
12:15 PM Feature #1794: implement font support
Rebased branch 1794c from trunk rev 10918 (new branch rev 10920). Constantin Asofiei

08/10/2015

06:23 PM Feature #1811: implement the AJAX client driver
> please review the changes. Committed revision 10944.
This is significantly better. I like it quite a bit. Ple...
Greg Shah
06:10 PM Feature #1811: implement the AJAX client driver
I am trying to finish work on resizing (as implemented by @SwingEmulatedWindow.resizeScreenBuffers()@ and on @repaint... Greg Shah
05:01 PM Feature #1811: implement the AJAX client driver
Greg, please review the changes. Committed revision 10944. Found conflicts:
Text conflict in src/com/goldencode/p2...
Sergey Ivanovskiy
04:18 PM Feature #1811: implement the AJAX client driver
> If you approve to split this part than I will update my local branch and commit into 1811o.
You can commit now.
Greg Shah
04:03 PM Feature #1811: implement the AJAX client driver
> Reference counting is a good strategy. Do we do that on the Java side? Then only when we remove an image on the J... Sergey Ivanovskiy
03:51 PM Feature #1811: implement the AJAX client driver
> Greg, could you correct me, because I don't understand clearly if it is required to implement or not.
We do need...
Greg Shah
03:29 PM Feature #1811: implement the AJAX client driver
>3
and
>6. I'd like to hear your ideas on how and when to remove images from the cache. This is both a Java and Jav...
Sergey Ivanovskiy
02:38 PM Feature #1811: implement the AJAX client driver
Greg, I've added to branch 1811o rev 10943 java-side support for SET_FONT, SET_FONT_STYLE, DRAW_STRING, DRAW_STRING_S... Constantin Asofiei
12:18 PM Feature #1811: implement the AJAX client driver
> how is the web socket supposed to receive data from the JS side, when, for example, the native width for a text is ... Greg Shah
11:44 AM Feature #1811: implement the AJAX client driver
Greg, another question: how is the web socket supposed to receive data from the JS side, when, for example, the nativ... Constantin Asofiei
11:08 AM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> Constantin, I am planning to move an image drawing from SwingEmulatedWindow to concrete im...
Constantin Asofiei
11:03 AM Feature #1811: implement the AJAX client driver
Constantin, I am planning to move an image drawing from SwingEmulatedWindow to concrete implementation of new interfa... Sergey Ivanovskiy
10:51 AM Feature #1811: implement the AJAX client driver
Greg, to reduce the resolution of font and text metrics, I'm adding caches at the @AbstractGuiDriver@ class - this wi... Constantin Asofiei
07:24 AM Feature #1811: implement the AJAX client driver
>1. Some of that logic duplicates code in >SwingEmulatedWindow. And you are missing much of the rendering logic in ho... Sergey Ivanovskiy
06:14 PM Feature #1790: implement menu support
> It looks like menubar is visible before WAIT-FOR - just right after menubar assignment.
The @visible@ attribute ...
Greg Shah
04:03 PM Feature #1790: implement menu support
I've checked it just now. Here the procedure... Vadim Gindin
03:54 PM Feature #1790: implement menu support
> So I'll have to change the place of warning processing from ThinClient.waitForWorker() to some other place.
I do...
Greg Shah
03:52 PM Feature #1790: implement menu support
After last rebase there is a new bug: warning is shown (when no enabled frames are defined). message area is not clea... Vadim Gindin
12:18 PM Feature #1790: implement menu support
Committed with rev 10947. Vadim Gindin
12:03 PM Feature #1790: implement menu support
Vadim Gindin wrote:
> I've fixed all remarks, but didn't commit it yet. Can I do it while regression testing is runn...
Constantin Asofiei
12:02 PM Feature #1790: implement menu support
Conversion testing is passed. Generated sources are identical. I've fixed all remarks, but didn't commit it yet. Can ... Vadim Gindin
05:45 PM Feature #1791: implement dynamic UI support
Plus issue:
8. Error on browse re-creation.
Stanislav Lomany
01:55 PM Feature #1791: implement dynamic UI support
Stanislav Lomany wrote:
> There is a problem related to @DynamicWidgetFactory.pushScreen(Un)lock@.
> # Conversion a...
Constantin Asofiei
01:48 PM Feature #1791: implement dynamic UI support
There is a problem related to @DynamicWidgetFactory.pushScreen(Un)lock@.
# Conversion assumes that ...
Stanislav Lomany
07:13 AM Feature #1791: implement dynamic UI support
I'm making changes only to static query case:
# OPEN QUERY without DEFINE QUERY - no conversion changes.
# OPEN QUE...
Stanislav Lomany
08:45 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Igor, if you are not rebasing at this time, I want to commit...
Constantin Asofiei
08:26 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> Igor, if you are not rebasing at this time, I want to commit some cleanups/pushScreenDef...
Igor Skornyakov
07:57 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor, if you are not rebasing at this time, I want to commit some cleanups/pushScreenDefinition changes I've made to ... Constantin Asofiei
07:43 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > Status line update is performed in the processing of FOCUS_G...
Igor Skornyakov
07:41 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> Status line update is performed in the processing of FOCUS_GAINED/FOCUS_LOST events. These ...
Constantin Asofiei
07:08 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Status line update is performed in the processing of FOCUS_GAINED/FOCUS_LOST events. These event are not fired in the... Igor Skornyakov
04:32 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> Igor, please post the 4GL test which required the changes in @FocusManager@
Constanti...
Igor Skornyakov
04:15 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor, please post the 4GL test which required the changes in @FocusManager@
Constantin Asofiei
04:00 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> Igor, just a heads up: the antivirus scanner was in progress (I've killed it now) and wh...
Igor Skornyakov

08/09/2015

04:59 PM Feature #1794: implement font support
> I'm good with the changes, except I think the @ds.unbind()@ in @FontTable.readFontAliases()@ should be in a @finall... Constantin Asofiei
01:01 PM Feature #1794: implement font support
Code Review Task Branch 1794c Revision 10918
I'm good with the changes, except I think the @ds.unbind()@ in @FontT...
Greg Shah
04:45 PM Feature #1790: implement menu support
Vadim, please focus on finishing cleaning up the code - do not work on 1790e issues yet, we want to release 1790d fir... Constantin Asofiei
08:17 AM Feature #1790: implement menu support
Constantin Asofiei wrote:
> ...
> * @Menu@
> - @setVisible:144@
> [...]
> Have you tested this? Is this the expe...
Vadim Gindin
08:16 AM Feature #1790: implement menu support
I've rebased 1790d branch. Current revision is 10945. Have a look please. Can I run conversion/regression testing? Vadim Gindin
08:13 AM Feature #1790: implement menu support
Constantin Asofiei wrote:
> ...
> * @Menu@
> - @setVisible:144@
> [...]
> Have you tested this? Is this the expected ...
Vadim Gindin
01:22 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor, just a heads up: the antivirus scanner was in progress (I've killed it now) and when this runs (sundays) this s... Constantin Asofiei
07:44 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
It appears the the failure of at least one test (gso_195) is is caused by a new "protection logic". Another workaroun... Igor Skornyakov
12:18 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811o Revision 10940
This is a very good start. I have some feedback. Much of the feedba...
Greg Shah

08/08/2015

10:57 AM Feature #1794: implement font support
Please review branch 1794c rev 10918.
I've added support for a new per-user node, @font-aliases@. In this conta...
Constantin Asofiei
10:52 AM Feature #1794: implement font support
Created task branch 1794c from trunk rev 10917. Constantin Asofiei
09:26 AM Feature #1790: implement menu support
Review for branch 1790d, revision 10944; most issues are just cleanup for code, comments, etc. Please address all i... Constantin Asofiei
08:26 AM Feature #1790: implement menu support
Vadim: please rebase from trunk revision 10917.
Constantin is going to do a code review. Make any needed changes ...
Greg Shah
08:39 AM Feature #1811: implement the AJAX client driver
> Don't know it can be any encoding supported by a web client. For example, for drawing dynamic screens Hextile is us... Greg Shah
08:24 AM Feature #1811: implement the AJAX client driver
Constantin: To see the history of the font work we have done so far, please review notes 687, 695, 705 - 718. Not mu... Greg Shah
08:26 AM Bug #2622 (Closed): width-pixel/height-pixels can't be assigned during create frame
Greg Shah
08:10 AM Bug #2622: width-pixel/height-pixels can't be assigned during create frame
Branch 2622a was merged to trunk rev 10917 and archived. Constantin Asofiei

08/07/2015

05:53 PM Feature #1791: implement dynamic UI support
Unless you change the behavior of @QueryWrapper.addComponent@, though, it will break their use (and possibly other AP... Eric Faulhaber
05:30 PM Feature #1791: implement dynamic UI support
It allows @NUM-BUFFERS@ and @BUFFER-HANDLE@ to work before the query was opened. Stanislav Lomany
05:22 PM Feature #1791: implement dynamic UI support
Stanislav Lomany wrote:
> Eric, I suggest to emit @addBuffer(.., true)@ at @DEFINE QUERY@ node's place.
This will d...
Eric Faulhaber
05:11 PM Feature #1791: implement dynamic UI support
Eric, I found no explicit way to set a dynamic query @SCROLLING@/@NON-SCROLLING@. As testing shows, it is scrolling. ... Stanislav Lomany
09:13 AM Feature #1791: implement dynamic UI support
Created task branch 2026b from P2J trunk revision 10916. Stanislav Lomany
08:58 AM Feature #1791: implement dynamic UI support
Plus issue:
7. Browse with dynamic query hangs on the last record.
Stanislav Lomany
07:41 AM Feature #1791: implement dynamic UI support
> 2. In P2J ADD-LIKE-COLUMN cannot be called for a static query until it is opened. Requires conversion changes
Er...
Stanislav Lomany
04:52 PM Feature #1811: implement the AJAX client driver
Greg, committed into 1811o, revision 10940, please review my changes. GuiWebDriver has method public NativeRectangle ... Sergey Ivanovskiy
03:16 PM Feature #1811: implement the AJAX client driver
> 1. Is there a need to send a hash of the image? Why not a simple 32-bit integer as an ID? The images are not bein... Sergey Ivanovskiy
12:38 PM Feature #1811: implement the AJAX client driver
> do you permit to commit my changes in 1811o
Yes, go ahead.
Some other thoughts:
1. Is there a need to send...
Greg Shah
12:20 PM Feature #1811: implement the AJAX client driver
Now it is implemented only 32 bits per a pixel RGB format, thus pixel_format isnot used in DRAW_IMAGE message:
DRAW_...
Sergey Ivanovskiy
04:50 PM Feature #1790: implement menu support
Here is the list of todos:
# drawing for keyboard menu navigation mode.
# API for working with accelerators dependi...
Vadim Gindin
04:45 PM Feature #1790: implement menu support
There are the bug. When I click on some menu-item in sub-menu body - body is closed but under the menu-item there is ... Vadim Gindin
04:42 PM Feature #1790: implement menu support
I've rebase my branch 1790d please review. I've committed fix for warning on no enabled widgets. Current branch is 1... Vadim Gindin
02:30 PM Feature #1790: implement menu support
It is only available on the server side for now.
Please just an @UnimplementedFeature.todo()@ in the code that gen...
Greg Shah
02:03 PM Feature #1790: implement menu support
Could somebody recall me, how to get procedure name and more important: line number? Vadim Gindin
04:47 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> ... but for CHUI I was running tests in lindev01 instead of proposed method. Is that matter?
...
Constantin Asofiei
04:44 AM Feature #1790: implement menu support
Thank you. You or Greg already told me about that some time before. I'm running tests on windev01 using that way, but... Vadim Gindin
04:38 AM Feature #1790: implement menu support
And why you need to do this: because the 4GL procedure editor is a 4GL program itself, and the behaviour is altered b... Constantin Asofiei
04:35 AM Feature #1790: implement menu support
Vadim, I should have checked this earlier: if you are not doing it already, please test all your menu-related tests (... Constantin Asofiei
02:47 PM Bug #2622: width-pixel/height-pixels can't be assigned during create frame
Rev 10917 passed runtime testing. Constantin Asofiei
08:53 AM Bug #2622: width-pixel/height-pixels can't be assigned during create frame
Code Review Task Branch 2622a Rev 10917
I'm fine with the changes.
Greg Shah
05:37 AM Bug #2622: width-pixel/height-pixels can't be assigned during create frame
Please review branch 2622a rev 10917.
This is in runtime testing now.
Constantin Asofiei
04:41 AM Bug #2622: width-pixel/height-pixels can't be assigned during create frame
Created branch 2622a from trunk rev 10916. Constantin Asofiei
12:51 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> From the main part the following tests failed in the same way in all 4 runs:
>
> gso_195...
Constantin Asofiei
12:25 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
There where 4 runs of the regression tests (3 on devsrv01 and 1 on my local machine).
The following tests failed i...
Igor Skornyakov
09:50 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> I don't understand this statement. The @apply@ is not executed on a separate thread. On the ser...
Igor Skornyakov
09:02 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
> In fact this is understandable as apply is processed in a separate thread, but at this moment I do not see how to f... Greg Shah
04:21 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> Igor, the wait-for tests (and generally all tests which require testing of focus/event p...
Igor Skornyakov
04:03 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor, the wait-for tests (and generally all tests which require testing of focus/event processing) need to be ran fro... Constantin Asofiei
04:45 AM Feature #2635: multi-window focus management
When there are multiple windows and each one with multiple enabled widgets, the focus management is not properly hand... Constantin Asofiei
04:43 AM Feature #2635 (New): multi-window focus management
Constantin Asofiei

08/06/2015

05:33 PM Feature #1811: implement the AJAX client driver
Updated the test example, removed dependencies from rfb of vncj project. Needs to do pixel format serialization. Sergey Ivanovskiy
04:12 PM Feature #1811: implement the AJAX client driver
This is a draft format for DRAW_IMAGE sub-message based on RFB specification document(https://www.realvnc.com/docs/rf... Sergey Ivanovskiy
09:21 AM Feature #1811: implement the AJAX client driver
Rebased task branch 1811o from P2J trunk revision 10916. The current revision in 1811o is now 10939. Greg Shah
04:09 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
It looks that the problem is due to the race condition. If there is a breakpoint on the second line of
@
apply "en...
Igor Skornyakov
10:11 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> I know you're working on the focus issue. Did you finish testing all of the focus testcases?
...
Igor Skornyakov
10:09 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Code Review Task Branch 2567a Revision 10941
The changes look fine. At some point we will need to move the privat...
Greg Shah
09:46 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Started regression testing of the branch 2567a Igor Skornyakov
09:37 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Rebased task branch 2567a from P2J trunk revision 10916 (new branch revision 10941). Igor Skornyakov
08:31 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Sounds good, thanks. Greg Shah
08:31 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> If you are close to a resolution, then go ahead and fix it now. If not, please open a new task a...
Igor Skornyakov
08:27 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
If you are close to a resolution, then go ahead and fix it now. If not, please open a new task and make it related t... Greg Shah
08:18 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
The problem is that @locate().client.getFocus()@ returns -1. Test @wait-for_restore_focus1.p@ line 39. Igor Skornyakov
07:58 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> When you said "previous version of FocusManager", did you mean that that problem already exists i...
Igor Skornyakov
07:54 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
When you said "previous version of FocusManager", did you mean that that problem already exists in the trunk of P2J? Greg Shah
07:52 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Please create a new task, make it related to this one and put enough details in to allow us to re...
Igor Skornyakov
07:50 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
> Exactly the same error with the previous version of the FocusManager.focusChange()
OK, you don't need to fix thi...
Greg Shah
07:34 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> No, we will work those problems in #2558. Please just modify the 4GL source code to bypass the i...
Igor Skornyakov
07:33 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> There are several errors in compilation of the converted testcases like this:
> @
> [...
Greg Shah
07:14 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Exactly the same error with the previous version of the @FocusManager.focusChange()@
Continue investigation.
Igor Skornyakov
07:00 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Some tests in @wait-for_focus_run.p@ fail:
@
Invalid handle. Not initialized or points to a deleted object. (313...
Igor Skornyakov
05:43 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
There are several errors in compilation of the converted testcases like this:
@
[javac] /home/ias/p2j/testcases...
Igor Skornyakov
03:47 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Code Review Task Branch 2567a Revision 10932
>
> I made a few minor additions or removals of w...
Igor Skornyakov
04:00 PM Feature #1791: implement dynamic UI support
> Depending on assignment order, there may be various 4GL error messages like "Unable to set ROW-MARKERS because the ... Greg Shah
03:33 PM Feature #1791: implement dynamic UI support
I found also:
4. Browse does not receive focus when created in a trigger.
5. Error on WIDGET DELETE.
6. Depending ...
Stanislav Lomany
01:17 PM Feature #1791: implement dynamic UI support
Please resolve all 3 issues. When do you think you have have the changes ready?
Other than those 3 problems, ther...
Greg Shah
01:02 PM Feature #1791: implement dynamic UI support
Stanislav Lomany wrote:
> 3. QUERY-PREPARE doesn't work. Is it something with my configuration or do you see the iss...
Eric Faulhaber
12:55 PM Feature #1791: implement dynamic UI support
Here is the set of problems so far:
1. Error if VISIBLE/HIDDEN is set prior to SENSITIVE. Doesn't affect the custo...
Stanislav Lomany
12:14 PM Feature #1791: implement dynamic UI support
Now that you have had 2-3 days to review the runtime support needed for CREATE BROWSE, please provide an estimate of ... Greg Shah
12:03 PM Feature #1790: implement menu support
Please post a list of all the remaining issues/todos/work for this task. Greg Shah
11:53 AM Feature #1790: implement menu support
> Is it a good place
Although this method is only called from the @waitForWorker()@, it is not guaranteed to only ...
Greg Shah

08/05/2015

06:26 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Code Review Task Branch 2567a Revision 10932
I made a few minor additions or removals of whitespace in some files....
Greg Shah
05:02 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Got rid of @Trigger.INFO@.
Committed to the branch 2567a, revno 10932.
Igor Skornyakov
04:27 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Fixed all issues from the Constantin's code review except the one regarding the @Trigger.INFO@. The @getWidhetId()@ r... Igor Skornyakov
03:07 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Thank you gentlemen. I understand the point. Although in this particular case using of a ThreadLocal is just a shortc... Igor Skornyakov
02:46 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Another point: it is not required that all sessions use the conversation model (where a dedicated thread executes the... Greg Shah
02:43 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> Constantin Asofiei wrote:s in alphabetical order
> > # Trigger.INFO
> > - in P2J we do no...
Constantin Asofiei
01:32 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:s in alphabetical order
> # Trigger.INFO
> - in P2J we do not use @ThreadLocal@ variables,...
Igor Skornyakov
12:21 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Thank you Constatin.
I will change the code as you advised.
Igor Skornyakov
12:12 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Review branch 2567a revision 10930:
# methods_attributes.rules:
- line 376: you've changed the name of the getter; ...
Constantin Asofiei
10:36 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Rebased task branch 2567a from P2J trunk revision 10909 (new branch revision 10930). Igor Skornyakov
10:15 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor, please rebase to trunk rev 10909, your branch is built on top of trunk rev 10906. Constantin Asofiei
09:58 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Do you believe this is the full solution to the focus issues? (Is it ready for final review?)
...
Igor Skornyakov
09:54 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Do you believe this is the full solution to the focus issues? (Is it ready for final review?) Greg Shah
05:59 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
The side effect of the temporary focus change where the events posted in the @AbstractWidget.requestFocus()@ method. ... Igor Skornyakov
05:31 PM Bug #2620 (Closed): problems when editable size of a field is smaller than the format length
Greg Shah
04:41 PM Bug #2620: problems when editable size of a field is smaller than the format length
Branch 2620a was merged to trunk rev 10912 and archived. Constantin Asofiei
04:26 PM Bug #2620: problems when editable size of a field is smaller than the format length
Rebased branch 2620a from trunk rev 10911 (new branch rev 10913). Constantin Asofiei
12:49 PM Bug #2620: problems when editable size of a field is smaller than the format length
Rebased branch 2620a from trunk rev 10910 (new branch rev 10912). Constantin Asofiei
12:44 PM Bug #2620 (WIP): problems when editable size of a field is smaller than the format length
All failures in 2620a runtime testing look like false negatives, another round is in progress - I expect to set it as... Constantin Asofiei
09:05 AM Bug #2620: problems when editable size of a field is smaller than the format length
Code Review Task Branch 2620a Revision 10911
I'm good with the changes.
Greg Shah
05:18 AM Bug #2620 (Review): problems when editable size of a field is smaller than the format length
Please review branch 2620a rev 10911 - it contains fixes for FILL-IN cursor problems when editable width is smaller t... Constantin Asofiei
03:44 PM Feature #1791: implement dynamic UI support
2026a was merged to trunk rev 10911. Stanislav Lomany
03:23 PM Feature #1791: implement dynamic UI support
Stanislav Lomany wrote:
> It is not expected to be used in loops. Should I change the code to
>
> [...]
>
> an...
Eric Faulhaber
03:14 PM Feature #1791: implement dynamic UI support
It is not expected to be used in loops. Should I change the code to... Stanislav Lomany
02:59 PM Feature #1791: implement dynamic UI support
Having written that, I don't know what the converted code that uses this will look like. I don't expect that this cod... Eric Faulhaber
02:56 PM Feature #1791: implement dynamic UI support
I looked a bit deeper, and something concerns me. From @BrowseWidget@:... Eric Faulhaber
02:46 PM Feature #1791: implement dynamic UI support
Should I distribute the update? Stanislav Lomany
02:37 PM Feature #1791: implement dynamic UI support
Yes, that is the point. Stanislav Lomany
02:28 PM Feature #1791: implement dynamic UI support
Code review 2026a/10914:
What is the purpose of the new variant @setQueryAsHandle(QueryWrapper)@, which is defined...
Eric Faulhaber
02:09 PM Feature #1791: implement dynamic UI support
As soon as he approves it, you can merge to trunk. He will have it done shortly. Greg Shah
01:51 PM Feature #1791: implement dynamic UI support
Rebased task branch 2026a from P2J trunk revision 10910.
Conversion regression passed.
I guess, waiting for Eric t...
Stanislav Lomany
12:41 PM Feature #1791: implement dynamic UI support
Code Review Task Branch 2026a Revision 10914
The changes look good.
> Am I right that I shouldn't run runtime r...
Greg Shah
11:54 AM Feature #1791: implement dynamic UI support
Committed @triggers_phrase_rewrite.rules@.
Am I right that I shouldn't run runtime regression testing?
Stanislav Lomany
08:58 AM Feature #1791: implement dynamic UI support
Code Review Task Branch 2026a Revision 10913
I'm OK with the changes.
> Should I rename the file (say, to creat...
Greg Shah
07:58 AM Feature #1791: implement dynamic UI support
Please review task branch 2026a revision 10913. Stanislav Lomany
07:57 AM Feature #1791: implement dynamic UI support
Rebased task branch 2026a from P2J trunk revision 10909. Stanislav Lomany
02:31 PM Feature #1811: implement the AJAX client driver
> how to test images using P2J, 4Gl function button.load-image()?
Until the GUI web client is further along, we ca...
Greg Shah
12:54 PM Feature #1811: implement the AJAX client driver
Fixed the test (canvas resizing, pixel format issue) and added ./red256x256.jpg, ./green256x256.jpg, ./blue256x256.jp... Sergey Ivanovskiy
01:01 PM Bug #2621 (Closed): wait-for only works for current-window
Greg Shah
12:41 PM Bug #2621 (Review): wait-for only works for current-window
Branch 2621a was merged to trunk rev 10910 and archived. Constantin Asofiei
12:36 PM Bug #2621: wait-for only works for current-window
Please merge to trunk now. Greg Shah
03:24 AM Bug #2621: wait-for only works for current-window
Rebased branch 2621a, from trunk rev 10909 (new branch rev 10911)
Also, it has passed runtime testing.
Constantin Asofiei

08/04/2015

06:29 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Fixed issues 5 mentioned in the code review.
I've tested several scenarios: no widget for the new focus, NO-APPLY i...
Igor Skornyakov
06:03 PM Feature #1811: implement the AJAX client driver
This very vague test (test.zip) yields several issues to be resolved. The fist one it needs to make an agreement betw... Sergey Ivanovskiy
05:59 PM Feature #1790: implement menu support
Have a look please at @FocusManager.undefImplicit()@:... Vadim Gindin
03:09 PM Feature #1790: implement menu support
> NO-ERROR is not supported for WAIT-FOR, so I can't check it.
Good point. That means it cannot be supported sinc...
Greg Shah
12:33 PM Feature #1790: implement menu support
Greg Shah wrote:
> You should also check these:
>
> * Does it matter if there are frames present, but they are NO...
Vadim Gindin
12:06 PM Feature #1790: implement menu support
> If a frame with enabled widgets persist in a window - than that error will not appear. Other cases (sub-menus/trig... Greg Shah
11:59 AM Feature #1790: implement menu support
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Short question. I'm confused a little.
> >
> > When I move ...
Vadim Gindin
11:31 AM Feature #1790: implement menu support
Greg Shah wrote:
> Vadim Gindin wrote:
> > I'm working on the following error. If the source procedure contains the...
Vadim Gindin
09:04 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> I'm working on the following error. If the source procedure contains the statement WAIT-FOR wi...
Greg Shah
03:50 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> Short question. I'm confused a little.
>
> When I move mouse pointer outside from the widg...
Constantin Asofiei
03:31 AM Feature #1790: implement menu support
Short question. I'm confused a little.
When I move mouse pointer outside from the widget (menu-item for example) ...
Vadim Gindin
04:15 PM Bug #2620 (WIP): problems when editable size of a field is smaller than the format length
Created task branch 2620a from trunk rev 10908. Constantin Asofiei
03:40 PM Feature #1791: implement dynamic UI support
There is file @embedded_attribute_assign_rewrite.rules@ which rewrites CREATE...ASSIGN. I've added rewrite for CREATE... Stanislav Lomany
03:08 PM Bug #2623 (Closed): mouse cursor icons for the window edges sometimes don't change back to the st...
Greg Shah
01:35 PM Bug #2623: mouse cursor icons for the window edges sometimes don't change back to the standard ar...
Branch 2623a was merged to trunk rev 10908 and archived. Constantin Asofiei
09:49 AM Bug #2623: mouse cursor icons for the window edges sometimes don't change back to the standard ar...
Greg Shah wrote:
> Did you @bzr push@ your rebased changes back to the devsrv01 task branch master? I don't see the...
Constantin Asofiei
09:47 AM Bug #2623: mouse cursor icons for the window edges sometimes don't change back to the standard ar...
Did you @bzr push@ your rebased changes back to the devsrv01 task branch master? I don't see the latest rebase chang... Greg Shah
03:55 AM Bug #2623: mouse cursor icons for the window edges sometimes don't change back to the standard ar...
Rebased branch 2623a, from trunk rev 10907 (new branch rev 10908)
Constantin Asofiei
01:34 PM Bug #2621: wait-for only works for current-window
Rebased branch 2621a, from trunk rev 10908 (new branch rev 10910)
Constantin Asofiei
09:42 AM Bug #2621: wait-for only works for current-window
Code Review Task Branch 2621a Revision 10909
It looks good. I think this can go into testing unless there is anyt...
Greg Shah
03:54 AM Bug #2621: wait-for only works for current-window
Rebased branch 2621a, from trunk rev 10907 (new branch rev 10909)
Constantin Asofiei
08:39 AM Feature #2252: implement GUI client support
Greg Shah wrote:
> Hynek: Are you planning to include fixes for @at_grows_frame.p/half_fixed_position.p@ and @frame-...
Hynek Cihlar
08:37 AM Feature #2252: implement GUI client support
Hynek: Are you planning to include fixes for @at_grows_frame.p/half_fixed_position.p@ and @frame-scrolling-size.p@ in... Greg Shah
08:24 AM Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review Task Branch 2424b Revision 10921
>
> I'm good with the changes.
>
> > the code...
Hynek Cihlar
02:35 AM Feature #2252: implement GUI client support
Created task branch 2424c. This will hold some generic scrolling fixes and potential changes related to frame scrolling. Hynek Cihlar
02:28 AM Feature #2252: implement GUI client support
Branch 2424b has passed conversion and runtime regression tests, was merged to trunk rev 10907, and archived. Hynek Cihlar
 

Also available in: Atom