Project

General

Profile

Activity

From 08/20/2015 to 09/18/2015

09/18/2015

05:46 PM Bug #2715: demo/calc-static.p drawing differences as compared to the 4GL version
Greg Shah wrote:
> Task branch 1811q revision 11025 is an attempt to fix the positioning of right justified fill-ins...
Constantin Asofiei
05:43 PM Bug #2715: demo/calc-static.p drawing differences as compared to the 4GL version
Task branch 1811q revision 11025 is an attempt to fix the positioning of right justified fill-ins that have larger wi... Greg Shah
03:16 PM Bug #2715: demo/calc-static.p drawing differences as compared to the 4GL version
Greg Shah wrote:
> At least part of the problem is in @FillInGuiImpl.editableNativeDimension()@. It just takes the ...
Constantin Asofiei
03:13 PM Bug #2715: demo/calc-static.p drawing differences as compared to the 4GL version
At least part of the problem is in @FillInGuiImpl.editableNativeDimension()@. It just takes the full physical size o... Greg Shah
02:48 PM Bug #2715: demo/calc-static.p drawing differences as compared to the 4GL version
I modified the testcase to leave the result fillin as enabled. This is the result:
!calc-static.p_in_p2j_swing_w_...
Greg Shah
11:08 AM Bug #2715: demo/calc-static.p drawing differences as compared to the 4GL version
Greg, I think this is a problem of aligning the "fill-in content". It should help making the @tfRes@ FILL-IN editabl... Constantin Asofiei
09:23 AM Bug #2715: demo/calc-static.p drawing differences as compared to the 4GL version
I changed the bgcolor and fgcolor for the result fillin and that shows that the size and position of the fillin are b... Greg Shah
05:19 PM Feature #1811: implement the AJAX client driver
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > And on a different note: the problems I'm seeing with the scrol...
Constantin Asofiei
05:17 PM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> And on a different note: the problems I'm seeing with the scrollbars are related to this...
Hynek Cihlar
05:08 PM Feature #1811: implement the AJAX client driver
Rev 11024 fixes the workspace background drawing.
The message area has two problems:
# for note 1229, in @Scrolla...
Constantin Asofiei
03:53 PM Feature #1811: implement the AJAX client driver
Hynek Cihlar wrote:
> Greg Shah wrote:
> > @hello.p@ P2J Swing result as of 1811q rev 11022:
> >
> > !hello_worl...
Constantin Asofiei
03:25 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> @hello.p@ P2J Swing result as of 1811q rev 11022:
>
> !hello_world_p2j_swing_broken_20150918.p...
Hynek Cihlar
03:21 PM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> 1811q rev 11022 fixes the NPE in system popup menu initialization.
>
> But all frames...
Hynek Cihlar
01:41 PM Feature #1811: implement the AJAX client driver
Please look at the committed revision 11023. Decided to fix the drawing ops for the web. But it doesn't fix "out of o... Sergey Ivanovskiy
01:38 PM Feature #1811: implement the AJAX client driver
On the positive side: the scrollbar for the message area is no longer displaying when it should not. But the message... Greg Shah
01:36 PM Feature #1811: implement the AJAX client driver
@hello.p@ P2J Swing result as of 1811q rev 11022:
!hello_world_p2j_swing_broken_20150918.png!
vs 4GL:
!hello...
Greg Shah
01:27 PM Feature #1811: implement the AJAX client driver
1811q rev 11022 fixes the NPE in system popup menu initialization.
But all frames are now forced to be scrollable....
Constantin Asofiei
01:22 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> The @WindowGuiImpl.createPopup()@ will cause the parent to be set on the @MenuGuiImpl@ instance a...
Constantin Asofiei
01:21 PM Feature #1811: implement the AJAX client driver
The @WindowGuiImpl.createPopup()@ will cause the parent to be set on the @MenuGuiImpl@ instance at the end of the met... Greg Shah
01:07 PM Feature #1811: implement the AJAX client driver
There is another issue with SET_WINDOW_BOUNDS drawing primitive. The last one breaks the order of drawing operations ... Sergey Ivanovskiy
01:02 PM Feature #1811: implement the AJAX client driver
This same abend occurs for all GUI testcases.
> Looks like the menu should be attached to the widget tree before i...
Greg Shah
11:08 AM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> Running @uast/demo/demo_widgets.p@ on the current version is failed for Swing and Web cli...
Hynek Cihlar
11:00 AM Feature #1811: implement the AJAX client driver
Running @uast/demo/demo_widgets.p@ on the current version is failed for Swing and Web clients while it initializes th... Sergey Ivanovskiy
09:54 AM Feature #1811: implement the AJAX client driver
Rebased task branch 1811q from P2J trunk revision 10937 (branch revision 11020). Also merged in changes from 2424d at... Hynek Cihlar
09:47 AM Feature #1811: implement the AJAX client driver
> do you also get that many false merge conflicts when rebasing
Not usually, but sometimes deep into the rebasing...
Greg Shah
09:24 AM Feature #1811: implement the AJAX client driver
Constantin, we both added @NativeRectangle.toString()@ and @Rectangle.toString()@. I kept my version which also inclu... Hynek Cihlar
08:53 AM Feature #1811: implement the AJAX client driver
Btw., do you also get that many false merge conflicts when rebasing? For example:... Hynek Cihlar
08:20 AM Feature #1811: implement the AJAX client driver
1811q rebase is in progress, I will let you know when finished. Hynek Cihlar
07:15 AM Feature #1811: implement the AJAX client driver
Hynek Cihlar wrote:
> Greg Shah wrote:
> > Hynek is going to rebase 1811q and then merge 2424d into 1811q. Before ...
Constantin Asofiei
06:47 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Hynek is going to rebase 1811q and then merge 2424d into 1811q. Before he does that, I wanted to...
Hynek Cihlar
11:17 AM Feature #1801: add some frame options
Task #2424 left some unfinished work related to frame sizing/scrolling. Frame must honor the VIRTUAL* attributes. Thi... Hynek Cihlar
10:04 AM Feature #2424 (Closed): GUI window sizing and scrollbar/viewport handling
Greg Shah
09:57 AM Feature #2252: implement GUI client support
Changes from task branch 2424d merged to 1811q at revision 11021. 2424d archived. Hynek Cihlar
07:46 AM Feature #2564: implement GUI BROWSE widget
Since it is a browse-related conversion issue, I decided to put it here.
The issue is about case sensitivity. This ...
Stanislav Lomany

09/17/2015

06:21 PM Feature #2560 (WIP): implement GUI DIALOG-BOX support
Hynek Cihlar
05:01 PM Feature #1811: implement the AJAX client driver
Hynek is going to rebase 1811q and then merge 2424d into 1811q. Before he does that, I wanted to give people a chanc... Greg Shah
09:54 AM Feature #1811: implement the AJAX client driver
> And something else: duplicating the @WinKeyboardReader@ code is not so well phrased. The code needs to be adjusted... Sergey Ivanovskiy
09:39 AM Feature #1811: implement the AJAX client driver
And something else: duplicating the @WinKeyboardReader@ code is not so well phrased. The code needs to be adjusted s... Constantin Asofiei
09:18 AM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> Greg, Constantin, please approve that JS client should repeat functionalities of @WinKeyb...
Constantin Asofiei
09:10 AM Feature #1811: implement the AJAX client driver
Greg, Constantin, please approve that JS client should repeat functionalities of @WinKeyboardReader@ and @Keyboard@ c... Sergey Ivanovskiy
09:06 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> The @p2j.keyboard.js@ and @p2j.keymap.js@ where written specifically for the ChUI web client. I ...
Constantin Asofiei
08:53 AM Feature #1811: implement the AJAX client driver
@WinKeyboardReader@ uses @Keyboard@ class in this method @private int processShift(int code)@. It follows that the js... Sergey Ivanovskiy
08:41 AM Feature #1811: implement the AJAX client driver
Greg, I don't understand it because @WebClientProtocol.readKey()@ gets a prepared key event from the chui web client ... Sergey Ivanovskiy
08:22 AM Feature #1811: implement the AJAX client driver
The @p2j.keyboard.js@ and @p2j.keymap.js@ where written specifically for the ChUI web client. I believe the idea was... Greg Shah
07:25 AM Feature #1811: implement the AJAX client driver
Constantin, @WinKeyboardReader@ uses @Keyboard@ class and there are hierarchies @GuiKeyboard@ derived from @ChuiWindo... Sergey Ivanovskiy
04:59 PM Feature #2252: implement GUI client support
> Do you want me to rebase 1811q and merge 2424d?
Yes.
Let's give Constantin and Sergey a chance to check in an...
Greg Shah
04:55 PM Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review Task Branch 2424d Revision 10939
>
> Unfortunately, with the @BorderLayout@ and @O...
Hynek Cihlar
04:44 PM Feature #2252: implement GUI client support
Code Review Task Branch 2424d Revision 10939
It looks good. Please add javadoc for the @EditorGuiImpl.EditorScrol...
Greg Shah
03:52 PM Feature #2252: implement GUI client support
Please review task branch 2424d, revision 10939. The changes contain leftover GUI fixes from 2424c. Hynek Cihlar
08:41 PM Feature #2252: implement GUI client support
Created task branch 2424d. This will be mainly for GUI fixes, leftovers from 2424c. Hynek Cihlar
02:58 PM Bug #2724: button interior focus highlight (small dotted stroked rectangle) is not pixel-for-pixe...
To see the problem use @demo/calc-static.p@. There is a close up image in #2715-4. Greg Shah
02:55 PM Bug #2724 (New): button interior focus highlight (small dotted stroked rectangle) is not pixel-fo...
Greg Shah
02:56 PM Bug #2715: demo/calc-static.p drawing differences as compared to the 4GL version
Task branch 1181q revision 11017 has changes that fix the button line stroke and properly implemented the height calc... Greg Shah
12:54 PM Bug #2715: demo/calc-static.p drawing differences as compared to the 4GL version
I have updated the system colors to match the windows classic theme (I captured them with the new @tools/dump_syscolo... Greg Shah
08:53 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
It looks that the value of the @FONT@ attribute is ignored by most widgets. I'm working now on refactoring the runtim... Igor Skornyakov
05:04 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Added testcases/uast/auto_resize/arbtn.p test for FILL-BUTTON:AUTO-RESIZE runtime support, revno 1333.
The following...
Igor Skornyakov
04:30 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Fixed incompatibility in the @FILL-IN:AUTO-RESIZE@ runtime support
Committed to branch 2567b revno 10953
Igor Skornyakov
02:55 AM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> Guys, how can I set my fonts in P2J? I've added this to the directory:
> [...]
> These f...
Constantin Asofiei

09/16/2015

06:47 PM Feature #2564: implement GUI BROWSE widget
Guys, how can I set my fonts in P2J? I've added this to the directory:... Stanislav Lomany
05:22 PM Feature #1811: implement the AJAX client driver
Greg, Constantin, thank you for help it is like I threw the baby out with the bathwater. Planning to implement the fu... Sergey Ivanovskiy
04:59 PM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> Constantin, what do you think if we leave the p2j.keyboard.js and p2j.keymap.js as they a...
Constantin Asofiei
04:47 PM Feature #1811: implement the AJAX client driver
At a minimum, the ESC key is processed differently. In GUI it is passed for processing while in ChUI the ESC key is ... Greg Shah
04:16 PM Feature #1811: implement the AJAX client driver
> Sergey, for the keyboard support for the Web client, we need a JS version of what @driver.swing.WinKeyboardReader@ ... Sergey Ivanovskiy
04:52 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Added @testcases/uast/auto_resize/arf.p@ test for FILL-IN:AUTO-RESIZE runtime support, revno 1332.
The following i...
Igor Skornyakov
03:46 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Added @testcase/uasr/selectable/s.p@ test for the @SELECTABLE@ attribute. revno 1331.
As far as I can see the SELE...
Igor Skornyakov
03:02 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
1. Added @testcases/uast/menu/menu_mouse.p@ revno 1330
2. Finished runtime support for the @MENU-MOUSE@ attribute.
...
Igor Skornyakov
11:33 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Write testcases to confirm that the behavior works fully. List any deviations and resolve them.
...
Igor Skornyakov
11:32 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Fixed setters for the MENU-MOUSE attribute.
Committed to the 2567b branch revno 10951
Igor Skornyakov
11:32 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Write testcases to confirm that the behavior works fully. List any deviations and resolve them. Greg Shah
11:08 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg,
Can you please provide more information about what I'm supposed to do regarding the @AUTO-RESIZE@ attribute? A...
Igor Skornyakov
10:41 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Added conversion support for the MENU-KEY and MENU-MOUSE attributes.
Committed to the 2567b branch revno 10950
Igor Skornyakov
10:35 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> > Does it makes sense to continue working on the SELECTABLE attribute runtime support?
>
> No...
Igor Skornyakov
10:33 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
> Does it makes sense to continue working on the SELECTABLE attribute runtime support?
No.
But I want do you t...
Greg Shah
09:56 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg,
I do not completely understand the semantics of the @SELECTABLE@ attribute at this moment but it seems that thi...
Igor Skornyakov
09:28 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Implemented @WINDOW:MOVE-TO-(TOP/BOTTOM)@ (by invoking invoking corresponding methods of the @WindowManager@). See no... Igor Skornyakov
08:59 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Well, at least part of the support is in @WindowManager.moveToTop()@, @WindowManager.moveToBottom...
Igor Skornyakov
08:24 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Well, at least part of the support is in @WindowManager.moveToTop()@, @WindowManager.moveToBottom()@ and the @WindowM... Greg Shah
08:17 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
On the WINDOW:MOVE-TO-TOP() invocation 4GL redraws only the affected window (the z-order of other windows with respec... Igor Skornyakov
07:58 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
I do not see any data structure which reflects windows' z-order. The only place where references to all windows are k... Igor Skornyakov
07:49 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
No apologies are needed. I would rather know about problems and if we have duplicate reports that is OK. Greg Shah
07:48 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Igor Skornyakov wrote:
> > Please note that the @WINDOW:TITLE@ attribute is ignored now. It is a...
Igor Skornyakov
07:47 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> Please note that the @WINDOW:TITLE@ attribute is ignored now. It is always @P2J GUI Client@...
Greg Shah
07:43 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Please note that the @WINDOW:TITLE@ attribute is ignored now. It is always @P2J GUI Client@. Igor Skornyakov
07:24 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
The remaining work for this task
1. @WINDOW:MOVE-TO-TOP/MOVE-TO-BOTTOM@ - will finish today (hopefullly in a couple...
Igor Skornyakov
07:12 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Please make a list of the remaining work in this task and an estimate of when it can be finished. Greg Shah
07:11 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> > I will try to fix the issue with window_parenting/waitfor_2wnd.p after finishing with the the i...
Igor Skornyakov
07:10 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
> I will try to fix the issue with window_parenting/waitfor_2wnd.p after finishing with the the intitial scope of the... Greg Shah
04:01 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
I've found a workaround for the issue mentioned in the note 263. If there are enabled frame(s) in the default window ... Igor Skornyakov
01:58 PM Feature #2252: implement GUI client support
2424c merged to trunk as revision 10937. 2424c archived. Hynek Cihlar
01:42 PM Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review Task Branch 2424c Revision 10993
>
> All of the following can be resolved without ...
Hynek Cihlar
08:34 AM Feature #2252: implement GUI client support
Code Review Task Branch 2424c Revision 10993
All of the following can be resolved without needing re-testing. Ple...
Greg Shah
07:09 AM Bug #2716 (New): The application with multiple windows doesn't start.
A workaround was found that takes this out of the #2567 critical path. This will be worked independently again. Greg Shah

09/15/2015

06:09 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Rebased task branch 2567a from P2J trunk revision 10936 (new branch revision 10948).
Igor Skornyakov
11:18 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
It seems that I faced a serious bug. With the attached test running with the debugger I see 3 windows instead of expe... Igor Skornyakov
07:31 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> The existing test @window_parenting/waitfor_2wnd.p@ doesn't start.
>
> [...]
>
> Shou...
Igor Skornyakov
07:03 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Added support for the @SELECTABLE@ attribute conversion.
Committed to branch 2567b revno 10946
Igor Skornyakov
06:56 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> > However it is a stopper for my work on WINDOWS:(MOVE-TO-TOP()/MOVE-TO-BOTTOM().
>
> OK, in t...
Igor Skornyakov
06:54 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
> However it is a stopper for my work on WINDOWS:(MOVE-TO-TOP()/MOVE-TO-BOTTOM().
OK, in that case you must fix th...
Greg Shah
06:52 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Igor Skornyakov wrote:
> > The existing test @window_parenting/waitfor_2wnd.p@ doesn't start.
>...
Igor Skornyakov
06:50 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> The existing test @window_parenting/waitfor_2wnd.p@ doesn't start.
>
> [...]
>
> Shou...
Greg Shah
06:09 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Modified test @frame-z-order/z4.p@, added @frame-z-order/zw.p@ - for @WINDOW:(MOVE-TO-TOP()/MOVE-TO-BOTTOM())@.
Co...
Igor Skornyakov
05:42 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
The existing test @window_parenting/waitfor_2wnd.p@ doesn't start.... Igor Skornyakov
05:01 PM Feature #1811: implement the AJAX client driver
http://unixpapa.com/js/key.html
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode
describe the w...
Sergey Ivanovskiy
12:01 PM Feature #1811: implement the AJAX client driver
Committed revision 11014 makes a window can be focused. Sergey Ivanovskiy
04:52 PM Feature #2564: implement GUI BROWSE widget
Created task branch 2564a from P2J trunk revision 10936. Stanislav Lomany
12:52 PM Bug #2717: The initial window's position is out of the screen.
Well, it seems that this is problem with dual monitor configuration only. Igor Skornyakov
07:08 AM Bug #2717: The initial window's position is out of the screen.
When I start the converted p2j application (both in ChUI and GUI modes) the initial window's position is out of the s... Igor Skornyakov
07:05 AM Bug #2717 (New): The initial window's position is out of the screen.
Igor Skornyakov
12:49 PM Feature #2252: implement GUI client support
Greg Shah wrote:
> Don't we have an assumption that all the drawing within a given drawing cycle is done within a si...
Hynek Cihlar
10:27 AM Feature #2252: implement GUI client support
Don't we have an assumption that all the drawing within a given drawing cycle is done within a single outermost clipp... Greg Shah
09:39 AM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Please check which widgets have @PaintEvent@ posted, in the test where you have incorrect...
Hynek Cihlar
09:18 AM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> Constantin, please review @BorderedPanelGuiImpl.draw()@ in 2424c, revision 10992.
>
> @Bor...
Constantin Asofiei
04:26 AM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin Asofiei wrote:
> > > Can you check if the report fi...
Hynek Cihlar
03:59 AM Feature #2252: implement GUI client support
Constantin, please review @BorderedPanelGuiImpl.draw()@ in 2424c, revision 10992.
@BorderedPanelGuiImpl@ is used ...
Hynek Cihlar
10:41 AM Bug #2715: demo/calc-static.p drawing differences as compared to the 4GL version
FYI, the same problems exist in task branch 1811q revision 11008 for both Swing and web clients. There are no differ... Greg Shah
09:06 AM Bug #2714: demo/calc.p is broken
Interestingly, in the web client (task branch 1181q revision 11008), what is described above as "flashing" of the but... Greg Shah
07:31 AM Bug #2716 (Rejected): The application with multiple windows doesn't start.
This will be worked in #2567 instead. Greg Shah
06:54 AM Bug #2716: The application with multiple windows doesn't start.
The existing test @window_parenting/waitfor_2wnd.p@ doesn't start.... Igor Skornyakov
06:53 AM Bug #2716 (Closed): The application with multiple windows doesn't start.
Igor Skornyakov

09/14/2015

05:56 PM Bug #2715: demo/calc-static.p drawing differences as compared to the 4GL version
Consider this output from @demo/calc-static.p@ as executed in the P2J swing client in trunk rev 10935:
!calc-static....
Greg Shah
05:38 PM Bug #2715 (Closed): demo/calc-static.p drawing differences as compared to the 4GL version
Greg Shah
05:56 PM Bug #2679: window borders should have a 3D appearance
The caption button 3D highlights seem to be the same. Selected buttons have some differences which are being resolve... Greg Shah
05:26 PM Bug #2714: demo/calc.p is broken
In the trunk revision 10935, running @demo/calc.p@ results in this screen:
!calc.p_p2j_failure_20150914.png!
There ...
Greg Shah
05:18 PM Bug #2714 (Closed): demo/calc.p is broken
Greg Shah
04:45 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Fixed minor bug in @MOVE-TO-TOP()@/@MOVE-TO-BOTTOM()@.
Committed to branch 2567b revno 10945
Igor Skornyakov
02:01 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> Igor, forgot to mention something: there is a change related to moveToTop/Bottom/BeforeT...
Igor Skornyakov
01:58 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor, forgot to mention something: there is a change related to moveToTop/Bottom/BeforeTab in 1811q WindowGuiImpl - I... Constantin Asofiei
01:56 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Implemented @MOVE-TO-TOP()@/@MOVE-TO-BOTTOM()@ for all widgets except @WINDOW@
Committed to the branch 2567b revno...
Igor Skornyakov
12:44 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> In regard to the @TitledWindow.processEvents()@ change in revision 10942, does the zombie event m...
Igor Skornyakov
12:42 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
In regard to the @TitledWindow.processEvents()@ change in revision 10942, does the zombie event message actually stop... Greg Shah
10:05 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> > I understand that both bugs do not fit naturally into the scope of this task. Should I create 2...
Igor Skornyakov
09:58 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> > When widgets' z-order is changed via MOVE-TO-TOP()/MOVE-TO-BOTTOM() methods the widgets' labels...
Igor Skornyakov
09:55 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
> I understand that both bugs do not fit naturally into the scope of this task. Should I create 2 separate independen... Greg Shah
09:54 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Are the problems with @Invalid frame ID@ the same as those reported in #2700?
Yes, it looks li...
Igor Skornyakov
09:53 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor,
> When widgets' z-order is changed via MOVE-TO-TOP()/MOVE-TO-BOTTOM() methods the widgets' labels are not affe...
Constantin Asofiei
09:51 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
> When widgets' z-order is changed via MOVE-TO-TOP()/MOVE-TO-BOTTOM() methods the widgets' labels are not affected.
...
Greg Shah
09:49 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Are the problems with @Invalid frame ID@ the same as those reported in #2700? Greg Shah
08:41 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> If you use Eclipse, there is the "Type Hierarchy" view (via F4 on an interface/class) an...
Igor Skornyakov
08:36 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > There are some name conventions we have for the widgets:
> ...
Constantin Asofiei
08:34 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> There are some name conventions we have for the widgets:
> # for server-side widgets, t...
Igor Skornyakov
08:24 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> Greg,
> I suggest to add a 'marker interface' or annotation to explicitely distinguish be...
Constantin Asofiei
04:19 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg,
I suggest to add a 'marker interface' or annotation to explicitely distinguish between those p2j widgets whic...
Igor Skornyakov
04:32 PM Bug #2713: Incorrect labels in case of the overlapping widgets.
If two widgets (@f@ and @g@ @FILL-IN@ in the attached program) are overlapped then with 4GL only the label of the top... Igor Skornyakov
04:28 PM Bug #2713 (WIP): Incorrect labels in case of the overlapping widgets.
Igor Skornyakov
04:16 PM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin Asofiei wrote:
> > > Can you check if the report fi...
Hynek Cihlar
03:56 PM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Can you check if the report file is in your home folder in devs...
Constantin Asofiei
03:39 PM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Can you check if the report file is in your home folder in devsrv01? The report is gener...
Hynek Cihlar
03:31 PM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> During Majic regression testing, I received
>
> 3. failure in step 29: 'java.lang.RuntimeE...
Constantin Asofiei
03:08 PM Feature #2252: implement GUI client support
During Majic regression testing, I received
3. failure in step 29: 'java.lang.RuntimeException: java.lang.Runtime...
Hynek Cihlar
11:01 AM Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review Task Branch 2424c Revision 10992
>
> 1. Do you plan to resolve the TODOs in @Selec...
Hynek Cihlar
10:56 AM Feature #2252: implement GUI client support
Code Review Task Branch 2424c Revision 10992
1. Do you plan to resolve the TODOs in @SelectionListGuiImpl.adjustSi...
Greg Shah
02:42 PM Feature #1811: implement the AJAX client driver
Committed revision 11013. Changed @AbstractGuiDriver@.
>if the OS-level window minimize event has been triggered, o...
Sergey Ivanovskiy
02:13 PM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> Committed revision 11012. Changed to improve visual effects of adding new windows.
>
>...
Constantin Asofiei
02:08 PM Feature #1811: implement the AJAX client driver
Committed revision 11012. Changed to improve visual effects of adding new windows.
1186 deserves to be clarified, be...
Sergey Ivanovskiy
01:48 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Code Review Task Branch 1811q Revision 11011
>
> 1. In regard to adding the @selectWindow()@ t...
Constantin Asofiei
11:53 AM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 11011
1. In regard to adding the @selectWindow()@ to the @GuiWebDriver.icon...
Greg Shah
10:07 AM Feature #1811: implement the AJAX client driver
Greg, please review the committed revision 11011. It attempts to fix the incorrect current window bug. Sergey Ivanovskiy
09:49 AM Feature #1811: implement the AJAX client driver
Propose to overide... Sergey Ivanovskiy
08:47 AM Feature #1811: implement the AJAX client driver
Found an inconsistent state for @simple_windows.p@. From logs produced by this code (GuiWebDriver) in the case two wi... Sergey Ivanovskiy
05:11 AM Feature #1811: implement the AJAX client driver
Committed revision 11010 fixes comments.
Constantin, if we minimize/restore the selected window, we get the round tri...
Sergey Ivanovskiy
10:37 AM Bug #2700: gui_btn_test4.p abend with "Invalid frame ID 4"
The root cause for @gui_btn_test4.p@ is this:... Constantin Asofiei
10:32 AM Bug #2707: menu/simple_sm.p causes an infinite loop where the window flashes and the OS is nearly...
I was using a modified version of simple_sm.p, the root cause is this:... Constantin Asofiei

09/13/2015

07:24 PM Feature #2252: implement GUI client support
Please review task branch 2424c revision 10992. Since the last review at revision 10957 the changes contain mostly st... Hynek Cihlar
07:09 PM Feature #1811: implement the AJAX client driver
Committed revision 11009. Fixed the initial task bar state.
Located the following bug. The sequence to reproduce.
@si...
Sergey Ivanovskiy
05:42 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
I've found 2 p2j bugs (see attache @z4.p@ program):
1. The conversion incorrectly process @DEFINE RECTANGLE .. LIKE ...
Igor Skornyakov
04:48 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Commited test uast/frame-z-order/z4.p revno 1324 - @RECTANCLE@ and @IMAGE@
The @MOVE-TO-TOP()@/@MOVE-TO-BOTTOM()@ ...
Igor Skornyakov
12:25 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Fixed problems with @Invalid frame ID@. There where 2 different reasons for @z2.p@ and @z3.p@.
Committed to the br...
Igor Skornyakov
10:45 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
1. Commited tests @uast/frame-z-order/z2.p@ and @uast/frame-z-order/z3.p@ revno 1323/
2. When running converted @z2....
Igor Skornyakov
08:47 AM Bug #2700: gui_btn_test4.p abend with "Invalid frame ID 4"
I wonder if this is related to running multiple testcases in the same session from @ask-gui.p@. I have seen another ... Greg Shah
08:39 AM Bug #2707: menu/simple_sm.p causes an infinite loop where the window flashes and the OS is nearly...
This still occurs for me on 1811q revision 11008. You don't see it? Could there be a change on your system that is ... Greg Shah

09/12/2015

10:40 AM Feature #1811: implement the AJAX client driver
> But there is a bug if two windows are minimized and we select the second child window by clicking on its task butto... Greg Shah
10:37 AM Feature #1811: implement the AJAX client driver
Code Review Rask Branch 1811q Revision 11008
The @setTaskIconVisible()@ seems to have duplicative code. It defini...
Greg Shah
10:24 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> You have been working on z-order since Aug 27th but I only see 1 testcase in the @testcases/uast/...
Igor Skornyakov
10:20 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
You have been working on z-order since Aug 27th but I only see 1 testcase in the @testcases/uast/frame-z-order/@ dire... Greg Shah
07:53 AM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
As far as I understand it, slider is a GUI-only widget.
Please test to confirm this.
Greg Shah

09/11/2015

07:48 PM Feature #2252: implement GUI client support
Rebased task branch 2424c from P2J trunk revision 10935 (branch revision 10984). Hynek Cihlar
07:37 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Task branch @2612a@ for review updated to revision @10936@.
This update adds first steps for @SLIDER@ widget conve...
Eugenie Lyzenko
04:36 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
The question. Do we need the support for slider widget in @ChUI@? I'm asking because some client code can be common f... Eugenie Lyzenko
08:11 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Created task branch @2612a@ from trunk revision @10935@. Eugenie Lyzenko
05:01 PM Bug #2707: menu/simple_sm.p causes an infinite loop where the window flashes and the OS is nearly...
This one is fixed in 1811q rev 11003 - it was a NPE in @FontManager.getTextWidth@. Constantin Asofiei
03:32 PM Bug #2707: menu/simple_sm.p causes an infinite loop where the window flashes and the OS is nearly...
This can be recreated in the trunk revision 10935 by running the @menu/simple_sm.p@ using the Swing client. Be prepa... Greg Shah
03:30 PM Bug #2707 (Closed): menu/simple_sm.p causes an infinite loop where the window flashes and the OS ...
Greg Shah
03:34 PM Feature #1811: implement the AJAX client driver
Committed revision 11008. Added @setTaskIconActive(windowId, active)@. For the tested example @simple_windows.p@ if w... Sergey Ivanovskiy
02:22 PM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> This code rises an interesting situation it hides the window and sets it on the top of th...
Constantin Asofiei
01:32 PM Feature #1811: implement the AJAX client driver
This code rises an interesting situation it hides the window and sets it on the top of the others.... Sergey Ivanovskiy
01:10 PM Feature #1811: implement the AJAX client driver
Going to implement this logic for the task bar
The only one button can be active:
If new button becomes active, the...
Sergey Ivanovskiy
11:32 AM Feature #1811: implement the AJAX client driver
> does it need for the presentation demo/simple_windows.p ?
No, I had other testcases that showed what I needed.
Greg Shah
10:52 AM Feature #1811: implement the AJAX client driver
> The taskbar also does not switch active windows or track active windows correctly. See @demo/simple_windows.p@.
Gr...
Sergey Ivanovskiy
09:43 AM Feature #1811: implement the AJAX client driver
Agreed that the task bar is only to display what it is directed to do. The task bar doesn't minimize and restore the ... Sergey Ivanovskiy
09:38 AM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> Some times if iconify one of these 2 - windows (@demo/simple_windows.p@) the other one is...
Constantin Asofiei
09:33 AM Feature #1811: implement the AJAX client driver
Some times if iconify one of these 2 - windows (@demo/simple_windows.p@) the other one is also iconified. I don't kno... Sergey Ivanovskiy
09:08 AM Feature #1811: implement the AJAX client driver
The taskbar also does not switch active windows or track active windows correctly. See @demo/simple_windows.p@. Greg Shah
09:02 AM Feature #1811: implement the AJAX client driver
Committed revision 11007. Fixed the background artefacts. Now VirtualScreen is not like it is supposed to be. It does... Sergey Ivanovskiy
08:53 AM Feature #1811: implement the AJAX client driver
Interestingly, the combo-box button mostly works (see @demo/demo_widgets.p@):
!combo_box_button_mostly_works.png!
...
Greg Shah
08:24 AM Feature #1811: implement the AJAX client driver
> After this update the web images rendering is broken.
The parts that are broken are implemented using @VectorGra...
Greg Shah
08:17 AM Feature #1811: implement the AJAX client driver
Committed revision 11005. Minor changes to truncate long task icon titles. Sergey Ivanovskiy
08:02 AM Feature #1811: implement the AJAX client driver
After this update the web images rendering is broken. I need to fix it.
!images_artifacts.png!
Sergey Ivanovskiy
03:04 PM Bug #2706: window title attribute is not honored
The @demo/simple_windows.p@ testcase assigns the title to a window that it creates. In the 4GL, the result is this:
...
Greg Shah
03:02 PM Bug #2706 (Closed): window title attribute is not honored
Greg Shah
02:34 PM Bug #2705: frame sizing using SIZE phrase is not honored
Refer to the @ask-gui.p@ screenshots (4GL, P2J Web and P2J Swing) in #2701-2
The frame is no-box and side-labels. ...
Greg Shah
02:32 PM Bug #2705 (Closed): frame sizing using SIZE phrase is not honored
Greg Shah
02:31 PM Bug #2704: large fill-in drawing differences
Refer to the @ask-gui.p@ screenshots (4GL, P2J Web and P2J Swing) in #2701-2
The "Program Name" fill-in has the fo...
Greg Shah
02:27 PM Bug #2704 (Closed): large fill-in drawing differences
Greg Shah
10:21 AM Feature #2673: support a kind of virtual desktop in the GUI web client
> More worrisome, is that we don't provide any way for accessing windows that are positioned outside of the currently... Greg Shah
09:38 AM Feature #2564: implement GUI BROWSE widget
> Please provide more details on your findings about what is not yet properly implemented.
!compare.png!
Here is a ...
Stanislav Lomany
07:50 AM Feature #2564: implement GUI BROWSE widget
> usual fill-in (not yet properly implemented in P2J)
Please provide more details on your findings about what is n...
Greg Shah
09:21 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Fixed the issue with OVERLAY/TOP-ONLY combination (see note 204 above).
Committed to branch 2567b revno 10941
Igor Skornyakov
07:44 AM Bug #2701: default font text sizing issue
-------- Forwarded Message --------
Subject: Re: label problem or something I did wrong?
Date: Thu, 10 Sep 2015 2...
Greg Shah

09/10/2015

07:15 PM Feature #1811: implement the AJAX client driver
Rebased task branch 1811q from P2J trunk revision 10935. The latest branch revision is 11004.
Please save off and ...
Greg Shah
04:33 PM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> Greg, Constantin, how to go forward from the simple Hello program to more complicated? Te...
Constantin Asofiei
04:29 PM Feature #1811: implement the AJAX client driver
Sergey, for the keyboard support for the Web client, we need a JS version of what @driver.swing.WinKeyboardReader@ cl... Constantin Asofiei
04:00 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> My only question is whether we can disable mouse event processing when a given window is hidden/n...
Constantin Asofiei
03:58 PM Feature #1811: implement the AJAX client driver
Try any of these:... Greg Shah
03:53 PM Feature #1811: implement the AJAX client driver
Greg, Constantin, how to go forward from the simple Hello program to more complicated? Tested an example taken from P... Sergey Ivanovskiy
03:31 PM Feature #1811: implement the AJAX client driver
Committed revision 11002. Minor changes: fixed methods javadocs. Sergey Ivanovskiy
02:16 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 11001
This is a really nice update.
My only question is whether we can d...
Greg Shah
01:59 PM Feature #1811: implement the AJAX client driver
Sergey, I've switched "key processing differences for GUI" from Constantin to you. Please work on that next.
Cons...
Greg Shah
01:48 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 11000
It looks very good.
The single line javadoc format is only used fo...
Greg Shah
01:47 PM Feature #1811: implement the AJAX client driver
1811q revision 11001 contains:
# added mouse web actions for remaining widgets
# All windows listen to any mouse ac...
Constantin Asofiei
01:35 PM Feature #1811: implement the AJAX client driver
> please let me know if/when I can commit them.
Go ahead now.
Greg Shah
01:34 PM Feature #1811: implement the AJAX client driver
Greg/Sergey, I have a large set of changes to commit to 1811q, related to mouse processing: please let me know if/whe... Constantin Asofiei
12:59 PM Feature #1811: implement the AJAX client driver
Greg, please review the committed revision 11000. There are two cases to add new visible state to TaskIcon and to man... Sergey Ivanovskiy
10:16 AM Feature #1811: implement the AJAX client driver
OK, go with that approach.
I don't see the difference that the @10 * lighthenColor(textActiveColor)@ is making. B...
Greg Shah
10:10 AM Feature #1811: implement the AJAX client driver
It can help to select the most usable colours.!TaskBarChangedColours.png! On the picture
the task bar background is [...
Sergey Ivanovskiy
09:47 AM Feature #1811: implement the AJAX client driver
!P2JGUIClient.png! Sergey Ivanovskiy
09:18 AM Feature #1811: implement the AJAX client driver
Please post an example screen shot of the results with your proposed inactive/active colors. Greg Shah
09:14 AM Feature #1811: implement the AJAX client driver
> draw the background of the inactive window task buttons as a lighter grey color so that the active/inactive buttons... Sergey Ivanovskiy
09:03 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> > 2. pressing maximize button makes client unresponsive (CA)
>
> Although the client is no lon...
Constantin Asofiei
08:46 AM Feature #1811: implement the AJAX client driver
Sergey: On the taskbar, please draw the background of the inactive window task buttons as a lighter grey color so tha... Greg Shah
08:33 AM Feature #1811: implement the AJAX client driver
> 2. pressing maximize button makes client unresponsive (CA)
Although the client is no longer unresponsive, the ma...
Greg Shah
08:05 AM Feature #1811: implement the AJAX client driver
> Proved on windev01 that if a window is hidden, it is removed from the task bar.
This one does need to be impleme...
Greg Shah
08:04 AM Feature #1811: implement the AJAX client driver
> Isn't stacking just a setting at the Window's OS taskbar? I don't think we need to emulate this.
Agreed. Stacki...
Greg Shah
05:27 AM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> But Window 8 OS stacks all windows created by the progress. It is displayed on the attach...
Constantin Asofiei
05:25 AM Feature #1811: implement the AJAX client driver
Proved on windev01 that if a window is hidden, it is removed from the task bar. But Window 8 OS stacks all windows cr... Sergey Ivanovskiy
06:57 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Rebased task branch 2567b from P2J trunk revision 10935 (new branch revision 10940). Igor Skornyakov
06:33 PM Bug #2703: VIEW of a dynamic widget abends
Running this code (@testcases/uast/minimal_view_dynamic_widget.p@):... Greg Shah
06:28 PM Bug #2703 (New): VIEW of a dynamic widget abends
Greg Shah
06:12 PM Feature #2606 (Closed): implement GUI runtime support for SELECTION-LIST
Greg Shah
05:51 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ has been archived. Eugenie Lyzenko
05:40 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ has been merged/committed into trunk as bzr revision @10935@. Eugenie Lyzenko
05:15 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ has been updated and rebased with @10934@ up to revision @10953@. Starting merge into trunk. Eugenie Lyzenko
04:48 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
> because only GUI code will be touched(only @ui/client/gui/ScrollBarGuiButton@) - merge final 2606a into trunk.
>
...
Greg Shah
04:43 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Regression testing completed. Results: @2606a_10950_16cd2a2_20150910_evl.zip@. No problems found.
My plan is:
Reb...
Eugenie Lyzenko
11:29 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
>Good, this can be merged to trunk if it passes testing. When do you expect runtime testing results?
The @CTRL-C@ te...
Eugenie Lyzenko
10:13 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Good, this can be merged to trunk if it passes testing. When do you expect runtime testing results? Greg Shah
09:52 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10951@.
>Please commit that comment change.
Done.
Eugenie Lyzenko
08:22 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Please commit that comment change. Greg Shah
08:06 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Greg Shah wrote:
> Code Review Task Branch 2606a Revision 10950
>
> My only question is regarding this:
>
> [....
Eugenie Lyzenko
07:53 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Code Review Task Branch 2606a Revision 10950
My only question is regarding this:...
Greg Shah
08:48 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Conversion test completed without regressions. The generated codes are the same. Starting runtime testing for @10950@... Eugenie Lyzenko
05:11 PM Bug #2702: MESSAGE SET/UPDATE in GUI mode implicitly enables a special VIEW-AS ALERT-BOX mode
When in GUI mode, a "normal" MESSAGE SET or MESSAGE UPDATE will implicitly use a special kind of alert-box instead of... Greg Shah
04:57 PM Bug #2702 (Closed): MESSAGE SET/UPDATE in GUI mode implicitly enables a special VIEW-AS ALERT-BOX...
Greg Shah
04:16 PM Feature #2564: implement GUI BROWSE widget
I found no metris differences in 3D and non-3D modes.
DEFAULT-FONT/DEFAULT-FIXED-FONT doesn't affect browse header.
...
Stanislav Lomany
02:04 AM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> >Stanislav, which font are you referring to? DEFAULT-FONT/DEFAULT-FIXED-FONT or an explici...
Constantin Asofiei
03:25 PM Bug #2701: default font text sizing issue
The @testcases/uast/ask-gui-fake-label.p@ uses a non-enabled fillin as a label/static text field. The "Program Name"... Greg Shah
03:18 PM Bug #2701 (Closed): default font text sizing issue
Greg Shah
01:31 PM Bug #2678 (Closed): scrollbar button arrow drawing is not 100% identical
Greg Shah
12:59 PM Bug #2678: scrollbar button arrow drawing is not 100% identical
Merged into trunk as revision @10934@. Archived. Eugenie Lyzenko
12:46 PM Bug #2678: scrollbar button arrow drawing is not 100% identical
Code Review Task Branch 2678a Revision 10941
It looks good.
Please merge this to trunk.
Greg Shah
11:58 AM Bug #2678: scrollbar button arrow drawing is not 100% identical
Task branch @2678a@ for review updated to revision @10941@.
>The only problem I see is that the bar on the top of ...
Eugenie Lyzenko
07:48 AM Bug #2678: scrollbar button arrow drawing is not 100% identical
Code Review Task Branch 2678a Revision 10940
The changes are good.
The only problem I see is that the bar on th...
Greg Shah
11:46 PM Bug #2678: scrollbar button arrow drawing is not 100% identical
Task branch @2678a@ for review updated to revision @10940@.
This update implements sharp images drawing. Almost al...
Eugenie Lyzenko
11:21 AM Bug #2700: gui_btn_test4.p abend with "Invalid frame ID 4"
When running the @button/gui_btn_test4.p@ in the Swing GUI client (using trunk revision 10933), the program abends ju... Greg Shah
11:14 AM Bug #2700 (Closed): gui_btn_test4.p abend with "Invalid frame ID 4"
Greg Shah

09/09/2015

07:46 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10950@.
Please review this small GUI fix for dotted focus mark...
Eugenie Lyzenko
05:25 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Greg Shah wrote:
> Code Review Task Branch 2606a Revision 10949
>
> I'm good with the changes.
>
> Please get ...
Eugenie Lyzenko
05:16 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Code Review Task Branch 2606a Revision 10949
I'm good with the changes.
Please get this regression tested (conv...
Greg Shah
04:38 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10949@.
Please review the horizontal scrolling implementation ...
Eugenie Lyzenko
11:19 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Rebased task branch @2606a@ from P2J trunk revision @10933@, new branch revision is @10948@. Eugenie Lyzenko
07:30 PM Feature #2564: implement GUI BROWSE widget
>Stanislav, which font are you referring to? DEFAULT-FONT/DEFAULT-FIXED-FONT or an explicit font set at the BROWSE?
...
Stanislav Lomany
05:36 PM Feature #2564: implement GUI BROWSE widget
> Row markers column's width depends on font width. I couldn't make 100% accurate formula, but it is very close to fl... Constantin Asofiei
05:25 PM Feature #2564: implement GUI BROWSE widget
Good work.
> Row markers column's width depends on font width. I couldn't make 100% accurate formula, but it is ve...
Greg Shah
04:46 PM Feature #2564: implement GUI BROWSE widget
Read-only browse metrics.
Browse header height is 20 px (with borders) (I haven't found a way to alternate title fon...
Stanislav Lomany
07:06 PM Bug #2678: scrollbar button arrow drawing is not 100% identical
It works. No fuzzy effect anymore. But this shows some @SVG@ images are not good, need to rework. Or may be play with... Eugenie Lyzenko
06:04 PM Bug #2678: scrollbar button arrow drawing is not 100% identical
> SharpPNGTranscoder with only overridden method createRenderer and turn the antialias off for created renderer - I g... Greg Shah
06:00 PM Bug #2678: scrollbar button arrow drawing is not 100% identical
Some findings. During the batik source code investigation I've found the @PNGTranscoder@ creates @ImageRenderer@ obje... Eugenie Lyzenko
10:55 AM Bug #2678: scrollbar button arrow drawing is not 100% identical
Rebased task branch @2678a@ from P2J trunk revision @10933@, new branch revision is @10939@. Eugenie Lyzenko
10:25 AM Bug #2678: scrollbar button arrow drawing is not 100% identical
Hynek Cihlar wrote:
> Result of the scaled images (title bar and scroll bars) should also be tested. Scaling was one...
Hynek Cihlar
10:00 AM Bug #2678: scrollbar button arrow drawing is not 100% identical
Does Batik support the @shape-rendering@ SVG property? The @crisp-edges@ value might be what we are looking for.
...
Greg Shah
09:31 AM Bug #2678: scrollbar button arrow drawing is not 100% identical
Greg Shah wrote:
> I am OK with you merging to trunk.
>
> However, before you do that I would like to discuss the...
Eugenie Lyzenko
08:42 AM Bug #2678: scrollbar button arrow drawing is not 100% identical
Result of the scaled images (title bar and scroll bars) should also be tested. Scaling was one of the motivations to ... Hynek Cihlar
08:28 AM Bug #2678: scrollbar button arrow drawing is not 100% identical
I am OK with you merging to trunk.
However, before you do that I would like to discuss the drawing differences tha...
Greg Shah
08:23 AM Bug #2678: scrollbar button arrow drawing is not 100% identical
Code Review Task Branch 2678a Revision 10938
The code changes are good.
Greg Shah
08:22 AM Bug #2678: scrollbar button arrow drawing is not 100% identical
The W3C license is acceptable.
1. It is officially approved by OSI: http://opensource.org/licenses/alphabetical
...
Greg Shah
10:41 PM Bug #2678: scrollbar button arrow drawing is not 100% identical
Rebased task branch @2678a@ from P2J trunk revision @10932@, new branch revision is @10938@. Eugenie Lyzenko
08:47 PM Bug #2678: scrollbar button arrow drawing is not 100% identical
Task branch @2678a@ for review updated to revision @10937@.
Notes resolution.
>2. The new code in ImageHelper rea...
Eugenie Lyzenko
06:51 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> I see.
>
> OVERLAY means that the frame with OVERLAY option or OVERLAY attribute set true "can...
Igor Skornyakov
06:48 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
I see.
OVERLAY means that the frame with OVERLAY option or OVERLAY attribute set true "can overlay" other frames.
Greg Shah
06:46 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> > This looks counterintuitive for me.
>
> I think this is simply the fact that by default the ...
Igor Skornyakov
06:43 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
> This looks counterintuitive for me.
I think this is simply the fact that by default the 4GL does auto-hiding of ...
Greg Shah
06:17 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Actually the 4GL behavior is a a little bit weird. If we have two overlapping frames @fr1@ and @fr2@ then @fr1@ is vi... Igor Skornyakov
05:20 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Revised conversion support for the OVERLAY and TOP-ONLY attributes.
Committed to branch 2567b revno 10935
Igor Skornyakov
04:09 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
I think that the similar problem with e.g. @FRAME:LINE@ attribute (currently not supported). Igor Skornyakov
04:01 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
I was thinking about the @FrameInterface@ but the @GenericFrame@ where @setTopOnly@ and @setOverlay@ methods are impl... Igor Skornyakov
03:55 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
@OVERLAY@ should be in @FrameInterface@.
@TOP-ONLY@ will need a new interface that can contain attrs and methods t...
Greg Shah
03:49 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
I have a question. What is the right interface for the TOP-ONLY/OVERLAY *attributes* support? I've added the correspo... Igor Skornyakov
03:43 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
> I planned to do it in parallel with regression testing
OK.
Greg Shah
03:40 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Have you tested your updated tooltips implementation with all the current widget types? If so, d...
Igor Skornyakov
03:38 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Have you tested your updated tooltips implementation with all the current widget types? If so, does it work generica... Greg Shah
02:23 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Added conversion support for the OVERLAY and TOP-ONLY attributes (was for the corresponding options only).
Committ...
Igor Skornyakov
10:25 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> > No, the issue is that with p2j the TOP-ONLY does not affect the initial visibility of the frame...
Igor Skornyakov
10:21 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
> No, the issue is that with p2j the TOP-ONLY does not affect the initial visibility of the frame.
Please do fix t...
Greg Shah
10:21 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
> the triggers use uppercase letters
Good point, thanks.
Greg Shah
10:12 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> In the @z2.p@ program, the @a@, @b@, @c@, @x@, @y@ and @z@ ANYWHERE triggers are not working. It...
Constantin Asofiei
10:10 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> 1. Is this true for ChUI and GUI?
Yes, it is.
> 2. Is this the cause of the issue reported in...
Igor Skornyakov
10:08 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
In the @z2.p@ program, the @a@, @b@, @c@, @x@, @y@ and @z@ ANYWHERE triggers are not working. It is hard to really t... Greg Shah
10:06 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> It looks that the value of the @FRAME:TOP-ONLY@ attribute affects only the inital visibilit...
Greg Shah
09:55 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
It looks that the value of the @FRAME:TOP-ONLY@ attribute affects only the inital visibility of the frame. Neither sw... Igor Skornyakov
08:18 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> > With 4GL the frame fr1 (see attached sample) is not VISIBLE (both in ChUI and Windows modes) wh...
Igor Skornyakov
07:59 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
> With 4GL the frame fr1 (see attached sample) is not VISIBLE (both in ChUI and Windows modes) while with p2j it is.
...
Greg Shah
06:04 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
I've found an incompability between 4GL and p2j. With 4GL the frame @fr1@ (see attached sample) is not VISIBLE (both ... Igor Skornyakov
06:36 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> > The remove task icon use case is not implemented. I think if the window is closed the correspo...
Constantin Asofiei
06:19 PM Feature #1811: implement the AJAX client driver
> The remove task icon use case is not implemented. I think if the window is closed the corresponding task icon shou... Greg Shah
06:16 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10999
The result is good.
1. The two new members of @WindowTitleBar.Wind...
Greg Shah
06:09 PM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> The remove task icon use case is not implemented. I think if the window is closed the cor...
Constantin Asofiei
06:04 PM Feature #1811: implement the AJAX client driver
Greg, please review the committed revision 10999. 1) Fixed @gd.setTitle()@ on @draw()@, 2) Sets the default font for ... Sergey Ivanovskiy
03:31 PM Feature #1811: implement the AJAX client driver
Rebased task branch 1811q from trunk revision 10933. Latest revision is now 10998. Greg Shah
02:24 PM Feature #1811: implement the AJAX client driver
> 2. Using SET_FONT to also set the taskbar font is wrong. We are constantly changing the font via SET_FONT, but none... Sergey Ivanovskiy
01:03 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10995
This is really good!
1. The unconditional call to @gd.setTitle()@ ...
Greg Shah
12:14 PM Feature #1811: implement the AJAX client driver
!TaskBarHorizontal.png! Sergey Ivanovskiy
11:59 AM Feature #1811: implement the AJAX client driver
Greg, please review the committed revision 10995. All known task bar usecases are implemented here. Sergey Ivanovskiy
06:15 AM Feature #1811: implement the AJAX client driver
Greg, Constantin, is it possible on the server (ThinClient) side to determine a widget component at the given point (... Sergey Ivanovskiy

09/08/2015

07:45 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Added MOVE-TO-TOP()/MOVE-TO-BOTTOM() for frames to testcases/uast/frame-z-order. revno 1316 Igor Skornyakov
07:32 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Implemented @MOVE-TO-TOP()@/@MOVE-TO-BOTTOM()@ for frames.
Committed to branch 2567b revno 10932
Igor Skornyakov
06:08 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Sorry, please disregard the previous post. Igor Skornyakov
06:05 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
There is some small incompatibility between 4GL and p2j in ChUI mode. With the attached program when the Z-order of f... Igor Skornyakov
05:52 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
> I understand that.
OK, sorry I misunderstood.
Greg Shah
05:25 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> It may be that originally, frames were the most important feature. But the application code we a...
Igor Skornyakov
05:21 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
> In fact at this moment I'm about to finish runtime support for the case with frames. I understand it is the main on... Greg Shah
05:04 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Please check in your testcases. This will help me understand the research you are doing.
>
> ...
Igor Skornyakov
04:52 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Please check in your testcases. This will help me understand the research you are doing.
When do you expect to ha...
Greg Shah
06:32 PM Bug #2678: scrollbar button arrow drawing is not 100% identical
>4. Are the xml-apis-1.3.04.jar, xml-apis-ext-1.3.04.jar and xmlgraphics-commons-2.0.jar from Apache commons? I want ... Eugenie Lyzenko
05:11 PM Bug #2678: scrollbar button arrow drawing is not 100% identical
>1. Using the latest revision, please post screen-shots of each resulting image and a comparison image of the same 4G... Eugenie Lyzenko
02:26 PM Bug #2678: scrollbar button arrow drawing is not 100% identical
Greg Shah wrote:
> Code Review Task Branch 2678a Revision 10936
>
> Good work!
>
> 1. Using the latest revisio...
Eugenie Lyzenko
10:05 AM Bug #2678: scrollbar button arrow drawing is not 100% identical
Code Review Task Branch 2678a Revision 10936
Good work!
1. Using the latest revision, please post screen-shots ...
Greg Shah
08:22 AM Bug #2678: scrollbar button arrow drawing is not 100% identical
The findings:
1. Using @TIFF@ does not have advantages, the look is the same as for @PNG@.
2. Handling @SVG@ from @...
Eugenie Lyzenko
07:30 AM Bug #2678: scrollbar button arrow drawing is not 100% identical
Some news. According to this:... Eugenie Lyzenko
09:48 PM Bug #2678: scrollbar button arrow drawing is not 100% identical
Task branch @2678a@ for review updated to revision @10936@.
This update adds SVG based image handling to the @Comb...
Eugenie Lyzenko
06:04 PM Feature #1811: implement the AJAX client driver
Committed revision 10994. Greg, please review "set title" changes. Sergey Ivanovskiy
02:25 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10992
I'm fine with the changes.
Please do not use @/*@ or @/**@ style c...
Greg Shah
02:21 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10990
I'm fine with the changes.
Greg Shah
02:17 PM Feature #1811: implement the AJAX client driver
> The following issue arises a title text for a window task widget can vary its size and if we permit a task widget ... Greg Shah
01:09 PM Feature #1811: implement the AJAX client driver
Committed revision 10993. Added view log button to the task bar and changed to use only one listener for all task ico... Sergey Ivanovskiy
06:21 AM Feature #1811: implement the AJAX client driver
Committed revision 10992. Added drawText and drawScaledText to CanvasRenderer. Sergey Ivanovskiy
05:53 PM Feature #1790 (Closed): implement menu support
Greg Shah
05:24 PM Feature #1790: implement menu support
Branch 1790e was merged to trunk rev 10932 and archived. Constantin Asofiei
09:24 AM Feature #1790: implement menu support
Please merge to trunk when it passes testing. Greg Shah
04:24 AM Feature #1790: implement menu support
Conversion testing has passed. Constantin Asofiei
04:12 AM Feature #1790: implement menu support
Runtime testing almost passed, need to clear some false negatives. Constantin Asofiei
02:30 PM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > Eugenie, isn't the combo's drop-down supposed to close when ...
Constantin Asofiei
02:18 PM Feature #2546: implement combo-box widget in GUI
Constantin Asofiei wrote:
> Eugenie, isn't the combo's drop-down supposed to close when a item is chosen via mouse c...
Eugenie Lyzenko
02:03 PM Feature #2546: implement combo-box widget in GUI
Eugenie, isn't the combo's drop-down supposed to close when a item is chosen via mouse click? Because currently it d... Constantin Asofiei
09:49 AM Bug #2557: Fix MENUBAR layouting in a window
We need to test to see if these issues are still a problem. Greg Shah
04:11 AM Bug #2690: ChUI quirk when sub-menu doesn't have any children
From #1790 note 573:
> I've faced with the following bug in CHUI: when some sub-menu has no items at all, but it i...
Constantin Asofiei
04:11 AM Bug #2690 (New): ChUI quirk when sub-menu doesn't have any children
Constantin Asofiei
04:10 AM Bug #2689: multiple items with same mnemonic
Previous entry was edited. Constantin Asofiei
04:09 AM Bug #2689: multiple items with same mnemonic
From #1790 note 570:
> And the last found peculiarity is about mnemonic behavior when a menu or sub-menu contains sev...
Constantin Asofiei
04:08 AM Bug #2689 (New): multiple items with same mnemonic
Constantin Asofiei
08:11 PM Feature #2564: implement GUI BROWSE widget
> In terms of drawing there are some minor metrics remain.
Please get the metrics exactly right from the beginning...
Greg Shah

09/07/2015

05:31 PM Feature #1811: implement the AJAX client driver
Great! iconify/deiconify works properly I have checked it. Committed revision 10991. - javadoc and set_title logs. Sergey Ivanovskiy
05:17 PM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> Constantin, the iconify/deiconify will be working properly as soon as you fix the priorit...
Constantin Asofiei
04:52 PM Feature #1811: implement the AJAX client driver
Greg, Constantin, do you agree to move drawString and drawScaledString to p2j.canvas_renderer.js. I think currentFont... Sergey Ivanovskiy
04:46 PM Feature #1811: implement the AJAX client driver
> > 3. The most important thing is to get the iconify/deinconify processing working properly.
> The base logic for i...
Sergey Ivanovskiy
04:08 PM Feature #1811: implement the AJAX client driver
>1. I was not planning to support tooltips, nor drag/drop. We are already going to have a heavy load of mouse event p... Sergey Ivanovskiy
04:06 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> 3. The most important thing is to get the iconify/deinconify processing working properly.
The ba...
Constantin Asofiei
03:02 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10987
Definitely there is a lot of good work here. I have checked in minor...
Greg Shah
02:25 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10983
Nice improvements.
Greg Shah
01:13 PM Feature #1811: implement the AJAX client driver
Committed revision 10987. Fixed tooltips for task icons. Now if we click on the minimize button, the action sinks on ... Sergey Ivanovskiy
05:24 PM Feature #1790: implement menu support
branch 1790e was rebased from trunk rev 10931 (new branch rev 10965).
Regression testing is in progress.
Constantin Asofiei
06:25 AM Feature #1790: implement menu support
1790e rev 10964 contains some misc formatting/header fixes. Constantin Asofiei
04:10 AM Feature #1790: implement menu support
Please let me know once you rebase, I have some changes to commit. Constantin Asofiei
03:35 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> I've committed my changes to 1790e revno 10963.
I'm reviewing rev 10963 now. Please rebase f...
Constantin Asofiei
02:18 AM Feature #1790: implement menu support
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > I've faced with the following bug in CHUI: when some sub-menu h...
Vadim Gindin
01:17 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> I've faced with the following bug in CHUI: when some sub-menu has no items at all, but it is i...
Constantin Asofiei
04:18 PM Feature #2564: implement GUI BROWSE widget
> What other research is needed before you are ready to start implementation?
In terms of drawing there are some min...
Stanislav Lomany
12:06 PM Feature #2564: implement GUI BROWSE widget
Good info.
What other research is needed before you are ready to start implementation? I do want you to understan...
Greg Shah
09:45 AM Feature #2564: implement GUI BROWSE widget
Browse column width metrics.
!browse-metrcis.png !
* WIDTH on the picture corresponds the value returned by @WIDTH-P...
Stanislav Lomany
03:29 PM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> The list of open 2424c issues:
> - out of memory error during execution of gso_185
The out...
Hynek Cihlar
03:27 PM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> > Wow, great find! Please see the checked in fix in 2424c/10967.
> What about the @root...
Hynek Cihlar
03:17 PM Feature #2252: implement GUI client support
>Eugenie, please see the note 1164.
>> This means the issue is in P2J, not in "wrong baseline" test screen.
>The...
Eugenie Lyzenko
03:03 PM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek, I've found the root cause: at the time @FrameChuiImpl.dr...
Constantin Asofiei
01:19 PM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek, I've found the root cause: at the time @FrameChuiImpl.draw@ is called, the @viewP...
Hynek Cihlar
12:46 PM Feature #2252: implement GUI client support
Eugenie Lyzenko wrote:
> The source file is:
> @syman/po/text-block-select.p@:
> [...]
> So I think the expected ...
Hynek Cihlar
11:09 AM Feature #2252: implement GUI client support
Hynek, I've found the root cause: at the time @FrameChuiImpl.draw@ is called, the @viewPort@ instance is located at @... Constantin Asofiei
10:50 AM Feature #2252: implement GUI client support
Eugenie Lyzenko wrote:
> The source file is:
> @syman/po/text-block-select.p@:
Can you extract the logic in a samp...
Constantin Asofiei
10:49 AM Feature #2252: implement GUI client support
The source file is:
@syman/po/text-block-select.p@:...
Eugenie Lyzenko
09:53 AM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > > 24 July 2014. This is certainly not a native 4GL environment....
Constantin Asofiei
09:50 AM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> > 24 July 2014. This is certainly not a native 4GL environment.
> Hynek: GC 62 will req...
Hynek Cihlar
09:45 AM Feature #2252: implement GUI client support
> 24 July 2014. This is certainly not a native 4GL environment.
Hynek: GC 62 will require screen updates to reflect ...
Constantin Asofiei
09:02 AM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> The problem I think is related to @BorderedPanelImpl.drawPanel@ - the @border@ instance ...
Hynek Cihlar
08:32 AM Feature #2252: implement GUI client support
Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> >
> > Eugenie, any idea when GC 62 was added and if the scre...
Hynek Cihlar
08:00 AM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
>
> Eugenie, any idea when GC 62 was added and if the screen was captured from the legac...
Eugenie Lyzenko
06:52 AM Feature #2252: implement GUI client support
Hynek, I think 2424c is right to add scrollbars to the frame. There is no "native env" where we can test the MAJIC 4... Constantin Asofiei
06:39 AM Feature #2252: implement GUI client support
In the 2424c test results the test gc_62 fails on the following frame.... Hynek Cihlar
05:48 AM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > And a cleaned-up version - the frame width has nothing to do, o...
Constantin Asofiei
05:41 AM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> And a cleaned-up version - the frame width has nothing to do, only the @DOWN@ is problem...
Hynek Cihlar
05:11 AM Feature #2252: implement GUI client support
And a cleaned-up version - the frame width has nothing to do, only the @DOWN@ is problematic. Do you recall having d... Constantin Asofiei
05:05 AM Feature #2252: implement GUI client support
The key part I think is to set the @page-size@ for the stream. This test duplicates the problem:... Constantin Asofiei
04:52 AM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> Hynek, this looks like a frame height issue when the stream is redirected to terminal. ...
Hynek Cihlar
04:47 AM Feature #2252: implement GUI client support
Hynek, this looks like a frame height issue when the stream is redirected to terminal. All the frames are displayed,... Constantin Asofiei
04:19 AM Feature #2252: implement GUI client support
Constantin Asofiei wrote:
> If you you point me the test results folder on devsrv01 and the failed test names, I can...
Hynek Cihlar
04:14 AM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > The list of open 2424c issues:
> >
> > - incorrect width of report...
Constantin Asofiei
04:07 AM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> The list of open 2424c issues:
>
> - incorrect width of report output
I have fixed one p...
Hynek Cihlar
12:37 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Thank you very much Greg! Igor Skornyakov
12:32 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
There is an issue with your frame definitions. As noted in the 4GL documentation:... Greg Shah
12:06 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
It seems that I was confused by my tests and in reality the only(?) way to switch between overlapping frames is to ex... Igor Skornyakov
09:04 PM Bug #2678: scrollbar button arrow drawing is not 100% identical
Task branch @2678a@ for review updated to revision @10935@.
This update adds @min/max/close/restore@ buttons support...
Eugenie Lyzenko

09/06/2015

07:51 PM Feature #1811: implement the AJAX client driver
Committed revision 10985. Added the first task bar version, iconify/deiconify don't work as expected. Planning to fix... Sergey Ivanovskiy
06:14 PM Feature #1790: implement menu support
I've faced with the following bug in CHUI: when some sub-menu has no items at all, but it is included in a MENUBAR (o... Vadim Gindin
03:37 PM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> Guys, consider the case in which field format is short, e.g. "x(1)". Browse column cannot ...
Constantin Asofiei
03:33 PM Feature #2564: implement GUI BROWSE widget
Guys, consider the case in which field format is short, e.g. "x(1)". Browse column cannot be narrower than some font-... Stanislav Lomany
06:46 AM Feature #2252: implement GUI client support
Greg Shah wrote:
> > I will continue tomorrow (Sunday).
>
> OK.
>
> Since both #2606 and #1811 are heavily dep...
Hynek Cihlar
06:45 AM Feature #2252: implement GUI client support
> I will continue tomorrow (Sunday).
OK.
Since both #2606 and #1811 are heavily dependent upon 2424c, we need t...
Greg Shah

09/05/2015

07:35 PM Feature #2252: implement GUI client support
The list of open 2424c issues:
- incorrect width of report output
- out of memory error during execution of gso_1...
Hynek Cihlar
11:43 AM Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review Task Branch 2424c Revision 10962
>
> The changes are fine.
>
> Is this a candid...
Hynek Cihlar
10:39 AM Feature #2252: implement GUI client support
Code Review Task Branch 2424c Revision 10962
The changes are fine.
Is this a candidate for merge to trunk or do...
Greg Shah
10:16 PM Feature #2252: implement GUI client support
The regression test of 2424c failed with an exception caused by duplicate detachment of alert box widget. Fix checked... Hynek Cihlar
07:31 PM Bug #2678: scrollbar button arrow drawing is not 100% identical
Task branch @2678a@ for review updated to revision @10934@.
This update adds caching ability for @SVG@ images hand...
Eugenie Lyzenko
08:27 PM Bug #2678: scrollbar button arrow drawing is not 100% identical
Task branch @2678a@ for review updated to revision @10933@.
This update for review contains first working release ...
Eugenie Lyzenko
01:41 PM Feature #1790: implement menu support
Vadim Gindin wrote:
> Constantin, do you propose not to store original label and store only prepared along with mnem...
Constantin Asofiei
12:27 PM Feature #1790: implement menu support
Constantin, do you propose not to store original label and store only prepared along with mnemonic and mnemonic chara... Vadim Gindin
11:20 AM Feature #1790: implement menu support
The current '&' processing algorithm @MenuItem.prepTitle(String)@ is incorrect. Here is the actual algorithm.
Source...
Vadim Gindin
09:52 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> All know issues are fixed (except mnemonics). It would be good to test it some more time.
>
...
Constantin Asofiei
09:42 AM Feature #1790: implement menu support
Greg Shah wrote:
> > Can we set aside specific cases implementation for some time?
>
> Is this especially difficu...
Vadim Gindin
12:14 PM Feature #1811: implement the AJAX client driver
Greg, please review committed revision 10984. Drawing functionalities are moved to p2j.canvas_renderer.js in order to... Sergey Ivanovskiy
11:11 AM Feature #1811: implement the AJAX client driver
1811q rev 10983 contains (for @2. pressing maximize button makes client unresponsive (CA)@ in note 1087):
# don't se...
Constantin Asofiei
09:59 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10982
Really good!
Greg Shah
08:13 PM Feature #1811: implement the AJAX client driver
1811q rev 10982 contains an improvement for web driver: all requests incoming from the JS are pushed and processed in... Constantin Asofiei

09/04/2015

04:57 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Rebased task branch @2606a@ from P2J trunk revision @10931@, new branch revision is @10945@.
The SVG code/libs has...
Eugenie Lyzenko
09:34 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Eugenie Lyzenko wrote:
> I'm going to put the @SVG@ images into
> [...]
> directory inside the sources/@p2j.jar@. ...
Greg Shah
11:49 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10945@.
Adding basic steps to implement @SVG@ handler. Still d...
Eugenie Lyzenko
04:33 PM Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review Task Branch 2424c Revision 10961
>
> I'm OK with the changes.
>
> Do you expect...
Hynek Cihlar
02:42 PM Feature #2252: implement GUI client support
Code Review Task Branch 2424c Revision 10961
I'm OK with the changes.
Do you expect to pass testing today? If ...
Greg Shah
02:21 PM Feature #2252: implement GUI client support
More fixes checked in to task branch 2424c, revision 10961. Restarted Majic regression tests. Hynek Cihlar
12:42 PM Feature #2252: implement GUI client support
Code Review Task Branch 2424c Revision 10960
The changes are good. I especially like the @ensureVisibility()@ sim...
Greg Shah
09:39 AM Feature #2252: implement GUI client support
Fixes for new regressions in 2424c are being finalized. I will be restarting Majic regression shortly. Hynek Cihlar
03:53 PM Feature #2683: reverse proxy implementation
One feature of our web client implementation (both ChUI and GUI) is the fact that we dynamically spawn the client and... Greg Shah
03:34 PM Feature #2683 (Closed): reverse proxy implementation
Greg Shah
02:00 PM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> Constantin, could you help to explain the logic sequence from click on the mimimize capti...
Constantin Asofiei
01:24 PM Feature #1811: implement the AJAX client driver
Constantin, could you help to explain the logic sequence from click on the mimimize caption button to @CaptionButton.... Sergey Ivanovskiy
10:36 AM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10981
This looks quite good.
In @p2j.mouse.js@, the @MousePopupable()@ c...
Greg Shah
09:42 AM Feature #1811: implement the AJAX client driver
Greg, 1811q rev 10981 replaces the window popup with the menu implementation in 1790. It's still buggy, but the bugs... Constantin Asofiei
01:23 PM Bug #2678: scrollbar button arrow drawing is not 100% identical
Task branch @2678a@ for review updated to revision @10932@.
This is the SVG related code moved from @2606a@ revisi...
Eugenie Lyzenko
12:30 PM Bug #2678: scrollbar button arrow drawing is not 100% identical
The task branch @2678a@ has been created from trunk revision @10931@. Eugenie Lyzenko
12:46 PM Feature #1790: implement menu support
> Can we set aside specific cases implementation for some time?
Is this especially difficult or risky to fix? It ...
Greg Shah
03:30 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> The differencies are the following:
> # For CHUI '&' can be mnemonic itself. To make it as a ...
Constantin Asofiei
10:43 AM Bug #2682: Swing GUI client does not honor icon in the OS level task bar
We have coded the initial implementation in #1811 (see notes 1084, 1089, 1091 and 1094 through 1103). The work is in... Greg Shah
10:41 AM Bug #2682 (New): Swing GUI client does not honor icon in the OS level task bar
Greg Shah
09:41 AM Feature #1791: implement dynamic UI support
2026c has been committed into the trunk as bzr revision 10931. Stanislav Lomany
09:38 AM Bug #2681: the titlebar height and outline does not match the 4GL version
Yes, and the active titlebar color is wrong too. It should be a dark blue instead of a light blue. Greg Shah
09:34 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
I assume you are writing many testcases to check behavior. Please make sure you are checking in your testcases to @t... Greg Shah

09/03/2015

07:10 PM Feature #1790: implement menu support
I've rebased the branch 1790e with current trunk revision. Now current branch revision is 10960. Vadim Gindin
06:54 PM Feature #1790: implement menu support
Can we set aside specific cases implementation for some time? Vadim Gindin
06:50 PM Feature #1790: implement menu support
It seems there are a lot of different (for GUI and CHUI) in mnemonic definition for specific cases when more than one... Vadim Gindin
03:25 PM Feature #1790: implement menu support
I'm currently fixing mnemonics case: when the last character is '&'. CHUI and GUI behaves differently.
# If a titl...
Vadim Gindin
12:00 PM Feature #1790: implement menu support
And something else: after rebase, please go through the notes in 522 and also do a general code cleanup for 1790e. Constantin Asofiei
11:53 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> Thank you so much! I'm testing. I'll post results.
Please rebase first, and after that start ...
Constantin Asofiei
11:49 AM Feature #1790: implement menu support
Thank you so much! I'm testing. I'll post results. Vadim Gindin
11:34 AM Feature #1790: implement menu support
1790e rev 10957 fixes cursor navigation for popup menus. I don't have anything else on my list.
Vadim: please let...
Constantin Asofiei
11:30 AM Feature #1790: implement menu support
What about @MenuItemWidget.setLabelInt@? 10957 fixes the drawing, but please fix the processing which determines whic... Constantin Asofiei
11:26 AM Feature #1790: implement menu support
I've committed mnemonic character fix. rev 10957 Vadim Gindin
11:05 AM Feature #1790: implement menu support
1790e revision 10956 fixes menubar navigation via cursor keys + ALT: some processing was moved to the @onFocusGained@... Constantin Asofiei
11:01 AM Feature #1790: implement menu support
You're right. My mistake. I'll fix it.
Talking about ALT mode: do you use additional field in a *Impl classes? Hav...
Vadim Gindin
10:21 AM Feature #1790: implement menu support
Vadim, something about mnemonics: the P2J code is made to underline the first char after the first @&@, but in 4GL it... Constantin Asofiei
09:54 AM Feature #1790: implement menu support
Vadim, I'm working on these two (and everything else related to ALT and cursor-key navigation):
> # check ALT naviga...
Constantin Asofiei
06:44 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Remaining tasks:
1. the support for the @WINDOW:FRAME-Z-ORDER@ attribute and @MOVE-TO-BOTTOM@/@MOVE-TO-TOP@ method...
Igor Skornyakov
08:10 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Please make a list of the remaining work on this task and an estimate of when it can be completed...
Igor Skornyakov
07:34 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Please make a list of the remaining work on this task and an estimate of when it can be completed. Greg Shah
06:33 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
I'm going to put the @SVG@ images into... Eugenie Lyzenko
02:55 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Sergey Ivanovskiy wrote:
> Batik uses asynchronous renderers and alarms the result is ready or not.
This seems t...
Hynek Cihlar
02:51 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Eugenie Lyzenko wrote:
> Another issue to solve in the @SVG@ converter implementation. The converter takes the sourc...
Hynek Cihlar
02:45 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Batik uses asynchronous renderers and alarms the result is ready or not. It has very complicated implementation of dy... Sergey Ivanovskiy
10:35 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Another issue to solve in the @SVG@ converter implementation. The converter takes the source file as name or @URL@ wh... Eugenie Lyzenko
05:25 PM Bug #2681: the titlebar height and outline does not match the 4GL version
By the way, the default window caption font color in the Windows classic theme is not black but white. Hynek Cihlar
04:58 PM Bug #2681: the titlebar height and outline does not match the 4GL version
The titlebar is sized too large in height in our version. The windows classic theme has a different way to draw the ... Greg Shah
04:57 PM Bug #2681 (Closed): the titlebar height and outline does not match the 4GL version
Greg Shah
05:22 PM Bug #2679: window borders should have a 3D appearance
In fact, not only windows are missing the 3D effect. Other controls as well - window caption buttons, scroll bars, bu... Hynek Cihlar
04:48 PM Bug #2679: window borders should have a 3D appearance
At this time we are only going to implement support for the look of the windows classic theme.
Attached is an exam...
Greg Shah
04:43 PM Bug #2679 (Closed): window borders should have a 3D appearance
Greg Shah
04:56 PM Bug #2680: status area border is not drawn correctly
The status area has its own extra thick border with a triangular bottom right corner. Our version has no raised bord... Greg Shah
04:50 PM Bug #2680 (Closed): status area border is not drawn correctly
Greg Shah
04:41 PM Feature #2252: implement GUI client support
It's good. If it passes testing, merge to trunk. Greg Shah
04:40 PM Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review Task Branch 2424c Revision 10957
>
> Please add javadoc to @ScrollableListImpl.scr...
Hynek Cihlar
04:15 PM Feature #2252: implement GUI client support
Code Review Task Branch 2424c Revision 10957
I'm fine with the changes. Please add javadoc to @ScrollableListImpl...
Greg Shah
03:51 PM Feature #2252: implement GUI client support
Please review task branch 2424c, revision 10957.
Hynek Cihlar
02:39 PM Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review Task Branch 2424c Revision 10956
>
> I'm good with the changes, except that @Defau...
Hynek Cihlar
02:36 PM Feature #2252: implement GUI client support
Code Review Task Branch 2424c Revision 10956
I'm good with the changes, except that @DefaultList.getColumns()@ nee...
Greg Shah
02:23 PM Feature #2252: implement GUI client support
Update for 2424c. I have cleaned up all known ChUI regressions and I will be starting a Majic test run. I still have ... Hynek Cihlar
04:39 PM Bug #2678: scrollbar button arrow drawing is not 100% identical
See #2606 notes 33 through 61. We are going to try the SVG approach.
Please implement this same approach for the ...
Greg Shah
04:38 PM Bug #2678 (Closed): scrollbar button arrow drawing is not 100% identical
Greg Shah
04:36 PM Bug #2677 (New): fix drawing and functional differences between P2J GUI and 4GL GUI
Greg Shah
04:34 PM Feature #2676: implement the equivalent to configurable support for a windows theme
See #2606 notes 34 through 53.
For this task, we are only going to add support for the "windows classic" theme. W...
Greg Shah
04:20 PM Feature #2676 (Closed): implement the equivalent to configurable support for a windows theme
Greg Shah
01:07 PM Feature #2564: implement GUI BROWSE widget
Getting these text metrics should not be hard, since we already have a process and some tools for doing it.
To sta...
Greg Shah
12:20 PM Feature #2564: implement GUI BROWSE widget
Guys, browse column width depends on format width. Format width is sum of widths of its characters/placeholders. Char... Stanislav Lomany
12:56 PM Feature #1811: implement the AJAX client driver
> 1) it holds all started application's windows as corresponding icons
Yes. But it should show both the icon and ...
Greg Shah
09:26 AM Feature #1811: implement the AJAX client driver
Agree with you if there are no plans to use folders and launch icons. Greg, please clarify functionalities of the tas... Sergey Ivanovskiy
08:32 AM Feature #1811: implement the AJAX client driver
The project is definitely interesting.
Although the license listed on MDN is GPL, on github the actual license s...
Greg Shah
07:56 AM Feature #1811: implement the AJAX client driver
> Sadly, the last version is still broken on my system.
Your system is fast enough to eliminate the time to start new...
Sergey Ivanovskiy
07:44 AM Feature #1811: implement the AJAX client driver
> The last version of SetIconImageTest seems to fix this bug
Sadly, the last version is still broken on my system.
Greg Shah
07:32 AM Feature #1811: implement the AJAX client driver
> Adding a sleep is not a solution we can use in the production code. For now, stop working on this problem. I'll o... Sergey Ivanovskiy
06:47 AM Feature #1791: implement dynamic UI support
Fixed conversion regression brought by 2026b.
Please review task branch 2026c, revision 10931.
Stanislav Lomany

09/02/2015

05:08 PM Feature #1790: implement menu support
Vadim, rev 10954 contains fixes for MENU-DROP event generation + misc fixes for popup menu. At this time, the menuba... Constantin Asofiei
04:08 PM Feature #1790: implement menu support
Constantin Asofiei wrote:
> About the wait-for: I think is safe to assume that wait-for must not check VISIBLE for a...
Vadim Gindin
03:58 PM Feature #1790: implement menu support
Vadim, this is good, I've integrated it with my changes and it fixed some popup issues I was having. Please don't co... Constantin Asofiei
03:30 PM Feature #1790: implement menu support
# I've moved "clicking" logic from @mouseClicked@ to @mousePressed@ that is more convenient place.
# I've added hidin...
Vadim Gindin
08:38 AM Feature #1790: implement menu support
Another issue: @VK_ENTER@ key is used to trigger an open of a sub-menu (or click of menu-item), when a mouse action w... Constantin Asofiei
08:02 AM Feature #1790: implement menu support
Revision 10952 fixes:
* focus processing when focus is moved from a higher to a lower level in the menu tree. The c...
Constantin Asofiei
04:07 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Sergey: please review this task history from note 30 to the end.
Eugenie/Hynek: Sergey has implemented an image ca...
Greg Shah
04:02 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Eugenie, also try to keep only unique set of converted images. For example when multiple scroll bars are painted we o... Hynek Cihlar
03:35 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
> Let me know if I've missed for something.
Your assumptions seem reasonable. Please make sure the SVG files are ...
Greg Shah
03:20 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
What I can tell from samples is the basic approach we can use:
1. Having @SVG@ files for every image we want to be...
Eugenie Lyzenko
02:56 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
> For Windows 7 I assume you mean the default non-aero Windows 7 Basic theme?
Yes.
For now, we should focus on ...
Greg Shah
02:08 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Eugenie Lyzenko wrote:
> Hynek, the 1.7 batik binary is enough to use this rasterizer in P2J? Do you have any sample...
Hynek Cihlar
01:52 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Hynek, the 1.7 batik binary is enough to use this rasterizer in P2J? Do you have any sample Java code that demonstrat... Eugenie Lyzenko
01:43 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Greg Shah wrote:
> > 4GL reference docs show screenshots from different versions of Windows and their themes, inclu...
Hynek Cihlar
01:01 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
> 4GL reference docs show screenshots from different versions of Windows and their themes, including a theme which l... Greg Shah
12:49 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Greg Shah wrote:
> > As much confident as with the hard-coded approach.
>
> Eugenie: please give the SVG approac...
Hynek Cihlar
12:04 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
> As much confident as with the hard-coded approach.
Eugenie: please give the SVG approach a try. Don't worry ab...
Greg Shah
11:59 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Hynek Cihlar wrote:
> As much confident as with the hard-coded approach. And I am afraid we won't achieve pixel perf...
Eugenie Lyzenko
11:54 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Greg Shah wrote:
> How confident are you that we can match the Windows vectors pixel for pixel using SVG?
As much...
Hynek Cihlar
10:03 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Greg Shah wrote:
> How confident are you that we can match the Windows vectors pixel for pixel using SVG?
I'm par...
Greg Shah
09:57 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
How confident are you that we can match the Windows vectors pixel for pixel using SVG? Greg Shah
09:29 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Greg Shah wrote:
> > My concern is that hard coding the vector images will lock us down to any future improvements (...
Hynek Cihlar
08:46 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
> My concern is that hard coding the vector images will lock us down to any future improvements (new themes for examp... Greg Shah
08:20 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Greg Shah wrote:
> Hynek Cihlar wrote:
> > Greg, there are and likely will be more places where vector based icons/...
Hynek Cihlar
08:19 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Hynek Cihlar wrote:
> Greg, there are and likely will be more places where vector based icons/images will be needed....
Greg Shah
08:16 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > Greg, there are and likely will be more places where vector based ...
Hynek Cihlar
08:13 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Hynek Cihlar wrote:
> Greg, there are and likely will be more places where vector based icons/images will be needed....
Eugenie Lyzenko
08:10 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Greg, there are and likely will be more places where vector based icons/images will be needed. Do you think it would ... Hynek Cihlar
08:04 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
I can see that some customers may need to customize that value (using themes) for accessibility reasons. We are goin... Greg Shah
08:00 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Greg Shah wrote:
> > Adding support for painting the disabled state for GUI scrollbar button. The current implementa...
Hynek Cihlar
07:43 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Eugenie Lyzenko wrote:
> Task branch @2606a@ for review updated to revision @10944@.
>
> Adding support for paint...
Hynek Cihlar
07:34 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
> As far as I know the scroll buttons is a part of the Windows system controls, not the 4GL elements. So the questio... Greg Shah
07:24 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
>But I wonder if it is bitmap based or if it can be scaled to a larger/smaller size. Please test in the 4GL, if there... Eugenie Lyzenko
07:13 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
> Adding support for painting the disabled state for GUI scrollbar button. The current implementation for button draw... Greg Shah
07:10 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
> Do we really need this to be implemented in SELECTION-LIST?
I checked, you're right. We don't need MAX-CHARS.
Greg Shah
09:13 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Testing on 4GL system shows the @MAX-CHARS@ is not queryable/settable attribute for @SELECTION-LIST@ widget. I have u... Eugenie Lyzenko
08:49 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10944@.
Adding support for painting the disabled state for GUI s...
Eugenie Lyzenko
04:02 PM Feature #1811: implement the AJAX client driver
Adding a sleep is not a solution we can use in the production code. For now, stop working on this problem. I'll ope... Greg Shah
03:43 PM Feature #1811: implement the AJAX client driver
May be task bar application window that represents the application icon is updated asynchronously on @setVisible(true... Sergey Ivanovskiy
03:22 PM Feature #1811: implement the AJAX client driver
If the image is found on the path, then you can try to run it several times or set the breakpoint after on @setVisibl... Sergey Ivanovskiy
03:08 PM Feature #1811: implement the AJAX client driver
The test does not work for me. I uncommented the @frame.setVisible(false)@ and tried it, but there is no difference.... Greg Shah
02:19 PM Feature #1811: implement the AJAX client driver
Found that if @frame.setIconImage()@ is called after the @frame@ becomes visible, then the application task bar icon ... Sergey Ivanovskiy
07:21 AM Feature #1811: implement the AJAX client driver
> Planning to fix it because this code works properly
OK, good.
Greg Shah
06:44 AM Feature #1811: implement the AJAX client driver
Greg, setIconImage doesn't change the swing client application icon for my Ubuntu task bar(like desktop),
please look...
Sergey Ivanovskiy

09/01/2015

06:32 PM Feature #1790: implement menu support
Vadim Gindin wrote:
> # fix the bug with unexpected exit when I click a menu-item from MENUBAR with assigned trigger...
Constantin Asofiei
11:01 AM Feature #1790: implement menu support
# fix the bug with unexpected exit when I click a menu-item from MENUBAR with assigned trigger, that dynamically sets... Vadim Gindin
09:53 AM Feature #1790: implement menu support
When you post the list of open issues, please include an estimate of how long it will take to resolve those issues. ... Greg Shah
09:51 AM Feature #1790: implement menu support
I faced with some new bugs after last commits and rebase. So I'm still close but not yet ready. I'll post current lis... Vadim Gindin
08:11 AM Feature #1790: implement menu support
Vadim, I'm good with the changes in rev 10949. If you are close to finish, please:
# rebase from latest revision
#...
Constantin Asofiei
05:45 PM Feature #2564: implement GUI BROWSE widget
Some metrics. I'll update @font_details.odt@ accordingly.
Browse constraints:...
Stanislav Lomany
10:59 AM Feature #2564: implement GUI BROWSE widget
You should expect to use @GuiFontResolver@ and @GuiColorResolver@. Greg Shah
05:08 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10980
The changes are good.
Greg Shah
04:58 PM Feature #1811: implement the AJAX client driver
Greg, please review the committed revision 10980. Sergey Ivanovskiy
04:38 PM Feature #1811: implement the AJAX client driver
Greg, 10979 uses @doLayout@ of @WindowTitleBar@, I would like to change it again to place @setIcon()@ code to @draw()... Sergey Ivanovskiy
04:18 PM Feature #1811: implement the AJAX client driver
> Code Review Task Branch 1811q Revision 10978
>
> I have one concern. It is possible to load a @.ico@ file as an...
Sergey Ivanovskiy
04:02 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10978
I have one concern. It is possible to load a @.ico@ file as an image...
Greg Shah
03:52 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10977
The changes are good.
Greg Shah
03:32 PM Feature #1811: implement the AJAX client driver
h2. Remaining Task List (in priority order)
h3. Task Branch 1811q
# -fix system menu- (CA)
# -pressing maximize but...
Greg Shah
02:39 PM Feature #1811: implement the AJAX client driver
Committed revision 10978. The changes are not good due to setIcon has the drawImage signature. It is because the web ... Sergey Ivanovskiy
11:56 AM Feature #1811: implement the AJAX client driver
1811q rev 10977 contains fixes related to p2j.mouse (window events functions are refactored to use a worker) and a fi... Constantin Asofiei
09:27 AM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10975
The changes look good. The only thing that seems missing would be ch...
Greg Shah
08:50 AM Feature #1811: implement the AJAX client driver
Greg, please review the committed revision 10975. It is the SET_ICON implementation. Sergey Ivanovskiy
07:32 AM Feature #1811: implement the AJAX client driver
> for SET_ICON?
Yes, this seems reasonable. If we have an image ID, we can easily draw the icon from that alone, ...
Greg Shah
07:24 AM Feature #1811: implement the AJAX client driver
Greg, do we need to reuse... Sergey Ivanovskiy
04:25 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> I just committed some merge fixes in rev 10973.
>
> Constantin: would you please check @FontTa...
Constantin Asofiei
04:13 AM Feature #1811: implement the AJAX client driver
> I'm aware of this. The question is: do you plan to set the window state by other means than the window's caption b... Sergey Ivanovskiy
03:59 AM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> Constantin please look at this issue
> >1. Implement the GuiWebEmulatedWindow.setIconifi...
Constantin Asofiei
03:23 AM Feature #1811: implement the AJAX client driver
Constantin please look at this issue
>1. Implement the GuiWebEmulatedWindow.setIconificationState() which will certa...
Sergey Ivanovskiy
03:30 PM Support #2675: list of differences between the web GUI client and the original 4GL Windows GUI en...
Please add to this list whenever you find something that is a permanent restriction.
1. The font rendering will be c...
Greg Shah
03:26 PM Support #2675 (New): list of differences between the web GUI client and the original 4GL Windows ...
Greg Shah
03:25 PM Support #2674: list of HTML5, CSS and Javascript features in use in the web client (both ChUI and...
Here is my first pass. I'm sure it is incomplete.
|_. Feature |_. Firefox |_. Chrome |_. IE |_. Safari |
| HTML5...
Greg Shah
02:41 PM Support #2674 (New): list of HTML5, CSS and Javascript features in use in the web client (both Ch...
Greg Shah
02:38 PM Feature #2673: support a kind of virtual desktop in the GUI web client
The idea here is to make sure that users can interact with the GUI web client in the similar use patterns to how they... Greg Shah
02:28 PM Feature #2673 (WIP): support a kind of virtual desktop in the GUI web client
Greg Shah
02:27 PM Support #2672: GUI web client performance improvements
The following are ideas for performance improvements in the GUI web client.
1. Watching the log of drawing operati...
Greg Shah
02:00 PM Support #2672 (New): GUI web client performance improvements
Greg Shah
12:10 PM Feature #2252: implement GUI client support
Greg Shah wrote:
> 1. One future improvement would be to improve abstraction such that there would not be widget-s...
Hynek Cihlar
11:33 AM Feature #2252: implement GUI client support
Code Review Task Branch 2424c Revision 10954
I like the improvements very much! It certainly is more regular and e...
Greg Shah
09:08 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Code Review Task Branch 2606a Revision 10942
This is very good! I've made some small cleanups to javadoc and chec...
Greg Shah
08:36 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
The current testcases for @selection-list@ widget have been uploaded to bzr repo. Version is @1313@. Eugenie Lyzenko
08:11 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10942@.
This update changes the location of the tooltip featur...
Eugenie Lyzenko

08/31/2015

07:49 PM Feature #2252: implement GUI client support
Please review 2424c revision 10954. Although it is not yet free of issues, it is close to be finished.
The changes pr...
Hynek Cihlar
07:46 PM Feature #1811: implement the AJAX client driver
Committed revision 10974. Sergey Ivanovskiy
06:12 PM Feature #1811: implement the AJAX client driver
I just committed some merge fixes in rev 10973.
Constantin: would you please check @FontTable@ to make sure I didn...
Greg Shah
06:02 PM Feature #1811: implement the AJAX client driver
Rebased task branch 1811q from P2J trunk revision 10930. The latest branch revision is 10972. Greg Shah
05:47 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10963
This is good. Please add a comment to the @draw()@ code where you re...
Greg Shah
05:44 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10962
It is quite good. A couple of thoughts:
1. The @WindowClose@, @Wi...
Greg Shah
05:28 PM Feature #1811: implement the AJAX client driver
gui&webClients.png
!gui&webClients.png!
Sergey Ivanovskiy
05:19 PM Feature #1811: implement the AJAX client driver
Committed revision 10963. It should fix close button differences for web and swing clients. Now the logs for drawing ... Sergey Ivanovskiy
05:10 PM Feature #1811: implement the AJAX client driver
> I have already implemented setGuiRenderingHints but it follows that STOKE_PURE produces incorrect graphics. I think... Greg Shah
04:54 PM Feature #1811: implement the AJAX client driver
Greg, Hynec, please look at these difficulties that comes trying to synchronize the close button with swing client an... Sergey Ivanovskiy
04:47 PM Feature #1811: implement the AJAX client driver
1811q revision 10926 contains support for window iconification/deiconification, maximize and close, plus enableEvents... Constantin Asofiei
03:04 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10961
The changes look good.
Greg Shah
01:45 PM Feature #1811: implement the AJAX client driver
> > But I think that it would be good if we have setRenderingHint implementation for stroke and for antialiasing?
> ...
Sergey Ivanovskiy
01:24 PM Feature #1811: implement the AJAX client driver
> But I think that it would be good if we have setRenderingHint implementation for stroke and for antialiasing?
We...
Greg Shah
01:19 PM Feature #1811: implement the AJAX client driver
!StrokeControl&LineCoveredWithSquares.png! Sergey Ivanovskiy
01:08 PM Feature #1811: implement the AJAX client driver
> > How about a different version of JRE?
>
> This would restrict customers (and ourselves) too much to be accepta...
Sergey Ivanovskiy
12:52 PM Feature #1811: implement the AJAX client driver
> How about a different version of JRE?
This would restrict customers (and ourselves) too much to be acceptable. ...
Greg Shah
12:50 PM Feature #1811: implement the AJAX client driver
> we would like to add setRenderingHints to drawing primitives.
Yes, go ahead.
Sergey: please also note that in...
Greg Shah
12:18 PM Feature #1811: implement the AJAX client driver
Greg, we would like to add setRenderingHints to drawing primitives. Sergey Ivanovskiy
12:13 PM Feature #1811: implement the AJAX client driver
When RenderingHints.KEY_STROKE_CONTROL set to RenderingHints.VALUE_STROKE_PURE, the following produces the expected r... Hynek Cihlar
11:59 AM Feature #1811: implement the AJAX client driver
> Setting @RenderingHints.KEY_STROKE_CONTROL@ to @RenderingHints.VALUE_STROKE_PURE@ does resolve the problem.
I will...
Sergey Ivanovskiy
11:52 AM Feature #1811: implement the AJAX client driver
Setting @RenderingHints.KEY_STROKE_CONTROL@ to @RenderingHints.VALUE_STROKE_PURE@ does resolve the problem. Hynek Cihlar
11:40 AM Feature #1811: implement the AJAX client driver
> Sergey, have you tried changing the KEY_STROKE_CONTROL hint? See http://docs.oracle.com/javase/7/docs/api/java/awt/... Sergey Ivanovskiy
11:28 AM Feature #1811: implement the AJAX client driver
Sergey, have you tried changing the KEY_STROKE_CONTROL hint? See http://docs.oracle.com/javase/7/docs/api/java/awt/Re... Hynek Cihlar
11:24 AM Feature #1811: implement the AJAX client driver
How about a different version of JRE? Hynek Cihlar
11:15 AM Feature #1811: implement the AJAX client driver
> Another idea: we could implement transforms that rotate the \ and horizontally flip (mirror image) the pixels aroun... Sergey Ivanovskiy
11:11 AM Feature #1811: implement the AJAX client driver
Another idea: we could implement transforms that rotate the \ and horizontally flip (mirror image) the pixels around ... Greg Shah
11:03 AM Feature #1811: implement the AJAX client driver
This code draws the cross of 2 pixels width, we have two variants: to implement the custom line widening drawing prim... Sergey Ivanovskiy
10:40 AM Feature #1811: implement the AJAX client driver
> We can use drawString('x' .. if it looks like the cross.
It must be exactly the same to work.
I'm not sure...
Greg Shah
10:30 AM Feature #1811: implement the AJAX client driver
> The reason for vectors was to allow caption size scaling.
Good point, I had forgotten this.
> I think it's a ...
Greg Shah
10:06 AM Feature #1811: implement the AJAX client driver
We can use drawString('x' .. if it looks like the cross. Sergey Ivanovskiy
09:56 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
>
> Why not use images instead of vector drawing?
The reason for vectors was to allow caption ...
Hynek Cihlar
09:48 AM Feature #1811: implement the AJAX client driver
But the stroke color can't be changed for an image. We can draw line like you do it for js? Sergey Ivanovskiy
09:39 AM Feature #1811: implement the AJAX client driver
Greg, please approve I am going to add the cross.png image with the transparent background and then to change Caption... Sergey Ivanovskiy
09:06 AM Feature #1811: implement the AJAX client driver
> if we can't find a way to fix things in the Swing client, I think it's a good idea to move the Caption button draw... Greg Shah
03:41 PM Feature #2671: provide a facility to customize the JVM args and Java command line used by the spa...
It can be very useful (for debugging purposes) to customize the JVM args and/or Java command line used by the spawner... Greg Shah
03:38 PM Feature #2671 (New): provide a facility to customize the JVM args and Java command line used by t...
Greg Shah
03:36 PM Feature #2670: browser resize should re-layout the login page
Once loaded, the current login page does not react to a resize of the browser itself. It should re-layout instead. Greg Shah
03:36 PM Feature #2670 (New): browser resize should re-layout the login page
Greg Shah
03:29 PM Feature #2669: tabbing flow improvements
When first loaded, the username field should have the focus, so that the user can type immediately.
Use of ENTER i...
Greg Shah
03:28 PM Feature #2669 (New): tabbing flow improvements
Greg Shah
03:27 PM Feature #2668: if there are multiple spawn hosts, allow the user to select the host being logged ...
If more than one host is available for spawning AND if the customer has configured the spawning host to be selectable... Greg Shah
03:25 PM Feature #2668 (New): if there are multiple spawn hosts, allow the user to select the host being l...
Greg Shah
03:24 PM Feature #2667: login page title improvements
The current page title implementation is mostly static and is hard coded in the @web_client.html@. This should be cu... Greg Shah
03:13 PM Feature #2667 (New): login page title improvements
Greg Shah
03:07 PM Feature #2666 (New): web client login page improvements
Greg Shah
12:28 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Rebased task branch @2606a@ from P2J trunk revision @10930@, new branch revision is @10941@. Eugenie Lyzenko
12:28 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10940@.
This update completes handling of the @SIZE PHRASE@ op...
Eugenie Lyzenko
10:37 AM Feature #2564: implement GUI BROWSE widget
Hynek is working on major improvements to the scrolling support classes in task branch 2424c. It should be in testin... Greg Shah
10:02 AM Feature #2564: implement GUI BROWSE widget
For editing browse I'll re-use @FillInGuiImpl@ component. Stanislav Lomany
10:00 AM Feature #2564: implement GUI BROWSE widget
Guys, are there any existing components that I can re-use for drawing browse or that can simplify drawing process? I ... Stanislav Lomany

08/30/2015

05:58 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Rebased task branch 2567b from P2J trunk revision 10930 (new branch revision 10931).
Igor Skornyakov
01:34 PM Feature #2252: implement GUI client support
Rebased task branch 2424c from P2J trunk revision 10930 (branch revision 10950). Hynek Cihlar
01:09 PM Feature #2252: implement GUI client support
Rebased task branch 2424c from P2J trunk revision 10929 (branch revision 10949). Hynek Cihlar
01:09 PM Bug #2662: memory leak in the native NCURSES client
Rebased task branch 2662a to trunk rev. 10929; task branch is now 10933.
Merged 2662a/10933 to trunk. 2662a was ar...
Eric Faulhaber

08/29/2015

07:01 PM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> Greg, please review my finding if turn on antialiasing before '/' drawing and turn off af...
Constantin Asofiei
04:10 PM Feature #1811: implement the AJAX client driver
Greg, please review my finding if turn on antialiasing before '/' drawing and turn off after it, then the final / lin... Sergey Ivanovskiy
10:23 AM Feature #1811: implement the AJAX client driver
1811q rev 10961 contains WindowActivated support for the JS (windows can be used in the Web client now). Constantin Asofiei
08:28 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Another TODO work is to verify @SIZE PHRASE@ working and tooltip functionality. Eugenie Lyzenko
11:12 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10939@.
This update fixes the scrollbar positioning. However I...
Eugenie Lyzenko
10:20 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
The new code samples to compare. As we can see the scrollbar does not have the painting for disabled state. But the w... Eugenie Lyzenko

08/28/2015

07:20 PM Feature #2252: implement GUI client support
I needed to add GUI drawing logic to @BorderedPanel@. Instead of mixing ChUI and GUI code in one class I split it in ... Hynek Cihlar
05:07 PM Feature #1811: implement the AJAX client driver
Greg, if we can't find a way to fix things in the Swing client, I think it's a good idea to move the Caption button d... Constantin Asofiei
03:55 PM Feature #1811: implement the AJAX client driver
No, it doesn't help.!strokesJava2DTest.png! The Java2d surprises me. It doesn't use symmetry of x and y. Sergey Ivanovskiy
02:48 PM Feature #1811: implement the AJAX client driver
Is there any performance or functional disadvantage to switching the @g2.drawLine()@ to @g2.getStroke().createStroked... Greg Shah
02:40 PM Feature #1811: implement the AJAX client driver
> I really don't want to duplicate a Java2D bug in JS. Please see if you can determine why the Java2D implementation... Sergey Ivanovskiy
02:27 PM Feature #1811: implement the AJAX client driver
Good idea. I'm going with this:... Greg Shah
02:20 PM Feature #1811: implement the AJAX client driver
Yes, that should do it. I would only prefer the @GuiDriver.draw@ method. Hynek Cihlar
02:04 PM Feature #1811: implement the AJAX client driver
How about changing this:... Greg Shah
01:21 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Task branch 1811q, revision 10959 has a fix for scrollable list overdrawing its boundaries when t...
Hynek Cihlar
12:58 PM Feature #1811: implement the AJAX client driver
Task branch 1811q, revision 10959 has a fix for scrollable list overdrawing its boundaries when the right or bottom i... Greg Shah
11:59 AM Feature #1811: implement the AJAX client driver
> We can simulate this behaviour in js for two nearest parallel lines to be 2-pixel width if its stroke width is also... Greg Shah
11:42 AM Feature #1811: implement the AJAX client driver
> The two @drawLine@ calls for the SW-NE line are there as a workaround for a Swing? 2D rendering bug. I couldn't mak... Sergey Ivanovskiy
11:32 AM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> Greg, please clarify the issue, we draw the cross with two pixels width, if so we can rem...
Hynek Cihlar
11:28 AM Feature #1811: implement the AJAX client driver
Greg, please clarify the issue, we draw the cross with two pixels width, if so we can remove this
// TODO: the SW-N...
Sergey Ivanovskiy
10:52 AM Feature #1811: implement the AJAX client driver
> May be due to odd or even points coordinates two pixels width of two parallels are collapsed in java 2d?
Possibl...
Greg Shah
10:50 AM Feature #1811: implement the AJAX client driver
I will try to fix it base on odd or even coordinates in p2j.strokes.js class WidenPathRenderer. Sergey Ivanovskiy
10:40 AM Feature #1811: implement the AJAX client driver
Also, these logs of swing client are proved it:
PaintPrimitives.TRANSLATE_POP 1; x = -358; y = -4
PaintPrimitives.TR...
Sergey Ivanovskiy
10:35 AM Feature #1811: implement the AJAX client driver
> Sergey: the drawing of the X in the close button is quite different from the Swing version. Would you please diagno... Sergey Ivanovskiy
10:14 AM Feature #1811: implement the AJAX client driver
Sergey: the drawing of the X in the close button is quite different from the Swing version. Would you please diagnose... Greg Shah
10:12 AM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10957
I'm good with the changes.
Greg Shah
10:06 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Constantin: Good work. Please check in your changes.
1811q rev 10958 contains the fix for the f...
Constantin Asofiei
10:01 AM Feature #1811: implement the AJAX client driver
Constantin: Good work. Please check in your changes.
In addition to the unwanted anti-aliasing, it also seems tha...
Greg Shah
09:20 AM Feature #1811: implement the AJAX client driver
Greg, about the fonts.
# bold fonts require their own .ttf file - so I've changed the custom fonts to specify if the...
Constantin Asofiei
04:14 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Rebased task branch @2606a@ from P2J trunk revision @10929@, new branch revision is @10938@. Eugenie Lyzenko
01:11 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10937@.
This improves height scaling. Preparing to rebase.
Eugenie Lyzenko
09:23 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10936@.
This update for review has fix for incorrect widget wi...
Eugenie Lyzenko
02:57 PM Bug #2665 (New): vim only partially works as an interactive child process in the NCURSES client
Greg Shah
02:55 PM Bug #2664 (New): vim doesn't work as an interactive child process in either Swing ChUI or the web...
Greg Shah
01:01 PM Feature #1791 (Closed): implement dynamic UI support
Greg Shah
12:26 PM Feature #1791: implement dynamic UI support
2026b has been committed into the trunk as bzr revision 10929. Stanislav Lomany
01:00 PM Feature #2026 (Closed): conversion support for CREATE_BROWSE
Greg Shah
12:27 PM Feature #2026 (Review): conversion support for CREATE_BROWSE
Stanislav Lomany
12:27 PM Feature #2026 (WIP): conversion support for CREATE_BROWSE
Stanislav Lomany
11:18 AM Feature #1790: implement menu support
I missed a case where @copy@ should have been used instead of @wa.anyActions@ on line 250 please fix it. Constantin Asofiei
11:05 AM Feature #1790: implement menu support
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Remained tasks:
> > > # fix sub-menu closing when clicking in ...
Vadim Gindin
04:10 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> Remained tasks:
> > # fix sub-menu closing when clicking in some free space. I wrote about th...
Constantin Asofiei
02:29 AM Feature #1790: implement menu support
I've committed actual tests. See below.
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Remained tasks:
> >...
Vadim Gindin
08:21 AM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> Guys, you are mentioning "3D" mode for GUI widgets. How is it switched?
Are you thinkin...
Greg Shah
08:20 AM Feature #2564: implement GUI BROWSE widget
The @*-DCOLOR@ and @*-PFCOLOR@ attributes/options are supposed to only be for ChUI, so it makes some sense if they do... Greg Shah
07:46 AM Feature #2564: implement GUI BROWSE widget
Guys, you are mentioning "3D" mode for GUI widgets. How is it switched? Stanislav Lomany
07:41 AM Feature #2564: implement GUI BROWSE widget
Attributes which affect drawing:
*Coloring:*
COLUMN-BGCOLOR attribute Column
COLUMN-FGCOLOR attribute Column
...
Stanislav Lomany

08/27/2015

05:28 PM Feature #1790: implement menu support
Vadim Gindin wrote:
> Remained tasks:
> > # fix sub-menu closing when clicking in some free space. I wrote about th...
Constantin Asofiei
05:26 PM Feature #1790: implement menu support
Remained tasks:
> # fix sub-menu closing when clicking in some free space. I wrote about this problem earlier. See t...
Vadim Gindin
03:52 PM Feature #1790: implement menu support
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Constantin Asofiei wrote:
> > > - please try something like th...
Vadim Gindin
05:37 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > - please try something like this: use a PAUSE statement and pre...
Constantin Asofiei
04:33 AM Feature #1790: implement menu support
Constantin Asofiei wrote:
> - please try something like this: use a PAUSE statement and press ALT (without having a ...
Vadim Gindin
04:22 AM Feature #1790: implement menu support
Greg Shah wrote:
> Based on the stack trace in note 528, by the time you see that the exception has already been pro...
Vadim Gindin
05:02 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Several testing shows the selection-list widget is working properly in case of the dynamically creation. Also the imp... Eugenie Lyzenko
08:56 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10935@.
This update completes the support for @SCROLL-TO-ITEM(...
Eugenie Lyzenko
04:56 PM Feature #1791: implement dynamic UI support
Code Review Task Branch 2026b Revision 10945
The change is good. Merge to trunk if it passes.
Greg Shah
04:47 PM Feature #1791: implement dynamic UI support
There is single minor regression. I've fixed it and committed the fix. Re-running regression testing. Stanislav Lomany
04:11 PM Feature #1791: implement dynamic UI support
Code Review Task Branch 2026b Revision 10944
I'm good with the changes. If they pass testing, please merge to tru...
Greg Shah
07:23 AM Feature #1791: implement dynamic UI support
Stanislav Lomany wrote:
> Constantin, many thanks! To be sure - are you talking about @GenericWIDGET.setVisible@?
A...
Constantin Asofiei
06:58 AM Feature #1791: implement dynamic UI support
Constantin, many thanks! To be sure - are you talking about @GenericWIDGET.setVisible@? Stanislav Lomany
05:16 AM Feature #1791: implement dynamic UI support
Stanislav, I think you are managing the VISIBLE attribute wrong. Even if you set it in the @CREATE BROWSE@, the VISI... Constantin Asofiei
04:32 PM Feature #1811: implement the AJAX client driver
Committed revision 10956 should fix the close button issue (#2) related to FILL_RECT drawing operation. Clean up the ... Sergey Ivanovskiy
03:43 PM Feature #1811: implement the AJAX client driver
Sergey: after your work on the bug number 2 from note 1014, please work on the following.
1. Implement the @GuiWeb...
Greg Shah
03:24 PM Feature #1811: implement the AJAX client driver
Constantin, I'd like you to tackle the following (in this priority order, unless you have reasons that a different or... Greg Shah
03:00 PM Feature #1811: implement the AJAX client driver
Wow, we are very code to having the hello world program pixel-for-pixel identical with the Swing version:
!hello_w...
Greg Shah
02:47 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10955
Good changes.
Greg Shah
01:19 PM Feature #1811: implement the AJAX client driver
And the attachments... Greg Shah
01:18 PM Feature #1811: implement the AJAX client driver
> are we sure we need a hard-coded 96 DPI for the web driver? Because setting it to 72 produces the same drawn string... Greg Shah
09:58 AM Feature #1811: implement the AJAX client driver
Greg, please review the committed revision 10955, added new parameter path to drawLine, but with help of function dra... Sergey Ivanovskiy
08:38 AM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10954
This is really good. Some thoughts:
1. When you add more details ...
Greg Shah
07:43 AM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > > # test/fix window resize in Web
> >
> > What kind of issue...
Hynek Cihlar
07:26 AM Feature #1811: implement the AJAX client driver
Hynek Cihlar wrote:
> > # test/fix window resize in Web
>
> What kind of issue is this?
Window resize in browse/...
Constantin Asofiei
07:01 AM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> Branch 1811q rev 10952 contains second phase of mouse support. Remaining mouse issues:
...
Hynek Cihlar
03:56 AM Feature #1811: implement the AJAX client driver
Greg, please review the committed revision 10954. It is a fix for window caption buttons, and p2j.strokes.js, empty s... Sergey Ivanovskiy

08/26/2015

07:29 PM Feature #1811: implement the AJAX client driver
Okay, I am using the current version, only please note that draw3DRect doesn't draw 3-D outline and if we use this.ct... Sergey Ivanovskiy
06:47 PM Feature #1811: implement the AJAX client driver
Revision 10953 has major fixes for @draw3DRect()@. With this (and prior fixes), the result is now:
!hello_world_w...
Greg Shah
06:16 PM Feature #1811: implement the AJAX client driver
Branch 1811q rev 10952 contains second phase of mouse support. Remaining mouse issues:
# window resize: the cursor i...
Constantin Asofiei
06:03 PM Feature #1811: implement the AJAX client driver
Greg, I think draw3DRect and drawRect are not correct. I will try to fix it. Sergey Ivanovskiy
05:39 PM Feature #1811: implement the AJAX client driver
Greg, please look at these changes, I have tested how to draw the window close button exactly like it is done by our ... Sergey Ivanovskiy
05:02 PM Feature #1811: implement the AJAX client driver
Revisions 10950 and 10951 fix @draw3DRect()@ and @drawRect()@ (fill mode only) respectively. With these changes some... Greg Shah
04:37 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Constantin: do you have a more functional version of mouse support that can be checked in (even i...
Constantin Asofiei
01:14 PM Feature #1811: implement the AJAX client driver
Attached are logs taken with rev 10949. The JS and Java sides of the web client output are basically the same. The S... Greg Shah
12:57 PM Feature #1811: implement the AJAX client driver
Constantin: do you have a more functional version of mouse support that can be checked in (even if it isn't the optim... Greg Shah
12:48 PM Feature #1811: implement the AJAX client driver
The reduction in console usage was enough to solve the current performance issue. I think it is best to get the func... Greg Shah
12:47 PM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> Greg, at first I can take this task 4. There is a dark outline around the min/max/close b...
Greg Shah
12:46 PM Feature #1811: implement the AJAX client driver
Greg, at first I can take this task 4. There is a dark outline around the min/max/close buttons. The min/max buttons ... Sergey Ivanovskiy
12:14 PM Feature #1811: implement the AJAX client driver
To be more concrete let us consider this example
Window.prototype.drawRect = function(ctx, x, y, width, height, color...
Sergey Ivanovskiy
11:47 AM Feature #1811: implement the AJAX client driver
> For now, please don't spend any time on loading extra modules. I think your webworker idea has more promise as a r... Sergey Ivanovskiy
09:21 AM Feature #1811: implement the AJAX client driver
> I think the difference is in the color usage for fill3DRect - it uses draker/lighter colors, when it should not cha... Greg Shah
06:07 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Code Review Task Branch 1811q Revision 10942
>
> The changes are good. Nice catch on the @dra...
Constantin Asofiei
06:01 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Constantin: any thoughts on item 2?
> 2. Fonts are significantly different.
I'm looking into ...
Constantin Asofiei
05:05 PM Feature #1790: implement menu support
Based on the stack trace in note 528, by the time you see that the exception has already been processed. You are bre... Greg Shah
04:37 PM Feature #1790: implement menu support
No ConditionException is raised. I've set a breakpoint after the event processing loop in @ThinClient.waitForEventWor... Vadim Gindin
04:05 PM Feature #1790: implement menu support
Vadim Gindin wrote:
> # fix the bug with unexpected exit when I click a menu-item from MENUBAR with assigned trigger...
Vadim Gindin
02:46 PM Feature #1790: implement menu support
I'm not able to finish all bugs till tomorrow. Here is the actual list.
# check drawing navigation mode (check pop-u...
Vadim Gindin
10:16 AM Feature #1791: implement dynamic UI support
The following testcase is for
(1) - @k@ should have no value
(2) report.txt should be "Employee: 0"...
Stanislav Lomany
08:48 AM Feature #1791: implement dynamic UI support
Stanislav, please specify some of the MAJIC tests which fail for the 3 issues in note 317 and also a 4GL test related... Constantin Asofiei
07:49 AM Feature #1791: implement dynamic UI support
In addition to the "value is displayed while it shouldn't" (1) changes in @makeFrameVisible@ also brought border draw... Stanislav Lomany
05:26 AM Feature #2252: implement GUI client support
I identified a new issue related to size calculation of scroll pane and its child widgets manifesting as frame scroll... Hynek Cihlar
03:35 AM Bug #2662: memory leak in the native NCURSES client
Greg Shah wrote:
> > is defined using @jbyteArray@ instead of @jintArray@ for attrs and colors parameters
>
> Thi...
Constantin Asofiei
08:45 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10934@.
This update contains suspended implementation scrollin...
Eugenie Lyzenko

08/25/2015

06:43 PM Feature #1811: implement the AJAX client driver
I just committed 10946. It has a temporary solution to the console log issue. It is not suitable for production use... Greg Shah
06:40 PM Feature #1811: implement the AJAX client driver
I'm not sure this is a real problem. I only saw it 4 times and that was while I also had an invalid character in @p2... Greg Shah
06:15 PM Feature #1811: implement the AJAX client driver
I see this when the client starts (output to Java stderr):... Greg Shah
04:46 PM Feature #1811: implement the AJAX client driver
> unexpected problems to direct dojo loading custom AMD js modules
Our Dojo is not loading the normal way you migh...
Greg Shah
04:39 PM Feature #1811: implement the AJAX client driver
> the browser console loses messages at the start of application, so we can't check the server log with the client lo... Greg Shah
04:08 PM Feature #1811: implement the AJAX client driver
It can help to evaluate log4javascript.js The diff file misses log4javascript.js, it must be copied to the folder wit... Sergey Ivanovskiy
03:49 PM Feature #1811: implement the AJAX client driver
Greg, I have some arguments to use log4javascript-1.4.13 or to implement own logger. The first one browser console ap... Sergey Ivanovskiy
03:10 PM Feature #1811: implement the AJAX client driver
> what do you think if we will use http://log4javascript.org/docs/index.html logging js library in p2j.js? http://www... Greg Shah
03:05 PM Feature #1811: implement the AJAX client driver
> I have tried to resolve missed web browser console logs. May be it is related to the js UI thread is utilized exte... Greg Shah
03:00 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10945
Good changes.
Greg Shah
02:57 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10944
It looks good.
Greg Shah
02:55 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10943
It looks good.
Greg Shah
02:52 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10942
The changes are good. Nice catch on the @drawPolygon()@ fix.
Did ...
Greg Shah
02:42 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10941
I like the changes.
Greg Shah
02:30 PM Feature #1811: implement the AJAX client driver
Attached is the current output of the GUI web client (left) and the same converted code in the Swing GUI client (righ... Greg Shah
10:46 AM Feature #1811: implement the AJAX client driver
Greg, what do you think if we will use http://log4javascript.org/docs/index.html logging js library in p2j.js? http:/... Sergey Ivanovskiy
03:13 PM Feature #1791: implement dynamic UI support
Code Review Task Branch 2026b Revision 10942
I was hoping for more comments in @makeFrameVisible()@ rather than le...
Greg Shah
01:42 PM Feature #1791: implement dynamic UI support
I don't like the fact that widget state is modified just by pushing definitions. So I think it is time to put into ac... Stanislav Lomany
12:27 PM Feature #1791: implement dynamic UI support
(copy from email) There is the regression. Now I got the sense of the comment in GenericFrame.makeFrameVisible:
<p...
Stanislav Lomany
11:55 AM Bug #2662: memory leak in the native NCURSES client
> is defined using @jbyteArray@ instead of @jintArray@ for attrs and colors parameters
This is definitely wrong. I ...
Greg Shah
11:53 AM Bug #2662: memory leak in the native NCURSES client
I have committed a change (rev 10929) to delete the screen resources when the driver is re-initialized (and also at p... Greg Shah
11:43 AM Bug #2662: memory leak in the native NCURSES client
Created task branch 2662a from trunk revision 10928. Greg Shah
11:30 AM Bug #2662: memory leak in the native NCURSES client
Greg, something else in @terminal.c@ - the @Java_com_goldencode_p2j_ui_client_chui_driver_console_ConsoleHelper_addAr... Constantin Asofiei
11:17 AM Bug #2662: memory leak in the native NCURSES client
I've been digging into the NCURSES API usage.
In @initConsole()@ we call @newterm()@, which allocates a @SCREEN@ d...
Greg Shah
10:54 AM Bug #2662: memory leak in the native NCURSES client
Next test was a long loop which just writes to a file numbers from 1 to 1 million: the RES memory stays constant at ~... Constantin Asofiei
10:44 AM Bug #2662: memory leak in the native NCURSES client
After using @mtrace()@ function, it reports lots of still allocated addresses. Unfortunately I haven't found a way t... Constantin Asofiei
10:22 AM Bug #2662: memory leak in the native NCURSES client
-------- Forwarded Message --------
Subject: Re: re-running full-search tests.
Date: Tue, 25 Aug 2015 08:35:14 -0...
Greg Shah
10:22 AM Bug #2662: memory leak in the native NCURSES client
-------- Forwarded Message --------
Subject: Re: re-running full-search tests.
Date: Tue, 25 Aug 2015 07:53:44 -0...
Greg Shah
10:22 AM Bug #2662: memory leak in the native NCURSES client
-------- Forwarded Message --------
Subject: Re: re-running full-search tests.
Date: Tue, 25 Aug 2015 12:57:55 +030...
Greg Shah
10:20 AM Bug #2662: memory leak in the native NCURSES client
-------- Forwarded Message --------
Subject: Re: memory usage
Date: Thu, 20 Aug 2015 08:46:21 -0400
From: Greg ...
Greg Shah
10:19 AM Bug #2662: memory leak in the native NCURSES client
This link is useful in understanding things:
http://stackoverflow.com/questions/561245/virtual-memory-usage-from-j...
Greg Shah
10:18 AM Bug #2662: memory leak in the native NCURSES client
Initial identification of the problem was from this report by a customer:... Greg Shah
10:16 AM Bug #2662 (Closed): memory leak in the native NCURSES client
Greg Shah
09:08 AM Support #2660: evaluate if the NCURSES 5.7 "threading improvements" can be made to work for P2J s...
NCURSES 5.9 release notes includes:
> This extends support for threaded applications by providing a new API which...
Greg Shah
08:59 AM Support #2660: evaluate if the NCURSES 5.7 "threading improvements" can be made to work for P2J s...
I never heard back from that reply. BUT then they added some dual threading support in 5.7. NCURSES 5.7 came out on... Greg Shah
08:55 AM Support #2660: evaluate if the NCURSES 5.7 "threading improvements" can be made to work for P2J s...
-------- Forwarded Message --------
Subject: Re: proposed extension API addition for ncurses 5.5
Date: Wed, 30 Au...
Greg Shah
08:54 AM Support #2660: evaluate if the NCURSES 5.7 "threading improvements" can be made to work for P2J s...
-------- Forwarded Message --------
Subject: Re: proposed extension API addition for ncurses 5.5
Date: Tue, 29 Au...
Greg Shah
08:53 AM Support #2660: evaluate if the NCURSES 5.7 "threading improvements" can be made to work for P2J s...
-------- Forwarded Message --------
Subject: proposed extension API addition for ncurses 5.5
Date: Tue, 29 Aug 20...
Greg Shah
08:53 AM Support #2660: evaluate if the NCURSES 5.7 "threading improvements" can be made to work for P2J s...
http://invisible-island.net/ncurses/ncurses.faq.html#multithread... Greg Shah
08:50 AM Support #2660 (Test): evaluate if the NCURSES 5.7 "threading improvements" can be made to work fo...
Greg Shah
09:05 AM Support #2661: evaluate use of NCURSES 6.0 on Windows which now has a MinGW port
The key question: does it make sense to use NCURSES instead of the WIN32 console APIs?
This task is meant to explo...
Greg Shah
09:03 AM Support #2661 (New): evaluate use of NCURSES 6.0 on Windows which now has a MinGW port
Greg Shah
07:56 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Greg Shah wrote:
> Do you have things to work on that do not involve scrolling? Hynek's 2424c update which is close...
Eugenie Lyzenko
07:47 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Do you have things to work on that do not involve scrolling? Hynek's 2424c update which is close to finishing testin... Greg Shah
09:53 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10933@.
This adds the generic scrollbar support for GUI select...
Eugenie Lyzenko

08/24/2015

05:37 PM Feature #1791: implement dynamic UI support
Code Review Task Branch 2026b Revision 10941
It looks good. Please get it regression tested (both conversion and ...
Greg Shah
03:26 PM Feature #1791: implement dynamic UI support
> * @query_associations.rules@: please refresh my memory...why were we hiding the DEFINE_QUERY node's children, and ... Stanislav Lomany
11:41 AM Feature #1791: implement dynamic UI support
Code review 2026b/10940:
* @query_associations.rules@: please refresh my memory...why were we hiding the DEFINE_Q...
Eric Faulhaber
09:25 AM Feature #1791: implement dynamic UI support
Code Review Task Branch 2026b Revision 10940
This is really good.
The only thing I see here is that @GenericFra...
Greg Shah
03:45 PM Feature #1790: implement menu support
Here is the list of opened issues:
# menuItem.setSensitive call actuates ThinClient.enable method (fixed, but not co...
Vadim Gindin
10:10 AM Feature #1790: implement menu support
Constantin Asofiei wrote:
> > I wrote earlier, that in it doesn't for my machine. Why it could be?
> Do you use the...
Vadim Gindin
08:26 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> > # @MenuGuiImpl@
> > - is missing history entry
> > - why did you comment out the code in @...
Constantin Asofiei
07:53 AM Feature #1790: implement menu support
Constantin Asofiei wrote:
> Review branch 1790e revision 10941:
> # @expressions.rules@
> - I don't understand the...
Vadim Gindin
05:33 AM Feature #1790: implement menu support
Review branch 1790e revision 10941:
# @expressions.rules@
- I don't understand the @ Added ';' suppression for ACCE...
Constantin Asofiei
02:40 AM Feature #1790: implement menu support
Constantin, thank you for help. I've rebased the branch. Now current revision is 1941. Please review the code. Can I ... Vadim Gindin
03:04 PM Feature #1811: implement the AJAX client driver
Greg, please review the committed revision 10945. I have tried to resolve missed web browser console logs. May be it ... Sergey Ivanovskiy

08/23/2015

06:06 PM Feature #1791: implement dynamic UI support
Rebased task branch 2026b from P2J trunk revision 10928. Stanislav Lomany
05:11 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Rebased task branch @2606a@ from P2J trunk revision @10928@, new branch revision is @10932@. Eugenie Lyzenko
04:51 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10931@.
This adds the mouse support for GUI selection-list is ...
Eugenie Lyzenko
03:40 PM Feature #1790: implement menu support
Vadim Gindin wrote:
> Next bug is the following:
> @MESSAGE MENU-ITEM mi:NEXT-SIBLING.@ is converted to @message(Me...
Constantin Asofiei
02:29 PM Feature #1790: implement menu support
Next bug is the following:
@MESSAGE MENU-ITEM mi:NEXT-SIBLING.@ is converted to @message(MenuItemWidget.findMenuItem...
Vadim Gindin
09:52 AM Feature #1790: implement menu support
Constantin, mnemonics do not work for me.. Vadim Gindin
08:34 AM Feature #1790: implement menu support
Constantin Asofiei wrote:
> Also, in GUI, why is this code in @Window.afterConfigUpdate@:
> [...]
> This will keep...
Vadim Gindin

08/22/2015

04:14 PM Feature #1811: implement the AJAX client driver
> ... Maybe there is some problem in reading the binary int32/int16.
Constantin, our functions to read and write int...
Sergey Ivanovskiy
03:55 PM Feature #1811: implement the AJAX client driver
Committed revision 10944. Fixed by sending non-premultiplied images pixels and calculating the middle value from an i... Sergey Ivanovskiy
08:32 AM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> Greg Shah wrote:
> > ... and the drawing of the window border.
> I don't think the win...
Constantin Asofiei
08:08 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> ... and the drawing of the window border.
I don't think the window border is being drawn explici...
Constantin Asofiei
07:57 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> I can't find any issues with the @draw3DRect()@ or @drawPolygon()@. The implementation works as ...
Constantin Asofiei
07:41 AM Feature #1791: implement dynamic UI support
Please review task branch 2026b revision 10939. Stanislav Lomany
03:35 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> Constantin, could you have a look at my CHUI implementation. I faced with the following bug: w...
Constantin Asofiei
03:19 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > Please take the changes from branch 1794c rev 10927 - I will me...
Constantin Asofiei

08/21/2015

07:24 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10930@.
This update adds support for multiple selection mode i...
Eugenie Lyzenko
09:07 PM Feature #2606: implement GUI runtime support for SELECTION-LIST
Task branch @2606a@ for review updated to revision @10929@.
This is very base selection-list implementation for si...
Eugenie Lyzenko
04:22 PM Feature #1811: implement the AJAX client driver
> 1. Initialize the image drawing buffer using @getImageData()@ to ensure that the original canvas contents are alrea... Sergey Ivanovskiy
04:03 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Hmm, looking at the console there are no errors. But the clipping coordinates are not always the...
Constantin Asofiei
04:01 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> I was a bit surprised that you integrated the mechanism with the drawing ops. It seems to me that...
Constantin Asofiei
03:41 PM Feature #1811: implement the AJAX client driver
Hmm, looking at the console there are no errors. But the clipping coordinates are not always the same as the ones lo... Greg Shah
03:22 PM Feature #1811: implement the AJAX client driver
I can't find any issues with the @draw3DRect()@ or @drawPolygon()@. The implementation works as expected in all the ... Greg Shah
02:01 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10940
This is a really good update. I'll be interested to see how the widge...
Greg Shah
01:06 PM Feature #1811: implement the AJAX client driver
I see something interesting in my debugging. I set a breakpoint in @draw3DRect()@ and ran the client. The first tim... Greg Shah
01:01 PM Feature #1811: implement the AJAX client driver
Greg, rev 10940 contains first pass at mouse support. Currently, the entire window area is registered for all mouse ... Constantin Asofiei
12:09 PM Feature #1811: implement the AJAX client driver
> There still exists another problem that was unseen before how to do the image background consistent with the curren... Greg Shah
11:53 AM Feature #1811: implement the AJAX client driver
Greg, please review the image resize fix committed revision 10939. There still exists another problem that was unseen... Sergey Ivanovskiy
10:24 AM Feature #1811: implement the AJAX client driver
The canvas line stroking state will definitely affect @drawRoundRect()@, because the corners are only rendered via th... Greg Shah
09:10 AM Feature #1811: implement the AJAX client driver
> Now we have additional properties strokeStyle and strokeWidth, is it true that lineWidth and strokeWidth should hav... Greg Shah
09:08 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Constantin: Do you think the keyboard improvements should be done before the mouse support? I'll...
Constantin Asofiei
09:01 AM Feature #1811: implement the AJAX client driver
Greg, I am doing 3 and 4. From my previous task there are the following unresolved issues. Now we have additional pro... Sergey Ivanovskiy
08:31 AM Feature #1811: implement the AJAX client driver
It looks to me like we have the following drawing problems:
1. The draw 3D rectangle is badly broken.
2. The fill...
Greg Shah
08:28 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> I never get the press ESC to exit the application when I run our Swing client or the web GUI. Is...
Constantin Asofiei
08:25 AM Feature #1811: implement the AJAX client driver
> Have you managed to press ESC key to terminate the app?
I think the current keyboard code is ChUI-specific. In ...
Greg Shah
08:15 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> By the way, the key processing works. Pressing space, cleanly exits the app.
Have you managed to...
Constantin Asofiei
08:14 AM Feature #1811: implement the AJAX client driver
With those changes (see rev 10938), we get this:
!better_drawing_polygons.png!
The polygon outline overdrawing ...
Greg Shah
08:11 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> I think the fill portion of the @drawPolygon()@ should not have any origin translation applied. ...
Constantin Asofiei
08:05 AM Feature #1811: implement the AJAX client driver
@drawRoundRect()@ has the same issue I think. It doesn't need the origin translation applied. Greg Shah
08:03 AM Feature #1811: implement the AJAX client driver
I think the fill portion of the @drawPolygon()@ should not have any origin translation applied. The reason is that t... Greg Shah
07:59 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Constantin: please check in your @p2j.screen.js@ changes.
Committed to 1811q rev 10937.
Constantin Asofiei
07:51 AM Feature #1811: implement the AJAX client driver
Sergey: you get "extra points" for being creative in using the built-in canvas APIs to figure out the current transla... Greg Shah
06:40 AM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> And the modified p2j.screen.js used to get the drawing in note 938.
To resume the chang...
Constantin Asofiei
06:25 AM Feature #1811: implement the AJAX client driver
Constantin, agree with you
> Explicitly maintaining the window translated origin provides better results.
Sergey Ivanovskiy
06:17 AM Feature #1811: implement the AJAX client driver
And the modified p2j.screen.js used to get the drawing in note 938. Constantin Asofiei
06:16 AM Feature #1811: implement the AJAX client driver
Explicitly maintaining the window translated origin provides better results.
!better_drawing.png!
Constantin Asofiei
06:11 AM Feature #1811: implement the AJAX client driver
I found the way to determine translation coordinates
ctx.beginPath();
ctx.rect(0, 0, 1, 1);...
Sergey Ivanovskiy
05:35 AM Feature #1811: implement the AJAX client driver
CanvasRenderingContext2D.currentTransform isn't supported by firefox, only chrome (https://developer.mozilla.org/en-U... Sergey Ivanovskiy
05:12 AM Feature #1811: implement the AJAX client driver
Constantin, you are right translate operations don't influence putImage results.
https://developer.mozilla.org/en-US...
Sergey Ivanovskiy
04:24 AM Feature #1811: implement the AJAX client driver
Sergey/Greg: I think the drawing corruption is related to the fact that when drawing pixels, this is not aware of the... Constantin Asofiei
04:10 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> The drawing is not 100% correct yet. Also there is some kind of problem interpreting the drawing...
Constantin Asofiei
04:05 PM Feature #1790: implement menu support
Constantin Asofiei wrote:
> Please take the changes from branch 1794c rev 10927 - I will merge it to trunk later tod...
Vadim Gindin
12:54 PM Feature #1790: implement menu support
Constantin, could you have a look at my CHUI implementation. I faced with the following bug: when sub-menu is hiding ... Vadim Gindin
03:48 PM Feature #1791: implement dynamic UI support
Stanislav, go ahead and disable the pushScreenLock/Unlock completely - comment out the code in @embedded_attribute_as... Constantin Asofiei
02:13 PM Feature #1791: implement dynamic UI support
Rebased task branch 2026a from P2J trunk revision 10927. Stanislav Lomany
01:39 PM Feature #1791: implement dynamic UI support
@realized@ is set on the client side. Well, I can check @locked && visible && !realized@ on the server side, but woul... Stanislav Lomany
07:56 AM Feature #1791: implement dynamic UI support
Stanislav Lomany wrote:
> @func()@ is just a way to show that assignments are executed one by one. The differences I...
Constantin Asofiei
05:58 AM Feature #1791: implement dynamic UI support
@func()@ is just a way to show that assignments are executed one by one. The differences I'm taking about is that aft... Stanislav Lomany
05:52 AM Feature #1791: implement dynamic UI support
Stanislav Lomany wrote:
> Unfortunately I think this optimization is incorrect. I will turn it off for browse becaus...
Constantin Asofiei
05:16 AM Feature #1791: implement dynamic UI support
Unfortunately I think this optimization is incorrect. I will turn it off for browse because of the behavior differenc... Stanislav Lomany
02:40 AM Feature #1791: implement dynamic UI support
Stanislav Lomany wrote:
> I mean the following:
> 1. A testcase that includes @pushScreenLock@ after conversion (i....
Constantin Asofiei
03:24 PM Feature #2252: implement GUI client support
Rebased task branch 2424c from P2J trunk revision 10927 (branch revision 10943). Hynek Cihlar

08/20/2015

05:33 PM Feature #1791: implement dynamic UI support
I mean the following:
1. A testcase that includes @pushScreenLock@ after conversion (i.e. testcase should have CREAT...
Stanislav Lomany
05:26 PM Feature #1791: implement dynamic UI support
Stanislav Lomany wrote:
> Constantin, can you provide a testcase that fails without @pushScreenLock/Unlock@?...
Constantin Asofiei
05:23 PM Feature #1791: implement dynamic UI support
Constantin, can you provide a testcase that fails without @pushScreenLock/Unlock@? Stanislav Lomany
04:59 PM Feature #1791: implement dynamic UI support
Greg/Stanislav: the usage of the @GenericWidget.frame@ field (throughout the server-side widget sub-classes) should b... Constantin Asofiei
04:40 PM Feature #1791: implement dynamic UI support
Stanislav Lomany wrote:
> Guys, I want to have a conversation about @pushScreenLock/pushScreenUnlock@. AFAIK what it...
Constantin Asofiei
04:34 PM Feature #1791: implement dynamic UI support
Stanislav Lomany wrote:
> > > There is no need to do it explicitly, it is done automatically in @pushScreenDefinitio...
Hynek Cihlar
04:21 PM Feature #1791: implement dynamic UI support
> > There is no need to do it explicitly, it is done automatically in @pushScreenDefinitions@ trip.
>
> Interestin...
Stanislav Lomany
04:04 PM Feature #1791: implement dynamic UI support
Guys, I want to have a conversation about @pushScreenLock/pushScreenUnlock@. AFAIK what it does is deferring @pushScr... Stanislav Lomany
03:30 PM Feature #1791: implement dynamic UI support
Stanislav Lomany wrote:
> > For the case when it is set on the client a similar logic must execute on the server.
>...
Hynek Cihlar
03:12 PM Feature #1791: implement dynamic UI support
> For the case when it is set on the client a similar logic must execute on the server.
There is no need to do it ...
Stanislav Lomany
02:56 PM Feature #1791: implement dynamic UI support
Indeed, the management of @realized@ flag is a bit messy.
Stanislav, your solution seems to be ok when @visible@ ...
Hynek Cihlar
02:32 PM Feature #1791: implement dynamic UI support
I don't know the answer to the question in note 287. It seems OK to me.
Constantin/Hynek: what do you think?
Greg Shah
05:22 PM Feature #1811: implement the AJAX client driver
I've just checked in revision 10935 which has many, many fixes. Some of the problems were caused by unqualified refer... Greg Shah
01:15 PM Feature #1811: implement the AJAX client driver
Greg, I fixed 1 and 2 in the committed revision 10934. Let me look at 3 and 4 due to we have no working example. To e... Sergey Ivanovskiy
11:11 AM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10932
This is really good. Note that I did check in some minor formatting ...
Greg Shah
10:45 AM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 10931
It looks good. The only thing to change is that @ChuiWebDriver.waitI...
Greg Shah
10:42 AM Feature #1811: implement the AJAX client driver
Greg, please review the committed revision 10932. Sergey Ivanovskiy
10:10 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> > to fix the page-loading race issue I've added a new message type MSG_PAGE_LOADED = 0xFF
>
>...
Constantin Asofiei
09:15 AM Feature #1811: implement the AJAX client driver
> to fix the page-loading race issue I've added a new message type MSG_PAGE_LOADED = 0xFF
Nice work! This sounds...
Greg Shah
08:54 AM Feature #1811: implement the AJAX client driver
Greg, to fix the page-loading race issue I've added a new message type @MSG_PAGE_LOADED = 0xFF@:
# @p2j.js@ will cal...
Constantin Asofiei
06:39 AM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> > Function @drawPixel@ I think has more issues; even if I set @this.pixData@, it still do...
Constantin Asofiei
06:35 AM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> But it still bugs me that sometimes the initial createFont call never gets executed: is...
Constantin Asofiei
06:29 AM Feature #1811: implement the AJAX client driver
> Function @drawPixel@ I think has more issues; even if I set @this.pixData@, it still doesn't work, because @pixData... Sergey Ivanovskiy
06:15 AM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> It is due to ctx must be changed to this.ctx and pixData to this.pixData. The draw method...
Constantin Asofiei
04:56 AM Feature #1811: implement the AJAX client driver
It is due to ctx must be changed to this.ctx and pixData to this.pixData. The draw method of Window class have many s... Sergey Ivanovskiy
04:48 AM Feature #1811: implement the AJAX client driver
Sergey, I get these JS errors in the console:... Constantin Asofiei
04:37 AM Feature #1811: implement the AJAX client driver
Greg, I've committed to rev 10929 some more fixes related to font creation/initialization. This time the web client ... Constantin Asofiei
11:12 AM Feature #2606: implement GUI runtime support for SELECTION-LIST
Rebased task branch @2606a@ from P2J trunk revision @10927@, new branch revision is @10928@. Eugenie Lyzenko
05:29 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Created task branch 2567b Igor Skornyakov
05:09 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Merged to trunk rev. 10927 Igor Skornyakov
04:42 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
I assume the conversion testing has passed? If so, you can merge branch 2567a and also commit the baseline changes - ... Constantin Asofiei
04:32 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Rebased task branch 2567a from P2J trunk revision 10926 (new branch revision 10960). Igor Skornyakov
04:19 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> All regression tests except @tc_job_002@ passed (not all in one run, but the intersection o...
Constantin Asofiei
04:18 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
All regression tests except @tc_job_002@ passed (not all in one run, but the intersection of sets of failed tests in ... Igor Skornyakov
 

Also available in: Atom