Project

General

Profile

Activity

From 01/23/2016 to 02/21/2016

02/20/2016

02:26 PM Bug #2914: Fix errors in window_sizing/test_runner.p
There is a technical limit of the max window size in Swing GUI driver. The screen buffer implemented by @BufferedImag... Hynek Cihlar
07:13 PM Bug #2914: Fix errors in window_sizing/test_runner.p
Thanks for the inputs. I have reverted my changes except of the fix of Case 1 and applied Constantin's changes. The r... Hynek Cihlar
01:18 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
Greg, please review the committed revision 11027. Sergey Ivanovskiy
04:52 AM Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> I'm trying to fix the following bug:
> When I open popup menu in EDITOR in a standard WINDOW ...
Hynek Cihlar
08:53 PM Bug #2849: implement and/or fix the default popup menus for all widgets
>Eugenie, does it ring a bell?
?
>If I remember correctly you were solving some mouse-click offset issues when impl...
Eugenie Lyzenko
07:32 PM Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> I'm trying to fix the following bug:
> When I open popup menu in EDITOR in a standard WINDOW ...
Hynek Cihlar

02/19/2016

04:57 PM Bug #2914: Fix errors in window_sizing/test_runner.p
For the third case, the @chp_wrapper=decimal@ annotation is emitted at the COLON node:... Constantin Asofiei
04:48 PM Bug #2914: Fix errors in window_sizing/test_runner.p
From previous note, changing the code to:... Constantin Asofiei
04:37 PM Bug #2914: Fix errors in window_sizing/test_runner.p
Hynek, the first case looks like an incorrect wrapping; the AST for the right-side value has a @no_wrap=true@ annotat... Constantin Asofiei
01:36 PM Bug #2914: Fix errors in window_sizing/test_runner.p
Code Review Task Branch 2914a Revision 10974
The @literals.rules@ change is fine.
The @functions_procedures.rul...
Greg Shah
09:12 AM Bug #2914: Fix errors in window_sizing/test_runner.p
I have found three conversion errors related to type conversion.
Case 1:...
Hynek Cihlar
07:37 AM Bug #2914: Fix errors in window_sizing/test_runner.p
Rebased task branch 2914a against trunk revision 10972. 2914a is now at revision 10974. Hynek Cihlar
04:14 PM Bug #2997: Add support for pre-defined cursor types which do not have direct counterparts in AWT/JS
Please find image captures of Progress pre-defined cursors which do not have AWT counterparts attached. Igor Skornyakov
03:57 PM Bug #2997: Add support for pre-defined cursor types which do not have direct counterparts in AWT/JS
Greg Shah wrote:
> http://www.trickyways.com/2014/03/capture-mouse-cursor-screenshot-windows/
> http://windows.micr...
Igor Skornyakov
03:54 PM Bug #2997: Add support for pre-defined cursor types which do not have direct counterparts in AWT/JS
http://www.trickyways.com/2014/03/capture-mouse-cursor-screenshot-windows/
http://windows.microsoft.com/en-us/window...
Greg Shah
03:48 PM Bug #2997: Add support for pre-defined cursor types which do not have direct counterparts in AWT/JS
Greg Shah wrote:
> Please post image captures of the "no counterpart" cursors. These will be for reference purposes...
Igor Skornyakov
07:51 AM Bug #2997: Add support for pre-defined cursor types which do not have direct counterparts in AWT/JS
To be clear, when we create these images, we must do so "from scratch". We cannot just make a copy of the bits used ... Greg Shah
07:51 AM Bug #2997: Add support for pre-defined cursor types which do not have direct counterparts in AWT/JS
Please post image captures of the "no counterpart" cursors. These will be for reference purposes only, we will not c... Greg Shah
03:54 AM Bug #2997: Add support for pre-defined cursor types which do not have direct counterparts in AWT/JS
At this moment there are a few mouse cursors which are standard for Progress but do not have direct counterparts in A... Igor Skornyakov
03:51 AM Bug #2997 (New): Add support for pre-defined cursor types which do not have direct counterparts i...
Igor Skornyakov
03:29 PM Bug #2849: implement and/or fix the default popup menus for all widgets
I'm trying to fix the following bug:
When I open popup menu in EDITOR in a standard WINDOW it is shown at the point ...
Vadim Gindin
05:08 AM Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > ..
> > Yes we attempt not to put driver-specific code into common code,...
Hynek Cihlar
04:39 AM Bug #2849: implement and/or fix the default popup menus for all widgets
Hynek Cihlar wrote:
> ..
> Yes we attempt not to put driver-specific code into common code, but there are exception...
Vadim Gindin
01:10 PM Support #2672: GUI web client performance improvements
Constantin Asofiei wrote:
> 2. fixed AbstractWidget.clipRectangle (the bottom/right coordinates were computed incorr...
Constantin Asofiei
01:09 PM Support #2672: GUI web client performance improvements
1811t rev 11026 fixes:
# the window icon - we must not cache image widgets, as they are not rectangular and can be t...
Constantin Asofiei
10:55 AM Support #2672: GUI web client performance improvements
Sergey Ivanovskiy wrote:
> Ok, we can create a task to fix artifacts that appear in the case of popup-menu with the ...
Constantin Asofiei
10:54 AM Support #2672: GUI web client performance improvements
Ok, we can create a task to fix artifacts that appear in the case of popup-menu with the most simple 4GL test case pr... Sergey Ivanovskiy
10:40 AM Support #2672: GUI web client performance improvements
Sergey, I've seen this only in a scenario for test 454 and also when the window popup-menu is shown then cleared (any... Constantin Asofiei
10:07 AM Support #2672: GUI web client performance improvements
Another argument can be if we test our system against @hello.p@, then are these artifacts present? Sergey Ivanovskiy
09:57 AM Support #2672: GUI web client performance improvements
In Chrome I found this issue if we get @var image = ctx.getImageData(0.5,0.5, 10, 1)@, then the returned image dimens... Sergey Ivanovskiy
09:51 AM Support #2672: GUI web client performance improvements
If you removed the @translate(0.5, 0.5)@ call, then some artifacts disappeared, didn't they? Now I have no ideas beca... Sergey Ivanovskiy
09:43 AM Support #2672: GUI web client performance improvements
I increased the sizes of regions to watch the picture and the second red squared rectangle is antialiased. It has smo... Sergey Ivanovskiy
09:29 AM Support #2672: GUI web client performance improvements
Constantin, please could you explain it more thoroughly.
The first script should intersect this rectangle(0, 0, 8, 8...
Sergey Ivanovskiy
08:58 AM Support #2672: GUI web client performance improvements
Constantin Asofiei wrote:
> 3. an existing issue in trunk: in Web client for test 454, after navigating through the ...
Constantin Asofiei
08:13 AM Support #2672: GUI web client performance improvements
About the editing and showing data on the editor/fill-in:
# for editor, let the driver parse the text and split it i...
Constantin Asofiei
12:52 AM Support #2672: GUI web client performance improvements
> Greg Shah wrote:
> > It got me thinking. When the user is editing text in a fill-in or editor (or a browse cell/s...
Sergey Ivanovskiy
12:54 PM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
> 1) Disconnect/reconnect usecase
> Greg, please could you explain disconnect/reconnect? Does it mean the main conne...
Greg Shah
12:37 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
@MouseEvent.MOUSE_MOVED@ is restored in @ScrollPaneGuiImpl.mouseActions@.
Committed to the task branch 2565a revno...
Igor Skornyakov
11:12 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Constantin Asofiei wrote:
> About 2565a rev 11035:
> # @ClientExports.setMousePointer@ - the javadoc is missing the...
Igor Skornyakov
09:59 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
More fixes according to the code review part 2:
>20. Why did you make the EditorGuiImpl.setEnabled() and FillInGui...
Igor Skornyakov
09:55 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Eugenie Lyzenko wrote:
> I think adding the informative comments will significantly help to review such code, just t...
Igor Skornyakov
09:51 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
>I'm sorry that you find the new version of the code less readable but you understand that this is mostly a matter of... Eugenie Lyzenko
07:14 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
About 2565a rev 11035:
# @ClientExports.setMousePointer@ - the javadoc is missing the parameter name for @ptr@.
# @...
Constantin Asofiei
06:47 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
More fixes according to the code review part 2:
>11. UiUtils.lookup4GLWidgetId() could have been done with less code....
Igor Skornyakov
06:08 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Constantin Asofiei wrote:
> Igor, in rev 11035 ThinClient.trigger returns if wait-state is on. But this code in 4GL...
Igor Skornyakov
05:55 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Constantin Asofiei wrote:
> Igor, in rev 11035 ThinClient.trigger returns if wait-state is on. But this code in 4GL...
Igor Skornyakov
05:50 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Igor, in rev 11035 ThinClient.trigger returns if wait-state is on. But this code in 4GL proves that triggers are exe... Constantin Asofiei
03:45 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Eugenie Lyzenko wrote:
> >Eugenie: Please review the FileSytemDaemon changes in 2565a.
>
> Well, the code was sig...
Igor Skornyakov
07:24 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
>Eugenie: Please review the FileSytemDaemon changes in 2565a.
Well, the code was significantly rewritten from the ...
Eugenie Lyzenko
11:55 AM Feature #3000: implement the SLIDER widget in ChUI
The GUI slider already is complete. This task is to add the proper ChUI support using as much common code as possible. Greg Shah
11:55 AM Feature #3000 (New): implement the SLIDER widget in ChUI
Greg Shah
11:54 AM Bug #2787: implement mnemonics/accelerator key support for button
> # How is the alert-box relates to mnemonics?
Did you read #2775-8 as mentioned above?
It has this comment:
...
Greg Shah
11:47 AM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
I'm OK with this proposed approach. Make sure you write your own from-scratch version of the faster timeouts approach. Greg Shah

02/18/2016

05:54 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> Code Review Task Branch 2565a Revision 11031
>
> This is part 2 of the code review.
> 42. You...
Igor Skornyakov
05:09 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Fixed the following issues from the code review part 2: 17-19, 47, 53.
Committed to the task branch 2565a revno 11...
Igor Skornyakov
04:08 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
> Regarding 47: There is no 'implements' keyword in the MouseHoverAction.
I should have written @extends@.
Greg Shah
04:04 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> As I noted in items 17 and 18 of my code review, we are going to use @window.btoa()@ for our enco...
Igor Skornyakov
04:04 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Sergey Ivanovskiy wrote:
> I don't know, but the reason can be found if we answer this question what css engine can ...
Igor Skornyakov
04:03 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
As I noted in items 17 and 18 of my code review, we are going to use @window.btoa()@ for our encoding. Please remove ... Greg Shah
04:01 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
I don't know, but the reason can be found if we answer this question what css engine can do with @this.canvas.style.c... Sergey Ivanovskiy
03:51 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Sergey Ivanovskiy wrote:
> Igor, please could you consider the second method due to the optimization. I am worried a...
Igor Skornyakov
03:46 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Igor, please could you consider the second method due to the optimization. I am worried about the large string that w... Sergey Ivanovskiy
03:43 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Fixed the following issues from the code review part 2: 1-7, 10, 12-16, 21-35, 37, 39-41, 45,46, 48-52, 54, 55.
Rega...
Igor Skornyakov
03:40 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Let us consider two methods to set a custom cursor:
1) The first we use now...
Sergey Ivanovskiy
03:13 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
It is okay, I only want to select the best, it should be your solution. Sergey Ivanovskiy
03:12 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Sergey Ivanovskiy wrote:
> If we consider @p2j.socket.js@, then we can find two methods to transform to base64 encod...
Igor Skornyakov
03:06 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
If we consider @p2j.socket.js@, then we can find two methods to transform to base64 encoding. The first method is imp... Sergey Ivanovskiy
02:51 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Sergey Ivanovskiy wrote:
> Igor, there are lot of changes, do you know that in the current 2565a the following funct...
Igor Skornyakov
02:43 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Igor, there are lot of changes, do you know that in the current 2565a the following function @Window.prototype.isPare... Sergey Ivanovskiy
02:21 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
> But in fact @GenericWidget.loadLousePointer@ does exactly what you describe (and no more).
You are processing on...
Greg Shah
02:10 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
> I've added the block of triggers as @SET-WAIT-STATE@ causes deactivation of the active drop-down. I had a trigger o... Greg Shah
12:50 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Sergey: Please review the web client changes in 2565a.
Constantin: Please review the mouse processing changes in 2...
Greg Shah
12:49 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Code Review Task Branch 2565a Revision 11031
This is part 2 of the code review.
1. You have put GUI-specific co...
Greg Shah
11:49 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> Code Review Task Branch 2565a Revision 11026
> 8. I am still finding a significant number of cod...
Igor Skornyakov
10:48 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> 1. The cursor loading and processing should be as hidden as is possible on the client side. Yet ...
Igor Skornyakov
10:35 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
I've added the block of triggers as @SET-WAIT-STATE@ causes deactivation of the active drop-down. I had a trigger on ... Igor Skornyakov
10:23 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> >> 4. Please explain the logic behind duplicating the mousePointer member in so many of the *Conf...
Igor Skornyakov
10:13 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
>> 4. Please explain the logic behind duplicating the mousePointer member in so many of the *Config classes (and thus... Greg Shah
10:08 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
You're right that some changes have been made. But I am concerned about the core approach. There are comments that ... Greg Shah
10:03 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Committed to the task branch 2565a revno 11031 Igor Skornyakov
10:00 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> Code Review Task Branch 2565a Revision 11026
> 4. Please explain the logic behind duplicating th...
Igor Skornyakov
09:01 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> 1. Most issues in note 121 (a code review) above have not been resolved. Items 1, 2 and 5 all ...
Igor Skornyakov
08:25 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Thank you Greg,
I'm working on your comments right now.
Igor Skornyakov
07:41 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Code Review Task Branch 2565a Revision 11026
This is part 1 of my code review. I want you to fix these things ver...
Greg Shah
06:41 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Re-tested after rebase. Added custom mouse pointer support for the @SLIDER@ widget.
Committed to the task branch 2...
Igor Skornyakov
05:37 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Rebased task branch 2565a from P2J trunk rev 10972. The latest revision is now 11028. Igor Skornyakov
12:28 PM Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> Does anybody know why in common class @TopLevelWindow@ the following GUI-specific statement is...
Hynek Cihlar
12:18 PM Bug #2849: implement and/or fix the default popup menus for all widgets
Does anybody know why in common class @TopLevelWindow@ the following GUI-specific statement is used: @GuiDriver gd = ... Vadim Gindin
06:25 AM Support #2672: GUI web client performance improvements
It should improve drawings of lines(horizontal and vertical) having 1 pixel width and lines having 2 or more pixels w... Sergey Ivanovskiy
11:56 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Branch @2612b@ was merged to trunk as revno @10972@ then it was archived. Eugenie Lyzenko
11:46 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
The results are in @2612b_10987_2791e7a_20160217_evl.zip@. Eugenie Lyzenko
11:42 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Greg Shah wrote:
> If CTRL-C testing passes, please go ahead and merge 2612b to trunk.
OK. The testing completed,...
Eugenie Lyzenko
10:36 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
If CTRL-C testing passes, please go ahead and merge 2612b to trunk. Greg Shah
10:21 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
The main part completed without regressions. Running @CTRL-C@ one. Eugenie Lyzenko

02/17/2016

05:44 PM Support #2672: GUI web client performance improvements
Very cool results! Great job!
I've taken a quick look. Please add the comments I requested in note 30. Then I w...
Greg Shah
04:43 PM Support #2672: GUI web client performance improvements
Sergey Ivanovskiy wrote:
> Greg, let me try with the 11021 design taking into account the tests result about the pix...
Sergey Ivanovskiy
04:11 PM Support #2672: GUI web client performance improvements
Greg, let me try with the 11021 design taking into account the tests result about the pixels operations. Sergey Ivanovskiy
04:03 PM Support #2672: GUI web client performance improvements
Greg, I change some method and gives improvement
look at this instead of get we can use create in some cases for Wid...
Sergey Ivanovskiy
03:49 PM Support #2672: GUI web client performance improvements
Committed revision 11023 removes 11020 and 11021 changes. Sergey Ivanovskiy
03:31 PM Support #2672: GUI web client performance improvements
> Greg, Do you agree if I will roll back 11021 changes according to this test?
Yes, roll it back. Even for the @...
Greg Shah
02:51 PM Support #2672: GUI web client performance improvements
Greg, Do you agree if I will roll back 11021 changes according to this test? Sergey Ivanovskiy
02:48 PM Support #2672: GUI web client performance improvements
I did this simple test to draw 160 vertical lines of 400 pixel width
for @DefaultPathRenderer@ with the default st...
Sergey Ivanovskiy
01:34 PM Support #2672: GUI web client performance improvements
>> I am planing to check it with script test and will provide the JS test and its result here. Depending on the resul... Greg Shah
11:50 AM Support #2672: GUI web client performance improvements
Also it is my fault that I don't check the performance for these two cases:
1) draw vertical|horizontal line by pixe...
Sergey Ivanovskiy
11:43 AM Support #2672: GUI web client performance improvements
Before 11021 changes these primitives: drawRect, drawRoundRect, draw3DRect draws the stroked lines only if the curren... Sergey Ivanovskiy
11:02 AM Support #2672: GUI web client performance improvements
Constantin, I found the performance issue with @./demo/movie-ratings-dynamic.p@ (@com.goldencode.testcases.demo.Movie... Sergey Ivanovskiy
08:11 AM Support #2672: GUI web client performance improvements
Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > The image background issue is ...
> Thanks for pointing t...
Constantin Asofiei
01:45 AM Support #2672: GUI web client performance improvements
I would like to notice the main problem related to the Web client performance is synchronous requests from the Java s... Sergey Ivanovskiy
12:49 AM Support #2672: GUI web client performance improvements
I think that @getImageData@ is also an expensive operation. Sergey Ivanovskiy
12:43 AM Support #2672: GUI web client performance improvements
It looks that the new caching introduced by 11022 is more slower than the previous version 11021.
The reported times...
Sergey Ivanovskiy
05:18 PM Bug #2996: Cursor change at the window border
Restore the mouse cursor change at the crossing of the window border for the Web GUI. Igor Skornyakov
05:17 PM Bug #2996 (Closed): Cursor change at the window border
Igor Skornyakov
05:14 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Cleanup finished.
Committed to the task branch 2565a revno 11026
Ready for the code review
Igor Skornyakov
02:30 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Custom mouse pointer support for the @COMBO-BOX@ (WebGUI) finished.
Committed to the task branch 2565a revno 11023...
Igor Skornyakov
10:13 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> Please create a separate task for this. We may have someone else work it. Do not work on the ...
Igor Skornyakov
10:08 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
> After that the only remaining issue will be cursor change on the window border. It should be difficult
Please crea...
Greg Shah
08:41 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> Igor: Please provide some details on the state of this task. I know you are working on some prob...
Igor Skornyakov
08:06 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Igor: Please provide some details on the state of this task. I know you are working on some problems with combo-box ... Greg Shah
02:34 PM Bug #2995: if the first mouse after app startup is on a combo-box, then an abend occurs
Greg Shah wrote:
> Code Review Task Branch 2565a Revisions 11019/11020
> 1. Why are @WidgetRegistry.getComponents()...
Igor Skornyakov
11:01 AM Bug #2995: if the first mouse after app startup is on a combo-box, then an abend occurs
Code Review Task Branch 2565a Revisions 11019/11020
Overall, the approach seems good.
1. Why are @WidgetRegistr...
Greg Shah
02:06 PM Bug #2914: Fix errors in window_sizing/test_runner.p
I've created task branch 2914a. Hynek Cihlar
12:53 PM Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> I've tested DIALOG-BOX. System popups are really don't work for it. So I'm adding that support...
Hynek Cihlar
12:28 PM Bug #2849: implement and/or fix the default popup menus for all widgets
I've tested DIALOG-BOX. System popups are really don't work for it. So I'm adding that support to DialogBox in the sa... Vadim Gindin
10:36 AM Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > In @MenuGuiImpl@, why to use reflection instead of just calling the c...
Hynek Cihlar
07:17 AM Bug #2849: implement and/or fix the default popup menus for all widgets
Hynek Cihlar wrote:
> @EditorGuiImpl.mouseClicked()@
> The @wnd.initEditorPopup()@ call is fishy and I think may not ...
Vadim Gindin
11:00 AM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
The conversion testing completed, generated codes are identical. Continue with runtime testing. Eugenie Lyzenko
07:32 AM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Greg Shah wrote:
> Code Review Task Branch 2612b Revision 10987
>
> I'm fine with the changes. Please put them t...
Eugenie Lyzenko
07:29 AM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Code Review Task Branch 2612b Revision 10987
I'm fine with the changes. Please put them through regression testing.
Greg Shah
07:47 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Task branch @2612b@ for review updated to revision @10987@.
Added support for @INT64@ internal slider variable. Sc...
Eugenie Lyzenko

02/16/2016

06:16 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Task branch @2612b@ for review updated to revision @10986@.
Notes resolution for point 1 and 3 from #60 note. The ...
Eugenie Lyzenko
06:07 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
> But the question: even if we can initially assign the big enough value the screen value can be from MIN to MAX - wh... Greg Shah
05:57 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
>> The only data is possible to use with slider is INTEGER.
>Changing the Sl variable in slider_test01.p to int64...
Eugenie Lyzenko
04:42 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
>> 2. Can you use an int64 or decimal with a slider?
>
> The only data is possible to use with slider is INTEGER.
...
Greg Shah
04:39 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Guy: Eugenie's slider testcases exhibit a strange behavior in GUI. Consider this code:... Greg Shah
04:31 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
>1. Please add comments to the javadoc for both versions of SliderWidget,setNoCurrentValue(). As you mention in note ... Eugenie Lyzenko
04:03 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Code Review Task Branch 2612b Revision 10985
This is great work!
1. Please add comments to the javadoc for both...
Greg Shah
03:54 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Greg Shah wrote:
> What testcases shows this behavior?
Every test in @uast/slider/@ directory. In all of them the...
Eugenie Lyzenko
03:31 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
> Also I've made the change looking strange, so need your comments. I have found in 4GL when the slider value is chan... Greg Shah
06:00 PM Bug #2849: implement and/or fix the default popup menus for all widgets
@EditorGuiImpl.mouseClicked()@
The @wnd.initEditorPopup()@ call is fishy and I think may not work in a @DIALOG-BOX@....
Hynek Cihlar
03:25 PM Bug #2849: implement and/or fix the default popup menus for all widgets
Yes, you can start testing.
Hynek and Constantin: please review.
Greg Shah
12:58 PM Bug #2849: implement and/or fix the default popup menus for all widgets
Fixed. Can I ran regression testing? Vadim Gindin
12:34 PM Bug #2849: implement and/or fix the default popup menus for all widgets
Code Review Task Branch 2849a Revision 10995
1. In @EditorPopupGuiImpl@, this code:...
Greg Shah
05:11 AM Bug #2849: implement and/or fix the default popup menus for all widgets
Greg Shah wrote:
> ..
> 3. It is not clear to me if the changes to how @invalidateSelection()@ is called in the @Ed...
Vadim Gindin
04:36 AM Bug #2849: implement and/or fix the default popup menus for all widgets
I've rebased branch 2849a with the latest trunk revision. Current branch revision is 10992. Vadim Gindin
05:53 PM Support #2672: GUI web client performance improvements
The difficult problems in ./browse/gui/browse-gui-stat1.p are
!browse_artifacts_in_title.png!
It happens after clicki...
Sergey Ivanovskiy
05:38 PM Support #2672: GUI web client performance improvements
It looks the same for ./browse/gui/browse-gui-stat1.p, I am planning to check the dots drawing and to do it the same ... Sergey Ivanovskiy
05:05 PM Support #2672: GUI web client performance improvements
Sergey Ivanovskiy wrote:
> If we draw the image exactly like it comes from the Java, the result should be like we se...
Constantin Asofiei
05:00 PM Support #2672: GUI web client performance improvements
Sergey Ivanovskiy wrote:
> It should be the same as the previous implementation it has been tested with demo_widgets...
Constantin Asofiei
04:59 PM Support #2672: GUI web client performance improvements
If we draw the image exactly like it comes from the Java, the result should be like we see, I have encountered it in ... Sergey Ivanovskiy
04:52 PM Support #2672: GUI web client performance improvements
Sergey Ivanovskiy wrote:
> The image background issue is ...
Thanks for pointing this, I'll look into it. I think so...
Constantin Asofiei
04:50 PM Support #2672: GUI web client performance improvements
The image background issue is !icons_bg_issue.png! Sergey Ivanovskiy
04:42 PM Support #2672: GUI web client performance improvements
Constantin Asofiei wrote:
> Sergey, about revision 11021; the changes look OK, but are you sure this gets us the sam...
Sergey Ivanovskiy
04:30 PM Support #2672: GUI web client performance improvements
Sergey, about revision 11021; the changes look OK, but are you sure this gets us the same result as the previous impl... Constantin Asofiei
03:54 PM Support #2672: GUI web client performance improvements
1811t rev 11022 enhances the drawing cache to include intermediate widget states; currently, caching is used only for... Constantin Asofiei
12:02 PM Support #2672: GUI web client performance improvements
Sergey Ivanovskiy wrote:
> Constantin, could you help? Does the Web Chui client support md5 hashing? It looks that p...
Constantin Asofiei
11:48 AM Support #2672: GUI web client performance improvements
Constantin, could you help? Does the Web Chui client support md5 hashing? It looks that p2j.socket.js is a common mod... Sergey Ivanovskiy
01:34 AM Support #2672: GUI web client performance improvements
Greg Shah wrote:
> It got me thinking. When the user is editing text in a fill-in or editor (or a browse cell/simple...
Sergey Ivanovskiy
04:51 PM Bug #2911: Fix extra background shown for popup_ext.p
Some more info for note 25; the main problem with menu and popup-menu is this: these widgets behave differently than ... Constantin Asofiei
03:29 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
Agree, it doesn't require to use Web Workers API. There is an alternative to use Timers API or http://dbaron.org/log/... Sergey Ivanovskiy
12:04 PM Bug #2995: if the first mouse after app startup is on a combo-box, then an abend occurs
Please find the diff file attached. The fix is committed to the task branch 2565a Igor Skornyakov
11:07 AM Bug #2995: if the first mouse after app startup is on a combo-box, then an abend occurs
I prefer not to add a 3rd party code dependency for this. The 3rd party code also seems more designed for caching. T... Greg Shah
11:04 AM Bug #2995: if the first mouse after app startup is on a combo-box, then an abend occurs
From Igor:
After added synchronization for access to the WidgetRegistry.widgetList the problem seem to disappear. ...
Greg Shah
11:03 AM Bug #2995: if the first mouse after app startup is on a combo-box, then an abend occurs
This was reported by Igor:
-------- Forwarded Message --------
Subject: Issue with COMBO-BOX
Date: Thu, 11 Feb...
Greg Shah
11:01 AM Bug #2995 (Closed): if the first mouse after app startup is on a combo-box, then an abend occurs
Greg Shah
11:19 AM Bug #2914: Fix errors in window_sizing/test_runner.p
Greg Shah wrote:
> Please create a 2914a task branch for the changes. I'd also like to see some details posted here...
Hynek Cihlar
09:59 AM Bug #2914: Fix errors in window_sizing/test_runner.p
Please create a 2914a task branch for the changes. I'd also like to see some details posted here about the problems ... Greg Shah
10:46 AM Bug #2784 (Rejected): ./menu/simple_sm.p displays parts of menus inside window content frame for ...
I closing this, since all known issues are already resolved. Greg Shah
10:39 AM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
> Implement everything from scratch keeping look and feel to match the Windows style. In this model all elements are... Greg Shah
10:35 AM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
The customer has confirmed that these statements will soon be disabled in their code. We do not have to work this ta... Greg Shah
08:44 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
-------- Forwarded Message --------
Subject: Re: Mouse cursor
Date: Wed, 10 Feb 2016 13:55:42 -0500
From: Igor ....
Greg Shah
08:43 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
-------- Forwarded Message --------
Subject: Re: Mouse cursor
Date: Wed, 10 Feb 2016 13:38:27 -0500
From: Igor ....
Greg Shah
08:42 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
-------- Forwarded Message --------
Subject: Re: Mouse cursor
Date: Wed, 10 Feb 2016 13:26:26 -0500
From: Igor ...
Greg Shah

02/15/2016

06:07 PM Support #2672: GUI web client performance improvements
Code Review Task Branch 1811t Revisions 11020/11021
The changes in @p2j.canvas_renderer.js@ are pretty straightfor...
Greg Shah
05:29 PM Support #2672: GUI web client performance improvements
This text was written by Sergey in #2967 (note 21):
> In the case of the text editor we have numerous synchronous ...
Greg Shah
04:40 PM Support #2672: GUI web client performance improvements
Greg, please review the committed revision 11021. It reduced @putImageData@ invocations for horizontal and vertical l... Sergey Ivanovskiy
02:29 AM Support #2672: GUI web client performance improvements
For vertical and horizontal lines the stroke that widens a line can be optimized to reduce @putImageData@, because th... Sergey Ivanovskiy
05:37 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
> The note 18 states that if we send a large message from JS to Java using JS WebSocket API, then the Jetty server ca... Greg Shah
12:36 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
> 4. I don't understand all your findings so far. In particular, you state in notes 12 and 14 above, that our curren... Sergey Ivanovskiy
11:51 AM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
Some thoughts:
1. The current RFC implements a per "frame" payload size specified in the frame header with a maxim...
Greg Shah
01:25 PM Bug #2982: in Web client, overlay window must not be "resizeable"
@processWindowBorder@ is noop when overlay window is active.
Committed to the task branch 2565a revno 11022.
Igor Skornyakov
11:24 AM Bug #2787: implement mnemonics/accelerator key support for button
# How is the alert-box relates to mnemonics?
# Does button grouping mechanism supported not or it doesn't supported ...
Vadim Gindin
08:23 AM Bug #2787: implement mnemonics/accelerator key support for button
Created task branch 2787a from P2J trunk revision 10971. Vadim Gindin
10:52 AM Bug #2857: font differences for toggle box and menu
Vadim, are the metrics of the toggle-box correct? I mean, the widget height/width (and its inner highlight rectangle)... Constantin Asofiei
10:18 AM Bug #2849: implement and/or fix the default popup menus for all widgets
Code Review Task Branch 2849a Revision 10991
1. Please rebase this to the latest trunk revision 10971.
2. The u...
Greg Shah
08:02 AM Bug #2784: ./menu/simple_sm.p displays parts of menus inside window content frame for the web client
I've checked it just now. It is not reproduced in the current trunk revision (10971). Vadim Gindin
07:15 AM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Rebased task branch @2612b@ from P2J trunk revision @10971@, new revision is @10985@. Eugenie Lyzenko
06:47 AM Bug #2911: Fix extra background shown for popup_ext.p
Vadim Gindin wrote:
> So I thought so and I'd tried to fix this changing the point used to call the body from @bodyL...
Constantin Asofiei
05:57 AM Feature #1801: add some frame options
Task branch 2038b was merged to trunk as revision 10971.
It resolves the runtime support for FRAME/WINDOW attribut...
Hynek Cihlar
05:36 AM Feature #1801: add some frame options
Hynek Cihlar wrote:
> Are you ok with merging 2038b revision 11000 to trunk?
Yes, go ahead and merge to trunk.
Constantin Asofiei
05:23 AM Feature #1801: add some frame options
Constantin Asofiei wrote:
> Hynek, about 2038b revision 10999:
> # @Frame.calculateWidth@ - line 1619 has some comm...
Hynek Cihlar
04:54 AM Feature #1801: add some frame options
Hynek, about 2038b revision 10999:
# @Frame.calculateWidth@ - line 1619 has some commented code, remove it if is no ...
Constantin Asofiei

02/14/2016

04:42 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
Greg Shah wrote:
> Actually, I'm trying to avoid doing this task for the current project. I am waiting to hear back...
Eugenie Lyzenko
04:41 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
Actually, I'm trying to avoid doing this task for the current project. I am waiting to hear back from the customer. ... Greg Shah
01:23 PM Bug #2911: Fix extra background shown for popup_ext.p
Sub-menu body background looks drawn in a correct point, but it is also cut (clipped), so it is hardly depends on ite... Vadim Gindin
06:00 AM Bug #2911: Fix extra background shown for popup_ext.p
So I thought so and I'd tried to fix this changing the point used to call the body from @bodyLoc@ to @this.physicalLo... Vadim Gindin
05:50 AM Bug #2911: Fix extra background shown for popup_ext.p
Could you help me to deal with that. Here is the sub-menus hierarchy: Menu->SubMenu["John"]->SubMenu["sm00"].
Here...
Vadim Gindin

02/13/2016

05:05 PM Support #2672: GUI web client performance improvements
Greg, Constantin, the committed revision 11020 reduces @putImageData@ invocations for horizontal and vertical lines. ... Sergey Ivanovskiy
03:54 PM Feature #1801: add some frame options
2038b revision 10999 passes ChUI regression tests, GUI regression tests and the supported customer GUI demo screens. ... Hynek Cihlar
07:07 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
Is this the next task in queue, correct? Eugenie Lyzenko
07:03 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
This is the simple demo for @SYSTEM-DIALOG GET-FILE@ statement. As you can see it is the native OS dialog. So we have... Eugenie Lyzenko

02/12/2016

03:39 PM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
1) Disconnect/reconnect usecase
Greg, please could you explain disconnect/reconnect? Does it mean the main connectio...
Sergey Ivanovskiy
11:27 AM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Task branch @2612b@ for review updated to revision @10983, 10984@.
Added missed @ASSIGN@ statement support. Now th...
Eugenie Lyzenko
07:21 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Some mote testing for GUI slider:
1. The web client works fine, see the attached file for sample.
2. There is one...
Eugenie Lyzenko
05:43 AM Support #2672: GUI web client performance improvements
Constantin, please look at this diff with the current 1811t. It works but the performance hasn't been increased yet. ... Sergey Ivanovskiy
12:41 AM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
Found that on the current branch the draw buffer size (0x81 message) is large enough if we scroll down the editor con... Sergey Ivanovskiy

02/11/2016

02:05 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
According to my test if we send the file with its size exceeding the maximum binary message size excepted by Jetty (g... Sergey Ivanovskiy
01:22 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Task branch @2612b@ for review updated to revision @10982@.
The screenshot for dynamic widget in @P2J@ is attached...
Eugenie Lyzenko
08:27 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Task branch @2612b@ for review updated to revision @10981@.
The update has changes that fixes the current value co...
Eugenie Lyzenko
01:14 PM Bug #2911: Fix extra background shown for popup_ext.p
> It means that @Origin@ of sm00 is @219:104@. What does @AbstractGuiDriver.translatedOrigin@ contain? Is it a locati... Constantin Asofiei
12:33 PM Bug #2911: Fix extra background shown for popup_ext.p
John drawing bitmap at: 25:104 with clip: NativeRectangle[top=0, left=0, bottom=23, right=100]
John drawing body bit...
Vadim Gindin
08:31 AM Bug #2911: Fix extra background shown for popup_ext.p
Vadim Gindin wrote:
> I've fixed bodyLoc translation in SubMenuGuiImpl.draw(). It was translated twice, that was wro...
Constantin Asofiei
05:38 AM Bug #2911: Fix extra background shown for popup_ext.p
I've fixed bodyLoc translation in SubMenuGuiImpl.draw(). It was translated twice, that was wrong and coordinates look... Vadim Gindin
11:28 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
1. The discussion become too deep inside the code logic to be private. Please move it to the Redmine, appropriate tas... Eugenie Lyzenko
11:28 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Well. it seem that the problem is in the AbstractContainer. findMouseSource method. Its implementation seems a little... Eugenie Lyzenko
11:26 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
I will take a look. Please note however that for all widgets except drop-down part of the COMBO-BOX mouse hover event... Eugenie Lyzenko
11:26 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Hi Igor,
The mouse events for drop-down's ScrollableSelectionListGuiImpl component is routed from ScrollPaneGuiImp...
Eugenie Lyzenko
11:25 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Hi Eugenie,
I'm working now on the runtime support for the custom mouse cursor (LOAD-MOUSE-POINTER method). At this ...
Eugenie Lyzenko
09:34 AM Feature #1801: add some frame options
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > All work OK.
> Great!
>
> Have you checked the standalone G...
Hynek Cihlar
09:17 AM Feature #1801: add some frame options
Hynek Cihlar wrote:
> All work OK.
Great!
Have you checked the standalone GUI tests?
Constantin Asofiei
09:12 AM Feature #1801: add some frame options
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Yes, I didn't find any regressions there. What is the official ...
Hynek Cihlar
07:03 AM Feature #1801: add some frame options
Hynek Cihlar wrote:
> Yes, I didn't find any regressions there. What is the official test scenario that should work?...
Constantin Asofiei
06:38 AM Feature #1801: add some frame options
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin, please review.
> I'm OK with the changes. I assum...
Hynek Cihlar
06:02 AM Feature #1801: add some frame options
Hynek Cihlar wrote:
> Constantin, please review.
I'm OK with the changes. I assume some cleanup is still needed, a...
Constantin Asofiei
04:18 AM Feature #1801: add some frame options
The ChUI regression test run ended with a regression, an NPE in FillIn.draw(). This was fixed in 2038b revision 10995... Hynek Cihlar

02/10/2016

05:54 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Interesting finding about usage of the @NO-CURRENT-VALUE@ attribute option. According to the Progress documentation t... Eugenie Lyzenko
08:36 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Task branch @2612b@ for review updated to revision @10980@.
The update implements the tic marks calculation compatib...
Eugenie Lyzenko
02:36 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Rebased task branch 2565a from P2J trunk rev 10970. The latest revision is now 11015. Igor Skornyakov
02:28 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Fixed @LOAD-MOUSE-POINTER@ support for the @COMBO-BOX@ (Swing GUI).
Committed to the task branch 2565a revno 11012.
Igor Skornyakov
01:18 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
Sergey Ivanovskiy wrote:
> Greg, should I commit my changes without @remote.sendPartialBytes(data,isLast)@?
The pro...
Sergey Ivanovskiy
12:59 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
My Firefox websocket configuration parameters are in this picture. @network.websocket.max-message-size@ is related to... Sergey Ivanovskiy
12:40 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
Since the Web Socket Jetty API and web socket browser's client don't work as it is expected. This article http://www.... Sergey Ivanovskiy
03:10 AM Feature #1801: add some frame options
Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > Please review 2038b revision 10994. This resolves all known issues pl...
Hynek Cihlar

02/09/2016

05:44 PM Feature #1801: add some frame options
Hynek Cihlar wrote:
> Please review 2038b revision 10994. This resolves all known issues plus some minor improvement...
Hynek Cihlar
05:44 PM Feature #1801: add some frame options
Constantin Asofiei wrote:
> If you are not aware yet, see test @popup_ext.p@ - with your changes, borders are being ...
Hynek Cihlar
05:42 PM Feature #1801: add some frame options
Please review 2038b revision 10994. This resolves all known issues plus some minor improvements to Widget Browser. Hynek Cihlar
07:42 AM Feature #1801: add some frame options
Constantin Asofiei wrote:
> Hynek, about the question in @Frame.setOuterSize()@: the @updateContentWidth@ call is no...
Hynek Cihlar
07:31 AM Feature #1801: add some frame options
> If you are not aware yet, see test @popup_ext.p@ - with your changes, borders are being drawn. Is this related to ... Constantin Asofiei
07:22 AM Feature #1801: add some frame options
Hynek, about the question in @Frame.setOuterSize()@: the @updateContentWidth@ call is no longer needed, as you've cha... Constantin Asofiei
08:47 PM Feature #1801: add some frame options
Code Review Task branch 2038b Revision 10990
I'm fine with the changes.
I will review again when the last fix i...
Greg Shah
07:47 PM Feature #1801: add some frame options
2038b revision 10990 contains regression fixes with one yet unresolved issue, the unexpected verticalStep from note 3... Hynek Cihlar
02:34 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
For an example, ./demo/sample2.bmp has 43.9 kB (43,854 bytes) that exceeds the limit returned by @session.getPolicy()... Sergey Ivanovskiy
02:17 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
Greg, should I commit my changes without @remote.sendPartialBytes(data,isLast)@? Sergey Ivanovskiy
02:12 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
I encountered troubles if we use the Jetty partial message API @remote.sendPartialBytes(data,isLast)@, then the JS we... Sergey Ivanovskiy
09:13 AM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
The code changes are ready. The test with Firefox is passed. Planning to add comments and to commit within two or mor... Sergey Ivanovskiy
10:21 AM Bug #2849: implement and/or fix the default popup menus for all widgets
I've committed the following changes: isRMBEntrySupported method(), added corresponding check to ThinClient.processPr... Vadim Gindin
05:36 AM Bug #2849: implement and/or fix the default popup menus for all widgets
Scroll bars are also ignore RMB click and in this case scrollbar owner will get ENTRY event after scroll popup will b... Vadim Gindin
12:42 AM Bug #2988: The web click events on the caption buttons can invoke the resize action.
Clicking on the minimized caption button can invoke the resize action for the window under the caption button if the ... Sergey Ivanovskiy
12:38 AM Bug #2988 (Closed): The web click events on the caption buttons can invoke the resize action.
Sergey Ivanovskiy
12:31 AM Bug #2987: the combo-box's resources aren't disposed if its dropdown is collapsed
Updated by Eugenie Lyzenko 5 days ago:
Sergey Ivanovskiy wrote:
> Eugenie, please look at this diff, it clea...
Sergey Ivanovskiy
12:29 AM Bug #2987: the combo-box's resources aren't disposed if its dropdown is collapsed
Eugenie, please look at this diff, it cleans resources for web and gui. Planning to postpone this fix because the roo... Sergey Ivanovskiy
12:28 AM Bug #2987: the combo-box's resources aren't disposed if its dropdown is collapsed
Updated by Eugenie Lyzenko 5 days ago:
I think the best place is @ComboBoxGuiImpl.postprocessDropDown()@. Here we ...
Sergey Ivanovskiy
12:26 AM Bug #2987: the combo-box's resources aren't disposed if its dropdown is collapsed
Found two methods that are supposed to clean up resources, but actually they don't clean up.... Sergey Ivanovskiy
12:22 AM Bug #2987 (New): the combo-box's resources aren't disposed if its dropdown is collapsed
Sergey Ivanovskiy
12:19 AM Bug #2986 (Closed): ./demo/simple_windows.p opens the frame titled "second frame" with unset init...
Sergey Ivanovskiy
08:49 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
This is good headway! It looks like you are very close. Greg Shah
07:38 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Task branch @2612b@ for review updated to revision @10979@.
The update has fixes to draw slider for every mode. Th...
Eugenie Lyzenko

02/08/2016

04:45 PM Bug #2911: Fix extra background shown for popup_ext.p
Vadim, the problem is with the fact that the items in the sub-menu's body are drawn with incorrect coordinates (they ... Constantin Asofiei
02:03 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
The plan sounds reasonable. Greg Shah
12:45 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
>I would also like to see message types as a symbolic names like we do with p2j.screen.ops for the drawing ops. This ... Sergey Ivanovskiy
12:41 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
>Use transferable objects in order to increase the round trip time between JS UI thread and the web worker thread.
S...
Sergey Ivanovskiy
12:14 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
> Use transferable objects in order to increase the round trip time between JS UI thread and the web worker thread.
...
Greg Shah
02:02 PM Bug #2849: implement and/or fix the default popup menus for all widgets
Greg Shah wrote:
> ..
> If you click on some other widget in the same window (for example, a button), then the butt...
Vadim Gindin
11:47 AM Bug #2849: implement and/or fix the default popup menus for all widgets
> May be it is needed to implement menus in a separate window first to go further in the proposed way. What do you th... Greg Shah
12:46 AM Bug #2849: implement and/or fix the default popup menus for all widgets
I suppose it would be better to commit system menus and finish ENTRY event in some other task? Vadim Gindin
01:53 PM Support #2672: GUI web client performance improvements
Sergey Ivanovskiy wrote:
> I thought about the JS optimization to reduce numerous calls of puImageData and came to th...
Sergey Ivanovskiy
09:25 AM Bug #2857: font differences for toggle box and menu
Could you recall me, when I got actual text and font metrics will be the fonts equal? In my case they are similar but... Vadim Gindin

02/07/2016

12:33 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
Following this plan:
1) Create the common module for the input and output operations - @p2j.io.js@
2) Reuse @p2j.io.j...
Sergey Ivanovskiy
09:31 AM Bug #2849: implement and/or fix the default popup menus for all widgets
So, can I start to implement menus in a separate window? Vadim Gindin
09:07 AM Bug #2911: Fix extra background shown for popup_ext.p
I've fixed PaintEvent's, but SubMenu's body still doesn't drawn. Constantin, could you have a look? Current branch re... Vadim Gindin

02/06/2016

04:01 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Greg Shah wrote:
> This is all coming along nicely. My only comment is that the colors/shading of the edges of the ...
Eugenie Lyzenko
05:01 AM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
This is all coming along nicely. My only comment is that the colors/shading of the edges of the SVG thumbs does not ... Greg Shah
09:48 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
The work for slider elements adjustment to completely fit the @4gl@ is in progress. Some intermediate results can be ... Eugenie Lyzenko
03:20 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
In any case if the websocket on the java side doesn't support messages that exceed the 32K limit, then we need to spl... Sergey Ivanovskiy

02/05/2016

06:54 PM Feature #1801: add some frame options
After the last ChUI regression test run 2038b has three unresolved issues:
* wrong report page size, this is a con...
Hynek Cihlar
03:13 AM Feature #1801: add some frame options
Ctrl-C part passed, Main part has failed. Overall a great improvement from the previous ChUI regression test run. The... Hynek Cihlar
05:55 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Rebased task branch @2612b@ from P2J trunk revision @10970@, new revision is @10978@. Eugenie Lyzenko
08:39 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Slider testcases updated in bzr to revision @1465@. Eugenie Lyzenko
08:29 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Task branch @2612b@ for review updated to revision @10977@.
This is rework for all thumb images to exactly match t...
Eugenie Lyzenko
05:28 PM Feature #1811: implement the AJAX client driver
Rebased 1811t from trunk revision 10970. The latest revision is now 11018. Greg Shah
01:13 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
If my understanding is correct, then Firefox Web Socket API doesn't require splitting data, if it sends/reads data ob... Sergey Ivanovskiy
10:33 AM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
We should not have a message limit. If it goes above 32K (the inherent limit in websockets), we should send multiple... Greg Shah
10:07 AM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
Greg, please could you write the requirements for this task? Should the maximum message size be configured via the di... Sergey Ivanovskiy
11:05 AM Bug #2982: in Web client, overlay window must not be "resizeable"
Constantin Asofiei wrote:
> Just use a test like this:
> [...]
> open the combo's drop-down and move the mouse aro...
Igor Skornyakov
11:04 AM Bug #2982: in Web client, overlay window must not be "resizeable"
Just use a test like this:... Constantin Asofiei
08:54 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Committed revision 11015 resolves the @TypeAHead@ lock between the main and web worker threads. Sergey Ivanovskiy
08:34 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Sergey Ivanovskiy wrote:
> Constantin Asofiei wrote:
> > I think the lock in @TypeAhead.getKeystroke@ should be mov...
Constantin Asofiei
08:12 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Constantin Asofiei wrote:
> I think the lock in @TypeAhead.getKeystroke@ should be moved from the method into its bo...
Sergey Ivanovskiy
04:52 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
I think the lock in @TypeAhead.getKeystroke@ should be moved from the method into its body, i.e.:... Constantin Asofiei
04:23 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
I would like to notify here even this task is unrelated about the blocking state between main thread... Sergey Ivanovskiy
04:04 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Ok, understand. Good news are these lines of the code can be successfully eliminated committed rev. 11012. Now the re... Sergey Ivanovskiy
04:02 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Sergey Ivanovskiy wrote:
> Sergey Ivanovskiy wrote:
> > I think it is a new requirement to forbid the usage of @Win...
Hynek Cihlar
01:43 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Sergey Ivanovskiy wrote:
> I think it is a new requirement to forbid the usage of @WindowManager.getActiveWindow()@ ...
Sergey Ivanovskiy
12:31 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Hynek Cihlar wrote:
> Sergey can you please explain in what situations is the parameter @focusOut@ needed?...
Sergey Ivanovskiy
12:24 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Hynek, please look at the committed revision 11010, the diff is at...
Sergey Ivanovskiy
05:52 AM Bug #2928: non-localhost testing and fixes
Constantin Asofiei wrote:
> Sergey, an issue about using @XMLHTTPRequest@ - if the web client startup fails, then th...
Sergey Ivanovskiy
05:35 AM Bug #2928: non-localhost testing and fixes
Committed revision 11013 should fix the incorrect processing error's page. Sergey Ivanovskiy
04:54 AM Bug #2928: non-localhost testing and fixes
Constantin Asofiei wrote:
> Sergey, an issue about using @XMLHTTPRequest@ - if the web client startup fails, then th...
Sergey Ivanovskiy
04:40 AM Bug #2928: non-localhost testing and fixes
Sergey, an issue about using @XMLHTTPRequest@ - if the web client startup fails, then the message is not displayed as... Constantin Asofiei
05:21 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Section 27 has been updated. Igor Skornyakov
01:56 AM Bug #2849: implement and/or fix the default popup menus for all widgets
I recall that at this step menus are implemented in the same window. In other words opened popup window is still in t... Vadim Gindin

02/04/2016

05:52 PM Bug #2982: in Web client, overlay window must not be "resizeable"
Constantin Asofiei wrote:
> Currently, when hovering the mouse on the edge of a i.e. drop-down combobox, the mouse p...
Igor Skornyakov
05:43 PM Bug #2982: in Web client, overlay window must not be "resizeable"
Greg Shah wrote:
> Igor: are you already planning to handle this issue as part of #2565?
If I understand this issue...
Igor Skornyakov
05:41 PM Bug #2982: in Web client, overlay window must not be "resizeable"
Igor: are you already planning to handle this issue as part of #2565? Greg Shah
05:38 PM Bug #2982: in Web client, overlay window must not be "resizeable"
Currently, when hovering the mouse on the edge of a i.e. drop-down combobox, the mouse pointer is switched to a "wind... Constantin Asofiei
05:37 PM Bug #2982 (Closed): in Web client, overlay window must not be "resizeable"
Constantin Asofiei
02:06 PM Feature #1801: add some frame options
ChUI regression tests for 2038b restarted. Hynek Cihlar
12:55 PM Feature #1801: add some frame options
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin, is it expected for the @Frame.verticalStep@ to be e...
Hynek Cihlar
10:12 AM Feature #1801: add some frame options
Hynek Cihlar wrote:
> Constantin, is it expected for the @Frame.verticalStep@ to be equal to the size of base unit w...
Constantin Asofiei
07:56 AM Feature #1801: add some frame options
Greg Shah wrote:
> Code Review Task branch 2038b Revision 10983
>
> I'm fine with the changes.
>
> How bad are...
Hynek Cihlar
07:45 AM Feature #1801: add some frame options
Code Review Task branch 2038b Revision 10983
I'm fine with the changes.
How bad are the regressions?
Greg Shah
07:23 AM Feature #1801: add some frame options
Hynek Cihlar wrote:
> ChUI regression testing is in progress.
The test run finished with regressions.
Hynek Cihlar
08:40 PM Feature #1801: add some frame options
Please review 2038b revision 10983. The branch adds or improves runtime support of SCROLLABLE, VIRTUAL-*, SCROLL-BARS... Hynek Cihlar
10:29 AM Bug #2978: The Swing GUI window cannot be dragged between two monitors
Moreover: even when the window is moved to another monitor via Alt-F7 is sometimes moves back to the initial one "by ... Igor Skornyakov
08:18 AM Bug #2978: The Swing GUI window cannot be dragged between two monitors
The Swing GUI window cannot be dragged between two monitors. It is possible to do it via Alt-F7. Igor Skornyakov
08:17 AM Bug #2978 (New): The Swing GUI window cannot be dragged between two monitors
Igor Skornyakov
08:19 AM Bug #2979: The drop-down selection list for the combo-box is not properly aligned in the WebGUI
The drop-down selection list for the combo-box is not properly aligned (shifted to the left) in the WebGUI Igor Skornyakov
08:19 AM Bug #2979 (New): The drop-down selection list for the combo-box is not properly aligned in the We...
Igor Skornyakov
07:56 AM Bug #2849: implement and/or fix the default popup menus for all widgets
> I think this is the same case as with combo drop-down. We do not handle mouse-click there but rather rely on Window... Greg Shah
08:50 PM Bug #2849: implement and/or fix the default popup menus for all widgets
Greg Shah wrote:
> The problem here is that we must detect a click outside of the popup but the click is really need...
Hynek Cihlar
05:56 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Sergey Ivanovskiy wrote:
> Hynek, please look at the committed revision 11010, the diff is attached, taking into acc...
Hynek Cihlar
05:33 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Sergey Ivanovskiy wrote:
> If we use TAB/SHIFT+TAB keys, then at the beginning these keys help to move between widge...
Hynek Cihlar
08:04 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Task branch @2612b@ for review updated to revision @10976@.
Adding code to draw the thumb shapes using @SVG@ image...
Eugenie Lyzenko

02/03/2016

06:14 PM Feature #1801: add some frame options
Constantin, is it expected for the @Frame.verticalStep@ to be equal to the size of base unit when the frame has no wi... Hynek Cihlar
08:52 AM Feature #1801: add some frame options
Code Review Task branch 2038b Revision 10979
The changes are functionally fine. Please do the final cleanups (e.g...
Greg Shah
05:07 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
The runtime support of @LOAD-MOUSE-POINTER@ and @SET-WAIT-STATE@ for WebGUI is mostly finished.
Committed to the t...
Igor Skornyakov
09:56 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
> 4. Custom mouse pointer support for the BROWSE (both SwingGUI and WebGUI).
I want to get 2565a tested and merged...
Greg Shah
09:22 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Most of the functionality is working in WebGUI. The remaining tasks are:
1. Lock mouse cursor while drop-down is act...
Igor Skornyakov
09:08 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Please make a list of all remaining work on this task and post it here. Greg Shah
06:40 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
The issue mentioned in the previous note was a result of the syntax error: @DISABLE fi IN FRAME fr.@ instead of @DISA... Igor Skornyakov
04:37 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Hynek, please look at the committed revision 11010, the diff is attached, taking into account the following bug found... Sergey Ivanovskiy
03:07 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Sergey Ivanovskiy wrote:
> Eugenie, please look at this diff, it cleans resources for web and gui. Planning to postp...
Eugenie Lyzenko
02:44 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Eugenie, please look at this diff, it cleans resources for web and gui. Planning to postpone this fix because the roo... Sergey Ivanovskiy
01:10 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
I think the best place is @ComboBoxGuiImpl.postprocessDropDown()@. Here we can identify @OverlayWindow@ and call
<pr...
Eugenie Lyzenko
12:54 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Eugenie Lyzenko wrote:
> Sergey Ivanovskiy wrote:
> > Eugenie, I found that the Swing version of combobox created t...
Sergey Ivanovskiy
10:47 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Sergey Ivanovskiy wrote:
> Eugenie, I found that the Swing version of combobox created the Overlay windows (by click...
Eugenie Lyzenko
10:39 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Eugenie, I found that the Swing version of combobox created the Overlay windows (by clicking the combobox dropdown bu... Sergey Ivanovskiy
08:42 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Sergey Ivanovskiy wrote:
> The Swing simple case with one window produces these events on minimize/restore
> Deicon...
Hynek Cihlar
08:15 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
In the case of two windows (./demo/simle_windows.p)
Restoring the "P2Gui Client" window and then the "second window"...
Sergey Ivanovskiy
07:30 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
The Swing simple case with one window produces these events on minimize/restore
Deiconify...
Sergey Ivanovskiy
05:34 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Sergey Ivanovskiy wrote:
> Sorry for this delay. The considered case is one window that is minimized and then restor...
Hynek Cihlar
05:26 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Sorry for this delay. The considered case is one window that is minimized and then restored by clicking on the task i... Sergey Ivanovskiy
02:51 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > Thanks for your shares. If my un...
Hynek Cihlar
02:44 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Sergey Ivanovskiy wrote:
> Does the code of @WindowManager@ implement the specific Swing logic?
The implementatio...
Hynek Cihlar
12:32 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Does the code of @WindowManager@ implement the specific Swing logic? Sergey Ivanovskiy
12:22 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Thanks for your shares. If my understanding is correct the code ...
Sergey Ivanovskiy
07:19 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Sergey Ivanovskiy wrote:
> Thanks for your shares. If my understanding is correct the code that manages to work this...
Hynek Cihlar
03:55 PM Bug #2849: implement and/or fix the default popup menus for all widgets
>> In other words, the mouse event is "eaten" and does not switch away from the widget. It just dismisses the popup.
...
Greg Shah
03:32 PM Bug #2849: implement and/or fix the default popup menus for all widgets
Greg Shah wrote:
> > Default popup menu:
> > widget gets the cursor
>
> Having the cursor is typically the sam...
Vadim Gindin
09:01 AM Bug #2849: implement and/or fix the default popup menus for all widgets
> Default popup menu:
> widget gets the cursor
Having the cursor is typically the same thing as having the focu...
Greg Shah
10:35 AM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
I think it is best called the "thumb". Greg Shah
10:32 AM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Greg Shah wrote:
> If the mouse pointer doesn't change, then #2565 is not related.
No, the mouse pointer remains ...
Eugenie Lyzenko
09:54 AM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
If the mouse pointer doesn't change, then #2565 is not related. Greg Shah
09:13 AM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Greg Shah wrote:
> Please see #2565 (and branch 2565a) for our current work on mouse pointer support. Please review...
Eugenie Lyzenko
07:45 AM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Please see #2565 (and branch 2565a) for our current work on mouse pointer support. Please review that branch and mak... Greg Shah
07:39 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Task branch @2612b@ for review updated to revision @10975@.
Adding support for moving slider pointer by mouse drag...
Eugenie Lyzenko
10:00 AM Bug #2977: LOAD-MOUSE-POINTER implementation for the BROWSE widget
Implement @LOAD-MOUSE-POINTER@ runtime support for the @BROWSE@ widget. See #2565 note 27 for the description of the ... Igor Skornyakov
09:58 AM Bug #2977 (New): LOAD-MOUSE-POINTER implementation for the BROWSE widget
Igor Skornyakov
08:42 AM Support #2672: GUI web client performance improvements
Thanks for the update.
> about the issue in note 6: we should really fix this, as lots of no-op attribute setter c...
Greg Shah
06:30 AM Support #2672: GUI web client performance improvements
1811t rev 11009 contains an expiry cache at the client-side (the MD5 producer). This is currently set to 1000 entrie... Constantin Asofiei

02/02/2016

05:57 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
With the @mouse.p@ (see note 145) the @DISABLE fi IN FRAME fr.@ results in the @FILL-IN@ re-creation with new id. Thi... Igor Skornyakov
12:13 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
The issue mentioned in the note 145 is fixed. Igor Skornyakov
11:03 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
When running converted @mouse.p@ (attached) the @FRAME@ and @RADIO-SET@ are registered with (non-visible) @WINDOW@ wi... Igor Skornyakov
04:22 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Thanks for your shares. If my understanding is correct the code that manages to work this method @WindowManager.isWin... Sergey Ivanovskiy
03:57 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Eugenie Lyzenko wrote:
> >In Swing gui driver, the focus gained event is only a synonym for an activated window.
> ...
Hynek Cihlar
03:49 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
>In Swing gui driver, the focus gained event is only a synonym for an activated window.
This is not always the tru...
Eugenie Lyzenko
03:30 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > Let us consider the activation u...
Hynek Cihlar
03:23 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
In general the GUI driver window logic should be pretty simple
* a window is activated/deactivated as a result of a...
Hynek Cihlar
03:14 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Let us consider the activation usecase. The current window is mi...
Sergey Ivanovskiy
03:03 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Sergey Ivanovskiy wrote:
> Hynek, I think we should develop the general conception for all usecases: with one window...
Hynek Cihlar
02:59 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Sergey Ivanovskiy wrote:
> Let us consider the activation usecase. The current window is minimized, the current focu...
Hynek Cihlar
02:27 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Greg, Hynek, Eugenie please look at the committed revision 11008. We need a conception to resolve the cases. Here I c... Sergey Ivanovskiy
02:00 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Hynek, I think we should develop the general conception for all usecases: with one window, two windows, one window th... Sergey Ivanovskiy
01:45 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Let us consider the activation usecase. The current window is minimized, the current focus window is cleared. The JS ... Sergey Ivanovskiy
01:34 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Let us consider the most simple case with only one window. The actual situation is that we send an event from JS clie... Sergey Ivanovskiy
01:22 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Sergey Ivanovskiy wrote:
> Hynek, please could you clarify the statement
> [...]
> Should the active window return...
Hynek Cihlar
12:44 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Hynek, please could you clarify the statement... Sergey Ivanovskiy
05:01 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Cleanup the committed revision 11007. I have troubles with the current windows management system, the lost events, wi... Sergey Ivanovskiy
04:36 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Clicking on the minimized caption button can invoke the resize action for the window under the caption button if the ... Sergey Ivanovskiy
01:05 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Committed revision 11005. This revision has the following found bugs reproduced for ./demo/simple_windows.p
1) The f...
Sergey Ivanovskiy
03:10 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Rebased task branch @2612b@ from P2J trunk revision @10969@, new revision @10974@. Eugenie Lyzenko
02:57 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Task branch @2612b@ for review updated to revision @10972@.
Adding mouse handling base. Preparing to rebase for @1...
Eugenie Lyzenko
08:55 AM Bug #2911: Fix extra background shown for popup_ext.p
Vadim, when clipping (at the driver level), the clip rectangle will be "the smallest rectangle which contains all cli... Constantin Asofiei

02/01/2016

05:00 PM Bug #2849: implement and/or fix the default popup menus for all widgets
Behaviour in order of appearance. There are 2 different cases: default and overridden popup menu.
FillIn, Editor a...
Vadim Gindin
04:03 PM Feature #1801: add some frame options
Hynek Cihlar wrote:
> The actual scrollable state (whether scroll bars are visible or not) is determined based on th...
Hynek Cihlar
03:59 PM Feature #1801: add some frame options
Constantin Asofiei wrote:
> I guess scrollable state is resolved when frame is realized and maintained forever, even...
Hynek Cihlar
03:58 PM Feature #1801: add some frame options
Code Review Task Branch 2038b Revision 10978
I'm fine with the changes so far.
Greg Shah
03:16 PM Feature #1801: add some frame options
Hynek, another interesting fact is that if you move the frame from a smaller window (where the frame is scrollable) t... Constantin Asofiei
02:39 PM Feature #1801: add some frame options
Constantin Asofiei wrote:
> Hynek, about this comment in @FrameConfig@:
> [...]
> As you probably noticed (after s...
Hynek Cihlar
01:32 PM Feature #1801: add some frame options
Hynek, about this comment in @FrameConfig@:... Constantin Asofiei
01:05 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Sergey Ivanovskiy wrote:
> Thanks, after all your explanations the windows management logic becomes more clear for m...
Eugenie Lyzenko
01:02 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Thanks, after all your explanations the windows management logic becomes more clear for me. The main window means the... Sergey Ivanovskiy
11:43 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Sergey Ivanovskiy wrote:
> This code of @GuiWebDriver@ is logically confused
> [...]
> It is supposed that it will...
Hynek Cihlar
11:42 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Sergey Ivanovskiy wrote:
> This code of @GuiWebDriver@ is logically confused
> [...]
> It is supposed that it will...
Eugenie Lyzenko
11:12 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
This code of @GuiWebDriver@ is logically confused... Sergey Ivanovskiy
09:12 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Thank you, the rebase is done. The committed revision 11004 has several text conflicts in the history entries and one... Sergey Ivanovskiy
08:01 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
> But the trunc commits have more priorities, don't?
Yes.
> Should these entries be kept as they are in the tru...
Greg Shah
07:49 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Greg, could you help to resolve history entries. I have only history entries conflicts in ... Sergey Ivanovskiy
07:20 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Starting rebase 1811t at revision 10992. Sergey Ivanovskiy
05:25 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Yes, go ahead with the rebase. I had hoped to wait for the #2038 changes, but I don't want to hold you up. Go ahead. Greg Shah
02:50 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Greg, the current 1811t needs to be rebased because the p2j has improvements in the windows management system (2837).... Sergey Ivanovskiy
01:23 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
No, window deactivated events aren't sent. It requires to extend MSG_WINDOW_ACTIVATED (0x0f) message by adding new pa... Sergey Ivanovskiy
08:31 AM Support #2672: GUI web client performance improvements
Is it still worth pursuing the @putImageData()@ optimization? If the odds of success with this approach are diminish... Greg Shah
08:23 AM Bug #2795 (Closed): scoped variables/tables/etc and persistent procedures
Please archive the task branch. Greg Shah
08:13 AM Bug #2795: scoped variables/tables/etc and persistent procedures
Greg Shah wrote:
> We can close this task, right?
Correct
Constantin Asofiei
08:12 AM Bug #2795: scoped variables/tables/etc and persistent procedures
Merged to trunk as part of revision 10967.
We can close this task, right?
Greg Shah
04:31 AM Bug #2911: Fix extra background shown for popup_ext.p
I'm currently working on the bug, when drawn sub-menu body is cut. Here is the screen shot:
!sm_body_cut.png!
Cou...
Vadim Gindin
01:39 AM Bug #2911: Fix extra background shown for popup_ext.p
I've rebased the branch 2911a to current trunk revision. Now revision is 10968. Vadim Gindin

01/31/2016

05:01 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Refactored @GuiWebDriver.registerMouseWidgets()@
Committed to task branch 2565a revno 11007.
Igor Skornyakov
01:03 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Sergey Ivanovskiy wrote:
> The current 10992 diff is here.
Sergey, are you also sending a window-deactivated mess...
Hynek Cihlar
12:56 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Code Review Task Branch 1811t Revision 10992
I'm fine with the changes. Can I close this task?
Greg Shah
12:16 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
The current 10992 diff is here. Sergey Ivanovskiy
12:15 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Committed revision 10992 should fix these cases. The JS client sends the window active event to the server if the tar... Sergey Ivanovskiy
11:39 AM Support #2672: GUI web client performance improvements
Constantin, please look at the attached picture of @./demo/simple_windows.p@ if the window's restore caption button i... Sergey Ivanovskiy

01/30/2016

06:24 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Rebased task branch @2612b@ from P2J trunk revision @10967@, new revision @10971@. Eugenie Lyzenko
08:01 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Task branch @2612b@ for review updated to revision @10970@.
Also the testcases repo updated to revision @1463@ wit...
Eugenie Lyzenko
04:08 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Rebased task branch 2565a from P2J trunk rev 10967. The latest revision is now 11006. Igor Skornyakov

01/29/2016

01:18 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Thank you, planning to check these cases in Swing Gui and then to simulate window events by the JS driver. Sergey Ivanovskiy
01:09 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Sergey Ivanovskiy wrote:
> he current JS side implementation sends @MSG_WINDOW_ACTIVATED@ (0x0f) message iff the top ...
Hynek Cihlar
12:11 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
The current JS side implementation sends @MSG_WINDOW_ACTIVATED@ (0x0f) message iff the top window is changed by click... Sergey Ivanovskiy
11:16 AM Support #2672: GUI web client performance improvements
Greg, 1811t rev 10991 contains these:
# the drawing cache (based on MD5 hashes). In a note you mentioned that we sh...
Constantin Asofiei
07:23 AM Support #2672: GUI web client performance improvements
I thought about the JS optimization to reduce numerous calls of puImageData and came to this plan:
1) Take the offsc...
Sergey Ivanovskiy
08:05 AM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Cool! Greg Shah
07:38 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Task branch @2612b@ for review updated to revision @10969@.
Added some @GUI@ rendering implementations for dotted ...
Eugenie Lyzenko
08:03 AM Bug #2972: StringIndexOutOfBoundsException in ScrollBar (GUI)
To recreate the error any EDITOR with horizontal scroll bars is enough. For example, @uast/gui_editor_popup.p@
h3....
Vadim Gindin
07:47 AM Bug #2972 (New): StringIndexOutOfBoundsException in ScrollBar (GUI)
Vadim Gindin
08:01 AM Bug #2849: implement and/or fix the default popup menus for all widgets
> There are possible 3 variants:
> # Leave the current change, that add right mouse button ignoring for all widgets ...
Greg Shah
07:59 AM Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> I've checked again @FillIn@ and @Editor@ widgets. It behave in the following way (when right m...
Greg Shah
07:54 AM Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > Greg Shah wrote:
> > > I'm OK with the changes.
> > >
> > > Hynek...
Hynek Cihlar
07:40 AM Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim: Please create a new sub-task of #2677 for the @java.lang.StringIndexOutOfBoundsException: String index out of ... Greg Shah
07:28 AM Bug #2849: implement and/or fix the default popup menus for all widgets
Hynek Cihlar wrote:
> Greg Shah wrote:
> > I'm OK with the changes.
> >
> > Hynek/Constantin: any concerns with ...
Vadim Gindin
05:23 AM Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim, are all the points from note 19 resolved? If not, please proceed with those. Should you have any questions ple... Hynek Cihlar
05:03 AM Bug #2849: implement and/or fix the default popup menus for all widgets
Hynek Cihlar wrote:
> ..
> Vadim, were you able to resolve all the scrolling issues for the "Scroll Here" functiona...
Vadim Gindin

01/28/2016

01:25 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
@LOAD-VOUSE-POINTER@ for the WebGUI is essentially done (including file-based cursors).
Committed to the task bran...
Igor Skornyakov
12:39 PM Bug #2849: implement and/or fix the default popup menus for all widgets
Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > Here is the current situation.
> > # System popups are implemented.
...
Hynek Cihlar
12:36 PM Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> Here is the current situation.
> # System popups are implemented.
> # The system popup of wi...
Hynek Cihlar
04:21 AM Bug #2849: implement and/or fix the default popup menus for all widgets
Here is the current situation.
# System popups are implemented.
# The system popup of window title bar displays ico...
Vadim Gindin
10:57 AM Bug #2928 (Closed): non-localhost testing and fixes
The code looks good. I'm closing this now. Greg Shah
09:27 AM Bug #2928: non-localhost testing and fixes
Committed revision 10990 has fixes according to the review.
Sergey Ivanovskiy
08:22 AM Bug #2928: non-localhost testing and fixes
Code Review Task Branch 1811t Revisions 10987 and 10988
This is really good work! And it highlights again why IE ...
Greg Shah
07:45 AM Bug #2928: non-localhost testing and fixes
The committed revision 10988 fixes the IE connection issue. Passes tests with IE, Chrome and Firefox. Sergey Ivanovskiy
06:03 AM Bug #2928: non-localhost testing and fixes
Decided to change the redirect response(302/303) to the simple text response(200) with the encoded redirect path in o... Sergey Ivanovskiy
04:38 AM Bug #2928: non-localhost testing and fixes
> > Planning to use JS object @XMLHttpRequest@ in @web_client.html@ to post the login/password and to get the redirec... Sergey Ivanovskiy
08:43 PM Bug #2928: non-localhost testing and fixes
Sergey Ivanovskiy wrote:
> Planning to use JS object @XMLHttpRequest@ in @web_client.html@ to post the login/password...
Sergey Ivanovskiy
10:24 AM Feature #1801: add some frame options
Rebased task branch 2038b from P2J trunk revision 10966 (new branch revision 10972). Hynek Cihlar
09:37 AM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Adding slider test screens in @4GL@. The @SIZE@ option is not specified, only min/max. Investigating how the default ... Eugenie Lyzenko
08:50 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Task branch @2612b@ for review updated to revision @10968@.
This is the preparation steps to have @GUI@ implementa...
Eugenie Lyzenko
09:16 AM Feature #2628: Non-fill-in column support in browse.
Browse @MAX-CHARS@ attribute must be implemented in this task. Greg Shah
09:15 AM Feature #2959: Implement search by key in browse
This task must also implement @ALLOW-COLUMN-SEARCHING@ and the @START-SEARCH@ and @END-SEARCH@ events. See #2564-276... Greg Shah

01/27/2016

03:45 PM Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> > In @WindowGuiImpl.initScrollPopup()@ you save the value of @owner@ parameter in the cached po...
Hynek Cihlar
12:54 PM Bug #2849: implement and/or fix the default popup menus for all widgets
Hynek Cihlar wrote:
> Vadim, see the attached diff. It fixes two issues, (1) an abend when doubleclicking inside an ...
Vadim Gindin
11:14 AM Bug #2928: non-localhost testing and fixes
Planning to use JS object @XMLHttpRequest@ in @web_client.html@ to post the login/password and to get the redirect ur... Sergey Ivanovskiy
07:40 AM Bug #2928: non-localhost testing and fixes
> I don't understand why the server is tried to create new spawn process and doesn't use the existing process,
Ple...
Greg Shah
12:42 AM Bug #2928: non-localhost testing and fixes
The reason of IE failures can be a bug while processing the "There is a problem with this website's security certific... Sergey Ivanovskiy
07:21 PM Bug #2928: non-localhost testing and fixes
Tested with Windows 8.1, 32-bit. The result is the same.
1) Print https://192.168.1.35:7443/gui in the IE address fi...
Sergey Ivanovskiy
10:30 AM Bug #2911: Fix extra background shown for popup_ext.p
Another issue: this code in @SubMenuGuiImpl.prepParentLocation@ is called on each step of the loop in @AbsractWidget.... Constantin Asofiei
08:12 AM Bug #2911: Fix extra background shown for popup_ext.p
Vadim, another issue: PaintEvent's are posted also when the popup-up menu is made visible. This includes the entire ... Constantin Asofiei
09:56 AM Bug #2795: scoped variables/tables/etc and persistent procedures
Constantin Asofiei wrote:
> Are you sure @instantiateDefault()@ needs to initialize the var with 0 instead of unknow...
Eric Faulhaber
09:48 AM Bug #2795: scoped variables/tables/etc and persistent procedures
Eric, I've merged 2795a into 2647a - see revision 10983.
With this revision, the following is needed:
# for MAJIC...
Constantin Asofiei
09:17 AM Bug #2795: scoped variables/tables/etc and persistent procedures
Eric, I have this conflict in @recid.java@:... Constantin Asofiei
09:00 AM Bug #2795: scoped variables/tables/etc and persistent procedures
Constantin Asofiei wrote:
> Eric: please let me know if I can merge into 2647a.
Yes, please do.
Eric Faulhaber
07:43 AM Bug #2795: scoped variables/tables/etc and persistent procedures
The only issue is with tc_item_master_007 - two records are ordered differently in the screen on step 80. Running in... Constantin Asofiei
04:09 AM Feature #1801: add some frame options
Constantin Asofiei wrote:
> Hynek, see this test:
Constantin, very helpful. Thanks.
Hynek Cihlar
02:54 AM Feature #1801: add some frame options
Hynek, see this test:... Constantin Asofiei
07:15 PM Feature #1801: add some frame options
I've been attempting to come up with a working @FRAME:TOP-ONLY@ test case. However I had no luck in getting any visib... Hynek Cihlar

01/26/2016

06:03 PM Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim, see the attached diff. It fixes two issues, (1) an abend when doubleclicking inside an empty editor and (2) sc... Hynek Cihlar
02:10 PM Bug #2849: implement and/or fix the default popup menus for all widgets
Here is the test:... Vadim Gindin
01:38 PM Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> Hynek, sometimes @scrollbar.orientation()@ returns incorrect value: for example HORIZONTAL whe...
Hynek Cihlar
01:30 PM Bug #2849: implement and/or fix the default popup menus for all widgets
Hynek, sometimes @scrollbar.orientation()@ returns incorrect value: for example HORIZONTAL when I'm clicking on a ver... Vadim Gindin
12:27 PM Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > I can't locate @ScrollBarGuiImpl.getButtonSize()@, is this a new meth...
Hynek Cihlar
11:52 AM Bug #2849: implement and/or fix the default popup menus for all widgets
Hynek Cihlar wrote:
> I can't locate @ScrollBarGuiImpl.getButtonSize()@, is this a new method in your working copy?
...
Vadim Gindin
07:43 AM Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> Thank you Hynek!
>
> > Do you mean to create the methods?
> I meant existing methods @Scro...
Hynek Cihlar
03:41 PM Bug #2795: scoped variables/tables/etc and persistent procedures
Rebased 2795a from trunk rev -10965- 10966. new rev 10989
testing again to clean some false negatives.
Constantin Asofiei
02:25 PM Bug #2928: non-localhost testing and fixes
Planning to check it today. Sergey Ivanovskiy
09:32 AM Bug #2928: non-localhost testing and fixes
Please do check it on a different VM and report the results here. Try the VM with IE11 on Windows 8.1. Greg Shah
08:14 AM Bug #2928: non-localhost testing and fixes
> I don't understand. It seems like there is a real problem that still needs to be resolved.
I would like if it is ...
Sergey Ivanovskiy
08:03 AM Bug #2928: non-localhost testing and fixes
I don't understand. It seems like there is a real problem that still needs to be resolved. Greg Shah
01:46 AM Bug #2928: non-localhost testing and fixes
No, I mean that it is still reproduced in my environment: Window 7 Service Pack 1 with the limited evaluation period. Sergey Ivanovskiy
01:22 PM Bug #2971: rework tooltip support to use OverlayWindow
Tooltips must be contained in an @OverlayWindow@ so that their contents can draw outside of the bounds of the "real" ... Greg Shah
01:21 PM Bug #2971 (Closed): rework tooltip support to use OverlayWindow
Greg Shah
01:22 PM Bug #2837 (Closed): GUI combo-box drop-down needs to be able to draw outside of it's containing t...
Greg Shah
01:21 PM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
I've created #2971 for reworking the tooltip support to use @OverlayWindow@. Greg Shah
01:20 PM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Yes, I was worried that might be the case. I'll make a new task for it. Greg Shah
12:17 PM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Greg Shah wrote:
> Before we close this task, would you please check if tooltips also need this support? I hope not...
Eugenie Lyzenko
11:50 AM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Greg Shah wrote:
> Before we close this task, would you please check if tooltips also need this support? I hope not...
Eugenie Lyzenko
11:46 AM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
I have created #2970 for implementing @OverlayWindow@ in menus and popup menus.
Before we close this task, would y...
Greg Shah
11:29 AM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Greg Shah wrote:
> You can merge to trunk.
Branch @2837b@ was merged to trunk as revno @10966@ then it was archived.
Eugenie Lyzenko
11:20 AM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
You can merge to trunk. Greg Shah
11:13 AM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
The testing completed without regression. Had to run @CTRL-C@ 3-way tests in separate session. The results - @2837b_1... Eugenie Lyzenko
07:33 AM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
The main part completed without regressions. Running the @CTRL-C@ tests. Eugenie Lyzenko
11:47 AM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Rebased task branch @2612b@ from P2J trunk revision @10966@, new branch revision is @10967@. Eugenie Lyzenko
11:44 AM Bug #2970: rework menus to use OverlayWindow
Sub-menus and popup menus must be contained in an @OverlayWindow@ so that their contents can draw outside of the boun... Greg Shah
11:42 AM Bug #2970 (Closed): rework menus to use OverlayWindow
Greg Shah
10:48 AM Bug #2911: Fix extra background shown for popup_ext.p
There is this code in SwingEmulatedWindow:973:... Constantin Asofiei
08:51 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Igor Skornyakov wrote:
> > Also, how is @parent@ involved for cursor processing? The way I see it, the @cursor@ shou...
Constantin Asofiei
08:37 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > The WebGUI logic based on mouseActions should be substantial...
Igor Skornyakov
08:30 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Igor Skornyakov wrote:
> The WebGUI logic based on mouseActions should be substantially re-worked.
> 1. The MouseEd...
Constantin Asofiei
03:41 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
The WebGUI logic based on mouseActions should be substantially re-worked.
1. The MouseEditable JS object state shoul...
Igor Skornyakov
06:45 AM Support #2675: list of differences between the web GUI client and the original 4GL Windows GUI en...
Firefox doesn't generate key events for some simultaneously pressed keys if the left and right control are hold. For ... Sergey Ivanovskiy

01/25/2016

05:37 PM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Greg Shah wrote:
> Hynek: Please add a note to #2956 with your concern and your recommended approach.
The concern...
Hynek Cihlar
05:37 PM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Hynek Cihlar wrote:
> Greg Shah wrote:
> > Hynek: If I understand correctly, your only remaining concern is the fol...
Hynek Cihlar
04:52 PM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Hynek: Please add a note to #2956 with your concern and your recommended approach. Greg Shah
04:51 PM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Greg Shah wrote:
> Hynek: If I understand correctly, your only remaining concern is the following:
Yes.
>
> ...
Hynek Cihlar
02:28 PM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Greg Shah wrote:
>
> Please go ahead with regression testing. Post your results here. Wait for my confirmation b...
Eugenie Lyzenko
12:52 PM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Greg Shah wrote:
> > In any case I believe we should keep the behavior of all drivers consistent. If Web GUI driver ...
Eugenie Lyzenko
12:49 PM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Hynek: If I understand correctly, your only remaining concern is the following:
> In any case I believe we should ...
Greg Shah
12:48 PM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Code Review Task Branch 2837b Revision 10977
I'm fine with the change.
Please go ahead with regression testing....
Greg Shah
12:34 PM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Rebased task branch @2837b@ from trunk revision @10965@, new branch revision is @10977@.
Hynek, the branch is now ...
Eugenie Lyzenko
12:13 PM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Task branch @2837b@ for review updated to revision @10976@.
This update fixes the issue for two combo-boxes openin...
Eugenie Lyzenko
07:39 AM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Code Review Task Branch 2837b Revision 10975
I'm fine with the changes.
Greg Shah
07:23 PM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Task branch @2837b@ for review updated to revision @10975@.
Notes resolution for @instanceof OverlayWindow@ usage ...
Eugenie Lyzenko
05:26 PM Bug #2928: non-localhost testing and fixes
> but this issue could be reproduced with new generated self-signed certificate with SHA-2 and 2048-bit key length in... Greg Shah
04:19 PM Bug #2928: non-localhost testing and fixes
It seems that there are no new issues. #note-43 Constantin didn't reproduce the IE connection issue, but this issue c... Sergey Ivanovskiy
04:08 PM Bug #2928: non-localhost testing and fixes
Are there any issues still open in this task?
If not, is there any further testing needed or is this ready to close?
Greg Shah
05:20 PM Bug #2969: websocket keep-alive
Currently there is an idle timeout for the websocket. We need to add a keep-alive sequence, otherwise a long-lived s... Greg Shah
05:16 PM Bug #2969 (Closed): websocket keep-alive
Greg Shah
05:16 PM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
Put changes in 1811t. Greg Shah
05:16 PM Bug #2968 (Closed): disconnect/reconnect and manual reload must re-establish the websocket connec...
Greg Shah
05:13 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
Put the fix for this into branch 1811t. Greg Shah
05:13 PM Feature #2967 (Closed): web socket message sizes are limited to 32K, make sure that drawing ops a...
Greg Shah
04:15 PM Bug #2809: implement missing behaviour related to HIDDEN attribute
Greg Shah wrote:
> Can you provide an estimate of how much work is left here?
What I need is to check how DIALOG:HI...
Constantin Asofiei
09:12 AM Bug #2809: implement missing behaviour related to HIDDEN attribute
Can you provide an estimate of how much work is left here? Greg Shah
04:07 PM Bug #2930 (Closed): test IE browser support
Please add any additional found key exclusions to #2675. Greg Shah
04:06 PM Bug #2930: test IE browser support
From Sergey:
Propose to close the tasks 2929 and 2930 and to support only the required keys combinations for the c...
Greg Shah
04:06 PM Bug #2929: test chrome browser support
Please add any additional found key exclusions (e.g. CTRL + CTRL + Z) to #2675. Greg Shah
04:04 PM Bug #2929 (Closed): test chrome browser support
Greg Shah
03:57 PM Bug #2929: test chrome browser support
Committed revision 10987 fixes CTRL + CTRL + key with the exception set. For example, if we press left and right cont... Sergey Ivanovskiy
11:33 AM Bug #2929: test chrome browser support
> You are talking about the keydown events here? I assume the keypress event generates the correct character, but th... Sergey Ivanovskiy
08:39 AM Bug #2929: test chrome browser support
You are talking about the keydown events here? I assume the keypress event generates the correct character, but this... Greg Shah
03:17 AM Bug #2929: test chrome browser support
> Let me know when you believe your testing is complete.
I think that Chrome differences is fixed in general with po...
Sergey Ivanovskiy
03:59 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Task branch @2612b@ for review updated to revision @10966@.
This is the fix for conversion support of the dynamic ...
Eugenie Lyzenko
01:26 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Rebased task branch @2612b@ from P2J trunk revision @10965@, still no changes from trunk. Eugenie Lyzenko
03:12 PM Bug #2953: WinKeyboardReader should clear the key modifiers when P2J window deactivated by keyboa...
From Sergey:
Committed revision 10984 is fixed the issue, for the web Alt + Tab can be handled properly because th...
Greg Shah
01:40 PM Bug #2953 (Closed): WinKeyboardReader should clear the key modifiers when P2J window deactivated ...
Greg Shah
01:42 PM Bug #2795: scoped variables/tables/etc and persistent procedures
Greg Shah wrote:
> Constantin: Please rebase from the latest trunk and put this through regression testing.
Rebased...
Constantin Asofiei
01:26 PM Bug #2795: scoped variables/tables/etc and persistent procedures
Constantin: Please rebase from the latest trunk and put this through regression testing.
If it passes testing, ple...
Greg Shah
10:29 AM Bug #2795: scoped variables/tables/etc and persistent procedures
Note that the unexpected scroll bars issue in @User Defined Alerts@ window is solved by #2038, task branch 2038b. Hynek Cihlar
10:27 AM Bug #2795: scoped variables/tables/etc and persistent procedures
Greg Shah wrote:
> > I have fixed this particular case, but there is more code like this that needs to be fixed.
>...
Hynek Cihlar
09:11 AM Bug #2795: scoped variables/tables/etc and persistent procedures
> I have fixed this particular case, but there is more code like this that needs to be fixed.
You have fixed this...
Greg Shah
01:00 PM Bug #2849: implement and/or fix the default popup menus for all widgets
Thank you Hynek!
> Do you mean to create the methods?
I meant existing methods @ScrollBarGuiImpl.getButtonSize()@...
Vadim Gindin
12:41 PM Feature #2564: implement GUI BROWSE widget
It seems (from the following article) that the attribute only causes the events to be generated in response to a mous... Greg Shah
12:00 PM Feature #2564: implement GUI BROWSE widget
> Check if this is the same as #2959.
The behavior described in this task is _disabled_ if ALLOW-COLUMN-SEARCHING is...
Stanislav Lomany
11:26 AM Feature #2564: implement GUI BROWSE widget
> ALLOW-COLUMN-SEARCHING - Requires search ability (whatever this means).
Check if this is the same as #2959.
>...
Greg Shah
09:57 AM Feature #2564: implement GUI BROWSE widget
> It is my understanding that the row deletion support is complete. This means that the remaining critical browse ed... Stanislav Lomany
09:31 AM Feature #2564: implement GUI BROWSE widget
It is my understanding that the row deletion support is complete. This means that the remaining critical browse edit... Greg Shah
12:30 PM Bug #2911: Fix extra background shown for popup_ext.p
Constantin Asofiei wrote:
> Vadim, what is the state of the current solution? Do you still have problems?
Yes. The p...
Vadim Gindin
12:25 PM Bug #2911: Fix extra background shown for popup_ext.p
Vadim, what is the state of the current solution? Do you still have problems? Constantin Asofiei
12:04 PM Bug #2911: Fix extra background shown for popup_ext.p
Greg Shah wrote:
> As soon as 2909b is merged to trunk, please rebase 2911a.
The branch 2911a is rebased. Current...
Vadim Gindin
11:32 AM Bug #2911: Fix extra background shown for popup_ext.p
As soon as 2909b is merged to trunk, please rebase 2911a. Greg Shah
12:26 PM Feature #1801: add some frame options
Greg Shah wrote:
> Is it a reasonable expectation to have this checked in by Friday evening?
Yes.
Hynek Cihlar
12:24 PM Feature #1801: add some frame options
Is it a reasonable expectation to have this checked in by Friday evening? Greg Shah
12:15 PM Feature #1801: add some frame options
Greg Shah wrote:
> What is the level of risk?
I think the risk is at low to moderate level.
Hynek Cihlar
11:33 AM Feature #1801: add some frame options
What is the level of risk? Greg Shah
10:03 AM Feature #1801: add some frame options
In progress issues:
1. Improve runtime support for @BOX@ attribute for @DIALOG-BOX@.
This is the cause of the une...
Hynek Cihlar
04:41 AM Feature #1801: add some frame options
Rebased task branch 2038b from P2J trunk revision 10964 (new branch revision 10966). Hynek Cihlar
12:16 PM Bug #2909 (Closed): Fix key navigation for popup_ext.p
Greg Shah
11:51 AM Bug #2909: Fix key navigation for popup_ext.p
The branch 2909b is merged into trunk and committed as bzr revision #10965. Vadim Gindin
11:28 AM Bug #2909: Fix key navigation for popup_ext.p
Please merge task branch 2909b revision 10969 to trunk and then archive 2909b (normal archive as completed).
Ple...
Greg Shah
11:11 AM Bug #2909: Fix key navigation for popup_ext.p
> By the way EmulatedWindowState is also write a lot of debug info to System.err. Does it really needed or we can rem... Greg Shah
10:54 AM Bug #2909: Fix key navigation for popup_ext.p
Done. By the way @EmulatedWindowState@ is also write a lot of debug info to @System.err@. Does it really needed or we... Vadim Gindin
10:27 AM Bug #2909: Fix key navigation for popup_ext.p
Vadi, you still have TODO's and commented code (like @/* !oldFocus.isEnabled()*/@) in ThinClient and FocusManager - p... Constantin Asofiei
09:19 AM Bug #2909: Fix key navigation for popup_ext.p
Greg Shah wrote:
> Code Review Task Branch 2909b Revision 10967
>
> The @MenuItem@ history entry just says "focus...
Vadim Gindin
08:46 AM Bug #2909: Fix key navigation for popup_ext.p
Code Review Task Branch 2909b Revision 10967
The @MenuItem@ history entry just says "focusTraversable() is.". I t...
Greg Shah
08:34 AM Bug #2909: Fix key navigation for popup_ext.p
I've fixed header and removed specified comment and debug code. Vadim Gindin
08:28 AM Bug #2909: Fix key navigation for popup_ext.p
Constantin Asofiei wrote:
> Review for 2909b rev 10966:
> * MenuItem: History entry says "Changed focusTraversable():...
Vadim Gindin
04:19 AM Bug #2909: Fix key navigation for popup_ext.p
Review for 2909b rev 10966:
* MenuItem: History entry says "Changed focusTraversable(): removed isEnabled() check." ...
Constantin Asofiei
02:11 AM Bug #2909: Fix key navigation for popup_ext.p
I've committed remarks fixes "javadoc fixes, history entry, removing debugging code". Branch revision 10966. Vadim Gindin
01:45 AM Bug #2909: Fix key navigation for popup_ext.p
I rerun full regression testing yesterday. Here are the failing tests: gso_269, tc_codes_employees_019, tc_job_002, t... Vadim Gindin
02:59 AM Bug #2964: fix key processing for web chui in Firefox, Chrome, IE and Safari
The current version has the following issue if the "keypress" event doesn't occur, than the Progress 4GL generated ke... Sergey Ivanovskiy

01/24/2016

10:29 AM Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > ..
> > You have to translate the mouse location to the logical scro...
Hynek Cihlar
09:31 AM Bug #2849: implement and/or fix the default popup menus for all widgets
Hynek Cihlar wrote:
> ..
> You have to translate the mouse location to the logical scroll bar position. This shoul...
Vadim Gindin
08:11 AM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Code Reivew Task Branch 2837b Revision 10973
This is certainly better.
However, instead of putting @instanceof ...
Greg Shah
05:21 AM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Eugenie Lyzenko wrote:
> Task branch @2837b@ for review updated to revision @10974@.
>
> Notes resolution.
>
>...
Hynek Cihlar
09:04 PM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Task branch @2837b@ for review updated to revision @10974@.
Notes resolution.
>(4) In WindowManager.activateWin...
Eugenie Lyzenko
07:15 PM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Eugenie Lyzenko wrote:
> >(1) TopLevelWindow.processEvent() sends LEAVE event to the main window when overlay window...
Hynek Cihlar
07:24 AM Bug #2909: Fix key navigation for popup_ext.p
> What does it mean?
That test is dependent upon a mutex semaphore that doesn't exist. It isn't compatible with r...
Greg Shah
07:16 AM Bug #2909: Fix key navigation for popup_ext.p
Code Review Task Branch 2909b Revision 10965
This seems to be a much smarter approach.
Constantin: please revie...
Greg Shah
07:08 AM Bug #2909: Fix key navigation for popup_ext.p
I've manually checked these tests using run_single.sh script and manually running the client. Here are the results:
...
Vadim Gindin
06:12 AM Bug #2909: Fix key navigation for popup_ext.p
> tc_job_002, tc_po_item_003
These are known issues, not your regressions.
> gso_375, gso_430, tc_codes_employe...
Greg Shah
04:53 AM Bug #2909: Fix key navigation for popup_ext.p
I've made new solution. See branch 2909b. I've added new method @navigable()@ to @Widget@ that saves old implementati... Vadim Gindin
07:21 PM Bug #2795: scoped variables/tables/etc and persistent procedures
Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > Greg Shah wrote:
> > > Hynek: It was my understanding that both of t...
Hynek Cihlar

01/23/2016

06:53 PM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
>(1) TopLevelWindow.processEvent() sends LEAVE event to the main window when overlay window is activated, it should n... Eugenie Lyzenko
06:32 PM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Hynek Cihlar wrote:
>
> In revision 10973 I don't see any references to @GuiDriver.isWindowActive()@. What code a...
Eugenie Lyzenko
06:19 PM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Eugenie Lyzenko wrote:
> >(5) When you moved caching of active window to WindowManager it is no longer needed in Gui...
Hynek Cihlar
06:01 PM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
>(5) When you moved caching of active window to WindowManager it is no longer needed in GuiWebDriver. GuiWebDriver.ac... Eugenie Lyzenko
05:18 PM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Task branch @2837b@ for review updated to revision @10973@.
The event processing code for deactivation has been mo...
Eugenie Lyzenko
04:56 PM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Code Review Task branch 2837b Revision 10972.
(1) @TopLevelWindow.processEvent()@ sends LEAVE event to the main wi...
Hynek Cihlar
07:28 AM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Code Review Task branch 2837b Revision 10971
I think the changes are moving in the right direction.
My only con...
Greg Shah
05:09 AM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Eugenie Lyzenko wrote:
> So the only issue I can see in with current drop-down/overlay implementation is the issue w...
Hynek Cihlar
06:29 AM Feature #2560 (Closed): implement GUI DIALOG-BOX support
Any remaining issues are being resolved in other tasks. Greg Shah
 

Also available in: Atom