Project

General

Profile

Activity

From 06/28/2017 to 07/27/2017

07/28/2017

10:42 PM Feature #1834: implement direct manipulation (drag and drop)
Greg Shah wrote:
> > I think need to find a way to avoid or minimize it because using instanceof means poor design ... Eugenie Lyzenko

07/27/2017

04:12 PM Feature #1834: implement direct manipulation (drag and drop)
> I think need to find a way to avoid or minimize it because using instanceof means poor design may be.
Agreed. ... Greg Shah
03:54 PM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834a@ has been updated for review to revision @11188@.
This is the fix for class cast exception ... Eugenie Lyzenko
10:35 PM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834a@ has been updated for review to revision @11187@.
The update includes row resize feature co... Eugenie Lyzenko

07/26/2017

08:23 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
Please note that Ovidiu has handled the conversion parts of SYSTEM-DIALOG-PRINTER-SETUP in #3313 (see branch 1830a). ... Greg Shah
10:47 PM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834a@ has been updated for review to revision @11186@.
The update makes preparation steps for ap... Eugenie Lyzenko

07/25/2017

01:37 PM Feature #3275: improve browse support
Greg Shah wrote:
> Eric did the most recent validation processing implementation including the more sophisticated ap... Eric Faulhaber
01:32 PM Feature #3275: improve browse support
> I just don't like the idea adding something that will be deleted later and wondering if I'm missing some lexer capa... Greg Shah
12:43 PM Feature #3275: improve browse support
> Are you simply suggesting that the only change would be @very early in rules processing delete validation statement... Stanislav Lomany
12:36 PM Feature #3275: improve browse support
Eric did the most recent validation processing implementation including the more sophisticated approach.
Are you s... Greg Shah
12:32 PM Feature #3275: improve browse support
Greg, consider the case of validation for @DISPLAY .. ENABLE ALL@ case. During processing of @ENABLE field@ we attach... Stanislav Lomany
01:16 PM Feature #1834: implement direct manipulation (drag and drop)
Yep, I have _a lot_ of browse changes to commit, and I don't know how to coordinate other that committing it first. E... Stanislav Lomany
04:17 AM Feature #1834: implement direct manipulation (drag and drop)
Stanislav: Please review this task so that you are aware of the changes Eugenie is making that are browse related. I... Greg Shah
10:11 PM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834a@ has been updated for review to revision @11185@.
This update makes first steps for impleme... Eugenie Lyzenko

07/24/2017

03:46 PM Feature #1827: implement a replacement for the Windows help viewer
I did not post the content from note 7 because it seems that all options are in fact some kind of primitives to commu... Ovidiu Maxiniuc
01:27 PM Feature #1827: implement a replacement for the Windows help viewer
I'm generally OK with this approach. The code currently has a partially stubbed conversion that is not as good as yo... Greg Shah
01:19 PM Feature #1827: implement a replacement for the Windows help viewer
Ovidiu's proposal for this code:... Greg Shah
10:12 AM Feature #1827: implement a replacement for the Windows help viewer
> Apparently the HEIGHT is interpreted as KW_HEIGHT_C, instead as KW_HEIGHT, as the parser expects. The WIDTH seems t... Greg Shah
09:46 AM Feature #1827 (WIP): implement a replacement for the Windows help viewer
While working on adding conversion support I discovered an issue with @POSITION@ syntax of the @SYSTEM-HELP@ statemen... Ovidiu Maxiniuc
09:36 AM Feature #3289: implement SYSTEM-DIALOG-GET-DIR
> I can unify the paradigm of file/dir chooser dialogs with the other system dialogs. I kept the c'tor as the head of... Greg Shah
09:30 AM Feature #3289: implement SYSTEM-DIALOG-GET-DIR
From Ovidiu:
> I can unify the paradigm of file/dir chooser dialogs with the other system dialogs. I kept the c'to... Greg Shah
09:30 AM Feature #3289: implement SYSTEM-DIALOG-GET-DIR
1. I prefer the static SomeClass.create*Dialog() + chaining approach over than the constructor + chaining approach. ... Greg Shah
09:20 AM Feature #3289 (WIP): implement SYSTEM-DIALOG-GET-DIR
Added conversion support in task branch 1830a, revision 11159.
The full-syntax construct like this:... Ovidiu Maxiniuc
09:28 AM Feature #3313: implement SYSTEM-DIALOG-PRINTER-SETUP
I like the approach. Go ahead with this. Greg Shah
09:23 AM Feature #3313 (WIP): implement SYSTEM-DIALOG-PRINTER-SETUP
Added conversion support in task branch 1830a, revision 11159.
The full-syntax construct like this:... Ovidiu Maxiniuc
09:22 AM Feature #3313 (Closed): implement SYSTEM-DIALOG-PRINTER-SETUP
Ovidiu Maxiniuc
09:18 AM Feature #3290: implement SYSTEM-DIALOG-FONT
I like the approach. Go ahead with this. Greg Shah
08:56 AM Feature #3290 (WIP): implement SYSTEM-DIALOG-FONT
Added conversion support in task branch 1830a, revision 11159.
The full-syntax construct like this:... Ovidiu Maxiniuc
08:52 AM Feature #3291: implement SYSTEM-DIALOG-COLOR
It looks good. Go ahead with this approach. Greg Shah
08:51 AM Feature #3291 (WIP): implement SYSTEM-DIALOG-COLOR
Added conversion support in task branch 1830a, revision 11159.
The full-syntax construct like this:... Ovidiu Maxiniuc

07/22/2017

06:46 PM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834a@ has been updated for review to revision @11184@.
This is the fix for @END-BOX-SELECTION@ p... Eugenie Lyzenko
10:13 PM Feature #1834: implement direct manipulation (drag and drop)
The more testing discovered new issue with @END-BOX-SELECTION@ approach currently implemented. On the time the event ... Eugenie Lyzenko
09:06 PM Feature #1834: implement direct manipulation (drag and drop)
The testcases repo has been updated to revision @1627@.
Two new testcases added to investigate and properly implem... Eugenie Lyzenko

07/21/2017

02:10 PM Feature #3282: create a 4GL language extension to control screen refresh
Code Review Task Branch 3282a Revision 11156
1. The gap analysis marking in @rules/gaps/lang_stmts.rules@ will not... Greg Shah
10:28 PM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834a@ has been updated for review to revision @11182@.
Some unification and optimization was per... Eugenie Lyzenko

07/20/2017

09:59 PM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834a@ has been updated for review to revision @11181@.
Adding runtime implementation for @GRID-S... Eugenie Lyzenko

07/19/2017

05:03 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
I agree, the approach is reasonable. Greg Shah
04:30 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
Conversion finished. At this moment, a code like:... Ovidiu Maxiniuc
01:37 PM Feature #1834: implement direct manipulation (drag and drop)
The note "77":https://proj.goldencode.com/issues/1834#note-77 has been updated to reflect new findings. Eugenie Lyzenko
10:38 AM Feature #1834: implement direct manipulation (drag and drop)
The testcases repo has been updated to revision @1625@. Added another test(@uast/drag_n_drop/dnd_test0_1.p@) to inves... Eugenie Lyzenko
08:51 PM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834a@ has been updated for review to revision @11180@.
Added real handling for @MOVE/RESIZE@ eve... Eugenie Lyzenko
11:01 AM Feature #3280: implement editor methods
I added @uast/combo_box/combo_box20_2.p@ as revision 1626 in testcases. Use this to see the regression in both GUI an... Ovidiu Maxiniuc
11:00 AM Feature #3280: implement editor methods
Agreed. Greg Shah
10:37 AM Feature #3280: implement editor methods
Ovidiu Maxiniuc wrote:
> Eugenie Lyzenko wrote:
> > I'm OK with changes. Just to make sure the @FORMAT "x(1)"@ regr... Eugenie Lyzenko
10:25 AM Feature #3280: implement editor methods
Eugenie Lyzenko wrote:
> I'm OK with changes. Just to make sure the @FORMAT "x(1)"@ regression is not starting with ... Ovidiu Maxiniuc
10:59 AM Feature #1818: implement a timer service to replace the PSTimer OCX
Code Review Task Branch 1818a Revision 11162
I am generally OK with the changes.
>> 3. In common-progress.rules... Greg Shah

07/18/2017

06:00 PM Feature #3280: implement editor methods
Greg Shah wrote:
> Code Review Task Branch 3279a Revision 11167
>
> I'm fine with the changes.
>
> Unless Euge... Eugenie Lyzenko
05:53 PM Feature #3280: implement editor methods
Code Review Task Branch 3279a Revision 11167
I'm fine with the changes.
Unless Eugenie has any objections, I'm ... Greg Shah
05:56 PM Feature #3260: auto-conversion and enablement for the embedded web client
I like the approach. Greg Shah
05:51 PM Feature #3260: auto-conversion and enablement for the embedded web client
A status for the automation of embedded windows.
The solution I found to automate the generation of embedded windo... Constantin Asofiei
10:28 PM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834a@ has been updated for review to revision @11179@.
This update changes the implementation ap... Eugenie Lyzenko

07/16/2017

07:01 PM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834a@ has been updated for review to revision @11178@.
This is the fix for painting issue with n... Eugenie Lyzenko

07/15/2017

10:46 PM Feature #1834: implement direct manipulation (drag and drop)
Greg Shah wrote:
> Yes, please get it implemented to match the 4GL behavior including all of the event processing. ... Eugenie Lyzenko

07/14/2017

12:04 PM Feature #3275: improve browse support
> I suspect we need to dynamically convert the VALEXP/VALMSG from the schema at runtime ...
>
> The only real tric... Stanislav Lomany
11:47 PM Feature #1834: implement direct manipulation (drag and drop)
> I would suggest to go the way number 2 which is longer I guess. Just because I think we need to implement everythin... Greg Shah
09:19 PM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834a@ has been updated for review to revision @11176@.
The update fixes event priority issues an... Eugenie Lyzenko
09:09 PM Feature #1834: implement direct manipulation (drag and drop)
Greg,
Investigating next steps for implementing direct manipulation functionality I've got a point I need to discu... Eugenie Lyzenko

07/13/2017

03:15 PM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834a@ has been updated for review to revision @11175@.
Small bug fix for @11174@ update with wro... Eugenie Lyzenko
11:10 PM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834a@ has been updated for review to revision @11174@.
The update starts handling implementation... Eugenie Lyzenko

07/12/2017

04:40 PM Feature #3280: implement editor methods
Ovidiu Maxiniuc wrote:
> I found two testcases with SIMPLE comboboxes. After a few tests, the UI is just fine, the o... Eugenie Lyzenko
03:06 PM Feature #3280: implement editor methods
I found two testcases with SIMPLE comboboxes. After a few tests, the UI is just fine, the only differences are the fo... Ovidiu Maxiniuc
10:30 AM Feature #3280: implement editor methods
Greg Shah wrote:
> Eugenie: after the rebase, please do a code review. Focus on the combo-box changes.
I have tw... Eugenie Lyzenko
09:02 AM Feature #3280: implement editor methods
Revision 11165 above is based on trunk 11155. Ovidiu Maxiniuc
09:00 AM Feature #3280: implement editor methods
Greg Shah wrote:
> Eugenie: after the rebase, please do a code review. Focus on the combo-box changes.
OK. Eugenie Lyzenko
08:58 AM Feature #3280: implement editor methods
Please rebase the branch.
Eugenie: after the rebase, please do a code review. Focus on the combo-box changes. Greg Shah
08:44 AM Feature #3280: implement editor methods
The task branch 3279a was rebased and updated. Current revision 11165.
Greg Shah wrote:
> Code Review Task Branch... Ovidiu Maxiniuc
11:01 AM Feature #1834: implement direct manipulation (drag and drop)
Ovidiu Maxiniuc wrote:
> Just had an idea, I don't know how hard is to implement it.
> We can use a second, tempora... Eugenie Lyzenko
10:24 AM Feature #1834: implement direct manipulation (drag and drop)
Ovidiu Maxiniuc wrote:
> Just had an idea, I don't know how hard is to implement it.
> We can use a second, tempora... Sergey Ivanovskiy
10:19 AM Feature #1834: implement direct manipulation (drag and drop)
Related to the current status of the trunc 11155, all changes of the web client were described in merge notification ... Sergey Ivanovskiy
09:27 AM Feature #1834: implement direct manipulation (drag and drop)
Just had an idea, I don't know how hard is to implement it.
We can use a second, temporary transparent canvas in fro... Ovidiu Maxiniuc
09:14 AM Feature #1834: implement direct manipulation (drag and drop)
There is a @xor@ operation that make _Shapes are made transparent where both overlap and drawn normal everywhere else... Ovidiu Maxiniuc
08:57 AM Feature #1834: implement direct manipulation (drag and drop)
Sergey: Please see the recent notes in this task and comment. Greg Shah
08:47 AM Feature #1834: implement direct manipulation (drag and drop)
Ovidiu Maxiniuc wrote:
> Eugenie Lyzenko wrote:
> > I'm still hoping to find @JS@ analog of the @Java2D@ @setXORMod... Eugenie Lyzenko
06:16 AM Feature #1834: implement direct manipulation (drag and drop)
Eugenie Lyzenko wrote:
> I'm still hoping to find @JS@ analog of the @Java2D@ @setXORMode()@ implementation.
Euge... Ovidiu Maxiniuc
10:55 PM Feature #1834: implement direct manipulation (drag and drop)
Greg Shah wrote:
> From Eugenie:
>
> If you create the proper drawing/primitive APIs in the @GuiDriver@, then eac... Eugenie Lyzenko
05:15 AM Feature #3275: improve browse support
I took a look into customer's code and found that in one place non-string value is used as the initial value for @ADD... Stanislav Lomany

07/11/2017

09:54 AM Feature #1834: implement direct manipulation (drag and drop)
From Eugenie:
> The investigation for web client starting issues. The tests show additional subtasks for web clien... Greg Shah

07/10/2017

02:23 PM Feature #1834: implement direct manipulation (drag and drop)
> It it a bit strange. You need to set @webClient/virtualDesktopEnabled@ to @true@ in your @directory.xml@. For unkno... Greg Shah
01:23 PM Feature #1834: implement direct manipulation (drag and drop)
Eugenie Lyzenko wrote:
> Are you able to run standalone testcases with web client? The server directory is @simple/s... Eugenie Lyzenko
12:16 PM Feature #1834: implement direct manipulation (drag and drop)
Ovidiu Maxiniuc wrote:
> Eugenie Lyzenko wrote:
> > So can anyone clarify what is the status of the Web client for ... Eugenie Lyzenko
11:47 AM Feature #1834: implement direct manipulation (drag and drop)
Eugenie Lyzenko wrote:
> So can anyone clarify what is the status of the Web client for trunk @11155@?
It it a bit ... Ovidiu Maxiniuc
11:03 AM Feature #1834: implement direct manipulation (drag and drop)
Eugenie Lyzenko wrote:
> The @Classic@ theme is the base for all others, correct? If we implement some drawing in @C... Ovidiu Maxiniuc
10:32 AM Feature #1834: implement direct manipulation (drag and drop)
Ovidiu Maxiniuc wrote:
> From email conversation:
> On 07/06/2017 03:20 PM, Greg Shah wrote:
> > On 07/06/2017 08:... Eugenie Lyzenko
08:52 AM Feature #1834: implement direct manipulation (drag and drop)
From email conversation:
On 07/06/2017 03:20 PM, Greg Shah wrote:
> On 07/06/2017 08:06 AM, Eugenie V. Lyzenko wrot... Ovidiu Maxiniuc
09:11 AM Feature #2683: reverse proxy implementation
For external certificates @apache.crt@ issued by well-known authorities it is required to add @SSLCertificateChainFil... Sergey Ivanovskiy
08:19 AM Feature #3275: improve browse support
I guess the best way is to make the notification abstracted so that it is not browse specific, but in this case it wi... Greg Shah

07/09/2017

05:49 PM Feature #1834: implement direct manipulation (drag and drop)
This is the only log I have for web client with current trunk for hotel GUI.
Has anyone the same issue? I have add... Eugenie Lyzenko

07/08/2017

04:39 PM Feature #3275: improve browse support
> Don't we eventually need to store the state for synchronization to the client side? Can we store it as we go and th... Stanislav Lomany
01:48 PM Feature #3275: improve browse support
Don't we eventually need to store the state for synchronization to the client side? Can we store it as we go and the... Greg Shah
01:42 PM Feature #3275: improve browse support
Greg, I have a question about displaying browse intermediate state. The stack looks like... Stanislav Lomany
10:36 PM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834a@ has been updated for review to revision @11172@.
The update finished the notes resolution.... Eugenie Lyzenko

07/07/2017

08:57 PM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834a@ has been updated for review to revision @11171@.
This is the partial notes resolution. Add... Eugenie Lyzenko

07/06/2017

06:19 PM Feature #1834: implement direct manipulation (drag and drop)
Ovidiu Maxiniuc wrote:
> Eugenie Lyzenko wrote:
> > Ovidiu Maxiniuc wrote:
> > >Also, all rendering should be done... Eugenie Lyzenko
04:54 PM Feature #1834: implement direct manipulation (drag and drop)
Eugenie Lyzenko wrote:
> Ovidiu Maxiniuc wrote:
> >Also, all rendering should be done in DRAG, using overlaid XOR o... Ovidiu Maxiniuc
03:05 PM Feature #1834: implement direct manipulation (drag and drop)
Ovidiu Maxiniuc wrote:
> Review of 1834a/11169.
> # in @PaneConfig@: do we need to keep both @gridUnitHeightChars@ ... Eugenie Lyzenko
02:53 PM Feature #1834: implement direct manipulation (drag and drop)
Ovidiu Maxiniuc wrote:
>Also, all rendering should be done in DRAG, using overlaid XOR operation, twice: once using ... Eugenie Lyzenko
01:45 PM Feature #1834: implement direct manipulation (drag and drop)
Review of 1834a/11169.
Nice job! Please see my observation below:
# in the default @BrowseInterface.setRowResizable... Ovidiu Maxiniuc
11:55 AM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834a@ has been updated for review to revision @11170@.
Small update to handle default setting fo... Eugenie Lyzenko
10:47 PM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834a@ has been updated for review to revision @11169@.
This update adds support for frame grid d... Eugenie Lyzenko
05:25 PM Feature #2676: implement the equivalent to configurable support for a windows theme
Ovidiu Maxiniuc wrote:
> Something else bothers me: since r11153 (or so) when running with Win10/win8 themes, the cl... Eugenie Lyzenko
04:44 PM Feature #2676: implement the equivalent to configurable support for a windows theme
I finished running @uast/rectangle/*@ tests. I noted two issues:
# tests 6(1): the gap between the two rectangles is... Ovidiu Maxiniuc
09:40 AM Feature #2676: implement the equivalent to configurable support for a windows theme
Ovidiu Maxiniuc wrote:
> # the background colour of frames is rendered by @BorderedPanelGuiImpl@, see lines 233-251.... Eugenie Lyzenko
08:00 AM Feature #2676: implement the equivalent to configurable support for a windows theme
Ovidiu Maxiniuc wrote:
> Eugenie, indeed, there are a couple of issues regarding to frames, but they are not strictl... Eugenie Lyzenko
07:25 AM Feature #2676: implement the equivalent to configurable support for a windows theme
Eugenie, indeed, there are a couple of issues regarding to frames, but they are not strictly related to styles:
# no... Ovidiu Maxiniuc

07/05/2017

05:43 PM Feature #2676: implement the equivalent to configurable support for a windows theme
Ovidiu Maxiniuc wrote:
> Please let me know if you agree to the changes I committed to new branch 2676b (rev 11156).... Eugenie Lyzenko
05:03 PM Feature #2676: implement the equivalent to configurable support for a windows theme
Ovidiu Maxiniuc wrote:
> Eugenie, you were right, in some cases the line was not correctly drawn on Win8/10. I creat... Eugenie Lyzenko
03:56 PM Feature #2676: implement the equivalent to configurable support for a windows theme
Eugenie, you were right, in some cases the line was not correctly drawn on Win8/10. I created a complex testcase (see... Ovidiu Maxiniuc

07/04/2017

06:25 PM Feature #3275: improve browse support
Interesting enough, if SCREEN-VALUE was updated in ROW-DISPLAY trigger during search by key, the new value is used fo... Stanislav Lomany
03:55 PM Feature #2676: implement the equivalent to configurable support for a windows theme
Ovidiu Maxiniuc wrote:
> Eugenie, please provide the exact 4GL code for this, I will run it on Win8.1 machine and co... Eugenie Lyzenko
03:49 PM Feature #2676: implement the equivalent to configurable support for a windows theme
Eugenie, please provide the exact 4GL code for this, I will run it on Win8.1 machine and continue investigations.
Th... Ovidiu Maxiniuc
03:44 PM Feature #2676: implement the equivalent to configurable support for a windows theme
I agree, the buttons and other widgets look differently in Windows10 theme. But I do not think the GUI rectangle shou... Eugenie Lyzenko
01:20 PM Feature #2676: implement the equivalent to configurable support for a windows theme
2676a was merged to trunk as revision 11155. Test results and the branch itself were archived. Notification email was... Ovidiu Maxiniuc
08:59 AM Feature #2676: implement the equivalent to configurable support for a windows theme
Ovidiu, I'm OK with merging 2676a to trunk - no further testing is needed, as it doesn't collide with 11154 trunk. Constantin Asofiei
03:50 PM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834a@ has been rebased with current trunk @11155@, new revision is @11168@. Eugenie Lyzenko
10:34 PM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834a@ has been updated for review to revision @11167@.
Starting with this update the implementat... Eugenie Lyzenko
09:42 AM Feature #2683: reverse proxy implementation
Private and public root CA keys are stored in @root-ca-pk.store@ protected by store password and key entry password. ... Sergey Ivanovskiy

07/03/2017

09:24 AM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834a@ has been updated for review to revision @11166@.
Added javadoc fix for @ClientsToPortsGene... Eugenie Lyzenko
07:13 AM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834a@ has been rebased with current trunk @11154@, new revision is @11165@. Eugenie Lyzenko
05:54 AM Feature #3236: implement port range support for the web client's embedded web server
2683a was merged to trunk as revision 11154. Greg Shah
05:54 AM Feature #3236 (Closed): implement port range support for the web client's embedded web server
Greg Shah
05:53 AM Feature #2683: reverse proxy implementation
The task branch 2683a was merged into the trunc as rev. 11154 and archived. Sergey Ivanovskiy
04:17 AM Feature #2683: reverse proxy implementation
Please merge 2683a to trunk. Greg Shah
05:19 AM Feature #3275: improve browse support
> But I still think to keep the values in order to make less changes and for the case I'm missing something, they don... Greg Shah

07/01/2017

05:54 AM Feature #3236: implement port range support for the web client's embedded web server
Greg, I think I gave you the wrong password, and I need to re-generate them again - I get the same now (even from Ecl... Constantin Asofiei
12:12 AM Feature #3236: implement port range support for the web client's embedded web server
Greg, 2683a rev 11180 contains the certificate-related changes (and the chrome 'subject-alternate-name' fix, too). A... Constantin Asofiei
11:40 PM Feature #3236: implement port range support for the web client's embedded web server
There is this option @webClient/portsRange/forwardedHost@ that can be important to set in Amazon environment. (https:... Sergey Ivanovskiy
10:50 PM Feature #3236: implement port range support for the web client's embedded web server
Or we can pass it in as a parameter. Greg Shah
10:50 PM Feature #3236: implement port range support for the web client's embedded web server
Greg Shah wrote:
> Yes.
OK, then I'll need to save its encryption password for its private key in the directory. Constantin Asofiei
10:49 PM Feature #3236: implement port range support for the web client's embedded web server
Yes. Greg Shah
10:43 PM Feature #3236: implement port range support for the web client's embedded web server
Greg, I'm almost done with this: do you want to add 're-use root CA', too? Because otherwise this would need to be re... Constantin Asofiei
09:44 PM Feature #3236: implement port range support for the web client's embedded web server
> Otherwise I'll need to read the input from the arguments
Yes, let's make these arguments. I can pass them in as... Greg Shah
09:43 PM Feature #3236: implement port range support for the web client's embedded web server
Greg Shah wrote:
> I am already automatically updating the @directory.xml@ placeholders using the Ansible scripting.... Constantin Asofiei
09:38 PM Feature #3236: implement port range support for the web client's embedded web server
I am already automatically updating the @directory.xml@ placeholders using the Ansible scripting. We can add another... Greg Shah
09:33 PM Feature #3236: implement port range support for the web client's embedded web server
Greg Shah wrote:
> If we can provide the mechanism to regen the cert for an arbitrary hostname, then we can meet our... Constantin Asofiei
09:30 PM Feature #3236: implement port range support for the web client's embedded web server
Virtual desktop mode works in the POC. AND because of the port range support, I can get multiple simultaneous sessio... Greg Shah
09:25 PM Feature #3236: implement port range support for the web client's embedded web server
I'll test it now.
Please consider the cert re-gen issue. Greg Shah
09:22 PM Feature #3236: implement port range support for the web client's embedded web server
Greg Shah wrote:
> Are you OK with merging to trunk?
Yes, I don't see any issues.
> Also: I plan to enable virtu... Constantin Asofiei
09:15 PM Feature #3236: implement port range support for the web client's embedded web server
Also: I plan to enable virtual desktop in the poc directory. Is there any reason to disable it? Greg Shah
09:14 PM Feature #3236: implement port range support for the web client's embedded web server
Are you OK with merging to trunk? Greg Shah
09:07 PM Feature #3236: implement port range support for the web client's embedded web server
main part passed, too. Constantin Asofiei
09:24 PM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834a@ has been updated for review to revision @11164@.
This update starts visual effects impleme... Eugenie Lyzenko

06/30/2017

07:19 PM Feature #3236: implement port range support for the web client's embedded web server
Greg Shah wrote:
> Constantin: Is the ChUI regression testing still running?
CTRL-C I think is passed (cumulative, ... Constantin Asofiei
07:17 PM Feature #3236: implement port range support for the web client's embedded web server
Constantin: Is the ChUI regression testing still running? Greg Shah
07:16 PM Feature #3236: implement port range support for the web client's embedded web server
Planning to log out sooner. Sergey Ivanovskiy
07:07 PM Feature #3236: implement port range support for the web client's embedded web server
I followed https://www.digitalocean.com/community/tutorials/how-to-use-apache-http-server-as-reverse-proxy-using-mod_... Sergey Ivanovskiy
06:59 PM Feature #3236: implement port range support for the web client's embedded web server
I setup certificates for the FWD server and the embedded web server for demo.goldencode.com. Those just replaced the... Greg Shah
06:56 PM Feature #3236: implement port range support for the web client's embedded web server
Yes, I think it helps to fix embedded client's certificate issue. It seems that you wrote about it when preparing an ... Sergey Ivanovskiy
06:54 PM Feature #3236: implement port range support for the web client's embedded web server
Can't we just pass through the SSL of the FWD server's? We don't want to generate yet another certificate that is on... Greg Shah
06:49 PM Feature #3236: implement port range support for the web client's embedded web server
At first it is required to create ssl virtual host and it seems that I followed this article https://www.digitalocean... Sergey Ivanovskiy
06:45 PM Feature #3236: implement port range support for the web client's embedded web server
openssl package must be installed. Sergey Ivanovskiy
06:43 PM Feature #3236: implement port range support for the web client's embedded web server
Greg Shah wrote:
> Do all of these get installed with the @apache2@ package?
I am not sure, but it seems that the... Sergey Ivanovskiy
06:34 PM Feature #3236: implement port range support for the web client's embedded web server
Do all of these get installed with the @apache2@ package? Greg Shah
06:30 PM Feature #3236: implement port range support for the web client's embedded web server
Please notice modules that enabled by site administrator. All these modules must be installed if you would like to ge... Sergey Ivanovskiy
06:27 PM Feature #3236: implement port range support for the web client's embedded web server
Also after your configuration has been done, you can check the installed modules by running... Sergey Ivanovskiy
06:19 PM Feature #3236: implement port range support for the web client's embedded web server
Committed revision 55 modified poc directory.xml. Sergey Ivanovskiy
06:18 PM Feature #3236: implement port range support for the web client's embedded web server
Please look at these resources:
1)
https://www.digitalocean.com/community/tutorials/how-to-install-linux-apache-my... Sergey Ivanovskiy
05:35 PM Feature #3236: implement port range support for the web client's embedded web server
Also, please update the directory.xml to have the right ACL and the new port range support for 10 clients.
Include... Greg Shah
05:31 PM Feature #3236: implement port range support for the web client's embedded web server
Yes.
I'm about to work on that next.
Please make a list of the following:
1. Packages to install to get Apac... Greg Shah
05:08 PM Feature #3236: implement port range support for the web client's embedded web server
Do you need my help with Apache configuration? Sergey Ivanovskiy
05:03 PM Feature #3236: implement port range support for the web client's embedded web server
Don't mind, I found REDACTED/REDACTED Sergey Ivanovskiy
05:00 PM Feature #3236: implement port range support for the web client's embedded web server
Greg Shah wrote:
> Can you check in your changes to the POC embedded code?
It doesn't need to change the source c... Sergey Ivanovskiy
04:54 PM Feature #3236: implement port range support for the web client's embedded web server
Can you check in your changes to the POC embedded code? Greg Shah
04:48 PM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> Greg, Constantin these changes work with the Apache configuration provided by note 152, I... Sergey Ivanovskiy
04:37 PM Feature #3236: implement port range support for the web client's embedded web server
Greg Shah wrote:
> > It should be a problem, I would like to change a direct access to https://localhost:8443/embedd... Sergey Ivanovskiy
04:30 PM Feature #3236: implement port range support for the web client's embedded web server
> It should be a problem, I would like to change a direct access to https://localhost:8443/embedded
Go ahead. Greg Shah
04:29 PM Feature #3236: implement port range support for the web client's embedded web server
Thank you, the poc is built now. I forgot that the embedded client needs a direct access too, but I changed its root ... Sergey Ivanovskiy
04:05 PM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> Ok, but it worked on my host with Posgresql before that.
Hotel was setup for postgresq... Greg Shah
04:02 PM Feature #3236: implement port range support for the web client's embedded web server
Ok, but it worked on my host with Posgresql before that. Sergey Ivanovskiy
04:00 PM Feature #3236: implement port range support for the web client's embedded web server
Are you on revision 53 of the POC project? You are probably on rev 52 which was hard coded to PostgreSQL.
Try rev... Greg Shah
03:56 PM Feature #3236: implement port range support for the web client's embedded web server
I need help with poc setup, I run ant deploy.all and got ... Sergey Ivanovskiy
03:51 PM Feature #3236: implement port range support for the web client's embedded web server
It seems that there no another changes. I updated this poc and started postgresql server, now running ant deploy.all ... Sergey Ivanovskiy
03:46 PM Feature #3236: implement port range support for the web client's embedded web server
> It seems that a single fixed port is the same as dynamically allocated from a degraded port range. I didn't provide... Greg Shah
03:41 PM Feature #3236: implement port range support for the web client's embedded web server
Greg Shah wrote:
> Is there any remaining known issue with 2683a?
> I understand that the POC embedded code needs... Sergey Ivanovskiy
03:31 PM Feature #3236: implement port range support for the web client's embedded web server
Is there any remaining known issue with 2683a?
I understand that the POC embedded code needs changes. Is there an... Greg Shah
03:17 PM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> Greg Shah wrote:
> > Any code changes to embedded mode will need to be applied to the cu... Greg Shah
02:51 PM Feature #3236: implement port range support for the web client's embedded web server
Greg Shah wrote:
> Any code changes to embedded mode will need to be applied to the customer POC project too.
Gre... Sergey Ivanovskiy
01:52 PM Feature #3236: implement port range support for the web client's embedded web server
Greg, Constantin these changes work with the Apache configuration provided by note 152, I did not use HTML rewrite mo... Sergey Ivanovskiy
01:39 PM Feature #3236: implement port range support for the web client's embedded web server
Any code changes to embedded mode will need to be applied to the customer POC project too. Greg Shah
01:26 PM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> Yes, I understand, but there are no ways, we need to change index.html and ehotel.js. It ... Constantin Asofiei
01:20 PM Feature #3236: implement port range support for the web client's embedded web server
Yes, I understand, but there are no ways, we need to change index.html and ehotel.js. It should take into account win... Sergey Ivanovskiy
01:16 PM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> At first it needs to change dojo config that was set by index.html to
Are these changes ... Constantin Asofiei
01:10 PM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> Greg Shah wrote:
> > All access is through port 443 right? So that is the only port exp... Sergey Ivanovskiy
01:03 PM Feature #3236: implement port range support for the web client's embedded web server
Greg Shah wrote:
> All access is through port 443 right? So that is the only port exposed via the firewall?
>
> ... Sergey Ivanovskiy
01:00 PM Feature #3236: implement port range support for the web client's embedded web server
All access is through port 443 right? So that is the only port exposed via the firewall?
What are the starting UR... Greg Shah
12:58 PM Feature #3236: implement port range support for the web client's embedded web server
I guess that we need to fix dojo configuration settings.... Sergey Ivanovskiy
12:57 PM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> Greg, if you need to proxy this url https://localhost:8443/, then it should be added sepa... Sergey Ivanovskiy
12:57 PM Feature #3236: implement port range support for the web client's embedded web server
Yes, I will need to proxy both 8443 and 7443. 8443 is the really important one.
Is there anything else needed? Greg Shah
12:22 PM Feature #3236: implement port range support for the web client's embedded web server
Greg, if you need to proxy this url https://localhost:8443/, then it should be added separetely, like for this url ht... Sergey Ivanovskiy
12:18 PM Feature #3236: implement port range support for the web client's embedded web server
I just imported hotel server der certificate into Firefox and got embedded clients working properly. Sergey Ivanovskiy
12:00 PM Feature #3236: implement port range support for the web client's embedded web server
Added my default ssl configuration with a mapping file.... Sergey Ivanovskiy
11:33 AM Feature #3236: implement port range support for the web client's embedded web server
Committed revision 11179 fixed java docs. Sergey Ivanovskiy
11:24 AM Feature #3236: implement port range support for the web client's embedded web server
Committed revision 11178, sorry for delay, during tests found that nodes are not updated if it is necessarily to sati... Sergey Ivanovskiy
10:58 AM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> Can I commit com.goldencode.p2j.main.ClientsToPortsGenerator into 2683a?
Yes. Greg Shah
10:51 AM Feature #3236: implement port range support for the web client's embedded web server
Can I commit com.goldencode.p2j.main.ClientsToPortsGenerator into 2683a? Sergey Ivanovskiy
10:49 AM Feature #3236: implement port range support for the web client's embedded web server
The clients to ports mapping tool works properly, only it creates case insensitive node name like 'portsrange' instea... Sergey Ivanovskiy
10:28 AM Feature #3236: implement port range support for the web client's embedded web server
Thank you, I read docs and thought that @openBatch@ brackets are used only for security nodes. Sergey Ivanovskiy
10:26 AM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> Constantin, could you help with this. I will try to add node to the directory using direc... Constantin Asofiei
10:21 AM Feature #3236: implement port range support for the web client's embedded web server
Constantin, could you help with this. I will try to add node to the directory using directory API, is it a correct wa... Sergey Ivanovskiy
10:15 AM Feature #3236: implement port range support for the web client's embedded web server
But it will be great if the Apache environment manual tests will be approved and tested on the different host machine. Sergey Ivanovskiy
10:12 AM Feature #3236: implement port range support for the web client's embedded web server
Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > Thank you, I don't know that it seems that if the ports ra... Sergey Ivanovskiy
10:06 AM Feature #3236: implement port range support for the web client's embedded web server
Make sure that we are testing in 2 modes:
1. Through a reverse proxy.
2. Direct access. Greg Shah
10:05 AM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> Thank you, I don't know that it seems that if the ports range is restricted, then it can ... Constantin Asofiei
10:04 AM Feature #3236: implement port range support for the web client's embedded web server
Thank you, I don't know that it seems that if the ports range is restricted, then it can be a weak place. I tested wh... Sergey Ivanovskiy
09:58 AM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > Thanks, I need this help to run ... Hynek Cihlar
08:09 AM Feature #3236: implement port range support for the web client's embedded web server
Code Review Task branch 2683a Revision 11177
I like the changes.
I have only one question: is it possible to h... Greg Shah
08:06 AM Feature #3236: implement port range support for the web client's embedded web server
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Thanks, I need this help to run 2683a at least once manually wit... Sergey Ivanovskiy
08:02 AM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> Thanks, I need this help to run 2683a at least once manually with hotel_gui using the emb... Hynek Cihlar
08:00 AM Feature #3236: implement port range support for the web client's embedded web server
Thanks, I need this help to run 2683a at least once manually with hotel_gui using the embedded and web clients taking... Sergey Ivanovskiy
07:57 AM Feature #3236: implement port range support for the web client's embedded web server
Constantin: Thanks! Greg Shah
07:56 AM Feature #3236: implement port range support for the web client's embedded web server
Please run the ChUI regression testing immediately. The CTRL-C tests will be quite important. Greg Shah
07:55 AM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> I didn't run ChUI regression tests.
I'll start these now.
 Constantin Asofiei
07:55 AM Feature #3236: implement port range support for the web client's embedded web server
Greg Shah wrote:
> I don't know the answer to this. How critical is it to our delivery today?
>
> Can you provid... Sergey Ivanovskiy
07:45 AM Feature #3236: implement port range support for the web client's embedded web server
I don't know the answer to this. How critical is it to our delivery today?
Can you provide a status of things?
... Greg Shah
06:51 AM Feature #3236: implement port range support for the web client's embedded web server
Web sockets use keep-alive HTTP connections, but does it mean that they leave forever or there exists a default timeo... Sergey Ivanovskiy
06:35 AM Feature #3236: implement port range support for the web client's embedded web server
Looking into these ... Sergey Ivanovskiy
06:00 AM Feature #3236: implement port range support for the web client's embedded web server
I did not import CA into the browser, it seems that in the Firefox the icon looks like an orange triangle with an exc... Sergey Ivanovskiy
04:07 AM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> I removed
> [...]
> from these tested configurations in order to use the standard hot... Constantin Asofiei
01:30 AM Feature #3236: implement port range support for the web client's embedded web server
I removed ... Sergey Ivanovskiy
01:21 AM Feature #3236: implement port range support for the web client's embedded web server
I have the following issue with the embedded client, probably due to certificate issue.
If the port settings in the ... Sergey Ivanovskiy
03:27 PM Feature #2676: implement the equivalent to configurable support for a windows theme
I used the whole set of GUI demo scenarios to test the 11172, comparing in parallel, the ABL on dedicated server, dif... Ovidiu Maxiniuc
01:02 PM Bug #3306: Improve intermediate state in ROW-DISPLAY trigger.
In addition, logic of Page Up, Page Down keys and search by key should be modified in order to match 4GL ROW-DISPLAY ... Stanislav Lomany
09:46 PM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834a@ has been updated for review to revision @11163@.
This is the base skeleton functionality a... Eugenie Lyzenko

06/29/2017

05:15 PM Feature #3236: implement port range support for the web client's embedded web server
Yes. Greg Shah
04:51 PM Feature #3236: implement port range support for the web client's embedded web server
It works now, thank you, I just copied @WebClientLauncher@ section and replaced it with @WebClientRegistrar@. Are the... Sergey Ivanovskiy
04:30 PM Feature #3236: implement port range support for the web client's embedded web server
This is an ACL issue. In @/security/acl/net/@ you need to add a section for @WebClientRegistrar@ to allow access to ... Greg Shah
04:16 PM Feature #3236: implement port range support for the web client's embedded web server
Thank you :), I rerun with 2683a and found that client logs are rewritten.... Sergey Ivanovskiy
04:05 PM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> Thank you, I see here only logs for P2J trunc's web client, so the embedded server was no... Hynek Cihlar
04:00 PM Feature #3236: implement port range support for the web client's embedded web server
Thank you, I see here only logs for P2J trunc's web client, so the embedded server was not started at all and the spa... Sergey Ivanovskiy
03:57 PM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> Sergey Ivanovskiy wrote:
> > I have problems with hotel_gui, and investigating them now.... Hynek Cihlar
03:53 PM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> I have problems with hotel_gui, and investigating them now.
It seems that the spawned pr... Sergey Ivanovskiy
02:29 PM Feature #3236: implement port range support for the web client's embedded web server
I have problems with hotel_gui, and investigating them now. Sergey Ivanovskiy
11:02 AM Feature #3236: implement port range support for the web client's embedded web server
You are right, it is an issue. Sergey Ivanovskiy
11:01 AM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > Yes, but it is required to wait ... Hynek Cihlar
10:58 AM Feature #3236: implement port range support for the web client's embedded web server
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Yes, but it is required to wait until requests timeout is passed... Sergey Ivanovskiy
10:57 AM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> Yes, but it is required to wait until requests timeout is passed. Committed revision 1117... Hynek Cihlar
10:48 AM Feature #3236: implement port range support for the web client's embedded web server
Yes, but it is required to wait until requests timeout is passed. Committed revision 11175 fixed this strict synchron... Sergey Ivanovskiy
10:39 AM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> The considered issue is that if all ports are used by the clients and new one user is try... Hynek Cihlar
10:27 AM Feature #3236: implement port range support for the web client's embedded web server
The considered issue is that if all ports are used by the clients and new one user is trying to get a client, then it... Sergey Ivanovskiy
08:59 AM Feature #3236: implement port range support for the web client's embedded web server
The manual GUI and regression testing are in process now, but the current code has some unknown issue and it should b... Sergey Ivanovskiy
08:45 AM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> They are present. Please look at these changes
> [...]
Please use a logger and not @Sys... Constantin Asofiei
08:40 AM Feature #3236: implement port range support for the web client's embedded web server
Sorry, I didn't look carefully enough.
What about the readiness for regression/GUI testing? Greg Shah
08:38 AM Feature #3236: implement port range support for the web client's embedded web server
Greg Shah wrote:
> > Committed revision 11173 fixed these trivial issues.
>
> I don't see any new javadoc for Con... Sergey Ivanovskiy
08:34 AM Feature #3236: implement port range support for the web client's embedded web server
> Committed revision 11173 fixed these trivial issues.
I don't see any new javadoc for Constantin's request in not... Greg Shah
08:29 AM Feature #3236: implement port range support for the web client's embedded web server
I am using the default @/etc/apache2/sites-available/default-ssl.conf@.... Sergey Ivanovskiy
08:22 AM Feature #3236: implement port range support for the web client's embedded web server
Greg Shah wrote:
> Sergey: Please finish item 6 in #3236-92 and handle #3236-95. These should be trivial.
Committe... Sergey Ivanovskiy
08:11 AM Feature #3236: implement port range support for the web client's embedded web server
Sergey: Please finish item 6 in #3236-92 and handle #3236-95. These should be trivial.
I do need you utility prog... Greg Shah
08:10 AM Feature #3236: implement port range support for the web client's embedded web server
Committed revision 11173 fixed all found issues, but now I am investigating the case when all two ports are used and ... Sergey Ivanovskiy
06:01 AM Feature #3236: implement port range support for the web client's embedded web server
Greg Shah wrote:
> Constantin: do the changes suitably address your concerns?
Yes.

> Also: perhaps we need to a... Constantin Asofiei
05:47 AM Feature #3236: implement port range support for the web client's embedded web server
Greg Shah wrote:
> 2. I think that #3236-85 is not yet addressed. What is your plan there?
I think it is address... Hynek Cihlar
04:57 AM Feature #3236: implement port range support for the web client's embedded web server
Constantin: do the changes suitably address your concerns?
Also: perhaps we need to add some comments to make sure... Greg Shah
04:55 AM Feature #3236: implement port range support for the web client's embedded web server
Code Review Task Branch 2683a Revision 11171
1. The @WebClientManager.try{Acquire|Release}Port()@ methods have a c... Greg Shah
08:38 PM Feature #3236: implement port range support for the web client's embedded web server
Please review committed revision 11171 that added "session counter" from the note 81. Sergey Ivanovskiy
04:24 PM Bug #3306: Improve intermediate state in ROW-DISPLAY trigger.
This task is about the browse state which is drawn when ROW-DISPLAY is triggered for multiple rows. See #3275-30 for ... Stanislav Lomany
02:09 PM Bug #3306 (New): Improve intermediate state in ROW-DISPLAY trigger.
Stanislav Lomany
11:12 AM Feature #3282: create a 4GL language extension to control screen refresh
The implementation has been committed to 3282a and is ready for review. GUI regression tests passed, ChUI tests in pr... Hynek Cihlar
10:21 PM Feature #1834: implement direct manipulation (drag and drop)
The task branch @1834a@ has been updated for review to revision @11162@.
The next preparation step to implement cl... Eugenie Lyzenko

06/28/2017

06:07 PM Feature #3236: implement port range support for the web client's embedded web server
Committed revision 11170 fixed getFreeLocalPort, now exploring "session counter" from the note 81. Sergey Ivanovskiy
03:57 PM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> You considered the case of leaking resources in the general case, the port management tha... Constantin Asofiei
03:32 PM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> Constantin, Hynek as I understand correctly there is a case when the web client lives for... Constantin Asofiei
03:31 PM Feature #3236: implement port range support for the web client's embedded web server
Constantin, Hynek as I understand correctly there is a case when the web client lives forever and can't reconnect to ... Sergey Ivanovskiy
03:30 PM Feature #3236: implement port range support for the web client's embedded web server
Ok, thank you, we can try blocking API for this case.
 Sergey Ivanovskiy
03:23 PM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> > Which is the case with the current implementation, too - when all ports are taken and a... Hynek Cihlar
03:18 PM Feature #3236: implement port range support for the web client's embedded web server
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Yes, it is expected behaviour, but it is only for the case if th... Sergey Ivanovskiy
03:08 PM Feature #3236: implement port range support for the web client's embedded web server
Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > Constantin, does it mean that this problem of leaking reso... Sergey Ivanovskiy
03:04 PM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> Yes, it is expected behaviour, but it is only for the case if the almost all resources ar... Hynek Cihlar
02:57 PM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> Constantin, does it mean that this problem of leaking resources described above exists in... Constantin Asofiei
02:57 PM Feature #3236: implement port range support for the web client's embedded web server
Yes, it is expected behaviour, but it is only for the case if the almost all resources are used (#range -1), correct?... Sergey Ivanovskiy
02:53 PM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> >
> > Still, the extra load can be easily avoided by scanning th... Hynek Cihlar
02:45 PM Feature #3236: implement port range support for the web client's embedded web server
Hynek Cihlar wrote:
>
> Still, the extra load can be easily avoided by scanning the usedLocalPorts map and only do... Sergey Ivanovskiy
02:37 PM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> Greg Shah wrote:
> > Hynek Cihlar wrote:
> > > Greg Shah wrote:
> > > > If I understan... Hynek Cihlar
02:27 PM Feature #3236: implement port range support for the web client's embedded web server
Greg Shah wrote:
> Hynek Cihlar wrote:
> > Greg Shah wrote:
> > > If I understand correctly, the check only occurs... Sergey Ivanovskiy
02:24 PM Feature #3236: implement port range support for the web client's embedded web server
Constantin Asofiei wrote:
> Beside the above, what I have in mind is a possible race condition; consider these execu... Sergey Ivanovskiy
01:46 PM Feature #3236: implement port range support for the web client's embedded web server
Hynek Cihlar wrote:
> Greg Shah wrote:
> > If I understand correctly, the check only occurs if we can't allocate a ... Greg Shah
12:55 PM Feature #3236: implement port range support for the web client's embedded web server
Constantin Asofiei wrote:
> When @true@, @running@ flag indicates the client must restart, but the FWD session will ... Constantin Asofiei
12:53 PM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> > So, I'm thinking that @isStillAlive@ should have a boolean parameter which 'forces' the... Constantin Asofiei
12:32 PM Feature #3236: implement port range support for the web client's embedded web server
Greg Shah wrote:
> If I understand correctly, the check only occurs if we can't allocate a port.
Unless I am read... Hynek Cihlar
12:13 PM Feature #3236: implement port range support for the web client's embedded web server
If I understand correctly, the check only occurs if we can't allocate a port. In the common case (there is a free po... Greg Shah
12:10 PM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> I agree if you mean that https involves heavy calculations.
Even without https, one ch... Hynek Cihlar
12:04 PM Feature #3236: implement port range support for the web client's embedded web server
I agree if you mean that https involves heavy calculations. Committed rev. 11169 fixed all comments that I could do. Sergey Ivanovskiy
11:58 AM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Code Review Task Branch 2683a.
> >
> > * In WebClientSpawner ... Hynek Cihlar
11:14 AM Feature #3236: implement port range support for the web client's embedded web server
Hynek Cihlar wrote:
> Code Review Task Branch 2683a.
>
> * In WebClientSpawner
> * Below the port should be giv... Sergey Ivanovskiy
11:11 AM Feature #3236: implement port range support for the web client's embedded web server
Hynek Cihlar wrote:
> Code Review Task Branch 2683a.
> * In WebClientSpawner
> ** @ if (!"/".equals(webClientConf... Sergey Ivanovskiy
10:30 AM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> It seems that DojoToolkitHandler should not be changed, because it is not a web virtual d... Hynek Cihlar
10:09 AM Feature #3236: implement port range support for the web client's embedded web server
It seems that DojoToolkitHandler should not be changed, because it is not a web virtual directory for the embedded se... Sergey Ivanovskiy
10:05 AM Feature #3236: implement port range support for the web client's embedded web server
Hynek Cihlar wrote:
> Code Review Task Branch 2683a.
>
> In addition to Greg's and Constantin's finds.
>
> * I... Sergey Ivanovskiy
09:45 AM Feature #3236: implement port range support for the web client's embedded web server
Constantin Asofiei wrote:
> What I'm trying to confirm is that the FWD server always frees the resources, for a FWD ... Sergey Ivanovskiy
09:33 AM Feature #3236: implement port range support for the web client's embedded web server
Code Review Task Branch 2683a.
In addition to Greg's and Constantin's finds.
* In WebClientSpawner
** @ if (!... Hynek Cihlar
09:31 AM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> I did this because we can't free a given port until its system resources are released.
... Constantin Asofiei
09:17 AM Feature #3236: implement port range support for the web client's embedded web server
Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > If the web client is failed, then its session is closed, a... Sergey Ivanovskiy
09:07 AM Feature #3236: implement port range support for the web client's embedded web server
Sergey Ivanovskiy wrote:
> If the web client is failed, then its session is closed, and it seems that all listeners ... Constantin Asofiei
09:03 AM Feature #3236: implement port range support for the web client's embedded web server
If the web client is failed, then its session is closed, and it seems that all listeners should be notified and @term... Sergey Ivanovskiy
07:28 AM Feature #3236: implement port range support for the web client's embedded web server
Sergey, the issues I have are these:
* have you tested if the FWD client terminates abruptly? In this case, the ser... Constantin Asofiei
06:19 AM Feature #3236: implement port range support for the web client's embedded web server
Code Review Task Branch 2683a Revision 11167
I have checked in some changes to fix code formatting issues. Overal... Greg Shah
01:21 AM Feature #3236: implement port range support for the web client's embedded web server
Committed revision 11167 prepared this branch 2683a for the review. Sergey Ivanovskiy
05:32 PM Feature #3275: improve browse support
About "value cannot be displayed using ... " case for the browse:
If a cell value cannot be displayed using column f... Stanislav Lomany
12:48 PM Bug #3305: broken widget references management
While testing a medium-large GUI application I noticed that at some time (I was not able to pinpoint the exact trigge... Ovidiu Maxiniuc
12:36 PM Bug #3305 (New): broken widget references management
Ovidiu Maxiniuc
 

Also available in: Atom