Activity
From 10/15/2017 to 11/13/2017
11/13/2017
- 12:40 PM Feature #3332 (Closed): Add support for load offset and load size parameters of LOAD-IMAGE* metho...
- 12:31 PM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...
- 3332a passed regression tests and have been merged to trunk as revision 11200. The task branch was archived.
- 12:14 PM Bug #3370: READ-ONLY attribute error in server log
- We see this in a customer app. Can also be recreated in Hotel GUI as follows:
# Log in.
# Click "Check-In..." in th... - 12:11 PM Bug #3370 (Closed): READ-ONLY attribute error in server log
11/12/2017
- 03:44 PM Bug #3368: dialog-box frame height is not set correctly
- Constantin, can you be more specific, what is the expected result of the sample code above? I didn't find any issues ...
- 07:11 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...
- 3332a rebased against latest trunk.
- 08:46 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
- 3369a was created from trunk rev 11199. It contains the changes to add support for @BGCOLOR-RGB@ and @FGCOLOR-RGB@ F...
- 08:20 PM Feature #3369 (Closed): add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
11/10/2017
- 03:18 PM Bug #3368: dialog-box frame height is not set correctly
- There is a bug in FWD where the height of a dialog-box window is not computed correct, when frame's height is set exp...
- 03:15 PM Bug #3368 (Closed): dialog-box frame height is not set correctly
11/09/2017
- 07:15 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- No, please create one.
- 07:12 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Do we have a branch for this?
- 05:36 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- > This dynamic layout (if enabled) will be in effect only when a browse widget will appear in any of the affected fra...
- 05:30 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- This dynamic layout (if enabled) will be in effect only when a browse widget will appear in any of the affected frame...
- 05:18 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- I should have mentioned that if the browse is not positioned at the top left and there is space in either of those di...
- 05:13 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Greg Shah wrote:
> This is the concept:
> # Expand the size of both the containing frame and the enhanced browse to... - 05:10 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Greg Shah wrote:
> This is the concept:
On which events should the layout be changed? Is it after it is displayed... - 05:06 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- This is the concept:
# Detect if the containing window has empty space horizontally, vertically or both. If the b... - 04:54 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Stanislav, Greg mentioned that you could use some help on "Automatically and sensibly expand to fit more space availa...
- 07:08 AM Feature #3275: improve browse support
- Created task branch 3275d from trunk revision 11198 (for "column and row resizing doesn't work properly" issues which...
11/08/2017
- 03:27 PM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...
- Code Review Task Branch 3332a Revision 11207
I'm good with the code.
You will need to rebase (Eric is about to ... - 02:57 PM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...
- 3332a 11207 makes the @loadImage@ methods accept @int64@ and added the overloads with Java primitive types. The revis...
- 11:21 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...
- Greg Shah wrote:
> My concern is that this converted code won't compile because @integer@ is more specific than @int... - 11:14 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...
- > This should be covered. Although the native 4GL allows passing int64 values, anything above the max int value will ...
- 10:33 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...
- Greg Shah wrote:
> Code Review Task Branch 3332a Revision 11206
>
> 2. I would prefer to leave the primitive vers... - 10:14 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...
- Code Review Task Branch 3332a Revision 11206
1. I have no problem with forced wrapping for @load-image*()@. Don't... - 09:51 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...
- 3332a revision 11206 is rebased againt trunk 11196. Please review.
- 09:45 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...
- 3332a revision 11206 resolves the review points except one exception mentioned below, fixes several widget sizing cas...
11/05/2017
- 02:14 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- > If we hide a column in interactive mode it is, obviously, hidden in the report. Is it hidden when we return to norm...
11/04/2017
- 01:28 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- > Are we talking about the same thing?
Yes.
> Everything is correct except that I don't understand why the Age ... - 09:25 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- >> Do you mean replaced with an enhanced version of itself?
>
> I mean a version where:
I think this is the sam... - 09:18 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Everything is correct except that I don't understand why the Age column exists in the final browse (bottom left to th...
11/03/2017
- 05:32 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- To make sure that we are on the same page. Is this diagram right?
!diagram1.png! - 01:42 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- > Do you mean replaced with an enhanced version of itself?
I mean a version where:
# column resize is on;
# col... - 12:51 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- > In that mode, browse is "replaced" with an interactive version of itself.
Do you mean replaced with an enhanced... - 12:30 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Consider user enters interactive mode. In that mode, browse is "replaced" with an interactive version of itself. Are ...
- 11:55 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- > So, when a column is hidden in report, it is hidden in the current browse too, right?
I would say it the other ... - 11:53 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- I assume "yes" means that formats match. So, when a column is hidden in report, it is hidden in the current browse to...
- 11:33 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Yes, that is the idea.
- 11:27 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Should in-application browse format (i.e. the current view) match output browse format or not?
- 11:05 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- The idea is that the user should be able to customize the look and feel of the actual browse columns in interactive m...
- 09:47 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- > I want the user to be able to override formatting choices like ... the width of a column
Do you mean column widt... - 08:05 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- As noted above, I want the user to be able to override formatting choices like font, font color, cell background colo...
- 08:02 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- I like the idea of a custom report template. That will be powerful capability.
Please note that there should be a... - 11:53 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...
- Eugenie Lyzenko wrote:
> Actually I do not understand why to change so lot. The image with offset is the regular ima... - 10:52 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...
- Greg Shah wrote:
> Code Review Task Branch 3332a Revision 11201
>
> Eugenie: Please review that code.
1. @load... - 09:15 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...
- Greg Shah wrote:
> On which line of code does that occur? I must be having a mental block, I don't see it.
See t... - 09:14 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...
- Greg Shah wrote:
> The caller can be using literals that will normally emit as Java primitives. When mixing those t... - 09:10 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...
- >> 5. I don't understand the implementation of ButtonWidget.loadImageInt(). All the offset and width/height data is u...
- 09:07 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...
- >> 4. We don't support the full range of method signatures for ButtonWidget.loadImage*(). We are currently missing th...
- 06:35 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...
- Greg Shah wrote:
> Code Review Task Branch 3332a Revision 11201
>
> 1. In the versions of @ButtonWidget.loadImage... - 05:57 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...
- Code Review Task Branch 3332a Revision 11201
1. In the versions of @ButtonWidget.loadImage*()@ which have @integer... - 11:06 AM Bug #3335 (Closed): buggy no-validate in browse widget
- These changes are included in trunk rev 11185.
- 10:25 AM Bug #3335 (Review): buggy no-validate in browse widget
- Fixed as part of #3275
11/02/2017
- 05:53 PM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...
- 3332a contains the implemented IMAGE and BUTTON load size and offset plus related changes. Also the branch includes t...
- 05:40 PM Feature #3261 (WIP): enhanced browse that can optionally selected as a replacement for the defaul...
- > One idea is to provide generic export to the following formats:
>
> * csv
> * xls/xlsx
> * pdf
I think we c... - 11:23 AM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- Greg Shah wrote:
> These seem important:
>
> * keyboard navigation
> * search combobox
> * New folder
> * More... - 11:01 AM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- These seem important:
* keyboard navigation
* search combobox
* New folder
* More options (at least the user sh... - 10:40 AM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- The basic functionality is there. One can navigate to desired location and select the desired file. Here are some scr...
11/01/2017
- 02:28 PM Feature #3289: implement SYSTEM-DIALOG-GET-DIR
- Greg Shah wrote:
> The runtime implementation for this task was written in branch 1830b and was merged to trunk as r... - 02:22 PM Feature #3289: implement SYSTEM-DIALOG-GET-DIR
- The runtime implementation for this task was written in branch 1830b and was merged to trunk as revision 11188.
An... - 02:25 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- An update from Ovidiu:
> File dialogs are well connected with Windows Explorer. One can use it as a 'shell' and: c... - 02:15 PM Feature #3291: implement SYSTEM-DIALOG-COLOR
- > After the the user makes a selection, the selection will be used by widgets that are subsequently created, but alre...
- 02:14 PM Feature #3291: implement SYSTEM-DIALOG-COLOR
- The runtime implementation for this task was written in branch 1830b and was merged to trunk as revision 11188.
Th... - 02:15 PM Feature #3290: implement SYSTEM-DIALOG-FONT
- > After the the user makes a selection, the selection will be used by widgets that are subsequently created, but alre...
- 02:14 PM Feature #3290: implement SYSTEM-DIALOG-FONT
- The runtime implementation for this task was written in branch 1830b and was merged to trunk as revision 11188.
Th... - 01:31 PM Feature #2368: allow widget output to stream in GUI mode
- > To be clear, issues mentioned in #2368-12 are not fixed.
OK, then log this case too (VIEW of a STREAM-IO frame).... - 01:04 PM Feature #2368: allow widget output to stream in GUI mode
- Greg Shah wrote:
> > We should be good as long as a frame is not used in mixed mode (and from all code I've seen, fr... - 01:02 PM Feature #2368: allow widget output to stream in GUI mode
- > We should be good as long as a frame is not used in mixed mode (and from all code I've seen, frames are usually sin...
- 12:56 PM Feature #2368: allow widget output to stream in GUI mode
- Greg Shah wrote:
> Constantin: Did you ever check to see if STREAM-IO frames have different behavior when used inter... - 12:50 PM Feature #2368: allow widget output to stream in GUI mode
- Constantin: Did you ever check to see if STREAM-IO frames have different behavior when used interactively?
If I ...
10/30/2017
- 06:45 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- Branch 1830b was rebased and merged to trunk as r11188.
The branch was archived and a notification email sent to tea... - 06:27 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- Please rebase and then merge to trunk.
- 06:21 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- Greg,
After doing some manual tests I identified a possible regression in 1830b/11210 that caused a NPE. Because o... - 04:54 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- Ignore this failure.
- 04:53 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- The extra line is (14):
@ 1234 14.0 6.1 0.0 20.2 -7.9 18.4 16.0 -5.4@
It is p... - 04:41 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- It may be just a rare timing issue.
Eugenie: what do you think? - 04:09 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- Branch 1830b was rebased to latest trunk (r11186). Current revision is 11210.
I tried to understand the extra line... - 03:45 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- Ovidiu Maxiniuc wrote:
> Hynek Cihlar wrote:
> > The window of windowId should be passed to @DialogBoxWindow.setOwn... - 03:39 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- Hynek Cihlar wrote:
> The window of windowId should be passed to @DialogBoxWindow.setOwner()@ before the modal windo... - 03:21 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- Ovidiu Maxiniuc wrote:
> > The parameter windowId in FontChooserGuiImpl.createInstance is not referenced. I think th... - 03:10 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- Hynek Cihlar wrote:
> Code review 1830b revision 11208.
>
> Please remove "Invalidates HSL encoding." from ColorR... - 01:17 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- Code review 1830b revision 11208, part two.
In DirDialogGuiImpl the copyright statement should only contain the cu... - 01:08 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- Code review 1830b revision 11208.
Here is a few minor points.
Please remove "Invalidates HSL encoding." from Co... - 10:32 AM Feature #3282: create a 4GL language extension to control screen refresh
- 3282b merged to trunk as revision 11186 and archived.
- 07:30 AM Feature #3282: create a 4GL language extension to control screen refresh
- Code Review Task Branch 3282b Revision 11187
The code is good.
Please rebase. There will be some minor conflic... - 02:46 AM Feature #3282: create a 4GL language extension to control screen refresh
- I checked in a fix of the regression of combo box and menu not handling mouse input in 3282b and also addressed the p...
- 11:32 PM Feature #3282: create a 4GL language extension to control screen refresh
- Code Review Task Branch 3282b Revision 11186
I'm fine with the code. - 06:04 AM Feature #3275: improve browse support
- 3275c has been merged into the trunk as bzr revision 11185.
- 04:43 AM Feature #3332: Add support for load offset and load size parameters of LOAD-IMAGE* methods of BUT...
- 3332a rebased against latest trunk.
10/29/2017
- 01:40 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- After replacing @ModalBox@ with @IsModal@ interface and fixing other regressions caused by rebase operation I committ...
- 12:35 PM Feature #3282: create a 4GL language extension to control screen refresh
- Greg Shah wrote:
> One question: What is the reason that @Window.isRepaintDisabled()@ is hard coded to @false@?
T... - 10:19 PM Feature #3282: create a 4GL language extension to control screen refresh
- Code Review Task Branch 3282b Revision 11184
I'm generally fine with the changes.
One question: What is the rea... - 06:40 AM Feature #3275: improve browse support
- Rebased task branch 3275c from P2J trunk revision 11184.
- 09:54 PM Feature #3275: improve browse support
- Code Review Task Branch 3275c Revision 11194
I'm good with the changes. If it passes testing you can merge to trunk. - 04:18 AM Feature #3287: local web client installation
- 3287a was merged into the trunc rev 11183 and archived.
- 09:26 PM Feature #1795 (Closed): implement printing support (real GUI printing not the child process stuff...
- 09:26 PM Feature #3313 (Closed): implement SYSTEM-DIALOG-PRINTER-SETUP
- For now, the implementation is not directly mapped to the Windows printer dialog. Instead it is designed to support ...
10/28/2017
- 03:44 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- Hynek Cihlar wrote:
> * build.xml is missing change history entry.
Added
> * It may be a bit confusing that ColorR... - 01:18 PM Feature #3275: improve browse support
- I'm good with the persistence-related changes. Also, I successfully ran the ETF full search test suite against 3275c/...
- 10:30 AM Feature #3282: create a 4GL language extension to control screen refresh
- 3282b rebased against trunk revision 11184.
- 10:14 AM Feature #2368: allow widget output to stream in GUI mode
- 1795b was merged to trunk as revision 11184.
- 10:13 AM Feature #3313: implement SYSTEM-DIALOG-PRINTER-SETUP
- Runtime support of the print dialog in the limited support for the internal PDF printer was merged to trunk in 1795b ...
- 10:11 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
- 1795b passed ChUI regression tests, was rebased against trunk revision 11183 and merged to trunk as revision 11184.
...
10/27/2017
- 07:42 PM Feature #3275: improve browse support
- Please review 3275c revision 11194, it has significant refactoring according to the notes above.
- 03:41 PM Feature #3275: improve browse support
- > * @BufferFieldImpl.java@:1265, instead of manually prefixing the error message with @**@ use the @prefix@ parameter...
- 07:59 AM Feature #3275: improve browse support
- Eric Faulhaber wrote:
> Ovidiu, please review the changes specific to the dynamic compilation and runtime JAST inter... - 07:22 PM Feature #3287: local web client installation
- The last result 20171027_153157 were not good but the target test TC-JOB-CLOCK-002 passed - OK. Planning to merge int...
- 06:41 PM Feature #3287: local web client installation
- OK. Running majic_regression_testing_tc.xml test case for TC-JOB-CLOCK-002, according to logs it should be completed ...
- 05:35 PM Feature #3287: local web client installation
- And please merge 3287a to trunk.
- 04:15 PM Feature #3287: local web client installation
- Sergey Ivanovskiy wrote:
> Yes, planning to create deploy/broker/ folder. It seems that I am very needed the tool th... - 04:13 PM Feature #3287: local web client installation
- Yes, planning to create @deploy/broker/@ folder. It seems that I am very needed the tool that can update only one new...
- 04:05 PM Feature #3287: local web client installation
- Ok, then 3287a can be released.
For Hotel GUI and POC: can you make the changes so that it doesn't affect the curr... - 03:53 PM Feature #3287: local web client installation
- I meant this broker user in @client.xml@ for the broker agent....
- 03:49 PM Feature #3287: local web client installation
- Yes, it is the first case from #3287-72 with the dedicated mode. The broker user is a trusted FWD user used for trust...
- 03:42 PM Feature #3287: local web client installation
- OK, so if a broker is started on the client's machine, the server will spawn the FWD client for the embedded app via ...
- 03:40 PM Feature #3287: local web client installation
- If there are no brokers, then web clients are created locally.
- 03:37 PM Feature #3287: local web client installation
- Yes, it should work without any additional setup. There are only required to change Hotel GUI embedded and customer's...
- 03:33 PM Feature #3287: local web client installation
- Sergey Ivanovskiy wrote:
> Greg, Constantin, can this branch be merged into trunc if this test will be OK?
Is there... - 02:59 PM Feature #3287: local web client installation
- Greg, Constantin, can this branch be merged into trunc if this test will be OK?
- 02:57 PM Feature #3287: local web client installation
- gso_ctrlc_3way_tests tests were passed in this 20171027_124426 run. There is only suspected TC-JOB-CLOCK-002.
- 12:39 AM Feature #3287: local web client installation
- In the last run gso_ctrlc_tests passed, but gso_ctrlc_3way_tests failed for:...
- 08:14 PM Feature #3287: local web client installation
- ctrl_c tests are frozen in two runs. Running this test again.
- 04:24 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- Ovidiu Maxiniuc wrote:
> Hynek,
>
> I got the notification because I am the assignee. Thank you very much for the... - 04:18 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- Hynek,
I got the notification because I am the assignee. Thank you very much for the quick review. I will do the f... - 04:14 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- Ovidiu, I added you as the issue watcher. Please see the review in note 18.
- 04:10 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- Code Review Task Branch 1830b Revision 11199.
The changes are impressive, hands down. I found only some minor issu... - 11:30 AM Feature #3282: create a 4GL language extension to control screen refresh
- Extended DSIABLE-REDRAW to all widget types. Previously only WINDOW widget was supported. I checked in the change int...
10/26/2017
- 05:08 PM Feature #3275: improve browse support
- I'm OK with adding a version that takes a boolean flag to disable the message box.
- 02:59 PM Feature #3275: improve browse support
- > 1. In @ControlEntity@, the use of @LogicalTerminal.message()@ instead of something in @ErrorManager@ seems incorrec...
- 02:05 PM Feature #3275: improve browse support
- > * In @DynamicQueryHelper.injectVariable@, why are all literal values replaced with the same variable?
I needed a f... - 01:42 PM Feature #3275: improve browse support
- Greg Shah wrote:
> Eric: Please review the changes in the persist package.
Wow, that's a big set of changes! The up... - 09:25 AM Feature #3275: improve browse support
- Code Review Task Branch 3275c Revision 11193
Eric: Please review the changes in the persist package.
Everything... - 07:53 AM Feature #3275: improve browse support
- Yes, just finished. Please review 3275c revision 11193.
- 07:33 AM Feature #3275: improve browse support
- Is 3275c ready for review?
- 01:55 PM Feature #3287: local web client installation
- OK. (It is recommended to run TC-JOB-CLOCK-002 after 16-00 of the server time. Thus I will run it later.) Planning st...
- 01:54 PM Feature #3287: local web client installation
- Sergey Ivanovskiy wrote:
> Yes, you are correct. I mean tc_job_clock_002.
I've checked the failed screen and this o... - 01:47 PM Feature #3287: local web client installation
- Yes, you are correct. I mean tc_job_clock_002.
- 01:44 PM Feature #3287: local web client installation
- Sergey Ivanovskiy wrote:
> Thus, tc_job_002 is suspected.
This is the single test which still fails in FWD, so you ... - 01:43 PM Feature #3287: local web client installation
- In two runs of the main-regression task there were
failed tests in the first run... - 12:06 PM Feature #3331 (Closed): translate 4GL menu widget processing into a standardized embedded web cli...
- 11:26 AM Feature #3331: translate 4GL menu widget processing into a standardized embedded web client menu ...
- Greg, this task can be closed too - the standard/default FWD menu for embedded mode works.
- 12:06 PM Feature #3260 (Closed): auto-conversion and enablement for the embedded web client
- 11:25 AM Feature #3260: auto-conversion and enablement for the embedded web client
- Greg, this task can be closed.
- 09:46 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
- Code Review Task branch 1795b Revision 11203
I'm good with the changes.
If it passes ChUI regression testing, p... - 09:33 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
- The latest 1795b resolves the points from review, point 3 from note 42, plus some related changes. I don't expect any...
- 04:32 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
- Sergey Ivanovskiy wrote:
> Were these pdf pages in your test pure text pages without graphics?
Yes, all were pure... - 04:30 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
- Hynek Cihlar wrote:
> Greg Shah wrote:
> > Code Review Task branch 1795b Revision 11200
> > 1. The thing I wonder ... - 04:26 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
- Greg Shah wrote:
> Code Review Task branch 1795b Revision 11200
> 1. The thing I wonder about is how well the strea...
10/25/2017
- 07:53 PM Feature #3275: improve browse support
- Rebased task branch 3275c from P2J trunk revision 11182.
- 06:00 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
- Code Review Task branch 1795b Revision 11200
Wow! This is really quite cool.
1. The thing I wonder about is ho... - 04:34 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
- 1795b 11200 passed GUI regression tests. ChUI still in progress, I got a technical error in previous run.
- 02:12 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
- Rebased 1795b against trunk revision 11182.
- 11:04 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
- Another fix checked in to 1795b revision 11196. ChUI regression tests restarted.
- 08:30 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
- I have checked in two regression fixes in 1795b revisions 11194 and 11195. I am restarting ChUI regression tests and ...
- 02:14 PM Feature #3287: local web client installation
- Yes, you are correct. New @hotel-root.der@ should be generated and imported into the browser. It seems that this issu...
- 12:02 PM Feature #3287: local web client installation
- Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > One of the reason is this parameter must be set TRUE.
> >... - 10:17 AM Feature #3287: local web client installation
- Sergey, I'm OK with changes in 3287a rev 11194. I assume all sync issues are solved?
Also, you mention to release... - 10:13 AM Feature #3287: local web client installation
- Sergey Ivanovskiy wrote:
> There are some issues with js embedded part, the spawned web client response looks correc... - 10:12 AM Feature #3287: local web client installation
- Sergey Ivanovskiy wrote:
> One of the reason is this parameter must be set TRUE.
> [...]
> The second reason is ea... - 09:26 AM Feature #3287: local web client installation
- One of the reason is this parameter must be set TRUE....
- 09:17 AM Feature #3287: local web client installation
- There are some issues with js embedded part, the spawned web client response looks correct but the process is not goi...
- 08:51 AM Feature #3287: local web client installation
- Constantin, do you know how these parameters are used by the spawned web client in the embedded web application?
<pr... - 07:52 AM Feature #3287: local web client installation
- Sergey Ivanovskiy wrote:
> I encountered this menu exception before, but its root cause was not fixed by me so I did... - 05:12 AM Feature #3287: local web client installation
- I encountered this menu exception before, but its root cause was not fixed by me so I didn't remember what was the ca...
- 05:08 AM Feature #3287: local web client installation
- The broker has been setup successfully with help of com.goldencode.p2j.security.SSLCertGenUtil and certificates have ...
- 03:05 AM Feature #3287: local web client installation
- Committed 11194 fixed @getHostsForUser@ to be a thread safe. Planning to setup broker for the embedded web applicatio...
10/24/2017
- 07:13 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
- 1795b revision 11193 resolves 1 from note 42 besides other fixes.
- 04:32 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
- The attached file is the modified @_osprint.p@ with the native code removed using the implemented print features in 1...
- 12:18 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
- 1795b is ready for review.
The following are remaining tasks on the issue.
1. Finish regression testing.
2. Pr... - 09:57 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
- Greg Shah wrote:
> Is this in a good place for a code review?
I am just putting in missing code comments, it will... - 09:26 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
- Is this in a good place for a code review?
- 04:03 PM Feature #3287: local web client installation
- Committed revision 1677 in @testcase@ project added configurations for the standard server with broker and for its br...
- 03:55 PM Feature #3287: local web client installation
- Yes, thank you for findings.
@BrokerManager.removeUserHostWithCheck@ is used only from @void deregisterBroker(Broke... - 03:18 PM Feature #3287: local web client installation
- Review for 3287a rev 11190:
# @BrokerManager.removeUserHostWithCheck@ - shouldn't this have some synchronization? Sa... - 03:05 PM Feature #3287: local web client installation
- Sergey Ivanovskiy wrote:
> Can I commit @server2/@ and @broker/@ configurations under @testcases/simple@ with genera... - 03:05 PM Feature #3287: local web client installation
- Can I commit @server2/@ and @broker/@ configurations under @testcases/simple@ with generated certificates and their l...
- 02:52 PM Feature #3287: local web client installation
- The 3287a is updated over rev 11182. The current revision 11190 fixed @ClientsToPortsGenerator@. I think that this br...
- 10:14 AM Feature #3287: local web client installation
- Greg Shah wrote:
> One concern I have: the need to restart the proxy server seems to be a problem. Dedicated client... - 09:48 AM Feature #3287: local web client installation
- Constantin will review the code and provide feedback.
One concern I have: the need to restart the proxy server see... - 04:38 AM Feature #3287: local web client installation
- Committed revision 11188 implemented the hosts file. Please review. The next file for planning changes is only @Clien...
- 02:07 AM Feature #3287: local web client installation
- Added rev 11187 explanations to help reviewers. Please look at #3287-97.
- 01:35 AM Feature #3287: local web client installation
- 11187 covers these cases
dedicated agent is a dedicated single-user agent in which executing the spawner shoul... - 03:21 PM Feature #2368: allow widget output to stream in GUI mode
- 2368c merged in 1795b and dead-archived.
- 12:45 PM Feature #2368: allow widget output to stream in GUI mode
- Constantin Asofiei wrote:
> Greg Shah wrote:
> > Alternatively, these can be merged into 1795b since that will be g... - 11:48 AM Feature #2368: allow widget output to stream in GUI mode
- Greg Shah wrote:
> Alternatively, these can be merged into 1795b since that will be going through testing soon and i... - 09:24 AM Feature #2368: allow widget output to stream in GUI mode
- Alternatively, these can be merged into 1795b since that will be going through testing soon and it is dependent on yo...
- 09:10 AM Feature #2368: allow widget output to stream in GUI mode
- Code Review Task Branch 2368c Revision 11182
I'm fine with the changes. Go ahead and put them through runtime tes... - 01:02 PM Feature #3260: auto-conversion and enablement for the embedded web client
- Greg Shah wrote:
> Code Review Task Branch 3260c Revision 11183
>
> I'm fine with the changes.
Merged to trunk r... - 10:11 AM Feature #3260: auto-conversion and enablement for the embedded web client
- Code Review Task Branch 3260c Revision 11183
I'm fine with the changes. - 11:59 AM Feature #3275: improve browse support
- > # In ChUI:
> 4.1 for an editable browse double Ctrl-G causes abend;
Fixed.
> 4.2 browse do not start e... - 11:58 AM Bug #3361: In ChUI browse does not start editing when we tab back into it
- Testcase (run in ChUI):...
- 11:48 AM Bug #3361 (New): In ChUI browse does not start editing when we tab back into it
10/23/2017
- 05:52 PM Feature #3287: local web client installation
- Please review the committed revision 11187 that used brokers to start web clients.
ADDED LATER
The dedicated broker... - 08:27 AM Feature #3287: local web client installation
- > I think we need a way to distinguish this client, so that it ensures the FWD client is spawned by the local broker...
- 07:58 AM Feature #3287: local web client installation
- > This functionality could be implemented by starting web client with web:client:host=localhost in this case this use...
- 07:54 AM Feature #3287: local web client installation
- > Is it OK if the dedicated broker client will start web clients accessed only by the user from the same host on whic...
- 07:53 AM Feature #3287: local web client installation
- Sergey Ivanovskiy wrote:
> Let us consider this scenario. The generic broker without associated users registers its ... - 04:58 AM Feature #3287: local web client installation
- 3287a is updated over 11181, current rev. 11186. Planning to fix a dynamic registration for dedicated broker agents a...
- 04:11 PM Feature #2368: allow widget output to stream in GUI mode
- 2368c rev 11182 should fix these two cases.
- 11:24 AM Feature #2368: allow widget output to stream in GUI mode
- Hynek, the key difference is that you have the unnamed stream redirected when wait-for starts. I'm looking into it.
- 11:24 AM Feature #2368: allow widget output to stream in GUI mode
- Another one....
- 11:12 AM Feature #2368: allow widget output to stream in GUI mode
- Constantin, with the latest trunk the following code sample abends....
- 10:59 AM Feature #3260: auto-conversion and enablement for the embedded web client
- Created 3260c which holds fixes/improvements related to ADM windows in embedded mode.
Revision 11182 contains:
# ... - 04:01 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
- 1795b rebased against trunk revision 11181.
10/22/2017
- 04:05 AM Feature #2368: allow widget output to stream in GUI mode
- 2368b passed runtime testing and was merged to trunk rev 11181, archived.
10/21/2017
- 01:02 PM Feature #3287: local web client installation
- I agree with Constantin that it seems there no ways to implement these requirements to start local clients in the cas...
- 10:36 AM Feature #3287: local web client installation
- Sergey, for embedded mode, there is no real knowledge of the authenticated FWD or OS user - the credentials you enter...
- 02:59 AM Feature #3287: local web client installation
- I think that the embedded server use case can work only in this case. We have one user 'fwd_user' and from the local ...
- 01:31 AM Feature #3287: local web client installation
- Is it OK if the dedicated broker client will start web clients accessed only by the user from the same host on which ...
10/20/2017
- 04:16 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
- 1795b rebased against trunk revision 11180.
- 03:56 PM Feature #3287: local web client installation
- Greg, please explain more thoroughly. This rule
>If a user with a dedicated agent registered connects from a host th... - 03:47 PM Feature #3287: local web client installation
- Let us consider this scenario. The generic broker without associated users registers its broker agent that proclaims ...
- 02:49 PM Feature #3287: local web client installation
- Exactly right.
- 02:48 PM Feature #3287: local web client installation
- If my understanding is correct, then we can generate clients to backends map for proxy server dynamically. If new ded...
- 02:40 PM Feature #3287: local web client installation
- Yes. @BrokerManager@ collects brokers for a given user if there are no such brokers, then it collects brokers without...
- 02:31 PM Feature #3287: local web client installation
- The current approach of allowing specific users to be associated with an agent is the implementation of this concept....
- 02:29 PM Feature #3287: local web client installation
- It seems that I don't understand this conception. Please explain what mean that user-limited shared agents are alread...
- 12:07 PM Feature #3287: local web client installation
- > Should these dedicated and user-limited shared agents save new added users and hosts in the directory?
The user-... - 11:54 AM Feature #3287: local web client installation
- Should these dedicated and user-limited shared agents save new added users and hosts in the directory?
- 11:27 AM Feature #3287: local web client installation
- The idea is that if the browser can forward enough information to calculate this value, then it can be used to lookup...
- 11:26 AM Feature #3287: local web client installation
- I think we don't care about the external IP address or hostname because we are not really using this for connectivity...
- 11:18 AM Feature #3287: local web client installation
- >Can we reduce or eliminate the directory configuration by doing some kind of registration when a dedicated agent is ...
- 11:07 AM Feature #3287: local web client installation
- Greg, do these requirements force to create new directory entity as host. Now we have these entities from accounts: u...
- 10:50 AM Feature #3287: local web client installation
- >Can we reduce or eliminate the directory configuration by doing some kind of registration when a dedicated agent is ...
- 10:38 AM Feature #3287: local web client installation
- Please review this branch 3287a 11184, it fixed @getPortName@ (@WebClientsManager@) to create well-defined map from h...
- 10:26 AM Feature #3287: local web client installation
- I see 3 cases:
* *dedicated agent* is a dedicated single-user agent in which executing the spawner should be only ... - 09:22 AM Feature #3287: local web client installation
- Greg Shah wrote:
> It is important that when a spawner is dedicate to a specific user, that no other users can spawn... - 09:13 AM Feature #3287: local web client installation
- It is important that when a spawner is dedicate to a specific user, that no other users can spawn FWD client instance...
- 08:48 AM Feature #3287: local web client installation
- Constantin Asofiei wrote:
> Sergey, do you have a scenario where @remote:spawner:host@ and the host configured in th... - 08:44 AM Feature #3287: local web client installation
- Sergey, do you have a scenario where @remote:spawner:host@ and the host configured in the directory's broker for the ...
- 08:40 AM Feature #3287: local web client installation
- Constantin Asofiei wrote:
>
> > > # what is the relation between @remote:spawner:host@ and directory's @brokers/ho... - 08:22 AM Feature #3287: local web client installation
- Sergey Ivanovskiy wrote:
> Constantin Asofiei wrote:
> > # I would prefer to have a java library path defaulted to ... - 08:16 AM Feature #3287: local web client installation
- Constantin Asofiei wrote:
> Review for 3287a rev 11183:
> # @LogicalTerminal@ is missing history entry
OK.
> # I ... - 08:00 AM Feature #3287: local web client installation
- Review for 3287a rev 11183:
# @LogicalTerminal@ is missing history entry
# I would prefer to have a java library pa... - 02:54 PM Feature #3260: auto-conversion and enablement for the embedded web client
- Greg Shah wrote:
> Is there any way to allow this to be set at runtime and send the result down to the client?
The ... - 02:50 PM Feature #3260: auto-conversion and enablement for the embedded web client
- Is there any way to allow this to be set at runtime and send the result down to the client?
- 02:19 PM Feature #3260: auto-conversion and enablement for the embedded web client
- There is at least one case where the window title for a ADM window is set as @window:title = some-char-var.@. In thi...
- 02:34 PM Feature #2368: allow widget output to stream in GUI mode
- Greg Shah wrote:
> What is left to do in this task (besides testing)?
There is some runtime behaviour in 4GL, when ... - 02:31 PM Feature #2368: allow widget output to stream in GUI mode
- Greg Shah wrote:
> 1. BorderedPanel needs a history entry.
Will fix.
> 2. Is it a problem to have references to @... - 02:24 PM Feature #2368: allow widget output to stream in GUI mode
- What is left to do in this task (besides testing)?
- 02:24 PM Feature #2368: allow widget output to stream in GUI mode
- Code Review Task Branch 2368b Revision 11181
Wow! I'm pretty impressed with the solution. It is less code and mu... - 11:43 AM Feature #2368 (WIP): allow widget output to stream in GUI mode
- Greg, please review 2368b rev 11181. I need to a little more testing, but the major changes I think are OK.
- 08:04 AM Feature #2368: allow widget output to stream in GUI mode
- Greg Shah wrote:
> Please merge to trunk.
Merged to trunk rev 11180 and archived. - 07:44 AM Feature #2368: allow widget output to stream in GUI mode
- Please merge to trunk.
- 07:40 AM Feature #2368: allow widget output to stream in GUI mode
- 2368a rev 11182 passed testing, it can be released.
- 11:45 AM Feature #3275: improve browse support
- This seems like a good compromise. Please go ahead with the change to @TableMapper@.
- 11:25 AM Feature #3275: improve browse support
- I think it may be better to add context-local map where @LABEL@ attributes modified by this quirk reside. That mean v...
- 10:03 AM Feature #3275: improve browse support
- Stanislav Lomany wrote:
> No problems to implement, except that I need to make @TableMapper.legacyFieldInfo()@ conte... - 09:51 AM Feature #3275: improve browse support
- No problems to implement, except that I need to make @TableMapper.legacyFieldInfo()@ context-local for permanent tabl...
- 07:43 AM Feature #3275: improve browse support
- This one seems straightforward to implement. Why not just implement it now while you are reworking the buffer-specif...
- 07:38 AM Feature #3275: improve browse support
- According to the rules above, all attributes are normally buffer-specific. However there is the 4GL quirk which takes...
10/19/2017
- 06:36 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
- Perfect.
- 06:36 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
- Greg Shah wrote:
> > But if for whatever reason you think we should go with the replacement of RUN _osprint.p at con... - 06:31 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
- > But if for whatever reason you think we should go with the replacement of RUN _osprint.p at conversion, then I will...
- 06:28 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
- Greg Shah wrote:
> > 4GL code doesn't allow to override the printer font. So in order to fully replace ProPrintFile ... - 06:19 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
- To be clear, the version of @_osprint.p@ that is to be used for any 4GL code editing must be the @src/adecomm/_osprin...
- 06:17 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
- > 4GL code doesn't allow to override the printer font. So in order to fully replace ProPrintFile with a 4GL code the ...
- 05:39 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
- It seems that the only motivation for using @ProPrintFile@ (from @PROPRINT.DLL@) in @_osprint.p@ is the ability to ov...
- 02:54 PM Feature #2368: allow widget output to stream in GUI mode
- > Something interesting about the 4GL runtime of STREAM-IO and why the GUI apps require this frame option.
Interes... - 02:11 PM Feature #2368: allow widget output to stream in GUI mode
- Some good news: I finally have some code which allows FWD to stream frames in GUI (both named and unnamed streams). ...
- 01:55 PM Feature #2368: allow widget output to stream in GUI mode
- Something interesting about the 4GL runtime of @STREAM-IO@ and why the GUI apps require this frame option. For this ...
- 01:45 PM Feature #2368: allow widget output to stream in GUI mode
- Revision 11182 of 2368a contains a #3281 fix and javadoc fixes.
- 12:19 PM Feature #3287: local web client installation
- Greg, please review 3287a (the current revision 11183 after rebasing).
Dedicated hosts are given by this settings
<... - 03:35 AM Feature #3287: local web client installation
- We can consider one broker process that serves many users. In this case we need to select broker client that is assoc...
- 06:34 AM Feature #3281: implement some frame options
- Somehow I forgot to update the branch before merging - trunk 11179 completes this branch.
10/18/2017
- 06:39 PM Feature #3287: local web client installation
- Committed revision 11181 changed to allocate new system resources in order to run new web client on the target host. ...
- 04:12 PM Feature #3287: local web client installation
- Correct.
- 03:45 PM Feature #3287: local web client installation
- Greg, thank you. It follows from your explanation that the answer is no.
- 03:42 PM Feature #3287: local web client installation
- Is it possible that for these two sessions @server(host0)<-session1->client(host1)@ and @server(host0)<-session2->cli...
- 03:34 PM Feature #3287: local web client installation
- > It seems that session.getRemoteAddress is not unique and there can be two different remote clients with the same se...
- 03:25 PM Feature #3287: local web client installation
- > Don't mind it doesn't need since I will use pair (session.getNodeAddress, session.getRemoteAddress).
It seems that... - 01:51 PM Feature #3287: local web client installation
- Don't mind it doesn't need since I will use pair (session.getNodeAddress, session.getRemoteAddress).
- 01:43 PM Feature #3287: local web client installation
- There is one issue with this schema above...
- 01:08 PM Feature #3287: local web client installation
- I meant @client:web:host@.
- 01:05 PM Feature #3287: local web client installation
- I found that it can be simplified since @client:web:host@ can be returned by the web remote client executing @proces...
- 11:14 AM Feature #3287: local web client installation
- Please evaluate this schema. Brokers are listed in the directory with associated users ...
- 09:29 AM Feature #2368: allow widget output to stream in GUI mode
- Code Review Task branch 2368a Revision 11180
I'm generally fine with the overall approach and changes.
The one ... - 08:33 AM Feature #2368: allow widget output to stream in GUI mode
- Greg Shah wrote:
> Does it make sense to get this branch tested and merged to trunk as is (and then do the rest of t... - 08:32 AM Feature #2368: allow widget output to stream in GUI mode
- Does it make sense to get this branch tested and merged to trunk as is (and then do the rest of the work in another b...
- 08:31 AM Feature #2368: allow widget output to stream in GUI mode
- Hynek, see 2368a revision 11180 - you can use PUT, MESSAGE and EXPORT statements to test your printing support. Norma...
- 07:39 AM Feature #2368: allow widget output to stream in GUI mode
- Hynek Cihlar wrote:
> Constantin, what is the status of the issue? I am asking to figure out whether I can use the b... - 08:28 AM Feature #3281 (Closed): implement some frame options
- 07:45 AM Feature #3281: implement some frame options
- Greg Shah wrote:
> If it passes testing you can merge to trunk.
After some more fixes, 3281a was merged to trunk re...
10/17/2017
- 07:01 PM Feature #2368: allow widget output to stream in GUI mode
- Constantin, what is the status of the issue? I am asking to figure out whether I can use the branch for an early test...
- 05:06 PM Feature #3275: improve browse support
- Rules that take place when a buffer-field attribute is assigned:
1. Attributes for permanent and temp-table buffers ... - 03:33 PM Feature #3287: local web client installation
- The customer is definitely going to use an embedded mode web client with multiple users that each run a separate loca...
- 03:25 PM Feature #3287: local web client installation
- Yes, understand.
I need to check another case when the web portal is used and the embedded clients are used. The em... - 02:04 PM Feature #3287: local web client installation
- Sergey Ivanovskiy wrote:
> Yes, I set it, the BrokerCore uses its own parameter when it starts spawn process. In gen... - 01:58 PM Feature #3287: local web client installation
- Yes, I set it, the BrokerCore uses its own parameter when it starts spawn process. In general I checked that the sche...
- 07:24 AM Feature #3287: local web client installation
- Sergey Ivanovskiy wrote:
> OK, understand, thank you. I have a new issue.
> The P2J web client spawned by the broke... - 06:04 AM Feature #3287: local web client installation
- OK, understand, thank you. I have a new issue.
The P2J web client spawned by the broker client is failed with web so... - 05:09 AM Feature #3287: local web client installation
- Sergey Ivanovskiy wrote:
> No, the os account must be here
Yes, OS account or FWD account; the FWD will redirect an... - 05:07 AM Feature #3287: local web client installation
- Sergey Ivanovskiy wrote:
> I did this
> [...]
> and changed this acl/system to permit only to this process to acce... - 04:49 AM Feature #3287: local web client installation
- I did this...
- 04:21 AM Feature #3287: local web client installation
- The client.xml has these settings...
- 04:16 AM Feature #3287: local web client installation
- Greg, Constantin, it seems that security model is not clear for me now. Could you help to understand how to associate...
- 03:52 AM Feature #3287: local web client installation
- I tried to prepare configuration or the broker process but didn't succeed. The P2J server logged...
Also available in: Atom