FWD » Core Development » User Interface

12/28/2017

01:52 PM Bug #3348 (Closed): The opened dropdown influences on the choice for the next tab widget for its ...

Greg Shah

01:46 PM Bug #3348: The opened dropdown influences on the choice for the next tab widget for its combobox

No, it was fixed in 3394a. Sergey Ivanovskiy

01:03 PM Bug #3348: The opened dropdown influences on the choice for the next tab widget for its combobox

Does this issue still exist in trunk revision 11214? Greg Shah

01:35 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes

This branch needs a rebase. Do you still believe it is safe to merge to trunk? Another option is to merge it into 3... Greg Shah

12:29 PM Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> Greg Shah wrote:
> > The changes are included in task branch 3394a which has been merged to t... Hynek Cihlar

11:19 AM Bug #3381: Sub-menu drawing issues

Greg Shah wrote:
> The changes are included in task branch 3394a which has been merged to trunk as revision 11214.
... Hynek Cihlar

11:14 AM Bug #3381: Sub-menu drawing issues

The changes are included in task branch 3394a which has been merged to trunk as revision 11214.
Hynek: Do you have... Greg Shah

11:14 AM Bug #3382: Client-side popup menus abend

The changes are included in task branch 3394a which has been merged to trunk as revision 11214.
Can I close this t... Greg Shah

11:13 AM Bug #2766: implement a text metrics server process

The improvements for web client font metrics processing are included in task branch 3394a which has been merged to tr... Greg Shah

11:12 AM Bug #3373: incremental scroll in non-full Browse page

The changes are included in task branch 3394a which has been merged to trunk as revision 11214. Greg Shah

11:11 AM Bug #3401 (Closed): clarifications for windows related methods in Widget and GuiDriver classes

The changes are included in task branch 3394a which has been merged to trunk as revision 11214. Greg Shah

10:57 AM Feature #3394 (Closed): generic drawing improvements: repaint and other misc code

Greg Shah

10:57 AM Feature #3394: generic drawing improvements: repaint and other misc code

Task branch 3394a has been merged to trunk as revision 11214.
I've archived 3394a. Greg Shah

09:13 AM Feature #3394: generic drawing improvements: repaint and other misc code

The only overlap this time is tc_job_clock_004 which was expected to fail due to the time of the run. At this point ... Greg Shah

03:17 AM Feature #3394: generic drawing improvements: repaint and other misc code

The next run of ChUI regression completed. Only 2 failures overlapped. Both of those are likely false negatives, ti... Greg Shah

09:29 PM Feature #3394: generic drawing improvements: repaint and other misc code

I've done one run of main ChUI regression testing. 6 unexpected failures occurred, but they all seem like false nega... Greg Shah

03:20 AM Feature #2368: allow widget output to stream in GUI mode

I'm OK with the approach, it seems correct. Greg Shah

12/27/2017

04:03 PM Feature #2368: allow widget output to stream in GUI mode

Hynek Cihlar wrote:
> The named stream redirection seems to work OK since the streamable OM in the GUI OM is redirec... Hynek Cihlar

08:50 AM Bug #3373 (Closed): incremental scroll in non-full Browse page

Fixed in branch 3394a revision 11298 which will be merged to trunk shortly. Greg Shah

12/26/2017

03:47 PM Feature #3394: generic drawing improvements: repaint and other misc code

3394a/11309 has passed ETF full search, developer, and batch tests. Eric Faulhaber

10:42 AM Feature #3394: generic drawing improvements: repaint and other misc code

Constantin Asofiei wrote:
> Please try 3394a 11309 - I think I had an unbalanced scope start/delete in SVM.
That di... Eric Faulhaber

04:06 AM Feature #3394: generic drawing improvements: repaint and other misc code

Eric Faulhaber wrote:
> There is a regression in task branch 3394a. ETF search testing grinds to a halt after a few ... Constantin Asofiei

12/25/2017

04:03 PM Feature #3394: generic drawing improvements: repaint and other misc code

There is a regression in task branch 3394a. ETF search testing grinds to a halt after a few minutes with multiple "No... Eric Faulhaber

12/23/2017

05:33 PM Feature #2368: allow widget output to stream in GUI mode

Constantin Asofiei wrote:
> Hynek, can you give me a simple standalone test which shows a few of the failures you de... Hynek Cihlar

04:10 PM Feature #2368: allow widget output to stream in GUI mode

Hynek, can you give me a simple standalone test which shows a few of the failures you describe in the previous note? Constantin Asofiei

09:59 AM Feature #2368: allow widget output to stream in GUI mode

There are numerous places where @ClassCastException@ is thrown when in GUI redirected mode and an @ALERT-BOX@ or an e... Hynek Cihlar

04:22 AM Bug #3373 (Review): incremental scroll in non-full Browse page

Stanislav Lomany

12/22/2017

11:34 AM Feature #3394: generic drawing improvements: repaint and other misc code

I've tested 3394a revision 11307 with Hotel GUI. It fixes the abend (Check-In then Add) and it fixes the tree contro... Greg Shah

08:33 AM Feature #3394: generic drawing improvements: repaint and other misc code

Rebased 3394a from trunk rev 11213 - new revision 11304.
3394a rev 11305 contains javadoc and history header fixes. Constantin Asofiei

10:08 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text

> So, rollback these two revisions in 3394a and commit them.
Done. Stanislav Lomany

09:23 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text

Stanislav Lomany wrote:
> > Stanislav: Please take this task. Please remove the changes for 11296/11297 such that i... Constantin Asofiei

09:23 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text

> Do you want me to revert 11296/11297 and then you merge 3394 and I check into another branch
This one. The fix ... Greg Shah

09:21 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text

> Stanislav: Please take this task. Please remove the changes for 11296/11297 such that it won't cause regressions. ... Stanislav Lomany

09:13 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text

Greg Shah wrote:
> Stanislav: Please take this task. Please remove the changes for 11296/11297 such that it won't c... Constantin Asofiei

09:09 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text

Stanislav: Please take this task. Please remove the changes for 11296/11297 such that it won't cause regressions. I... Greg Shah

09:07 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text

Is this code from @BrowseGuiImpl.doLayout()@ correct?... Sergey Ivanovskiy

08:49 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text

Stanislav Lomany wrote:
> > Stanislav, please describe font settings thoroughly, what are fonts without anti-aliasin... Sergey Ivanovskiy

08:22 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text

> Stanislav, please describe font settings thoroughly, what are fonts without anti-aliasing?
I don't know, but th... Stanislav Lomany

08:12 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text

The rev.11297, 11301 don't make changes for column widths. It is supposed that they are calculated correctly. Sergey Ivanovskiy

08:03 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text

Did you build a font-metrics file for the strings from your test? Sergey Ivanovskiy

08:01 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text

Stanislav Lomany wrote:
> It is not clear if actual P2J version (rev 11295) has issues with clipping (please use fon... Sergey Ivanovskiy

07:43 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text

It is not clear if actual P2J version (rev 11295) has issues with clipping (please use fonts without anti-aliasing fo... Stanislav Lomany

07:10 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text

I'm not good, wait a bit. Stanislav Lomany

07:09 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text

If Stanislav is OK with these changes, then we are good to go. Greg Shah

04:52 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text

Yes. Agree, committed rev 11301. Sergey Ivanovskiy

08:24 PM Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> With the latest 3394a the multiple selection issue is fixed and the Esc key works properly. Ho... Eugenie Lyzenko

12/21/2017

05:56 PM Bug #3425: text is drawn 1-pixel to the left, cutting the text

Greg Shah wrote:
> Stanislav/Hynek: please review.
Formally, I don't see anything wrong with the code. Maybe I wo... Hynek Cihlar

03:44 PM Bug #3425: text is drawn 1-pixel to the left, cutting the text

Code Review Task Branch 3394a Revisions 11296/7
I don't see a specific issue with the changes. However, the valid... Greg Shah

03:12 PM Bug #3425: text is drawn 1-pixel to the left, cutting the text

Please review committed revision 11297. Sergey Ivanovskiy

02:40 PM Bug #3425: text is drawn 1-pixel to the left, cutting the text

Please review committed revision 11296 that should fix drawing of labels with help of #3394-88. Sergey Ivanovskiy

05:09 PM Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> I'll try to rephrase what the problem is. When you open a submenu body, none of the menu items... Eugenie Lyzenko

04:47 PM Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> >
> > Yes, this is it. You can see it in the gif close to the end ... Hynek Cihlar

04:42 PM Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
>
> Yes, this is it. You can see it in the gif close to the end of the playback.
But in @FW... Eugenie Lyzenko

04:35 PM Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > 4. Menu item is highlighted when its submenu is opened, it should ... Hynek Cihlar

04:32 PM Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> 4. Menu item is highlighted when its submenu is opened, it should not be.
I do not understa... Eugenie Lyzenko

04:22 PM Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> > 2. There is a noticable lag when navigating from one root submenu to another, in native 4... Hynek Cihlar

04:20 PM Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> With the latest 3394a the multiple selection issue is fixed and the Esc key works properly. Ho... Eugenie Lyzenko

04:13 PM Bug #3381: Sub-menu drawing issues

With the latest 3394a the multiple selection issue is fixed and the Esc key works properly. However there are some ne... Hynek Cihlar

01:03 PM Bug #3381: Sub-menu drawing issues

Task branch @3394a@ has been updated for review to revision @11295@.
This is new approach to control menu item sel... Eugenie Lyzenko

06:56 AM Bug #3381: Sub-menu drawing issues

Code Review Task Branch 3394a Revision 11293
I'm OK with the changes.
> I think in 4GL the ESC handling is not... Greg Shah

10:18 PM Bug #3381: Sub-menu drawing issues

Task branch @3394a@ has been updated for review to revision @11293@.
This is suggested fix for @ESC@ key processin... Eugenie Lyzenko

02:20 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes

Code Review Task Branch 3369b Revision 11211
It is not clear why we need both @Coordinate.guiRound()@ and @Coordin... Greg Shah

12:59 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes

3369b replaces all UI coordinate roundings implemented by @BigDecimal@ with more primitive constructs, like @java.mat... Hynek Cihlar

07:22 AM Feature #3394: generic drawing improvements: repaint and other misc code

3394a revision 11294 fixes browse column widths due to incorrectly resolved column font. Hynek Cihlar

12/20/2017

01:53 PM Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> Fixes for issue except @ESC@ key press reaction, for which I still do not have the @4GL@ te... Hynek Cihlar

12:41 PM Bug #3381: Sub-menu drawing issues

Task branch @3394a@ has been updated for review to revision @11291@.
Fixes for issue except @ESC@ key press reacti... Eugenie Lyzenko

11:32 AM Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
>
> Another point is the way the menu bar should handle Esc key. On the first Esc press the su... Eugenie Lyzenko

03:38 AM Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> With the revision there are still some issues with the main bar. Please see the attached gif.
... Hynek Cihlar

03:10 AM Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> Task branch @3394a@ has been updated for review to revision @11288@.
>
> This is the fix... Hynek Cihlar

12:50 AM Bug #3381: Sub-menu drawing issues

Task branch @3394a@ has been updated for review to revision @11288@.
This is the fix for classic theme menu painti... Eugenie Lyzenko

09:28 PM Bug #3381: Sub-menu drawing issues

There are some @UI@ painting deviations for classic theme implementation. Consider the following native Windows pictu... Eugenie Lyzenko

08:38 PM Bug #3381: Sub-menu drawing issues

Task branch @3394a@ has been updated for review to revision @11286@.
The minor changes to resolve menu related iss... Eugenie Lyzenko

04:00 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text

Thank you, if we don't shift the text by 1 pixel to the left, then some table headers don't fit the column and some r... Sergey Ivanovskiy

03:50 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text

The @text-metrics.xml@ for AW was last updated by Constantin on Tue 2017-11-28 22:20:15 +0200 as revno 110.
I don't... Ovidiu Maxiniuc

03:24 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text

Ovidiu Maxiniuc wrote:
> It is possible that the font configuration to had been different. If it is wrong, please dr... Sergey Ivanovskiy

12/19/2017

02:47 PM Feature #3394: generic drawing improvements: repaint and other misc code

Sergey Ivanovskiy wrote:
> OK, please review the committed revision 11282.
The changes look good. Hynek Cihlar

02:16 PM Feature #3394: generic drawing improvements: repaint and other misc code

OK, please review the committed revision 11282. Sergey Ivanovskiy

11:10 AM Feature #3394: generic drawing improvements: repaint and other misc code

Greg Shah wrote:
> Sergey Ivanovskiy wrote:
> > Please review committed revision 11275 - tried to fix activations o... Hynek Cihlar

08:26 AM Feature #3394: generic drawing improvements: repaint and other misc code

Sergey Ivanovskiy wrote:
> Please review committed revision 11275 - tried to fix activations of task icons in the vi... Greg Shah

01:19 PM Bug #3425: text is drawn 1-pixel to the left, cutting the text

I cannot remember why I added that special processing. Most likely I adjusted that based on offset revealed when comp... Ovidiu Maxiniuc

01:13 PM Bug #3425: text is drawn 1-pixel to the left, cutting the text

> It seems that table labels are displayed 1-pixel left due to this code ClassicTheme.this.drawBrowseCellText
This... Stanislav Lomany

12:21 PM Bug #3425: text is drawn 1-pixel to the left, cutting the text

OK. It seems that table labels are displayed 1-pixel left due to this code @ClassicTheme.this.drawBrowseCellText@
<p... Sergey Ivanovskiy

11:15 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text

> Should I work on these browser issues?
Yes, but make sure you get input from Stanislav so that you don't cause r... Greg Shah

11:06 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text

Committed revision 11280(3394a) should fix the web text position along a horizontal. It seems that the other text pos... Sergey Ivanovskiy

09:40 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text

I didn't implement this function. Please explain the reasons that in the code below the text @x@-position coordinate ... Sergey Ivanovskiy

09:27 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text

The web client displays text in tables incorrectly too.
!TextInBrowser.png! Sergey Ivanovskiy

09:25 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text

It seems that header's and cell's content in tables incorrectly positioned. It can be observed for the web and swing ... Sergey Ivanovskiy

06:56 AM Bug #3425 (Closed): text is drawn 1-pixel to the left, cutting the text

Sergey Ivanovskiy

07:47 AM Bug #3381: Sub-menu drawing issues

Task branch @3394a@ has been updated for review to revision @11279@.
This change contains the fix for @ClassicThem... Eugenie Lyzenko

12/18/2017

06:29 PM Feature #3394: generic drawing improvements: repaint and other misc code

Sergey Ivanovskiy wrote:
> Constantin Asofiei wrote:
> >.. I ask because I have some more generic fixes related to ... Constantin Asofiei

12:28 PM Feature #3394: generic drawing improvements: repaint and other misc code

Please review committed revision 11275 - tried to fix activations of task icons in the virtual desktop. Sergey Ivanovskiy

03:11 PM Bug #3381: Sub-menu drawing issues

Code Review Task Branch 3394a Revisions 11276/11277
I like the approach. Greg Shah

12:58 PM Bug #3381: Sub-menu drawing issues

Task branch @3394a@ has been updated for review to revision @11276@, @11277@.
Added the ability to configure menu ... Eugenie Lyzenko

03:25 AM Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > > Can someone clarify what this code was added for? What is the ca... Hynek Cihlar

03:17 AM Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> Yes, but because in trunk there is no functionality to hide submenu once mouse is left the ... Hynek Cihlar

12/17/2017

05:50 PM Bug #3381: Sub-menu drawing issues

Greg Shah wrote:
> > Guys, the delay improves usability in cases when you navigate the menu by mouse. Without the de... Eugenie Lyzenko

12:43 PM Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> > Can someone clarify what this code was added for? What is the case the code become working. ... Eugenie Lyzenko

11:18 AM Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > Greg Shah wrote:
> > > Code Review Task Branch 3394a Revision 112... Greg Shah

09:14 AM Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > Hynek Cihlar wrote:
> > I think the root cause here is the 1-pixe... Eugenie Lyzenko

05:53 AM Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> Task branch @3394a@ has been updated for review to revision @11272@.
>
> This is the fix... Hynek Cihlar

05:00 AM Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > Eugenie, I think there is another regression in the menu bar. The ... Hynek Cihlar

04:57 AM Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> Greg Shah wrote:
> > Code Review Task Branch 3394a Revision 11267
> > ...
> > 1. Does th... Hynek Cihlar

04:52 AM Feature #3394: generic drawing improvements: repaint and other misc code

Sergey Ivanovskiy wrote:
> I guess that @config.showInTaskbar@ is always true for the regular desktop window and fal... Hynek Cihlar

12/16/2017

11:07 PM Bug #3381: Sub-menu drawing issues

Task branch @3394a@ has been updated for review to revision @11272@.
This is the fix for menu regressions/issues/n... Eugenie Lyzenko

12/15/2017

06:24 PM Feature #3394: generic drawing improvements: repaint and other misc code

3394a rev 11269 was rebased with trunk rev 11210. 3394a new rev is 11271. Constantin Asofiei

01:18 PM Feature #3394: generic drawing improvements: repaint and other misc code

This implementation of @WindowGuiImpl.this.isDesktopMinimized()@ is confusing ... Sergey Ivanovskiy

01:00 PM Feature #3394: generic drawing improvements: repaint and other misc code

I think that this implementation @WindowGuiImpl.iconify(postEvent)@ to iconify window is incorrect... Sergey Ivanovskiy

10:24 AM Feature #3394: generic drawing improvements: repaint and other misc code

Constantin Asofiei wrote:
>.. I ask because I have some more generic fixes related to focus window (which affect Swi... Sergey Ivanovskiy

05:57 PM Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> Eugenie, I think there is another regression in the menu bar. The delayed submenu hiding doesn... Eugenie Lyzenko

04:52 PM Bug #3381: Sub-menu drawing issues

Task branch @3394a@ has been updated for review to revision @11268@.
Undo for menu show/hide delay implementation.... Eugenie Lyzenko

03:48 PM Bug #3381: Sub-menu drawing issues

Greg Shah wrote:
> Please comment out the delay code to disable it. I want to ensure it can be added later if neede... Eugenie Lyzenko

03:30 PM Bug #3381: Sub-menu drawing issues

Please comment out the delay code to disable it. I want to ensure it can be added later if needed, but for now I pre... Greg Shah

03:23 PM Bug #3381: Sub-menu drawing issues

Greg Shah wrote:
> Code Review Task Branch 3394a Revision 11267
> ...
> 1. Does the delay implementation improve t... Eugenie Lyzenko

11:58 AM Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> Another exception when menu bar menu item is mouse-highlighted and arrow keys pressed.
>
> ... Sergey Ivanovskiy

06:39 AM Bug #3381: Sub-menu drawing issues

Eugenie, I think there is another regression in the menu bar. The delayed submenu hiding doesn't seem to apply there ... Hynek Cihlar

06:37 AM Bug #3381: Sub-menu drawing issues

Another exception when menu bar menu item is mouse-highlighted and arrow keys pressed.... Hynek Cihlar

06:22 AM Bug #3381: Sub-menu drawing issues

Code Review Task Branch 3394a Revision 11267
The delay implementation seems good. I'm still not sure I like havin... Greg Shah

06:12 AM Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> We used message box for testing and issue resolution purpose, isn't it? It is not a part of... Hynek Cihlar

11:19 PM Bug #3381: Sub-menu drawing issues

Task branch @3394a@ has been updated for review to revision @11267@.
Greg,
This is the approach I suggest to us... Eugenie Lyzenko

12/14/2017

06:50 PM Bug #3381: Sub-menu drawing issues

Task branch @3394a@ has been updated for review to revision @11266@.
The review notes resolution. The code in @Ove... Eugenie Lyzenko

06:35 PM Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> Code review the #3381 changes in task branch 3394a.
> ...
> The body of @onKeyPressed()@ is ... Eugenie Lyzenko

04:09 PM Bug #3381: Sub-menu drawing issues

Greg Shah wrote:
> > The only thing left in this area is to implement the delay between menu status change and mouse... Eugenie Lyzenko

09:17 AM Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> Please rebuild all. I still unable to recreate this. Pressing title bar caused the menu to ... Hynek Cihlar

08:59 AM Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > What is your testing environment? Swing client, Web client or both... Eugenie Lyzenko

08:56 AM Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> Code review the #3381 changes in task branch 3394a.
> [...]
> In the code above, shouldn't t... Eugenie Lyzenko

07:58 AM Bug #3381: Sub-menu drawing issues

Another regression with the window menu bar. Run the @uast/menu/Menubar.p@ try to navigate the menu, an exception bel... Hynek Cihlar

07:53 AM Bug #3381: Sub-menu drawing issues

Another problem is that the popup menu cannot be navigated by keyboard. However this probably exists in trunk, too. Hynek Cihlar

07:52 AM Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> What is your testing environment? Swing client, Web client or both?
I can see this only ... Hynek Cihlar

07:43 AM Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > Hynek Cihlar wrote:
> > > There is a regression caused by the cha... Eugenie Lyzenko

07:39 AM Bug #3381: Sub-menu drawing issues

Code review the #3381 changes in task branch 3394a.
MenuItemGuiImpl.selectMenuItem... Hynek Cihlar

07:06 AM Bug #3381: Sub-menu drawing issues

Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > There is a regression caused by the changes. When the popup is dis... Hynek Cihlar

07:04 AM Bug #3381: Sub-menu drawing issues

Hynek Cihlar wrote:
> There is a regression caused by the changes. When the popup is displayed and another window (o... Eugenie Lyzenko

06:04 AM Bug #3381: Sub-menu drawing issues

There is a regression caused by the changes. When the popup is displayed and another window (or the title bar of the ... Hynek Cihlar

05:20 AM Bug #3381: Sub-menu drawing issues

> The only thing left in this area is to implement the delay between menu status change and mouse enter/leave the sub... Greg Shah

10:09 PM Bug #3381: Sub-menu drawing issues

Task branch @3394a@ has been updated for review to revision @11265@.
This update adds hover base show/hide pop-up ... Eugenie Lyzenko

12/13/2017

03:44 PM Bug #3381: Sub-menu drawing issues

Task branch @3394a@ has been updated for review to revision @11264@.
Added fix for sub menu hiding issues as react... Eugenie Lyzenko

09:31 PM Bug #3381: Sub-menu drawing issues

Task branch @3394a@ has been updated for review to revision @11259@.
This is the fix for @"Export" item doesn't di... Eugenie Lyzenko

09:35 AM Feature #3394: generic drawing improvements: repaint and other misc code

Constantin Asofiei wrote:
> Does the same bug happen on the Web client, too? I ask because I have some more generic... Sergey Ivanovskiy

09:22 AM Feature #3394: generic drawing improvements: repaint and other misc code

Sergey Ivanovskiy wrote:
> Sergey Ivanovskiy wrote:
> > It seems that the root cause of the combo box issue is the ... Constantin Asofiei

09:03 AM Feature #3394: generic drawing improvements: repaint and other misc code

Sergey Ivanovskiy wrote:
> It seems that the root cause of the combo box issue is the current focus window is still ... Sergey Ivanovskiy

08:35 AM Feature #3394: generic drawing improvements: repaint and other misc code

It seems that the root cause of the combo box issue is the current focus window is still a drop down overlay when the... Sergey Ivanovskiy

12/12/2017

09:42 AM Feature #3394: generic drawing improvements: repaint and other misc code

OK. Related to the Hotel GUI I didn't detect artifacts except the focus traversal chain started from the opened dropd... Sergey Ivanovskiy

09:26 AM Feature #3394: generic drawing improvements: repaint and other misc code

> > In the current version of 3394a (rev 11256) there is at least one known regression related to the combo box dropd... Greg Shah

08:44 AM Feature #3394: generic drawing improvements: repaint and other misc code

Sergey Ivanovskiy wrote:
> In the current version of 3394a (rev 11256) there is at least one known regression relate... Sergey Ivanovskiy

07:30 AM Feature #3394: generic drawing improvements: repaint and other misc code

OK, thank you. Sergey Ivanovskiy

07:28 AM Feature #3394: generic drawing improvements: repaint and other misc code

Quantity of radio buttons should match the maximum number of guests for the selected room type. So far I see no issues. Stanislav Lomany

07:24 AM Feature #3394: generic drawing improvements: repaint and other misc code

I am just looking into it but if we open Update Reservation for rooms with 3 and 4 guests, then this dialog displays ... Sergey Ivanovskiy

07:15 AM Feature #3394: generic drawing improvements: repaint and other misc code

Sergey Ivanovskiy wrote:
> There is an issue with radio buttons.
> !RadioButtonsGroup.png!
Please describe it.
... Constantin Asofiei

07:02 AM Feature #3394: generic drawing improvements: repaint and other misc code

There is an issue with radio buttons.
!RadioButtonsGroup.png!
Sergey Ivanovskiy

06:05 AM Feature #3394: generic drawing improvements: repaint and other misc code

Please review these minor changes in the committed revision 11257 that discarded PainEvents with empty update rectang... Sergey Ivanovskiy

05:14 AM Feature #3394: generic drawing improvements: repaint and other misc code

Constantin, empty rectangles are generated from size or another updates on @widget.repaint()@. Please look at this lo... Sergey Ivanovskiy

04:48 AM Feature #3394: generic drawing improvements: repaint and other misc code

In the current version of 3394a (rev 11256) there is at least one known regression related to the combo box dropdown ... Sergey Ivanovskiy

09:08 PM Bug #3381: Sub-menu drawing issues

Task branch @3394a@ has been updated for review to revision @11256@.
The fix for @Windows10@ selected menu item ba... Eugenie Lyzenko

07:46 PM Bug #3381: Sub-menu drawing issues

Task branch @3394a@ has been updated for review to revision @11255@.
This update include several painting issues i... Eugenie Lyzenko

12/11/2017

02:56 PM Feature #3394: generic drawing improvements: repaint and other misc code

Constantin, your changes fixed the tree control and all date picker issues. Thank you for help. There are only visibl... Sergey Ivanovskiy

02:37 PM Feature #3394: generic drawing improvements: repaint and other misc code

Sergey Ivanovskiy wrote:
> OK. Did you try to draw sequence diagrams related to drawings? It seems there are differe... Constantin Asofiei

02:32 PM Feature #3394: generic drawing improvements: repaint and other misc code

OK. Did you try to draw sequence diagrams related to drawings? It seems there are different scenarios that can invoke... Sergey Ivanovskiy

02:23 PM Feature #3394: generic drawing improvements: repaint and other misc code

Sergey, when you mentioned the @afterConfigUpdateBase@, it got me thinking... we need to post physical boundaries and... Constantin Asofiei

09:23 AM Feature #3394: generic drawing improvements: repaint and other misc code

This trace should be discussed too... Sergey Ivanovskiy

08:44 AM Feature #3394: generic drawing improvements: repaint and other misc code

Constantin, you are correct that @AbstractWidget.afterConfigUpdateBase@ (trunc version) looks incorrect because of @p... Sergey Ivanovskiy

05:16 AM Feature #3394: generic drawing improvements: repaint and other misc code

It looks like a bug that for a date picker button defined by... Sergey Ivanovskiy

04:51 AM Feature #3394: generic drawing improvements: repaint and other misc code

This function of @OutputManager@... Sergey Ivanovskiy

02:17 PM Bug #3381: Sub-menu drawing issues

> No there is no such line in @FWD@. Can you remember when you saw it last time?
I guess somewhere between revisio... Stanislav Lomany

12:07 PM Bug #3381: Sub-menu drawing issues

Stanislav,
From your picture I can see vertical line in @Windows10@ theme:
!missing_vert_win10.jpg!
No there... Eugenie Lyzenko

12/09/2017

07:43 AM Bug #3382: Client-side popup menus abend

Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > Guys,
> >
> > I'm just trying to run browse pop-up test in my W... Eugenie Lyzenko

04:19 AM Bug #3382: Client-side popup menus abend

Eugenie Lyzenko wrote:
> Guys,
>
> I'm just trying to run browse pop-up test in my Windows devbox. And has abend ... Hynek Cihlar

08:06 PM Bug #3382: Client-side popup menus abend

Guys,
I'm just trying to run browse pop-up test in my Windows devbox. And has abend from inability to open temp t... Eugenie Lyzenko

10:01 PM Bug #3381: Sub-menu drawing issues

4GL level1 menu opening:
!sub_menu1_level1.jpg!
4GL level2 menu opening:
!sub_menu1_level2.jpg! Eugenie Lyzenko

12/08/2017

04:25 PM Feature #3394: generic drawing improvements: repaint and other misc code

Constantin, no, updates for combo boxes and tree and another widgets are different issues. I didn't solve them. This ... Sergey Ivanovskiy

04:20 PM Feature #3394: generic drawing improvements: repaint and other misc code

Sergey Ivanovskiy wrote:
> Please review committed revision 11249 (3394a) that should discard empty rectangles from ... Constantin Asofiei

03:22 PM Feature #3394: generic drawing improvements: repaint and other misc code

Please review committed revision 11249 (3394a) that should discard empty rectangles from @SceenBitmap@. It seems that... Sergey Ivanovskiy

12:11 PM Feature #3394: generic drawing improvements: repaint and other misc code

Please clarify what is incorrect in setNewSelection?
I traced @ScrenBitmap.this.setState@ and found many cases wit... Sergey Ivanovskiy

08:50 AM Feature #3394: generic drawing improvements: repaint and other misc code

Sergey Ivanovskiy wrote:
> The following changes can help to fix combo box updates
> [...]
> but I found another p... Constantin Asofiei

08:39 AM Feature #3394: generic drawing improvements: repaint and other misc code

But it is possible that these empty clipping rectangles have been incorrectly added to @ScreenBitmap@. It needs to fi... Sergey Ivanovskiy

05:27 AM Feature #3394: generic drawing improvements: repaint and other misc code

Sergey Ivanovskiy wrote:
> I changed coordinates in #3394-41. The rectangle is empty and is invalid but if it is pas... Constantin Asofiei

05:26 AM Feature #3394: generic drawing improvements: repaint and other misc code

Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > I meant the existing definition of @NativeRectangle.this.e... Sergey Ivanovskiy

05:22 AM Feature #3394: generic drawing improvements: repaint and other misc code

Sergey Ivanovskiy wrote:
> Constantin Asofiei wrote:
> > See @CombobBox.setValue@ and other @setValue@ for i.e. sel... Constantin Asofiei

05:21 AM Feature #3394: generic drawing improvements: repaint and other misc code

Constantin Asofiei wrote:
> See @CombobBox.setValue@ and other @setValue@ for i.e. selection-list and other widgets ... Sergey Ivanovskiy

05:16 AM Feature #3394: generic drawing improvements: repaint and other misc code

Sergey Ivanovskiy wrote:
> I meant the existing definition of @NativeRectangle.this.empty()@ which is correct.
I do... Constantin Asofiei

05:13 AM Feature #3394: generic drawing improvements: repaint and other misc code

I meant the existing definition of @NativeRectangle.this.empty()@ which is correct. Sergey Ivanovskiy

05:10 AM Feature #3394: generic drawing improvements: repaint and other misc code

Yes I mean @NativeRectangle@, but @Rectangle@ has the same issue. To clarify this bug with empty rectangles let us co... Sergey Ivanovskiy

05:07 AM Feature #3394: generic drawing improvements: repaint and other misc code

Sergey Ivanovskiy wrote:
> Yes, and the fact that the month combo box is not repainted with actual value.
See @Comb... Constantin Asofiei

04:58 AM Feature #3394: generic drawing improvements: repaint and other misc code

Yes, and the fact that the month combo box is not repainted with actual value.
It seems that the @NativeRectangle.... Sergey Ivanovskiy

04:56 AM Feature #3394: generic drawing improvements: repaint and other misc code

Sergey Ivanovskiy wrote:
> Please look at this picture date_picker.mkv.
You refer to the border artefacts around th... Constantin Asofiei

04:43 AM Feature #3394: generic drawing improvements: repaint and other misc code

Please look at this picture date_picker.mkv. Sergey Ivanovskiy

03:02 PM Bug #3382: Client-side popup menus abend

Hynek Cihlar wrote:
>
> In your last change you used the menu popup location passed to @Menu.showPopup()@, which a... Eugenie Lyzenko

12:40 PM Bug #3382: Client-side popup menus abend

Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > Yes, the coordinates must be taken from the mouse event causing th... Hynek Cihlar

10:42 AM Bug #3382: Client-side popup menus abend

Hynek Cihlar wrote:
> Yes, the coordinates must be taken from the mouse event causing the popup to come up and not f... Eugenie Lyzenko

06:57 AM Bug #3382: Client-side popup menus abend

Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > Eugenie, why not to get the location from the mouse event? What if... Hynek Cihlar

04:47 AM Bug #3382: Client-side popup menus abend

Hynek Cihlar wrote:
> Eugenie, why not to get the location from the mouse event? What if the popup isn't actually di... Eugenie Lyzenko

02:57 AM Bug #3382: Client-side popup menus abend

Eugenie Lyzenko wrote:
> Task branch @3394a@ has been updated for review to revision @11247@.
>
> Fixed the bar s... Hynek Cihlar

08:10 PM Bug #3382: Client-side popup menus abend

Task branch @3394a@ has been updated for review to revision @11247@.
Fixed the bar scrolling initiated from pop-up... Eugenie Lyzenko

12/07/2017

03:32 PM Feature #3394: generic drawing improvements: repaint and other misc code

Sergey Ivanovskiy wrote:
> OK, I lost the conception of redrawing if the business methods change some widget (its po... Constantin Asofiei

03:32 PM Feature #3394: generic drawing improvements: repaint and other misc code

Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > This resize rectangle is displayed forever after its appea... Eugenie Lyzenko

03:25 PM Feature #3394: generic drawing improvements: repaint and other misc code

OK, I lost the conception of redrawing if the business methods change some widget (its position, its size, its conten... Sergey Ivanovskiy

03:18 PM Feature #3394: generic drawing improvements: repaint and other misc code

Sergey Ivanovskiy wrote:
> This resize rectangle is displayed forever after its appearance on double click at the fr... Constantin Asofiei

03:17 PM Feature #3394: generic drawing improvements: repaint and other misc code

Sergey Ivanovskiy wrote:
> Please answer to this conceptual question. What is the meaning of this flag and when it c... Constantin Asofiei

02:53 PM Feature #3394: generic drawing improvements: repaint and other misc code

Please answer to this conceptual question. What is the meaning of this flag and when it can be used (@BaseConfig@)? C... Sergey Ivanovskiy

02:50 PM Feature #3394: generic drawing improvements: repaint and other misc code

This resize rectangle is displayed forever after its appearance on double click at the frame space right to the last ... Sergey Ivanovskiy

02:47 PM Feature #3394: generic drawing improvements: repaint and other misc code

Don't know it is an answer. The frame is @folder-frm 27 Dimension[126.0,16.43] Point[0.0,1.0] visible true can false;... Sergey Ivanovskiy

02:33 PM Feature #3394: generic drawing improvements: repaint and other misc code

Sergey Ivanovskiy wrote:
> With the current version the main tab frame can be resizable and resize or editor grid is... Constantin Asofiei

02:22 PM Feature #3394: generic drawing improvements: repaint and other misc code

With the current version the main tab frame can be resizable and resize or editor grid is displayed. It wasn't observ... Sergey Ivanovskiy

09:54 AM Feature #3394: generic drawing improvements: repaint and other misc code

Don't mind, I answered by myself. Sergey Ivanovskiy

09:44 AM Feature #3394: generic drawing improvements: repaint and other misc code

Please help to answer why in this code adatesd0.w for the date picker the x and y coordinates for the selected date r... Sergey Ivanovskiy

01:29 PM Bug #3382: Client-side popup menus abend

Hynek Cihlar wrote:
>When you are at the changes can you make sure the key input works correctly? I am getting an ex... Eugenie Lyzenko

04:00 AM Bug #3382: Client-side popup menus abend

Eugenie Lyzenko wrote:
> Well, looks like I have found alternative approach. So the set of changes:
I like that. ... Hynek Cihlar

11:52 PM Bug #3382: Client-side popup menus abend

Well, looks like I have found alternative approach. So the set of changes:
1. No using @invokeLater()@ to avoid chan... Eugenie Lyzenko

12/06/2017

05:12 PM Bug #3382: Client-side popup menus abend

Eugenie Lyzenko wrote:
> If adapter @adapter.mouseClicked(e)@ calls body that has @invokeLater@ wrapper the result w... Hynek Cihlar

05:06 PM Bug #3382: Client-side popup menus abend

Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> >
> > (2) Enqueue only the call to @TC.messageBox()@ in the mouse ... Hynek Cihlar

05:05 PM Bug #3382: Client-side popup menus abend

Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > This is exactly how it is currently implemented. Pop-up @ScrollPop... Eugenie Lyzenko

04:57 PM Bug #3382: Client-side popup menus abend

Hynek Cihlar wrote:
>
> (2) Enqueue only the call to @TC.messageBox()@ in the mouse adapter body. Less impact on t... Eugenie Lyzenko

04:50 PM Bug #3382: Client-side popup menus abend

Eugenie Lyzenko wrote:
> This is exactly how it is currently implemented. Pop-up @ScrollPopupGuiImpl.mouseClicked()@... Hynek Cihlar

04:39 PM Bug #3382: Client-side popup menus abend

Hynek Cihlar wrote:
> > In this case we have null parent again because @invokeLater()@ defer click handler to the mo... Eugenie Lyzenko

04:36 PM Bug #3382: Client-side popup menus abend

Eugenie Lyzenko wrote:
> Yes, at least scrolling down by pop-up menu does not work.
I think there are two options... Hynek Cihlar

04:30 PM Bug #3382: Client-side popup menus abend

Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > But if we postpone click processing to the end - we have dismissed... Eugenie Lyzenko

04:27 PM Bug #3382: Client-side popup menus abend

Eugenie Lyzenko wrote:
> But if we postpone click processing to the end - we have dismissed menu when it should exis... Hynek Cihlar

04:17 PM Bug #3382: Client-side popup menus abend

Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > Hynek Cihlar wrote:
> >
> > In fact I don't see any reason the ... Hynek Cihlar

03:32 PM Bug #3382: Client-side popup menus abend

Hynek Cihlar wrote:
> Hynek Cihlar wrote:
>
> In fact I don't see any reason the ordering should not be enforced ... Eugenie Lyzenko

01:55 PM Bug #3382: Client-side popup menus abend

Hynek Cihlar wrote:
> > Another word you mean every possible code (we will remove @ThinClient.messageBox()@ from fin... Hynek Cihlar

01:31 PM Bug #3382: Client-side popup menus abend

Eugenie Lyzenko wrote:
> What I do not understand here is why we are committed to @ThinClient.messageBox()@? This is... Hynek Cihlar

12:20 PM Bug #3382: Client-side popup menus abend

Hynek Cihlar wrote:
>
> The call to @ThinClient.messageBox()@ must be executed in @ThinClient.invokeLater@ so that... Eugenie Lyzenko

12:04 PM Bug #3382: Client-side popup menus abend

Eugenie Lyzenko wrote:
> Unfortunately this is not enough to fix the issue. Moving @MenuItemGuiImpl.selectMenuItem()... Hynek Cihlar

09:49 PM Bug #3382: Client-side popup menus abend

Unfortunately this is not enough to fix the issue. Moving @MenuItemGuiImpl.selectMenuItem()@ before @ScrollPopupGuiIm... Eugenie Lyzenko

03:25 PM Feature #3394: generic drawing improvements: repaint and other misc code

Sergey Ivanovskiy wrote:
> With the current 3394a the Hotel GUI Check-in date picker doesn't repaint items correctly... Constantin Asofiei

03:24 PM Feature #3394: generic drawing improvements: repaint and other misc code

With the current 3394a the Hotel GUI Check-in date picker doesn't repaint items correctly if the current month (year)... Sergey Ivanovskiy

12/05/2017

02:34 PM Bug #3382: Client-side popup menus abend

Eugenie Lyzenko wrote:
> You mean execution @selectMenuItem()@ first, then mouse adapters?
Exactly so. Hynek Cihlar

05:55 AM Bug #3382: Client-side popup menus abend

Hynek Cihlar wrote:
> Please try to move the execution of mouse adapters in @MenuItemGuiImpl.mouseClicked@ before @s... Eugenie Lyzenko

04:29 AM Bug #3382: Client-side popup menus abend

Eugenie Lyzenko wrote:
> So the suggested fix approach can be the following change in @ThinClient.invokeTriggers(...... Hynek Cihlar

09:35 PM Bug #3382: Client-side popup menus abend

So the suggested fix approach can be the following change in @ThinClient.invokeTriggers(...)@, line starting at @1822... Eugenie Lyzenko

12/04/2017

06:36 PM Bug #3382: Client-side popup menus abend

Debugging result. The current events data flow:
1. After the user clicks on @Scroll here@ pop up menu from scrollb... Eugenie Lyzenko

04:00 PM Feature #3394: generic drawing improvements: repaint and other misc code

Sergey Ivanovskiy wrote:
> The order of repaints can be the root cause?
No, as they just determine which widgets wi... Constantin Asofiei

03:27 PM Feature #3394: generic drawing improvements: repaint and other misc code

The order of repaints can be the root cause? Sergey Ivanovskiy

03:25 PM Feature #3394: generic drawing improvements: repaint and other misc code

Updated #3394-18 with correct logs. Yes, they are 121 and 124. Sergey Ivanovskiy

03:10 PM Feature #3394: generic drawing improvements: repaint and other misc code

Sergey Ivanovskiy wrote:
> Finally, the last two nodes: "Twin" and "Luxury Suite " were not repainted.
Do you now t... Constantin Asofiei

03:08 PM Feature #3394: generic drawing improvements: repaint and other misc code

Yes, I tested Hotel GUI Add Room Dialog and opened the first node and then opened the second node. Finally, the last ... Sergey Ivanovskiy

01:38 PM Feature #3394: generic drawing improvements: repaint and other misc code

Sergey Ivanovskiy wrote:
> Interesting note if setup conditional breakpoints for the tree control widgets in @Abstra... Constantin Asofiei

01:35 PM Feature #3394: generic drawing improvements: repaint and other misc code

Interesting note if setup conditional breakpoints for the tree control widgets in @AbstractWidget.afterConfigUpdateBa... Sergey Ivanovskiy

03:57 PM Bug #2766: implement a text metrics server process

Code Review Task Branch 3394a Revisions 11232/11233
I'm good with the changes. Greg Shah

02:36 PM Bug #2766: implement a text metrics server process

Greg, please review 3394a rev 11232/11233. Constantin Asofiei

01:27 PM Bug #2766: implement a text metrics server process

Greg Shah wrote:
> You recently added the captured @text-metrics.xml@ to the project. Was there a problem that drov... Constantin Asofiei

01:21 PM Bug #2766: implement a text metrics server process

> Another note: currently FontManager reads the entire font-table (~46k strings) into the client-side's memory. In th... Greg Shah

01:18 PM Bug #2766: implement a text metrics server process

I was not using the properly derived font (as Swing was doing) when computing the metrics. With current changes, the... Constantin Asofiei

10:52 AM Bug #2766: implement a text metrics server process

Some quick and dirty changes in web code allow AWT Font and FontMetrics to be used. But I think I'm not using the co... Constantin Asofiei

08:02 AM Bug #2766: implement a text metrics server process

Agreed. Greg Shah

06:26 AM Bug #2766: implement a text metrics server process

Greg Shah wrote:
> Another approach might be to use caching for the calculated metrics. This would have to be done ... Constantin Asofiei

06:14 AM Bug #2766: implement a text metrics server process

I agree we should resolve this.
If we can calculate suitable metrics in the Java client, I would be fine with that... Greg Shah

06:05 AM Bug #2766: implement a text metrics server process

In addition to the functional issues we see from deviations from the Windows metrics when encountering dynamic text, ... Greg Shah