Activity
From 12/05/2017 to 01/03/2018
01/04/2018
- 07:45 PM Bug #3381: Sub-menu drawing issues
- Task branch @3381a@ has been updated for review to revision @11215@.
This is the fix for notes @2@ and @4@ in rema...
01/03/2018
- 05:09 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
- Greg Shah wrote:
> Constantin:
>
> * Is my recollection correct?
Almost; this is always problematic when buildi... - 04:55 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
- FYI, here's what the same use case looks like on the client, starting at @BitSet.clear@ <- @BitSet.set@ <- @ConfigMan...
- 04:26 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
- Greg Shah wrote:
> Instead of looking at AspectJ, perhaps we can come up with an alternate approach. What about a g... - 03:36 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
- The following screenshot was taken by ECF during his work on profiling the initial load of a complex ADM screen:
!... - 02:47 PM Bug #3381: Sub-menu drawing issues
- Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > 4. Item 3 from note 60 is still an issue.
>
> I do not have thi... - 08:53 AM Bug #3381: Sub-menu drawing issues
- Hynek Cihlar wrote:
> 4. Item 3 from note 60 is still an issue.
I do not have this one. If you mean: @3. When a m...
01/02/2018
- 02:48 PM Bug #3381: Sub-menu drawing issues
- Created task branch @3381a@ from trunk revision @11214@.
12/28/2017
- 01:52 PM Bug #3348 (Closed): The opened dropdown influences on the choice for the next tab widget for its ...
- 01:46 PM Bug #3348: The opened dropdown influences on the choice for the next tab widget for its combobox
- No, it was fixed in 3394a.
- 01:03 PM Bug #3348: The opened dropdown influences on the choice for the next tab widget for its combobox
- Does this issue still exist in trunk revision 11214?
- 01:35 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
- This branch needs a rebase. Do you still believe it is safe to merge to trunk? Another option is to merge it into 3...
- 12:29 PM Bug #3381: Sub-menu drawing issues
- Hynek Cihlar wrote:
> Greg Shah wrote:
> > The changes are included in task branch 3394a which has been merged to t... - 11:19 AM Bug #3381: Sub-menu drawing issues
- Greg Shah wrote:
> The changes are included in task branch 3394a which has been merged to trunk as revision 11214.
... - 11:14 AM Bug #3381: Sub-menu drawing issues
- The changes are included in task branch 3394a which has been merged to trunk as revision 11214.
Hynek: Do you have... - 11:14 AM Bug #3382: Client-side popup menus abend
- The changes are included in task branch 3394a which has been merged to trunk as revision 11214.
Can I close this t... - 11:13 AM Bug #2766: implement a text metrics server process
- The improvements for web client font metrics processing are included in task branch 3394a which has been merged to tr...
- 11:12 AM Bug #3373: incremental scroll in non-full Browse page
- The changes are included in task branch 3394a which has been merged to trunk as revision 11214.
- 11:11 AM Bug #3401 (Closed): clarifications for windows related methods in Widget and GuiDriver classes
- The changes are included in task branch 3394a which has been merged to trunk as revision 11214.
- 10:57 AM Feature #3394 (Closed): generic drawing improvements: repaint and other misc code
- 10:57 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Task branch 3394a has been merged to trunk as revision 11214.
I've archived 3394a. - 09:13 AM Feature #3394: generic drawing improvements: repaint and other misc code
- The only overlap this time is tc_job_clock_004 which was expected to fail due to the time of the run. At this point ...
- 03:17 AM Feature #3394: generic drawing improvements: repaint and other misc code
- The next run of ChUI regression completed. Only 2 failures overlapped. Both of those are likely false negatives, ti...
- 09:29 PM Feature #3394: generic drawing improvements: repaint and other misc code
- I've done one run of main ChUI regression testing. 6 unexpected failures occurred, but they all seem like false nega...
- 03:20 AM Feature #2368: allow widget output to stream in GUI mode
- I'm OK with the approach, it seems correct.
12/27/2017
- 04:03 PM Feature #2368: allow widget output to stream in GUI mode
- Hynek Cihlar wrote:
> The named stream redirection seems to work OK since the streamable OM in the GUI OM is redirec... - 08:50 AM Bug #3373 (Closed): incremental scroll in non-full Browse page
- Fixed in branch 3394a revision 11298 which will be merged to trunk shortly.
12/26/2017
- 03:47 PM Feature #3394: generic drawing improvements: repaint and other misc code
- 3394a/11309 has passed ETF full search, developer, and batch tests.
- 10:42 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Constantin Asofiei wrote:
> Please try 3394a 11309 - I think I had an unbalanced scope start/delete in SVM.
That di... - 04:06 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Eric Faulhaber wrote:
> There is a regression in task branch 3394a. ETF search testing grinds to a halt after a few ...
12/25/2017
- 04:03 PM Feature #3394: generic drawing improvements: repaint and other misc code
- There is a regression in task branch 3394a. ETF search testing grinds to a halt after a few minutes with multiple "No...
12/23/2017
- 05:33 PM Feature #2368: allow widget output to stream in GUI mode
- Constantin Asofiei wrote:
> Hynek, can you give me a simple standalone test which shows a few of the failures you de... - 04:10 PM Feature #2368: allow widget output to stream in GUI mode
- Hynek, can you give me a simple standalone test which shows a few of the failures you describe in the previous note?
- 09:59 AM Feature #2368: allow widget output to stream in GUI mode
- There are numerous places where @ClassCastException@ is thrown when in GUI redirected mode and an @ALERT-BOX@ or an e...
- 04:22 AM Bug #3373 (Review): incremental scroll in non-full Browse page
12/22/2017
- 11:34 AM Feature #3394: generic drawing improvements: repaint and other misc code
- I've tested 3394a revision 11307 with Hotel GUI. It fixes the abend (Check-In then Add) and it fixes the tree contro...
- 08:33 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Rebased 3394a from trunk rev 11213 - new revision 11304.
3394a rev 11305 contains javadoc and history header fixes. - 10:08 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- > So, rollback these two revisions in 3394a and commit them.
Done. - 09:23 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- Stanislav Lomany wrote:
> > Stanislav: Please take this task. Please remove the changes for 11296/11297 such that i... - 09:23 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- > Do you want me to revert 11296/11297 and then you merge 3394 and I check into another branch
This one. The fix ... - 09:21 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- > Stanislav: Please take this task. Please remove the changes for 11296/11297 such that it won't cause regressions. ...
- 09:13 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- Greg Shah wrote:
> Stanislav: Please take this task. Please remove the changes for 11296/11297 such that it won't c... - 09:09 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- Stanislav: Please take this task. Please remove the changes for 11296/11297 such that it won't cause regressions. I...
- 09:07 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- Is this code from @BrowseGuiImpl.doLayout()@ correct?...
- 08:49 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- Stanislav Lomany wrote:
> > Stanislav, please describe font settings thoroughly, what are fonts without anti-aliasin... - 08:22 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- > Stanislav, please describe font settings thoroughly, what are fonts without anti-aliasing?
I don't know, but th... - 08:12 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- The rev.11297, 11301 don't make changes for column widths. It is supposed that they are calculated correctly.
- 08:03 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- Did you build a font-metrics file for the strings from your test?
- 08:01 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- Stanislav Lomany wrote:
> It is not clear if actual P2J version (rev 11295) has issues with clipping (please use fon... - 07:43 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- It is not clear if actual P2J version (rev 11295) has issues with clipping (please use fonts without anti-aliasing fo...
- 07:10 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- I'm not good, wait a bit.
- 07:09 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- If Stanislav is OK with these changes, then we are good to go.
- 04:52 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- Yes. Agree, committed rev 11301.
- 08:24 PM Bug #3381: Sub-menu drawing issues
- Hynek Cihlar wrote:
> With the latest 3394a the multiple selection issue is fixed and the Esc key works properly. Ho...
12/21/2017
- 05:56 PM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- Greg Shah wrote:
> Stanislav/Hynek: please review.
Formally, I don't see anything wrong with the code. Maybe I wo... - 03:44 PM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- Code Review Task Branch 3394a Revisions 11296/7
I don't see a specific issue with the changes. However, the valid... - 03:12 PM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- Please review committed revision 11297.
- 02:40 PM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- Please review committed revision 11296 that should fix drawing of labels with help of #3394-88.
- 05:09 PM Bug #3381: Sub-menu drawing issues
- Hynek Cihlar wrote:
> I'll try to rephrase what the problem is. When you open a submenu body, none of the menu items... - 04:47 PM Bug #3381: Sub-menu drawing issues
- Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> >
> > Yes, this is it. You can see it in the gif close to the end ... - 04:42 PM Bug #3381: Sub-menu drawing issues
- Hynek Cihlar wrote:
>
> Yes, this is it. You can see it in the gif close to the end of the playback.
But in @FW... - 04:35 PM Bug #3381: Sub-menu drawing issues
- Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > 4. Menu item is highlighted when its submenu is opened, it should ... - 04:32 PM Bug #3381: Sub-menu drawing issues
- Hynek Cihlar wrote:
> 4. Menu item is highlighted when its submenu is opened, it should not be.
I do not understa... - 04:22 PM Bug #3381: Sub-menu drawing issues
- Eugenie Lyzenko wrote:
> > 2. There is a noticable lag when navigating from one root submenu to another, in native 4... - 04:20 PM Bug #3381: Sub-menu drawing issues
- Hynek Cihlar wrote:
> With the latest 3394a the multiple selection issue is fixed and the Esc key works properly. Ho... - 04:13 PM Bug #3381: Sub-menu drawing issues
- With the latest 3394a the multiple selection issue is fixed and the Esc key works properly. However there are some ne...
- 01:03 PM Bug #3381: Sub-menu drawing issues
- Task branch @3394a@ has been updated for review to revision @11295@.
This is new approach to control menu item sel... - 06:56 AM Bug #3381: Sub-menu drawing issues
- Code Review Task Branch 3394a Revision 11293
I'm OK with the changes.
> I think in 4GL the ESC handling is not... - 10:18 PM Bug #3381: Sub-menu drawing issues
- Task branch @3394a@ has been updated for review to revision @11293@.
This is suggested fix for @ESC@ key processin... - 02:20 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
- Code Review Task Branch 3369b Revision 11211
It is not clear why we need both @Coordinate.guiRound()@ and @Coordin... - 12:59 PM Feature #3369: add support for BGCOLOR-RGB and FGCOLOR-RGB, FWD extension widget attributes
- 3369b replaces all UI coordinate roundings implemented by @BigDecimal@ with more primitive constructs, like @java.mat...
- 07:22 AM Feature #3394: generic drawing improvements: repaint and other misc code
- 3394a revision 11294 fixes browse column widths due to incorrectly resolved column font.
12/20/2017
- 01:53 PM Bug #3381: Sub-menu drawing issues
- Eugenie Lyzenko wrote:
> Fixes for issue except @ESC@ key press reaction, for which I still do not have the @4GL@ te... - 12:41 PM Bug #3381: Sub-menu drawing issues
- Task branch @3394a@ has been updated for review to revision @11291@.
Fixes for issue except @ESC@ key press reacti... - 11:32 AM Bug #3381: Sub-menu drawing issues
- Hynek Cihlar wrote:
>
> Another point is the way the menu bar should handle Esc key. On the first Esc press the su... - 03:38 AM Bug #3381: Sub-menu drawing issues
- Hynek Cihlar wrote:
> With the revision there are still some issues with the main bar. Please see the attached gif.
... - 03:10 AM Bug #3381: Sub-menu drawing issues
- Eugenie Lyzenko wrote:
> Task branch @3394a@ has been updated for review to revision @11288@.
>
> This is the fix... - 12:50 AM Bug #3381: Sub-menu drawing issues
- Task branch @3394a@ has been updated for review to revision @11288@.
This is the fix for classic theme menu painti... - 09:28 PM Bug #3381: Sub-menu drawing issues
- There are some @UI@ painting deviations for classic theme implementation. Consider the following native Windows pictu...
- 08:38 PM Bug #3381: Sub-menu drawing issues
- Task branch @3394a@ has been updated for review to revision @11286@.
The minor changes to resolve menu related iss... - 04:00 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- Thank you, if we don't shift the text by 1 pixel to the left, then some table headers don't fit the column and some r...
- 03:50 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- The @text-metrics.xml@ for AW was last updated by Constantin on Tue 2017-11-28 22:20:15 +0200 as revno 110.
I don't... - 03:24 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- Ovidiu Maxiniuc wrote:
> It is possible that the font configuration to had been different. If it is wrong, please dr...
12/19/2017
- 02:47 PM Feature #3394: generic drawing improvements: repaint and other misc code
- Sergey Ivanovskiy wrote:
> OK, please review the committed revision 11282.
The changes look good. - 02:16 PM Feature #3394: generic drawing improvements: repaint and other misc code
- OK, please review the committed revision 11282.
- 11:10 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Greg Shah wrote:
> Sergey Ivanovskiy wrote:
> > Please review committed revision 11275 - tried to fix activations o... - 08:26 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Sergey Ivanovskiy wrote:
> Please review committed revision 11275 - tried to fix activations of task icons in the vi... - 01:19 PM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- I cannot remember why I added that special processing. Most likely I adjusted that based on offset revealed when comp...
- 01:13 PM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- > It seems that table labels are displayed 1-pixel left due to this code ClassicTheme.this.drawBrowseCellText
This... - 12:21 PM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- OK. It seems that table labels are displayed 1-pixel left due to this code @ClassicTheme.this.drawBrowseCellText@
<p... - 11:15 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- > Should I work on these browser issues?
Yes, but make sure you get input from Stanislav so that you don't cause r... - 11:06 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- Committed revision 11280(3394a) should fix the web text position along a horizontal. It seems that the other text pos...
- 09:40 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- I didn't implement this function. Please explain the reasons that in the code below the text @x@-position coordinate ...
- 09:27 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- The web client displays text in tables incorrectly too.
!TextInBrowser.png! - 09:25 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text
- It seems that header's and cell's content in tables incorrectly positioned. It can be observed for the web and swing ...
- 06:56 AM Bug #3425 (Closed): text is drawn 1-pixel to the left, cutting the text
- 07:47 AM Bug #3381: Sub-menu drawing issues
- Task branch @3394a@ has been updated for review to revision @11279@.
This change contains the fix for @ClassicThem...
12/18/2017
- 06:29 PM Feature #3394: generic drawing improvements: repaint and other misc code
- Sergey Ivanovskiy wrote:
> Constantin Asofiei wrote:
> >.. I ask because I have some more generic fixes related to ... - 12:28 PM Feature #3394: generic drawing improvements: repaint and other misc code
- Please review committed revision 11275 - tried to fix activations of task icons in the virtual desktop.
- 03:11 PM Bug #3381: Sub-menu drawing issues
- Code Review Task Branch 3394a Revisions 11276/11277
I like the approach. - 12:58 PM Bug #3381: Sub-menu drawing issues
- Task branch @3394a@ has been updated for review to revision @11276@, @11277@.
Added the ability to configure menu ... - 03:25 AM Bug #3381: Sub-menu drawing issues
- Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > > Can someone clarify what this code was added for? What is the ca... - 03:17 AM Bug #3381: Sub-menu drawing issues
- Eugenie Lyzenko wrote:
> Yes, but because in trunk there is no functionality to hide submenu once mouse is left the ...
12/17/2017
- 05:50 PM Bug #3381: Sub-menu drawing issues
- Greg Shah wrote:
> > Guys, the delay improves usability in cases when you navigate the menu by mouse. Without the de... - 12:43 PM Bug #3381: Sub-menu drawing issues
- Hynek Cihlar wrote:
> > Can someone clarify what this code was added for? What is the case the code become working. ... - 11:18 AM Bug #3381: Sub-menu drawing issues
- Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > Greg Shah wrote:
> > > Code Review Task Branch 3394a Revision 112... - 09:14 AM Bug #3381: Sub-menu drawing issues
- Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > Hynek Cihlar wrote:
> > I think the root cause here is the 1-pixe... - 05:53 AM Bug #3381: Sub-menu drawing issues
- Eugenie Lyzenko wrote:
> Task branch @3394a@ has been updated for review to revision @11272@.
>
> This is the fix... - 05:00 AM Bug #3381: Sub-menu drawing issues
- Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > Eugenie, I think there is another regression in the menu bar. The ... - 04:57 AM Bug #3381: Sub-menu drawing issues
- Eugenie Lyzenko wrote:
> Greg Shah wrote:
> > Code Review Task Branch 3394a Revision 11267
> > ...
> > 1. Does th... - 04:52 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Sergey Ivanovskiy wrote:
> I guess that @config.showInTaskbar@ is always true for the regular desktop window and fal...
12/16/2017
- 11:07 PM Bug #3381: Sub-menu drawing issues
- Task branch @3394a@ has been updated for review to revision @11272@.
This is the fix for menu regressions/issues/n...
12/15/2017
- 06:24 PM Feature #3394: generic drawing improvements: repaint and other misc code
- 3394a rev 11269 was rebased with trunk rev 11210. 3394a new rev is 11271.
- 01:18 PM Feature #3394: generic drawing improvements: repaint and other misc code
- This implementation of @WindowGuiImpl.this.isDesktopMinimized()@ is confusing ...
- 01:00 PM Feature #3394: generic drawing improvements: repaint and other misc code
- I think that this implementation @WindowGuiImpl.iconify(postEvent)@ to iconify window is incorrect...
- 10:24 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Constantin Asofiei wrote:
>.. I ask because I have some more generic fixes related to focus window (which affect Swi... - 05:57 PM Bug #3381: Sub-menu drawing issues
- Hynek Cihlar wrote:
> Eugenie, I think there is another regression in the menu bar. The delayed submenu hiding doesn... - 04:52 PM Bug #3381: Sub-menu drawing issues
- Task branch @3394a@ has been updated for review to revision @11268@.
Undo for menu show/hide delay implementation.... - 03:48 PM Bug #3381: Sub-menu drawing issues
- Greg Shah wrote:
> Please comment out the delay code to disable it. I want to ensure it can be added later if neede... - 03:30 PM Bug #3381: Sub-menu drawing issues
- Please comment out the delay code to disable it. I want to ensure it can be added later if needed, but for now I pre...
- 03:23 PM Bug #3381: Sub-menu drawing issues
- Greg Shah wrote:
> Code Review Task Branch 3394a Revision 11267
> ...
> 1. Does the delay implementation improve t... - 11:58 AM Bug #3381: Sub-menu drawing issues
- Hynek Cihlar wrote:
> Another exception when menu bar menu item is mouse-highlighted and arrow keys pressed.
>
> ... - 06:39 AM Bug #3381: Sub-menu drawing issues
- Eugenie, I think there is another regression in the menu bar. The delayed submenu hiding doesn't seem to apply there ...
- 06:37 AM Bug #3381: Sub-menu drawing issues
- Another exception when menu bar menu item is mouse-highlighted and arrow keys pressed....
- 06:22 AM Bug #3381: Sub-menu drawing issues
- Code Review Task Branch 3394a Revision 11267
The delay implementation seems good. I'm still not sure I like havin... - 06:12 AM Bug #3381: Sub-menu drawing issues
- Eugenie Lyzenko wrote:
> We used message box for testing and issue resolution purpose, isn't it? It is not a part of... - 11:19 PM Bug #3381: Sub-menu drawing issues
- Task branch @3394a@ has been updated for review to revision @11267@.
Greg,
This is the approach I suggest to us...
12/14/2017
- 06:50 PM Bug #3381: Sub-menu drawing issues
- Task branch @3394a@ has been updated for review to revision @11266@.
The review notes resolution. The code in @Ove... - 06:35 PM Bug #3381: Sub-menu drawing issues
- Hynek Cihlar wrote:
> Code review the #3381 changes in task branch 3394a.
> ...
> The body of @onKeyPressed()@ is ... - 04:09 PM Bug #3381: Sub-menu drawing issues
- Greg Shah wrote:
> > The only thing left in this area is to implement the delay between menu status change and mouse... - 09:17 AM Bug #3381: Sub-menu drawing issues
- Eugenie Lyzenko wrote:
> Please rebuild all. I still unable to recreate this. Pressing title bar caused the menu to ... - 08:59 AM Bug #3381: Sub-menu drawing issues
- Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > What is your testing environment? Swing client, Web client or both... - 08:56 AM Bug #3381: Sub-menu drawing issues
- Hynek Cihlar wrote:
> Code review the #3381 changes in task branch 3394a.
> [...]
> In the code above, shouldn't t... - 07:58 AM Bug #3381: Sub-menu drawing issues
- Another regression with the window menu bar. Run the @uast/menu/Menubar.p@ try to navigate the menu, an exception bel...
- 07:53 AM Bug #3381: Sub-menu drawing issues
- Another problem is that the popup menu cannot be navigated by keyboard. However this probably exists in trunk, too.
- 07:52 AM Bug #3381: Sub-menu drawing issues
- Eugenie Lyzenko wrote:
> What is your testing environment? Swing client, Web client or both?
I can see this only ... - 07:43 AM Bug #3381: Sub-menu drawing issues
- Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > Hynek Cihlar wrote:
> > > There is a regression caused by the cha... - 07:39 AM Bug #3381: Sub-menu drawing issues
- Code review the #3381 changes in task branch 3394a.
MenuItemGuiImpl.selectMenuItem... - 07:06 AM Bug #3381: Sub-menu drawing issues
- Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > There is a regression caused by the changes. When the popup is dis... - 07:04 AM Bug #3381: Sub-menu drawing issues
- Hynek Cihlar wrote:
> There is a regression caused by the changes. When the popup is displayed and another window (o... - 06:04 AM Bug #3381: Sub-menu drawing issues
- There is a regression caused by the changes. When the popup is displayed and another window (or the title bar of the ...
- 05:20 AM Bug #3381: Sub-menu drawing issues
- > The only thing left in this area is to implement the delay between menu status change and mouse enter/leave the sub...
- 10:09 PM Bug #3381: Sub-menu drawing issues
- Task branch @3394a@ has been updated for review to revision @11265@.
This update adds hover base show/hide pop-up ...
12/13/2017
- 03:44 PM Bug #3381: Sub-menu drawing issues
- Task branch @3394a@ has been updated for review to revision @11264@.
Added fix for sub menu hiding issues as react... - 09:31 PM Bug #3381: Sub-menu drawing issues
- Task branch @3394a@ has been updated for review to revision @11259@.
This is the fix for @"Export" item doesn't di... - 09:35 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Constantin Asofiei wrote:
> Does the same bug happen on the Web client, too? I ask because I have some more generic... - 09:22 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Sergey Ivanovskiy wrote:
> Sergey Ivanovskiy wrote:
> > It seems that the root cause of the combo box issue is the ... - 09:03 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Sergey Ivanovskiy wrote:
> It seems that the root cause of the combo box issue is the current focus window is still ... - 08:35 AM Feature #3394: generic drawing improvements: repaint and other misc code
- It seems that the root cause of the combo box issue is the current focus window is still a drop down overlay when the...
12/12/2017
- 09:42 AM Feature #3394: generic drawing improvements: repaint and other misc code
- OK. Related to the Hotel GUI I didn't detect artifacts except the focus traversal chain started from the opened dropd...
- 09:26 AM Feature #3394: generic drawing improvements: repaint and other misc code
- > > In the current version of 3394a (rev 11256) there is at least one known regression related to the combo box dropd...
- 08:44 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Sergey Ivanovskiy wrote:
> In the current version of 3394a (rev 11256) there is at least one known regression relate... - 07:30 AM Feature #3394: generic drawing improvements: repaint and other misc code
- OK, thank you.
- 07:28 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Quantity of radio buttons should match the maximum number of guests for the selected room type. So far I see no issues.
- 07:24 AM Feature #3394: generic drawing improvements: repaint and other misc code
- I am just looking into it but if we open Update Reservation for rooms with 3 and 4 guests, then this dialog displays ...
- 07:15 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Sergey Ivanovskiy wrote:
> There is an issue with radio buttons.
> !RadioButtonsGroup.png!
Please describe it.
... - 07:02 AM Feature #3394: generic drawing improvements: repaint and other misc code
- There is an issue with radio buttons.
!RadioButtonsGroup.png!
- 06:05 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Please review these minor changes in the committed revision 11257 that discarded PainEvents with empty update rectang...
- 05:14 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Constantin, empty rectangles are generated from size or another updates on @widget.repaint()@. Please look at this lo...
- 04:48 AM Feature #3394: generic drawing improvements: repaint and other misc code
- In the current version of 3394a (rev 11256) there is at least one known regression related to the combo box dropdown ...
- 09:08 PM Bug #3381: Sub-menu drawing issues
- Task branch @3394a@ has been updated for review to revision @11256@.
The fix for @Windows10@ selected menu item ba... - 07:46 PM Bug #3381: Sub-menu drawing issues
- Task branch @3394a@ has been updated for review to revision @11255@.
This update include several painting issues i...
12/11/2017
- 02:56 PM Feature #3394: generic drawing improvements: repaint and other misc code
- Constantin, your changes fixed the tree control and all date picker issues. Thank you for help. There are only visibl...
- 02:37 PM Feature #3394: generic drawing improvements: repaint and other misc code
- Sergey Ivanovskiy wrote:
> OK. Did you try to draw sequence diagrams related to drawings? It seems there are differe... - 02:32 PM Feature #3394: generic drawing improvements: repaint and other misc code
- OK. Did you try to draw sequence diagrams related to drawings? It seems there are different scenarios that can invoke...
- 02:23 PM Feature #3394: generic drawing improvements: repaint and other misc code
- Sergey, when you mentioned the @afterConfigUpdateBase@, it got me thinking... we need to post physical boundaries and...
- 09:23 AM Feature #3394: generic drawing improvements: repaint and other misc code
- This trace should be discussed too...
- 08:44 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Constantin, you are correct that @AbstractWidget.afterConfigUpdateBase@ (trunc version) looks incorrect because of @p...
- 05:16 AM Feature #3394: generic drawing improvements: repaint and other misc code
- It looks like a bug that for a date picker button defined by...
- 04:51 AM Feature #3394: generic drawing improvements: repaint and other misc code
- This function of @OutputManager@...
- 02:17 PM Bug #3381: Sub-menu drawing issues
- > No there is no such line in @FWD@. Can you remember when you saw it last time?
I guess somewhere between revisio... - 12:07 PM Bug #3381: Sub-menu drawing issues
- Stanislav,
From your picture I can see vertical line in @Windows10@ theme:
!missing_vert_win10.jpg!
No there...
12/09/2017
- 07:43 AM Bug #3382: Client-side popup menus abend
- Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > Guys,
> >
> > I'm just trying to run browse pop-up test in my W... - 04:19 AM Bug #3382: Client-side popup menus abend
- Eugenie Lyzenko wrote:
> Guys,
>
> I'm just trying to run browse pop-up test in my Windows devbox. And has abend ... - 08:06 PM Bug #3382: Client-side popup menus abend
- Guys,
I'm just trying to run browse pop-up test in my Windows devbox. And has abend from inability to open temp t... - 10:01 PM Bug #3381: Sub-menu drawing issues
- 4GL level1 menu opening:
!sub_menu1_level1.jpg!
4GL level2 menu opening:
!sub_menu1_level2.jpg!
12/08/2017
- 04:25 PM Feature #3394: generic drawing improvements: repaint and other misc code
- Constantin, no, updates for combo boxes and tree and another widgets are different issues. I didn't solve them. This ...
- 04:20 PM Feature #3394: generic drawing improvements: repaint and other misc code
- Sergey Ivanovskiy wrote:
> Please review committed revision 11249 (3394a) that should discard empty rectangles from ... - 03:22 PM Feature #3394: generic drawing improvements: repaint and other misc code
- Please review committed revision 11249 (3394a) that should discard empty rectangles from @SceenBitmap@. It seems that...
- 12:11 PM Feature #3394: generic drawing improvements: repaint and other misc code
- Please clarify what is incorrect in setNewSelection?
I traced @ScrenBitmap.this.setState@ and found many cases wit... - 08:50 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Sergey Ivanovskiy wrote:
> The following changes can help to fix combo box updates
> [...]
> but I found another p... - 08:39 AM Feature #3394: generic drawing improvements: repaint and other misc code
- But it is possible that these empty clipping rectangles have been incorrectly added to @ScreenBitmap@. It needs to fi...
- 05:27 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Sergey Ivanovskiy wrote:
> I changed coordinates in #3394-41. The rectangle is empty and is invalid but if it is pas... - 05:26 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > I meant the existing definition of @NativeRectangle.this.e... - 05:22 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Sergey Ivanovskiy wrote:
> Constantin Asofiei wrote:
> > See @CombobBox.setValue@ and other @setValue@ for i.e. sel... - 05:21 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Constantin Asofiei wrote:
> See @CombobBox.setValue@ and other @setValue@ for i.e. selection-list and other widgets ... - 05:16 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Sergey Ivanovskiy wrote:
> I meant the existing definition of @NativeRectangle.this.empty()@ which is correct.
I do... - 05:13 AM Feature #3394: generic drawing improvements: repaint and other misc code
- I meant the existing definition of @NativeRectangle.this.empty()@ which is correct.
- 05:10 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Yes I mean @NativeRectangle@, but @Rectangle@ has the same issue. To clarify this bug with empty rectangles let us co...
- 05:07 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Sergey Ivanovskiy wrote:
> Yes, and the fact that the month combo box is not repainted with actual value.
See @Comb... - 04:58 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Yes, and the fact that the month combo box is not repainted with actual value.
It seems that the @NativeRectangle.... - 04:56 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Sergey Ivanovskiy wrote:
> Please look at this picture date_picker.mkv.
You refer to the border artefacts around th... - 04:43 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Please look at this picture date_picker.mkv.
- 03:02 PM Bug #3382: Client-side popup menus abend
- Hynek Cihlar wrote:
>
> In your last change you used the menu popup location passed to @Menu.showPopup()@, which a... - 12:40 PM Bug #3382: Client-side popup menus abend
- Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > Yes, the coordinates must be taken from the mouse event causing th... - 10:42 AM Bug #3382: Client-side popup menus abend
- Hynek Cihlar wrote:
> Yes, the coordinates must be taken from the mouse event causing the popup to come up and not f... - 06:57 AM Bug #3382: Client-side popup menus abend
- Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > Eugenie, why not to get the location from the mouse event? What if... - 04:47 AM Bug #3382: Client-side popup menus abend
- Hynek Cihlar wrote:
> Eugenie, why not to get the location from the mouse event? What if the popup isn't actually di... - 02:57 AM Bug #3382: Client-side popup menus abend
- Eugenie Lyzenko wrote:
> Task branch @3394a@ has been updated for review to revision @11247@.
>
> Fixed the bar s... - 08:10 PM Bug #3382: Client-side popup menus abend
- Task branch @3394a@ has been updated for review to revision @11247@.
Fixed the bar scrolling initiated from pop-up...
12/07/2017
- 03:32 PM Feature #3394: generic drawing improvements: repaint and other misc code
- Sergey Ivanovskiy wrote:
> OK, I lost the conception of redrawing if the business methods change some widget (its po... - 03:32 PM Feature #3394: generic drawing improvements: repaint and other misc code
- Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > This resize rectangle is displayed forever after its appea... - 03:25 PM Feature #3394: generic drawing improvements: repaint and other misc code
- OK, I lost the conception of redrawing if the business methods change some widget (its position, its size, its conten...
- 03:18 PM Feature #3394: generic drawing improvements: repaint and other misc code
- Sergey Ivanovskiy wrote:
> This resize rectangle is displayed forever after its appearance on double click at the fr... - 03:17 PM Feature #3394: generic drawing improvements: repaint and other misc code
- Sergey Ivanovskiy wrote:
> Please answer to this conceptual question. What is the meaning of this flag and when it c... - 02:53 PM Feature #3394: generic drawing improvements: repaint and other misc code
- Please answer to this conceptual question. What is the meaning of this flag and when it can be used (@BaseConfig@)? C...
- 02:50 PM Feature #3394: generic drawing improvements: repaint and other misc code
- This resize rectangle is displayed forever after its appearance on double click at the frame space right to the last ...
- 02:47 PM Feature #3394: generic drawing improvements: repaint and other misc code
- Don't know it is an answer. The frame is @folder-frm 27 Dimension[126.0,16.43] Point[0.0,1.0] visible true can false;...
- 02:33 PM Feature #3394: generic drawing improvements: repaint and other misc code
- Sergey Ivanovskiy wrote:
> With the current version the main tab frame can be resizable and resize or editor grid is... - 02:22 PM Feature #3394: generic drawing improvements: repaint and other misc code
- With the current version the main tab frame can be resizable and resize or editor grid is displayed. It wasn't observ...
- 09:54 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Don't mind, I answered by myself.
- 09:44 AM Feature #3394: generic drawing improvements: repaint and other misc code
- Please help to answer why in this code adatesd0.w for the date picker the x and y coordinates for the selected date r...
- 01:29 PM Bug #3382: Client-side popup menus abend
- Hynek Cihlar wrote:
>When you are at the changes can you make sure the key input works correctly? I am getting an ex... - 04:00 AM Bug #3382: Client-side popup menus abend
- Eugenie Lyzenko wrote:
> Well, looks like I have found alternative approach. So the set of changes:
I like that. ... - 11:52 PM Bug #3382: Client-side popup menus abend
- Well, looks like I have found alternative approach. So the set of changes:
1. No using @invokeLater()@ to avoid chan...
12/06/2017
- 05:12 PM Bug #3382: Client-side popup menus abend
- Eugenie Lyzenko wrote:
> If adapter @adapter.mouseClicked(e)@ calls body that has @invokeLater@ wrapper the result w... - 05:06 PM Bug #3382: Client-side popup menus abend
- Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> >
> > (2) Enqueue only the call to @TC.messageBox()@ in the mouse ... - 05:05 PM Bug #3382: Client-side popup menus abend
- Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > This is exactly how it is currently implemented. Pop-up @ScrollPop... - 04:57 PM Bug #3382: Client-side popup menus abend
- Hynek Cihlar wrote:
>
> (2) Enqueue only the call to @TC.messageBox()@ in the mouse adapter body. Less impact on t... - 04:50 PM Bug #3382: Client-side popup menus abend
- Eugenie Lyzenko wrote:
> This is exactly how it is currently implemented. Pop-up @ScrollPopupGuiImpl.mouseClicked()@... - 04:39 PM Bug #3382: Client-side popup menus abend
- Hynek Cihlar wrote:
> > In this case we have null parent again because @invokeLater()@ defer click handler to the mo... - 04:36 PM Bug #3382: Client-side popup menus abend
- Eugenie Lyzenko wrote:
> Yes, at least scrolling down by pop-up menu does not work.
I think there are two options... - 04:30 PM Bug #3382: Client-side popup menus abend
- Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > But if we postpone click processing to the end - we have dismissed... - 04:27 PM Bug #3382: Client-side popup menus abend
- Eugenie Lyzenko wrote:
> But if we postpone click processing to the end - we have dismissed menu when it should exis... - 04:17 PM Bug #3382: Client-side popup menus abend
- Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > Hynek Cihlar wrote:
> >
> > In fact I don't see any reason the ... - 03:32 PM Bug #3382: Client-side popup menus abend
- Hynek Cihlar wrote:
> Hynek Cihlar wrote:
>
> In fact I don't see any reason the ordering should not be enforced ... - 01:55 PM Bug #3382: Client-side popup menus abend
- Hynek Cihlar wrote:
> > Another word you mean every possible code (we will remove @ThinClient.messageBox()@ from fin... - 01:31 PM Bug #3382: Client-side popup menus abend
- Eugenie Lyzenko wrote:
> What I do not understand here is why we are committed to @ThinClient.messageBox()@? This is... - 12:20 PM Bug #3382: Client-side popup menus abend
- Hynek Cihlar wrote:
>
> The call to @ThinClient.messageBox()@ must be executed in @ThinClient.invokeLater@ so that... - 12:04 PM Bug #3382: Client-side popup menus abend
- Eugenie Lyzenko wrote:
> Unfortunately this is not enough to fix the issue. Moving @MenuItemGuiImpl.selectMenuItem()... - 09:49 PM Bug #3382: Client-side popup menus abend
- Unfortunately this is not enough to fix the issue. Moving @MenuItemGuiImpl.selectMenuItem()@ before @ScrollPopupGuiIm...
- 03:25 PM Feature #3394: generic drawing improvements: repaint and other misc code
- Sergey Ivanovskiy wrote:
> With the current 3394a the Hotel GUI Check-in date picker doesn't repaint items correctly... - 03:24 PM Feature #3394: generic drawing improvements: repaint and other misc code
- With the current 3394a the Hotel GUI Check-in date picker doesn't repaint items correctly if the current month (year)...
12/05/2017
- 02:34 PM Bug #3382: Client-side popup menus abend
- Eugenie Lyzenko wrote:
> You mean execution @selectMenuItem()@ first, then mouse adapters?
Exactly so. - 05:55 AM Bug #3382: Client-side popup menus abend
- Hynek Cihlar wrote:
> Please try to move the execution of mouse adapters in @MenuItemGuiImpl.mouseClicked@ before @s... - 04:29 AM Bug #3382: Client-side popup menus abend
- Eugenie Lyzenko wrote:
> So the suggested fix approach can be the following change in @ThinClient.invokeTriggers(......
Also available in: Atom