Project

General

Profile

Activity

From 01/06/2018 to 02/04/2018

02/02/2018

09:08 AM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
Also, the changes in 3413a/11250 passed runtime testing. Constantin Asofiei
09:06 AM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
3413a rev 11250 contains these changes:
* Fixed pushWidgetAttr() for menu cases.
* Improved performance for dynamic...
Constantin Asofiei

02/01/2018

05:56 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
ETF batch tests passed for 3246a/11225. Eric Faulhaber
02:57 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
I'll use 3413a for this set of changes. Will use 3246b for the caching attempt. Constantin Asofiei
02:29 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
Actually, I would prefer putting it in a different branch. We have so many in process now (3413a, 3444a, 3440a, 1830... Greg Shah
02:00 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
Greg Shah wrote:
> Yes, it is OK.
>
> Are the changes risky?
The sub-set I have now is not risky, can be added t...
Constantin Asofiei
01:50 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
Yes, it is OK.
Are the changes risky?
Greg Shah
01:17 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
Is it OK to use 3246b for my other WIP performance issues? Constantin Asofiei
01:05 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
Greg Shah wrote:
> ChUI regression testing passed?
Yes. 3246a was merged to trunk rev 11216 and archived.
Constantin Asofiei
01:04 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
ChUI regression testing passed? Greg Shah
12:51 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
Constantin Asofiei wrote:
> Is there any concern on ETF dev tests passing on the third run?
This sometimes happens,...
Eric Faulhaber
12:42 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
Eric Faulhaber wrote:
> The ETF dev tests passed on the third run. Search tests passed on the first run. This was al...
Constantin Asofiei
12:41 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
The ETF dev tests passed on the third run. Search tests passed on the first run. This was all with revision 11225. Ho... Eric Faulhaber
12:37 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
3246a rev 11226 fixes an issue for GUI redirected mode exposed by my changes.
If I get the go-ahead from Eric, I c...
Constantin Asofiei
10:09 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Good. Then we'll just list the added memory usage as part of the description of the export feature. When customers ... Greg Shah
09:56 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
No. Stanislav Lomany
09:38 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
I think this is fine. It is good that you noted it.
Other than the memory usage, are there any compatibility issu...
Greg Shah
08:27 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
FYI. When printing from a browse, I have to create an intermediate result set containing all browse rows (all pages).... Stanislav Lomany

01/31/2018

06:55 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
> Seeing the amount of new translatable strings I am wondering whether we should start thinking about i18n.
Yes, w...
Greg Shah
05:47 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
Code Review Task Branch 1830c Revision 11230
@TC.modalEventLoopWorker@
The condition @evt instanceof KeyInput && ...
Hynek Cihlar
02:41 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
I committed changes suggested in note 41 to revision 11230.
Regarding the @LineEditor@. There are a few changes re...
Ovidiu Maxiniuc
11:40 AM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
Ovidiu: Please take a look at the in process fill-in/editor mouse selection changes that Sergey is implementing now i... Greg Shah
11:39 AM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
Hynek: please do a code review of 1830c. Greg Shah
11:38 AM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
Code Review Task Branch 1830c Revision 11229
Overall, the changes are really good. I especially like the better t...
Greg Shah
03:21 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
There was one failure in the ETF dev tests; running again in case it was a false negative. Eric Faulhaber
01:44 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
Code Review Task Branch 3246a Revision 11225
I'm good with the changes.
> 3246a rev 11225 is the candidate to b...
Greg Shah

01/30/2018

05:32 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
3246a rev 11225 is the candidate to be merged trunk if it passes testing. What else I have on queue:
# @screenLocat...
Constantin Asofiei
07:08 AM Bug #3461: Remaining menu/sub-menu bugs or incorrect behavior
The menu mnemonics don't work as expected. There are multiple issues, menu/items not opened/triggered when mnemonic t... Hynek Cihlar

01/26/2018

01:44 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
> It shouldn't be in 11221 in bzr... I'm not seeing it there, in bzr.
Sorry, you're right. I was looking at the 3...
Greg Shah
01:42 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
Greg Shah wrote:
> I only see rev 11221 in bzr. Anyway, the changes are good.
It shouldn't be in 11221 in bzr... ...
Constantin Asofiei
01:21 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
I only see rev 11221 in bzr. Anyway, the changes are good. Do you want to test it separately from 3435a?
For tha...
Greg Shah
12:57 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
Greg Shah wrote:
> > I'm not sure what you mean for ConfigManager - there is no java.lang.reflect usage there. Can y...
Constantin Asofiei
12:55 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
> WidgetConfigDef is a one-time setup at client startup.
Good point.
> I'm not sure what you mean for ConfigMan...
Greg Shah
12:20 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
Greg Shah wrote:
> 1. There are some places which directly edit the @frame.config@ in @GenericFrame@ (@setDialogBox(...
Constantin Asofiei
12:14 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
Code Review Task Branch 3246a Revision 11221
This is a really great set of changes! I'm excited to see them final...
Greg Shah
01:52 AM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > The reason why backup config is not used is that the config cha...
Hynek Cihlar
08:22 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
Greg, you can do a review for 3246a rev 11220; is cleaned up and what is left is:
# avoid @pushScreenDefinition@ for...
Constantin Asofiei
08:19 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
Hynek Cihlar wrote:
> The reason why backup config is not used is that the config changes in some cases have differe...
Constantin Asofiei

01/25/2018

03:20 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
Sorry, I forgot to mention two important things I've had to do to get true CPU profiling working in VisualVM:
* up...
Eric Faulhaber
11:15 AM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
Constantin Asofiei wrote:
> Eric, were you able to profile the FWD server? I can't attach safely with Oracle JDK 1.8...
Eric Faulhaber

01/24/2018

06:23 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
Forgot to note:
# menus are treated via @pushWidgetAttr@, when feasible
# windows are treated via @LogicalTerminal....
Constantin Asofiei
06:14 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
A state of the point I reached with these improvements:
# server-side AspectJ should be avoided, especially if it re...
Constantin Asofiei
05:24 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
Hynek Cihlar wrote:
> Are you concerned about performance?
Yes, but although it gets called many times, it looks pr...
Constantin Asofiei
02:33 AM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
Constantin Asofiei wrote:
> Hynek, do you recall why you used @ConfigManager.duplicate()@ instead of relying on the ...
Hynek Cihlar
07:14 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
Hynek, do you recall why you used @ConfigManager.duplicate()@ instead of relying on the @backup@ config instance (fro... Constantin Asofiei

01/23/2018

08:34 AM Bug #3382 (Closed): Client-side popup menus abend
Greg Shah
08:28 AM Bug #3382: Client-side popup menus abend
I also think it can be closed. Eugenie Lyzenko
08:22 AM Bug #3382: Client-side popup menus abend
Greg Shah wrote:
> I can close this, right?
Yes, I think so.
Hynek Cihlar
08:10 AM Bug #3382: Client-side popup menus abend
I can close this, right? Greg Shah

01/22/2018

05:56 PM Bug #3461: Remaining menu/sub-menu bugs or incorrect behavior
So far I do not see anymore remaining issues in current menu implementation. Including multiple item highlighted issu... Eugenie Lyzenko
05:53 PM Bug #3461: Remaining menu/sub-menu bugs or incorrect behavior
When application exits the menu is still visible. Testcase: @menu/menubar.p@
1. Run the test and press @Show menub...
Eugenie Lyzenko
05:07 PM Bug #3461: Remaining menu/sub-menu bugs or incorrect behavior
Focus is not properly returning to the initial widget. Testcase: @menu/menubar.p@
1. Run the test and press @Show ...
Eugenie Lyzenko
04:35 PM Bug #3461 (New): Remaining menu/sub-menu bugs or incorrect behavior
Eugenie Lyzenko
05:15 PM Bug #3381 (Closed): Sub-menu drawing issues
Greg Shah
02:41 PM Bug #3381: Sub-menu drawing issues
Task branch @3381a@ has been merged into trunk as revision @11215@. The branch @3381a@ has been archived. Eugenie Lyzenko
02:35 PM Bug #3381: Sub-menu drawing issues
Greg Shah wrote:
> Eugenie: please go forward with the following:
>
> # Merge 3381a to trunk.
> # Open a new tas...
Eugenie Lyzenko
02:15 PM Bug #3381: Sub-menu drawing issues
Eugenie: please go forward with the following:
# Merge 3381a to trunk.
# Open a new task for the remaining menuin...
Greg Shah
02:04 PM Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> Task branch @3381a@ has been updated for review to revision @11231@.
>
> This is the fix...
Hynek Cihlar
01:25 PM Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
>
> Code review @3381a/11230@. The changes are ok. The abend is resolved. I found the followin...
Eugenie Lyzenko
12:31 PM Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> Task branch @3381a@ has been updated for review to revision @11230@.
>
> Fixed abend wit...
Hynek Cihlar
10:22 AM Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > Task branch @3381a@ has been updated for review to revision @11229...
Eugenie Lyzenko
09:19 AM Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> Task branch @3381a@ has been updated for review to revision @11229@.
Code review @3381a/...
Hynek Cihlar

01/20/2018

01:58 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Rebased task branch 3261a from P2J trunk revision 11214. Stanislav Lomany
07:17 PM Bug #3381: Sub-menu drawing issues
Task branch @3381a@ has been updated for review to revision @11229@.
This is the fix for @1-3@ notes. The case (3)...
Eugenie Lyzenko

01/19/2018

12:55 PM Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> I have added some documentation to usage of the activation control method when it is called...
Hynek Cihlar
11:01 AM Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> Code review 3381a/11227.
>
> In ThinClient.processEventsWorker()
> [...]
> should be chan...
Eugenie Lyzenko
06:42 AM Bug #3381: Sub-menu drawing issues
Code review 3381a/11227.
In ThinClient.processEventsWorker()...
Hynek Cihlar
08:55 PM Bug #3381: Sub-menu drawing issues
Task branch @3381a@ has been updated for review to revision @11227@.
Final testing discovered new regression for m...
Eugenie Lyzenko
07:08 PM Bug #3381: Sub-menu drawing issues
Task branch @3381a@ has been updated for review to revision @11226@.
More fixes for menu handling issues with de-a...
Eugenie Lyzenko

01/18/2018

05:10 PM Bug #3381: Sub-menu drawing issues
Task branch @3381a@ has been updated for review to revision @11225@.
This is the small change to separate @GUI@ me...
Eugenie Lyzenko
03:49 PM Bug #3381: Sub-menu drawing issues
Task branch @3381a@ has been updated for review to revision @11224@.
This is the fix for (3) issue with root menu ...
Eugenie Lyzenko
09:56 PM Bug #3381: Sub-menu drawing issues
Task branch @3381a@ has been updated for review to revision @11223@.
This is the fixes for point (1) and (2). Work...
Eugenie Lyzenko
03:28 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
Greg Shah wrote:
> > For example when you install a PDF plugin in the browser, the pdf will open in its window, if n...
Hynek Cihlar
12:31 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
> For example when you install a PDF plugin in the browser, the pdf will open in its window, if not it will be downlo... Greg Shah
12:10 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
Greg Shah wrote:
> Code Review Task Branch 3435a Revision 11255
>
> I'm good with the change.
>
> 2. In my tes...
Hynek Cihlar
11:25 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
FYI, Stanislav is working to enhance the JasperReports support (see #3342) to handle XLS output. It already handles ... Greg Shah
11:19 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
Code Review Task Branch 3435a Revision 11255
I'm good with the change.
1. Please review "Open URL":/projects/p2...
Greg Shah
08:43 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
Hynek Cihlar wrote:
> Greg Shah wrote:
> > I tried it in Swing ChUI, Swing GUI and Virtual Desktop GUI modes. I ne...
Hynek Cihlar
04:30 AM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
Greg Shah wrote:
> I tried it in Swing ChUI, Swing GUI and Virtual Desktop GUI modes. I never see the PDF output......
Hynek Cihlar
01:10 PM Bug #3425: text is drawn 1-pixel to the left, cutting the text
Code Review Task Branch 3435a Revision 11256
I'm fine with the changes.
Greg Shah
09:23 AM Bug #3425 (Review): text is drawn 1-pixel to the left, cutting the text
Stanislav Lomany
09:22 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text
The fix is committed into the branch 3435a rev 11256. Stanislav Lomany

01/17/2018

06:45 PM Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...
I've just tested the following program:... Greg Shah
04:51 PM Bug #3425: text is drawn 1-pixel to the left, cutting the text
Just finished, going to update the branch and check for regressions in AW. Stanislav Lomany
04:40 PM Bug #3425: text is drawn 1-pixel to the left, cutting the text
What is the status of this task? Greg Shah
11:58 AM Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > Great, thanks. But how did you get two @FWD@ windows with @menu/me...
Hynek Cihlar
11:56 AM Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> Great, thanks. But how did you get two @FWD@ windows with @menu/menubar.p@ testcase?
Mak...
Hynek Cihlar
11:52 AM Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > OK. Please provide demo for (2) and (3) cases above or more detail...
Eugenie Lyzenko
11:40 AM Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> OK. Please provide demo for (2) and (3) cases above or more detailed instructions or specif...
Hynek Cihlar
10:31 AM Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> Code review 3381a/11222. The code changes look OK to me.
>
> I also did a quick retest and ...
Eugenie Lyzenko
09:29 AM Bug #3381: Sub-menu drawing issues
Code review 3381a/11222. The code changes look OK to me.
I also did a quick retest and found:
(1) Note 94 point...
Hynek Cihlar
08:47 AM Bug #3381: Sub-menu drawing issues
I haven't done a full code review but the TC changes are fine to merge to trunk.
Hynek: Please do a code review. ...
Greg Shah

01/16/2018

04:19 PM Bug #3381: Sub-menu drawing issues
Task branch @3381a@ has been updated for review to revision @11222@.
Added changes to fix some GUI issues/regressi...
Eugenie Lyzenko
10:24 PM Bug #3381: Sub-menu drawing issues
Task branch @3381a@ has been updated for review to revision @11221@.
The update is a starting point for keyboard n...
Eugenie Lyzenko

01/15/2018

12:41 PM Bug #3381: Sub-menu drawing issues
Interesting finding for original @4GL@ behavior. On @4GL@ capable @Windows@ system.
When navigating menu via keybo...
Eugenie Lyzenko
08:12 AM Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> Hynek,
>
> Are the problem in notes @94@ and @95@ the regressions from branch changes or...
Hynek Cihlar
06:56 AM Bug #3381: Sub-menu drawing issues
Hynek,
Are the problem in notes @94@ and @95@ the regressions from branch changes or new found issues?
Eugenie Lyzenko
04:33 AM Bug #3381: Sub-menu drawing issues
Greg Shah wrote:
> Hynek: Can we merge this to trunk? Or should we merge this into 3435a?
Yes I think it can be ...
Hynek Cihlar
04:28 AM Bug #3381: Sub-menu drawing issues
Some more issue in the latest 3381a.
To reproduce 1:
* in @menu/menubar.p@
* click on a root menu item
* click ...
Hynek Cihlar
04:04 AM Bug #3381: Sub-menu drawing issues
I found two more issue in the latest 3381a.
To reproduce 1:
* run @menu/menubar.p@
* open the menu and navigate ...
Hynek Cihlar

01/13/2018

07:20 AM Bug #3381: Sub-menu drawing issues
Hynek: Can we merge this to trunk? Or should we merge this into 3435a? Greg Shah

01/12/2018

05:40 PM Bug #3381: Sub-menu drawing issues
Running the testcases I have not found the regressions.
And the @ChUI@ code was not touched in this branch.
Eugenie Lyzenko
05:54 AM Bug #3425: text is drawn 1-pixel to the left, cutting the text
FYI.
To draw a columns separator we should decide to which column it belongs. In original design a column contained ...
Stanislav Lomany

01/11/2018

04:43 AM Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> Task branch @3381a@ has been updated for review to revision @11220@.
>
> And I still nee...
Hynek Cihlar

01/10/2018

06:25 PM Bug #3381: Sub-menu drawing issues
Task branch @3381a@ has been updated for review to revision @11220@.
Fixed the @1@ and @2@ notes resolution. The i...
Eugenie Lyzenko
03:18 PM Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
>1. When menu bar is hovered and then mouse-exited the highlight should go away, but it stays on...
Eugenie Lyzenko
01:15 AM Bug #3381: Sub-menu drawing issues
Code review 3381a/11219.
Exiting the highlighted item now looks solid. Also I don't see anything wrong with the co...
Hynek Cihlar

01/09/2018

03:10 PM Bug #3381: Sub-menu drawing issues
Task branch @3381a@ has been updated for review to revision @11219@.
This is the fix for point @3@ with mouse exit...
Eugenie Lyzenko
01:22 PM Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > OK. Need to perform some debugging.
>
> Eugenie, I suggest you ...
Eugenie Lyzenko
08:24 AM Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> OK. Need to perform some debugging.
Eugenie, I suggest you put a couple of trace stateme...
Hynek Cihlar
08:19 AM Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> > Yes, it is true. However I think the mouse exited event is not properly posted in this case....
Eugenie Lyzenko
06:07 AM Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > > I mean the main event queue in @ThinClient@ event loop where the...
Hynek Cihlar
06:06 AM Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> > I mean the main event queue in @ThinClient@ event loop where the mouse events are posting fr...
Eugenie Lyzenko
05:51 AM Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > Eugenie Lyzenko wrote:
> > > Task branch @3381a@ has been updated...
Hynek Cihlar
05:46 AM Bug #3381: Sub-menu drawing issues
Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > Task branch @3381a@ has been updated for review to revision @11218...
Eugenie Lyzenko
04:18 AM Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> Task branch @3381a@ has been updated for review to revision @11218@.
>
> This is the fix...
Hynek Cihlar
09:42 PM Bug #3381: Sub-menu drawing issues
Task branch @3381a@ has been updated for review to revision @11218@.
This is the fixes for notes @1-4@. As to note...
Eugenie Lyzenko

01/08/2018

12:58 PM Bug #3381: Sub-menu drawing issues
Eugenie Lyzenko wrote:
> Task branch @3381a@ has been updated for review to revision @11216@.
>
> The update cont...
Hynek Cihlar
 

Also available in: Atom