Project

General

Profile

Activity

From 04/16/2018 to 05/15/2018

05/15/2018

06:53 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> I call @browse.repaint()@, but it is not repainted: paint event is posted, but @browse.draw()@ is not called.
@r...
Stanislav Lomany
05:05 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Stanislav Lomany wrote:
> After merging with the current trunk I met so far the following regressions:
> # No stabl...
Hynek Cihlar
05:02 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
After merging with the current trunk I met so far the following regressions:
# Incorrect enhanced popup menu for col...
Stanislav Lomany
03:07 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Rebased task branch 3261c from P2J trunk revision 11253. Stanislav Lomany
11:41 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
The query support for dynamic sorting/filter was committed to branch 3261c (rev 11244).
The API is found in @QueryWr...
Ovidiu Maxiniuc
10:33 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Something else to add: simple users should have only a single option named "Save changes", without all the server/use... Constantin Asofiei
08:55 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
That is definitely pretty useful.
My only concern is that we should not give all users the ability to set defaul...
Greg Shah
08:52 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> Is the state saving complete now?
Still working on it.

> Can we set a default in the directory that is overrid...
Stanislav Lomany
08:48 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
FYI, enhanced browse now has the following options to save the settings (WIP):
!save-options.png!
Option "FOR A...
Stanislav Lomany
08:47 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Is the state saving complete now?
Can we set a default in the directory that is overridden when a user makes chang...
Greg Shah
08:42 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> Stanislav, see 3507a rev 11332 for another example how to create a node in the directory.xml , to set CURRENT-LANGU... Stanislav Lomany
03:12 PM Bug #3538: The next focus widget for menu widget is not defined
Greg Shah wrote:
> Do you expect to finish testing today? I want to get this into trunk.
I haven't finished ChUI...
Hynek Cihlar
03:08 PM Bug #3538: The next focus widget for menu widget is not defined
Greg Shah wrote:
> 1. In @MenuItem.processKeyEvent()@ line 306 calls @getParentMenu()@ and saves the result in the @...
Hynek Cihlar
02:11 PM Bug #3538: The next focus widget for menu widget is not defined
Do you expect to finish testing today? I want to get this into trunk. Greg Shah
11:53 AM Bug #3538: The next focus widget for menu widget is not defined
Code Review Task Branch 3538c Revision 11271
These changes certainly make the menu processing significantly simple...
Greg Shah
08:56 PM Bug #3538: The next focus widget for menu widget is not defined
Please review latest 3538c. It contains an overhaul of the menu navigation implementation. It was simplified in order... Hynek Cihlar
09:47 AM Bug #3570: Web client beeping
It seems that the root cause of unusual beeping is @p2j.screen.js@
/**
* Display an error message.
...
Sergey Ivanovskiy
09:37 AM Bug #3570 (Closed): Web client beeping
Sergey Ivanovskiy
06:11 AM Bug #3106: Various GUI COMBO-BOX issues
Another issue, when an item selected in the combo drop-down, ENTER key doesn't have any effect. ENTER should close th... Hynek Cihlar

05/14/2018

12:16 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Stanislav, see 3507a rev 11332 for another example how to create a node in the directory.xml , to set CURRENT-LANGUAG... Constantin Asofiei

05/11/2018

06:14 AM Bug #3538 (WIP): The next focus widget for menu widget is not defined
Hynek Cihlar
06:13 AM Bug #3538: The next focus widget for menu widget is not defined
Greg Shah wrote:
> Code Review Task Branch 3538c Revision 11258
>
> I'm good with the changes.
>
> If I unders...
Hynek Cihlar
05:45 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
I have to finish enhanced browse stuff first, so will see who will be available earlier. Stanislav Lomany
05:32 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Stanislav Lomany wrote:
> > Please review the committed revision 11242 that should fix the web client usage and the ...
Sergey Ivanovskiy
05:13 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> Please review the committed revision 11242 that should fix the web client usage and the swing client is still worki... Stanislav Lomany

05/10/2018

04:34 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Stanislav Lomany wrote:
> > Thus we can see that mouse pointer can be default or S_RESIZE. It is not clear for me wh...
Sergey Ivanovskiy
02:39 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Greg Shah wrote:
> Editing is serialized. While one session is editing, other sessions are locked out.
I see, @syn...
Constantin Asofiei
02:36 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> Greg, do we need something specific to flush the directory changes to disk? Or ds.unbind() will take care of saving... Greg Shah
11:17 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Stanislav, about reading/writing the browse state in the directory.xml - you can take a look at @AppServerDefinition.... Constantin Asofiei
09:15 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> Thus we can see that mouse pointer can be default or S_RESIZE. It is not clear for me why another sides of "resize"... Stanislav Lomany
09:00 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Sergey Ivanovskiy wrote:
> Also I found that @MouseDirectManipulation@ java logic doesn't change the cursor shape.
...
Sergey Ivanovskiy
02:14 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Sergey Ivanovskiy wrote:
> It seems that a widget should implement at least these methods in order its mouse pointer...
Sergey Ivanovskiy
04:24 PM Bug #3538: The next focus widget for menu widget is not defined
Code Review Task Branch 3538c Revision 11258
I'm good with the changes.
If I understand correctly, this also re...
Greg Shah

05/09/2018

06:12 PM Bug #3538: The next focus widget for menu widget is not defined
Please review 3538c, it resolves this issue plus multiple others - several menu-related abends, drawing issues, event... Hynek Cihlar
06:10 PM Bug #3538: The next focus widget for menu widget is not defined
Due to rebasing issues in branch 3538b I created 3538c and merged in all the changes from 3538b. 3538b will be dead-a... Hynek Cihlar

05/08/2018

03:50 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Constantin Asofiei wrote:
> An idea: apply this 'client-side' filtering (UDFs and other stuff, for computed columns)...
Ovidiu Maxiniuc
03:47 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
As a reminder about performance: #3261#note-67
If we want to support computed columns, then we have to go with the...
Stanislav Lomany
03:35 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Ovidiu Maxiniuc wrote:
> Stanislav Lomany wrote:
> > Computed columns can be not only formulas, but user-written fu...
Constantin Asofiei
03:32 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Stanislav Lomany wrote:
> Computed columns can be not only formulas, but user-written functions, which can run sub-q...
Ovidiu Maxiniuc
03:24 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Computed columns can be not only formulas, but user-written functions, which can run sub-queries etc. So caching comp... Stanislav Lomany
03:19 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> Stanislav: I guess we may already pass an anonymous inner class instance of these expressions so that the browse ca... Stanislav Lomany
02:54 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> * I think it would be better for filtering to pass in the actual BDT, not its string representation. If it is reall... Stanislav Lomany
02:42 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Eric Faulhaber wrote:
> How would we use lambdas to augment an order by (sorting) or where clause (filtering), since...
Ovidiu Maxiniuc
02:39 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Eric Faulhaber wrote:
> How would we use lambdas to augment an order by (sorting) or where clause (filtering), since...
Greg Shah
02:33 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
How would we use lambdas to augment an order by (sorting) or where clause (filtering), since we need to do these on t... Eric Faulhaber
02:31 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Do we need to implement lambdas for the expression in a computed column? This way the browse can calculate it whenev... Greg Shah
02:03 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Sorry, I missed that these are _computed_ columns. I was referencing _calc_ columns. Stanislav Lomany
02:02 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> * what happens with computed columns? Should we filter / sort based on them? For example:
It is impossible to filt...
Stanislav Lomany
01:58 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
I have some other concerns/questions:
* what is the best API: pass to @QueryWrapper@ one filter at a time and keep t...
Ovidiu Maxiniuc
01:44 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Eric Faulhaber wrote:
> Does anyone have a concern about encapsulating the "query switching" needed for filter/sort ...
Ovidiu Maxiniuc
01:15 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Stanislav Lomany wrote:
> > currently, BrowseWidget references P2JQuery, but isn't it actually limited to QueryWrapp...
Eric Faulhaber
06:00 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> currently, BrowseWidget references P2JQuery, but isn't it actually limited to QueryWrapper instances?
Yes, I thi...
Stanislav Lomany
05:35 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Yes. Stanislav Lomany
05:33 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Stanislav Lomany wrote:
> > If we drag rapidly the bottom side of the resize box until it passes more than 3 rows, t...
Sergey Ivanovskiy
05:31 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> If we drag rapidly the bottom side of the resize box until it passes more than 3 rows, then it throws this error. I... Stanislav Lomany
01:01 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Also I found that @MouseDirectManipulation@ java logic doesn't change the cursor shape. Sergey Ivanovskiy
12:40 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
It seems that a widget should implement at least these methods in order its mouse pointer shape will react on mouse h... Sergey Ivanovskiy

05/07/2018

05:37 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
I just found that for the web client right sides of cells also can be dragged but the mouse pointer is not changed if... Sergey Ivanovskiy
05:29 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Stanislav Lomany wrote:
> > Stas, can you be more specific as to what needs to be fixed?
>
> !browse-resize-issue...
Sergey Ivanovskiy
05:06 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Ovidiu Maxiniuc wrote:
> create a set of couple of methods in @BrowseWidget@ for adding a filter and a sort order fo...
Eric Faulhaber
04:59 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Ovidiu Maxiniuc wrote:
> Stanislav,
> For latest issue, I can only confirm that the Swing client is handling fine t...
Sergey Ivanovskiy
04:31 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Stanislav,
For latest issue, I can only confirm that the Swing client is handling fine the resize and column reorder...
Ovidiu Maxiniuc
11:54 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> Stas, can you be more specific as to what needs to be fixed?
!browse-resize-issues.png!
On the screenshot I was...
Stanislav Lomany
11:20 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
OK. I had it in mind. Sergey Ivanovskiy
11:17 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Sergey Ivanovskiy wrote:
> Greg Shah wrote:
> > Sergey: Can you help Stanislav with his request in #3261-124?
> Ye...
Eric Faulhaber
11:05 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Greg Shah wrote:
> Sergey: Can you help Stanislav with his request in #3261-124?
Yes, I can take it. What is the pr...
Sergey Ivanovskiy
10:46 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Sergey: Can you help Stanislav with his request in #3261-124? Greg Shah
04:50 PM Bug #3395 (Closed): rectangle:edge-chars is not working in GUI
Greg Shah
05:52 AM Bug #3538: The next focus widget for menu widget is not defined
Due to rebasing issues in branch 3538a I created 3538b and merged in all the changes from 3538a. 3538a will be dead-a... Hynek Cihlar

05/04/2018

03:53 AM Bug #3538: The next focus widget for menu widget is not defined
3538a rebased against trunk revision 11252. Hynek Cihlar

05/03/2018

05:42 PM Feature #3281: implement some frame options
The remaining issues were fixed as part of #3528, in 3507a rev 11291 Constantin Asofiei
03:34 PM Feature #3281: implement some frame options
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Sorry, it seems this code has been added recently by rev 11251. ...
Hynek Cihlar
11:33 AM Feature #3281: implement some frame options
Sergey Ivanovskiy wrote:
> Sorry, it seems this code has been added recently by rev 11251. Hynek should know why it ...
Hynek Cihlar
12:51 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Guys, I've found that column and row resizing doesn't work properly in web version with the current trunk: during col... Stanislav Lomany
11:29 AM Bug #3560: widget handles in the 4GL will compile with any valid attribute name even if it is not...
We do intend to implement some handle type-analysis in the future. This would enable us to find and warn about these... Greg Shah
11:25 AM Bug #3560: widget handles in the 4GL will compile with any valid attribute name even if it is not...
4GL allows (I think) any attribute/method to be specified for a widget reference, i.e.:... Greg Shah
11:24 AM Bug #3560 (New): widget handles in the 4GL will compile with any valid attribute name even if it ...
Greg Shah
11:24 AM Bug #3395 (WIP): rectangle:edge-chars is not working in GUI
This was fixed in 3507a rev -11290- 11291. Constantin Asofiei

05/02/2018

03:40 PM Feature #3281: implement some frame options
Sergey Ivanovskiy wrote:
> Constantin Asofiei wrote:
> > Anyone has any idea why this code was added to FillInGuiIm...
Sergey Ivanovskiy
02:49 PM Feature #3281: implement some frame options
Constantin Asofiei wrote:
> Anyone has any idea why this code was added to FillInGuiImpl and EditorGuiImpl.mouseClic...
Sergey Ivanovskiy
02:23 PM Feature #3281: implement some frame options
Anyone has any idea why this code was added to FillInGuiImpl and EditorGuiImpl.mouseClicked?... Constantin Asofiei

05/01/2018

05:46 PM Bug #3559: trigger matching for multi-label events (i.e. RETURN/ENTER/CTRM-M, PAGE-UP/PGUP/PREV-P...
4GL has a weird way of matching an event to a trigger, if that event has multiple labels associated with it. For exa... Constantin Asofiei
05:36 PM Bug #3559 (New): trigger matching for multi-label events (i.e. RETURN/ENTER/CTRM-M, PAGE-UP/PGUP/...
Constantin Asofiei

04/26/2018

04:11 PM Feature #3469: final improvements and polish for the embedded mode web client
3469a was merged to trunk rev 11252 and archived. Constantin Asofiei

04/25/2018

06:34 AM Bug #3487: Sub-menu graphical issues
3487b dead-archived. Hynek Cihlar
06:30 AM Bug #3487: Sub-menu graphical issues
Merged the only change in 3487b to 3553a.
Correction, merged the change in 3487b to 3538a.
Hynek Cihlar
05:23 AM Bug #3487: Sub-menu graphical issues
Greg Shah wrote:
> Are you proposing to merge this to trunk now? Or do you plan to include the changes for #3538?
...
Hynek Cihlar
05:19 AM Bug #3487: Sub-menu graphical issues
Code Review Task Branch 3487b Revision 11252
I'm fine with the change.
Are you proposing to merge this to trunk...
Greg Shah
04:23 AM Bug #3487: Sub-menu graphical issues
The ChUI menu regressions are more serious than I thought. I created new issue #3553 and checked in my WIP changes th... Hynek Cihlar
06:33 AM Bug #3538: The next focus widget for menu widget is not defined
Created task branch 3538a and merged in changes from 3487b. Hynek Cihlar
04:28 AM Bug #3553: ChUI menus don't work
There are already multiple open issues for ChUI menus, some seem to have some overlap with this one. https://proj.gol... Hynek Cihlar
04:20 AM Bug #3553: ChUI menus don't work
Created task branch 3553a and checked in some early and incomplete changes. This only fixes the related event handlin... Hynek Cihlar
04:00 AM Bug #3553: ChUI menus don't work
Window-attached menu (MENU-BAR) can't be entered and "opened" with the standard menu-enter keys (F3) or mnemonics. An... Hynek Cihlar
03:55 AM Bug #3553 (New): ChUI menus don't work
Hynek Cihlar

04/24/2018

06:56 AM Bug #3532 (Closed): Failed to instantiate menu definition class
Greg Shah
03:10 AM Bug #3532: Failed to instantiate menu definition class
The issue was resolved in 3487a, the branch was merged to trunk in revision 11259. Hynek Cihlar
06:56 AM Bug #3508 (Closed): 1st level popup menu won't close when menu item selected
Greg Shah
03:09 AM Bug #3508: 1st level popup menu won't close when menu item selected
The issue was resolved in 3487a, the branch was merged to trunk in revision 11259. Hynek Cihlar
03:07 AM Bug #3487: Sub-menu graphical issues
3487a rebased and merged to trunk as revision 11251. The branch was archived. Hynek Cihlar
02:36 AM Bug #3487: Sub-menu graphical issues
3487a passed ChUI test harness. I am merging to trunk. Hynek Cihlar

04/23/2018

12:48 PM Bug #3487: Sub-menu graphical issues
When it passes testing, merge to trunk. Greg Shah
11:44 AM Bug #3487: Sub-menu graphical issues
Greg Shah wrote:
> The existing revision of 3487a is a significant improvement over trunk, right?
Yes, it fixes...
Hynek Cihlar
11:44 AM Bug #3487: Sub-menu graphical issues
ChUI regression test harness finished with some failures which are most likely negative failures. I restarted the tests. Hynek Cihlar
09:57 AM Bug #3487: Sub-menu graphical issues
Code Review Task branch 3487a Revision 11258
I'm good with the changes.
Greg Shah
07:29 AM Bug #3487: Sub-menu graphical issues
The existing revision of 3487a is a significant improvement over trunk, right? Unless there are regressions, I would... Greg Shah
07:04 AM Bug #3487: Sub-menu graphical issues
While regression testing 3487a I see client abends which prevent me to run all the required cases. These errors alrea... Hynek Cihlar

04/22/2018

06:19 PM Bug #3487: Sub-menu graphical issues
3487a revision 11258 resolves the points from the last review. It passed GUI regression tests (a large customer's GUI... Hynek Cihlar

04/20/2018

12:49 PM Bug #3487: Sub-menu graphical issues
Code Review Task Branch 3487a Revision 11256
These changes are really good. I see no functional issues.
One mi...
Greg Shah
08:56 AM Bug #3487: Sub-menu graphical issues
3487a revision 11256 fixes this issue plus #3462, #3508, #3532.
Regression testing is in progress. Please review.
Hynek Cihlar
08:53 AM Bug #3487: Sub-menu graphical issues
3487a rebased against trunk 11249. Hynek Cihlar

04/19/2018

05:05 AM Bug #3487: Sub-menu graphical issues
3487a rebased against trunk 11248. Hynek Cihlar

04/18/2018

02:53 PM Bug #3487: Sub-menu graphical issues
Checked in revision 11247 to 3487a.
This resolves all the issues mentioned in this issue plus:
* popup menu not s...
Hynek Cihlar
10:32 AM Bug #3550: Window restore from maximized state GUI mode issue
Greg Shah wrote:
> Eugenie confirmed this is not an issue in Swing.
To be clear. The Swing portion of the issue i...
Eugenie Lyzenko
10:28 AM Bug #3550: Window restore from maximized state GUI mode issue
Eugenie confirmed this is not an issue in Swing. Greg Shah
09:41 AM Bug #3550: Window restore from maximized state GUI mode issue
This can be recreated in trunk revision 11248 (and before). It is not related to the changes from #3548, but was jus... Greg Shah
09:39 AM Bug #3550: Window restore from maximized state GUI mode issue
Found issue in trunk for hotel GUI. When window is restoring from maximized state by restore title bar button the win... Eugenie Lyzenko
09:33 AM Bug #3550 (New): Window restore from maximized state GUI mode issue
Eugenie Lyzenko
10:29 AM Bug #3548 (Closed): Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Greg Shah
10:22 AM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Greg Shah wrote:
> Did you test Hotel GUI in both Swing and Web?
Yes. The Swing difference is in new issue that f...
Eugenie Lyzenko
09:56 AM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Did you test Hotel GUI in both Swing and Web? Greg Shah
09:32 AM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Branch @3548a@ was merged to trunk as revno @11248@ then it was archived. Eugenie Lyzenko
08:25 AM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Please merge 3548a to trunk.
> But found issue in trunk for hotel GUI. When window is restoring from maximized sta...
Greg Shah
08:01 AM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Not found the regressions in hotel @GUI@.
But found issue in trunk for hotel GUI. When window is restoring from ma...
Eugenie Lyzenko
07:35 AM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Greg Shah wrote:
> Have you already tested Hotel GUI?
In progress now. Need to check one option comparing with tr...
Eugenie Lyzenko
07:26 AM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Have you already tested Hotel GUI? Greg Shah
07:25 AM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Greg Shah wrote:
> What GUI testing is needed to confirm this is safe for trunk? Is it enough to test the AW and Ho...
Eugenie Lyzenko
07:09 AM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
What GUI testing is needed to confirm this is safe for trunk? Is it enough to test the AW and Hotel usage cases? Greg Shah
02:40 AM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Code review 3548a revision 11253.
The changes are OK. I don't register any more open points for the branch.
Hynek Cihlar

04/17/2018

05:36 PM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Hynek Cihlar wrote:
>
> The test case is as follows. Show a window, hide it, assign menu-bar, read the @FULL-@ att...
Eugenie Lyzenko
05:19 PM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Eugenie Lyzenko wrote:
> >Consider the case when the window layout is changed (for example menu-bar assigned) while ...
Hynek Cihlar
05:13 PM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Hynek Cihlar wrote:
> Code review 3548a revision 11252.
>
> The code changes are OK except the @!config().dynamic...
Eugenie Lyzenko
04:56 PM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > Code review 3548a revision 11251.
> >
> > The changes are good....
Hynek Cihlar
07:10 AM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Hynek Cihlar wrote:
> Code review 3548a revision 11251.
>
> The changes are good. But note that the value of the ...
Eugenie Lyzenko
04:48 AM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Code review 3548a revision 11251.
The changes are good. But note that the value of the @FULL-*@ attribute changes ...
Hynek Cihlar
11:03 AM Feature #3469: final improvements and polish for the embedded mode web client
See #3498-21 for a list of some ADM2 reference materials. Greg Shah
04:41 AM Feature #3469: final improvements and polish for the embedded mode web client
Eric, if you want to be sure, convert with this patch applied to trunk, then with the patch applied to your branch an... Constantin Asofiei
02:19 AM Feature #3469: final improvements and polish for the embedded mode web client
Eric Faulhaber wrote:
> Constantin, there is a TRPL function @generate_code_for_page_getPageHandles@ in @rules/adm/a...
Constantin Asofiei
01:00 AM Feature #3469: final improvements and polish for the embedded mode web client
Constantin, there is a TRPL function @generate_code_for_page_getPageHandles@ in @rules/adm/adm_windows.xml@. I see th... Eric Faulhaber

04/16/2018

01:33 PM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Task branch @3548a@ has been updated for review to revision @11251@.
This is reworked code with changed location t...
Eugenie Lyzenko
01:30 PM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Code review task branch 3548a revision 11250.
@WindowGuiImpl.fullSizeAttributesUpdated@ is redundant. Just move th...
Hynek Cihlar
07:02 AM Bug #3548: Window widget FULL-(WIDTH|HEIGHT)-(CHARS|PIXELS) proper initialization
Task branch @3548a@ has been updated for review to revision @11250@.
This is the small typo fixes for file headers...
Eugenie Lyzenko
09:35 AM Bug #3286 (Closed): fix features that can be relied upon to implement a limited form of dynamic r...
The work for this was done in #3434. The fixes in branch 3434a were merged into trunk as revision 11246. Greg Shah
 

Also available in: Atom