Activity
From 07/13/2018 to 08/11/2018
08/10/2018
- 05:33 PM Feature #3469: final improvements and polish for the embedded mode web client
- Constantin Asofiei wrote:
> From the initial list in #3469-1, only this is left:
> * footer control - provide a mec... - 01:23 PM Feature #3469: final improvements and polish for the embedded mode web client
- From the initial list in #3469-1, only this is left:
* footer control - provide a mechanism for the application to p... - 05:32 PM Feature #3218: enhance the embedded mode web GUI to implement a good default approach for common ...
- Greg Shah wrote:
> I think this task can be closed, right?
Yes. 3218a was archived as dead. - 04:31 PM Feature #3218: enhance the embedded mode web GUI to implement a good default approach for common ...
- I think this task can be closed, right?
- 01:24 PM Feature #3218: enhance the embedded mode web GUI to implement a good default approach for common ...
- From 3218a branch, all usable code was extracted into #3469 branches and used. Otherwise, the branch can be archived.
- 09:06 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- When can you have a working version that can be tested/shown to a customer?
- 03:22 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- > Stanislav, have you been following this set of changes to be sure you are on the same page with Ovidiu's changes to...
- 12:07 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Code review 3261d/11278.
None of the changed files have history entries.
@QueryComponent.resolveArg@ was made @...
08/08/2018
- 01:54 PM Feature #3681: replace the window decorations with a lightweight implementation
- In #3599-135 through #3599-144, there is a discussion in which Ovidiu notes that the window decorations (caption butt...
- 01:50 PM Feature #3681 (New): replace the window decorations with a lightweight implementation
08/07/2018
- 06:22 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Thanks to Eric's idea the dynamic filtering is now running for compound queries.
While testing the new filtering par... - 04:11 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Eric Faulhaber wrote:
> In @CompoundQuery@, can you reset @components@ to @null@, work with @originalComponents@ ins...
08/06/2018
- 03:39 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- From Ovidiu via email w.r.t. the persistence support for filtering:
> While testing I found some cases when the HQ... - 03:33 PM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
- That is really impressive! Well done.
- 12:05 PM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
- Greg Shah wrote:
> > Do we want to redraw (and relayout) the resized window, after each pixel difference for windows...
08/05/2018
- 12:57 PM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
- Greg Shah wrote:
> In the next phase of dynamic layout, I was planning frame-level and window-level layout strategie...
08/03/2018
- 09:23 AM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
- Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > (2) The window resize is painfully slow. This is also present i... - 09:01 AM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
- I think the results are fantastic. This is really, really good!
> (1) The resize breaks the UI somewhat. For exam... - 01:53 AM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
- Hynek Cihlar wrote:
> (2) The window resize is painfully slow. This is also present in trunk. The problem is that we... - 09:44 PM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
- I'm attaching a demo demonstrating the current state of implementation. The attached animated gif shows the Hotel GUI...
08/02/2018
- 05:15 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- >> Where do you plan to put these buttons?
>
> I'm planning to put then on a small panel over cells data, bound to ... - 04:54 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- > Good. I assume that subsequent columns clicked become the 2, 3...?
Yes.
> Where do you plan to put these but... - 09:18 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- > I assume we want to implement multiple-column sorting criteria.
Yes.
> We have sorting arrows and sorting num... - 07:04 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Greg, how sorting UI logic should work? I assume we want to implement multiple-column sorting criteria. We have sorti...
- 03:57 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Created task branch 3261d from P2J trunk revision 11276.
- 03:10 AM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
- 3269a rebased against trunk revision 11276.
07/31/2018
- 06:28 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Updated list of work remaining. Completed items are crossed out. Items not listed before are bold.
* -hyperlinkin... - 04:18 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Ovidiu Maxiniuc wrote:
> Hynek Cihlar wrote:
> > Add @com.goldencode.util.LogHelper.traces(15, windowId)@ to @selec... - 04:14 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Hynek Cihlar wrote:
> Add @com.goldencode.util.LogHelper.traces(15, windowId)@ to @selectWindow()@ and find out the ... - 03:19 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Add @com.goldencode.util.LogHelper.traces(15, windowId)@ to @selectWindow()@ and find out the places that do window s...
- 02:53 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- After setting the @enhancedBrowseEnabled@ in directory, the client got disconnected after right-clicking the header o...
- 05:09 PM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
- 3269a rebased against trunk revision 11275.
07/27/2018
- 07:27 PM Feature #3469 (WIP): final improvements and polish for the embedded mode web client
- 3469b was merged to trunk rev 11275 and archived.
- 07:15 PM Feature #3469: final improvements and polish for the embedded mode web client
- Yes, please merge to trunk.
- 07:01 PM Feature #3469: final improvements and polish for the embedded mode web client
- OK, I have Hotel GUI up-to-date with 3469b rev 11279 (added @p2j.emain.js@) and is working properly. I can merge thi...
- 06:57 PM Feature #3469: final improvements and polish for the embedded mode web client
- Constantin Asofiei wrote:
> Greg Shah wrote:
> > Code Review Task Branch 3469b Revision 11274
> I assume you revie... - 05:36 PM Feature #3469: final improvements and polish for the embedded mode web client
- Constantin Asofiei wrote:
> Greg Shah wrote:
> > Code Review Task Branch 3469b Revision 11274
> I assume you revie... - 04:39 PM Feature #3469: final improvements and polish for the embedded mode web client
- Greg Shah wrote:
> Code Review Task Branch 3469b Revision 11274
I assume you reviewed 11277? - 03:25 PM Feature #3469: final improvements and polish for the embedded mode web client
- Code Review Task Branch 3469b Revision 11277
Sorry it took a while for the review. I think the changes are really... - 12:58 PM Feature #3469: final improvements and polish for the embedded mode web client
- I've rebased and updated 3469b to 11277 - Greg, please review.
- 08:10 AM Feature #3469: final improvements and polish for the embedded mode web client
- Greg, if you want to review 3469b 11275, please go ahead.
- 10:03 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- 3261c has been merged into the trunk as bzr revision 11274.
07/26/2018
- 07:28 PM Feature #3469: final improvements and polish for the embedded mode web client
- 3469b rev 11275 contains almost final changes. What is left is:
# p2j.embedded.js cleanup
# finish the JS 'merger'... - 03:37 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- > I guess that is all. Can I commit?
How quickly can you test these changed paths using Hotel GUI? I just want to... - 02:36 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- > Review for 3261c rev 11318:
> # @FontManager.registerFontDetails@ - you have @selectWindow@ on line 412 instead of... - 02:16 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Review for 3261c rev 11318:
# @FontManager.registerFontDetails@ - you have @selectWindow@ on line 412 instead of @re... - 02:06 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Ovidiu Maxiniuc wrote:
> Current revision 11321.
The changes from r11319 look good. - 01:58 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Eric Faulhaber wrote:
> Code review 3261c/11319 (persistence only):
> * @DBUtils.toSqlValue@ isn't referenced anymo... - 01:06 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Greg Shah wrote:
> Eric: Please review the query changes.
Code review 3261c/11319 (persistence only):
* @DBUti... - 12:30 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Greg Shah wrote:
> Code Review Task Branch 3261c Revision 11318
> Ovidiu: @QueryComponent.resolveArg()@, @RandomAcc... - 12:26 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- If the remaining code reviews are OK, then I would like you to merge to trunk.
- 11:45 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- > Stanislav: Please restart ChUI regression testing (if you haven't already done so).
I've tested 11317. 11318 con... - 11:42 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Stanislav: Please restart ChUI regression testing (if you haven't already done so).
Am I correct that it has passe... - 11:41 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Code Review Task Branch 3261c Revision 11318
Stanislav: The changes look fine to me.
Ovidiu: @QueryComponent.re... - 10:31 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- > Please check the smoke tests in the customer app. If they work properly, then we can merge to trunk.
Greg, I've...
07/25/2018
- 04:37 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Stanislav Lomany wrote:
> Guys, during the smoke test 1, when an estimate is added using the editable browse row, at... - 04:36 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Guys, during the smoke test 1, when an estimate is added using the editable browse row, at the point just after a cel...
07/24/2018
- 06:09 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Ovidiu, I've tested only r11315 revision, so I'll restart regression testing. Let me know if you want to check in som...
- 05:30 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- I understand. There a big set of changes and it is better to get it to trunk or else maintenance/rebasing is hell. If...
- 05:19 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- > Is this abend limited to enhanced mode?
Yes.
> but if you have already tested then I can commit my changes to... - 05:16 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Stanislav Lomany wrote:
> > What testing has been done on the customer application? What about testing on Hotel GUI... - 05:08 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Stanislav Lomany wrote:
> I missed the message that gc_64 fails in trunk, so consider the regression testing for 326... - 05:03 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- > What testing has been done on the customer application? What about testing on Hotel GUI?
Some random testing in... - 02:19 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- What testing has been done on the customer application? What about testing on Hotel GUI?
- 01:01 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- I missed the message that gc_64 fails in trunk, so consider the regression testing for 3261c passed. Should I merge i...
07/23/2018
- 09:15 AM Feature #3469: final improvements and polish for the embedded mode web client
- Yes, it seems that it was my mistake.
- 09:09 AM Feature #3469: final improvements and polish for the embedded mode web client
- Constantin Asofiei wrote:
> FYI, the zips in this folder have another zip inside with the same file content, which d... - 08:54 AM Feature #3469: final improvements and polish for the embedded mode web client
- I think that must be a mistake.
Hynek/Sergey: please see #3469-78 and comment. - 02:52 AM Feature #3469: final improvements and polish for the embedded mode web client
- Constantin Asofiei wrote:
> I thought that gradle pulls JS zips from https://proj.goldencode.com/artifacts/javascrip... - 09:00 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- > I thought you resolved this by using bulk web metrics when using a font override.
I request web metrics only f... - 08:44 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- > for some fonts size difference is pretty significant between web and swing, so I suppose we should limit the set of...
07/22/2018
- 06:01 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Greg, FYI: for some fonts size difference is pretty significant between web and swing, so I suppose we should limit t...
07/20/2018
- 06:50 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Eric Faulhaber wrote:
> The cure to SQL injection generally is to use query substitution parameters instead of inlin... - 05:33 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Ovidiu Maxiniuc wrote:
> > * It looks like @QueryComponent.prepareHQLPreprocessor@ is still vulnerable to SQL (HQL?)... - 05:22 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Eric Faulhaber wrote:
> The changes for the sort/filter feature set are less extensive than I thought would be neede... - 04:11 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Summary from Ovidiu about the remaining work needed for the query part of the filtering/sorting support:
> There a... - 01:06 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Rebased 3261c from trunk rev 11273. Looking into merge issues.
- 12:21 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Greg Shah wrote:
> While we are waiting for Constantin's review
I don't see any other issues beside what was mentio... - 09:01 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- > 1. The @setHyperlinkEvent(character eventName)@ should have @null@ and unknown value protection.
I'll add @null@... - 08:42 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Code Review Task Branch 3261c Revision 11308
Generally, I'm good with these changes. I've committed some minor ch... - 08:36 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- In regard to revision 11307, I wonder if there are still ways that SQL injection can be done....
- 08:20 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- > 2. I think we should implement @HYPERLINK@ as a browse column attribute...
> 3. I think that @BrowseWidget.checkDu... - 02:04 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Code review 3261c/11307 (persistence changes only):
The changes for the sort/filter feature set are less extensive... - 10:03 AM Bug #3640 (Closed): using font or color choosing dialogs more than once in the web client hangs t...
- 09:35 AM Bug #3640: using font or color choosing dialogs more than once in the web client hangs the client
- I successfully tested the update with injected code and then with scenario encountered by Eric and communicated by pr...
- 03:47 AM Bug #3640: using font or color choosing dialogs more than once in the web client hangs the client
- Task branch 3600b was merged to trunk revision 11273. Can this be closed?
- 09:42 AM Bug #3637 (Closed): The frame is not shown with its default window after executing 'enable all wi...
07/19/2018
- 06:14 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- > For the ABL programmer I think we can add an option FILTERABLE and SORTABLE when the column is defined. By default ...
- 05:24 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Greg Shah wrote:
> 1. Do we need to provide a method for the 4GL developer to disable filtering (or even sorting) on... - 08:17 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- > Currently hyperlink is client-side only widget. If you want to access widget attributes like hyperlink color (unles...
- 07:38 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- > 1. What is the value for @BrowseConfig.ehKeyBrowseName@ when using a dynamic browse?...
- 04:35 AM Feature #3469: final improvements and polish for the embedded mode web client
- > business code notification for page switch (I see no way other than ADM sources to do a PUBLISH that the page chang...
- 04:34 AM Feature #3469: final improvements and polish for the embedded mode web client
- > I meant that currently is working in a way that embedded server starts with the FWD server, with all Hotel GUI embe...
07/18/2018
- 06:38 PM Feature #3469: final improvements and polish for the embedded mode web client
- Greg Shah wrote:
> The @/embedded@ context makes sense.
>
> > for example, the Hotel GUI - we can make this to au... - 06:33 PM Feature #3469: final improvements and polish for the embedded mode web client
- The @/embedded@ context makes sense.
> for example, the Hotel GUI - we can make this to automatically start the em... - 06:01 PM Feature #3469: final improvements and polish for the embedded mode web client
- Greg, the default embedded web server is mostly working (allowing all the resources to be handled from the app jar, n...
- 05:38 PM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
- Created task branch 3269a.
- 04:58 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- A quick note: this code in RandomAccessQuery will fail first time the user inputs a single quote in the value: @filte...
- 04:29 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Code Review Task Branch 3261c Revision 11305
Overall this is a very good set of changes. It is so large that ther... - 11:15 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- > Please review 3261c rev 11304.
Added a fix: review 11305. - 03:03 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Please review 3261c rev 11304.
- 08:49 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Rebased task branch 3261c from P2J trunk revision 11272.
- 08:50 AM Bug #3597: fix direct manipulation problems related to MOVABLE, SELECTED, SELECTABLE and misc wid...
- Another implementation note: the JS side will need to save the current window canvas and the dotted rectangle will be...
- 08:48 AM Bug #3597: fix direct manipulation problems related to MOVABLE, SELECTED, SELECTABLE and misc wid...
- Constantin Asofiei wrote:
> I'm not sure I understand - there is no @drawSelectedArea()@ method - you mean @MouseDir... - 02:47 AM Bug #3597: fix direct manipulation problems related to MOVABLE, SELECTED, SELECTABLE and misc wid...
- Eugenie Lyzenko wrote:
> If my understanding is correct the problematic areas are the drawing the dotted widgets bou...
07/17/2018
- 09:43 PM Bug #3597: fix direct manipulation problems related to MOVABLE, SELECTED, SELECTABLE and misc wid...
- Constantin Asofiei wrote:
> At some point there was some discussion about the fact that the move/resize is not 'live...
07/13/2018
- 07:30 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Stanislav Lomany wrote:
> Do we want by default render right-aligned columns (not hyperlinks) using proper web metri... - 07:20 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
- Do we want by default render right-aligned columns (not hyperlinks) using proper web metrics?
Also available in: Atom