Project

General

Profile

Activity

From 07/23/2018 to 08/21/2018

08/21/2018

11:29 AM Bug #3693 (Rejected): web client dragging titlebar drops the window while still dragging
Duplicates an existing issue. Greg Shah
11:22 AM Bug #3693: web client dragging titlebar drops the window while still dragging
In the web client virtual desktop mode, if you try to move a window by dragging the titlebar, the drag operation will... Greg Shah
11:20 AM Bug #3693 (Rejected): web client dragging titlebar drops the window while still dragging
Greg Shah
11:05 AM Bug #3692: invalid handle in tree view
Recreate in Hotel GUI:
# Login
# Switch to the Rooms tab.
# Select any room in the browse.
# Click "Update Room...
Greg Shah
11:01 AM Bug #3692 (New): invalid handle in tree view
Greg Shah
10:57 AM Bug #3691: literal $ character in format appears on the right side of the fill-in
Recreate in Hotel GUI:
# Login
# Click on the Rates tab.
# Select any room type in the browse.
# Click Add butt...
Greg Shah
10:51 AM Bug #3691 (New): literal $ character in format appears on the right side of the fill-in
Greg Shah

08/20/2018

10:27 AM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > How do we get the dynamic layout feature to fill the availabl...
Hynek Cihlar
08:23 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> One more feature I would really like to get into the enhanced browse is the ability to "stripe" the rows (alternati... Stanislav Lomany

08/18/2018

08:37 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
One more feature I would really like to get into the enhanced browse is the ability to "stripe" the rows (alternating... Eric Faulhaber

08/17/2018

07:34 PM Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
Well, just retested with AW VM Windows8 system. Got different button colors for hovered and pressed states:
The @hov...
Eugenie Lyzenko
05:11 PM Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys
The issues to solve here:
1. Investigate and fix how the reaction on @ENTER@ key implemented in 4GL.
2. Find out th...
Eugenie Lyzenko
05:04 PM Bug #3690 (Closed): BUTTON widget reaction on SPACEBAR and ENTER keys
Eugenie Lyzenko
06:28 PM Feature #3684: implement a web theme inspired by material design
I committed a new revision (r11305) to 3670a.
What's new:
* improved browse drawing;
* added support for drawing ...
Ovidiu Maxiniuc
03:46 PM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
Eric Faulhaber wrote:
> How do we get the dynamic layout feature to fill the available iframe space in embedded mode...
Constantin Asofiei
03:14 PM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
Eric Faulhaber wrote:
> How do we get the dynamic layout feature to fill the available iframe space in embedded mode...
Hynek Cihlar
02:43 PM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
How do we get the dynamic layout feature to fill the available iframe space in embedded mode? Eric Faulhaber
12:28 PM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
To enable the dynamic layout feature, it must be turned on in the directory. The feature is turned globally for all t... Hynek Cihlar
11:55 AM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
Hynek Cihlar wrote:
> Eric, there is are couple of new config values in the directory. I will post here a documentat...
Eric Faulhaber
11:51 AM Bug #3632: BUTTON and COMBO-BOX don't react on ENTER key
The @BUTTON@ widget regression has been fixed in @3661a@ revision @11282@.
So far the task loos completed.
Eugenie Lyzenko
10:46 AM Bug #3632: BUTTON and COMBO-BOX don't react on ENTER key
Only @SPACEBAR@ key pressing has visual feedback in @4GL@. @ENTER@ key has nothing to be visible.
So we have the d...
Eugenie Lyzenko
10:30 AM Bug #3632: BUTTON and COMBO-BOX don't react on ENTER key
Task branch @3661a@ has been updated for review to revision @11281@.
This is the fix for @COMBO-BOX@ reaction on @...
Eugenie Lyzenko
08:04 AM Bug #3632: BUTTON and COMBO-BOX don't react on ENTER key
Hynek Cihlar wrote:
> For BUTTON, when it is focused, pressing SPACEBAR should cause the @CHOOSE@ event. In FWD pres...
Hynek Cihlar
08:00 AM Bug #3632: BUTTON and COMBO-BOX don't react on ENTER key
The simplest use cases can be used to reproduce this, @uast/demo/demo_widgets.p@ will do.
As of trunk revision 112...
Hynek Cihlar
11:14 AM Feature #3681: replace the window decorations with a lightweight implementation
Another component that is really not needed is the @BorderedPanelGuiImpl@, and probably its immediate ancestor. If th... Ovidiu Maxiniuc

08/16/2018

11:19 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Stanislav,
Please update to revision 11282. After the variables were initialized the client application started work...
Ovidiu Maxiniuc
10:38 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Stanislav Lomany wrote:
> There is no testcase, I just can't login the customer app. The data on on the login screen...
Ovidiu Maxiniuc
09:52 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
I'm debugging it. Stanislav Lomany
09:05 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
There is no testcase, I just can't login the customer app. The data on on the login screen is not filled with this er... Stanislav Lomany
08:55 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Stanislav Lomany wrote:
> It is about the changes in @RandomAccessQuery.java@ and @QueryComponent.java@. I guess som...
Ovidiu Maxiniuc

08/15/2018

07:26 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> Have you sorted out this range issue? I don't recall encountering it and I have no idea where it comes from. Do you... Stanislav Lomany
11:14 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Stanislav Lomany wrote:
> Ovidiu, I'll be posting dynamic sorting/filtering issues I'll find. I'll try to find maxim...
Ovidiu Maxiniuc
06:48 PM Feature #3684: implement a web theme inspired by material design
I committed a new revision (r11294) to 3670a.
What's new:
* added ellipses drawing primitive (not yet tested on Swi...
Ovidiu Maxiniuc
07:58 AM Feature #3684: implement a web theme inspired by material design
Guidelines for Material Design:
https://material.io/design/
I've seen some examples of scrollbars:
https://m...
Greg Shah
07:01 AM Feature #3684: implement a web theme inspired by material design
Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > Btw, I committed a 1st revision r11288 in 3670a.
> You've a...
Ovidiu Maxiniuc
04:12 PM Bug #3689: In Web GUI when a window is maximized the title bar buttons stop accepting mouse input
To reproduce just maximize any window and try to restore it. The restore won't work, it seems the title bar buttons s... Hynek Cihlar
04:11 PM Bug #3689 (New): In Web GUI when a window is maximized the title bar buttons stop accepting mouse...
Hynek Cihlar
04:09 PM Bug #3688: Window can't be resized to smaller sizes
This can be reproduced in Hotel GUI for example. The main application window, after login, can be resized to larger b... Hynek Cihlar
04:05 PM Bug #3688 (New): Window can't be resized to smaller sizes
Hynek Cihlar
04:01 PM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
3269a 11306 was merged to trunk as revision 11279. The task branch was archived. Hynek Cihlar
02:48 PM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
Hynek Cihlar wrote:
> Fixed in 3269a revision 11306. I also checked in fixes for several layout edge cases. Please r...
Constantin Asofiei
02:03 PM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
Greg Shah wrote:
> > is there anything holding back merging 3269a to trunk?
>
> I think it can be merged to trunk...
Hynek Cihlar
02:03 PM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
Eric Faulhaber wrote:
> Hynek Cihlar wrote:
> > These kind of UIs would require some assumptions of the widget stru...
Hynek Cihlar
02:01 PM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
Eric Faulhaber wrote:
> Hynek, Greg, Constantin, is there anything holding back merging 3269a to trunk?
>
> Hynek...
Hynek Cihlar
11:51 AM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
> is there anything holding back merging 3269a to trunk?
I think it can be merged to trunk.
Greg Shah
11:50 AM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
Eric Faulhaber wrote:
> Hynek Cihlar wrote:
> > These kind of UIs would require some assumptions of the widget stru...
Greg Shah
11:46 AM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
Hynek Cihlar wrote:
> These kind of UIs would require some assumptions of the widget structure or compile time hinti...
Eric Faulhaber
11:43 AM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
Hynek, Greg, Constantin, is there anything holding back merging 3269a to trunk?
Hynek, how do we enable the feature?
Eric Faulhaber

08/14/2018

07:49 PM Feature #3684: implement a web theme inspired by material design
Ovidiu Maxiniuc wrote:
> Btw, I committed a 1st revision r11288 in 3670a.
You've added a @src2/@ folder - is this t...
Constantin Asofiei
05:29 PM Feature #3684: implement a web theme inspired by material design
Yes, feel free to add primitives to the GUI driver as needed. Greg Shah
05:28 PM Feature #3684 (WIP): implement a web theme inspired by material design
Yes, we are drawing them as circles, but they are actually tiny images.
I could do the same here, but then they w...
Ovidiu Maxiniuc
05:21 PM Feature #3684: implement a web theme inspired by material design
Ovidiu Maxiniuc wrote:
> for radio buttons I need to paint circles/ellipses. The @GuiDriver@ completely lacks suppor...
Eric Faulhaber
05:17 PM Feature #3684: implement a web theme inspired by material design
I encountered two issues until now:
* painting using the width of the line of 2 pixels. It seems to me that we do no...
Ovidiu Maxiniuc
12:43 PM Feature #3684: implement a web theme inspired by material design
Ovidiu Maxiniuc wrote:
> BTW, is it OK to name the new class @MaterialTheme@?
Yes.
Eric Faulhaber
12:42 PM Feature #3684: implement a web theme inspired by material design
Eric Faulhaber wrote:
> Unless there is a high risk of regression, please add this implementation to task branch 367...
Ovidiu Maxiniuc
12:35 PM Feature #3684: implement a web theme inspired by material design
Unless there is a high risk of regression, please add this implementation to task branch 3670a. Eric Faulhaber
05:44 PM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Review for 3269a rev 11303:
> > * the @-T- @ column needs to b...
Hynek Cihlar
01:55 PM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
Constantin Asofiei wrote:
> Review for 3269a rev 11303:
> * the @-T- @ column needs to be removed from the header e...
Hynek Cihlar
01:05 PM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
Review for 3269a rev 11303:
* the @-T- @ column needs to be removed from the header entries of @Directory.java@, @Di...
Constantin Asofiei
08:00 AM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
I should mention that the current state of the dynamic layout algorithm works by laying out widget containers individ... Hynek Cihlar
04:36 AM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
> Please review 3269a revision 11303. The revision passed GUI regression tests, ChUI is yet in progress.
The brows...
Stanislav Lomany
05:10 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Ovidiu, I'll be posting dynamic sorting/filtering issues I'll find. I'll try to find maximum of them before you go to... Stanislav Lomany
09:20 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Rebased task branch 3261d from P2J trunk revision 11278. Stanislav Lomany
12:47 PM Bug #3686: PSTimer threads must be cleaned up when the client session terminates
From #3552-118:
Constantin Asofiei wrote:
> Greg Shah wrote:
> > > The notifyPWD is supposed to notify any threa...
Greg Shah
12:25 PM Bug #3686: PSTimer threads must be cleaned up when the client session terminates
See #3552-113, #3552-114, #3552-115, #3552-116 and others. The idea here is the PSTimer thread is left with this sta... Constantin Asofiei
12:21 PM Bug #3686 (Closed): PSTimer threads must be cleaned up when the client session terminates
Constantin Asofiei

08/13/2018

06:38 PM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
Please review 3269a revision 11303. The revision passed GUI regression tests, ChUI is yet in progress. Hynek Cihlar
09:01 AM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
Status report.
I am wrapping up regression testing. GUI passes all the regression tests. I found some errors duri...
Hynek Cihlar
04:36 AM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
3269a rebased against trunk revision 11278. Hynek Cihlar
12:56 PM Feature #3684: implement a web theme inspired by material design
Constantin,
Where can I find details on how to set-up the embedded web environment for the project so that I can s...
Ovidiu Maxiniuc
12:30 PM Feature #3684: implement a web theme inspired by material design
> I understand that this will be a default theme for web clients only.
It really depends on the result. If we ca...
Greg Shah
12:21 PM Feature #3684: implement a web theme inspired by material design
I took a look over the demo widgets at [[material-components-web.appspot.com]]. I understand that we will create a fr... Ovidiu Maxiniuc
12:17 PM Feature #3684: implement a web theme inspired by material design
In regards to CSS theme colors: we could just redefine the 4GL color-table from CSS values, via some dedicated API. Constantin Asofiei
12:11 PM Feature #3684: implement a web theme inspired by material design
Our embedded mode client uses the https://codyhouse.co/demo/multi-level-accordion-menu/index.html for menus. I don't... Greg Shah
12:07 PM Feature #3684: implement a web theme inspired by material design
Our current themes work for all GUI clients. I did not intend to make this enhanced theme only for the GUI embedded ... Greg Shah
11:51 AM Feature #3684: implement a web theme inspired by material design
Currently, we have legacy-based Windows-like UI themes, but when placed in the context of an embedded web client, the... Eric Faulhaber
11:34 AM Feature #3684 (Closed): implement a web theme inspired by material design
Eric Faulhaber
07:07 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> When can you have a working version that can be tested/shown to a customer?
Around the next Monday.
Stanislav Lomany
09:51 PM Feature #3218 (Closed): enhance the embedded mode web GUI to implement a good default approach fo...
Greg Shah

08/10/2018

05:33 PM Feature #3469: final improvements and polish for the embedded mode web client
Constantin Asofiei wrote:
> From the initial list in #3469-1, only this is left:
> * footer control - provide a mec...
Constantin Asofiei
01:23 PM Feature #3469: final improvements and polish for the embedded mode web client
From the initial list in #3469-1, only this is left:
* footer control - provide a mechanism for the application to p...
Constantin Asofiei
05:32 PM Feature #3218: enhance the embedded mode web GUI to implement a good default approach for common ...
Greg Shah wrote:
> I think this task can be closed, right?
Yes. 3218a was archived as dead.
Constantin Asofiei
04:31 PM Feature #3218: enhance the embedded mode web GUI to implement a good default approach for common ...
I think this task can be closed, right? Greg Shah
01:24 PM Feature #3218: enhance the embedded mode web GUI to implement a good default approach for common ...
From 3218a branch, all usable code was extracted into #3469 branches and used. Otherwise, the branch can be archived. Constantin Asofiei
09:06 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
When can you have a working version that can be tested/shown to a customer? Greg Shah
03:22 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> Stanislav, have you been following this set of changes to be sure you are on the same page with Ovidiu's changes to... Stanislav Lomany
12:07 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Code review 3261d/11278.
None of the changed files have history entries.
@QueryComponent.resolveArg@ was made @...
Eric Faulhaber

08/08/2018

01:54 PM Feature #3681: replace the window decorations with a lightweight implementation
In #3599-135 through #3599-144, there is a discussion in which Ovidiu notes that the window decorations (caption butt... Greg Shah
01:50 PM Feature #3681 (New): replace the window decorations with a lightweight implementation
Greg Shah

08/07/2018

06:22 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Thanks to Eric's idea the dynamic filtering is now running for compound queries.
While testing the new filtering par...
Ovidiu Maxiniuc
04:11 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Eric Faulhaber wrote:
> In @CompoundQuery@, can you reset @components@ to @null@, work with @originalComponents@ ins...
Ovidiu Maxiniuc

08/06/2018

03:39 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
From Ovidiu via email w.r.t. the persistence support for filtering:
> While testing I found some cases when the HQ...
Eric Faulhaber
03:33 PM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
That is really impressive! Well done. Greg Shah
12:05 PM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
Greg Shah wrote:
> > Do we want to redraw (and relayout) the resized window, after each pixel difference for windows...
Hynek Cihlar

08/05/2018

12:57 PM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
Greg Shah wrote:
> In the next phase of dynamic layout, I was planning frame-level and window-level layout strategie...
Hynek Cihlar

08/03/2018

09:23 AM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > (2) The window resize is painfully slow. This is also present i...
Ovidiu Maxiniuc
09:01 AM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
I think the results are fantastic. This is really, really good!
> (1) The resize breaks the UI somewhat. For exam...
Greg Shah
01:53 AM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
Hynek Cihlar wrote:
> (2) The window resize is painfully slow. This is also present in trunk. The problem is that we...
Constantin Asofiei
09:44 PM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
I'm attaching a demo demonstrating the current state of implementation. The attached animated gif shows the Hotel GUI... Hynek Cihlar

08/02/2018

05:15 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
>> Where do you plan to put these buttons?
>
> I'm planning to put then on a small panel over cells data, bound to ...
Greg Shah
04:54 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> Good. I assume that subsequent columns clicked become the 2, 3...?
Yes.
> Where do you plan to put these but...
Stanislav Lomany
09:18 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> I assume we want to implement multiple-column sorting criteria.
Yes.
> We have sorting arrows and sorting num...
Greg Shah
07:04 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Greg, how sorting UI logic should work? I assume we want to implement multiple-column sorting criteria. We have sorti... Stanislav Lomany
03:57 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Created task branch 3261d from P2J trunk revision 11276. Stanislav Lomany
03:10 AM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
3269a rebased against trunk revision 11276. Hynek Cihlar

07/31/2018

06:28 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Updated list of work remaining. Completed items are crossed out. Items not listed before are bold.

* -hyperlinkin...
Stanislav Lomany
04:18 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Ovidiu Maxiniuc wrote:
> Hynek Cihlar wrote:
> > Add @com.goldencode.util.LogHelper.traces(15, windowId)@ to @selec...
Hynek Cihlar
04:14 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Hynek Cihlar wrote:
> Add @com.goldencode.util.LogHelper.traces(15, windowId)@ to @selectWindow()@ and find out the ...
Ovidiu Maxiniuc
03:19 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Add @com.goldencode.util.LogHelper.traces(15, windowId)@ to @selectWindow()@ and find out the places that do window s... Hynek Cihlar
02:53 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
After setting the @enhancedBrowseEnabled@ in directory, the client got disconnected after right-clicking the header o... Ovidiu Maxiniuc
05:09 PM Feature #3269: implement optional enhanced mode for ABL GUI which supports dynamic layout
3269a rebased against trunk revision 11275. Hynek Cihlar

07/27/2018

07:27 PM Feature #3469 (WIP): final improvements and polish for the embedded mode web client
3469b was merged to trunk rev 11275 and archived. Constantin Asofiei
07:15 PM Feature #3469: final improvements and polish for the embedded mode web client
Yes, please merge to trunk. Greg Shah
07:01 PM Feature #3469: final improvements and polish for the embedded mode web client
OK, I have Hotel GUI up-to-date with 3469b rev 11279 (added @p2j.emain.js@) and is working properly. I can merge thi... Constantin Asofiei
06:57 PM Feature #3469: final improvements and polish for the embedded mode web client
Constantin Asofiei wrote:
> Greg Shah wrote:
> > Code Review Task Branch 3469b Revision 11274
> I assume you revie...
Greg Shah
05:36 PM Feature #3469: final improvements and polish for the embedded mode web client
Constantin Asofiei wrote:
> Greg Shah wrote:
> > Code Review Task Branch 3469b Revision 11274
> I assume you revie...
Eric Faulhaber
04:39 PM Feature #3469: final improvements and polish for the embedded mode web client
Greg Shah wrote:
> Code Review Task Branch 3469b Revision 11274
I assume you reviewed 11277?
Constantin Asofiei
03:25 PM Feature #3469: final improvements and polish for the embedded mode web client
Code Review Task Branch 3469b Revision 11277
Sorry it took a while for the review. I think the changes are really...
Greg Shah
12:58 PM Feature #3469: final improvements and polish for the embedded mode web client
I've rebased and updated 3469b to 11277 - Greg, please review. Constantin Asofiei
08:10 AM Feature #3469: final improvements and polish for the embedded mode web client
Greg, if you want to review 3469b 11275, please go ahead. Constantin Asofiei
10:03 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
3261c has been merged into the trunk as bzr revision 11274. Stanislav Lomany

07/26/2018

07:28 PM Feature #3469: final improvements and polish for the embedded mode web client
3469b rev 11275 contains almost final changes. What is left is:
# p2j.embedded.js cleanup
# finish the JS 'merger'...
Constantin Asofiei
03:37 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> I guess that is all. Can I commit?
How quickly can you test these changed paths using Hotel GUI? I just want to...
Greg Shah
02:36 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> Review for 3261c rev 11318:
> # @FontManager.registerFontDetails@ - you have @selectWindow@ on line 412 instead of...
Stanislav Lomany
02:16 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Review for 3261c rev 11318:
# @FontManager.registerFontDetails@ - you have @selectWindow@ on line 412 instead of @re...
Constantin Asofiei
02:06 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Ovidiu Maxiniuc wrote:
> Current revision 11321.
The changes from r11319 look good.
Eric Faulhaber
01:58 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Eric Faulhaber wrote:
> Code review 3261c/11319 (persistence only):
> * @DBUtils.toSqlValue@ isn't referenced anymo...
Ovidiu Maxiniuc
01:06 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Greg Shah wrote:
> Eric: Please review the query changes.
Code review 3261c/11319 (persistence only):
* @DBUti...
Eric Faulhaber
12:30 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Greg Shah wrote:
> Code Review Task Branch 3261c Revision 11318
> Ovidiu: @QueryComponent.resolveArg()@, @RandomAcc...
Ovidiu Maxiniuc
12:26 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
If the remaining code reviews are OK, then I would like you to merge to trunk. Greg Shah
11:45 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> Stanislav: Please restart ChUI regression testing (if you haven't already done so).
I've tested 11317. 11318 con...
Stanislav Lomany
11:42 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Stanislav: Please restart ChUI regression testing (if you haven't already done so).
Am I correct that it has passe...
Greg Shah
11:41 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Code Review Task Branch 3261c Revision 11318
Stanislav: The changes look fine to me.
Ovidiu: @QueryComponent.re...
Greg Shah
10:31 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> Please check the smoke tests in the customer app. If they work properly, then we can merge to trunk.
Greg, I've...
Stanislav Lomany

07/25/2018

04:37 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Stanislav Lomany wrote:
> Guys, during the smoke test 1, when an estimate is added using the editable browse row, at...
Constantin Asofiei
04:36 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Guys, during the smoke test 1, when an estimate is added using the editable browse row, at the point just after a cel... Stanislav Lomany

07/24/2018

06:09 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Ovidiu, I've tested only r11315 revision, so I'll restart regression testing. Let me know if you want to check in som... Stanislav Lomany
05:30 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
I understand. There a big set of changes and it is better to get it to trunk or else maintenance/rebasing is hell. If... Ovidiu Maxiniuc
05:19 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> Is this abend limited to enhanced mode?
Yes.
> but if you have already tested then I can commit my changes to...
Stanislav Lomany
05:16 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Stanislav Lomany wrote:
> > What testing has been done on the customer application? What about testing on Hotel GUI...
Greg Shah
05:08 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Stanislav Lomany wrote:
> I missed the message that gc_64 fails in trunk, so consider the regression testing for 326...
Ovidiu Maxiniuc
05:03 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> What testing has been done on the customer application? What about testing on Hotel GUI?
Some random testing in...
Stanislav Lomany
02:19 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
What testing has been done on the customer application? What about testing on Hotel GUI? Greg Shah
01:01 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
I missed the message that gc_64 fails in trunk, so consider the regression testing for 3261c passed. Should I merge i... Stanislav Lomany

07/23/2018

09:15 AM Feature #3469: final improvements and polish for the embedded mode web client
Yes, it seems that it was my mistake. Sergey Ivanovskiy
09:09 AM Feature #3469: final improvements and polish for the embedded mode web client
Constantin Asofiei wrote:
> FYI, the zips in this folder have another zip inside with the same file content, which d...
Hynek Cihlar
08:54 AM Feature #3469: final improvements and polish for the embedded mode web client
I think that must be a mistake.
Hynek/Sergey: please see #3469-78 and comment.
Greg Shah
02:52 AM Feature #3469: final improvements and polish for the embedded mode web client
Constantin Asofiei wrote:
> I thought that gradle pulls JS zips from https://proj.goldencode.com/artifacts/javascrip...
Constantin Asofiei
09:00 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> I thought you resolved this by using bulk web metrics when using a font override.
I request web metrics only f...
Stanislav Lomany
08:44 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> for some fonts size difference is pretty significant between web and swing, so I suppose we should limit the set of... Greg Shah
 

Also available in: Atom