Project

General

Profile

Activity

From 09/06/2018 to 10/05/2018

10/06/2018

09:11 PM Feature #2673: support a kind of virtual desktop in the GUI web client
Planning to add new directory settings under @webClient/desktop@... Sergey Ivanovskiy

10/05/2018

03:28 PM Feature #2673: support a kind of virtual desktop in the GUI web client
Yes, agree. Sergey Ivanovskiy
03:26 PM Feature #2673: support a kind of virtual desktop in the GUI web client
Constantin Asofiei wrote:
> Actually, what @Theme.getName()@ is not really usable in a UX point of view: it returns ...
Ovidiu Maxiniuc
01:48 PM Feature #2673: support a kind of virtual desktop in the GUI web client
Thanks for the thoughtful discourse of this task. Planning to follow it. Sergey Ivanovskiy
01:38 PM Feature #2673: support a kind of virtual desktop in the GUI web client
Sergey Ivanovskiy wrote:
> Agree that class annotations can be used for theme name, but in this case we will add new...
Constantin Asofiei
01:27 PM Feature #2673: support a kind of virtual desktop in the GUI web client
The @Theme.getName()@ is practically not used. I added it for similar reasons. Currently the name is only displayed i... Ovidiu Maxiniuc
11:29 AM Feature #2673: support a kind of virtual desktop in the GUI web client
Agree that class annotations can be used for theme name, but in this case we will add new dependency. @Theme@ interfa... Sergey Ivanovskiy
11:17 AM Feature #2673: support a kind of virtual desktop in the GUI web client
Sergey Ivanovskiy wrote:
> > Hmm... ideally we wouldn't need to instantiate the theme to get its name. An annotatio...
Constantin Asofiei
11:13 AM Feature #2673: support a kind of virtual desktop in the GUI web client
Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > > * why is the @OutputManager.instance()@ change required ...
Sergey Ivanovskiy
11:09 AM Feature #2673: support a kind of virtual desktop in the GUI web client
Sergey Ivanovskiy wrote:
> > * why is the @OutputManager.instance()@ change required for this task? Is this trying t...
Constantin Asofiei
11:01 AM Feature #2673: support a kind of virtual desktop in the GUI web client
Constantin Asofiei wrote:
> Review for 3600e rev 11337 (now in trunk 11286):
> * @WebHandler.doPost@ - you need to ...
Sergey Ivanovskiy
10:40 AM Feature #2673: support a kind of virtual desktop in the GUI web client
Review for 3600e rev 11337 (now in trunk 11286):
* @WebHandler.doPost@ - you need to validate @base.getParameter("th...
Constantin Asofiei
10:25 AM Feature #2673: support a kind of virtual desktop in the GUI web client
This code rev 11337 from 3600e is in the trunc rev 11286 already. The rest independent part of my task is to set the ... Sergey Ivanovskiy
10:10 AM Feature #2673: support a kind of virtual desktop in the GUI web client
Sergey Ivanovskiy wrote:
> Please review the committed rev 11337
What branch is this in?
Constantin Asofiei
08:55 AM Feature #2673: support a kind of virtual desktop in the GUI web client
Constantin: Please review. Greg Shah
12:07 PM Feature #3684: implement a web theme inspired by material design
The only remaining issue is the customization. For the moment the implementation is hardcoded, more like "this way yo... Ovidiu Maxiniuc
12:01 PM Feature #3684: implement a web theme inspired by material design
Ovidiu, is there anything left to do from the original goals of implementing the material theme, or can we close this... Eric Faulhaber
08:57 AM Feature #3684: implement a web theme inspired by material design
> but it seems the task bar style and its buttons style can be changed to flat with new background and foreground col... Greg Shah
04:32 AM Feature #3684: implement a web theme inspired by material design
Greg Shah wrote:
> Can you show what you mean using a screen capture from Hotel GUI? What specifically needs to be ...
Sergey Ivanovskiy
11:13 AM Feature #3269 (Closed): implement optional enhanced mode for ABL GUI which supports dynamic layout
It seems the core implementation is done. We can address defects and enhancements in separate tasks. Eric Faulhaber

10/04/2018

06:17 PM Feature #2673: support a kind of virtual desktop in the GUI web client
Please review the committed rev 11337 that added UI Theme drop down for the web client. The UI themes are given by @a... Sergey Ivanovskiy
05:04 PM Feature #2673: support a kind of virtual desktop in the GUI web client
Sergey Ivanovskiy wrote:
> Don't understand. Now the options are verified against security context. Since this conte...
Constantin Asofiei
04:43 PM Feature #2673: support a kind of virtual desktop in the GUI web client
Constantin Asofiei wrote:
> Sergey, for reading the available themes from the directory, follow the @FontTable.readF...
Sergey Ivanovskiy
04:06 PM Feature #2673: support a kind of virtual desktop in the GUI web client
Sergey, for reading the available themes from the directory, follow the @FontTable.readFontTable@ approach; these sho... Constantin Asofiei
03:50 PM Feature #2673: support a kind of virtual desktop in the GUI web client
Greg, please could you advise to do in this case. @WebHandler.verifySpawnOptions@ is used for the trusted mode in thi... Sergey Ivanovskiy
12:20 PM Feature #2673: support a kind of virtual desktop in the GUI web client
I was trying to set theme via @"client:driver:theme"@... Sergey Ivanovskiy
01:07 PM Feature #3684: implement a web theme inspired by material design
Ovidiu Maxiniuc wrote:
> The problem occurs when there are both fixed and scrollable columns in a browse. The fixed ...
Ovidiu Maxiniuc

10/03/2018

01:18 PM Feature #3684: implement a web theme inspired by material design
The problem occurs when there are both fixed and scrollable columns in a browse. The fixed ones are drawn with a (+1,... Ovidiu Maxiniuc
08:38 AM Feature #3684: implement a web theme inspired by material design
Greg Shah wrote:
> Can you show what you mean using a screen capture from Hotel GUI? What specifically needs to be ...
Ovidiu Maxiniuc
08:35 AM Feature #3684: implement a web theme inspired by material design
Can you show what you mean using a screen capture from Hotel GUI? What specifically needs to be done and what do you... Greg Shah
03:35 AM Feature #3684: implement a web theme inspired by material design
It can be observed with the Material theme that the virtual desktop looks differently not according to the selected t... Sergey Ivanovskiy
12:19 PM Feature #2673: support a kind of virtual desktop in the GUI web client
I realized that it is done intentionally due to security restriction. If this code is invoked from @StandardServer@ d... Sergey Ivanovskiy
12:04 PM Feature #2673: support a kind of virtual desktop in the GUI web client
Do we really need a separate @theme@ directory class? This essentially is just a key/value mapping between strings. C... Eric Faulhaber
11:53 AM Feature #2673: support a kind of virtual desktop in the GUI web client
I defined this new class but @SecurityManager.getAccountIds()@ throws @NullPointerException@ ... Sergey Ivanovskiy
11:45 AM Feature #2673: support a kind of virtual desktop in the GUI web client
I think you need to define the @theme@ node type in @src/dir_schema.xml@.
Ovidiu Maxiniuc
11:40 AM Feature #2673: support a kind of virtual desktop in the GUI web client
I don't understand but this code returns null value for @nodePath1@... Sergey Ivanovskiy

10/02/2018

03:10 PM Feature #2673: support a kind of virtual desktop in the GUI web client
Planning to get all available themes from the directory. Sergey Ivanovskiy
03:07 PM Feature #2673: support a kind of virtual desktop in the GUI web client
I think the themes available to a user should come from a list in the directory, not from every available subclass of... Eric Faulhaber
03:03 PM Feature #2673: support a kind of virtual desktop in the GUI web client
OK, thank you. I found that there is @reflections-0.9.9-RC1.jar@ in the @build/lib@ but @build.gradle@ doesn't list t... Sergey Ivanovskiy
10:51 AM Feature #2673: support a kind of virtual desktop in the GUI web client
Sergey Ivanovskiy wrote:
> Please help to answer if there is a way to enumerate all supported themes. The supported ...
Ovidiu Maxiniuc
09:12 AM Feature #2673: support a kind of virtual desktop in the GUI web client
Please help to answer if there is a way to enumerate all supported themes. The supported themes can be made hard code... Sergey Ivanovskiy

10/01/2018

02:41 PM Feature #3684: implement a web theme inspired by material design
Sergey Ivanovskiy wrote:
> Ovidiu, please review the committed 11324. It seems that the root cause was that the web ...
Ovidiu Maxiniuc
08:00 PM Feature #3684: implement a web theme inspired by material design
Ovidiu, please review the committed 11324. It seems that the root cause was that the web client was waiting for the p... Sergey Ivanovskiy

09/24/2018

04:44 AM Feature #3684: implement a web theme inspired by material design
Eric Faulhaber wrote:
> Ovidiu, the material theme looks really great. Nice job! I have a few questions and a sugges...
Ovidiu Maxiniuc

09/22/2018

11:34 PM Feature #3684: implement a web theme inspired by material design
I also just noticed that the I-beam cursor seems to get lost when tabbing between fill-ins. The highlight/underline o... Eric Faulhaber
11:20 PM Feature #3684: implement a web theme inspired by material design
Ovidiu, the material theme looks really great. Nice job! I have a few questions and a suggested change:
* How easy...
Eric Faulhaber

09/21/2018

02:14 PM Feature #2673: support a kind of virtual desktop in the GUI web client
We have SET_DESKTOP_BGCOLOR drawing primitive that is used to set background colors in the embedded mode client with ... Sergey Ivanovskiy
12:27 PM Feature #2673 (WIP): support a kind of virtual desktop in the GUI web client
Sergey, please work on the following:
* We should provide wallpaper support. We can allow a scaled or cropped imag...
Greg Shah
12:16 PM Feature #2673: support a kind of virtual desktop in the GUI web client
This issue is fixed. Sergey Ivanovskiy
12:15 PM Feature #2673: support a kind of virtual desktop in the GUI web client
Yes, the web client updates the desktop size using this message @MSG_GET_DESKTOP_DIMENSION@. I looked at p2j.socket.j... Sergey Ivanovskiy
12:04 PM Feature #2673: support a kind of virtual desktop in the GUI web client
> The web page already is a kind of desktop or screen. We define that "screen size" in GuiWebDriver, defaulting it to... Greg Shah
12:32 PM Feature #3684: implement a web theme inspired by material design
I will work on this issue as a part of #2673. Sergey Ivanovskiy
10:14 AM Feature #3684: implement a web theme inspired by material design
Sergey: Can you please look at this web client palette message issue? Greg Shah
12:23 PM Feature #2676 (Closed): implement the equivalent to configurable support for a windows theme
Greg Shah
09:06 AM Bug #3723: Pressing ESC key twice doesn't allow the web client to log out properly
Found that if we executed a simple GUI program in the web client and press ESC key, then "Procedure complete ..." sta... Sergey Ivanovskiy
09:03 AM Bug #3723 (New): Pressing ESC key twice doesn't allow the web client to log out properly
Sergey Ivanovskiy

09/19/2018

12:24 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
I've added "rework of the Save Changes processing and directory approach for layout/UI customization as described in ... Greg Shah
12:12 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
> I think this approach is workable. Does anyone have any questions, comments or concerns?
I like it. I don't lik...
Stanislav Lomany
11:05 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
I think the current approach for storing/reading/saving layout and UI settings cannot be used in a production environ... Greg Shah

09/16/2018

04:34 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
Sorting and filtering should be allowed to be combined. This would certainly be the expectation of the user.
> sh...
Greg Shah

09/15/2018

07:18 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...
UX question. Consider a browse has both enhanced sorting and filtering enabled. How should it behave if user tries to... Stanislav Lomany

09/13/2018

02:02 PM Feature #3684: implement a web theme inspired by material design
I merged the 3684a branch into 3600e. Please let me know your opinions on how it looks.
As usual, to have the Theme...
Ovidiu Maxiniuc
 

Also available in: Atom