FWD » Core Development » User Interface

10/08/2018

07:12 PM Feature #2673: support a kind of virtual desktop in the GUI web client

Committed revision 11303 added @background-color@ setting for the virtual desktop. Sergey Ivanovskiy

06:36 PM Feature #2673: support a kind of virtual desktop in the GUI web client

Constantin, please change position if it looks better. It is my subjective judgement that it looks properly with the ... Sergey Ivanovskiy

06:25 PM Feature #2673: support a kind of virtual desktop in the GUI web client

Sergey Ivanovskiy wrote:
> Committed revision 11302 (3706a) has minor fix for @background-color@ and committed rev 1... Constantin Asofiei

06:14 PM Feature #2673: support a kind of virtual desktop in the GUI web client

Committed revision 11302 (3706a) has minor fix for @background-color@ and committed rev 178 (Hotel GUI) changed @dire... Sergey Ivanovskiy

05:31 PM Feature #2673: support a kind of virtual desktop in the GUI web client

Committed revision 11300 (3706a) should fix NPE by doing conditional static initializations for the virtual desktop m... Sergey Ivanovskiy

04:47 PM Feature #2673: support a kind of virtual desktop in the GUI web client

Fixing this NPE now and planning to change @background-size@ to @auto@ can help to preserve the original image. Sergey Ivanovskiy

04:40 PM Feature #2673: support a kind of virtual desktop in the GUI web client

Sergey Ivanovskiy wrote:
> Don't understand, please clarify your question. The @web_client.html@ template has been f... Greg Shah

04:34 PM Feature #2673: support a kind of virtual desktop in the GUI web client

Sergey, when starting a standalone server for Hotel GUI embedded mode (ran from /embedded/ folder), I get this error:... Constantin Asofiei

04:25 PM Feature #2673: support a kind of virtual desktop in the GUI web client

Don't understand, please clarify your question. The @web_client.html@ template has been filled by @WebHandler@ on @GE... Sergey Ivanovskiy

04:15 PM Feature #2673: support a kind of virtual desktop in the GUI web client

If we can't serve the resources, how does this work? Greg Shah

01:34 PM Feature #2673: support a kind of virtual desktop in the GUI web client

It seems that @web_client.html@ can be decorated for an example using the existing Bootsrap styles. In order to do th... Sergey Ivanovskiy

12:30 PM Feature #2673: support a kind of virtual desktop in the GUI web client

Committed revision 177 (Hotel_GUI) added @available-themes@ and @background-image@ style settings. Sergey Ivanovskiy

12:18 PM Feature #2673: support a kind of virtual desktop in the GUI web client

Yes. Greg Shah

12:03 PM Feature #2673: support a kind of virtual desktop in the GUI web client

Greg, would you like to use the same desktop image for web_client.html as for index.html?
Sergey Ivanovskiy

11:59 AM Feature #2673: support a kind of virtual desktop in the GUI web client

> Greg, do we need this now?
If it is easily possible, then yes please do it. Greg Shah

11:40 AM Feature #2673: support a kind of virtual desktop in the GUI web client

OK. Please wait. Sergey Ivanovskiy

11:34 AM Feature #2673: support a kind of virtual desktop in the GUI web client

Sergey, please update the Hotel GUI project with all directory settings required for the background image (@directory... Constantin Asofiei

11:22 AM Feature #2673: support a kind of virtual desktop in the GUI web client

Sergey Ivanovskiy wrote:
> Constantin Asofiei wrote:
> > Sergey Ivanovskiy wrote:
> > > Constantin, it seems that ... Constantin Asofiei

11:21 AM Feature #2673: support a kind of virtual desktop in the GUI web client

Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > Constantin, it seems that @web_client.html@ template is fo... Sergey Ivanovskiy

11:17 AM Feature #2673: support a kind of virtual desktop in the GUI web client

Sergey Ivanovskiy wrote:
> Constantin, it seems that @web_client.html@ template is for login page
Did you add suppo... Constantin Asofiei

11:14 AM Feature #2673: support a kind of virtual desktop in the GUI web client

OK. This task is done. It seems that if the FWD had @SET-DESKTOP-IMAGE url.@ statement, then adding MSG_SET_DESKTOP_I... Sergey Ivanovskiy

11:11 AM Feature #2673: support a kind of virtual desktop in the GUI web client

Please make sure that Hotel GUI has a functional solution today. We intend to show this at the PUG Challenge. Greg Shah

11:07 AM Feature #2673: support a kind of virtual desktop in the GUI web client

Constantin, it seems that @web_client.html@ template is for login page but the JS web client uses @index.html@ template. Sergey Ivanovskiy

11:03 AM Feature #2673: support a kind of virtual desktop in the GUI web client

I meant that the background images should be managed by the web client web server and should be delivered via https. ... Sergey Ivanovskiy

10:58 AM Feature #2673: support a kind of virtual desktop in the GUI web client

Eventually, you can set the @body@ image at login, and after login, move this image as background for our virtual des... Constantin Asofiei

10:57 AM Feature #2673: support a kind of virtual desktop in the GUI web client

Sergey Ivanovskiy wrote:
> It seems now to me that this solution is not good, because we should add the desktop imag... Constantin Asofiei

10:45 AM Feature #2673: support a kind of virtual desktop in the GUI web client

It seems now to me that this solution is not good, because we should add the desktop image support to @index.html@ te... Sergey Ivanovskiy

10:15 AM Feature #2673: support a kind of virtual desktop in the GUI web client

Greg Shah wrote:
> Do you have settings we can use with Hotel GUI to add the FWD logo and improve the attractiveness... Sergey Ivanovskiy

10:01 AM Feature #2673: support a kind of virtual desktop in the GUI web client

Found a copy paste error in the @p2j.socket.js@ and added empty styles validation. Please review committed rev.11296. Sergey Ivanovskiy

09:56 AM Feature #2673: support a kind of virtual desktop in the GUI web client

> but there is no mechanism to refresh the background image without restarting the server.
This is OK. Greg Shah

08:50 AM Feature #2673: support a kind of virtual desktop in the GUI web client

Greg Shah wrote:
> Do you have settings we can use with Hotel GUI to add the FWD logo and improve the attractiveness... Sergey Ivanovskiy

08:46 AM Feature #2673: support a kind of virtual desktop in the GUI web client

Greg Shah wrote:
> You described how incorrect settings were handled. What about missing settings?
No, missing set... Sergey Ivanovskiy

08:17 AM Feature #2673: support a kind of virtual desktop in the GUI web client

Do you have settings we can use with Hotel GUI to add the FWD logo and improve the attractiveness of the virtual desk... Greg Shah

08:16 AM Feature #2673: support a kind of virtual desktop in the GUI web client

You described how incorrect settings were handled. What about missing settings? Greg Shah

07:56 AM Feature #2673: support a kind of virtual desktop in the GUI web client

I tested if these settings are not configured. Incorrect settings can lead to CSS style errors.The java web client or... Sergey Ivanovskiy

05:45 AM Feature #2673: support a kind of virtual desktop in the GUI web client

Sergey Ivanovskiy wrote:
> Please review committed revision 11292 (3706a) that added desktop images for the virtual ... Constantin Asofiei

03:24 AM Feature #2673: support a kind of virtual desktop in the GUI web client

Committed revision 11294 fixed NPE if @background-image@ is not set.
Sergey Ivanovskiy

10/07/2018

05:48 PM Feature #2673: support a kind of virtual desktop in the GUI web client

Please review committed revision 11292 (3706a) that added desktop images for the virtual desktop mode. Sergey Ivanovskiy

04:44 PM Feature #2673: support a kind of virtual desktop in the GUI web client

I'm saying that your approach has security advantages. Greg Shah

03:51 PM Feature #2673: support a kind of virtual desktop in the GUI web client

I didn't add CSS parameters validation now but these parameters are secured by the directory. They can't be inserted ... Sergey Ivanovskiy

03:25 PM Feature #2673: support a kind of virtual desktop in the GUI web client

Constantin Asofiei wrote:
> Sergey, I don't think we want to encode each and every CSS property you want to set for ... Greg Shah

03:15 PM Feature #2673: support a kind of virtual desktop in the GUI web client

Sergey, I don't think we want to encode each and every CSS property you want to set for the image, as a distinct dire... Constantin Asofiei

02:53 PM Feature #2673: support a kind of virtual desktop in the GUI web client

I didn't invent these parameters they define the CSS background image styles:
https://developer.mozilla.org/en-US/do... Sergey Ivanovskiy

10/06/2018

12:45 PM Feature #2673: support a kind of virtual desktop in the GUI web client

I like it. Please post some details on the meaning of each one. Greg Shah

09:11 PM Feature #2673: support a kind of virtual desktop in the GUI web client

Planning to add new directory settings under @webClient/desktop@... Sergey Ivanovskiy

10/05/2018

03:28 PM Feature #2673: support a kind of virtual desktop in the GUI web client

Yes, agree. Sergey Ivanovskiy

03:26 PM Feature #2673: support a kind of virtual desktop in the GUI web client

Constantin Asofiei wrote:
> Actually, what @Theme.getName()@ is not really usable in a UX point of view: it returns ... Ovidiu Maxiniuc

01:48 PM Feature #2673: support a kind of virtual desktop in the GUI web client

Thanks for the thoughtful discourse of this task. Planning to follow it. Sergey Ivanovskiy

01:38 PM Feature #2673: support a kind of virtual desktop in the GUI web client

Sergey Ivanovskiy wrote:
> Agree that class annotations can be used for theme name, but in this case we will add new... Constantin Asofiei

01:27 PM Feature #2673: support a kind of virtual desktop in the GUI web client

The @Theme.getName()@ is practically not used. I added it for similar reasons. Currently the name is only displayed i... Ovidiu Maxiniuc

11:29 AM Feature #2673: support a kind of virtual desktop in the GUI web client

Agree that class annotations can be used for theme name, but in this case we will add new dependency. @Theme@ interfa... Sergey Ivanovskiy

11:17 AM Feature #2673: support a kind of virtual desktop in the GUI web client

Sergey Ivanovskiy wrote:
> > Hmm... ideally we wouldn't need to instantiate the theme to get its name. An annotatio... Constantin Asofiei

11:13 AM Feature #2673: support a kind of virtual desktop in the GUI web client

Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > > * why is the @OutputManager.instance()@ change required ... Sergey Ivanovskiy

11:09 AM Feature #2673: support a kind of virtual desktop in the GUI web client

Sergey Ivanovskiy wrote:
> > * why is the @OutputManager.instance()@ change required for this task? Is this trying t... Constantin Asofiei

11:01 AM Feature #2673: support a kind of virtual desktop in the GUI web client

Constantin Asofiei wrote:
> Review for 3600e rev 11337 (now in trunk 11286):
> * @WebHandler.doPost@ - you need to ... Sergey Ivanovskiy

10:40 AM Feature #2673: support a kind of virtual desktop in the GUI web client

Review for 3600e rev 11337 (now in trunk 11286):
* @WebHandler.doPost@ - you need to validate @base.getParameter("th... Constantin Asofiei

10:25 AM Feature #2673: support a kind of virtual desktop in the GUI web client

This code rev 11337 from 3600e is in the trunc rev 11286 already. The rest independent part of my task is to set the ... Sergey Ivanovskiy

10:10 AM Feature #2673: support a kind of virtual desktop in the GUI web client

Sergey Ivanovskiy wrote:
> Please review the committed rev 11337
What branch is this in? Constantin Asofiei

08:55 AM Feature #2673: support a kind of virtual desktop in the GUI web client

Constantin: Please review. Greg Shah

12:07 PM Feature #3684: implement a web theme inspired by material design

The only remaining issue is the customization. For the moment the implementation is hardcoded, more like "this way yo... Ovidiu Maxiniuc

12:01 PM Feature #3684: implement a web theme inspired by material design

Ovidiu, is there anything left to do from the original goals of implementing the material theme, or can we close this... Eric Faulhaber

08:57 AM Feature #3684: implement a web theme inspired by material design

> but it seems the task bar style and its buttons style can be changed to flat with new background and foreground col... Greg Shah

04:32 AM Feature #3684: implement a web theme inspired by material design

Greg Shah wrote:
> Can you show what you mean using a screen capture from Hotel GUI? What specifically needs to be ... Sergey Ivanovskiy

11:13 AM Feature #3269 (Closed): implement optional enhanced mode for ABL GUI which supports dynamic layout

It seems the core implementation is done. We can address defects and enhancements in separate tasks. Eric Faulhaber

10/04/2018

06:17 PM Feature #2673: support a kind of virtual desktop in the GUI web client

Please review the committed rev 11337 that added UI Theme drop down for the web client. The UI themes are given by @a... Sergey Ivanovskiy

05:04 PM Feature #2673: support a kind of virtual desktop in the GUI web client

Sergey Ivanovskiy wrote:
> Don't understand. Now the options are verified against security context. Since this conte... Constantin Asofiei

04:43 PM Feature #2673: support a kind of virtual desktop in the GUI web client

Constantin Asofiei wrote:
> Sergey, for reading the available themes from the directory, follow the @FontTable.readF... Sergey Ivanovskiy

04:06 PM Feature #2673: support a kind of virtual desktop in the GUI web client

Sergey, for reading the available themes from the directory, follow the @FontTable.readFontTable@ approach; these sho... Constantin Asofiei

03:50 PM Feature #2673: support a kind of virtual desktop in the GUI web client

Greg, please could you advise to do in this case. @WebHandler.verifySpawnOptions@ is used for the trusted mode in thi... Sergey Ivanovskiy

12:20 PM Feature #2673: support a kind of virtual desktop in the GUI web client

I was trying to set theme via @"client:driver:theme"@... Sergey Ivanovskiy

01:07 PM Feature #3684: implement a web theme inspired by material design

Ovidiu Maxiniuc wrote:
> The problem occurs when there are both fixed and scrollable columns in a browse. The fixed ... Ovidiu Maxiniuc

10/03/2018

01:18 PM Feature #3684: implement a web theme inspired by material design

The problem occurs when there are both fixed and scrollable columns in a browse. The fixed ones are drawn with a (+1,... Ovidiu Maxiniuc

08:38 AM Feature #3684: implement a web theme inspired by material design

Greg Shah wrote:
> Can you show what you mean using a screen capture from Hotel GUI? What specifically needs to be ... Ovidiu Maxiniuc

08:35 AM Feature #3684: implement a web theme inspired by material design

Can you show what you mean using a screen capture from Hotel GUI? What specifically needs to be done and what do you... Greg Shah

03:35 AM Feature #3684: implement a web theme inspired by material design

It can be observed with the Material theme that the virtual desktop looks differently not according to the selected t... Sergey Ivanovskiy

12:19 PM Feature #2673: support a kind of virtual desktop in the GUI web client

I realized that it is done intentionally due to security restriction. If this code is invoked from @StandardServer@ d... Sergey Ivanovskiy

12:04 PM Feature #2673: support a kind of virtual desktop in the GUI web client

Do we really need a separate @theme@ directory class? This essentially is just a key/value mapping between strings. C... Eric Faulhaber

11:53 AM Feature #2673: support a kind of virtual desktop in the GUI web client

I defined this new class but @SecurityManager.getAccountIds()@ throws @NullPointerException@ ... Sergey Ivanovskiy

11:45 AM Feature #2673: support a kind of virtual desktop in the GUI web client

I think you need to define the @theme@ node type in @src/dir_schema.xml@.
Ovidiu Maxiniuc

11:40 AM Feature #2673: support a kind of virtual desktop in the GUI web client

I don't understand but this code returns null value for @nodePath1@... Sergey Ivanovskiy

10/02/2018

03:10 PM Feature #2673: support a kind of virtual desktop in the GUI web client

Planning to get all available themes from the directory. Sergey Ivanovskiy

03:07 PM Feature #2673: support a kind of virtual desktop in the GUI web client

I think the themes available to a user should come from a list in the directory, not from every available subclass of... Eric Faulhaber

03:03 PM Feature #2673: support a kind of virtual desktop in the GUI web client

OK, thank you. I found that there is @reflections-0.9.9-RC1.jar@ in the @build/lib@ but @build.gradle@ doesn't list t... Sergey Ivanovskiy

10:51 AM Feature #2673: support a kind of virtual desktop in the GUI web client

Sergey Ivanovskiy wrote:
> Please help to answer if there is a way to enumerate all supported themes. The supported ... Ovidiu Maxiniuc

09:12 AM Feature #2673: support a kind of virtual desktop in the GUI web client

Please help to answer if there is a way to enumerate all supported themes. The supported themes can be made hard code... Sergey Ivanovskiy

10/01/2018

02:41 PM Feature #3684: implement a web theme inspired by material design

Sergey Ivanovskiy wrote:
> Ovidiu, please review the committed 11324. It seems that the root cause was that the web ... Ovidiu Maxiniuc

08:00 PM Feature #3684: implement a web theme inspired by material design

Ovidiu, please review the committed 11324. It seems that the root cause was that the web client was waiting for the p... Sergey Ivanovskiy

09/24/2018

04:44 AM Feature #3684: implement a web theme inspired by material design

Eric Faulhaber wrote:
> Ovidiu, the material theme looks really great. Nice job! I have a few questions and a sugges... Ovidiu Maxiniuc

09/22/2018

11:34 PM Feature #3684: implement a web theme inspired by material design

I also just noticed that the I-beam cursor seems to get lost when tabbing between fill-ins. The highlight/underline o... Eric Faulhaber

11:20 PM Feature #3684: implement a web theme inspired by material design

Ovidiu, the material theme looks really great. Nice job! I have a few questions and a suggested change:
* How easy... Eric Faulhaber

09/21/2018

02:14 PM Feature #2673: support a kind of virtual desktop in the GUI web client

We have SET_DESKTOP_BGCOLOR drawing primitive that is used to set background colors in the embedded mode client with ... Sergey Ivanovskiy

12:27 PM Feature #2673 (WIP): support a kind of virtual desktop in the GUI web client

Sergey, please work on the following:
* We should provide wallpaper support. We can allow a scaled or cropped imag... Greg Shah

12:16 PM Feature #2673: support a kind of virtual desktop in the GUI web client

This issue is fixed. Sergey Ivanovskiy

12:15 PM Feature #2673: support a kind of virtual desktop in the GUI web client

Yes, the web client updates the desktop size using this message @MSG_GET_DESKTOP_DIMENSION@. I looked at p2j.socket.j... Sergey Ivanovskiy

12:04 PM Feature #2673: support a kind of virtual desktop in the GUI web client

> The web page already is a kind of desktop or screen. We define that "screen size" in GuiWebDriver, defaulting it to... Greg Shah

12:32 PM Feature #3684: implement a web theme inspired by material design

I will work on this issue as a part of #2673. Sergey Ivanovskiy

10:14 AM Feature #3684: implement a web theme inspired by material design

Sergey: Can you please look at this web client palette message issue? Greg Shah

12:23 PM Feature #2676 (Closed): implement the equivalent to configurable support for a windows theme

Greg Shah

09:06 AM Bug #3723: Pressing ESC key twice doesn't allow the web client to log out properly

Found that if we executed a simple GUI program in the web client and press ESC key, then "Procedure complete ..." sta... Sergey Ivanovskiy

09:03 AM Bug #3723 (New): Pressing ESC key twice doesn't allow the web client to log out properly

Sergey Ivanovskiy

09/19/2018

12:24 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...

I've added "rework of the Save Changes processing and directory approach for layout/UI customization as described in ... Greg Shah

12:12 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...

> I think this approach is workable. Does anyone have any questions, comments or concerns?
I like it. I don't lik... Stanislav Lomany

11:05 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...

I think the current approach for storing/reading/saving layout and UI settings cannot be used in a production environ... Greg Shah

09/16/2018

04:34 PM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...

Sorting and filtering should be allowed to be combined. This would certainly be the expectation of the user.
> sh... Greg Shah

09/15/2018

07:18 AM Feature #3261: enhanced browse that can optionally selected as a replacement for the default ABL ...

UX question. Consider a browse has both enhanced sorting and filtering enabled. How should it behave if user tries to... Stanislav Lomany

09/13/2018

02:02 PM Feature #3684: implement a web theme inspired by material design

I merged the 3684a branch into 3600e. Please let me know your opinions on how it looks.
As usual, to have the Theme... Ovidiu Maxiniuc