FWD » Core Development » User Interface

08/24/2023

09:30 AM Feature #3931: single sign-on for virtual desktop mode

Ah, this makes sense. Up in r14683. Galya B

09:28 AM Feature #3931: single sign-on for virtual desktop mode

I was thinking of a default method in the interface. Greg Shah

09:15 AM Feature #3931: single sign-on for virtual desktop mode

Also the hotel gui SsoAuthenticator implementation (I still haven't uploaded) returns null. Galya B

09:14 AM Feature #3931: single sign-on for virtual desktop mode

Greg Shah wrote:
> > To enable auto-login they need to implement two methods of the @SsoAuthenticator@: @getAuthCook... Galya B

09:12 AM Feature #3931: single sign-on for virtual desktop mode

Galya B wrote:
> Greg Shah wrote:
> > > With allowing auto-login, as I've said in the past, new clients will be way... Greg Shah

09:11 AM Feature #3931: single sign-on for virtual desktop mode

Greg Shah wrote:
> > With allowing auto-login, as I've said in the past, new clients will be way easier to get spawn... Galya B

09:07 AM Feature #3931: single sign-on for virtual desktop mode

> The abuser is someone with valid username and password, so it's very much in the hands of the customers to keep tha... Greg Shah

08:59 AM Feature #3931: single sign-on for virtual desktop mode

I get:... Galya B

07:42 AM Feature #3931: single sign-on for virtual desktop mode

We can further expand the args passed in to the @SsoAuthenticator@ to allow licensing management, but that with next ... Galya B

07:40 AM Feature #3931: single sign-on for virtual desktop mode

I was thinking how to protect better the expensive resource of spawning a new web client process. And I was thinking ... Galya B

08/23/2023

01:11 PM Bug #7742 (WIP): NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application

Hynek Cihlar

01:11 PM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application

Vladimir Tsichevski wrote:
> Hynek Cihlar wrote:
> > Vladimir Tsichevski wrote:
> > > I see no differences.
> > >... Hynek Cihlar

01:05 PM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application

Hynek Cihlar wrote:
> Vladimir Tsichevski wrote:
> > I see no differences.
> >
> > Also: after the @Escape@ was ... Vladimir Tsichevski

01:01 PM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application

Vladimir Tsichevski wrote:
> I see no differences.
>
> Also: after the @Escape@ was pressed, the new key press is... Hynek Cihlar

12:53 PM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application

Vladimir Tsichevski wrote:
> Hynek Cihlar wrote:
> > Vladimir Tsichevski wrote:
> > > Hynek Cihlar wrote:
> > > >... Vladimir Tsichevski

12:46 PM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application

Hynek Cihlar wrote:
> Vladimir Tsichevski wrote:
> > Hynek Cihlar wrote:
> > > Vladimir, please also retest.
> > ... Vladimir Tsichevski

12:43 PM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application

Vladimir Tsichevski wrote:
> Hynek Cihlar wrote:
> > Vladimir, please also retest.
>
> The NPE disappeared now, ... Hynek Cihlar

12:36 PM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application

Hynek Cihlar wrote:
> Vladimir, please also retest.
The NPE disappeared now, but it seems the code works incorrec... Vladimir Tsichevski

12:12 PM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application

I added missing code comments in 7742a revision 14708. Hynek Cihlar

11:52 AM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application

Greg Shah wrote:
> Are we sure we need to add a @null@ keyboard event to the queue?
>
> Tomasz: Have you encounte... Tomasz Domin

11:28 AM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application

Vladimir, please also retest. Hynek Cihlar

11:26 AM Bug #7742 (Review): NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application

Hynek Cihlar

11:25 AM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application

The issue is fixed in 7742a revision 14707. The problem only showed in Swing ChUI client. Please review. Hynek Cihlar

11:14 AM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application

Hynek Cihlar wrote:
> Greg Shah wrote:
> > Are we sure we need to add a @null@ keyboard event to the queue?
>
> ... Vladimir Tsichevski

10:32 AM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application

Greg Shah wrote:
> Are we sure we need to add a @null@ keyboard event to the queue?
Yes, it is used to signal a m... Hynek Cihlar

10:00 AM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application

Are we sure we need to add a @null@ keyboard event to the queue?
Tomasz: Have you encountered this issue in @<larg... Greg Shah

09:26 AM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application

ChUI Swing: when I press @Escape@, the client crashes with NPE here:... Vladimir Tsichevski

09:15 AM Bug #7742 (WIP): NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application

Vladimir Tsichevski

11:10 AM Feature #6438: frame attributes, methods and options

Rebased @6438b@ with recent trunk @14707@. New revision is @14708@.
Greg,
I have no plans to add new changes he... Eugenie Lyzenko

10:15 AM Feature #7709: ABLUnit support for web clients

Yes, it is a good point. There is a benefit to testing the spawning process itself.
On the other hand, spawning i... Greg Shah

08:56 AM Feature #3931: single sign-on for virtual desktop mode

Greg Shah wrote:
> > What I'm trying to say is the major flaw with launching before auth is fixed.
>
> Yes, I un... Galya B

08:50 AM Feature #3931: single sign-on for virtual desktop mode

> The question is if @auth-mode/ssoplugin@ is defined, but can't be instantiated (some typo in the package, class nam... Greg Shah

08:49 AM Feature #3931: single sign-on for virtual desktop mode

> What I'm trying to say is the major flaw with launching before auth is fixed.
Yes, I understand. My discussion... Greg Shah

08:18 AM Feature #3931: single sign-on for virtual desktop mode

A question about configs: currently if @auth-mode/ssoplugin@ is defined and can be instantiated, then SSO is enabled.... Galya B

07:24 AM Feature #3931: single sign-on for virtual desktop mode

But I think it's fine. "works without SSO" means it directly checks the user / pass against the DB, where the in-app ... Galya B

07:19 AM Feature #3931: single sign-on for virtual desktop mode

Greg Shah wrote:
> To be clear: in #3770-81 I noted that our current login approach with embedded mode does need ser... Galya B

07:16 AM Feature #3931: single sign-on for virtual desktop mode

The hotel gui js and the embedded driver js (intertwined with it) are very particular. I'm sure we don't have a guide... Galya B

07:16 AM Feature #3931: single sign-on for virtual desktop mode

To be clear: in #3770-81 I noted that our current login approach with embedded mode does need serious changes. Spawn... Greg Shah

07:09 AM Feature #3931: single sign-on for virtual desktop mode

Galya: Along with other objectives, Hotel GUI is intended to be an example of how to implement Embedded Mode for a GU... Greg Shah

04:51 AM Feature #3931: single sign-on for virtual desktop mode

So @setuserid@ does DB auth, which is a valid approach. I haven't uploaded anything to hotel_gui, but there are certa... Galya B

08/22/2023

12:30 PM Bug #7515: FILL-IN: editing dates issues

All fixes were tested for the following date formats: @9999/99/99@, @99/99/99@, @99999999@, @999999@.
The component ... Vladimir Tsichevski

12:28 PM Bug #7515: FILL-IN: editing dates issues

The 7019a revision 14691 contains the following fixes:
# #7515-1 bullet 1: missing feature implemented
# #7515-1 ... Vladimir Tsichevski

09:18 AM Bug #7515: FILL-IN: editing dates issues

Yet another issue: the empty screen value for the @99/99/99@ format must be @ / /@, in trunk it is @ / / @ (the ... Vladimir Tsichevski

11:03 AM Feature #6438: frame attributes, methods and options

Rebased @6438b@ with recent trunk @14706@. New revision is @14707@.
Guys,
Can I merge this into trunk? Eugenie Lyzenko

10:50 AM Feature #3931: single sign-on for virtual desktop mode

Hotel gui works well in a parent frame with login form validated by @SsoAuthenticator@. Even the CORS error (a non-cr... Galya B

08:36 AM Feature #3931: single sign-on for virtual desktop mode

It works, it's just that the CORS error is actually present in the console and some DB configs are missing in directo... Galya B

07:27 AM Feature #3931: single sign-on for virtual desktop mode

Embedded mode with Hotel GUI rev 271 and FWD trunk rev 14703 works fine. Constantin Asofiei

05:50 AM Feature #3931: single sign-on for virtual desktop mode

Constantin, do you know if hotel_gui's embedded works? With latest trunk + latest hotel_gui I get a very weird behavi... Galya B

08/21/2023

07:23 PM Feature #6438 (Review): frame attributes, methods and options

The @6438b@ updated for review to revision @14704@.
Added basic support for @STREAM-IO@/@SCREEN-IO@ frame option. ... Eugenie Lyzenko

06:50 PM Feature #6438: frame attributes, methods and options

Created task branch @6438b@ from trunk revision @14703@. Eugenie Lyzenko

02:54 PM Feature #6438: frame attributes, methods and options

Constantin Asofiei wrote:
>
> About @GET-ITERATION@ - does this convert/compile properly in FWD?
> [...]
Yes i... Eugenie Lyzenko

02:39 PM Feature #6438: frame attributes, methods and options

Eugenie, the priority of these attributes is for ChUI, although if any missing GUI support can be added easily to be ... Constantin Asofiei

02:02 PM Feature #6438: frame attributes, methods and options

Go ahead with these changes.
Constantin: What do you think? Greg Shah

01:10 PM Feature #6438: frame attributes, methods and options

Greg Shah wrote:
> > The other thing to be happen is setting USE-TEXT frame option to true. But it is already implem... Eugenie Lyzenko

01:05 PM Feature #6438: frame attributes, methods and options

> The other thing to be happen is setting USE-TEXT frame option to true. But it is already implemented.
You mean t... Greg Shah

12:17 PM Feature #6438: frame attributes, methods and options

Greg Shah wrote:
> Is forcing the use of the fixed width font really the only thing that needs to happen to support ... Eugenie Lyzenko

12:05 PM Feature #6438: frame attributes, methods and options

Is forcing the use of the fixed width font really the only thing that needs to happen to support @STREAM-IO@? Greg Shah

08:47 AM Feature #7709: ABLUnit support for web clients

Greg Shah wrote:
> I was thinking that we already have a client process so we don't need to spawn. I'd prefer to av... Hynek Cihlar

08/19/2023

08:53 PM Feature #6438: frame attributes, methods and options

Further investigations shows the following:
1. Seems like the @SCROLL@ option is currently supported at runtime. At ... Eugenie Lyzenko

08/18/2023

12:33 PM Feature #6438: frame attributes, methods and options

Branch @6438a@ was merged to trunk as revno @14699@ then it was archived. Eugenie Lyzenko

12:22 PM Feature #6438: frame attributes, methods and options

Greg Shah wrote:
> Code Review Task Branch 6438a Revision 14700
>
> The change is fine. I've edited the comments... Eugenie Lyzenko

12:14 PM Feature #6438: frame attributes, methods and options

Code Review Task Branch 6438a Revision 14700
The change is fine. I've edited the comments and history in revision... Greg Shah

11:35 AM Feature #6438: frame attributes, methods and options

Greg Shah wrote:
> Code Review Task Branch 6438a Revision 14699
>
> Overall the changes are good. The only probl... Eugenie Lyzenko

10:51 AM Feature #6438: frame attributes, methods and options

> Also @GET-ITERATION()@ method for @Buffer@ object has only stub at runtime. I think we need to ask the persistence ... Greg Shah

10:50 AM Feature #6438: frame attributes, methods and options

Code Review Task Branch 6438a Revision 14699
Overall the changes are good. The only problem I see is with the imp... Greg Shah

09:13 AM Feature #6438: frame attributes, methods and options

The @6438a@ rebased with recent trunk @14698@. The new revision is @14699@. Eugenie Lyzenko

04:08 AM Feature #3931: single sign-on for virtual desktop mode

Embedded doesn't have a face, because it's supposed to be shaped by the customer, but can I summarize what it is with... Galya B

08/17/2023

07:56 PM Feature #6438 (WIP): frame attributes, methods and options

Eugenie Lyzenko

07:26 PM Feature #6438: frame attributes, methods and options

Also @GET-ITERATION()@ method for @Buffer@ object has only stub at runtime. I think we need to ask the persistence ex... Eugenie Lyzenko

05:12 PM Feature #6438: frame attributes, methods and options

The @6438a@ updated for review to revision @14697@.
This change adds conversion support and partial runtime suppor... Eugenie Lyzenko

11:47 AM Feature #6438: frame attributes, methods and options

Greg Shah wrote:
> * @STREAM-IO@ option
> * @SCROLL@ option
> * @NO-ATTR-SPACE@ option
All of these options to ... Eugenie Lyzenko

08:25 AM Feature #6438: frame attributes, methods and options

Created task branch @6438a@ from trunk revision @14696@. Eugenie Lyzenko

05:19 PM Bug #7515: FILL-IN: editing dates issues

Greg, I need help.
It seems, OE uses different methods for date validation and date conversion:
Both @3010124@ ... Vladimir Tsichevski

04:42 PM Bug #7515: FILL-IN: editing dates issues

The behavior of OE I cannot explain:
# I use the @99999999@ format, and @ymd@ component order.
# I use the followin... Vladimir Tsichevski

04:03 PM Bug #7515: FILL-IN: editing dates issues

Vladimir Tsichevski wrote:
> Vladimir Tsichevski wrote:
> > Another (anti?)issue: date validation for date format @... Vladimir Tsichevski

04:57 AM Feature #7709: ABLUnit support for web clients

> but what I've described can be achieved with Cypress: the go-to nowadays, very solid web UI testing framework with ... Greg Shah

04:54 AM Feature #7709: ABLUnit support for web clients

I was thinking that we already have a client process so we don't need to spawn. I'd prefer to avoid the spawning unl... Greg Shah

03:37 AM Feature #7709: ABLUnit support for web clients

Greg Shah wrote:
> * Rework the login/spawning approach to work from ABLUnit. [..]
> * We need to be able to launch... Galya B

08/16/2023

03:38 PM Feature #7709: ABLUnit support for web clients

Our UI tests being written in #6856 need to be executed in both Swing and the web client. Today, the architecture of... Greg Shah

03:33 PM Feature #7709 (New): ABLUnit support for web clients

Greg Shah

03:19 PM Bug #7515: FILL-IN: editing dates issues

Vladimir Tsichevski wrote:
> Another (anti?)issue: date validation for date format @99999999@:
>
> In OE, any scr... Vladimir Tsichevski

01:37 PM Bug #7515: FILL-IN: editing dates issues

Another (anti?)issue: date validation for date format @99999999@:
In OE, any screen value, which includes a space,... Vladimir Tsichevski

10:40 AM Bug #7515: FILL-IN: editing dates issues

Another issue to check: for the @99999999@ format, the screen values shall never be auto-completed.
Note: in trunk... Vladimir Tsichevski

10:01 AM Bug #7515: FILL-IN: editing dates issues

Another thing I do not understand in in @date.parseWorker(..)@:... Vladimir Tsichevski

09:53 AM Bug #7515: FILL-IN: editing dates issues

Vladimir Tsichevski wrote:
> Another issue: setting the date @FILL-IN@ screen value to @///1@ crashes the client wit... Vladimir Tsichevski

08:51 AM Bug #7515: FILL-IN: editing dates issues

Another issue: setting the date @FILL-IN@ screen value to @///1@ crashes the client with @NumberFormatException@:
... Vladimir Tsichevski

06:48 AM Feature #3931: single sign-on for virtual desktop mode

OK, I'll be digging deeper. Galya B

06:48 AM Feature #3931: single sign-on for virtual desktop mode

To be clear: I'm OK with reworking things now to achieve more common code and a consistent approach. Greg Shah

06:46 AM Feature #3931: single sign-on for virtual desktop mode

Yes, that makes sense. Greg Shah

06:41 AM Feature #3931: single sign-on for virtual desktop mode

I'm not sure how these two evolved and ended up being so different. I guess they can be unified further, but I'm not ... Galya B

06:27 AM Feature #3931: single sign-on for virtual desktop mode

Greg Shah wrote:
> The key point here is that the logins can be the same.
Embedded includes all the driver resour... Galya B

06:25 AM Feature #3931: single sign-on for virtual desktop mode

The key point here is that the logins can be the same. Greg Shah

06:25 AM Feature #3931: single sign-on for virtual desktop mode

This selector is a convenience only. It is not strictly needed in any mode, however it is just as useful in both mod... Greg Shah

06:23 AM Feature #3931: single sign-on for virtual desktop mode

Is the theme selector needed for embedded? Are there themes in embedded? Currently only virtual desktop sets the option. Galya B

05:45 AM Feature #3931: single sign-on for virtual desktop mode

> Do we want to support a default login page for embedded when the customer doesn't provide one? Currently we don't.
... Greg Shah

05:20 AM Feature #3931: single sign-on for virtual desktop mode

If there is no FWD login page it's the same as with the custom VD login - some features won't be available before sta... Galya B

04:37 AM Feature #3931: single sign-on for virtual desktop mode

Do we want to support a default login page for embedded when the customer doesn't provide one? Currently we don't. Galya B

08/15/2023

02:07 PM Bug #7515: FILL-IN: editing dates issues

*ISSUE* Another issue regarding @SESSION:DATE-FORMAT@ and existing date formats.
For all object types, compiled fo... Vladimir Tsichevski

12:52 PM Feature #3931: single sign-on for virtual desktop mode

These embedded resources are really confusing, but I think I start understanding what is going on.
The FWD server ... Galya B

11:45 AM Feature #3931: single sign-on for virtual desktop mode

Galya, the FWD analytics (which I assume you mean by 'report') is managed by @p2j/report/server/ReportWebServer@. Al... Constantin Asofiei

11:27 AM Feature #3931: single sign-on for virtual desktop mode

Constantin, can you tell if these handlers are actually used by any embedded index.html or only by report in @p2j/rep... Galya B

10:13 AM Feature #3931: single sign-on for virtual desktop mode

Greg Shah wrote:
> > The other way of spawning embedded needs some sort of authentication. Do we tackle this?
>
>... Galya B

09:18 AM Feature #3931: single sign-on for virtual desktop mode

In directory we have the following configs related to embedded:
* @embeddedWebApp/enabled@ (boolean) used in @Standa... Galya B

01:14 AM Bug #7674: FILL-IN for a character variable: cannot delete an unknown value

Vladimir Tsichevski wrote:
> The variable is first assigned the @?@ character value, then is unconditionally reset t... Hynek Cihlar

08/14/2023

05:07 PM Bug #7674: FILL-IN for a character variable: cannot delete an unknown value

Hynek Cihlar wrote:
> To me the change looks suspicious. The change addresses an issue, which is related to the @scr... Vladimir Tsichevski

04:51 PM Bug #7674: FILL-IN for a character variable: cannot delete an unknown value

To me the change looks suspicious. The change addresses an issue, which is related to the @screen-value@ use case. Bu... Hynek Cihlar

04:46 PM Bug #7515: FILL-IN: editing dates issues

A date validation issue: the year value @001-@ is raises error 85 in OE, but is successfully parsed into value @1@ in... Vladimir Tsichevski

03:09 PM Feature #3931: single sign-on for virtual desktop mode

> It's more secure, but more complicated. I can't think of a reason to remove it, since it's already there, but it ma... Greg Shah

12:07 PM Feature #3931: single sign-on for virtual desktop mode

The other way of spawning embedded needs some sort of authentication. Do we tackle this? Galya B

11:54 AM Feature #3931: single sign-on for virtual desktop mode

It's more secure, but more complicated. I can't think of a reason to remove it, since it's already there, but it may ... Galya B

11:47 AM Feature #3931: single sign-on for virtual desktop mode

> Do we support remote network interface for launching clients only for embedded? Currently it's enabled for any web ... Greg Shah

10:57 AM Feature #3931: single sign-on for virtual desktop mode

Do we support remote network interface for launching clients only for embedded? Currently it's enabled for any web cl... Galya B

01:55 PM Bug #7685: LEAVE/ENTRY events are raised before MOUSE-UP event.

See the attached testcase. You'll see wrong order of events.
As an initial discussion see #7048 entries 71 thru 74. Stanislav Lomany

01:43 PM Bug #7685 (New): LEAVE/ENTRY events are raised before MOUSE-UP event.

Stanislav Lomany

01:27 PM Bug #7684: ENTRY event is emitted twice

See the attached testcase. ENTRY event is raised twice for all (?) widgets. Stanislav Lomany

01:15 PM Bug #7684 (Closed): ENTRY event is emitted twice

Stanislav Lomany

08/11/2023

10:24 AM Bug #7674: FILL-IN for a character variable: cannot delete an unknown value

Greg Shah wrote:
> Eugenie/Hynek: Please review.
I have no objections. Eugenie Lyzenko

09:56 AM Bug #7674: FILL-IN for a character variable: cannot delete an unknown value

Eugenie/Hynek: Please review. Greg Shah

09:36 AM Bug #7674: FILL-IN for a character variable: cannot delete an unknown value

Greg Shah wrote:
> Is this task related to an existing customer bug? If so, please link them.
This issue prevent... Vladimir Tsichevski

09:27 AM Bug #7674: FILL-IN for a character variable: cannot delete an unknown value

Is this task related to an existing customer bug? If so, please link them. Greg Shah

06:46 AM Bug #7674 (Review): FILL-IN for a character variable: cannot delete an unknown value

Please, review the fix. Vladimir Tsichevski

06:44 AM Bug #7674 (WIP): FILL-IN for a character variable: cannot delete an unknown value

The fix: set the @unknownValueDisplayed@ value in the @StringFormat.CharBuf@ constructor in case an unknown variable ... Vladimir Tsichevski

09:27 AM Feature #3931: single sign-on for virtual desktop mode

Galya B wrote:
> Greg Shah wrote:
> > By #30 do you mean #3931-30?
>
> Nope, #30. This was mentioned by Constant... Greg Shah

07:46 AM Feature #3931: single sign-on for virtual desktop mode

Greg Shah wrote:
> By #30 do you mean #3931-30?
Nope, #30. This was mentioned by Constantin in response to my ema... Galya B

07:44 AM Feature #3931: single sign-on for virtual desktop mode

By #30 do you mean #3931-30? Greg Shah

07:20 AM Feature #3931: single sign-on for virtual desktop mode

I think #30 can be resolved with #3931. If the customer wants to prevent this type of DOS, they can replace their 4GL... Galya B

08/10/2023

06:42 PM Bug #7674: FILL-IN for a character variable: cannot delete an unknown value

The boolean @StringFormat:unknownValueDisplayed@ field should handle the situation then no screen buffer is allocated... Vladimir Tsichevski

06:31 PM Bug #7674: FILL-IN for a character variable: cannot delete an unknown value

@FILL-IN@ for a character variable: if the @screen-value@ is set to an unknown value, the screen value is replaced by... Vladimir Tsichevski

06:28 PM Bug #7674 (WIP): FILL-IN for a character variable: cannot delete an unknown value

Vladimir Tsichevski

03:45 PM Bug #7673: FILL-IN for a character variable: pressing Shift+Delete inserts a dot

@FILL-IN@ for a character variable: pressing @Shift+Delete@ inserts a dot character. In OE this key combination perfo... Vladimir Tsichevski

03:43 PM Bug #7673 (New): FILL-IN for a character variable: pressing Shift+Delete inserts a dot

Vladimir Tsichevski

08:05 AM Bug #7671: View statement does not work on o not visible frame

Consider the following scenario, you have a @main-frame@, inside this there is @secondary-frame@ that has @button1@ a... Eduard Soltan

07:54 AM Bug #7671 (New): View statement does not work on o not visible frame

Eduard Soltan

08/09/2023

05:47 PM Bug #7515: FILL-IN: editing dates issues

Yet another issue:
# set @SESSION:DATE-FORMAT = "ymd".@
# create an editor for a date variable with the @9999/99/... Vladimir Tsichevski

08/08/2023

07:35 AM Feature #3931: single sign-on for virtual desktop mode

OS passwords can't be stored in directory.xml the same way as FWD user passwords. FWD passwords are encrypted with SH... Galya B

08/04/2023

09:18 AM Feature #3931: single sign-on for virtual desktop mode

Greg Shah wrote:
> The fact that you are in a context now and spawn another context is what I am calling "forking". ... Galya B

09:06 AM Feature #3931: single sign-on for virtual desktop mode

Greg Shah wrote:
> > > That is why we have a complex pipe approach used to deliver the password to the spawner, beca... Galya B

09:02 AM Feature #3931: single sign-on for virtual desktop mode

> > That is why we have a complex pipe approach used to deliver the password to the spawner, because pipes are privat... Greg Shah

09:00 AM Feature #3931: single sign-on for virtual desktop mode

Greg Shah wrote:
> The more conditions we add, the more we have to think about how we use it and the more likely a r... Galya B

08:53 AM Feature #3931: single sign-on for virtual desktop mode

Greg Shah wrote:
> In regard to the proposed UI changes, I think 1 and 3 are good to go. For 2, I would prefer if i... Galya B

08:52 AM Feature #3931: single sign-on for virtual desktop mode

Greg Shah wrote:
> That is why we have a complex pipe approach used to deliver the password to the spawner, because ... Galya B

08:48 AM Feature #3931: single sign-on for virtual desktop mode

In regard to the proposed UI changes, I think 1 and 3 are good to go. For 2, I would prefer if it is more obvious th... Greg Shah

08:47 AM Feature #3931: single sign-on for virtual desktop mode

Greg Shah wrote:
> > > The current use of @trustedspawner@ is a kind of "forking" because it enables spawning from a... Galya B

08:43 AM Feature #3931: single sign-on for virtual desktop mode

> The default os user password will have to be stored as env var, it can't be entered as plain text in @webClient@ co... Greg Shah

08:41 AM Feature #3931: single sign-on for virtual desktop mode

> > > @remotelaunchoption@ checks to be executed only for remote spawns (using @WebClientLauncher@ network interface)... Greg Shah

05:19 AM Feature #3931: single sign-on for virtual desktop mode

The default os user password will have to be stored as env var, it can't be entered as plain text in @webClient@ conf... Galya B

04:15 AM Feature #3931: single sign-on for virtual desktop mode

Here are the mockups for the Admin UI: 1. OS users (new page) 2. OS user password update (new dialog), 3. FWD user ed... Galya B

01:29 AM Feature #3931: single sign-on for virtual desktop mode

Greg Shah wrote:
> The current use of @trustedspawner@ is a kind of "forking" because it enables spawning from an ex... Galya B

01:12 AM Feature #3931: single sign-on for virtual desktop mode

Greg Shah wrote:
> > @remotelaunchoption@ checks to be executed only for remote spawns (using @WebClientLauncher@ ne... Galya B

08/03/2023

04:05 PM Feature #3931: single sign-on for virtual desktop mode

Galya B wrote:
> Greg Shah wrote:
> > > > > RPC WebClientLauncher.spawn with SSO
> > What you are proposing is not... Greg Shah

04:02 PM Feature #3931: single sign-on for virtual desktop mode

> @remotelaunchoption@ checks to be executed only for remote spawns (using @WebClientLauncher@ network interface). Ot... Greg Shah

03:50 PM Feature #3931: single sign-on for virtual desktop mode

> 1. @ssopluginoption@ is enough to support a default fwd user.
This is what I suggested previously, so I tend to ... Greg Shah

10:21 AM Feature #3931: single sign-on for virtual desktop mode

Can you share client configs for @<security>@ and @<access>@ for a broker running against testcases server? Galya B

01:43 AM Feature #3931: single sign-on for virtual desktop mode

Greg Shah wrote:
> > > > RPC WebClientLauncher.spawn with SSO
> What you are proposing is not clear to me. I espec... Galya B

01:38 AM Feature #3931: single sign-on for virtual desktop mode

I need confirmation that:
1. @ssopluginoption@ is enough to support a default fwd user.
2. @webClient/defaultAccoun... Galya B

12:18 PM Bug #7657: 8-bit character entry problem in ChUI

As reported by one of our customers:
> I did notice one other thing. It occurs both in the Hotel sample app as wel... Greg Shah

12:18 PM Bug #7657 (Review): 8-bit character entry problem in ChUI

Greg Shah

08/02/2023

01:48 PM Feature #3931: single sign-on for virtual desktop mode

> > > RPC WebClientLauncher.spawn with SSO
> >
> > This still needs to be discussed. We have a customer that orig... Greg Shah

01:41 PM Feature #3931: single sign-on for virtual desktop mode

> The @BrokerServerServices@ acl/net config described [[p2j:Remote_Launchers|here]] seems outdated. Does it need to b... Greg Shah

09:55 AM Feature #3931: single sign-on for virtual desktop mode

Greg Shah wrote:
> > RPC WebClientLauncher.spawn with SSO
>
> This still needs to be discussed. We have a custom... Galya B

09:31 AM Feature #3931: single sign-on for virtual desktop mode

Galya B wrote:
> Do we feed the default user explicitly?
Actually my bad, it's already done in the latest revision ... Galya B

09:23 AM Feature #3931: single sign-on for virtual desktop mode

And here is my conclusion on the other topic:
* @remotelaunchoption@ checks to be executed only for remote spawns (u... Galya B

09:01 AM Feature #3931: single sign-on for virtual desktop mode

Constantin Asofiei wrote:
> I don't think we should allow FWD to determine a default is required - the SSO authentic... Galya B

08:57 AM Feature #3931: single sign-on for virtual desktop mode

Galya B wrote:
> Greg Shah wrote:
> > I think the answer here is to provide a facility for the authenticator to get... Constantin Asofiei

08:55 AM Feature #3931: single sign-on for virtual desktop mode

Greg Shah wrote:
> I think the answer here is to provide a facility for the authenticator to get some configuration ... Galya B

08:47 AM Feature #3931: single sign-on for virtual desktop mode

> 1. Do you want a configurable FWD user for when SSO Authenticator (customer) doesn't know what it wants for securit... Greg Shah

08:39 AM Feature #3931: single sign-on for virtual desktop mode

Greg Shah wrote:
> I would not expect there to be a default os user that is not specified in the directory, but I do... Galya B

08:38 AM Feature #3931: single sign-on for virtual desktop mode

> @GuestAccess@ has nothing to do with SSO, not a single bit, so let's not get it involved in the discussion. Both au... Greg Shah

08:35 AM Feature #3931: single sign-on for virtual desktop mode

> Do you want a default os user if none is specified in directory?
I would not expect there to be a default os use... Greg Shah

08:31 AM Feature #3931: single sign-on for virtual desktop mode

Constantin Asofiei wrote:
> Galya B wrote:
> > Let me just explain it that way: SSO with a default FWD user and a d... Galya B

08:31 AM Feature #3931: single sign-on for virtual desktop mode

Galya B wrote:
> Let me just explain it that way: SSO with a default FWD user and a default OS user is called @Guest... Constantin Asofiei

08:30 AM Feature #3931: single sign-on for virtual desktop mode

Let me just explain it that way: SSO with a default FWD user and a default OS user is called @GuestAccess@. Galya B

08:24 AM Feature #3931: single sign-on for virtual desktop mode

Greg Shah wrote:
> > Default FWD user for SSO
>
> Are you asking if we still need to support @GuestAccess@ or som... Galya B

08:19 AM Feature #3931: single sign-on for virtual desktop mode

> RPC WebClientLauncher.spawn with SSO
This still needs to be discussed. We have a customer that originally plann... Greg Shah

08:15 AM Feature #3931: single sign-on for virtual desktop mode

Greg Shah wrote:
> I think this was about securing the entry points (e.g. @client:cmd-line-option:startup-procedure@... Constantin Asofiei

08:12 AM Feature #3931: single sign-on for virtual desktop mode

> Since both checks were omitted with VD before, I want to know if it makes sense to enable them for regular VD spawn... Greg Shah

08:08 AM Feature #3931: single sign-on for virtual desktop mode

> > @remotelaunchoption@ I guess is allowing the fwd user to send certain options to the client. Why is it called rem... Greg Shah

08:05 AM Feature #3931: single sign-on for virtual desktop mode

> @trustedspawner@ I guess is allowing the fwd user to spawn a new process without os password.
Correct
> @remo... Greg Shah

06:06 AM Feature #3931: single sign-on for virtual desktop mode

Configs for testing:... Galya B

06:03 AM Feature #3931: single sign-on for virtual desktop mode

r14659 up, all code review requests addressed.
I'll be waiting for *answers* to my questions and further *code re... Galya B

05:27 AM Feature #3931: single sign-on for virtual desktop mode

Actually is it possible to determine the fwd user for Virtual Desktop running without SSO? For the connection auth wi... Galya B

04:55 AM Feature #3931: single sign-on for virtual desktop mode

SSO Features Support:
|Feature|Planned|
|SSL connection authentication + SSO|❌|
|OS account pools|❌|
|RPC WebCl... Galya B

04:37 AM Feature #3931: single sign-on for virtual desktop mode

Since both checks were omitted with VD before, I want to know if it makes sense to enable them for regular VD spawn r... Galya B

04:35 AM Feature #3931: single sign-on for virtual desktop mode

I have a question about the security checks, that are for the plugins @trustedspawner@ and @remotelaunchoption@: what... Galya B

08/01/2023

03:28 AM Feature #3931: single sign-on for virtual desktop mode

I'll soon apply the changes with the latest revision, so when you have time, you can also check the initial refactori... Galya B

02:28 AM Feature #3931: single sign-on for virtual desktop mode

Check how @auth-plugins@ works with @GuestAccess@ - something similar can be done for the guest SSO plugin (we should... Constantin Asofiei

02:21 AM Feature #3931: single sign-on for virtual desktop mode

The fwd user attr @<node-attribute name="osuser" value="[os-user]"/>@ can't be replaced by a default. That's how the ... Galya B

07/31/2023

12:59 PM Feature #3931: single sign-on for virtual desktop mode

Galya B wrote:
> I mean we can still use @bogus@. When I'm done with the work, I'll change it to @bogus@ and will ad... Constantin Asofiei

12:10 PM Feature #3931: single sign-on for virtual desktop mode

I mean we can still use @bogus@. When I'm done with the work, I'll change it to @bogus@ and will add @<node-attribute... Galya B

12:06 PM Feature #3931: single sign-on for virtual desktop mode

I created the @SsoAuthenticatorSample@ and hardcoded fwd user @newuser@ that can use any os user configured for it.
... Galya B

12:02 PM Feature #3931: single sign-on for virtual desktop mode

Thanks for the explanation.
Greg, just an idea: it would be helpful for i.e. development mode to have a 'GuestSSOP... Constantin Asofiei

11:55 AM Feature #3931: single sign-on for virtual desktop mode

Correct. This will be pure Java and will not have a context. Greg Shah

11:52 AM Feature #3931: single sign-on for virtual desktop mode

Basically we can't have a context before determining the fwd user that is returned by the SSO auth, so it should run ... Galya B

11:49 AM Feature #3931: single sign-on for virtual desktop mode

Constantin Asofiei wrote:
> I don't understand; from looking at the code, the default value for @Thread.defaultUncau... Galya B

11:15 AM Feature #3931: single sign-on for virtual desktop mode

Galya B wrote:
> Constantin Asofiei wrote:
> > Review for 3931a rev 14653:
> > * @ClientDriver.main@ - @defaultUnc... Constantin Asofiei

09:10 AM Feature #3931: single sign-on for virtual desktop mode

Constantin Asofiei wrote:
> Review for 3931a rev 14653:
> * @ClientDriver.main@ - @defaultUncaughtExceptionHandler@... Galya B

07:13 AM Feature #3931: single sign-on for virtual desktop mode

Review for 3931a rev 14653:
* @ClientDriver.main@ - @defaultUncaughtExceptionHandler@ can be null
* @SchemaComparat... Constantin Asofiei

07:20 AM Bug #7646: FILL-IN: NPE during the PASTE of non-text clipboard contents

Greg Shah wrote:
> Instead of applying the fix to trunk directly, I prefer to just include the fix in another branch... Vladimir Tsichevski

07:10 AM Bug #7646: FILL-IN: NPE during the PASTE of non-text clipboard contents

Greg Shah wrote:
> Instead of applying the fix to trunk directly, I prefer to just include the fix in another branch... Vladimir Tsichevski

07:09 AM Bug #7646: FILL-IN: NPE during the PASTE of non-text clipboard contents

Instead of applying the fix to trunk directly, I prefer to just include the fix in another branch where you are alrea... Greg Shah

06:46 AM Bug #7646: FILL-IN: NPE during the PASTE of non-text clipboard contents

Greg Shah wrote:
> Do we need a task for this? The fix seems trivial.
I think we don't. I can fix this in the tr... Vladimir Tsichevski

06:44 AM Bug #7646: FILL-IN: NPE during the PASTE of non-text clipboard contents

Do we need a task for this? The fix seems trivial. Greg Shah

06:28 AM Bug #7646 (WIP): FILL-IN: NPE during the PASTE of non-text clipboard contents

Scenario:
# there is no *text* contents in system-wide clipboard (for example, the user copied an image to clipboa... Vladimir Tsichevski

06:05 AM Bug #7646 (Merge Pending): FILL-IN: NPE during the PASTE of non-text clipboard contents

Vladimir Tsichevski

07/28/2023

03:59 PM Bug #7515: FILL-IN: editing dates issues

Vladimir Tsichevski wrote:
> Yet another issue: normally pressing @?@ (question) should always reset screen value to... Vladimir Tsichevski

11:41 AM Bug #7515: FILL-IN: editing dates issues

**#9855 (FIXED)** Yet another issue:
Test program:... Vladimir Tsichevski

02:53 PM Bug #7642: Assigning SESSION:DATE-FORMAT has no effect on existing date instances

Run this program. Assume the default date format is @mdy@ (as set in @directory.xml@).... Vladimir Tsichevski

02:39 PM Bug #7642 (WIP): Assigning SESSION:DATE-FORMAT has no effect on existing date instances

Vladimir Tsichevski

07/27/2023

08:59 AM Bug #7515: FILL-IN: editing dates issues

**(FIXED)** Yet another issue: normally pressing @?@ (question) should always reset screen value to an empty string.
... Vladimir Tsichevski