Activity

From 08/15/2023 to 09/13/2023

09/13/2023

05:05 PM Bug #7794: FILL-IN: editing numbers issues: I am remembering that some layout modes (@COLON-ALIGNED@?, @SIDE-LABELS@?) might change the alignment of the associat... Greg Shah
04:51 PM Bug #7794: FILL-IN: editing numbers issues: *FIXED*
Screen value formatting issue:
GUI Swing, both decimal/integer editors:
In OE, a non-unknown value is ... Vladimir Tsichevski

09/12/2023

02:35 PM Bug #7794: FILL-IN: editing numbers issues: *ISSUE*
@FILL-IN@ for a decimal variable, default format, Swing: if the cursor points to a thousands delimiter, an i... Vladimir Tsichevski
02:33 PM Bug #7794: FILL-IN: editing numbers issues: *ISSUE*
@FILL-IN@ for an *integer* variable, default format, Swing: if the cursor points to a thousands delimiter,... Vladimir Tsichevski
02:31 PM Bug #7794 (WIP): FILL-IN: editing numbers issues: Vladimir Tsichevski
12:04 PM Feature #4856 (Review): web client session forking: Ready for review in 3931a (latest r14770), based on trunk r14707.
Relevant files:... Galya B
10:42 AM Feature #3931: single sign-on for virtual desktop mode: Galya B wrote:
> Just mentioning on time... the whole confusion of the end user about messages about FWD user / acco... Greg Shah
10:40 AM Feature #3931: single sign-on for virtual desktop mode: Just mentioning on time... the whole confusion of the end user about messages about FWD user / account and OS user / ... Galya B
10:40 AM Feature #3931: single sign-on for virtual desktop mode: Galya B wrote:
> And you want them translated or not?
Yes. If there is any problem with the translations, our cu... Greg Shah
10:37 AM Feature #3931: single sign-on for virtual desktop mode: And you want them translated or not? Galya B
10:33 AM Feature #3931: single sign-on for virtual desktop mode: Galya B wrote:
> Greg Shah wrote:
> > Please restore the previous level of detail.
> The number / type of errors i... Greg Shah
09:44 AM Feature #3931: single sign-on for virtual desktop mode: Also translating the errors with Google translator may get funny for things like @Cannot load dynamic libraries.@. :) Galya B
09:26 AM Feature #3931: single sign-on for virtual desktop mode: Greg Shah wrote:
> Please restore the previous level of detail.
The number / type of errors in the web handlers wen... Galya B
08:45 AM Feature #3931: single sign-on for virtual desktop mode: > > When running in an enviornment where there is no existing session, then I think we should handle this same requir... Greg Shah
08:39 AM Feature #3931: single sign-on for virtual desktop mode: > It's convenient when end-users tell admins what exactly went wrong by quoting the error message, but at the same ti... Greg Shah
01:30 AM Feature #3931: single sign-on for virtual desktop mode: Constantin Asofiei wrote:
> Galya B wrote:
> > All right, I'll just set the context anew every time it's not a remo... Galya B
01:26 AM Feature #3931: single sign-on for virtual desktop mode: Greg Shah wrote:
> When running in an enviornment where there is no existing session, then I think we should handle ... Galya B
01:21 AM Feature #3931: single sign-on for virtual desktop mode: Constantin Asofiei wrote:
> At least, we need a proper error message being shown (something like @Not enough permiss... Galya B
07:37 AM Bug #7515: FILL-IN: editing dates issues: Yet another issue: in @7019.p@ I assign the date variable on the @LEAVE@ event of the date @FILL-IN@:... Vladimir Tsichevski

09/11/2023

05:37 PM Bug #7515: FILL-IN: editing dates issues: Another issue: when the user presses @TAB@, and focus moves from the date @FILL-IN@ to the next tabbed widget, this w... Vladimir Tsichevski
04:11 PM Bug #7779: ChUI Swing: focus does not move backward with Shift-TAB key: Yet another issue in FWD ChUI:
I invoke a button, which causes an action, which causes an error, which raises an e... Vladimir Tsichevski
04:01 PM Bug #7779: ChUI Swing: focus does not move backward with Shift-TAB key: Another issue:
In OE in character mode error messages are displayed in the message area.
In FWD a message box is ... Vladimir Tsichevski
11:18 AM Bug #7779: ChUI Swing: focus does not move backward with Shift-TAB key: Vladimir Tsichevski wrote:
> Another issue with ChUI (both Swing and native).
>
> In OE pressing the @Ctrl-R@ key... Vladimir Tsichevski
09:58 AM Bug #7779: ChUI Swing: focus does not move backward with Shift-TAB key: Another issue with ChUI (both Swing and native).
In OE pressing the @Ctrl-R@ key cleans the screen to an empty str... Vladimir Tsichevski
08:54 AM Bug #7779: ChUI Swing: focus does not move backward with Shift-TAB key: Another issue in ChUI (both Swing and native).
In OE ChUI the @Home@ and @End@ keys move focus to the first and la... Vladimir Tsichevski
08:34 AM Bug #7779: ChUI Swing: focus does not move backward with Shift-TAB key: ChUI Swing: another issue: the @CursorDown@ key moves the cursor outside the destination widget area.
See the @777... Vladimir Tsichevski
07:39 AM Bug #7779: ChUI Swing: focus does not move backward with Shift-TAB key: Another issue in *ChUI native* mode: pressing @Tab@ and @Backtab@ sometimes does not work as expected:
# can cause... Vladimir Tsichevski
03:04 PM Feature #3931: single sign-on for virtual desktop mode: > Sergey, as far as I understand at the moment there is no config for languages outside of a 4GL app? I mean there is... Greg Shah
03:00 PM Feature #3931: single sign-on for virtual desktop mode: Constantin Asofiei wrote:
> Galya B wrote:
> > All right, I'll just set the context anew every time it's not a remo... Greg Shah
12:26 PM Feature #3931: single sign-on for virtual desktop mode: Galya B wrote:
> All right, I'll just set the context anew every time it's not a remote call.
The context needs to ... Constantin Asofiei
10:30 AM Feature #3931: single sign-on for virtual desktop mode: I'm speaking about redirections and links... On app end JS redirects to the logout page in SSO. The taskbar menu shou... Galya B
10:27 AM Feature #3931: single sign-on for virtual desktop mode: > The easy way out was if directory knew the external address for login / logout.
How is this different from the s... Greg Shah
10:06 AM Feature #3931: single sign-on for virtual desktop mode: The variables in the address are too many and both the Java servlets and the js code have difficulties to imagine whe... Galya B
09:56 AM Feature #3931: single sign-on for virtual desktop mode: I don't see how we can eliminate the reverse proxy support. Some customers require that only the server's port 443 i... Greg Shah
09:51 AM Feature #3931: single sign-on for virtual desktop mode: Can we remove reverse proxies for customers?
The /gui, /chui, /embedded port is configurable and if that is @443@ ... Galya B
08:32 AM Feature #3931: single sign-on for virtual desktop mode: r14767 Review part II improvements applied. Galya B
06:13 AM Feature #3931: single sign-on for virtual desktop mode: Greg, I remember you wanted @remotelaunchoption@ to be checked for all web spawn requests, instead of just those from... Galya B
05:53 AM Feature #3931: single sign-on for virtual desktop mode: Btw the mime types look neater in the latest revision. I've put them in a map. Galya B
05:28 AM Feature #3931: single sign-on for virtual desktop mode: Constantin Asofiei wrote:
> > > ** @handle@ - can we make the mime type code for images more generic?
> > Do you st... Galya B
05:06 AM Feature #3931: single sign-on for virtual desktop mode: Constantin Asofiei wrote:
> > Unfortunately that wacky @initSecurityManager@ serves a purpose. The authenticator is ... Galya B
04:49 AM Feature #3931: single sign-on for virtual desktop mode: Galya B wrote:
> This part is completely reworked, especially in the latest revision, so it's not applicable any mor... Constantin Asofiei
03:49 AM Feature #3931: single sign-on for virtual desktop mode: Constantin Asofiei wrote:
> 4. SecurityManager refactoring
> * @SecurityManager@ is used from customer applications... Galya B
03:20 AM Feature #3931: single sign-on for virtual desktop mode: Constantin Asofiei wrote:
> 3. SSO and embedded refactoring
> * @LeafSessionManager@, @p2j.remote.js@ - no actual c... Galya B
10:45 AM Feature #4856: web client session forking: It is fine where it is for now. We will probably reorganize these so that the features that are for analysis or diag... Greg Shah
10:43 AM Feature #4856: web client session forking: The new menu item ended up in the middle, because it seems the lower menu is added after the initialization. Do I try... Galya B
09:01 AM Feature #4856: web client session forking: > > There is an existing popup menu on the taskbar, add an item to that.
>
> It is existing only for virtual deskt... Greg Shah
08:49 AM Feature #4856: web client session forking: Greg Shah wrote:
> There is an existing popup menu on the taskbar, add an item to that.
It is existing only for v... Galya B
08:06 AM Feature #4854: origin affinity: Yes, this sounds reasonable. Greg Shah
07:36 AM Feature #4854: origin affinity: OK, then if a storage identifier is provided (probably userId with SSO), then the value will be set in @localStorage@... Galya B
07:26 AM Feature #4854: origin affinity: The design is good.
> Do I work on it under #4517 or here?
Here.
> > Due to the fact that some customers hav... Greg Shah
02:48 AM Bug #7786: FOCUS handle must return only field-level widgets: This issue was identified during #6615.
@FOCUS@ should only return field-level (frame child widgets or other frame... Hynek Cihlar
02:44 AM Bug #7786 (New): FOCUS handle must return only field-level widgets: Hynek Cihlar

09/10/2023

01:12 PM Feature #3931: single sign-on for virtual desktop mode: Continue for the review of 3931a rev 14758 on top of trunk rev 14707.
3. SSO and embedded refactoring
* @LeafSess... Constantin Asofiei

09/08/2023

05:00 PM Bug #7779: ChUI Swing: focus does not move backward with Shift-TAB key: The following patch removed this asymmetry with the @TAB@ key and seems to cure the issue. I consider this as an urge... Vladimir Tsichevski
04:43 PM Bug #7779 (Feedback): ChUI Swing: focus does not move backward with Shift-TAB key: The difference is in the @LinuxKeyboardReader@: instead of one keyboard event it generates two events: one for key pr... Vladimir Tsichevski
09:06 AM Bug #7779: ChUI Swing: focus does not move backward with Shift-TAB key: Alexandru Lungu wrote:
> Eduard, can you please check if this is caused by your recent focus changes?
Probably no... Eduard Soltan
02:29 AM Bug #7779: ChUI Swing: focus does not move backward with Shift-TAB key: Eduard, can you please check if this is caused by your recent focus changes? Alexandru Lungu
08:29 AM Feature #4856: web client session forking: There is an existing popup menu on the taskbar, add an item to that. Greg Shah
08:15 AM Feature #4856: web client session forking: The @.dock@ div is generated programmatically and the @#taskBar@ is a canvas. If this is where the new button should ... Galya B
08:08 AM Feature #4856: web client session forking: Is there already a toolbar / taskbar in the DOM where this button can be added? Galya B
08:25 AM Feature #3931: single sign-on for virtual desktop mode: > If customers with embedded are not going to be updated with trunk, I can fix it here.
Yes, we can fix it here. Greg Shah
02:57 AM Feature #3931: single sign-on for virtual desktop mode: Sergey, as far as I understand at the moment there is no config for languages outside of a 4GL app? I mean there is n... Galya B
02:10 AM Feature #3931: single sign-on for virtual desktop mode: There is a regression related to #4938 (4938b merged in r14688).
@ClientCore.processClientParams@ lost:... Galya B
02:41 AM Feature #4854 (WIP): origin affinity: In 3931a the landing page for both drivers has @iframe@, where the actual login page resides. The content gets later ... Galya B
02:23 AM Feature #4129 (Review): map web client users to OS accounts: Review in progress in #3931. Galya B
02:23 AM Feature #4129 (WIP): map web client users to OS accounts: Galya B

09/07/2023

07:00 PM Bug #7779: ChUI Swing: focus does not move backward with Shift-TAB key: Greg Shah wrote:
> What testcase?
@7779.p@ attached. Vladimir Tsichevski
05:19 PM Bug #7779: ChUI Swing: focus does not move backward with Shift-TAB key: What testcase? Greg Shah
04:47 PM Bug #7779: ChUI Swing: focus does not move backward with Shift-TAB key: In ChUI mode when I press @Shift-TAB@, the focus jumps to the previous widget in the tab order, but returns back in t... Vladimir Tsichevski
04:44 PM Bug #7779 (Feedback): ChUI Swing: focus does not move backward with Shift-TAB key: Vladimir Tsichevski
03:22 PM Feature #3931: single sign-on for virtual desktop mode: If there is a requirement to internationalize login pages, then http request object gives the user client preferred l... Sergey Ivanovskiy
08:27 AM Feature #3931: single sign-on for virtual desktop mode: I'm not sure how translation should work on the login page. @gettext.js@ uses the language set by the 4GL session acc... Galya B
07:56 AM Feature #3931: single sign-on for virtual desktop mode: Constantin, here is the new look of the OS Users Management page. Please note that the second table (Associated FWD U... Galya B
02:08 AM Feature #3931: single sign-on for virtual desktop mode: Sergey,
1. renaming of @virtualDesktopEnabled@ was for consistency. The whole "enable" drivers thing was very mess... Galya B
10:57 AM Feature #4856 (WIP): web client session forking: Greg Shah wrote:
> > Also I possibly need to fix Jetty's sessions - the FWD client's embedded Jetty policy attaches ... Galya B
10:53 AM Feature #4856: web client session forking: > > create multiple sessions so long as they stay in the same browser.
> I don't like the phrasing. They can go to a... Greg Shah
10:52 AM Feature #4856: web client session forking: > OK, then a button to open a new tab with the virtual desktop landing page address is enough.
Rather than have a ... Greg Shah
10:51 AM Feature #4856: web client session forking: Greg Shah wrote:
> create multiple sessions so long as they stay in the same browser.
I don't like the phrasing. Th... Galya B
10:46 AM Feature #4856: web client session forking: OK, then a button to open a new tab with the virtual desktop landing page address is enough.
The limitation is tha... Galya B
10:32 AM Feature #4856: web client session forking: > > This will meet the customers needs. If it is not possible, help me understand why.
>
> Because the customer c... Greg Shah
10:28 AM Feature #4856: web client session forking: Greg Shah wrote:
> The same user is able to access multiple organizations and it is an application function to imple... Galya B
10:25 AM Feature #4856: web client session forking: Greg Shah wrote:
> This will meet the customers needs. If it is not possible, help me understand why.
Because th... Galya B
10:24 AM Feature #4856: web client session forking: > I think they want different sessions with different in-app users in one browser.
No, they don't want this. The ... Greg Shah
10:23 AM Feature #4856: web client session forking: > > A customer has the requirement that a user should be able to create more than one web client session with their a... Greg Shah
10:16 AM Feature #4856: web client session forking: Can we get some clarifications from the customer on their requirements? I think they want different sessions with dif... Galya B
10:12 AM Feature #4856: web client session forking: Let me try to put it in other words:
> A customer has the requirement that a user should be able to create more th... Galya B
10:02 AM Feature #4856: web client session forking: > One person can open multiple sessions on multiple devices, with multiple browsers and in multiple tabs in each brow... Greg Shah
09:56 AM Feature #4856: web client session forking: > Under "in-app" I mean a user in the customer's DB or any directory they use. The above questions can apply to any o... Greg Shah
09:54 AM Feature #4856: web client session forking: Galya B wrote:
> Maybe it's time to define some basic terms and reconsider the core statements.
>
> > a user shou... Greg Shah
09:41 AM Feature #4856: web client session forking: One person can open multiple sessions on multiple devices, with multiple browsers and in multiple tabs in each browse... Galya B
08:59 AM Feature #4856: web client session forking: Under "in-app" I mean a user in the customer's DB or any directory they use. The above questions can apply to any oth... Galya B
08:56 AM Feature #4856: web client session forking: Maybe it's time to define some basic terms and reconsider the core statements.
> a user should be able to create m... Galya B

09/06/2023

11:58 AM Feature #3931: single sign-on for virtual desktop mode: The code part @<script/>@ of @web_landing.html@ template does not use https://developer.mozilla.org/en-US/docs/Web/Ja... Sergey Ivanovskiy
11:45 AM Feature #3931: single sign-on for virtual desktop mode: I would prefer to use different tasks for SSO plugin and for login pages because these two tasks should be completely... Sergey Ivanovskiy
11:24 AM Feature #3931: single sign-on for virtual desktop mode: Galya, please help to understand what are advantages of renaming @webClient/virtualDesktopEnabled -> webClient/virtua... Sergey Ivanovskiy
05:16 AM Feature #3931: single sign-on for virtual desktop mode: Constantin, I think @No Password Protection@ is not working properly for FWD accounts as well, can you confirm? It's ... Galya B
05:00 AM Feature #3931: single sign-on for virtual desktop mode: Constantin Asofiei wrote:
> * @AdminServiceImpl.setOsUser@ - if @plainPassword@ is null/empty, don't we need to rese... Galya B
03:40 AM Feature #3931: single sign-on for virtual desktop mode: Constantin Asofiei wrote:
> For consistency; you can have:
> ... Galya B
02:25 AM Feature #3931: single sign-on for virtual desktop mode: Sergey, a few pointers about what's going on in 3931a:
* @com.goldencode.p2j.main.Webandler@ was renamed to @WebDriv... Galya B

09/05/2023

02:04 PM Feature #3931: single sign-on for virtual desktop mode: and translation resources are defined by special get text js json format. Please look at this file
@src/com/goldenco... Sergey Ivanovskiy
01:43 PM Feature #3931: single sign-on for virtual desktop mode: Greg Shah wrote:
> Sergey: Please point Galya to some details for how we handle the I18N support in the JS side of t... Sergey Ivanovskiy
10:48 AM Feature #3931: single sign-on for virtual desktop mode: Sergey: Please point Galya to some details for how we handle the I18N support in the JS side of the web client. Greg Shah
10:47 AM Feature #3931: single sign-on for virtual desktop mode: Branch 3931a is where the changes are. Please focus on the web client login and admin console changes. Constantin i... Greg Shah
10:35 AM Feature #3931: single sign-on for virtual desktop mode: Greg Shah wrote:
> Galya B wrote:
> > r14759 an updated default login screen (html + css). Desktop settings (bgr at... Sergey Ivanovskiy
09:54 AM Feature #3931: single sign-on for virtual desktop mode: Greg Shah wrote:
> Let's also make sure that the new login and the error message processing is honoring our I18N tra... Galya B
09:31 AM Feature #3931: single sign-on for virtual desktop mode: Default favicon and logo added to the main project in r14761. Galya B
09:25 AM Feature #3931: single sign-on for virtual desktop mode: > > If this is the default login for FWD, why do we need to add the logo and favicon to the application jar? I'd pre... Greg Shah
09:15 AM Feature #3931: single sign-on for virtual desktop mode: Greg Shah wrote:
> If this is the default login for FWD, why do we need to add the logo and favicon to the applicati... Galya B
09:14 AM Feature #3931: single sign-on for virtual desktop mode: Let's also make sure that the new login and the error message processing is honoring our I18N translations approach.
... Greg Shah
09:13 AM Feature #3931: single sign-on for virtual desktop mode: Galya B wrote:
> r14759 an updated default login screen (html + css). Desktop settings (bgr attributes from director... Greg Shah
04:52 AM Feature #3931: single sign-on for virtual desktop mode: Galya B wrote:
> Constantin Asofiei wrote:
> > ** check and fix conversion for @h:auth-blob@ support (i.e. handle a... Constantin Asofiei
03:59 AM Feature #3931: single sign-on for virtual desktop mode: Constantin Asofiei wrote:
> ** check and fix conversion for @h:auth-blob@ support (i.e. handle access, not @SESSION@... Galya B
02:33 AM Feature #3931: single sign-on for virtual desktop mode: Galya, this is the first part of the review. I'm still going through the SSO changes and the SecurityManager refacto... Constantin Asofiei

09/04/2023

11:32 AM Feature #3931: single sign-on for virtual desktop mode: r14759 an updated default login screen (html + css). Desktop settings (bgr attributes from directory) removed.
The... Galya B

09/01/2023

09:17 AM Feature #3931: single sign-on for virtual desktop mode: r14758 adds support for @/webres@ context for base virtual desktop and embedded resources (style.css, login page, fav... Galya B

08/30/2023

04:22 AM Feature #3931: single sign-on for virtual desktop mode: A few minor fixes pushed to r14757. Galya B
04:18 AM Feature #3931: single sign-on for virtual desktop mode: Here is what needs to be done to hotel_gui to run with 3931a:
Add the @SsoAuthenticator@ implementation (dummy as ... Galya B

08/28/2023

09:05 AM Feature #6438 (Closed): frame attributes, methods and options: Greg Shah
08:35 AM Feature #6438: frame attributes, methods and options: Branch @6438b@ was merged to trunk as revno @14711@ then it was archived. Eugenie Lyzenko
08:26 AM Feature #6438: frame attributes, methods and options: Greg Shah wrote:
> You can merge to trunk after 7589a.
OK. I'm starting. Eugenie Lyzenko

08/27/2023

05:58 PM Feature #6438: frame attributes, methods and options: You can merge to trunk after 7589a. Greg Shah
05:53 PM Feature #6438: frame attributes, methods and options: Code Review Task Branch 6438b Revision 14710
The changes are good. Greg Shah

08/25/2023

11:04 AM Feature #6438: frame attributes, methods and options: Rebased @6438b@ with recent trunk @14709@. New revision is @14710@. Eugenie Lyzenko
07:35 AM Feature #3931: single sign-on for virtual desktop mode: Final touch-ups in r14756: CertificateUtil removed, file headers added to AccountExtUtil and SecurityUtil.
Galya B
06:12 AM Feature #3931: single sign-on for virtual desktop mode: r14755 with file headers.
Constantin, if you can, check it out. It will be helpful. There are a bunch of files upd... Galya B
05:57 AM Feature #3931: single sign-on for virtual desktop mode: I'm reviewing 3931a. Constantin Asofiei
03:19 AM Feature #3931: single sign-on for virtual desktop mode: P.S. File headers in the making. Galya B
03:18 AM Feature #3931 (Review): single sign-on for virtual desktop mode: 3931a rebased on trunk r14707. Ready for review. Galya B

08/24/2023

09:30 AM Feature #3931: single sign-on for virtual desktop mode: Ah, this makes sense. Up in r14683. Galya B
09:28 AM Feature #3931: single sign-on for virtual desktop mode: I was thinking of a default method in the interface. Greg Shah
09:15 AM Feature #3931: single sign-on for virtual desktop mode: Also the hotel gui SsoAuthenticator implementation (I still haven't uploaded) returns null. Galya B
09:14 AM Feature #3931: single sign-on for virtual desktop mode: Greg Shah wrote:
> > To enable auto-login they need to implement two methods of the @SsoAuthenticator@: @getAuthCook... Galya B
09:12 AM Feature #3931: single sign-on for virtual desktop mode: Galya B wrote:
> Greg Shah wrote:
> > > With allowing auto-login, as I've said in the past, new clients will be way... Greg Shah
09:11 AM Feature #3931: single sign-on for virtual desktop mode: Greg Shah wrote:
> > With allowing auto-login, as I've said in the past, new clients will be way easier to get spawn... Galya B
09:07 AM Feature #3931: single sign-on for virtual desktop mode: > The abuser is someone with valid username and password, so it's very much in the hands of the customers to keep tha... Greg Shah
08:59 AM Feature #3931: single sign-on for virtual desktop mode: I get:... Galya B
07:42 AM Feature #3931: single sign-on for virtual desktop mode: We can further expand the args passed in to the @SsoAuthenticator@ to allow licensing management, but that with next ... Galya B
07:40 AM Feature #3931: single sign-on for virtual desktop mode: I was thinking how to protect better the expensive resource of spawning a new web client process. And I was thinking ... Galya B

08/23/2023

01:11 PM Bug #7742 (WIP): NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application: Hynek Cihlar
01:11 PM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application: Vladimir Tsichevski wrote:
> Hynek Cihlar wrote:
> > Vladimir Tsichevski wrote:
> > > I see no differences.
> > >... Hynek Cihlar
01:05 PM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application: Hynek Cihlar wrote:
> Vladimir Tsichevski wrote:
> > I see no differences.
> >
> > Also: after the @Escape@ was ... Vladimir Tsichevski
01:01 PM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application: Vladimir Tsichevski wrote:
> I see no differences.
>
> Also: after the @Escape@ was pressed, the new key press is... Hynek Cihlar
12:53 PM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application: Vladimir Tsichevski wrote:
> Hynek Cihlar wrote:
> > Vladimir Tsichevski wrote:
> > > Hynek Cihlar wrote:
> > > >... Vladimir Tsichevski
12:46 PM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application: Hynek Cihlar wrote:
> Vladimir Tsichevski wrote:
> > Hynek Cihlar wrote:
> > > Vladimir, please also retest.
> > ... Vladimir Tsichevski
12:43 PM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application: Vladimir Tsichevski wrote:
> Hynek Cihlar wrote:
> > Vladimir, please also retest.
>
> The NPE disappeared now, ... Hynek Cihlar
12:36 PM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application: Hynek Cihlar wrote:
> Vladimir, please also retest.
The NPE disappeared now, but it seems the code works incorrec... Vladimir Tsichevski
12:12 PM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application: I added missing code comments in 7742a revision 14708. Hynek Cihlar
11:52 AM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application: Greg Shah wrote:
> Are we sure we need to add a @null@ keyboard event to the queue?
>
> Tomasz: Have you encounte... Tomasz Domin
11:28 AM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application: Vladimir, please also retest. Hynek Cihlar
11:26 AM Bug #7742 (Review): NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application: Hynek Cihlar
11:25 AM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application: The issue is fixed in 7742a revision 14707. The problem only showed in Swing ChUI client. Please review. Hynek Cihlar
11:14 AM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application: Hynek Cihlar wrote:
> Greg Shah wrote:
> > Are we sure we need to add a @null@ keyboard event to the queue?
>
> ... Vladimir Tsichevski
10:32 AM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application: Greg Shah wrote:
> Are we sure we need to add a @null@ keyboard event to the queue?
Yes, it is used to signal a m... Hynek Cihlar
10:00 AM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application: Are we sure we need to add a @null@ keyboard event to the queue?
Tomasz: Have you encountered this issue in @<larg... Greg Shah
09:26 AM Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application: ChUI Swing: when I press @Escape@, the client crashes with NPE here:... Vladimir Tsichevski
09:15 AM Bug #7742 (WIP): NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application: Vladimir Tsichevski
11:10 AM Feature #6438: frame attributes, methods and options: Rebased @6438b@ with recent trunk @14707@. New revision is @14708@.
Greg,
I have no plans to add new changes he... Eugenie Lyzenko
10:15 AM Feature #7709: ABLUnit support for web clients: Yes, it is a good point. There is a benefit to testing the spawning process itself.
On the other hand, spawning i... Greg Shah
08:56 AM Feature #3931: single sign-on for virtual desktop mode: Greg Shah wrote:
> > What I'm trying to say is the major flaw with launching before auth is fixed.
>
> Yes, I un... Galya B
08:50 AM Feature #3931: single sign-on for virtual desktop mode: > The question is if @auth-mode/ssoplugin@ is defined, but can't be instantiated (some typo in the package, class nam... Greg Shah
08:49 AM Feature #3931: single sign-on for virtual desktop mode: > What I'm trying to say is the major flaw with launching before auth is fixed.
Yes, I understand. My discussion... Greg Shah
08:18 AM Feature #3931: single sign-on for virtual desktop mode: A question about configs: currently if @auth-mode/ssoplugin@ is defined and can be instantiated, then SSO is enabled.... Galya B
07:24 AM Feature #3931: single sign-on for virtual desktop mode: But I think it's fine. "works without SSO" means it directly checks the user / pass against the DB, where the in-app ... Galya B
07:19 AM Feature #3931: single sign-on for virtual desktop mode: Greg Shah wrote:
> To be clear: in #3770-81 I noted that our current login approach with embedded mode does need ser... Galya B
07:16 AM Feature #3931: single sign-on for virtual desktop mode: The hotel gui js and the embedded driver js (intertwined with it) are very particular. I'm sure we don't have a guide... Galya B
07:16 AM Feature #3931: single sign-on for virtual desktop mode: To be clear: in #3770-81 I noted that our current login approach with embedded mode does need serious changes. Spawn... Greg Shah
07:09 AM Feature #3931: single sign-on for virtual desktop mode: Galya: Along with other objectives, Hotel GUI is intended to be an example of how to implement Embedded Mode for a GU... Greg Shah
04:51 AM Feature #3931: single sign-on for virtual desktop mode: So @setuserid@ does DB auth, which is a valid approach. I haven't uploaded anything to hotel_gui, but there are certa... Galya B

08/22/2023

12:30 PM Bug #7515: FILL-IN: editing dates issues: All fixes were tested for the following date formats: @9999/99/99@, @99/99/99@, @99999999@, @999999@.
The component ... Vladimir Tsichevski
12:28 PM Bug #7515: FILL-IN: editing dates issues: The 7019a revision 14691 contains the following fixes:
# #7515-1 bullet 1: missing feature implemented
# #7515-1 ... Vladimir Tsichevski
09:18 AM Bug #7515: FILL-IN: editing dates issues: Yet another issue: the empty screen value for the @99/99/99@ format must be @ / /@, in trunk it is @ / / @ (the ... Vladimir Tsichevski
11:03 AM Feature #6438: frame attributes, methods and options: Rebased @6438b@ with recent trunk @14706@. New revision is @14707@.
Guys,
Can I merge this into trunk? Eugenie Lyzenko
10:50 AM Feature #3931: single sign-on for virtual desktop mode: Hotel gui works well in a parent frame with login form validated by @SsoAuthenticator@. Even the CORS error (a non-cr... Galya B
08:36 AM Feature #3931: single sign-on for virtual desktop mode: It works, it's just that the CORS error is actually present in the console and some DB configs are missing in directo... Galya B
07:27 AM Feature #3931: single sign-on for virtual desktop mode: Embedded mode with Hotel GUI rev 271 and FWD trunk rev 14703 works fine. Constantin Asofiei
05:50 AM Feature #3931: single sign-on for virtual desktop mode: Constantin, do you know if hotel_gui's embedded works? With latest trunk + latest hotel_gui I get a very weird behavi... Galya B

08/21/2023

07:23 PM Feature #6438 (Review): frame attributes, methods and options: The @6438b@ updated for review to revision @14704@.
Added basic support for @STREAM-IO@/@SCREEN-IO@ frame option. ... Eugenie Lyzenko
06:50 PM Feature #6438: frame attributes, methods and options: Created task branch @6438b@ from trunk revision @14703@. Eugenie Lyzenko
02:54 PM Feature #6438: frame attributes, methods and options: Constantin Asofiei wrote:
>
> About @GET-ITERATION@ - does this convert/compile properly in FWD?
> [...]
Yes i... Eugenie Lyzenko
02:39 PM Feature #6438: frame attributes, methods and options: Eugenie, the priority of these attributes is for ChUI, although if any missing GUI support can be added easily to be ... Constantin Asofiei
02:02 PM Feature #6438: frame attributes, methods and options: Go ahead with these changes.
Constantin: What do you think? Greg Shah
01:10 PM Feature #6438: frame attributes, methods and options: Greg Shah wrote:
> > The other thing to be happen is setting USE-TEXT frame option to true. But it is already implem... Eugenie Lyzenko
01:05 PM Feature #6438: frame attributes, methods and options: > The other thing to be happen is setting USE-TEXT frame option to true. But it is already implemented.
You mean t... Greg Shah
12:17 PM Feature #6438: frame attributes, methods and options: Greg Shah wrote:
> Is forcing the use of the fixed width font really the only thing that needs to happen to support ... Eugenie Lyzenko
12:05 PM Feature #6438: frame attributes, methods and options: Is forcing the use of the fixed width font really the only thing that needs to happen to support @STREAM-IO@? Greg Shah
08:47 AM Feature #7709: ABLUnit support for web clients: Greg Shah wrote:
> I was thinking that we already have a client process so we don't need to spawn. I'd prefer to av... Hynek Cihlar

08/19/2023

08:53 PM Feature #6438: frame attributes, methods and options: Further investigations shows the following:
1. Seems like the @SCROLL@ option is currently supported at runtime. At ... Eugenie Lyzenko

08/18/2023

12:33 PM Feature #6438: frame attributes, methods and options: Branch @6438a@ was merged to trunk as revno @14699@ then it was archived. Eugenie Lyzenko
12:22 PM Feature #6438: frame attributes, methods and options: Greg Shah wrote:
> Code Review Task Branch 6438a Revision 14700
>
> The change is fine. I've edited the comments... Eugenie Lyzenko
12:14 PM Feature #6438: frame attributes, methods and options: Code Review Task Branch 6438a Revision 14700
The change is fine. I've edited the comments and history in revision... Greg Shah
11:35 AM Feature #6438: frame attributes, methods and options: Greg Shah wrote:
> Code Review Task Branch 6438a Revision 14699
>
> Overall the changes are good. The only probl... Eugenie Lyzenko
10:51 AM Feature #6438: frame attributes, methods and options: > Also @GET-ITERATION()@ method for @Buffer@ object has only stub at runtime. I think we need to ask the persistence ... Greg Shah
10:50 AM Feature #6438: frame attributes, methods and options: Code Review Task Branch 6438a Revision 14699
Overall the changes are good. The only problem I see is with the imp... Greg Shah
09:13 AM Feature #6438: frame attributes, methods and options: The @6438a@ rebased with recent trunk @14698@. The new revision is @14699@. Eugenie Lyzenko
04:08 AM Feature #3931: single sign-on for virtual desktop mode: Embedded doesn't have a face, because it's supposed to be shaped by the customer, but can I summarize what it is with... Galya B

08/17/2023

07:56 PM Feature #6438 (WIP): frame attributes, methods and options: Eugenie Lyzenko
07:26 PM Feature #6438: frame attributes, methods and options: Also @GET-ITERATION()@ method for @Buffer@ object has only stub at runtime. I think we need to ask the persistence ex... Eugenie Lyzenko
05:12 PM Feature #6438: frame attributes, methods and options: The @6438a@ updated for review to revision @14697@.
This change adds conversion support and partial runtime suppor... Eugenie Lyzenko
11:47 AM Feature #6438: frame attributes, methods and options: Greg Shah wrote:
> * @STREAM-IO@ option
> * @SCROLL@ option
> * @NO-ATTR-SPACE@ option
All of these options to ... Eugenie Lyzenko
08:25 AM Feature #6438: frame attributes, methods and options: Created task branch @6438a@ from trunk revision @14696@. Eugenie Lyzenko
05:19 PM Bug #7515: FILL-IN: editing dates issues: Greg, I need help.
It seems, OE uses different methods for date validation and date conversion:
Both @3010124@ ... Vladimir Tsichevski
04:42 PM Bug #7515: FILL-IN: editing dates issues: The behavior of OE I cannot explain:
# I use the @99999999@ format, and @ymd@ component order.
# I use the followin... Vladimir Tsichevski
04:03 PM Bug #7515: FILL-IN: editing dates issues: Vladimir Tsichevski wrote:
> Vladimir Tsichevski wrote:
> > Another (anti?)issue: date validation for date format @... Vladimir Tsichevski
04:57 AM Feature #7709: ABLUnit support for web clients: > but what I've described can be achieved with Cypress: the go-to nowadays, very solid web UI testing framework with ... Greg Shah
04:54 AM Feature #7709: ABLUnit support for web clients: I was thinking that we already have a client process so we don't need to spawn. I'd prefer to avoid the spawning unl... Greg Shah
03:37 AM Feature #7709: ABLUnit support for web clients: Greg Shah wrote:
> * Rework the login/spawning approach to work from ABLUnit. [..]
> * We need to be able to launch... Galya B

08/16/2023

03:38 PM Feature #7709: ABLUnit support for web clients: Our UI tests being written in #6856 need to be executed in both Swing and the web client. Today, the architecture of... Greg Shah
03:33 PM Feature #7709 (New): ABLUnit support for web clients: Greg Shah
03:19 PM Bug #7515: FILL-IN: editing dates issues: Vladimir Tsichevski wrote:
> Another (anti?)issue: date validation for date format @99999999@:
>
> In OE, any scr... Vladimir Tsichevski
01:37 PM Bug #7515: FILL-IN: editing dates issues: Another (anti?)issue: date validation for date format @99999999@:
In OE, any screen value, which includes a space,... Vladimir Tsichevski
10:40 AM Bug #7515: FILL-IN: editing dates issues: Another issue to check: for the @99999999@ format, the screen values shall never be auto-completed.
Note: in trunk... Vladimir Tsichevski
10:01 AM Bug #7515: FILL-IN: editing dates issues: Another thing I do not understand in in @date.parseWorker(..)@:... Vladimir Tsichevski
09:53 AM Bug #7515: FILL-IN: editing dates issues: Vladimir Tsichevski wrote:
> Another issue: setting the date @FILL-IN@ screen value to @///1@ crashes the client wit... Vladimir Tsichevski
08:51 AM Bug #7515: FILL-IN: editing dates issues: Another issue: setting the date @FILL-IN@ screen value to @///1@ crashes the client with @NumberFormatException@:
... Vladimir Tsichevski
06:48 AM Feature #3931: single sign-on for virtual desktop mode: OK, I'll be digging deeper. Galya B
06:48 AM Feature #3931: single sign-on for virtual desktop mode: To be clear: I'm OK with reworking things now to achieve more common code and a consistent approach. Greg Shah
06:46 AM Feature #3931: single sign-on for virtual desktop mode: Yes, that makes sense. Greg Shah
06:41 AM Feature #3931: single sign-on for virtual desktop mode: I'm not sure how these two evolved and ended up being so different. I guess they can be unified further, but I'm not ... Galya B
06:27 AM Feature #3931: single sign-on for virtual desktop mode: Greg Shah wrote:
> The key point here is that the logins can be the same.
Embedded includes all the driver resour... Galya B
06:25 AM Feature #3931: single sign-on for virtual desktop mode: The key point here is that the logins can be the same. Greg Shah
06:25 AM Feature #3931: single sign-on for virtual desktop mode: This selector is a convenience only. It is not strictly needed in any mode, however it is just as useful in both mod... Greg Shah
06:23 AM Feature #3931: single sign-on for virtual desktop mode: Is the theme selector needed for embedded? Are there themes in embedded? Currently only virtual desktop sets the option. Galya B
05:45 AM Feature #3931: single sign-on for virtual desktop mode: > Do we want to support a default login page for embedded when the customer doesn't provide one? Currently we don't.
... Greg Shah
05:20 AM Feature #3931: single sign-on for virtual desktop mode: If there is no FWD login page it's the same as with the custom VD login - some features won't be available before sta... Galya B
04:37 AM Feature #3931: single sign-on for virtual desktop mode: Do we want to support a default login page for embedded when the customer doesn't provide one? Currently we don't. Galya B

08/15/2023

02:07 PM Bug #7515: FILL-IN: editing dates issues: *ISSUE* Another issue regarding @SESSION:DATE-FORMAT@ and existing date formats.
For all object types, compiled fo... Vladimir Tsichevski
12:52 PM Feature #3931: single sign-on for virtual desktop mode: These embedded resources are really confusing, but I think I start understanding what is going on.
The FWD server ... Galya B
11:45 AM Feature #3931: single sign-on for virtual desktop mode: Galya, the FWD analytics (which I assume you mean by 'report') is managed by @p2j/report/server/ReportWebServer@. Al... Constantin Asofiei
11:27 AM Feature #3931: single sign-on for virtual desktop mode: Constantin, can you tell if these handlers are actually used by any embedded index.html or only by report in @p2j/rep... Galya B
10:13 AM Feature #3931: single sign-on for virtual desktop mode: Greg Shah wrote:
> > The other way of spawning embedded needs some sort of authentication. Do we tackle this?
>
>... Galya B
09:18 AM Feature #3931: single sign-on for virtual desktop mode: In directory we have the following configs related to embedded:
* @embeddedWebApp/enabled@ (boolean) used in @Standa... Galya B
01:14 AM Bug #7674: FILL-IN for a character variable: cannot delete an unknown value: Vladimir Tsichevski wrote:
> The variable is first assigned the @?@ character value, then is unconditionally reset t... Hynek Cihlar

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » User Interface

Activity

Activity

09/13/2023

09/12/2023

09/11/2023

09/10/2023

09/08/2023

09/07/2023

09/06/2023

09/05/2023

09/04/2023

09/01/2023

08/30/2023

08/28/2023

08/27/2023

08/25/2023

08/24/2023

08/23/2023

08/22/2023

08/21/2023

08/19/2023

08/18/2023

08/17/2023

08/16/2023

08/15/2023