Activity

From 12/03/2023 to 01/01/2024

01/01/2024

03:57 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions: Hynek Cihlar wrote:
> Code review 8074a.
>
> @WebDriverHandler.getAvailableThemes@ should somehow handle a theme ... Galya B

12/22/2023

12:09 PM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions: Code review 8074a.
@WebDriverHandler.getAvailableThemes@ should somehow handle a theme with empty name in the dire... Hynek Cihlar

12/21/2023

11:36 AM Bug #7824 (Test): Simplify idle connection settings and apply the default configuration for the w...: Sergey Ivanovskiy
11:33 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: 7824a has been rebased, merged into the trunc as rev 14893 and archived. Sergey Ivanovskiy
11:21 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: Planning to merge within next 15 minutes after rebase. Sergey Ivanovskiy
10:00 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: This can merge after 7889a. Greg Shah
09:46 AM Bug #7824 (Merge Pending): Simplify idle connection settings and apply the default configuration ...: Code review 7824a revision 14897. The changes are good, I have no more objections. Hynek Cihlar
04:00 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: 7824a has been rebased. It seems that it can be merged into the trunc. Are there any objections? Sergey Ivanovskiy

12/20/2023

01:21 PM Bug #7794: FILL-IN: editing numbers issues: h2. Known issues compiled
This entry contains all know sub-issues, and will be edited as new sub-issues emerge and... Vladimir Tsichevski
12:50 PM Bug #7794: FILL-IN: editing numbers issues: Greg Shah wrote:
> I am remembering that some layout modes (@COLON-ALIGNED@?, @SIDE-LABELS@?) might change the align... Vladimir Tsichevski

12/18/2023

11:40 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: Please review rev 14889 (7824a) that fixed refs: #7824-17 and #7824-27. Sergey Ivanovskiy

12/14/2023

02:13 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Waiting for feedback from Eric and Ovidiu #7884-32, #7884-42 and #7884-44. Galya B

12/11/2023

11:30 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: Sergey Ivanovskiy wrote:
> Please review the committed revision 14868 (7824a).
Code review.
According to the j... Hynek Cihlar
06:34 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > We can change the code of @WebClientsManager@ for the case when ... Sergey Ivanovskiy

12/08/2023

09:49 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: Sergey Ivanovskiy wrote:
> We can change the code of @WebClientsManager@ for the case when agent range is not config... Hynek Cihlar
09:47 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: Sergey Ivanovskiy wrote:
> At this moment the debug mode is not enabled if the agent range is not configured. For th... Hynek Cihlar
08:43 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: Sergey Ivanovskiy wrote:
> These web client settings (under @webClient@ node)
> [...]
> are set automatically for... Greg Shah
07:22 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: We can change the code of @WebClientsManager@ for the case when agent range is not configured but the @jvmArgs@ is gi... Sergey Ivanovskiy
07:10 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: The agent range is common for the debugger and jmx agents so jvmArgs just describes jmx and/or debug agents should be... Sergey Ivanovskiy
07:06 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: At this moment the debug mode is not enabled if the agent range is not configured. For the known application there ar... Sergey Ivanovskiy
06:48 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: Sergey Ivanovskiy wrote:
> The agent port is assigned by @WebClientManager@ that reads @jvmArgs@ option in the direc... Hynek Cihlar
06:31 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: Hynek Cihlar wrote:
> Code review 7824a revisions 14862..14867.
>
> I may be misinterpreting the changes, but I d... Sergey Ivanovskiy
05:05 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: Hynek Cihlar wrote:
> Code review 7824a revisions 14862..14867.
>
> I may be misinterpreting the changes, but I d... Hynek Cihlar
05:04 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: Code review 7824a revisions 14862..14867.
I may be misinterpreting the changes, but I don't see how the debug mode... Hynek Cihlar
02:46 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: These web client settings (under @webClient@ node) ... Sergey Ivanovskiy
02:16 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: This is what was changed in this task in one patch. Sergey Ivanovskiy
02:13 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: Hynek, please review rev 14867 (7824a) that removed @MAX_HTTP_IDLE_TIMEOUT@ and added @CONNECTION_TIMEOUT@ and @INFIN... Sergey Ivanovskiy

12/07/2023

03:01 PM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: Is there any documentation about the connection settings (the full set, not just the ones changed here)?
Hynek: Pl... Greg Shah
12:25 PM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: Could this task be reviewed? I rebased 7824a. Sergey Ivanovskiy
10:42 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Greg Shah wrote:
> Eric: Is @org.apache.commons.lang3.tuple.*@ a supported/approved library for use in persistence? ... Eric Faulhaber
10:06 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: > I've been obedient adding the overloaded method with the logical name, but where is the java @SsoAuthenticator@ get... Greg Shah
09:55 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: I've been obedient adding the overloaded method with the logical name, but where is the java @SsoAuthenticator@ getti... Galya B
09:51 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: We're doing a default authentication for SSO login, where the customer should not know anything about the details, bu... Galya B
09:50 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Greg Shah wrote:
> Supplement to the code review: the @ldbname@ parameter must be processed case insensitively (e.g.... Galya B
09:45 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Supplement to the code review: the @ldbname@ parameter must be processed case insensitively (e.g. storing/retrieving ... Greg Shah
09:20 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: >
> > Anyway, the directory database cfgs are there for runtime usage. Any usage from import is a side usage.
> >... Greg Shah
09:17 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Greg Shah wrote:
> > > I thought I had answered this in #7884-25. We are reworking the code DB logic into sessionle... Galya B
09:15 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: > Such reader will need to learn to read the names of the classes and the javadoc, where it says:
My comment stand... Greg Shah
09:10 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Greg Shah wrote:
> > > 2. The logic in @connectToDb()@ which reads configuration from the directory is also somethin... Galya B
09:01 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Greg Shah wrote:
> Galya B wrote:
> > Greg Shah wrote:
> > > > 4. There is nothing hidden. The connection is clean... Galya B
09:00 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Galya B wrote:
> Greg Shah wrote:
> > > 4. There is nothing hidden. The connection is cleaned up on JVM shutdown.
... Greg Shah
08:58 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: > > I thought I had answered this in #7884-25. We are reworking the code DB logic into sessionless code that is in F... Greg Shah
08:55 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: > 2. Is it better to create a DB connection on each login attempt in a live system?
This was a retorical question. Galya B
08:54 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Greg Shah wrote:
> > 4. There is nothing hidden. The connection is cleaned up on JVM shutdown.
>
> I mean it is a... Galya B
08:52 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: > 1. It's expected to be only one connection.
Per database instance. This may be many connections to a given clus... Greg Shah
08:50 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Greg Shah wrote:
> I thought I had answered this in #7884-25. We are reworking the code DB logic into sessionless c... Galya B
08:49 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: > > 2. The logic in @connectToDb()@ which reads configuration from the directory is also something that should not be... Greg Shah
08:40 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Galya B wrote:
> Greg Shah wrote:
> > Code Review Task Branch 7884a Revision 14843
> >
> > 1. I think the logic ... Greg Shah
08:24 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Greg Shah wrote:
> 3. I don't think it is a good idea to implement long lived connections to the database here, nor ... Galya B
08:18 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Greg Shah wrote:
> 2. The logic in @connectToDb()@ which reads configuration from the directory is also something th... Galya B
08:15 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Greg Shah wrote:
> Code Review Task Branch 7884a Revision 14843
>
> 1. I think the logic for obtaining the defaul... Galya B
07:27 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Code Review Task Branch 7884a Revision 14843
1. I think the logic for obtaining the default database name (@Databa... Greg Shah
07:21 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Eric: Is @org.apache.commons.lang3.tuple.*@ a supported/approved library for use in persistence? I see it used there... Greg Shah
07:06 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: r14843: @setuserid(userid, password, ldbname)@. Galya B
06:45 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: It will optionally be present in the original 4GL code. There are 2 forms:
* @setuserid(userid, password)@
* @se... Greg Shah
02:26 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Greg Shah wrote:
> My primary concern is that we don't support the @ldbname@ parameter variant of @setuserid()@. I ... Galya B
02:22 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Ovidiu Maxiniuc wrote:
> For the second part. Provided the @ldbname@, the database configuration from registry can b... Galya B
09:23 PM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: I reviewed the changes in 7884a.
I am OK with the changes. My concerns were for:
* duplicate code;
* hardcoded t... Ovidiu Maxiniuc
02:19 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions: Eugenie Lyzenko wrote:
> In general I have no objections.
>
> But I have the question and the clear answer is ver... Galya B

12/06/2023

04:20 PM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Code Review Task Branch 7884a Revisions 14840 through 14842
The overall approach is reasonable. Ovidiu and Eric w... Greg Shah
07:31 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: 7884a r14842 ready for review. The dialect and conversion specifics now shared between @MetadataSecurityOps.NoSession... Galya B
05:23 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Galya, yes, @SQL_MODE_DEFAULT@ is the default if otherwise not specified in p2j.cfg.xml, as a @conversion="minimal"@ ... Constantin Asofiei
03:40 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Galya B wrote:
> Is the "conversion" always @SQL_MODE_DEFAULT@. I don't see a case where @NsConfig.setConversion@ is... Galya B
03:33 PM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions: In general I have no objections.
But I have the question and the clear answer is very important. How the custom th... Eugenie Lyzenko
12:56 PM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions: Eugenie/Hynek: Please review. Greg Shah

12/05/2023

11:58 AM Bug #8098: The task bar without tasks is not displayed or drawn if ui program displays a lonely d...: The task bar is not displayed for this program... Sergey Ivanovskiy
09:29 AM Bug #8098 (New): The task bar without tasks is not displayed or drawn if ui program displays a lo...: Sergey Ivanovskiy
07:37 AM Bug #8074 (Review): Preferred UI Theme not selected in web with auto-login and forked sessions: 8074a based on trunk r14859 ready for review. Includes (in order of appearance):
* Theme options include an empty op... Galya B
04:38 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions: A note: The path in @FallbackEnvironmentReader@ when using @Preferences@ is composed from root user node @~/.java/.us... Galya B
02:17 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions: Greg Shah wrote:
> > But java @Preferences@ is case-sensitive, so we can either keep the original names (envs / keys... Galya B

12/04/2023

01:38 PM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions: > But java @Preferences@ is case-sensitive, so we can either keep the original names (envs / keys / sections), or mak... Greg Shah
12:01 PM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions: @EnvironmentDaemon@ is almost case-insensitive (check occurrences of @.toLowerCase()@). I guess it started with the r... Galya B
08:54 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions: Eugenie Lyzenko wrote:
> Greg Shah wrote:
> > > Also there is a problem in registry where the @base_name@ is actual... Galya B
08:43 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions: Greg Shah wrote:
> > Also there is a problem in registry where the @base_name@ is actually not used in the native co... Eugenie Lyzenko
08:26 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions: Greg Shah wrote:
> Galya B wrote:
> > Actually there is another conversion issue with the example.
> >
> > It ha... Galya B
08:20 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions: > Also there is a problem in registry where the @base_name@ is actually not used in the native code. The char is load... Greg Shah
08:18 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions: Galya B wrote:
> Actually there is another conversion issue with the example.
>
> It has @PUT-KEY-VALUE SECTION "... Greg Shah
07:45 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions: Also there is a problem in registry where the @base_name@ is actually not used in the native code. The char is loaded... Galya B
07:30 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions: Actually there is another conversion issue with the example.
It has @PUT-KEY-VALUE SECTION "PSC\Clue\TEMP-PRGM" KE... Galya B
06:27 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions: I'm trying to convert an example procedure from "here":https://community.progress.com/s/article/21529.
Edited: Co... Galya B
02:52 AM Feature #4203 (Test): expose some web-client details as 4GL global variables: 4203a was merged to trunk as rev. 14856 and archived. Galya B

12/03/2023

09:39 AM Bug #8095: LEAVE trigger fires in no focus change situation: In the following code, a @FILL-IN@ is created in its own frame, and three @ON LEAVE@ triggers are attached to the @FI... Vladimir Tsichevski
08:07 AM Bug #8095 (New): LEAVE trigger fires in no focus change situation: Vladimir Tsichevski

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » User Interface

Activity

Activity

01/01/2024

12/22/2023

12/21/2023

12/20/2023

12/18/2023

12/14/2023

12/11/2023

12/08/2023

12/07/2023

12/06/2023

12/05/2023

12/04/2023

12/03/2023