Activity
From 12/07/2023 to 01/05/2024
01/05/2024
- 08:05 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Galya B wrote:
> Ovidiu Maxiniuc wrote:
> > At any rate, I think @Pair@ and @StringUtils@ are the only class from t... - 02:42 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Ovidiu Maxiniuc wrote:
> At any rate, I think @Pair@ and @StringUtils@ are the only class from that package/library ... - 02:39 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- We've started discussing how to access the DB configs in #7572-134 and I mentioned an issue noone paid attention to, ...
01/04/2024
- 03:56 PM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- I had a look over 7884a/14843. I see it already uses some of the ideas I wrote above. I have only a few notes:
* I... - 03:27 PM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Eric Faulhaber wrote:
> Greg Shah wrote:
> > Eric: Is @org.apache.commons.lang3.tuple.*@ a supported/approved libra... - 03:01 PM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- In #7884-32 Galya B wrote:
> Ovidiu Maxiniuc wrote:
> > For the second part. Provided the @ldbname@, the database c... - 08:46 AM Bug #8074 (Closed): Preferred UI Theme not selected in web with auto-login and forked sessions
- 08:42 AM Bug #8074 (Test): Preferred UI Theme not selected in web with auto-login and forked sessions
- 8074a was merged to trunk as rev. 14911 and archived.
- 08:30 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- It can be merged to trunk now.
- 07:52 AM Bug #8074 (Merge Pending): Preferred UI Theme not selected in web with auto-login and forked sess...
- Galya B wrote:
> It's been tested before the review and now I've tested the newly introduced changes - @UserPreferen... - 07:18 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- It's been tested before the review and now I've tested the newly introduced changes - @UserPreferences@ needed some m...
- 03:45 AM Bug #8074 (Internal Test): Preferred UI Theme not selected in web with auto-login and forked sess...
- Code review 8074a revisions 14865 and 14866. The changes are good, I have no more concerns. Do you plan any more test...
- 02:20 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- r14866 Theme without value in directory to use class name in the dropdown
- 02:09 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- Hynek Cihlar wrote:
> Galya B wrote:
> > Hynek Cihlar wrote:
> > > Code review 8074a.
> > >
> > > @WebDriverHan...
01/03/2024
- 12:10 PM Bug #7515: FILL-IN: editing dates issues
- Another minor issue:
OE: when the cursor points to a delimiter, and the user inputs the *same* delimiter character... - 11:25 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- Galya B wrote:
> Hynek Cihlar wrote:
> > Code review 8074a.
> >
> > @WebDriverHandler.getAvailableThemes@ should...
01/01/2024
- 03:57 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- Hynek Cihlar wrote:
> Code review 8074a.
>
> @WebDriverHandler.getAvailableThemes@ should somehow handle a theme ...
12/22/2023
- 12:09 PM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- Code review 8074a.
@WebDriverHandler.getAvailableThemes@ should somehow handle a theme with empty name in the dire...
12/21/2023
- 11:36 AM Bug #7824 (Test): Simplify idle connection settings and apply the default configuration for the w...
- 11:33 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- 7824a has been rebased, merged into the trunc as rev 14893 and archived.
- 11:21 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- Planning to merge within next 15 minutes after rebase.
- 10:00 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- This can merge after 7889a.
- 09:46 AM Bug #7824 (Merge Pending): Simplify idle connection settings and apply the default configuration ...
- Code review 7824a revision 14897. The changes are good, I have no more objections.
- 04:00 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- 7824a has been rebased. It seems that it can be merged into the trunc. Are there any objections?
12/20/2023
- 01:21 PM Bug #7794: FILL-IN: editing numbers issues
- h2. Known issues compiled
This entry contains all know sub-issues, and will be edited as new sub-issues emerge and... - 12:50 PM Bug #7794: FILL-IN: editing numbers issues
- Greg Shah wrote:
> I am remembering that some layout modes (@COLON-ALIGNED@?, @SIDE-LABELS@?) might change the align...
12/18/2023
- 11:40 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- Please review rev 14889 (7824a) that fixed refs: #7824-17 and #7824-27.
12/14/2023
- 02:13 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Waiting for feedback from Eric and Ovidiu #7884-32, #7884-42 and #7884-44.
12/11/2023
- 11:30 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- Sergey Ivanovskiy wrote:
> Please review the committed revision 14868 (7824a).
Code review.
According to the j... - 06:34 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > We can change the code of @WebClientsManager@ for the case when ...
12/08/2023
- 09:49 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- Sergey Ivanovskiy wrote:
> We can change the code of @WebClientsManager@ for the case when agent range is not config... - 09:47 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- Sergey Ivanovskiy wrote:
> At this moment the debug mode is not enabled if the agent range is not configured. For th... - 08:43 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- Sergey Ivanovskiy wrote:
> These web client settings (under @webClient@ node)
> [...]
> are set automatically for... - 07:22 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- We can change the code of @WebClientsManager@ for the case when agent range is not configured but the @jvmArgs@ is gi...
- 07:10 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- The agent range is common for the debugger and jmx agents so jvmArgs just describes jmx and/or debug agents should be...
- 07:06 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- At this moment the debug mode is not enabled if the agent range is not configured. For the known application there ar...
- 06:48 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- Sergey Ivanovskiy wrote:
> The agent port is assigned by @WebClientManager@ that reads @jvmArgs@ option in the direc... - 06:31 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- Hynek Cihlar wrote:
> Code review 7824a revisions 14862..14867.
>
> I may be misinterpreting the changes, but I d... - 05:05 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- Hynek Cihlar wrote:
> Code review 7824a revisions 14862..14867.
>
> I may be misinterpreting the changes, but I d... - 05:04 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- Code review 7824a revisions 14862..14867.
I may be misinterpreting the changes, but I don't see how the debug mode... - 02:46 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- These web client settings (under @webClient@ node) ...
- 02:16 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- This is what was changed in this task in one patch.
- 02:13 AM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- Hynek, please review rev 14867 (7824a) that removed @MAX_HTTP_IDLE_TIMEOUT@ and added @CONNECTION_TIMEOUT@ and @INFIN...
12/07/2023
- 03:01 PM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- Is there any documentation about the connection settings (the full set, not just the ones changed here)?
Hynek: Pl... - 12:25 PM Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- Could this task be reviewed? I rebased 7824a.
- 10:42 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Greg Shah wrote:
> Eric: Is @org.apache.commons.lang3.tuple.*@ a supported/approved library for use in persistence? ... - 10:06 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- > I've been obedient adding the overloaded method with the logical name, but where is the java @SsoAuthenticator@ get...
- 09:55 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- I've been obedient adding the overloaded method with the logical name, but where is the java @SsoAuthenticator@ getti...
- 09:51 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- We're doing a default authentication for SSO login, where the customer should not know anything about the details, bu...
- 09:50 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Greg Shah wrote:
> Supplement to the code review: the @ldbname@ parameter must be processed case insensitively (e.g.... - 09:45 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Supplement to the code review: the @ldbname@ parameter must be processed case insensitively (e.g. storing/retrieving ...
- 09:20 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- >
> > Anyway, the directory database cfgs are there for runtime usage. Any usage from import is a side usage.
> >... - 09:17 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Greg Shah wrote:
> > > I thought I had answered this in #7884-25. We are reworking the code DB logic into sessionle... - 09:15 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- > Such reader will need to learn to read the names of the classes and the javadoc, where it says:
My comment stand... - 09:10 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Greg Shah wrote:
> > > 2. The logic in @connectToDb()@ which reads configuration from the directory is also somethin... - 09:01 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Greg Shah wrote:
> Galya B wrote:
> > Greg Shah wrote:
> > > > 4. There is nothing hidden. The connection is clean... - 09:00 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Galya B wrote:
> Greg Shah wrote:
> > > 4. There is nothing hidden. The connection is cleaned up on JVM shutdown.
... - 08:58 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- > > I thought I had answered this in #7884-25. We are reworking the code DB logic into sessionless code that is in F...
- 08:55 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- > 2. Is it better to create a DB connection on each login attempt in a live system?
This was a retorical question. - 08:54 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Greg Shah wrote:
> > 4. There is nothing hidden. The connection is cleaned up on JVM shutdown.
>
> I mean it is a... - 08:52 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- > 1. It's expected to be only one connection.
Per database instance. This may be many connections to a given clus... - 08:50 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Greg Shah wrote:
> I thought I had answered this in #7884-25. We are reworking the code DB logic into sessionless c... - 08:49 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- > > 2. The logic in @connectToDb()@ which reads configuration from the directory is also something that should not be...
- 08:40 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Galya B wrote:
> Greg Shah wrote:
> > Code Review Task Branch 7884a Revision 14843
> >
> > 1. I think the logic ... - 08:24 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Greg Shah wrote:
> 3. I don't think it is a good idea to implement long lived connections to the database here, nor ... - 08:18 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Greg Shah wrote:
> 2. The logic in @connectToDb()@ which reads configuration from the directory is also something th... - 08:15 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Greg Shah wrote:
> Code Review Task Branch 7884a Revision 14843
>
> 1. I think the logic for obtaining the defaul... - 07:27 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Code Review Task Branch 7884a Revision 14843
1. I think the logic for obtaining the default database name (@Databa... - 07:21 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Eric: Is @org.apache.commons.lang3.tuple.*@ a supported/approved library for use in persistence? I see it used there...
- 07:06 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- r14843: @setuserid(userid, password, ldbname)@.
- 06:45 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- It will optionally be present in the original 4GL code. There are 2 forms:
* @setuserid(userid, password)@
* @se... - 02:26 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Greg Shah wrote:
> My primary concern is that we don't support the @ldbname@ parameter variant of @setuserid()@. I ... - 02:22 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Ovidiu Maxiniuc wrote:
> For the second part. Provided the @ldbname@, the database configuration from registry can b... - 02:19 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- Eugenie Lyzenko wrote:
> In general I have no objections.
>
> But I have the question and the clear answer is ver...
Also available in: Atom